[Koha-bugs] [Bug 23971] Add logging for basket related actions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

--- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #11)

> I am sorry... but I'd like to at least try to explain my point of view a bit
> more. This bug states to add logging for basket related actions and of all
> the basket related actions one is missing. I don't feel this is out of scope
> at all. I've thought about why this is bothering me so much. I think it
> comes down to this: One of the biggest challenges we face is to develop Koha
> to be consistent and intuitive, to work as one piece of software, for
> everyone using it. When I have a feeling that something will cause question
> marks, and have me say: 'I know that doesn't make sense' to a library later,
> I feel I have to point it out.

Hi Katrin

Thanks for your comments :) Firstly, I *completely* understand what you're
saying and agree with everything. The challenge I face is that we have very
specific requirements from the customer who is sponsoring this work and the
patches that I have created address those requirements. So my comment about
additional logging being out of scope meant that it was out of scope of those
requirements. You're right, it is not out of scope of basket logging.

There are many actions that can be performed on a basket, Séverine highlighted
this by pointing out that logging did not occur when a basket manager is
changed. Our requirement was to add logging of basket modification in the
context of modifying the basket contents. Ideally, this bug would log every
possible action on a basket, but that would significantly increase development
time. I feel that this work is a foundation which will facilitate the addition
of further logging.

That said, I am about to create a patch to add basket reopening and basket
header modification logging since those were specifically mentioned by yourself
and Séverine.

It's also worth me pointing out that I am about to embark on a further Acq
logging development that is being sponsored by another customer, this will add
substantial logging to other areas of Acq and will hopefully partly address
some of your concerns.

-- 
You are receiving this mail because:
You are watching all bug changes.