[Koha-bugs] [Bug 21685] Name our exceptions consistently

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 13 10:26:53 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21685

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Agreed it would be nice to build a consistent pattern and add a guideline to
help work towards that... we also don't always subclass and so exceptions are
hard to find sometimes which I think is what leads to the nearly duplicate ones
you have discovered.

I'd even go so far as to ask the question of whether it's worth us starting to
take on a more consistent approach with our objects in general.. We already
actually have Moo as a dependency, we could start using some of its
recommendations today if we wanted to for type checking etc.  We're also doing
a poor mans version of method signatures in a few cases now.. perhaps we should
start advocating something there too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list