[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #26 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Jonathan Druart from comment #24)
> I do not understand the following change:
> 
> +++ b/Koha/Item.pm
> @@ -382,7 +382,7 @@ This method checks the tmp_holdsqueue to see if this
> item has been selected for
>  sub has_pending_hold {
>      my ( $self ) = @_;
>      my $pending_hold = $self->_result->tmp_holdsqueues;
> -    return !C4::Context->preference('AllowItemsOnHoldCheckout') &&
> $pending_hold->count ? 1: 0;
> +    return $pending_hold->count ? 1: 0;
>  }
> 
> 
> I also do not understand what it meant originally.

This was explained in more detail in the comment number 3. I'm switching this
back to Signed Off, OK?

-- 
You are receiving this mail because:
You are watching all bug changes.