[Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 96355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96355&action=edit
Bug 14419: [19.05.x] (squashed) Expanding facets (Show more) performs a new
search

This patch removes the constraint of only passing 5 facets to the template
unless the list is expanded, in fact, it removes the 'expanded' attribute from
Search.pm
Now that all facets are passed to page it adds a 'show more' link at the bottom
of lists and allows user to expand or collapse any facet set without reloading
page.

Updated tests included.

To test:
1  - Perform an OPAC search that returns more than 5 of any given facet type
2  - Click the "Show more" link on the facets and see that the search is
reloaded
3  - Apply patch
4  - Repeat search
5  - Note that you can click "Show more" without reloading page
6  - Test that page load is not greatly affected
7  - Ensure that all facet links function normally
8  - Ensure that facets are the same a prior to patch
9  - Repeat for staff client
10 - Prove t/Search.t

NOTE: This patch makes it much easier to see that there is an existing issue
with marking the "active" facet.  Ending punctuation seems to confuse the
matcher.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Bug 14419: (QA follow-up) Restore the link styling

Test plan:
Look at Show more/less links in facets, in opac and staff client
--> without this patch they are pure text, no styling, no hand cursor
--> with this patch it is link, but continues to work as before

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.