[Koha-bugs] [Bug 13897] Use XML files for installer data

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #25 from David Cook <dcook at prosentient.com.au> ---
That looks a lot nicer!

Since you're going with this approach, perhaps it would be worth turning off
AutoCommit, running the INSERTs, and then COMMITing? According to the MySQL
documentation, that should be higher performance. Probably easier to handle
exceptions that way too.

I wonder if we should add more error-handling in the eval{} block as well. I
suppose any errors will be caught during $loadyaml->execute(), so maybe that's
unnecessary. (Due to my nitpicker nature, I'd suggest $loadyaml be $load_sth
instead, but that's really just nitpicking, so feel free to ignore it.)

+1 Bernardo

-- 
You are receiving this mail because:
You are watching all bug changes.