[Koha-bugs] [Bug 13897] Use YAML files for installer data

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Jonathan,
thanks to change Bug description, planned to do it today :)

(In reply to Jonathan Druart from comment #26)
> I am all good with it, we could improve (performance) later (like one INSERT
> per file) if needed.

Ok

> Another improvement would be to move the .txt file into the YAML.

I thought about that too, which would allow it to be translated as well.
I will add the content in a description field.

> I would like to see the translator tool ready before we push this one. Did
> you investigate already the work that needs to be done?

Yes... for xml :)
I will work on this in Bug 24262

> I think we should move the already translated strings into a new .po (one
> .po for all installer files?)

I agree, perhaps 'xx-YY-installer.po' for common files, and append marcflavor
content for MARC21/UNIMARC/NORMARC to existing files, or add new ones.


> I can have a look if you did not already, but prefer to avoid duplication of
> work :)

Thanks! I'll try to solve this and let you know.

Now some questions:

1) Bug 22824 - This patch can work indistinctly with YAML, YAML::Syck or
YAML::XS, no problem with that.

2) YAML format:
I'm using
---
table:
  translatable: { A: 1 }
  rows:
    - A: 1
      B: 2

    - A: 3
      B: 4

With this format we have only one table per file, and all rows must have the
same number of values ( required by prepare($query) )

If we define things like
---
- firstTable:
    translatable: { A: 1 }
    rows:
      - A1: 1
        B1: 2

      - A2: 1
        B2: 2

- firstTable:
    translatable: { A: 1 }
    rows:
      - A: 1
        B: 2
        C: 3

      - A: 4
        B: 5
        C: 6

- secondTable:
    translatable: { G: 1 }
    rows:
      - F: 1
        G: 2

      - F: 3
        G: 4

we can have entries for the same table with different number of values, and
also entries for different tables inserted in order.
(BTW, of current installer sql files: 30 just one table, 9 more than one table;
common+en files )

A change in format needs a simple revision of the code, but I would like some
opinions about the format.

-- 
You are receiving this mail because:
You are watching all bug changes.