[Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun
                   |ommunity.org                |ity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Maybe that should be moved one line above, but I am not sure how to test that
correctly actually.

diff --git a/misc/sip_cli_emulator.pl b/misc/sip_cli_emulator.pl
index 1b987279b5..f28c067674 100755
--- a/misc/sip_cli_emulator.pl
+++ b/misc/sip_cli_emulator.pl
@@ -319,8 +319,8 @@ sub build_command_message {

     foreach my $key ( keys %$parameters ) {
         unless ( $parameters->{$key} ) {
+            $key =~ s|_|-|g; # options of this script have hyphens
             unless ( $optional{$key} ) {
-                $key =~ s|_|-|g; # options of this script have hyphens
                 say "$key is required for $message";
                 return;
             }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.