[Koha-bugs] [Bug 23112] Circulation of ILL items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 95566
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95566
Bug 23112: Add circulation to ILL requests

Review of attachment 95566:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23112&attachment=95566)
-----------------------------------------------------------------

Also, I think you should use patron-title.inc to display patron's info.

::: Koha/Illrequest.pm
@@ +1211,5 @@
> +        # For some reason, AddIssue requires an unblessed Patron
> +        $issue_args[0] = $patron->unblessed;
> +        my $issue = C4::Circulation::AddIssue(@issue_args);
> +
> +        if ($issue && %{$issue}) {

AddIssue return a Koha::Checkout object. The test will work but I think it's
confusing.

::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ +704,4 @@
>      </script>
>      [% INCLUDE 'ill-list-table-strings.inc' %]
>      [% Asset.js("js/ill-list-table.js") | $raw %]
> +    [% Asset.js("js/ill-check-out.js") | $raw %]

Where does this file come from?

-- 
You are receiving this mail because:
You are watching all bug changes.