From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 00:05:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jan 2019 23:05:02 +0000 Subject: [Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 01:39:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 00:39:59 +0000 Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be renamed 'schema' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155 --- Comment #12 from David Cook --- (In reply to Nick Clemens from comment #11) > Awesome work all! > > Pushed to master for 19.05 Nick is a champion :3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:47:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 09:47:37 +0000 Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #14 from Ray Delahunty --- We have 6 college libraries and had recently noticed what appeared to be one library "stealing" another's stock. We now know of course that the problem is down to this bug. We have a report to identify the problem records (Report Note read "Item's home library not equal to item's holding library, AND item is not on loan AND item is not in transit, AND item type not REVIEW and neither the home or holding branch is [central processing] AND Item is not marked as lost"). It may not be the prettiest of SQL but it did identify 150 problem records. Cleaning these up is proving tedious, requiring a lot of shelf checking and inter-site communication. We were alerted to this problem following a complaint from a student when a reservation / hold on one of the problem records went wrong... It would be great to have a fix. In the meantime we have reviewed workflows (so some staff training) and are considering hiding circulation actions within the Patron Detail, via jQuery. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 09:53:09 +0000 Subject: [Koha-bugs] [Bug 22254] New: t/db_dependent/Koha/Patrons.t contains a DateTime math error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Bug ID: 22254 Summary: t/db_dependent/Koha/Patrons.t contains a DateTime math error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- So, one of the peculiarities of DateTime maths is that 12 plus 1 doesn't always equal 13 ;) This calls for an example (using 'limit' for end_of_month mode): 2019-01-31 + 1 month = 2019-02-28 2019-01-31 + 13 months = 2020-02-29 (this one maintains 'end of month' over the leap year) 2019-02-28 + 12 months = 2020-02-28 Koha does the third case but the test is currently setup for the second. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:57:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 09:57:43 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 09:57:29 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 --- Comment #1 from Martin Renvoize --- Created attachment 84599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84599&action=edit Bug 22254: Correction to datehandling in test Adding 13 months is not always the same as adding 1 month and then adding 12 months in DateTime maths. This patch rectified the test to match the correct behaviour in koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 10:58:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 09:58:10 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:01:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 10:01:00 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 --- Comment #2 from Martin Renvoize --- Test plan. 1) Modify the test (around line 268) to test against the suspect leap date of 2019-01-31 and watch the test fail. 2) Apply the patch (which also adds this modification to test for such a leap date) and watch the test now pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:43:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 10:43:54 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 10:43:58 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84599|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 84600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84600&action=edit Bug 22254: Correction to datehandling in test Adding 13 months is not always the same as adding 1 month and then adding 12 months in DateTime maths. This patch rectified the test to match the correct behaviour in koha. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:45:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 10:45:12 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|chris at bigballofwax.co.nz |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 11:45:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 10:45:21 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:01:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:01:55 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:01:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:01:59 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:04 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:09 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:12 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:15 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81020|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:18 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:37 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #41 from Tom?s Cohen Arazi --- Created attachment 84601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84601&action=edit Bug 21610: Add tests Adding few tests to Koha/Object.t in order to highlight what we are trying to fix. Note that Koha::ItemType->store was wrong for notforloan, the default value should be null `notforloan` smallint(6) DEFAULT NULL, but the previous fix (bug 21599) made it default to '0' Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:45 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #42 from Tom?s Cohen Arazi --- Created attachment 84602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84602&action=edit Bug 21610: Remove specific changes we made previously We handled integers and dates for Koha::Patron and Koha::ItemType, we want now Koha::Object to deal with. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:50 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #43 from Tom?s Cohen Arazi --- Created attachment 84603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84603&action=edit Bug 21610: Fix integers and dates values at Koha::Object->store level With strict SQL modes, we are facing several issues when objects are stored. The following errors can be raised by DBIx::Class when an object does not have a valid (as defined at DB level) value: - Incorrect integer value: '' for column COLUMN - Incorrect decimal value: '' for column COLUMN - Column 'COLUMN' cannot be null - Field 'COLUMN' doesn't have a default value - Incorrect date value: '' for column 'COLUMN' We already handled some of them for Koha::Patron. As we do not want to provide such changes for all Koha::* modules we are going to fix this at Koha::Object->store level in order to provide a global fix. This is related to bug 21599 (for item types) and bug 21596 (for patrons) Test plan: - Apply first patch, run the tests => Patch fail because of the previous error in Koha::ItemType->store, to make them pass you can replace $self->notforloan(0) unless $self->notforloan; with $self->notforloan(undef) unless $self->notforloan; - Apply second patch, run the tests => They fail because of dates and/or integers values - Apply third patch, run the tests => They now pass Deep code review wanted! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:02:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:02:54 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #44 from Tom?s Cohen Arazi --- Created attachment 84604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84604&action=edit Bug 21610: (QA follow-up) Better use columns_info from DBIx We should better use the published method than a private hash key. And shorter to go via _result than adding a new schema call. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:03:00 +0000 Subject: [Koha-bugs] [Bug 20424] Zebra - Updating default Unimarc biblio mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20434 CC| |claire.hernandez at biblibre.c | |om Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 [Bug 20434] Updating Unimarc existing frameworks with IFLA updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:03:00 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #45 from Tom?s Cohen Arazi --- Created attachment 84605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84605&action=edit Bug 21610: (follow-up) Default value for dates We have some dates with DEFAULT CURRENT_TIMESTAMP and some dates with default and UPDATE clause. Test plan: Run Object.t again. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:03:00 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 [Bug 20424] Zebra - Updating default Unimarc biblio mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:03:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:03:04 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #46 from Tom?s Cohen Arazi --- Created attachment 84606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84606&action=edit Bug 21610: Improve default values for dates This patch fixes failures on t/db_dependent/Koha/Patrons/Import.t and keep t/Auth_with_shibboleth.t and t/db_dependent/Koha/Object.t green Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:03:27 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 [Bug 20424] Zebra - Updating default Unimarc biblio mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:03:27 +0000 Subject: [Koha-bugs] [Bug 20424] Zebra - Updating default Unimarc biblio mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 [Bug 18309] UNIMARC update from IFLA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:25:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:25:13 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:25:16 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 --- Comment #1 from Ere Maijala --- Created attachment 84607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84607&action=edit Bug 22246: Fix indexing of large fields with Elasticsearch Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense. Also fixes mapping for llevel while at it. Test plan: 1. Reset ES mappings in administration 2. Check that sort is '0' for local-classification in biblio mappings. 3. Change sort back to '1' for local-classification for the next steps. 4. Create a record with 20 items, each with a 100 character long call number 5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:29:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:29:52 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:30:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:30:43 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:34:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:34:26 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #3 from Tom?s Cohen Arazi --- I agree we should either remove it from AUTOLOAD or write our own as a wrapper on top of the class's ->store. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:36:14 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #6) > > I think we need to consider the backdated returns use case, and have another > offset for those, as fine_increment doesn't look right. What I meant here is that FU (Fine Update) should be splitted into 'fine_increment' and 'fine_decrement'. Not all 'fine_increment'. And in the case of backdated returns/dropbox mode we could pass a specific offset_type to ->adjust. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:38:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:38:48 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84607|0 |1 is obsolete| | --- Comment #2 from Ere Maijala --- Created attachment 84608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84608&action=edit Bug 22246: Fix indexing of large fields with Elasticsearch Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense. Test plan: 1. Reset ES mappings in administration 2. Check that sort is '0' for local-classification in biblio mappings. 3. Change sort back to '1' for local-classification for the next steps. 4. Create a record with 20 items, each with a 100 character long call number 5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:52:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:52:43 +0000 Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:52:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:52:43 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Bug 14591 depends on bug 22049, which changed state. Bug 22049 Summary: MarkIssueReturned should rely on returndate only https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:53:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:53:40 +0000 Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" - addorderiso2709.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:54:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:54:32 +0000 Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 12:58:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 11:58:42 +0000 Subject: [Koha-bugs] [Bug 21877] Show authorized value description for withdrawn in checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:01:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:01:37 +0000 Subject: [Koha-bugs] [Bug 22255] New: Item Search csv export, missing fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22255 Bug ID: 22255 Summary: Item Search csv export, missing fields Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: joseanjos at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Using Vers. 18.11 On Search --> Item search, if output is "Screen" all the columns are OK If output is CSV several columns are empty like: Title Publication date Publisher Collection On version 17.11 it was working fine. You can test it on https://intranet-demo.biblibre.com Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:02:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:02:29 +0000 Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:05:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:05:14 +0000 Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering information on acqui/supplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:20:10 +0000 Subject: [Koha-bugs] [Bug 22256] New: lleader mapping wrong in default Elasticsearch mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Bug ID: 22256 Summary: lleader mapping wrong in default Elasticsearch mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi Target Milestone: --- lleader is set to come from positions 1-5 while it should be 0-4. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:20:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:20:24 +0000 Subject: [Koha-bugs] [Bug 22256] lleader mapping wrong in default Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:20:46 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:30:08 +0000 Subject: [Koha-bugs] [Bug 22207] Course reserves page does not have unique body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:30:34 +0000 Subject: [Koha-bugs] [Bug 21776] Set ACQ_NOTIF_ON_RECEIV notice message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21776 Bug 21776 depends on bug 21241, which changed state. Bug 21241 Summary: Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:30:34 +0000 Subject: [Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #23 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:30:34 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Bug 21781 depends on bug 21241, which changed state. Bug 21241 Summary: Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:31:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:31:19 +0000 Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:31:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:31:57 +0000 Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:33:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:33:06 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:36:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:36:39 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #25 from Martin Renvoize --- As this is an old and very stable API and this could be perceived as a breaking change I am not going to backport this one to 18.11.x series at this time.. please speak up if you disagree and would like it as I may be persuadable under my caveat of backporting API improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:37:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:37:14 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #42 from Martin Renvoize --- This will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:37:15 +0000 Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Bug 20600 depends on bug 20640, which changed state. Bug 20640 Summary: Allow migrating a request between backends https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:37:15 +0000 Subject: [Koha-bugs] [Bug 22103] ILL: Tests for migrate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22103 Bug 22103 depends on bug 20640, which changed state. Bug 20640 Summary: Allow migrating a request between backends https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:37:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:37:57 +0000 Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:38:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:38:33 +0000 Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:39:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:39:19 +0000 Subject: [Koha-bugs] [Bug 21913] Clean up payment details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #10 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:39:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:39:19 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21913, which changed state. Bug 21913 Summary: Clean up payment details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:39:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:39:51 +0000 Subject: [Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #5 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:40:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:40:17 +0000 Subject: [Koha-bugs] [Bug 20729] Update style of datepickers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:40:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:40:47 +0000 Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:40:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:40:48 +0000 Subject: [Koha-bugs] [Bug 22215] table_borrowers name is inconsistent with other tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22215 Bug 22215 depends on bug 17353, which changed state. Bug 17353 Summary: Add phone number column to checkout search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:41:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:41:27 +0000 Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry form to modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:42:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:42:20 +0000 Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated to have the new tab names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:42:56 +0000 Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated to have the new tab names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:58:17 +0000 Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A simple string patch that release notes| |clarifies the intention of | |the CheckPrevCheckout | |system preference options. CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 13:58:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 12:58:30 +0000 Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:00:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:00:51 +0000 Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:02:14 +0000 Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Google revealed that Google release notes| |Plus accounts will be shut | |down on April 2, 2019. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:03:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:03:26 +0000 Subject: [Koha-bugs] [Bug 21930] Typo in the manage_circ_rules_from_any_libraries description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:03:43 +0000 Subject: [Koha-bugs] [Bug 21930] Typo in the manage_circ_rules_from_any_libraries description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:04:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:04:32 +0000 Subject: [Koha-bugs] [Bug 22149] Grammar fix in the manage_circ_rules_from_any_libraries description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Severity|enhancement |minor --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:04:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:04:53 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #65 from David Gustafsson --- Unfortunately I have have been a little bit too busy lately to have a look at this, but hope will have the time to do so some time next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:07:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:07:05 +0000 Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:18:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:18:55 +0000 Subject: [Koha-bugs] [Bug 22256] lleader mapping wrong in default Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:18:58 +0000 Subject: [Koha-bugs] [Bug 22256] lleader mapping wrong in default Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 --- Comment #1 from Ere Maijala --- Created attachment 84609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84609&action=edit Bug 22256: Fix lleader mapping in Elasticsearch Test plan: 1. Reset mappings 2. Index records 3. Check that in Elasticsearch the correct length information is stored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:49:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:49:45 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #57 from Kyle M Hall --- Created attachment 84611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84611&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:49:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:49:48 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #58 from Kyle M Hall --- Created attachment 84612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84612&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:49:52 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #59 from Kyle M Hall --- Created attachment 84613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84613&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:49:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #60 from Kyle M Hall --- Created attachment 84614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84614&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:49:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:49:35 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84570|0 |1 is obsolete| | Attachment #84571|0 |1 is obsolete| | Attachment #84572|0 |1 is obsolete| | Attachment #84573|0 |1 is obsolete| | Attachment #84574|0 |1 is obsolete| | Attachment #84575|0 |1 is obsolete| | Attachment #84576|0 |1 is obsolete| | Attachment #84577|0 |1 is obsolete| | Attachment #84578|0 |1 is obsolete| | Attachment #84579|0 |1 is obsolete| | Attachment #84580|0 |1 is obsolete| | Attachment #84581|0 |1 is obsolete| | Attachment #84582|0 |1 is obsolete| | Attachment #84583|0 |1 is obsolete| | Attachment #84584|0 |1 is obsolete| | Attachment #84585|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall --- Created attachment 84610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84610&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:49:58 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #61 from Kyle M Hall --- Created attachment 84615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84615&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:02 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #62 from Kyle M Hall --- Created attachment 84616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84616&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:06 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #63 from Kyle M Hall --- Created attachment 84617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84617&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:10 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #64 from Kyle M Hall --- Created attachment 84618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84618&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:13 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #65 from Kyle M Hall --- Created attachment 84619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84619&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:17 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #66 from Kyle M Hall --- Created attachment 84620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84620&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:19 +0000 Subject: [Koha-bugs] [Bug 22257] New: Mana should prevent duplicate comments Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22257 Bug ID: 22257 Summary: Mana should prevent duplicate comments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 17047 Target Milestone: --- I think Mana should not let the same user submit multiple identical comments. At the very least Mana should ignore duplicate submissions (increments) of existing comments. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:19 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22257 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22257 [Bug 22257] Mana should prevent duplicate comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:21 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #67 from Kyle M Hall --- Created attachment 84621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84621&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:25 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #68 from Kyle M Hall --- Created attachment 84622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84622&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:29 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #69 from Kyle M Hall --- Created attachment 84623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84623&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:32 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #70 from Kyle M Hall --- Created attachment 84624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84624&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:50:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:50:36 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #71 from Kyle M Hall --- Created attachment 84625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84625&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:54:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:54:03 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:54:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:54:05 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84608|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 84626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84626&action=edit Bug 22246: Fix indexing of large fields with Elasticsearch Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense. Test plan: 1. Reset ES mappings in administration 2. Check that sort is '0' for local-classification in biblio mappings. 3. Change sort back to '1' for local-classification for the next steps. 4. Create a record with 20 items, each with a 100 character long call number 5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:56:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:56:02 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:56:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:56:05 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 --- Comment #1 from Owen Leonard --- Created attachment 84627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84627&action=edit Bug 22250: Clean up Mana KB integration with serials and reports This patch makes many changes to templates and JavaScript related to the integration of Mana with serials reports: - Many incorrect uses of the raw filter with html - Corrections to Bootstrap modal markup - Untranslatable strings moved out of JavaScript - Removed markup and JavaScript related to reports comments, a feature which doesn't exist in this version. New include file: mana/mana-comment-status.inc This file contains hidden-by-default messages which are shown during the process of submitting a comment on a subscription. New include file: mana/mana-share-report.inc This file contains the "Share report" modal markup formerly in guided_reports_start.tt New JavaScript file: mana.js Previously mana.inc, an include file containing only JavaScript which didn't include any template processing. Changed: mana/mana-report-search-result.inc This include file is now a full template so that jQuery's load() function can be used to pull its contents into the reports search modal. Changed: svc/mana/search This script was returning json-encoded HTML. Now it returns regular HTML. To test you must have Mana configured and enabled. Apply the patch and go to Reports -> Saved reports. - Choose New report -> New SQL from Mana. A "Mana search" modal should appear. - Perform a search which will return results, e.g. "circulation." - A "Loading" indicator should appear while the results are being retrieved. It should disappear when results appear. - Results should appear in the DataTable with sorting, paging, and search options. - In the "Notes" column, notes longer than 200 characters should be truncated with a "Show more" link. Clicking it should expand the comment and reveal a "Show less" link in its place. - Click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - When the import is complete you should be redirected to a view of your new report. Go to Serials and click the "Search on Mana" link in the sidebar. - Perform a search for a serial - Results should appear in a DataTable with sorting, paging, and search options. - Sorting by title should ignore articles "a," "an," and "the." Create a new subscription or edit an existing subscription which will match a record in Mana. - On the second step of adding/editing the subscription a message should appear at the top of the form, "Searching for subscription in Mana Knowledge Base," with a loading icon. - When searching has completed a "Show Mana results" link should appear. - Clicking the link should trigger a modal showing search results which match your subscription, displayed in a DataTable with sorting, paging, and search options. - The last column of the table should contain "Import" and "Report" buttons. - Clicking the "Report" button should trigger a menu. Any existing comments will be listed as well as a "New comment" item. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should redisplay the search results. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. - In the table of search results, click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - The modal should close and the data from Mana should be loaded into the subscription entry form. View the detail page of a subscription which has saved with Mana data. - There should be a "Report mistake" button in the toolbar. Clicking it should reveal a menu of comments like the one you saw previously. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form modal. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should hide the modal. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:57:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:57:27 +0000 Subject: [Koha-bugs] [Bug 22258] New: Elasticsearch - full record is not indexed in plain text Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Bug ID: 22258 Summary: Elasticsearch - full record is not indexed in plain text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Target Milestone: --- This is to start a discussion - at some point we dropped the inclusion of the full record in plain text in the ES index A consequence is that data in a field that is not specifically indexed is no longer searchable. This is a change from zebra I believe where the entire record can be searched. I am not sure of the affect on relevancy, but I think we need t o find a way to support full record searching. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:57:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:57:40 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 14:58:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 13:58:44 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com | |, m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nicolas.legrand at bulac.fr, | |severine.queune at bulac.fr, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:01:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:01:05 +0000 Subject: [Koha-bugs] [Bug 22259] New: If two catalogers work on same record, one overwrites the other Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 Bug ID: 22259 Summary: If two catalogers work on same record, one overwrites the other Change sponsored?: --- Product: Koha Version: 18.05 Hardware: Other OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: karin.hochschein at linklaters.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- If 2 librarians edit the same cataloguing record at the same time, the last one to save overwrites the work of the other. There is not way to block the catalogue record for other cataloguers in your library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:04:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:04:26 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:14:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:14:00 +0000 Subject: [Koha-bugs] [Bug 22260] New: Incorrect GROUP BY in spent and ordered pages in Acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22260 Bug ID: 22260 Summary: Incorrect GROUP BY in spent and ordered pages in Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To recreate: 1 - Have some budgets and orders 2 - Visit acqui/acqui-home.pl 3 - looks fine 4 - click on either the spent or ordered column for a fund 5 - Internal server error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:14:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:14:44 +0000 Subject: [Koha-bugs] [Bug 22260] Incorrect GROUP BY in spent and ordered pages in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22260 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:14:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:14:46 +0000 Subject: [Koha-bugs] [Bug 22260] Incorrect GROUP BY in spent and ordered pages in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22260 --- Comment #1 from Nick Clemens --- Created attachment 84628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84628&action=edit Bug 22260: Incorrect GROUP BY in spent and ordered pages in Acquisitions To test: 1 - Have some budgets and orders 2 - Visit acqui/acqui-home.pl 3 - looks fine 4 - click on either the spent or ordered column for a fund 5 - Internal server error 6 - Apply patch (restart all the things) 7 - Both links now work 8 - Verify totals are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:14:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:14:27 +0000 Subject: [Koha-bugs] [Bug 22260] Incorrect GROUP BY in spent and ordered pages in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22260 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:23:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:23:33 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Bug 11375 depends on bug 21964, which changed state. Bug 21964 Summary: Switch two-column templates to Bootstrap grid: Patrons part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:23:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:23:33 +0000 Subject: [Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported for the 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:23:34 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21964, which changed state. Bug 21964 Summary: Switch two-column templates to Bootstrap grid: Patrons part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:23:34 +0000 Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Bug 21751 depends on bug 21964, which changed state. Bug 21964 Summary: Switch two-column templates to Bootstrap grid: Patrons part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:23:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:23:35 +0000 Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to consolidate buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 --- Comment #7 from Owen Leonard --- Created attachment 84629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84629&action=edit Bug 22195: (follow-up) Add text labels to buttons if window is wide enough This patch adds responsive handling of text labels to the columns configuration and export buttons. To test, apply the patch and clear your browser cache if necessary. - View a page with column configuration, e.g. Administration -> Patron categories. - At wider browser widths the buttons should have text labels. - At narrower browser widths the labels should be hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:37:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:37:11 +0000 Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:38:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:38:42 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:40:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:40:37 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #10 from Martin Renvoize --- I changed my mind.. this is a worthwhile improvement to documentation early enough in the cycle that I think it can slide in.. Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:40:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:40:43 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:40:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:40:50 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:40:57 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:41:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:41:03 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:41:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:41:09 +0000 Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:42:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:42:16 +0000 Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- This cleanup isn't required for 18.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:43:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:43:24 +0000 Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement will not be backported to 18.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:43:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:43:25 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 22104, which changed state. Bug 22104 Summary: Clean up patron API keys template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:44:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:44:26 +0000 Subject: [Koha-bugs] [Bug 21945] Clean up stock rotation template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Renvoize --- Thanks for tidying this Owen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:44:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:44:26 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 21945, which changed state. Bug 21945 Summary: Clean up stock rotation template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:45:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:45:05 +0000 Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:47:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:47:39 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #18 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 22134] Add account expiration information to patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Martin Renvoize --- Enhancement, will not be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:52:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:52:11 +0000 Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because the syspref isn't referenced correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:53:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:53:36 +0000 Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not generate type parameter in script tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:54:17 +0000 Subject: [Koha-bugs] [Bug 22240] Add possibility to specify a category of patron in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240 --- Comment #2 from Patrick Robitaille --- Hello, In the case of school libraries, we have several types of users as an example: a library can have users such as students, teachers, employees, library staff, etc. However, when we close days in the calendar, it would be interesting to be able to select one or more types of users who are concerned by these closures. As in the example of winter vacations where teachers and staff go back to work faster than students and want to use the resources of the library, if we closed calendar dates until the start of the school session, this causes problems with the circulation of documents. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:54:29 +0000 Subject: [Koha-bugs] [Bug 15110] Improve decreaseHighHolds system preference description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 15:54:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 14:54:34 +0000 Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric in numeric eq (==) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:03:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:03:25 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #1 from Ere Maijala --- I'd suggest something like allowing wildcards in the index mappings so that you could index all the needed fields in the _all field using the index mappings. This would make it possible to e.g. concatenate the subfields for proper phrase searching. Additionally, there could be an option to index the MARC record so that it's easily searchable by field. I wouldn't make it the default since it can be sort of a really big hammer used on a really small nail, but having it as an option would give nice flexibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:04:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:04:11 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:05:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:05:31 +0000 Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |trivial CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:06:16 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #2 from Nicolas Legrand --- Hey Nick, thank you for working on ES! I think we have a better relevancy without having the whole notice indexed. I guess it produces also a smaller index volume too and maybe a faster indexation. It looks redundant too me to do otherwise. Like doing something super precisely very very neatly and in the same move throwing whatever you have in a big bucket. Some people wants it because they fear to lose something in the way. But, this may make noise like a cluster of thousands fuzz pedals with all knobs all the way up (OK maybe I'm a bit dramatic here :)). In the UNIMARC fields 4XX for example we have a lot of references. If the notice is the notice of an article, you'll get the name of the serial in some 4XX fields. Yup, typing the name of a serial may bring up all his minions and they will hide it in the tenth result page or something like that. So we have to be sure how to sort it. Ok, with weighting on the title index, the serial ends up on the top of the list, so maybe it is not that bad. I'm not eager for this one, if it has to be, I'll put a super low weight on the index entry to test it first. I'll also check the speed and the weight. Cheers! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:06:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:06:56 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:09:01 +0000 Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron attributes" default on patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #12 from Martin Renvoize --- A good enhancement, but it brings a change of functionality which could prove surprising to end users on the stable branch.. as such I will not be backporting this one to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:09:51 +0000 Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:15:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:15:38 +0000 Subject: [Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 [Bug 17006] Add route to change patron's password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:15:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:15:38 +0000 Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |22047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 [Bug 22047] set_password should have a 'skip_validation' param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:20:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:20:29 +0000 Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #77 from Martin Renvoize --- As is my policy on non-breaking api additions I have backported this to 18.11.x series for 18.11.03 release. I have also added the missing `Sponsored-by: Municipal Libray Ceska Trebova` lines so due appreciation is shown in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:23:22 +0000 Subject: [Koha-bugs] [Bug 22256] llength mapping wrong in default Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|lleader mapping wrong in |llength mapping wrong in |default Elasticsearch |default Elasticsearch |mappings |mappings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:24:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:24:32 +0000 Subject: [Koha-bugs] [Bug 22256] llength mapping wrong in default Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 --- Comment #2 from Ere Maijala --- Created attachment 84630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84630&action=edit Bug 22256: Fix llength mapping in Elasticsearch Test plan: 1. Reset mappings 2. Index records 3. Check that in Elasticsearch the correct length information is stored in llength -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:25:08 +0000 Subject: [Koha-bugs] [Bug 22061] Public route to change password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #27 from Martin Renvoize --- New feature, will not be backported at this time to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:25:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:25:09 +0000 Subject: [Koha-bugs] [Bug 22216] Make GET /patrons/{patron_id} staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216 Bug 22216 depends on bug 22061, which changed state. Bug 22061 Summary: Public route to change password https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:25:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:25:09 +0000 Subject: [Koha-bugs] [Bug 22227] Make GET /cities staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227 Bug 22227 depends on bug 22061, which changed state. Bug 22061 Summary: Public route to change password https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:28:45 +0000 Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:29:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:29:41 +0000 Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:31:27 +0000 Subject: [Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::build_sample_biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #43 from Martin Renvoize --- Enhancement, will not be backported at this time to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:31:27 +0000 Subject: [Koha-bugs] [Bug 21816] [OMNIBUS] Ease the write of our tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 Bug 21816 depends on bug 21798, which changed state. Bug 21798 Summary: We need t::lib::TestBuilder::build_sample_biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:31:27 +0000 Subject: [Koha-bugs] [Bug 21971] TestBuilder::build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Bug 21971 depends on bug 21798, which changed state. Bug 21798 Summary: We need t::lib::TestBuilder::build_sample_biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:32:10 +0000 Subject: [Koha-bugs] [Bug 21971] TestBuilder::build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement, will not be backported at this time to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:32:10 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Bug 21985 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:32:10 +0000 Subject: [Koha-bugs] [Bug 21816] [OMNIBUS] Ease the write of our tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 Bug 21816 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:33:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:33:02 +0000 Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical labels "Library:" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:33:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:33:36 +0000 Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be renamed 'schema' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement, will not be backported at this time to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:33:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:33:37 +0000 Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144 Bug 22144 depends on bug 22155, which changed state. Bug 22155 Summary: biblio_metadata.marcflavour should be renamed 'schema' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:35:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:35:24 +0000 Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #19 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:36:09 +0000 Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:36:09 +0000 Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144 Bug 22144 depends on bug 22194, which changed state. Bug 22194 Summary: Add Koha::Exceptions::Metadata https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:36:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:36:34 +0000 Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:37:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:37:22 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:37:24 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84595|0 |1 is obsolete| | Attachment #84596|0 |1 is obsolete| | Attachment #84597|0 |1 is obsolete| | Attachment #84598|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 84631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84631&action=edit Bug 21890: DB updates This patch adds a new column to the categories table: 'can_reset_password' which is a boolean, and represents, well... that. It also deletes the OpacResetPassword system preference, but first sets the OpacResetPassword value to all defined categories as it will be used in the same way. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:37:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:37:38 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #12 from Kyle M Hall --- Created attachment 84632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84632&action=edit Bug 21890: Add can_any_reset_password() to the Categories TT plugin This patch introduces a method to the Koha::Template::Plugin::Categories TT plugin. This methods queries for categories that have the can_reset_password flag set, and returns a boolean representing the fact that there's at least one category with the flag set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Categories.t => SUCCESS: Tests pass! - Sign off :-D Caveat: this patch/tests require the schema to be updated Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:37:40 +0000 Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- Enhancement, change of behaviour, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:37:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:37:41 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #13 from Kyle M Hall --- Created attachment 84633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84633&action=edit Bug 21890: Handle can_reset_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:37:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:37:44 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #14 from Kyle M Hall --- Created attachment 84634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84634&action=edit Bug 21890: Allow restricting password resets by patron category This patch makes the templates relying on the OpacResetPassword syspref use the introduced TT plugin method instead by changing: [% IF Koha.Preference('OpacResetPassword') %] => [% IF Categories.can_any_reset_password %] To test: - Verify that all the places in which the 'forgot password' link is displayed in OPAC keep working, provided there's at least one category that has the flag set - Attempt to recover the password for a patron that belong to a valid category (i.e. that has the flag set) => SUCCESS: You can go through the normal process - Attempt to recover the password for a patron that belongs to a category with the flag unset. => SUCCESS: Once Koha identifies your category, you are told you are not allowed to do it - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:38:14 +0000 Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs redirects to unexpected page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:38:39 +0000 Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap grid: Circulation part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:38:39 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21449, which changed state. Bug 21449 Summary: Switch two-column templates to Bootstrap grid: Circulation part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:39:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:39:04 +0000 Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:39:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:39:30 +0000 Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:41:02 +0000 Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #15 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:41:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:41:48 +0000 Subject: [Koha-bugs] [Bug 17854] New Print slip and close button next to Close button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:47:49 +0000 Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #28 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 as per my policy on API non-breaking change api enhancements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:48:14 +0000 Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 16:49:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 15:49:07 +0000 Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds http BASIC release notes| |authentication as an | |optional auth method to the | |RESTful api's. This | |greatly aids developers | |when developing against our | |api's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 16:22:35 +0000 Subject: [Koha-bugs] [Bug 22015] Move DataTables CSS to global include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22015 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:22:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 16:22:37 +0000 Subject: [Koha-bugs] [Bug 22015] Move DataTables CSS to global include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22015 --- Comment #1 from Owen Leonard --- Created attachment 84635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84635&action=edit Bug 22015: Move DataTables CSS to global include DataTables are used on enough pages in the staff client that it doesn't make sense to put inclusion of the CSS into each template where it is needed. This patch moves includes of datatables.css from individual templates into the global header file. To test, apply the patch and view various pages which have DataTables. View various styles of DataTables, e.g. - Full pagination, like item search results - Four-button, like Saved SQL reports Everything should look the same as it was. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:46:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 16:46:29 +0000 Subject: [Koha-bugs] [Bug 22261] New: Revise style of DataTables menus Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261 Bug ID: 22261 Summary: Revise style of DataTables menus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 22195 Target Milestone: --- Created attachment 84636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84636&action=edit Animated gif showing the proposed style update Prompted by the fact that I find the on/off state of columns configuration buttons ambiguous, I would like to change the style of DataTables menus. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 [Bug 22195] Change default DataTables configuration to consolidate buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 17:46:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 16:46:29 +0000 Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to consolidate buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261 [Bug 22261] Revise style of DataTables menus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:07:43 +0000 Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84421|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 84637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84637&action=edit Bug 22175: Make stock rotation table sortable This patch adds sorting and column configuration to the stock rotation tables, both rotas and items. No new defaults for the table are defined. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Stock rotation. - In the table of rotas test that sorting works correctly. - Test that the "Column visibility" button works to show and hide columns. The "actions" column should be excluded. - Test that export options (Excel, CSV, etc) exclude the "actions" column. - Choose a rota with multiple items on it and select manage -> items. Repeat the above DataTables functionality tests. - Go to Administration -> Columns settings and edit the default configuration of the stock rotation tables. Confirm that these changes are reflected in the corresponding tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:07:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:07:40 +0000 Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:12:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:12:54 +0000 Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:16:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:16:06 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:16:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:16:10 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84281|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 84638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84638&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:16:14 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #6 from Owen Leonard --- Created attachment 84639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84639&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:17:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:17:33 +0000 Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged as boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:37:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:37:09 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:37:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:37:12 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84594|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 84640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84640&action=edit Bug 22253: Check we actually need to update the password This patch makes memberentry.pl check if password needs to be updated before attempting to call set_password. Above this there's a check that won't raise any errors if no password is passed, or the default string (****) is received. So we could reach that line of code with no password, but the code wouldn't check that. To test: - In master, edit any patron without changing the password => FAIL: It raises an exception - Apply this patch - Edit the patron withtout changing the password => SUCCESS: Edit successful - Edit the patron, changing the password - Try to login with the new password => SUCCESS: The password got changed correctly - Sigh off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 18:59:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 17:59:42 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This patch doesn't work for me. What about doing this? name: '[% server.servername | html_entity %]', It looks like the html_entity filter is what we want here: http://template-toolkit.org/docs/manual/Filters.html#section_html_entity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 19:08:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 18:08:07 +0000 Subject: [Koha-bugs] [Bug 22240] Add possibility to specify a category of patron in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240 --- Comment #3 from Katrin Fischer --- What you could do now is use a special due date for the students to ensure their items only get due after the school break and not enter closing dates to the calendar, so the teachers would be unaffected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 19:34:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 18:34:18 +0000 Subject: [Koha-bugs] [Bug 22101] ILL requests missing in menu on advanced search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 19:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 18:56:56 +0000 Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged as boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125 --- Comment #7 from Lucas Gass --- MY mistake. this should NOT be 18.05 as it is missing dependencies. Reverted commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:15:39 +0000 Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by Select2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:15:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:15:41 +0000 Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by Select2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84565|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 84641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84641&action=edit Bug 22242: Javascript error in value builder cased by Select2 Same as Bug 17780 but in value builders. Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. This patch checks if input has name attribute, because some inputs in Select2 have not. It brakes value builders marc21_linking_section.tt and unimarc_field_4XX.tt. Test plan : 1) On a MARC21 database 2) Define 774$0 as a regular subfield 3) Define 774$4 with an authorised value category 4) Define 774$t with value builder marc21_linking_section 5) Create a new record 6) Use value builder in 774$t 7) Search for a record and click choose 8) Without patch : a popup window does not close and show a blank screen 9) With patch : popup windows get close and you see in field 774 $0 and $t field with values 10) Same tests with a UNIMARC database on field 461 with value builder unimarc_field_4XX.tt Signed-off-by: Owen Leonard Tested successfully with MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:15:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:15:58 +0000 Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options match in acq and cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:21:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:21:41 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:21:44 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84602|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:21:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:21:47 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:21:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:21:50 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84604|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:21:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:21:53 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:21:55 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:22:26 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #48 from Tom?s Cohen Arazi --- Created attachment 84643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84643&action=edit Bug 21610: Remove specific changes we made previously We handled integers and dates for Koha::Patron and Koha::ItemType, we want now Koha::Object to deal with. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:22:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:22:30 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #49 from Tom?s Cohen Arazi --- Created attachment 84644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84644&action=edit Bug 21610: Fix integers and dates values at Koha::Object->store level With strict SQL modes, we are facing several issues when objects are stored. The following errors can be raised by DBIx::Class when an object does not have a valid (as defined at DB level) value: - Incorrect integer value: '' for column COLUMN - Incorrect decimal value: '' for column COLUMN - Column 'COLUMN' cannot be null - Field 'COLUMN' doesn't have a default value - Incorrect date value: '' for column 'COLUMN' We already handled some of them for Koha::Patron. As we do not want to provide such changes for all Koha::* modules we are going to fix this at Koha::Object->store level in order to provide a global fix. This is related to bug 21599 (for item types) and bug 21596 (for patrons) Test plan: - Apply first patch, run the tests => Patch fail because of the previous error in Koha::ItemType->store, to make them pass you can replace $self->notforloan(0) unless $self->notforloan; with $self->notforloan(undef) unless $self->notforloan; - Apply second patch, run the tests => They fail because of dates and/or integers values - Apply third patch, run the tests => They now pass Deep code review wanted! Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:22:34 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #50 from Tom?s Cohen Arazi --- Created attachment 84645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84645&action=edit Bug 21610: (QA follow-up) Better use columns_info from DBIx We should better use the published method than a private hash key. And shorter to go via _result than adding a new schema call. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:22:38 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #51 from Tom?s Cohen Arazi --- Created attachment 84646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84646&action=edit Bug 21610: (follow-up) Default value for dates We have some dates with DEFAULT CURRENT_TIMESTAMP and some dates with default and UPDATE clause. Test plan: Run Object.t again. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:22:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:22:21 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #47 from Tom?s Cohen Arazi --- Created attachment 84642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84642&action=edit Bug 21610: Add tests Adding few tests to Koha/Object.t in order to highlight what we are trying to fix. Note that Koha::ItemType->store was wrong for notforloan, the default value should be null `notforloan` smallint(6) DEFAULT NULL, but the previous fix (bug 21599) made it default to '0' Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:22:43 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #52 from Tom?s Cohen Arazi --- Created attachment 84647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84647&action=edit Bug 21610: Improve default values for dates This patch fixes failures on t/db_dependent/Koha/Patrons/Import.t and keep t/Auth_with_shibboleth.t and t/db_dependent/Koha/Object.t green Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:23:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:23:05 +0000 Subject: [Koha-bugs] [Bug 22262] New: text/javascript responses should be compressed by Apache Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22262 Bug ID: 22262 Summary: text/javascript responses should be compressed by Apache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Neither the vanilla Apache configuration nor the Debian one includes text/javascript in the list of MIME types of responses that get compressed by mod_deflate. Since some APIs under /svc/ happen to use that MIME type in their responses, a bit of bandwidth can be unnecessarily wasted. However, the lack of compression is of more import for svc/cataloguing/framework, which transfers a megabyte or so whenever it is invoked to fetch the default MARC21 framework (and presumably a similar amount of data for other MARC frameworks). Since that API is invoked when Rancor initializes, it's been observed that over a slow connection a RequireJS "define" call can time out, leading to the MARC editor never fully initializing and an error like this appearing in the browser debug console: "error" load timeout for modules: /cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define" onscripterror https://HOST/intranet-tmp1/lib/require_18.0504000.js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:23:57 +0000 Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling item-level_itypes syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:25:18 +0000 Subject: [Koha-bugs] [Bug 7614] Use branch transfer limits for determining available opac holds pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #46 from Lucas Gass --- missing dependency for 18.05.x wont backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:29:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:29:50 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84638|0 |1 is obsolete| | --- Comment #7 from Maryse Simard --- Created attachment 84648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84648&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:30:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:30:26 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:30:29 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84639|0 |1 is obsolete| | --- Comment #8 from Maryse Simard --- Created attachment 84649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84649&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:46:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:46:39 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:46:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:46:42 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84366|0 |1 is obsolete| | Attachment #84367|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 84650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84650&action=edit Bug 22193: Code refactoring/improvments Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:46:44 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #5 from Owen Leonard --- Created attachment 84651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84651&action=edit Bug 22193: Share report comments Test plan: - apply this patches, - download a report from Mana, - you should see a "Report mistake" button when you show, edit and run this report, - click on Report mistake -> New and type a comment, - check that it appears on the list, - reload the page, check the comment is still in the list, - click on Report mistake -> your comment, - ckeck the count has been incremented, - reload the page, the counter is still the same Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:50:44 +0000 Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Pierre-Marc Thibault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84532|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault --- Created attachment 84652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84652&action=edit Bug 22236: Translation should generate tags with consistent attribute order When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl. This causes things like this in run 1: And this in run 2: As you can see, there is actually no difference apart from the order. When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes. The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol). Test plan: [1] Run a translation without this patch and set a few templates aside. [2] Run a translation with this patch. [3] Run a compare (diff) on the templates copied in step 1. Verify that the only changes are found in the sort order of attributes in html tags. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 20:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 19:51:05 +0000 Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Pierre-Marc Thibault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-marc.thibault at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 21:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 20:34:48 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #53 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 21:35:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 20:35:09 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 21:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 20:43:12 +0000 Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 21:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 20:55:07 +0000 Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 22:14:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 21:14:42 +0000 Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members but has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 22:19:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 21:19:21 +0000 Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for Norwegian web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 22:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 21:48:20 +0000 Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 23:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 22:18:23 +0000 Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be specified per instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 23:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 22:26:14 +0000 Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated delete_unverified_opac_registrations.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 23:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 22:34:29 +0000 Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 23:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 22:47:18 +0000 Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds (maxoutstanding warning) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 1 23:48:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Feb 2019 22:48:29 +0000 Subject: [Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- missing dependency for 18.05.x will not backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 09:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 08:28:49 +0000 Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83812|0 |1 is obsolete| | Attachment #83813|0 |1 is obsolete| | --- Comment #83 from Josef Moravec --- Created attachment 84653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84653&action=edit Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. Test plan : - Apply patch. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 09:28:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 08:28:40 +0000 Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 09:29:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 08:29:09 +0000 Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #84 from Josef Moravec --- Created attachment 84654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84654&action=edit Bug 11373: (follow-up) Add "change calculation" feature to the fine payment forms This patch provides some follow-ups, including corrections to the JavaScript and updates to the text for readability. - Remove obsolete script "type" attribute - Update the use of the obsolete jQuery method "bind" - Use Bootstrap's built-in "show" option instead of simulated click - Handle preventDoubleFormSubmit function's "waiting" class if modal is closed manually To test, apply the patch and follow the original test plan. Everything should work as expected. Note that when the modal is shown, the cursor changes to the "waiting" one when you hover over the body of the page. If you click "No" in the modal, the cursor should return to normal. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 09:43:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 08:43:15 +0000 Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 09:43:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 08:43:20 +0000 Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84652|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 84655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84655&action=edit Bug 22236: Translation should generate tags with consistent attribute order When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl. This causes things like this in run 1: And this in run 2: As you can see, there is actually no difference apart from the order. When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes. The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol). Test plan: [1] Run a translation without this patch and set a few templates aside. [2] Run a translation with this patch. [3] Run a compare (diff) on the templates copied in step 1. Verify that the only changes are found in the sort order of attributes in html tags. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 09:43:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 08:43:29 +0000 Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:15:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:15:02 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #6 from Josef Moravec --- Comment on attachment 84650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84650 Bug 22193: Code refactoring/improvments Review of attachment 84650: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22193&attachment=84650) ----------------------------------------------------------------- ::: Koha/SharedContent.pm @@ +141,5 @@ > +sub get_entity_comments { > + my ($resource, $id) = @_; > + > + unless ($id) { > + return []; I would like to see here an implicit undef, so just 'return;' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:15:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:15:42 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:43:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:43:08 +0000 Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by Select2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:43:12 +0000 Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by Select2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84641|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 84656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84656&action=edit Bug 22242: Javascript error in value builder cased by Select2 Same as Bug 17780 but in value builders. Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. This patch checks if input has name attribute, because some inputs in Select2 have not. It brakes value builders marc21_linking_section.tt and unimarc_field_4XX.tt. Test plan : 1) On a MARC21 database 2) Define 774$0 as a regular subfield 3) Define 774$4 with an authorised value category 4) Define 774$t with value builder marc21_linking_section 5) Create a new record 6) Use value builder in 774$t 7) Search for a record and click choose 8) Without patch : a popup window does not close and show a blank screen 9) With patch : popup windows get close and you see in field 774 $0 and $t field with values 10) Same tests with a UNIMARC database on field 461 with value builder unimarc_field_4XX.tt Signed-off-by: Owen Leonard Tested successfully with MARC21 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:43:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:43:32 +0000 Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by Select2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:52:55 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:53:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:53:00 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84640|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 84657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84657&action=edit Bug 22253: Check we actually need to update the password This patch makes memberentry.pl check if password needs to be updated before attempting to call set_password. Above this there's a check that won't raise any errors if no password is passed, or the default string (****) is received. So we could reach that line of code with no password, but the code wouldn't check that. To test: - In master, edit any patron without changing the password => FAIL: It raises an exception - Apply this patch - Edit the patron withtout changing the password => SUCCESS: Edit successful - Edit the patron, changing the password - Try to login with the new password => SUCCESS: The password got changed correctly - Sigh off :-D Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 10:53:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 09:53:11 +0000 Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a borrower with an insecure password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 12:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 11:47:56 +0000 Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Text to go in the|This adds http BASIC |This adds http BASIC release notes|authentication as an |authentication as an |optional auth method to the |optional auth method to the |RESTful api's. This |RESTful APIs. This greatly |greatly aids developers |aids developers when |when developing against our |developing against our |api's. |APIs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 12:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 11:53:22 +0000 Subject: [Koha-bugs] [Bug 22241] Duplicate records. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Estel, some information is missing here in order to be able to help you, like the version you are running. Tbh I have on idea what might be happening there. But I am wondering if you meant to raise this as a support request with your Koha support provider maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:50:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:50:22 +0000 Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Owen, I think this might be in conflict with your big clean-up patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:51:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:51:01 +0000 Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244 --- Comment #4 from Katrin Fischer --- Created attachment 84658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84658&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:51:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:51:41 +0000 Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:51:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:51:45 +0000 Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84658|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 84659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84659&action=edit Bug 22244: Fix typo in Mana Knowledge Base message knowlede -> knowledge Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:54:17 +0000 Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84500|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer --- Created attachment 84660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84660&action=edit Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: David Cook Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:54:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:54:21 +0000 Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84501|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer --- Created attachment 84661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84661&action=edit Bug 21751: Remove former fixFloat plugin Signed-off-by: David Cook Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:54:25 +0000 Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84502|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer --- Created attachment 84662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84662&action=edit Bug 21751: (follow-up) Correction to selectors This patch makes a couple of corrections to the selectors used by hcsticky in targeting the position of the floating toolbar. These changes were made necessary by changes made in recently-pushed patches. To test, confirm that these two pages work correctly: - Acquisitions -> Vendor -> View basket - Patrons -> New patron Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:55:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:55:20 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #19 from Katrin Fischer --- Passed QA on depenency, unlocking this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:56:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:56:31 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #20 from Katrin Fischer --- Tried to apply on top of patches for 21751, but got a conflict: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11375: Improve patrons permissions display error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 11375: Improve patrons permissions display The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11375-Improve-patrons-permissions-display-jTsU_R.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 14:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 13:57:16 +0000 Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:07:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:07:08 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |additional_work_needed --- Comment #9 from Katrin Fischer --- Hi Owen, I am passing QA on this, but can I ask you to please complete the cookie documentation on the wiki according to coding guidelines? https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:07:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:07:59 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:08:02 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84648|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 84663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84663&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:08:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:08:06 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84649|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 84664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84664&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:13:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:13:17 +0000 Subject: [Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- I am with Jonathan on this one... it kind of screems for tests as they are practically written out in the bug and on the commit message. It will also help us to confirm in the future that this is the desired behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:13:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:13:24 +0000 Subject: [Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Number of items to order on |Number of items to order on |holds ratio report will not |holds ratio report will not |fulfill the holds ratio. |fulfill the holds ratio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:15:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:15:31 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #43 from Katrin Fischer --- (In reply to Jessie Zairo from comment #42) > It would be great if we could also add a feature to browse by call number. Hi Jesse, please file a separate bug for this depending on this one. Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:30:59 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer --- Hi Nick, coming back to this: QA scripts pass now (good!) Am I right that this is ES only? But: 1) There is an issue with the CSS files (please fix first of all): $ node_modules/.bin/gulp build --view=opac [14:17:24] Using gulpfile ~/kohaclone/gulpfile.js [14:17:24] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Error: Invalid CSS after "... solid #E3E3E3;": expected "}", was ".border-radius-all(" on line 3281 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> border: 1px solid #E3E3E3; -----------------------------------^ 2) Please add the link to the navigation (formerly 1). I feel it would make sense to have this depending on a system preference as the other additional features in the navigation bar do. It should also note that this is for Elasticsearch only. But beware: We already got OpacBrowser and OpacBrowseReults... (probably OpacBrowser should be renamed OpacBrowseAuthorities...). 3) opac-browse.pl doesn't use the standard use CGI qw ( -utf8 ); 4) Follow-up bug or something to resolve before pushing? +# This is the temporary entrance point to the API. Once bug #13799 is settled, +# it should be ported to using that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:36:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:36:47 +0000 Subject: [Koha-bugs] [Bug 22263] New: Command line script to populate or update items.cn_sort Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22263 Bug ID: 22263 Summary: Command line script to populate or update items.cn_sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Sometimes cn_sort might be incorrect (wrong configuration when loading the items) or even empty (migration issue). It would be nice to have a script that allowed recalculating and updating the cn_sort field in items. This would be a maintenance script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 15:39:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 14:39:01 +0000 Subject: [Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Katrin Fischer --- I feel if we agree this is a data issue, the bug could probably be closed? I filed bug 22263 for adding a maintenance script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 16:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 15:17:49 +0000 Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236 --- Comment #4 from Marcel de Rooy --- (In reply to Josef Moravec from comment #3) > Signed-off-by: Pierre-Marc Thibault > > Signed-off-by: Josef Moravec Thanks Pierre-Marc and Josef ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 17:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 16:57:29 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22263 --- Comment #50 from Katrin Fischer --- > > It might be nice to add a script to help people populating this field if it > > was somehow missed during migration or set to a wrong value, but that is out > > of scope here for sure! > > Thank you, file a bug and we can look at a future time :-) Done: bug 22263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 17:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 16:57:29 +0000 Subject: [Koha-bugs] [Bug 22263] Command line script to populate or update items.cn_sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19915 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:09 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:19 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83645|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer --- Created attachment 84666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84666&action=edit Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t Standard edits like modules, schema, Koha objects instead of DBIC. Removing unneeded autoflush. Moving initial test to a first subtest. No need to clear issues if you clear items. Adding a FIXME for OldWay; would be nice to remove that code.. Signed-off-by: Marcel de Rooy https://bugs.koha-community.org/show_bug.cgi?id=19905 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:24 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83646|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer --- Created attachment 84667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84667&action=edit Bug 19915: Use cn_sort values for getting inventory items To test: 1 - Catalog an item under LCC with callnumber GT95 2 - cn_sort should calculate as GT0095 3 - Go to inventory tool 4 - Enter a range that should have your item e.g LC GT90 to GT100 5 - Item is not returned 6 - Apply patch 7 - Item should be returned 8 - Verify things otherwise work as expected Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy https://bugs.koha-community.org/show_bug.cgi?id=19905 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:14 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83644|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer --- Created attachment 84665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84665&action=edit Bug 19915: Add unit test to GetItemsForInventory.t prove -v t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy Moved the betwen typo edit back here. https://bugs.koha-community.org/show_bug.cgi?id=19905 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:30 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83647|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer --- Created attachment 84668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84668&action=edit Bug 19915: Only show class sources in use Signed-off-by: Marcel de Rooy https://bugs.koha-community.org/show_bug.cgi?id=19905 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:34 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83648|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer --- Created attachment 84669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84669&action=edit Bug 19915: Don't delete in tests https://bugs.koha-community.org/show_bug.cgi?id=19905 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 18:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 17:06:40 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83649|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer --- Created attachment 84670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84670&action=edit Bug 19915: (follow-up) Fix test count from rebase https://bugs.koha-community.org/show_bug.cgi?id=19905 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:34:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:34:57 +0000 Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- Hi, there is one noticeable and big difference: With the patch you see the optgroups of budgets, even if there are no funds listed below. That makes the list grow long, especially as it also includes the inactive ones by default. Combinations I tested: - Active budget with multi-level funds - ok - Inactive budget with fund - not ok, budget is listed - Locked budget with fund - not ok, budget is listed - Active budget with funds that are not accessible by permission (restricted to owner) - not ok This would for example be used to separate budgets and funds of different libraries in a system and could also make the list quite long. I really like the idea of this improvement, but I think we are not there yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:39:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:39:17 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:39:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:39:21 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83672|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 84671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84671&action=edit Bug 20000: Use Modern::Perl in installer scripts To test: Check that we are using Modern::Perl when strict *and* warnings were used before, and commented lines and FIXMEs have been removed from the rest, out of files listed below. data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:42:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:42:10 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #42 from Katrin Fischer --- Created attachment 84672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84672&action=edit Bug 12759: Add missing html filters Add some missing html filters to fix QA script complaints. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:42:28 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:43:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:43:04 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #43 from Katrin Fischer --- Just fixed my own typo on the follow-up patch's commit message. Can't QA as I signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:45:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:45:33 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #66 from Katrin Fischer --- Conflicts in the Schema changes part (should be a separate patch) Can you please fix and maybe separate these changes out? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15326: Add CMS feature Applying: Bug 15326: (follow-up) Add CMS feature Using index info to reconstruct a base tree... M Koha/Schema/Result/Branch.pm Falling back to patching base and 3-way merge... Removing t/Pages.t Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15326: (follow-up) Add CMS feature The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15326-follow-up-Add-CMS-feature-E4XbRe.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 21:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 20:47:54 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #88 from Katrin Fischer --- Hi Owen, I see you signed off the follow-up, does this count for the whole patch set or only the follow-up? Looking to get my QA token back :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 22:45:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 21:45:18 +0000 Subject: [Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 22:45:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 21:45:22 +0000 Subject: [Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83752|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 84673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84673&action=edit Bug 21738: check items count in C4:ILSDI::HoldTitle Test plan: - Try holding a title without items via ILS-DI (cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1), - you get an error, - apply this patch, - try again, - you should get the code "Notitems"Bug 21738: check items count in C4:ILSDI::HoldTitle Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 22:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 21:45:26 +0000 Subject: [Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83753|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 84674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84674&action=edit Bug 21738: make call of CanBookBeReserved more safe Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 22:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 21:58:17 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |oleonard at myacpl.org --- Comment #6 from Katrin Fischer --- Some things: 1) Tiny typo in "subflied": $(this).parent().find('.hint').html(_("Enter a regular expression for this subflied")); 2) I am not happy witht he GUI. The delete checkbox always takes some time explaining and I think having now 2 unlabelled checkboxes makes it worse. Maybe a link or small button "RegEx" would work? Adding Owen to see if he has an idea. 3) During our discussion on bug 15836 we came to the conclusion that a separate permission should be added for that page as there are some potential issues with the regex. In our libraries a lot of people have item batch edit permissions, as this is a super useful tool. In wonder if we need to take extra precautions here. Adding some people in hope for a second opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 22:58:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 21:58:44 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 --- Comment #7 from Katrin Fischer --- I should also say: I've tested it a bit and it all worked ok so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 2 22:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Feb 2019 21:59:45 +0000 Subject: [Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- BLOCKED by bug 20338 dependency being Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 03:10:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 02:10:49 +0000 Subject: [Koha-bugs] [Bug 22264] New: Account expiration warning via notices and e-mail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22264 Bug ID: 22264 Summary: Account expiration warning via notices and e-mail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Would like to see more options in giving patrons advance notice that their account is about to expire. To my knowledge, right now, there is only a warning on the OPAC if they happen to login. Not all patrons come into a library or login to the catalog. A preference to be notified via mail or e-mail or text would be superb. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 09:32:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 08:32:42 +0000 Subject: [Koha-bugs] [Bug 22264] Account expiration warning via notices and e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Christopher, there is already an email feature. Take a look at the MEMBERSHIP_EXPIRY notice: https://koha-community.org/manual/18.11/en/html/tools.html?highlight=notices#existing-notices-slips -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 09:55:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 08:55:18 +0000 Subject: [Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Permanent location should |Improve display of changed |show instead of cart |values on course reserves |location - |and show permanent location |course-details.tt |instead of cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 09:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 08:56:12 +0000 Subject: [Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 --- Comment #11 from Katrin Fischer --- Created attachment 84675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84675&action=edit Bug 21446: Improve display of changed values on course reserves and show permanent location instead of cart TO TEST: 1) Set ReturnToShelvingCart on. 2) Create a Course Reserve and make inactive. 3) Add an item, changing Item type, Collection code, Shelving location, and Holding library. 4) Note these four fields in the item list. 5) Activate course reserve. 6) Note subtle/no difference in these fiels in the list. 7) Check in the item. 8) Go back to course reserves and note that the cart is listed in the field instead of permanent location. 9) Deactivate course reserve. 10) Reset permanent location on item manually. 11) Apply patch. 12) Repeat steps 4-9 noting that the permanent location is showing instead of current location. Also, if a change is assigned to the item, the change AND the regular state always show. The active state will be in bold. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 09:56:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 08:56:16 +0000 Subject: [Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84113|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 84676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84676&action=edit Bug 21446: Remove fix comment Fix is not needed. Signed-off-by: helene hickey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 09:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 08:56:09 +0000 Subject: [Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 10:18:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 09:18:10 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Tomas, I think I would have liked a workflow where the value from the global preference is inherited and can be overwritten on category level a little better as this is yet another thing to remember when setting up patron categories (adding more steps and clicks in most use cases). An example for the different behaviour would be: Block expired patrons. (something to consider) 2) NOT allowed = 1 for the column categories.can_reset_password seems counter intuitive? Please check values. 3) The new column is missing from the category overview page and column configuration. I know others appear to be missing too, but I'd consider this a bug as it means you have to open each one to see where you might have made a wrong choice. 4) The message is: + [% ELSIF errNoBorrowerFound %] +
  • You are not allowed to reset your password. Contact library staff for assistance.
  • [% END %] I think the
  • is wrong here as we are not inside a list and the other message doesn't have it. I think it would be nice to add a span around the message with an id, so if libraries want to change the message it will be easy. The message might read a little harsh to some or they might want to explain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 10:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 09:19:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #72 from Katrin Fischer --- (In reply to Martin Renvoize from comment #55) > I have given this a thorough testing and added a few qa followups to fix > some failing test cases and improve test coverage. > > I also felt it important to add support for hourly loan periods and as such, > I've added a pair of follow-ups to add this. As such, although I'd PQA on > all work preceding my own, I've asked Tomas and Kyle to cast their eyes over > the followup as a final QA signoff. Are we waiting for Tomas or should this be moved on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 10:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 09:21:27 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Moving to failed QA as of Tomas last comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 10:25:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 09:25:20 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 10:25:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 09:25:23 +0000 Subject: [Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84600|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 84677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84677&action=edit Bug 22254: Correction to datehandling in test Adding 13 months is not always the same as adding 1 month and then adding 12 months in DateTime maths. This patch rectified the test to match the correct behaviour in koha. Test plan. 1) Modify the test (around line 268) to test against the suspect leap date of 2019-01-31 and watch the test fail. 2) Apply the patch (which also adds this modification to test for such a leap date) and watch the test now pass. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:22:41 +0000 Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi all, I tested, but found 2 issues that we need to fix: - The QA script complains about missing filters - While most values of the system preference translate directly, tabulation does not: ;|tabulation|,|/|\|#||. So when tab is selected, the file exported is not usable as it has "tabulation" printed as a separator instead of the actual 'tab'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:28:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:28:08 +0000 Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:28:12 +0000 Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83774|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 84678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84678&action=edit Bug 22097: CataloguingLog should be suppressed for item branch transfers Bug 18816 missed the fact that a branch transfer triggers ModItem and thus generates an action log line. We should not be creating those action logs, especially considering the transfers table itself already documents the transfer. Test Plan: 1) Enable CataloguingLog 2) Transfer an item to another branch 3) Note the new action log line created 4) Apply this patch 5) Create another item transfer 6) No new action log line should be created! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:28:42 +0000 Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Behaviour of ModItem with and without the logging flag is already tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:35:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:35:16 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:35:20 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84101|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 84679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84679&action=edit Bug 21622: Adjust incorrect GROUP BY clauses in acqui script acqui/ordered.pl: GROUP BY aqorders.ordernumber acqui/spent.pl: GROUP BY aqorders.ordernumbe 'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY Test plan: - Create orders for different basket and using different funds - Receive some of them - Hit the ordered and spent pages (from the acqui home page) => The tables must contain the same data with and without this patch Signed-off-by: Jasmine Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:44:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:44:04 +0000 Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:44:08 +0000 Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83833|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 84680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84680&action=edit Bug 16231: Correct permission handling in subscription edit This patch corrects the way subscription edit menu items are displayed according to the user's permissions settings. To test, apply the patch and log in to the staff client as a user who has permission to create, edit, and delete subscriptions. - Locate an subscription and view the details for it. - Confirm that each "Edit" menu item works correctly. - Repeat the process when logged in as a user with varying combinations of create, edit, and delete permissions. - Test as a user limited by IndependentBranches. Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 11:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 10:54:25 +0000 Subject: [Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I am not even sure if the current behaviour is correct: When requesting an article the pick-up branch is selected and it seems only libraries from the pick-up branch see the request... so the fact where the item actually is is not taken into account at all and libraries who might be able to fill the request are not notified? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:16:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:16:41 +0000 Subject: [Koha-bugs] [Bug 22265] New: Processing article requests requires borrowers permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22265 Bug ID: 22265 Summary: Processing article requests requires borrowers permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- I just noticed that you will only be able to see article requests if the staff patron has "borrowers" permission. You can still access the article requests page without the permission, but it will always show "no pending article requests". This dependency doesn't seem logical, especially since you can still access the page and it just seems like there are no requests. The problem seems to come from this part of the code: Koha::ArticleRequests: sub search_limited { my ( $self, $params, $attributes ) = @_; my $userenv = C4::Context->userenv; my @restricted_branchcodes; if ( $userenv and $userenv->{number} ) { my $logged_in_user = Koha::Patrons->find( $userenv->{number} ); @restricted_branchcodes = $logged_in_user->libraries_where_can_see_patrons; } # TODO This 'borrowernumber' relation name is confusing and needs to be renamed $params->{'borrowernumber.branchcode'} = { -in => \@restricted_branchcodes } if @restricted_branchcodes; $attributes->{join} = 'borrowernumber'; return $self->search( $params, $attributes ); } Not sure yet what the best way would be: Do we want to allow article request processing without borrowers? If no, we could hide article requests from view if the staff user doesn't have the required permission. If yes, what would be the consequence? (stuck on that one) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:17:23 +0000 Subject: [Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 --- Comment #5 from Katrin Fischer --- My confusion was related to bug 22265. PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:18:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:18:33 +0000 Subject: [Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:18:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:18:37 +0000 Subject: [Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83794|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 84681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84681&action=edit Bug 21907: Fix article requests count for non-superlibrarians The query generates "Column 'branchcode' in where clause is ambiguous" Test plan: 1 - Enable 'IndependentBranchesPatronModifications' and article requests 2 - Sign in as non-superlibrarian 3 - View plack log 4 - Refresh mainpage, see error in logs Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:28:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:28:41 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- QA script: FAIL misc/maintenance/fix_tags_weight.pl OK critic FAIL forbidden patterns forbidden pattern: merge marker (=======) (line 85) forbidden pattern: merge marker (=======) (line 124) OK git manipulation Please fix! I also noticed that you can only tag an item with any emoticon once. If I try to add whale and then later add smiley I always get told I can't add the same twice. Is this related? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:32:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:32:04 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:33:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:33:02 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #115 from Katrin Fischer --- I am sorry, but there are some conflicts. Please rebase, I'll try to come back to this soon: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15774: Add additional fields to order baskets Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M serials/serials-search.pl M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in serials/subscription-add.pl Auto-merging serials/serials-search.pl CONFLICT (content): Merge conflict in serials/serials-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc Auto-merging admin/additional-fields.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 15774: Add additional fields to order baskets The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15774-Add-additional-fields-to-order-baskets-LGaSot.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:37:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:37:46 +0000 Subject: [Koha-bugs] [Bug 22266] New: Make layout name for patron card layouts a required field to avoid db error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22266 Bug ID: 22266 Summary: Make layout name for patron card layouts a required field to avoid db error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When creating a new patron card layout the layout name is not a required field, but the layout won't save if it's left empty. There will also be an error in the log: Database returned the following error: Column 'layout_name' cannot be null at /home/vagrant/kohaclone/C4/Creators/Layout.pm line 183. Manage interface called an unsupported operation: save at /home/vagrant/kohaclone/patroncards/manage.pl line 103. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:38:03 +0000 Subject: [Koha-bugs] [Bug 22266] Make layout name for patron card layouts a required field to avoid db error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:44:01 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I still see one: 1) Add a new patron layout, just entering the layout name 2) Change the Units CGI::param called in list context from /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. 3) Delete layout CGI::param called in list context from /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. I don't seem to be able to make them appear consistently. Can you take a look? (Marking failed QA, to get your attention ;) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:50:35 +0000 Subject: [Koha-bugs] [Bug 17186] Error duplicate bibliography when saving new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Hardware|PC |All Severity|enhancement |major Resolution|--- |WONTFIX OS|Windows |All --- Comment #1 from Katrin Fischer --- Koha version 3.18 is no longer maintained. Please reopen if this problem still occurs for you in newer versons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:53:57 +0000 Subject: [Koha-bugs] [Bug 11031] Delete useless 9XX field in french unimarc public library default Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |katrin.fischer at bsz-bw.de, | |sonia.bouis at univ-lyon3.fr, | |victor.grousset at biblibre.co | |m --- Comment #1 from Katrin Fischer --- Adding some UNIMARC users I know - Is this bug still valid? Shoudl the 9xx be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 12:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 11:57:20 +0000 Subject: [Koha-bugs] [Bug 7052] print button confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- The print button still shows, but as it's a pull down listing all available options, it seems clear enough to me. Please reopen if you think a change is still desirable. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:01:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:01:29 +0000 Subject: [Koha-bugs] [Bug 22267] New: Warns in logs when adding and editing descriptions to batches Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 Bug ID: 22267 Summary: Warns in logs when adding and editing descriptions to batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To test: Watch logs while: - Add new patron card batch - Fill in description - Save description - Edit batch - Change description text and click save description Use of uninitialized value $description in string eq at /home/vagrant/kohaclone/svc/creator_batches line 60. Use of uninitialized value in string eq at /home/vagrant/kohaclone/svc/creator_batches line 60. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:02:22 +0000 Subject: [Koha-bugs] [Bug 5169] name/rename label batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- I think this has been resolved by the ability to add descriptions to batches with bug 15766. *** This bug has been marked as a duplicate of bug 15766 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:02:22 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #62 from Katrin Fischer --- *** Bug 5169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:03:07 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 [Bug 22267] Warns in logs when adding and editing descriptions to batches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:03:07 +0000 Subject: [Koha-bugs] [Bug 22267] Warns in logs when adding and editing descriptions to batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 [Bug 15766] Give label and patron card batches a description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:06:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:06:11 +0000 Subject: [Koha-bugs] [Bug 16627] Show library and date of patron requests for update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- The information now displays: koha - Board (Centerville) (42) - Requested on 03.02.2019 12:05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:09:55 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 --- Comment #2 from Katrin Fischer --- Still valid, holds log doesn't log changes to priority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:10:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:10:05 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changes to holds priority |Changes to holds priority |list should be logged for |list should be logged for |accountability. |accountability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:11:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:11:28 +0000 Subject: [Koha-bugs] [Bug 18614] Add useful CSS classes to the *detail.pl pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Mason, I think this bug is a bit too general as of now. I'll close it, please reopen if you have more information! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:14:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:14:26 +0000 Subject: [Koha-bugs] [Bug 9598] Ability to split up shipping cost between all items and funds on an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|pro-rate shipping |Ability to split up | |shipping cost between all | |items and funds on an | |invoice CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:20:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:20:19 +0000 Subject: [Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|17.05 |master Summary|Categories.pl allows users |Enrollment period date on |to set the |patron category can be set |enrolementperioddate to |in the past without any |before the current date |error/warning messages |without any error/warning | |messages | --- Comment #2 from Katrin Fischer --- Still valid, resetting to master and rephrasing/shortening bug title a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 13:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 12:24:04 +0000 Subject: [Koha-bugs] [Bug 16487] Cataloging/Authority search: add link to number of times used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.20 |master --- Comment #1 from Katrin Fischer --- I wonder, as this is in a pop-up if it would be possible to open results in a new tab in the 'origin' window? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 21:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 20:57:54 +0000 Subject: [Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all holds' button on holds over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Cancel all holds button |Make it easy to hide |text needs .class or at |'Cancel all holds' button |least an html tag. |on holds over report --- Comment #2 from Katrin Fischer --- You can already hide the button with: form[name=cancelAllReserve] { display:none; } But this leaves the text that and is a syntax not everyone might be familiar with. I suggest to wrap both into a span that will make things easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 3 23:05:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 22:05:47 +0000 Subject: [Koha-bugs] [Bug 5938] Maximum number of issues across a family group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 Mark Alexander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marka at pobox.com --- Comment #7 from Mark Alexander --- Our library may have an interest in a family group feature, but rather than having a system-level setting for maximum issues per group, we would need to have circulation rules for family groups. As an example, our library has an informal rule that says: no more than two issues of item type DVD allowed per household. There was no automated way to enforce this rule when we were using Mandarin, nor is there a way using Koha now. Instead, it depends on the librarian (or volunteer desk staff) knowing everybody in this small town and performing the restriction manually. In practice I have never seen this rule enforced. In any case, to implement this rule, we would need to add a field to the circulation rule for item type DVD that specifies maximum issues per family group. But implementing this seems rather complex. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:27:10 +0000 Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > Hi, > > there is one noticeable and big difference: With the patch you see the > optgroups of budgets, even if there are no funds listed below. That makes > the list grow long, especially as it also includes the inactive ones by > default. > > Combinations I tested: > - Active budget with multi-level funds - ok > - Inactive budget with fund - not ok, budget is listed > - Locked budget with fund - not ok, budget is listed > - Active budget with funds that are not accessible by permission > (restricted to owner) - not ok > This would for example be used to separate budgets and funds of different > libraries in a system and could also make the list quite long. > > I really like the idea of this improvement, but I think we are not there yet. Do you know if this is comparable to orderreceive.tt? My original plan was just to bring parcels.tt and newemptyorder.tt in line with that template. Did inactive and locked budgets not show before the patch? I'm not sure I understand the "accessible by permission" part. I think the code for that is identical before and after the patch? If the list were long, I would think having optgroup tags would be essential for organising them? Otherwise the select list would be difficult to navigate. I'm not sure that I understand this part of the feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:30:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:30:16 +0000 Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:30:06 +0000 Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #12 from David Cook --- This is a change that I already manage locally so I'm probably unlikely to revise this patch any time soon. I'll remove myself as Assignee, but re-add myself if I do find myself with some time to try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:34:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:34:07 +0000 Subject: [Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22263 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:34:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:34:07 +0000 Subject: [Koha-bugs] [Bug 22263] Command line script to populate or update items.cn_sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22263 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21447 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:14 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83404|0 |1 is obsolete| | --- Comment #67 from Aleisha Amohia --- Created attachment 84682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84682&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:31 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83406|0 |1 is obsolete| | --- Comment #69 from Aleisha Amohia --- Created attachment 84684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84684&action=edit Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:37 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83407|0 |1 is obsolete| | --- Comment #70 from Aleisha Amohia --- Created attachment 84685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84685&action=edit Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:45 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83408|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia --- Created attachment 84686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84686&action=edit Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:52 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83409|0 |1 is obsolete| | --- Comment #72 from Aleisha Amohia --- Created attachment 84687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84687&action=edit Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:24 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83405|0 |1 is obsolete| | --- Comment #68 from Aleisha Amohia --- Created attachment 84683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84683&action=edit Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:37:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:37:59 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83410|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia --- Created attachment 84688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84688&action=edit Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:38:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:38:06 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83411|0 |1 is obsolete| | --- Comment #74 from Aleisha Amohia --- Created attachment 84689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84689&action=edit Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:38:13 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83412|0 |1 is obsolete| | --- Comment #75 from Aleisha Amohia --- Created attachment 84690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84690&action=edit Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:39:22 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #76 from Aleisha Amohia --- Created attachment 84691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84691&action=edit Bug 15326: Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:39:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:39:17 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:39:52 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #77 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #66) > Conflicts in the Schema changes part (should be a separate patch) Can you > please fix and maybe separate these changes out? > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 15326: Add CMS feature > Applying: Bug 15326: (follow-up) Add CMS feature > Using index info to reconstruct a base tree... > M Koha/Schema/Result/Branch.pm > Falling back to patching base and 3-way merge... > Removing t/Pages.t > Auto-merging Koha/Schema/Result/Branch.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 15326: (follow-up) Add CMS feature > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-15326-follow-up-Add-CMS-feature-E4XbRe.patch Rebased and moved schema fixes into a separate patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 00:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Feb 2019 23:53:21 +0000 Subject: [Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > I feel if we agree this is a data issue, the bug could probably be closed? > I filed bug 22263 for adding a maintenance script. Sounds good to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 04:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 03:39:57 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:39:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:39:47 +0000 Subject: [Koha-bugs] [Bug 22262] text/javascript responses should be compressed by Apache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22262 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:41:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:41:16 +0000 Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric in numeric eq (==) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:46:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:46:01 +0000 Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #13 from Katrin Fischer --- I wrote difference because the behaviour is different to the already existing drop down on receive. This one works correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:47:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:47:13 +0000 Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #14 from Katrin Fischer --- "By permission" would for example be a fund managed by another library in the system that is restricted to users, owners and staff patrons from this library. With you patch I seee the budget, even if I can't order from any fund below it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:50:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:50:41 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #78 from Katrin Fischer --- Hi Aleisha, you can usually set back to "Signed off" after a rebase if it was before (unless you feel the changes were too heavy and should be retested) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:52:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:52:21 +0000 Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I raised this issue many years ago but I don't think there was any interest in fixing it. My original idea was to implement row locking in the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 07:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 06:58:59 +0000 Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|Other |All Version|18.05 |master CC| |katrin.fischer at bsz-bw.de OS|Windows |All --- Comment #2 from Katrin Fischer --- (In reply to David Cook from comment #1) > I raised this issue many years ago but I don't think there was any interest > in fixing it. I think the problem is not interest, we can easily agree that this is not a good situation. But it will also need funding and agreeing on the right method in order to be able to fix it. I think it's good the problem is on bugzilla now, thx Karin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 08:00:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 07:00:30 +0000 Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 08:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 07:12:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #115 from Katrin Fischer --- Aleisha, did you mean to sign-off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 08:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 07:48:20 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #75 from Josef Moravec --- Comment on attachment 81032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81032 Bug 8643: Add important constraint to marc subfields Review of attachment 81032: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8643&attachment=81032) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql @@ +6,5 @@ > +-- $dbh->do("ALTER TABLE marc_subfield_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory"); > +-- $dbh->do("ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory"); > +-- print "Upgrade to $DBversion done (Bug 8643 - Add important constraint to marc subfields)\n"; > +-- SetVersion($DBversion); > +-- } The database update should be idempotent, make it all in perl and use column_exists helper function, like this: if( !column_exists( 'marc_subfield_structure', 'important' ) ) { $dbh->do("ALTER TABLE ... ADD COLUMN ..."); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 08:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 07:48:34 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 08:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 07:50:29 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Checkouts_endpoin | |t_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:13:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:13:45 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #3 from Ere Maijala --- Nicolas, don't worry, it will be completely optional. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:16:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:16:55 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #4 from Nicolas Legrand --- He he, I just fear the moment when my librarian colleagues will know about this option :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:20:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:20:44 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #5 from Ere Maijala --- Ah, yes :) Then again you could already add rules for all MARC fields, it's just more cumbersome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:32:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:32:11 +0000 Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric in numeric eq (==) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:33:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:33:51 +0000 Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:36:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:36:33 +0000 Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged as boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:36:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:36:34 +0000 Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Bug 16497 depends on bug 22125, which changed state. Bug 22125 Summary: branches.pickup_location should be flagged as boolean https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:38:03 +0000 Subject: [Koha-bugs] [Bug 22101] ILL requests missing in menu on advanced search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:39:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:39:35 +0000 Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options match in acq and cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:49:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:49:59 +0000 Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling item-level_itypes syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Ok for this patch. But I think this file needs more work. I see : while (($itemtype, $description,$biblioitems,$total) = $sth->fetchrow) So first var is the item type. $biblioitems seems unused. This code is confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:51:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:51:52 +0000 Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling item-level_itypes syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274 --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 10:54:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 09:54:22 +0000 Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- Depends on Bug 18816 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 11:34:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 10:34:24 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #1 from Matthias Meusburger --- Created attachment 84692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84692&action=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 11:34:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 10:34:55 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 12:14:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 11:14:24 +0000 Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #54 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 12:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 11:20:12 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84258|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 84693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84693&action=edit Bug 21560: report ODS export optimization SQL reports can be exported with CSV, TSV of ODS format. When report has thousands of rows, using ODS format is around 10 times longer than other formats. It also loads CPU and RAM a lot. The longest call is expandTable(). I found that the call on OpenOffice-OODoc lib can be optimized. Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table Test plan : 1) Don't apply patch yet 2) Create a new SQL report : Home > Reports > Create from SQL 3) Enter a SQL that will return thousands of results 4) Run report 5) Click Download > Semicolon separated text (.csv), look execution time 6) Click Download > Open Document Spreadsheet, look execution time 7) Apply patch 8) Redo 5) and 6) and compare times, CSV export should be the same but ODS export should be better My tests shows 1,5 seconds for CSV export. And for ODS export : 18 seconds without patch and 8 seconds with patch. Signed-off-by: David Nind Signed-off-by: Chris Cormack Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 12:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 11:20:16 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84259|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 84694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84694&action=edit Bug 21560: Optimize ODS export of gather_print_notices.pl Like previous patch, the call on OpenOffice-OODoc lib can be optimized. Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table Test plan inspired from Bug 11679. Test plan: - define your ODUE notice for the print template as: cardnumber:patron:email:item <>:<> <>:<>:<> - define overdues rules for a patron category - check-out 2 items using a due date in order to generate the overdue notices - check-in these 2 items - launch the script /misc/cronjobs/overdue_notices.pl - the 'message_queue' table should now contain 2 new entries - launch the gather_print_notices cronjob : perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: - A ods file should be generated in your /tmp/test directory - Compare times with and without patch Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 12:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 11:21:04 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Nice little optimization, passing QA scripts and no regressions found.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 12:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 11:42:46 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com --- Comment #2 from Katrin Fischer --- Please don't forget to add yourself as assignee :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:02:13 +0000 Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:05:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:05:51 +0000 Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members but has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:11:16 +0000 Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for Norwegian web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:15:39 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82511|0 |1 is obsolete| | --- Comment #21 from Andrew Isherwood --- Created attachment 84695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84695&action=edit Bug 20563: Allow display of requested partners This patch adds the display of requested partner email addresses when an ILL backend provides the ability to send requests to partners. Partner email addresses are displayed in the illlist and illview displays, they are also included in the 'illrequests' API response. * api/v1/swagger/paths/illrequests.json: - Add 'requested_partners' as an 'embed' enum * Koha/Illrequest.pm: - Add 'requested_partners' accessor calling optional backend 'get_requested_partners' method. - Store requested partners upon email send, calling optional backend 'set_requested_partners' method. - Add 'requested_parners' embed to overloaded TO_JSON method. * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: - Add 'requested_partners' embed to illrequests API call - Add render function for "Additional status" datatables column - Add display of requested partner email addresses to illlist table - Add display of requested partner email addresses to illview display To test: 1) Enable Interlibrary loans 2) Add a backend that supports sending requests to partners, e.g. FreeForm 3) Set up at least one partner 4) Create an ILL request 5) Send request to partner(s) 6) Observe partner(s) email address(es) are displayed in "View ILL requests" view 7) Observe partner(s) email address(es) are displayed in "Manage ILL request" view Signed-off-by: mmg at interleaf.ie https://bugs.koha-community.org/show_bug.cgi?id=20653 Bug 20563: (follow-up) Fix requested partners As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563#c10 Thanks for the suggestion on merging the "Status" and "Additional status" columns, looks much better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:23:30 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 --- Comment #6 from Martin Renvoize --- I think we need a second syspref added here as it sneaks in an additional LDAP lookup per local search result to allow for a Sync operation. This could add a not insignificant additional load to the remote LDAP server which some users may wish to avoid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:29:03 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82734|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood --- Created attachment 84697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84697&action=edit Bug 20563: (follow-up) Fix rebasing bug Fix erroneous curly brackets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:29:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:29:07 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84695|0 |1 is obsolete| | --- Comment #24 from Andrew Isherwood --- Created attachment 84698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84698&action=edit Bug 20563: Allow display of requested partners This patch adds the display of requested partner email addresses when an ILL backend provides the ability to send requests to partners. Partner email addresses are displayed in the illlist and illview displays, they are also included in the 'illrequests' API response. * api/v1/swagger/paths/illrequests.json: - Add 'requested_partners' as an 'embed' enum * Koha/Illrequest.pm: - Add 'requested_partners' accessor calling optional backend 'get_requested_partners' method. - Store requested partners upon email send, calling optional backend 'set_requested_partners' method. - Add 'requested_parners' embed to overloaded TO_JSON method. * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: - Add 'requested_partners' embed to illrequests API call - Add render function for "Additional status" datatables column - Add display of requested partner email addresses to illlist table - Add display of requested partner email addresses to illview display To test: 1) Enable Interlibrary loans 2) Add a backend that supports sending requests to partners, e.g. FreeForm 3) Set up at least one partner 4) Create an ILL request 5) Send request to partner(s) 6) Observe partner(s) email address(es) are displayed in "View ILL requests" view 7) Observe partner(s) email address(es) are displayed in "Manage ILL request" view Signed-off-by: mmg at interleaf.ie https://bugs.koha-community.org/show_bug.cgi?id=20653 Bug 20563: (follow-up) Fix requested partners As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563#c10 Thanks for the suggestion on merging the "Status" and "Additional status" columns, looks much better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:29:00 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82512|0 |1 is obsolete| | --- Comment #22 from Andrew Isherwood --- Created attachment 84696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84696&action=edit Bug 20563: (follow-up) Add unit test Test that requested partners are returned in API response when requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:31:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:31:34 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd hashes passwords with MD5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Group|Koha security | QA Contact| |testopia at bugs.koha-communit | |y.org CC| |robin at catalyst.net.nz Component|Koha |Command-line Utilities Version|unspecified |master Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:32:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:32:43 +0000 Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:38:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:38:12 +0000 Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be specified per instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- I prefer not to change the configuration in 17.11.x since its oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:40:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:40:42 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:41:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:41:36 +0000 Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:41:52 +0000 Subject: [Koha-bugs] [Bug 22262] text/javascript responses should be compressed by Apache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22262 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:44:06 +0000 Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated delete_unverified_opac_registrations.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20856 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:44:06 +0000 Subject: [Koha-bugs] [Bug 20856] Restore ability to delete unverified self registrations after x hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21855 CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS --- Is this obsolete since Bug 21855 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:44:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:44:38 +0000 Subject: [Koha-bugs] [Bug 21808] Field 711 is not handled correctly in showAuthor XSLT for relator term or code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21808 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82418|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 84699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84699&action=edit Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code The test should check $4 or $e for fields ne 111,711. And should check $4 or $j for 111,711. Test plan: Edit a record, add a meeting in 711 without $4 but with $j. Without this patch the term is not visible, with this patch it is. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:44:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:44:35 +0000 Subject: [Koha-bugs] [Bug 21808] Field 711 is not handled correctly in showAuthor XSLT for relator term or code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21808 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:45:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:45:49 +0000 Subject: [Koha-bugs] [Bug 21808] Field 711 is not handled correctly in showAuthor XSLT for relator term or code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21808 --- Comment #4 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #3) > Signed-off-by: Kyle M Hall Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:46:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:46:25 +0000 Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated delete_unverified_opac_registrations.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |13049 --- Comment #10 from Fridolin SOMERS --- The cronjob delete_unverified_opac_registrations.pl has been deprecated in favor of cleanup_database by Bug 13049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 [Bug 13049] Merge selfreg cron jobs into cleanup_database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:46:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:46:25 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 [Bug 21855] Remove mention of deprecated delete_unverified_opac_registrations.pl cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:48:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:48:21 +0000 Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated delete_unverified_opac_registrations.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS --- I prefer not to apply to 17.11.x since its oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:51:09 +0000 Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:56:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:56:03 +0000 Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds (maxoutstanding warning) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 13:58:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 12:58:45 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 --- Comment #9 from Martin Renvoize --- Hi Katrin... So the first patch doesn't actually 'add' a new term but rather keeps the existing terminology.. and you are entirely correct that it's not translatable as it's stored in the database as data. I personally would like to ditch the 'description' field entirely at some point and rather use code and then translatable descriptions at the template level further down the call path.. But I didn't want to introduce too many changes in one go (these descriptions may already be in use for reports for example). The second patch is a 'code' and I thought matched current guidelines.. I can happily rename that one to `Hold Fee` though.. would that make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:06:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:06:00 +0000 Subject: [Koha-bugs] [Bug 22252] Status messages returned by Mana are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22252 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:10:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:10:24 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |In Discussion --- Comment #10 from Nick Clemens --- I missed this one and filed 22260 I am wondering if one situation is preferable to the other (subquery vs adding all fields to group by) Bug 20182 and 21723 imply there may be some issues here - can we get some opinions here on the best way to fix these situations? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:10:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:10:52 +0000 Subject: [Koha-bugs] [Bug 22260] Incorrect GROUP BY in spent and ordered pages in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22260 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21622 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:10:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:10:52 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22260, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21723 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:10:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:10:52 +0000 Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of memory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21622 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:11:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:11:22 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:11:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:11:23 +0000 Subject: [Koha-bugs] [Bug 22247] Koha::IssuingRule->get_effective_issuing_rule has no hard fallback In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22247 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:11:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:11:38 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:11:45 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:12:45 +0000 Subject: [Koha-bugs] [Bug 22226] Add status information to Z39.50 server administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22226 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:13:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:13:13 +0000 Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:14:52 +0000 Subject: [Koha-bugs] [Bug 22261] Revise style of DataTables menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:15:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:15:56 +0000 Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require privileged credentials [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:17:47 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84143|0 |1 is obsolete| | --- Comment #21 from Owen Leonard --- Created attachment 84700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84700&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:18:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:18:10 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:18:17 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:18:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:18:18 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:18:23 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84700|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:19:02 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #22 from Owen Leonard --- Created attachment 84701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84701&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:18:59 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:19:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:19:06 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #23 from Owen Leonard --- Created attachment 84702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84702&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:31:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:31:25 +0000 Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED CC| |josef.moravec at gmail.com Resolution|--- |DUPLICATE --- Comment #6 from Josef Moravec --- (In reply to Katrin Fischer from comment #3) > Owen, I think this might be in conflict with your big clean-up patch? It definitely is. Owen's patch fixes this typo and do much more ;) *** This bug has been marked as a duplicate of bug 22196 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:31:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:31:25 +0000 Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com --- Comment #11 from Josef Moravec --- *** Bug 22244 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:42:22 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #12 from Owen Leonard --- (In reply to Katrin Fischer from comment #9) > Hi Owen, I am passing QA on this, but can I ask you to please complete the > cookie documentation on the wiki according to coding guidelines? Done. Let me know if I need to provide more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:48:58 +0000 Subject: [Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Failed QA --- Comment #14 from Nick Clemens --- Tests for changes to HoldTitle? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 14:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 13:59:10 +0000 Subject: [Koha-bugs] [Bug 22268] New: Data displayed in request list datatable is not sanitized Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 Bug ID: 22268 Summary: Data displayed in request list datatable is not sanitized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- Request data displayed in the "Request view" or similar views is sanitized by the html filter in the template. However, the main request list table is generated via Datatables and is not sanitized. This can be demonstrated by entering a malicious string, such as: Into the request notes field, then displaying the requests table. I've not yet investigated if column data that is generated via render functions is affected, or whether it's just the columns that are passed through by Datatables. Investigate how this has been addressed elsewhere in Koha. Also, possible mitigations can be seen here: https://datatables.net/manual/security -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:01:02 +0000 Subject: [Koha-bugs] [Bug 22268] Data displayed in request list datatable is not sanitized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20600 Depends on| |20640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:01:02 +0000 Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 [Bug 22268] Data displayed in request list datatable is not sanitized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:01:02 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 [Bug 22268] Data displayed in request list datatable is not sanitized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:01:52 +0000 Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20640 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:01:52 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:02:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:02:27 +0000 Subject: [Koha-bugs] [Bug 22268] Data displayed in request list datatable is not sanitized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:06:18 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |In Discussion --- Comment #15 from Nick Clemens --- This seems to be the same code in two scripts - any chance we could move this to a subroutine? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:09:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:09:11 +0000 Subject: [Koha-bugs] [Bug 18637] Handle Free Text vendor notes on Edifact Quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18637 imelda.bennis at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imelda.bennis at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:09:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:09:47 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 imelda.bennis at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imelda.bennis at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:10:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:10:16 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 imelda.bennis at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imelda.bennis at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 4 15:15:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Feb 2019 14:15:15 +0000 Subject: [Koha-bugs] [Bug 20102] Remove attribute "text/css" for