[Koha-bugs] [Bug 22236] Translation should generate tags with consistent attribute order

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84652|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84655&action=edit
Bug 22236: Translation should generate tags with consistent attribute order

When running misc/translator/translate, the order of attributes in the
translated templates is not consistent and may vary. This is caused by the
random order of hash keys in perl.

This causes things like this in run 1:
<input type="submit" class="btn" value="Plaats aanvraag" />
And this in run 2:
<input value="Plaats aanvraag" type="submit" class="btn" />
As you can see, there is actually no difference apart from the order.

When comparing the result of various translation runs, I would rather get rid
of such noise and only see the real changes.

The needed change is not trivial to find, but only requires a simple addition
to a sort operation in tmpl_process3.pl. The current sort only makes sure that
the '/' comes at the end. We should sort the names of the keys too when this
value is 0 (just meaning: no end tag symbol).

Test plan:
[1] Run a translation without this patch and set a few templates aside.
[2] Run a translation with this patch.
[3] Run a compare (diff) on the templates copied in step 1. Verify that the
    only changes are found in the sort order of attributes in html tags.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.