[Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #9)
> Hi Katrin...
> 
> So the first patch doesn't actually 'add' a new term but rather keeps the
> existing terminology.. and you are entirely correct that it's not
> translatable as it's stored in the database as data.  I personally would
> like to ditch the 'description' field entirely at some point and rather use
> code and then translatable descriptions at the template level further down
> the call path.. But I didn't want to introduce too many changes in one go
> (these descriptions may already be in use for reports for example).

My mistake here was that I thought it introduced the "code" - it doesn't. So I
am fine with continuing with clean-up later. A lot of times it's better to get
things right from the beginning, because things get much harder once people
start using things (like you said with reports)

Description is less heavily used than it was in 3.0 or 3.2 these days as there
was already an attempt to move it into templates. We should continue that and
clean up all remaining (see bug 21953 in that context too)

> The second patch is a 'code' and I thought matched current guidelines.. I
> can happily rename that one to `Hold Fee` though.. would that make sense?

Guidelines say: terminology as GUI = so reserve should be hold and then there
is capitalization... but current codes don't follow coding guidelines in some
cases already - I will leave it up to you and Tomas. But as we are trying to
get things right for API, maybe switching to Hold if easily possible would be
good.

-- 
You are receiving this mail because:
You are watching all bug changes.