[Koha-bugs] [Bug 21444] Permanent location should show with cart location - returns.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher,

I'have tested it and it works nicely. I wonder if it should be Book cart
(permanent location) as the first is the current... but I think both work.

But I'd like to ask you to move the display logic, like setting the () to the
template.

I have to say that I am confused by all the checking before your patch and
after - but I notice it's different than before?


-        $ri{'location'} = $shelflocations->{$shelfcode} if ( defined(
$shelfcode ) && defined($shelflocations) && exists(
$shelflocations->{$shelfcode} ) );
+        my $permshelfcode = $ri{'permlocation'};
+        $ri{'location'} = ( $shelflocations->{$permshelfcode} ne '' ) ?
$shelflocations->{$permshelfcode} : ( $permshelfcode ) ? $permshelfcode :
undef;
+        $ri{'location'} .= ( ( $shelflocations->{$shelfcode} ne '' ) && (
$shelfcode ne $permshelfcode ) ) ? ' (' . $shelflocations->{$shelfcode} . ')' :
( ( $shelfcode ) && ( $shelfcode ne $permshelfcode ) ) ? ' (' . $shelfcode .
')' : undef;

-- 
You are receiving this mail because:
You are watching all bug changes.