[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Cook from comment #2)
> (In reply to Jonathan Druart from comment #1)
> > Done with a script, see
> >   commit 582502644801b44595497caf6bbee449f0347238
> >   Bug 21526: uri escape TT variables when used in 'a href'
> > We may need to adjust some occurrences manually.
> 
> I'm not sure what you're saying, Jonathan. Do you mean that the filter was
> added by the script and that we need to remove the filters manually?
> 
> If so, what would prevent the filters from being re-added by a script in the
> future?

Did you read the commit message and the bug description?
I wrote a script to guess what needed to be escaped correctly, in <a
href=/uri?param=[% value %]>, 'value' must be uri escaped, not html escaped.

This is true in ~90% of the situations, others (specific cases) need to be
handled separately and fixed manually.
If you found one you can provide a patch and I will test it.

-- 
You are receiving this mail because:
You are watching all bug changes.