From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 22:54:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 21:54:06 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-zA0OBvb5Cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 22:54:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 21:54:09 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-fyZnQrYKoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83465|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83560&action=edit
Bug 22034: Handle default framework for MARC view with framework

To test:

- Create a record in any framework that is not default
- Search for the record in your catalog
- Switch to the MARC tab
- Change framework pull down to default on top
- Note the page reloads and the framework stay default
- Verify it works for other frameworks

Also test the "labeled MARC" view (you will need the pref viewLabeledMARC
turned on)

Signed-off-by: Nazl? ?etin <nazli at devinim.com.tr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:02:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:02:13 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-1vhi4h0BMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:02:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:02:18 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-zTClcUJRkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83286|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83561&action=edit
Bug 22007: Remove html filters when KohaDates called with a parameter

Bug 13618 took care of the KohaDates output but not if it is called
with a parameter (eg. [% var | $KohaDates with_hours => 1 %]).

We could avoid unnecessary processing by removing the extra html filter.

Patch generated with the following command:
  % perl -p -i -e 's/KohaDates([^%\|]*)\s?\|\s?html\s?/KohaDates $1/g' **/*.inc
**/*.tt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:02:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:02:22 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-CrLUS6kQu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83287|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83562&action=edit
Bug 22007: Handle safe filtered output (KohaDates)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:02:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:02:26 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-DTqKMQZCTp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83288|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83563&action=edit
Bug 22007: Also handle Price and HtmlTags

Those 2 filters should return safe output as well

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:02:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:02:30 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-bw2OJTS7G5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83289|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83564&action=edit
Bug 22007: Generated with add_missing_filters.pl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:05:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:05:39 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-p5P7zTFrON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:05:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:05:42 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-7q1wj5R82M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83239|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83565&action=edit
Bug 21990: Replace dialog .error with .alert

<div class="dialog error"> will display a div without background color, the
correct class is "dialog alert".

https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages

Test plan:
Hit /cgi-bin/koha/acqui/parcel.pl
Notice the background color change with and without this patch

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:06:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:06:15 +0000
Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21953-70-ntesNoZX9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr
                   |ity.org                     |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:10:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:10:29 +0000
Subject: [Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not
	working
In-Reply-To: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21928-70-CZgqjNowN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:10:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:10:33 +0000
Subject: [Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not
	working
In-Reply-To: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21928-70-XPriVJv5l8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83281|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83566&action=edit
Bug 21928: (bug 18789 follow-up) Fix CircAutoPrintQuickSlip=clear

caused by commit 105b3e10e8b31b7de6d733e676c3e661a39b1280

bug 18789

To recreate:
1 - Set CircAutoPrintQuickSlip to 'clear'
2 - Bring up a patron in circulation
3 - Click in checkout box and hit enter to submit empty
4 - Patron is partially loaded

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:11:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:11:26 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-ooOpLUA4Pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:17:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:17:42 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-i4g59STNO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:17:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:17:46 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-KMMgx6zFJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83283|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83567&action=edit
Bug 21802: Align fieldset with accordion headers when editing notice's template

Test plan:
Regenerate the css using `yarn css`
Edit a notice's template and confirm that the fieldsets are aligned with
the accordion headers

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:21:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:21:48 +0000
Subject: [Koha-bugs] [Bug 21797] Update two-column templates with Bootstrap
 grid: Acquisitions part 5
In-Reply-To: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21797-70-dnZezojCAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21797

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:21:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:21:52 +0000
Subject: [Koha-bugs] [Bug 21797] Update two-column templates with Bootstrap
 grid: Acquisitions part 5
In-Reply-To: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21797-70-jojoFRWBlD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21797

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83302|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83568&action=edit
Bug 21797: Update two-column templates with Bootstrap grid: Acquisitions part 5

This patch adds or corrects Bootstrap grids on three
acquisitions-related templates.

To test, apply the patch and confirm that these pages look correct and
adjust well to various browser widths:

- Acquisitions -> Vendor -> Basket -> View
- Acquisitions -> Vendor -> Details
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a new
  (empty) record

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:30:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:30:13 +0000
Subject: [Koha-bugs] [Bug 22054] New: Display a nicer error message when
 trying to renew an on-site checkout from renew page
Message-ID: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

            Bug ID: 22054
           Summary: Display a nicer error message when trying to renew an
                    on-site checkout from renew page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

To test:

1) Enable OnSiteCheckouts system preference
2) Checkout an item checking the onsite checkout checkbos in more options
3) Go to circulation > pending on-site checkouts
4) Verify the checkout shows
5) Go to circulation > renew
6) Try to renew the on-site checkout using the barcode
7) Verify display:

onsite_checkout  Continue without renewing

onsite_checkout reads like a code and should be replaced with a proper message.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:34:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:34:32 +0000
Subject: [Koha-bugs] [Bug 21442] Switch two-column templates to Bootstrap
 grid: Circulation part 1
In-Reply-To: <bug-21442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21442-70-bMrUiMs5pA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83313|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83569&action=edit
Bug 21442: Update two-column templates with Bootstrap grid: Circulation part 1

This patch modifies several circulation templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Circulation -> Pending on-site checkouts (enable OnSiteCheckouts
   preference).
    - Test with the CircSidebar system preference both on and off
 - Circulation -> Overdues
 - Circulation -> Holds to pull
 - Circulation -> Renew
    - Test with the CircSidebar system preference both on and off
 - Circulation -> Bibliographic detail page -> Request article (enable
   ArticleRequests system preferences)
 - Circulation -> Hold ratios

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:43:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:43:22 +0000
Subject: [Koha-bugs] [Bug 21785] Add column configuration to hold ratios
	report
In-Reply-To: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21785-70-ILWX5h25uQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:43:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:43:25 +0000
Subject: [Koha-bugs] [Bug 21785] Add column configuration to hold ratios
	report
In-Reply-To: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21785-70-yuum5eAVUX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83298|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83570&action=edit
Bug 21785: Add columns configuration to hold ratios report

This patch adds column configuration to the hold ratios report
DataTable.

This patch also amends some JavaScript and markup related to some
obsolete jQuery syntax: A hover function was being used to change an
element's style on hover. It has been removed in favor of using a link
and CSS>

To test, apply the patch and view the hold ratios report using a ratio
which will return multiple results. Confirm that DataTables controls
work correctly: Paging, search, column visibility, export and print.

Click a number in the "hold ratio" column of the table and verify that
it populates the "hold ratio" field in the "refine results" form in the
sidebar.

Test setting default column configurations in Administration -> Columns
settings.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:46:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:46:52 +0000
Subject: [Koha-bugs] [Bug 22055] New: When ordering from hold ratio report
 link to order is lost when changing filters
Message-ID: <bug-22055-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22055

            Bug ID: 22055
           Summary: When ordering from hold ratio report link to order is
                    lost when changing filters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When creating an order from the 'hold ratio report' the links to create orders
get lost when filters like the hold ratio are changed.

To test:
- Place a few holds on a record (at least 3 on a record with 1 item)
- Create a new order/basket in acq
- Create a new order line using '... from hold ratio report'
- Verify the last column of the table displays a link to place an order
- Change the filter on the left side, like lower the hold ratio
- Verify the order links are no longer displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:58:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:58:37 +0000
Subject: [Koha-bugs] [Bug 21672] Switch templates to Bootstrap grid: Various
In-Reply-To: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21672-70-a482H6eIzg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21672

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  1 23:58:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 22:58:40 +0000
Subject: [Koha-bugs] [Bug 21672] Switch templates to Bootstrap grid: Various
In-Reply-To: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21672-70-RUGEPRpuqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21672

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83294|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83571&action=edit
Bug 21672: Switch templates to Bootstrap grid: Various

This patch modifies various templates to add or improve coverage of the
Bootstrap grid.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Item circulation alerts
 - Authorities -> Authorities search -> Merge records
 - Catalog -> Bibliographic details -> Rota (StockRotation must be
   enabled)
 - Tools -> News: Main and add/edit view

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 00:02:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 23:02:34 +0000
Subject: [Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the
	purpose
In-Reply-To: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21578-70-UxxIKXYIYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 00:02:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Jan 2019 23:02:38 +0000
Subject: [Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the
	purpose
In-Reply-To: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21578-70-Byf0FXYAsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82982|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83572&action=edit
Bug 21578: Terminology changes in patron's account section (staff)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 01:08:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 00:08:46 +0000
Subject: [Koha-bugs] [Bug 21558] Plugins: Make it possible to disable
	installed plugins
In-Reply-To: <bug-21558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21558-70-rLlNsVInXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21558

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 01:09:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 00:09:02 +0000
Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins
In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22053-70-PxdUCbQDoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 06:48:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 05:48:39 +0000
Subject: [Koha-bugs] [Bug 22056] New: Remove test/search.pl
Message-ID: <bug-22056-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056

            Bug ID: 22056
           Summary: Remove test/search.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

As far as I can tell, the "test/search.pl" script isn't used for anything and
can be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 08:13:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 07:13:11 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-itSojSFzzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen,

working through the test plan using Chrome and Firefox on Ubuntu:


- Patrons -> New patron
       - Test before and after expanding the patron search options at the
         top of the page
       - Test editing a patron too

The floating toolbar doesn't work here for me in either browser. The toolbar
stays fixed when scrolling. 

Lists -> View list
- Tools -> Label creator -> New label batch -> Add items -> Search ->
       Results
- Open the plugin window for the 008 field

Would float in Firefox, but not in Chrome for me. Cleared the cache... maybe
someone else can have a look?

All other toolbars behaved as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 08:21:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 07:21:41 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-brw5dYF3lm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Depends on a bug waiting for signoff. Moving to BLOCKED.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 08:22:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 07:22:16 +0000
Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
In-Reply-To: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22046-70-MWYnwKNsYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I haven't looked at the patch but might be worth keeping in mind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 08:30:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 07:30:07 +0000
Subject: [Koha-bugs] [Bug 21577] Enable Koha to act as Shibboleth identity
	provider
In-Reply-To: <bug-21577-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21577-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21577-70-P0UkD6PxSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21577

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Recently, I've been thinking about using Keycloak (https://www.keycloak.org/)
as a SAML/OpenID Connect identity provider for Koha, but I suppose Koha is the
thing that is acquiring the user information, so maybe it could make sense
having it as the identity provider...

...but I'm curious about your use case. I don't think I understand.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 08:30:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 07:30:55 +0000
Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets
In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15774-70-QkgQe94zRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:09:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:09:21 +0000
Subject: [Koha-bugs] [Bug 21962] The `searching entire record` option in
 authority searches is currently failing
In-Reply-To: <bug-21962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21962-70-V5ufL3yHya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

Note that backport to 18.05.x created a followup :
Bug 21962: (RMaint follow-up) Fixed bad rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:23:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:23:48 +0000
Subject: [Koha-bugs] [Bug 21849] Offsets not stored correctly in
	_FixOverduesOnReturn
In-Reply-To: <bug-21849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21849-70-LwXiJT2cQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:25:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:25:29 +0000
Subject: [Koha-bugs] [Bug 21908] biblio_metadata is missing from the
 rebuild_zebra.pl tables list
In-Reply-To: <bug-21908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21908-70-KOdMUI46If@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:31:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:31:17 +0000
Subject: [Koha-bugs] [Bug 21277] fr-CA translation for notices in
	sample_notices.sql
In-Reply-To: <bug-21277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21277-70-oEzx6qfOhc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21277

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Since its for new install, I dont backport to 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:31:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:31:40 +0000
Subject: [Koha-bugs] [Bug 21796] Patron Restriction do not restrict
 checkouts if patron also has a fee/fine on their account
In-Reply-To: <bug-21796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21796-70-xAIdIEqpVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:31:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:31:59 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
	lost item fees
In-Reply-To: <bug-18677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18677-70-WW4ZunG5v7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:32:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:32:15 +0000
Subject: [Koha-bugs] [Bug 20598] Accruing fines not closed out by
 longoverdue.pl if WhenLostForgiveFine is not enabled
In-Reply-To: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20598-70-iJ9K0M40Lw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:33:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:33:03 +0000
Subject: [Koha-bugs] [Bug 21815] Rephrase
 HidePersonalPatronDetailOnCirculation a little bit
In-Reply-To: <bug-21815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21815-70-0yxe4ABjjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21815

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I prefer not to change text in oldoldstable 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:35:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:35:24 +0000
Subject: [Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search
 based on permissions
In-Reply-To: <bug-21778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21778-70-aZrGcaZz74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:35:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:35:40 +0000
Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by
 cardnumber if userid exists in file and in Koha
In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21465-70-BALVG2KkKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:36:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:36:44 +0000
Subject: [Koha-bugs] [Bug 21644] UNIMARC XSLT display of 210 in intranet
In-Reply-To: <bug-21644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21644-70-U7VmUO9fVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21644

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:37:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:37:33 +0000
Subject: [Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
In-Reply-To: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21896-70-6CVEiabKJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:37:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:37:36 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-zNRuBemCDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915
Bug 21915 depends on bug 21896, which changed state.

Bug 21896 Summary: Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:37:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:37:34 +0000
Subject: [Koha-bugs] [Bug 18805] Currently it is impossible to apply credits
 against debits in patron accounts
In-Reply-To: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18805-70-qGIT0GEJum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805
Bug 18805 depends on bug 21896, which changed state.

Bug 21896 Summary: Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:37:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:37:52 +0000
Subject: [Koha-bugs] [Bug 18805] Currently it is impossible to apply credits
 against debits in patron accounts
In-Reply-To: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18805-70-3ZtEPJ6aDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:37:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:37:54 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-XhQVKH3cou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Bug 14825 depends on bug 18805, which changed state.

Bug 18805 Summary: Currently it is impossible to apply credits against debits in patron accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:38:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:38:09 +0000
Subject: [Koha-bugs] [Bug 21853] Internal software error when exporting
 basket group as PDF with Perl > 5.24.1
In-Reply-To: <bug-21853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21853-70-nc7kmPMwUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21853

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:38:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:38:24 +0000
Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration
 to overdues report
In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21852-70-8ojH2AGoBP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852
Bug 21852 depends on bug 21837, which changed state.

Bug 21837 Summary: Overdues report shoudln't set homebranchfilter as holdingbranchfilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:38:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:38:35 +0000
Subject: [Koha-bugs] [Bug 21854] Patron category is not showing during batch
	modification
In-Reply-To: <bug-21854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21854-70-VhIYbpxPTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:38:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:38:48 +0000
Subject: [Koha-bugs] [Bug 21819] Marc modification templates action always
 checks Regexp checkbox
In-Reply-To: <bug-21819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21819-70-jKnEemvjIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21819

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:38:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:38:48 +0000
Subject: [Koha-bugs] [Bug 21867] Replace remaining document.element.onchange
 calls in marc_modification_templates.js
In-Reply-To: <bug-21867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21867-70-6lGEgK1Vjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21867
Bug 21867 depends on bug 21819, which changed state.

Bug 21819 Summary: Marc modification templates action always checks Regexp checkbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21819

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:38:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:38:23 +0000
Subject: [Koha-bugs] [Bug 21837] Overdues report shoudln't set
 homebranchfilter as holdingbranchfilter
In-Reply-To: <bug-21837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21837-70-JwpN4MZzZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:39:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:39:01 +0000
Subject: [Koha-bugs] [Bug 21867] Replace remaining document.element.onchange
 calls in marc_modification_templates.js
In-Reply-To: <bug-21867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21867-70-lGtRX9RhB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21867

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:39:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:39:15 +0000
Subject: [Koha-bugs] [Bug 21861] The MARC modification template actions
 editor does not always validate user input
In-Reply-To: <bug-21861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21861-70-9l6kPCZp5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21861

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:39:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:39:01 +0000
Subject: [Koha-bugs] [Bug 21861] The MARC modification template actions
 editor does not always validate user input
In-Reply-To: <bug-21861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21861-70-M2HJVLUKGe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21861
Bug 21861 depends on bug 21867, which changed state.

Bug 21867 Summary: Replace remaining document.element.onchange calls in marc_modification_templates.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21867

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:39:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:39:32 +0000
Subject: [Koha-bugs] [Bug 21874] Encoding broken in list and cart email
	subjects
In-Reply-To: <bug-21874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21874-70-oX3avNIV8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21874

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:39:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:39:53 +0000
Subject: [Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized
 values categories
In-Reply-To: <bug-21730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21730-70-C7jtosUexS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:40:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:40:45 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.11.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-m9okn654b7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:41:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:41:19 +0000
Subject: [Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache
In-Reply-To: <bug-21955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21955-70-s1Umctp5UI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:42:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:42:13 +0000
Subject: [Koha-bugs] [Bug 21961] Typo in permission keeps Did you mean?
 config from showing up
In-Reply-To: <bug-21961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21961-70-clInT51SR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:42:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:42:29 +0000
Subject: [Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in
 _FixAccountForLostAndReturned
In-Reply-To: <bug-21759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21759-70-xUE8lcw6ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:43:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:43:03 +0000
Subject: [Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look
 for debits/credits by checking 'amount'
In-Reply-To: <bug-21969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21969-70-8AUoj15xXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:43:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:43:04 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-pzAAoF9F8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915
Bug 21915 depends on bug 21969, which changed state.

Bug 21969 Summary: Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:42:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:42:46 +0000
Subject: [Koha-bugs] [Bug 21947] Filtering order generates html in notes
In-Reply-To: <bug-21947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21947-70-ZKnvXfrvHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:43:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:43:34 +0000
Subject: [Koha-bugs] [Bug 21950] Searching with 'accents' breaks on
 navigating to the second page of results
In-Reply-To: <bug-21950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21950-70-9NVfjoIT1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:47:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:47:35 +0000
Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has HTML tag br showing
In-Reply-To: <bug-15717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15717-70-ss9Oj4ol4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:48:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:48:36 +0000
Subject: [Koha-bugs] [Bug 21596] Handle default values when storing
	Koha::Patron
In-Reply-To: <bug-21596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21596-70-0oWcby2fs8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:48:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:48:36 +0000
Subject: [Koha-bugs] [Bug 21597] Test suite is still failing with new
	default SQL modes
In-Reply-To: <bug-21597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21597-70-N386uJtqqf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597
Bug 21597 depends on bug 21596, which changed state.

Bug 21596 Summary: Handle default values when storing Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:48:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:48:37 +0000
Subject: [Koha-bugs] [Bug 21618] side-effects with timestamp columns with
 Test::DBIx::Class
In-Reply-To: <bug-21618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21618-70-6Q0DvGszh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21618
Bug 21618 depends on bug 21596, which changed state.

Bug 21596 Summary: Handle default values when storing Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:48:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:48:54 +0000
Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's
	account
In-Reply-To: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20944-70-aOFSyy3KXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:48:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:48:56 +0000
Subject: [Koha-bugs] [Bug 21786] Routes for credits should include library_id
In-Reply-To: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21786-70-kVQoTpbihZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786
Bug 21786 depends on bug 20944, which changed state.

Bug 20944 Summary: Add routes to add credits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:48:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:48:55 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-ZUhZM95S9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165
Bug 15165 depends on bug 20944, which changed state.

Bug 20944 Summary: Add routes to add credits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:50:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:50:05 +0000
Subject: [Koha-bugs] [Bug 21576] Add a developer script to automatically fix
 missing filters
In-Reply-To: <bug-21576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21576-70-JlTaaphkW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Resolved ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:50:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:50:32 +0000
Subject: [Koha-bugs] [Bug 20486] Add --marc_conditions option to
	export_records.pl
In-Reply-To: <bug-20486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20486-70-5rANVd0UY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:57:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:57:30 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-JvJn4O4F9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21465


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465
[Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists
in file and in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:57:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:57:30 +0000
Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by
 cardnumber if userid exists in file and in Koha
In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21465-70-Q3KHM5TOda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12598


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598
[Bug 12598] New misc/import_borrowers.pl command line tool
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 10:58:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 09:58:58 +0000
Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by
 cardnumber if userid exists in file and in Koha
In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21465-70-pytytHOVTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 12598 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:00:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:00:09 +0000
Subject: [Koha-bugs] [Bug 21991] Displaying more rows on report results does
 not work for reports with parameters
In-Reply-To: <bug-21991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21991-70-upXQ1dEho6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:02:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:02:28 +0000
Subject: [Koha-bugs] [Bug 21991] Displaying more rows on report results does
 not work for reports with parameters
In-Reply-To: <bug-21991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21991-70-lhbbcrn5vG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 9634 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:03:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:03:31 +0000
Subject: [Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running
 updatedatabase.pl script
In-Reply-To: <bug-21931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21931-70-XtzT8O3DYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:14:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:14:44 +0000
Subject: [Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in
	several places
In-Reply-To: <bug-21986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21986-70-Y68AowXtsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:22:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:22:42 +0000
Subject: [Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
In-Reply-To: <bug-14334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14334-70-BRsLVh3iwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #39 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:31:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:31:25 +0000
Subject: [Koha-bugs] [Bug 21984] Unable to load second page of results for
 reports with reused parameters
In-Reply-To: <bug-21984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21984-70-fwLIwjaVnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 9634 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:40:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:40:46 +0000
Subject: [Koha-bugs] [Bug 22057] New: OpenLibrarySearch
Message-ID: <bug-22057-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22057

            Bug ID: 22057
           Summary: OpenLibrarySearch
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: vbovictor at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

How to link other sources in the OpenLibrarySearch option?
I would like to link to this resource other sources such as
https://www.wdl.org/pt/ and others

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:43:27 +0000
Subject: [Koha-bugs] [Bug 21635] Incorrect GROUP BY clause in batchMod.pl
In-Reply-To: <bug-21635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21635-70-KLwHqkWsiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22022


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22022
[Bug 22022] Authorised values on the batch item modification page are not
displayed in order (order by code, not lib)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:43:27 +0000
Subject: [Koha-bugs] [Bug 22022] Authorised values on the batch item
 modification page are not displayed in order (order by code, not lib)
In-Reply-To: <bug-22022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22022-70-S0H2gKfmXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22022

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Depends on|                            |21635
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Caused by Bug 21635 not in 17.11.x


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635
[Bug 21635] Incorrect GROUP BY clause in batchMod.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 11:46:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 10:46:59 +0000
Subject: [Koha-bugs] [Bug 21848] Resolve unac_string warning from
	Circulation.t
In-Reply-To: <bug-21848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21848-70-gbhSlNpR5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 12:13:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 11:13:01 +0000
Subject: [Koha-bugs] [Bug 22057] OpenLibrarySearch
In-Reply-To: <bug-22057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22057-70-ug6w3AU89X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22057

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi victor,

please ask your question on the mailing list
(https://koha-community.org/support/koha-mailing-lists/) - bugzilla is only
used for bugs and enhancement requests. Support, installation and general
questions should always be asked on the mailing list where a lot more people
will read them and be able to answer and help. 


Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 12:19:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 11:19:27 +0000
Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and
 a filter presence test to Koha
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-Zmc4vBXVVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Mark Alexander <marka at pobox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22058


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058
[Bug 22058] OPAC holdings table shows &nbsp; instead of blank
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 12:19:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 11:19:27 +0000
Subject: [Koha-bugs] [Bug 22058] New: OPAC holdings table shows &nbsp;
	instead of blank
Message-ID: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

            Bug ID: 22058
           Summary: OPAC holdings table shows &nbsp; instead of blank
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: marka at pobox.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13618
  Target Milestone: ---

Created attachment 83573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83573&action=edit
OPAC MARC view holding detail in 18.11

In the OPAC, when looking at the MARC view for an item, there is a
table at the bottom of the page showing some holding information.
Those table fields that used to be blank in 18.05 are now displaying
as "&nbsp;" (without the quotes) in 18.11.  In my particular case, the
fields that are displayed this way are:

* Withdrawn status
* Lost status
* Damaged status
* Not for loan


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Add additional template filter methods and a filter presence test
to Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 13:55:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 12:55:23 +0000
Subject: [Koha-bugs] [Bug 22059] New: Wrong exception parameters in
 Koha::Patron->set_password
Message-ID: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

            Bug ID: 22059
           Summary: Wrong exception parameters in
                    Koha::Patron->set_password
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Exception::Class requires parameters to be passed as a list instead of a
hashref. Then

this is wrong:
Koha::Exceptions::Password::TooShort->throw({ length => $password_length,
min_length => $min_length });

this is ok:
Koha::Exceptions::Password::TooShort->throw( length => $password_length,
min_length => $min_length );

This is a minor issue anyway, preventing exceptions from being stringified
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 13:55:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 12:55:36 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-DmPH5PNCVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21178
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178
[Bug 21178] Add Koha::Patron::set_password method
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 13:55:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 12:55:36 +0000
Subject: [Koha-bugs] [Bug 21178] Add Koha::Patron::set_password method
In-Reply-To: <bug-21178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21178-70-yIeBf8AdN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22059


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059
[Bug 22059] Wrong exception parameters in Koha::Patron->set_password
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 13:59:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 12:59:54 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-kCJZp32mbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83574&action=edit
Bug 22059: regression tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 13:59:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 12:59:57 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-Q7X4s4XkoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83575&action=edit
Bug 22059: Fix exception params in Koha::Patron->set_password

This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
enclosed in curly brackets.

To test:
- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail because the throw call is wrong
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
-Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:00:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:00:21 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-3Aip91cW1T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:18:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:18:00 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-DzkNaW2wTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:18:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:18:02 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-TGvn2xBusy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83574|0                           |1
        is obsolete|                            |
  Attachment #83575|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83576&action=edit
Bug 22059: regression tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:18:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:18:13 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-EyjPlBedZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83577&action=edit
Bug 22059: Fix exception params in Koha::Patron->set_password

This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
enclosed in curly brackets.

To test:
- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail because the throw call is wrong
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
-Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:21:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:21:02 +0000
Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to
 often set to Y incorrectly
In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22043-70-rMADB2NhZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:21:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:21:05 +0000
Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to
 often set to Y incorrectly
In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22043-70-Cn8I0qH6NM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83468|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83578&action=edit
Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly

If a checkin has any messages at all, even informational like LocalUse, the
alert flag ( 4th character of the response ) will be set to Y, even if we do
not prove a corresponding alert code in the CV field. We should only set the
alert flag if we are going to send a value in the CV field.If a checkin has any
messages at all, even informational like LocalUse, the alert flag ( 4th
character of the response ) will be set to Y, even if we do not prove a
corresponding alert code in the CV field. We should only set the alert flag if
we are going to send a value in the CV field.

Test Plan:
1) Set the checked_in_ok sip account flag to 1 for an account
2) Check in an already checked in item via SIP
3) Note the alert flag is set to Y
4) Apply this patch
5) Restart SIP
6) Check the item in again
7) Note the alert flag is set to N

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven at pueblolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:29:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:29:06 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-TH2rJZKItZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82626|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:29:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:29:14 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-b3GUogxs1r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82627|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:29:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:29:22 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-kHuA5YRQKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82628|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:28:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:28:58 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-9RupbzfidK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82625|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:31:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:31:20 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-ACeRuF0N54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:31:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:31:51 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-kmPeTkxQLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22059


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059
[Bug 22059] Wrong exception parameters in Koha::Patron->set_password
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:31:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:31:51 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-zMACILYSnj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
[Bug 17006] Add route to change patron's password
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:32:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:32:24 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-eqxnApuJhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #65 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83579&action=edit
Bug 17006: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:32:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:32:32 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-Cezx2p2K0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #66 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83580&action=edit
Bug 17006: OpenAPI spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:32:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:32:41 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-OiiN5i77yh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #67 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83581&action=edit
Bug 17006: Add /patrons/{patron_id}/password

This patch introduces an endpoint for changing a patron's password. It
targets privileged user with the right permissions, changing some
patron's password.

To test:

- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t
=> SUCCESS: tests pass!
- Play with the different use cases highlighted by the tests, on your
favourite REST testing tool (Postman, RESTer on FF, etc).

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:37:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:37:02 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-YyEt8TrB6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #68 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
As we voted for having a /public endpoint for unprivileged routes, I simplified
the implementation and removed that use case. I will file a new bug for
implementing the on/off switch for the /public namespace, and the endpoint for
changing passwords for un-privileged users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:40:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:40:57 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-qMJ6THBTWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:41:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:41:00 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-DBvsjT6QxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83491|0                           |1
        is obsolete|                            |
  Attachment #83492|0                           |1
        is obsolete|                            |
  Attachment #83493|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83582&action=edit
Bug 22047: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:41:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:41:33 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-loHR6pKM8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83583&action=edit
Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password

This patch makes Koha::Patron->set_password expect a hashref as param
and adds support for an 'skip_validation' param to be passed. Its purpose is to
make the method skip the relevant password strength checks if required.

It targets the Auth_with_ldap.pm usage when the 'update_password' flag
is set in the configuration.

The tests on this bug cover this use case so, to test:

- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail, code doesn't work as expected
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass! Yay!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 14:41:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 13:41:35 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-folskKldxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83584&action=edit
Bug 22047: Fix opac/opac-passwd.pl call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:01:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:01:38 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-DiVb3mfqrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:01:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:01:40 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-xZZUZKpHPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83501|0                           |1
        is obsolete|                            |
  Attachment #83502|0                           |1
        is obsolete|                            |
  Attachment #83503|0                           |1
        is obsolete|                            |
  Attachment #83504|0                           |1
        is obsolete|                            |
  Attachment #83505|0                           |1
        is obsolete|                            |
  Attachment #83506|0                           |1
        is obsolete|                            |
  Attachment #83507|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83585&action=edit
Bug 22048: Use set_password in onboarding.pl

To test, verify the onboarding process sets the password correctly.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:02:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:02:28 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-ldOGvXWBWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83586&action=edit
Bug 22048: Use set_password in member-password.pl

This patch makes member-password.pl use $patron->set_password instead of
update_password. The side effect is that setting password and userid
become separate steps in the code.

For the password all the initial checks are the same, but password
strength is checked on calling set_password and an exception is thrown.
So instead of checking the password quality, we just wait for exceptions
and behave the same as before.

Bonus: you will notice I reused the initially fetched $patron object.
Things get simpler :-D

To test:
- Verify that changing the password / userid for a patron works as usual

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:02:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:02:31 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-awp90dnx5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83587&action=edit
Bug 22048: Use set_password in memberentry.pl

To test:
- Verify that changing the password and userid of a patron by globally
editing they works,

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:02:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:02:34 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-XgzrkYjuSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83588&action=edit
Bug 22048: Use set_password in create_superlibrarian.pl

Use $patron->set_password instead of update_password. In this case the
'skip_validation' param needs to be set as no password strength checks
are expected.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:02:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:02:36 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-2udWfPiDsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83589&action=edit
Bug 22048: Use set_password opac/opac-password-recovery.pl

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:02:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:02:39 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-jm9gPI512Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83590&action=edit
Bug 22048: Use set_password in tests

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Auth.t \
          t/db_dependent/Koha/Patrons.t \
          t/db_dependent/Search/History.t \
          t/db_dependent/selenium/authentication.t \
          t/db_dependent/selenium/regressions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:02:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:02:42 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-G7kunjC1gs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83591&action=edit
Bug 22048: Use set_password in Auth_with_ldap.pm

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:04:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:04:22 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-JBw55jb44f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:04:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:04:24 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-o8LB1fJXzr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83500|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83592&action=edit
Bug 21992: Remove unused Koha::Patron->update_password method

This patch removes the no longer used method.

To test:
- Apply this patch
- Run:
  $ git grep update_password
=> SUCCESS: Only references are in Auth_with_ldap.pm and not related
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:38:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:38:12 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-dQFErpgGMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:38:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:38:15 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-8kpnN8YV8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82107|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 83593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83593&action=edit
Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3

This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and go to Serials.

 - Add or edit a new subscription. The "create an item..." and "do not
   create an item..." labels should look correct.
 - Search for subscriptions
   - Select two or more subscriptions to batch edit.
     - The subscription batch edit page should look correct and adjust
       well to various browser widths.
   - View a subscription and click the "Renew" button. The subscription
     renewal pop-up window should look correct.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 15:53:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 14:53:15 +0000
Subject: [Koha-bugs] [Bug 22060] New: how to configure the tmp?
Message-ID: <bug-22060-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22060

            Bug ID: 22060
           Summary: how to configure the tmp?
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: federicoantoniopaiz at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

how to configure the tmp?, I put in koha-conf.xml and keeps checking that it is
not configured in "Home> About Koha".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:05:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:05:22 +0000
Subject: [Koha-bugs] [Bug 17978] Include 'Next available'/title level holds
 in holds count when placing holds (opac and staff)
In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17978-70-4TvTGNBW3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Circ rules will not limit   |Include 'Next
                   |holds                       |available'/title level
                   |                            |holds in holds count when
                   |                            |placing holds (opac and
                   |                            |staff)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:16:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:16:43 +0000
Subject: [Koha-bugs] [Bug 22060] how to configure the tmp?
In-Reply-To: <bug-22060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22060-70-XxASTKSXfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:21:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:21:14 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-gCyuNWOGrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This is what I was playing around with:

https://zivotdesign.com/p/#1/15223413373574

The section links would float along with the toolbar. There were some issues
with it that I was still working out, so I'll have to rebase and take another
look if it's interesting to folks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:22:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:22:18 +0000
Subject: [Koha-bugs] [Bug 21848] Resolve unac_string warning from
	Circulation.t
In-Reply-To: <bug-21848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21848-70-TXhTxWrT5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936
[Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:22:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:22:18 +0000
Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to
	Koha::Patron
In-Reply-To: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19936-70-bkKah6v0TW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21848


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848
[Bug 21848] Resolve unac_string warning from Circulation.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:22:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:22:55 +0000
Subject: [Koha-bugs] [Bug 22061] Add a /public namespace that can be
	switched on/off
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-YuCfARKL0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:22:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:22:51 +0000
Subject: [Koha-bugs] [Bug 22061] New: Add a /public namespace that can be
	switched on/off
Message-ID: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

            Bug ID: 22061
           Summary: Add a /public namespace that can be switched on/off
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:26:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:26:15 +0000
Subject: [Koha-bugs] [Bug 21848] Resolve unac_string warning from
	Circulation.t
In-Reply-To: <bug-21848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21848-70-b8LtpjjwfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Ah brakes Jenkins.

In the end the warn does not exist in 17.11.x.

Caused by Bug 19936 who moved generate_userid to Koha::Patron.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:46:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:46:21 +0000
Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
In-Reply-To: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22046-70-Jv5fXn4nbT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Cook from comment #2)
> I haven't looked at the patch but might be worth keeping in mind
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710.

I don't think it should have any effect here - this simply removes a
conditional on SearchEngine setting so that the matcher code is the same in
either scenario (the check does still happen, but in a subroutine, this removes
a second check)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 16:55:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 15:55:26 +0000
Subject: [Koha-bugs] [Bug 17291] Add <item>...</item> syntax to
	advance_notices.pl
In-Reply-To: <bug-17291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17291-70-oVlJrZ6Xsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17291

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still much wanted :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 17:20:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 16:20:11 +0000
Subject: [Koha-bugs] [Bug 22060] how to configure the tmp?
In-Reply-To: <bug-22060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22060-70-QvbaDRVADe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22060

Federico Paiz <federicoantoniopaiz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|System Administration       |Installation and upgrade
                   |                            |(command-line installer)

--- Comment #2 from Federico Paiz <federicoantoniopaiz at gmail.com> ---

I do what the documentation says but the koha tells me that the tmp is not
configured

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 17:34:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 16:34:20 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be
 useful to see on OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-iaXjQHNajd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marjorie Barry-Vila from comment #4)

> With 18.05, item_materials is not in column configuration for holdingst.
> 
> could it be added?


+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 17:36:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 16:36:54 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-jPYfRjNTOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,

ist this patch testable?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 17:50:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 16:50:53 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/18.05.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-VNEP5FHTdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 17:51:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 16:51:01 +0000
Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item
	search results
In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17748-70-kzS62RfSvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 17:50:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 16:50:54 +0000
Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm
In-Reply-To: <bug-18018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18018-70-xbbK4w18cL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018
Bug 18018 depends on bug 17111, which changed state.

Bug 17111 Summary: Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 18:13:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 17:13:34 +0000
Subject: [Koha-bugs] [Bug 22061] Add a /public namespace that can be
	switched on/off
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-s4rU44Xokz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17006

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 18:13:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 17:13:34 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-nzUaqwjHTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22061

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 18:36:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 17:36:27 +0000
Subject: [Koha-bugs] [Bug 21796] Patron Restriction do not restrict
 checkouts if patron also has a fee/fine on their account
In-Reply-To: <bug-21796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21796-70-MA8JWzVvJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:27:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:27:43 +0000
Subject: [Koha-bugs] [Bug 22062] New: Ability to link individual accounts
 into a family account/specify "family administrator"
Message-ID: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22062

            Bug ID: 22062
           Summary: Ability to link individual accounts into a family
                    account/specify "family administrator"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: atech087 at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

=======================
Reposting from Bug ID 3591 because it's over 9 years old, and I'd really like
to see this feature implemented. Linked here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3591 
=======================

I'd like a designated parent to have the ability to access all the OPAC
features that their children normally would when the latter log in to the OPAC
under their own accounts.

In other words, when a parent logs in to their own account, they will also be
able to do all of these for their children's accounts: 
(from http://koha.org/documentation/manual/3.0/opac/your-account)
View and renew items checked out
View and renew items overdue
View status of and cancel holds you have placed
View fines you owe
Submit changes to your personal details (like name or address)
Submit a change to your password
View your Reading History (also known as 'Checkout History')
Manage your purchase suggestions (view status and add)
Manage how you're notified by the library of events and due dates
Review an edit your lists

If new features are planned under 3.2, then these should also be available.

Rationale: A family administrator account would make it much easier for
families to maintain their library accounts. At present, for example, the
simple task of making a list of all family items due back would require a
parent to set up user logins for each of his/her children & log in under each
of those accounts.

Note that this should be an _option_ at the child account level. To meet
librarians' long-standing respect for patrons' privacy & intellectual freedom,
access to account information for young adults in particular may need to be
limited to that account alone (& staff of course.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:35:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:35:52 +0000
Subject: [Koha-bugs] [Bug 359] Biblio ID drill down gives 500 Internal
	Server Error
In-Reply-To: <bug-359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-359-70-pAQP6anaGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=359

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |atech087 at yahoo.com

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 22062 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:35:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:35:52 +0000
Subject: [Koha-bugs] [Bug 22062] Ability to link individual accounts into a
 family account/specify "family administrator"
In-Reply-To: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22062-70-X8T7iJm3ey@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22062

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 359 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:36:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:36:01 +0000
Subject: [Koha-bugs] [Bug 22062] Ability to link individual accounts into a
 family account/specify "family administrator"
In-Reply-To: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22062-70-rLNG713NQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22062

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 3591 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:36:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:36:01 +0000
Subject: [Koha-bugs] [Bug 3591] "Family administrator" account for OPAC
In-Reply-To: <bug-3591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3591-70-M5za9aiE9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3591

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |atech087 at yahoo.com

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 22062 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:36:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:36:32 +0000
Subject: [Koha-bugs] [Bug 22062] Ability to link individual accounts into a
 family account/specify "family administrator"
In-Reply-To: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22062-70-pYZZxiMMkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22062

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please comment on the original bug - duplicates won't make it happen faster! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 19:37:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 18:37:33 +0000
Subject: [Koha-bugs] [Bug 22062] Ability to link individual accounts into a
 family account/specify "family administrator"
In-Reply-To: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22062-70-heKlTO5gJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22062

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Indeed, easiest way to make it happen faster is to pay someone to write the
code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 20:19:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 19:19:20 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-6Pbftx66vJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21751


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
[Bug 21751] fixFloat toolbar not displaying properly in Chrome
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 20:19:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 19:19:20 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-XCY2MyVqrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED
         Depends on|                            |21813


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813
[Bug 21813] In-page JavaScript causes error on patron entry page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:02:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:02:29 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-gjdMDrGni6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:05:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:05:21 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-qyaEFtRVRV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:05:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:05:25 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-kjvgnn9puE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83582|0                           |1
        is obsolete|                            |
  Attachment #83583|0                           |1
        is obsolete|                            |
  Attachment #83584|0                           |1
        is obsolete|                            |

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83594&action=edit
Bug 22047: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:05:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:05:29 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-QxvTb7tYwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83595&action=edit
Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password

This patch makes Koha::Patron->set_password expect a hashref as param
and adds support for an 'skip_validation' param to be passed. Its purpose is to
make the method skip the relevant password strength checks if required.

It targets the Auth_with_ldap.pm usage when the 'update_password' flag
is set in the configuration.

The tests on this bug cover this use case so, to test:

- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail, code doesn't work as expected
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass! Yay!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:05:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:05:33 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-ndT7YSewo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83596&action=edit
Bug 22047: Fix opac/opac-passwd.pl call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:31:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:31:29 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-73I2GZTDiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
I must have hit the wrong bug number, apologies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:33:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:33:38 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-vfqf1P2Pl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:35 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-Hr1EbGZaTI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83585|0                           |1
        is obsolete|                            |
  Attachment #83586|0                           |1
        is obsolete|                            |
  Attachment #83587|0                           |1
        is obsolete|                            |
  Attachment #83588|0                           |1
        is obsolete|                            |
  Attachment #83589|0                           |1
        is obsolete|                            |
  Attachment #83590|0                           |1
        is obsolete|                            |
  Attachment #83591|0                           |1
        is obsolete|                            |

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83597&action=edit
Bug 22048: Use set_password in onboarding.pl

To test, verify the onboarding process sets the password correctly.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:40 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-QTwkZJOUBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83598&action=edit
Bug 22048: Use set_password in member-password.pl

This patch makes member-password.pl use $patron->set_password instead of
update_password. The side effect is that setting password and userid
become separate steps in the code.

For the password all the initial checks are the same, but password
strength is checked on calling set_password and an exception is thrown.
So instead of checking the password quality, we just wait for exceptions
and behave the same as before.

Bonus: you will notice I reused the initially fetched $patron object.
Things get simpler :-D

To test:
- Verify that changing the password / userid for a patron works as usual

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:44 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-16vKNM3seK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #17 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83599&action=edit
Bug 22048: Use set_password in memberentry.pl

To test:
- Verify that changing the password and userid of a patron by globally
editing they works,

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:47 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-ddpqxDnEUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #18 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83600&action=edit
Bug 22048: Use set_password in create_superlibrarian.pl

Use $patron->set_password instead of update_password. In this case the
'skip_validation' param needs to be set as no password strength checks
are expected.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:51 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-tsQmHL73wa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #19 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83601&action=edit
Bug 22048: Use set_password opac/opac-password-recovery.pl

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:32 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-2H8Uc49aX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:56 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-pFFF0HVV68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #20 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83602&action=edit
Bug 22048: Use set_password in tests

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Auth.t \
          t/db_dependent/Koha/Patrons.t \
          t/db_dependent/Search/History.t \
          t/db_dependent/selenium/authentication.t \
          t/db_dependent/selenium/regressions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:34:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:34:59 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-hODiLXONGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #21 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83603&action=edit
Bug 22048: Use set_password in Auth_with_ldap.pm

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:35:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:35:04 +0000
Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints
 and is never cleaned up
In-Reply-To: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13515-70-6lDWyETMm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
The update doe snot appear to be idempotent - can you check the condition?

The tests seem to cover the basic case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:39:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:39:42 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-0sIVbJnIP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:39:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:39:45 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-uSkqt7WtAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83592|0                           |1
        is obsolete|                            |

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83604&action=edit
Bug 21992: Remove unused Koha::Patron->update_password method

This patch removes the no longer used method.

To test:
- Apply this patch
- Run:
  $ git grep update_password
=> SUCCESS: Only references are in Auth_with_ldap.pm and not related
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:44:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:44:07 +0000
Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to
 often set to Y incorrectly
In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22043-70-oii6CNonRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:52:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:52:56 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-AP2R9RIGLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Pierre, which checkboxes are you referring to?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:53:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:53:52 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-JFtOAakz0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:54:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:54:17 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-wG2OO6uF8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:54:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:54:20 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-sul2r9KZwh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83593|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83605&action=edit
Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3

This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and go to Serials.

 - Add or edit a new subscription. The "create an item..." and "do not
   create an item..." labels should look correct.
 - Search for subscriptions
   - Select two or more subscriptions to batch edit.
     - The subscription batch edit page should look correct and adjust
       well to various browser widths.
   - View a subscription and click the "Renew" button. The subscription
     renewal pop-up window should look correct.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 21:55:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 20:55:08 +0000
Subject: [Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap
 grid: Patron card creator
In-Reply-To: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21438-70-aOYTbAKUMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:02:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:02:53 +0000
Subject: [Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap
 grid: Patron card creator
In-Reply-To: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21438-70-CnppEemHnL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:02:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:02:56 +0000
Subject: [Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap
 grid: Patron card creator
In-Reply-To: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21438-70-4G6RT69X7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83282|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83606&action=edit
Bug 21438: Update two-column templates with Bootstrap grid: Patron card creator

This patch modifies the patron card creator templates to use the
Bootstrap grid instead of YUI.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> patron card creator
   - Manage -> Card batches
     - Edit card batch
   - Manage -> Layouts
     - Edit layout
   - Manage -> Images
   - Manage -> Card templates
     - Edit template
   - Manage -> Printer profiles
     - Edit profile

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:07:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:07:10 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-pO9KKZFBYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #32)
> Taking the liberty of passing QA in one run.
> Nick: Only affects test suite. Multiple rebasing avoided?

It needs a simple rebase - do we not need rollback since bug 14334 - or did we
just forgot to add a rollback for the schema? t/db_dependent/Serials.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:07:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:07:38 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-c4N6IRdnmQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:07:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:07:44 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-FPpa7Goj8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83576|0                           |1
        is obsolete|                            |
  Attachment #83577|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83607&action=edit
Bug 22059: regression tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:07:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:07:47 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-lUWhOMWayH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83608&action=edit
Bug 22059: Fix exception params in Koha::Patron->set_password

This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
enclosed in curly brackets.

To test:
- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail because the throw call is wrong
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
-Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:08:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:08:12 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-1d1Dcb4PSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:09:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:09:29 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-BGoNerKKHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:09:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:09:43 +0000
Subject: [Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the
	purpose
In-Reply-To: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21578-70-jRctDXV0ht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:09:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:09:54 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-1hFXdOiEZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:10:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:10:05 +0000
Subject: [Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks
	method
In-Reply-To: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21817-70-xTovm4lkh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:10:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:10:24 +0000
Subject: [Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should
 preserve call context
In-Reply-To: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21909-70-ryEbqHsTCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:11:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:11:08 +0000
Subject: [Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not
	working
In-Reply-To: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21928-70-0Pjf92HDzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:11:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:11:21 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-1wd6Nq5rK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:12:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:12:00 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-42u2JHeKf4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:12:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:12:15 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-EEeEedSJG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:28:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:28:11 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-enCNHzoRz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Oh, should have read the test plan better!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 22:29:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 21:29:49 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-qqgsEq6nLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:26:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:26:16 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-HlN24DSA2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please, no descriptions in authorised values or prefs - these are not
translatable and break things for multi-language installations.

Better to keep configuration to behaviour if possible.

In a consortia setting with multiple branches: When is an item on hold?
- If it's on the pickup shelf
- if it has an item level hold on it

... but what about record level holds where items are available at multiple
branches?

If there are 2 holds to be pulled and there are 5 items to potentially fill the
hold - how should this be displayed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:35:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:35:00 +0000
Subject: [Koha-bugs] [Bug 7403] CataloguingLog warning incorrect
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-VHQYOlwS8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18816


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816
[Bug 18816] Make CataloguingLog work in production by preventing circulation
from spamming the log
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:35:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:35:00 +0000
Subject: [Koha-bugs] [Bug 18816] Make CataloguingLog work in production by
 preventing circulation from spamming the log
In-Reply-To: <bug-18816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18816-70-wh5WPte8qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403
[Bug 7403] CataloguingLog warning incorrect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:36:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:36:28 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-8aEnmT1977@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
            Summary|CataloguingLog warning      |Remove warning from
                   |incorrect                   |CataloguingLog system
                   |                            |preference

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The preference currently reads:

[Log|Don't log] any changes to bibliographic or item records. Since this occurs
whenever a book is checked in or out as well, it is not advisable to turn this
on. 


The second part "Since this occurs.." is no longer true with the changes from
bug 18816 and can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:37:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:37:17 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-aViGj8XNsi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:42:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:42:44 +0000
Subject: [Koha-bugs] [Bug 6533] Enhancement: Printer Friendly Lists
In-Reply-To: <bug-6533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6533-70-eRPFAS72wD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Karen, please consider filing a separate bug for the reading history - it
will make it more visible and it should best be a separate patch to keep things
nice and testable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:44:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:44:47 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-qA1OvQr6wB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21279
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe a similar fix as bug 21279?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  2 23:44:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 22:44:47 +0000
Subject: [Koha-bugs] [Bug 21279] Transport cost matrix shows html entity in
 all empty cells
In-Reply-To: <bug-21279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21279-70-rLg9V5uYSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22058

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:03:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:03:19 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-d0okaJj12p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Version|18.11                       |master
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:13:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:13:38 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-cgGCT2aH2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's line 320 in opac-MARCDetail.pl:
        $item_data->{$subfield_code} ||= "&nbsp;"

If you change that to " " or "" it will display correctly.

But: I compared the display to staff and there we actually use a $raw filter on
the template which will also display correctly. It has the added benefit that
HTML used in note fields (I know, we do that) will display correctly.

So I will propose a patch making staff and OPAC match.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:19:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:19:22 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-ndzM2FEUbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:19:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:19:25 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-JiNbEhJuuv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83609&action=edit
Bug 22058: Fix display of empty table cells in OPAC MARC view holdings

I compared the template logic to the MARC detail page in staff.
We use $raw there instead of html, which will also make notes and other
fields with HTML in them display correctly. I am proposing to use the
$raw filter in OPAC as well.

To test:
- Go to the OPAC
- Search for a record with items
- Switch to the MARC view
- Verify empty cells show &nbsp; (html entity for space)
- Apply patch
- Repeat test
- Verify empty table cells now show as empty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:20:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:20:30 +0000
Subject: [Koha-bugs] [Bug 21935] Setup sip accounts through front end
In-Reply-To: <bug-21935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21935-70-PdXqrpFi5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21935

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:20:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:20:41 +0000
Subject: [Koha-bugs] [Bug 21935] Setup SIP2 accounts through front end
In-Reply-To: <bug-21935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21935-70-5UF725XPVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21935

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Setup sip accounts through  |Setup SIP2 accounts through
                   |front end                   |front end

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 00:31:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Jan 2019 23:31:34 +0000
Subject: [Koha-bugs] [Bug 21888] I can not create Label Template
In-Reply-To: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21888-70-AsBXiuBEBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
What is your exact Koha version? (see About page)
What is your MySQL version? (also see About)
Can you please check that the problem also appears using the English templates?
(Ruling out an issue with the translation)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 05:20:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 04:20:31 +0000
Subject: [Koha-bugs] [Bug 21888] I can not create Label Template
In-Reply-To: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21888-70-heGneGbN0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

sergeinik <sergeinik at tut.by> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.05                       |18.11

--- Comment #6 from sergeinik <sergeinik at tut.by> ---
18.11.01.000 - Koha.
10.3.11- MariaDB.
The problem also exists when using English.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 05:25:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 04:25:19 +0000
Subject: [Koha-bugs] [Bug 21888] I can not create Label Template
In-Reply-To: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21888-70-2jNqzaCdF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

--- Comment #7 from sergeinik <sergeinik at tut.by> ---
I solve this problem not from the administrator interface, but by entering data
directly into the MySql table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 08:13:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 07:13:58 +0000
Subject: [Koha-bugs] [Bug 21888] I can not create Label Template
In-Reply-To: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21888-70-FFZbKfjQ92@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21888

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tested both the label creator and the patron card creator and both work ok
for me. I think it could help if you checked the error logs for an error. 

If you are using Plack, something should be visible in the plack-error.log when
you save.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 09:28:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 08:28:47 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-SquHMBBauR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tested on 17.11 again - still not working. Looking at the code I don't see a
reason for it not working. lost and damaged are also numerical and work without
issues, but restricted does not.

It doesn't appear to be a reserved word in SQL... out of ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 09:34:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 08:34:24 +0000
Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect
 holidays, and everybody need to know the last pickup date for reserves,
 even notices.
In-Reply-To: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12353-70-m3Ve9rj2T0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|In Discussion               |RESOLVED

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 12063 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 09:34:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 08:34:24 +0000
Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve
 expiration to skip all holidays
In-Reply-To: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12063-70-yrBlwM0lKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #91 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 12353 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 09:38:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 08:38:22 +0000
Subject: [Koha-bugs] [Bug 17839] 'Print summary' totals charges and fines,
 but only shows charges
In-Reply-To: <bug-17839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17839-70-lxdr0aU2Z3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:33:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:33:48 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-JaObaCs9aP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:33:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:33:51 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-KMmeUdQBvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78568|0                           |1
        is obsolete|                            |

--- Comment #30 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83610&action=edit
Bug 18585 - Connect to RDF triplestore

This commit adds a 'triplestore' method to C4::Context. It takes
a model name as a parameter and returns a RDF::Trine::Model object
if triplestore.yaml is properly configured.

(At the moment, it just supports RDF::Trine::Store::SPARQL,
but it would be trivial to add support for RDF::Trine::Store::DBI too,
or any other RDF::Trine::Store::* backend.)

This code will provide a base from which people can use RDF::Trine
for querying and updating a RDF triplestore.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:33:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:33:54 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-qAYj3iKXVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78975|0                           |1
        is obsolete|                            |

--- Comment #31 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83611&action=edit
Bug 18585: Missing triplestore configuration causes warnings in logs

This patch checks that the triplestore configuration is defined
before trying to find it and read it.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:37:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:37:32 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-XJXUtUOCcv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:37:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:37:34 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-5QLUk30lnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69633|0                           |1
        is obsolete|                            |

--- Comment #29 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83612&action=edit
Bug 18713: Add support for named graphs and rfds:seeAlso to Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

This patch includes unit tests for both of these changes.

_TEST PLAN_
1) Run "prove t/Koha/RDF.t"
2) Note that all tests have run successfully.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:38:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:38:33 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-4knQjt8u6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #30 from Josef Moravec <josef.moravec at gmail.com> ---
Rebased on top of signed off patches from bug 18585 and set back to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 10:59:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 09:59:12 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-5vFSycGFXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We've had a similar issue now with the item search where a publisher is spelled
with a \ in the name. I think we can't rule \ appearing in real data and for
patrons. Can we have another go here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 11:08:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 10:08:48 +0000
Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/invoice.pl
In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14850-70-tZaCeg9yHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Would love to see this fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 11:56:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 10:56:35 +0000
Subject: [Koha-bugs] [Bug 22063] New: Prevent library staff from changing
 other people's password.
Message-ID: <bug-22063-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22063

            Bug ID: 22063
           Summary: Prevent library staff from changing other people's
                    password.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: r.delahunty at arts.ac.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org
  Target Milestone: ---

We use LDAP authentication where the userid is passed to the university's
authentication service and if a match is found the password must be the one the
staff member themselves has chosen for their university network account. Only
when the university's authentication service fails, or the user has no
university account (such as our 3rd party support staff) does the local
password (borrowers.password) get checked and used. The 'Add, modify and view
user Information' permission is astoundingly broad, allowing **any** user with
catalogue access to change anyone's password. It is possible for someone to
change the password of the superlibrarian, to claim access to all areas of
Koha. If the superlibrarian were not logged on, they would effectively be
locked out and lose control of the system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 12:36:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 11:36:22 +0000
Subject: [Koha-bugs] [Bug 11962] New 'cluster' install mode
In-Reply-To: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11962-70-dY0zqlX3Ua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11962

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:01:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:01:22 +0000
Subject: [Koha-bugs] [Bug 11962] New 'cluster' install mode
In-Reply-To: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11962-70-bp73eFmcYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Tomas, is this still something you want to follow-up on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:03:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:03:22 +0000
Subject: [Koha-bugs] [Bug 11962] New 'cluster' install mode
In-Reply-To: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11962-70-7Ldm4P8U5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11962

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #1)
> Hi Tomas, is this still something you want to follow-up on?

I'm more interested in Julian's work on making Koha a Mojolicious app (with
multi-tenancy in mind). So, not clear right now this is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:08:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:08:57 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-olKPIVdio7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|Add a /public namespace     |Public route to change
                   |that can be switched on/off |password

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I'm changing the bug description, because I didn't manage to have tests for the
on/off switch without a real implemented route.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:09:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:09:59 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-ze1UqOImis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83613&action=edit
Bug 22061: Add RESTPublicAPI syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:10:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:10:03 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-qSN1yjvNIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83614&action=edit
Bug 22061: Add a /public namespace that can be switched on/off

This patch adds a check in Koha::REST::V1::Auth::under to catch all
routes that begin with 'public' (inside /api/v1). If they match, and the
RESTPublicAPI syspref is off, then an exception is thrown, rendering a
403 error to the consumer.

Otherwise the routes are processed as usual. This is THE on/off switch
for the public REST API. The target use case: people not wanting an OPAC
or public interaction with the API besides privileged users.

In order to test, the rest of the patches are needed because the only
way to test a route is having it in the spec.

To test:
- Apply the patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth.t
=> SUCCESS: tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:11:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:11:06 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-wLcXAfA4sP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Leaving this as ASSIGNED until I solve some bugs found in the process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:11:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:11:21 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-sYOBpb7gSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17006
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=17006                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
[Bug 17006] Add route to change patron's password
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:11:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:11:21 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-WIWsq9vmjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22061
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=22061                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061
[Bug 22061] Public route to change password
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:22:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:22:05 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-fKq3JNHPwx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make Koha::Object->store    |Make Koha::Object->store
                   |translate 'Incorrect        |translate 'Incorrect <type>
                   |datetime value' exceptions  |value' exceptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:48:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:48:41 +0000
Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account
 payments and write-offs
In-Reply-To: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19191-70-QZ96NK64sV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 13842 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 13:48:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 12:48:41 +0000
Subject: [Koha-bugs] [Bug 13842] Send payment slip to patron by email
In-Reply-To: <bug-13842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13842-70-EYSgCLzwtM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13842

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 19191 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 14:12:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 13:12:55 +0000
Subject: [Koha-bugs] [Bug 22064] New: Allow to change due date of an item
 without requiring checkin or renewal
Message-ID: <bug-22064-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22064

            Bug ID: 22064
           Summary: Allow to change due date of an item without requiring
                    checkin or renewal
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

Sometimes it woudl be helpful if it was possible to change the due date of an
item without generating an e-mail by renewing or checkin/checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 14:46:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 13:46:41 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-sblcxcvuOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 14:46:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 13:46:43 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-LxjmZJB11K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83386|0                           |1
        is obsolete|                            |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83615&action=edit
Bug 5770: Notify for new suggestion - sample notices

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 14:46:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 13:46:47 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-onN7daPfF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83388|0                           |1
        is obsolete|                            |

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83616&action=edit
Bug 5770: Email librarian when purchase suggestion made

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 14:46:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 13:46:50 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-3lpOqDXl4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83617&action=edit
Bug 5770: New system pref for new suggestion email

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 14:49:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 13:49:34 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-4Zwn4Nc1tc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Works as advertised, a few notes:
1 - I encourage everyone to use skeleton.perl as a base for update statements
:-) - perl ones are easier to push
2 - I would like to see the new notice use TT syntax instead of our legacy
syntax

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:05:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:05:15 +0000
Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings
In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18320-70-fyeMhTztHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
The remaining warning comes from manage.pl. Taking care of it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:09:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:09:04 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-5arUqxK3EG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22051


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051
[Bug 22051] Make Koha::Object->store translate 'Incorrect <type> value'
exceptions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:09:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:09:04 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-OqecnyY4w9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049
[Bug 22049] MarkIssueReturned should rely on returndate only
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:10:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:10:10 +0000
Subject: [Koha-bugs] [Bug 22064] Allow to change due date of an item without
 requiring checkin or renewal
In-Reply-To: <bug-22064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22064-70-Zy5czknW12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22064

Andrew <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #1 from Andrew <andrew at bywatersolutions.com> ---
This is definitely something I get asked about when training new users. Other
programs allow it and folks find it useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:15:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:15:57 +0000
Subject: [Koha-bugs] [Bug 22033] related_resultset is a hole in the
	Koha::Object logic
In-Reply-To: <bug-22033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22033-70-imT4Qqx93p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
   Target Milestone|---                         |18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:18:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:18:40 +0000
Subject: [Koha-bugs] [Bug 22033] related_resultset is a hole in the
	Koha::Object logic
In-Reply-To: <bug-22033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22033-70-nJHJ5KDLTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02.

I chose to backport this to the 18.11.x as we're early in the cycle. I don't
feel it's required for earlier releases however as it's a precautionary measure
to prevent it's misuse in future developments.

Marking RESOLVED FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:21:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:21:15 +0000
Subject: [Koha-bugs] [Bug 21789] Example usage of I18N Template::Toolkit
	plugin
In-Reply-To: <bug-21789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21789-70-tmCqR1zG2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21789

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:21:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:21:49 +0000
Subject: [Koha-bugs] [Bug 21790] Switch error page template to Bootstrap grid
In-Reply-To: <bug-21790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21790-70-vFrBpBABQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:21:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:21:50 +0000
Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to
 use Bootstrap grid
In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19980-70-i5ecgbO6UB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
Bug 19980 depends on bug 21790, which changed state.

Bug 21790 Summary: Switch error page template to Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21790

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:22:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:22:24 +0000
Subject: [Koha-bugs] [Bug 21795] Switch two-column templates to Bootstrap
 grid: Notices and slips
In-Reply-To: <bug-21795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21795-70-cMxMBTgGkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21795

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:22:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:22:24 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-9xul25G81Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21795, which changed state.

Bug 21795 Summary: Switch two-column templates to Bootstrap grid: Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21795

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:22:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:22:24 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-fKvZ9Ggwqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802
Bug 21802 depends on bug 21795, which changed state.

Bug 21795 Summary: Switch two-column templates to Bootstrap grid: Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21795

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:23:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:23:30 +0000
Subject: [Koha-bugs] [Bug 21695] Clean up access files template
In-Reply-To: <bug-21695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21695-70-5fhieU8RIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:23:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:23:30 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-w51HhwsR32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21695, which changed state.

Bug 21695 Summary: Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:23:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:23:54 +0000
Subject: [Koha-bugs] [Bug 21693] Clean up checkout notes template
In-Reply-To: <bug-21693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21693-70-4H8UPWFJ8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:23:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:23:55 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-MLEE9aMegX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21693, which changed state.

Bug 21693 Summary: Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:24:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:24:30 +0000
Subject: [Koha-bugs] [Bug 21844] Add callnumber to fines descriptions
In-Reply-To: <bug-21844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21844-70-IwlgR3jBJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21844

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:25:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:25:05 +0000
Subject: [Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
In-Reply-To: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21571-70-W5nd00XcUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:25:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:25:51 +0000
Subject: [Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
In-Reply-To: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21571-70-1dW4fs7z5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02... it is a bug if something cannot be
translated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:26:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:26:37 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21929-70-sb4m0dlI2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:27:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:27:09 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21929-70-WZ3UlFjLa4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:27:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:27:51 +0000
Subject: [Koha-bugs] [Bug 21754] If an item is marked as lost,
 any outstanding transfers upon it should be automatically cancelled
In-Reply-To: <bug-21754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21754-70-HN8Gbdnw9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:27:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:27:51 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
	allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-fjKThc23j7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
Bug 20844 depends on bug 21754, which changed state.

Bug 21754 Summary: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:30:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:30:59 +0000
Subject: [Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove
	sub goodkey
In-Reply-To: <bug-21547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21547-70-3CmVXc1g6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

I chose to backport this architectural change as it's simple cleanup and may
aid in future backports.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:30:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:30:59 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-zoZdmYZEY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047
Bug 22047 depends on bug 21547, which changed state.

Bug 21547 Summary: Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:30:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:30:59 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-m8jZ2ph65y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048
Bug 22048 depends on bug 21547, which changed state.

Bug 21547 Summary: Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:32:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:32:33 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-QQpRhRyzIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:32:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:32:36 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-NztoCyzTdf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83299|0                           |1
        is obsolete|                            |

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83618&action=edit
Bug 19489: Add the Koha::Account::Line->issue method

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:32:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:32:39 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-jd47ED2hZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83300|0                           |1
        is obsolete|                            |

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83619&action=edit
Bug 19489: Development for fines and Fees Module - Detailed Description of
charges in Patron Account Tab/Fines Tab

Test plan:
1) Apply this patch
2) Choose a patron with overdue items applied fines
3) Click Fines from left menu
4) Test the values in barcode, due date and return date in Pay fines and
Account tabs
5) Also test Column visibility, Print and Details buttons for
functioning

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:32:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:32:43 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-usMRqyii6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83301|0                           |1
        is obsolete|                            |

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83620&action=edit
Bug 19489: Cover non-existent issue

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 15:34:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 14:34:08 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-zCIePPQNOI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Cleared minor conflict when applying (test counts)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 16:44:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 15:44:54 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-m9tDrMKw0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83609|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83621&action=edit
Bug 22058: Fix display of empty table cells in OPAC MARC view holdings

I compared the template logic to the MARC detail page in staff.
We use $raw there instead of html, which will also make notes and other
fields with HTML in them display correctly. I am proposing to use the
$raw filter in OPAC as well.

To test:
- Go to the OPAC
- Search for a record with items
- Switch to the MARC view
- Verify empty cells show &nbsp; (html entity for space)
- Apply patch
- Repeat test
- Verify empty table cells now show as empty

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 16:44:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 15:44:51 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-R9UuzqChEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 16:46:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 15:46:52 +0000
Subject: [Koha-bugs] [Bug 22065] Can't receive isses wheren there is no
 serial with status 1 (expected)
In-Reply-To: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22065-70-xVWPol56eB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22065

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 16:46:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 15:46:45 +0000
Subject: [Koha-bugs] [Bug 22065] New: Can't receive isses wheren there is no
 serial with status 1 (expected)
Message-ID: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22065

            Bug ID: 22065
           Summary: Can't receive isses wheren there is no serial with
                    status 1 (expected)
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

We had several libraries reporting this after the update to 17.11.11.

To test:
- Create a subscription without an issue in status "expected"
  serial.status = 1
  You will need to use SQL, as I don't know yet how this happens.
- Go to the subscription detail form
- Click the receive button

Link is: 
/cgi-bin/koha/serials/serials-edit.pl?subscriptionid=9&serstatus=1,3

- Verify the page explodes in "internal server error"

The error translates to:

Can't call method "title" on an undefined value at
/usr/share/koha/intranet/cgi-                                                  
                                                               
bin/serials/serials-edit.pl line 424.

Workaround: 
- Go to serial collection
- Generate next issue

Needs more testing with newer versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 16:47:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 15:47:16 +0000
Subject: [Koha-bugs] [Bug 22065] Can't receive isses when there is no serial
 with status 1 (expected)
In-Reply-To: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22065-70-REUhtvYy2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22065

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't receive isses wheren  |Can't receive isses when
                   |there is no serial with     |there is no serial with
                   |status 1 (expected)         |status 1 (expected)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 16:54:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 15:54:23 +0000
Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees
 without creating credits
In-Reply-To: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20262-70-JFHHDehFo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

--- Comment #14 from Chris Slone <cslone at camdencountylibrary.org> ---
Just to add to the interest and need expressed by Martha and Rhonda: This is
more than ever a necessity for us, as the recent changes to how Koha handles
credits have made apparent how often refunds have been automatically generated
for something already resolved without anyone catching it. Hoping this is in a
release soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:27:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:27:24 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-3DbVyh6Ngk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:27:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:27:27 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-N4jlggEJAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83534|0                           |1
        is obsolete|                            |
  Attachment #83535|0                           |1
        is obsolete|                            |
  Attachment #83536|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83622&action=edit
Bug 22051: Add Koha::Exceptions::Object::WrongValue

This patch adds a new exception to be thrown in Koha::Object->store when
a DBIC exception is thrown regarding bad data format.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:27:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:27:32 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-GfzDNCyyrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83623&action=edit
Bug 22051: Unit tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:27:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:27:36 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-E41R4hibQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83624&action=edit
Bug 22051: Make Koha::Object->store translate incorrect value exceptions

This patch adds a new condition to Koha::Object->store so it catches
incorrect value-related DBIC exceptions.

This DBIC exceptions get now translated into
Koha::Exceptions::Object::BadValue exceptions with relevant parameters
passed.

To test:
- Apply the exception and unit tests patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because this exception handling code is not
implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:35:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:35:41 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-gxEa2mSdxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:35:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:35:45 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-8STbM2jSfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83543|0                           |1
        is obsolete|                            |
  Attachment #83548|0                           |1
        is obsolete|                            |
  Attachment #83549|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83625&action=edit
Bug 22049: Make MarkIssueReturned rely on returndate only

This patch changes the params accepted by
C4::Circulation::MarkIssueReturned by removing the $dropbox_branch
param.

This passed branchcode was only used to initialize the Koha::Calendar
object, but the date arithmetic has already taken place in a couple
places before we reach this point. This logic needs to be simplified
(bug 14591), and this is the starting point.

To test:
- Apply this patch
- Run:
  $ git grep MarkIssueReturned
=> SUCCESS: Check all the uses of the function either originally passed
undef, or now pass the same date that would've been calculated anyway,
in the returndate param.
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:35:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:35:50 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-9J43uVDu3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83626&action=edit
Bug 22049: Add tests

The current tests only check some failure use cases. This patch makes it cover
more use cases

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:35:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:35:57 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-FIDlAC9mXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83627&action=edit
Bug 22049: (follow-up) Remove leftover variable

The $circControlBranch variable was originally set to be used to pick
the right dropbox branch. It was only used in MarkIssueReturned, to get
the right Koha::Calendar object. As this responsability was moved top to
the AddReturn caller, and the fact that _GetCircControlBranch is
actually used for fines rules, there's no use for it in this context.
And it was left on the previous patch as a mistake.

To test:
- Make sure the variable is not actually used:
  $ git grep '$circControlBranch'
=> SUCCESS: removed variable is not actually used.
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:40:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:40:53 +0000
Subject: [Koha-bugs] [Bug 20729] Update style of datepickers
In-Reply-To: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20729-70-vln3d2DZEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 17:50:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 16:50:55 +0000
Subject: [Koha-bugs] [Bug 6495] After deleting a list the output of lists is
	truncated
In-Reply-To: <bug-6495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6495-70-3FgKHgWQoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6495

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 18:31:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 17:31:49 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-iPwLqxsESy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Katrin,
I've just tested this on 18.06.00.028 and it is working.  Restricted items are
being hidden in the OPAC when a value of restricted: [1] is placed in the
OPACHiddenItems syspref.




(In reply to Katrin Fischer from comment #4)
> Tested on 17.11 again - still not working. Looking at the code I don't see a
> reason for it not working. lost and damaged are also numerical and work
> without issues, but restricted does not.
> 
> It doesn't appear to be a reserved word in SQL... out of ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 18:57:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 17:57:14 +0000
Subject: [Koha-bugs] [Bug 21807] Allow choosing narrower/broader when
 linking authority hierarchies
In-Reply-To: <bug-21807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21807-70-qKnHL01i7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21807

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Andreas Roussos from comment #1)
> (In reply to Tom?s Cohen Arazi from comment #0)
> > The idea is that instead of just picking the 'Choose' button, the end-user
> > can choose if the selected one is a narrower or a broader term, and thus
> > filling $w accordingly.
> Hi Tom?s. There does exist a dropdown menu in both MARC21/UNIMARC
> setups with various relationship options. If you select one of the
> options (say, "g - Broader term") before you pick the 'Choose'
> button, subfield $w ($5 in UNIMARC) will be filled in with the
> appropriate code.
> 
> Or were you referring to something different in your comment? :-)

That's correct! I missed it, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 19:10:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 18:10:43 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-Y3SyHy0vVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Joy, that's good news!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 20:07:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 19:07:12 +0000
Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines
In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19066-70-wN9RqjXUTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #94 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 20:08:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 19:08:02 +0000
Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines
In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19066-70-QLro7mKQ0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

--- Comment #95 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83628&action=edit
Bug 19066: (RM follow-up) Fix test count and structure error

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 20:09:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 19:09:33 +0000
Subject: [Koha-bugs] [Bug 22066] New: Branchcode should be recorded for
	manual credits
Message-ID: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

            Bug ID: 22066
           Summary: Branchcode should be recorded for manual credits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 20:09:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 19:09:46 +0000
Subject: [Koha-bugs] [Bug 22066] Branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-f1IE8bkSCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |19066


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066
[Bug 19066] Add branchcode to accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 20:09:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 19:09:46 +0000
Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines
In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19066-70-kF5jOzMmLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22066


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066
[Bug 22066] Branchcode should be recorded for manual credits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 21:52:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 20:52:04 +0000
Subject: [Koha-bugs] [Bug 22067] New: Koha::Patron->can_see_patron_infos
 should return if no patron is passed
Message-ID: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

            Bug ID: 22067
           Summary: Koha::Patron->can_see_patron_infos should return if no
                    patron is passed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

If there is a problem retrieving a patron's guarantor they cannot be edited.

To recreate:
1 - Find an adult patron
2 - Add a child to their account
3 - Delete the parent from the db
4 - Attempt to edit the child record

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 21:54:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 20:54:50 +0000
Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should
 return if no patron is passed
In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22067-70-95GvhFbjvZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 21:54:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 20:54:52 +0000
Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should
 return if no patron is passed
In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22067-70-07scEoeG8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83629&action=edit
Bug 22067: Return if no patron passed to can_see_patron_infos

To test:
1 - Find an adult patron
2 - Add a child to their account
3 - Delete the parent from the db
4 - Attempt to edit the child record
5 - Apply patch
6 - Repeat
7 - Note you can edit the child account
8 - Note guarantor id is not a link

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 22:20:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 21:20:56 +0000
Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should
 return if no patron is passed
In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22067-70-srVPrrBXpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  3 22:36:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Jan 2019 21:36:14 +0000
Subject: [Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
In-Reply-To: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21571-70-5dZ50TcV1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 18.05 for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 03:51:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 02:51:38 +0000
Subject: [Koha-bugs] [Bug 11962] New 'cluster' install mode
In-Reply-To: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11962-70-5sP1S3gb8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11962

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 03:54:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 02:54:58 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-CC5OOhN5I1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

--- Comment #32 from David Cook <dcook at prosentient.com.au> ---
For what it's worth, I'm no longer convinced what I have here is the best way
forward, but I suppose it's better than nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 03:55:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 02:55:05 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-O54e3tEwIC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
For what it's worth, I'm no longer convinced what I have here is the best way
forward, but I suppose it's better than nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 07:34:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 06:34:26 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-dKXFLqSZiv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|josef.moravec at gmail.com     |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 10:01:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 09:01:26 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-0081hQMIvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joy,

I tested again today on master - it still doesn't work for me.

Here is what I did:

OpacHiddenItems:
restricted: [1]

Changed 1 item out of 4 to be restricted.

Opac now shows it as: 
Available (Restricted Access)

Not hidden...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 10:50:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 09:50:43 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-rMKrw4pMVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
After some debugging I think I have found the reason. It won't work with the
numeric value of the authorised value used, it needs the description:

restricted: ['Restricted Access']

For other values like Damaged it will works with numerics. 

The reason is some code in GetItemsInfo:

        # get notforloan complete status if applicable
        $descriptions =
Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode =>
$data->{frameworkcode}, kohafield => 'items.notforloan', authorised_value =>
$data->{itemnotforloan} });
        $data->{notforloanvalue}     = $descriptions->{lib} // '';
        $data->{notforloanvalueopac} = $descriptions->{opac_description} // '';

        # get restricted status and description if applicable
        $descriptions =
Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode =>
$data->{frameworkcode}, kohafield => 'items.restricted', authorised_value =>
$data->{restricted} });
        $data->{restricted}     = $descriptions->{lib} // '';
        $data->{restrictedopac} = $descriptions->{opac_description} // '';

While it uses a new variable "*value*" for notforloan, it overwrites the
restricted numerical value with the description.

I think the clean solution is to change it so that OpacHiddenItems works like
for the other item fields with authorised values, using the codes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 11:15:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 10:15:51 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-UpUuJEdapf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 11:15:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 10:15:54 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-RQqcK0KrNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83630&action=edit
Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted

The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't
exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 12:43:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 11:43:09 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-5j7pU5KNMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83631&action=edit
Bug 10676: Add unit tests - GetItemsInfo

To test:
  prove t/db_dependent/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 13:20:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 12:20:32 +0000
Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber
	does not work
In-Reply-To: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21460-70-IpwAdI5JUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460

--- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Thanks for taking the time to post that patch Jonathan, it makes for an
interesting experiment!

I'll create a patch that will iterate the and escape the prefilters in the .pl
then constructs the string in the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 13:47:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 12:47:53 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-2iHl0CXoLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 14:03:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 13:03:41 +0000
Subject: [Koha-bugs] [Bug 22065] Can't receive isses when there is no serial
 with status 1 (expected)
In-Reply-To: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22065-70-qFISGmDDcT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22065

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It works nicely on master:
If there is no expected issue you are forwarded to the serial collection page
where you can generate the next issue or change status of one of the older
issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 14:18:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 13:18:07 +0000
Subject: [Koha-bugs] [Bug 22069] New: Viewlog not displaying renewals
	correctly
Message-ID: <bug-22069-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069

            Bug ID: 22069
           Summary: Viewlog not displaying renewals correctly
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barry.cannon at interleaf.ie
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

If Tools > Log Viewer is selected and run using the module "Circulation" with
the action of "Renew" no results are shown. Selecting the action of "All" shows
all results including renewals. The reason appears to be because when selecting
the action of "Renew" the form POST uses the action parameter value of "RENEW".
This, in turn, gets passed to GetLogs where is used in the SQL query. However,
the actual value that is logged in the action_logs table is "RENEWAL" and not
"RENEW". Changing the SQL query to "RENEWAL" obtains the correct results.

RENEW is correct for the MEMBERS module but RENEWAL should be used for Circ.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 14:39:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 13:39:03 +0000
Subject: [Koha-bugs] [Bug 22070] New: OpacBrowseResults has broken link back
 to search results
Message-ID: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

            Bug ID: 22070
           Summary: OpacBrowseResults has broken link back to search
                    results
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Under certain conditions the OPACBrowseResults (navigation between results in
OPAC) feature will have a broken link "back to results".

To test:
- Search for a term with diacritics. You can cheat a little here and search for
something like "b??ks" with the sample data. (? will also find o). 
It's important that it's at least to result pages.
- Go to the last result of the first result page
- Verify the URL "back to results" works and diacritic shows up nicely
- Go to the last result of the first page again
- Navigate "Next >>" 
- Check "Back to results" again
- Verify the link is broken and the diacritics are mangled


Link looks something like this:
http://localhost:8080/cgi-bin/koha/opac-search.pl?offset=20&q=b%C3%83%C2%83%C3%82%C2%B6%C3%83%C2%83%C3%82%C2%B6ks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 14:43:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 13:43:07 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
	search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-SwBoiM5oNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
            Version|17.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:13:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:13:08 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-2gFyDEMHiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:13:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:13:10 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-UGF4EZOtp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82239|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83632&action=edit
Bug 21813: In-page JavaScript causes error on patron entry page

This patch removes a block of JavaScript from memberentrygen.tt which
was being included in the page before jQuery is loaded. This causes a
JavaScript error.

To test, apply the patch, regenerate CSS, and clear your browser cache
if necessary.

 - In Administration -> Patron categories, confirm that you have two
    patron categories with different default messaging preferences
    defined.
 - Go to Patrons -> New patron
   - Create a new patron using one of the categories with messaging
     preferences.
   - Confirm that when you switch the category selection to the other
     patron category, the patron messaging preference checkboxes are
     changed to the default for that category.
     - A "Loading" indicator should appear above the checkboxes to show
      that an operation is in process. It should disappear when new
      default prefs are loaded.
   - Manually change one or more patron messaging preference checkboxes.
   - Switch the patron category again and confirm that you are prompted
     to confirm resetting the preferences to the default for that
     category.
 - Perform the same set of tests when editing a patron.
   - Defaults should not be loaded during the edit process.
 - Confirm that there are no other JavaScript errors in the console.
 - Test again with EnhancedMessagingPreferences disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:28:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:28:49 +0000
Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff
	search
In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18421-70-7TbM75Ua5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80137|0                           |1
        is obsolete|                            |

--- Comment #36 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83633&action=edit
Bug 18421: Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:29:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:29:02 +0000
Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff
	search
In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18421-70-fFZN6fwymJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80138|0                           |1
        is obsolete|                            |

--- Comment #37 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83634&action=edit
Bug 18421: (follow-up) QA fixes

Use the community's terminology, change coce.js's path, update <script>
to Asset, remove forbidden patterns

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:29:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:29:26 +0000
Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff
	search
In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18421-70-wleO6mrrzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80139|0                           |1
        is obsolete|                            |

--- Comment #38 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83635&action=edit
Bug 18421: (follow-up) Adding missing filters

This patch adds template filters as prompted by the QA tool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:30:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:30:22 +0000
Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff
	search
In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18421-70-7DKu8kgQIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:30:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:30:25 +0000
Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff
	search
In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18421-70-vx1qwRQHoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #39 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83636&action=edit
Bug 18421: (follow-up) Center image in results table

Adds the "thumbnail" class to the image to have it centered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:35:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:35:30 +0000
Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
In-Reply-To: <bug-18078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18078-70-FUzkaIXuXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Aleisha Amohia from comment #9)
> Wasn't able to complete the Search. After clicking Search, this error shows:
> 
> Template process failed: undef error - WHILE loop terminated (> 1000
> iterations)
>  at /home/vagrant/kohaclone/C4/Templates.pm line 122

I'm obsoleting that comment because it's really long and I think the above
snippet is what's really relevant: My changed template tries to use a WHILE
loop with result pages and there is a hard limit of 1000 for that kind of loop.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:46:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:46:41 +0000
Subject: [Koha-bugs] [Bug 22071] New: Make authenticate_api_request stash
 koha.user in OAuth use case
Message-ID: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

            Bug ID: 22071
           Summary: Make authenticate_api_request stash koha.user in OAuth
                    use case
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

The patron that made the request is not being stashed in OAuth authentication.
Regression tests and fixes to be submitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:46:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:46:54 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-oz3G2Riq6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21198
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198
[Bug 21198] authenticate_api_request should stash the reason access is granted
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 15:46:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 14:46:54 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-90AJkRJi3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22071


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071
[Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:34:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:34:19 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-MfLx3VL05n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

--- Comment #9 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83637&action=edit
Bug 21738: make call of CanBookBeReserved more safe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:34:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:34:36 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-GmYhOn0IcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:50:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:50:06 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-OIzfFVBBOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:50:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:50:29 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-3ULjKwV5tA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83638&action=edit
Bug 22071: Regression tests

The authenticate_api_request() behaviour needs more tests. This patch
adds tests for the stashed Koha::Patron object. It highlights the bug in
the OAuth authentication case.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail in the OAuth case, pass in the cookie-based auth
case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:50:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:50:32 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-sFRle43uUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83639&action=edit
Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case

This patch makes the OAuth code stash the requestion Koha::Patron.

To test:
- Apply the tests patch:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail :-(
- Apply this patch
- Run:
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass :-D
- Sign off =D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:50:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:50:47 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-dj2UPoHzGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:52:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:52:35 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-j0ZcKkqvfQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:52:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:52:38 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-FKA6bhXEZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Version|16.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:54:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:54:56 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-mUggcJuFUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:54:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:54:59 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-ypJD0JLt20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83640&action=edit
Bug 21850: Remove search request from page title of OPAC result list

This patch modifies the OPAC search results template so that advanced
search terms are not shown in the page title and breadcrumbs. This
removes potentially confusing computer-oriented code from the public
view.

For simple searches the search term is displayed, using the same logic
that determines whether the search bar should be populated with the last
search term.

To test:

 - Apply the patch
 - Peform a simple keyword search in the OPAC
   - On the results page the title and breadcrumbs should show 'Results
     of search for [your keyword]
 - Perform an advanced search with multiple parameters
   - The page title and breadrumbs should show only 'Search results'
   - The breadcrumbs should also show a link back to Advanced search
     using the returntosearch parameter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:58:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:58:20 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-t7X3Mx84yM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83638|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83641&action=edit
Bug 22071: Regression tests

The authenticate_api_request() behaviour needs more tests. This patch
adds tests for the stashed Koha::Patron object. It highlights the bug in
the OAuth authentication case.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail in the OAuth case, pass in the cookie-based auth
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:58:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:58:23 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-QHiQtFOXwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83639|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83642&action=edit
Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case

This patch makes the OAuth code stash the requestion Koha::Patron.

To test:
- Apply the tests patch:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail :-(
- Apply this patch
- Run:
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass :-D
- Sign off =D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 16:58:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 15:58:29 +0000
Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order
In-Reply-To: <bug-15051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15051-70-QTwvOVMYvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 17:03:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 16:03:05 +0000
Subject: [Koha-bugs] [Bug 17119] Shouldn't have to scroll to see submit
 button in Z39.50 authority search popup
In-Reply-To: <bug-17119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17119-70-mAWPyqo4q1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17119

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This was fixed by Bug 19946

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 18:08:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 17:08:26 +0000
Subject: [Koha-bugs] [Bug 15806] Remove obsolete vendor prefixes from staff
	client CSS
In-Reply-To: <bug-15806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15806-70-ZqNtDoLUl8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15806

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Fixed by Bug 19474

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 18:09:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 17:09:22 +0000
Subject: [Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
In-Reply-To: <bug-13614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13614-70-3nOHnPAe1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 18:44:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 17:44:40 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-KFlWcMO3lX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 18:44:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 17:44:43 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-ntfUeLRsEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58549|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83643&action=edit
Bug 15505 - Mark Hold Items 'On hold' instead of 'Available'

This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
allow for displaying status of an item when it has been selected for a
hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't
allow'

To test:
00 - Set AllowItemsOnHoldCheckout to 'Allow'
01 - Place a hold on an item
02 - Build the holdsqueue (kohadevbox example below)
      sudo koha-shell kohadev
      perl misc/cronjobs/holds/build_holds_queue.pl
03 - Search for the item on the OPAC
04 - Note item shows as 'Available' in results and details
05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow'
06 - Repeat search, note there is no change
06 - Apply Patch
07 - Search for the item on the OPAC
08 - Note that item now shows as 'Pending hold'
09 - Toggle AllowItemsOnHoldCheckout to Allow
10 - Note item shows as available
11 - prove -v t/db_dependent/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 18:46:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 17:46:52 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-uMOLThH9Ln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
I updated the patches to respect AllowItemsOnHoldCheckout and updated the pref
description.

This patch only affects sites using the holds queue and will only affect items
that have been currently selected to be pulled for a hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 18:48:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 17:48:35 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-pkG3Pa7TZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:38:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:38:40 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-Sd9GHOOuje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:38:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:38:44 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-Y2MZC2imiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81816|0                           |1
        is obsolete|                            |
  Attachment #81817|0                           |1
        is obsolete|                            |
  Attachment #81818|0                           |1
        is obsolete|                            |
  Attachment #81819|0                           |1
        is obsolete|                            |
  Attachment #81820|0                           |1
        is obsolete|                            |
  Attachment #81821|0                           |1
        is obsolete|                            |

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83644&action=edit
Bug 19915: Add unit test to GetItemsForInventory.t

prove -v t/db_dependent/Items/GetItemsForInventory.t

Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Moved the betwen typo edit back here.

https://bugs.koha-community.org/show_bug.cgi?id=19905

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:38:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:38:48 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-KvaOahQjco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #44 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83645&action=edit
Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t

Standard edits like modules, schema, Koha objects instead of DBIC.
Removing unneeded autoflush.
Moving initial test to a first subtest.
No need to clear issues if you clear items.
Adding a FIXME for OldWay; would be nice to remove that code..

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

https://bugs.koha-community.org/show_bug.cgi?id=19905

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:38:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:38:52 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-eQnCOic8YJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #45 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83646&action=edit
Bug 19915: Use cn_sort values for getting inventory items

To test:
1 - Catalog an item under LCC with callnumber GT95
2 - cn_sort should calculate as GT0095
3 - Go to inventory tool
4 - Enter a range that should have your item e.g LC GT90 to GT100
5 - Item is not returned
6 - Apply patch
7 - Item should be returned
8 - Verify things otherwise work as expected

Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

https://bugs.koha-community.org/show_bug.cgi?id=19905

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:39:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:39:00 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-mhuLyFMU2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #47 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83648&action=edit
Bug 19915: Don't delete in tests

https://bugs.koha-community.org/show_bug.cgi?id=19905

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:39:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:39:04 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-hOZPvmSAZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #48 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83649&action=edit
Bug 19915: (follow-up) Fix test count from rebase

https://bugs.koha-community.org/show_bug.cgi?id=19905

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:38:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:38:56 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-4nS6JSRzv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #46 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83647&action=edit
Bug 19915: Only show class sources in use

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

https://bugs.koha-community.org/show_bug.cgi?id=19905

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 19:41:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 18:41:09 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-Jkv73yA84m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #49 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #42)
> Just a thought: would it be hard to use itemcallnumber if cn_sort is
> empty/not set? That might give some flexibility.

We could, but I am afraid ti wouldn't help since the range passed into the
template is transformed using the classification rules - so an untransformed
callnumebr would likely remain outside the range

> It might be nice to add a script to help people populating this field if it
> was somehow missed during migration or set to a wrong value, but that is out
> of scope here for sure!

Thank you, file a bug and we can look at a future time :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:00:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:00:29 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-HZ99ZTWoSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:00:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:00:32 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-TMaNCYuciN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83640|0                           |1
        is obsolete|                            |

--- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83650&action=edit
Bug 21850: Remove search request from page title of OPAC result list

This patch modifies the OPAC search results template so that advanced
search terms are not shown in the page title and breadcrumbs. This
removes potentially confusing computer-oriented code from the public
view.

For simple searches the search term is displayed, using the same logic
that determines whether the search bar should be populated with the last
search term.

To test:

 - Apply the patch
 - Peform a simple keyword search in the OPAC
   - On the results page the title and breadcrumbs should show 'Results
     of search for [your keyword]
 - Perform an advanced search with multiple parameters
   - The page title and breadrumbs should show only 'Search results'
   - The breadcrumbs should also show a link back to Advanced search
     using the returntosearch parameter

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:10:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:10:38 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-sBo27eSvwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |charles.farmer at inlibro.com

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
I was able to get the same behavior as described in the test plan: "not ok 1 -
token-based tests" but "ok 2 - cookie-based tests"

The following patch made all tests successful.

Had to download Net::OAuth2::AuthorizationServer and activate the syspref
RESTOAuth2ClientCredentials, if anybody needs additional instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:12:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:12:36 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-fhBBXzZACF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83641|0                           |1
        is obsolete|                            |

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83651&action=edit
Bug 22071: Regression tests

The authenticate_api_request() behaviour needs more tests. This patch
adds tests for the stashed Koha::Patron object. It highlights the bug in
the OAuth authentication case.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail in the OAuth case, pass in the cookie-based auth
case.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:12:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:12:40 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-0IvTmH5toP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83642|0                           |1
        is obsolete|                            |

--- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83652&action=edit
Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case

This patch makes the OAuth code stash the requestion Koha::Patron.

To test:
- Apply the tests patch:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail :-(
- Apply this patch
- Run:
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass :-D
- Sign off =D

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:17:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:17:14 +0000
Subject: [Koha-bugs] [Bug 21967] Switch two-column templates to Bootstrap
 grid: Patrons part 4
In-Reply-To: <bug-21967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21967-70-cVdazHqEae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21967

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 21965 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:17:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:17:14 +0000
Subject: [Koha-bugs] [Bug 21965] Switch two-column templates to Bootstrap
 grid: Patrons part 3
In-Reply-To: <bug-21965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21965-70-s3PNtVMF8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21965

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 21967 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:17:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:17:15 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-456wtNi7Yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21967, which changed state.

Bug 21967 Summary: Switch two-column templates to Bootstrap grid: Patrons part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21967

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:19:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:19:22 +0000
Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should
 return if no patron is passed
In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22067-70-pA2bPQub5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:19:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:19:25 +0000
Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should
 return if no patron is passed
In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22067-70-PS3nu5aGz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83629|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83653&action=edit
Bug 22067: Return if no patron passed to can_see_patron_infos

To test:
1 - Find an adult patron
2 - Add a child to their account
3 - Delete the parent from the db
4 - Attempt to edit the child record
5 - Apply patch
6 - Repeat
7 - Note you can edit the child account
8 - Note guarantor id is not a link

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:28:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:28:38 +0000
Subject: [Koha-bugs] [Bug 11894] Funds toolbar menu items greyed out without
	explanation
In-Reply-To: <bug-11894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11894-70-lbsNLYXTtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11894

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:30:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:30:02 +0000
Subject: [Koha-bugs] [Bug 15912] Correct JSHint errors in datatables.js
In-Reply-To: <bug-15912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15912-70-Y2QAhe8a77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15912

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:30:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:30:55 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
	entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-ygvSB2d7I0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:33:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:33:14 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-io9WY6j0VG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83625|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83654&action=edit
Bug 22049: Make MarkIssueReturned rely on returndate only

This patch changes the params accepted by
C4::Circulation::MarkIssueReturned by removing the $dropbox_branch
param.

This passed branchcode was only used to initialize the Koha::Calendar
object, but the date arithmetic has already taken place in a couple
places before we reach this point. This logic needs to be simplified
(bug 14591), and this is the starting point.

To test:
- Apply this patch
- Run:
  $ git grep MarkIssueReturned
=> SUCCESS: Check all the uses of the function either originally passed
undef, or now pass the same date that would've been calculated anyway,
in the returndate param.
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:33:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:33:17 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-cit2fmxqNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83626|0                           |1
        is obsolete|                            |

--- Comment #10 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83655&action=edit
Bug 22049: Add tests

The current tests only check some failure use cases. This patch makes it cover
more use cases

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:33:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:33:22 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-fxBHhvDDP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83627|0                           |1
        is obsolete|                            |

--- Comment #11 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83656&action=edit
Bug 22049: (follow-up) Remove leftover variable

The $circControlBranch variable was originally set to be used to pick
the right dropbox branch. It was only used in MarkIssueReturned, to get
the right Koha::Calendar object. As this responsability was moved top to
the AddReturn caller, and the fact that _GetCircControlBranch is
actually used for fines rules, there's no use for it in this context.
And it was left on the previous patch as a mistake.

To test:
- Make sure the variable is not actually used:
  $ git grep '$circControlBranch'
=> SUCCESS: removed variable is not actually used.
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:44:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:44:32 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-rWwrIZk3iV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83622|0                           |1
        is obsolete|                            |

--- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83657&action=edit
Bug 22051: Add Koha::Exceptions::Object::WrongValue

This patch adds a new exception to be thrown in Koha::Object->store when
a DBIC exception is thrown regarding bad data format.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:44:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:44:37 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-cOowNn1fK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83623|0                           |1
        is obsolete|                            |

--- Comment #8 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83658&action=edit
Bug 22051: Unit tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 20:44:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 19:44:42 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-mO6D0wQNB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83624|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83659&action=edit
Bug 22051: Make Koha::Object->store translate incorrect value exceptions

This patch adds a new condition to Koha::Object->store so it catches
incorrect value-related DBIC exceptions.

This DBIC exceptions get now translated into
Koha::Exceptions::Object::BadValue exceptions with relevant parameters
passed.

To test:
- Apply the exception and unit tests patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because this exception handling code is not
implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:10:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:10:16 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-UXhTiiwpWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

--- Comment #11 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
All seems allright, except the last step where the item doesn't show up when
OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for
you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:18:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:18:08 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-HGJvv8IsrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
My testing of the original issue (on 18.06) could not replicate it.  I was
using the code for the Restricted value, not the description.  The items were
hidden on the opac when Restricted: [1] was in the opachiddenitems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:25:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:25:40 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-tvUabbM6rv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joy, is it possible you used a framework that was not linked to the
authorised value correctly? Looking at the code it can't work with the number,
unless the number is in the description or the authorised value description
cannot be found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:28:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:28:24 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-8KtVV4r7GA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Pierre-Marc Thibault from comment #11)
> All seems allright, except the last step where the item doesn't show up when
> OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for
> you?

Yes it did work - when the pref is empty and read correctly, there is no more
reason to hide it for Koha.

Can you please check that the item didn't fit another criteria for being
hidden? 
Is your system preference OpacHiddenItems really empty?
Is your system set up with memcached and Plack?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:33:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:33:36 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-GSz92Ugu8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83545|0                           |1
        is obsolete|                            |

--- Comment #3 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83660&action=edit
Bug 22052: Unit tests

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:33:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:33:56 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-kseqUgg8FF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83660|0                           |1
        is obsolete|                            |

--- Comment #4 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83661&action=edit
Bug 22052: Unit tests

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:34:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:34:00 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-3p2hrHPOah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83546|0                           |1
        is obsolete|                            |

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83662&action=edit
Bug 22052: Refactor DeleteExpiredOpacReigstrations

This patch changes the sub to use Koha::Objects and updates the tests.
Previously the sub would die on borrowers with checkouts and would
delete borrowers if they had fines

To test:
 1 - prove -v t/db_dependent/
 2 - Set your selfreg preferences:
    PatronSelfRegistration: Allow
    PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
    PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
 3 - Register a patron into SELFREG or how you set above
 4 - Set their date enrolled to two months ago
 5 - Checkout an item to the patron
 6 - Issue a fine to that patron
 7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
 8 - The job should die with an error
 9 - Check in the item
10 - run the corn again - patron is deleted, oops
11 - Apply patch
12 - Create another patron in the same way
13 - Checkout and fine the patron
14 - run the cron
15 - they are not deleted, and no error
16 - checkin the item
17 - run the cron
18 - they are not deleted and no error
19 - clear the fine
20 - run the cron
21 - patron is deleted, huzzah

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:37:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:37:21 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-5D6MuFIjq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
My framework is the Default framework.  952$5 is tied to RESTRICTED authorized
value list.  The RESTRICTED auth value list has code of 1 and description of
"Restricted Access".

OpacHiddenItems contains (with a blank line at end)
itype: [GAMES,EBOOK]
ccode: [REFERENCE,MUSIC]
location: [HOMESCHOOL,PARENTING]
restricted: [1]

My item was none of the values listed below and appeared in OPAC searches. 
When i edit the item to RESTRICTED (items.restricted=1), it dissappears from
searches.  Although number of bibs still show the count of 5, where search
results only show 4.  

(In reply to Katrin Fischer from comment #13)
> Hi Joy, is it possible you used a framework that was not linked to the
> authorised value correctly? Looking at the code it can't work with the
> number, unless the number is in the description or the authorised value
> description cannot be found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:40:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:40:15 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-WqjEfSyOWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Followed test plan, got the "DBD::mysql::st execute failed: Cannot delete or
update a parent row..." has expected.

Patch did what it advertised: self-reg'd borrower couldn't be deleted unless it
had no checked out items, no fines, and all this without crashing the cron in
the mean time.

Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:43:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:43:04 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-bEd3JP68Ab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #16 from Joy Nelson <joy at bywatersolutions.com> ---
Testing with Nick shows that this is dependent on the number of items.  My test
were for a bib with 1 item and that item was restricted.  It does hide the
title from the OPAC because the one item is 'hidden'.

However when another item is added, the hidden item does not appear in search
results (as available), but does appear in the detail page when the title is
clicked on.

(In reply to Joy Nelson from comment #15)
> My framework is the Default framework.  952$5 is tied to RESTRICTED
> authorized value list.  The RESTRICTED auth value list has code of 1 and
> description of "Restricted Access".
> 
> OpacHiddenItems contains (with a blank line at end)
> itype: [GAMES,EBOOK]
> ccode: [REFERENCE,MUSIC]
> location: [HOMESCHOOL,PARENTING]
> restricted: [1]
> 
> My item was none of the values listed below and appeared in OPAC searches. 
> When i edit the item to RESTRICTED (items.restricted=1), it dissappears from
> searches.  Although number of bibs still show the count of 5, where search
> results only show 4.  
> 
> (In reply to Katrin Fischer from comment #13)
> > Hi Joy, is it possible you used a framework that was not linked to the
> > authorised value correctly? Looking at the code it can't work with the
> > number, unless the number is in the description or the authorised value
> > description cannot be found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 21:47:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 20:47:04 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-6aP4HT8kwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #17 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
(In reply to Katrin Fischer from comment #14)
> (In reply to Pierre-Marc Thibault from comment #11)
> > All seems allright, except the last step where the item doesn't show up when
> > OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for
> > you?
> 
> Yes it did work - when the pref is empty and read correctly, there is no
> more reason to hide it for Koha.
> 
> Can you please check that the item didn't fit another criteria for being
> hidden? 
> Is your system preference OpacHiddenItems really empty?
> Is your system set up with memcached and Plack?

Sorry, it was likely a mistake on the refresh of the content.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:03:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:03:29 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-VUnG914soL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83632|0                           |1
        is obsolete|                            |

--- Comment #6 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83663&action=edit
Bug 21813: In-page JavaScript causes error on patron entry page

This patch removes a block of JavaScript from memberentrygen.tt which
was being included in the page before jQuery is loaded. This causes a
JavaScript error.

To test, apply the patch, regenerate CSS, and clear your browser cache
if necessary.

 - In Administration -> Patron categories, confirm that you have two
    patron categories with different default messaging preferences
    defined.
 - Go to Patrons -> New patron
   - Create a new patron using one of the categories with messaging
     preferences.
   - Confirm that when you switch the category selection to the other
     patron category, the patron messaging preference checkboxes are
     changed to the default for that category.
     - A "Loading" indicator should appear above the checkboxes to show
      that an operation is in process. It should disappear when new
      default prefs are loaded.
   - Manually change one or more patron messaging preference checkboxes.
   - Switch the patron category again and confirm that you are prompted
     to confirm resetting the preferences to the default for that
     category.
 - Perform the same set of tests when editing a patron.
   - Defaults should not be loaded during the edit process.
 - Confirm that there are no other JavaScript errors in the console.
 - Test again with EnhancedMessagingPreferences disabled.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:03:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:03:46 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-Z8FMj7ZB9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:28:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:28:48 +0000
Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
In-Reply-To: <bug-5087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5087-70-aUgGK6eQeh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:28:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:28:50 +0000
Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
In-Reply-To: <bug-5087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5087-70-zxhGRYZlZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83438|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83664&action=edit
Bug 5087: Ability to define whether CSV profile shows in OPAC

To test:
1) Update database
2) Update schema
3) In staff side, go to Tools -> CSV profiles
4) Make a CSV profile with profile type = MARC and usage = Export
records
5) Leave 'Show option in OPAC' unchecked and save
6) Go to OPAC and add an item to your cart
7) Click Cart, click Download, confirm that your newly created CSV
profile does not show as an option
8) Go back and edit CSV profile on staff side
9) Check the 'Show option in OPAC' checkbox and save
10) Go back to download cart in OPAC
11) Confirm the CSV profile now shows in the dropdown

Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:30:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:30:20 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-8RG8SRnn5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joy, thx for checking again! I'd need to investigate a bit more, but it's
possible the code for hiding the record is using a slightly different logic.
Koha is always fun ;)

Pierre, is it working ok now for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:32:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:32:59 +0000
Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart
	location
In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18355-70-eXEFnVIYDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:33:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:33:04 +0000
Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart
	location
In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18355-70-PHqenvV0tP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80153|0                           |1
        is obsolete|                            |

--- Comment #41 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83665&action=edit
Bug 18355: Update opac-detail.pl/tt to show both

Adding dependancy of bug 21503 for templates to fully fail correctly.

To Test this patch:

1) Apply patch / restart_all
2) Check out an item.
3) Check item in with ReturnToShelvingCart set to Move.
4) View the item in opac-detail.pl and see the permanent location, and
the cart location in parentesis.
5) Try removing opac description from the cart and item sleving
location.  Refresh opac-detail.pl.  Should default to regular
description.  (If not, may need patch 21503 to test.)
6) To test for code replacement if regular and opac description are
missing, you WILL need patch 21503.

Signed-off-by: Jose-Mario <jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:34:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:34:18 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-T4Agw3buPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #19 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
I didn't complete the test since there is a current conversation involving Joy
which let me think there is a problem that is not in the test plan and that
would make my sign off meaningless. I am wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:45:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:45:45 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-wqL1wQquxX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OpacHiddenItems not working |OpacHiddenItems not working
                   |for restricted              |for restricted on OPAC
                   |                            |detail

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If I understood correctly, you can still sign off. This deals with the case,
that not all items on a record are hidden and the OPAC detail pages.

You could extend the test plan a bit:
- Verify that if the restricted item is the only item, the record cannot be
found in the OPAC
- Verfy you can't access the record directly by URL
- Verify the item information in the results is correct

>From what Joy said those already work, but should not be broken by the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:51:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:51:48 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21929-70-JFycczIHWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 18.05 for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:55:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:55:55 +0000
Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins
In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22053-70-toD6MnoR6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

--- Comment #9 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83666&action=edit
Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted

The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't
exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:55:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:55:58 +0000
Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins
In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22053-70-SwBvJpcmi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

--- Comment #10 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83667&action=edit
Bug 10676: Add unit tests - GetItemsInfo

To test:
  prove t/db_dependent/Items.t

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:59:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:59:16 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-SvXpaB2iPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83630|0                           |1
        is obsolete|                            |

--- Comment #21 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83668&action=edit
Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted

The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't
exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

https://bugs.koha-community.org/show_bug.cgi?id=22053

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:59:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:59:19 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-EsFs5Sstrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83631|0                           |1
        is obsolete|                            |

--- Comment #22 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83669&action=edit
Bug 10676: Add unit tests - GetItemsInfo

To test:
  prove t/db_dependent/Items.t

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

https://bugs.koha-community.org/show_bug.cgi?id=22053

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 22:59:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 21:59:20 +0000
Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14393-70-lbCGJ1b7gD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #21 from Charles Farmer <charles.farmer at inlibro.com> ---
Merging seems to fail because of HTML filters and whatnot, pretty expected from
a 2015 patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:04:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:04:54 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-51NAIoJZSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83668|0                           |1
        is obsolete|                            |

--- Comment #23 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83670&action=edit
Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted

The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't
exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:04:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:04:57 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-IHaEM35clF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83669|0                           |1
        is obsolete|                            |

--- Comment #24 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83671&action=edit
Bug 10676: Add unit tests - GetItemsInfo

To test:
  prove t/db_dependent/Items.t

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:05:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:05:48 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-5GFctcXhNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #25 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
(In reply to Pierre-Marc Thibault from comment #22)
> Created attachment 83669 [details] [review]
> Bug 10676: Add unit tests - GetItemsInfo
> 
> To test:
>   prove t/db_dependent/Items.t
> 
> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
> 
> https://bugs.koha-community.org/show_bug.cgi?id=22053

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:11:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:11:06 +0000
Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
 on OPAC detail
In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10676-70-wNdqUxBOGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

--- Comment #26 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Your test plan works and it doesn't seem there's a problem with the extended
steps either. Sorry, for the mistakes I made while editing the page, I will try
to be more focus next time. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:11:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:11:48 +0000
Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts
In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20000-70-JwAbf8Dvv5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:11:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:11:50 +0000
Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts
In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20000-70-Hs2rxjRxAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83402|0                           |1
        is obsolete|                            |

--- Comment #18 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83672&action=edit
Bug 20000: Use Modern::Perl in installer scripts

To test:

Check that we are using Modern::Perl when strict *and* warnings were used
before,
and commented lines and FIXMEs have been removed from the rest, out of
files listed below.

data/mysql/backfill_statistics.pl
data/mysql/labels_upgrade.pl
data/mysql/patroncards_upgrade.pl
data/mysql/update22to30.pl
data/mysql/updatedatabase.pl
externalmodules.pl
html-template-to-template-toolkit.pl
install.pl

Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:13:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:13:13 +0000
Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins
In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22053-70-bmg9kXmxE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83667|0                           |1
        is obsolete|                            |
  Attachment #83667|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:13:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:13:39 +0000
Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins
In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22053-70-MqcxyUV7S5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83666|0                           |1
        is obsolete|                            |
  Attachment #83666|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:36:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:36:41 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-NJ0KiuKHV4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

mikael Olangcay Brisebois <mikael at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83650|0                           |1
        is obsolete|                            |

--- Comment #5 from mikael Olangcay Brisebois <mikael at inLibro.com> ---
Created attachment 83673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83673&action=edit
Bug 21850: Remove search request from page title of OPAC result list

This patch modifies the OPAC search results template so that advanced
search terms are not shown in the page title and breadcrumbs. This
removes potentially confusing computer-oriented code from the public
view.

For simple searches the search term is displayed, using the same logic
that determines whether the search bar should be populated with the last
search term.

To test:

 - Apply the patch
 - Peform a simple keyword search in the OPAC
   - On the results page the title and breadcrumbs should show 'Results
     of search for [your keyword]
 - Perform an advanced search with multiple parameters
   - The page title and breadrumbs should show only 'Search results'
   - The breadcrumbs should also show a link back to Advanced search
     using the returntosearch parameter

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: mikael <mikael.Olangcay-Brisebois at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan  4 23:59:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Jan 2019 22:59:43 +0000
Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too
 many items to display unless viewing them all
In-Reply-To: <bug-13654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13654-70-spkNHbXXdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #11 from Charles Farmer <charles.farmer at inlibro.com> ---
In the case where neither CountItemsIssued nor
$biblio->has_items_waiting_or_intransit return 1, pushing AllowOnShelfHolds =>
1 to the template doesn't seem enough, since the ReservableItems variable
wouldn't have been initialized in opac-details.pl. On my end, at least, this
means that I'm still not able to see the 'Place hold' button after applying the
patch.

I would suggest either also sending ReservableItems to the template, or simply
setting $allow_onshelf_holds = 1.

Still a bit too early to put this as Failed QA, as I'm not a QA person myself,
but the patch doesn't feel quite right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan  5 03:46:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Jan 2019 02:46:56 +0000
Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional
	categories
In-Reply-To: <bug-15174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15174-70-NMtJuQBa98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174

cfhong2000 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cfhong2000 at gmail.com

--- Comment #9 from cfhong2000 at gmail.com ---
Hi,

Can this patch be applied to Koha 18.05? 
If so, how do I apply this patch?

Thanks,
Chee

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 00:18:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Jan 2019 23:18:09 +0000
Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14393-70-2FRJGkDxU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #22 from David Cook <dcook at prosentient.com.au> ---
(In reply to Charles Farmer from comment #21)
> Merging seems to fail because of HTML filters and whatnot, pretty expected
> from a 2015 patch.

Thanks for checking, Charles. 

Looks like the patch is 9474 commits behind master. Let me try rebasing it.

Not a trivial rebase at a glance. Will have to look at this more some other
time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 00:29:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Jan 2019 23:29:52 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-adRjlW5pBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #30 from David Cook <dcook at prosentient.com.au> ---
(In reply to Colin Campbell from comment #25)
> Text::Unaccent does not build on 64bit systems, the tests fail because of
> errors in the ccode. There has been a patch for that for four years but it
> looks like the upstream code is moribund. If you look at the test results it
> now fails on all linux test builds. The module has not been kept up to date
> to handle modern perl strings. I think the debian version may be patched to
> fix the bug in 64bit tests but it is buggy and should not be relied on.
> Suggest moving to Text::Unaccent::PurPerl be prioritized

I just ran into this again. 

Can't build on a 64 bit system running Perl 5.26. If you do force the build and
install, you'll just get difficult to diagnose 500 errors in Koha.

As Colin mentioned, there's been known issues for this for ages:
https://rt.cpan.org/Public/Dist/Display.html?Name=Text-Unaccent

I've gone to https://packages.debian.org/stretch/libtext-unaccent-perl to see
if I can find the patch that Debian uses.

I reckon
http://deb.debian.org/debian/pool/main/libt/libtext-unaccent-perl/libtext-unaccent-perl_1.08-1.3.diff.gz
is the patch but the Debian CDN keeps timing out on me. 

When I try with curl, it seems like the CDN is refusing connections on port 80
and 443, so something looks like it's up with Debian...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 00:31:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Jan 2019 23:31:05 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-Ou8JoU9v37@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
In any case, this seems like a major sticking point for anyone not using
Debian-based distros.

For now, I'm just removing Text::Unaccent where necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 00:41:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Jan 2019 23:41:36 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-8p3AgQaxAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #32 from David Cook <dcook at prosentient.com.au> ---
Went to the Australia mirror...

http://ftp.au.debian.org/debian/pool/main/libt/libtext-unaccent-perl/

http://ftp.au.debian.org/debian/pool/main/libt/libtext-unaccent-perl/libtext-unaccent-perl_1.08-1.3.diff.gz

Patch looks consistent with the following:

https://bugs.launchpad.net/ubuntu/+source/libtext-unaccent-perl/+bug/460640

https://rt.cpan.org/Public/Bug/Display.html?id=21177

I don't think the maintainer has done anything on CPAN or Debian for many
years. Looks like other Debian folk fixed the Debian package, and CPAN is just
abandoned.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 06:54:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 05:54:42 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-pHPKjAP8NN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #27 from David Cook <dcook at prosentient.com.au> ---
Just confirming that I'm issues with the fixFloat plugin as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 07:05:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 06:05:14 +0000
Subject: [Koha-bugs] [Bug 21089] Bad floats in Ordering information on
	acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-BZrgj48kxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Still an issue in 18.11.x, although it doesn't look like floats. Rather than
the position for a few "ol" elements with the radio class are relative and
that's causing the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 07:06:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 06:06:26 +0000
Subject: [Koha-bugs] [Bug 21089] Bad overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-mEaWiGoKVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bad floats in Ordering      |Bad overlapping elements in
                   |information on              |ordering information on
                   |acqui/supplier.pl           |acqui/supplier.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 07:07:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 06:07:14 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-mgbkEUE9mq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bad overlapping elements in |Overlapping elements in
                   |ordering information on     |ordering information on
                   |acqui/supplier.pl           |acqui/supplier.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 07:17:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 06:17:22 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-CB3zorxbsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #28 from David Cook <dcook at prosentient.com.au> ---
I imagine this must be affecting a number of people in production?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 07:34:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 06:34:34 +0000
Subject: [Koha-bugs] [Bug 22072] New: Datatable Javascript error on
 subscription-detail.pl
Message-ID: <bug-22072-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22072

            Bug ID: 22072
           Summary: Datatable Javascript error on subscription-detail.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

When I create a fresh git install of Koha and go to
/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1, I'm seeing the
following in the console:

jquery.treetable_18.1101000.js:481 Uncaught TypeError: Cannot read property
'expandAll' of undefined
    at a.fn.init.expandAll (jquery.treetable_18.1101000.js:481)
    at a.fn.init.$.fn.treetable (jquery.treetable_18.1101000.js:608)
    at HTMLDocument.<anonymous> (subscription-detail.pl?subscriptionid=1:952)
    at i (jquery-2.2.3.min_18.1101000.js:2)
    at Object.fireWith [as resolveWith] (jquery-2.2.3.min_18.1101000.js:2)
    at Function.ready (jquery-2.2.3.min_18.1101000.js:2)
    at HTMLDocument.J (jquery-2.2.3.min_18.1101000.js:2)

This is invoked by the second function call here:

            $(table).treetable({
                expandable: true
            });
            $(table).treetable('expandAll');

The table is for "orders" which doesn't sound familiar to me on this page, but
oh well. Should be an easy enough fix. I don't have time for it now, so just
reporting here for the time being.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 07:49:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 06:49:35 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-98h0wAjauD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You could help by signing off bug 21813 ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 08:04:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 07:04:04 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-LnYqOVeq41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
                 CC|                            |joy at bywatersolutions.com

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #26)
> After gaining more experience with RDF and triplestores, I'm not really
> happy with this one anymore. 
> 
> This functionality should probably be moved into a Koha::RDF::Triplestore
> module, as it's very triplestore specific... or maybe Koha::RDF::Model...
> since you could use other non-triplestore models. 
> 
> But there's other things that can be done in Koha::RDF that don't need to
> relate to models/triplestores...

>For what it's worth, I'm no longer convinced what I have here is the best way >forward, but I suppose it's better than nothing.

Those comments make me doubt that we should put more work into this. I'd really
like to get more opinions on this. I am asking for a second sign-off, also to
widen the audience on this bug beyond the QA team.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 08:06:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 07:06:31 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-yglDHJj579@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like to ask for a second sign-off, see also bug 18713 comment 32

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 08:52:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 07:52:50 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-L0sy6hpK61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 10:02:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 09:02:13 +0000
Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints
 and is never cleaned up
In-Reply-To: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13515-70-wiV23OESWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515

--- Comment #11 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Nick Clemens from comment #10)
> The update doe snot appear to be idempotent - can you check the condition?
> 
Yep. Constraint nameis wrong in foreign_key_exists call. Need a follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 10:17:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 09:17:04 +0000
Subject: [Koha-bugs] [Bug 18175] Makefile sets koha-httpd api path
 incorrectly for standard installs
In-Reply-To: <bug-18175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18175-70-THfRNilToA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 10:35:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 09:35:53 +0000
Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber
	does not work
In-Reply-To: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21460-70-vPTN3tVNSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 10:35:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 09:35:56 +0000
Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber
	does not work
In-Reply-To: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21460-70-c44ENmu2VI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460

--- Comment #21 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 83674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83674&action=edit
Bug 21460: (follow-up) Filter params in .pl

This patch filters the passed parameters in the .pl, rather than doing
it in the template. As per comment 16
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460#c16)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 10:48:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 09:48:48 +0000
Subject: [Koha-bugs] [Bug 18175] Makefile sets koha-httpd api path
 incorrectly for standard installs
In-Reply-To: <bug-18175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18175-70-0J1OvGzBqY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I 'think' this problem has gone away now..  going to mark as resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:01:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:01:05 +0000
Subject: [Koha-bugs] [Bug 21686] Koha::Account->pay has no tests
In-Reply-To: <bug-21686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21686-70-Cs5dlF6P2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21686

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Brill, I must have just missed them.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:02:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:02:53 +0000
Subject: [Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
In-Reply-To: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21993-70-JMTRWA8QPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83389|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83675&action=edit
Bug 21993: Display a user-friendly message when the CSRF token is wrong

Instead of dying!

Test plan:
Assuming you have a patron with borrowernumber=51 and another one that
can be deleted with borrowernumber=42

- authorities-home.pl
 * Delete an authority record
 * hit /cgi-bin/koha/authorities/authorities-home.pl?op=delete

- basket/sendbasket.pl
 * Send a basket to someone
 * hit /cgi-bin/koha/basket/sendbasket.pl?email_add=1

- members/apikeys.pl
  * Generate and delete an API key for a patron
  * hit /cgi-bin/koha/members/apikeys.pl?patron_id=51&op=delete

- members/deletemem.pl
  * Delete a patron
  * hit /cgi-bin/koha/members/deletemem.pl?member=42&op=delete_confirmed

- members/mancredit.pl
  * Add a manual credit
  * hit /cgi-bin/koha/members/mancredit.pl?borrowernumber=51&add=1

- members/maninvoice.pl
  * Add a manual invoice
  * hit /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51&add=1

- members/member-flags.pl
  * Change permissions for a patron
  * hit /cgi-bin/koha/members/member-flags.pl?member=51&newflags=1

- members/member-password.pl
  * Change the password for a patron (from the staff interface)
  * hit /cgi-bin/koha/members/member-password.pl?member=51&newpassword=aA1

- members/memberentry.pl
  * Edit some patron's info
  * hit /cgi-bin/koha/members/memberentry.pl?borrowernumber=51&op=save

- members/paycollect.pl
  * Pay an individual fine
  * hit something like
/cgi-bin/koha/members/paycollect.pl?borrowernumber=51&pay_individual=1&accounttype=L&amount=1.00&amountoutstanding=1.00&accountlines_id=157&paid=1
  You may need to edit some values

- tools/import_borrowers.pl
  * Import some patrons
  * hit /cgi-bin/koha/tools/import_borrowers.pl?uploadborrowers=1

- tools/picture-upload.pl
  * Upload an image for a patron
  * You will need to edit the html content
  hit Home ? Tools ? Upload patron images
  then locate the csrf_token input and modify its value

Note for QA:
- Opac is not done as blocking_errors.inc does not exist for this
interface
- ill/ill-requests.pl
I did not manage to replace this occurrence

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:04:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:04:03 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To: <bug-21875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21875-70-KD8DmKuF5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:04:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:04:13 +0000
Subject: [Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
In-Reply-To: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21993-70-sQGV2i20qC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Great idea!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:04:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:04:34 +0000
Subject: [Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
In-Reply-To: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21993-70-tbjah9ozUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:07:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:07:29 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-G6h12Ixxw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This one probably deserves a t/db_dependent/selenium/regressions.t test.
Specially if we allow HTML in note fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:09:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:09:03 +0000
Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to
 enable users to renew before the autorenew date
In-Reply-To: <bug-22018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22018-70-KXJw4Gt3kk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:25:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:25:35 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-1Yii9FREwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
         QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:39:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:39:15 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-KcGzzxJvE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83676&action=edit
Bug 22071: (follow-up) Simplify code

In order to add features to this method, the current code would force us
to do it for each authentication method.

There's duplicated code that could be simplified. This patch makes the
authentication code just set $user on each block (oauth and cookie
authentication) and moves the final permissions check to the end of the
authenticate_api_request method.

Overall, the behaviour remains unchanged.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
          t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass! Nothing changed!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:39:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:39:20 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-VYgTMAf5UH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83677&action=edit
Bug 22071: (follow-up) Add POD for validate_query_parameters

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 11:40:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 10:40:00 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-ETYV1KZKaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:26:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:26:06 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-mNNoOKsPo3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83661|0                           |1
        is obsolete|                            |

--- Comment #7 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83678&action=edit
Bug 22052: Unit tests

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:26:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:26:15 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-cySf77mg7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83662|0                           |1
        is obsolete|                            |

--- Comment #8 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83679&action=edit
Bug 22052: Refactor DeleteExpiredOpacReigstrations

This patch changes the sub to use Koha::Objects and updates the tests.
Previously the sub would die on borrowers with checkouts and would
delete borrowers if they had fines

To test:
 1 - prove -v t/db_dependent/
 2 - Set your selfreg preferences:
    PatronSelfRegistration: Allow
    PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
    PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
 3 - Register a patron into SELFREG or how you set above
 4 - Set their date enrolled to two months ago
 5 - Checkout an item to the patron
 6 - Issue a fine to that patron
 7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
 8 - The job should die with an error
 9 - Check in the item
10 - run the corn again - patron is deleted, oops
11 - Apply patch
12 - Create another patron in the same way
13 - Checkout and fine the patron
14 - run the cron
15 - they are not deleted, and no error
16 - checkin the item
17 - run the cron
18 - they are not deleted and no error
19 - clear the fine
20 - run the cron
21 - patron is deleted, huzzah

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:26:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:26:46 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-fP1qMutfhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:32:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:32:20 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-oZR4lddSHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83680&action=edit
Bug 22061: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:32:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:32:28 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-j43W9NLmbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83682&action=edit
Bug 22061: Public route to change password

This patch implements a route to change patron's password for
unprivileged users. It's intended for using in the OPAC (or however
consumers find it useful).

It is a starting point for the public API, and the bug also implements
the on/off switch some community members asked for.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t \
          t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass! i.e.
        - RESTPublicAPI is honoured
        - The /public/patrons/:patron_id/password endpoint works as
        expected
- Use your favourite API testing tool to try the endpoint.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:32:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:32:25 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-RFlEzPUaQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83681&action=edit
Bug 22061: OpenAPI spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:33:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:33:17 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-VK02WMyzrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |josef.moravec at gmail.com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 12:35:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 11:35:21 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-XjIzIBTkyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

--- Comment #9 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Patch does the job. Test are ok. Code review is ok. So passed QA.

However (and that doesn't put these patches in discussion), i'm wondering if
should not move the self registered patrons in the deletedborrower table before
deleting. Does that make sense to create an other bug ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:21:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:21:16 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-SWeYWdPA6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:21:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:21:23 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-cx1I1M8KIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:30:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:30:16 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-iJjLBf3xFt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83683&action=edit
Bug 21198: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:30:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:30:25 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-GnQhcvEKck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83684&action=edit
Bug 21198: Make authenticate_api_request stash the reason access is granted

This patch makes the authenticate_api_request method stash the reason
the request or has been granted access to the resource.

Possible values are:
- permissions
- owner
- guarantor

This will allow the controllers to avoid querying on their own for this
info.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:35:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:35:50 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-EEh5B69INg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
When I thought about this, I was writing the /patrons/:patron_id/password
endpoint, which was an hybrid endpoint: it was intended for the user to change
its own password, and also an admin user to change a patron's password. It
required the controller to check what was the reason to grant access to the
resource.

We decided to create a /public namespace for endpoints that would be used by
unprivileged users instead.

I decided to still submit this, because
- We might need it
- People writing endpoints through plugins could take advantage of this

I hope you'll agree with this enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:40:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:40:40 +0000
Subject: [Koha-bugs] [Bug 18531] Add an endpoint for use by GOBI
In-Reply-To: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18531-70-GW7FNmHenT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST api: Add an endpoint   |Add an endpoint for use by
                   |for use by GOBI             |GOBI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:43:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:43:40 +0000
Subject: [Koha-bugs] [Bug 18531] Add an endpoint for use by GOBI
In-Reply-To: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18531-70-Uh2R11loDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX
                URL|                            |https://github.com/thekesol
                   |                            |utions/koha-plugin-gobi

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jon Knight from comment #1)
> Is there a link for documentation on the GOBI API available?  I've been
> asked about integrating it with our open source LORLS reading list system
> (which itself is integrated with our live Koha instance) but my Google-fu
> has let me down finding any public documentation about how the GobiAPI works
> or the XML it expects/generates.
> 
> If I could hit this bug fix at the same time it could kill two birds with
> one stone.

Jon, I wrote a Koha plugin to deal with this. The GOBI docs are proprietary-ish
but I was allowed to distribute the sample messages along with the plugin:

https://github.com/thekesolutions/koha-plugin-gobi

I'm closing this bug as I won't be making this Koha-proper at the time being.
Feel free to approach me on IRC or email to talk about this if you need it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 14:48:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 13:48:31 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-xRhn9wJZyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Branchcode should be        |branchcode should be
                   |recorded for manual credits |recorded for manual credits

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:05:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:05:02 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-82X2fE0QSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:05:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:05:05 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-EzwgY6IBQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83685&action=edit
Bug 21089: Overlapping elements in ordering information on acqui/supplier.pl

This patch changes the HTML structure of the vendor edit page so that
the markup is a little simpler. CSS is modified to match. This structure
should serve as a model for other similar form structures:

 <fieldset class="rows">
     <ol>
         <li>
             <label>General label:</label>
             <label class="radio">
                 Specific label 1 <input type="radio" />
             </label>
             <label class="radio">
                 Specific label 2 <input type="radio" />
             </label>
         </li>
     </ol>
 </fieldset>

To test, apply the patch and regenerate the staff client CSS.

 - Go to Acquisitions -> Vendor search -> Vendor -> Edit vendor
 - In the "Ordering information" section, confirm that the position of
   radio buttons looks correct.
 - Confirm that radio button labels work correctly.
 - Confirm that the adjacent dropdown menus work well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:05:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:05:21 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-qaOYWewbYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:16:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:16:27 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-Sf40OQoA1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83651|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83686&action=edit
Bug 22071: Regression tests

The authenticate_api_request() behaviour needs more tests. This patch
adds tests for the stashed Koha::Patron object. It highlights the bug in
the OAuth authentication case.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail in the OAuth case, pass in the cookie-based auth
case.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:16:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:16:31 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-7QjEq6A3fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83652|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83687&action=edit
Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case

This patch makes the OAuth code stash the requestion Koha::Patron.

To test:
- Apply the tests patch:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail :-(
- Apply this patch
- Run:
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass :-D
- Sign off =D

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:16:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:16:35 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-TuH33ILBwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83676|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83688&action=edit
Bug 22071: (follow-up) Simplify code

In order to add features to this method, the current code would force us
to do it for each authentication method.

There's duplicated code that could be simplified. This patch makes the
authentication code just set $user on each block (oauth and cookie
authentication) and moves the final permissions check to the end of the
authenticate_api_request method.

Overall, the behaviour remains unchanged.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
          t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass! Nothing changed!
- Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:16:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:16:38 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-Lnyk83y3KN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83677|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83689&action=edit
Bug 22071: (follow-up) Add POD for validate_query_parameters

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:17:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:17:21 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-X9G8vtdFeq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
A solid improvement to the existing code and good additional of tests.  No
regressions found and no qa failures found.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:23:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:23:13 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_New=3A_Diacritics_=C5=BD_an?=
 =?utf-8?q?d_=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
Message-ID: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

            Bug ID: 22073
           Summary: Diacritics ? and ? not being mapped for searching
                    (Non-ICU)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Zebra
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
  Target Milestone: ---

To recreate:
0 - Ensure your catalog is not using ICU
1 - Find or add a record by author Slavoj ?i?ek
2 - Search for 'Zizek'
3 - No results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:27:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:27:21 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-nU4rrcfbDN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83690&action=edit
Bug 22076: Add to diacritics mappings for ? and ?

To test:
1 - Find or add a record by author Slavoj ?i?ek
2 - Search for 'Zizek'
3 - No results
4 - Apply patch
5 - Reindex
6 - Search again
7 - Success!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:27:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:27:44 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-GFuNrmpPbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83691&action=edit
Bug 22073: Add to diacritics mappings for ? and ?

To test:
1 - Find or add a record by author Slavoj ?i?ek
2 - Search for 'Zizek'
3 - No results
4 - Apply patch
5 - Reindex
6 - Search again
7 - Success!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:28:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:28:04 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-7uFihjGiM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83690|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:30:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:30:01 +0000
Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching
	(Non-ICU)
In-Reply-To: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8426-70-imAqhsFLpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81722|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:30:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:30:44 +0000
Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching
	(Non-ICU)
In-Reply-To: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8426-70-By4QYOjbfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #11)
> (In reply to Owen Leonard from comment #9)
> > Is this patch still relevant? Comments here are contradictory. If this
> > should still be tested please provide a detailed test plan.
> 
> Still relevant, plan for Kyle's patch is similar to follow-up:
> 
> 1 - Import the sample record
> 2 - Search for Zhar-ptitsa
> 3 - No result
> 4 - Apply patch
> 5 - You may need to cp word-phrase-utf.chr from
> /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to
> /etc/koha/zebradb/etc/word-phrase-utf.chr
> (backup your original first)
> 6 - Reindex zebra
> 7 - Search again, you should get result

Z problems moved to bug 22073 as the patches for original issue don't seem to
work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:31:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:31:10 +0000
Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching
	(Non-ICU)
In-Reply-To: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8426-70-XN0T6vdIhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle.m.hall at gmail.com       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:52:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:52:02 +0000
Subject: [Koha-bugs] [Bug 21816] [OMNIBUS] Ease the write of our tests
In-Reply-To: <bug-21816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21816-70-5UFefKr1ou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816
Bug 21816 depends on bug 21817, which changed state.

Bug 21817 Summary: Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:52:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:52:01 +0000
Subject: [Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks
	method
In-Reply-To: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21817-70-teszPeIvP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
At this early stage in the cycle, I have decided to backport this one as I'm
envisaging it may be required by future ports and it doesn't cause any
noticable changes for the end user.

Pushed to 18.11.x for 18.11.02

RMaint note, I personally wouldn't feel the need to port this any further back
than the 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 15:55:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 14:55:38 +0000
Subject: [Koha-bugs] [Bug 21902] OPAC login should redirect to referring page
In-Reply-To: <bug-21902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21902-70-ayg25G4K5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21902

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Hugo Agud from comment #0)
> Some services at koha request to be logged for example holds, suggestions,
> send email , add to lists... 
> 
> the issue is that once you're logged koha redirect the user to 'my account'
> and looses the previous page... for example the search, the record..
> whatever.
> 
> It should be great to add a syspref to allow admin decide what happends
> after a login... if it keeps to the previous page or if it moves to my
> account

Hello Hugo,

That seems to work already, if i'm not wrong.
Please try this test plan:

- as anonymous user, make a search at the opac side,
- click "place hold" link on a document,
- Koha request you to be logged in,
- login,
- your redirected to the hold process page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:02:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:02:37 +0000
Subject: [Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should
 preserve call context
In-Reply-To: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21909-70-g8ymP3EXKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
           Severity|enhancement                 |minor

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm changing this from 'enhancement' to 'minor' as I believe it was a mistake
and thus a bug in the first place for the caller context to be lost..  as such:

Pushed to 18.11.x for 18.11.02.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:05:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:05:07 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-jeZWwrmmOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:06:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:06:17 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires 'username' to be
	cardnumber
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-sR9hb51xAh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:06:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:06:57 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-Z2CT2nuyIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OverDrive requires          |OverDrive requires
                   |'username' to be cardnumber |configuration for field
                   |                            |passed as username

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:09:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:09:03 +0000
Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
In-Reply-To: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16939-70-BO60ChL1Ra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:10:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:10:33 +0000
Subject: [Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not
	working
In-Reply-To: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21928-70-O6U44H64Mq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:14:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:14:37 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-FsQNAIArCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:16:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:16:31 +0000
Subject: [Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the
	purpose
In-Reply-To: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21578-70-Pte2fmOfVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This would cause an unexpected end user-facing change in the stable branch..
Upping to 'enhancement' and stating intention not to backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:18:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:18:59 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-8x1AeQwyU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:19:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:19:17 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-ZqmInyPhij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:20:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:20:16 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-lGsQImaZTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:20:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:20:52 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-Z9KOCBqqxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Cosmetic fix, Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:33:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:33:09 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-zB0mH8uGr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:33:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:33:12 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-JrRjnp0SAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83403|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83692&action=edit
Bug 22030: Use preference to determine username sent to overdrive

Overdrive configuration generally defaults to cardnumber, however, they
have confirmed that some libraries use usernames. We need to allow for
both scenarios.

To test:
1 - Have an OverDrive account setup with SIP authentication
    Note: You can apply for a testing account at developer.overdrive.com
    and setup an environment
2 - Fill in all your OverDrive system preferences
3 - Test with a patron whose username is their cardnumber
4 - Confirm their overdrive account tab on opac loads
5 - Change the username to be another value like "borked_wont_work"
6 - Note the overdrive account tab won't load
7 - Apply patch, update database, change the system preference
8 - Note the OD account loads successfully

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:39:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:39:31 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-LcZvOAZAhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:42:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:42:58 +0000
Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines
In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19066-70-AmIPeHG1Ol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #96 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:42:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:42:59 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-61jE81ppa5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461
Bug 16461 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:00 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-Rd4nzpPykq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
Bug 21002 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:01 +0000
Subject: [Koha-bugs] [Bug 21401] Account offsets should save the transacting
	library
In-Reply-To: <bug-21401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21401-70-rcdR95EtvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401
Bug 21401 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:01 +0000
Subject: [Koha-bugs] [Bug 21786] Routes for credits should include library_id
In-Reply-To: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21786-70-JYfzVGHf8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786
Bug 21786 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:01 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-Uzr7sfiWUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788
Bug 21788 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:02 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-96cQJLY16q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066
Bug 22066 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:01 +0000
Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when
 adding accountlines
In-Reply-To: <bug-21801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21801-70-Jf2Cl3Z5Pw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801
Bug 21801 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:43:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:43:02 +0000
Subject: [Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and
 "Reserve Charge" does not create account offset
In-Reply-To: <bug-21678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21678-70-Y2c9e22Ndr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678
Bug 21678 depends on bug 19066, which changed state.

Bug 19066 Summary: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:45:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:45:49 +0000
Subject: [Koha-bugs] [Bug 22074] New: Printer friendly Reading History
Message-ID: <bug-22074-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22074

            Bug ID: 22074
           Summary: Printer friendly Reading History
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: karen.fellows at citruslibraries.org
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

We have had some patrons request a more printer friendly version of their
reading history.  They like to have the list handy when browsing for books. 
Right now, printing is possible, but it yields way too many pages and also
shows book covers/images and extra stuff that is not needed.  Just a simple
title and author list would be a great enhancement for our patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:51:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:51:13 +0000
Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates
In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18789-70-oglY87Klyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
  Text to go in the|                            |RMaint Note: Followup in
      release notes|                            |bug 21928 causes this bug
                   |                            |to appear in release note..
                   |                            |remove before release!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:52:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:52:51 +0000
Subject: [Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove
	sub goodkey
In-Reply-To: <bug-21547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21547-70-H4Qb1NhOJc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Architectural enhancement
      release notes|                            |backported to 18.11.x
                   |                            |series to aid future
                   |                            |backports. There should be
                   |                            |no noticeable effects for
                   |                            |the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:54:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:54:56 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-o2SUacHohH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83692|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83693&action=edit
Bug 22030: Use preference to determine username sent to overdrive

Overdrive configuration generally defaults to cardnumber, however, they
have confirmed that some libraries use usernames. We need to allow for
both scenarios.

To test:
1 - Have an OverDrive account setup with SIP authentication
    Note: You can apply for a testing account at developer.overdrive.com
    and setup an environment
2 - Fill in all your OverDrive system preferences
3 - Test with a patron whose username is their cardnumber
4 - Confirm their overdrive account tab on opac loads
5 - Change the username to be another value like "borked_wont_work"
6 - Note the overdrive account tab won't load
7 - Apply patch, update database, not new system preference
OverDriveUsername (default to 'cardnumber)
8 - Note the OD account loads successfully
9 - Change the system preference to 'user name' - the account load fails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:55:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:55:13 +0000
Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and
 a filter presence test to Koha
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-hkrRUCOuvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This important improvement  |RMaint Note: The inclusion
      release notes|to Koha's security policy   |of bug 22007 in 18.11.02
                   |greatly decreases the       |means this enhancement bug
                   |likelihood of XSS           |gets added to the release
                   |vulnerabilities being       |notes.. It should be
                   |introduced into the Koha    |removed before release!
                   |codebase moving forward. We |
                   |have introduced the         |
                   |requirement for all         |
                   |variables inside templates  |
                   |to be passed through a      |
                   |filter and added a test to  |
                   |check this requirement is   |
                   |being upheld.               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 16:58:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 15:58:24 +0000
Subject: [Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks
	method
In-Reply-To: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21817-70-PjdEGP4cLX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Test suit enhancement
      release notes|                            |backported to 18.11.x
                   |                            |series to aid future
                   |                            |backports. There should be
                   |                            |no noticeable effects for
                   |                            |the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 17:29:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 16:29:33 +0000
Subject: [Koha-bugs] [Bug 9606] If you export to Ris the page information is
	not included
In-Reply-To: <bug-9606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9606-70-2BD2b6KCGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |normal

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is still valid for RIS at least. 

It might require some "clever" guessing as the page information is stored in a
non-structured way in 773$g (also: mutli-lingual: German S., English p.) and
RIS expects start (SP) and end page (EP) in separate lines.

I consider this a bug and not an enhancement as the information is vital for
articles.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 17:32:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 16:32:38 +0000
Subject: [Koha-bugs] [Bug 22075] New: Encoding problem with RIS export
Message-ID: <bug-22075-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

            Bug ID: 22075
           Summary: Encoding problem with RIS export
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When exporting a record in RIS format from the detail page in OPAC the encoding
is incorrect. If you open the RIS file in a text editor, umlauts and other
diacritics are not displayed correctly.

Tested with 17.11, needs confirmation for master still.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 17:33:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 16:33:36 +0000
Subject: [Koha-bugs] [Bug 22075] Encoding problem with RIS export
In-Reply-To: <bug-22075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22075-70-PPT2MlU4dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.11                       |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:30:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:30:05 +0000
Subject: [Koha-bugs] [Bug 22075] Encoding problem with RIS export
In-Reply-To: <bug-22075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22075-70-unht8n3QYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22075

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:38:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:38:47 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-0ODIASw2vn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #95 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Josef Moravec from comment #89)
> Nick, why do you prefer to _ALL_ rule override everything? Shouldn't the
> most specific rule be the first taken into account and _ALL_ rule used as
> fallback? I imagine it could simplify the setting  on systems with many
> locations.

I suppose my thought was that _ALL_ could be used to circumvent all others in a
scenario where you had a closing or something.

I am not sure I envisioned a scenario where ALL would be used constantly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:45:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:45:30 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-saPaFFem4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:45:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:45:23 +0000
Subject: [Koha-bugs] [Bug 22076] New: SIP checkin for withdrawn item returns
 ok in checkin response
Message-ID: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

            Bug ID: 22076
           Summary: SIP checkin for withdrawn item returns ok in checkin
                    response
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

If an item that is withdrawn is checked in via SIP2, Koha does not process the
checkin, but still indicates the checkin succeeded via the ok flag in the
checkin response message.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:49:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:49:27 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-2AsthFiGVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:49:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:49:30 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-1SpqJ3XTv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83694&action=edit
Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response

If an item that is withdrawn is checked in via SIP2, Koha does not process the
checkin, but still indicates the checkin succeeded via the ok flag in the
checkin response message.

To recreate:
 1 - Mark an item withdrawn
 2 - Set up sip server:
     https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
 3 - Set 'BlockReturnOfWithdrawnItems' to block
 4 - Use the sip_cli_emulator to checkin the withdrawn item
 5 - There is no error in the checkin

Test Plan:
1) Mark an item withdrawn
2) Set BlockReturnOfWithdrawnItems to block
3) Use the sip cli emulator to checkin the withdrawn item
4) Note the response begins with 101
5) Apply this patch
6) Restart all the things ( including SIP server )
7) Repeat checkin with sip cli emulator
8) Note the checkin now beings with 100

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:50:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:50:01 +0000
Subject: [Koha-bugs] [Bug 21745] Checkin of withdrawn items marked
 successful via SIP2 when BlockReturnOfWithdrawnItems is enabled
In-Reply-To: <bug-21745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21745-70-ozfyewplGx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 22076 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:50:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:50:01 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-eyhNIeVSfs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 21745 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:50:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:50:35 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-sNjwoTvzFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83663|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83695&action=edit
Bug 21813: In-page JavaScript causes error on patron entry page

This patch removes a block of JavaScript from memberentrygen.tt which
was being included in the page before jQuery is loaded. This causes a
JavaScript error.

To test, apply the patch, regenerate CSS, and clear your browser cache
if necessary.

 - In Administration -> Patron categories, confirm that you have two
    patron categories with different default messaging preferences
    defined.
 - Go to Patrons -> New patron
   - Create a new patron using one of the categories with messaging
     preferences.
   - Confirm that when you switch the category selection to the other
     patron category, the patron messaging preference checkboxes are
     changed to the default for that category.
     - A "Loading" indicator should appear above the checkboxes to show
      that an operation is in process. It should disappear when new
      default prefs are loaded.
   - Manually change one or more patron messaging preference checkboxes.
   - Switch the patron category again and confirm that you are prompted
     to confirm resetting the preferences to the default for that
     category.
 - Perform the same set of tests when editing a patron.
   - Defaults should not be loaded during the edit process.
 - Confirm that there are no other JavaScript errors in the console.
 - Test again with EnhancedMessagingPreferences disabled.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:56:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:56:23 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-BBpqUa3Z3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works for me, no regressions found and the qa scripts all pass.

I'm going to go ahead and PQA this as it's a major.. but I think an
accompanying regression test would be good to prevent future regressions.  I'll
create a new bug for that to prevent holding this one up and discus whether we
want a specific test or a more generic check for errors in the console
anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:58:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:58:42 +0000
Subject: [Koha-bugs] [Bug 22077] New: Uncaught JS Console errors
Message-ID: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22077

            Bug ID: 22077
           Summary: Uncaught JS Console errors
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Bug 21813 resolves an uncaught JS console error which was introduced after the
mass move of JS to the footer.

I'd love to see some sort of regression test to catch such errors in the
future.. but I'm not sure how to proceed and didn't want to prevent that bug
from progressing.. hence the new report here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:58:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:58:50 +0000
Subject: [Koha-bugs] [Bug 22077] Uncaught JS Console errors
In-Reply-To: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22077-70-5DPCiURsHs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22077

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:58:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:58:50 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-BtOAWl2JfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22077

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 18:59:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 17:59:00 +0000
Subject: [Koha-bugs] [Bug 22077] Uncaught JS Console errors
In-Reply-To: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22077-70-24TGBPyk5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22077

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:04:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:04:14 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-qKwYkoq1TW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83113|0                           |1
        is obsolete|                            |
  Attachment #83114|0                           |1
        is obsolete|                            |
  Attachment #83115|0                           |1
        is obsolete|                            |

--- Comment #96 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83696&action=edit
Bug 14576: Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences.  The update statement should
insert values that replciate these functions.  Note existing
functionality of all items in PROC location being returned to
permanent_location is preserved by default.  Also, any items issued from
CART location will be returned to their permanent location on issue (if
it differs)

Special values for this pref are:
_ALL_ - used on left side only to affect all items
_BLANK_ - used on either side to match on/set to blank (actual blanks
        will work, but this is an easier to read option)
_PERM_ - used on right side only to return items to permanent location

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN
8) Test using _ALL_, _BLANK_ and _PERM_ for updates
9) Try entering various incorrect syntax in the pref and note you are warned

Sponsored by:
    Arcadia Public Library (http://library.ci.arcadia.ca.us/)
    Middletown Township Public Library (http://www.mtpl.org/)
    Round Rock Public Library
(https://www.roundrocktexas.gov/departments/library/)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:04:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:04:19 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-PEzfID9JKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #97 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83697&action=edit
Bug 14576: Unit tests

To test:
1 - prove -v t/db_dependent/Circulation/Returns.t
2 - prove -v t/db_dependent/Circulation/issue.t
3 - prove -v t/db_dependent/UsageStats.t
4 - All should pass

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:04:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:04:25 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-qmRu07o7kh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #98 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83698&action=edit
Bug 14576: Update to use get_yaml_pref_hash

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:06:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:06:42 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-4X8eFd2tVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Bad bug - we should make it go away. Martin offered and I am ok with it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:09:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:09:43 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-AcvTEuT0fL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:09:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:09:46 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-LEbJT0GJXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83699&action=edit
Bug 22066: Record library_id for manual credits

On creating manual credits, the (newly introduced) branchcode should be
set now. This trivial patch makes it work.

To test:
- Create a manual credit for a known patron
- Using MySQL check the result:
  $ sudo mysql
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> FAIL: The created accountline row has NULL for the branchcode
- Apply this patch
- Create a manual credit for the patron
- Run:
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> SUCCESS: branchcode is set correctly
-Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:11:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:11:41 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-u6ysuyHsDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83167|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83700&action=edit
Bug 21605: Ensure EDI acct fields set to boolean val

Validate the input to the fields indicating account
functionality. The only valid values are 1 and 0
non-integer (or integers other than 0/1) are invalid

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:11:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:11:44 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-G521ePpj7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83168|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83701&action=edit
Bug 21605: (follow-up) Simple ternary boolean to number conversion

Imo it is much easier to do just "$a ? 1 : 0" than testing defined($a) etc.
in the additional loop.
Less code, more readable?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:13:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:13:20 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-yXOGkrFHTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Passing QA. This is a trivial patch and causes no regressions. I agree with
Marcels alternative/follow being easier to read and process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:25:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:25:12 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-wFq69lbn6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This all looks sane to me.. but I'm going to raise it to our resident ES expert
and ask for his SO as a PQA.. calling Ere

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:25:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:25:29 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-p85saqZMGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:33:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:33:52 +0000
Subject: [Koha-bugs] [Bug 21890] Patron password reset by category
In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21890-70-NIsnClwmwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patron Password Resets      |Patron password reset by
                   |                            |category

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:34:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:34:29 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-gj04wdE9Nx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83693|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83702&action=edit
Bug 22030: Use preference to determine username sent to overdrive

Overdrive configuration generally defaults to cardnumber, however, they
have confirmed that some libraries use usernames. We need to allow for
both scenarios.

To test:
1 - Have an OverDrive account setup with SIP authentication
    Note: You can apply for a testing account at developer.overdrive.com
    and setup an environment
2 - Fill in all your OverDrive system preferences
3 - Test with a patron whose username is their cardnumber
4 - Confirm their overdrive account tab on opac loads
5 - Change the username to be another value like "borked_wont_work"
6 - Note the overdrive account tab won't load
7 - Apply patch, update database, not new system preference
OverDriveUsername (default to 'cardnumber)
8 - Note the OD account loads successfully
9 - Change the system preference to 'user name' - the account load fails

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:34:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:34:58 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-Y2qcU0HsDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivia fix, no regressions.. going straight for QA here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:35:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:35:07 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-xsFUY6m7yS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:35:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:35:22 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-tO4BCgqhdH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:35:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:35:55 +0000
Subject: [Koha-bugs] [Bug 22078] New: Move Expired Opac Registrations to
 deleted borrowers instead of deleting
Message-ID: <bug-22078-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22078

            Bug ID: 22078
           Summary: Move Expired Opac Registrations to deleted borrowers
                    instead of deleting
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

>From bug 22052

It might be nice to have the option to track expired registrations - I would
think maybe a syspref, or a switch in the cronjob as some libraries might not
want/need to preserve these

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:36:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:36:05 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-AGsycVAbc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Alex Arnaud from comment #9)
> Patch does the job. Test are ok. Code review is ok. So passed QA.
> 
> However (and that doesn't put these patches in discussion), i'm wondering if
> should not move the self registered patrons in the deletedborrower table
> before deleting. Does that make sense to create an other bug ?

Bug 22078

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 19:36:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 18:36:16 +0000
Subject: [Koha-bugs] [Bug 20856] Restore ability to delete unverified self
 registrations after x hours
In-Reply-To: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20856-70-MGZO7Lbh1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 20:01:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 19:01:28 +0000
Subject: [Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks
	method
In-Reply-To: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21817-70-7DpO1ZDKzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|Test suit enhancement       |Test suite enhancement
      release notes|backported to 18.11.x       |backported to 18.11.x
                   |series to aid future        |series to aid future
                   |backports. There should be  |backports. There should be
                   |no noticeable effects for   |no noticeable effects for
                   |the end user.               |the end user.
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 20:13:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 19:13:49 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-A61MmWbYoV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

kholt at roseville.ca.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholt at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 20:35:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 19:35:25 +0000
Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search
In-Reply-To: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8778-70-6bBJfT0FzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 21:02:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 20:02:35 +0000
Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search
In-Reply-To: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8778-70-aw4fBlz5ay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin SOMERS from comment #3)
> I'd say this patch manages 2 different things :
> 1/ adds index "kw,phr" in OPAC bootstrap advanced search
> 2/ moves indexes with "phr" out of "more options" condition
> 
> I think the point n?2 is under discussion and I vote against.
> 
> What about point n?1 ? I've add a ask for this feature by a library.
> Can I create a new bug for adding index "kw,phr" in OPAC bootstrap advanced
> search, but into a more options" condition ?

Hi Fridolin, this is an old one - but I'd like to have the first without the
second.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 23:39:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 22:39:49 +0000
Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch
In-Reply-To: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15497-70-Gttxh5ijhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> ---
We are a large consortium -- this would definitely be of benefit to us.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 23:41:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 22:41:36 +0000
Subject: [Koha-bugs] [Bug 21919] Fast Add Cataloging UX Enhancements
In-Reply-To: <bug-21919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21919-70-pFbNFTIyYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21919

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> ---
This would be helpful to our libraries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 23:43:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 22:43:04 +0000
Subject: [Koha-bugs] [Bug 21407] Can't enter new macros in the advanced
 cataloging editor (rancor)
In-Reply-To: <bug-21407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21407-70-uQIhwCTgeT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #8 from AspenCat Team <aspencatteam at clicweb.org> ---
This is quite frustrating as it seems browser dependent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 23:47:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 22:47:43 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-Jk5WFYevpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83695|0                           |1
        is obsolete|                            |

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 83703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83703&action=edit
Bug 21813: In-page JavaScript causes error on patron entry page

This patch removes a block of JavaScript from memberentrygen.tt which
was being included in the page before jQuery is loaded. This causes a
JavaScript error.

To test, apply the patch, regenerate CSS, and clear your browser cache
if necessary.

 - In Administration -> Patron categories, confirm that you have two
    patron categories with different default messaging preferences
    defined.
 - Go to Patrons -> New patron
   - Create a new patron using one of the categories with messaging
     preferences.
   - Confirm that when you switch the category selection to the other
     patron category, the patron messaging preference checkboxes are
     changed to the default for that category.
     - A "Loading" indicator should appear above the checkboxes to show
      that an operation is in process. It should disappear when new
      default prefs are loaded.
   - Manually change one or more patron messaging preference checkboxes.
   - Switch the patron category again and confirm that you are prompted
     to confirm resetting the preferences to the default for that
     category.
 - Perform the same set of tests when editing a patron.
   - Defaults should not be loaded during the edit process.
 - Confirm that there are no other JavaScript errors in the console.
 - Test again with EnhancedMessagingPreferences disabled.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  7 23:48:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 22:48:38 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-yzHoTsGoos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org
           Severity|normal                      |critical

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Would like to see this pushed ASAP.  This is a huge disconnect of patron and
items if you are not paying attention!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 00:22:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 23:22:34 +0000
Subject: [Koha-bugs] [Bug 18175] Makefile sets koha-httpd api path
 incorrectly for standard installs
In-Reply-To: <bug-18175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18175-70-X5fa0mPq4N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #3)
> I 'think' this problem has gone away now..  going to mark as resolved.

I think we fixed it with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 00:48:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 23:48:21 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-kI6Po127PP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #33 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #32)
> Those comments make me doubt that we should put more work into this. I'd
> really like to get more opinions on this. I am asking for a second sign-off,
> also to widen the audience on this bug beyond the QA team.

As the author of the patch, I'd say it's probably worth pausing for the time
being. 

I think our next priority should be changing biblio_metadata.marcflavour to
something like biblio_metadata.schema (Tomas and I have talked about this
before). 

Then the next step would be to store RDFXML in biblio_metadata.metadata with a
biblio_metadata.format of "rdfxml" and a schema like "BIBFRAME". 

The next logical step would probably be to generate RDF from MARC, so that 1
"bibliographic record" can have 2 different metadata records. 

After that, we could focus on allowing Koha to use RDF (or any non-MARC
metadata really). Practically, this might mean introducing a Koha intermediate
metadata format which maps to/from other metadata formats. 

--

RDF itself isn't necessarily that hard to work with. RDFXML is awful to look at
in comparison to Turtle or N3, but it's machine readable and easy enough to
work at after it's parsed into triples in Perl. 

However, "Linked Data" is difficult. When RDF objects are links to external
objects, things get tricky. However, I have yet to find a RDF system that
handles perfectly Linked Data. 

Fedora Commons 4.x uses RDF natively but it doesn't have any "Linked Data"
handling. You can have an external URI as an object, but it won't do anything
special. That'll be up to the application one level higher from Fedora. (I
haven't worked with Samvera or Hydra or Fez or anything like that.)

IIIF is a RDF metadata schema that mostly embeds literal values although some
objects can be resolvable URIs. I don't think anyone does that in practice
though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 00:56:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Jan 2019 23:56:03 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-5g4M0eSUFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

--- Comment #34 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #33)
> I'd like to ask for a second sign-off, see also bug 18713 comment 32

I've added some comments to 18713, but I think it's worth pausing on this bug
too. 

I've been working with Fedora Commons 4.x for the past year or two, and it's
opened up my eyes more to RDF.

Fedora uses RDF as its native metadata format but it doesn't use a triplestore
to store the RDF. Instead, it uses ModeShape (a JCR - Java Content Repository
data store) and Infinispan to store the data in a single file or a database. It
works pretty well although there are some performance issues with ModeShape in
terms of parent-child relationships. 

What I mean to say is that I'm not convinced that we need a triplestore just
yet. 

I've also worked with Apache Fuseki a bit over the past few years, and it's not
the best bit of software. I've founded and help resolve a few major bugs, but
it isn't super robust. I've noticed it seems to have issues with fragmentation
as well which means its disk usage can sky rocket when you update or delete
data. 

Like Fedora, I think the best bet is to have a more conventional data store,
and then if we want to use a triplestore we can add the RDF to the triplestore
like we add metadata to ElasticSearch or Zebra. It's nice to trust a more
established data store and be able to destroy and rebuild the external
triplestore. 

For bigger libraries, it's worth noting that Apache Fuseki doesn't scale at
all, so things like load balancing and replication aren't really possible. 

--

Going back to Fedora... I haven't found a need for a triplestore yet. If you
wanted to have a SPARQL endpoint, it could be useful. Otherwise, you just want
to index your data into a search engine or display the record on a screen...
and for those you don't need a triplestore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 01:00:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 00:00:13 +0000
Subject: [Koha-bugs] [Bug 22077] Uncaught JS Console errors
In-Reply-To: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22077-70-eyfrq77BPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22077

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #0)
> I'd love to see some sort of regression test to catch such errors in the
> future.. but I'm not sure how to proceed and didn't want to prevent that bug
> from progressing.. hence the new report here.

Do you mean an automated test? I'd be intrigued by that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 01:00:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 00:00:40 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-EGb8O316oF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #30 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #29)
> You could help by signing off bug 21813 ;)

I thought it was already passed QA?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 01:03:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 00:03:43 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-Da4N89donR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not when I commented - it has progressed since :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 01:09:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 00:09:22 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-CkQK8Ls4uY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #32 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #31)
> Not when I commented - it has progressed since :)

Ahhh excellent!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 05:54:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 04:54:58 +0000
Subject: [Koha-bugs] [Bug 22079] New: Store the borrowernumber of user
 returning item in associatedborrower in statistics table
Message-ID: <bug-22079-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22079

            Bug ID: 22079
           Summary: Store the borrowernumber of user returning item in
                    associatedborrower in statistics table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The borrowernumber in the statistics table stores the borrowernumber of the
borrower who checked out the item. 

This patch should use the un-used associatedborrower column in the statistics
table to store the borrowernumber or self check machine id returning the item. 

This makes it possible to track who checked an item in

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 07:13:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 06:13:05 +0000
Subject: [Koha-bugs] [Bug 21407] Can't enter new macros in the advanced
 cataloging editor (rancor)
In-Reply-To: <bug-21407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21407-70-ZVD8Ya3JLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Are you suggesting there's still a problem here?  If that's the case can you
open a new bug and describe how to replicate it including which browser it is
presenting in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 07:52:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 06:52:05 +0000
Subject: [Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
In-Reply-To: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21571-70-3rZYKGcpyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 07:58:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 06:58:42 +0000
Subject: [Koha-bugs] [Bug 21407] Can't enter new macros in the advanced
 cataloging editor (rancor)
In-Reply-To: <bug-21407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21407-70-bUidcIPvOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407

--- Comment #10 from AspenCat Team <aspencatteam at clicweb.org> ---
(In reply to Martin Renvoize from comment #9)
> Are you suggesting there's still a problem here?  If that's the case can you
> open a new bug and describe how to replicate it including which browser it
> is presenting in.

Sorry - The patch which fixed this is loaded to our test site, so all is good. 
New to the system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 08:05:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 07:05:13 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21929-70-Fd3bqQMoMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21387
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 21387 not in 17.11.x


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387
[Bug 21387] Receive items from - form should include tax hints the same as the
ordering form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 08:05:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 07:05:13 +0000
Subject: [Koha-bugs] [Bug 21387] Receive items from - form should include
 tax hints the same as the ordering form
In-Reply-To: <bug-21387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21387-70-pwLtczBd3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21929


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
[Bug 21929] Typo in orderreceive.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:42:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:42:40 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-8VjkVEG6yG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82794|0                           |1
        is obsolete|                            |

--- Comment #58 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83704&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates and
sorting of search results in UI. Also make field names in search strings
case insensitive to accept case variations in template links and user input.

Sponsored-by: Gothenburg University Library

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:43:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:43:36 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-6RuffKdWV9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #59 from Ere Maijala <ere.maijala at helsinki.fi> ---
Awesome, thanks David. This was actually on my list of things to work on when
time permits, and it had been bugging me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:46:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:46:43 +0000
Subject: [Koha-bugs] [Bug 21793] Inconsistences between search fields and
	mappings
In-Reply-To: <bug-21793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21793-70-IcYr528kTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21793

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> ---


*** This bug has been marked as a duplicate of bug 19575 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:46:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:46:43 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-sdSxaQvj6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frank.hansen at ub.lu.se

--- Comment #60 from Ere Maijala <ere.maijala at helsinki.fi> ---
*** Bug 21793 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:51:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:51:02 +0000
Subject: [Koha-bugs] [Bug 22080] New: Easier translation of ElasticSearch
	mappings page
Message-ID: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

            Bug ID: 22080
           Summary: Easier translation of ElasticSearch mappings page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Actual translation of ElasticSearch mappings page contains a huge block :

%s %s An error occurred when updating mappings (%s). %s An error occurred when
deleting the existing mappings. Nothing has been changed! (search field %s with
mapping %s.) %s Invalid field weight "%s", must be a positive decimal number.
%s An error occurred when updating Elasticsearch index mappings: %s. %s Index
"%s" needs to be reindexed %s Index "%s" needs to be recreated %s Mappings
updated successfully. %s Mappings have been reset successfully. %s %s %s 

I propose to add <span> to split into several translation blocks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:51:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:51:16 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-yDEZv4FT0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:55:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:55:01 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-aAl5IhijYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 09:55:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 08:55:04 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-QzM913osB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 83705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83705&action=edit
Bug 22080 - Easier translation of ElasticSearch mappings page

Actual translation of ElasticSearch mappings page contains a huge block with a
lot of %s.
It makes translation hard.

This patch adds <span> to split into several translation blocks.

Test plan :
1) Compare page with and without patch, check the only difference is span tags.
2) Check HTML is OK with patch.
3) Update a PO file and see new translation blocks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 10:34:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 09:34:30 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-2dAMHMjlcC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr,
                   |                            |julian.maurice at biblibre.com

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Isn't it a good place to use new translation mechanism introduced by bug #15395
(thanks Julian)? A sample usage is available on bug #21789.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 10:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 09:43:27 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-HzvyvuhOK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Fr?d?ric Demians from comment #2)
> Isn't it a good place to use new translation mechanism introduced by bug
> #15395 (thanks Julian)? A sample usage is available on bug #21789.

Absolutely. Fridolin, please look at
https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC
to see how to do it (or ask me directly ;))

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 10:54:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 09:54:20 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-SJPneas87g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83273|0                           |1
        is obsolete|                            |

--- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83706&action=edit
Bug 21002: Add tests for Koha::Account::add_debit

Sponsored-by: PTFS Europe

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 10:54:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 09:54:28 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-A0mpQEFUv1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83274|0                           |1
        is obsolete|                            |

--- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83707&action=edit
Bug 21002: Add ->add_debit method to Koha::Account

Sponsored-by: PTFS Europe

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 10:56:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 09:56:58 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-AE804O4CqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 11:25:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 10:25:40 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-bT0BPmDmSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 11:50:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 10:50:01 +0000
Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data
In-Reply-To: <bug-10680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10680-70-LErHcWKmSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680

Mioara Voncila <mioara_v18 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mioara_v18 at yahoo.com
   When did the bot|                            |2019-01-08
    last check this|                            |
           Priority|P5 - low                    |P3
           Severity|normal                      |major
   Target Milestone|---                         |19.05

--- Comment #4 from Mioara Voncila <mioara_v18 at yahoo.com> ---
On a Log View search on the CATALOG Module, with MODIFY action, by entering the
"biblio" option in the "object" field, there is no result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:02:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:02:29 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-BGkOhoaJPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83708&action=edit
Bug 22073: Add to diacritics mappings for ? and ?

To test:
1 - Find or add a record by author Slavoj ?i?ek
2 - Search for 'Zizek'
3 - No results
4 - Apply patch
5 - Reindex
6 - Search again
7 - Success!

https://bugs.koha-community.org/show_bug.cgi?id=22073

Signed-off-by: Eric Phetteplace <ephetteplace at cca.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:02:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:02:55 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-sNwIZ2PGLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83691|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:03:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:03:05 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-TuLY3Ad8dX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:03:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:03:13 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-rmibJZvdms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:03:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:03:26 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-QWZn5p5j5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:04:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:04:42 +0000
Subject: [Koha-bugs] [Bug 22081] New: Alternate merging functionality
Message-ID: <bug-22081-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22081

            Bug ID: 22081
           Summary: Alternate merging functionality
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: simon.hohl at dainst.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Currently the merging process let's you select which fields ought to be copied
over to the "winning" record from the "loosing" record(s). Afterwards, the
"loosing" record is deleted (moved to tables "deletedbiblio" etc.). 

One problem with the current solution: You can't tell after the fact, which
deleted record was merged with which existing record. This is bad if you want
to provide stable links to bibliographic records, for citation in research
papers for example: Ideally you would want to be able to redirect to the
"winning" records if somebody calls URL to a deleted record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:17:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:17:26 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-rvAvqDkcQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:17:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:17:29 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-PyMEUISBTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83694|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83709&action=edit
Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response

If an item that is withdrawn is checked in via SIP2, Koha does not process the
checkin, but still indicates the checkin succeeded via the ok flag in the
checkin response message.

To recreate:
 1 - Mark an item withdrawn
 2 - Set up sip server:
     https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
 3 - Set 'BlockReturnOfWithdrawnItems' to block
 4 - Use the sip_cli_emulator to checkin the withdrawn item
 5 - There is no error in the checkin

Test Plan:
1) Mark an item withdrawn
2) Set BlockReturnOfWithdrawnItems to block
3) Use the sip cli emulator to checkin the withdrawn item
4) Note the response begins with 101
5) Apply this patch
6) Restart all the things ( including SIP server )
7) Repeat checkin with sip cli emulator
8) Note the checkin now beings with 100

Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:17:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:17:58 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-8fGnvqSLN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:54:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:54:05 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-ax9jpRpsRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 12:57:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 11:57:22 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-ofTfY1RDdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Tom?s Cohen Arazi from comment #4)
> I have a concern: if we cache the record to be displayed, then the item
> statuses won't be up-to-date. If the tradeoff is not enough, maybe this is
> just not worth. Because people expect to see updated information on the
> records.

Indeed.

I think we need to change this by moving items out of this XSLT file.
I think we should use Ajax to load in realtime items infos, with and API for
that.
This will also avoid indexing all record on item circulation.
Dreams ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 13:07:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 12:07:01 +0000
Subject: [Koha-bugs] [Bug 21902] OPAC login should redirect to referring page
In-Reply-To: <bug-21902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21902-70-7SUQFtSN9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21902

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Hugo Agud <hagud at orex.es> ---
Hi

you are right!, for most uupdated versions it is already working...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 13:49:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 12:49:38 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-K7g3xmzYf4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 13:51:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 12:51:28 +0000
Subject: [Koha-bugs] [Bug 22081] Alternate merging functionality
In-Reply-To: <bug-22081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22081-70-eyd9QDyQ00@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22081

--- Comment #1 from Simon Hohl <simon.hohl at dainst.org> ---
One solution:

1. Add a toggle when merging "keep merged record"
2. If the toggle is active, let the user specify into which of the loosing
record's fields to write the replacement's system number.
3. Remove all data from the loosing record except the replacement's sys number

If somebody navigates to a record replaced in this manner either redirect
directly (OPAC) or show a link to the replacement record (Backend).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 13:58:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 12:58:50 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-E7PS5vFdUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83704|0                           |1
        is obsolete|                            |

--- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83710&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates and
sorting of search results in UI. Also make field names in search strings
case insensitive to accept case variations in template links and user input.

Sponsored-by: Gothenburg University Library

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 13:59:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 12:59:49 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-n7ZUGK5pzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fixed a single whitespace error that was introduced.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:00:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:00:11 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-C8MSitr7zL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:21:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:21:49 +0000
Subject: [Koha-bugs] [Bug 22082] New: ambiguous column in patron stats
Message-ID: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

            Bug ID: 22082
           Summary: ambiguous column in patron stats
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

In Reports > Patrons statistics, the combination of activity and extended
attributes generates an invalid SQL query with error :
ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:21:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:21:56 +0000
Subject: [Koha-bugs] [Bug 22082] ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-DkNgXze5SW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8306

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:21:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:21:56 +0000
Subject: [Koha-bugs] [Bug 8306] Patron stats,
	patron activity : no active doesn't work
In-Reply-To: <bug-8306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8306-70-dBP2PHmdYU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22082

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:22:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:22:07 +0000
Subject: [Koha-bugs] [Bug 22082] ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-UaCnvgkixA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:36:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:36:51 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-uqfNNy5fXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:41:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:41:48 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-g35lJPd3VB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:41:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:41:51 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-9GitXpr91N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82333|0                           |1
        is obsolete|                            |
  Attachment #82334|0                           |1
        is obsolete|                            |
  Attachment #82335|0                           |1
        is obsolete|                            |

--- Comment #21 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 83711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83711&action=edit
[SIGNED-OFF] Bug 20809: Link patron image to patron image add/edit form

This patch modifies an include file so that it is possible with edit a
patron's image on any patron-related page which uses that include.

To test you must have the patronimages system preference enabled.

Apply the patch and open any patron record for viewing.

 - Hover the mouse over the patron image.

   - If the patron has a previously-defined patron image, should you see
     an "Edit" button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

   - If a patron has no patron image defined, you should see an "Add"
     button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

This process should work from any page which shows the patron sidebar:
Check out, Details, Fines, Routing lists, Circulation history, etc.

Patch works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:41:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:41:55 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-Fc2rIZIWnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #22 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 83712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83712&action=edit
[SIGNED-OFF] Bug 20809: (follow-up) Corrections to CSS and JS

This follow-up modifies JavaScript so that the confirmation dialog is
triggered when deleting a patron image from the modal window.

The CSS is modified to improve the alignment of patron image and edit
button.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 14:41:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 13:41:58 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-6kOw6N31he@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #23 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 83713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83713&action=edit
[SIGNED-OFF] Bug 20809: (follow-up) Add missing JS to view log page

If the log viewer is being used to track patron-related data the
patron-related JavaScript file should be included.

To test, apply the patch and open a patron record. In the left-hand
sidebar choose Modification Log. Test the patron image edit/replace
process from the patron image in the sidebar and confirm that it works
correctly.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 15:00:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 14:00:26 +0000
Subject: [Koha-bugs] [Bug 22082] ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-W7ZDqulXsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 83714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83714&action=edit
Bug 22082: ambiguous column in patron stats

In Reports > Patrons statistics, the combination of activity and extended
attributes generates an invalid SQL query with error :
ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous

This is because FROM contains tables borrowers and borrower_attributes both
containing borrowernumber column.

Test plan :
1) Be sure to have a patron extended attribute
2) Be sure you have some recent circulation activity
3) Go to Reports > Patrons statistics
4) Select 'active' in 'Patron activity' and 1 years of activity
5) Check 'Row' in 'Patron category'
6) Check 'Columns' in a extended attribute
7) Submit
8) Without patch you have no results, with patch you have exepected results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 15:00:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 14:00:23 +0000
Subject: [Koha-bugs] [Bug 22082] ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-RMTzfNkgzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 15:24:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 14:24:08 +0000
Subject: [Koha-bugs] [Bug 22083] New: Typo in circulation_batch_checkouts.tt
Message-ID: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

            Bug ID: 22083
           Summary: Typo in circulation_batch_checkouts.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: caroline.cyr-la-rose at inlibro.com
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

There is a typo in circulation_batch_checkouts.tt that makes Koha skip a
warning if the user cannot borrow due to circulation rules.

To reproduce:
1. In Administration > Global system preferences, 'Allow' BatchCheckouts and
enter patron categories in BatchCheckoutsValidCategories
2. Go to Administration > Circulation and fines rules
3. Enter a rule where a certain category of patrons (that is in
BatchCheckoutsValidCategories) cannot take out a particular item type
4. Search the catalog for an item of that item type
5. Copy the barcode
6. Go into patrons and find a patron of that category
7. Click on the Batch checkout tab
8. Paste the barcode in the box and click Check out
9. It should say 'Too many checked out'

It should also say 'This patron can't check out this item per library
circulation policy'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 15:32:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 14:32:48 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-5Th6cltw2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 83715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83715&action=edit
Bug 22083: Typo in circulation_batch_checkouts.tt

There is a typo in circulation_batch_checkouts.tt that makes Koha skip a
warning if the user cannot borrow due to circulation rules.

This patch corrects this typo.

To test:

1. In Administration > Global system preferences, 'Allow' BatchCheckouts and
enter patron categories in BatchCheckoutsValidCategories
2. Go to Administration > Circulation and fines rules
3. Enter a rule where a certain category of patrons (that is in
BatchCheckoutsValidCategories) cannot take out a particular item type
4. Search the catalog for an item of that item type
5. Copy the barcode
6. Go into patrons and find a patron of that category
7. Click on the Batch checkout tab
8. Paste the barcode in the box and click Check out
9. It should say 'Too many checked out'
10. Apply the patch
11. Try the check out again, it should show both warnings ('Too many checked
out' and 'This patron can't check out this item per library circulation
policy')

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 15:33:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 14:33:08 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-rPAvRdKAOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 15:43:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 14:43:46 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-M2jaHQnc4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I also think that the 'too many checked out' warning should only appear if the
circulation rules allow 1 or more. If the circulation rules allow 0, only 'This
patron can't check out this item per library circulation rules' should show...

It is, however, outside of the scope of this bug and outside my capabilities...
Just throwing it out there if someone wants to take it over :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:44:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:44:45 +0000
Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup
 Date ) to Koha
In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19619-70-aK35o0zJpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:44:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:44:48 +0000
Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup
 Date ) to Koha
In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19619-70-iEHbpHVDRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83716&action=edit
Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha

The CM field was all set up for implementation, but never completed.
We should fully implement the CM ( Hold Pickup Date ), which according
to the SIP2 protocol specification is "The date that the hold expires".

Test Plan:
1) Set up a waiting hold for an item
2) Using the sip cli emulator, send an item information request for that item
3) Note the CM field does not show up
4) Apply this patch
5) Restart all the things!
6) Repeat the item information request
7) Note the CM field is now transmitted!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:44:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:44:54 +0000
Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup
 Date ) to Koha
In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19619-70-9iIIEaBLA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jesse at bywatersolutions.com  |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:45:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:45:29 +0000
Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup
 Date ) to Koha
In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19619-70-EuViLULJgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:49:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:49:28 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-ZyK0AZ44t7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #63 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #62)
> Fixed a single whitespace error that was introduced.
> 
> Passing QA

Tests are failing with these patches:

prove -v t/db_dependent/SearchEnginge/ElasticSearch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:55:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:55:25 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-0MsuqmO652@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:55:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:55:37 +0000
Subject: [Koha-bugs] [Bug 21786] Routes for credits should include library_id
In-Reply-To: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21786-70-qe0GjPV3u2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:55:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:55:49 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-GQcTI6SO6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:56:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:56:01 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-8eu7qbuK9a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:56:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:56:14 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-SYkApTwV3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:56:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:56:27 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-s7WQM8SOtQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 16:59:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 15:59:54 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates
	(stable/18.11.x)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-Q6LvgfKbXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 17:15:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 16:15:25 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-glXgcXPdSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83717&action=edit
Bug 21846: (follow-up) Add maintenance script

This patch adds a maintenance script that generates the missing
tags_approval entries based on the tags_all table, and then recalculates
the weights for both tags_approval and tags_index tables.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 17:49:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 16:49:32 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19876-70-1fElz2ijYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
To recreate:
1 - Create a manual fine for a patron (or find one with fines)
2 - Check out an item to this patron
3 - Ensure the item has a lost charge
4 - Mark the item lost via a method that will not check it in
(MarkLostItemsAsReturned syspref) 
5 - Note the item is checked out to patron and they are charged
6 - From patron go to Accounting->Make a payment, select all, 'Pay selected'
7 - Enter an amount less than the value of the first fine and pay
8 - Payments are calculated correctly, however, the item is now checked in
9 - View the item on the 'items' tab of the biblio
10 - The 'Paid for?' section notes the item has been paid for
11 - Pay a partial amount again
12 - Paid for now has doubled info

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 17:49:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 16:49:43 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19876-70-2h51sQpYqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:29:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:29:25 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-XoMW9688rB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83718&action=edit
Bug 22073: Add to diacritics mappings for ? and ?

To test:
1 - Find or add a record by author Slavoj ?i?ek
2 - Search for 'Zizek'
3 - No results
4 - Apply patch
5 - Reindex
6 - Search again
7 - Success!

https://bugs.koha-community.org/show_bug.cgi?id=22073

Signed-off-by: Eric Phetteplace <ephetteplace at cca.edu>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:30:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:30:11 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-h5RzFMgsY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:30:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:30:27 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-oVFzbaJI0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83708|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:30:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:30:40 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-3w5RgMwNS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:36:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:36:27 +0000
Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by
 cardnumber if userid exists in file and in Koha
In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21465-70-V33jM947uN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #16 from Jesse Maseto <jesse at bywatersolutions.com> ---
This was backported to 18.05.x for 18.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:42:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:42:47 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-DHzc3LGHEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:42:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:42:53 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-ZfY0WmJ6Ii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83472|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83719&action=edit
Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl

The table is used by circulation.pl and moremember.pl
When it is modified we need to take care of the two view.

Test plan:
Use the columns settings to hide/show the "check in" and other columns
Confirm the this patch fixes the display for moremember.pl

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 18:43:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 17:43:11 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-sK6VQwkBRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:03:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:03:09 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-vkgVSh9gPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:03:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:03:12 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-fryd9giLzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55831|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83720&action=edit
Bug 17353 - Add phone number column to checkout search

This patch adds borrowers.phone as 'Primary phone' in the checkout
search results. It also ads the table to columns configuration

To test:
1 - Perform a checkout search
2 - Note phone is not displayed
3 - Apply patch
4 - Note phone does not display
5 - Visit columns configuration
6 - Unhide the 'phone' column
7 - Note phone displays
8 - Ensure page functions as before patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:10:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:10:37 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-2zMiVVLlHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #2)
> Hi Nick,
> 
> ist this patch testable?

It needs to take separate holdings into account, not testable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:10:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:10:38 +0000
Subject: [Koha-bugs] [Bug 22084] New: Plugin upgrade method and database
 plugin version storage will never be triggered for existing installs
Message-ID: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

            Bug ID: 22084
           Summary: Plugin upgrade method and database plugin version
                    storage will never be triggered for existing installs
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

If an existing plugin begins using the upgrade() method, it will never actually
get triggered because the installation has already occurred and no database
plugin version was stored at the time. Without that database version, the
upgrade method will never be triggered.

In addition, if the plugin has no upgrade method, the installed version is
never updated in the database!

Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:11:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:11:05 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-V1Kq1ftvH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:11:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:11:18 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-WiCGhiSxuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:11:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:11:21 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-elS5sBU3VY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82285|0                           |1
        is obsolete|                            |
  Attachment #82286|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83721&action=edit
Bug 21788: Unit tests

This patch refactors the tests related to ProcessOfflinePayment and adds
checks for setting branchcode on the account line.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation.t
=> FAIL: branchcode is not set

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:11:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:11:25 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-7j9nSsXfMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83722&action=edit
Bug 21788: Make ProcessOfflinePayment pass the library_id parameter

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation.t
=> FAIL: branchcode is not set
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:11:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:11:41 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-aSUz793ngZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:18:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:18:38 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-YzQgTRh6FB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:18:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:18:58 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19876-70-ntylynbIc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:19:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:19:28 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-TfMb737DD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:19:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:19:32 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-B9SPNguH7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83657|0                           |1
        is obsolete|                            |
  Attachment #83658|0                           |1
        is obsolete|                            |
  Attachment #83659|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83723&action=edit
Bug 22051: Add Koha::Exceptions::Object::WrongValue

This patch adds a new exception to be thrown in Koha::Object->store when
a DBIC exception is thrown regarding bad data format.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:19:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:19:36 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-PlBGSniNPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83724&action=edit
Bug 22051: Unit tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:19:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:19:40 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-DuD8EZk4tJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83725&action=edit
Bug 22051: Make Koha::Object->store translate incorrect value exceptions

This patch adds a new condition to Koha::Object->store so it catches
incorrect value-related DBIC exceptions.

This DBIC exceptions get now translated into
Koha::Exceptions::Object::BadValue exceptions with relevant parameters
passed.

To test:
- Apply the exception and unit tests patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because this exception handling code is not
implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:20:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:20:07 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19876-70-7sYScG9isU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This could be solved by replacing ->pay for ->add_credit + ->apply (they were
designed for that). I'll take a look!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:32:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:32:34 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-uBT2NYj84L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:32:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:32:37 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-tondzpEjSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83726&action=edit
Bug 22084: Plugin upgrade method and database plugin version storage will never
be triggered for existing installs

If an existing plugin begins using the upgrade() method, it will never actually
get triggered because the installation has already occurred and no database
plugin version was stored at the time. Without that database version, the
upgrade method will never be triggered.

In addition, if the plugin has no upgrade method, the installed version is
never updated in the database!

Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.

Test Plan:
1) Install an older version of the Kitchen sink plugin:
   *
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from
plugin_data for this plugin, to simulate having installed from an earlier
version of Koha
3) Upgrade to the latest version of the Kitchen sink plugin:
   *
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the
plugin_data table
5) Apply this patch
6) Restart all the things
7) Browse to the Kitchen sink configuration page, this should trigger the
upgrade method
8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in
plugin_data for the Kitchen Sink plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:33:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:33:19 +0000
Subject: [Koha-bugs] [Bug 20669] Add upgrade method to plugins
In-Reply-To: <bug-20669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20669-70-cngZMMwF1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20669

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084
[Bug 22084] Plugin upgrade method and database plugin version storage will
never be triggered for existing installs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:33:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:33:19 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-qjo9ljj2uy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20669


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20669
[Bug 20669] Add upgrade method to plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:34:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:34:40 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-l4boztQONi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
                 CC|                            |tomascohen at gmail.com
   Target Milestone|---                         |19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:38:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:38:42 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-KWgATEpq01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:47:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:47:46 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-3BD4ncLZr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:47:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:47:50 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-heBvqj1FAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83654|0                           |1
        is obsolete|                            |
  Attachment #83655|0                           |1
        is obsolete|                            |
  Attachment #83656|0                           |1
        is obsolete|                            |

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83727&action=edit
Bug 22049: Make MarkIssueReturned rely on returndate only

This patch changes the params accepted by
C4::Circulation::MarkIssueReturned by removing the $dropbox_branch
param.

This passed branchcode was only used to initialize the Koha::Calendar
object, but the date arithmetic has already taken place in a couple
places before we reach this point. This logic needs to be simplified
(bug 14591), and this is the starting point.

To test:
- Apply this patch
- Run:
  $ git grep MarkIssueReturned
=> SUCCESS: Check all the uses of the function either originally passed
undef, or now pass the same date that would've been calculated anyway,
in the returndate param.
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:47:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:47:54 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-pStlUp1ck1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83728&action=edit
Bug 22049: Add tests

The current tests only check some failure use cases. This patch makes it cover
more use cases

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:47:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:47:58 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-sqabw9WP1m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83729&action=edit
Bug 22049: (follow-up) Remove leftover variable

The $circControlBranch variable was originally set to be used to pick
the right dropbox branch. It was only used in MarkIssueReturned, to get
the right Koha::Calendar object. As this responsability was moved top to
the AddReturn caller, and the fact that _GetCircControlBranch is
actually used for fines rules, there's no use for it in this context.
And it was left on the previous patch as a mistake.

To test:
- Make sure the variable is not actually used:
  $ git grep '$circControlBranch'
=> SUCCESS: removed variable is not actually used.
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 19:48:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 18:48:03 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-kMMBvBojz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83730&action=edit
Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl

Test plan:
Try to upload koc file with some returns
Success: the file should be correctly processed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 20:24:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 19:24:54 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-7R1cgVSPAp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 20:24:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 19:24:57 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-ThegAlrhu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83292|0                           |1
        is obsolete|                            |
  Attachment #83293|0                           |1
        is obsolete|                            |

--- Comment #33 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83731&action=edit
Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display

This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky
(https://github.com/somewebmedia/hc-sticky). This plugin provides the
same functionality without the page-reflow problems fixFloat suffers
from.

To test, apply the patch and regenerate the staff client CSS. Test the
behavior of the floating toolbar on these pages:

 - Acquisitions -> Vendor -> Vendor details
 - Acquisitions -> Vendor -> View basket
   - On both these pages, test toolbar behavior before and after
     expanding the "Orders search" options at the top of the page.
 - Administration -> System preferences
 - Authorities -> Create or edit an authority
 - Catalog -> Advanced search
   - Search results
 - Catalog -> Item search
 - Cataloging -> Add or edit a record
   - Open the plugin window for the 008 field
 - Tools -> Label creator -> New label batch -> Add items -> Search ->
   Results
 - Patrons -> New patron
   - Test before and after expanding the patron search options at the
     top of the page
   - Test editing a patron too
 - Tools -> Automatic item modifications by age -> Edit
 - Tools -> Notices & slips -> Edit
 - Lists -> View list

Check that the About page has been updated with information about the
plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 20:25:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 19:25:00 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-iOYRR0aUwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #34 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83732&action=edit
Bug 21751: Remove former fixFloat plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 21:12:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 20:12:49 +0000
Subject: [Koha-bugs] [Bug 22082] ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-WfNRBALSI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 21:12:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 20:12:52 +0000
Subject: [Koha-bugs] [Bug 22082] ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-2Om5kyOn9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83714|0                           |1
        is obsolete|                            |

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 83733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83733&action=edit
Bug 22082: ambiguous column in patron stats

In Reports > Patrons statistics, the combination of activity and extended
attributes generates an invalid SQL query with error :
ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous

This is because FROM contains tables borrowers and borrower_attributes both
containing borrowernumber column.

Test plan :
1) Be sure to have a patron extended attribute
2) Be sure you have some recent circulation activity
3) Go to Reports > Patrons statistics
4) Select 'active' in 'Patron activity' and 1 years of activity
5) Check 'Row' in 'Patron category'
6) Check 'Columns' in a extended attribute
7) Submit
8) Without patch you have no results, with patch you have exepected results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  8 21:44:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 20:44:59 +0000
Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch
In-Reply-To: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15497-70-jI7Pnxfnx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

--- Comment #2 from Lisette Scheer <lisetteslatah at gmail.com> ---
http://devs.bywatersolutions.com/2016/11/30/Limit-Item-Types-by-Branch/ 
According to the updated dev site on Bywater it looks like this has been
funded. 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 00:15:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 23:15:47 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-9pL4AIkran@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to Tom?s Cohen Arazi from comment #4)
> > I have a concern: if we cache the record to be displayed, then the item
> > statuses won't be up-to-date. If the tradeoff is not enough, maybe this is
> > just not worth. Because people expect to see updated information on the
> > records.
> 
> Indeed.
> 
> I think we need to change this by moving items out of this XSLT file.
> I think we should use Ajax to load in realtime items infos, with and API for
> that.
> This will also avoid indexing all record on item circulation.
> Dreams ...

I often think using Ajax to load real time item info is a good idea too,
although I think we'd still have the indexing issue because of the "limit to
currently available items" filter on the search. 

Often, I think we should think about our OPAC as if it were a totally separate
system, and just link it up to the Koha instance using APIs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 00:21:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 23:21:12 +0000
Subject: [Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should
 preserve call context
In-Reply-To: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21909-70-dByLQera1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---
cannot cleanly apply this for 18.05. if this is needed in 18.05 can we please
rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 00:29:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 23:29:02 +0000
Subject: [Koha-bugs] [Bug 18531] Add an endpoint for use by GOBI
In-Reply-To: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18531-70-meAasxWVMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 00:30:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Jan 2019 23:30:51 +0000
Subject: [Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not
	working
In-Reply-To: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21928-70-tcYYgTWBqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 18.05 for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:14:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:14:11 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-0kluvrG3Gd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:14:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:14:30 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-q5JCMO1vmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:14:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:14:48 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-RRAPDUzPwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:15:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:15:07 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-hWy6Pyg5qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:15:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:15:32 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-lwkfVVniJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #32 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:16:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:16:31 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-pzQJ6shNGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
We should have a dependent bug to call reconcile balance for fines (when
closed, not accruing) but I think is beyond scope here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:16:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:16:50 +0000
Subject: [Koha-bugs] [Bug 21436] Switch two-column templates to Bootstrap
 grid: Tools part 4
In-Reply-To: <bug-21436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21436-70-BvfTmdr8RL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:17:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:17:10 +0000
Subject: [Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account
	methods
In-Reply-To: <bug-21980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21980-70-ebv7LGFrsD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 02:17:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 01:17:29 +0000
Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and
	should be removed
In-Reply-To: <bug-21753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21753-70-3XjgSk6cFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 07:45:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 06:45:00 +0000
Subject: [Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not
	working
In-Reply-To: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21928-70-g3BHawoQpo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18789 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 08:13:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 07:13:14 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-Y1sb68S3FW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
I've run out of time today but I want to test this tomorrow. Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 08:14:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 07:14:01 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-M2QxGaI8SY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #36 from David Cook <dcook at prosentient.com.au> ---
Quick question: How does one "regenerate the staff client CSS"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 10:26:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 09:26:53 +0000
Subject: [Koha-bugs] [Bug 20568] Add API key management interface for patrons
In-Reply-To: <bug-20568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20568-70-8SFuL6fdfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

Caroline Webb <Carolinewebb78 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Carolinewebb78 at gmail.com

--- Comment #57 from Caroline Webb <Carolinewebb78 at gmail.com> ---
A best platform for users and makers to tell the developers about the bug which
they experience and feels that there is need of adding API key management
interface for patrons and welcoming solutions here.

Caroline,
http://www.personalstatementfolks.co.uk/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 10:51:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 09:51:46 +0000
Subject: [Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should
 preserve call context
In-Reply-To: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21909-70-8J4jSU9Jmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Lucas Gass from comment #18)
> cannot cleanly apply this for 18.05. if this is needed in 18.05 can we
> please rebase.

You can skip it, Lucas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 10:53:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 09:53:42 +0000
Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees
 without creating credits
In-Reply-To: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20262-70-8qPMYdlPYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Failed QA                   |Patch doesn't apply

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Kyle, unfortunately a lot of the code changed in the meantime so this doesn't
apply. I suggest you take a look at the PQA stuffs because there's still lots
of moving pieces here (Koha::Account->add_debit, Koha::Account::Lin->adjust
bugs specifically)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:02:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:02:49 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-78UO4UWzTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to Tom?s Cohen Arazi from comment #4)
> > I have a concern: if we cache the record to be displayed, then the item
> > statuses won't be up-to-date. If the tradeoff is not enough, maybe this is
> > just not worth. Because people expect to see updated information on the
> > records.
> 
> Indeed.
> 
> I think we need to change this by moving items out of this XSLT file.
> I think we should use Ajax to load in realtime items infos, with and API for
> that.

I agree! Let's have that endpoint!

> This will also avoid indexing all record on item circulation.

Not sure about it, but we could certainly index items and make JOIN operations
in our queries ;-) (for limits, as David also suggests).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:34:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:34:25 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-xSrJA1K7uz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83726|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:34:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:34:21 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-TXdRazzu9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:34:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:34:55 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-ixJ6cmfo9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83734&action=edit
Bug 22084: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:35:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:35:01 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-tEsVgt6S1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83735&action=edit
Bug 22084: Plugin upgrade method and database plugin version storage will never
be triggered for existing installs

If an existing plugin begins using the upgrade() method, it will never actually
get triggered because the installation has already occurred and no database
plugin version was stored at the time. Without that database version, the
upgrade method will never be triggered.

In addition, if the plugin has no upgrade method, the installed version is
never updated in the database!

Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.

Test Plan:
1) Install an older version of the Kitchen sink plugin:
   *
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from
plugin_data for this plugin, to simulate having installed from an earlier
version of Koha
3) Upgrade to the latest version of the Kitchen sink plugin:
   *
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the
plugin_data table
5) Apply this patch
6) Restart all the things
7) Browse to the Kitchen sink configuration page, this should trigger the
upgrade method
8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in
plugin_data for the Kitchen Sink plugin

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:39:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:39:14 +0000
Subject: [Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for
 specifying a source number for SMS messages
In-Reply-To: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21988-70-3C21oqp088@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83175|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Comment on attachment 83175
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83175
Bug 21988: Add support for SMSSendFrom syspref

Obsoleting, as
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83176&action=diff
supercedes this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:39:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:39:38 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-pBqkykGLHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:39:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:39:44 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-gjNuCeltTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83621|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83736&action=edit
Bug 22058: Fix display of empty table cells in OPAC MARC view holdings

I compared the template logic to the MARC detail page in staff.
We use $raw there instead of html, which will also make notes and other
fields with HTML in them display correctly. I am proposing to use the
$raw filter in OPAC as well.

To test:
- Go to the OPAC
- Search for a record with items
- Switch to the MARC view
- Verify empty cells show &nbsp; (html entity for space)
- Apply patch
- Repeat test
- Verify empty table cells now show as empty

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:40:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:40:04 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-LbGLknpglF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:44:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:44:35 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-D30FX0gQEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Ammarah Siddiqui <ammarahsiddiqui at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
            Version|master                      |18.11
                 CC|                            |ammarahsiddiqui at gmail.com

--- Comment #188 from Ammarah Siddiqui <ammarahsiddiqui at gmail.com> ---
IT is really hard and tough for me to migrate data in koha , i have put all the
codes for koha correctly into marc file and miggrated properly but eg if
uploading 10,000 records , it show 10,000 records staged and 22,000 items
staged 

in that case i hae deleted the batch beletion and staged and undo catalogue ,
but data is still showing in staff client catalogue as well as in KOHA OPAC

Kindly review my problem and solve this issue 
Thank you so much

Regards
Ammarah Siddiqui
Senior Librarian
Bait-al-Hikmah Lbrary
Hamdard University
Karachi
Email: Ammarah.Siddiqui at hamdard.edu.pk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:47:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:47:24 +0000
Subject: [Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for
 specifying a source number for SMS messages
In-Reply-To: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21988-70-sVOsQmvnqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83175|1                           |0
        is obsolete|                            |

--- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Comment on attachment 83175
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83175
Bug 21988: Add support for SMSSendFrom syspref

Unobsoleting as it breaks application due to the missing ancestor. I'll
recreate these patches properly reverting the first one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 11:49:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 10:49:55 +0000
Subject: [Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for
 specifying a source number for SMS messages
In-Reply-To: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21988-70-H3Azc5acsO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988

--- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
D'oh! Ignore me, I was misreading the second patch, it replaces the contents of
the first one, so no obsoleting required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 12:11:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 11:11:47 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-aOEyFCt39U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

--- Comment #34 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Nick Clemens from comment #33)
> We should have a dependent bug to call reconcile balance for fines (when
> closed, not accruing) but I think is beyond scope here

Feel free to file a bug and assign it to me to deal with that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 12:16:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 11:16:38 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-TWRTb81EkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 12:53:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 11:53:04 +0000
Subject: [Koha-bugs] [Bug 21241] Set suggestion notices
 message_transport_type to sms if syspref is enabled and patron has an
 smsalertnumber but no email address
In-Reply-To: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21241-70-kFMpCiFk6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks solid to me.. go for it Nick.. my PQA still stands :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 12:53:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 11:53:12 +0000
Subject: [Koha-bugs] [Bug 21241] Set suggestion notices
 message_transport_type to sms if syspref is enabled and patron has an
 smsalertnumber but no email address
In-Reply-To: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21241-70-ZpYfpNbdVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 12:54:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 11:54:44 +0000
Subject: [Koha-bugs] [Bug 21776] Set ACQ_NOTIF_ON_RECEIV notice
 message_transport_type to sms if syspref is enabled and patron has an
 smsalertnumber but no email
In-Reply-To: <bug-21776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21776-70-lDt4s8bdAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21776

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:01:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:01:05 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-a5H28HExh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
           Keywords|Academy                     |

--- Comment #189 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removing Academy again ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:03:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:03:55 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-45cyewBhRJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83738&action=edit
Bug 22076 - Fix the same situation for lost items

Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:03:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:03:47 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-y7EoxmrbI9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83709|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83737&action=edit
Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response

If an item that is withdrawn is checked in via SIP2, Koha does not process the
checkin, but still indicates the checkin succeeded via the ok flag in the
checkin response message.

To recreate:
 1 - Mark an item withdrawn
 2 - Set up sip server:
     https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
 3 - Set 'BlockReturnOfWithdrawnItems' to block
 4 - Use the sip_cli_emulator to checkin the withdrawn item
 5 - There is no error in the checkin

Test Plan:
1) Mark an item withdrawn
2) Set BlockReturnOfWithdrawnItems to block
3) Use the sip cli emulator to checkin the withdrawn item
4) Note the response begins with 101
5) Apply this patch
6) Restart all the things ( including SIP server )
7) Repeat checkin with sip cli emulator
8) Note the checkin now beings with 100

Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:06:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:06:42 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-ibmjHDlH36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83739&action=edit
Bug 22076 - Add missing whitespace on if statments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:17:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:17:22 +0000
Subject: [Koha-bugs] [Bug 22085] New: UNIMARC default XSLT broken by Bug
	14716
Message-ID: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

            Bug ID: 22085
           Summary: UNIMARC default XSLT broken by Bug 14716
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Bug 14716 added a call to encode-uri() and namespace str.
This namespace declaration is sometimes missing in UNIMARC default XSLT files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:17:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:17:33 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-KMf17KvFyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:21:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:21:38 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-cvYn8q6vrw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14716


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716
[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:21:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:21:38 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-dZeF40tgGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22085


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085
[Bug 22085] UNIMARC default XSLT broken by Bug 14716
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:41:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:41:11 +0000
Subject: [Koha-bugs] [Bug 22007] KohaDates output does not need to be html
	filtered
In-Reply-To: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22007-70-L4GW2Cp4CL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22007

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #15 from Jesse Maseto <jesse at bywatersolutions.com> ---
Merge conflicts when attempting to backport to 18.05. If this is required for
18.05.x this will need to be rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:48:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:48:05 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-xnQG8bi52O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83734|0                           |1
        is obsolete|                            |
  Attachment #83735|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83740&action=edit
Bug 22084: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:48:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:48:35 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-RAnsastlkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83741&action=edit
Bug 22084: Plugin upgrade method and database plugin version storage will never
be triggered for existing installs

If an existing plugin begins using the upgrade() method, it will never actually
get triggered because the installation has already occurred and no database
plugin version was stored at the time. Without that database version, the
upgrade method will never be triggered.

In addition, if the plugin has no upgrade method, the installed version is
never updated in the database!

Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.

Test Plan:
1) Install an older version of the Kitchen sink plugin:
   *
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from
plugin_data for this plugin, to simulate having installed from an earlier
version of Koha
3) Upgrade to the latest version of the Kitchen sink plugin:
   *
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the
plugin_data table
5) Apply this patch
6) Restart all the things
7) Browse to the Kitchen sink configuration page, this should trigger the
upgrade method
8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in
plugin_data for the Kitchen Sink plugin

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:55:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:55:43 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
 version storage will never be triggered for existing installs
In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22084-70-4murX85yDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:57:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:57:08 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-YXgSaqDvwY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:57:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:57:25 +0000
Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok
 in checkin response
In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22076-70-6s99jf9bNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:57:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:57:38 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-UYBIwHVwsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #190 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Ammarah Siddiqui from comment #188)
> IT is really hard and tough for me to migrate data in koha , i have put all
> the codes for koha correctly into marc file and miggrated properly but eg if
> uploading 10,000 records , it show 10,000 records staged and 22,000 items
> staged 
> 
> in that case i hae deleted the batch beletion and staged and undo catalogue
> , but data is still showing in staff client catalogue as well as in KOHA OPAC
> 
> Kindly review my problem and solve this issue 
> Thank you so much
> 
> Regards
> Ammarah Siddiqui
> Senior Librarian
> Bait-al-Hikmah Lbrary
> Hamdard University
> Karachi
> Email: Ammarah.Siddiqui at hamdard.edu.pk

Hi Ammarah, this is a support question and not related to this bug report.
Please ask for help on the mailing list:
https://koha-community.org/support/koha-mailing-lists/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 13:58:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 12:58:06 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-cVwDqhFxjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #37 from Owen Leonard <oleonard at myacpl.org> ---
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:01:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:01:31 +0000
Subject: [Koha-bugs] [Bug 21802] Edit notices form is not aligned with
	accordeon headers
In-Reply-To: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21802-70-Ii3jacS07x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21802

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Not backported to 18.05. If this is needed please provide a patch for 18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:05:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:05:31 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-4qnq4tRiqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:05:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:05:59 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-D5lbjMEl0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:13:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:13:10 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-DglsKrQpsl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:13:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:13:10 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-Z7ocPHkH9f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18786
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:13:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:13:44 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-WflQ3gZUn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18786
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=18786                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
[Bug 18786] Add ability to create custom payment types
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:13:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:13:44 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-2jltNjXHkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21791
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=21791                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791
[Bug 21791] Add payment type on Cash register report (cash_register_stats.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:16:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:16:31 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-04QfYkk4po@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:19:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:19:49 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-r6L7dg9uHM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5620

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:19:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:19:49 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-ZsOAqh1iQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13985

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:20:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:20:13 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-uKHo1DhZ6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cash Management             |Cash Management - Koha as
                   |                            |'Point of Sale'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:23:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:23:54 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-T49o3SArHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15654

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:23:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:23:54 +0000
Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into
	Koha: An Example
In-Reply-To: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15654-70-TtFELKOGDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13985

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:26:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:26:11 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-7AHd7IqeO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=15894                   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:26:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:26:39 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-84sFvCaaUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21791

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:26:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:26:11 +0000
Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions
In-Reply-To: <bug-15894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15894-70-Z2FZ8cgxjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=5620                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:26:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:26:39 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-CvkSdVEIZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13985

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:26:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:26:47 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-f8u8UbkaWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:27:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:27:40 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-AQPgDTMXZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21938

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:27:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:27:40 +0000
Subject: [Koha-bugs] [Bug 21938] Add biblio information to credits on cash
	register
In-Reply-To: <bug-21938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21938-70-sQ5q7xBkUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21938

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13985

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:29:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:29:22 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-QQKbdz9q9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11373

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:29:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:29:22 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-cjdwuFlzyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13985

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:45:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:45:18 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-Xj14tpWoMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 14:45:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 13:45:20 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-Lh3XRwNoGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83699|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83742&action=edit
Bug 22066: Record library_id for manual credits

On creating manual credits, the (newly introduced) branchcode should be
set now. This trivial patch makes it work.

To test:
- Create a manual credit for a known patron
- Using MySQL check the result:
  $ sudo mysql
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> FAIL: The created accountline row has NULL for the branchcode
- Apply this patch
- Create a manual credit for the patron
- Run:
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> SUCCESS: branchcode is set correctly
-Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:14:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:14:05 +0000
Subject: [Koha-bugs] [Bug 21016] Plugins: Expand usage of opac_js method,
 or create intranet_js
In-Reply-To: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21016-70-kswVZl9TJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Duplicate of bug 21352 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:21:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:21:59 +0000
Subject: [Koha-bugs] [Bug 21016] Plugins: Expand usage of opac_js method,
 or create intranet_js
In-Reply-To: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21016-70-ieLQknSS6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Definitely a duplicate!

*** This bug has been marked as a duplicate of bug 21352 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:21:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:21:59 +0000
Subject: [Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to
 Staff interface
In-Reply-To: <bug-21352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21352-70-D0vRWCcZ7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 21016 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:26:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:26:51 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-1XtRxQHzxK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83720|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83743&action=edit
Bug 17353: Add phone number column to checkout search

This patch adds borrowers.phone as 'Primary phone' in the checkout
search results. It also ads the table to columns configuration

To test:
1 - Perform a checkout search
2 - Note phone is not displayed
3 - Apply patch
4 - Note phone does not display
5 - Visit columns configuration
6 - Unhide the 'phone' column
7 - Note phone displays
8 - Ensure page functions as before patch

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:26:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:26:48 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-FPE4ppVryh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:47:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:47:26 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-cb4LPXqust@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:48:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:48:50 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-r4Y0I4gK36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83742|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83744&action=edit
Bug 22066: Record library_id for manual credits

On creating manual credits, the (newly introduced) branchcode should be
set now. This trivial patch makes it work.

To test:
- Create a manual credit for a known patron
- Using MySQL check the result:
  $ sudo mysql
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> FAIL: The created accountline row has NULL for the branchcode
- Apply this patch
- Create a manual credit for the patron
- Run:
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> SUCCESS: branchcode is set correctly
-Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:48:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:48:48 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-lP3v1kRAfJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:55:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:55:14 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-2FxyxJPaq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:55:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:55:17 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-j9TbizoUCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79046|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83745&action=edit
Bug 19945: ILSDI - Return the reason a reserve is impossible

Currently, the ILDSI services HoldTitle and HoldItem always return a
"NotHoldable" code is the reserve is impossible. We need to know why

Test plan:

 - Apply this patch
 - Place a hold on a non reservable title using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=)
 - you should get the reason instead of NotHoldable,
 - Place a hold on a non reservable item using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1)
 - you should get the reason instead of NotHoldable,

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:55:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:55:33 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-W7z628E4SH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79047|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83746&action=edit
Bug 19945: (follow-up) optimization and test correction

The double call to CanItemBeReserved was pointless in
the C4/Reserves.pm HoldItem, as CanBookBeReserved calls
CanItemBeReserved and even returns that code.

Additionally, the tests failed, because there were 5
tests not 4.

TEST PLAN
----------
prove t/db_dependent/ILSDI_Services.t
run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:55:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:55:36 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-mhYGDogU2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79048|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83747&action=edit
Bug 19945: Add a test proving that using CanBookBeReserved in ILSDI::HoldItem
is wrong.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 15:55:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 14:55:40 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-HpwHd1dvIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79049|0                           |1
        is obsolete|                            |

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83748&action=edit
Bug 19945: Use CanItemBeReserved in ILSDI HoldItem instead of
CanBookBeReserved.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:13:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:13:31 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-WZ4JGRlFBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:13:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:13:35 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-NMOdXjSAfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83579|0                           |1
        is obsolete|                            |
  Attachment #83580|0                           |1
        is obsolete|                            |
  Attachment #83581|0                           |1
        is obsolete|                            |

--- Comment #69 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83749&action=edit
Bug 17006: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:13:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:13:40 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-to648PPXjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #70 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83750&action=edit
Bug 17006: OpenAPI spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:13:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:13:45 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-dEzXRwJgEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #71 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83751&action=edit
Bug 17006: Add /patrons/{patron_id}/password

This patch introduces an endpoint for changing a patron's password. It
targets privileged user with the right permissions, changing some
patron's password.

To test:

- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t
=> SUCCESS: tests pass!
- Play with the different use cases highlighted by the tests, on your
favourite REST testing tool (Postman, RESTer on FF, etc).

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:15:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:15:36 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-23FskIPMRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82251|0                           |1
        is obsolete|                            |
  Attachment #83637|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83752&action=edit
Bug 21738: check items count in C4:ILSDI::HoldTitle

Test plan:
  - Try holding a title without items via ILS-DI
    (cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1),
  - you get an error,
  - apply this patch,
  - try again,
  - you should get the code "Notitems"Bug 21738: check items count in
    C4:ILSDI::HoldTitle

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:15:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:15:45 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-Euohn9mF3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83753&action=edit
Bug 21738: make call of CanBookBeReserved more safe

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:15:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:15:33 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-A0KsFfY5sv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:26:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:26:54 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-bOBt6ZfruC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
t/db_dependent/api/v1/patrons_password.t .. Could not load document from
/home/vagrant/kohaclone/api/v1/swagger/paths/public_patrons.json: Can't open
file "/home/vagrant/kohaclone/api/v1/swagger/paths/public_patrons.json": No
such file or directory at /usr/share/perl5/JSON/Validator.pm line 154.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 16:32:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 15:32:38 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl
In-Reply-To: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21346-70-DhvqmLsEFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #51 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 82891
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82891
Bug 21346: Remove inline onclicks per comment 42

Review of attachment 82891:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21346&attachment=82891)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +672,2 @@
>                      [% ELSE %]
> +                        <input type="checkbox" id="return_date_override_remember" name="return_date_override_remember" />

While the code below actually fixes some of the inline javascript that you
corrected, I don't see anything that is the equivalent of forcing the focus to
barcode for this. I'll look at the full file to confirm if there is something
already.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:11:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:11:47 +0000
Subject: [Koha-bugs] [Bug 7088] cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-lXCuGzRmwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:26:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:26:06 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-xy1QFOJStQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:26:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:26:08 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-agbOAEQhRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 83754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83754&action=edit
Bug 22085: fix UNIMARC default XSLT broken by Bug 14716

Bug 14716 added a call to encode-uri() and namespace str.
This namespace declaration is sometimes missing in UNIMARC default XSLT files.

This patch adds namespace declaration also where encode-uri is not used because
it may be used in the future. And those files are the base for home made custom
files.

Test plan :
1) Use a UNIMARC DB
2) Use default in all XSLT sysprefs
3) Apply patch
4) Perform a search on OPAC
5) Check display is OK
6) Click on a record for detail page
7) Check display is OK
8) Perform a search on staff interface
9) Check display is OK
10) Click on a record for detail page
11) Check display is OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:32:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:32:11 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-tPQx3MMftj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83681|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83755&action=edit
Bug 22061: OpenAPI spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:32:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:32:14 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-9Oi89qrhcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83682|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83756&action=edit
Bug 22061: Public route to change password

This patch implements a route to change patron's password for
unprivileged users. It's intended for using in the OPAC (or however
consumers find it useful).

It is a starting point for the public API, and the bug also implements
the on/off switch some community members asked for.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t \
          t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass! i.e.
        - RESTPublicAPI is honoured
        - The /public/patrons/:patron_id/password endpoint works as
        expected
- Use your favourite API testing tool to try the endpoint.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:32:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:32:41 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-TyR03r1omj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |19.05
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 17:47:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 16:47:07 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-rVyOcLw7RN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #129 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83757&action=edit
Bug 21753: DBRev 18.12.00.007

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 18:05:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 17:05:40 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-RxXvqe5aJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83757|0                           |1
        is obsolete|                            |

--- Comment #130 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83758&action=edit
Bug 21753: DBRev 18.12.00.007

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:07:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:07:19 +0000
Subject: [Koha-bugs] [Bug 22086] New: Birthday Wishes email to patron
Message-ID: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

            Bug ID: 22086
           Summary: Birthday Wishes email to patron
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mishravk79 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

Dear All,

We are sending a lot of alert messages through Koha like book renewal, hold,
overdue, etc. So how can we make this possible to send birthday wishes from
Koha?

The system should match the Koha server date with patron birthday record/field
and send a wish as per library defined format like other email alerts?

The case may be similar to already available email alerts to patron before
their account expire in system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:26:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:26:16 +0000
Subject: [Koha-bugs] [Bug 22087] New: It would be helpful to have City and
 State visible in member.pl
Message-ID: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

            Bug ID: 22087
           Summary: It would be helpful to have City and State visible in
                    member.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

When a staff member searches for a patron via the search patron box or filters
a search through the patron module, they get results on members-home.pl or
member.pl. The column for name includes firstname, surname, address and email.
It would be beneficial to also see the city and state.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:52:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:52:12 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-3BGChp1Moa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:52:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:52:18 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-9Z8CIXT2sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83760&action=edit
Bug 21846: Regression tests for add_tag_approval

Due to collation issues, add_tag_approval wrongly calculates
the weight for strings including extended UNICODE characters.

This patch introduces a test for this situation.

To test:
- Apply this patch on master
- Run:
  $ kshell
 k$ prove t/db_dependent/Tags.t
=> FAIL: Tests fail because all extended characters match the same

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:52:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:52:21 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-pIbhDd63U6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83761&action=edit
Bug 21846: Make 'term' use utf8mb_bin collation on tags tables

This patch makes the utf8mb4_bin collation preferred for comparing tags.
Otherwise suppolemental unicode characters all match.

To test:

- Enable tags and disable moderation (or plan to moderate and accept tags)
- Tag 3 records:
   a - with ?
   b - with ?
   c - with ?
- Note the weight on each says '3'
- Click the tag to search, you get back all the records
- Apply the previous patches from this bug report
- Run:
  $ kshell
 k$ prove t/db_dependent/Tags.t
=> FAIL: Tests fail, related to counting stuffs
- Apply this patch and
(a) Run updatedatabase to upgrade the schema
- Run:
 k$ prove t/db_dependent/Tags.t
=> SUCCESS: Tests pass!
(b) reset_all to get a fresh DB using kohastructure.sql
- Run:
 k$ prove t/db_dependent/Tags.t
=> SUCCESS: Tests pass too!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:52:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:52:24 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-1cyEQLbeGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83762&action=edit
Bug 21846: (follow-up) Add maintenance script

This patch adds a maintenance script that generates the missing
tags_approval entries based on the tags_all table, and then recalculates
the weights for both tags_approval and tags_index tables.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:52:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:52:15 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-TDlOit21QL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82621|0                           |1
        is obsolete|                            |
  Attachment #82622|0                           |1
        is obsolete|                            |
  Attachment #82623|0                           |1
        is obsolete|                            |
  Attachment #83717|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83759&action=edit
Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es)

In order to avoid writing the tests using plain DBIC which would later
need to be replaced by a Koha::Object-based counterpart, I introduce
this stub classes.

Stub tests are added as well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Tags.t \
          t/db_dependent/Koha/Tags/Approvals.t \
          t/db_dependent/Koha/Tags/Indexes.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 19:54:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 18:54:04 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-KYaSeWlkSq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
These patches worked as expected for me. I did get inconsistent results from
'prove t/db_dependent/Tags.t.' It sometimes passed and sometimes didn't.

The QA tool has some complaints, but I'm not sure if they're false positives.
I'll leave it for QA to decide.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:00:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:00:04 +0000
Subject: [Koha-bugs] [Bug 22088] New: Possibility to add new course when
 consulting another one
Message-ID: <bug-22088-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22088

            Bug ID: 22088
           Summary: Possibility to add new course when consulting another
                    one
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Hi, 

It would be nice if when you consult a course in the reserve, to have the
possibility to creat new course. It would be interesting to have a button "new
course" when we are in the page of a course in the reserve of course. This
would avoid having to return to the homepage of the reserve of course and would
allow to add several courses one after the others.this addition to Koha would
be very useful.

thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:10:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:10:55 +0000
Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is
 faulty when there are waiting/intransit holds
In-Reply-To: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21608-70-mwKzBP1rhQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:15:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:15:17 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-PbVGnjezfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:15:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:15:20 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-zPDtHje5Bg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83715|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83763&action=edit
Bug 22083: Typo in circulation_batch_checkouts.tt

There is a typo in circulation_batch_checkouts.tt that makes Koha skip
a warning if the user cannot borrow due to circulation rules.

This patch corrects this typo.

To test:

1. In Administration > Global system preferences, 'Allow'
   BatchCheckouts and enter patron categories in
   BatchCheckoutsValidCategories
2. Go to Administration > Circulation and fines rules
3. Enter a rule where a certain category of patrons (that is in
   BatchCheckoutsValidCategories) cannot take out a particular item type
4. Search the catalog for an item of that item type
5. Copy the barcode
6. Go into patrons and find a patron of that category
7. Click on the Batch checkout tab
8. Paste the barcode in the box and click Check out
9. It should say 'Too many checked out'
10. Apply the patch
11. Try the check out again, it should show both warnings ('Too many
    checked out' and 'This patron can't check out this item per library
    circulation policy')

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:15:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:15:49 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-tY76tgiuMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:15:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:15:53 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-5MzsP1sAPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83613|0                           |1
        is obsolete|                            |
  Attachment #83614|0                           |1
        is obsolete|                            |
  Attachment #83680|0                           |1
        is obsolete|                            |
  Attachment #83755|0                           |1
        is obsolete|                            |
  Attachment #83756|0                           |1
        is obsolete|                            |

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83764&action=edit
Bug 22061: Add RESTPublicAPI syspref

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:15:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:15:59 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-suxRmLQuWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83765&action=edit
Bug 22061: Add a /public namespace that can be switched on/off

This patch adds a check in Koha::REST::V1::Auth::under to catch all
routes that begin with 'public' (inside /api/v1). If they match, and the
RESTPublicAPI syspref is off, then an exception is thrown, rendering a
403 error to the consumer.

Otherwise the routes are processed as usual. This is THE on/off switch
for the public REST API. The target use case: people not wanting an OPAC
or public interaction with the API besides privileged users.

In order to test, the rest of the patches are needed because the only
way to test a route is having it in the spec.

To test:
- Apply the patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth.t
=> SUCCESS: tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:16:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:16:05 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-1XQBnuic8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83766&action=edit
Bug 22061: Unit tests

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:16:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:16:10 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-jHiqQUrWuM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83767&action=edit
Bug 22061: OpenAPI spec

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:16:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:16:15 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-YvWv8tkqOM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83768&action=edit
Bug 22061: Public route to change password

This patch implements a route to change patron's password for
unprivileged users. It's intended for using in the OPAC (or however
consumers find it useful).

It is a starting point for the public API, and the bug also implements
the on/off switch some community members asked for.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t \
          t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass! i.e.
        - RESTPublicAPI is honoured
        - The /public/patrons/:patron_id/password endpoint works as
        expected
- Use your favourite API testing tool to try the endpoint.
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:17:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:17:47 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
	templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-m8XaX8a4E0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |mtompset at hotmail.com

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
you missed line 128 or so in
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt
There is still an onclick.

Also, there seems to be a problem with using every authorized value in the drop
down. I chose the birthday reason one, and it didn't say, in either the club or
the other field. Though, I think that might be beyond the scope of this bug,
and yet fixing it first would make testing this bug easier.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:20:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:20:35 +0000
Subject: [Koha-bugs] [Bug 22089] New: add an option to indicate that a item
 must be delivered
Message-ID: <bug-22089-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22089

            Bug ID: 22089
           Summary: add an option to indicate that a item must be
                    delivered
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

Hi,

It would be nice to have a checkbox to determine if a reservation should be
delivered to the borrower who requested it. This could be an available box when
delivering in the staff interface. It would be used to indicate that this
reservation must be delivered to the borrower. Like this when the item back to
the library we would be notified that this item should be delivered to the next
listed user for reservations.

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:21:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:21:09 +0000
Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of
	prevent_submit.js
In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15911-70-GNHf7NtJ84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:22:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:22:52 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-R6AXpEJi6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83758|1                           |0
           is patch|                            |
  Attachment #83758|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:30:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:30:59 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-Vqqthoutmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:32:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:32:04 +0000
Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No
 Renewal Before period
In-Reply-To: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20360-70-5pmCu5HAzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 20:54:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 19:54:15 +0000
Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate
 between emoji when calculating weights or searching
In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21846-70-7HSSTeRnoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Owen Leonard from comment #11)
> These patches worked as expected for me. I did get inconsistent results from
> 'prove t/db_dependent/Tags.t.' It sometimes passed and sometimes didn't.
> 
> The QA tool has some complaints, but I'm not sure if they're false
> positives. I'll leave it for QA to decide.

Owen, thanks for reporting that. The problem is the patchset isn't updating the
DBIC schema files. You can do it by issuing the following command

 $ dbic

on the 'vagrant' user.

The @RM will provide those schema updates when pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 21:46:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 20:46:01 +0000
Subject: [Koha-bugs] [Bug 22090] New: cash_register_stats.pl export missing
	data
Message-ID: <bug-22090-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22090

            Bug ID: 22090
           Summary: cash_register_stats.pl export missing data
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When exporting a cash_register_stats.pl report, the following fields are
missing: 
manager surname
patron surname
note

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  9 22:26:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 21:26:20 +0000
Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch
In-Reply-To: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15497-70-0AnRVwsLRJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Seeking cosponsors          |Sponsored
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 00:53:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Jan 2019 23:53:34 +0000
Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on
 issue and return based on syspref values
In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21159-70-PXb2ASUWiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Brian <bklein at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bklein at dubuque.lib.ia.us

--- Comment #20 from Brian <bklein at dubuque.lib.ia.us> ---
Any updates on bug 21159?

Carnegie team

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 02:17:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 01:17:34 +0000
Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger
In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18205-70-RtqWCPdCVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
This still hasn't been rebased, so not sure if I can test bug 18206.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 02:58:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 01:58:17 +0000
Subject: [Koha-bugs] [Bug 20572] Refactor AddIssuingCharges parameter to
	hashref
In-Reply-To: <bug-20572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20572-70-u49VSWsqpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20572

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|Needs Signoff               |RESOLVED
   Patch complexity|---                         |Trivial patch

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
The AddingIssuingCharges was changed to pass an Issue object in another bug.
This is no longer relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 03:26:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 02:26:50 +0000
Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export
In-Reply-To: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18143-70-HGSTyBB4Ln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 03:48:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 02:48:34 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
	templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-ZDRZ7xo2oT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Owen Leonard from comment #7)
> (In reply to Candice Hope from comment #6)
> > 
> > DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: ''
> 
> I don't think that error is related to my patch, so I'm going to set this
> back to "Needs signoff."

I concur, as I did not experience errors like this. Perhaps they got logged and
I didn't read them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 03:50:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 02:50:13 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-2AMrQdT3YO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #7)
> (In reply to Fridolin SOMERS from comment #5)
> > This will also avoid indexing all record on item circulation.
> 
> Not sure about it, but we could certainly index items and make JOIN
> operations in our queries ;-) (for limits, as David also suggests).

I was totally thinking about that, as I was thinking about Solr query joins. I
imagine ElasticSearch must be able to do the same thing, although I don't think
Zebra could. Or did you have something in mind for JOIN operations?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 04:50:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 03:50:00 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-SopnosnAf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #38 from David Cook <dcook at prosentient.com.au> ---
(In reply to Owen Leonard from comment #37)
> https://wiki.koha-community.org/wiki/
> Working_with_SCSS_in_the_OPAC_and_staff_client

You're a champion, Owen. I'll take a look ASAP.

Realized late last night I'm still doing half days so might need a bit more
time to test this one..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 04:50:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 03:50:31 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-TygOUTIiWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #39 from David Cook <dcook at prosentient.com.au> ---
Also going to be trying it in koha-testing-docker so wish me luck...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 04:53:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 03:53:18 +0000
Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No
 Renewal Before period
In-Reply-To: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20360-70-vbRNChb8Pa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #3)
> Please take a look at bug 19014, I think it fixes the issue you face.

Happy to get more people looking at bug 19014. 

"It's also an issue for us with holds--Patron A will receive a failed renewal
notice the day after Patron B places a hold on a book checked out to Patron A,
regardless of how many days remain before the actual due date of book for
Patron A."

I've been hearing about this one a lot and would love to find a solution to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 05:59:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 04:59:24 +0000
Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron
In-Reply-To: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22086-70-AXkujHZwFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

Vinod <mishravk79 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mishravk79 at gmail.com

--- Comment #1 from Vinod <mishravk79 at gmail.com> ---

Requirements:

Nowadays clients send Birthday Wishes through SMS/email alerts from Banks or
other organizations on their Birthday. It makes the clients feel happy due to
personalize the message on a specific day. The library may also send the same
to bring patrons close to the library and build good repo about librarians.

Test:

1. Patron fields already contain the date of birth field in their data entry
module
2. The system may regularly check the date of birth field and if a match with
server date is found a Birthday message should deliver.
3. The message content should be customizable like other email alert service
4. There should be an option to use or not to use this option

Hope the above idea is good and it is possible to do similar to sending the
message alert before the expiry of the patron registration date.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 07:06:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 06:06:12 +0000
Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron
In-Reply-To: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22086-70-NClqleR25g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |
                 CC|                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 07:06:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 06:06:50 +0000
Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron
In-Reply-To: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22086-70-a5zobTVJDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

--- Comment #2 from Amit Gupta <amitddng135 at gmail.com> ---
I am interested to develop this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 07:06:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 06:06:26 +0000
Subject: [Koha-bugs] [Bug 22091] New: Need Details of Books or Accession
 Number issued to particular patron via SIP2
Message-ID: <bug-22091-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22091

            Bug ID: 22091
           Summary: Need Details of Books or Accession Number issued to
                    particular patron via SIP2
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rohit.sethi at libsys.co.in
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

Dear Team,

Please let us know the possibility, that can we get a details of Books or
Accession number via SIP2 module.

If possible please provide detailed information.

Also is it possible to get the info that to which patron the particular
accession number is issued via SIP2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 07:33:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 06:33:11 +0000
Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron
In-Reply-To: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22086-70-b3cxor99CK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Patrons                     |Notices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 08:15:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 07:15:33 +0000
Subject: [Koha-bugs] [Bug 22092] New: When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
Message-ID: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

            Bug ID: 22092
           Summary: When creating a new subscription, biblio.serial is not
                    set if field 942 is missing.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 08:21:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 07:21:34 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-1tGA99USpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at helsinki.fi> ---
Created attachment 83769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83769&action=edit
0001-Bug-22092-When-creating-a-new-subscription-biblio.se.patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 08:21:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 07:21:45 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-1WwJxzTit6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

Olli-Antti Kivilahti <olli-antti.kivilahti at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 08:38:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 07:38:38 +0000
Subject: [Koha-bugs] [Bug 2081] Unable to edit an authorised value
In-Reply-To: <bug-2081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2081-70-Ag521PD90G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2081

divya <divya.divya145 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |divya.divya145 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 08:40:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 07:40:56 +0000
Subject: [Koha-bugs] [Bug 22093] New: unable to enter password
Message-ID: <bug-22093-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22093

            Bug ID: 22093
           Summary: unable to enter password
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: divya.divya145 at gmail.com
  Target Milestone: ---

Password mismatch occur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 08:43:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 07:43:31 +0000
Subject: [Koha-bugs] [Bug 22093] unable to enter password
In-Reply-To: <bug-22093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22093-70-9uA7QhyZhH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22093

divya <divya.divya145 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Deadline|                            |2019-01-10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 12:22:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 11:22:46 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-QEl99BWuIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #8)
> (In reply to Tom?s Cohen Arazi from comment #7)
> > (In reply to Fridolin SOMERS from comment #5)
> > > This will also avoid indexing all record on item circulation.
> > 
> > Not sure about it, but we could certainly index items and make JOIN
> > operations in our queries ;-) (for limits, as David also suggests).
> 
> I was totally thinking about that, as I was thinking about Solr query joins.
> I imagine ElasticSearch must be able to do the same thing, although I don't
> think Zebra could. Or did you have something in mind for JOIN operations?

I was thinking ES. Zebra support is in freeze mode. And I'm sure you cannot mix
different databases on a query.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:11:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:11:06 +0000
Subject: [Koha-bugs] [Bug 21334] Add bibliographic content type definitions
In-Reply-To: <bug-21334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21334-70-3uYfth9xrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334

Justin Jack <adamgrayling at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adamgrayling at gmail.com

--- Comment #12 from Justin Jack <adamgrayling at gmail.com> ---
(In reply to Josef Moravec from comment #7)
> Created attachment 78600 [details] [review]
> Bug 21334: Add bibliographic content type definitions
> 
> This patch adds the following content type definitions, to be used by
> endpoint authors implementing MARC-related endpoints:
> 
> --------------------------------------
> | Content-type             | Alias   |
> |--------------------------|---------|
> | application/marcxml+xml  | marcxml |
> | application/marc-in-json | mij     |
> | application/marc         | marc    |
> --------------------------------------
> 
> Code using this aliases will use them like this:
> - Suppose you want to output data in MARCXML format:
> 
> my $record = cool_method_that_returns_MARC_RECORD();
> return $c->render( status => 200, format => 'marcxml', text =>
> $record->as_xml_record );
> 
> Note: 'text' by defaults encodes output as UTF-8. If the encoding is not
> UTF-8 you should encode the data on your own.
> 
> To test:
> - Apply this patches
> - Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/REST/V1.t
> => SUCCESS: Test pass!
> - Sign off :-D
> 
> Signed-off-by: Michal Denar <https://whatstatus.co/guess-ill-die>
> 
> Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

After pushing bug 21116 I decided this one warranted backporting for the same
reasons outlined on that bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:37:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:37:45 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-quEESjqRuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:39:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:39:36 +0000
Subject: [Koha-bugs] [Bug 20729] Update style of datepickers
In-Reply-To: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20729-70-jHR5tuK7Kh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:42:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:42:16 +0000
Subject: [Koha-bugs] [Bug 9069] Make it possible to import MARC21
 authorities from VIAF into Koha
In-Reply-To: <bug-9069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9069-70-NT5enIlzgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:42:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:42:17 +0000
Subject: [Koha-bugs] [Bug 22094] New: REST API: Add endpoint /serials
Message-ID: <bug-22094-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22094

            Bug ID: 22094
           Summary: REST API: Add endpoint /serials
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:47:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:47:40 +0000
Subject: [Koha-bugs] [Bug 21826] Automatic authority record generation
	improvements
In-Reply-To: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21826-70-9fEp79PiyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:48:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:48:21 +0000
Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
	authorities
In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13412-70-T4ODsBZkVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 13:51:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 12:51:04 +0000
Subject: [Koha-bugs] [Bug 22093] unable to enter password
In-Reply-To: <bug-22093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22093-70-wpK8buyjj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22093

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:06:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:06:46 +0000
Subject: [Koha-bugs] [Bug 22095] New: Dead link in web installer
Message-ID: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

            Bug ID: 22095
           Summary: Dead link in web installer
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mik at adminkuhn.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

When configuring Koha 18.11 using the web installer you can opt for authorized
values according to Z39.71-2006 Holdings Statements for Bibliographic Items
(this part was formerly called "marc21_holdings_coded_values"). It is
accompanied with the URL http://www.niso.org/standards/index.html

Calling this URL says "The requested page could not be found."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:25:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:25:36 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-IguyKWmkLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:41:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:41:13 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-qJEltarSr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:42:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:42:21 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-C6yZEIZ5eu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:45:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:45:44 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-oBM7ipp1pL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:47:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:47:59 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-iqsNrhX6Db@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 14:51:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 13:51:43 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-7D51blHaTI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:02:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:02:09 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-hFllH141ul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:12:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:12:43 +0000
Subject: [Koha-bugs] [Bug 21786] Routes for credits should include library_id
In-Reply-To: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21786-70-RXYIr8OeUM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Severity|normal                      |enhancement
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Depends on enhancement in bug 19066, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:14:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:14:03 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-nsTO7zKTgr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:14:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:14:21 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-tTERWlBd3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:18:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:18:06 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-Ei1gu4BpuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:17:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:17:48 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-z3whAIYOVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:18:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:18:46 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-DX8B0plZMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:20:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:20:47 +0000
Subject: [Koha-bugs] [Bug 21786] Routes for credits should include library_id
In-Reply-To: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21786-70-jG1xJh8H27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:21:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:21:30 +0000
Subject: [Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment
 should pass library_id to ->pay
In-Reply-To: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21788-70-prEp99CtZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Depends on enhancement in bug 19066, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:24:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:24:29 +0000
Subject: [Koha-bugs] [Bug 22071] Make authenticate_api_request stash
 koha.user in OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-3MhoaeyZKB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 15:24:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 14:24:56 +0000
Subject: [Koha-bugs] [Bug 22071] authenticate_api_request does not stash
 koha.user in the OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-bRI278nzw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make                        |authenticate_api_request
                   |authenticate_api_request    |does not stash koha.user in
                   |stash koha.user in OAuth    |the OAuth use case
                   |use case                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:01:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:01:41 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-kAK7YU466s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:09:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:09:47 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-0HoBNz3CiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21751


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
[Bug 21751] fixFloat toolbar not displaying properly in Chrome
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:09:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:09:47 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-8VnqHpg3Sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22045


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045
[Bug 22045] Cataloging UX enhancement - Improve access to tabs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:16:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:16:19 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-E2KmtIgVjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83770&action=edit
Bug 22045: Cataloging UX enhancement - Improve access to tabs

This patch makes style changes to the standard MARC editor with the goal
of both making it more responsive and making it easier to navigate among
tabs and tags.

Tabs are now part of the page's toolbar, which floats as the page
scrolls. In addition to the numbered tabs, there is also a section
showing in-page links to the MARC tags which are available on that page.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

Open a blank or existing record in the standard cataloging editor. Test
the redesigned tabs, the floating toolbar, and the in-page tag links.
Confirm that everything works well at various browser widths.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:16:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:16:15 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-DWRXPbwZ0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:30:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:30:59 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
	templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-37vn72CYXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:31:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:31:02 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
	templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-BBctgzk9hH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82332|0                           |1
        is obsolete|                            |

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83771&action=edit
Bug 18530: Remove event attributes from patron clubs templates

This patch removes event attributes like "onclick" from patron clubs
templates in favor of putting these event handlers in the JavaScript.

To test, apply the patch and go to Tools -> Patron clubs.

 - Test deletion of both club templates and clubs. Deletion confirmation
   dialogs should work as expected, both for OK and Cancel.
 - Test editing of a club template. Under "Club fields," the "Add new
   field" and "Delete field" links should work correctly.
 - Open a patron record for checkout.
   - Test enrolling and un-enrolling the patron.
   - Test the same process from the patron detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:32:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:32:12 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
	templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-Nth7VVmRJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to M. Tompsett from comment #8)

> I chose the birthday reason one, and it didn't say, in either the
> club or the other field.

I don't understand this description, but if the problem exists in master please
file a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:49:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:49:07 +0000
Subject: [Koha-bugs] [Bug 22059] Wrong exception parameters in
	Koha::Patron->set_password
In-Reply-To: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22059-70-yLo9d3XBPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
21178 not in 18.05, not backporting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:49:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:49:07 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-42Q3ECkjch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
Bug 17006 depends on bug 22059, which changed state.

Bug 22059 Summary: Wrong exception parameters in Koha::Patron->set_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:50:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:50:52 +0000
Subject: [Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear
 old fines as did recordpayment
In-Reply-To: <bug-18580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18580-70-5DfTXV6p7Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899
[Bug 15899] Remove the use of recordpayment
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:50:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:50:52 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-Z0XsqjfWnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18580


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580
[Bug 18580] Account-pay does not apply credits / clear old fines as did
recordpayment
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:51:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:51:57 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-pMeJH3pIN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|In the past, if a patron    |In the past, if a patron
      release notes|had any credit existing on  |had any credit existing on
                   |their account (newly added, |their account (newly added,
                   |or pre-existing), if debts  |or pre-existing), if debts
                   |were present then the       |were present then the
                   |credit balance would always |credit balance would always
                   |be immediately applied to   |be immediately applied to
                   |the debt.  This             |the debt.  This
                   |functionality was           |functionality was
                   |inadvertently removed       |inadvertently removed
                   |during refactoring efforts. |during refactoring efforts
                   |
                           |which debuted in 16.11.
                   |This patch adds code to     |
                   |restore the functionality   |This patch adds code to
                   |and allows it to be         |restore the functionality
                   |optionally applied to the   |and allows it to be
                   |system via a new system     |optionally applied to the
                   |preference,                 |system via a new system
                   |`AccountAutoReconcile`.     |preference,
                   |                            |`AccountAutoReconcile`.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:52:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:52:20 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-CzNEhaRHjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21915


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915
[Bug 21915] Add a way to automatically reconcile balance for patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:52:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:52:20 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-fb2Ktvq7gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899
[Bug 15899] Remove the use of recordpayment
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 16:53:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 15:53:43 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-lm4AE1DXbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|new feature                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:15:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:15:25 +0000
Subject: [Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing
 records from a staged file
In-Reply-To: <bug-20324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20324-70-8hG7lyXIpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324

--- Comment #3 from Sandre Cunha <cunha at monterey.org> ---
Is anyone working on this? Could we get some action?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:21:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:21:23 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-iJ4SpAZZeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:22:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:22:05 +0000
Subject: [Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing
 records from a staged file
In-Reply-To: <bug-20324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20324-70-VVUMtP7qAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
If waiting for an unpaid volunteer to fix this bug is taking too long, you
could always try paid support: https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:23:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:23:18 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-YzJpUkMsgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|In the past, if a patron    |In the past, if a patron
      release notes|had any credit existing on  |had any credit existing on
                   |their account (newly added, |their account (newly added,
                   |or pre-existing), if debts  |or pre-existing), if debts
                   |were present then the       |were present then the
                   |credit balance would always |credit balance would always
                   |be immediately applied to   |be immediately applied to
                   |the debt.  This             |the debt.  This
                   |functionality was           |functionality was
                   |inadvertently removed       |inadvertently removed
                   |during refactoring efforts  |during refactoring efforts
                   |which debuted in 16.11.
    |which debuted in 16.11.
                   |                            |
                   |This patch adds code to     |This patch adds code to
                   |restore the functionality   |restore the functionality
                   |and allows it to be         |and allows it to be
                   |optionally applied to the   |optionally applied to the
                   |system via a new system     |system via a new system
                   |preference,                 |preference,
                   |`AccountAutoReconcile`.     |`AccountAutoReconcile`.
                   |                            |
                   |                            |Note: The new preference
                   |                            |defaults to the post 16.11
                   |                            |behaviour, if you wish to
                   |                            |restore the 16.11
                   |                            |functionality then you will
                   |                            |need to update the
                   |                            |preference after the
                   |                            |upgrade.
             Status|Pushed to Stable            |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:23:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:23:40 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-aJnDcwseec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:24:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:24:25 +0000
Subject: [Koha-bugs] [Bug 21436] Switch two-column templates to Bootstrap
 grid: Tools part 4
In-Reply-To: <bug-21436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21436-70-FW8dgQKcwp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:24:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:24:25 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-mHYrASQs5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21436, which changed state.

Bug 21436 Summary: Switch two-column templates to Bootstrap grid: Tools part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:36:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:36:28 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-kqRvvVASZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:36:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:36:31 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-aqeGsoUend@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #29 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83772&action=edit
Bug 20959: (follow-up) Alternate: Add preventDefault to link controls

This patch adds a missing preventDefault to the function for showing and
hiding the checkin settings panel. This prevents the page from
unexpected scrolling when the link is clicked.

To test, apply the patch and go to Circulation -> Check in. Reduce the
height of the browser window until you have to scroll down to reveal the
"Checkin settings" link. Clicking it should not cause the page to
scroll.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:39:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:39:06 +0000
Subject: [Koha-bugs] [Bug 22096] New: Missing default values in
	'social_data' table
Message-ID: <bug-22096-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22096

            Bug ID: 22096
           Summary: Missing default values in 'social_data' table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

With strict SQL modes enabled there is a discrepancy in the generated schema
files:

diff --git a/Koha/Schema/Result/SocialData.pm
b/Koha/Schema/Result/SocialData.pm
index b2d835b..0388635 100644
--- a/Koha/Schema/Result/SocialData.pm
+++ b/Koha/Schema/Result/SocialData.pm
@@ -26,6 +26,7 @@ __PACKAGE__->table("social_data");
 =head2 isbn

   data_type: 'varchar'
+  default_value: (empty string)
   is_nullable: 0
   size: 30

@@ -64,7 +65,7 @@ __PACKAGE__->table("social_data");

 __PACKAGE__->add_columns(
   "isbn",
-  { data_type => "varchar", is_nullable => 0, size => 30 },
+  { data_type => "varchar", default_value => "", is_nullable => 0, size => 30
},
   "num_critics",
   { data_type => "integer", is_nullable => 1 },
   "num_critics_pro",
@@ -92,8 +93,8 @@ __PACKAGE__->add_columns(
 __PACKAGE__->set_primary_key("isbn");


-# Created by DBIx::Class::Schema::Loader v0.07046 @ 2018-11-13 15:24:28
-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:l44tYFEfIKX0xXzj6AHInQ
+# Created by DBIx::Class::Schema::Loader v0.07042 @ 2019-01-09 05:01:13
+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:JQqbbM1Yf7tRSgkcyinHIw

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 17:39:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 16:39:12 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-2hhfbEhCji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #30 from Owen Leonard <oleonard at myacpl.org> ---
Sorry Jonathan I missed that you had added a follow-up to this. I've submitted
an alternative which uses preventDefault. I don't think it makes sense to use
the other solution just to make the link target wider. While a wider click
target might be easier in some cases, I think it's usually better to make the
click target match the controls so that clicking in "empty space" doesn't give
unexpected results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:31:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:31:06 +0000
Subject: [Koha-bugs] [Bug 22097] New: CatalogingLog should be suppressed for
 item branch transfers
Message-ID: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

            Bug ID: 22097
           Summary: CatalogingLog should be suppressed for item branch
                    transfers
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Bug 18816 missed the fact that a branch transfer triggers ModItem and thus
generates an action log line. We should not be creating those action logs,
especially considering the transfers table itself already documents the
transfer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:31:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:31:11 +0000
Subject: [Koha-bugs] [Bug 22097] CatalogingLog should be suppressed for item
 branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-YIfLwT7jKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:33:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:33:24 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-8314TYRxhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CatalogingLog should be     |CataloguingLog should be
                   |suppressed for item branch  |suppressed for item branch
                   |transfers                   |transfers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:35:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:35:36 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-0dEbCTFmdL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:35:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:35:39 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-F6P3lS6dTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83773&action=edit
Bug 22097: CataloguingLog should be suppressed for item branch transfers

Bug 18816 missed the fact that a branch transfer triggers ModItem and thus
generates an action log line. We should not be creating those action logs,
especially considering the transfers table itself already documents the
transfer.

Test Plan:
1) Enable CataloguingLog
2) Transfer an item to another branch
3) Note the new action log line created
4) Apply this patch
5) Create another item transfer
6) No new action log line should be created!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:57:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:57:06 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-7ILBas9dxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83773|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83774&action=edit
Bug 22097: CataloguingLog should be suppressed for item branch transfers

Bug 18816 missed the fact that a branch transfer triggers ModItem and
thus generates an action log line. We should not be creating those
action logs, especially considering the transfers table itself already
documents the transfer.

Test Plan:
1) Enable CataloguingLog
2) Transfer an item to another branch
3) Note the new action log line created
4) Apply this patch
5) Create another item transfer
6) No new action log line should be created!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 20:57:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 19:57:04 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-VxHGdUf6BJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 21:43:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 20:43:10 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-FcZnZ8q8Yx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83775&action=edit
Bug 17353: (follow-up) Adjust config variable for moremember.tt too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 10 22:24:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Jan 2019 21:24:02 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-v79LKIZswV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 18.05 for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 03:55:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 02:55:46 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-97sQNEvvN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #9)
> Zebra support is in freeze mode. 

That's good to hear. I've been wondering how long we'd try to support both. I
look forward to a time where we're just focusing on one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 07:58:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 06:58:34 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-MjlsPHGeMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 08:01:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 07:01:42 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-Yb4DroaUEO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 08:11:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 07:11:48 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-tBvQ8FOWCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As far as I know there has been no official decision on Zebra. There are still
Zebra bugs being worked on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 08:51:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 07:51:58 +0000
Subject: [Koha-bugs] [Bug 21124] Non-Public note does not appear if added to
 item in MARC field
In-Reply-To: <bug-21124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21124-70-tREVVmxJ4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21124

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #8 from Hugo Agud <hagud at orex.es> ---
Hi

I have seen this issue right now... as far I have been able to check

At MySQL we have two fields 

mysql itemnotes_nonpubl
mysql more_subfields_xml


when you add non public notes via 'edit items' the content is saved on
more_subfields_xml
when you add non public notes via items tab at biblio record, the content is
saved on itemnotes_nonpubl

the detail view of record shows the content of itemonotes_nonpubl and the table
inside edit items show mysql_more_subfields_xml

then we have duplicate store fields for non_public_notes , and depending what
you have filled you can see in one place or another

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 10:12:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 09:12:34 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-ctGgYhCIpt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 10:24:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 09:24:39 +0000
Subject: [Koha-bugs] [Bug 22098] New: Update stocknumberAV cataloguing plugin
Message-ID: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

            Bug ID: 22098
           Summary: Update stocknumberAV cataloguing plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

This plugin could be updated to use Koha::Object instead of SQL queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 10:33:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 09:33:36 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-eNrCL0rjxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 10:33:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 09:33:38 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-bQfTi1Y0pR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83776&action=edit
Bug 22098: Update stocknumberAV cataloguing plugin to use objects

This patch:
- changes SQL to Koha::AuthorisedValues
- remove type param from script tag
- fixes the plugin description

0) Do not apply the patch
1) Set the plugin
1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item
subfield
1.2) Add authorised values category called "INVENTORY"
1.3) Add some authorised values: authorised value is prefix and
description is a current stock/inventory number
2) Add an item and try to use this plugin to ensure you set it
correctly
2.1) Use a defined prefix to see if the number is correct
2.2) Ensure the number is correctly incremented in authorised values
2.3) Use not defined prefix to see the error message
2.4) Insert a not prefix string (eg number) to see it is not changed
3) Apply the patch
4) Repeat 2) and see it is working the same
5) Look into patch and confirm the description does make sense and is
rigth according to what you see in UI
6) Sign off :D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 10:33:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 09:33:53 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-yZrdFtJsFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 11:06:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 10:06:54 +0000
Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context,
	and more
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-thlWXGC3Xz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080
[Bug 22080] Easier translation of ElasticSearch mappings page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 11:06:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 10:06:54 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-7yOj64sW5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15395


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
[Bug 15395] Internationalization: plural forms, context, and more
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 11:07:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 10:07:35 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-zej8QZH8a1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83705|0                           |1
        is obsolete|                            |

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Comment on attachment 83705
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83705
Bug 22080 - Easier translation of ElasticSearch mappings page

I'm creating a new patch with new translate system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 11:23:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 10:23:55 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-uZ8NoUpdrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:30:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:30:20 +0000
Subject: [Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap
 grid: Patrons part 2
In-Reply-To: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21964-70-YnasjZjhlB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:39:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:39:56 +0000
Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when
	listing requests
In-Reply-To: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22099-70-GNysHh7uTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:39:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:39:33 +0000
Subject: [Koha-bugs] [Bug 22099] New: "List requests" button displays when
 listing requests
Message-ID: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099

            Bug ID: 22099
           Summary: "List requests" button displays when listing requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
  Target Milestone: ---

On the main ILL Requests page that lists all requests ("illlist" action), the
"List request" button is displayed, which makes no sense since we're already
listing requests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:42:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:42:26 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-4Psw2TpnyQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81826|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83777&action=edit
Bug 20640: Add backend migration support to ILL

- Add core methods required to support the migration of ILL requests
between backends.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:42:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:42:30 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-BcSipAT14o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81827|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83778&action=edit
Bug 20640: (follow-up) Degrade gracefully on error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:42:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:42:33 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-PRvHUb9aYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83779&action=edit
Bug 20640: (follow-up) Redirect to new request at completion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:59:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:59:26 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-naxgQiC9hX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82660|0                           |1
        is obsolete|                            |

--- Comment #74 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83780&action=edit
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
     using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
     verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
     option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
     added to the item tags as appropriate. It should show some
     combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
     "Withdrawn", "In Transit", or "On Hold" as appropriate, or
     "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
     "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
     "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
     descriptions are used instead of the default values above.

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 13:59:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 12:59:53 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-OCnJ0Ptx3u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83780|0                           |1
        is obsolete|                            |

--- Comment #75 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83781&action=edit
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
     using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
     verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
     option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
     added to the item tags as appropriate. It should show some
     combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
     "Withdrawn", "In Transit", or "On Hold" as appropriate, or
     "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
     "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
     "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
     descriptions are used instead of the default values above.

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:01 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-bc8PinWdtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82661|0                           |1
        is obsolete|                            |

--- Comment #76 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83782&action=edit
Bug 13937: (follow-up) Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this sub is built into fetch and this call is a duplicate

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:10 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-J2QpvzDWgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82662|0                           |1
        is obsolete|                            |

--- Comment #77 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83783&action=edit
Bug 13937: (follow-up) Correct error call to use self

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:18 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-8UwVQw7Ti3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82663|0                           |1
        is obsolete|                            |

--- Comment #78 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83784&action=edit
Bug 13937: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:26 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-g5KSqkBY2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82664|0                           |1
        is obsolete|                            |

--- Comment #79 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83785&action=edit
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:32 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-pOuU8y3Ipz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82665|0                           |1
        is obsolete|                            |

--- Comment #80 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83786&action=edit
Bug 13937: Fix issues found in QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:38 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-kkdlUDRRNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82666|0                           |1
        is obsolete|                            |

--- Comment #81 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83787&action=edit
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:44 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-4Pj58ox3Mi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82667|0                           |1
        is obsolete|                            |

--- Comment #82 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83788&action=edit
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:00:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:00:50 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-6zLQzqRcKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #83 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83789&action=edit
Bug 13937: Add support for Z39.50 responder to the Debian scripts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:02:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:02:32 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-Za8qmezwES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #84 from Ere Maijala <ere.maijala at helsinki.fi> ---
Rebased and added support for managing the Z39.50 responder in the Debian init
scripts. Not included in koha-create by default, but I reworded the current
options in it to indicate that they apply to Zebra's Z39.50/SRU server only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:08:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:08:57 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-TdkczcZITM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #85 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> ---
(In reply to Ere Maijala from comment #84)
> Rebased and added support for managing the Z39.50 responder in the Debian
> init scripts.

What did you rebase? The previous patches applied for me just fine with the
current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:25:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:25:35 +0000
Subject: [Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap
 grid: Patrons part 2
In-Reply-To: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21964-70-7UQjVdc5Dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:25:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:25:38 +0000
Subject: [Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap
 grid: Patrons part 2
In-Reply-To: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21964-70-2Nfed74wT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83316|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83790&action=edit
Bug 21964: Update two-column templates with Bootstrap grid: Patrons part 2

This patch modifies several patron templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Patrons home page
   - New patron
 - Patron -> Fines -> Create manual invoice
 - Patron -> Set permissions
 - Patron -> Change password
 - Patron -> Edit

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:26:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:26:39 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-hPNbJXNbh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #86 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Joonas Kylm?l? from comment #85)
> (In reply to Ere Maijala from comment #84)
> > Rebased and added support for managing the Z39.50 responder in the Debian
> > init scripts.
> 
> What did you rebase? The previous patches applied for me just fine with the
> current master.

Nothing, actually. Sorry about that. Just verified that the patches still apply
cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:31:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:31:31 +0000
Subject: [Koha-bugs] [Bug 19458] Self-check module highlighting
In-Reply-To: <bug-19458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19458-70-d97tfdzewm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:31:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:31:42 +0000
Subject: [Koha-bugs] [Bug 21442] Switch two-column templates to Bootstrap
 grid: Circulation part 1
In-Reply-To: <bug-21442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21442-70-6NkFGKLwQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:31:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:31:54 +0000
Subject: [Koha-bugs] [Bug 21569] Switch two-column templates to Bootstrap
 grid: Circulation part 3
In-Reply-To: <bug-21569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21569-70-ymW5SItwtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21569

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:32:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:32:07 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
In-Reply-To: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21727-70-SSFTYqqww9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:33:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:33:05 +0000
Subject: [Koha-bugs] [Bug 21785] Add column configuration to hold ratios
	report
In-Reply-To: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21785-70-ox9fE6zHge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:33:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:33:31 +0000
Subject: [Koha-bugs] [Bug 21797] Update two-column templates with Bootstrap
 grid: Acquisitions part 5
In-Reply-To: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21797-70-ACkSHEmPbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21797

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:33:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:33:43 +0000
Subject: [Koha-bugs] [Bug 21803] Redesign authorized values interface
In-Reply-To: <bug-21803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21803-70-5Xufk9Tpd0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21803

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:34:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:34:00 +0000
Subject: [Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
In-Reply-To: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21912-70-9HhAyCLaW1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:34:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:34:12 +0000
Subject: [Koha-bugs] [Bug 21963] Switch two-column templates to Bootstrap
 grid: Patrons part 1
In-Reply-To: <bug-21963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21963-70-9exASKrBJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21963

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:34:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:34:32 +0000
Subject: [Koha-bugs] [Bug 21999] C4::Circulation::AddIssue uses DBIx::Class
	directly
In-Reply-To: <bug-21999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21999-70-GqmaNwostQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:34:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:34:49 +0000
Subject: [Koha-bugs] [Bug 22003] Remove unused subroutines displaylog and
 GetLogStatus from in C4::Log
In-Reply-To: <bug-22003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22003-70-iLYO3YMK7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22003

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:34:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:34:39 +0000
Subject: [Koha-bugs] [Bug 22100] New: REST API: Add endpoint /subscriptions
	LIST
Message-ID: <bug-22100-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22100

            Bug ID: 22100
           Summary: REST API: Add endpoint /subscriptions LIST
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:39:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:39:08 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-Q9GSl9XQtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:39:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:39:11 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-pkJcEHbYLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 83791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83791&action=edit
Bug 22080: [DO NOT PUSH] test code

This code is not generate all messages to template :
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:39:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:39:25 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-Hu3VlVflaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 83792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83792&action=edit
Bug 22080: Easier translation of ElasticSearch mappings page

Actual translation of ElasticSearch mappings page contains a huge block with a
lot of %s.
It makes translation hard.

This patch uses new method from Bug 15395 to split into several translation
blocks.

Test plan :
1) Apply patch "Bug 22080: [DO NOT PUSH] test code"
2) Apply this patch
3) Enable ElasticSearch in SearchEngine preference
4) Go to Administration > Search engine configuration
5) Check page is OK
6) Update the PO files of a language : perl translate update xx-YY
7) Write translation strings in misc/translator/po/xx-YY-messages.po
8) Install translation : perl translate install xx-YY
9) Check translated page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:48:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:48:33 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-TI4MxoopTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #5)
> Created attachment 83791 [details] [review]
> Bug 22080: [DO NOT PUSH] test code
> 
> This code is not generate all messages to template :
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/
> mappings.tt

To make the strings easy to see in template, I've added this code to the perl
page.
Of course, don't sign it nor push it ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 14:49:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 13:49:11 +0000
Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch
	mappings page
In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22080-70-5ovnTTEadc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fr?d?ric Demians from comment #2)
> Isn't it a good place to use new translation mechanism introduced by bug
> #15395 (thanks Julian)? A sample usage is available on bug #21789.

This mechanism is great, thanks a lot Julian and Fr?d?ric :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:09:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:09:33 +0000
Subject: [Koha-bugs] [Bug 21913] Clean up payment details page
In-Reply-To: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21913-70-1vo4241n0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82757|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83793&action=edit
Bug 21913: Clean up payment details page

This patch makes various corrections and improvements to the payment
details page:

 - Grid converted to Bootstrap
 - Correct title tag
 - Add patron toolbar
 - Adding missing patron-related JavaScript
 - Improve some language

To test, apply the patch and locate a patron who has one or more
payments on their account.

 - Open Fines -> Account -> Details of a transaction
 - Confirm that the page looks correct and adjusts well at various
   browser widths.
 - Confirm that patron toolbar items work correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:10:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:10:50 +0000
Subject: [Koha-bugs] [Bug 21913] Clean up payment details page
In-Reply-To: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21913-70-PIyZdSFhWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Devinim from comment #2)
> > ?f there isn't any payment, payment section appears. Other functionalities
> > are working as described.
> 
> Failing QA for that as it is advertised in the commit message.

I removed those changes. There wasn't a straightforward way to accomplish it
with template changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:26:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:26:38 +0000
Subject: [Koha-bugs] [Bug 21796] Patron Restriction do not restrict
 checkouts if patron also has a fee/fine on their account
In-Reply-To: <bug-21796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21796-70-44RAUTnzbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796

Andrew <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #12 from Andrew <andrew at bywatersolutions.com> ---
This is sort of moot, since this is already resolved, but it looks like this
bug isn't/wasn't actually allowing checkout. Koha gives you a checkout box, but
when you actually try to check something out it blocks it, tells you the patron
has a restriction, and doesn't give an override option.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:29:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:29:14 +0000
Subject: [Koha-bugs] [Bug 21907] Error from mainpage when Article requests
 enabled and either IndependentBranches or
 IndependentBranchesPatronModifications is enabled
In-Reply-To: <bug-21907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21907-70-z57cgpQqYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:29:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:29:17 +0000
Subject: [Koha-bugs] [Bug 21907] Error from mainpage when Article requests
 enabled and either IndependentBranches or
 IndependentBranchesPatronModifications is enabled
In-Reply-To: <bug-21907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21907-70-CHJT4vTuyw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83037|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83794&action=edit
Bug 21907: Fix article requests count for non-superlibrarians

The query generates "Column 'branchcode' in where clause is ambiguous"

Test plan:
1 - Enable 'IndependentBranchesPatronModifications' and article requests
2 - Sign in as non-superlibrarian
3 - View plack log
4 - Refresh mainpage, see error in logs

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:34:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:34:02 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ugRHl1l12U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #379 from Kyle M Hall <kyle at bywatersolutions.com> ---
Alex, could you rebase this patch set again? I'd like to QA it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:38:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:38:23 +0000
Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter
 subfields to item search fields
In-Reply-To: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20689-70-sNf9dvLxpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:38:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:38:26 +0000
Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter
 subfields to item search fields
In-Reply-To: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20689-70-eQ6aph18E5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81150|0                           |1
        is obsolete|                            |
  Attachment #81151|0                           |1
        is obsolete|                            |

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83795&action=edit
Bug 20689: Replace marc (sub)field pull downs with input fields on item search
fields config

The pull down for marc subfields on the item search fields config page is
long and hard to use. It also doesn't include the commonly used
upper case letters for custom item subfields.

Also hard to use with its 999 entries is the marc field list. It doesn't
allow for tags like 01e, which exist in our MARC21 default framework.

To test:
- Go to Administration > Item search fields
- Add different mappings with and without subfields
- Verify the entered values are stored correctly
- Edit mappings
- Verify editing works and changes save correctly

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:38:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:38:29 +0000
Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter
 subfields to item search fields
In-Reply-To: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20689-70-lsXIWG5hoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

--- Comment #26 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83796&action=edit
Bug 20689: (follow-up) Make it possible to add capital letter subfields to item
search fields

This patch adds some custom validation to the MARC tag and subfield
fields so that they are limited to alphanumeric characters.

Both templates (the main view and the edit view) have been modified so
that item_search_fields.js can be included in both.

To test, apply the patch and test the form by entering a variety of
different character combinations. The "MARC field" and "MARC subfield"
inputs should only accept alphanumeric entries.

Test both "new" and "edit" operations.
Test other operations like delete and cancel.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:51:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:51:54 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-CKmcJp7Sya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83797&action=edit
Bug 20640: (follow-up) Make error message translatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:56:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:56:16 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-2sunVwhtXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:56:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:56:20 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-DM1LLypzEL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83777|0                           |1
        is obsolete|                            |

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83798&action=edit
Bug 20640: Add backend migration support to ILL

- Add core methods required to support the migration of ILL requests
between backends.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:56:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:56:23 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-0SOPdSlY8g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83778|0                           |1
        is obsolete|                            |

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83799&action=edit
Bug 20640: (follow-up) Degrade gracefully on error

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:56:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:56:27 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-bhLRBTtKOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83779|0                           |1
        is obsolete|                            |

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83800&action=edit
Bug 20640: (follow-up) Redirect to new request at completion

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 15:56:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 14:56:31 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-to2WDjVdiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83797|0                           |1
        is obsolete|                            |

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83801&action=edit
Bug 20640: (follow-up) Make error message translatable

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:01:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:01:16 +0000
Subject: [Koha-bugs] [Bug 22101] New: Ill Requests missing in menu on
 advanced search page
Message-ID: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

            Bug ID: 22101
           Summary: Ill Requests missing in menu on advanced search page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
  Target Milestone: ---

A picture speaks a thousand words.

On the 'advanced search' page on the staff client.. the 'Ill requests' option
is missing from the 'More' dropdown menu in the header menu bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:01:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:01:47 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-bdx1tbpTUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:02:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:02:47 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-bXaVeOgk48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Found another issue - setting to FQA waiting for news from Martin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:02:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:02:42 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-TBCld4X0uY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:13:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:13:56 +0000
Subject: [Koha-bugs] [Bug 22102] New: Markup fixes for OPAC article request
	page
Message-ID: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

            Bug ID: 22102
           Summary: Markup fixes for OPAC article request page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

There are a couple of fixes I'd like to make to the OPAC article request page:

- Improve the breadcrumbs menu by adding a link to the title
- Add a header with the record's title
- Wrap the "no article requests" message in the correct dialog div

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:24:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:24:56 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-xN1M8AwuJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:24:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:24:59 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-743mkcxgj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83802&action=edit
Bug 22102: Markup fixes for OPAC article request page

This patch makes a few improvements to the OPAC article request page:

- Improve the breadcrumbs menu by adding a link to the title
- Add a header with the record's title
- Wrap the "no article requests" message in the correct dialog div
- Remove obsolete CDATA marker

To test, apply the patch and log in to the OPAC

 - Peform a search which will return multiple results
 - Click "Request article" on a title for which article requests can be
   submitted.
   - Confirm that the breadcrumbs menu looks and works correctly.
 - Click "Request article" on a title for which article requsts are not
   allowed.
   - Confirm that the message is correctly styled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:30:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:30:53 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-DEFjybmDOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83801|0                           |1
        is obsolete|                            |

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83803&action=edit
Bug 20640: (follow-up) Make error message translatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:36:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:36:53 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-HmA7lgamSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 16:37:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 15:37:32 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-hu1IYdIQt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Should be ready again for testing now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:09:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:09:11 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-No312xt1Ad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:09:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:09:17 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-UOXfVUbqF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #79 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83804&action=edit
Bug 11373: (follow-up) Add "change calculation" feature to the fine payment
forms

This patch provides some follow-ups, including corrections to the
JavaScript and updates to the text for readability.

- Remove obsolete script "type" attribute
- Update the use of the obsolete jQuery method "bind"
- Use Bootstrap's built-in "show" option instead of simulated click
- Handle preventDoubleFormSubmit function's "waiting" class if modal is
  closed manually

To test, apply the patch and follow the original test plan. Everything
should work as expected.

Note that when the modal is shown, the cursor changes to the "waiting"
one when you hover over the body of the page. If you click "No" in the
modal, the cursor should return to normal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:13:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:13:15 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-ccrN4F1T7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83805&action=edit
Bug 20640: (follow-up) Always send a backend on migrate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:19:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:19:09 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-Tyg9YqWrSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:19:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:19:13 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-0YlLEgFH9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83798|0                           |1
        is obsolete|                            |

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83806&action=edit
Bug 20640: Add backend migration support to ILL

- Add core methods required to support the migration of ILL requests
between backends.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:19:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:19:17 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-uC7X0aKwsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83799|0                           |1
        is obsolete|                            |

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83807&action=edit
Bug 20640: (follow-up) Degrade gracefully on error

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:19:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:19:21 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-Td6NqVowLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83800|0                           |1
        is obsolete|                            |

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83808&action=edit
Bug 20640: (follow-up) Redirect to new request at completion

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:19:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:19:29 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-UhqGUHEtcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83805|0                           |1
        is obsolete|                            |

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83810&action=edit
Bug 20640: (follow-up) Always send a backend on migrate

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:19:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:19:25 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-EhX5w9YKru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83803|0                           |1
        is obsolete|                            |

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83809&action=edit
Bug 20640: (follow-up) Make error message translatable

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:21:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:21:28 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-NzvJsR6w8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:24:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:24:39 +0000
Subject: [Koha-bugs] [Bug 22103] New: ILL: Tests for migrate
Message-ID: <bug-22103-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22103

            Bug ID: 22103
           Summary: ILL: Tests for migrate
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
  Target Milestone: ---

We decided to PQA on bug 20640 so that QA could continue on the ILL tree.. but,
I spotted right at the last moment that I've managed to miss the tests
somehow.. I'll be submitting them here shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:24:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:24:52 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-yAAiICZPe4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:24:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:24:55 +0000
Subject: [Koha-bugs] [Bug 22103] ILL: Tests for migrate
In-Reply-To: <bug-22103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22103-70-FgCyUuLFDQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22103

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20640


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640
[Bug 20640] Allow migrating a request between backends
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:24:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:24:55 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-xyYh7zvmXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22103


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22103
[Bug 22103] ILL: Tests for migrate
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:34:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:34:35 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-JWZKmN1UNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #83 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andrew,

here some first findings:

1) Unit tests failing:

t/db_dependent/api/v1/illrequests.t .. 
    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/illrequests.t line 108.
    #     Structures begin differing at:
    #          $got->[0]{id_prefix} = ''
    #     $expected->[0]{id_prefix} = Does not exist

    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/illrequests.t line 143.
    #     Structures begin differing at:
    #          $got->[0]{id_prefix} = ''
    #     $expected->[0]{id_prefix} = Does not exist
    # Looks like you failed 2 tests of 18.
t/db_dependent/api/v1/illrequests.t .. 1/1 
#   Failed test 'list() tests'
#   at t/db_dependent/api/v1/illrequests.t line 155.
# Looks like you failed 1 test of 1.

2) QA tool complaining:


 FAIL   Koha/REST/V1/Illrequests.pm
   FAIL   critic
                # Variables::ProhibitUnusedVariables: Got 1 violation(s).  

I am having some issues with my yarn... so couldn't test further yet. Can you
please have a look at the above?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:34:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:34:35 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-9fVcvTTBZ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:34:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:34:38 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-M6IxkSuIZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83811&action=edit
Bug 22101: Ill Requests missing in menu on advanced search page

This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.

To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.

- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
  "ILL requests."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 17:58:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 16:58:26 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-kTnUSL1t1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

Andrew <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #7 from Andrew <andrew at bywatersolutions.com> ---
Hi Cab! Are you sure the record used in your example search didn't also have
that data in some field that *is* indexed as publisher? I just tested this on a
library migrating to 18.05.05 and records that have publisher data only in the
264 don't come up in a publisher search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:05:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:05:26 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-mVMnlIanjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83804|0                           |1
        is obsolete|                            |

--- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83813&action=edit
Bug 11373: (follow-up) Add "change calculation" feature to the fine payment
forms

This patch provides some follow-ups, including corrections to the
JavaScript and updates to the text for readability.

- Remove obsolete script "type" attribute
- Update the use of the obsolete jQuery method "bind"
- Use Bootstrap's built-in "show" option instead of simulated click
- Handle preventDoubleFormSubmit function's "waiting" class if modal is
  closed manually

To test, apply the patch and follow the original test plan. Everything
should work as expected.

Note that when the modal is shown, the cursor changes to the "waiting"
one when you hover over the body of the page. If you click "No" in the
modal, the cursor should return to normal.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:05:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:05:20 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-wPDF0PewPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82797|0                           |1
        is obsolete|                            |

--- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83812&action=edit
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

This patch adds a feature in the fine payment section. It allows to see the
change due to patrons when the amount collected is higher than the amount paid.

Test plan :
- Apply patch.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$).
- Confirm that the change is correct (example : 5$ - 3$ = 2$).
- Click the button confirm.
- Click on Yes in the dialog box.
- Confirm that the payment has been made (example : last amount = 3$).

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:05:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:05:57 +0000
Subject: [Koha-bugs] [Bug 22104] New: Clean up patron API keys template
Message-ID: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

            Bug ID: 22104
           Summary: Clean up patron API keys template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/members/apikeys.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 20654
  Target Milestone: ---

The patron API keys template has a couple of issues to be corrected:

- Bootstrap grid
- Fix class on "new key" button


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
[Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:05:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:05:57 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-rBro9qPkG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22104


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104
[Bug 22104] Clean up patron API keys template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:06:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:06:24 +0000
Subject: [Koha-bugs] [Bug 22027] Upload cover image
In-Reply-To: <bug-22027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22027-70-tCmiwGJMZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22027

--- Comment #8 from Federico Paiz <federicoantoniopaiz at gmail.com> ---

the tmp would already be but the error persists

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:06:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:06:37 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-dV7tctV17O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works well for me, signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:06:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:06:57 +0000
Subject: [Koha-bugs] [Bug 22105] New: opac-detail hides place hold link when
 items list hidden
Message-ID: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22105

            Bug ID: 22105
           Summary: opac-detail hides place hold link when items list
                    hidden
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Created attachment 83814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83814&action=edit
Place hold link missing

If the item list is too large when opening the opac-detail.pl page, the list is
hidden, with a link to view.  But while the list is hidden, the Place hold link
is hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:06:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:06:58 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-LK4AZAgVfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11373


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373
[Bug 11373] Add "change calculation" feature to the fine payment forms
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:06:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:06:58 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-XriO18ulK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:07:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:07:27 +0000
Subject: [Koha-bugs] [Bug 22105] opac-detail hides place hold link when
	items list hidden
In-Reply-To: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22105-70-LWaWtk6rCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22105

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:10:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:10:29 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-OCQiVWktcZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:10:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:10:32 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-lkh6TmbX59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83815&action=edit
Bug 22104: Clean up patron API keys template

This patch makes two corrections to the patron API key template: Convert
to Bootstrap grid and correct class on "new key" button.

To test, apply the patch and enable the RESTOAuth2ClientCredentials
preference.

 - Open a patron record in the staff client and choose More -> Manage
   API keys.
 - On the API keys page, confirm that the page adjusts well at various
   page widths.
 - Confirm that the size of the "Generate new client id/key pair" button
   matches the buttons in the toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 18:28:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 17:28:20 +0000
Subject: [Koha-bugs] [Bug 22106] New: Column settings needs to include OPAC
 and Intranet holds (requests) tables
Message-ID: <bug-22106-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22106

            Bug ID: 22106
           Summary: Column settings needs to include OPAC and Intranet
                    holds (requests) tables
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

The hold request tables need to be included in the Column settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:06:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:06:41 +0000
Subject: [Koha-bugs] [Bug 22105] opac-detail hides place hold link when
	items list hidden
In-Reply-To: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22105-70-5JEKAOqkxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22105

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
OPAC detail page doesn't know that the "place hold" link can be shown unless it
has parsed all the items on the record. In the "too many items" case, the items
are not parsed.


Assuming we're not parsing all the items on the record in order to gain some
speed, I don't know how to solve that other than to always show the hold link
when there are too many items and risk that the hold can't be placed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:10:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:10:49 +0000
Subject: [Koha-bugs] [Bug 22107] New: Avoid deleting data in some tests
Message-ID: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

            Bug ID: 22107
           Summary: Avoid deleting data in some tests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The following tests rely on deleting all patrons for running, and this is
failing (and doesn't make sense):

t/db_dependent/api/v1/patrons.t
t/db_dependent/Koha/REST/Plugin/Objects.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:12:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:12:36 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-wN4HtwxNYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|chris at bigballofwax.co.nz    |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:12:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:12:44 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-Gf26XovGUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:16:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:16:51 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-sZC6cTs8nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83816&action=edit
Bug 22107: Make tests use a simpler class, with no FK

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:16:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:16:54 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-RW6PQsCPoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83817&action=edit
Bug 22107: patrons.t doesn't need to delete existing data

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:19:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:19:18 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
In-Reply-To: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21727-70-tOQBUS7wXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727

--- Comment #31 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83818&action=edit
Bug 21727: (QA follow-up) Fix POD encoding

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:34:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:34:25 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-5xeeBRs2tF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:34:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:34:31 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-vEvmw3m98E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:50:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:50:22 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-0bQ96WDmAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:50:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:50:24 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-d5XL0r0fpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83816|0                           |1
        is obsolete|                            |
  Attachment #83817|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83819&action=edit
Bug 22107: Make tests use a simpler class, with no FK

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:50:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:50:27 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-lkhOg1iNAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83820&action=edit
Bug 22107: patrons.t doesn't need to delete existing data

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:51:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:51:52 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-dWDpimpI1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Thanks Tomas, pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 19:52:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 18:52:24 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
In-Reply-To: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21727-70-HvHLrN5MNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727

--- Comment #32 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Tom?s Cohen Arazi from comment #31)
> Created attachment 83818 [details] [review]
> Bug 21727: (QA follow-up) Fix POD encoding

Follow-up pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:00:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:00:33 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-dTXedDTHLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:00:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:00:35 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-rFzvBT8Zxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83811|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 83821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83821&action=edit
Bug 22101: Ill Requests missing in menu on advanced search page

This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.

To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.

- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
  "ILL requests."

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:04:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:04:49 +0000
Subject: [Koha-bugs] [Bug 22105] opac-detail hides place hold link when
	items list hidden
In-Reply-To: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22105-70-r0qWikwqHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22105

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I don't think it would be a huge loss to have the link always show.  Patrons
will figure it out on the next page.  It's the lesser of two evils in this
case.  Let the patron find out on the next page rather than confuse the patron
as to why they can't find the hold link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:17:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:17:27 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-9p2IPeE0Cp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:17:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:17:38 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-98IMrMahT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:20:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:20:19 +0000
Subject: [Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron
	entry page
In-Reply-To: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21813-70-PQrWXtBSam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #12 from Jesse Maseto <jesse at bywatersolutions.com> ---
Merge conflicts with 18.05.x. Please rebase for 18.05.x if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:23:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:23:38 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
	templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-BJi5nhQB5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

--- Comment #12 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
I noticed there is no longer an onclick attribute for "Add new field" and
"Delete field" for enrollment fields, but it's still there for club fields when
I edit a club template. I put the QA Failed status because the patch doesn't
seem to be complete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:28:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:28:23 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-qmAqorjzCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

--- Comment #3 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
The radio buttons look wonky to me. Some labels are to the button's left, while
others are on top of it. https://imgur.com/eAkhNYo

The dropdowns work fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:33:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:33:11 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-S8Au5K0poj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |charles.farmer at inlibro.com

--- Comment #16 from Charles Farmer <charles.farmer at inlibro.com> ---
Seems to unfortunately not apply anymore because of additional '| html' filters
in the most recent templates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:44:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:44:06 +0000
Subject: [Koha-bugs] [Bug 22019] Amount to collect on paycollect.pl doesn't
 reflect credits
In-Reply-To: <bug-22019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22019-70-MLH2xDwmBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22019

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:44:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:44:26 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-nrZr538mfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76577|0                           |1
        is obsolete|                            |

--- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83822&action=edit
Bug 10562: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl

This patch takes the suggestions in Bug 10562 and implements those
changes in MARC21slim2OPACResults.xsl. This patch also makes the
following changes:

 - De-duplicate famfamfam icons: Remove the /silk subdirectory and move
   non-duplicates to famfamfam/; Correct paths to these images in
   templates and CSS
 - Improve the granularity of some material type icon choices: Show
   "Film," "Picture," or "Object" instead of "Visual material."
 - Remove unnecessary title attributes from material type images
 - Implement the kind of changes made in Bug 18235, "Add classes to
   material type icons on result lists and detail pages"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:44:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:44:57 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-bYkOASZvKJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #3 from Charles Farmer <charles.farmer at inlibro.com> ---
Patch wouldn't apply anymore, made a small rebase

Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:51:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:51:21 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-X00NZIZowk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83822|0                           |1
        is obsolete|                            |

--- Comment #4 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83823&action=edit
Bug 10562: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl

This patch takes the suggestions in Bug 10562 and implements those
changes in MARC21slim2OPACResults.xsl. This patch also makes the
following changes:

 - De-duplicate famfamfam icons: Remove the /silk subdirectory and move
   non-duplicates to famfamfam/; Correct paths to these images in
   templates and CSS
 - Improve the granularity of some material type icon choices: Show
   "Film," "Picture," or "Object" instead of "Visual material."
 - Remove unnecessary title attributes from material type images
 - Implement the kind of changes made in Bug 18235, "Add classes to
   material type icons on result lists and detail pages"

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 20:54:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 19:54:28 +0000
Subject: [Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt
 and newemptyorder.tt
In-Reply-To: <bug-21098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21098-70-FzkCy0WJNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82878|0                           |1
        is obsolete|                            |

--- Comment #9 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83824&action=edit
Bug 21098: Add missing budget optgroups to parcels.tt and newemptyorder.tt

I noticed that orderreceive.tt organizes funds by budget, but neworderempty.tt
and parcels.tt do not. That is to say, when placing an order there is no
organisation of funds in the drop-down menu, but there is when you recive an
order,
but not when you receive a shipment (ie choose a Shipping fund).

This patch seeks to harmonize the user experience, so that users are always
seeing funds organised by budget.

_TEST PLAN_
1. Add two budgets
2. Add one fund to each budget
3. Add a vendor
4. Add a basket
5. Add an order
5b. Note that you can now see funds grouped by budget
6. Close the basket
7. Receive the shipment
7b. Note that you can now see funds groups by budget
8. Receive the order
8b. Note that the organisation of funds is the same as the
    other two areas (even though the patch doesn't touch this one).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jose-Mario <jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:03:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:03:48 +0000
Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export
In-Reply-To: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18143-70-6oCXCDLxWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60434|0                           |1
        is obsolete|                            |

--- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83825&action=edit
Bug 18143: Silence XML MARC Framework export flood

TEST PLAN
---------
1) Log in to staff client
2) Click Koha administration
3) Click MARC bibliographic framework
4) export default as xml
5) Read the error log
   -- it's floody and export is default framework
6) export another framework as xml
7) Read the error log
   -- it's floody and export is the correct framework
8) apply the patch
9) repeat steps 4-7
   -- expected frameworks exported, and no flooding.
10) run koha qa test tools

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:03:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:03:51 +0000
Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export
In-Reply-To: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18143-70-XYHuQ0xueh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60435|0                           |1
        is obsolete|                            |

--- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83826&action=edit
Bug 18143: Silence ods MARC framework export flood

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:04:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:04:15 +0000
Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export
In-Reply-To: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18143-70-Y98c0R9bKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:10:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:10:35 +0000
Subject: [Koha-bugs] [Bug 22108] New: Items generated through
 MARCItemFieldsToOrder do not receive values applied in Item Information and
 Default Accounting Details
Message-ID: <bug-22108-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22108

            Bug ID: 22108
           Summary: Items generated through MARCItemFieldsToOrder do not
                    receive values applied in Item Information and Default
                    Accounting Details
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When adding titles to a basket from a staged file (acqui/addorderiso2709.pl),
item and fund choices can be applied item-by-item on the Select To Import tab
or can be applied to all titles at once using the Item Information or Default
Accounting Details tabs.

However, if the library is using MARCItemFieldsToOrder to pull some of these
values from vendor-supplied MARC files, Koha will ignore selections made on the
Item Information or Default Accounting Details tabs. Nothing in the interface
indicates that values selected on those tabs will not be used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:18:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:18:50 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-OKGGPEWR8x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:18:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:18:55 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-SEErjnkAOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:18:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:18:40 +0000
Subject: [Koha-bugs] [Bug 22071] authenticate_api_request does not stash
 koha.user in the OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-lAUgxxhfOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #17 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:19:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:19:14 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-lrC5PWtjSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #13 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:19:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:19:24 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-cXMIs1VovD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #9 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:20:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:20:42 +0000
Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter
 subfields to item search fields
In-Reply-To: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20689-70-Z6lRFKuWeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83796|0                           |1
        is obsolete|                            |

--- Comment #27 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83827&action=edit
Bug 20689: (follow-up) Make it possible to add capital letter subfields to item
search fields

This patch adds some custom validation to the MARC tag and subfield
fields so that they are limited to alphanumeric characters.

Both templates (the main view and the edit view) have been modified so
that item_search_fields.js can be included in both.

To test, apply the patch and test the form by entering a variety of
different character combinations. The "MARC field" and "MARC subfield"
inputs should only accept alphanumeric entries.

Test both "new" and "edit" operations.
Test other operations like delete and cancel.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jose-Mario <jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:25:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:25:34 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-uoR1HCKznM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Failed to apply patch


Bug 22102 - Markup fixes for OPAC article request page

83802 - Bug 22102: Markup fixes for OPAC article request page

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22102: Markup fixes for OPAC article request page
fatal: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 22102: Markup fixes for OPAC article request page
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-22102-Markup-fixes-for-OPAC-article-request-pa-j8mImP.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:28:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:28:25 +0000
Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20022-70-ynOz4pPktF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maryse.simard at inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:33:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:33:34 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-W2UTFYU992@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maryse.simard at inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> ---
I can't apply the patch.

Applying: Bug 22045: Cataloging UX enhancement - Improve access to tabs
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss).
error: could not build fake ancestor
Patch failed at 0001 Bug 22045: Cataloging UX enhancement - Improve access to
tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:36:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:36:29 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
	to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-lMiBiwBZov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Maryse, this bug depends on bug 21751, it needs to be applied and tested
first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:39:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:39:50 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-Q7DswH93XF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|display patron age in       |Display patron age in
                   |useful places               |useful places
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 21:51:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 20:51:46 +0000
Subject: [Koha-bugs] [Bug 21913] Clean up payment details page
In-Reply-To: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21913-70-FA2laxnZhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83793|0                           |1
        is obsolete|                            |

--- Comment #7 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83828&action=edit
Bug 21913: Clean up payment details page

This patch makes various corrections and improvements to the payment
details page:

 - Grid converted to Bootstrap
 - Correct title tag
 - Add patron toolbar
 - Adding missing patron-related JavaScript
 - Improve some language

To test, apply the patch and locate a patron who has one or more
payments on their account.

 - Open Fines -> Account -> Details of a transaction
 - Confirm that the page looks correct and adjusts well at various
   browser widths.
 - Confirm that patron toolbar items work correctly

Signed-off-by: Jose-Mario <jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:13:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:13:05 +0000
Subject: [Koha-bugs] [Bug 22109] New: Koha to Marc Mapping Chart is not in
 english in the English version
Message-ID: <bug-22109-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22109

            Bug ID: 22109
           Summary: Koha to Marc Mapping Chart is not in english in the
                    English version
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Hi,
On this page in the 18.05 manual linking to the Koha to marc Mapping, the
column "Lib" is actually written in French.  

https://koha-community.org/manual/18.05/en/html/administration.html#koha-to-marc-mapping


Kelly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:34:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:34:09 +0000
Subject: [Koha-bugs] [Bug 16666] TagsExternalDictionary is a rather
 confusing preference name
In-Reply-To: <bug-16666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16666-70-qBh0BBEASS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16666

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Do you have a suggestion?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:34:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:34:21 +0000
Subject: [Koha-bugs] [Bug 16666] TagsExternalDictionary is a rather
 confusing preference name
In-Reply-To: <bug-16666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16666-70-WKsT6mNTgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16666

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
IspellPath?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:34:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:34:41 +0000
Subject: [Koha-bugs] [Bug 16666] TagsExternalDictionary is a rather
 confusing preference name
In-Reply-To: <bug-16666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16666-70-AP6K4wrcD7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16666

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
TagsDictionary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:48:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:48:03 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-sdqgFfnW5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76044|0                           |1
        is obsolete|                            |

--- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83829&action=edit
Bug 20937: Truncate items for print notices when user has an email

To test:
 1 - Set PrintNotciesMaxLines to 1
 2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
notice
 3 - Make sure the patron has an email
 4 - Make sure the notice you are sending is set to 'print' as the type
 5 - Run overdue_notices.pl without the 'nomail' option
 6 - Find the message and note all items have been added
 7 - Apply patch
 8 - Clear the message queue
 9 - Re-run overdue_notices.pl
10 - Confirm the message now has only 1 item.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:48:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:48:50 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-noqfgJzayy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #3 from Charles Farmer <charles.farmer at inlibro.com> ---
Test plan made it easy to reproduce, patch works has expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:51:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:51:37 +0000
Subject: [Koha-bugs] [Bug 20729] Update style of datepickers
In-Reply-To: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20729-70-bOY5Otvjdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83478|0                           |1
        is obsolete|                            |

--- Comment #11 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83830&action=edit
Bug 20729: Update style of datepickers

This patch updates the styling of form fields which are configured to
use the jQueryUI datepicker widget. Some CSS has been added, and the
default datepicker configuration has been changed.

To test, apply the patch, rebuild the staff client CSS file, and clear
your cache if necessary. Test pages which include a datepicker to
confirm that they look correct and work correctly. Some examples:

 - Circulation -> Check out -> Specify due date
 - Patrons -> Add patron -> Date of birth, registration date, expiry
   date fields
 - Serials -> Search subscriptions -> Search results page sidebar
 - Tools -> News -> Add news item

And confirm that this change hasn't adversely affected the calendar
tool:

 - Tools -> Calendar

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:51:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:51:51 +0000
Subject: [Koha-bugs] [Bug 22110] New: Editing adjustments doesn't work for
 Currencyformat != US
Message-ID: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

            Bug ID: 22110
           Summary: Editing adjustments doesn't work for Currencyformat !=
                    US
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19166
  Target Milestone: ---

When the CurrencyFormat is set to FR the amount of an adjustment will display
with decimal comma. Changing 1,00 to 1,10 will save as 1.00.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166
[Bug 19166] Add the ability to add adjustments to an invoice
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:51:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:51:51 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-yO1dOYjPio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22110


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110
[Bug 22110] Editing adjustments doesn't work for Currencyformat != US
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:57:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:57:39 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-KhCTvA9URG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #40 from Lucas Gass <lucas at bywatersolutions.com> ---
this is awesome. one small note: when I apply this patch and go to cataloging >
add record the #toolbar seems to loose its 'z-index' and displays underneath
everything else instead of on top.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:59:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:59:14 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-slygUIpDKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 22:59:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 21:59:18 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-XkcYb5Fh8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83831&action=edit
Bug 21427: Format prices on ordered/spent lists consistently

Some price information on the spent and ordered list already
used the $Price filter. With this patch all amounts should be
formatted according to the CurrencyFormat system preference.

1) Switch CurrencyFormat to FR
2) Make sure you have
  - Pending orders
  - An open invoice with shipment cost and
    adjustment with "encumber while open" checked
  - A received order
  - A closed invoice with shipment cost and
    adjustment
3) View the "oder" and "spent" lists clicking on the
   amounts in the budget and funds table on the acq
   start page
4) Verify all price information is formatted wit
   decimal comma
5) Switch CurrencyFormat to other settings and verify
   display changes accordingly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:00:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:00:13 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-FH9eOY8rTE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79485|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:01:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:01:40 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-4JFozhbNAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Brian from comment #9)
> what's the status of bug 21427?
> 
> Carnegie Stout Team

Hi Carnegie Stout, took me a bit to get back to this. New patch added, would be
easy to test with sandboxes (https://wiki.koha-community.org/wiki/Sandboxes) ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:03:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:03:57 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-kgmNeJDY0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14911


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
[Bug 14911] Serial Subscr. and Item search: Display additional 245 subfields in
search results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:03:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:03:57 +0000
Subject: [Koha-bugs] [Bug 14911] Serial Subscr. and Item search: Display
 additional 245 subfields in search results
In-Reply-To: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14911-70-mv6agbxDxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11529

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
bcnp would be easy to do with bug 11529.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:05:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:05:02 +0000
Subject: [Koha-bugs] [Bug 12940] Enter start and end date for course
In-Reply-To: <bug-12940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12940-70-rgHVKg4Bpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12940

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|enter start and end date    |Enter start and end date
                   |for course                  |for course

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:08:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:08:04 +0000
Subject: [Koha-bugs] [Bug 18408] Remainder of title (245$b) in Koha::Biblio
In-Reply-To: <bug-18408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18408-70-eL5hhiXZGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11529
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can we have more of a description and a test plan here?

Wondering how it would fit with bug 11529.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:08:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:08:04 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-BByTLeKGWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18408

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:09:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:09:20 +0000
Subject: [Koha-bugs] [Bug 18100] Pay amount,
 Pay selected and individual pay behaving differently
In-Reply-To: <bug-18100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18100-70-67DSAd2hDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It was fixed - tested in 17.11.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:13:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:13:28 +0000
Subject: [Koha-bugs] [Bug 6960] staffaccess permission requires borrowers
	permission
In-Reply-To: <bug-6960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6960-70-ve4xiyzH1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6960

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Moving it is not only a visual change, but will also change how this permission
is stored in the db as it will move from top to second level. 

Also:
- People now having full borrowers will have to be changed to have all
borrowers sub permissions but staffaccess.
- People now having staffaccess need to get the new sub permission. Also:
userflags has to be updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:35:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:35:11 +0000
Subject: [Koha-bugs] [Bug 22111] New: Correctly format fines when placing
 holds (maxoutstanding warning)
Message-ID: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

            Bug ID: 22111
           Summary: Correctly format fines when placing holds
                    (maxoutstanding warning)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

When a user has more fines than maxoutstanding holds are no longer possible.
The fine amount displayed should be formatted according to the CurrencyFormat
system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:47:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:47:24 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-Sr3NO0bqsP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83832&action=edit
Bug 22111: Format price on place holds place when maxoutstanding is reached

Displays amount outstanding correctly when holds are blocked
by maxoutstanding.

To test:
- Check maxoutstanding system preference value
- Add a fine to a patron account exceeding maxoutstanding
- Try to place a hold for this patron from staff
- Verify this message is shown:

     Patron has outstanding fines: 6.00

- Toggle CurrencyFormat system preference and verify display
  changes according to setting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:47:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:47:42 +0000
Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription
	edit menu
In-Reply-To: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16231-70-i0xc4BZIi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82336|0                           |1
        is obsolete|                            |

--- Comment #16 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83833&action=edit
Bug 16231: Correct permission handling in subscription edit

This patch corrects the way subscription edit menu items are displayed
according to the user's permissions settings.

To test, apply the patch and log in to the staff client as a user who
has permission to create, edit, and delete subscriptions.

- Locate an subscription and view the details for it.
- Confirm that each "Edit" menu item works correctly.
- Repeat the process when logged in as a user with varying combinations
  of create, edit, and delete permissions.
- Test as a user limited by IndependentBranches.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:47:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:47:21 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-ykKldOxhz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 11 23:56:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Jan 2019 22:56:19 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-6AMjdxqPU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82596|0                           |1
        is obsolete|                            |

--- Comment #3 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83834&action=edit
Bug 21871: Show authority 856 links in the OPAC

This patch modifies the authority detail view in the OPAC so that any
links found in 856 tags are displayed and active.

To test, apply the patch and locate or create an authority record which
contains one or more URLs in 856 tags.
 - View this record in the OPAC and confirm that the links appear.
 - Test records with and without link text.
 - Test records with and without public notes.

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:28:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:28:30 +0000
Subject: [Koha-bugs] [Bug 22112] New: Omnibus: Use Price filter everywhere
Message-ID: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

            Bug ID: 22112
           Summary: Omnibus: Use Price filter everywhere
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

We should use the Price filter everywhere for formatting prices and amounts
correctly according to the CurrencyFormat system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:28:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:28:55 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-UPne4SaRfe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21427


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427
[Bug 21427] Format prices on ordered/spent lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:28:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:28:55 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-r9QEatZeRg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22112


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:34:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:34:08 +0000
Subject: [Koha-bugs] [Bug 22113] New: Add price formatting on item lost
	report
Message-ID: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

            Bug ID: 22113
           Summary: Add price formatting on item lost report
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:34:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:34:15 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-p4MCROOh6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:38:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:38:13 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-7qxR3JJk64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:38:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:38:17 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-8VD7REOzkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83835&action=edit
Bug 22113: Add price formatting on item lost report

The item lost report displays the price and replacement
price for lost items. With the patch they will display
according to the CurrencyFormat system preference.

To test:
- Mark 1 or more items lost
- Make sure that replacement cost and purchase price are set
- Go to Reports > Items lost
- Search for your lost items
- Verify price and replacement price display
- Apply patch and toggle CurrencyFormat to different settings
- Refresh lost items report
- Verify prices are always displayed according to syspref setting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:38:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:38:51 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-RQSsJv658h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22113


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113
[Bug 22113] Add price formatting on item lost report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 01:38:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 00:38:51 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-dZXmQGHASo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22112


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 02:50:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 01:50:47 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-Clfxaf1hWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

--- Comment #8 from Cab Vinton <bibliwho at gmail.com> ---
You may be right, Andrew. Not sure how I was testing back before the fall --
lost in the mists of time -- but I most likely did overlook something ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 04:34:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 03:34:45 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-AaosAhIyG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #155 from Liz Rea <wizzyrea at gmail.com> ---
What were you thinking for the blocker? Interface validation that the email
address is an actual address, or some kind of verification that the email
address is one that actually receives mail? And what would you prefer to happen
if the address given doesn't receive mail?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:46:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:46:12 +0000
Subject: [Koha-bugs] [Bug 22114] New: Untranslatable "Patron note:" in
	checkout.js
Message-ID: <bug-22114-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114

            Bug ID: 22114
           Summary: Untranslatable "Patron note:" in checkout.js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
  Target Milestone: ---

just noticed a line in checkout.js that contains a string:

 $('.patron_note_' + data.itemnumber).html("Patron note: " + data.patronnote);

.js files are not translated currently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:50:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:50:16 +0000
Subject: [Koha-bugs] [Bug 22115] New: Table of checkouts doesn't respect
 CurrencyFormat setting
Message-ID: <bug-22115-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115

            Bug ID: 22115
           Summary: Table of checkouts doesn't respect CurrencyFormat
                    setting
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 22112
  Target Milestone: ---

The table of checkouts on the checkouts and details tabs in the patron account
can display the columns Charge, Price and Fine. Those columns are not formatted
according to the CurrencyFormat systme preference.

I don't know how to fix this. It appears the formatting is currently done in
checkouts.js using toFixed(2):

Example:
                    "mDataProp": function ( oObj ) {
                        if ( ! oObj.charge ) oObj.charge = 0;
                        return '<span style="text-align: right; display:
block;">' + parseFloat(oObj.charge).toFixed(2) + '<span>';
                    }


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:50:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:50:16 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-0EWMqkupR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22115


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115
[Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:53:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:53:30 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-IfWH2WeQwx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22115                       |
         Depends on|                            |22115


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115
[Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:53:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:53:30 +0000
Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect
 CurrencyFormat setting
In-Reply-To: <bug-22115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22115-70-losYGZtoRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22112
         Depends on|22112                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:54:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:54:49 +0000
Subject: [Koha-bugs] [Bug 22116] New: Add price formatting to rental charge
 and replacement price on items tab in staff
Message-ID: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

            Bug ID: 22116
           Summary: Add price formatting to rental charge and replacement
                    price on items tab in staff
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 22112
  Target Milestone: ---


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:54:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:54:49 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-dNItrvcM4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22116


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116
[Bug 22116] Add price formatting to rental charge and replacement price on
items tab in staff
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:55:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:55:09 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-kN20VTU2Zc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22112
             Status|NEW                         |ASSIGNED
         Depends on|22112                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 08:55:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 07:55:09 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-7xcagcH56C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22116                       |
         Depends on|                            |22116


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116
[Bug 22116] Add price formatting to rental charge and replacement price on
items tab in staff
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:04:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:04:17 +0000
Subject: [Koha-bugs] [Bug 22117] New: Show rental charge for each item on
 items tab when item-level itypes are used
Message-ID: <bug-22117-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22117

            Bug ID: 22117
           Summary: Show rental charge for each item on items tab when
                    item-level itypes are used
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

The items tab in the staff interface shows the rental charge only for the
itemtype of the record on top of the list.
When using item-level itemtypes this makes no sense, the rental charge should
be shown for each item's itemtype instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:06:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:06:16 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-oQluuV4CkZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:06:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:06:19 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-C50pAkURnC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83836&action=edit
Bug 22116: Add price formatting to rental charge and replacement price on items
tab in staff

Adds formatting to replacement price and rental charge on items
tab.

To test:
- Add a rental charge to one or more of your item types
- Edit a record with some items, add replacement cost to some
- Find or create a record with your rental charged itemtype (MARC21:942$c)
- Go to the staff detail page of those records
- Check "Items" tab for
  - Rental charge on top
  - Replacement price for items
- Verify information is displayed correctly when toggling CurrencyFormat
  system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:06:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:06:51 +0000
Subject: [Koha-bugs] [Bug 22117] Show rental charge for each item on items
 tab when item-level itypes are used
In-Reply-To: <bug-22117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22117-70-rukIZD70Ur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22117

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22116

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:06:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:06:51 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-K4Ih2JveXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22117

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:09:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:09:18 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-5FVt2PWbqy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22111


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111
[Bug 22111] Correctly format fines when placing holds (maxoutstanding warning)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:09:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:09:18 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-kDSDucW91q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22112


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:17:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:17:59 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-k4IYGwXbiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83837&action=edit
Bug 22111: Format amount shown on place holds when maxoutstanding is reached
(staff)

Displays amount outstanding correctly when holds are blocked
by maxoutstanding.

To test:
- Check maxoutstanding system preference value
- Add a fine to a patron account exceeding maxoutstanding
- Try to place a hold for this patron from staff
- Verify this message is shown:

     Patron has outstanding fines: 6.00

- Toggle CurrencyFormat system preference and verify display
  changes according to setting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:20:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:20:30 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-KuKio11O93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118
[Bug 22118] Format hold fee when placing holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:20:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:20:30 +0000
Subject: [Koha-bugs] [Bug 22118] New: Format hold fee when placing holds in
	OPAC
Message-ID: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

            Bug ID: 22118
           Summary: Format hold fee when placing holds in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 22112
  Target Milestone: ---


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:34:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:34:10 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-37It2R0twA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 09:34:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 08:34:13 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-lWg12onIqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83838&action=edit
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 13:19:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 12:19:26 +0000
Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron
In-Reply-To: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22086-70-3SE4INENO0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

Serhij Dubyk <dubyk at ukr.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dubyk at ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 12 13:24:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Jan 2019 12:24:01 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-8d6n8Qczev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Serhij Dubyk <dubyk at ukr.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dubyk at ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 09:58:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 08:58:29 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-66PyGgwBHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22119


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119
[Bug 22119] Add price formatting in circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 09:58:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 08:58:29 +0000
Subject: [Koha-bugs] [Bug 22119] New: Add price formatting in circulation
Message-ID: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119

            Bug ID: 22119
           Summary: Add price formatting in circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Blocks: 22112
  Target Milestone: ---


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 10:18:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 09:18:51 +0000
Subject: [Koha-bugs] [Bug 22119] Add price formatting in circulation
In-Reply-To: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22119-70-abpXguW2Vc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 10:18:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 09:18:55 +0000
Subject: [Koha-bugs] [Bug 22119] Add price formatting in circulation
In-Reply-To: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22119-70-TtQN3DKaen@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83839&action=edit
Bug 22119: Add price formatting in more places in circulation

This adds some missing Price filters to some places in circulation.
To check verify the amount are displayed according to setting
of CurrencyFormat (use FR or CH for seeing a change)

Use a patron account with no pending fines at the beginning
for all tests.

1)
- Switch RentalFeesCheckoutConfirmation to "Ask"
- Check out an item with a rental charge
- Verify message is formatted correctly:
  Rental charge for this item: ...

2)
- Switch RentalsInNoissuesCharge to "Don't include"
- Make sure patron has only Rental fines on their account
- Check out another item
- Verify message is formatted correctly:
  The patron has unpaid charges for holds, rentals etc ...

3)
- Switch BatchCheckouts to "Allow"
- Add the patron category of your test patron to BatchCheckoutsValidCategories
- Checkout any item
- Verify the message in the information column is formatted correctly:
  The patron has unpaid charges for holds, rentals etc of ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 11:11:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 10:11:12 +0000
Subject: [Koha-bugs] [Bug 22120] New: Add price formatting to patron summary
	print
Message-ID: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

            Bug ID: 22120
           Summary: Add price formatting to patron summary print
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Blocks: 22112
  Target Milestone: ---


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 11:11:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 10:11:12 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-92mHYIBRSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22120


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120
[Bug 22120] Add price formatting to patron summary print
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 11:18:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 10:18:42 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-3wfEWc7prQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 11:18:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 10:18:45 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-wzqjcAhDSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83840&action=edit
Bug 22120: Add price formattig to patron summary print

The patron summary print lists the replacement prices
and rental charges of items and totals them. With this
patch they will be formatted according to the
CurrencyFormat system preference.

To test:
- Find or create a patron with some checkouts
- Make sure some items have replacement price set
  and some have a rental charge
- "Print summary" from the account in staff
- Verify that charges and prices in the checkouts
  table are formatted correctly
- Toggle CurrencyFormat to different settings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:02:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:02:01 +0000
Subject: [Koha-bugs] [Bug 22121] New: Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
Message-ID: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

            Bug ID: 22121
           Summary: Display 'Price paid' on ILL requests according to
                    CurrencyFormat pref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:02:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:02:13 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-QquAaEkh87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:12:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:12:55 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-nCKKrrRtvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83841&action=edit
Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat
pref

To test:
- Install BLDSS backend
  see: https://wiki.koha-community.org/wiki/ILL_backends
- Add a new BLDSS ILL request
- Edit ILL request
- Fill in Price paid field
- Verify Price paid is formatted correctly on 'Manage ILL request'
  page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:13:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:13:12 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-9ON2ohwY4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22112


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
[Bug 22112] Omnibus: Use Price filter everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:13:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:13:12 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-mLA5DbLjaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22121


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121
[Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat
pref
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:12:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:12:52 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-0Ki9dkVT5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 12:17:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 11:17:48 +0000
Subject: [Koha-bugs] [Bug 22009] Fix error messages for classification
 sources and filing rules
In-Reply-To: <bug-22009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22009-70-ko0qYRKtUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22009

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Possible mistake in error   |Fix error messages for
                   |messages for classification |classification sources and
                   |sources and filing rules    |filing rules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:34:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:34:40 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-9n8FukgEO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:34:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:34:43 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-AjMEXNv4KC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83763|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83842&action=edit
Bug 22083: Typo in circulation_batch_checkouts.tt

There is a typo in circulation_batch_checkouts.tt that makes Koha skip
a warning if the user cannot borrow due to circulation rules.

This patch corrects this typo.

To test:

1. In Administration > Global system preferences, 'Allow'
   BatchCheckouts and enter patron categories in
   BatchCheckoutsValidCategories
2. Go to Administration > Circulation and fines rules
3. Enter a rule where a certain category of patrons (that is in
   BatchCheckoutsValidCategories) cannot take out a particular item type
4. Search the catalog for an item of that item type
5. Copy the barcode
6. Go into patrons and find a patron of that category
7. Click on the Batch checkout tab
8. Paste the barcode in the box and click Check out
9. It should say 'Too many checked out'
10. Apply the patch
11. Try the check out again, it should show both warnings ('Too many
    checked out' and 'This patron can't check out this item per library
    circulation policy')

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:35:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:35:01 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-tGmkTfRLKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Caroline!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:36:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:36:31 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-mJ4GKXpCtq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83821|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83843&action=edit
Bug 22101: Ill Requests missing in menu on advanced search page

This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.

To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.

- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
  "ILL requests."

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:36:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:36:27 +0000
Subject: [Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-q5VKOVfiU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:36:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:36:50 +0000
Subject: [Koha-bugs] [Bug 22101] ILL requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-q4NM8CsPC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Ill Requests missing in     |ILL requests missing in
                   |menu on advanced search     |menu on advanced search
                   |page                        |page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:40:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:40:39 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-9tmnJRkhwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are some complaints from the QA tool:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
   FAIL   filters
                missing_filter at line 148 (                <img src="[%
interface %]/[% theme %]/img/spinner-small.gif" alt="" />)

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
   FAIL   filters
                missing_filter at line 272 (                                   
            <div class="hint">To update the image for [% patron.title %] [%
patron.firstname | html %] [% patron.surname | html %], select a new image file
and click 'Upload.' <br />Click the 'Delete' button to remove the current
image.</div>)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:55:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:55:37 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-1ET76wKeye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83844&action=edit
Bug 20809: Link patron image to patron image add/edit form

This patch modifies an include file so that it is possible with edit a
patron's image on any patron-related page which uses that include.

To test you must have the patronimages system preference enabled.

Apply the patch and open any patron record for viewing.

 - Hover the mouse over the patron image.

   - If the patron has a previously-defined patron image, should you see
     an "Edit" button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

   - If a patron has no patron image defined, you should see an "Add"
     button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

This process should work from any page which shows the patron sidebar:
Check out, Details, Fines, Routing lists, Circulation history, etc.

Patch works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:55:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:55:41 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-uCg6k6rxZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83845&action=edit
Bug 20809: (follow-up) Corrections to CSS and JS

This follow-up modifies JavaScript so that the confirmation dialog is
triggered when deleting a patron image from the modal window.

The CSS is modified to improve the alignment of patron image and edit
button.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:55:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:55:45 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-CgjqVRTMJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83846&action=edit
Bug 20809: (follow-up) Add missing JS to view log page

If the log viewer is being used to track patron-related data the
patron-related JavaScript file should be included.

To test, apply the patch and open a patron record. In the left-hand
sidebar choose Modification Log. Test the patron image edit/replace
process from the patron image in the sidebar and confirm that it works
correctly.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:55:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:55:50 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-M9am546g8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83847&action=edit
Bug 20809: (QA follow-up) Fix missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:56:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:56:08 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-XhQbXzr6Ml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Added the missing filters in a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 18:56:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 17:56:20 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-kvSJ1X9Myo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 19:11:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 18:11:06 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-XJRh6FCAA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The display works, but I think the code for the TrackClicks should not be
there. The linktracker table only has a bilbionumber column, nothing is tracked
there if you click on the authority links now. I suggest removing it and adding
a separate bug to make it possible to track links for authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:07:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:07:35 +0000
Subject: [Koha-bugs] [Bug 21913] Clean up payment details page
In-Reply-To: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21913-70-7Qtq1Tijjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:07:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:07:39 +0000
Subject: [Koha-bugs] [Bug 21913] Clean up payment details page
In-Reply-To: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21913-70-JklZNk9gPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83828|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83848&action=edit
Bug 21913: Clean up payment details page

This patch makes various corrections and improvements to the payment
details page:

 - Grid converted to Bootstrap
 - Correct title tag
 - Add patron toolbar
 - Adding missing patron-related JavaScript
 - Improve some language

To test, apply the patch and locate a patron who has one or more
payments on their account.

 - Open Fines -> Account -> Details of a transaction
 - Confirm that the page looks correct and adjusts well at various
   browser widths.
 - Confirm that patron toolbar items work correctly

Signed-off-by: Jose-Mario <jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:15:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:15:25 +0000
Subject: [Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date
 descending as a default
In-Reply-To: <bug-21399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21399-70-X3a7Dz0yLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83466|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83849&action=edit
Bug 21399: Sort patron fines in OPAC by date descending as a default

This patch modifies the DataTables configuration of the logged-in user's
"Fines and charges" table in the OPAC so that the table is sorted by
date, descending.

To test, apply the patch and log in to the OPAC as a user with multiple
fines. Go to the "your fines" page and confirm that the table is sorted
by default on the first column with the newest entries first.

Signed-off-by: Nazl? ?etin <nazli at devinim.com.tr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:15:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:15:21 +0000
Subject: [Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date
 descending as a default
In-Reply-To: <bug-21399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21399-70-mrxlmy0zrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:17:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:17:04 +0000
Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should
 return if no patron is passed
In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22067-70-hQO1Ep81hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:19:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:19:56 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-ENtXkdn0ow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:20:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:20:00 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-rqkqiR0aOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83673|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83850&action=edit
Bug 21850: Remove search request from page title of OPAC result list

This patch modifies the OPAC search results template so that advanced
search terms are not shown in the page title and breadcrumbs. This
removes potentially confusing computer-oriented code from the public
view.

For simple searches the search term is displayed, using the same logic
that determines whether the search bar should be populated with the last
search term.

To test:

 - Apply the patch
 - Peform a simple keyword search in the OPAC
   - On the results page the title and breadcrumbs should show 'Results
     of search for [your keyword]
 - Perform an advanced search with multiple parameters
   - The page title and breadrumbs should show only 'Search results'
   - The breadcrumbs should also show a link back to Advanced search
     using the returntosearch parameter

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: mikael <mikael.Olangcay-Brisebois at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:20:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:20:23 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-U1UAa5SmQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Owen, I really like the solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:47:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:47:13 +0000
Subject: [Koha-bugs] [Bug 20729] Update style of datepickers
In-Reply-To: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20729-70-S7bMx9wRAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:47:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:47:17 +0000
Subject: [Koha-bugs] [Bug 20729] Update style of datepickers
In-Reply-To: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20729-70-BguMNPXqPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83830|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83851&action=edit
Bug 20729: Update style of datepickers

This patch updates the styling of form fields which are configured to
use the jQueryUI datepicker widget. Some CSS has been added, and the
default datepicker configuration has been changed.

To test, apply the patch, rebuild the staff client CSS file, and clear
your cache if necessary. Test pages which include a datepicker to
confirm that they look correct and work correctly. Some examples:

 - Circulation -> Check out -> Specify due date
 - Patrons -> Add patron -> Date of birth, registration date, expiry
   date fields
 - Serials -> Search subscriptions -> Search results page sidebar
 - Tools -> News -> Add news item

And confirm that this change hasn't adversely affected the calendar
tool:

 - Tools -> Calendar

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 21:57:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 20:57:20 +0000
Subject: [Koha-bugs] [Bug 22122] New: Make sequence of Z39.50 search options
 match in acq and cataloguing
Message-ID: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

            Bug ID: 22122
           Summary: Make sequence of Z39.50 search options match in acq
                    and cataloguing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

While we offer the same search options for Z39.50 search in catalouging and
acquisition the sequence of search options is totally different. This seems
unnecessary from a functional point of view and only confusing.

Personally, I'd prefer cataloguing as it has ISBN and ISSN together at the top,
followed by title and author grouped together.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:00:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:00:26 +0000
Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50
	search form
In-Reply-To: <bug-21921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21921-70-s0m0osIkaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This works well, but can you please add it to the search form in acq too? While
the sequence is different (bug 22122), we currently offer the same search
options there and I think it would be better to not have the forms drift apart.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:17:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:17:27 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
 gives no results if search terms include punctuation
In-Reply-To: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21084-70-NSGLEpNQdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:17:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:17:42 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
 gives no results if search terms include punctuation
In-Reply-To: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21084-70-NsO3jqZIKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Much better!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:17:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:17:31 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
 gives no results if search terms include punctuation
In-Reply-To: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21084-70-2ROgZGM5Rp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82966|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83852&action=edit
Bug 21084: Fix automatic truncation in authority search

- Makes token splitting work like in biblio search
- Only adds right hand truncation since that's what Zebra also does
- Only adds truncation if the token is not a phrase and ends in a word
character
- Adds tests to existing and new QueryBuilder functions

Test plan:

1. Create an authority record for "Duck, Donald"
2. Try contains type authority searches with the following terms and make sure
they find the record:
Duck, Donald
donald duck
don duck
"Duck, Donald"
3. Make sure the following search works but does not find anything:
"Duck, Don"

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:26:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:26:28 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-BtScH2OCGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:26:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:26:33 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-2RvMv3mYdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76608|0                           |1
        is obsolete|                            |

--- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 83853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83853&action=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:27:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:27:18 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-osPDZ0w1zq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83368|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83854&action=edit
Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it

Caused by
  commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0
  Bug 21621: Remove incorrect GROUP BY from tools/letter.pl
The test plan was not complete enough.

Test plan:
1) Go to Home ? Tools ? Notices & slips
2) Choose a letter to edit, e.g. PREDUE. Note that there is only a
single row.
3) Click the edit button on the notice.
4) Expand the 'Print' section. Put text into the Message subject and
Message body text areas.
5) Click save, this will take you back to the 'Notices & slips' page.
6) Clone PREDUE for a specific library
7) The 'all libraries' option must list the templates for all libraries,
but without duplicate
8) Select a library in the dropdown list: only the templates for the
given library is listed, without duplicate

Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:27:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:27:22 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-CBuIzthjjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83855&action=edit
Bug 22002: (QA follow-up) Remove some debugging code from template

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:27:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:27:40 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-cjkcx5gCX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry for missing the issue before!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:27:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:27:14 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-8W3zUA5UxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:28:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:28:23 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-DlxFGNF7Pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|ambiguous column in patron  |Ambiguous column in patron
                   |stats                       |stats

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:31:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:31:14 +0000
Subject: [Koha-bugs] [Bug 21954] Koha update having a strange effect on
	checkout rules
In-Reply-To: <bug-21954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21954-70-wu0lGQqOJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21954

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's generally recommended to configure an All-All-All rule as there are some
cases where it's needed. I think one of the cases is when the record has no
itemtype set, but it's needed for max holds calculation.
Could this be the case here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:34:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:34:33 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-QEEVadp2LG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:34:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:34:36 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-re6a31lVtz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83733|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83856&action=edit
Bug 22082: ambiguous column in patron stats

In Reports > Patrons statistics, the combination of activity and extended
attributes generates an invalid SQL query with error :
ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous

This is because FROM contains tables borrowers and borrower_attributes both
containing borrowernumber column.

Test plan :
1) Be sure to have a patron extended attribute
2) Be sure you have some recent circulation activity
3) Go to Reports > Patrons statistics
4) Select 'active' in 'Patron activity' and 1 years of activity
5) Check 'Row' in 'Patron category'
6) Check 'Columns' in a extended attribute
7) Submit
8) Without patch you have no results, with patch you have exepected results

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:35:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:35:17 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-M88FGlQIug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Never hurts to be specific :) Good catch, Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:36:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:36:47 +0000
Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in
	checkins table
In-Reply-To: <bug-21750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21750-70-ylGn70ERPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Dependency is FQA - moving to BLOCKED for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:38:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:38:13 +0000
Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20022-70-730IYJESQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:38:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:38:17 +0000
Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20022-70-W7GrUdM5aU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70717|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 83857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83857&action=edit
Bug 20022 - use Modern::Perl in t (test) perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

00-checkdatabase-version.t
00-deprecated.t
00-valid-xml.t
AuthoritiesMarc_MARC21.t
AuthoritiesMarc_UNIMARC.t
Barcodes_EAN13.t
Barcodes_hbyymmincr.t
Barcodes_incremental.t
Bookseller.t
Budgets.t
ClassSortRoutine.t
ClassSortRoutine_Dewey.t
ClassSortRoutine_Generic.t
ClassSortRoutine_LCC.t
ClassSource.t
Contract.t
Creators.t
EdiInvoice.t
Edifact.t
Ediorder.t
Ediordrsp.t
External/Syndetics.t
Form_MessagingPreferences.t
Heading.t
HtmlTags.t
Installer_PerlDependencies.t
Installer_pm.t
ItemCirculationAlertPreference.t
Koha_Util_MARC.t
Labels.t
Labels_split_ccn.t
Labels_split_ddcn.t
Labels_split_lccn.t
Log.t
Members_Attributes.t
Members_Messaging.t
Output.t
Output_JSONStream.t
Patroncards.t
Patroncards_Batch.t
Patroncards_Layout.t
Patroncards_Lib.t
Patroncards_Patroncard.t
Patroncards_Profile.t
Patroncards_Template.t
Print.t
QueryParser.t
Scheduler.t
Scrubber.t
Stats.t
SuggestionEngine.t
TmplToken.t
db_dependent/00-strict.t
db_dependent/Amazon.t
db_dependent/Heading_MARC21.t
db_dependent/LDAP/test_ldap_add.pl
db_dependent/Languages.t
db_dependent/MungeMarcPrice.t
db_dependent/Record/Record.t
db_dependent/RecordProcessor_EmbedSeeFromHeadings.t
db_dependent/Reports.t
db_dependent/Service.t
db_dependent/SuggestionEngine_ExplodedTerms.t
db_dependent/Tags.t

:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:38:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:38:37 +0000
Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20022-70-DUJFKv3dp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Jon Knight from comment #2)
> Appears to be missing 'use Modern::Perl;' in:
> 
> t/Barcodes_annual.t

The reason this was skipped is because there is no use strict; use warnings; so
we don't want to add them if they're not already being used. It was likely
accidentally added to the commit message.

Patch has been rebased and is ready to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:52:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:52:56 +0000
Subject: [Koha-bugs] [Bug 22091] Need Details of Books or Accession Number
 issued to particular patron via SIP2
In-Reply-To: <bug-22091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22091-70-RDmvL6QO2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Rohit,

this looks more like a support question/configuration issue. Bugzilla is
intended for problems relating to the code/software directly. 

I think this is a question better suited to the mailing lists:
https://koha-community.org/support/koha-mailing-lists/

Or ask some community members in IRC:
https://koha-community.org/get-involved/irc/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 22:58:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 21:58:44 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-cPlWBv3my1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |oleonard at myacpl.org

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Owen, could you have a look maybe? Is this an urgent one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:14:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:14:34 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-tL1iPIRAmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Small favor: can we please use a clearer name for the table, that is consistent
with the others? This uses: table_borrowers. Most use *-table and hyphens.
Also... patron vs. borrower.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:15:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:15:24 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-DhbZ10VQL5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:15:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:15:28 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-KE9AT7Yvhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83743|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83858&action=edit
Bug 17353: Add phone number column to checkout search

This patch adds borrowers.phone as 'Primary phone' in the checkout
search results. It also ads the table to columns configuration

To test:
1 - Perform a checkout search
2 - Note phone is not displayed
3 - Apply patch
4 - Note phone does not display
5 - Visit columns configuration
6 - Unhide the 'phone' column
7 - Note phone displays
8 - Ensure page functions as before patch

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:15:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:15:33 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-CbzPZDugiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83775|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83859&action=edit
Bug 17353: (follow-up) Adjust config variable for moremember.tt too

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:15:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:15:53 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-op1ZBCCa3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
see comment 8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:32:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:32:28 +0000
Subject: [Koha-bugs] [Bug 21491] When 'Default lost item fee refund on
 return policy' is unset it says no but acts as if 'yes'
In-Reply-To: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21491-70-MUTIdpPgmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:32:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:32:32 +0000
Subject: [Koha-bugs] [Bug 21491] When 'Default lost item fee refund on
 return policy' is unset it says no but acts as if 'yes'
In-Reply-To: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21491-70-b1F2h2ZJIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83443|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83860&action=edit
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

To test:
1 - Delete all refund_lost_item_fee_rules form the db
    delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as
'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund (this is in the
        LostItemFeeRules code, default 1 if not set)
5 - Apply patch
6 - Rule shows as 'Yes'
7 - View a specifc rule, still says Default (Yes)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 13 23:35:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Jan 2019 22:35:19 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title
	without item
In-Reply-To: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21738-70-1BqBLKtZLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|[ILS-DI] error while        |[ILS-DI] Error placing a
                   |holding a title without     |hold on a title without
                   |item                        |item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 04:00:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 03:00:10 +0000
Subject: [Koha-bugs] [Bug 18039] Move the mandatory and optional files for
 non-english languages into 'default' directory so bug 17855 permits use of
 other languages
In-Reply-To: <bug-18039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18039-70-wWmFAuIvnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 06:56:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 05:56:22 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D_Remove_or_clarify_checkbox_?=
 =?utf-8?q?=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?=
In-Reply-To: <bug-14772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14772-70-LTwk9r9ube@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
The only references I can find to "flagged" are in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt and
koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js.

And koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js is only found
in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt.

There is another reference to "-8" in Koha/Filter/MARC/ViewPolicy.pm.

--

It might be worth leaving in Koha/Filter/MARC/ViewPolicy.pm for backward
compatibility for hiding values... but I think we could remove it from the
templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 07:46:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 06:46:16 +0000
Subject: [Koha-bugs] [Bug 22123] New: Hardcoded values in subfield
	constraint visibility
Message-ID: <bug-22123-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22123

            Bug ID: 22123
           Summary: Hardcoded values in subfield constraint visibility
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The MARC subfield constraint editor shows checkboxes for the subfield
visibility (OPAC, Intranet, Editor, Collapsed, Flagged). The state of these
checkboxes is encoded in the database as a single integer, and the conversion
is done in marc_subfields_structure.js via hardcoded magic values:

    if ( flagged_checked ) {
        hidden_value='-8';
    } else if ( opac_checked && ! intranet_checked && ! editor_checked &&
collapsed_checked ) {
        hidden_value='-7';
    } else if ( opac_checked && intranet_checked && ! editor_checked && !
collapsed_checked) {
        hidden_value='-6';


etc.

These should be moved into the database, perhaps as authorised values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 07:49:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 06:49:23 +0000
Subject: [Koha-bugs] [Bug 22123] Hardcoded values in subfield constraint
	visibility
In-Reply-To: <bug-22123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22123-70-Dt6TjfNnCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22123

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure about this one - what would be the advantage of moving them into
the db? The 3 checkboxes GUI seems like the easiest way to translate this to
the user.

For people working with SQL we keep some documentation here:
https://wiki.koha-community.org/wiki/Hidden_values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 07:50:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 06:50:19 +0000
Subject: [Koha-bugs] [Bug 22109] Koha to Marc Mapping Chart is not in
 english in the English version
In-Reply-To: <bug-22109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22109-70-sHZ6ObepYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22109

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 08:21:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 07:21:00 +0000
Subject: [Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results
 in column Location
In-Reply-To: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17643-70-W9vZsBvmGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 08:20:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 07:20:51 +0000
Subject: [Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results
 in column Location
In-Reply-To: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17643-70-N4zBlMYQMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am failing to replicate this - given it's age, I think if it wasn't a
configuration issue, it might have been fixed in a different way by now. Please
reopen with a test plan if this is still an issue!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 08:27:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 07:27:43 +0000
Subject: [Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results
 in column Location
In-Reply-To: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17643-70-oqAsbxzI2p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |---
             Status|RESOLVED                    |REOPENED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Actually, I figured it out:

- Change the description of NOT_LOAN = 1 to something easy to recognize
- Set an itemtype to "not for loan"
- Search for records with items of that item type in staff
- Look at the search results
- The items will be listed as unavailable, which I think is ok, BUT:
  each item will show the value of the not for loan = 1, which is not correct

I think if the itemtype is marked as not for loan, we should leave it as
showing them as unavailable, without looking up a wrong authorised value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 08:30:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 07:30:33 +0000
Subject: [Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results
 in column Location
In-Reply-To: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17643-70-XLD4YFcgOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83861&action=edit
Screenshot of result list with nfl = 1 = Treatment, itemtype books = nfl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 08:33:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 07:33:48 +0000
Subject: [Koha-bugs] [Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group
 codes as limits
In-Reply-To: <bug-17683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17683-70-75RlR3tmMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Martin, is it possible this was fixed by bug 21911?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 09:28:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 08:28:50 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-UCBjnHaRjp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 09:28:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 08:28:53 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-C3kCYABoWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83754|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 83862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83862&action=edit
Bug 22085: fix UNIMARC default XSLT broken by Bug 14716

Bug 14716 added a call to encode-uri() and namespace str.  This
namespace declaration is sometimes missing in UNIMARC default XSLT
files.

This patch adds namespace declaration also where encode-uri is not used
because it may be used in the future. And those files are the base for
home made custom files.

Test plan :
1) Use a UNIMARC DB
2) Use default in all XSLT sysprefs
3) Apply patch
4) Perform a search on OPAC
5) Check display is OK
6) Click on a record for detail page
7) Check display is OK
8) Perform a search on staff interface
9) Check display is OK
10) Click on a record for detail page
11) Check display is OK

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:16:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:16:36 +0000
Subject: [Koha-bugs] [Bug 22124] New: Update cataloguing plugin system to
 not generate type parameter in script tag
Message-ID: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

            Bug ID: 22124
           Summary: Update cataloguing plugin system to not generate type
                    parameter in script tag
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:17:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:17:25 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-xWfmxYKfX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:57:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:57:18 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-bXQB2nJEzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81935|0                           |1
        is obsolete|                            |

--- Comment #380 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83863&action=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:57:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:57:40 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ekMgLWpW1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81936|0                           |1
        is obsolete|                            |

--- Comment #381 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83864&action=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:58:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:58:25 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-zh6FKXFObJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81938|0                           |1
        is obsolete|                            |

--- Comment #383 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83866&action=edit
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to
prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any
crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the
test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again
on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the
action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:58:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:58:04 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-p546AoKH9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81937|0                           |1
        is obsolete|                            |

--- Comment #382 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83865&action=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by
number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
    - no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you
anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a
Share button)
- Try to create a new subscription for serial #1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana-KB for more results, enter a few word from title, notes, type of the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake &
comment why you report: click on report mistake. You only can chose "other"
because there's no comment in Mana-KB [if there are comments, you'll get other
values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:58:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:58:44 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-37HTfjVgoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81939|0                           |1
        is obsolete|                            |

--- Comment #384 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83867&action=edit
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from
Mana.
- Error messages are displayed in case of fail
- Correct the display of sql reports containing "'"
- Importing a report from Mana now opens the edit page
- You don't get message after a successful import from mana (you simply get
redirected)
- Fix an error when cretaing subscription
- Fix mana search
- Correct encoding issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:59:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:59:04 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-looQTItNl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81940|0                           |1
        is obsolete|                            |

--- Comment #385 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83868&action=edit
Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema
change, add to kohastructure.sql - Update schema files - Remove javascript
debugger call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:59:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:59:32 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-MoaD718uPE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81941|0                           |1
        is obsolete|                            |

--- Comment #386 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83869&action=edit
Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html
attribute - Remove useless passing of mana_id variable in serials-toolbar.inc -
Remove using CGI::param in list context - remove new subs from
serials/subscription-add.pl - remov

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 10:59:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 09:59:52 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-us7DS4kUr1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81942|0                           |1
        is obsolete|                            |

--- Comment #387 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83870&action=edit
Bug 17047 - Move ability to comment mana entities from search results table to
report/subscription detail page

+ code refactoring

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:00:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:00:10 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-xxmi8ndb0l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81943|0                           |1
        is obsolete|                            |

--- Comment #388 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83871&action=edit
Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a
serial Provide a more visible message when sharing a report without note Fix
Internal server error when trying to share a new report Make update DB
idempotent

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:00:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:00:49 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-kNzDvSp1hm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81945|0                           |1
        is obsolete|                            |

--- Comment #390 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83873&action=edit
Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and
Subscription.pm - mana.inc included twice

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:00:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:00:30 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-FJzQpRPp8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81944|0                           |1
        is obsolete|                            |

--- Comment #389 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83872&action=edit
Bug 17047 - Fix retrieving Mana token

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:01:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:01:08 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-i9K8N3wFDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81946|0                           |1
        is obsolete|                            |

--- Comment #391 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83874&action=edit
Bug 17047 - Move mana JS and put correct subscription id when sharing

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:01:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:01:26 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-fVhvk5kjY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81947|0                           |1
        is obsolete|                            |

--- Comment #392 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83875&action=edit
Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA
script warnings

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:01:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:01:50 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-6Putw2cDkH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81948|0                           |1
        is obsolete|                            |

--- Comment #393 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83876&action=edit
Bug 17047: Koha::SharedContent subs snake casing/renaming

manaRequest           => process_request
manaIncrementRequest  => increment_entity_value
manaPostRequest       => send_entity
prepareSharedData     => prepare_entity_data
manaGetRequestWithId  => get_entity_by_id
manaGetRequest        => search_entities
buildRequest          => build_request
manaUrl               => get_sharing_url

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:02:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:02:08 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-FvVPjd1Xt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81949|0                           |1
        is obsolete|                            |

--- Comment #394 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83877&action=edit
Bug 17047: add a dedicated page for Mana setup

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:02:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:02:34 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-bByxssynjh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81950|0                           |1
        is obsolete|                            |

--- Comment #395 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83878&action=edit
Bug 17047: [DO NOT PUSH] provide staff-global.css

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:02:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:02:55 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-w5vQ9m1S6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81951|0                           |1
        is obsolete|                            |

--- Comment #396 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83879&action=edit
Bug 17047: [DO NOT PUSH] provides schema files

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:03:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:03:35 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Cal0xruBnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81968|0                           |1
        is obsolete|                            |

--- Comment #398 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83881&action=edit
Bug 17047: [QA tool] add template filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:03:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:03:14 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Wa3nDoa50T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81952|0                           |1
        is obsolete|                            |

--- Comment #397 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 83880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83880&action=edit
Bug 17047: Fix reports sharing

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:05:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:05:34 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-v6p50TWvof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 11:42:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 10:42:36 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-TC8CrX1NZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #84 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 83882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83882&action=edit
Bug 20600: (follow-up) Fix tests

Some silly variable name typos in the tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:02:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:02:56 +0000
Subject: [Koha-bugs] [Bug 22125] New: branches.pickup_location should be
 flagged as boolean
Message-ID: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

            Bug ID: 22125
           Summary: branches.pickup_location should be flagged as boolean
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Our coding guidelines make it mandatory to flag boolean columns as such (and
use the TINYINT type on their definitions.

QA on bug 7534 missed this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:03:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:03:05 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-UfN1Z4OyAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7534
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534
[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries
allowing holds
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:03:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:03:05 +0000
Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for
 only showing libraries allowing holds
In-Reply-To: <bug-7534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7534-70-dqrlQqEZBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22125


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125
[Bug 22125] branches.pickup_location should be flagged as boolean
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:05:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:05:39 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-EC86fkczgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:05:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:05:42 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-zgBC0fyEIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83883&action=edit
Bug 22125: branches.pickup_location should be flagged as boolean

This trivial patch just marks the mentioned column as a boolean.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:06:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:06:03 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-X7e3shZr1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22125


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125
[Bug 22125] branches.pickup_location should be flagged as boolean
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:06:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:06:03 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-hKbofHnrj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16497


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
[Bug 16497] Add routes to list libraries
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:08:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:08:24 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-cgQtMG88WO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #85 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #83)
> 
> 1) Unit tests failing:

Silly mistake in the test script, latest patch fixes it

> 2) QA tool complaining:
> 
> 
>  FAIL	Koha/REST/V1/Illrequests.pm
>    FAIL	  critic
> 		# Variables::ProhibitUnusedVariables: Got 1 violation(s).  
> 

I can't replicate this, I ran:

koha-qa.pl -v 2 -c 8

and didn't get any failures. What command did you run and did the error give
any indication of what the unused variable was?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:28:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:28:43 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-RKbfOiwZ4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83884&action=edit
Bug 22124: Update cataloguing plugin system to not generate type parameter in
script tag

Test plan:
1) Apply the patch
2) Have defined some cataloguing plugin which generates javascript - for
example dateaccessioned.pl
3) Go to cataloguing/adding item and show source
-> there should be no type parameter in script tag in code added by
cataloguing pulgin
4) prove t/db_dependent/FrameworkPlugin.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:28:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:28:41 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-me4ZQohtop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:29:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:29:29 +0000
Subject: [Koha-bugs] [Bug 22126] New: OMNIBUS: Update cataloguing plugins
Message-ID: <bug-22126-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126

            Bug ID: 22126
           Summary: OMNIBUS: Update cataloguing plugins
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:30:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:30:19 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-wZqVK7bPDz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126
[Bug 22126] OMNIBUS: Update cataloguing plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:30:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:30:19 +0000
Subject: [Koha-bugs] [Bug 22126] OMNIBUS: Update cataloguing plugins
In-Reply-To: <bug-22126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22126-70-UoeBlRT555@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
         Depends on|                            |22124, 22098


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098
[Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124
[Bug 22124] Update cataloguing plugin system to not generate type parameter in
script tag
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:30:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:30:19 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-0jQTB7DYLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126
[Bug 22126] OMNIBUS: Update cataloguing plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:30:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:30:39 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-OHpCqVYAsJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:33:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:33:59 +0000
Subject: [Koha-bugs] [Bug 22127] New: Update dateaccessioned value builder
Message-ID: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127

            Bug ID: 22127
           Summary: Update dateaccessioned value builder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:38:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:38:08 +0000
Subject: [Koha-bugs] [Bug 22126] OMNIBUS: Update cataloguing plugins
In-Reply-To: <bug-22126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22126-70-H28Wgfhe92@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22127


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127
[Bug 22127] Update dateaccessioned value builder
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:38:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:38:08 +0000
Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder
In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22127-70-OQIo8cPkqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22126
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126
[Bug 22126] OMNIBUS: Update cataloguing plugins
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:38:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:38:29 +0000
Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder
In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22127-70-XCJAPihGRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:38:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:38:32 +0000
Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder
In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22127-70-2xtTW3IcHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83885&action=edit
Bug 22127: Update date accessioned plugin - remove unused routine

Test plan:
1) Apply the patch
2) Have set dateaccessioned plugin to an item subfield (it is set on 952$d by
default)
3) Confirm the functionality of this plugin is same as before patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 12:48:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 11:48:50 +0000
Subject: [Koha-bugs] [Bug 22128] New: koha-remove fails mysql ERROR 1133
 (42000) at line 2: Can't find any matching row in the user table
Message-ID: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128

            Bug ID: 22128
           Summary: koha-remove fails mysql ERROR 1133 (42000) at line 2:
                    Can't find any matching row in the user table
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Heinrich.Hartl at email.de
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
  Target Milestone: ---

The script fails in in a GRANT command - the user does not exist
This probably is due to changed behaviour of mysql 5.7ff

 From https://dev.mysql.com/doc/refman/5.7/en/grant.html#grant-overview:
Note
If an account named in a GRANT statement does not already exist, GRANT may
create it under the conditions described later in the discussion of the
NO_AUTO_CREATE_USER SQL mode. It is also possible to use GRANT to specify
nonprivilege account characteristics such as whether it uses secure connections
and limits on access to server resources.
However, use of GRANT to create accounts or define nonprivilege characteristics
is deprecated as of MySQL 5.7.6. Instead, perform these tasks using CREATE USER
or ALTER USER.

In my case mysql hosted a koha 16.11 database upgraded to 18.5 and the only
existing user was koha_library@%. There was no user koha_library at localhost.

mysql was running in the version (> 5.7)supplied with ubuntu 16.4 (Xenial).

My solution to the problem was commenting out two lines in the script. 

 diff /usr/sbin/koha-remove /usr/sbin/koha-remove_ori
71c71
< # GRANT USAGE ON \`koha_$name\`.* TO \`koha_$name\`@\`$mysql_hostname\`;
---
> GRANT USAGE ON \`koha_$name\`.* TO \`koha_$name\`@\`$mysql_hostname\`;
73c73
< # DROP USER \`koha_$name\`@\`$mysql_hostname\`;
---
> DROP USER \`koha_$name\`@\`$mysql_hostname\`;
hhl at koha-VM-dev:~ >

For a general solution the koha-remove script should be made more resilient and
should not use deprecated mysql features. Since I am only very occasionally
dealing with mysql and moreover I have no knowledge which user(s) have been
used for koha instances in the past it is beyond my skills to define the proper
revision of the script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 13:49:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 12:49:57 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-XNeY551m1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 13:50:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 12:50:00 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-VBpTfoR46K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83884|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83886&action=edit
Bug 22124: Update cataloguing plugin system to not generate type parameter in
script tag

Test plan:
1) Apply the patch
2) Have defined some cataloguing plugin which generates javascript - for
example dateaccessioned.pl
3) Go to cataloguing/adding item and show source
-> there should be no type parameter in script tag in code added by
cataloguing pulgin
4) prove t/db_dependent/FrameworkPlugin.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:16:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:16:26 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-aNmAJVUZEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 83887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83887&action=edit
Bug 20600: (follow-up) Fix critic error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:17:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:17:28 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-E4LS6HCkgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:18:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:18:02 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-O83SYIkUKk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorted the critic error for you.. setting back to SO

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:33:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:33:34 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-JfVComzGJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #48 from Patrick Robitaille <patrick.robitaille at collecto.ca> ---
Hi, 

Does anyone work on this? The possibility to prioritize cover image sources
would be a usefull add for Koha. 

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:44:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:44:36 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-V0icwEui97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:44:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:44:38 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-njilzMta38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83802|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83888&action=edit
Bug 22102: Markup fixes for OPAC article request page

This patch makes a few improvements to the OPAC article request page:

- Improve the breadcrumbs menu by adding a link to the title
- Add a header with the record's title
- Wrap the "no article requests" message in the correct dialog div
- Remove obsolete CDATA marker

To test, apply the patch and log in to the OPAC

 - Peform a search which will return multiple results
 - Click "Request article" on a title for which article requests can be
   submitted.
   - Confirm that the breadcrumbs menu looks and works correctly.
 - Click "Request article" on a title for which article requsts are not
   allowed.
   - Confirm that the message is correctly styled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:49:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:49:41 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-A73nVOgtLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #41 from Owen Leonard <oleonard at myacpl.org> ---
Thanks for testing Lucas. Did you regenerate the staff client CSS before
testing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 14:58:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 13:58:27 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-hC463ot33q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Thanks for testing Jos?-Mario. Did you regenerate the staff client CSS before
testing? 

https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:00:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:00:42 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-9BYnxGTsvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
Bug 21002 depends on bug 21980, which changed state.

Bug 21980 Summary: Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:00:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:00:42 +0000
Subject: [Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account
	methods
In-Reply-To: <bug-21980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21980-70-GjjXdmdB5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, this will not be backported for 18.11.x at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:00:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:00:43 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
In-Reply-To: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21727-70-XGn0T2waQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Bug 21727 depends on bug 21980, which changed state.

Bug 21980 Summary: Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:00:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:00:56 +0000
Subject: [Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account
	methods
In-Reply-To: <bug-21980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21980-70-5G6r89K0H4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:01:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:01:55 +0000
Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and
	should be removed
In-Reply-To: <bug-21753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21753-70-bxq9ZLL57i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:01:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:01:55 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-b4OfIF20ku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
Bug 21747 depends on bug 21753, which changed state.

Bug 21753 Summary: issuingrules.chargename is unused and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:02:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:02:46 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-JEWbq0ZWdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
Bug 21747 depends on bug 21727, which changed state.

Bug 21727 Summary: Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:02:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:02:45 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
In-Reply-To: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21727-70-IN6WVYUBEY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:03:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:03:48 +0000
Subject: [Koha-bugs] [Bug 22003] Remove unused subroutines displaylog and
 GetLogStatus from in C4::Log
In-Reply-To: <bug-22003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22003-70-DAP3ni6nft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22003

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:04:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:04:22 +0000
Subject: [Koha-bugs] [Bug 22003] Remove unused subroutines displaylog and
 GetLogStatus from in C4::Log
In-Reply-To: <bug-22003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22003-70-Y1rg2qNgsn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22003

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:04:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:04:46 +0000
Subject: [Koha-bugs] [Bug 21569] Switch two-column templates to Bootstrap
 grid: Circulation part 3
In-Reply-To: <bug-21569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21569-70-N9GBblAE0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:04:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:04:46 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-dDlCiEjcEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21569, which changed state.

Bug 21569 Summary: Switch two-column templates to Bootstrap grid: Circulation part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:05:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:05:12 +0000
Subject: [Koha-bugs] [Bug 21963] Switch two-column templates to Bootstrap
 grid: Patrons part 1
In-Reply-To: <bug-21963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21963-70-klFIY0B5Jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21963

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:05:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:05:13 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-IKFjnIswVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21963, which changed state.

Bug 21963 Summary: Switch two-column templates to Bootstrap grid: Patrons part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21963

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:05:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:05:30 +0000
Subject: [Koha-bugs] [Bug 21963] Switch two-column templates to Bootstrap
 grid: Patrons part 1
In-Reply-To: <bug-21963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21963-70-XKhbkacVIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21963

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:06:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:06:06 +0000
Subject: [Koha-bugs] [Bug 19458] Self-check module highlighting
In-Reply-To: <bug-19458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19458-70-Mgi8CHfjDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:07:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:07:45 +0000
Subject: [Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
In-Reply-To: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21912-70-RzglG1rzvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Never a bad idea to increase test coverage... choosing to backport this 'tests
only' patch.

Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:09:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:09:31 +0000
Subject: [Koha-bugs] [Bug 21803] Redesign authorized values interface
In-Reply-To: <bug-21803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21803-70-YhR4U5dmWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:11:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:11:59 +0000
Subject: [Koha-bugs] [Bug 21999] C4::Circulation::AddIssue uses DBIx::Class
	directly
In-Reply-To: <bug-21999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21999-70-MQAZeFLijD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:11:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:11:59 +0000
Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to
 use Koha::Account->add_debit
In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21720-70-AsH0p6esni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720
Bug 21720 depends on bug 21999, which changed state.

Bug 21999 Summary: C4::Circulation::AddIssue uses DBIx::Class directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:12:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:12:31 +0000
Subject: [Koha-bugs] [Bug 21797] Update two-column templates with Bootstrap
 grid: Acquisitions part 5
In-Reply-To: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21797-70-11wG3PzUBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21797

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:12:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:12:31 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-xZ2wnimSlj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21797, which changed state.

Bug 21797 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21797

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:13:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:13:02 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-RwpgwmMnt7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21442, which changed state.

Bug 21442 Summary: Switch two-column templates to Bootstrap grid: Circulation part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:13:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:13:03 +0000
Subject: [Koha-bugs] [Bug 21785] Add column configuration to hold ratios
	report
In-Reply-To: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21785-70-eQfT9PUqVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785
Bug 21785 depends on bug 21442, which changed state.

Bug 21442 Summary: Switch two-column templates to Bootstrap grid: Circulation part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:13:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:13:02 +0000
Subject: [Koha-bugs] [Bug 21442] Switch two-column templates to Bootstrap
 grid: Circulation part 1
In-Reply-To: <bug-21442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21442-70-Jw8qHSx935@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:13:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:13:30 +0000
Subject: [Koha-bugs] [Bug 21785] Add column configuration to hold ratios
	report
In-Reply-To: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21785-70-osdk87iec2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:17:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:17:32 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-KYs4Lam4Pv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|jonathan.druart at bugs.koha-c |oleonard at myacpl.org
                   |ommunity.org                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:25:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:25:32 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-8xgNXbRFyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:25:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:25:35 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-vI3RhqKAgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83889&action=edit
Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl

This patch undoes the changes to addorderiso2709.tt introduced by Bug
19753. The item information tab can include embedded JavaScript for
cataloging plugins, and these don't currently work with JS in the
footer.

To test, apply the patch and test the JavaScript driven features of the
"Add to basket from a staged file" page:

  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - MARC and Card previews, select all/clear all
    - Item information tab: Cataloging plugins for fields like date
      acquired, barcode
    - Default accounting details tab: Show inactive control

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:30:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:30:25 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-6iEVW4hl56@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:32:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:32:25 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-n55S0jq7HN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha.sekjal at gmail.com       |testopia at bugs.koha-communit
                   |                            |y.org
             Status|ASSIGNED                    |NEW
           Assignee|kmkale at anantcorp.com        |oleonard at myacpl.org

--- Comment #49 from Owen Leonard <oleonard at myacpl.org> ---
> Does anyone work on this?

I think the introduction of Coce has solved this problem well enough that there
isn't much demand for more work. However, I agree with Frodolin that it would
be good to make Coce and local cover images work better together.

I'm resetting the "ASSIGNED" status of this because I think it's not actively
being worked on by anyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:40:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:40:16 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-lrUrw9TfSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:40:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:40:46 +0000
Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription
	edit menu
In-Reply-To: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16231-70-Ex26ZeIgzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 15:48:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 14:48:35 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-1iD0ORuyMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
> Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 16:01:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 15:01:10 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-CuZkCTAh6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 16:33:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 15:33:13 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-Zc3POrmgWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #87 from Ere Maijala <ere.maijala at helsinki.fi> ---
Handling of quotes and parenthesis still needs some work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 17:07:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 16:07:04 +0000
Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on
	report output
In-Reply-To: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16149-70-RhauJNUkS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79329|0                           |1
        is obsolete|                            |

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83890&action=edit
Bug 16149: Unit tests

To test:
prove -v t/db_dependent/Reports/Guided.t

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 17:07:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 16:07:08 +0000
Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on
	report output
In-Reply-To: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16149-70-0Fwp0nIwqy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79330|0                           |1
        is obsolete|                            |

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83891&action=edit
Bug 16149: Generate and send custom notices based on report output

Ths patch add an EmailReport function to C4::Reports::Guided

It accepts a notice (module, code, branch) and a report and attempts to
email notices to patron, generating content using report content.

Notice must be in template toolkit syntax, only columns in report are
available for notice.

To test:
1 - Specify various options
2 - Ensure errors are returned if options are incomplete or incorrect
3 - Pass a report containing 'from' and 'email' and 'borrowernumber'
columns and ensure message queue populated as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 17:38:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 16:38:25 +0000
Subject: [Koha-bugs] [Bug 18408] Remainder of title (245$b) in Koha::Biblio
In-Reply-To: <bug-18408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18408-70-KvcNeEuaVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 18:58:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 17:58:00 +0000
Subject: [Koha-bugs] [Bug 16558] Option to choose to include or exclude bibs
 without items when exporting records
In-Reply-To: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16558-70-6WORtSUFmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16558

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Exporting only records with items can be achieved by selecting all libraries.
Exporting only item without items is, I think, not possible yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:08:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:08:09 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-z0NnGryvjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #5 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
I did not, that is surely why it doesn't look right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:29:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:29:42 +0000
Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to
 circulation_rules
In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18925-70-T6OG705c1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

--- Comment #56 from Nick Clemens <nick at bywatersolutions.com> ---
Attempted rebase due to bug 21753 - got tests failures after that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:41:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:41:06 +0000
Subject: [Koha-bugs] [Bug 22129] New: Report 1.3.3 Patrons Whose Age
 Violates Category Age Limits (finds nothing /is faulty)
Message-ID: <bug-22129-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22129

            Bug ID: 22129
           Summary: Report 1.3.3 Patrons Whose Age Violates Category Age
                    Limits (finds nothing /is faulty)
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Heinrich.Hartl at email.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The report is faulty: For MaxAge a value specified correctly in the category is
overidden and replaced by 999. Therefore no violation of MaxAge is found by
this report.
I made a quick and dirty correction:

$ diff Rep*
7c7,8
<    GREATEST ( c.upperagelimit, 999 ) AS MaxAge,
---
> #   GREATEST ( c.upperagelimit, 999 ) AS MaxAge,
>     c.upperagelimit AS MaxAge,

19c20,23
< #   age NOT BETWEEN MinAge AND MaxAge
---
>   age < MinAge or ( age > MaxAge And Maxage > 0 )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:46:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:46:18 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-pSFjnMnLUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:46:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:46:36 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-AMo3P741Yg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83863|0                           |1
        is obsolete|                            |
  Attachment #83864|0                           |1
        is obsolete|                            |
  Attachment #83865|0                           |1
        is obsolete|                            |
  Attachment #83866|0                           |1
        is obsolete|                            |
  Attachment #83867|0                           |1
        is obsolete|                            |
  Attachment #83868|0                           |1
        is obsolete|                            |
  Attachment #83869|0                           |1
        is obsolete|                            |
  Attachment #83870|0                           |1
        is obsolete|                            |
  Attachment #83871|0                           |1
        is obsolete|                            |
  Attachment #83872|0                           |1
        is obsolete|                            |
  Attachment #83873|0                           |1
        is obsolete|                            |
  Attachment #83874|0                           |1
        is obsolete|                            |
  Attachment #83875|0                           |1
        is obsolete|                            |
  Attachment #83876|0                           |1
        is obsolete|                            |
  Attachment #83877|0                           |1
        is obsolete|                            |
  Attachment #83878|0                           |1
        is obsolete|                            |
  Attachment #83879|0                           |1
        is obsolete|                            |
  Attachment #83880|0                           |1
        is obsolete|                            |
  Attachment #83881|0                           |1
        is obsolete|                            |

--- Comment #399 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83892&action=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:47:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:47:21 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-jKTiFaZhTY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #400 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83893&action=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:47:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:47:35 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ge7D4XJdFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #401 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83894&action=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by
number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
    - no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you
anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a
Share button)
- Try to create a new subscription for serial #1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana-KB for more results, enter a few word from title, notes, type of the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake &
comment why you report: click on report mistake. You only can chose "other"
because there's no comment in Mana-KB [if there are comments, you'll get other
values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:47:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:47:45 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-a1rAXZe1UN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #402 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83895&action=edit
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to
prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any
crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the
test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again
on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the
action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:47:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:47:58 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-EalPf6v1BB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #403 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83896&action=edit
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from
Mana.
- Error messages are displayed in case of fail
- Correct the display of sql reports containing "'"
- Importing a report from Mana now opens the edit page
- You don't get message after a successful import from mana (you simply get
redirected)
- Fix an error when cretaing subscription
- Fix mana search
- Correct encoding issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:48:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:48:12 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-DF7bJGdVQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #404 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83897&action=edit
Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema
change, add to kohastructure.sql - Update schema files - Remove javascript
debugger call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:48:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:48:29 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-iIIMKAQNYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #405 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83898&action=edit
Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html
attribute - Remove useless passing of mana_id variable in serials-toolbar.inc -
Remove using CGI::param in list context - remove new subs from
serials/subscription-add.pl - remov

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:48:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:48:38 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-B4WpSMeAYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #406 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83899&action=edit
Bug 17047 - Move ability to comment mana entities from search results table to
report/subscription detail page

+ code refactoring

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:48:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:48:48 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-QJs1CKqEVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #407 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83900&action=edit
Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a
serial Provide a more visible message when sharing a report without note Fix
Internal server error when trying to share a new report Make update DB
idempotent

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:48:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:48:58 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-fZbYo0cjKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #408 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83901&action=edit
Bug 17047 - Fix retrieving Mana token

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:49:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:49:10 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-kqPQ6a0uE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #409 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83902&action=edit
Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and
Subscription.pm - mana.inc included twice

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:49:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:49:22 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-SmXXOowHvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #410 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83903&action=edit
Bug 17047 - Move mana JS and put correct subscription id when sharing

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:49:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:49:33 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ecmPr48LmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #411 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83904&action=edit
Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA
script warnings

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:49:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:49:43 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-4g31DtNrhc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #412 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83905&action=edit
Bug 17047: Koha::SharedContent subs snake casing/renaming

manaRequest           => process_request
manaIncrementRequest  => increment_entity_value
manaPostRequest       => send_entity
prepareSharedData     => prepare_entity_data
manaGetRequestWithId  => get_entity_by_id
manaGetRequest        => search_entities
buildRequest          => build_request
manaUrl               => get_sharing_url

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:49:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:49:54 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-8UbTH8QDu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #413 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83906&action=edit
Bug 17047: add a dedicated page for Mana setup

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:50:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:50:06 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-3LXHxqySXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #414 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83907&action=edit
Bug 17047: [DO NOT PUSH] provide staff-global.css

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:50:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:50:15 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-s950xnhkbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #415 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83908&action=edit
Bug 17047: [DO NOT PUSH] provides schema files

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:50:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:50:24 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-0SVCEsshDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #416 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83909&action=edit
Bug 17047: Fix reports sharing

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:50:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:50:32 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ILLt20UugG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #417 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83910&action=edit
Bug 17047: [QA tool] add template filters

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:50:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:50:48 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ljIujjKcbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #418 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83911&action=edit
Bug 17047 [QA Followup] - Fixes to make unit tests pass

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:51:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:51:05 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-F6SgIRg8Tr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #419 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83912&action=edit
Bug 17047 [QA Followup] - Don't enable by default

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 19:53:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 18:53:24 +0000
Subject: [Koha-bugs] [Bug 22130] New: Batch checkout : authorized value
 description is never shown with notforloan status.
Message-ID: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130

            Bug ID: 22130
           Summary: Batch checkout : authorized value description is never
                    shown with notforloan status.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: pierre-marc.thibault at inlibro.com
          Reporter: pierre-marc.thibault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com,
                    philippe.blouin at inlibro.com
  Target Milestone: ---

There is an error when document status is shown. When the text information is
"Item is normally not for loan", the text in brackets is always the authorized
value even if there is a description for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:16:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:16:39 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-2hsDxJljxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68840|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:16:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:16:43 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-gPgrKER1lB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68841|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:16:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:16:46 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-SC2M0sTZy4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69508|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:16:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:16:49 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-9zfq5akKKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68839|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:18:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:18:48 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-5bNXPGIvoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #32 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83913&action=edit
Bug 16497: Add /api/v1/libraries

CRUD for libraries via REST API.

GET    /api/v1/libraries              - List all libraries
GET    /api/v1/libraries/{branchcode} - Get one Library
POST   /api/v1/libraries              - Add new Library
DELETE /api/v1/libraries/{branchcode} - Delete Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:18:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:18:52 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-KaSepiNcXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #33 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83914&action=edit
Bug 16497: Add missing field in definitions due to bug 18066

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:18:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:18:57 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-IInBkBZSmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #34 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83915&action=edit
Bug 16497: (follow-up) New column marcorgcode added

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:19:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:19:02 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-AU8KR3PYg4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #35 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83916&action=edit
Bug 16497: Add POD in Koha/REST/V1/Library.pm

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:19:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:19:07 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-NoIk5Xvh2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #36 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83917&action=edit
Bug 16497: (follow-up) Adapt to existing guidelines and RFC

This patch makes the original implementation match what is specified on
the RFC [1].

The controller is updated, and so the tests.

To test:
- Apply this patches:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/libraries.t
=> SUCCESS: Tests pass!

[1] https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:21:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:21:46 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-BgrwWVeou2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #37 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I've just implemented what I mentioned on comment 31. The attributes got
adapted to the voted RFC and the implementation now is more in line with the
current practices we adopted.

I'm setting it NSO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:22:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:22:04 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-fzVeJTxYNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|tomascohen at gmail.com        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:24:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:24:05 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-88GPS9noia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add routes to list          |Add API routes for
                   |libraries                   |libraries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:31:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:31:17 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-TyMt308w5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alex.arnaud at biblibre.com    |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 20:45:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 19:45:59 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-ohgJbkuHTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

felicia.martin at dncr.nh.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |felicia.martin at dncr.nh.gov
     Who signed the|                            |Felicia Martin
          patch off|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:03:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:03:46 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
 homebranch, holding branch or both for library groups in advanced search
In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21249-70-QDN0t0RZuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Brian <bklein at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bklein at dubuque.lib.ia.us

--- Comment #12 from Brian <bklein at dubuque.lib.ia.us> ---
Any updates on bug 21249?

Carnegie team

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:35:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:35:13 +0000
Subject: [Koha-bugs] [Bug 21562] Sorting on checkout date is broken
In-Reply-To: <bug-21562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21562-70-6uIozzGsHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18396 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:35:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:35:13 +0000
Subject: [Koha-bugs] [Bug 18396] UK format dates not sorting correctly
In-Reply-To: <bug-18396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18396-70-Cm5JgyNYCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18396

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The checkouts table checkout date sorting issue was fixed by bug 21562.

*** This bug has been marked as a duplicate of bug 21562 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:47:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:47:38 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-hWIglToNax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:47:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:47:42 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-xUyHKPxrjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83918&action=edit
Bug 17347: Ignore whitespace before and after on renewing

When an item is checked out, Koha ignores whitespace
at the beginning and the end of the entered barcode.
This makes life easier, if a barcode is C&P from another
page. This patch makes the renewal page behave the same.

To test:
- Checkout an item
- Renew the item from the renew tab or renewal page
  entering the barcode with leading and trailing
  whitespace
- "Barcode not found"
- Apply patch
- Try again
- Barcode should be found now

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:48:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:48:20 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-EKWjhslpMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 21:49:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 20:49:44 +0000
Subject: [Koha-bugs] [Bug 7040] Public note should show when placing item
 level holds in staff
In-Reply-To: <bug-7040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7040-70-dRWmTYnkOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7040

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Filed this bug ages ago - I know the answer now: The empty holds column is the
holds note, so it's all correct :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:24:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:24:39 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-WpDhU2dYol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:32:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:32:55 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-GgQ2cNNrtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:32:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:32:59 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-MNCn0Zp6kJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83919&action=edit
Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds

Patch makes use fo patron-string.inc for displaying the patron information
on the waiting holds report.

It also adds spans with classes for phone and email.

To Test:
1 - View the holds awaiting pickup report
2 - Note there is no cardnumber for the patron
3 - Apply patch
4 - Cardnumber shows now
5 - Verify the same works for 'Holds over' tab

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:08 +0000
Subject: [Koha-bugs] [Bug 21840] Fix some typos in the templates
In-Reply-To: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21840-70-jH9BZ4Mrvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |olivialokm at gmail.com
                 CC|                            |olivialokm at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:15 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-DiccAUKJt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jke0429 at stacmail.net
                 CC|                            |jke0429 at stacmail.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:15 +0000
Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of
	category limits
In-Reply-To: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17492-70-qSKd9sEVoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.amohia at gmail.com
           Assignee|rbit at rbit.cz                |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:18 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-W8kqVYCaHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:21 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-AK7505NKmq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mackeyfj at gmail.com
                   |ity.org                     |
                 CC|                            |mackeyfj at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:23 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-b9A9iSUKoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivialokm at gmail.com
           Assignee|oleonard at myacpl.org         |olivialokm at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:24 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-7tHThzNWlA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |hickeyhe at wgc.school.nz
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:33:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:33:31 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-hpIkkkAq9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69612|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:38:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:38:50 +0000
Subject: [Koha-bugs] [Bug 18838] Add a list without name in OPAC
In-Reply-To: <bug-18838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18838-70-WvNTMMgJu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:39:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:39:47 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-LUyAUKBHM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jke0429 at stacmail.net        |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:41:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:41:46 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-WQYqPQM5Ls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jke0429 at stacmail.net
           Assignee|koha-bugs at lists.koha-commun |jke0429 at stacmail.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 22:49:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 21:49:42 +0000
Subject: [Koha-bugs] [Bug 2069] Label Example Image
In-Reply-To: <bug-2069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2069-70-HoKf3ZJM1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2069

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|Templates                   |Documentation

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 23:05:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 22:05:42 +0000
Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables
In-Reply-To: <bug-14027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14027-70-6XGrQn8jVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|BLOCKED                     |RESOLVED

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This functionality was added with another bug now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 23:05:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 22:05:42 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-dmZOrjgZQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427
Bug 6427 depends on bug 14027, which changed state.

Bug 14027 Summary: Add TableTools plugin for DataTables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 23:12:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 22:12:11 +0000
Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules
In-Reply-To: <bug-8366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8366-70-TOC23le73N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but I don't understand the difference for itemtypes.
We've had no issues with the terms here so far. Currently Koha uses "All".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 14 23:42:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 22:42:07 +0000
Subject: [Koha-bugs] [Bug 22131] New: overdue_notice.pl and
 gather_print_notices.pl should honor letter.is_html
Message-ID: <bug-22131-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22131

            Bug ID: 22131
           Summary: overdue_notice.pl and gather_print_notices.pl should
                    honor letter.is_html
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
  Target Milestone: ---

At present, overdue_notice.pl requires the command line flag '--html' to be
present in order to render overdue notices as html. This causes a lot of
confusion among users -- they check the 'html' check box, and nothing happens.

I'm not *exactly* sure what the behavior of gather_print_notices.pl is, but it
has an '--html' flag, so we should look at that as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 00:08:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 23:08:51 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-hB32LFNZhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivialokm at gmail.com
           Assignee|oleonard at myacpl.org         |olivialokm at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 00:09:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 23:09:29 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-MLw0pucqHM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|katrin.fischer at bsz-bw.de    |olivialokm at gmail.com
                 CC|                            |olivialokm at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 00:11:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 23:11:03 +0000
Subject: [Koha-bugs] [Bug 21444] Permanent location should show with cart
 location - returns.pl
In-Reply-To: <bug-21444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21444-70-oddr1Q9gHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivialokm at gmail.com
           Assignee|cbrannon at cdalibrary.org     |olivialokm at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 00:13:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 23:13:11 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-aDOUGoHZPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Jack Kelliher <jke0429 at stacmail.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 00:13:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 23:13:25 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-60APBlMySh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83838|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 00:13:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Jan 2019 23:13:33 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-WnIV9Naske@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 83920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83920&action=edit
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:36:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:36:09 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-QPrASOSJjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mackeyfj at gmail.com
           Assignee|olivialokm at gmail.com        |mackeyfj at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:56:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:56:37 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-RDCyMjSVZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|katrin.fischer at bsz-bw.de    |hickeyhe at wgc.school.nz
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:57:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:57:04 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-Th77k9WFNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivialokm at gmail.com
           Assignee|katrin.fischer at bsz-bw.de    |olivialokm at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:56:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:56:42 +0000
Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page
In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21948-70-KqXa3SMeor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |ethan.amohia at gmail.com
                 CC|                            |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:58:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:58:15 +0000
Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page
In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21948-70-LmGNcRHl45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ethan.amohia at gmail.com      |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:58:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:58:22 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-iFOQy7jh1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mackeyfj at gmail.com          |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:58:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:58:29 +0000
Subject: [Koha-bugs] [Bug 21444] Permanent location should show with cart
 location - returns.pl
In-Reply-To: <bug-21444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21444-70-PQndZjT5dA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|olivialokm at gmail.com        |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:58:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:58:31 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-oWrmbmZsoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olivialokm at gmail.com        |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 01:58:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 00:58:11 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-kpLSjzrUr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|hickeyhe at wgc.school.nz      |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 02:06:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 01:06:31 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-hiyZcaj2PQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
Bug 22112 depends on bug 22111, which changed state.

Bug 22111 Summary: Correctly format fines when placing holds (maxoutstanding warning)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 02:06:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 01:06:31 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-NThr6fQPUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.amohia at gmail.com
         Resolution|---                         |FIXED
             Status|Needs Signoff               |RESOLVED

--- Comment #3 from Ethan <ethan.amohia at gmail.com> ---
I believe these changes have already been made, this is the message I got when
I tried to test. Setting to resolved

$ git bz apply 22111
Bug 22111 - Correctly format fines when placing holds (maxoutstanding warning)

83832 - Bug 22111: Format price on place holds place when maxoutstanding is
reached
83837 - Bug 22111: Format amount shown on place holds when maxoutstanding is
reached (staff)

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22111: Format price on place holds place when maxoutstanding is
reached
Applying: Bug 22111: Format amount shown on place holds when maxoutstanding is
reached (staff)
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:08:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:08:17 +0000
Subject: [Koha-bugs] [Bug 22119] Add price formatting in circulation
In-Reply-To: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22119-70-d1CscRgAJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:08:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:08:19 +0000
Subject: [Koha-bugs] [Bug 22119] Add price formatting in circulation
In-Reply-To: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22119-70-cHPk6pYlxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83839|0                           |1
        is obsolete|                            |

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 83921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83921&action=edit
Bug 22119: Add price formatting in more places in circulation

This adds some missing Price filters to some places in circulation.
To check verify the amount are displayed according to setting
of CurrencyFormat (use FR or CH for seeing a change)

Use a patron account with no pending fines at the beginning
for all tests.

1)
- Switch RentalFeesCheckoutConfirmation to "Ask"
- Check out an item with a rental charge
- Verify message is formatted correctly:
  Rental charge for this item: ...

2)
- Switch RentalsInNoissuesCharge to "Don't include"
- Make sure patron has only Rental fines on their account
- Check out another item
- Verify message is formatted correctly:
  The patron has unpaid charges for holds, rentals etc ...

3)
- Switch BatchCheckouts to "Allow"
- Add the patron category of your test patron to BatchCheckoutsValidCategories
- Checkout any item
- Verify the message in the information column is formatted correctly:
  The patron has unpaid charges for holds, rentals etc of ...

Signed-off-by: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:17:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:17:40 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-lxGcPOV5sY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:17:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:17:42 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-7BM0Zw9iD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83836|0                           |1
        is obsolete|                            |

--- Comment #2 from Jack <jke0429 at stacmail.net> ---
Created attachment 83922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83922&action=edit
Bug 22116: Add price formatting to rental charge and replacement price on items
tab in staff

Adds formatting to replacement price and rental charge on items
tab.

To test:
- Add a rental charge to one or more of your item types
- Edit a record with some items, add replacement cost to some
- Find or create a record with your rental charged itemtype (MARC21:942$c)
- Go to the staff detail page of those records
- Check "Items" tab for
  - Rental charge on top
  - Replacement price for items
- Verify information is displayed correctly when toggling CurrencyFormat
  system preference

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:23:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:23:39 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-KBAS7jtvXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:23:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:23:42 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-yUxBcdSC21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83835|0                           |1
        is obsolete|                            |

--- Comment #2 from Olivia <olivialokm at gmail.com> ---
Created attachment 83923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83923&action=edit
Bug 22113: Add price formatting on item lost report

The item lost report displays the price and replacement
price for lost items. With the patch they will display
according to the CurrencyFormat system preference.

To test:
- Mark 1 or more items lost
- Make sure that replacement cost and purchase price are set
- Go to Reports > Items lost
- Search for your lost items
- Verify price and replacement price display
- Apply patch and toggle CurrencyFormat to different settings
- Refresh lost items report
- Verify prices are always displayed according to syspref setting

Signed-off-by: Olivia Lu <olivialokm at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:24:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:24:12 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-zjrGhRBEyA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:24:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:24:19 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-sWjoIOZ0eR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80612|0                           |1
        is obsolete|                            |

--- Comment #2 from Mackey Johnstone <mackeyfj at gmail.com> ---
Created attachment 83924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83924&action=edit
Bug 21573: Move lists barcode and biblionumber entry form to modal

This patch modifies the staff client lists page so that the
barcode/biblionumber entry form from the left hand sidebar into a modal
window, triggered by a button in the toolbar.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - View the contents of a list in the staff client, logged in as a user
   who has permission to add items.
 - Click the "Add items" button. A modal window should appear with the
   barcode/biblionumber entry form.
 - Submit barcodes and/or biblionumbers and confirm that the correct
   titles are added to the list.
 - Log in again as a user who does not have permission to add to the
   list. Confirm that the button isn't present.

Signed-off-by: Mackey Johnstone <mackeyfj at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:25:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:25:57 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-ks9rdED419@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from helene <hickeyhe at wgc.school.nz> ---
When I change the currency format it doesn't change in the checkout table.
However is changing in other places on the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:28:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:28:43 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-ViUg25T6Pk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:28:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:28:45 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-3Fwj7IzlFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83840|0                           |1
        is obsolete|                            |

--- Comment #3 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 83925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83925&action=edit
Bug 22120: Add price formattig to patron summary print

The patron summary print lists the replacement prices
and rental charges of items and totals them. With this
patch they will be formatted according to the
CurrencyFormat system preference.

To test:
- Find or create a patron with some checkouts
- Make sure some items have replacement price set
  and some have a rental charge
- "Print summary" from the account in staff
- Verify that charges and prices in the checkouts
  table are formatted correctly
- Toggle CurrencyFormat to different settings

Signed-off-by: helene hickey <hickeyhe at wgc.school.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:29:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:29:52 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-obTRh4fEIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83925|0                           |1
        is obsolete|                            |

--- Comment #4 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 83926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83926&action=edit
Bug 22120: Add price formattig to patron summary print

The patron summary print lists the replacement prices
and rental charges of items and totals them. With this
patch they will be formatted according to the
CurrencyFormat system preference.

To test:
- Find or create a patron with some checkouts
- Make sure some items have replacement price set
  and some have a rental charge
- "Print summary" from the account in staff
- Verify that charges and prices in the checkouts
  table are formatted correctly
- Toggle CurrencyFormat to different settings

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 03:30:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 02:30:32 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-rumZ1t6UWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from helene <hickeyhe at wgc.school.nz> ---
Sorry was meant to set to Failed QA as this didn't test as planned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:06:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:06:35 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-2Q9cRaJROC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:06:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:06:38 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-IRO3AbfbOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

--- Comment #1 from Mackey Johnstone <mackeyfj at gmail.com> ---
Created attachment 83927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83927&action=edit
Bug 21637: Fixed upercase letter in EasyAnalyticalRecords syspref

Changed 'Don't Display' to 'Don't display' for the
EasyAnalyticalRecords options.

To find fix:

1.Be loged in as a user who can access sys prefrences.

2.Go to:
Koha Administration > Global System Preferences > Cataloging >
Interface.

3.Confirm that the dropdown option for EasyAnalyticalRecords is now
'Don't display'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:09:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:09:02 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-eAehfDgxbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:09:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:09:06 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-nJ8OQVsKqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

--- Comment #1 from Jack <jke0429 at stacmail.net> ---
Created attachment 83928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83928&action=edit
BUG 22011: Fixed Typo on batchMod-edit.tt

1. Navigate to tools, then batch item modification.
2. Input a valid barcode into the barcode list input field, and press
continue.
3. Under the Edit items heading, text should display "Checking the box
right next the subfield ..."
4. Apply patch and refresh page, text should now display "Checking the
box right next to the subfield ..."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:18:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:18:19 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-6N150VNYBt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jke0429 at stacmail.net
           Assignee|koha-bugs at lists.koha-commun |jke0429 at stacmail.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:27:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:27:35 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-khm9vyRdFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:27:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:27:38 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-AaymiG4ViO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

--- Comment #1 from Olivia <olivialokm at gmail.com> ---
Created attachment 83929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83929&action=edit
Bug 20165 : Changed uppercase letter to a lowercase letter in the patron search
search fields under the plus option.

Changed "Street Address" to "Street address" in the patron search search
fields under the plus sign to fit Koha's capitalization rules.

To find this change:

1. Go to Patrons and switch in the search to search patrons
2. Click on the plus sign
3. Check "Search fields" pull down
4. "Street Address" should now be "Street address"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:36:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:36:15 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-fZxXmVq2LY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:36:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:36:18 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-9dhxojflho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

--- Comment #2 from Jack <jke0429 at stacmail.net> ---
Created attachment 83930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83930&action=edit
BUG 21930: Reworded message on permissions.inc

1. Go to patrons account, more, Set Permissions.
2. Dropdown the Parameters section.
3. Text should display "If not set the logged in user could only edit
circulation rules for its the own library (please note that
        manage_circ_rules is still required)"
4. Apply patch and reload page
5. Text should now display "Edit circulation rules from any library. If
not set the logged in user could only edit circulation rules for their
own library (please note that manage_circ_rules is still required)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:40:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:40:44 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-Rgsh5maxtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jke0429 at stacmail.net
           Assignee|koha-bugs at lists.koha-commun |jke0429 at stacmail.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:48:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:48:29 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-kpX6gOvY68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83841|0                           |1
        is obsolete|                            |

--- Comment #2 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 83931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83931&action=edit
Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat
pref

To test:
- Install BLDSS backend
  see: https://wiki.koha-community.org/wiki/ILL_backends
- Add a new BLDSS ILL request
- Edit ILL request
- Fill in Price paid field
- Verify Price paid is formatted correctly on 'Manage ILL request'
  page

Signed-off-by: Ethan Amohia <ethan.amohia at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:49:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:49:12 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-LutGrsLkWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:49:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:49:15 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-JFcQwCbDSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 83932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83932&action=edit
Bug 22036: Indented code where '^I' was written rather than an indent.

Code was previously written with '^I' where an indent was supposed to
be. I deleted all '^I's and replaced them with indents.

To find this change:
Look at the tags/review.pl file and confirm indentation is correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 04:49:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 03:49:33 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-m7X10FfhpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.amohia at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 05:01:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 04:01:16 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-cfSnqdPXe9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

--- Comment #1 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 83933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83933&action=edit
Bug 22054: Updated the error message for attempting to renew an onsite checkout

To test:

1) Enable OnSiteCheckouts system preference
2) Checkout an item checking the onsite checkout checkbos in more
options
3) Go to circulation > pending on-site checkouts
4) Verify the checkout shows
5) Go to circulation > renew
6) Try to renew the on-site checkout using the barcode
7) Verify display:

onsite_checkout  Continue without renewing

8) apply the patch and reload page with error message
9) verify display:

Item cannot be renewed because it's an onsite checkout

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 05:02:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 04:02:41 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-8ika7Yw6kJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 05:02:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 04:02:44 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-hSU0c6qQrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

--- Comment #1 from Olivia <olivialokm at gmail.com> ---
Created attachment 83934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83934&action=edit
Bug 21866: Changed "report" to "plugins" for the warning "This report was
written for an older version of Koha. Run at your own risk"

To find this change:

1. Enable use plugins in global system preferences
2. Go to tools then click tool plugins
3. Verify that this string now says plugins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 06:35:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 05:35:14 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-zF3sd6bTZ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83927|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 83935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83935&action=edit
Bug 21637: Fixed upercase letter in EasyAnalyticalRecords syspref

Changed 'Don't Display' to 'Don't display' for the
EasyAnalyticalRecords options.

To find fix:

1.Be loged in as a user who can access sys prefrences.

2.Go to:
Koha Administration > Global System Preferences > Cataloging >
Interface.

3.Confirm that the dropdown option for EasyAnalyticalRecords is now
'Don't display'

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 06:36:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 05:36:26 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-VEZbVnEIEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 06:55:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 05:55:42 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-Om5XU6Lnfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Olivia, please leave assignee as the patch writer. If you change by
accident, you can see it it looking at "History" or looking at the author line
of the patch. Thx for your sign off! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:08:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:08:47 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-WXRTvI4KAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83936&action=edit
PDF of "Print summary"

Hi Helene,
I just tested again and it look ok for me (see attached PDF). Could you try
again and make sure you restarted Plack? (restart_all on kohadevbox) If it
still doesn't look right, can you maybe upload a screenshot or printed PDF or
describe it a bit more?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:09:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:09:11 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-8Ba7WEXeuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:09:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:09:59 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-g8oNSrvR5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olivialokm at gmail.com        |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:11:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:11:19 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-FIa5p8f16O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:12:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:12:09 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-Ii6ti4CD8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83832|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:14:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:14:07 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-ssI6Clupsq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Ethan,

thx for testing! This was my fault. When I attached a second version of the
patch with a changed commit message, I forgot to obsolete the first one. So
when you tried to test it applied both and the second caused the warning as the
change was the same in both.

Could you please try again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:14:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:14:08 +0000
Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
In-Reply-To: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22112-70-7ehqFUB7Bw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112
Bug 22112 depends on bug 22111, which changed state.

Bug 22111 Summary: Correctly format fines when placing holds (maxoutstanding warning)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:14:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:14:13 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-FVmdJbE0m0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:16:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:16:20 +0000
Subject: [Koha-bugs] [Bug 22116] Add price formatting to rental charge and
 replacement price on items tab in staff
In-Reply-To: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22116-70-WsFQYPjuPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Jack!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:16:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:16:40 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-jH1jEhK2ae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:17:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:17:14 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-PjVj8nmNFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Ethan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:16:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:16:54 +0000
Subject: [Koha-bugs] [Bug 22119] Add price formatting in circulation
In-Reply-To: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22119-70-dPRpZoaeaO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Jasmine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:24:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:24:03 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-5jevIP7cz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83924|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83937&action=edit
Bug 21573: Move lists barcode and biblionumber entry form to modal

This patch modifies the staff client lists page so that the
barcode/biblionumber entry form from the left hand sidebar into a modal
window, triggered by a button in the toolbar.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - View the contents of a list in the staff client, logged in as a user
   who has permission to add items.
 - Click the "Add items" button. A modal window should appear with the
   barcode/biblionumber entry form.
 - Submit barcodes and/or biblionumbers and confirm that the correct
   titles are added to the list.
 - Log in again as a user who does not have permission to add to the
   list. Confirm that the button isn't present.

Signed-off-by: Mackey Johnstone <mackeyfj at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:23:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:23:59 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-PtLf058lvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:24:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:24:47 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-HePnPtgFPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Mackey!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:27:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:27:45 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-9gXOLCJIy2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83935|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83938&action=edit
Bug 21637: Fixed upercase letter in EasyAnalyticalRecords syspref

Changed 'Don't Display' to 'Don't display' for the
EasyAnalyticalRecords options.

To find fix:

1.Be loged in as a user who can access sys prefrences.

2.Go to:
Koha Administration > Global System Preferences > Cataloging >
Interface.

3.Confirm that the dropdown option for EasyAnalyticalRecords is now
'Don't display'

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:30:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:30:19 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-mw3Ccjn350@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:30:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:30:23 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-VQJvDlvigD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83938|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 83939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83939&action=edit
Bug 21637: Fixed upercase letter in EasyAnalyticalRecords syspref

Changed 'Don't Display' to 'Don't display' for the
EasyAnalyticalRecords options.

To find fix:

1.Be loged in as a user who can access sys prefrences.

2.Go to:
Koha Administration > Global System Preferences > Cataloging >
Interface.

3.Confirm that the dropdown option for EasyAnalyticalRecords is now
'Don't display'

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:33:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:33:04 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-FXVkxG47sd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mackey, congrats on your first patch!

Small thing: Your original patch had an incomplete author line, reading:
From: Your Full Name <your_email>
I've fixed that while doing QA to:
Author: Mackey Johnstone <mackeyfj at gmail.com>

Hope, that's ok!

You can fix this in your git settings with the following commands:

git config --global user.name "your NAME"
git config --global user.email "your at mail.com"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:35:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:35:20 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-UVO2jpSgR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Switching to "Needs Signoff".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:47:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:47:23 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-SogT0alkb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83928|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 83940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83940&action=edit
BUG 22011: Fixed Typo on batchMod-edit.tt

1. Navigate to tools, then batch item modification.
2. Input a valid barcode into the barcode list input field, and press
continue.
3. Under the Edit items heading, text should display "Checking the box
right next the subfield ..."
4. Apply patch and refresh page, text should now display "Checking the
box right next to the subfield ..."

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:49:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:49:19 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-NegprxCdOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 07:59:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 06:59:21 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-9GqJps6WSq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #50 from David Cook <dcook at prosentient.com.au> ---
I'm interested in the outcome but don't have the time to work on this :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 10:11:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 09:11:50 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-FV0Q51YFT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Hi Olivia.

I couldn't get your patch to work.

I think line 53 needs to be changed as well:

53   <option value='address'>Street Address</option>

David Nind

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 10:48:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 09:48:48 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-aytSO5qphS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

--- Comment #9 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 83941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83941&action=edit
Bug 19661 - Add and change properties and parameters to conform to the funds
RFC.

Also, perform an exact search when searching on the fund owner id.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 10:51:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 09:51:19 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-3ozQg1YTL2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:36:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:36:19 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-4xN39XS8Lu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
To check the current and updated wording:
1. Go to the Patrons screen
2. Search or browse for a patron
3. Click on the link for the patron's name in the Name column (result: should
end on the details screen for the patron)
4. From the buttons above the patron name select More > Set permissions
5. Expand the list of options under (parameters) Manage Koha system settings
(Administration panel)

(Note: I've only added this as I'm not familiar with the patrons area and it
took me ages to find where this was ...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:43:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:43:45 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-fm1lyIaoWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Matthias Meusburger from comment #9)
> Created attachment 83941 [details] [review]
> Bug 19661 - Add and change properties and parameters to conform to the funds
> RFC.
> 
> Also, perform an exact search when searching on the fund owner id.

Matthias, great work. I would like to mention I'm proposing a change here:

https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API

basically standardize return codes and add the Location header in POST (see bug
16497 for an example).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:44:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:44:08 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-7dY7tgcixd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

--- Comment #4 from David Nind <david at davidnind.com> ---
Note: I prefer Katrin's wording, but I don't know whether I understand what
exactly is required for the wording, except to remove 'the':

"Manage circulation rules from any library. If not set the logged in user can
only edit circulation rules from their own library (please note that
manage_circ_rules is still required)."

Should 'from' in both occurences be 'for'?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:44:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:44:45 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-ZwRGEjA2kd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83930|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 83942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83942&action=edit
BUG 21930: Reworded message on permissions.inc

1. Go to patrons account, more, Set Permissions.
2. Dropdown the Parameters section.
3. Text should display "If not set the logged in user could only edit
circulation rules for its the own library (please note that
        manage_circ_rules is still required)"
4. Apply patch and reload page
5. Text should now display "Edit circulation rules from any library. If
not set the logged in user could only edit circulation rules for their
own library (please note that manage_circ_rules is still required)"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:45:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:45:13 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-5vZA2WGIBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:56:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:56:34 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-DvEUM9ySYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #43 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 83106
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83106
Bug 11529: Clean up subtitle usage

Review of attachment 83106:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11529&attachment=83106)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/js/checkouts.js
@@ +244,3 @@
>                          });
>  
> +                        title += " " + oObj.part_number + " " + oObj.part_name;

If there is no part_number or part_name, there is "null" string shown in UI

@@ +601,3 @@
>                              });
>  
> +                            title += " " + oObj.part_number + " " + oObj.part_name;

If there is no part_number or part_name, there is "null" string shown in UI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 11:57:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 10:57:25 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-cnYe8f2kLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:09:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:09:23 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-uTkoKZoyvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #38 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83943&action=edit
Bug 22125: branches.pickup_location should be flagged as boolean

This trivial patch just marks the mentioned column as a boolean.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:11:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:11:03 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-e4dtt7rXfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83943|0                           |1
        is obsolete|                            |

--- Comment #39 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 83943
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83943
Bug 22125: branches.pickup_location should be flagged as boolean

Sorry, wrong bug number

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:11:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:11:26 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-6xbTVmIomg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:11:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:11:29 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-iWKT6Tui7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83883|0                           |1
        is obsolete|                            |

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83944&action=edit
Bug 22125: branches.pickup_location should be flagged as boolean

This trivial patch just marks the mentioned column as a boolean.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:11:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:11:47 +0000
Subject: [Koha-bugs] [Bug 22132] New: Add Basic authentication
Message-ID: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

            Bug ID: 22132
           Summary: Add Basic authentication
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

It would help testing using tools like Postman or Rested easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:24:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:24:06 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-n9kdgaHT3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83913|0                           |1
        is obsolete|                            |
  Attachment #83914|0                           |1
        is obsolete|                            |
  Attachment #83915|0                           |1
        is obsolete|                            |
  Attachment #83916|0                           |1
        is obsolete|                            |
  Attachment #83917|0                           |1
        is obsolete|                            |

--- Comment #40 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83945&action=edit
Bug 16497: Add /api/v1/libraries

CRUD for libraries via REST API.

GET    /api/v1/libraries              - List all libraries
GET    /api/v1/libraries/{branchcode} - Get one Library
POST   /api/v1/libraries              - Add new Library
DELETE /api/v1/libraries/{branchcode} - Delete Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:24:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:24:10 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-26KRKaQGs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #41 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83946&action=edit
Bug 16497: Add missing field in definitions due to bug 18066

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:24:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:24:14 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-59YFhR5wQb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #42 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83947&action=edit
Bug 16497: (follow-up) New column marcorgcode added

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:24:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:24:18 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-OSV1ka9rnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #43 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83948&action=edit
Bug 16497: Add POD in Koha/REST/V1/Library.pm

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:24:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:24:02 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-zevznMvVdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:24:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:24:22 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-DJDA4JNlDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #44 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83949&action=edit
Bug 16497: (follow-up) Adapt to existing guidelines and RFC

This patch makes the original implementation match what is specified on
the RFC [1].

The controller is updated, and so the tests.

To test:
- Apply this patches:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/libraries.t
=> SUCCESS: Tests pass!

[1] https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:26:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:26:02 +0000
Subject: [Koha-bugs] [Bug 22133] New: Wrong layout in OAI-PMH:archiveID
 syspref description
Message-ID: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

            Bug ID: 22133
           Summary: Wrong layout in OAI-PMH:archiveID syspref description
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

It looks like this:

"Identify records at this site with the prefix | KOHA-OAI-TEST | : ."

the colon shouldn't be there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:26:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:26:38 +0000
Subject: [Koha-bugs] [Bug 18102] REST API: Add pickup_location to library's
 Swagger definition
In-Reply-To: <bug-18102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18102-70-Xr7447Gfzs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18102

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |josef.moravec at gmail.com
             Status|NEW                         |RESOLVED

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Last follow-up added this to bug 16497

*** This bug has been marked as a duplicate of bug 16497 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:26:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:26:12 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-9Ls9koeVFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
           Assignee|oleonard at myacpl.org         |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:26:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:26:38 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-0t13qZO8Ou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #45 from Josef Moravec <josef.moravec at gmail.com> ---
*** Bug 18102 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:30:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:30:33 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-UFY2wulVTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:30:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:30:37 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-7DaM62wKOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83950&action=edit
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description

This patch fixes a trivial text layout problem on the syspref
description.

To test:
- Search for the OAI-PMH:archiveID syspref on the staff interface
=> FAIL: Notice the colon is placed *after* the input, and looks weird.
- Apply this patch
- Reload the page
=> SUCCESS: The colon is placed *before* the input, and looks more
correct.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:55:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:55:54 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-Bg85hBERSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:55:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:55:59 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-ycTCLK0QfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83781|0                           |1
        is obsolete|                            |

--- Comment #88 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83951&action=edit
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
     using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
     verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
     option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
     added to the item tags as appropriate. It should show some
     combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
     "Withdrawn", "In Transit", or "On Hold" as appropriate, or
     "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
     "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
     "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
     descriptions are used instead of the default values above.

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:04 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-NwuyNsCD5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83782|0                           |1
        is obsolete|                            |

--- Comment #89 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83952&action=edit
Bug 13937: (follow-up) Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this sub is built into fetch and this call is a duplicate

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:09 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-ckeK9NJyXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83783|0                           |1
        is obsolete|                            |

--- Comment #90 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83953&action=edit
Bug 13937: (follow-up) Correct error call to use self

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:14 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-yZqvKKD8qD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83784|0                           |1
        is obsolete|                            |

--- Comment #91 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83954&action=edit
Bug 13937: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:19 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-UODPYetaRz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83785|0                           |1
        is obsolete|                            |

--- Comment #92 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83955&action=edit
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:24 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-9LEpqGbEYk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83786|0                           |1
        is obsolete|                            |

--- Comment #93 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83956&action=edit
Bug 13937: Fix issues found in QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:29 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-kytkisYXzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83787|0                           |1
        is obsolete|                            |

--- Comment #94 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83957&action=edit
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:36 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-MibfeDsJhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83788|0                           |1
        is obsolete|                            |

--- Comment #95 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83958&action=edit
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 12:56:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 11:56:41 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-SFWsC0ONLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #96 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83959&action=edit
Bug 13937: Fix RPN conversion

Fixes handling of quotes and parenthesis.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:07:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:07:05 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-xIK0yD58yQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83933|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 83960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83960&action=edit
Bug 22054: Updated the error message for attempting to renew an onsite checkout

To test:

1) Enable OnSiteCheckouts system preference
2) Checkout an item checking the onsite checkout checkbos in more
options
3) Go to circulation > pending on-site checkouts
4) Verify the checkout shows
5) Go to circulation > renew
6) Try to renew the on-site checkout using the barcode
7) Verify display:

onsite_checkout  Continue without renewing

8) apply the patch and reload page with error message
9) verify display:

Item cannot be renewed because it's an onsite checkout

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:07:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:07:57 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-qBts2pA8da@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:26 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-N9CHwqjpVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:35 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-S6I4iQWjl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83104|0                           |1
        is obsolete|                            |

--- Comment #45 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83962&action=edit
Bug 11529: Use new biblio fields whenever possible

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:39 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-G7k4885TU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83105|0                           |1
        is obsolete|                            |

--- Comment #46 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83963&action=edit
Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:43 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-DyrvEapj4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83106|0                           |1
        is obsolete|                            |

--- Comment #47 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83964&action=edit
Bug 11529: Clean up subtitle usage

Unify and clean up subtitle usage so that it's always used as a simple array
and not the old hash structure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:48 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-8Nkrgiv1JD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83107|0                           |1
        is obsolete|                            |

--- Comment #48 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83965&action=edit
Bug 11529: Remove field mapping table and admin page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:52 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-33qGi3LtqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83108|0                           |1
        is obsolete|                            |

--- Comment #49 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83966&action=edit
Bug 11529: DBIx schema changes

Updates to Biblio schema and removal of FieldMapping schema.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:12:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:12:30 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-egtyqEXmfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83103|0                           |1
        is obsolete|                            |

--- Comment #44 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 83961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83961&action=edit
Bug 11529: Add new fields to biblio table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:13:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:13:12 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-vpGhHdpW79@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #50 from Ere Maijala <ere.maijala at helsinki.fi> ---
Thanks Josef, fixed and rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:27:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:27:05 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-v1LEZPi0nz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 69833
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69833
Bug 19661 - REST API: Funds Endpoint

Review of attachment 69833:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19661&attachment=69833)
-----------------------------------------------------------------

::: Koha/REST/V1/Acquisitions/Funds.pm
@@ +19,5 @@
> +
> +use Mojo::Base 'Mojolicious::Controller';
> +
> +use C4::Budgets;
> +use JSON qw(to_json);

Unused import here

@@ +83,5 @@
> +
> +    return $returnfund;
> +}
> +
> +=head3 _to_model

Should this private routine be introduced before any corresponding write
functions are added to the controller or should it be added when those routines
are?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:36:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:36:08 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-RwVlLtjEvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:55:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:55:00 +0000
Subject: [Koha-bugs] [Bug 21444] Permanent location should show with cart
 location - returns.pl
In-Reply-To: <bug-21444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21444-70-vKacbpCckY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |cbrannon at cdalibrary.org
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 13:55:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 12:55:45 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-V20o16yI5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:10:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:10:26 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-yf8xwkU4XV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
This is a quote directly from the sponsor (Peddie School):

The goal of this development would be to create a file folder structure that
could be uploaded to from Tools>Upload and then have a way to easily view the
folder structure so that you can see what files have been uploaded and which
folder they belong to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:16:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:16:54 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-uS8RdmSoNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:16:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:16:57 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-bpTcAUFoO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83934|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83967&action=edit
Bug 21866: Changed "report" to "plugins" for the warning "This report was
written for an older version of Koha. Run at your own risk"

To find this change:

1. Enable use plugins in global system preferences
2. Go to tools then click tool plugins
3. Verify that this string now says plugins

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:20:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:20:32 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-9LxUPYCxCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:20:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:20:35 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-BF6whzwYbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83932|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83968&action=edit
Bug 22036: Indented code where '^I' was written rather than an indent.

Code was previously written with '^I' where an indent was supposed to
be. I deleted all '^I's and replaced them with indents.

To find this change:
Look at the tags/review.pl file and confirm indentation is correct

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:30:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:30:28 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-G9dYpQD3dy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:30:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:30:30 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-KhKeAcbx32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83967|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83969&action=edit
Bug 21866: Changed "report" to "plugins" for the warning "This report was
written for an older version of Koha. Run at your own risk"

To find this change:

1. Enable use plugins in global system preferences
2. Go to tools then click tool plugins
3. Verify that this string now says plugins

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:46:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:46:48 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-edULun0pDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83941|0                           |1
        is obsolete|                            |

--- Comment #12 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 83970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83970&action=edit
Bug 19661 - Add and change properties and parameters to conform to the funds
RFC.

Also, perform an exact search when searching on the fund owner id.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 14:50:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 13:50:49 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-WW1mDPAvia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

--- Comment #13 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
> Unused import here

Unused import removed.

> Should this private routine be introduced before any corresponding write functions are added to the controller or should it be added when those routines are?

I just wanted to make future work easier :)
Besides, since the RFC has already been voted, it's unlikely to change before
new features are added.
But any option is fine by me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 15:39:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 14:39:18 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-gSCDU5fuTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 15:39:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 14:39:21 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-Jefuf9E3fz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #15 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 83971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83971&action=edit
Bug 18723: (Alternate Solution) Block form submission

When entering an amount in "Actual Cost" on the orderreceive page,
it is multiplied by 100 if the entered number's format does not
match the "CurrencyFormat" syspref.

This patch adds a value check before submitting the form. It uses
regexps based on the "CurrencyFormat" syspref to validate that the
number will be processed correctly.

Test Plan:
a)Replicate the issue:
    0- Set CurrencyFormat to FR
    1- Go to Acquisitions
    2- Search for a Vendor
    3- Click on "New basket"
    4- Give basket a name and click "Save"
    5- Click on "Add to basket"
    6- Add an order through preferred method
    7- In Accounting details, enter a vendor price with dot decimal (i.e.
19.44)
    8- Save your order line
    9- Click on "Close this basket"
    10- Confirm closing of basket by clicking on "Yes, close"
    11- Click on "Receive shipment"
    12- Enter an invoice number and click "Next"
    13- Click on "Receive" to the right of your order
    14- In Accounting details, notice the Actual cost is written with a decimal
dot.
    15- Change the Actual cost, using a dot decimal (i.e 20.99)
    16- Receive the order
    17- Click on "Save"
    18- In "Already received" notice the price is multiplied by 100 (i.e.
2099,00)
    19- Click on "Cancel receipt"
    20- Click on "Receive" to the right of your order
    21- In Accounting details, change the Actual cost, using a comma decimal
(i.e. 20,99)
    22- Receive the order
    23- Click on "Save"
    24- In "Already received", notice the price is correct.
b)Apply the patch
c)Test the patch:
    1- Click on "Cancel receipt"
    2- Click on "Receive to the right of your order
    3- In Accounting Details, notice the Actual cost is formatted correctly
(comma decimal)
    4- Change the Actual cost, using a dot decimal (21.99)
    5- Receive the order
    6- Click on "Save"
    7- Notice an error message explaining the proper format for Actual cost
(click "Ok")
    8- Change the Actual cost, using a comma decimal (21,99)
    9- Click on "Save"
    10- In "Already received", notice the price is correct.
    11- Test the other CurrencyFormat settings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 15:41:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 14:41:38 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-26LQwbv5SE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 15:51:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 14:51:59 +0000
Subject: [Koha-bugs] [Bug 22134] New: Add account expiration information to
 patron details
Message-ID: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

            Bug ID: 22134
           Summary: Add account expiration information to patron details
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

On the patron detail page in the staff client, expired patrons should show a
message at the top like the checkout page does.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:08:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:08:12 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-R7QuOhBGIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:08:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:08:14 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-ey4vFqXwSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83972&action=edit
Bug 22134: Add account expiration information to patron details

This patch modifies the patron detail template in the staff client so
that when a patron's registration is expired a message shows at the top
of the page along with the same "Renew" and "Edit" links which appear on
the checkout page. Links are also shown next the the expiration date in
the body of the page.

This patch also corrects the capitalization of the "Edit Details" link
on circulation.tt.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.
 - On the patron's checkout page the "Edit details" link in the
   expiration message should have correct capitalization.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:16:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:16:57 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-mkHfLMMSWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:08 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-R6dfocOkn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82968|0                           |1
        is obsolete|                            |

--- Comment #146 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83974&action=edit
Bug 18736: Use rounding syspref to determine correct prices in calculations

To test:
Place an order (no tax just for simplicity)
 listprice/rrp = 16.99
 discount = 42%
 quantity = 8
 estimated calculated at 9.85
 but order total is 78.83, but 8 times 9.85 = 78.80
Apply patches, set OrderPriceRounding syspref to 'Nearest cent'
Not order total is now as expected
View ordered.pl and confirm values are correct
Complete order, view invoice and confirm values
View spent.pl and confirm values
Go through acquisitions module and confirm prices throughout are
correct.

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:02 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-QvKE97PbBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82967|0                           |1
        is obsolete|                            |

--- Comment #145 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83973&action=edit
Bug 18736: Add OrderPriceRounding syspref

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:13 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-XHtR0Ff3nE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82969|0                           |1
        is obsolete|                            |

--- Comment #147 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83975&action=edit
Bug 18736: Unit tests for rounding

Unit tests to highlight the issue

To test:
Prove t/db_dependent/Budgets.t
prove t/Acquisition.t

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:18 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-lsNt1QijVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82970|0                           |1
        is obsolete|                            |

--- Comment #148 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83976&action=edit
Bug 18736: (follow-up) Add tests and FIXME for GetbudgetsPlanCell

prove t/db_dependent/Budgets.t

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:23 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-GsZKQB2s7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82971|0                           |1
        is obsolete|                            |

--- Comment #149 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83977&action=edit
Bug 18736: (follow-up) Add missing test cases

We now fully cover GetBudgetsPlanCell in these tests

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:30 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-LzgkHPjc9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82972|0                           |1
        is obsolete|                            |

--- Comment #150 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83978&action=edit
Bug 18736: (follow-up) Fix missing rounding and bad formatting

This patch:
Adds a missing use
Uses 'Koha::Number::Price->round()' instead of 'format()' to ensure numeric
returns
Ensures too big numbers don't crash round()
Uses syspref in 'GetBudgetHierarchy'

To test:
Follow previous test plan
Check values on admin/aqbudgets.pl are affected by syspref
Ensure values throughout acquisitions are correctly calculated/displayed
(even when greater than 1,000)

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:35 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-zdhmzxZCB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82973|0                           |1
        is obsolete|                            |

--- Comment #151 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83979&action=edit
Bug 18736: Unit tests for GetBudgetHierarchy

prove -v t/db_dependent/Budgets.t

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:40 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-NYAgA9sY1r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82974|0                           |1
        is obsolete|                            |

--- Comment #152 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83980&action=edit
Bug 18736: (follow-up) cast as UNSIGNED instead of INTEGER

More recent MySql versions require the use of SIGNED or UNSIGNED rather
than INTEGER. UNSIGNED will still work in older installs

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:47 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-ZI4J3cokyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82975|0                           |1
        is obsolete|                            |

--- Comment #153 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83981&action=edit
Bug 18736: (follow-up) Remove duplicate code and adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:53 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-pCA0sR7kK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82976|0                           |1
        is obsolete|                            |

--- Comment #154 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83982&action=edit
Bug 18736: (QA follow-up) Cosmetic changes

[1] Resolve warnings like:
Use of uninitialized value $rounding_pref in string eq at
/usr/share/koha/devclone/C4/Acquisition.pm line 2040.

[2] Fixing unusual use of whitespace too.

[3] Remove list operator from get_rounding_sql return. Only used in scalar
context.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:17:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:17:59 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-L059hCdJl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82977|0                           |1
        is obsolete|                            |

--- Comment #155 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83983&action=edit
Bug 18736: (QA follow-up) Change to signed, add large int test

[1] Add trivial subtest in t/Number/Price.t
Checking a negative number and a large number for the MAX_INT change.
Note: Confusing to have t/Prices.t too.

[2] Change UNSIGNED to SIGNED in get_rounding_sql. Although I did not spot
problems with negative prices, we theoretically could while casting.
cast(-2 as unsigned) == 18446744073709551614

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:18:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:18:06 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-NNaEtnTKol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83212|0                           |1
        is obsolete|                            |

--- Comment #156 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83984&action=edit
Bug 18736: (QA follow-up) Resolve uninitialized warn from Biblio.pm L3334

Running t/db/Budgets.t:
Use of uninitialized value in join or string at C4/Biblio.pm line 3334.

Test plan:
Run again. Verify no warnings left.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:18:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:18:12 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-QLIvoTv2Nj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #157 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 83985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83985&action=edit
Bug 18736: Calculate tax depending on rounding

Marcel's comments pointed out that while I tried to avoid storing
rounded values it is required for tax generation.

This patch makes that change and adds test coverage and POD for
populate_order_with_prices

To test:
Follow plan on other patches, ensure that orders and totals match on the
basket, invoice, and budget pages

prove -v t/db_dependent/Acquisition/populate_order_with_prices.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:21:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:21:19 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-2KCjmb1D6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:22:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:22:12 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-naV3Q1IEWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #158 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #144)
> (In reply to Nick Clemens from comment #140)

Ah, okay, I understand now - it seems we cannot leave the tax values untouched
when enabling rounding, I added a followup for this. Let me know if the new
calculations and tests match your expectations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:42:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:42:07 +0000
Subject: [Koha-bugs] [Bug 22130] Batch checkout : authorized value
 description is never shown with notforloan status.
In-Reply-To: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22130-70-RVmbYvnQyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130

--- Comment #1 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83986&action=edit
Bug 22130: Correct parameter to get authorized value description.

This patch corrects the error that shows an authorized value instead of the
obvious description of the document status.

TEST PLAN
1) In Koha administration, search "BatchCheckouts".
2) Make sure "BatchCheckouts" is set at "Allow".
3) Make sure "BatchCheckoutsValidCategories" contains at least one patron
category.
5) Copy the barcode of an item and change the status document so it cannot be
loaned.
4) Choose a patron which belongs to the patron category at 3).
(their account should not be expired and they should not have active fees
preferably)
5) Go to the patron details page.
6) Click on "Batch check out".
7) Enter the item barcode.
8) Notice a number is in brackets under the column "Information".
9) Apply patch.
10) Notice the status description has replaced the number.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:43:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:43:49 +0000
Subject: [Koha-bugs] [Bug 22130] Batch checkout : authorized value
 description is never shown with notforloan status.
In-Reply-To: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22130-70-hKISa0lPQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:50:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:50:31 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-RVxQQBS5lq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:50:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:50:33 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-KOEJtPV3PD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83837|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83987&action=edit
Bug 22111: Format amount shown on place holds when maxoutstanding is reached
(staff)

Displays amount outstanding correctly when holds are blocked
by maxoutstanding.

To test:
- Check maxoutstanding system preference value
- Add a fine to a patron account exceeding maxoutstanding
- Try to place a hold for this patron from staff
- Verify this message is shown:

     Patron has outstanding fines: 6.00

- Toggle CurrencyFormat system preference and verify display
  changes according to setting

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 16:53:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 15:53:16 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-U8GI09nAJc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:14:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:14:21 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-gmu0EvUt1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:14:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:14:23 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-9uUEphA3WV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83918|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83988&action=edit
Bug 17347: Ignore whitespace before and after on renewing

When an item is checked out, Koha ignores whitespace
at the beginning and the end of the entered barcode.
This makes life easier, if a barcode is C&P from another
page. This patch makes the renewal page behave the same.

To test:
- Checkout an item
- Renew the item from the renew tab or renewal page
  entering the barcode with leading and trailing
  whitespace
- "Barcode not found"
- Apply patch
- Try again
- Barcode should be found now

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:27:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:27:55 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-XVQV2k0yIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83989&action=edit
Bug 22132: Add RESTBasicAuth syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:27:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:27:59 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-t3PbGQUlFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83990&action=edit
Bug 22132: Unit tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:28:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:28:05 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-d8xKS7GZTL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83991&action=edit
Bug 22132: Add Basic authentication to the API

This patch implements Basic authentication for the API to aid testers
and developers with tools like Postman.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_basic.t
=> SUCCESS: Tests pass!
- Open Postman or your favourite tool
- In Authorization, choose Basic auth.
- Enter the username and password of a known privileged user.
- Hit an endpoint with Postman, for example:
  ] GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons
=> SUCCESS: Basic authentication is great!
- Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:28:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:28:30 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-vFRMgmxHNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:48:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:48:31 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-IouEpBsJB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 17:48:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 16:48:38 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-opty0F4a2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:29:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:29:42 +0000
Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling
 of staff client menu bar
In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22023-70-5eBpj8XO7b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:29:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:29:44 +0000
Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling
 of staff client menu bar
In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22023-70-51Qq0A4FqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 83992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83992&action=edit
Bug 22023: Further improve responsive layout handling of staff client menu bar

This patch makes a number of changes in order to improve the way the
staff client's header menu adjusts at narrower browser widths:

 - Updated version of Bootstrap 3.3.7 which includes the "collapse"
   JavaScript plugin.
 - Modified default Bootstrap CSS using Bootstrap's customization tool.
   These changes facilitate the removal of some custom CSS (overriding
   Bootstrap) from staff-global.scss.
 - Added Bootstrap config file for loading customizations at
   https://getbootstrap.com/docs/3.3/customize/
 - Revised button classes for buttons in Bootstrap-styled toolbars.

   The modified default CSS resets the base font size in Bootstrap to
   better match our global CSS. A side-effect of this is that toolbar
   buttons ended up looking smaller than they should. Changing the
   button class solves this.

 - Restructure the header menu in order to allow different rules to
   govern the appearance of the navigational part of the menu
   (Circulation, Search, etc) and the user menu (Set library, My
   account, Log out).

 - Modify the cart JS to so that the popup works well at narrow widths.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache.

 - Log in to the staff client and observe the layout of the header menu
   as you adjust the browser to various widths.
   - Confirm that sections of the menu "collapse" as the window gets
     narrower.
   - Confirm that dropdown menus behave correctly and that links work.
   - Confirm that the Cart link works as expected when the cart empty
     and when it has items.
- Install and enable multiple translations, including at least one
  set of sub-languages (e.g. fr-FR and fr-CA).
  - Test the appearance of the language menus in the footer at
    various browser widths.
- View pages with button toolbars and confirm that they appear unchanged
  (e.g. biblio detail page, patron detail page).

NOTE: While this patch is intended to make improvements to staff client
responsiveness, it does so within a limited scope. There are still many
pages which do not work well at narrower browser widths.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:30:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:30:49 +0000
Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling
 of staff client menu bar
In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22023-70-81xgC130OJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This will probably require some follow-ups, but I would love to get some
testers for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:46:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:46:51 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-bPCy5xJykn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83990|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:46:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:46:53 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-nkTSW1yzcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83991|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:46:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:46:49 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-oFQ5ea5NcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83989|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:47:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:47:17 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-5Ks07wL4do@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83993&action=edit
Bug 22132: Add RESTBasicAuth syspref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:47:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:47:20 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-9Kdaa4dwAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83994&action=edit
Bug 22132: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:47:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:47:23 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-3QxyDb3pm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83995&action=edit
Bug 22132: Add Basic authentication to the API

This patch implements Basic authentication for the API to aid testers
and developers with tools like Postman.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_basic.t
=> SUCCESS: Tests pass!
- Open Postman or your favourite tool
- In Authorization, choose Basic auth.
- Enter the username and password of a known privileged user.
- Hit an endpoint with Postman, for example:
  ] GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons
=> SUCCESS: Basic authentication is great!
- Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:48:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:48:38 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-P3TDGDn1VD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, oleonard at myacpl.org
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:58:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:58:46 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-mJrXqoWKYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 18:58:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 17:58:49 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-FcjzUDfkQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83950|0                           |1
        is obsolete|                            |

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 83996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83996&action=edit
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description

This patch fixes a trivial text layout problem on the syspref
description.

To test:
- Search for the OAI-PMH:archiveID syspref on the staff interface
=> FAIL: Notice the colon is placed *after* the input, and looks weird.
- Apply this patch
- Reload the page
=> SUCCESS: The colon is placed *before* the input, and looks more
correct.
- Sign off :-D

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:00:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:00:02 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-6Rc3DnHHcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:00:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:00:06 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-JpmYpTT0HH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83968|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83997&action=edit
Bug 22036: Indented code where '^I' was written rather than an indent.

Code was previously written with '^I' where an indent was supposed to
be. I deleted all '^I's and replaced them with indents.

To find this change:
Look at the tags/review.pl file and confirm indentation is correct

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:10:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:10:30 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-P4k3an9AtQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:10:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:10:33 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-U32najhv9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83972|0                           |1
        is obsolete|                            |

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 83998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83998&action=edit
Bug 22134: Add account expiration information to patron details

This patch modifies the patron detail template in the staff client so
that when a patron's registration is expired a message shows at the top
of the page along with the same "Renew" and "Edit" links which appear on
the checkout page. Links are also shown next the the expiration date in
the body of the page.

This patch also corrects the capitalization of the "Edit Details" link
on circulation.tt.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.
 - On the patron's checkout page the "Edit details" link in the
   expiration message should have correct capitalization.

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:19:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:19:17 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-ynhscoQD4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:19:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:19:20 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-OtNrCEdLoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83960|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83999&action=edit
Bug 22054: Updated the error message for attempting to renew an onsite checkout

To test:

1) Enable OnSiteCheckouts system preference
2) Checkout an item checking the onsite checkout checkbos in more
options
3) Go to circulation > pending on-site checkouts
4) Verify the checkout shows
5) Go to circulation > renew
6) Try to renew the on-site checkout using the barcode
7) Verify display:

onsite_checkout  Continue without renewing

8) apply the patch and reload page with error message
9) verify display:

Item cannot be renewed because it's an onsite checkout

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:19:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:19:41 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-ByBJKe2AE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:20:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:20:03 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-nA3Ytxtm9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Good job!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:43:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:43:47 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-RRS7YeeeGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:43:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:43:50 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-cL4joTtCE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83246|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84000&action=edit
Bug 22006: Add tests

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:43:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:43:55 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-Fwlhr8hsHR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83247|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84001&action=edit
Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item

If there is no item linked to an account line, the ->item method should return
undef.
Without this patch it explodes with:
Carp::croak('DBIC result _type  isn\'t of the _type Item') called at
/home/vagrant/kohaclone/Koha/Object.pm line 102

Exists since the introduction of this method by bug 12001

Reported on bug 19489 comment 18.

Test plan:
  prove t/db_dependent/Koha/Account/Lines.t
must return green

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:44:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:44:11 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-Ld4An1gsqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 19:47:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 18:47:07 +0000
Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21953-70-5E5StcSusf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #3)
> 2 things:
> 
> - Joubu already pointed out on IRC that there should be a test (change in C4)
> - Should we update existing data and remove the String there to have a clean
> state? It's mostly a display issue.

In my opinion, this has been wrong from the begining: the information should be
built for display using the account_type and the biblio information, but
instead we hardcoded those values.

Once Koha::Account::add_debit and friends is pushed, I'd review this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:08:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:08:58 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
	entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-xYZCvggsfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:08:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:08:58 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-GONCmdnCGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457
[Bug 16457] Remove the use of "onclick" from the patron entry form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:09:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:09:08 +0000
Subject: [Koha-bugs] [Bug 16763] Remove the use of "onclick" from record
 matching rules form
In-Reply-To: <bug-16763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16763-70-FYHYOcFx2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:09:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:09:08 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-cBljsyK4Yj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16763


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763
[Bug 16763] Remove the use of "onclick" from record matching rules form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:09:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:09:15 +0000
Subject: [Koha-bugs] [Bug 16300] Remove the use of "onclick" from
 circulation and fine rules template
In-Reply-To: <bug-16300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16300-70-l9KrqcJVcc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:09:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:09:15 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-4Ic6oQGflH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16300


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300
[Bug 16300] Remove the use of "onclick" from circulation and fine rules
template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:09:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:09:20 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection and serial edit templates
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-WsnR8EeHal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:09:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:09:20 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-jpmEzsQ65l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16962


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962
[Bug 16962] Remove the use of "onclick" from serial collection and serial edit
templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:12:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:12:08 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-dM57MYeYki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
   Target Milestone|---                         |19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:11:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:11:56 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-tPqeo9tV06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:21:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:21:55 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-jlASAbqaqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84005&action=edit
Bug 21871: (follow-up) Remove link tracking

Links to tracklinks.pl were erroneously copied from detail.tt. This
patch removes them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:21:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:21:52 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-WdeTlTt1Fk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:37:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:37:40 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-nbJ1QUL5yj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82831|0                           |1
        is obsolete|                            |

--- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84006&action=edit
Bug 21206: Replace C4::Items::GetItem

Note: This is here for information purpose, feel free to test it if you
wan to play with it.

TODO: C4::Reserves::_get_itype is not longer in use

No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:37:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:37:44 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-vUDn7H6VTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82832|0                           |1
        is obsolete|                            |

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84007&action=edit
Bug 21206: Remove GetItem

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:37:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:37:48 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-rSBWF1Tqo3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82833|0                           |1
        is obsolete|                            |

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84008&action=edit
Bug 21206: Fix Returns.t

we are calling several times effective_itemtype
Must be fixed later

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:37:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:37:52 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-CTa7ywDAqB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82834|0                           |1
        is obsolete|                            |

--- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84009&action=edit
Bug 21206: (follow-up) Fix Circulation.t

Test plan:
prove t/db_dependent/Circulation.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 20:37:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 19:37:56 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-2jnMIiZkJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84010&action=edit
Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:19:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:19:30 +0000
Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of
	category limits
In-Reply-To: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17492-70-SJuznmtB5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ethan.amohia at gmail.com      |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:25:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:25:07 +0000
Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and
 volumne information
In-Reply-To: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15436-70-4GrxzmLUkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ellermaugustus at gmail.com    |ethan.amohia at gmail.com
                 CC|                            |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:27:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:27:54 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-sOeGaBK0mU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:27:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:27:57 +0000
Subject: [Koha-bugs] [Bug 22120] Add price formatting to patron summary print
In-Reply-To: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22120-70-JTY6ZfnmRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83926|0                           |1
        is obsolete|                            |

--- Comment #7 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84011&action=edit
Bug 22120: Add price formattig to patron summary print

The patron summary print lists the replacement prices
and rental charges of items and totals them. With this
patch they will be formatted according to the
CurrencyFormat system preference.

To test:
- Find or create a patron with some checkouts
- Make sure some items have replacement price set
  and some have a rental charge
- "Print summary" from the account in staff
- Verify that charges and prices in the checkouts
  table are formatted correctly
- Toggle CurrencyFormat to different settings

Signed-off-by: helene hickey <hickeyhe at wgc.school.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:28:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:28:01 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-r1Pwvo1irD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:28:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:28:04 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-2wP1qNYIg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83929|0                           |1
        is obsolete|                            |

--- Comment #3 from Olivia <olivialokm at gmail.com> ---
Created attachment 84012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84012&action=edit
Bug 20165 : Changed uppercase letter to a lowercase letter in the patron search
search fields under the plus option.

Changed "Street Address" to "Street address" in the patron search search
fields under the plus sign to fit Koha's capitalization rules.

To find this change:

1. Go to Patrons and switch in the search to search patrons
2. Click on the plus sign
3. Check "Search fields" pull down
4. "Street Address" should now be "Street address"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:29:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:29:47 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-hJ6ka4mDZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Olivia, can you take another look? I think you uploaded the same patch
again, It shows the "Street Address" remaining a few lines below your change.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:44:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:44:29 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-j15ACsrPji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivialokm at gmail.com

--- Comment #1 from Olivia <olivialokm at gmail.com> ---
The message which is supposed to appear when decreaseHighHolds system
preference is enabled in circulation no longer shows up. Does this bug still
exist?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:51:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:51:20 +0000
Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and
 volumne information
In-Reply-To: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15436-70-2XVleyVsSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ethan.amohia at gmail.com      |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:51:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:51:57 +0000
Subject: [Koha-bugs] [Bug 22135] New: Inventory tool doesn't export "out of
 order" problem to CSV
Message-ID: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135

            Bug ID: 22135
           Summary: Inventory tool doesn't export "out of order" problem
                    to CSV
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marka at pobox.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 21408
  Target Milestone: ---

Created attachment 84013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84013&action=edit
Fix for out of order problem seen as blank in CSV exported by inventory tool

When using the inventory tool with an uploaded barcode file and checking the
"Compare barcodes list to results", "Check barcodes list for items shelved out
of order" and "Export to CSV file" checkboxes, the resulting CSV file shows a
blank in the "problem" column for items with out of order callnumbers.

I was able to fix this using the attached patch.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21408
[Bug 21408] Inventory - Warn of items possibly scanned out of order
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:51:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:51:57 +0000
Subject: [Koha-bugs] [Bug 21408] Inventory - Warn of items possibly scanned
	out of order
In-Reply-To: <bug-21408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21408-70-zIcpnVsBNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21408

Mark Alexander <marka at pobox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22135


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135
[Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 21:52:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 20:52:04 +0000
Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and
 volumne information
In-Reply-To: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15436-70-y5vj9AHmQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

--- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
This bug has been confusing us for a little while. Can you please clarify how
to reproduce the bug, what fields should be filled?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:01:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:01:05 +0000
Subject: [Koha-bugs] [Bug 21326] Add branch param to C4::SIP->checkout
In-Reply-To: <bug-21326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21326-70-sus4f7Hupa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:01:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:01:12 +0000
Subject: [Koha-bugs] [Bug 21326] Add branch param to C4::SIP->checkout
In-Reply-To: <bug-21326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21326-70-Ss9tNEcbA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78541|0                           |1
        is obsolete|                            |

--- Comment #5 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84014&action=edit
Bug 21326: C4::SIP::ILS add missing branch param

ILS::Transaction was missing branch param for unknown reason.
Since every transactions needs a branch, it makes sense to include it in
the object and allow as param.

This patch only adds the param to the object and ILS->checkout so it
can be used in submodules.

Signed-off-by: Ethan Amohia <ethan.amohia at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:10:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:10:02 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-iNprrsgSoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:10:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:10:05 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-6cG3PNw9TV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84015&action=edit
Bug 20865: Removed space before : on order receive filters

I removed space before : on order receive filters

To find this change:
1. Create a vendor
2. Create a basket and add an order to basket
3. Close basket and select 'receive shipment'
4. Check that filter options found on the left side of the page finish with a
colon and that there is no space before the colon

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:13:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:13:30 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-nxd6LQn4GR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:13:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:13:33 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-Kik6nkkEOk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

--- Comment #2 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84016&action=edit
Bug 22029: Google plus has been removed from the social links.

For testing:
1) Make sure SocailNetworks is enabled
2) Find a book and verify that in the social links, there is a Google
Plus option
3) apply patch and verify that the Google Plus option is no longer there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:15:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:15:07 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-ogwWmm15sz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I believe that link should be replaced with
https://www.niso.org/publications/standards

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:16:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:16:37 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-cV3gHdpveF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.amohia at gmail.com
           Assignee|koha-bugs at lists.koha-commun |ethan.amohia at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:18:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:18:05 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-ENhoP3IWTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:18:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:18:09 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-WDR7OJVqKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74123|0                           |1
        is obsolete|                            |
  Attachment #74124|0                           |1
        is obsolete|                            |
  Attachment #74125|0                           |1
        is obsolete|                            |
  Attachment #74126|0                           |1
        is obsolete|                            |
  Attachment #74818|0                           |1
        is obsolete|                            |
  Attachment #75652|0                           |1
        is obsolete|                            |

--- Comment #131 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84017&action=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR <http://www.ccsr.qc.ca>

Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:19:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:19:43 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-eLEBCOKWBO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #132 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84018&action=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:19:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:19:59 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-YLwU1EX6Mc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #133 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84019&action=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:20:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:20:09 +0000
Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and
 volumne information
In-Reply-To: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15436-70-eB3ILiZl3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha,

I found an example in the kohadevboxsample data: 

Title:  Sc?la mucce Meic Dath?,

490     0               
_aMediaeval and modern Irish series.
_vvol. VI 

Displays as: Series: Mediaeval and modern Irish series. vol. VI.

That should be: Series: Mediaeval and modern Irish series ; vol. VI.

See: http://www.loc.gov/marc/bibliographic/bd490.html (you could also test
catalog the examples given there)

Antoher problem appears with the older 440:

Title: Scarlet and black

440             0       
_aPenguin readers.
_pLevel 6
_9582 

Displays as: Series: Penguin readersLevel 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:20:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:20:09 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-MTQaC2ktUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #134 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84020&action=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:20:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:20:18 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-xnIHCEFLAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #135 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84021&action=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:20:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:20:26 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-OxmMF5alte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #136 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84022&action=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:21:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:21:42 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
	contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-Z9aOTRQQo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

--- Comment #137 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Rebased to master, patch should apply again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:33:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:33:51 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical lables
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-nEnm5HqvCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

--- Comment #1 from Olivia <olivialokm at gmail.com> ---
Created attachment 84023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84023&action=edit
Bug: 20634 Changing the identical label "Library:" to "Location" in Inventory
Home.

To find fix:

1. Go to tools
2. Go to Inventory
3. Verify that under Item location filters the label should be "Location"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:34:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:34:06 +0000
Subject: [Koha-bugs] [Bug 21245] Move 'Last patron' button inside of the
	'breadcrumb' bar
In-Reply-To: <bug-21245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21245-70-W9NhvfP3xR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21245

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hickeyhe at wgc.school.nz
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from helene <hickeyhe at wgc.school.nz> ---
This looks like it has been fixed in master, setting to resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:33:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:33:48 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical lables
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-W5WHUDDPFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:38:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:38:28 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical lables
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-3kKWIbeIhj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84023|0                           |1
        is obsolete|                            |

--- Comment #2 from Olivia <olivialokm at gmail.com> ---
Created attachment 84024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84024&action=edit
Bug 20634: Changing the identical label "Library:" to "Location" in Inventory
Home.

To find fix:

1. Go to tools
2. Go to Inventory
3. Verify that under Item location filters the label should be "Location"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:42:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:42:27 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-uJF6mZChyZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:42:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:42:30 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-hMH26F0xkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84012|0                           |1
        is obsolete|                            |

--- Comment #5 from Olivia <olivialokm at gmail.com> ---
Created attachment 84025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84025&action=edit
Bug 20165: Changed uppercase letter to a lowercase letter in the patron search
search fields under the plus option.

Changed "Street Address" to "Street address" in the patron search search
fields under the plus sign to fit Koha's capitalization rules.

To find this change:

1. Go to Patrons and switch in the search to search patrons
2. Click on the plus sign
3. Check "Search fields" pull down
4. "Street Address" should now be "Street address"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:45:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:45:33 +0000
Subject: [Koha-bugs] [Bug 9488] way to track who placed a hold
In-Reply-To: <bug-9488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9488-70-UIn7ZSjnRp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9488

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If HoldsLog is activated, opac or intranet will be tracked in the interface
column.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:50:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:50:31 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-OVG4jNia4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:50:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:50:34 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-y6VYGQoqeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84026&action=edit
Bug 20569: Improved description of CheckPrevCheckout system preference

The CheckPrevCheckout preference can be overriden by a setting in the
patron categories, I've edited the options to reflect this.

Test plan:
1. Check the CheckPrevCheckout system preferences and confirm that the
options are clear

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:52:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:52:24 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-tW0HCwQxLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:52:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:52:27 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-b37AiKRHhM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

--- Comment #2 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84027&action=edit
Bug 22095: Replaced dead links with working links

I have updated the broken link everywhere it occurs.

Confirm that the new link works in the installer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 22:55:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 21:55:02 +0000
Subject: [Koha-bugs] [Bug 22110] Editing adjustments doesn't work for
 Currencyformat != US
In-Reply-To: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22110-70-0VebQzSYjo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:00:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:00:15 +0000
Subject: [Koha-bugs] [Bug 22110] Editing adjustments doesn't work for
 Currencyformat != US
In-Reply-To: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22110-70-7gwBxwGtAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84028&action=edit
Bug 22110: Fix editing of adjustments for CurrencyFormat != US

When using CurrencyFormat FR or CH the editing an amount behave
badly. Example: changing displayed 1,00 to 1,11 would save as 1,00.

At the moment Koha only understands decimal dot, not comma.
So every time data is entered, we use decimal dot.

1) Add an adjustment to an invoice
2) Change system preference CurrencyFormat to FR or CH
3) Verify the amount displays with a decimal comma
4) Try changing the amount to something like 1,11
5) Save the amount
6) Verify it shows 1.00
7) Apply patch
8) Refresh the invoice page if necessary
9) Verify amount is now shown as 1.00
10) Repeat test, use 1.11
11) Verify it will be stored correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:00:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:00:11 +0000
Subject: [Koha-bugs] [Bug 22110] Editing adjustments doesn't work for
 Currencyformat != US
In-Reply-To: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22110-70-1Yh1L8DsAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:10:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:10:00 +0000
Subject: [Koha-bugs] [Bug 22017] Cannot start the web installer
In-Reply-To: <bug-22017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22017-70-ICfGtB6hsc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22017

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:36:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:36:18 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-DsGsI65RNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84025|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84029&action=edit
Bug 20165: Changed uppercase letter to a lowercase letter in the patron search
search fields under the plus option.

Changed "Street Address" to "Street address" in the patron search search
fields under the plus sign to fit Koha's capitalization rules.

To find this change:

1. Go to Patrons and switch in the search to search patrons
2. Click on the plus sign
3. Check "Search fields" pull down
4. "Street Address" should now be "Street address"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:39:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:39:24 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-Ir7rq508Gc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |hickeyhe at wgc.school.nz

--- Comment #9 from helene <hickeyhe at wgc.school.nz> ---
This is really good, but the column settings in administration are not having
any effect.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:39:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:39:26 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-aas02VMBEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from David Nind <david at davidnind.com> ---
Nice work Olivia!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:53:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:53:20 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical lables
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-ByNb40VMGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84024|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84030&action=edit
Bug 20634: Changing the identical label "Library:" to "Location" in Inventory
Home.

To find fix:

1. Go to tools
2. Go to Inventory
3. Verify that under Item location filters the label should be "Location"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 15 23:53:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 22:53:53 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical lables
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-e5AjFNSCHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:01:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:01:45 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-pVrZszwUXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:01:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:01:50 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-WhOQIshbcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70572|0                           |1
        is obsolete|                            |

--- Comment #3 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84031&action=edit
Bug 18661: Made "Replace only included patron attributes" default on patron
import

Test Plan:
1) Go to the import patrons page and notice that "Replace all patron
attributes" is selected by default in the Patron Attributes section.
2) Apply this patch
3) Go back to the import patrons page and notice that "Replace only included
patron attributes" is delected by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:02:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:02:09 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-4TFgqj3TWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:07:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:07:00 +0000
Subject: [Koha-bugs] [Bug 22136] New: Import patrons notes hides a note
 because the syspref isn't referenced correctly
Message-ID: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

            Bug ID: 22136
           Summary: Import patrons notes hides a note because the syspref
                    isn't referenced correctly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

To reproduce:

Go to Tools -> Import patrons
Look under Notes
There should be NO note talking about the patron_attributes field.
Go to Administration -> system preferences
Enable the ExtendedPatronAttributes syspref
Go back to Tools -> Import patrons
Notice the note still hasn't shown up, but it is meant to.

This is because it is not checking the system preference correctly
The code says [% IF ( ExtendedPatronAttributes ) %]
but it should say [% IF ( Koha.Preference('ExtendedPatronAttributes') ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:07:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:07:07 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-OFT5ybqHjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:14:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:14:56 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-JAdmzW5OMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:14:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:14:59 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-yn7o5DOBiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

--- Comment #1 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84032&action=edit
Bug 20274 When the system preference for item-level_itypes changed, it gave a
zero result.

1) Go to reports then catalog by item types
2) Pick a location and look at table
3) Change the system prefernce of item-level_itypes
4) Verify a zero result
5) Apply patch and retry
6) Verify that result does not change to zero on either preference

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:15:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:15:54 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-z7HOYPsyMb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:23:27 +0000
Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
In-Reply-To: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17433-70-nKhgVnyODV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433

Brian <bklein at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bklein at dubuque.lib.ia.us

--- Comment #5 from Brian <bklein at dubuque.lib.ia.us> ---
any updates on bug 17433?

Carnegie team

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:25:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:25:24 +0000
Subject: [Koha-bugs] [Bug 19642] If autoMemberNum is enabled,
 we should just ignore cardnumber entry in BorrowerMandatoryField
In-Reply-To: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19642-70-COio06ELV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642

Brian <bklein at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bklein at dubuque.lib.ia.us

--- Comment #1 from Brian <bklein at dubuque.lib.ia.us> ---
any updates on bug 19642?

Carnegie Team.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 00:26:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Jan 2019 23:26:52 +0000
Subject: [Koha-bugs] [Bug 19225] Warn on About page regarding sysprefs
 autoMemberNum and BorrowerMandatoryField
In-Reply-To: <bug-19225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19225-70-aFgJjCz3Uk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225

Brian <bklein at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bklein at dubuque.lib.ia.us

--- Comment #2 from Brian <bklein at dubuque.lib.ia.us> ---
any updates on bug 19225?

Carnegie Team.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 01:04:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 00:04:48 +0000
Subject: [Koha-bugs] [Bug 22137] New: Koha should warn when
 maxRecordsForFacets is less than numSearchResults or OPACnumSearchResults
Message-ID: <bug-22137-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22137

            Bug ID: 22137
           Summary: Koha should warn when maxRecordsForFacets is less than
                    numSearchResults or OPACnumSearchResults
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When configuring search results, many libraries will increase
maxRecordsForFacets to more than what's found in numSearchResults or
OPACnumSearchResults, so that they will show more facets than what is seen on
the page. This won't generally cause confusion -- unless a patron is looking
for a facet, they tend not to pay attention to them. If, however,
numSearchResults or OPACnumSearchResults is increased and maxRecordsForFacets
is *not* increased, it is possible to have search results on the page that
aren't reflected in the facets, and that will get noticed / cause confusion.

I'm not sure that maxRecordsForFacets should *necessarily* be equal to the
larger of these two, but we should at least show a warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 01:23:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 00:23:53 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-s0WCgybpr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I think the colon might be after the OAI-PMH:archiveID to show that they don't
need to include the colon in the value itself?

I've been wondering if it's worth adding the following to the description:
http://www.openarchives.org/OAI/openarchivesprotocol.html#UniqueIdentifier
http://www.openarchives.org/OAI/2.0/guidelines-oai-identifier.htm

I suppose if people are interested in OAI-PMH, they should look it up
themselves, but I know it's taken me years to read these documents inside and
out.

Maybe we could add something like "E.g. <OAI-PMH:archiveID>:<biblionumber>" to
make it more obvious about how the identifier is constructed using this system
preference?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 01:37:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 00:37:39 +0000
Subject: [Koha-bugs] [Bug 22138] New: members/paycollect.pl has not been
 updated to have the new tab names
Message-ID: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

            Bug ID: 22138
           Summary: members/paycollect.pl has not been updated to have the
                    new tab names
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Under the new Accounting tab (was "Fines") the tabs have also been renamed -
'Account' became 'Transactions', and 'Pay fines' became 'Make a payment'.

These tab headings need to be updated on members/paycollect.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 01:37:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 00:37:45 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-c3LnXVbIuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:07:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:07:55 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-qinXp768Mk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:07:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:07:57 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-HyScsTCX8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84033&action=edit
Bug 22138: updated tab names on members/paycollect.pl

Test plan:
1. Give patron outstanding fees
2. Search patron and select 'Make payment'
3. Select either 'Pay' or 'Write off'
4. Confirm that first tab title remains as 'Transactions'
5. Confirm that current tab title remains as 'Make a payment'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:31:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:31:35 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-mExwh7cpKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:31:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:31:38 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-LoBmPLeWCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

--- Comment #3 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84034&action=edit
Bug 20527: Made the "Writeoff amount" input focus when the "Pay fines" tab
loads.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:32:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:32:48 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-Ycsquuhiwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |ethan.amohia at gmail.com
                   |ity.org                     |
                 CC|                            |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:38:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:38:17 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-wv6WEaL27y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:38:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:38:20 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-somwD08616@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

--- Comment #1 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84035&action=edit
Bug 21290: Removed obslete line from code

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:38:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:38:52 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-MDghehGW2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:52:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:52:00 +0000
Subject: [Koha-bugs] [Bug 21840] Fix some typos in the templates
In-Reply-To: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21840-70-ZOEp7a3jxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:52:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:52:03 +0000
Subject: [Koha-bugs] [Bug 21840] Fix some typos in the templates
In-Reply-To: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21840-70-2ndXLXW0eH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840

--- Comment #6 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84036&action=edit
Bug 21840: Fixed some typos in the templates

intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13
Bibliograpic record ID --> Bibliographic record ID

intranet-tmpl/prog/en/modules/acqui/basket.tt:547
Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked
with this order cancel holds first -->  ... with this order. Cancel holds first

intranet-tmpl/prog/en/modules/acqui/parcel.tt
Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked
with this order cancel holds first --> ... with this order. Cancel holds first

intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32
Print this slabel --> Print this label

Test plan:
1. Check that the fixes in the patch are correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:52:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:52:24 +0000
Subject: [Koha-bugs] [Bug 21840] Fix some typos in the templates
In-Reply-To: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21840-70-cMa9inEACo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olivialokm at gmail.com        |jasmineamohia.student at wegc.
                   |                            |school.nz
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 02:52:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 01:52:51 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-roLvcWeghG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 03:17:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 02:17:57 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-ORqyzgiSO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 03:18:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 02:18:00 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-qHcn2DyG2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84037&action=edit
Bug 19920: Removed unnecessary code from C4/Members.pm

A seperate bug (Bug 16853) removed the subroutine used in this file. I removed
the code as it had become unnecessary.

Test plan:
1. Confirm that &changepassword can't be found in C4/Members.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 03:20:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 02:20:42 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-ygt5VllLgi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 03:20:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 02:20:45 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-VMJAe0rVpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

--- Comment #8 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84038&action=edit
Bug 7403: Shorterned what the prefernce reads. To test: 1) Look at value of
CataloguingLog prefernce 2) Apply the patch and the value should change 3)
Verify that the warning has been removed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 03:21:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 02:21:01 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-tGcowy7eCU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hickeyhe at wgc.school.nz
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 04:32:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 03:32:11 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-muacKIWymY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 04:32:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 03:32:15 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-GlDdoSzuyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

--- Comment #1 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84039&action=edit
Bug 22122: Rearranged inputs from a patrons basket in Acquisitions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 04:37:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 03:37:15 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-Z4TWpj8N2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 04:37:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 03:37:19 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-y8chwcKnhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

--- Comment #10 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84040&action=edit
Bug 19818: Added appropriate id to all the list items under libary use heading.

1) Go to the patron details for a patron
2) On the right of the screen, right click one of the labels below
'Library use' etc, and Inspect Element
3) View <li> tags which should now each have a unique <id> tag for each

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 04:37:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 03:37:20 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-oX3DfirTFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |ethan.amohia at gmail.com
                   |ity.org                     |
                 CC|                            |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 04:37:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 03:37:36 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-CQZOT65H84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|victor.grousset at biblibre.co |hickeyhe at wgc.school.nz
                   |m                           |
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:02:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:02:47 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-75NYJcK92G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:02:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:02:52 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-vvPowzhv43@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

--- Comment #1 from Olivia <olivialokm at gmail.com> ---
Created attachment 84041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84041&action=edit
Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob"
to "cleanup_database"

To Find Fix:

1. Go to Koha Administration
2. Search PatronSelfRegistrationVerifyByEmail
3. Verify that NOTE now says "system preference requires the
cleanup_database ..."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:04:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:04:15 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-M38PuKAkSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:04:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:04:19 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-BshdkSZdYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

--- Comment #1 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84042&action=edit
Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:06:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:06:07 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-sIQTjGcAUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:06:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:06:10 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-DTPaCLVQ7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84043&action=edit
Bug 20679: Created syspref to hide/show 'rows per page' from reports print
layout

Test Plan:
1. Update the database
2. Find reportRowsPerPage syspref and confirm it is set to Show by default
3. In another tab, make a new report to run or run an existing report
4. Confirm that rows per page dropdown shows
5. Change syspref to Don't show
6. Refresh report tab and confirm that rows per page dropdown doesn't
show.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 05:08:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 04:08:48 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-5mNgpRE9KA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84041|0                           |1
        is obsolete|                            |

--- Comment #2 from Olivia <olivialokm at gmail.com> ---
Created attachment 84044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84044&action=edit
Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob"
to "cleanup_database"

To Find Fix:

1. Go to Koha Administration
2. Search PatronSelfRegistrationVerifyByEmail
3. Verify that NOTE now says "system preference requires the
cleanup_database ..."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 06:30:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 05:30:13 +0000
Subject: [Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly
In-Reply-To: <bug-22139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22139-70-zfHm2MK4ba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

Muneeb Kalathil <muneebkalathil at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fields ACCTDETAILS not      |Fields of ACCTDETAILS not
                   |working properly            |working properly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 06:29:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 05:29:52 +0000
Subject: [Koha-bugs] [Bug 22139] New: Fields ACCTDETAILS not working properly
Message-ID: <bug-22139-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

            Bug ID: 22139
           Summary: Fields ACCTDETAILS not working properly
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: muneebkalathil at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Some of the fields in ACCTDETAILS is not working properly when we create new
patrons. There is no problem in receiving mails.

The only field it takes is <<borrowers.password>>

The remaining fields in this notice does not showing any values in the mail.
<<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>>

<<borrowers.userid>>

#####################################

This is the mail I recieved.

Hello  .

Your new Koha account details are:

User:  
Password: 1234


If you have any problems or questions regarding your account, please contact
your Koha Administrator.


Thank you,
Librarian
library at xxxx

#####################################

* Checkout notice is working fine with ACCTDETAILS details.
* Also I imported this DB to 18.05 and it is working perfectly; No issues .
* Didn't find any errors in log related to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 06:31:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 05:31:03 +0000
Subject: [Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly
In-Reply-To: <bug-22139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22139-70-dhOOcTqgWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

Muneeb Kalathil <muneebkalathil at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 08:17:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 07:17:30 +0000
Subject: [Koha-bugs] [Bug 19225] Warn on About page regarding sysprefs
 autoMemberNum and BorrowerMandatoryField
In-Reply-To: <bug-19225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19225-70-pc7qofK2ZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We've got a warning on the patron page now - I am marking this duplicate
resolved.

*** This bug has been marked as a duplicate of bug 19466 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 08:17:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 07:17:30 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-lkWETkAC68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19225 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 08:21:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 07:21:50 +0000
Subject: [Koha-bugs] [Bug 19642] If autoMemberNum is enabled,
 we should just ignore cardnumber entry in BorrowerMandatoryField
In-Reply-To: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19642-70-Mfj5KlDBNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Brian, instead of just asking for an update, I think it would be nice if you
made your requests more specific. Read through the bug, look at the history,
the timeline, and phrase if you'd like the suggested solution etc.

At the moment, there is a good workaround for this problem: We show a warning
to change configuration and people can do that. I like Nick's suggestion
because it gets rid of a lot of text and is a little more intuitive, but I
think I'd categorize it more as an enh at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 08:33:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 07:33:30 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-VzV1C0Isie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Hi Jasmine.

The patch works, but it duplicates the patron attributes form section and puts
it AFTER the Notes section on the right hand side(depending on your browser
window size).

It should update the form section before the import button, which starts at
around line 223.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 08:51:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 07:51:48 +0000
Subject: [Koha-bugs] [Bug 18408] Remainder of title (245$b) in Koha::Biblio
In-Reply-To: <bug-18408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18408-70-toSFUbpyB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |ere.maijala at helsinki.fi

--- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> ---
This would have been a workaround for not having the fields in the biblio
table. I think bug 11529 provides a more performant and flexible
(framework-based) solution, so I'm marking this as a duplicate.

*** This bug has been marked as a duplicate of bug 11529 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 08:51:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 07:51:48 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
	medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-PHe3yF7oWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at live.fi

--- Comment #51 from Ere Maijala <ere.maijala at helsinki.fi> ---
*** Bug 18408 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:15:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:15:03 +0000
Subject: [Koha-bugs] [Bug 22034] Viewing record with Default framework
 doesn't work on MARC tab
In-Reply-To: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22034-70-PAvz32uB6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:15:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:15:57 +0000
Subject: [Koha-bugs] [Bug 21990] No background color for div.error,
	must be .alert
In-Reply-To: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21990-70-dW1HbciBGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:19:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:19:37 +0000
Subject: [Koha-bugs] [Bug 21605] Cannot create EDI account
In-Reply-To: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21605-70-US2D8cIEPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:29:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:29:46 +0000
Subject: [Koha-bugs] [Bug 22030] OverDrive requires configuration for field
 passed as username
In-Reply-To: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22030-70-HBe6baBvgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 21082 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:34:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:34:04 +0000
Subject: [Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip
	bad borrowers
In-Reply-To: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22052-70-Bohr3icW8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

Thanks a lot for the unit test, it makes life sweeter ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:34:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:34:59 +0000
Subject: [Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin
 hides renewal
In-Reply-To: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22020-70-L5yKGAyC4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 21777 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 09:59:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 08:59:03 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22073=5D_Diacritics_=C5=BD_and_?=
 =?utf-8?q?=C5=BE_not_being_mapped_for_searching_=28Non-ICU=29?=
In-Reply-To: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22073-70-0Z7biSr3y9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 10:02:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 09:02:40 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-mRJtRDDZtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84033|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84045&action=edit
Bug 22138: updated tab names on members/paycollect.pl

Test plan:
1. Give patron outstanding fees
2. Search patron and select 'Make payment'
3. Select either 'Pay' or 'Write off'
4. Confirm that first tab title remains as 'Transactions'
5. Confirm that current tab title remains as 'Make a payment'

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 10:02:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 09:02:45 +0000
Subject: [Koha-bugs] [Bug 22071] authenticate_api_request does not stash
 koha.user in the OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-5LEjKLjURI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Depends on|                            |20568


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568
[Bug 20568] Add API key management interface for patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 10:02:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 09:02:45 +0000
Subject: [Koha-bugs] [Bug 20568] Add API key management interface for patrons
In-Reply-To: <bug-20568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20568-70-yS04tUGs1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22071


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071
[Bug 22071] authenticate_api_request does not stash koha.user in the OAuth use
case
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 10:04:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 09:04:09 +0000
Subject: [Koha-bugs] [Bug 22071] authenticate_api_request does not stash
 koha.user in the OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-jEMXVVO6yS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 20568 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 10:04:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 09:04:10 +0000
Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the
 reason access is granted
In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21198-70-kO5CgEDZ0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198
Bug 21198 depends on bug 22071, which changed state.

Bug 22071 Summary: authenticate_api_request does not stash koha.user in the OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 10:25:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 09:25:20 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-gKtXeuZpas@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from David Nind <david at davidnind.com> ---
Nice work Jasmine!

This works as intended, and I've signed it off.

For future test plans it might help if they are a little bit more detailed
(this makes it easier and quicker for sign off and QA), for example:

1. Search for a patron (Patrons > Search > Select a patron)
2. Add an invoice for a patron (Accounting > Create manual invoice)
3. Before applying the patch check that when you click on the Pay and Write off
buttons (under Accounting > Make a payment) the tab titles change to the old
terms used 'Account' and 'Pay fines'
4. After applying the patch click on the Pay and Write off buttons again
5. Confirm that first tab title is now 'Transactions'
6. Confirm that second tab title is now 'Make a payment'

I was able to figure it out, so no worries.

Keep up the good work!

David

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 11:24:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 10:24:43 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-fDHG1oPf67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from David Nind <david at davidnind.com> ---
Hi Ethan.

This works for the Write off button.

I think this should also be done for the other buttons as well - Pay, Pay
amount, Pay selected, and Write off selected.

I also noticed that for the row of buttons at the bottom (Pay, Pay amount, Pay
selected, and Write off selected) when you press cancel on the individual
screens that it takes you back to the Transactions tab, rather than Make a
payment tab. This should probably be added as separate bug.

Note that bug 18661 will fix the tab titles when you are in any of the payment
and write off screens so that they stay as 'Transactions' and 'Make a payment' 
(currently they are labelled Account and Pay fines).

I would also add an updated test plan to the bug as well (the QA team will
probably ask for it!), for example:

1. Search for a patron (Patrons > Search > Select a patron)
2. Add an invoice for a patron (Accounting > Create manual invoice)
3. Before applying the patch click on any of the payment or write off buttons*
(under Accounting > Make a payment) - you should notice that the tab focus is
on the search patrons field at the top of the page, rather than the payment
amount field
4. After applying the patch check that the tab focus for all of the payment or
write off buttons* is on the payment amount field (and it should be outlined in
a darker green)

* Buttons for transaction line items: Pay, Write off; Buttons at the bottom:
Pay, Pay amount, Pay selected, and Write off selected

Setting the focus on the payment amount field allows staff to more quickly
update the amount.

It is also an accessibility issue, and fixing this makes navigating the pages
easier for those using accessibility tools, such as screen readers.


David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 11:27:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 10:27:43 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-MSXmsuTRJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20702

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 11:27:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 10:27:43 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-0DoBVJczIv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19279

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 11:35:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 10:35:24 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-2eChflqJbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84026|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84046&action=edit
Bug 20569: Improved description of CheckPrevCheckout system preference

The CheckPrevCheckout preference can be overriden by a setting in the
patron categories, I've edited the options to reflect this.

Test plan:
1. Check the CheckPrevCheckout system preferences and confirm that the
options are clear

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 11:36:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 10:36:32 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-ZrcuqTeU9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
This makes it clearer. Nice work Jasmine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 11:54:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 10:54:34 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-6OLX7rQNTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
How can we continue here ?
Can someone benchmark on a sandbox ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:03:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:03:53 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-wOYo9SzV64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Oh, there is also nearly the same code in additem.pl for @hostitemnumbers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:17:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:17:04 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-9ougdWg6bs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:16:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:16:46 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-EXMG0sDYTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84015|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84047&action=edit
Bug 20865: Removed space before : on order receive filters

I removed space before : on order receive filters

To find this change:
1. Create a vendor
2. Create a basket and add an order to basket
3. Close basket and select 'receive shipment'
4. Check that filter options found on the left side of the page finish with a
colon and that there is no space before the colon

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:18:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:18:45 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-DSmNKWOqCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

--- Comment #3 from David Nind <david at davidnind.com> ---
It might pay to check other filters in the acquisitions area to see if there
are any other like this. This patch fixed for this occurrence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:25:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:25:08 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-V4w02fDfKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84016|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84048&action=edit
Bug 22029: Google plus has been removed from the social links.

For testing:
1) Make sure SocailNetworks is enabled
2) Find a book and verify that in the social links, there is a Google
Plus option
3) apply patch and verify that the Google Plus option is no longer there

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:28:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:28:14 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-BbGMoBDnYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

--- Comment #4 from David Nind <david at davidnind.com> ---
Nice work Helene!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:45:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:45:45 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-GYkSePv84n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84027|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84049&action=edit
Bug 22095: Replaced dead links with working links

I have updated the broken link everywhere it occurs.

Confirm that the new link works in the installer.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 12:46:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 11:46:30 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-3vgKOV6dwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:05:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:05:32 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-l3laMJzIEv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83789|0                           |1
        is obsolete|                            |

--- Comment #97 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84050&action=edit
Bug 13937: Add support for Z39.50 responder to the Debian scripts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:08:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:08:10 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-TnanQTIBKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83951|0                           |1
        is obsolete|                            |

--- Comment #98 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84051&action=edit
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
     using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
     verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
     option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
     added to the item tags as appropriate. It should show some
     combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
     "Withdrawn", "In Transit", or "On Hold" as appropriate, or
     "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
     "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
     "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
     descriptions are used instead of the default values above.

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:08:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:08:32 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-nFEtbrdZ3f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83952|0                           |1
        is obsolete|                            |

--- Comment #99 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84052&action=edit
Bug 13937: (follow-up) Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this sub is built into fetch and this call is a duplicate

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:08:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:08:56 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-fDhHAHbhVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83953|0                           |1
        is obsolete|                            |

--- Comment #100 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84053&action=edit
Bug 13937: (follow-up) Correct error call to use self

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:09:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:09:19 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-qT97sTRiEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83954|0                           |1
        is obsolete|                            |

--- Comment #101 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84054&action=edit
Bug 13937: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:09:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:09:50 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-MQRw6F4UwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83955|0                           |1
        is obsolete|                            |

--- Comment #102 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84055&action=edit
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:10:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:10:31 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-grik6fdcZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83956|0                           |1
        is obsolete|                            |

--- Comment #103 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84056&action=edit
Bug 13937: Fix issues found in QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:11:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:11:03 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-ZZzqNvJtj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83957|0                           |1
        is obsolete|                            |

--- Comment #104 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84057&action=edit
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:11:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:11:39 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-nBgHJQnHhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83958|0                           |1
        is obsolete|                            |

--- Comment #105 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84058&action=edit
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:12:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:12:57 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-nrLiRJVT68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84050|0                           |1
        is obsolete|                            |

--- Comment #106 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84059&action=edit
Bug 13937: Add support for Z39.50 responder to the Debian scripts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:31:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:31:07 +0000
Subject: [Koha-bugs] [Bug 22140] New: More use of EasyAnalyticalRecords pref
Message-ID: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

            Bug ID: 22140
           Summary: More use of EasyAnalyticalRecords pref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords
pref is disabled, there are other places where code must be dependant on this
pref.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:31:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:31:26 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-7B5hRRfYVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20702


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702
[Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:31:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:31:26 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-Twj9NfZW65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22140


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140
[Bug 22140] More use of EasyAnalyticalRecords pref
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:32:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:32:59 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-HHhUZkZthT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19279

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:32:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:32:59 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-0hS4MEuvOu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22140

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:39:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:39:30 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-tyIlJTtP7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 84060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84060&action=edit
Bug 22140: More use of EasyAnalyticalRecords pref

Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords
pref is disabled, there are other places where code must be dependant on this
pref.

Test plan :
1) Build an analitical record with 773$0 and $9
2) Enable EasyAnalyticalRecords
3) Don't apply patch
4) Go to OPAC
5) Perform a search that displays the record, check there is the linked item
6) Open record detail page, check there is the linked item
7) Apply patch and redo 5) and 6)
8) Disable EasyAnalyticalRecords
9) redo 5) and 6), you should not see the linked item

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:39:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:39:27 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-NqouFrWHbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:41:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:41:47 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-g67P6aOFlL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #19 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Nick Clemens from comment #18)
> Hi Nancy, We have also worked around this by simply excluding that page from
> plack, it avoids the issue and allows exports to complete.

Anyone got an example of how to do that? Is it something we should do in the
strandard config, until someone comes up with a better solution? 

I think the second patch from Dobrica should be a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 13:55:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 12:55:00 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-Jwh7ou6ltE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:03:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:03:24 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-00Lf1GikT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83959|0                           |1
        is obsolete|                            |

--- Comment #107 from Ere Maijala <ere.maijala at helsinki.fi> ---
Comment on attachment 83959
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83959
Bug 13937: Fix RPN conversion

I made a mess somehow, need to clean up the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:12:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:12:11 +0000
Subject: [Koha-bugs] [Bug 22141] New: Update the Lists portion of the manual
Message-ID: <bug-22141-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22141

            Bug ID: 22141
           Summary: Update the Lists portion of the manual
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The image and directions on using lists has changed from bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228- it would be
nice if the manual correlated with what the user is actually seeing in Koha.


This is a link to the
https://koha-community.org/manual/18.05/en/html/lists.html#lists

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:14:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:14:32 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-6RwgPyn5gh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:14:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:14:25 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-o9OmtJdQJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84061&action=edit
Screenshot showing differing field orders

The changes in this patch are good, but as shown in the screenshot more changes
are needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:19:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:19:33 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-UdJtUbIby2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84051|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:19:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:19:38 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-CRG80SGVQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84052|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:19:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:19:43 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-EyZus6JYhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84053|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:19:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:19:51 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-rjBPHhUF9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84054|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:20:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:20:00 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-wy8WROoRRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84055|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:20:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:20:03 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-0dTFrJWrY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84056|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:20:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:20:09 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-nu92KedUYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84057|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:20:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:20:16 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-Ttp6Creimw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84058|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:20:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:20:22 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-woiHYHuUb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84059|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:22:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:22:00 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-pxLuPFBk3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #109 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84063&action=edit
Bug 13937: (follow-up) Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this sub is built into fetch and this call is a duplicate

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:21:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:21:40 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-PnFvI9myz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #108 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84062&action=edit
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
     using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
     verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
     option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
     added to the item tags as appropriate. It should show some
     combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
     "Withdrawn", "In Transit", or "On Hold" as appropriate, or
     "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
     "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
     "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
     descriptions are used instead of the default values above.

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:22:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:22:28 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-xJjAqi5JoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #110 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84064&action=edit
Bug 13937: (follow-up) Correct error call to use self

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:22:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:22:50 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-61u60bSHff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #111 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84065&action=edit
Bug 13937: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:23:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:23:19 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-4fALWQCEX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #112 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84066&action=edit
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:24:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:24:07 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-Paz3a75bwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #113 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84067&action=edit
Bug 13937: Fix issues found in QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:24:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:24:41 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-Ns5xl0hL2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #114 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84068&action=edit
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:25:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:25:09 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-5PH7HXG5vo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #115 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84069&action=edit
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:25:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:25:41 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-50ztCDZJOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:25:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:25:44 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-iBLbsITWZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84070&action=edit
Bug 19832: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:25:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:25:47 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-INn111uYPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84071&action=edit
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm

AddIssue already checks for holds in the item being issued and deals with them

The sip code, additionally, does not consider that multiple holds per bib
is allowed

To test:
 0 - Apply only first patch (unit tests)
 1 - Place two holds for a patron on a bib
 2 - Checkout that item via sip_cli_emulator
 3 - Note all holds are cancelled/filled
 4 - prove -v t/db_dependent/SIP/Transaction.t
 5 - it fails
 6 - Apply second patch
 7 - prove tests, all green
 8 - Place two holds on a single bib for one patron again
 9 - Checkout the item via sip_cli_emulator
10 - Only one holds is filled

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:25:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:25:50 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-GI6PEwBezf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #116 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84072&action=edit
Bug 13937: Fix RPN conversion

Fixes handling of parenthesis and removes unused quote handling.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:26:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:26:21 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-qKDSu5Cpef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #117 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84073&action=edit
Bug 13937: Add support for Z39.50 responder to the Debian scripts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:26:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:26:35 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-EtlGUk4AR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 14:33:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 13:33:51 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-3VFcgaEtzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 15:55:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 14:55:16 +0000
Subject: [Koha-bugs] [Bug 22142] New: An item's current location changes to
 blank when it is removed from Course Reserves
Message-ID: <bug-22142-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22142

            Bug ID: 22142
           Summary: An item's current location changes to blank when it is
                    removed from Course Reserves
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When removing items from a course reserve, Koha is removing the current
location field unless the current location was modified when it was added to
the course.

Steps:
1.Add an item to an existing active course reserve.
2. Modify Item Type, Shelving Location, Collection code
3.  Confirm these changes were made to the item,
4. Remove this item from an active course reserve.
5. See that the item type, shelving location and collection code was reverted
to its original value, however, see that the Current Location is now empty.



Steps:
1.Add an item to an existing active course reserve.
2. Modify Item Type, Shelving Location, Collection code, and Holding Library
3.  Confirm these changes were made to the item,
4. Remove this item from an active course reserve.
5. See that the item type, shelving location and collection code was reverted
to its original place, however, see that the Current Location correctly added
back.


This is happening on 18.05.06, 18.05.07 and 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 16:56:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 15:56:14 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-z6FWK0rgE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Jasmine, this patch works very well but I don't think it accomplishes what the
bug is about. My understanding is that the bug refers specifically to the way
the page looks when printed. To hide something in the print view we need to
address it using the print stylesheet, intranet-tmpl/prog/css/print.css.

There is a ruleset starting at about line 289 which just lists elements which
should be "display:none" when printed. I think all you need to do is add the id
of the "Rows per page" form to that list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:01:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:01:23 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-lSGaJnsU7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22143

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:01:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:01:23 +0000
Subject: [Koha-bugs] [Bug 22143] New: Fix permission and owner of
	configuration backups
Message-ID: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

            Bug ID: 22143
           Summary: Fix permission and owner of configuration backups
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net
  Target Milestone: ---

If you install Koha with the Debian packages you get backups in
/var/spool/koha/<instance>/ that look like this:

-rw------- 1 root root            6616261 jan.  12 03:11
xxxxxxxx-2019-01-12.tar.gz
-rw-r----- 1 root xxxxxxxx-koha 109473282 jan.  13 03:10
xxxxxxxx-2019-01-13.sql.gz
-rw------- 1 root root            6677496 jan.  13 03:10
xxxxxxxx-2019-01-13.tar.gz
-rw-r----- 1 root xxxxxxxx-koha 109473283 jan.  14 03:20
xxxxxxxx-2019-01-14.sql.gz
-rw------- 1 root root            6721580 jan.  14 03:20
xxxxxxxx-2019-01-14.tar.gz
-rw-r----- 1 root xxxxxxxx-koha 109473282 jan.  15 03:16
xxxxxxxx-2019-01-15.sql.gz
-rw------- 1 root root            6723809 jan.  15 03:16
xxxxxxxx-2019-01-15.tar.gz
-rw-r----- 1 root xxxxxxxx-koha 109473283 jan.  16 03:17
xxxxxxxx-2019-01-16.sql.gz
-rw------- 1 root root            6770890 jan.  16 03:17
xxxxxxxx-2019-01-16.tar.gz

Notice the difference in the permissions and the ownership of the files. 

Recently, I tried to turn on download of backups from the "Export" tool, with
these settings in koha-conf.xml: 

 <backup_db_via_tools>1</backup_db_via_tools>
 <backup_conf_via_tools>1</backup_conf_via_tools>

This worked nicely for the db files, but not for the conf files, where the page
just said "Unfortunately, no backups are available."

I found a workaround was to do the following: 

  $ sudo chmod 0640 /var/spool/koha/<instance>/*
  $ sudo chown root:<instance>-koha /var/spool/koha/<instance>/*

After this, the files showed up as expected. This is due to the check on line
342 of /usr/share/koha/intranet/cgi-bin/tools/export.pl:

  return unless ( -f $filename && -r $filename );

The -r mens "File is readable by effective uid/gid."

Looking around in Bugzilla, I found a patch for this problem, by Dobrica
Pavlinusic, on bug 8437. That bug is mainly about downloading large files with
Plack, and the permissions issue described here is fixed in a followup patch. I
will try and move that patch to this bug, so the discussion about Plack does
not block fixing the permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:03:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:03:18 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-EfubCpBqUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 84074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84074&action=edit
Patch from Bug 8437

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:40:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:40:07 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-vMP9tpA4Qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 84075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84075&action=edit
Bug 22143 - Fix permission and owner of configuration backups

This allows backups created using Debian package to show up
automatically in web interface and makes permissions of backup
files consistent.

Signed-off-by: Magnus Enger <magnus at libriotech.no>

Original patch by Dobrica Pavlinusic. Moved from Bug 8437 by me.
Tested thusly:
- Look at backup files in /var/spool/koha/<instance>/
- Notice that permissions for .tar.gz files are -rw-------
- Notice ownership of .tar.gz files are root:root
- Apply this patch
- Make sure the changes in the patch are applied to the script
  you run when you run "sudo koha-dump". This might include
  copying debian/scripts/koha-dump to /usr/sbin/koha-dump, if
  you are on a gitified setup.
- Run the modified koha-dump
- Notice that both backup files dated today are now -rw-r-----
  and ownership is root:<instance>-koha

For extra testing credit:
Set <backup_conf_via_tools>1</backup_conf_via_tools> in koha-conf.xml
and verify that no files are listed under Tools > Export > Export
configuration initially. After patching and running koha-dump the
.tar.gz with the current date should show up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:41:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:41:10 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-0Vz4OjWhy7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84074|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:41:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:41:35 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-Tlg8x6g9XR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:41:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:41:50 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-x9CWGifAGe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:42:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:42:42 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-lpK5nKymiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11355|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 18:44:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 17:44:46 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-1bf5iNKv1Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #20 from Magnus Enger <magnus at libriotech.no> ---
I have taken the liberty of moving the second patch from Dobrica to a dedicated
bug: Bug 22143. I also signed it off. Obsoleting the patch here to avoid
confusion. 

Also setting this bug to "In discussion", since there does not seem to be a
clear plan for solving the main problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 19:55:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 18:55:11 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-oaExyg7U6d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I reviewed the patches, everything looks good. I fixed minor issues too.
Will mark PQA once I cover all the changes on the UI too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:23:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:23:04 +0000
Subject: [Koha-bugs] [Bug 22144] New: Add method marc() to Koha::Biblio
Message-ID: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

            Bug ID: 22144
           Summary: Add method marc() to Koha::Biblio
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

It would be very convenient to be able to retrieve a bib's MARC::Record object
directly from biblio object. This would be very useful for Template Toolkit
syntax in slips and notices where a library would like to use arbitrary MARC
fields that aren't stored in the database.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:27:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:27:27 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-HvpyK1yzgO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:27:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:27:30 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-Mzs89qiqCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84076&action=edit
Bug 22144: Add method marc() to Koha::Biblio

It would be very convenient to be able to retrieve a bib's MARC::Record object
directly from biblio object. This would be very useful for Template Toolkit
syntax in slips and notices where a library would like to use arbitrary MARC
fields that aren't stored in the database.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Biblio.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:27:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:27:43 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-HhN24s420R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:52:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:52:28 +0000
Subject: [Koha-bugs] [Bug 22094] REST API: Add endpoint /serials
In-Reply-To: <bug-22094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22094-70-XTO9YAyISU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22094

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:53:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:53:00 +0000
Subject: [Koha-bugs] [Bug 22096] Missing default values in 'social_data'
	table
In-Reply-To: <bug-22096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22096-70-mPlW1ZDmHR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22096

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:53:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:53:20 +0000
Subject: [Koha-bugs] [Bug 22100] REST API: Add endpoint /subscriptions LIST
In-Reply-To: <bug-22100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22100-70-PezGnrLzdo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22100

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:55:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:55:27 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-UaWkHIFNBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:55:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:55:31 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-b6uLTk0Ku0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84049|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84077&action=edit
Bug 22095: Replaced dead links with working links

I have updated the broken link everywhere it occurs.

Confirm that the new link works in the installer.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:56:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:56:21 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-4EABHXHbJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Ethan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:56:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:56:44 +0000
Subject: [Koha-bugs] [Bug 22123] Hardcoded values in subfield constraint
	visibility
In-Reply-To: <bug-22123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22123-70-0sN7dd21mM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22123

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:57:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:57:01 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-fvoSoMIf4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |olivialokm at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:58:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:58:21 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-axNWyjSj53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:58:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:58:25 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-oBIfmlj8Ml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84029|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84078&action=edit
Bug 20165: Changed uppercase letter to a lowercase letter in the patron search
search fields under the plus option.

Changed "Street Address" to "Street address" in the patron search search
fields under the plus sign to fit Koha's capitalization rules.

To find this change:

1. Go to Patrons and switch in the search to search patrons
2. Click on the plus sign
3. Check "Search fields" pull down
4. "Street Address" should now be "Street address"

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 20:59:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 19:59:55 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical lables
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-4RSiGw6XA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |olivialokm at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:00:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:00:04 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical labels
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-tjB36pZWPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inventory form has 2        |Inventory form has 2
                   |identical lables "Library:" |identical labels "Library:"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:01:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:01:20 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical labels
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-lgK3dSa1cq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84030|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84079&action=edit
Bug 20634: Changing the identical label "Library:" to "Location" in Inventory
Home.

To find fix:

1. Go to tools
2. Go to Inventory
3. Verify that under Item location filters the label should be "Location"

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:01:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:01:17 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical labels
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-4BK8nPjQIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:03:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:03:34 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-SpC4VrE3Z7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with David in that I understand the : as a hint to not enter it. Tomas,
could you take a look at comment 3 and comment please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:05:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:05:28 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-sOnfGWrK0v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:07:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:07:05 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-7I7AquIMsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:07:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:07:16 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-euWHQnxLfd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:07:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:07:19 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-Dq9xeSt3qx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84045|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84080&action=edit
Bug 22138: updated tab names on members/paycollect.pl

Test plan:
1. Give patron outstanding fees
2. Search patron and select 'Make payment'
3. Select either 'Pay' or 'Write off'
4. Confirm that first tab title remains as 'Transactions'
5. Confirm that current tab title remains as 'Make a payment'

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:08:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:08:12 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-xJGkIKBRm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:11:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:11:16 +0000
Subject: [Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by
 default for new installations
In-Reply-To: <bug-22044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22044-70-PBZow76THu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Nick, don't make your QAM grumpy, assign your bugs! ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:11:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:11:35 +0000
Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
In-Reply-To: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22046-70-sexNPRvWIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:12:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:12:25 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-noRtYCZSCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:12:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:12:07 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-aB2wutyj9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at helsin
                   |ity.org                     |ki.fi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:12:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:12:57 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-6SEsuooWxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:12:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:12:44 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-zr0WW6Qpt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |ethan.amohia at gmail.com
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:13:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:13:21 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-pmHb8fn2Dk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:13:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:13:47 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-O004I4u2gS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:14:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:14:06 +0000
Subject: [Koha-bugs] [Bug 22130] Batch checkout : authorized value
 description is never shown with notforloan status.
In-Reply-To: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22130-70-HhNH2FAK2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:15:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:15:55 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-BGCCHhFuuO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84046|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84081&action=edit
Bug 20569: Improved description of CheckPrevCheckout system preference

The CheckPrevCheckout preference can be overriden by a setting in the
patron categories, I've edited the options to reflect this.

Test plan:
1. Check the CheckPrevCheckout system preferences and confirm that the
options are clear

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:15:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:15:51 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-QFavhz4Icw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:18:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:18:22 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-p8KDoh3b8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84047|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84082&action=edit
Bug 20865: Removed space before : on order receive filters

I removed space before : on order receive filters

To find this change:
1. Create a vendor
2. Create a basket and add an order to basket
3. Close basket and select 'receive shipment'
4. Check that filter options found on the left side of the page finish with a
colon and that there is no space before the colon

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:18:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:18:19 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-LgKx2Oigu0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:21:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:21:11 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-GS0Z9xx3XB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:21:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:21:15 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-ffqmDIj3xP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84083&action=edit
Bug 22011: Fixed Typo on batchMod-edit.tt

1. Navigate to tools, then batch item modification.
2. Input a valid barcode into the barcode list input field, and press
continue.
3. Under the Edit items heading, text should display "Checking the box
right next the subfield ..."
4. Apply patch and refresh page, text should now display "Checking the
box right next to the subfield ..."

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:21:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:21:36 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-nlzsrOrpbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Jack!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:21:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:21:47 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-6nXxZ4zRSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:23:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:23:54 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-7rieV6dkLc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21926
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:23:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:23:54 +0000
Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference
	description
In-Reply-To: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21926-70-xnSYJiwx3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22133

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:24:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:24:06 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-IgWWxYVLH3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:24:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:24:10 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-pWYtjDaljz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84084&action=edit
Bug 21930: Reworded message on permissions.inc

1. Go to patrons account, more, Set Permissions.
2. Dropdown the Parameters section.
3. Text should display "If not set the logged in user could only edit
circulation rules for its the own library (please note that
        manage_circ_rules is still required)"
4. Apply patch and reload page
5. Text should now display "Edit circulation rules from any library. If
not set the logged in user could only edit circulation rules for their
own library (please note that manage_circ_rules is still required)"

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:24:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:24:22 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-GDAguxJhTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:24:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:24:23 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-VPOx3IoGoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83942|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:24:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:24:26 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-NstZNG8Wd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84031|0                           |1
        is obsolete|                            |

--- Comment #5 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84085&action=edit
Bug 18661: Made "Replace only included patron attributes" default on patron
import

Test Plan:
1) Go to the import patrons page and notice that "Replace all patron
attributes" is selected by default in the Patron Attributes section.
2) Apply this patch
3) Go back to the import patrons page and notice that "Replace only included
patron attributes" is delected by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:24:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:24:57 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-4jA1HrTQOT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83940|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:25:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:25:46 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-TlOeZjiO9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:27:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:27:58 +0000
Subject: [Koha-bugs] [Bug 22145] New: Add a syspref to hide the 'rows per
 page' dropdown when running a report
Message-ID: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

            Bug ID: 22145
           Summary: Add a syspref to hide the 'rows per page' dropdown
                    when running a report
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When your report has very few results, this dropdown just takes up space.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:28:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:28:05 +0000
Subject: [Koha-bugs] [Bug 22145] Add a syspref to hide the 'rows per page'
 dropdown when running a report
In-Reply-To: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22145-70-zzFj7P85Ni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:35:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:35:26 +0000
Subject: [Koha-bugs] [Bug 22145] Add a syspref to hide the 'rows per page'
 dropdown when running a report
In-Reply-To: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22145-70-AnCEYiGJux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:35:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:35:28 +0000
Subject: [Koha-bugs] [Bug 22145] Add a syspref to hide the 'rows per page'
 dropdown when running a report
In-Reply-To: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22145-70-z0cNYfDPRQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84086&action=edit
Bug 22145: Created syspref to hide/show 'rows per page' from reports print
layout

Test Plan:
1. Update the database
2. Find reportRowsPerPage syspref and confirm it is set to Show by default
3. In another tab, make a new report to run or run an existing report
4. Confirm that rows per page dropdown shows
5. Change syspref to Don't show
6. Refresh report tab and confirm that rows per page dropdown doesn't
show.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:35:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:35:44 +0000
Subject: [Koha-bugs] [Bug 22145] Add a syspref to hide the 'rows per page'
 dropdown when running a report
In-Reply-To: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22145-70-1FMIgr9qyX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:36:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:36:04 +0000
Subject: [Koha-bugs] [Bug 22145] Add a syspref to hide the 'rows per page'
 dropdown when running a report
In-Reply-To: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22145-70-QRXROELuZ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:36:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:36:39 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-r92TVypIZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84085|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84087&action=edit
Bug 18661: Made "Replace only included patron attributes" default on patron
import

Test Plan:
1) Go to the import patrons page and notice that "Replace all patron
attributes" is selected by default in the Patron Attributes section.
2) Apply this patch
3) Go back to the import patrons page and notice that "Replace only included
patron attributes" is delected by default.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:37:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:37:06 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-HoFc9dmAlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen,
I think it shoudl be possible to use is_expired and is_going_to_expire from the
template without having to pass template variable from the .pl file.
I found some examples with is_child: [% IF patron.is_child %]
Can you take a look please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:37:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:37:35 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-wNBJYPlSNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from David Nind <david at davidnind.com> ---
Thanks Jasmine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:39:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:39:57 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-R11ZjiGj50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:40:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:40:00 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-00q6gFH1A0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84087|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84088&action=edit
Bug 18661: Made "Replace only included patron attributes" default on patron
import

Test Plan:
1) Go to the import patrons page and notice that "Replace all patron
attributes" is selected by default in the Patron Attributes section.
2) Apply this patch
3) Go back to the import patrons page and notice that "Replace only included
patron attributes" is delected by default.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:41:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:41:00 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-sup4Dcuy9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Jasmine! 

I'd be nice if you could add a little note to the "Text to go in the release
notes" describing the change in behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:50:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:50:25 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-YkN2QUH5iN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:50:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:50:29 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-zJxDhPT60A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84039|0                           |1
        is obsolete|                            |

--- Comment #3 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84089&action=edit
Bug 22122: Rearranged inputs from a patrons basket in Acquisitions.

Test Plan:
1. From home page, go to "Acquisitions"
2. Add a test vendor under "New vendor"
3. Give the vendor any name and click "Save"
4. Click "New Basket"
5. Give the basket a name and click "Save"
6. Click on "Add to basket"
7. Click on "From an external source"
8. Note the order of inputs (ISBN, ISSN, Title...)
9. Go back to the homepage
10. Go to "Cataloging"
11. Click on "New from Z39.50/SRU" button. A new window should open
12. The order of inputs under 'Z39.50/SRU Search' should all match the
order of inputs from step 8. (Except "Select MARC framework)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:50:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:50:40 +0000
Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference
	description
In-Reply-To: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21926-70-uMLrkT87vw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:50:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:50:44 +0000
Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference
	description
In-Reply-To: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21926-70-tIU123GMr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82892|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84090&action=edit
Bug 21926: Enhance OAI-PMH:archiveID system preference description

Test plan:
1) Apply the patch
2) Go to Administration -> System preferences -> Web services, section
OAI-PMH
3) See description on OAI-PMH:archiveID and confirm it does make sense
and have the link to implementation guidelines

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:54:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:54:16 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-m2ZUnaIZR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:54:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:54:20 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-s24ARQnHeH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84048|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84091&action=edit
Bug 22029: Google plus has been removed from the social links.

For testing:
1) Make sure SocailNetworks is enabled
2) Find a book and verify that in the social links, there is a Google
Plus option
3) apply patch and verify that the Google Plus option is no longer there

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:54:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:54:36 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-HsGw9P9X3R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
A good deed :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:54:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:54:42 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-7YLhWxZbq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:57:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:57:53 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-IIx0LuNvpD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:57:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:57:56 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-5FB91KS8c1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

--- Comment #3 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84092&action=edit
Bug 20679: Removed 'rows per page' from report print layout

Test plan:
1. Create a report or view an existing report
2. Notice that 'Rows per page:' is visible
3. Print report (Ctrl+P)
4. Confirm that on printed report, 'Rows per page:' is no longer visible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:57:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:57:58 +0000
Subject: [Koha-bugs] [Bug 22146] New: import_patrons command line script
 should accept quote_char or document that doulbe quotes are required
Message-ID: <bug-22146-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22146

            Bug ID: 22146
           Summary: import_patrons command line script should accept
                    quote_char or document that doulbe quotes are required
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
  Target Milestone: ---

The cli import tool assumes that csv files use double quotes as the quote_char
- but it doesn't say that - we should either take a apram or document the
requirement

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:59:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:59:26 +0000
Subject: [Koha-bugs] [Bug 22146] import_patrons command line script should
 accept quote_char or document that double quotes are required
In-Reply-To: <bug-22146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22146-70-f9RDMEGZSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22146

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|import_patrons command line |import_patrons command line
                   |script should accept        |script should accept
                   |quote_char or document that |quote_char or document that
                   |doulbe quotes are required  |double quotes are required
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 21:59:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 20:59:48 +0000
Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by
 cardnumber if userid exists in file and in Koha
In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21465-70-SWYsKeSlFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jesse Maseto from comment #16)
> This was backported to 18.05.x for 18.05.07

I think it is in 18.05.08?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:02:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:02:30 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-Wc0CqchOKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

terahuitunua at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84076|0                           |1
        is obsolete|                            |

--- Comment #2 from terahuitunua at catalyst.net.nz ---
Created attachment 84093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84093&action=edit
Bug 22144: Add method marc() to Koha::Biblio

It would be very convenient to be able to retrieve a bib's MARC::Record object
directly from biblio object. This would be very useful for Template Toolkit
syntax in slips and notices where a library would like to use arbitrary MARC
fields that aren't stored in the database.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Te Rahui Tunua <terahuitunua at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:04:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:04:23 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-GQ70bejBRm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

terahuitunua at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terahuitunua at catalyst.net.n
                   |                            |z
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:04:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:04:30 +0000
Subject: [Koha-bugs] [Bug 22147] New: Hide 'Batch modify' button when
	printing reports
Message-ID: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

            Bug ID: 22147
           Summary: Hide 'Batch modify' button when printing reports
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

To reproduce: 
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page 
4) Notice the button still shows on the printed page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:04:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:04:35 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-QBpzwnvsUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:06:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:06:32 +0000
Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the
 acquisition module home page
In-Reply-To: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16126-70-sQHDJhIGbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:06:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:06:35 +0000
Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the
 acquisition module home page
In-Reply-To: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16126-70-PH28YxWRzM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64659|0                           |1
        is obsolete|                            |

--- Comment #21 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84094&action=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
I tested the functionality and it works as expected. It also passes the QA
script.
It basically adds 'base-level' information to the acquisitions page. The only
difference
with what is displayed on the funds page is that it doesn't add the base-level
available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the
funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow
exactly as
the funds table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:10:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:10:05 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-iUPhB9VaCI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84044|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84095&action=edit
Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob"
to "cleanup_database"

To Find Fix:

1. Go to Koha Administration
2. Search PatronSelfRegistrationVerifyByEmail
3. Verify that NOTE now says "system preference requires the
cleanup_database ..."

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:10:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:10:01 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-4FvbL7K4lA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:13:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:13:29 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-mHsfoaFJBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This went a little further in removing the old script as well. I've looked it
up - we added the deprecation warning on 2015-07-28. So I think it's about
time. 

Olivia, if you'd like to, it would be nice if you could add a note to the "Text
to go in the release notes" field describing the change (old script removed,
please use... or something like that)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:13:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:13:42 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-sNwaU27hUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |olivialokm at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:19:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:19:47 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-04KDADWF94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:19:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:19:51 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-7Oq1QNmHFf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84038|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84096&action=edit
Bug 7403: Shorten CataloguingLog preference description

To test:

1) Look at value of CataloguingLog prefernce
2) Apply the patch and the value should change
3) Verify that the warning has been removed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:21:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:21:35 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-YHYC1VS37Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:23:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:23:39 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-7p1yCxrrKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Helene,

I think we also need to delete the "and update" from the line above to have it
make sense. Can you take another look please? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:24:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:24:40 +0000
Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the
 acquisition module home page
In-Reply-To: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16126-70-GK7UsCHPi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:27:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:27:04 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-D96802X9aK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|josef.moravec at gmail.com     |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like the codebase changed a bit since the patch was written. There is
a conflict now in moremember.tt. Can you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:32:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:32:23 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-YzlNKajmaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84097&action=edit
Bug 22147: Hidden 'Batch modify' button on report print layout

Test plan:
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page
4) Notice the button no longer shows on the printed page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:32:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:32:20 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-iOP2WW2DKp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:33:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:33:46 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-AFujYmevoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:47:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:47:56 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-HfD8r5MdGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:47:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:47:52 +0000
Subject: [Koha-bugs] [Bug 22148] New: Cancelling some payments/writeoffs
 redirects to unexpected page
Message-ID: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

            Bug ID: 22148
           Summary: Cancelling some payments/writeoffs redirects to
                    unexpected page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Go to a patron's account, then Accounting tab
Create a manual invoice and save
Go to Make a payment tab
Click 'Pay amount', then cancel
Notice you are redirected to the Transactions tab, rather than back to Make a
payment
The behaviour is the same for Pay selected and Writeoff selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 22:51:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 21:51:43 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-nLEj1JXEFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Nind from comment #4)
> 
> I also noticed that for the row of buttons at the bottom (Pay, Pay amount,
> Pay selected, and Write off selected) when you press cancel on the
> individual screens that it takes you back to the Transactions tab, rather
> than Make a payment tab. This should probably be added as separate bug.
> 
This can be fixed at Bug 22148.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:00:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:00:46 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-xAAFecIYaR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:00:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:00:50 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-8r2NpRQaz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

--- Comment #2 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84098&action=edit
Bug 20491: Test plan: 1) Go to admin, then to MARC frameworks, then to default
frameworks structure, then subfield stucture for 952 2) Verify that 'q' is
described as 'checked out' 3) Go to
<intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x 4)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:09:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:09:16 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-asdwjMap5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

--- Comment #3 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84099&action=edit
Bug 20491: Updating the MARC subfield desciption of 952q

Test plan:
1) Go to admin, then to MARC frameworks, then to default
frameworks structure, then subfield stucture for 952
2) Verify that 'q'
is described as 'checked out'
3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
4) Verify
that 'q' is also descirbed as 'Checked out' in
5) Apply patch and update
your database
6) Verify that the description of 'q' has changed to 'Date
due'
7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
6) Verify that it has changed to 'Date due'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:09:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:09:47 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-nGKi2WzDWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:16:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:16:49 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-iZRefCxOSu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:16:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:16:52 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-6TJLQHGl0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84034|0                           |1
        is obsolete|                            |

--- Comment #6 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84100&action=edit
Bug 20527: Significant inputs will be focused on in the "Accounting" section of
a patron.

Test Plan:
1. From the homepage, select Patrons.
2. Search for any patron and select any patron.
3. You should be seeing the patrons' details. On the left, select "Accounting".
4. Click on "Pay".
5. The "Collect from patron" field should be focused. This means you
should not have to click on the input field to start typing, it should
already be selected. Confirm that this
works.
6. Click "Cancel" and you should be back to the "Make a payment" tab.
7. Click on "Write off".
8.The "Writeoff amount" field should be focused. Confirm that this
works.
9. Click "Cancel" and you should be back to the "Make a payment" tab.
10. Click on "Pay amount".
11. The "Collect from patron" field should be focused. Confirm that this
works.
12. Click "Pay fines" tab and you should be back to the "Make a payment" tab.
13. Click on "Pay selected".
14. Repeat steps 12 & 13.
15. Click  on "Write off selected".
16. The "Writeoff amount" field should be focused. Confirm that this
works.
17. Click "Pay fines" tab and you should be back to the "Make a payment" tab.
18. Click the "Create manual invoice".
19. The "Amount" field should be focused. Confirm that this works.
20. Click on "Create manual credit".
21. The "Amount" field should be focused. Confirm that this works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:20:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:20:43 +0000
Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21622-70-OqaeuXVsOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:20:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:20:47 +0000
Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21622-70-D0QBjGEHld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81725|0                           |1
        is obsolete|                            |

--- Comment #8 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84101&action=edit
Bug 21622: Adjust incorrect GROUP BY clauses in acqui script

acqui/ordered.pl:    GROUP BY aqorders.ordernumber
acqui/spent.pl:    GROUP BY aqorders.ordernumbe

'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY

Test plan:
- Create orders for different basket and using different funds
- Receive some of them
- Hit the ordered and spent pages (from the acqui home page)
=> The tables must contain the same data with and without this patch

Signed-off-by: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:23:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:23:28 +0000
Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences
 (administration page, example for geolocation)
In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20106-70-zJ7glsUBrg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
The geolocation is looking for longitude and latitude. A nice recognisable
example might be:
Longitude of Eiffel Tower: 2.294481
Latitude of Eiffel Tower: 48.858370

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:41:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:41:24 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-jS01hHMwJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:41:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:41:27 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-FkWHxIbkaf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

--- Comment #1 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84102&action=edit
Bug 22148: Changed where user is redirected by cancelling payment

To test:
1) Create a manual invoice and save
2) Go to Make a payment tab
3) Click 'Pay amount', then cancel
4) Notice you are redirected to the Transactions tab, rather than back to
Make a payment
5) Also try this with Pay selected and write off selected result when
cancelling should be the same
6) Apply patch and try steps 2-6 again
7) Verify that you are now redirected to the 'make a payment tab'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:42:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:42:01 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-UvtLKRhj4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hickeyhe at wgc.school.nz
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:42:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:42:01 +0000
Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests
In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21692-70-cIMoMFO85T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
These tests will go in t/db_dependent/Koha/Account.t
This page may help: https://wiki.koha-community.org/wiki/Unit_Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:42:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:42:24 +0000
Subject: [Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no
	tests
In-Reply-To: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21691-70-PKizZXCk0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
These tests will go in t/db_dependent/Koha/Account.t
This page may help: https://wiki.koha-community.org/wiki/Unit_Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:43:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:43:18 +0000
Subject: [Koha-bugs] [Bug 21688] Koha::Account->balance has no tests
In-Reply-To: <bug-21688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21688-70-BnEWh7eUwP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21688

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
These tests will go in t/db_dependent/Koha/Account.t
This page may help: https://wiki.koha-community.org/wiki/Unit_Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:58:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:58:18 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-rcSVuv1KZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 16 23:58:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 22:58:21 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-oGPKnO7BtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84040|0                           |1
        is obsolete|                            |

--- Comment #12 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84103&action=edit
Bug 19818: Added appropriate id to all the list items under libary use heading.

1) Go to the patron details for a patron
2) On the right of the screen, right click one of the labels below
'Library use' etc, and Inspect Element
3) View <li> tags which should now each have a unique <id> tag for each

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:01:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:01:34 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-i9pGZ5ibyu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:01:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:01:26 +0000
Subject: [Koha-bugs] [Bug 22149] New: Grammar fix in the
 manage_circ_rules_from_any_libraries description
Message-ID: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

            Bug ID: 22149
           Summary: Grammar fix in the
                    manage_circ_rules_from_any_libraries description
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

>From Bug 21930: 

"Manage circulation rules from any library. If not set the logged in user can
only edit circulation rules from their own library (please note that
manage_circ_rules is still required)."

Should 'from' in both occurences be 'for'?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:01:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:01:57 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-dCTQsW0RVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Nind from comment #4)
> Note: I prefer Katrin's wording, but I don't know whether I understand what
> exactly is required for the wording, except to remove 'the':
> 
> "Manage circulation rules from any library. If not set the logged in user can
> only edit circulation rules from their own library (please note that
> manage_circ_rules is still required)."
> 
> Should 'from' in both occurences be 'for'?

I have made Bug 22149 for this to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:14:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:14:05 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-ZIS1Z9QtYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
         Depends on|                            |21930


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930
[Bug 21930] Typo in the manage_circ_rules_from_any_libraries description
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:14:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:14:05 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-up36CiBAsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22149


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149
[Bug 22149] Grammar fix in the manage_circ_rules_from_any_libraries description
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:14:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:14:08 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-hXCjxbCVhv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84104&action=edit
Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries
description

Test plan:
1. Review patch and confirm that the sentence makes sense

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:14:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:14:12 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-qYRnKlVdmY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:14:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:14:15 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-GZlgb8wLo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

--- Comment #3 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84105&action=edit
Bug 21290: Cool thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:15:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:15:20 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-YqyYti6xsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:22:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:22:56 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-Az6VfnJ1k9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84035|0                           |1
        is obsolete|                            |
  Attachment #84105|0                           |1
        is obsolete|                            |

--- Comment #4 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84106&action=edit
Bug 21290: Updating documentation for ModItem

To test:
Review the patch and check it is now updated correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:35:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:35:46 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-nev5EKzElO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84043|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:37:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:37:54 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-PYaZHoqbQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:37:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:37:57 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-hjLcE4LtDQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84092|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84107&action=edit
Bug 20679: Removed 'rows per page' from report print layout

Test plan:
1. Create a report or view an existing report
2. Notice that 'Rows per page:' is visible
3. Print report (Ctrl+P)
4. Confirm that on printed report, 'Rows per page:' is no longer visible

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:39:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:39:46 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-GTGA513LGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 00:40:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Jan 2019 23:40:07 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-PaKuxmwbB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:09:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:09:45 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-bFzIbraajK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Thanks Cait -- You're right that patron.is_expired works right in the template,
but patron.is_going_to_expire doesn't seem to work as it should. It always
evaluates as true. I'll see if I can figure out why.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:13:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:13:41 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-rbeV83yl7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:13:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:13:44 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-RAjptptd5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84089|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84108&action=edit
Bug 22122: Rearranged inputs from a patrons basket in Acquisitions.

Test Plan:
1. From home page, go to "Acquisitions"
2. Add a test vendor under "New vendor"
3. Give the vendor any name and click "Save"
4. Click "New Basket"
5. Give the basket a name and click "Save"
6. Click on "Add to basket"
7. Click on "From an external source"
8. Note the order of inputs (ISBN, ISSN, Title...)
9. Go back to the homepage
10. Go to "Cataloging"
11. Click on "New from Z39.50/SRU" button. A new window should open
12. The order of inputs under 'Z39.50/SRU Search' should all match the
order of inputs from step 8. (Except "Select MARC framework)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:21:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:21:58 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-jqndMuagb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #11)
> It looks like the codebase changed a bit since the patch was written. There
> is a conflict now in moremember.tt. Can you please rebase?

Helene is your patch supposed to be applied on master with or without the
patches already on this bug? The older patches don't apply now. The best way to
approach this might be to obsolete the older patches and re-implement their
changes on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:58:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:58:15 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-0U34g6t6uK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:58:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:58:18 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-nXsjFXHCsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70675|0                           |1
        is obsolete|                            |

--- Comment #5 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84109&action=edit
Bug 19994: Used Modern::Perl in Authorities perl scripts

Test plan:
1. Review code of the following files and confirm that 'use Modern::Perl;' is
used in place of
'use strict; use warnings;'

auth_finder.pl
authorities-home.pl
authorities.pl
blinddetail-biblio-search.pl
detail-biblio-search.pl
detail.pl
export.pl
merge.pl
merge_ajax.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 01:59:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 00:59:11 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-CqN5VRzSRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 02:09:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 01:09:22 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-4XdfUL32Oz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

--- Comment #7 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84110&action=edit
Bug 20527: Removing focus from payment note

Did not mean to leave this in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 02:12:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 01:12:08 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-fRXvK2ajrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 02:12:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 01:12:12 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-mBrR3UVU6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70555|0                           |1
        is obsolete|                            |
  Attachment #70641|0                           |1
        is obsolete|                            |
  Attachment #84103|0                           |1
        is obsolete|                            |

--- Comment #14 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84111&action=edit
Bug 19818: Thanks, this patch should work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 02:54:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 01:54:59 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-E7zkgL8eLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

--- Comment #2 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84112&action=edit
Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table

Test plan:
1. From homepage, go to Koha Amdinistration
2. Go to Authorised Values
3. Scroll down to ITEMTYPECAT and click Add
4. Give the new authorised value an Authorised value and Description
5. Save it
6. On the left, go to Item types
7. Click Edit on an item type
8. Under Search Catergory, select the new authorised value you just
created. It should appear in the dropdown as it's description
9. Click Save changes
10. Under Search category for the item type you just edited, you should see
your new authorised values' description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 02:54:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 01:54:57 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-psDbKphsPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 02:55:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 01:55:45 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-lpZCLJ6vcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |ethan.amohia at gmail.com
                 CC|                            |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:02:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:02:54 +0000
Subject: [Koha-bugs] [Bug 21446] Permanent location should show instead of
 cart location - course-details.tt
In-Reply-To: <bug-21446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21446-70-v4rPTMlOeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:02:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:02:58 +0000
Subject: [Koha-bugs] [Bug 21446] Permanent location should show instead of
 cart location - course-details.tt
In-Reply-To: <bug-21446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21446-70-RkTR4Qm4GY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82106|0                           |1
        is obsolete|                            |

--- Comment #10 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84113&action=edit
Bug 21446: Remove fix comment

Fix is not needed.

Signed-off-by: helene hickey <hickeyhe at wgc.school.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:03:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:03:01 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-svYMX71eRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:06:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:06:33 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-KfZiLu3V6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:07:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:07:21 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-oeTwFEXVZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:09:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:09:04 +0000
Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences
 (administration page, example for geolocation)
In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20106-70-1pkjg5xw9W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:09:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:09:06 +0000
Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences
 (administration page, example for geolocation)
In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20106-70-mEGtUPxHqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84114&action=edit
Bug 20106: Hea - Added notes to sysprefs (administration page, example for
geolocation)

Test plan:
1) Go to system preferences and search for UsageStats.
2) Confirm that the system preferences all have a note with a link directing
user to a page to
update their usage statistics
3) In system preferences for UsageStats, notice that the description of
sys pref 'UsageStatsGeolocation' provides an example with the Eiffel
Tower's geolocation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:09:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:09:32 +0000
Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences
 (administration page, example for geolocation)
In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20106-70-iqaqpYfFZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:11:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:11:47 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-3MebfyzXWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:22:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:22:43 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-54fnhvqYpm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #440 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84115&action=edit
Bug 7143: Update about page for new devs (Academy)wq

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:26:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:26:25 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-9Resykhm5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Olivia! Congratulations on your first patch!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:26:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:26:51 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-KRw4Wrc840@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Ethan! Congratulations on your first patch!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:27:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:27:17 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-IWbR63lZTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Helene! Congratulations on your first patch!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:27:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:27:42 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-j8zVgThyrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Olivia!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:28:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:28:24 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-XYRAGRtdbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Jasmine! Congratulations on your first patch!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:28:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:28:56 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-lbxx0JJkAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Jasmine!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:29:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:29:30 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-GBI3Tsiq6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Mackey! Congratulations on your first patch!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:29:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:29:54 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-zDClmTb4iW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work Jack! Congratulations on your first patch!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:30:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:30:27 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-coSOF5be7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #441 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #440)
> Created attachment 84115 [details] [review]
> Bug 7143: Update about page for new devs (Academy)wq

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:30:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:30:46 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-QbnTMwwHDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|magnus at libriotech.no        |jasmineamohia.student at wegc.
                   |                            |school.nz
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:31:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:31:38 +0000
Subject: [Koha-bugs] [Bug 22150] New: Make it easier to unselect one member
 permission after selecting all
Message-ID: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

            Bug ID: 22150
           Summary: Make it easier to unselect one member permission after
                    selecting all
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

Go to a patron account page
Click more -> Set permissions

At the moment, if you select Superlibrarian, it is the same as selecting all.
However, you can't then unselect one permission because the checkboxes are
disabled. It is very slow and tedious to have to select every other checkbox
one by one.

There should be a way to disable the checkboxes when I want to unselect one or
some permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:31:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:31:55 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-OkBIDFifNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:33:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:33:04 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-X57M3spJMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:33:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:33:08 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-SxO7UdqdF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

--- Comment #2 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84116&action=edit
Bug 15110: I have changed the description to include the words suggested.

To test:
1) Apply patch
2) Go to Koha admin
3) Search in system prefernces for 'high demand'
4) Verify that the system prefernce 'decreaseLoanHighHolds' is in the
results of the search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:33:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:33:47 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-TjGRvri4QK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hickeyhe at wgc.school.nz
           Assignee|jke0429 at stacmail.net        |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:41:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:41:42 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-p3q7wBRyFJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:41:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:41:44 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-4TcvpbtXkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

--- Comment #1 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84117&action=edit
Bug 11922: Added SHOW_BCIDE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:45:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:45:25 +0000
Subject: [Koha-bugs] [Bug 11996] default active currencies for ru-RU and
 uk-UA are probably wrong
In-Reply-To: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11996-70-bpdat0YpRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:45:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:45:28 +0000
Subject: [Koha-bugs] [Bug 11996] default active currencies for ru-RU and
 uk-UA are probably wrong
In-Reply-To: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11996-70-yD0jZbO26L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996

--- Comment #1 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84118&action=edit
Bug 11996: Made RUB default currency for ru-RU

Didn't know how to change the uk-UA default currency.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:46:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:46:06 +0000
Subject: [Koha-bugs] [Bug 11996] default active currencies for ru-RU and
 uk-UA are probably wrong
In-Reply-To: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11996-70-4A7ad1H9Lg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |ethan.amohia at gmail.com
                   |ity.org                     |
                 CC|                            |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:54:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:54:55 +0000
Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff results list
In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17765-70-Q43u9VfkN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:54:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:54:39 +0000
Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff results list
In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17765-70-ja8tLLEwMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Hide 'Holds' link in patron |Hide 'Holds' link in staff
                   |account in staff            |results list

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
The 'Holds(In reply to Katrin Fischer from comment #5)
> I feel like the patches proposed here don't do the right thing. A staff
> patron without place_holds should still be able to see information about
> existing holds on the circ desk. 
> If people disagree, we should discuss how to achieve this without causing a
> disruption for libraries, maybe using a new separate pref? Marking 'In
> discussion' for now.

I agree with this. We must have misunderstood the original bug.

However, the original bug still stands. I'd like to change this bug description
back to the original and have a 2019 academy student write the correct fix for
that, because the current patch isn't desired behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:58:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:58:00 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-qwnhRJROij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:58:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:58:03 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-DSiQH7grMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84119&action=edit
Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes

Test plan:
1) Check all Koha/REST files and confirm that 'use Modern::Perl;' has
been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 03:58:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 02:58:26 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-x6IjAXzsdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:19:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:19:49 +0000
Subject: [Koha-bugs] [Bug 22151] New: Developer name spelled wrong in About
Message-ID: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

            Bug ID: 22151
           Summary: Developer name spelled wrong in About
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Helen Hickey should be Helene Hickey!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:19:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:19:54 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-XcmFvAkca5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:21:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:21:05 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-mqmTTpxHus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

--- Comment #21 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Magnus Enger from comment #19)
> (In reply to Nick Clemens from comment #18)
> > Hi Nancy, We have also worked around this by simply excluding that page from
> > plack, it avoids the issue and allows exports to complete.
> 
> Anyone got an example of how to do that? Is it something we should do in the
> strandard config, until someone comes up with a better solution? 
> 
> I think the second patch from Dobrica should be a separate bug.

Magnus, take a look at /etc/koha/apache-shared-intranet-plack.conf, you'll find
lines that look like this:

        ProxyPass "/cgi-bin/koha/offline_circ/process_koc.pl" "!"

... the "!" means "Don't run this under plack".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:31:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:31:27 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: <bug-12460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12460-70-TqfORVzrAz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Patch doesn't apply

--- Comment #35 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Patches need rebasing!

$ git bz apply 12460
Bug 12460 - Search history: Combine to start a new search

78648 - Bug 12460: Allow to start a new search from multiple search history
lines
78649 - Bug 12460: Simplify interface to combine queries
78650 - Bug 12460: Fix query combination for anonymous users

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12460: Allow to start a new search from multiple search history
lines
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
M       koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:31:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:31:55 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-LIzn1w8CGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:31:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:31:57 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-gmLHuJGPop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

--- Comment #1 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84120&action=edit
Bug 22151: Updated Helen to Helene

To test:
1) Go to about koha from 'more' at the top of the page
2) Press the 'koha team' tab
3) Find name 'Helen Hickey'
4) Apply patch
5) Reload page and name should change to 'Helene Hickey'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:32:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:32:17 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-CosR989mnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hickeyhe at wgc.school.nz
                   |ity.org                     |
                 CC|                            |hickeyhe at wgc.school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:37:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:37:50 +0000
Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests
In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21692-70-zzM20PGHqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:37:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:37:52 +0000
Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests
In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21692-70-ZMmFTuMp6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84121&action=edit
Bug 21692: created a test for Koha::Account->new

Test plan:
1) Run test for /Koha/Account.t and confirm that all tests were
successful

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:38:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:38:57 +0000
Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests
In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21692-70-lJa8tLBSti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jasmineamohia.student at wegc.
                   |                            |school.nz
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 04:43:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 03:43:44 +0000
Subject: [Koha-bugs] [Bug 21688] Koha::Account->balance has no tests
In-Reply-To: <bug-21688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21688-70-LrhXJkUKFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21688

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
t/db_dependent/Koha/Account.t:169
It looks like there are already tests for balance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:03:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:03:22 +0000
Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search
 language search
In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15067-70-sjAMqqwpPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:03:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:03:26 +0000
Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search
 language search
In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15067-70-9soEN8jvyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

--- Comment #11 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84122&action=edit
Bug 15067: Added translations of languages to those 5 languages.

Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq are added with
their translations to the Advanced Search languages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:06:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:06:18 +0000
Subject: [Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no
	tests
In-Reply-To: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21691-70-EcDjLK4w0d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:06:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:06:20 +0000
Subject: [Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no
	tests
In-Reply-To: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21691-70-5ToSHSgOog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691

--- Comment #2 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84123&action=edit
Bug 21691:  Created test for Koha::Account->non_issues_charges

Test Plan:
1) Run test for t/db_dependent/Koha/Account.t and confirm that all tests are
successful

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:06:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:06:42 +0000
Subject: [Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no
	tests
In-Reply-To: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21691-70-wwC9dZ0ZfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz
           Assignee|chris at bigballofwax.co.nz    |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:12:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:12:17 +0000
Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search
 language search
In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15067-70-ArQpcgsyOR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84122|0                           |1
        is obsolete|                            |

--- Comment #12 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84124&action=edit
Bug 15067: Added translations of languages to those 5 languages.

Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq are added with
their translations to the Advanced Search languages.

Test Plan:
1. From homepage, go to Advanced search
2. Click on More options next to the Search button
3. Scroll down to the Limits section
4. Click on Language: No limit
5. Find Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq at the
bottom of the dropdown.
6. They should all be there.
7. Estonian and Latvian are repeated, this need to be fixed.
8. They need to be put in alphabetical order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 05:12:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 04:12:36 +0000
Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search
 language search
In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15067-70-nedCRGwuQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.amohia at gmail.com
           Assignee|ellermaugustus at gmail.com    |ethan.amohia at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:11:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:11:42 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-Lsgvk9GNhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it is on purpose - superlibrarian means all, but it's actually more
than 'all'. Superlibrarians can do more than some of the permissions,
especially when it comes to Independentbranches. So there would be conflicts if
you could have superlibrarian without some of the other permissions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:18:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:18:35 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-EprJReAt1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:18:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:18:38 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-oF7MYwK3sY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84120|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84125&action=edit
Bug 22151: Updated Helen to Helene

To test:
1) Go to about koha from 'more' at the top of the page
2) Press the 'koha team' tab
3) Find name 'Helen Hickey'
4) Apply patch
5) Reload page and name should change to 'Helene Hickey'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:18:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:18:57 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-cbPgDwqtbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Cheating a little and moving this directly to passed QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:24:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:24:01 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-AEGcPYWfCM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:24:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:24:05 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-Y5C6irMjXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84107|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84126&action=edit
Bug 20679: Removed 'rows per page' from report print layout

Test plan:
1. Create a report or view an existing report
2. Notice that 'Rows per page:' is visible
3. Print report (Ctrl+P)
4. Confirm that on printed report, 'Rows per page:' is no longer visible

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:26:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:26:34 +0000
Subject: [Koha-bugs] [Bug 22152] New: Hide printing the tools navigation
 when printing reports
Message-ID: <bug-22152-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152

            Bug ID: 22152
           Summary: Hide printing the tools navigation when printing
                    reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Hide the navigation showing up on the left side when printing a report page.
(see  22147 for reference)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:27:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:27:04 +0000
Subject: [Koha-bugs] [Bug 22152] Hide printing the tools navigation when
	printing reports
In-Reply-To: <bug-22152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22152-70-GD8LeeJV8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22147
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:27:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:27:04 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-AWaDPj6kyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22152

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:42:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:42:17 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-fTBhW9R00P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:42:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:42:20 +0000
Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing
	reports
In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22147-70-omElu11aRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84097|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84127&action=edit
Bug 22147: Hidden 'Batch modify' button on report print layout

Test plan:
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page
4) Notice the button no longer shows on the printed page

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:45:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:45:58 +0000
Subject: [Koha-bugs] [Bug 21840] Fix some typos in the templates
In-Reply-To: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21840-70-cpmmmfmfI2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:46:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:46:01 +0000
Subject: [Koha-bugs] [Bug 21840] Fix some typos in the templates
In-Reply-To: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21840-70-eBRkGiDyne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84036|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84128&action=edit
Bug 21840: Fixed some typos in the templates

intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13
Bibliograpic record ID --> Bibliographic record ID

intranet-tmpl/prog/en/modules/acqui/basket.tt:547
Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked
with this order cancel holds first -->  ... with this order. Cancel holds first

intranet-tmpl/prog/en/modules/acqui/parcel.tt
Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked
with this order cancel holds first --> ... with this order. Cancel holds first

intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32
Print this slabel --> Print this label

Test plan:
1. Check that the fixes in the patch are correct

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:48:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:48:13 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-RRuYRRbBHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:48:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:48:16 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-XUWRhjwybo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84108|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84129&action=edit
Bug 22122: Rearranged inputs from a patrons basket in Acquisitions.

Test Plan:
1. From home page, go to "Acquisitions"
2. Add a test vendor under "New vendor"
3. Give the vendor any name and click "Save"
4. Click "New Basket"
5. Give the basket a name and click "Save"
6. Click on "Add to basket"
7. Click on "From an external source"
8. Note the order of inputs (ISBN, ISSN, Title...)
9. Go back to the homepage
10. Go to "Cataloging"
11. Click on "New from Z39.50/SRU" button. A new window should open
12. The order of inputs under 'Z39.50/SRU Search' should all match the
order of inputs from step 8. (Except "Select MARC framework)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 07:51:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 06:51:03 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-KHxs991dVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Ethan, please take another look here, I tihnk something has gone wrong:

-                [% IF ( Koha.Preference('ExtendedPatronAttributes') == 1 ) %]
+                [% IF ( Koha.Preference(''tronAttributes) == 1 ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:04:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:04:30 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-pQyua87j0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84100|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84130&action=edit
Bug 20527: Significant inputs will be focused on in the "Accounting" section of
a patron.

Test Plan:
1. From the homepage, select Patrons.
2. Search for any patron and select any patron.
3. You should be seeing the patrons' details. On the left, select "Accounting".
4. Click on "Pay".
5. The "Collect from patron" field should be focused. This means you
should not have to click on the input field to start typing, it should
already be selected. Confirm that this
works.
6. Click "Cancel" and you should be back to the "Make a payment" tab.
7. Click on "Write off".
8.The "Writeoff amount" field should be focused. Confirm that this
works.
9. Click "Cancel" and you should be back to the "Make a payment" tab.
10. Click on "Pay amount".
11. The "Collect from patron" field should be focused. Confirm that this
works.
12. Click "Pay fines" tab and you should be back to the "Make a payment" tab.
13. Click on "Pay selected".
14. Repeat steps 12 & 13.
15. Click  on "Write off selected".
16. The "Writeoff amount" field should be focused. Confirm that this
works.
17. Click "Pay fines" tab and you should be back to the "Make a payment" tab.
18. Click the "Create manual invoice".
19. The "Amount" field should be focused. Confirm that this works.
20. Click on "Create manual credit".
21. The "Amount" field should be focused. Confirm that this works.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:04:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:04:32 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-qpSR3sHqmX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84110|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84131&action=edit
Bug 20527: Removing focus from payment note

Did not mean to leave this in.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:05:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:05:18 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-1tIemjLak3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:20:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:20:10 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-y0IH08vJO0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84102|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84132&action=edit
Bug 22148: Changed where user is redirected by cancelling payment

To test:
1) Create a manual invoice and save
2) Go to Make a payment tab
3) Click 'Pay amount', then cancel
4) Notice you are redirected to the Transactions tab, rather than back to
Make a payment
5) Also try this with Pay selected and write off selected result when
cancelling should be the same
6) Apply patch and try steps 2-6 again
7) Verify that you are now redirected to the 'make a payment tab'

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:22:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:22:12 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-EO1QiPMrRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:31:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:31:26 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-XSkFogT06X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14564
             Status|Signed Off                  |In Discussion

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Hi Magnus, this is a duplicate of bug 14564. I won't duplicate-link to it so I
don't close your bug, but please take a look and see if you agree with the
discussion. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:31:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:31:26 +0000
Subject: [Koha-bugs] [Bug 14564] Export configuration: Unfortunately,
 no backups are available.
In-Reply-To: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14564-70-mLmcwoUkEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22143

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:36:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:36:33 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-MSCdhLVw1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|In Discussion               |RESOLVED

--- Comment #4 from Magnus Enger <magnus at libriotech.no> ---


*** This bug has been marked as a duplicate of bug 14564 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:36:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:36:33 +0000
Subject: [Koha-bugs] [Bug 14564] Export configuration: Unfortunately,
 no backups are available.
In-Reply-To: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14564-70-HxJIIrXH63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #11 from Magnus Enger <magnus at libriotech.no> ---
*** Bug 22143 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 09:37:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 08:37:07 +0000
Subject: [Koha-bugs] [Bug 22143] Fix permission and owner of configuration
	backups
In-Reply-To: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22143-70-qG4zb6tVsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22143

--- Comment #5 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Mirko Tietgen from comment #3)
> Hi Magnus, this is a duplicate of bug 14564. I won't duplicate-link to it so
> I don't close your bug, but please take a look and see if you agree with the
> discussion. :)

Thanks for pointing it out, bad searching on my part.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 10:18:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 09:18:32 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-cQSBNYhHQU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78435|0                           |1
        is obsolete|                            |

--- Comment #12 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 84133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84133&action=edit
Bug 18731: /acquisitions/orders endpoint

This patches implement the /acquisitions/orders endpoint.
It uses the new pagination, query parsing and object searching plugins.

The attribute names are consistent with the voted RFC

Sponsored-by: Camden County
Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 10:18:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 09:18:40 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-qtgEDx4Cp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78436|0                           |1
        is obsolete|                            |

--- Comment #13 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 84134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84134&action=edit
Bug 18731: OpenAPI definitions

This patch introduces the OpenAPI definitions required for the orders
endpoint. It adds query parameters definitions for the reserved params:

- _match
- _order_by
- _page
- _per_page

Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 10:19:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 09:19:33 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-VZ94YKApJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #14 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
As far as I'm concerned, it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 10:27:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 09:27:32 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-gH9GmuW8gf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from David Nind <david at davidnind.com> ---
Hi Jasmine.

After reviewing this I think it should be 'for' rather than 'from'.

Also, the patch doesn't change the text.

If you could redo with the new wording as follows:

"Manage circulation rules for any library. If not set the logged in user can
only edit circulation rules for their own library (please note that
manage_circ_rules is still required)."

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 10:28:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 09:28:50 +0000
Subject: [Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no
	tests
In-Reply-To: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21691-70-oIDi32A2o2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 10:28:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 09:28:52 +0000
Subject: [Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no
	tests
In-Reply-To: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21691-70-7E3RYmcVVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 84135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84135&action=edit
Bug 21691: Created test for Koha::Account->non_issues_charges

Test Plan:
1) Run test for t/db_dependent/Koha/Account.t and confirm that all tests are
successful

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 11:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 10:23:27 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-0n9PcV2lw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84037|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 84136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84136&action=edit
Bug 19920: Removed unnecessary code from C4/Members.pm

A seperate bug (Bug 16853) removed the subroutine used in this file. I removed
the code as it had become unnecessary.

Test plan:
1. Confirm that &changepassword can't be found in C4/Members.pm

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 11:24:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 10:24:17 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-f9rL7S3999@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Thanks Jasmine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:01:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:01:59 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-jAAz3Jn4YI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84093|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84137&action=edit
Bug 22144: Add method marc() to Koha::Biblio

It would be very convenient to be able to retrieve a bib's MARC::Record object
directly from biblio object. This would be very useful for Template Toolkit
syntax in slips and notices where a library would like to use arbitrary MARC
fields that aren't stored in the database.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Te Rahui Tunua <terahuitunua at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:07:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:07:37 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-qboOe46rgt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:07:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:07:40 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-2UOMH83d2U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84032|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 84138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84138&action=edit
Bug 20274 When the system preference for item-level_itypes changed, it gives a
zero result.

1) Go to reports then catalog by item types
2) Pick a location and look at table
3) Change the system prefernce of item-level_itypes
4) Verify a zero result
5) Apply patch and retry
6) Verify that result does not change to zero on either preference

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:22:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:22:22 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-Cb9Plyqoor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:22:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:22:25 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-vuQFHLZ1cH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84106|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 84139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84139&action=edit
Bug 21290: Updating documentation for ModItem

To test:
Review the patch and check it is now updated correctly

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:54:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:54:06 +0000
Subject: [Koha-bugs] [Bug 22072] Datatable Javascript error on
	subscription-detail.pl
In-Reply-To: <bug-22072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22072-70-FUiVvQ1wO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22072

Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan.berndtsson at ub.gu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:54:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:54:33 +0000
Subject: [Koha-bugs] [Bug 20486] Add --marc_conditions option to
	export_records.pl
In-Reply-To: <bug-20486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20486-70-7b6sXnvIoV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #21 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello,
I have questions about this one : is it possible to add several filters? If
it's the case, which is the separator between the several filters? 
Could we use whatever operator in the filter (= or > or < )?

Thanks in advance!

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 13:56:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 12:56:10 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-FnEKIYCkL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
This patch works well, but I think Katrin's suggestion is the more efficient
solution. There's a shortcut for getting the description of authorised values.
The template already has [% USE AuthorisedValues %] included, so we know the
plugin is already being loaded for use:

[% AuthorisedValues.GetByCode( 'ITEMTYPECAT', itemtype.searchcategory ) | html
%]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 14:49:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 13:49:45 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-0Jng1VrXup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21964


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964
[Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 14:49:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 13:49:45 +0000
Subject: [Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap
 grid: Patrons part 2
In-Reply-To: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21964-70-NCIA7HxUFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11375


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375
[Bug 11375] Improve patrons permissions display
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 15:38:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 14:38:50 +0000
Subject: [Koha-bugs] [Bug 22153] New: Automatic item modifications by age:
 Boolean options
Message-ID: <bug-22153-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22153

            Bug ID: 22153
           Summary: Automatic item modifications by age: Boolean options
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: chris.kirby at ilsleypubliclibrary.org
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Automatic item modifications by age is limited to boolean '='. There is NOT a
boolean '!=' or even a boolean OR.
Having boolean NOT EQUAL and OR would make "Automatic item modifications by
age" much more useful. In consortium settings, this enhancement would allow
branches to opt out of aging set for the rest of the consortium.

For example, it would be possible to set a rule such as the following:
For example, 

"Age in days x days items.itype = itypename
AND items.homebranch 
!= branch name items.itype = itypename"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 15:56:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 14:56:42 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-AjosC8oiiT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83296|0                           |1
        is obsolete|                            |

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84140&action=edit
Bug 11375: Improve patrons permissions display

This patch updates the patron permissions interface in order to
emphasize permission descriptions (which can be translated) over
permission code (which cannot).

The tree structure (and jQuery plugin) is removed, and permissions are
displayed in a table-like way. Sub-permissions are shown or hidden with
a link.

A free-text filter is added to the top for narrowing the list by
keyword.

Save and cancel buttons are now in a floating toolbar.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

 - Open the "Set permissions" page for any patron.
 - Confirm that the filter works correctly to show only lines which
   match your entry
   - Note that the superlibrarian line stays visible all the time. This
     is to make it clearer that sub-permissions cannot be selected if
     superlibrarian is checked.
 - Check the superlibrarain "hint" text for clarity.
 - Test the show/hide controls.
 - Test that checking a "parent" permission displays the
   sub-permissions.
 - Test that the toolbar with Save and Cancel floats when scrolling.
 - Test that changing and saving permissions works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:07:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:07:05 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-rdXXWgrRM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
While we really need to move things into Koha::Biblio, we might better keep in
mind that we now have biblio_metadata, which isn't actually tied to a specific
serialization format and data schema.
I'm not implying we should move C4 code into Koha::Biblio to have something
like this (we should, in a mid term) but at least we should leave room for a
more general approach: at least return a metadata object, in the lines of
Koha::MetadataRecord which "can" be a MARC record.

My two cents. I will think about it, because this would benefit the API
develpment too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:07:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:07:16 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-M4Myvqmg9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:14:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:14:09 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-zFvenTVICO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:14:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:14:12 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-FLhEs5osDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84139|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84141&action=edit
Bug 21290: Updating documentation for ModItem

To test:
Review the patch and check it is now updated correctly

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:22:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:22:13 +0000
Subject: [Koha-bugs] [Bug 22154] New: Subtype search for Format - Braille
 doesn't look for the right codes
Message-ID: <bug-22154-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154

            Bug ID: 22154
           Summary: Subtype search for Format - Braille doesn't look for
                    the right codes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Zebra
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
  Target Milestone: ---

When you do an advanced search and choose the Format subtype Braille, it looks
for l-format:fk, but that is not the right code for Braille.

To reproduce:
1) In Administration > System preferences, make sure 'Subtypes' is checked in
either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 
2) Go in Advanced search
2.5) If necessary, click on 'More options'
3) In the 'Subtype limits' section, choose 'Braille' from the 'Format'
drop-down menu
4) Click on 'Search'
5) In the breadcrumbs, it says 'Search  with limit(s): 'l-format:fk''

fk does not exist. It should be fb for Tactile material/Braille OR tc for
Text/Braille

The codes for marc21 can be found here:
http://www.loc.gov/marc/bibliographic/bd007f.html

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:28:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:28:22 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-wLbAQ6t5OS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #420 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84142&action=edit
Bug 17047: QA fixes:   - don't search subscriptions when mana is disabled,   -
subscription detail page: don't show share button or search link if Mana is
disabled,   - fix report sharing,   - submit report search form by pressing
enter,   - add a waittin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:41:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:41:24 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-WtUwexGEOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

--- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84143&action=edit
Bug 11375: (follow-up) Add links to show all/hide all

This patch adds links in the toolbar to show or hide all
sub-permissions.

To test, apply the patch and view the permissions page for a patron.
Clicking the "Show all" or "Hide all" links should work to show or hide
all sub-permissions. The corresponding "Show details" and "Hide details"
links for each permission set should be correctly toggled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:44:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:44:58 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-8FBBghMAfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This conversation has nudged me to rebase my patch for Bug 11375 which
redesigns the patron permission interface.

I think that even with my redesign this is still an issue. I wonder if it could
be solved by adding "check all" and "check none" controls where "check all"
would automatically de-select the superlibrarian flag?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:49:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:49:08 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-UxjDRcCdcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:50:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:50:30 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-ywi5T9mKdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:50:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:50:33 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-ogGzWXBpW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84138|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84144&action=edit
Bug 20274: Itemtypes report gives zero results if item-level_itypes set to
bibliographic records

1) Go to reports then catalog by item types
2) Pick a location and look at table
3) Change the system prefernce of item-level_itypes
4) Verify a zero result
5) Apply patch and retry
6) Verify that result does not change to zero on either preference

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:59:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:59:18 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-2L3Mc7ReB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Good fix!

For next patch: please make sure the commit subject (the first line) follows
the guidelines. You can run the qa script yourself before submitting so you can
fix that!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 16:59:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 15:59:27 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-2ZlvWtbhbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84142|0                           |1
        is obsolete|                            |

--- Comment #421 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84145&action=edit
Bug 17047: QA fixes:   - don't search subscriptions when mana is disabled,   -
subscription detail page: don't show share button or search link if Mana is
disabled,   - fix report sharing,   - submit report search form by pressing
enter,   - add a waittin

foo

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:10:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:10:37 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-4MxEHpNZHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84146&action=edit
Bug 19818: Add id into tag html from moremember.tt

1) Go to the patron details for a patron
2) On the right of the screen, right click one of the labels below
   'Library use' etc, and Inspect Element
3) View <li> tags which should now each have a unique <id> tag for each

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:11:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:11:00 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-XMnIf6RVIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84111|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:10:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:10:34 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-1iiYOlExtG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:26:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:26:42 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-fAJO3gyuhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19818


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818
[Bug 19818] Add id into tag html from moremember.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:26:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:26:42 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-sBEztEQz24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22134


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134
[Bug 22134] Add account expiration information to patron details
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:27:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:27:59 +0000
Subject: [Koha-bugs] [Bug 22155] New: biblio_metadata.marcflavour should be
 renamed 'schema'
Message-ID: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

            Bug ID: 22155
           Summary: biblio_metadata.marcflavour should be renamed 'schema'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

If we are thinking of supporting other metadata schemas, the 'marcflavour'
field should be renamed 'schema'. This is what the Koha::MetadataRecord class
does already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:31:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:31:55 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-pFuIcrqXPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:31:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:31:57 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-9KmZuaFPVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84147&action=edit
Bug 22134: (follow-up) Simplify check for expired patron

This patch move the check for "is_expired" to the template and removes
unnecessary code from the script. The interface should show no
difference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:36:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:36:32 +0000
Subject: [Koha-bugs] [Bug 22156] New: Subscription result list sorty by
	"checkbox"
Message-ID: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

            Bug ID: 22156
           Summary: Subscription result list sorty by "checkbox"
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

The subscription result list default sort is on the checkbox column (on older
version it was ISSN, when that was the first column). Both are a bit confusing
to libraries - I think it would make sense to have the default sort on the
title.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:36:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:36:57 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-uYlfPUHEcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Subscription result list    |Subscription result list
                   |sorty by "checkbox"         |sorts on "checkbox" by
                   |                            |default

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:38:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:38:09 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-jKKySC4Y3V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Version|17.11                       |master
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:44:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:44:18 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-rbDCUdSA3J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:44:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:44:21 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-Ljxne7usoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84148&action=edit
Bug 22156: Subscription result list sorts on "checkbox" by default

This patch adds default sorting by title to the subscription search
results list. Previously no default sort was defined, so it defaulted to
sorting by the first column in the table.

To test, apply the patch and go to Serials.

- Perform a search of subscriptions which will return multiple results.
- Confirm that the table of open subscriptions is sorted by default by
  title ascending.
- Confirm the same for the table of closed subscriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 17:49:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 16:49:18 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-iCVyVuujPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84149&action=edit
Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default

This patch adds default sorting by title to the subscription search
results list. Previously no default sort was defined, so it defaulted to
sorting by the first column in the table.

To test, apply the patch and go to Serials.

- Perform a search of subscriptions which will return multiple results.
- Confirm that the table of open subscriptions is sorted by default by
  title ascending.
- Confirm the same for the table of closed subscriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 18:29:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 17:29:41 +0000
Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21953-70-tRnrMdUd5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
1. I don't know how to do tests, I'll know in the future not to touch anything
in C4 even if it's a simple string patch. I feel it's a bit overkill to do
tests just for removing two displayed words. But if someone wants to code
tests, it's fine with me. I will de-assign myself the bug since I can't do more
than submit the string patch.

2. I'm not sure how I would go about to update the existing data. I'm guessing
it's an UPDATE using regex. 

3. From Tom?s' comment, I understand that this bug is put on the back burner.
Should we change it to "in discussion"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 18:30:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 17:30:15 +0000
Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21953-70-cRntoD48pB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|caroline.cyr-la-rose at inlibr |koha-bugs at lists.koha-commun
                   |o.com                       |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 18:32:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 17:32:49 +0000
Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21953-70-ONDZLTpJVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Caroline Cyr La Rose from comment #5)
> 1. I don't know how to do tests, I'll know in the future not to touch
> anything in C4 even if it's a simple string patch. I feel it's a bit
> overkill to do tests just for removing two displayed words. But if someone
> wants to code tests, it's fine with me. I will de-assign myself the bug
> since I can't do more than submit the string patch.
> 
> 2. I'm not sure how I would go about to update the existing data. I'm
> guessing it's an UPDATE using regex. 
> 
> 3. From Tom?s' comment, I understand that this bug is put on the back
> burner. Should we change it to "in discussion"?

I will try to take a look at the add_debit bugs again and see how it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:05:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:05:57 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-dLcVY4YsHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:06:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:06:48 +0000
Subject: [Koha-bugs] [Bug 22157] New: HideLostItems items still show in OPAC
 when patron places a hold on a specific item
Message-ID: <bug-22157-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22157

            Bug ID: 22157
           Summary: HideLostItems items still show in OPAC when patron
                    places a hold on a specific item
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

If a library has the system preference set to HIDE lost items, the item will
still show up in the holds screen when a patron places a hold on a specific
item
These items should not appear within the OPAC as they should be hidden per this
system preference.

This bug is similar to 15448 where the system preference OPAChiddenItems is
performing the same way. This might have some correlation with bug 2711.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:40:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:40:34 +0000
Subject: [Koha-bugs] [Bug 22130] Batch checkout : authorized value
 description is never shown with notforloan status.
In-Reply-To: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22130-70-jJ70PbzRHj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Hi Pierre-Marc,

We went through your steps but we didn't see any number under the column
"Information"

We saw "! Item not for loan" message there.

Thanks.
Devinim Koha Team

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:42:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:42:39 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-Bg5uiEXzjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #16 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Hi, thanks for your help :)

Something is a bit weird:

>    14- In Accounting details, notice the Actual cost is written with a decimal dot.

?Alright?

>    15- Change the Actual cost, using a dot decimal (i.e 20.99)

?Wait that was already the case?

Anyway, I kept going.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:42:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:42:54 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-Y8YUMfoAOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83971|0                           |1
        is obsolete|                            |

--- Comment #17 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 84150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84150&action=edit
Bug 18723: (Alternate Solution) Block form submission

When entering an amount in "Actual Cost" on the orderreceive page,
it is multiplied by 100 if the entered number's format does not
match the "CurrencyFormat" syspref.

This patch adds a value check before submitting the form. It uses
regexps based on the "CurrencyFormat" syspref to validate that the
number will be processed correctly.

Test Plan:
a)Replicate the issue:
    0- Set CurrencyFormat to FR
    1- Go to Acquisitions
    2- Search for a Vendor
    3- Click on "New basket"
    4- Give basket a name and click "Save"
    5- Click on "Add to basket"
    6- Add an order through preferred method
    7- In Accounting details, enter a vendor price with dot decimal (i.e.
19.44)
    8- Save your order line
    9- Click on "Close this basket"
    10- Confirm closing of basket by clicking on "Yes, close"
    11- Click on "Receive shipment"
    12- Enter an invoice number and click "Next"
    13- Click on "Receive" to the right of your order
    14- In Accounting details, notice the Actual cost is written with a decimal
dot.
    15- Change the Actual cost, using a dot decimal (i.e 20.99)
    16- Receive the order
    17- Click on "Save"
    18- In "Already received" notice the price is multiplied by 100 (i.e.
2099,00)
    19- Click on "Cancel receipt"
    20- Click on "Receive" to the right of your order
    21- In Accounting details, change the Actual cost, using a comma decimal
(i.e. 20,99)
    22- Receive the order
    23- Click on "Save"
    24- In "Already received", notice the price is correct.
b)Apply the patch
c)Test the patch:
    1- Click on "Cancel receipt"
    2- Click on "Receive to the right of your order
    3- In Accounting Details, notice the Actual cost is formatted correctly
(comma decimal)
    4- Change the Actual cost, using a dot decimal (21.99)
    5- Receive the order
    6- Click on "Save"
    7- Notice an error message explaining the proper format for Actual cost
(click "Ok")
    8- Change the Actual cost, using a comma decimal (21,99)
    9- Click on "Save"
    10- In "Already received", notice the price is correct.
    11- Test the other CurrencyFormat settings

Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:49:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:49:55 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-SegT5lYBoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #18 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
(In reply to Victor Grousset/tuxayo from comment #16)
> Hi, thanks for your help :)
> 
> Something is a bit weird:
> 
> >    14- In Accounting details, notice the Actual cost is written with a decimal dot.
> 
> ?Alright?
> 
> >    15- Change the Actual cost, using a dot decimal (i.e 20.99)
> 
> ?Wait that was already the case?
> 
> Anyway, I kept going.

I see how it can be a little confusing. What line 14 shows is that even though
the CurrencyFormat uses a comma, the form uses a period when it is being
edited. When that price (or a different price) is entered at step 15, the
period "breaks" the formatting and leads to the unwanted multiplication.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:53:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:53:16 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-3lmDMszkHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #19 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
According to the QA and functionnal feedback that I got on bug 21507 and bug
12310:

- here we must also use jQuery.validator
  -
https://gitlab.com/tuxayo/Koha/compare/master...bug%2F21507%2Fdecimal-separators-fines#0d520d86f436b1c7c08ed14dc1ac60e58fa114a4_0_19
  - can we copy the code from the above patch? So when both will be merged,
there will be a consistence between payments/fines and acquisitions
- thousands separators shouldn't be allowed, which means the code that prefills
 the field shouldn't add it.


(I'll reread again to see if there are other things to mention)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 19:53:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 18:53:24 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-tlDxpNgEXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:09:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:09:07 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-PurZVd0IwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
I can't reproduce that problem in my test system. Could you please try again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:23:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:23:37 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-WzyLYku3La@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83988|0                           |1
        is obsolete|                            |

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 84151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84151&action=edit
Bug 17347: Ignore whitespace before and after on renewing

When an item is checked out, Koha ignores whitespace
at the beginning and the end of the entered barcode.
This makes life easier, if a barcode is C&P from another
page. This patch makes the renewal page behave the same.

To test:
- Checkout an item
- Renew the item from the renew tab or renewal page
  entering the barcode with leading and trailing
  whitespace
- "Barcode not found"
- Apply patch
- Try again
- Barcode should be found now

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:25:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:25:46 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-krALXQtDo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

--- Comment #4 from Devinim <kohadevinim at devinim.com.tr> ---
Hi Katrin,
Good patch, Thanks.

We tried to give a blank in the box, then press Tab, go back to the box again
and paste the barcode, in that case it did not recognize the barcode since
there is a Tab.

Thanks
Devinim Koha Team

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:44:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:44:30 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-mu7DnHDxWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can we just get a patch for now that makes this form behave like the rest of
Koha  again and keep elaborate better fixes for the next step?

We have still not been able to fix the regression!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:44:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:44:45 +0000
Subject: [Koha-bugs] [Bug 3716] Sorting Labels for printing by barcode.
In-Reply-To: <bug-3716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3716-70-UjvW6pVF6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3716

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
This is still valid on master

To reproduce:
1) Go to Tools > Label creator
2) Make sure you have a template and a layout for barcodes
3) Click on New > Label batch
4) Click on Add items
5) Add items in a random order
6) Click on Done
7) Click on Export full batch
8) Choose the template and layout for barcode labels
9) Click Export
10) Open the PDF, Note that the barcodes are in the order they were added, not
in order of barcodes

I'm not sur if it is useful to have the barcodes in the order they were added.
I would sort them in order by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:45:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:45:22 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-KuWvRMtgcm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:45:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:45:25 +0000
Subject: [Koha-bugs] [Bug 15110] decreaseHighHolds unclear
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-YrIhDLnlMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84116|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 84152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84152&action=edit
Bug 15110: I have changed the description to include the words suggested.

To test:
1) Apply patch
2) Go to Koha admin
3) Search in system prefernces for 'high demand'
4) Verify that the system prefernce 'decreaseLoanHighHolds' is in the
results of the search

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:47:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:47:19 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-StfRHiSVMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:47:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:47:21 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-6oZGDM4cmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84104|0                           |1
        is obsolete|                            |

--- Comment #3 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84153&action=edit
Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries
description

Test plan:
1. Review patch and confirm that the sentence makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:48:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:48:18 +0000
Subject: [Koha-bugs] [Bug 17347] 'Renew' tab should ignore whitespace at
 begining and end of barcode
In-Reply-To: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17347-70-JtSZEokFMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Devinim, could you test the same in circ please? I used the same regex that
is used there. I was aiming to make them behave the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:50:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:50:33 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-BUjPWrwK8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22155

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 20:50:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 19:50:33 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-jWyTAxgObG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22144

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:01:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:01:33 +0000
Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests
In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21692-70-2KRQIt0faR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:01:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:01:36 +0000
Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests
In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21692-70-40MlwZz672@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84121|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 84154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84154&action=edit
Bug 21692: created a test for Koha::Account->new

Test plan:
1) Run test for /Koha/Account.t and confirm that all tests were
successful

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:09:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:09:17 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-ePlyPXltO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Owen Leonard from comment #2)
> 
> I think that even with my redesign this is still an issue. I wonder if it
> could be solved by adding "check all" and "check none" controls where "check
> all" would automatically de-select the superlibrarian flag?

This is exactly what I had in mind.

(In reply to Katrin Fischer from comment #1)
> I think it is on purpose - superlibrarian means all, but it's actually more
> than 'all'. Superlibrarians can do more than some of the permissions,
> especially when it comes to Independentbranches. So there would be conflicts
> if you could have superlibrarian without some of the other permissions.

I meant that if you unselected any checkbox, the superlibrarian box would also
be unselected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:10:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:10:33 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-owkvaXKIM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think what we want for the stable releases is consistent behaviour. If I have
to add my data everywhere with a decimal dot (independent of the CurrencyFormat
setting!) then I want that on the receive form as well. Currently only this one
input behaves badly which causes a lot of confusion and frustration.

And if we are going to make a change here - we need to do it for all input
fields in ACQ (or in Koha) at once and release that with a major version. 

I think while the new patch might be a way forward, it might not work for
fixing the regression.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:12:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:12:47 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-KDr4ZrfHrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for commenting, I agree!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:15:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:15:34 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-JKPLHkBVOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:15:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:15:39 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-1yDnX3BJev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

--- Comment #11 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84155&action=edit
Bug 21918: Sorry about that, I think I may have been changing the wrong setting
as it is working now.

Signed-off-by: helene hickey <hickeyhe at wgc.school.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:15:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:15:47 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-SilWmnvL8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:15:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:15:51 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-Q2EkyxhBAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84042|0                           |1
        is obsolete|                            |

--- Comment #3 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84156&action=edit
Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes.

Fixed ExtendedPatronAttributes typo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:16:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:16:01 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-ljnoQ3JW52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Can you please provide a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:16:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:16:15 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-5OJM5agE1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |On the 'import patrons'
      release notes|                            |page, the "Replace all
                   |                            |patron attributes" is
                   |                            |automatically selected
                   |                            |which is the more dangerous
                   |                            |option. This patch sets the
                   |                            |default selection as
                   |                            |"Replace only included
                   |                            |patron attributes" as it is
                   |                            |a safer option.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:20:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:20:11 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-APhTRGHCEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:20:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:20:14 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-mlHFiSQEdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84117|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 84157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84157&action=edit
Bug 11922: Added SHOW_BCIDE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:22:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:22:32 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-Xy021Wb5e4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Note: I checked that the two files from the installer are now in the Norwegian
web installer folder.

I didn't test by running through the actual installer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:27:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:27:54 +0000
Subject: [Koha-bugs] [Bug 22158] New: Add keyboard shortcuts in advanced
 editor to move current line up or down within record
Message-ID: <bug-22158-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22158

            Bug ID: 22158
           Summary: Add keyboard shortcuts in advanced editor to move
                    current line up or down within record
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

It'd be handy to have keyboard shortcuts to easily reorder lines in the
advanced cataloging editor, as it's easy to get one's MARC fields out of
numerical order.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:28:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:28:17 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-YyuvwBy52i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:28:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:28:23 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-KyfFKfZwZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84112|0                           |1
        is obsolete|                            |

--- Comment #4 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84158&action=edit
Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table

Test plan:
1. From homepage, go to Koha Amdinistration
2. Go to Authorised Values
3. Scroll down to ITEMTYPECAT and click Add
4. Give the new authorised value an Authorised value and Description
5. Save it
6. On the left, go to Item types
7. Click Edit on an item type
8. Under Search Catergory, select the new authorised value you just
created. It should appear in the dropdown as it's description
9. Click Save changes
10. Under Search category for the item type you just edited, you should see
your new authorised values' description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:29:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:29:44 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-eHPMihQ7SI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hickeyhe at wgc.school.nz

--- Comment #2 from helene <hickeyhe at wgc.school.nz> ---
Created attachment 84159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84159&action=edit
API Keys page

API keys page after apply the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:30:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:30:58 +0000
Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff results list
In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17765-70-vAvj6zASLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jke0429 at stacmail.net
                   |ity.org                     |
                 CC|                            |jke0429 at stacmail.net

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:32:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:32:32 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-cClcOBG716@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from helene <hickeyhe at wgc.school.nz> ---
I did not observe any changes and the ' Generate a new client id/secret pair'
did not become a button other then adjusting more at different page sizes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:37:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:37:10 +0000
Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff results list
In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17765-70-3B2m0oYZEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jke0429 at stacmail.net        |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:58:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:58:18 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-8Wpglccvh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:58:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:58:21 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-fJqSnRraWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83815|0                           |1
        is obsolete|                            |

--- Comment #4 from Jack <jke0429 at stacmail.net> ---
Created attachment 84160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84160&action=edit
Bug 22104: Clean up patron API keys template

This patch makes two corrections to the patron API key template: Convert
to Bootstrap grid and correct class on "new key" button.

To test, apply the patch and enable the RESTOAuth2ClientCredentials
preference.

 - Open a patron record in the staff client and choose More -> Manage
   API keys.
 - On the API keys page, confirm that the page adjusts well at various
   page widths.
 - Confirm that the size of the "Generate new client id/key pair" button
   matches the buttons in the toolbar.

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:59:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:59:14 +0000
Subject: [Koha-bugs] [Bug 22110] Editing adjustments doesn't work for
 Currencyformat != US
In-Reply-To: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22110-70-laWjvq7OEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 21:59:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 20:59:16 +0000
Subject: [Koha-bugs] [Bug 22110] Editing adjustments doesn't work for
 Currencyformat != US
In-Reply-To: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22110-70-fn5CkEmip1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84028|0                           |1
        is obsolete|                            |

--- Comment #2 from Mackey Johnstone <mackeyfj at gmail.com> ---
Created attachment 84161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84161&action=edit
Bug 22110: Fix editing of adjustments for CurrencyFormat != US

When using CurrencyFormat FR or CH the editing an amount behave
badly. Example: changing displayed 1,00 to 1,11 would save as 1,00.

At the moment Koha only understands decimal dot, not comma.
So every time data is entered, we use decimal dot.

1) Add an adjustment to an invoice
2) Change system preference CurrencyFormat to FR or CH
3) Verify the amount displays with a decimal comma
4) Try changing the amount to something like 1,11
5) Save the amount
6) Verify it shows 1.00
7) Apply patch
8) Refresh the invoice page if necessary
9) Verify amount is now shown as 1.00
10) Repeat test, use 1.11
11) Verify it will be stored correctly.

Signed-off-by: Mackey Johnstone <mackeyfj at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:00:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:00:27 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-iAjV3dghsy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jke0429 at stacmail.net
  Attachment #84160|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:00:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:00:48 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-zmXfyAx5cY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83815|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:01:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:01:19 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-0VSgXYyUWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jack <jke0429 at stacmail.net> ---
Accidental Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:03:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:03:43 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-EXbKOB1oNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84147|0                           |1
        is obsolete|                            |

--- Comment #6 from Jack <jke0429 at stacmail.net> ---
Created attachment 84162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84162&action=edit
Bug 22134: (follow-up) Simplify check for expired patron

This patch move the check for "is_expired" to the template and removes
unnecessary code from the script. The interface should show no
difference.

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:03:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:03:40 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-QkiCqRJIWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:04:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:04:41 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-ETb029qZmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.amohia at gmail.com

--- Comment #3 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84163&action=edit
Bug 22156: Open subs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:05:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:05:13 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-iI6BMKFgoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

--- Comment #4 from Ethan <ethan.amohia at gmail.com> ---
Created attachment 84164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84164&action=edit
Bug 22156: Closed subs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:05:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:05:58 +0000
Subject: [Koha-bugs] [Bug 11996] default active currencies for ru-RU and
 uk-UA are probably wrong
In-Reply-To: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11996-70-X8zOW1d0Bj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from David Nind <david at davidnind.com> ---
Hi Ethan.

I think the best course of action is to change the 'GRN line to ' UAH' in both
files (installer/data/mysql/ru-RU/optional/sample_currency.sql and
installer/data/mysql/uk-UA/optional/sample_currency.sql).

GRN was the old currency, but is now RUB for Russia and UAH for the Ukraine.
The symbol for UAH remains as ???

For a list of currency codes see https://en.wikipedia.org/wiki/ISO_4217 and for
the Ukraine see 
https://en.wikipedia.org/wiki/Ukrainian_hryvnia

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:09:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:09:56 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-FjaugVNZCI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Ethan <ethan.amohia at gmail.com> ---
As seen from the two recently added attachments, it doesn't look like the code
is working as intended. The subscriptions on both the open and closed
subscriptions tables are not arranged by default by title ascending.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:20:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:20:19 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-pMmfVrCVCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mackeyfj at gmail.com

--- Comment #3 from Mackey Johnstone <mackeyfj at gmail.com> ---
We can't seem to save a record without field 942 filled anyway, so not sure
when this bug would occur.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:26:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:26:29 +0000
Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff results list
In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17765-70-xQwQBCSw9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #7 from Jack <jke0429 at stacmail.net> ---
Created attachment 84165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84165&action=edit
Screenshot of results page

In master, when I log in with a user that does not have reserveforothers
permissions, the place hold button no longer appears, and the holds text is no
longer a link, so I think this may have been fixed in a different patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:32:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:32:10 +0000
Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff results list
In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17765-70-iyYnU0GWIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:55:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:55:08 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-i96UD9pC6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 22:55:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 21:55:13 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-rDCX9vhlVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79892|0                           |1
        is obsolete|                            |

--- Comment #22 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84166&action=edit
Bug 18723: Change dot into comma

This fixes the regression that multiplies the amount entered by 100
when CurrencyFormat is set to FR. It replaces the last dot with a
comma before dealing with the value of ActualCost and ReplacementCost.

Test Plan:
a)Replicate the issue:
    0- Set CurrencyFormat to FR
    1- Go to Acquisitions
    2- Search for a Vendor
    3- Click on "New basket"
    4- Give basket a name and click "Save"
    5- Click on "Add to basket"
    6- Add an order through preferred method
    7- In Accounting details, enter a vendor price with dot decimal (i.e.
19.44)
    8- Save your order line
    9- Click on "Close this basket"
    10- Confirm closing of basket by clicking on "Yes, close"
    11- Click on "Receive shipment"
    12- Enter an invoice number and click "Next"
    13- Click on "Receive" to the right of your order
    14- In Accounting details, notice the Actual cost is written with a decimal
dot.
    15- Change the Actual cost, using a dot decimal (i.e 20.99)
    16- Receive the order
    17- Click on "Save"
    18- In "Already received" notice the price is multiplied by 100 (i.e.
2099,00)
    19- Click on "Cancel receipt"
    20- Click on "Receive" to the right of your order
    21- In Accounting details, change the Actual cost, using a comma decimal
(i.e. 20,99)
    22- Receive the order
    23- Click on "Save"
    24- In "Already received", notice the price is correct.
b)Apply the patch
c)Test the patch:
    1- Click on "Cancel receipt"
    2- Click on "Receive to the right of your order
    3- Change the Actual cost/Replacement cost, using a dot decimal (21.99)
    4- Receive the order
    5- Click on "Save"
    6- Notice that the Actual cost and the Replacement cost use commas
    7- Change the Actual cost, using a comma decimal (21,99)
    8- Click on "Save"
    9- In "Already received", notice the price is still correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:04:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:04:23 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-Mm06Lkb3q8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

helene <hickeyhe at wgc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hickeyhe at wgc.school.nz
             Status|Needs Signoff               |Failed QA

--- Comment #2 from helene <hickeyhe at wgc.school.nz> ---
We restarted memcached and plack and the link still did not disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:07:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:07:40 +0000
Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page
In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22032-70-iIxYkPn1wq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032

Ethan <ethan.amohia at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |ethan.amohia at gmail.com

--- Comment #3 from Ethan <ethan.amohia at gmail.com> ---
Looks like its already been signed off but wasnt set to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:15:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:15:13 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-BgtukFmraD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:15:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:15:15 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-Rc2mn7uGqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Mackey Johnstone <mackeyfj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68425|0                           |1
        is obsolete|                            |

--- Comment #25 from Mackey Johnstone <mackeyfj at gmail.com> ---
Created attachment 84167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84167&action=edit
Bug_19164: remove use strict/warn lines (were commented out anyway)

Signed-off-by: Mackey Johnstone <mackeyfj at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:15:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:15:47 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-YTQfdQFpn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:15:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:15:50 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21427-70-1aD3MXlEGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

Jack <jke0429 at stacmail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83831|0                           |1
        is obsolete|                            |

--- Comment #12 from Jack <jke0429 at stacmail.net> ---
Created attachment 84168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84168&action=edit
Bug 21427: Format prices on ordered/spent lists consistently

Some price information on the spent and ordered list already
used the $Price filter. With this patch all amounts should be
formatted according to the CurrencyFormat system preference.

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:26:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:26:18 +0000
Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter'
In-Reply-To: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20171-70-bb971Rv5EJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171

Olivia <olivialokm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 17 23:26:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 22:26:21 +0000
Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter'
In-Reply-To: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20171-70-2S0DqiBvJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171

--- Comment #2 from Olivia <olivialokm at gmail.com> ---
Created attachment 84169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84169&action=edit
Bug 20171: Fixed CSV output to use syspref 'delimiter' in export files

To Find Fix:

1. Go to sysprefs and change delimiter to slashes
2. Under the Search drop down click Item search
3. Set Output as CSV
4. Click Search
5. A file should be downloaded and when opened the set delimiter should
appear as the delimiter

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 00:17:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 23:17:47 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-eHtov9Ze87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 00:17:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 23:17:49 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-CWDH0N3b6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

--- Comment #5 from Jasmine Amohia <jasmineamohia.student at wegc.school.nz> ---
Created attachment 84170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84170&action=edit
Bug 22150: Ability to select or unselect all member flags

To test:
1) Find a patron
2) Click More -> Set permissions
3) Click 'Clear all', confirm all checkboxes get cleared and disabled
4) Click 'Select all', confirm all checkboxes get selected
5) Unselect one checkbox (not superlibrarian), and confirm that the
superlibrarian checkbox also gets unselected
6) Confirm that saving still works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 00:18:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 23:18:32 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-vTB937jqMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

Jasmine Amohia <jasmineamohia.student at wegc.school.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jasmineamohia.student at wegc.
                   |ity.org                     |school.nz
                 CC|                            |jasmineamohia.student at wegc.
                   |                            |school.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 00:32:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 23:32:39 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-xZKzHiarVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 00:32:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 23:32:42 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-Zy0N5uMjO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84153|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 84171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84171&action=edit
Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries
description

Test plan:
1. Review patch and confirm that the sentence makes sense

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 00:33:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Jan 2019 23:33:26 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-6XmODeRGWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

--- Comment #5 from David Nind <david at davidnind.com> ---
Thanks Jasmine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:01:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:01:59 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-DS79ndbX0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Ethan from comment #5)
> The subscriptions on both the open and closed
> subscriptions tables are not arranged by default by title ascending.

The sorting in the screenshots is correct. When sorting by title we ignore
articles like "A" and "The."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:13:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:13:52 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-ecfgb9i0gF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84172&action=edit
Screenshot showing when no keys have been added

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:14:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:14:34 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-WBzVCvU7Ru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84173&action=edit
Screenshot showing an added key

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:23:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:23:17 +0000
Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member
 permission after selecting all
In-Reply-To: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22150-70-bMoLHwBVeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
This works well, but the superlibrarian checkbox shouldn't be checked when you
click "Select all." If you check all, including the superlibrarian checkbox,
and save, you'll get an error when you return to the permissions page:

"Inconsistency detected! The superlibrarian privilege is mutually exclusive of
other privileges, as it includes them all. This patron's privileges will now be
reset to include only superlibrarian."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:40:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:40:37 +0000
Subject: [Koha-bugs] [Bug 22159] New: Add ColumnExists method
Message-ID: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

            Bug ID: 22159
           Summary: Add ColumnExists method
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

It would be handy to have a method to check if a column exists on a table. This
is specially useful when rmaints backport changes to the DB structure.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:40:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:40:43 +0000
Subject: [Koha-bugs] [Bug 22159] Add ColumnExists method
In-Reply-To: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22159-70-e43XwG59cI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:50:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:50:35 +0000
Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences
 (administration page, example for geolocation)
In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20106-70-G1h9TiGLv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Hi Jasmine.

I feel like I'm being a bit picky here, but the QA team would probably pick
these things up!

If you could make these changes, I will sign it off:

- Put a space between NOTE: and the start of the sentence, for example NOTE:
Whatever the note is. This makes it consistent with the other notes.

- Add a full stop at the end of the note sentence, for example NOTE: Whatever
the note is. This also makes it consistent with the other notes.

- The note is missing for the UsageStatsLibraryName preference.

- Change the text for the note and link from 'Usage statistics can also be
configured here' to something like 'Configure all the usage statistics
settings.'.

(When writing for the web I usually try and avoid writing the equivalent of
'click here', and generally try to make link text name meaningful. It is also a
web accessibility thing as well. The QA team/translation team might have some
thoughts on what is better from a translation perspective.)

Thanks!

This is a really nice improvement.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:51:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:51:46 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-mlE4z8K79o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I totally agree.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:53:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:53:04 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-v515YKdnck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22159
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159
[Bug 22159] Add ColumnExists method
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:53:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:53:04 +0000
Subject: [Koha-bugs] [Bug 22159] Add ColumnExists method
In-Reply-To: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22159-70-6CA21rCw60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155
[Bug 22155] biblio_metadata.marcflavour should be renamed 'schema'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:53:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:53:39 +0000
Subject: [Koha-bugs] [Bug 22159] Add ColumnExists method
In-Reply-To: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22159-70-yGVKYDjXl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84174&action=edit
Bug 22159: Add ColumnExists method

This patch adds a method for checking if a column exists on a DB table.
The way this is checked is used already on updatedatabase.pl [1] (i.e.
querying INFORMATION_SCHEMA.

To test:
- Create an atomicupdate file like this:
  $ cd installer/data/mysql/atomicupdate
  $ cp skeleton.perl test.perl
- Change the contents of test.perl so it looks like this:
$DBversion = 'XXX';
if( CheckVersion( $DBversion ) ) {

    if ( ColumnExists( 'borrowers', 'firstname' ) ) {
        print "Column borrowers.firstname exists!";
    }
    else {
        print "Boo, borrowers.firstname wasn't detected";
    }

    if ( ColumnExists( 'borrowers', 'friendly_alias' ) ) {
        print "Great, there's no borrowers.firend_alias";
    }
    else {
        print "Boo, this is really wrong";
    }
}

- Run:
  $ updatedatabase
  or
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
=> SUCCESS: No 'Boo' message is printed
- Sign off :-D

[1] See 3.03.00.023 or 18.12.00.002

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:53:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:53:57 +0000
Subject: [Koha-bugs] [Bug 22159] Add ColumnExists method
In-Reply-To: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22159-70-cuRmWjkEs8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:55:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:55:30 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-UoRXlF8hSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84175&action=edit
Bug 22155: DB update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 02:55:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 01:55:45 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-7YKZsQi00x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 03:33:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 02:33:39 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-XBS4H0OZhi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 03:34:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 02:34:10 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-mbMMnyHNjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84175|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84176&action=edit
Bug 22155: DB update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 03:34:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 02:34:22 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-QSqDPxvMZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84177&action=edit
Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema

This patch makes the code using Koha::Biblio::Metadata->marcflavour use
->schema instead for all interactions.

To test:
- Update the DB structure:
  $ updatedatabase
- Update the schema files:
  $ dbic
- Notice all the places in which biblio_metadata is used
  $ cd kohaclone
  $ git grep biblio_metadata
=> SUCCESS: They all use `schema` instead of marcflavour
- Notice all the places that use Koha::Biblio::Metadata:
  $ git grep Koha::Biblio::Metadata
=> SUCCESS: They all use the schema attribute when they used to use
marcflavour
- Run all the modified tests and scripts
=> SUCCESS: We are all good
- Sign off :-D

Note: while this seems like a minor change, the places in which plain
SQL is used really require understanding the queries and how they are
used, because some query results might be passed to some other method
that in turn uses the marcflavour attribute. I of course took that into
account but errare humanum est :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 06:55:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 05:55:50 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-BtH3JOSJzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 06:55:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 05:55:54 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-7IpJBfJyDg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84109|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 84178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84178&action=edit
Bug 19994: Used Modern::Perl in Authorities perl scripts

Test plan:
1. Review code of the following files and confirm that 'use Modern::Perl;' is
used in place of
'use strict; use warnings;'

auth_finder.pl
authorities-home.pl
authorities.pl
blinddetail-biblio-search.pl
detail-biblio-search.pl
detail.pl
export.pl
merge.pl
merge_ajax.pl

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:19:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:19:46 +0000
Subject: [Koha-bugs] [Bug 22160] New: OMNIBUS: Transfers enhancements
Message-ID: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

            Bug ID: 22160
           Summary: OMNIBUS: Transfers enhancements
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:20:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:20:23 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-Ff1QdCr87w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:21:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:21:45 +0000
Subject: [Koha-bugs] [Bug 22161] New: Move transferbook to Koha namespace
Message-ID: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161

            Bug ID: 22161
           Summary: Move transferbook to Koha namespace
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:22:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:22:28 +0000
Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook to Koha
	namespace
In-Reply-To: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22161-70-C3M4QtWf0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |22160
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
            Summary|Move transferbook to Koha   |Move
                   |namespace                   |C4::Circulation::transferbo
                   |                            |ok to Koha namespace


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:22:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:22:28 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-BEL1RQ2wkC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161
[Bug 22161] Move C4::Circulation::transferbook to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:23:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:23:20 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-si9klvfEyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6615


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6615
[Bug 6615] Add shelving location option to transfers page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:23:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:23:20 +0000
Subject: [Koha-bugs] [Bug 6615] Add shelving location option to transfers
	page
In-Reply-To: <bug-6615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6615-70-NHej9gppj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6615

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:24:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:24:00 +0000
Subject: [Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for
 item branch transfers
In-Reply-To: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22097-70-GxCw7EmqZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:24:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:24:00 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-3zIgqGfTQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097
[Bug 22097] CataloguingLog should be suppressed for item branch transfers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:28:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:28:03 +0000
Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results
 in a transfer where the destination is the same as the source
In-Reply-To: <bug-20344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20344-70-J80Kk9Ojxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:28:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:28:03 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-5PktHlX23e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20344


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344
[Bug 20344] Transferring an item while on hold results in a transfer where the
destination is the same as the source
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:41:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:41:24 +0000
Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and
 C4::Items::ModItemTransfer to Koha namespace
In-Reply-To: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22161-70-gfdYnPsoVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move                        |Move
                   |C4::Circulation::transferbo |C4::Circulation::transferbo
                   |ok to Koha namespace        |ok and
                   |                            |C4::Items::ModItemTransfer
                   |                            |to Koha namespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:48:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:48:29 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-yFYPdXX4PJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:48:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:48:45 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-WZMp1J5XvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

--- Comment #22 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Barton Chittenden from comment #21)
> ... the "!" means "Don't run this under plack".

Thanks! There are already a number of pages listed here:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/templates/apache-shared-intranet-plack.conf

Would it make sense to add export.pl until someone comes up with a proper
solution? Or are there so few people downloading huge files that it is not
worth it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:57:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:57:14 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-smh66o1DoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:57:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:57:14 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-cw1Ipaxqqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7614


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614
[Bug 7614] Branch transfer limit and holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:57:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:57:55 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-GxyQrxdrhT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22160
                 CC|                            |josef.moravec at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 09:57:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 08:57:55 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-64qhZTpCJR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7376


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376
[Bug 7376] Transfer limits should be checked at check-in
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:07:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:07:24 +0000
Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and
 GetAllPendingTransfers functions to ease testing.
In-Reply-To: <bug-14188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14188-70-sv4GVhsleu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Patch doesn't apply         |BLOCKED

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Koha::Item::Transfers->search should be enough I think...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:09:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:09:16 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: <bug-13906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13906-70-qMnQWyWpEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #27 from Josef Moravec <josef.moravec at gmail.com> ---
Could builder->build_object cover this case?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:24:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:24:55 +0000
Subject: [Koha-bugs] [Bug 16131] Messages for branch transfers show with
	bullet points
In-Reply-To: <bug-16131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16131-70-oB4fclmTd7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:25:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:25:37 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-yRGdwziC1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126
[Bug 7126] Transfer does not prompt with hold information
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:26:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:26:04 +0000
Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled
 when on loan or a waiting reserve
In-Reply-To: <bug-14170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14170-70-B3ybPJlVMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:25:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:25:37 +0000
Subject: [Koha-bugs] [Bug 7126] Transfer does not prompt with hold
	information
In-Reply-To: <bug-7126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7126-70-5LawAomfex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22160
                 CC|                            |josef.moravec at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:26:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:26:04 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-OLV3yCvNwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14170


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170
[Bug 14170] branchtransfers items need to be cancelled when on loan or a
waiting reserve
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:32:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:32:51 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-YP2MkMNPJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:41:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:41:36 +0000
Subject: [Koha-bugs] [Bug 22162] New: Refactor branchtransfers.pl
Message-ID: <bug-22162-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22162

            Bug ID: 22162
           Summary: Refactor branchtransfers.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:41:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:41:43 +0000
Subject: [Koha-bugs] [Bug 22162] Refactor branchtransfers.pl
In-Reply-To: <bug-22162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22162-70-8bdDY0WWjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22162

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:41:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:41:51 +0000
Subject: [Koha-bugs] [Bug 22162] Refactor branchtransfers.pl
In-Reply-To: <bug-22162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22162-70-YTuKEQzA0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22162

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161
[Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer
to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:41:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:41:51 +0000
Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and
 C4::Items::ModItemTransfer to Koha namespace
In-Reply-To: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22161-70-fbC7lgPumE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22162
[Bug 22162] Refactor branchtransfers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:41:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:41:43 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-GBGC3XmooY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22162
[Bug 22162] Refactor branchtransfers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:43:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:43:42 +0000
Subject: [Koha-bugs] [Bug 22163] New: Add transfers history page to catalog
Message-ID: <bug-22163-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22163

            Bug ID: 22163
           Summary: Add transfers history page to catalog
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

As a tab on record detail page, similar to circulation history for records

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:43:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:43:57 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-aQdNixrio7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22163
[Bug 22163] Add transfers history page to catalog
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:43:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:43:57 +0000
Subject: [Koha-bugs] [Bug 22163] Add transfers history page to catalog
In-Reply-To: <bug-22163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22163-70-QtI7lN2M5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22163

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22161
             Blocks|                            |22160
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161
[Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer
to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:43:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:43:57 +0000
Subject: [Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and
 C4::Items::ModItemTransfer to Koha namespace
In-Reply-To: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22161-70-umvjB4FClP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22163
[Bug 22163] Add transfers history page to catalog
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:46:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:46:14 +0000
Subject: [Koha-bugs] [Bug 22164] New: Inform librarian that a transfer was
 finished during checking in
Message-ID: <bug-22164-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22164

            Bug ID: 22164
           Summary: Inform librarian that a transfer was finished during
                    checking in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

Transfers are usually finished when the item is checked in on the right
library. But there is no message in UI about finishing the transfer.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:46:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:46:27 +0000
Subject: [Koha-bugs] [Bug 22164] Inform librarian that a transfer was
 finished during checking in
In-Reply-To: <bug-22164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22164-70-vVWdceG2i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22164

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22160
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:46:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:46:27 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-kov2Cd7Oo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22164


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22164
[Bug 22164] Inform librarian that a transfer was finished during checking in
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:55:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:55:44 +0000
Subject: [Koha-bugs] [Bug 22165] New: Ability to add notes to manually
	started transfers
Message-ID: <bug-22165-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22165

            Bug ID: 22165
           Summary: Ability to add notes to manually started transfers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

This will need to add a new field on branchtranfers page, and to add ability to
edit notes in transfers to receive page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:55:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:55:55 +0000
Subject: [Koha-bugs] [Bug 22165] Ability to add notes to manually started
	transfers
In-Reply-To: <bug-22165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22165-70-BWJz2t0pCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22165

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Blocks|                            |22160
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:55:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:55:55 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-HJTDUjLR9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22165
[Bug 22165] Ability to add notes to manually started transfers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:58:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:58:25 +0000
Subject: [Koha-bugs] [Bug 22166] Add cron to automatically finish transfers
 based on some configuration
In-Reply-To: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22166-70-T2JJros1xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22166

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:58:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:58:13 +0000
Subject: [Koha-bugs] [Bug 22166] New: Add cron to automatically finish
 transfers based on some configuration
Message-ID: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22166

            Bug ID: 22166
           Summary: Add cron to automatically finish transfers based on
                    some configuration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

Sometimes it could be useful to have transfers been finished automatically,
based on library/time rules.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 10:58:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 09:58:25 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-0aZGNCtrJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22166


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22166
[Bug 22166] Add cron to automatically finish transfers based on some
configuration
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:09:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:09:11 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-ZXekUT4kxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at helsinki.fi> ---
It is probably due to our Voyager-> Koha data migration pipeline.

For performance reasons it skips the bulkmarcimport.pl -script.

In Koha there probably are other points where the presence of field 942 is
assumed. However having migrated a few libraries already, we don't seem to be
facing any strange problems yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:16:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:16:45 +0000
Subject: [Koha-bugs] [Bug 22092] When creating a new subscription,
 biblio.serial is not set if field 942 is missing.
In-Reply-To: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22092-70-Y3W5fu2s4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22092

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at helsinki.fi> ---
(In reply to Aleisha Amohia from comment #2)
> Can you please provide a test plan for this?

I cant remember how the stock Koha-Community version actually uses the
biblio.serial -flag.
We have a feature which paginates our 500+ (up to several thousand) serials and
their attached records on the detail.pl to a serial enumeration tree:

  2018 
    -> : 1
        -> : 1
        -> : 2
        -> : 3
        -> : 4
    -> : 2
        -> : 1
  ...

Then by clicking the enumeration component we render (from the REST API) all
the Items matching that year/issue/volume.
This way loading the detail.pl doesn't take up to one minute, but typically
only seconds with large Item volumes.

To activate the "dynamic Serial numbers tree" -view, we check the
koha.biblio.serial -flag

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:24:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:24:31 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-TXA0ZE1nI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:26:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:26:03 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-05P5gnpI69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:26:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:26:06 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-9x2agS9xfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84119|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 84179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84179&action=edit
Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes

Test plan:
1) Check all Koha/REST files and confirm that 'use Modern::Perl;' has
been removed.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:28:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:28:49 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-uOvyKtLk3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84070|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84180&action=edit
Bug 19832: Unit tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:28:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:28:52 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-86NC9DvNZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84071|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84181&action=edit
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm

AddIssue already checks for holds in the item being issued and deals with them

The sip code, additionally, does not consider that multiple holds per bib
is allowed

To test:
 0 - Apply only first patch (unit tests)
 1 - Place two holds for a patron on a bib
 2 - Checkout that item via sip_cli_emulator
 3 - Note all holds are cancelled/filled
 4 - prove -v t/db_dependent/SIP/Transaction.t
 5 - it fails
 6 - Apply second patch
 7 - prove tests, all green
 8 - Place two holds on a single bib for one patron again
 9 - Checkout the item via sip_cli_emulator
10 - Only one holds is filled

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:29:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:29:24 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-KhZzkVLRz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Code seems sound and passes tests.  Signing Off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:31:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:31:59 +0000
Subject: [Koha-bugs] [Bug 22159] Add ColumnExists method
In-Reply-To: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22159-70-LZkx1J4oYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Tom?s, why do we need this? We have column_exists defined in C4/Installer.pm
and it could be used in atomic updates...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:34:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:34:30 +0000
Subject: [Koha-bugs] [Bug 22159] Add ColumnExists method
In-Reply-To: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22159-70-TDskxuSBkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Josef Moravec from comment #2)
> Tom?s, why do we need this? We have column_exists defined in C4/Installer.pm
> and it could be used in atomic updates...

LOL. This is because I failed to find it yesterday =D

*** This bug has been marked as a duplicate of bug 17234 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:34:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:34:30 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
 This breaks updatedatabase.pl
In-Reply-To: <bug-17234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17234-70-LNSi10p3w1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

--- Comment #64 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 22159 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:34:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:34:31 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-SAQ0TTRSeg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155
Bug 22155 depends on bug 22159, which changed state.

Bug 22159 Summary: Add ColumnExists method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22159

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:36:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:36:04 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-RiSz9rWiUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:37:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:37:30 +0000
Subject: [Koha-bugs] [Bug 22133] Wrong layout in OAI-PMH:archiveID syspref
	description
In-Reply-To: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22133-70-e8nLATbK04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---


*** This bug has been marked as a duplicate of bug 21926 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:37:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:37:30 +0000
Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference
	description
In-Reply-To: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21926-70-UECHeCIUwB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 22133 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:40:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:40:14 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-wGKgVSaLrw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84176|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84182&action=edit
Bug 22155: DB update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:40:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:40:22 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-UGdW7QCZx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84177|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84183&action=edit
Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema

This patch makes the code using Koha::Biblio::Metadata->marcflavour use
->schema instead for all interactions.

To test:
- Update the DB structure:
  $ updatedatabase
- Update the schema files:
  $ dbic
- Notice all the places in which biblio_metadata is used
  $ cd kohaclone
  $ git grep biblio_metadata
=> SUCCESS: They all use `schema` instead of marcflavour
- Notice all the places that use Koha::Biblio::Metadata:
  $ git grep Koha::Biblio::Metadata
=> SUCCESS: They all use the schema attribute when they used to use
marcflavour
- Run all the modified tests and scripts
=> SUCCESS: We are all good
- Sign off :-D

Note: while this seems like a minor change, the places in which plain
SQL is used really require understanding the queries and how they are
used, because some query results might be passed to some other method
that in turn uses the marcflavour attribute. I of course took that into
account but errare humanum est :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:53:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:53:03 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-BcBw5gycGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84007|0                           |1
        is obsolete|                            |

--- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84185&action=edit
Bug 21206: Remove GetItem

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:52:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:52:55 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-YcRJ1fonbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84006|0                           |1
        is obsolete|                            |

--- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84184&action=edit
Bug 21206: Replace C4::Items::GetItem

Note: This is here for information purpose, feel free to test it if you
wan to play with it.

TODO: C4::Reserves::_get_itype is not longer in use

No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:53:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:53:23 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-J7JyJQp78J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84009|0                           |1
        is obsolete|                            |

--- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84187&action=edit
Bug 21206: (follow-up) Fix Circulation.t

Test plan:
prove t/db_dependent/Circulation.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:53:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:53:30 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-AIQFE1agyP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84010|0                           |1
        is obsolete|                            |

--- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84188&action=edit
Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:53:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:53:15 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-eqqP1S2XOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84008|0                           |1
        is obsolete|                            |

--- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84186&action=edit
Bug 21206: Fix Returns.t

we are calling several times effective_itemtype
Must be fixed later

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:54:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:54:46 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-5ZSVkIWPK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:56:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:56:36 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-ClSYR3Qq3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:58:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:58:18 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-Kxb1V4Deyi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 11:58:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 10:58:22 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-bKwEuhqBPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84179|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84189&action=edit
Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes

Test plan:
1) Check all Koha/REST files and confirm that 'use Modern::Perl;' has
been removed.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 12:11:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 11:11:00 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-QTz5V47dyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl
should probably be updated to mention this special case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 13:10:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 12:10:26 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-Tq78JtYbMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://wiki.koha-community
                   |                            |.org/wiki/Public_patrons_pa
                   |                            |ssword_endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 13:20:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 12:20:11 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-KGDCSu7JVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
On the dev meeting it was requested that we change the 'password2' parameter
into something that explains that it is a repeated password more explicitly.

I'll do it on a follow-up, but wanted to mention that the inspiration for this
implementation was Django's:
https://django-rest-auth.readthedocs.io/en/latest/api_endpoints.html

and the fact that most of the examples on the web are quite similar too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 13:26:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 12:26:46 +0000
Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences
 (administration page, example for geolocation)
In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20106-70-5lQ8VdMZkH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> (When writing for the web I usually try and avoid writing the equivalent of
> 'click here', and generally try to make link text name meaningful. It is
> also a web accessibility thing as well. The QA team/translation team might
> have some thoughts on what is better from a translation perspective.)

<3 I thought, I was the only one :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 13:56:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 12:56:44 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-kxWCEy5QDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 13:56:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 12:56:54 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-va5tcMBuaJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84162|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:06:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:06:39 +0000
Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric
 in numeric eq (==)
In-Reply-To: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21170-70-nSJsbstZQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:08:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:08:33 +0000
Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric
 in numeric eq (==)
In-Reply-To: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21170-70-BoWGx37KV9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:08:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:08:37 +0000
Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric
 in numeric eq (==)
In-Reply-To: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21170-70-pi4nuPSJam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83471|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84190&action=edit
Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail

Easily removed switching the two conditions.

Test plan:
Hit catalogue/MARCdetail.pl?biblionumber=1
=> Without this patch you will see in the log warnings like
  Argument "ddc" isn't numeric in numeric eq (==) at
/home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277.
=> With this patch applied the warnings do no longer appear

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:25:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:25:42 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-orMkT13BYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:25:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:25:45 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-gs3BtSnuJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84191&action=edit
Bug 22134: (follow-up) Simplify check for expired patron

This patch move the check for "is_expired" to the template and removes
unnecessary code from the script.

The page now correctly handles messages for patrons who are about to
expire, as defined in the NotifyBorrowerDeparture preference.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.

Select a patron who will expire within the period defined in
NotifyBorrowerDeparture.

 - On the patron detail page you should see a message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:41:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:41:41 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-BXhRtTUyfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com
                   |y.org                       |
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:42:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:42:29 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-9qGDTuffUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83862|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 84192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84192&action=edit
Bug 22085: fix UNIMARC default XSLT broken by Bug 14716

Bug 14716 added a call to encode-uri() and namespace str.  This
namespace declaration is sometimes missing in UNIMARC default XSLT
files.

This patch adds namespace declaration also where encode-uri is not used
because it may be used in the future. And those files are the base for
home made custom files.

Test plan :
1) Use a UNIMARC DB
2) Use default in all XSLT sysprefs
3) Apply patch
4) Perform a search on OPAC
5) Check display is OK
6) Click on a record for detail page
7) Check display is OK
8) Perform a search on staff interface
9) Check display is OK
10) Click on a record for detail page
11) Check display is OK

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:42:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:42:40 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-8fiPmWskJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:46:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:46:26 +0000
Subject: [Koha-bugs] [Bug 22167] Allow itemnumber column to be labelled
 differently when using bach item edit feature
In-Reply-To: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22167-70-r1YI7Zcjur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19233


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233
[Bug 19233] Add ability to send itemnumbers in report results to batch
modification
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:46:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:46:26 +0000
Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report
 results to batch modification
In-Reply-To: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19233-70-Cbm68pkDzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167
[Bug 22167] Allow itemnumber column to be labelled differently when using bach
item edit feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:46:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:46:17 +0000
Subject: [Koha-bugs] [Bug 22167] New: Allow itemnumber column to be labelled
 differently when using bach item edit feature
Message-ID: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167

            Bug ID: 22167
           Summary: Allow itemnumber column to be labelled differently
                    when using bach item edit feature
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Bug 19233 added a feature that allows you to send a list of items to the item
batch edit from a saved SQL report. At the moment this only works, if your
column is displayed as itemnumber.

Example:

Works:

show itemnumber from items; 

Doesn't work:

show itemnumber as "Item#" from items;

This is not nice for translations. It would be nice if there was a different
way to mark the itemnumber and explicitly activate the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:48:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:48:01 +0000
Subject: [Koha-bugs] [Bug 22168] New: Improve styling of new chart settings
	for reports
Message-ID: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

            Bug ID: 22168
           Summary: Improve styling of new chart settings for reports
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The new chart settings are great fun, but appear a little "squashed". This
form's styling could be improved a little.

1) Run a report
2) Open chart options on top
3) Check out the various options of the form and the formatting

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:48:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:48:25 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-4uzn52uSfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17282


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282
[Bug 17282] Ability to create charts for SQL reports
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 14:48:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 13:48:25 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-Z00DzrxNdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22168


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168
[Bug 22168] Improve styling of new chart settings for reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:02:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:02:41 +0000
Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno
In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21683-70-Y6VYYXZJQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21722


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722
[Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:02:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:02:41 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
 Koha::Account->add_debit
In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21722-70-ETeNWZ9gXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683
[Bug 21683] Remove accountlines.accountno
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:03:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:03:33 +0000
Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno
In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21683-70-EF9T0nGi8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21728, 21756, 21747


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728
[Bug 21728] Update C4::Reserves::ChargeReserveFee to use
Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
[Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and
Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756
[Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit
instead)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:03:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:03:33 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-3xEmkkUkjo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683
[Bug 21683] Remove accountlines.accountno
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:03:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:03:33 +0000
Subject: [Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use
 Koha::Account->add_debit instead)
In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21756-70-yiQtyTKxrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683
[Bug 21683] Remove accountlines.accountno
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:03:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:03:33 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-R4U3VbyoS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683
[Bug 21683] Remove accountlines.accountno
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:04:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:04:34 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-CUJF4lnuXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|21721                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721
[Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:04:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:04:44 +0000
Subject: [Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use
 Koha::Account->add_debit instead)
In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21756-70-YowNaF1X3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:04:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:04:44 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-pSuScG984F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|21756                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756
[Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit
instead)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:04:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:04:54 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
 Koha::Account->add_debit
In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21722-70-upROfFyDQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:04:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:04:54 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-i3cm9zMcLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|21722                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722
[Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:04:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:04:34 +0000
Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use
 Koha::Account->add_debit
In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21721-70-tmVjpAFhPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:05:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:05:06 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-9Rh2VDmeOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:05:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:05:06 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-GmBaUA3iSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|21728                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728
[Bug 21728] Update C4::Reserves::ChargeReserveFee to use
Koha::Account->add_debit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:07:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:07:35 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-wd3aENOD1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:07:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:07:35 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-7Z2fqKhnPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|21747                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
[Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and
Koha::Account::Line->adjust
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:08:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:08:48 +0000
Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details
 Screen Use Self Register Field Options Incorrectly
In-Reply-To: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21192-70-J9SEvzGEzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com
                   |y.org                       |
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:10:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:10:50 +0000
Subject: [Koha-bugs] [Bug 22167] Allow itemnumber column to be labelled
 differently when using batch item edit feature
In-Reply-To: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22167-70-dtW3s9OZP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow itemnumber column to  |Allow itemnumber column to
                   |be labelled differently     |be labelled differently
                   |when using bach item edit   |when using batch item edit
                   |feature                     |feature
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:21:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:21:18 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-LqLvaH8Kgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.11                       |master
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:33:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:33:18 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-78YaJivvbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82501|0                           |1
        is obsolete|                            |

--- Comment #41 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84193&action=edit
Bug 20750: Allow logging of arbitrary actions

This patch allows logging of arbitrary actions on request objects. A
chronological summary of these actions can then be displayed when
viewing a request.

This patch also adds logging of request status changes. Additional work
has been done on the BLDSS backend to log requests to the BLDSS request
status check API.

To test:
- Apply patch
- Ensure the Illlog logging preference is turned on
- Create an ILL request and perform actions on it that change it's
status.
- Navigate to the "Manage ILL request" screen
- Click the "Display request log" button
- Observe that a modal opens displaying a summary of the status changes.

Signed-off-by: Niamh Walker <Niamh.Walker-Headon at it-tallaght.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:33:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:33:21 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-pQ4X5mVKr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82502|0                           |1
        is obsolete|                            |

--- Comment #42 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84194&action=edit
Bug 20750: (follow-up) Fix sorting of log entries

The log entries are received from C4::Log::GetLogs with their timestamps
formatted as '2018-18-10 16:09:29', this doesn't sort well. In fact, it
causes a warning in the Koha logs:

Argument "2018-10-04 15:48:15" isn't numeric in numeric comparison (<=>)
at /home/koha/kohaclone/Koha/Illrequest/Logger.pm line 231

This patch converts the timestamps to be sorted into epoch dates prior
to them being compared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:33:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:33:25 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-XMYRPnfBCb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82500|0                           |1
        is obsolete|                            |

--- Comment #43 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84195&action=edit
Bug 20750: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:34:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:34:05 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-3zIWc6IEDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #44 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Rebased following changes to C4/Log.pm & t/Log.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:52:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:52:45 +0000
Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details
 Screen Use Self Register Field Options Incorrectly
In-Reply-To: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21192-70-TyLYWm35yV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83017|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 84196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84196&action=edit
Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification

There was a mix up between "modification" and "edit" for $action in
opac-memberentry.pl.

If a patron is logged into the OPAC and they attempt to submit changes to their
personal details without having actually changed anything, the page reloads
with
a message stating 'No changes were made.' However, the fields that now appear
are those that have been allowed/hidden according to the preferences set for
patron self registration, even if patron self registration is disabled. This
can
lead to problems if there are discrepancies between the fields allowed for self
register settings and those allowed for patron self modification settings.

To replicate:

1.) In Administration ? System preferences > OPAC, set PatronSelfRegistration
to
'don't allow'

2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField
and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is
different between the two settings and save (for example, specify 'mobile' to
be
hidden in the former, but don't include in the list of fields to be hidden in
the latter).

3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice
that the editable fields correspond to those not hidden by
PatronSelfModificationBorrowerUnwantedField

4.) Without making any changes, click on 'Submit update request'.

5.) Note that on this page the fields correspond to those not hidden by
PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any
fields that would otherwise be hidden by the Self Modification settings).

Reported-By: Chris Slone <cslone at camdencountylibrary.org>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:52:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:52:59 +0000
Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details
 Screen Use Self Register Field Options Incorrectly
In-Reply-To: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21192-70-wsD41UV0se@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:53:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:53:19 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-BVmj1tVuGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #5)
> Created attachment 83252 [details] [review]
> Bug 21747: Use Koha::Account:: routines in UpdateFine
> 
> Set to use Koha::Account->add_debit and Koha::Account::Line->adjust
> 
> Known Side Effect: The format of the FinesLog, if enabled, is changed
> after this patch. Prior to this patch the $actionname was left undefined
> and the $infos field contained the string:
> 
> `"due=".$due."  amount=".$amount." itemnumber=".$itemnum`
> 
> After this patch, the logs are more consistent with other FINES logs,
> with an $actionname of 'CREATE' or 'UPDATE' and the $infos field
> containing a Dumper of fine data.
> 
> Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

I think we need to consider the backdated returns use case, and have another
offset for those, as fine_increment doesn't look right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 15:59:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 14:59:41 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18589-70-A6uSO0oWRe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

--- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84197&action=edit
Bug 18589: (follow-up) Fix QA error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:03:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:03:34 +0000
Subject: [Koha-bugs] [Bug 22169] New: ill-requests.tt failing QA test
Message-ID: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22169

            Bug ID: 22169
           Summary: ill-requests.tt failing QA test
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
  Target Milestone: ---

The id and class attributes on the body tag are causing:

not ok 2 - <body> tag with id and class attributes
#   Failed test '<body> tag with id and class attributes'
#   at xt/tt_valid.t line 91.
# Files list:
# intranet-tmpl/prog/en/modules/members/ill-requests.tt: 16

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:04:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:04:08 +0000
Subject: [Koha-bugs] [Bug 22169] ill-requests.tt failing QA test
In-Reply-To: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22169-70-NfJb3IMJ9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22169

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:07:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:07:54 +0000
Subject: [Koha-bugs] [Bug 22169] ill-requests.tt failing QA test
In-Reply-To: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22169-70-QMUqU3jA9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22169

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Actually, I'm going to fix this is bug 18589. It's a tiny fix and, although
that's not where the problem originated, it's the top of the ILL dependency
branch and we could really do without making that branch longer.

So marking as Resolved Moved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:07:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:07:27 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-H17cesNNQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84198&action=edit
Bug 16497: (follow-up) GET operations require staff access

With the introduction of the /public namespace all other endpoints, the
rest of the endpoints are restricted to privileged users.

This patch makes the GET /libraries and GET /libraries/:library_id
endpoints require 'catalogue' permissions.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:08:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:08:57 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18589-70-wfjuC7g7sq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

--- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84199&action=edit
Bug 18589: (follow-up) Fix QA failure

This patch removes the id and class attributes on the body tag in:

koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt

To test:
- Apply the patch
- Run the QA tools
- Note that the "Failed test '<body> tag with id and class attributes'"
no longer is reported

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:11:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:11:27 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-waidzhHMFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155
[Bug 22155] biblio_metadata.marcflavour should be renamed 'schema'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:11:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:11:27 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-o0XQo4U4du@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144
[Bug 22144] Add method marc() to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:20:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:20:28 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-SfVdlguyGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:20:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:20:31 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-e9B3tC4fsz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84182|0                           |1
        is obsolete|                            |
  Attachment #84183|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84200&action=edit
Bug 22155: DB update

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:26:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:26:03 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-dpEk3aM0kj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84201&action=edit
Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema

This patch makes the code using Koha::Biblio::Metadata->marcflavour use
->schema instead for all interactions.

To test:
- Update the DB structure:
  $ updatedatabase
- Update the schema files:
  $ dbic
- Notice all the places in which biblio_metadata is used
  $ cd kohaclone
  $ git grep biblio_metadata
=> SUCCESS: They all use `schema` instead of marcflavour
- Notice all the places that use Koha::Biblio::Metadata:
  $ git grep Koha::Biblio::Metadata
=> SUCCESS: They all use the schema attribute when they used to use
marcflavour
- Run all the modified tests and scripts
=> SUCCESS: We are all good
- Sign off :-D

Note: while this seems like a minor change, the places in which plain
SQL is used really require understanding the queries and how they are
used, because some query results might be passed to some other method
that in turn uses the marcflavour attribute. I of course took that into
account but errare humanum est :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:30:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:30:56 +0000
Subject: [Koha-bugs] [Bug 22170] New: Library group description input field
 should be longer
Message-ID: <bug-22170-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170

            Bug ID: 22170
           Summary: Library group description input field should be longer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

When editing a library group's description the input field is really short
which makes it hard to edit. A longer input or a multi-line input would be
nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:32:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:32:23 +0000
Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL
	request statuses
In-Reply-To: <bug-20581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20581-70-UoyjtviOXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #131 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84202&action=edit
Bug 20581: (follow-up) Fix QA errors

This patch fixes the "missing_filter" errors on ill-requests.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:34:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:34:46 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-LfJ26hqeuj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #45 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84203&action=edit
Bug 20750: (follow-up) Fix QA errors

This patch fixes the "missing_filter" QA error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:39:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:39:20 +0000
Subject: [Koha-bugs] [Bug 22170] Library group description input field
	should be longer
In-Reply-To: <bug-22170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22170-70-4CkwFF9i62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:40:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:40:17 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18589-70-4OYIbFa85V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

--- Comment #10 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84204&action=edit
Bug 18589: (follow-up) Fix QA errors

This patch fixes the "missing_filter" QA errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 16:53:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 15:53:17 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-BgsnPJ5xRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84205&action=edit
Bug 22144 [QA Followup]: Move Koha::Biblio::marc to
Koha::Biblio::Metadata::record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:02:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:02:12 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-k8AjpRbzET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83944|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84206&action=edit
Bug 22125: branches.pickup_location should be flagged as boolean

This trivial patch just marks the mentioned column as a boolean.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

https://bugs.koha-community.org/show_bug.cgi?id=16497

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:02:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:02:10 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-uPZPdS7i3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:26:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:26:14 +0000
Subject: [Koha-bugs] [Bug 12967] Allow to choose currency for calculating
	shipping cost
In-Reply-To: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12967-70-NQT9unlBHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12967

abyrne at ait.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
                 CC|                            |abyrne at ait.ie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:31:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:31:13 +0000
Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in
	acquisitions
In-Reply-To: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18412-70-kuix6kSMGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412

abyrne at ait.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abyrne at ait.ie
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:31:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:31:17 +0000
Subject: [Koha-bugs] [Bug 12967] Allow to choose currency for calculating
	shipping cost
In-Reply-To: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12967-70-ggmc0XPUeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12967

Niamh <niamh.walker-headon at it-tallaght.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |niamh.walker-headon at it-tall
                   |                            |aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:36:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:36:15 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-BhvUCJN51g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84207&action=edit
Bug 22061: (QA follow-up) Rename password_2 => password_repeated

As voted when the RFC was discussed, the attribute gets renamed. The
tests are adjusted accordingly.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:58:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:58:36 +0000
Subject: [Koha-bugs] [Bug 22171] New: Format shipping cost on invoice.pl
 with with 2 decimals
Message-ID: <bug-22171-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171

            Bug ID: 22171
           Summary: Format shipping cost on invoice.pl with with 2
                    decimals
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The shipping cost on an invoice will show as 12.00000 instead of 12.00.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 17:58:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 16:58:19 +0000
Subject: [Koha-bugs] [Bug 12967] Allow to choose currency for calculating
	shipping cost
In-Reply-To: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12967-70-DwEPYmbHjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12967

abyrne at ait.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1 - high                   |P4

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 18:05:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 17:05:46 +0000
Subject: [Koha-bugs] [Bug 19661] Add routes for funds
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-GaJJ0EPmtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needs_rfc                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 18:07:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 17:07:26 +0000
Subject: [Koha-bugs] [Bug 22172] New: EDI order records with zero items
	create one item
Message-ID: <bug-22172-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22172

            Bug ID: 22172
           Summary: EDI order records with zero items create one item
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bdaeuber at cityoffargo.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When creating a grid order in which we are not ordering a copy for every
branch, lines with zero items in the EDIFACT message are creating one item in
Koha. Some vendors delete lines with zero items, but some do not and zero items
should not create an item for that branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 18:20:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 17:20:23 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-HwVz7sZ58s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 18:20:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 17:20:26 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-xidEDXasoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84208&action=edit
Bug 22168: Improve styling of new chart settings for reports

This patch updates a number of aspects of the reports chart creation
interface: Chart creation form is now shown in a modal window, and a
separate link has been added to show or hide the chart itself.

Also changed: Minor markup and JavaScript cleanup.

To test, apply the patch and go to Reports -> Saved reports.

- Run a report which returns more than one column.
- On the report results page, click the "Create chart" button. The chart
  settings form should appear in a modal window.
- Confirm that the form controls work correctly: Each label should give
  focus to the correct input. Changing the chart type should show or
  hide the appropriate form fields.
- Click the "Draw" button. The modal should disappear and the chart
  should be shown.
- Above the chart should be a "Hide chart" link which works to hide (and
  then show) the chart.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 18:23:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 17:23:08 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-FfvPeiT2sP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Would anyone be willing to take another look at this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 18:39:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 17:39:45 +0000
Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the
 library's calendar and skip closed days
In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18064-70-jgTufVUBP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064

Andrew <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #5 from Andrew <andrew at bywatersolutions.com> ---
Giving this bug a bump as this continues to be a source of confusion and
frustration for any library that wants their overdues to follow the calendar
and their 3rd overdue to line up with their longoverduelost behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:17:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:17:38 +0000
Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected
	structure
In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22173-70-9dsW4UErRB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:17:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:17:33 +0000
Subject: [Koha-bugs] [Bug 22173] New: Search Groups broken by change in
 expected structure
Message-ID: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

            Bug ID: 22173
           Summary: Search Groups broken by change in expected structure
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The original logic of Search Groups using the heirarchical library groups was
to enable search groups on a root group and have each sub group be a search
group listed in the pulldown:

RootGroup:
   SearchGroup1:
        LibraryA
        LibraryB
   SearchGroup2:
        LibraryC
        LibraryD
   SearchGroup3:
        LibraryE
        LibraryF

At some point, the code was changed to expect the each search group to be the
root group:

RootSearchGroup1:
    LibraryA
    LibraryB

RootSearchGroup2:
    LibraryC
    LibraryD

RootSearchGroup3:
    LibraryE
    LibraryF

It's likely that both styles are being used in production now with different
versions. If a library upgrades, their search groups will be broken. If we
revert the change, currently up to date libraries will have search groups
broken.

Instead, we should accommodate both configurations.

So, if a root group has libraries as direct children, it should be displayed as
a search group. If it does not, we should display the child search groups
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:21:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:21:18 +0000
Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected
	structure
In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22173-70-dIN8nZsULg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:21:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:21:21 +0000
Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected
	structure
In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22173-70-7pdlM6CCs9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84209&action=edit
Bug 22173: Search Groups broken by change in expected structure

The original logic of Search Groups using the heirarchical library groups was
to enable search groups on a root group and have each sub group be a search
group listed in the pulldown:

RootGroup:
   SearchGroup1:
        LibraryA
        LibraryB
   SearchGroup2:
        LibraryC
        LibraryD
   SearchGroup3:
        LibraryE
        LibraryF

At some point, the code was changed to expect the each search group to be the
root group:

RootSearchGroup1:
    LibraryA
    LibraryB

RootSearchGroup2:
    LibraryC
    LibraryD

RootSearchGroup3:
    LibraryE
    LibraryF

It's likely that both styles are being used in production now with different
versions. If a library upgrades, their search groups will be broken. If we
revert the change, currently up to date libraries will have search groups
broken.

Instead, we should accommodate both configurations.

So, if a root group has libraries as direct children, it should be displayed as
a search group. If it does not, we should display the child search groups
instead.

Test Plan:
1) Set up a root group with multiple subgroups each with libraries,
   enable staff and opac search groups for that root group
2) Note the root group is displayed in all the search pulldowns instead
   of the subgroups
3) Apply this patch
4) Restart all the things!
5) Note the search pulldowns now contain the subgroups instead
6) Create another root group, add only libraries to it.
   Set it as a search group for staff and opac.
7) Note the search pulldowns now contain this group as well!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:26:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:26:19 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-AyWTqRdwup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:26:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:26:37 +0000
Subject: [Koha-bugs] [Bug 22144] Add method marc() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-UdYWPxLKbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22155                       |
             Status|Signed Off                  |In Discussion


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155
[Bug 22155] biblio_metadata.marcflavour should be renamed 'schema'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 19:26:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 18:26:37 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-KK22jzCHEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22144                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144
[Bug 22144] Add method marc() to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:10:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:10:40 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-qhCWKviCIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #422 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84210&action=edit
Bug 17047: (follow-up) Improve mana messages, enable by default, show messages
if not configured

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:13:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:13:10 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-fjmniq3R77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #423 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #422)
> Created attachment 84210 [details] [review]
> Bug 17047: (follow-up) Improve mana messages, enable by default, show
> messages if not configured

Hi Alex,

I added a followup to enable by default, show a helpful tip if not configured,
and updated some language - if this one is okay can you remove the third option
from the syspref, squash the followups and then I think we can push this one.

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:16:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:16:53 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl
In-Reply-To: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21346-70-bMlIemVXPG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:17:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:17:32 +0000
Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected
	structure
In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22173-70-i73WZkOiyP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:17:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:17:35 +0000
Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected
	structure
In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22173-70-cd2RKGo0MF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84209|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84211&action=edit
Bug 22173: Search Groups broken by change in expected structure

The original logic of Search Groups using the heirarchical library groups was
to enable search groups on a root group and have each sub group be a search
group listed in the pulldown:

RootGroup:
   SearchGroup1:
        LibraryA
        LibraryB
   SearchGroup2:
        LibraryC
        LibraryD
   SearchGroup3:
        LibraryE
        LibraryF

At some point, the code was changed to expect the each search group to be the
root group:

RootSearchGroup1:
    LibraryA
    LibraryB

RootSearchGroup2:
    LibraryC
    LibraryD

RootSearchGroup3:
    LibraryE
    LibraryF

It's likely that both styles are being used in production now with different
versions. If a library upgrades, their search groups will be broken. If we
revert the change, currently up to date libraries will have search groups
broken.

Instead, we should accommodate both configurations.

So, if a root group has libraries as direct children, it should be displayed as
a search group. If it does not, we should display the child search groups
instead.

Test Plan:
1) Set up a root group with multiple subgroups each with libraries,
   enable staff and opac search groups for that root group
2) Note the root group is displayed in all the search pulldowns instead
   of the subgroups
3) Apply this patch
4) Restart all the things!
5) Note the search pulldowns now contain the subgroups instead
6) Create another root group, add only libraries to it.
   Set it as a search group for staff and opac.
7) Note the search pulldowns now contain this group as well!

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:21:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:21:17 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-mYepmTfaKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84208|0                           |1
        is obsolete|                            |

--- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84212&action=edit
Bug 22168: Improve styling of new chart settings for reports

This patch updates a number of aspects of the reports chart creation
interface: Chart creation form is now shown in a modal window, and a
separate link has been added to show or hide the chart itself.

Also changed: Minor markup and JavaScript cleanup.

To test, apply the patch and go to Reports -> Saved reports.

- Run a report which returns more than one column.
- On the report results page, click the "Create chart" button. The chart
  settings form should appear in a modal window.
- Confirm that the form controls work correctly: Each label should give
  focus to the correct input. Changing the chart type should show or
  hide the appropriate form fields.
- Click the "Draw" button. The modal should disappear and the chart
  should be shown.
- Above the chart should be a "Hide chart" link which works to hide (and
  then show) the chart.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:21:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:21:33 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-Eh1bXOtSsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:37:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:37:36 +0000
Subject: [Koha-bugs] [Bug 22145] Add a syspref to hide the 'rows per page'
 dropdown when running a report
In-Reply-To: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22145-70-CsTyDNoOe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22145

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
I followed the test plan and all seemed to work, but when I checked the QA
test, it failed :

<<<<<
 FAIL   installer/data/mysql/sysprefs.sql
   OK     git manipulation
   FAIL   semicolon
                simicolon found instead of comma at line 483
   OK     sysprefs_order

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template
>>>>>

Therefore, I set the Failed QA status until.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:40:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:40:28 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-z1b5pHw9tP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82851|0                           |1
        is obsolete|                            |
  Attachment #84155|0                           |1
        is obsolete|                            |

--- Comment #12 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84213&action=edit
Bug 21918: Update buttons on fines to match newer buttons

This patch makes a number of changes to the "Pay fines" template, the
goal of which is to make the interface look better in general. Changes
include:

 - Styling the "Pay" and "Write off" buttons as Bootstrap buttons.
 - Adding DataTables sorting, searching, and filtering.
 - Adding a column showing the fine date.
 - Hide the "Add note" input, add a link to show it.
 - Add some missing "preventDefault" methods from events.
 - Add "Writeoff selected" to the buttons which are disabled when there
   is no checkbox selection.
 - The <tfoot> tag is now expected by the HTML validator to be after
   <tbody>, so this section has been moved to suppress validator errors.

To test, apply the patch and locate a patron who has multiple
outstanding fines.

 - Go to Fines -> Pay fines
 - Confirm that the table of fines is shown as a DataTable, with sorting
   on columns which have data.
 - Test columns settings in Administration -> Columns settings.
 - Confirm that fine dates are shown, and that sorting by this column
   works correctly.
 - Click an "Add note" link to show a note input field. Focus should be
   in the newly-displayed input.
   - Confirm that notes are still saved correctly when paying or writing
     off single or multiple fines.
   - Confirm that when the "add note" input is hidden, its contents are
     erased.
 - Uncheck all checkboxes by clicking the "Clear all" link at the top.
   The "Pay selected" and "Write off selected" buttons should become
   disabled.
   - Checking any checkbox should re-enable those buttons.
 - Test that the relocated "Apply" button (for outstanding credits)
   still works as expected.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:49:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:49:03 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-F82Vi7LcWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:49:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:49:06 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-X3x7IKBFKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83998|0                           |1
        is obsolete|                            |

--- Comment #8 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84214&action=edit
Bug 22134: Add account expiration information to patron details

This patch modifies the patron detail template in the staff client so
that when a patron's registration is expired a message shows at the top
of the page along with the same "Renew" and "Edit" links which appear on
the checkout page. Links are also shown next the the expiration date in
the body of the page.

This patch also corrects the capitalization of the "Edit Details" link
on circulation.tt.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.
 - On the patron's checkout page the "Edit details" link in the
   expiration message should have correct capitalization.

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:49:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:49:34 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-hHtpoML45S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84191|0                           |1
        is obsolete|                            |

--- Comment #9 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84215&action=edit
Bug 22134: (follow-up) Simplify check for expired patron

This patch move the check for "is_expired" to the template and removes
unnecessary code from the script.

The page now correctly handles messages for patrons who are about to
expire, as defined in the NotifyBorrowerDeparture preference.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.

Select a patron who will expire within the period defined in
NotifyBorrowerDeparture.

 - On the patron detail page you should see a message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:53:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:53:57 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-DDNXae17gQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #28 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Failed to apply patch 

Bug 14723 - Additional delivery notes to messages

78313 - Bug 14723: Additional delivery notes to messages

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14723: Additional delivery notes to messages
Using index info to reconstruct a base tree...
M       C4/Letters.pm
M       installer/data/mysql/kohastructure.sql
M       koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
M       t/db_dependent/Letters.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Letters.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14723: Additional delivery notes to messages
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-vyvgwK.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:54:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:54:10 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-TQ7mX41oDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84156|0                           |1
        is obsolete|                            |

--- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84217&action=edit
Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes.

Fixed ExtendedPatronAttributes typo.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:53:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:53:47 +0000
Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter'
In-Reply-To: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20171-70-piMN6Sy69R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84169|0                           |1
        is obsolete|                            |

--- Comment #3 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84216&action=edit
Bug 20171: Fixed CSV output to use syspref 'delimiter' in export files

To Find Fix:

1. Go to sysprefs and change delimiter to slashes
2. Under the Search drop down click Item search
3. Set Output as CSV
4. Click Search
5. A file should be downloaded and when opened the set delimiter should
appear as the delimiter

Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 20:54:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 19:54:25 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-OqepMRD1ho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:03:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:03:29 +0000
Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not
 scramble email addresses
In-Reply-To: <bug-21535-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21535-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21535-70-Wefpil8iVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Could not apply patch

80349 - Bug 21535: Anonymize function in Patron should not scramble email
addresses

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21535: Anonymize function in Patron should not scramble email
addresses
fatal: sha1 information is lacking or useless (Koha/Patron.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 21535: Anonymize function in Patron should not
scramble email addresses
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-21535-Anonymize-function-in-Patron-should-not--A7pXsa.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:12:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:12:40 +0000
Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form
In-Reply-To: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21312-70-hst7iUdVvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80385|0                           |1
        is obsolete|                            |

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84218&action=edit
Bug 21312: Show lockout on Patrons form

Just what the title says :)
Specifically: moremember.pl

Test plan:
Check if you see the locked message on the patron form for an account
that has been locked. (Either login_attempts<0 or >FailedLoginAttempts)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:16:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:16:49 +0000
Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form
In-Reply-To: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21312-70-2idbInXsxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:21:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:21:26 +0000
Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration
 to overdues report
In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21852-70-nEXOj7OZb1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Patch doesn't apply

82550 - Bug 21852: Add more columns and column configuration to overdues report

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21852: Add more columns and column configuration to overdues
report
Using index info to reconstruct a base tree...
M       admin/columns_settings.yml
M       koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
Auto-merging admin/columns_settings.yml
CONFLICT (content): Merge conflict in admin/columns_settings.yml
error: Failed to merge in the changes.
Patch failed at 0001 Bug 21852: Add more columns and column configuration to
overdues report
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-21852-Add-more-columns-and-column-configuratio-WOKvpz.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:51:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:51:02 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-BQfloPHTGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83853|0                           |1
        is obsolete|                            |

--- Comment #18 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 84219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84219&action=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:51:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:51:31 +0000
Subject: [Koha-bugs] [Bug 21945] Clean up stock rotation template
In-Reply-To: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21945-70-uyjKTdtiEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82849|0                           |1
        is obsolete|                            |

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84220&action=edit
Bug 21945: Clean up stock rotation template

This patch makes some minor markup upgrades to the stock rotation
template: Replace some YUI markup with Bootstrap; Add some missing <tr>
tags; Remove invalid "type" attribute from <script> tag.

To test, apply the patch and go to Tools -> Stock rotation. Confirm that
the page looks correct and adjusts well at various browser widths. Test
with various views: New rota, edit rota, manage stages, manage items.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:51:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:51:44 +0000
Subject: [Koha-bugs] [Bug 21945] Clean up stock rotation template
In-Reply-To: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21945-70-a6C7khGBB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:51:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:51:50 +0000
Subject: [Koha-bugs] [Bug 22110] Editing adjustments doesn't work for
 Currencyformat != US
In-Reply-To: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22110-70-eydIQiyR40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84161|0                           |1
        is obsolete|                            |

--- Comment #3 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84221&action=edit
Bug 22110: Fix editing of adjustments for CurrencyFormat != US

When using CurrencyFormat FR or CH the editing an amount behave
badly. Example: changing displayed 1,00 to 1,11 would save as 1,00.

At the moment Koha only understands decimal dot, not comma.
So every time data is entered, we use decimal dot.

1) Add an adjustment to an invoice
2) Change system preference CurrencyFormat to FR or CH
3) Verify the amount displays with a decimal comma
4) Try changing the amount to something like 1,11
5) Save the amount
6) Verify it shows 1.00
7) Apply patch
8) Refresh the invoice page if necessary
9) Verify amount is now shown as 1.00
10) Repeat test, use 1.11
11) Verify it will be stored correctly.

Signed-off-by: Mackey Johnstone <mackeyfj at gmail.com>
Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:55:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:55:26 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-wPuYbkUMpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84005|0                           |1
        is obsolete|                            |

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 84223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84223&action=edit
Bug 21871: (follow-up) Remove link tracking

Links to tracklinks.pl were erroneously copied from detail.tt. This
patch removes them.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:55:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:55:16 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-zURHEomZTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84099|0                           |1
        is obsolete|                            |

--- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84222&action=edit
Bug 20491: Updating the MARC subfield desciption of 952q

Test plan:
1) Go to admin, then to MARC frameworks, then to default
frameworks structure, then subfield stucture for 952
2) Verify that 'q'
is described as 'checked out'
3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
4) Verify
that 'q' is also descirbed as 'Checked out' in
5) Apply patch and update
your database
6) Verify that the description of 'q' has changed to 'Date
due'
7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
6) Verify that it has changed to 'Date due'

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:55:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:55:48 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-CL7pTl3s0d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:55:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:55:51 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-S59DfP7nN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83919|0                           |1
        is obsolete|                            |

--- Comment #7 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84224&action=edit
Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds

Patch makes use fo patron-string.inc for displaying the patron information
on the waiting holds report.

It also adds spans with classes for phone and email.

To Test:
1 - View the holds awaiting pickup report
2 - Note there is no cardnumber for the patron
3 - Apply patch
4 - Cardnumber shows now
5 - Verify the same works for 'Holds over' tab

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:57:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:57:14 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-MShgTgZgIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:57:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:57:38 +0000
Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric
 in numeric eq (==)
In-Reply-To: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21170-70-FwMOz30jW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:57:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:57:52 +0000
Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details
 Screen Use Self Register Field Options Incorrectly
In-Reply-To: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21192-70-77X8y8WWMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:57:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:57:26 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
 gives no results if search terms include punctuation
In-Reply-To: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21084-70-8gIkYdJwdM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:58:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:58:06 +0000
Subject: [Koha-bugs] [Bug 21491] When 'Default lost item fee refund on
 return policy' is unset it says no but acts as if 'yes'
In-Reply-To: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21491-70-VCefAK33Wa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:58:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:58:45 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-vtxiIs1I4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:59:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:59:09 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-vddbjlEyF6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:59:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:59:22 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-xqO6GkK10C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:59:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:59:36 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-SfLe9LAR4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:59:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:59:39 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-0vNtHyZABm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84095|0                           |1
        is obsolete|                            |

--- Comment #5 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84225&action=edit
Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob"
to "cleanup_database"

To Find Fix:

1. Go to Koha Administration
2. Search PatronSelfRegistrationVerifyByEmail
3. Verify that NOTE now says "system preference requires the
cleanup_database ..."

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>


 Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 21:59:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 20:59:51 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-OWEzL00sJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:00:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:00:06 +0000
Subject: [Koha-bugs] [Bug 22101] ILL requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-Bx1yYGxn1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:00:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:00:21 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-Am2Y7Qtwct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:00:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:00:42 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-mvcwQ9iz6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
I figured your first patch was not neccessary, so I put the tag obsolete on it
and only tested the second one, it seems to work correctly. It's signed off :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:01:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:01:24 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-Ygt6Z1dhxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #442 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #441)
> (In reply to Nick Clemens from comment #440)
> > Created attachment 84115 [details] [review] [review]
> > Bug 7143: Update about page for new devs (Academy)wq
> 
> Pushed to master for 19.05

Pushed fix for tyop, sorry Helene

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=824e9a7c9e3dc2f46043b5a4361d8beb57419d15

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:01:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:01:45 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-iQS77bJS9o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84098|Bug 20491: Test plan: 1) Go |Bug 20491: Test plan: 1) Go
        description|to admin, then to MARC      |to admin, then to MARC
                   |frameworks, then to default |frameworks, then to default
                   |frameworks structure, then  |frameworks structure, then
                   |subfield stucture for 952   |subfield stucture for 952
                   |2) Verify that 'q' is       |2) Verify that 'q' is
                   |described as 'checked out'  |described as 'checked out'
                   |3) Go to                    |3) Go to
                   |<intranet>/cgi-bin/koha/cat |<intranet>/cgi-bin/koha/cat
                   |aloguing/additem.pl?biblion |aloguing/additem.pl?biblion
                   |umber=x 4)                  |umber=x 4)
  Attachment #84098|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:06:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:06:44 +0000
Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by
 cardnumber if userid exists in file and in Koha
In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21465-70-Hq3HNxl3XL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #17)
> (In reply to Jesse Maseto from comment #16)
> > This was backported to 18.05.x for 18.05.07
> 
> I think it is in 18.05.08?

Yes, 18.05.08 NOT 18.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:24:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:24:25 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-TBPEm8HZ8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:35:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:35:35 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-b9UeKjDacg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84158|0                           |1
        is obsolete|                            |

--- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84226&action=edit
Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table

Test plan:
1. From homepage, go to Koha Amdinistration
2. Go to Authorised Values
3. Scroll down to ITEMTYPECAT and click Add
4. Give the new authorised value an Authorised value and Description
5. Save it
6. On the left, go to Item types
7. Click Edit on an item type
8. Under Search Catergory, select the new authorised value you just
created. It should appear in the dropdown as it's description
9. Click Save changes
10. Under Search category for the item type you just edited, you should see
your new authorised values' description

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:36:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:36:05 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-AIs26vxEfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:43:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:43:36 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-4aRo7MksyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:43:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:43:39 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-PjHh4Ugbnd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83888|0                           |1
        is obsolete|                            |

--- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84227&action=edit
Bug 22102: Markup fixes for OPAC article request page

This patch makes a few improvements to the OPAC article request page:

- Improve the breadcrumbs menu by adding a link to the title
- Add a header with the record's title
- Wrap the "no article requests" message in the correct dialog div
- Remove obsolete CDATA marker

To test, apply the patch and log in to the OPAC

 - Peform a search which will return multiple results
 - Click "Request article" on a title for which article requests can be
   submitted.
   - Confirm that the breadcrumbs menu looks and works correctly.
 - Click "Request article" on a title for which article requsts are not
   allowed.
   - Confirm that the message is correctly styled.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 22:59:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 21:59:07 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-9v7Lh0kHqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83987|0                           |1
        is obsolete|                            |

--- Comment #6 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84228&action=edit
Bug 22111: Format amount shown on place holds when maxoutstanding is reached
(staff)

Displays amount outstanding correctly when holds are blocked
by maxoutstanding.

To test:
- Check maxoutstanding system preference value
- Add a fine to a patron account exceeding maxoutstanding
- Try to place a hold for this patron from staff
- Verify this message is shown:

     Patron has outstanding fines: 6.00

- Toggle CurrencyFormat system preference and verify display
  changes according to setting

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 23:01:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 22:01:35 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-HNHG03DUDk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83923|0                           |1
        is obsolete|                            |

--- Comment #4 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84229&action=edit
Bug 22113: Add price formatting on item lost report

The item lost report displays the price and replacement
price for lost items. With the patch they will display
according to the CurrencyFormat system preference.

To test:
- Mark 1 or more items lost
- Make sure that replacement cost and purchase price are set
- Go to Reports > Items lost
- Search for your lost items
- Verify price and replacement price display
- Apply patch and toggle CurrencyFormat to different settings
- Refresh lost items report
- Verify prices are always displayed according to syspref setting

Signed-off-by: Olivia Lu <olivialokm at gmail.com>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 23:11:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 22:11:07 +0000
Subject: [Koha-bugs] [Bug 21997] SIP patron information requests can lock
 patron out of account
In-Reply-To: <bug-21997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21997-70-DpWSmkKlUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21997

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83183|0                           |1
        is obsolete|                            |

--- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 84230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84230&action=edit
Bug 21997 - SIP patron information requests can lock patron out of account

Many SIP services send an empty password field (AD). Even if
allow_empty_passwords is enabled for the given SIP account, this empty password
is run though Koha's password checker which increments the number of login
attempts for a patron. Thus repeated patron information requests can lock a
patron out! Empty password fields in SIP should not call for a password check
if allow_empty_passwords is enabled.

Test Plan:
1) Enable a patron password attempt with a limit of 3
2) Send 4 patron information requests with an empty AD field
3) Note the patron's account is now locked
4) Apply this patch
5) Repeat step 2 with a different patron
6) Note the patron's account does not get locked!

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 18 23:19:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Jan 2019 22:19:37 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-LrxyJ1CiWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83920|0                           |1
        is obsolete|                            |

--- Comment #5 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84231&action=edit
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>
Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 05:17:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 04:17:12 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-UK6Yi4se3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #6 from David Nind <david at davidnind.com> ---
I was testing but didn't notice that it was already signed-off!

For the frameworks: I can confirm that this works as intended after the patch
is applied.

For NEW items checked out: I can confirm that this works as intended for NEW
items checked out after the patch is applied. That is, the column heading
displays as 'Due date'.

For EXISTING items already checked out: It doesn't seem to work for EXISTING
items checked out before the patch is applied. That is, the column heading
stays as 'Checked out'.
- Is something required in the database update to update all existing checked
out items?
- Is it something to do with caching? I restarted all services (using
koha-testing-docker = restart_all), rebuilt the index (koha-rebuild-zebra -f -v
kohadev), and used a browser with all the history completely cleared.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 05:22:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 04:22:00 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-nQIuSmn85m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

--- Comment #7 from David Nind <david at davidnind.com> ---
Also, a couple of things I noted that are probably obvious to those more
familiar with Koha and testing:

- Test plan: Between steps 2 and 3, you need to check an item out for a record
and use that record number for 'x' in step 3. Otherwise, the 'Checkout out'
column doesn't display. This drove me a bit nuts trying to find the column
(just kidding!).

- The patch involves database updates. If you remove the branch used to test
the bug (for example, git branch -D bz20491) and reset your koha repository
(git reset --hard origin/master) then the column still displays as 'Due date'.
You need to either reset the database (however you do that) or refresh your
development environment (koha-testing-docker = CTRL C, docker-compose -p koha
down, docker-compose -p koha up).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 07:15:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 06:15:21 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-C7IuW5mgET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
My testing matches your screenshots in comment #6 and #7.

However, there is some inconsistency in how the different account screens
display. I can post some screenshots if you would like.

When you narrow the screen width down most of the account screens leave the
account information on the top left (name, address, etc), the menu items under
this (Check out, Details, etc), and then content for the screen to the right.

Th API key screen along with the Holds history and Modification log behave in a
more responsive manner. These have the particular screen first, the account
information, then the menu items.

If this is what you intended (the results matching your screenshots) then I am
happy to sign-off on that basis.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 07:17:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 06:17:41 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-K7rbDVi3ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83815|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 84232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84232&action=edit
Bug 22104: Clean up patron API keys template

This patch makes two corrections to the patron API key template: Convert
to Bootstrap grid and correct class on "new key" button.

To test, apply the patch and enable the RESTOAuth2ClientCredentials
preference.

 - Open a patron record in the staff client and choose More -> Manage
   API keys.
 - On the API keys page, confirm that the page adjusts well at various
   page widths.
 - Confirm that the size of the "Generate new client id/key pair" button
   matches the buttons in the toolbar.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 09:11:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 08:11:11 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-5DuLRmXehO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:08:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:08:54 +0000
Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and
 GetAllPendingTransfers functions to ease testing.
In-Reply-To: <bug-14188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14188-70-OhCz39Lsjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|BLOCKED                     |RESOLVED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Agreeing with Joseph - just changing status as BLOCKED usually indicates we are
waiting for something higher up in the dependency tree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:08:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:08:55 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-tm3wF3m8GY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
Bug 9525 depends on bug 14188, which changed state.

Bug 14188 Summary: branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:12:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:12:35 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Sg9FLRxUao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #424 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi all, as this means you are communicating with an external server, I am not
sure if we should enable by default. I think all those should be opt-in
choices. Even an IP address is considered personal data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:15:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:15:09 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-VNCJfmwUJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #425 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
So last comment doesn't get missed (it's a looong bug)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:21:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:21:43 +0000
Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter'
In-Reply-To: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20171-70-O6VfDQ7VSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com
           Assignee|koha-bugs at lists.koha-commun |olivialokm at gmail.com
                   |ity.org                     |

--- Comment #4 from David Nind <david at davidnind.com> ---
Signed-off by Mika?l, but status not changed. So have updated.

Also changed assignee to Olivia.

(Can confirm the patch works as expected).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:30:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:30:11 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-5mRdL7Vezm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #426 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Katrin Fischer from comment #424)
> Hi all, as this means you are communicating with an external server, I am
> not sure if we should enable by default. I think all those should be opt-in
> choices. Even an IP address is considered personal data.

If it the syspref is set to 0, BUT there is no mana token, there's no
communication.
The patch just remove the syspref value "I haven't decided" and replace it by
"set to yes + no token = the librarian hasn't decided"
And the token is set only when the library ask for it by clicking on the "get
token button".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:30:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:30:56 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ox6ouZs5yK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:55:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:55:34 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-4vUC5y0eMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #427 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Paul, thx for replying!

I've applied the patches and taken a look at the configuration page. What's the
difference between the 'no' and 'no, let me think about it'? Where is it
explained? I think as the system preference reads "Enable request to Mana
Webservice" this is not clear to the user that there is no communication
without the token. I would feel better if we left to "no". We can still
advertise Mana of course - I am not against the service at all, but I feel we
should be consistent and clear about protecting user's privacy.

Noticing while testing: commmit messages are a bit messy and not following
guidelines (old patch, I know, but easy to fix). I even volunteer doing it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 10:56:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 09:56:19 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-YEObouxWei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Jasmine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 11:08:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 10:08:49 +0000
Subject: [Koha-bugs] [Bug 22166] Add cron to automatically finish transfers
 based on some configuration
In-Reply-To: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22166-70-rksImWTg9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Josef, can you explain the use case a bit more?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 22:09:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 21:09:03 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-1199vRGE6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Moving to passed QA since Mikael has signed off and freed my QA token :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 22:24:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 21:24:18 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-eSNzb6jagW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:40:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:40:11 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-SbJK5mxDn3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:40:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:40:15 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-gC0A4clL1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84212|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84233&action=edit
Bug 22168: Improve styling of new chart settings for reports

This patch updates a number of aspects of the reports chart creation
interface: Chart creation form is now shown in a modal window, and a
separate link has been added to show or hide the chart itself.

Also changed: Minor markup and JavaScript cleanup.

To test, apply the patch and go to Reports -> Saved reports.

- Run a report which returns more than one column.
- On the report results page, click the "Create chart" button. The chart
  settings form should appear in a modal window.
- Confirm that the form controls work correctly: Each label should give
  focus to the correct input. Changing the chart type should show or
  hide the appropriate form fields.
- Click the "Draw" button. The modal should disappear and the chart
  should be shown.
- Above the chart should be a "Hide chart" link which works to hide (and
  then show) the chart.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:44:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:44:20 +0000
Subject: [Koha-bugs] [Bug 22174] New: Add specific help link to
 /cgi-bin/koha/members/apikeys.pl
Message-ID: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174

            Bug ID: 22174
           Summary: Add specific help link to
                    /cgi-bin/koha/members/apikeys.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The API keys page in staff has no specific help, the help link on the top
directs to the start page of the manual. It would be nice if this lead to a
more helpful one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:46:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:46:34 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-I5eYIc4MnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84232|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84234&action=edit
Bug 22104: Clean up patron API keys template

This patch makes two corrections to the patron API key template: Convert
to Bootstrap grid and correct class on "new key" button.

To test, apply the patch and enable the RESTOAuth2ClientCredentials
preference.

 - Open a patron record in the staff client and choose More -> Manage
   API keys.
 - On the API keys page, confirm that the page adjusts well at various
   page widths.
 - Confirm that the size of the "Generate new client id/key pair" button
   matches the buttons in the toolbar.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:46:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:46:30 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-Hq4NVFaCMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:49:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:49:30 +0000
Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of
 code in itemtypes summary table
In-Reply-To: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20238-70-oH1ERKjtIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but there are some things wrong with this patch:

1) If you take a look at the changes commited, you can see it includs a lot of
unintentional changes:

---
 Koha/Illbackends/BLDSS                                  |   1 +
 Koha/Illbackends/koha-ill-freeform                      |   1 +
 admin/itemtypes.pl                                      |   2 ++
 koha-ill-freeform                                       |   1 +
 .../prog/en/modules/admin/.itemtypes.tt.swp             | Bin 0 -> 40960 bytes
 .../intranet-tmpl/prog/en/modules/admin/itemtypes.tt    |   4 +++-
 6 files changed, 8 insertions(+), 1 deletion(-)
 create mode 160000 Koha/Illbackends/BLDSS
 create mode 160000 Koha/Illbackends/koha-ill-freeform
 create mode 160000 koha-ill-freeform
 create mode 100644
koha-tmpl/intranet-tmpl/prog/en/modules/admin/.itemtypes.tt.swp

2) Using the TT plugin on the template side, the changes to admin/itemtypes.pl
are no longer needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:54:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:54:05 +0000
Subject: [Koha-bugs] [Bug 22175] New: Make stock rotation table sortable
Message-ID: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

            Bug ID: 22175
           Summary: Make stock rotation table sortable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The table for stock rotation rotas is not sortable yet. It would be nice if it
was.

- Go to Tools > Stock rotation
- Add some rotas using "New rota"
- Verify table is not sortable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:54:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:54:51 +0000
Subject: [Koha-bugs] [Bug 21945] Clean up stock rotation template
In-Reply-To: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21945-70-Q5c6D7TWKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 19 23:54:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 22:54:55 +0000
Subject: [Koha-bugs] [Bug 21945] Clean up stock rotation template
In-Reply-To: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21945-70-VvS4Q5IoBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84220|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84235&action=edit
Bug 21945: Clean up stock rotation template

This patch makes some minor markup upgrades to the stock rotation
template: Replace some YUI markup with Bootstrap; Add some missing <tr>
tags; Remove invalid "type" attribute from <script> tag.

To test, apply the patch and go to Tools -> Stock rotation. Confirm that
the page looks correct and adjusts well at various browser widths. Test
with various views: New rota, edit rota, manage stages, manage items.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 00:05:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 23:05:06 +0000
Subject: [Koha-bugs] [Bug 11996] default active currencies for ru-RU and
 uk-UA are probably wrong
In-Reply-To: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11996-70-CEIP72ubC1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996

--- Comment #3 from David Nind <david at davidnind.com> ---
(In reply to Ethan from comment #1)

> Didn't know how to change the uk-UA default currency.

The active column set to 1 in the sql will make it the default currency.

For the uk-UA sample_currency.sql you don't need to do anything if you change
the 'GRN' entry to 'UAH' as there is a '1' already in the column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 00:07:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 23:07:07 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-YKoZEDGWn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 00:07:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 23:07:10 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-XRUuLFtaex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84227|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84236&action=edit
Bug 22102: Markup fixes for OPAC article request page

This patch makes a few improvements to the OPAC article request page:

- Improve the breadcrumbs menu by adding a link to the title
- Add a header with the record's title
- Wrap the "no article requests" message in the correct dialog div
- Remove obsolete CDATA marker

To test, apply the patch and log in to the OPAC

 - Peform a search which will return multiple results
 - Click "Request article" on a title for which article requests can be
   submitted.
   - Confirm that the breadcrumbs menu looks and works correctly.
 - Click "Request article" on a title for which article requsts are not
   allowed.
   - Confirm that the message is correctly styled.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 00:11:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 23:11:08 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-HKoPQ9Efg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 00:11:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Jan 2019 23:11:12 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-IxLwVbzX99@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84171|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84237&action=edit
Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries
description

Test plan:
1. Review patch and confirm that the sentence makes sense

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 01:13:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 00:13:24 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-WSPZeYmaAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |larry at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 01:15:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 00:15:41 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-pA3MFsK6eN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

--- Comment #23 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Magnus Enger from comment #22)

> Would it make sense to add export.pl until someone comes up with a proper
> solution? Or are there so few people downloading huge files that it is not
> worth it?

I think it's probably worth it -- it's a one-line change, and it's easy to back
out when we finally fix it. Nick, Kyle, Larry, care to weigh in?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 02:17:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 01:17:24 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-EKlONUzUvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #8 from Barton Chittenden <barton at bywatersolutions.com> ---
I would very much like to get this back-ported to 18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:31:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:31:10 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-MDBxvvT22l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84238&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:32:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:32:08 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-NvOKkUAL9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84238|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:33:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:33:34 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-rONT6WzXXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:33:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:33:38 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-rn1csFHhXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84146|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84239&action=edit
Bug 19818: Add id into tag html from moremember.tt

1) Go to the patron details for a patron
2) On the right of the screen, right click one of the labels below
   'Library use' etc, and Inspect Element
3) View <li> tags which should now each have a unique <id> tag for each

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:49:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:49:43 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-DXBINdenxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84214|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84240&action=edit
Bug 22134: Add account expiration information to patron details

This patch modifies the patron detail template in the staff client so
that when a patron's registration is expired a message shows at the top
of the page along with the same "Renew" and "Edit" links which appear on
the checkout page. Links are also shown next the the expiration date in
the body of the page.

This patch also corrects the capitalization of the "Edit Details" link
on circulation.tt.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.
 - On the patron's checkout page the "Edit details" link in the
   expiration message should have correct capitalization.

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:49:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:49:46 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-XnaAbUwXpm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84215|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84241&action=edit
Bug 22134: (follow-up) Simplify check for expired patron

This patch move the check for "is_expired" to the template and removes
unnecessary code from the script.

The page now correctly handles messages for patrons who are about to
expire, as defined in the NotifyBorrowerDeparture preference.

To test, apply the patch and locate a patron record which is expired.

 - On the patron detail page (members/moremember.pl) you should see a
   message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.

Select a patron who will expire within the period defined in
NotifyBorrowerDeparture.

 - On the patron detail page you should see a message at the top of the page.
 - In the body of the page, next to the expiration date information, you
   should see similar message and links.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:49:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:49:39 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-APJs33g5E8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:55:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:55:12 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-6I0gOc3kag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:55:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:55:15 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-lrz0zV8jRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84217|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84242&action=edit
Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes.

Fixed ExtendedPatronAttributes typo.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 12:59:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 11:59:05 +0000
Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page
In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22032-70-2NMuYyIM38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |BLOCKED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Moving to BLOCKED because of the dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:02:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:02:05 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-2KsZqwLm7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83886|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84243&action=edit
Bug 22124: Update cataloguing plugin system to not generate type parameter in
script tag

Test plan:
1) Apply the patch
2) Have defined some cataloguing plugin which generates javascript - for
example dateaccessioned.pl
3) Go to cataloguing/adding item and show source
-> there should be no type parameter in script tag in code added by
cataloguing pulgin
4) prove t/db_dependent/FrameworkPlugin.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:02:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:02:02 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-yuLdRAd5Oc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:26:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:26:15 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-tzC9kAhiHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:26:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:26:24 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-G8jYXaKkKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84201|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84245&action=edit
Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema

This patch makes the code using Koha::Biblio::Metadata->marcflavour use
->schema instead for all interactions.

To test:
- Update the DB structure:
  $ updatedatabase
- Update the schema files:
  $ dbic
- Notice all the places in which biblio_metadata is used
  $ cd kohaclone
  $ git grep biblio_metadata
=> SUCCESS: They all use `schema` instead of marcflavour
- Notice all the places that use Koha::Biblio::Metadata:
  $ git grep Koha::Biblio::Metadata
=> SUCCESS: They all use the schema attribute when they used to use
marcflavour
- Run all the modified tests and scripts
=> SUCCESS: We are all good
- Sign off :-D

Note: while this seems like a minor change, the places in which plain
SQL is used really require understanding the queries and how they are
used, because some query results might be passed to some other method
that in turn uses the marcflavour attribute. I of course took that into
account but errare humanum est :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:26:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:26:20 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-2W8zzXnR4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84200|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84244&action=edit
Bug 22155: DB update

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:40:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:40:09 +0000
Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not
 installable on 32bit systems
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-v8RaQlaIBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

giacomo at cregut.it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
                 CC|                            |giacomo at cregut.it
             Status|RESOLVED                    |REOPENED

--- Comment #14 from giacomo at cregut.it ---
Hello,
I am fairly new to Koha and I'm currently trying to install Koha on a 32-bit
Debian Stretch machine.
I have run into the same problem as described above, even though here it says
it was fixed.
I'm trying to install the current stable version of Koha(18.11) and my
sources.list file contains this:
  deb http://debian.koha-community.org/koha dists/stable/main/binary-i386/

Whenever I try to run 
  $ sudo apt-get install koha-common
this is the output:
  Reading package lists... Done
  Building dependency tree
  Reading state information... Done
  Some packages could not be installed. This may mean that you have
  requested an impossible situation or if you are using the unstable
  distribution that some required packages have not yet been created
  or been moved out of Incoming.
  The following information may help to resolve the situation:

  The following packages have unmet dependencies:
   koha-common : Depends: libnet-oauth2-authorizationserver-perl but it is not
going to be installed
  E: Unable to correct problems, you have held broken packages.
Am I missing something?
Regards,
Giacomo

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:41:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:41:34 +0000
Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form
In-Reply-To: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21312-70-FiqMjo2cUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84218|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84246&action=edit
Bug 21312: Show lockout on Patrons form

Just what the title says :)
Specifically: moremember.pl

Test plan:
Check if you see the locked message on the patron form for an account
that has been locked. (Either login_attempts<0 or >FailedLoginAttempts)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:41:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:41:38 +0000
Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form
In-Reply-To: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21312-70-VUSi8JMx67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84247&action=edit
Bug 21312: (QA follow-up) Ease translation

I've changed the language a bit from "account locked out" to
"account locked" and split it up to ease translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 13:45:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 12:45:49 +0000
Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form
In-Reply-To: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21312-70-EPzNYBABhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is a bit problematic as it depends on bug 21336 which introduces the
administrative lockout that is currently in Faild QA.

The other is my follow-up suggesting some changes to the template and removing
the "out". I am hesitating to move to BLOCKED because I think having the
message on the patron account would be good to have now.

Marcel or someone, would you mind taking a look at my follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:00:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:00:28 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-icIJoUJCxH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:00:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:00:33 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-uTciXBWs9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84213|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84248&action=edit
Bug 21918: Update buttons on fines to match newer buttons

This patch makes a number of changes to the "Pay fines" template, the
goal of which is to make the interface look better in general. Changes
include:

 - Styling the "Pay" and "Write off" buttons as Bootstrap buttons.
 - Adding DataTables sorting, searching, and filtering.
 - Adding a column showing the fine date.
 - Hide the "Add note" input, add a link to show it.
 - Add some missing "preventDefault" methods from events.
 - Add "Writeoff selected" to the buttons which are disabled when there
   is no checkbox selection.
 - The <tfoot> tag is now expected by the HTML validator to be after
   <tbody>, so this section has been moved to suppress validator errors.

To test, apply the patch and locate a patron who has multiple
outstanding fines.

 - Go to Fines -> Pay fines
 - Confirm that the table of fines is shown as a DataTable, with sorting
   on columns which have data.
 - Test columns settings in Administration -> Columns settings.
 - Confirm that fine dates are shown, and that sorting by this column
   works correctly.
 - Click an "Add note" link to show a note input field. Focus should be
   in the newly-displayed input.
   - Confirm that notes are still saved correctly when paying or writing
     off single or multiple fines.
   - Confirm that when the "add note" input is hidden, its contents are
     erased.
 - Uncheck all checkboxes by clicking the "Clear all" link at the top.
   The "Pay selected" and "Write off selected" buttons should become
   disabled.
   - Checking any checkbox should re-enable those buttons.
 - Test that the relocated "Apply" button (for outstanding credits)
   still works as expected.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:01:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:01:52 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-Pu6RXhBlkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Testing this I got confused about the payment note feature. I am wondering, do
we need it to be on the payments table? It seems a little confusing as you seem
to only be able to save it actually paying a fine. Wouldn't it be enough if the
field appeared editable on the actual form? Maybe I am missing something!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:07:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:07:14 +0000
Subject: [Koha-bugs] [Bug 15110] Improve decreaseHighHolds system preference
	description
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-BE1bqfOn8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|decreaseHighHolds unclear   |Improve decreaseHighHolds
                   |                            |system preference
                   |                            |description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:09:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:09:21 +0000
Subject: [Koha-bugs] [Bug 15110] Improve decreaseHighHolds system preference
	description
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-pmQbePuBNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:09:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:09:25 +0000
Subject: [Koha-bugs] [Bug 15110] Improve decreaseHighHolds system preference
	description
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-Goo3ApylDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84249&action=edit
Bug 15110: Improve decreaseHighHolds system preference description

To test:
1) Apply patch
2) Go to Koha admin
3) Search in system prefernces for 'high demand'
4) Verify that the system prefernce 'decreaseLoanHighHolds' is in the
results of the search

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:19:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:19:39 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-DgxscmSIWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this patch is ok, but should be pushed without the atomicupdate. 

The problem is that we kind of have a rule to not mess with people's existing
framework setups. As such we don't add new fields there usually for the MARC
updates etc. The other major problem is that people with translated frameworks
would find their translations overwritten by the English term.

I am adding a follow-up removing the atomic-update, to be on the safe side, but
it might be easier to do it on RM side :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:21:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:21:45 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-IVQhUXo2Aq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:21:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:21:49 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-i8c59fnrxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84222|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84250&action=edit
Bug 20491: Updating the MARC subfield desciption of 952q

Test plan:
1) Go to admin, then to MARC frameworks, then to default
frameworks structure, then subfield stucture for 952
2) Verify that 'q'
is described as 'checked out'
3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
4) Verify
that 'q' is also descirbed as 'Checked out' in
5) Apply patch and update
your database
6) Verify that the description of 'q' has changed to 'Date
due'
7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
6) Verify that it has changed to 'Date due'

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:21:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:21:53 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-1BpT3BTbYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84251&action=edit
Bug 20491: (QA follow-up) Remove atomic update

We should not update existing installations, especially
since this would not work for translated frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:27:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:27:15 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-qnGMRomHhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:27:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:27:19 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-mVWokP63ow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84252&action=edit
Bug 11922: Added SHOW_BCODE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:29:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:29:08 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-76kyyNvacv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84157|0                           |1
        is obsolete|                            |
  Attachment #84252|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84253&action=edit
Bug 11922: Add SHOW_BCODE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:31:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:31:02 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-aMhFmiTjoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The new files haven't been translated to Norwegian, but I think this is still
good as it bringes the nb-NO installer more in line with the others and allows
to install the same data. Translation can be fixed later (hope Magnus agrees :)
)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:42:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:42:51 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-qgi8hF3aJb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:42:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:42:56 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-XUYGsLD8Vi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83823|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84254&action=edit
Bug 10562: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl

This patch takes the suggestions in Bug 10562 and implements those
changes in MARC21slim2OPACResults.xsl. This patch also makes the
following changes:

 - De-duplicate famfamfam icons: Remove the /silk subdirectory and move
   non-duplicates to famfamfam/; Correct paths to these images in
   templates and CSS
 - Improve the granularity of some material type icon choices: Show
   "Film," "Picture," or "Object" instead of "Visual material."
 - Remove unnecessary title attributes from material type images
 - Implement the kind of changes made in Bug 18235, "Add classes to
   material type icons on result lists and detail pages"

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:43:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:43:19 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-PKocZq0Lvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I really like the text change from "book" to "text".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:46:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:46:03 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-uLo1JdVfgr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:46:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:46:07 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-cyLIXQ31PS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84178|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84255&action=edit
Bug 19994: Used Modern::Perl in Authorities perl scripts

Test plan:
1. Review code of the following files and confirm that 'use Modern::Perl;' is
used in place of
'use strict; use warnings;'

auth_finder.pl
authorities-home.pl
authorities.pl
blinddetail-biblio-search.pl
detail-biblio-search.pl
detail.pl
export.pl
merge.pl
merge_ajax.pl

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:48:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:48:57 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-NqSGn0OVum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 15:49:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 14:49:01 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-sn9wxOeVJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84136|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84256&action=edit
Bug 19920: Removed unnecessary code from C4/Members.pm

A seperate bug (Bug 16853) removed the subroutine used in this file. I removed
the code as it had become unnecessary.

Test plan:
1. Confirm that &changepassword can't be found in C4/Members.pm

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 16:33:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 15:33:22 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_22176=5D_New=3A_analg=C3=A9sicos_aut?=
 =?utf-8?q?=C3=A9nticos_y_medicamentos_para_la_ansiedad_disponibles?=
Message-ID: <bug-22176-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22176

            Bug ID: 22176
           Summary: analg?sicos aut?nticos y medicamentos para la ansiedad
                    disponibles
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lorieta202 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Created attachment 84257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84257&action=edit
the main source

Nuestro equipo de profesionales dedicados se esfuerza por hacer que su
experiencia en l?nea sea lo m?s r?pida y placentera posible. Nos enorgullecemos
de nuestra capacidad para proporcionar estos servicios a un costo
significativamente m?s bajo de lo que uno pagar?a normalmente. Todo ello
evitando cargos ocultos o tasas. Nunca perdemos de vista a nuestros pacientes
como personas, en oposici?n a los n?meros. Nuestro equipo nunca dejar? de
buscar la mejor oferta de medicamentos que podamos poner a su disposici?n.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 16:34:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 15:34:16 +0000
Subject: [Koha-bugs] [Bug 22176] SPAM
In-Reply-To: <bug-22176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22176-70-igjuRqhqko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22176

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|analg?sicos aut?nticos y    |SPAM
                   |medicamentos para la        |
                   |ansiedad disponibles        |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 20 20:56:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 19:56:04 +0000
Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable
In-Reply-To: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22175-70-OhMAknvJch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 00:42:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Jan 2019 23:42:57 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-xoDfGDfbWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 02:49:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 01:49:14 +0000
Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not
 installable on 32bit systems
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-4p9kMqwStY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
I am curious why anyone would be running 32-bit Linux in this day and age.

Giacomo, can you explain why you're using 32-bit Linux and not 64-bit Linux? 

The only modern use case I can think of is using a Raspberry Pi with a 32-bit
Raspbian OS. 

Maybe using really old hardware? But it would have to be very old at this point
not to support a 64-bit OS...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 02:49:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 01:49:45 +0000
Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page
In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22032-70-GGi6aSRfIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 02:50:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 01:50:26 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-q1CrklJQIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 05:44:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 04:44:53 +0000
Subject: [Koha-bugs] [Bug 22177] New: Update years for
	meetings.koha-community.org
Message-ID: <bug-22177-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

            Bug ID: 22177
           Summary: Update years for meetings.koha-community.org
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
               URL: http://meetings.koha-community.org
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: david at davidnind.com
  Target Milestone: ---

Add 2018 and 2019 years to meetings.koha-community.org site front page and
header.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 06:11:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 05:11:17 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
	deleted
In-Reply-To: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17355-70-PwxbDfsO91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #13)
> Can we revive this?

I think that sounds like a good idea. I just had someone ask me to delete a
category for them that they added by accident. It seemed unfortunate that they
couldn't do it themself. 

I was thinking "user_defined" might be a better column for the database than
"is_internal". Anything without that flag would be considered to be an
internal/system value. 

I think this would future-proof us against new internal/system authorised
values categories. For instance, in the existing patches, there are lots of
categories missing which show up in the SQL packaged with the Koha installer. I
think we only really want to worry about deleting categories that have been
added by users, so we could just set that flag when users add via the Web UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 08:06:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 07:06:00 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-tdC6YRPLqD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 08:06:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 07:06:28 +0000
Subject: [Koha-bugs] [Bug 21997] SIP patron information requests can lock
 patron out of account
In-Reply-To: <bug-21997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21997-70-pCtHzGJ0zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21997

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 08:06:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 07:06:47 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-pwIP8qgQag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 09:04:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 08:04:45 +0000
Subject: [Koha-bugs] [Bug 22178] New: Add start and end date for repeated
	holidays
Message-ID: <bug-22178-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22178

            Bug ID: 22178
           Summary: Add start and end date for repeated holidays
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

When weekly or other repeating holidays are changed it will always effect dates
in the future, but also in the past. For fine calculation and other reasons
this can cause problems. It would be nice if it would possible to start and and
repeated holidays at specific dates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 09:37:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 08:37:46 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-oAaVlnaOEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

--- Comment #7 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Katrin Fischer from comment #6)
> The new files haven't been translated to Norwegian, but I think this is
> still good as it bringes the nb-NO installer more in line with the others
> and allows to install the same data. Translation can be fixed later (hope
> Magnus agrees :) )

I totally agree!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:12:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:12:54 +0000
Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports
In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21560-70-r6vWtOTipB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:13:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:13:01 +0000
Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports
In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21560-70-ktecTNwJ3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82951|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 84259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84259&action=edit
Bug 21560: Optimize ODS export of gather_print_notices.pl

Like previous patch, the call on OpenOffice-OODoc lib can be optimized.
Based on
https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table

Test plan inspired from Bug 11679.

Test plan:
- define your ODUE notice for the print template as:
cardnumber:patron:email:item
<<borrowers.cardnumber>>:<<borrowers.firstname>>
<<borrowers.surname>>:<<borrowers.email>>:<item><<items.barcode>></item>
- define overdues rules for a patron category
- check-out 2 items using a due date in order to generate the overdue notices
- check-in these 2 items
- launch the script /misc/cronjobs/overdue_notices.pl
- the 'message_queue' table should now contain 2 new entries
- launch the gather_print_notices cronjob :
  perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods
--letter_code=OVERDUE -d=:
- A ods file should be generated in your /tmp/test directory
- Compare times with and without patch

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:12:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:12:58 +0000
Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports
In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21560-70-aDZVFnMYKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80683|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 84258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84258&action=edit
Bug 21560: report ODS export optimization

SQL reports can be exported with CSV, TSV of ODS format.
When report has thousands of rows, using ODS format is around 10 times longer
than other formats.
It also loads CPU and RAM a lot.

The longest call is expandTable().
I found that the call on OpenOffice-OODoc lib can be optimized.
Based on
https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table

Test plan :
1) Don't apply patch yet
2) Create a new SQL report : Home > Reports > Create from SQL
3) Enter a SQL that will return thousands of results
4) Run report
5) Click Download > Semicolon separated text (.csv), look execution time
6) Click Download > Open Document Spreadsheet, look execution time
7) Apply patch
8) Redo 5) and 6) and compare times, CSV export should be the same but ODS
export should be better

My tests shows 1,5 seconds for CSV export.
And for ODS export : 18 seconds without patch and 8 seconds with patch.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:17:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:17:41 +0000
Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports
In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21560-70-WGt3uYM8p5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560

--- Comment #11 from David Nind <david at davidnind.com> ---
An updated test plan for the second patch (Optimize ODS export of
gather_print_notices.pl)

Test plan
---------

Pre-requisites: To test the gather_print_notices.pl patch you need to setup
some overdue items to generate overdue notices. The basic steps to do this are
included in the test plan.

1) Define your ODUE notice for the print template (Tools > Patrons and
circulation > Notices & slips > edit the ODUE notice > expand the Print
section):
   cardnumber:patron:email:item
   <<borrowers.cardnumber>>:<<borrowers.firstname>>
<<borrowers.surname>>:<<borrowers.email>>:<item><<items.barcode>></item>
2) Define the overdue rules for a patron category, for example:
   . Check that 'Overdue notice required' is set to 'Yes' for the patron
category (Administration > Patrons and circulation > Patron categories)
   . Check that the 'Loan period' for the 'Standard rules all libraries' is set
to 5 days (Administration > Patrons and circulation > Circulation and fine
rules)
   . Check that a trigger is set for the patron category, for example: Delay =
1, Letter = Overdue Notice, Print = ticked (Tools > Patrons and circulation >
Overview notice/status triggers)
3) Check out 2 items for a patron in the same patron category defined in step 2
- set the due date so that it will generate the overdue notices. (Circulation >
Check out > enter patron details (card number or partial name) > enter a
barcode for an item > specifiy a due date by expanding 'Checkout settings' and
entering a date at least 5 days before the current date > Check out > confirm
check out.)
4) Run the overdue notices cronjob from the command line: perl
misc/cronjobs/overdue_notices.pl
5) Check that the 'message_queue' table in the database contains 2 new entries
(from the command line 'koha-mysql kohadev' and then enter the query 'select *
from message_queue;')
6) Run the gather_print_notices cronjob from the command line and record how
long it takes to run (use  the time command* if available to record this): time
perl misc/cronjobs/gather_print_notices.pl /tmp --ods --letter_code=ODUE -d=:
7) An ods file should be generated in the /tmp directory
8) Apply the patch
9) Run step 6 again to get the time after the patch is applied

* If using the bash shell and the time package is installed you can record how
long a script takes to run.

Result before the patch was applied:
real    0m1.702s
user    0m1.336s
sys     0m0.172s

Result after the patch was applied:
real    0m1.541s
user    0m1.404s
sys     0m0.132s

Note: got several different times, but all were quicker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:44:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:44:53 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-KKsaWJ7OMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83892|0                           |1
        is obsolete|                            |
  Attachment #83893|0                           |1
        is obsolete|                            |
  Attachment #83894|0                           |1
        is obsolete|                            |
  Attachment #83895|0                           |1
        is obsolete|                            |
  Attachment #83896|0                           |1
        is obsolete|                            |
  Attachment #83897|0                           |1
        is obsolete|                            |
  Attachment #83898|0                           |1
        is obsolete|                            |
  Attachment #83899|0                           |1
        is obsolete|                            |
  Attachment #83900|0                           |1
        is obsolete|                            |
  Attachment #83901|0                           |1
        is obsolete|                            |
  Attachment #83902|0                           |1
        is obsolete|                            |
  Attachment #83903|0                           |1
        is obsolete|                            |
  Attachment #83904|0                           |1
        is obsolete|                            |
  Attachment #83905|0                           |1
        is obsolete|                            |
  Attachment #83906|0                           |1
        is obsolete|                            |
  Attachment #83907|0                           |1
        is obsolete|                            |
  Attachment #83908|0                           |1
        is obsolete|                            |
  Attachment #83909|0                           |1
        is obsolete|                            |
  Attachment #83910|0                           |1
        is obsolete|                            |
  Attachment #83911|0                           |1
        is obsolete|                            |
  Attachment #83912|0                           |1
        is obsolete|                            |
  Attachment #84145|0                           |1
        is obsolete|                            |
  Attachment #84210|0                           |1
        is obsolete|                            |

--- Comment #428 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84260&action=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:45:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:45:15 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-utrNhpmwd5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #429 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84261&action=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:45:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:45:42 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-xFq6TD0nWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #430 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84262&action=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by
number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
    - no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the
test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again
on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the
action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:46:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:46:13 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-zeyaYjpt4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #431 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84263&action=edit
Bug 17047: add a dedicated page for Mana setup

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:46:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:46:51 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-xGffAOpb6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #432 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84264&action=edit
Bug 17047: [DO NOT PUSH] provide staff-global.css

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:47:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:47:16 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-BroBipE1Fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #433 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84265&action=edit
Bug 17047: [DO NOT PUSH] provides schema files

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 10:53:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 09:53:24 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-sXFxKpQ3xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #434 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Nick Clemens from comment #423)
> (In reply to Nick Clemens from comment #422)
> > Created attachment 84210 [details] [review] [review]
> > Bug 17047: (follow-up) Improve mana messages, enable by default, show
> > messages if not configured
> 
> Hi Alex,
> 
> I added a followup to enable by default, show a helpful tip if not
> configured, and updated some language - if this one is okay can you remove
> the third option from the syspref, squash the followups and then I think we
> can push this one.
> 
> -Nick

Hi Nick,

Removed the third option, restore the IGNORE in SQL statement to make it
idempotent and did a big squash.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 11:08:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 10:08:14 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-3p1B7MjtE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #435 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Katrin Fischer from comment #427)
> Hi Paul, thx for replying!
> 
> I've applied the patches and taken a look at the configuration page. What's
> the difference between the 'no' and 'no, let me think about it'? Where is it
> explained? I think as the system preference reads "Enable request to Mana
> Webservice" this is not clear to the user that there is no communication
> without the token. I would feel better if we left to "no". We can still
> advertise Mana of course - I am not against the service at all, but I feel
> we should be consistent and clear about protecting user's privacy.
> 
> Noticing while testing: commmit messages are a bit messy and not following
> guidelines (old patch, I know, but easy to fix). I even volunteer doing it :)

Hello Katrin,

It was a way to promote the feature (i say "it was" since we decided to remove
this third option).
"No, let me think about it" was the default choice, and, in this case, the user
saw a message telling him he has not decided yet to use or not Mana.

You can communicate with Mana if you did not set a token. You can retrieve
subscriptions and reports but not share them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 12:30:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 11:30:21 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-BCUHtuLYPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #436 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Alex Arnaud from comment #435)
 guidelines (old patch, I know, but easy to fix). I even volunteer doing it :)
> 
> Hello Katrin,
> 
> It was a way to promote the feature (i say "it was" since we decided to
> remove this third option).
> "No, let me think about it" was the default choice, and, in this case, the
> user saw a message telling him he has not decided yet to use or not Mana.
> 
> You can communicate with Mana if you did not set a token. You can retrieve
> subscriptions and reports but not share them.

Thx Alex for clearing this up! In this case I really think we should default to
no, like we do for other external services like Covers, Hea etc.

I see the file attached. What could be a good way to provide that information
to the users interested in Mana? 

We could update the wiki page:
https://wiki.koha-community.org/wiki/Mana_central_database. Adding the
information to the manual might also be good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 13:43:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 12:43:11 +0000
Subject: [Koha-bugs] [Bug 12967] Allow to choose currency for calculating
	shipping cost
In-Reply-To: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12967-70-VkjPh4YPfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12967

Paul Thornton <paul.thornton at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.thornton at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 13:45:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 12:45:01 +0000
Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in
	acquisitions
In-Reply-To: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18412-70-pncBwrF1gJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412

Paul Thornton <paul.thornton at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.thornton at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 13:46:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 12:46:06 +0000
Subject: [Koha-bugs] [Bug 18637] Handle Free Text vendor notes on Edifact
	Quotes
In-Reply-To: <bug-18637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18637-70-LkUFwJ5yzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18637

Paul Thornton <paul.thornton at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.thornton at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 13:52:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 12:52:28 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-RPMnrMYDfr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #437 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Katrin Fischer from comment #436)

> Thx Alex for clearing this up! In this case I really think we should default
> to no, like we do for other external services like Covers, Hea etc.
mana defaulted to yes/no token is similar to "I haven't explicitly decided". If
we set it to "no" by default, then the library can miss the feature. I want to
avoid the hea case where the default set to "no" result in many libraries
missing the feature, and not saying "I don't want to share".
the proposed behavior is harmless from privacy as well as from ergonomics point
of view.
So I really think we must not default to "no" and the proposed change is fine.

Hea is a good example of something we could have promoted better: how many
libraries are not sharing because they don't know that hea exist vs not sharing
because they don't want to share ?
I want to avoid this behavior.

> I see the file attached. What could be a good way to provide that
> information to the users interested in Mana? 
> 
> We could update the wiki page:
> https://wiki.koha-community.org/wiki/Mana_central_database. Adding the
> information to the manual might also be good.
I agree with promoting & documenting.
But that's not enough, many libraries don't read the doc, or don't investigate.
Add the case where an IT makes upgrade and the library don't even know...
So making mana visible in the staff interface, to be sure the librarian chose,
and not only "don't know" is the way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:14:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:14:12 +0000
Subject: [Koha-bugs] [Bug 22166] Add cron to automatically finish transfers
 based on some configuration
In-Reply-To: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22166-70-m56ODUzLUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22166

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Katrin Fischer from comment #1)
> Hi Josef, can you explain the use case a bit more?

Of course I can, we have two use cases:
1) We often use Koha for whole regions - where one library is regional center,
and makes rotating collections which sends to small libraries in the regional
library system - the collections have usually about 60 items or more and would
be handy not to have to all the items check in

2) Some libraries have set a stock as another branch, to be able to know if the
item is on department or in stock (it could be even external), some of these
libraries don't have a computer in the stock and have good workflow in which
they are pretty sure, that the book which started transfer to this branch/stock
will finish the move here in short time. Now they have to change the library,
check the items in, and change the library back to usual department, which
leads sometimes to mistakes, as they could forget to change the library back..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:25:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:25:08 +0000
Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected
	structure
In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22173-70-v5NdlFwFNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:27:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:27:35 +0000
Subject: [Koha-bugs] [Bug 22167] Allow itemnumber column to be labelled
 differently when using batch item edit feature
In-Reply-To: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22167-70-Y3aoB3iUME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:28:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:28:52 +0000
Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on
	"checkbox" by default
In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22156-70-H0gtVL5IO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:29:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:29:13 +0000
Subject: [Koha-bugs] [Bug 22158] Add keyboard shortcuts in advanced editor
 to move current line up or down within record
In-Reply-To: <bug-22158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22158-70-huvB2R7yqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22158

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:42:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:42:43 +0000
Subject: [Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't
 look for the right codes
In-Reply-To: <bug-22154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22154-70-lwllOrT28b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:43:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:43:04 +0000
Subject: [Koha-bugs] [Bug 22153] Automatic item modifications by age:
	Boolean options
In-Reply-To: <bug-22153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22153-70-oyD6FFDyUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22153

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:44:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:44:10 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-ivxwLLPup8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:45:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:45:39 +0000
Subject: [Koha-bugs] [Bug 22152] Hide printing the tools navigation when
	printing reports
In-Reply-To: <bug-22152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22152-70-sMy5Zi48Ax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:47:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:47:18 +0000
Subject: [Koha-bugs] [Bug 22137] Koha should warn when maxRecordsForFacets
 is less than numSearchResults or OPACnumSearchResults
In-Reply-To: <bug-22137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22137-70-jcy0gel0md@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22137

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 14:53:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 13:53:45 +0000
Subject: [Koha-bugs] [Bug 22131] overdue_notice.pl and
 gather_print_notices.pl should honor letter.is_html
In-Reply-To: <bug-22131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22131-70-Tm4YwPhE7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22131

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 15:04:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 14:04:12 +0000
Subject: [Koha-bugs] [Bug 21806] Patron card creator - batch to export
	-unicode support
In-Reply-To: <bug-21806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21806-70-ZpSoDD9BKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21806

--- Comment #4 from cfhong2000 at gmail.com ---
I found a workaround from Koha Taiwan user group.
Here is the link to a google doc that provides the solution.

https://docs.google.com/viewer?a=v&pid=forums&srcid=MDA0NDYxNTM3NzUwNTcyNzI5NjYBMDkxODU4MDQ3OTk1NjE2NzgxMjEBLWNMdzJoYjRCd0FKATAuMQEBdjI&authuser=0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 15:15:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 14:15:43 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-nP3CBvkfXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #438 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hea is actually sending data. While it's not personal data, I still think
having Hea turned off by default was the only way to go. We should not create
an application that is calling home without asking. 

I actually liked your approach with the third option - turn off, but show a
message to give them a note. Maybe this idea could be explored further?

But ultimately it would be nice to get more opinions on this, because we won't
agree :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 15:25:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 14:25:12 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-oDmAI7iVo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #46 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84266&action=edit
Bug 20750: (follow-up) Remove Time::Piece dep

The sorting of log entries was being achieved using Time::Piece::epoch
to derive the epoch date from the log timestamps. Time::Piece is not
used anywhere else, therefore it was desirable to find an alternative
method that uses a library that is already in use in Koha.

It would have been possible to use Koha::DateUtils::dt_from_string to do
this, however, this function instantiates a DateTime object to do the
conversion. DateTime objects are notoriously slow at instantiating, so
for this use case where we're potentially converting a lot, it didn't
seem ideal. Besides, dt_from_string is built to convert from a variety
of formats, but since our timestamps are in a defined format, this seems
overkill.

In the end, we're using Time::Local::timelocal to obtain the epoch time.
Time::Local is in use elsewhere and doesn't depend on DateTime.

Also updated the unit test of get_request_logs, it was using the wrong
date format anyway!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 15:25:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 14:25:46 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-aHcr2yYOJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #439 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Katrin Fischer from comment #438)
> Hea is actually sending data. While it's not personal data, I still think
> having Hea turned off by default was the only way to go. We should not
> create an application that is calling home without asking. 
> 
> I actually liked your approach with the third option - turn off, but show a
> message to give them a note. Maybe this idea could be explored further?
> 
> But ultimately it would be nice to get more opinions on this, because we
> won't agree :)

Hey, but we agree !!!
I fully agree that we don't want to activate HEA by default !
The mistake we made, was to set it OFF by default. The right approach would
have been to have "undecided yet" by default. And show the "please, look at
HEA, there's some important decision we want YOU do take". So the library can
be warned they have a decision to take, a choice to make.
I'm sure that it would have been resulting in more libraries sharing.

That's what I wanted to avoid with MANA, and that's what's Kyle patch improve:
our initial dev was a syspref with 3 status (explicit yes, explicit no, no
explicit decision), and kyle found a way to have those 3 options with a binary
syspref and the token
* syspref=yes / token empty => no explicit decision
* syspref=yes / token filled => explicit decision
* syspref=no => explicit decision

do you agree that we agree ? :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 15:39:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 14:39:57 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-SAD9mbHrxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #440 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
"No undecided" sounds fine to me indeed :)

But I wonder if this is really the behaviur of the current patches? I think it
said "Enabled" when I test installed the other day. But I won't have time for
another test the next days :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:01:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:01:53 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-XW1jjZbYit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #19 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 84219
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84219
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

Review of attachment 84219:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7960&attachment=84219)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
@@ +121,4 @@
>          <tr>
>      [% FOREACH itemtypeloo IN advsearchloo.code_loop %]
>          <td><input type="checkbox" id="[% itemtypeloo.ccl FILTER remove(',') | html %]-[% itemtypeloo.number | html %]" name="limit" value="mc-[% itemtypeloo.ccl | html %]:[% itemtypeloo.code | html %]"/><label for="[% itemtypeloo.ccl FILTER remove(',') | html %]-[% itemtypeloo.number | html %]">[% UNLESS ( noItemTypeImages ) %][% IF ( itemtypeloo.imageurl ) %]<img src="[% itemtypeloo.imageurl | html %]" alt="[% itemtypeloo.description | html %]" />[% END %]&nbsp;[% END %]
> +        <span class="itypetext">[% itemtypeloo.description | html %]<span></label></td>

Bad ending tag - missing "/"

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ +534,4 @@
>                                          [% IF ( onloan_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&amp;q=%22[% onloan_items_loo.itemcallnumber |uri %]%22">[% onloan_items_loo.itemcallnumber | html %]</a>][% END %]
>                                          ([% onloan_items_loo.count | html %][% IF ( onloan_items_loo.longoverdue ) %], [% onloan_items_loo.longoverdue | html %] long overdue[% END %]) date due: [% onloan_items_loo.due_date | $KohaDates %]
>                                          [% IF item_level_itypes && onloan_items_loo.description %]
> +<<<<<<< HEAD

Merge markers

@@ +566,4 @@
>                                          [% IF ( other_items_loo.notforloan ) %][% other_items_loo.notforloan | html %][% END %]
>                                          ([% other_items_loo.count | html %])
>                                          [% IF item_level_itypes && other_items_loo.description %]
> +<<<<<<< HEAD

Merge markers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:02:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:02:14 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
	types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-3Uhff16wUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |josef.moravec at gmail.com
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:43:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:43:25 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-0roDBK23qi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:43:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:43:44 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-UUCedMpriD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:43:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:43:29 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-5HsJL5F0ea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84231|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84267&action=edit
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>
Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:47:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:47:25 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-YecFhxzjUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:47:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:47:30 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-Wd9ztYVbDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84229|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84268&action=edit
Bug 22113: Add price formatting on item lost report

The item lost report displays the price and replacement
price for lost items. With the patch they will display
according to the CurrencyFormat system preference.

To test:
- Mark 1 or more items lost
- Make sure that replacement cost and purchase price are set
- Go to Reports > Items lost
- Search for your lost items
- Verify price and replacement price display
- Apply patch and toggle CurrencyFormat to different settings
- Refresh lost items report
- Verify prices are always displayed according to syspref setting

Signed-off-by: Olivia Lu <olivialokm at gmail.com>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:47:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:47:39 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-OdIfZ0WU67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:53:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:53:53 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-5mczGjwSrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84228|0                           |1
        is obsolete|                            |

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84269&action=edit
Bug 22111: Format amount shown on place holds when maxoutstanding is reached
(staff)

Displays amount outstanding correctly when holds are blocked
by maxoutstanding.

To test:
- Check maxoutstanding system preference value
- Add a fine to a patron account exceeding maxoutstanding
- Try to place a hold for this patron from staff
- Verify this message is shown:

     Patron has outstanding fines: 6.00

- Toggle CurrencyFormat system preference and verify display
  changes according to setting

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mikael Olangcay Brisebois
<mikael.olangcay-brisebois at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:53:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:53:49 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-qCXMtU9izS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 16:54:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 15:54:20 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-vmSOD7IV8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 17:07:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 16:07:05 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-8TrOYjmO6j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 17:07:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 16:07:09 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-LvFynllYwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84224|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84270&action=edit
Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds

Patch makes use fo patron-string.inc for displaying the patron information
on the waiting holds report.

It also adds spans with classes for phone and email.

To Test:
1 - View the holds awaiting pickup report
2 - Note there is no cardnumber for the patron
3 - Apply patch
4 - Cardnumber shows now
5 - Verify the same works for 'Holds over' tab

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 17:08:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 16:08:46 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-tWQjW8h1VQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 17:38:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 16:38:58 +0000
Subject: [Koha-bugs] [Bug 21264] Data inconsistencies - "Item type" and
 "item type for older issues" in subscriptions
In-Reply-To: <bug-21264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21264-70-yKvudbSXdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21264

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
This issue is one of the causes of having invalid itype on items.
So it would help having directly the root cause.

We use a check for that:
https://git.biblibre.com/biblibre/tools/src/commit/da516fdcd8a367047e1a5e5bdff9f9449f45b6eb/koha/db_check_itype.sh#L34

The important par is this one:

if [[ "$itype_on_item" ]] &&                 # the syspref
   [[ "$makePreviousSerialAvailable" ]] &&   # another syspref
   [[ "$invalid_itemtypes_exists" ||         # subscription.itemtype 
      "$invalid_previousitemtypes_exists" ]] # subscription.previousitemtype

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 18:00:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 17:00:24 +0000
Subject: [Koha-bugs] [Bug 21264] Data inconsistencies - "Item type" and
 "item type for older issues" in subscriptions
In-Reply-To: <bug-21264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21264-70-C4neXWQy6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21264

--- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Maybe checking for subscription.itemtype isn't need. I haven't tested if the
MARC frameworks usually doesn't let invalid values slip by.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 20:34:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 19:34:55 +0000
Subject: [Koha-bugs] [Bug 22179] New: Hide columns of all the subscriptions
 of a record with columns settings (id=subscriptionst) for the OPAC
Message-ID: <bug-22179-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22179

            Bug ID: 22179
           Summary: Hide columns of all the subscriptions of a record with
                    columns settings (id=subscriptionst) for the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

Hi, 

When you have multiple subscriptions from different sites for a bibliographic
record, if you decide to hide some columns from the OPAC using Columns settings
in the Koha's administration(id=subscriptionst), the columns will not be hidden
for all the subscriptions of the record.It will be nice that when we hide a
column it is hidden for all the subscriptions of the different sites. 

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 21:04:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 20:04:42 +0000
Subject: [Koha-bugs] [Bug 22180] New: SERIAL_ALERT email does not send if
 the status is Claimed before becoming Arrived.
Message-ID: <bug-22180-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22180

            Bug ID: 22180
           Summary: SERIAL_ALERT email does not send if the status is
                    Claimed before becoming Arrived.
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

Hi,

SERIAL_ALERT email sends itself correctly when the status of the issue changes
from Expected to Arrived.
But the issues goes from Expected to Claimed and then to Arrived, the email
does not send.
I also tested it with other status. Only the way Expected> Arrived works.
Is it normal?
Version tested: 18.05.04

REgards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 21 23:48:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Jan 2019 22:48:39 +0000
Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not
 installable on 32bit systems
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-MUA7Rjx0yW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #16 from giacomo at cregut.it ---
Yes, I was trying to install Koha on a raspberry pi 3.
I found a workaround as in I installed an unofficial 64bit Os and it worked.
Still I don't understand why you would list it as compatible when it's not...
Giacomo

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 02:41:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 01:41:00 +0000
Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not
 installable on 32bit systems
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-4sGaFIiRqy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
(In reply to giacomo from comment #16)
> Yes, I was trying to install Koha on a raspberry pi 3.
> I found a workaround as in I installed an unofficial 64bit Os and it worked.

Thanks for confirming that.

> Still I don't understand why you would list it as compatible when it's not...

Fair question. Mirko might be able to shed some light on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 08:22:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 07:22:34 +0000
Subject: [Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use
 Koha::Account->add_debit instead)
In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21756-70-y6RDYhA89V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #17 from Josef Moravec <josef.moravec at gmail.com> ---
Need rebase due to bug 21915.

Also qa tools have some complains:

 FAIL   Koha/Patron.pm
   FAIL   pod
                *** ERROR: Spurious text after =cut  in file Koha/Patron.pm

 FAIL   members/maninvoice.pl
   FAIL   valid
                        (Missing operator before $error?)
                Global symbol "$template" requires explicit package name (did
you forget to declare "my $template"?) 
                Scalar found where operator expected 
                Can't redeclare "my" in "my" 
                members/maninvoice.pl has too many errors.
                Global symbol "$cookie" requires explicit package name (did you
forget to declare "my $cookie"?) 
                Global symbol "$loggedinuser" requires explicit package name
(did you forget to declare "my $loggedinuser"?) 
                Global symbol "$error" requires explicit package name (did you
forget to declare "my $error"?) 
                "my" variable $input masks earlier declaration in same scope 
                Type of arg 1 to Try::Tiny::catch must be block or sub {} (not
reference constructor) 
                syntax error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 08:24:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 07:24:14 +0000
Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno
In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21683-70-ffbKTNzeQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Marking as BLOCKED, I'll wait for dependency patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 08:27:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 07:27:33 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-Nlax1deWnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to helene from comment #2)
> We restarted memcached and plack and the link still did not disappear.

Sorry could you describe more please ? Where does the test plan fail ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 08:30:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 07:30:16 +0000
Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to
 use Koha::Account->add_debit
In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21720-70-faLF1cetQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Martin Renvoize from comment #6)
> QA Question: Regarding the side effect, this is reasonably easy to avert
> within the add_debit method but I'd like input as to whether the FinesLog
> should really be just about Fines or should include all Charges.. as it
> stands it's a bit of a mix of both.. this patch series turns it into more of
> the ChargesLog but upping the logging but it could alternatively go the
> other way and make what is recorded a bit more explicitly about fines and
> only fines.

I would prefer to log all charges, not only fines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 08:31:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 07:31:48 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-ow5gHljR7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82624|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 08:32:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 07:32:53 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-oRo3PkyOyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Jonathan Druart from comment #5)
> > Created attachment 83400 [details] [review] [review]
> > Bug 21877: [ALTERNATIVE-PATCH] Display authorized value description for
> > withdrawn in checkout
> 
> Hi Frido,
> This is what I had in mind.
> It will avoid adding more stuff to C4::Circulation as well as unify the way
> we display/fetch the values
> 
> I would prefer this approach and provide selenium tests.
> 
> Note that another occurrence of notforloan must be replaced in circulation.tt
> 
> What do you think?

OK better indeed.
I will signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 09:08:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 08:08:44 +0000
Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to
 use Koha::Account->add_debit
In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21720-70-PzZfvZBAYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 09:08:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 08:08:47 +0000
Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to
 use Koha::Account->add_debit
In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21720-70-mIBh2xZI8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83199|0                           |1
        is obsolete|                            |
  Attachment #83200|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84271&action=edit
Bug 21720: Use Koha::Account->add_debit in AddIssuingCharge

Known Side Effect: Prior to this patch issuing charges were not
recorded in the FinesLog. After this patch, if the FinesLog is
enabled then the 'action' will be recorded as `create_rent`.

Sponsored-by: PTFS Europe

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 09:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 08:08:50 +0000
Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to
 use Koha::Account->add_debit
In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21720-70-g9G4U2tWZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84272&action=edit
Bug 21720: Update Tests

AddIssuing charge is always called in void context, but the tests
checked that the return value was a Koha::Account::Offset and we now
return a Koha::Account::Line.

This patch changes the test to accept a Koha::Account::Line as returned,
adds a test to ensure a Koha::Account::Offset is also created and
corrects the logic that tests that only one accountline is added.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 09:29:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 08:29:18 +0000
Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not
 installable on 32bit systems
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-0s5qGgp3k6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #18 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to giacomo from comment #14)
> Hello,
> I am fairly new to Koha and I'm currently trying to install Koha on a 32-bit
> Debian Stretch machine.
> I have run into the same problem as described above, even though here it
> says it was fixed.
> I'm trying to install the current stable version of Koha(18.11) and my
> sources.list file contains this:
>   deb http://debian.koha-community.org/koha dists/stable/main/binary-i386/

The line should be
deb http://debian.koha-community.org/koha 18.11 main

Does this work? Or do you need armhf? Then it is not a problem of 32bit vs
64bit, but amd64 and i386 being supported but armhf being not.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 09:30:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 08:30:27 +0000
Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not
 installable on 32bit systems
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-uiNz52ipyZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #19 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to David Cook from comment #15)
> The only modern use case I can think of is using a Raspberry Pi with a
> 32-bit Raspbian OS. 

Good catch, saves me a lot of headache :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:00:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:00:20 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-UuHXtUIRRG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83400|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:01:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:01:46 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-lj4ML3Sjp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Ah in the end I review all the code and split into 2 patches :
- adding withdrawn description
- changing the way notforloan description is fetched

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:02:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:02:08 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-uyXmJAqbIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 84273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84273&action=edit
Bug 21877: Show authorized value description for withdrawn in checkout

During checkout the withdrawn information is displayed in a message :
"Item has been withdrawn".

Like in other pages and like notforloan, we should display the withdrawn
authorized value description.

This patch adds this display.
Add <span> so that translation does not change.
Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding
this new information via CSS.

Test plan :
1) On a catalog with items.withdrawn defined with authorized values category
WITHDRAWN
2) Define in WITHDRAWN an authorized values 1 with description 'dropped in
trash'
3) Define in WITHDRAWN an authorized values 2 with description empty
4) Edit an item with withdrawn=1
5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)'
6) Edit an item with withdrawn=2
7) Checkout this item => You see 'Item has been withdrawn'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:02:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:02:20 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-iFT8qVrgoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 84274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84274&action=edit
Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in
checkout

Using only TT plugin for authorised value description is a better code.

Test plan :
Part 1:
1.1) On a catalog with items.notforloan defined with authorized values category
NOT_LOAN
1.2) Define in NOT_LOAN an authorized values 1 with description 'at the beach'
1.3) Define in NOT_LOAN an authorized values 2 with description empty
Part 2:
2.1) Set preference 'AllowNotForLoanOverride' to 'Don't allow'
2.2) Edit an item with notforloan=1
2.3) Checkout this item => You see 'Item not for loan (at the beach)'
2.4) Edit an item with notforloan=2
2.5) Checkout this item => You see 'Item not for loan'
Part 3:
3.1) Set preference 'AllowNotForLoanOverride' to 'Allow'
3.2) Edit an item with notforloan=1
3.3) Checkout this item => You see 'Item is normally not for loan (at the
beach)'
3.4) Edit an item with notforloan=2
3.5) Checkout this item => You see 'Item is normally not for loan'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:05:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:05:03 +0000
Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use
 Koha::Account->add_debit
In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21721-70-aUu8ArhYtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:05:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:05:05 +0000
Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use
 Koha::Account->add_debit
In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21721-70-bcEgR7EYEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83219|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84275&action=edit
Bug 21721: Use Koha::Account->add_debit in AddRenewal

Known Side Effect: Prior to this patch renewal charges were not
recorded in the FinesLog. After this patch, if the FinesLog is
enabled then the 'action' will be recorded as `create_rent`.

Sponsored-by: PTFS Europe

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:14:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:14:34 +0000
Subject: [Koha-bugs] [Bug 22181] New: Test "Payment notice" in
 t/db_dependent/Accounts.t fails when CurrencyFormat is set to FR
Message-ID: <bug-22181-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22181

            Bug ID: 22181
           Summary: Test "Payment notice" in t/db_dependent/Accounts.t
                    fails when CurrencyFormat  is set to FR
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:17:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:17:14 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
 Koha::Account->add_debit
In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21722-70-feiB0xKY7a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:17:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:17:16 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
 Koha::Account->add_debit
In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21722-70-lJ41YWXWMY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83197|0                           |1
        is obsolete|                            |
  Attachment #83198|0                           |1
        is obsolete|                            |

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84276&action=edit
Bug 21722: Tidy up tests and increase coverage

This patch moves the chargelostitem 'branchcode' test to within the
'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also
adds tests for additional accountline fields that should be getting
set by this method and adds tests for ProcessingFeeNote before removing
t/db_dependent/Circulation/Chargelostitem.t which covered this
previously.

Sponsored-by: PTFS Europe

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:17:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:17:19 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
 Koha::Account->add_debit
In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21722-70-UCY6KkNlP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84277&action=edit
Bug 21722: Use Koha::Account->add_debit in chargelostitem

This patch updates C4::Accounts::chargelostitem to use the newly
available add_debit method from Koha::Account.

Known Side Effects: If the FinesLog is enabled then the 'action'
recorded will change from the generic `create_fee` (for both the lost
charge and any associated processing charge) to the more descriptive
terms `create_processing` and `create_lost_item`.

Sponsored-by: PTFS Europe

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:26:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:26:21 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-2mK6MNyffO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82808|0                           |1
        is obsolete|                            |
  Attachment #82809|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84278&action=edit
Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:26:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:26:24 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-zF2sC6QxZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84279&action=edit
Bug 21728: Add 'Reserve Fee' to the account_offset_types

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 10:26:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 09:26:19 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-F2Q5i2avyd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 11:11:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 10:11:25 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-23Ca05dLH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

Simon Hohl <simon.hohl at dainst.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.hohl at dainst.org

--- Comment #66 from Simon Hohl <simon.hohl at dainst.org> ---
Hi Katrin,

could you elaborate on your variation of stocknumberAV? It looks like there are
some plugins for setting item related fields, but none for 001.

https://github.com/Koha-Community/Koha/tree/master/cataloguing/value_builder

So basically you'd need a script that reads the maximum biblio_metadata.id
instead of items.stocknumber as in
https://github.com/Koha-Community/Koha/blob/master/cataloguing/value_builder/stocknumber.pl?

Is your script publicly available somewhere?

Kind regards,
Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 12:15:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 11:15:34 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-ywlQZYGo8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84166|0                           |1
        is obsolete|                            |

--- Comment #23 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 84280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84280&action=edit
Bug 18723: Change dot into comma

This fixes the regression that multiplies the amount entered by 100
when CurrencyFormat is set to FR. It replaces the last dot with a
comma before dealing with the value of ActualCost and ReplacementCost.

Test Plan:
a)Replicate the issue:
    0- Set CurrencyFormat to FR
    1- Go to Acquisitions
    2- Search for a Vendor
    3- Click on "New basket"
    4- Give basket a name and click "Save"
    5- Click on "Add to basket"
    6- Add an order through preferred method
    7- In Accounting details, enter a vendor price with dot decimal (i.e.
19.44)
    8- Save your order line
    9- Click on "Close this basket"
    10- Confirm closing of basket by clicking on "Yes, close"
    11- Click on "Receive shipment"
    12- Enter an invoice number and click "Next"
    13- Click on "Receive" to the right of your order
    14- In Accounting details, notice the Actual cost is written with a decimal
dot.
    15- Change the Actual cost, using a dot decimal (i.e 20.99)
    16- Receive the order
    17- Click on "Save"
    18- In "Already received" notice the price is multiplied by 100 (i.e.
2099,00)
    19- Click on "Cancel receipt"
    20- Click on "Receive" to the right of your order
    21- In Accounting details, change the Actual cost, using a comma decimal
(i.e. 20,99)
    22- Receive the order
    23- Click on "Save"
    24- In "Already received", notice the price is correct.
b)Apply the patch
c)Test the patch:
    1- Click on "Cancel receipt"
    2- Click on "Receive to the right of your order
    3- Change the Actual cost/Replacement cost, using a dot decimal (21.99)
    4- Receive the order
    5- Click on "Save"
    6- Notice that the Actual cost and the Replacement cost use commas
    7- Change the Actual cost, using a comma decimal (21,99)
    8- Click on "Save"
    9- In "Already received", notice the price is still correct.

Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 12:15:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 11:15:53 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-6lwpMR89HY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 12:30:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 11:30:37 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-Y0CYwuj3vq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #24 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Here are the result with the 3 formats, is that the expected behavior?

CurrencyFormat:
- FR:
  - dot: ok (act as decimal separator)
  - comma: ok (act as decimal separator)
- US
  - dot: ok
  - comma: acts as a thousand separator (so multiply by 100 if one expected it
to act as a decimal separator)
- CH
  - dot: ok
  - comma: acts as a thousand separator (so multiply by 100 if one expected it
to act as a decimal separator)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 13:58:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 12:58:50 +0000
Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration
 to overdues report
In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21852-70-5opiTDF5Wg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 13:58:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 12:58:53 +0000
Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration
 to overdues report
In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21852-70-Y6BWrlWHyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82550|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84281&action=edit
Bug 21852: Add more columns and column configuration to overdues report

This patch adds some new columns to the overdue report: Patron category,
item home library, item holding library, item type. Adding these columns
makes available columns better match the available filter fields in the
sidebar form.

Column configuration is added to this DataTable, with the new columns
defined as hidden by default in order to preserve current functionality.

New code has been added to the global DataTables configuration to allow
the locally-stored column visibility information to override the default
Koha configuration for that table. This lets us take advantage of the
"stateSave" option in DataTAbles.

This patch also fixes a bug where the home and holding branch template
variable names didn't match what was being used in the template for
pre-selecting the searched-for value in the sidebar filter menu.

To test, apply the patch and go to Circulation -> Overdues.

 - The list of overdues should look correct, with no new columns shown.
 - Test the column visibility button, showing the columns which are
   hidden by default. Confirm that the data in these columns displays
   correctly.
 - Show or hide columns in such a way that it doesn't match the default
   configuration.
   - Navigate away from this page.
   - Return to the page. The same set of columns should be visible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 14:29:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 13:29:46 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-0YtsdsySpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #25 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
(In reply to Victor Grousset/tuxayo from comment #24)
> Here are the result with the 3 formats, is that the expected behavior?
> 
> CurrencyFormat:
> - FR:
>   - dot: ok (act as decimal separator)
>   - comma: ok (act as decimal separator)
> - US
>   - dot: ok
>   - comma: acts as a thousand separator (so multiply by 100 if one expected
> it to act as a decimal separator)
> - CH
>   - dot: ok
>   - comma: acts as a thousand separator (so multiply by 100 if one expected
> it to act as a decimal separator)

The other 2 formats use commas (or apostrophes for CH) as thousands separators,
so that behavior is kind of normal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:09:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:09:52 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-92ILuHH9Q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:09:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:09:56 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-GS8J29qDXB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82416|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84282&action=edit
Bug 21495: Regression in hold override functionality

The changes caused by the patches for bug 11512 have broken existing
workflows for many libraries and are widely considered to be a bad move.
We should revert this behavior.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Rhonda Kuiper <kuiper at roundrocktexas.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:10:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:10:20 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-uDsU7xHTIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:25:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:25:01 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-t0EUJjkCai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Barton Chittenden from comment #23)
> (In reply to Magnus Enger from comment #22)
> 
> > Would it make sense to add export.pl until someone comes up with a proper
> > solution? Or are there so few people downloading huge files that it is not
> > worth it?
> 
> I think it's probably worth it -- it's a one-line change, and it's easy to
> back out when we finally fix it. Nick, Kyle, Larry, care to weigh in?

That's up to the RM :)

Avoiding plack will 'fix' the script, but most likely cause everyone to stop
looking for an actual solution. That's my worry. That being said, it's probably
better to get it working in the near-term.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:25:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:25:11 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-y252W2KdeJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:48:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:48:50 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-RSUtNDpsA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can we please fix terminology?

The first patch adds "Reserve charge" (Translatability?)
The second adds "Reserve fee". 

Not sure if it should be charge or fee, but it should be hold! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:50:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:50:34 +0000
Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many
	subfields
In-Reply-To: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21958-70-6q6HMOYIYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:50:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:50:38 +0000
Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many
	subfields
In-Reply-To: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21958-70-GaEOLuSbAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958

--- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84283&action=edit
Bug 21958: Fix bibliographic record field comparison with authority

This makes the comparison between bibliographic field and authority field more
robust and per subfield. This makes the comparison not consider the same e.g.
the following fields:

$a Test User
$a Test $b User

The actual issue cannot be as easily reproduced with the patches for bug 21826
applied, but here's a test plan anyway:

1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*)
2. Make sure authority linking still works properly
3. Make sure authority and biblio frameworks allow subfield i
4. Make sure that even if you add subfield i to 700 in biblio, authority link
is kept the same
5. Make sure that even if you add subfield i to the authority record, the
authority link is kept the same

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:54:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:54:12 +0000
Subject: [Koha-bugs] [Bug 22182] New: Advanced editor - Rancor - Create item
	record
Message-ID: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22182

            Bug ID: 22182
           Summary: Advanced editor - Rancor - Create item record
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Currently you can use the macros feature in the advanced editor -rancor - to
create text strings to add fields in a record. It would be a nice enhancement
to add the item record fields (952$) via a macro in the editor too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 15:55:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 14:55:05 +0000
Subject: [Koha-bugs] [Bug 22182] Advanced editor - Rancor - Create item
	record
In-Reply-To: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22182-70-LyGLvHFHCM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22182

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:02:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:02:36 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-JmRtNZy6ri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72493|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84284&action=edit
Bug 18909: Enable the maximum zebra records size to be specified per instance

The default for Zebra is to not return results where the record size is
greater than 1045 KB ( 1 MB ). Some libraries need to increase this
ceiling, but it may come at a cost with z39.50 compatibility with other
services. For that reason, we should make this setting configurable on a
per-instance basis.

Test plan for kohadevbox:
1) Apply this patch
2) Run:
   $ reset_all
3) Restart Zebra:
   $ sudo koha-zebra --restart kohadev
4) Check how zebrasrv was called:
   $ ps waux | grep zebrasrv
=> SUCCESS: Looks like
 ... /usr/bin/zebrasrv -v none,fatal,warn -k 1024
5) Edit /etc/koha/sites/kohadev/koha-conf.xml, add:
   <zebra_max_record_size>2048</zebra_max_record_size>
6) Repeat (3) and (4)
=> SUCCESS: Looks like
 ... /usr/bin/zebrasrv -v none,fatal,warn -k 2048
7) Sign off :-D

General test plan:
1) Apply this patch
2) Build a Debian package
3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml
4) Restart zebra
5) Index a record greater than 1 MB but smaller than 2 MB
6) Note that it is searchable!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:03:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:03:57 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-UGDcbfrr8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:12:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:12:36 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-0hSd2GKIlp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #67 from Simon Hohl <simon.hohl at dainst.org> ---
I just realized: biblio_metadata.id is not the system number in 001. So you
would need the use the search index somehow?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:23:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:23:07 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-IvTkoFVRtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:23:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:23:12 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-i3m7AbQMIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83749|0                           |1
        is obsolete|                            |
  Attachment #83750|0                           |1
        is obsolete|                            |
  Attachment #83751|0                           |1
        is obsolete|                            |

--- Comment #72 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84285&action=edit
Bug 17006: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:23:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:23:24 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-xHV9QaOVDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #73 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84286&action=edit
Bug 17006: OpenAPI spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:23:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:23:28 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-Zl8MxbXR7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #74 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84287&action=edit
Bug 17006: Add /patrons/{patron_id}/password

This patch introduces an endpoint for changing a patron's password. It
targets privileged user with the right permissions, changing some
patron's password.

To test:

- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t
=> SUCCESS: tests pass!
- Play with the different use cases highlighted by the tests, on your
favourite REST testing tool (Postman, RESTer on FF, etc).

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:29:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:29:24 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-g6xMn8Cgqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:29:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:29:27 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-cxq8tJbiDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83764|0                           |1
        is obsolete|                            |
  Attachment #83765|0                           |1
        is obsolete|                            |
  Attachment #83766|0                           |1
        is obsolete|                            |
  Attachment #83767|0                           |1
        is obsolete|                            |
  Attachment #83768|0                           |1
        is obsolete|                            |
  Attachment #84207|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84288&action=edit
Bug 22061: Add RESTPublicAPI syspref

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:30:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:30:56 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-CPcgtsJD3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84288|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84289&action=edit
Bug 22061: Add RESTPublicAPI syspref

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:31:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:31:05 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-yYvm3YEUmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84290&action=edit
Bug 22061: Add a /public namespace that can be switched on/off

This patch adds a check in Koha::REST::V1::Auth::under to catch all
routes that begin with 'public' (inside /api/v1). If they match, and the
RESTPublicAPI syspref is off, then an exception is thrown, rendering a
403 error to the consumer.

Otherwise the routes are processed as usual. This is THE on/off switch
for the public REST API. The target use case: people not wanting an OPAC
or public interaction with the API besides privileged users.

In order to test, the rest of the patches are needed because the only
way to test a route is having it in the spec.

To test:
- Apply the patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth.t
=> SUCCESS: tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:31:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:31:08 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-dF9DTcahX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84291&action=edit
Bug 22061: Unit tests

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:31:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:31:12 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-dZMi8texrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84292&action=edit
Bug 22061: OpenAPI spec

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:31:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:31:15 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-fupBDH1uiM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84293&action=edit
Bug 22061: Public route to change password

This patch implements a route to change patron's password for
unprivileged users. It's intended for using in the OPAC (or however
consumers find it useful).

It is a starting point for the public API, and the bug also implements
the on/off switch some community members asked for.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t \
          t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass! i.e.
        - RESTPublicAPI is honoured
        - The /public/patrons/:patron_id/password endpoint works as
        expected
- Use your favourite API testing tool to try the endpoint.
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:31:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:31:18 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-RedP54jksE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84294&action=edit
Bug 22061: (QA follow-up) Rename password_2 => password_repeated

As voted when the RFC was discussed, the attribute gets renamed. The
tests are adjusted accordingly.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_password.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:33:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:33:38 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-QPYat1mjWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

--- Comment #15 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #14)
> Testing this I got confused about the payment note feature. I am wondering,
> do we need it to be on the payments table? It seems a little confusing as
> you seem to only be able to save it actually paying a fine. Wouldn't it be
> enough if the field appeared editable on the actual form? Maybe I am missing
> something!

I agree that this is a little wonky.

It would also be helpful if notes could be updated or edited after the fact,
but this is a topic for another ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 16:39:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 15:39:31 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-TcQyFz6CIO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #26 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
That's what I understood, good :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 17:10:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 16:10:12 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-BiNalTEfaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 17:32:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 16:32:38 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-DNuyHPmiuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #441 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Katrin Fischer from comment #440)
> "No undecided" sounds fine to me indeed :)
> 
> But I wonder if this is really the behaviur of the current patches? I think
> it said "Enabled" when I test installed the other day. But I won't have time
> for another test the next days :(

Katrin,

Does that means you are ok for the third option (the so called "No, let me
think about it") as described above ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 17:33:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 16:33:44 +0000
Subject: [Koha-bugs] [Bug 22183] New: Koha to MARC mapping should provide
	warning
Message-ID: <bug-22183-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22183

            Bug ID: 22183
           Summary: Koha to MARC mapping should provide warning
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rogan.hamby at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

Koha to MARC mapping should recommend to users to run the framework tests after
making changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 17:39:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 16:39:10 +0000
Subject: [Koha-bugs] [Bug 22183] Koha to MARC mapping should provide warning
In-Reply-To: <bug-22183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22183-70-U2PrDUq2hJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22183

Rogan Hamby <rogan.hamby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |rogan.hamby at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:22:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:22:59 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-j6oVevp18K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:16 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-kHzCziSUdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77896|0                           |1
        is obsolete|                            |

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84296&action=edit
Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved

This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold. This patch
checks if the library is configured to be a pickup location (see Bug 7534), and
also if the item can be transferred into the given library (see Bug 18072).

To test:
1. prove t/db_dependent/Holds.t

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:20 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-c7WGf43Mx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77897|0                           |1
        is obsolete|                            |

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84297&action=edit
Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches

Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations.

This patch modified the mentioned method to consider branch transfer limits and
does not include any library in the returned list of libraries in case a branch
transfer limit applies for a given book or item.

To be tested in following patches.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:23 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-gnMB98FAjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77898|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84298&action=edit
Bug 7614: Build a list of pickup locations in OPAC considering transfer limits

This patch enables the checks for transfer limits for given biblionumber in
OPAC when patron proceeds to place a hold. In case none of the items of that
biblio can be transferred to a library, that library will not be included in
the list of pickup locations.

To test:
1. Make sure you meet the following requirements:
   1.1: You are able to make holds in OPAC
   1.2: System preference UseBranchTransferLimits set to "Enforce"
   1.3: System preference BranchTransferLimitsType set to "item type"
        (for the sake of simplicity of this test plan, but you may also
         set it to "collection code" and deal with ccodes instead)
   1.4: System preference item-level_itypes set to "specific item"
   1.5: You have the default libraries and item types, otherwise replace
        the branchcodes and itemtypes in this test plan with your own
2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled
   its ability to act as a "Pickup location"
3. Have a biblio with exactly one item of item-level itemtype 'BK'
4. Set item holdingbranch as 'CPL'
5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in
   a second tab for faster testing)
6. Select library 'Centerville'
7. Uncheck the checkbox 'FFL - Fairfield' and click Save
8. Go to OPAC and find your biblio, and start placing a hold on it
9. Click at the list of "Pick up location"s.
10. Observe that it is missing 'Fairfield'
11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl
12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield'
13. Refresh the page you arrived at step 8
14. Observe that it now includes 'Fairfield'

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:02 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-swVlcxzcIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77895|0                           |1
        is obsolete|                            |

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84295&action=edit
Bug 7614: Add a new method Koha::Libraries->pickup_locations

This patch adds a new method, Koha::Libraries->pickup_locations. This method
takes either an item or a biblio as a parameter, and returns the list of
acceptable pickup locations by considering libraries' configuration to act
as a pickup location as well as any branch transfer limits that may apply.

To test:
1. prove t/db_dependent/Koha/Libraries.t

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:27 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-z82MaVYArK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77899|0                           |1
        is obsolete|                            |

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84299&action=edit
Bug 7614 - Fix my variable earlier declaration bug.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:31 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-YdX2dxEdpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77900|0                           |1
        is obsolete|                            |

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84300&action=edit
Bug 7614: (follow-up) If patron's home library is not a pickup library, let
them choose another one

This patch fixes an issue where patron is not allowed to place a hold in OPAC
while their home library is not a pickup library.

Instead, they should be presented with a list of other available pickup
locations.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:23:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:23:34 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-98chXbHqdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78020|0                           |1
        is obsolete|                            |

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84301&action=edit
Bug 7614: Don't allow un-usable pickup locations in the opac pickup locations
pulldown

Also fully qualifies some subroutine calls that fail for reasons unkown.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 19:44:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 18:44:04 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-qQSyF9mOzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:06:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:06:46 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-vAOJ119SCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:27 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-gyBY1mJneF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:31 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-6umAhwbHhc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84295|0                           |1
        is obsolete|                            |
  Attachment #84296|0                           |1
        is obsolete|                            |
  Attachment #84297|0                           |1
        is obsolete|                            |
  Attachment #84298|0                           |1
        is obsolete|                            |
  Attachment #84299|0                           |1
        is obsolete|                            |
  Attachment #84300|0                           |1
        is obsolete|                            |
  Attachment #84301|0                           |1
        is obsolete|                            |

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84302&action=edit
Bug 7614: Add a new method Koha::Libraries->pickup_locations

This patch adds a new method, Koha::Libraries->pickup_locations. This method
takes either an item or a biblio as a parameter, and returns the list of
acceptable pickup locations by considering libraries' configuration to act
as a pickup location as well as any branch transfer limits that may apply.

To test:
1. prove t/db_dependent/Koha/Libraries.t

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:45 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-hVXCJz43qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84304&action=edit
Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches

Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations.

This patch modified the mentioned method to consider branch transfer limits and
does not include any library in the returned list of libraries in case a branch
transfer limit applies for a given book or item.

To be tested in following patches.

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:48 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-yT54YIQPbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84305&action=edit
Bug 7614: Build a list of pickup locations in OPAC considering transfer limits

This patch enables the checks for transfer limits for given biblionumber in
OPAC when patron proceeds to place a hold. In case none of the items of that
biblio can be transferred to a library, that library will not be included in
the list of pickup locations.

To test:
1. Make sure you meet the following requirements:
   1.1: You are able to make holds in OPAC
   1.2: System preference UseBranchTransferLimits set to "Enforce"
   1.3: System preference BranchTransferLimitsType set to "item type"
        (for the sake of simplicity of this test plan, but you may also
         set it to "collection code" and deal with ccodes instead)
   1.4: System preference item-level_itypes set to "specific item"
   1.5: You have the default libraries and item types, otherwise replace
        the branchcodes and itemtypes in this test plan with your own
2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled
   its ability to act as a "Pickup location"
3. Have a biblio with exactly one item of item-level itemtype 'BK'
4. Set item holdingbranch as 'CPL'
5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in
   a second tab for faster testing)
6. Select library 'Centerville'
7. Uncheck the checkbox 'FFL - Fairfield' and click Save
8. Go to OPAC and find your biblio, and start placing a hold on it
9. Click at the list of "Pick up location"s.
10. Observe that it is missing 'Fairfield'
11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl
12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield'
13. Refresh the page you arrived at step 8
14. Observe that it now includes 'Fairfield'

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:52 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-FJPgJHy9Mt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84306&action=edit
Bug 7614: Fix my variable earlier declaration bug.

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:55 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-WtUmaRRnrm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84307&action=edit
Bug 7614: (follow-up) If patron's home library is not a pickup library, let
them choose another one

This patch fixes an issue where patron is not allowed to place a hold in OPAC
while their home library is not a pickup library.

Instead, they should be presented with a list of other available pickup
locations.

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:59 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-lXgFJjnpqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84308&action=edit
Bug 7614: Don't allow un-usable pickup locations in the opac pickup locations
pulldown

Also fully qualifies some subroutine calls that fail for reasons unkown.

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:07:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:07:41 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-WKEJfUZ2Vy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84303&action=edit
Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved

This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold. This patch
checks if the library is configured to be a pickup location (see Bug 7534), and
also if the item can be transferred into the given library (see Bug 18072).

To test:
1. prove t/db_dependent/Holds.t

Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:08:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:08:03 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-9VmBwuyG5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84309&action=edit
Bug 7614 [QA Follow-up]: Fix POD merge missed in rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:08:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:08:07 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-TOm01vUzfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84310&action=edit
Bug 7614 [QA Follow-up]: Tidy code to remove tab characters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:08:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:08:11 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-F6lqhp30XT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84311&action=edit
Bug 7614 [QA Follow-up]: Remove unused variable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 20:55:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 19:55:03 +0000
Subject: [Koha-bugs] [Bug 12793] Breaking up IndependentBranches syspref to
 support finer staff permissions granularity
In-Reply-To: <bug-12793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12793-70-Zv13u0Mm82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12793

Carl <ctodd at hcc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ctodd at hcc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 21:10:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 20:10:33 +0000
Subject: [Koha-bugs] [Bug 22184] New: Move payment note out of payments
 table and into payment form
Message-ID: <bug-22184-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22184

            Bug ID: 22184
           Summary: Move payment note out of payments table and into
                    payment form
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

>From Comment 14 on Bug 21918:
I got confused about the payment note feature. I am wondering, do we need it to
be on the payments table? It seems a little confusing as you seem to only be
able to save it actually paying a fine. Wouldn't it be enough if the field
appeared editable on the actual form?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 21:13:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 20:13:39 +0000
Subject: [Koha-bugs] [Bug 22184] Move payment note out of payments table and
 into payment form
In-Reply-To: <bug-22184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22184-70-FCoQ1Q38KB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22184

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 21:18:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 20:18:59 +0000
Subject: [Koha-bugs] [Bug 22185] New: Make a payment/fee note editable
Message-ID: <bug-22185-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22185

            Bug ID: 22185
           Summary: Make a payment/fee note editable
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

At the moment, once a fine has been paid and the note saved, it can't be edited
after.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 21:19:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 20:19:40 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-TvqiiwpfJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

--- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Christopher Brannon from comment #15)
> (In reply to Katrin Fischer from comment #14)
> > Testing this I got confused about the payment note feature. I am wondering,
> > do we need it to be on the payments table? It seems a little confusing as
> > you seem to only be able to save it actually paying a fine. Wouldn't it be
> > enough if the field appeared editable on the actual form? Maybe I am missing
> > something!

Made Bug 22184 for this

> 
> I agree that this is a little wonky.
> 
> It would also be helpful if notes could be updated or edited after the fact,
> but this is a topic for another ticket.

Made Bug 22185 for this

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 22 22:21:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 21:21:40 +0000
Subject: [Koha-bugs] [Bug 22186] New: Reword 'number of num' when renewing a
	subscription
Message-ID: <bug-22186-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22186

            Bug ID: 22186
           Summary: Reword 'number of num' when renewing a subscription
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

Find a subscription that has expired
Click Renew
Notice there is a text input with label "Number of num" which isn't very clear

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 00:30:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Jan 2019 23:30:06 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-5WDn3BPvs4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

--- Comment #25 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #24)
> Avoiding plack will 'fix' the script, but most likely cause everyone to stop
> looking for an actual solution. That's my worry. That being said, it's
> probably better to get it working in the near-term.

This is my worry as well but I didn't want to say it and seem like a naysayer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 01:33:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 00:33:25 +0000
Subject: [Koha-bugs] [Bug 22187] New: Choose which fields can be modified by
 patron on OPAC
Message-ID: <bug-22187-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22187

            Bug ID: 22187
           Summary: Choose which fields can be modified by patron on OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Some libraries would like to choose which fields patrons can modify (or suggest
modifications to) through the OPAC when they go into their online account and
"my personal information" (for example phone number and email only).

This could be a syspref, something like OPACPatronDetailsFields where
administrators can put a list of fields, separated by |, which the users can
modifiy through the OPAC. If left empty, defaults to everything.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 02:03:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 01:03:46 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-FAV4UX9ShU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 02:04:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 01:04:07 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-onFwLyAYxp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 02:03:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 01:03:48 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-UuU0Av60Kd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84312&action=edit
Bug 15148: Predict serials issues from subscription start date

To test:
1 - Create a new serial
2 - Set 'First issue plublication date' to some date in 2016
3 - Set subscription start date to today
4 - Set length to 104 weeks
5 - Test prediction pattern - only one generated
6 - Apply patch
7 - Test prediction patern - many generated!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 02:12:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 01:12:06 +0000
Subject: [Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called
 twice when running link_bibs_to_authorities
In-Reply-To: <bug-21957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21957-70-BqHIKWdASQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 02:12:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 01:12:09 +0000
Subject: [Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called
 twice when running link_bibs_to_authorities
In-Reply-To: <bug-21957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21957-70-eKb7dHv229@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82893|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84313&action=edit
Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker

To test:
1 - prove -v t/db_dependent/Biblio.t
2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities
3 - Modify a biblio to add a heading with no existing auth record
4 - Ensure the record was created on saving
5 - Ensure that editing works as normal otherwise
6 - Run link_bibs_to_authorities
7 - Ensure results are as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 04:48:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 03:48:53 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-gJU3ayDYed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
I'm trying this now... 

Currently updating
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
to work with koha-testing-docker...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 04:53:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 03:53:22 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-AvFUHiC8gP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Having issues with koha-testing-docker running in Docker Desktop on Windows...

Although that reminds me of a little workaround I did so that I wouldn't have
to deal with Windows...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 05:48:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 04:48:49 +0000
Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern
In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22188-70-pWmtrehrd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 05:48:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 04:48:42 +0000
Subject: [Koha-bugs] [Bug 22188] New: Use publication date as numbering
	pattern
Message-ID: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

            Bug ID: 22188
           Summary: Use publication date as numbering pattern
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

Brimbank Libraries Australia would like to be able to use the publication date
of a serial as the issue number.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 05:59:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 04:59:44 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-5eEEZvhRrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
Moved my Koha git repo into an actual Docker volume, so it exists on the Linux
VM and not on my Windows host and shared as a bind mount. That removes the OS
issues I seemed to be experiencing. 

I'd already increased the default disk space in the Hyper-V VM, and now I
increased the CPU and RAM, and now git is working much much better in
koha-testing-docker on Windows. 

Now to the actual testing...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:07:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:07:50 +0000
Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern
In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22188-70-mVuhiLw2Io@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:07:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:07:53 +0000
Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern
In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22188-70-6TqFeXhjkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84314&action=edit
Bug 22188: Use publication date as numbering pattern

Brimbank were trying to make a numbering pattern that displays the
publication date, but numbering patterns are calculated mathematically,
and dates are not always consistent and don't work that way. I've
written a feature that hardcodes an option to use the publication date
instead of a numbering pattern, in a 'Y M D' format.

To test:
1) Go to Serials
2) Click New subscription
3) Fill in the necessary details for the first page and click Next
4) Fill in the necessary details for the second page. Under numbering
pattern, select Number.
5) Notice the advanced pattern table shows. Put some random data in
these fields
6) Change numbering pattern to Use publication date. Confirm that
selecting this option hides the advanced pattern table and clears its fields.
7) Click Test prediction pattern and confirm the prediction pattern shows as
expected
8) Save subscription
9) You should now be on the subscription detail page for your new
subscription. Go to the Planning tab and confirm that it says 'uses
publication date' under Number pattern and that there is now table
saying 'Starting with' and 'Rollover'
10) Go to the Issues tab and confirm the first serial is there with the
correct issue number (publication date).
11) Click the Receive button
12) Confirm the publication date shows under the Numbered column, in the
Issue text field and click Save
13) Click the Generate next button and confirm the alert box
14) Confirm the publication date shows under 'Number'
15) Find/make a subscription that uses a normal numbering pattern
16) Edit this subscription to now use the publication date as numbering
pattern
17) Upon saving, confirm that previously received serials keep their old
issue numbers
18) Click Receive and Generate next again and confirm that the next
serial now has the publication date
19) Confirm that making a subscription with a normal numbering pattern
works as expected. Upon saving, the table should show under the Planning
tab with 'Starting with' and 'Rollover' and all other fields should be
filled correctly.

Sponsored-by: Brimbank Libraries Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:12:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:12:31 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-4zXxzSKWgm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:12:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:12:34 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-ZQPyhLiYre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83685|0                           |1
        is obsolete|                            |

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84315&action=edit
Bug 21089: Overlapping elements in ordering information on acqui/supplier.pl

This patch changes the HTML structure of the vendor edit page so that
the markup is a little simpler. CSS is modified to match. This structure
should serve as a model for other similar form structures:

 <fieldset class="rows">
     <ol>
         <li>
             <label>General label:</label>
             <label class="radio">
                 Specific label 1 <input type="radio" />
             </label>
             <label class="radio">
                 Specific label 2 <input type="radio" />
             </label>
         </li>
     </ol>
 </fieldset>

To test, apply the patch and regenerate the staff client CSS.

 - Go to Acquisitions -> Vendor search -> Vendor -> Edit vendor
 - In the "Ordering information" section, confirm that the position of
   radio buttons looks correct.
 - Confirm that radio button labels work correctly.
 - Confirm that the adjacent dropdown menus work well.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:13:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:13:01 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-lOCpWXVkOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
Thanks for this, Owen! It looks much much better with your changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:14:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:14:00 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-LjPNQKEII7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
I take it that the RM is responsible for generating the
koha-tmpl/intranet-tmpl/prog/css/staff-global.css later?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:47:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:47:21 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-1Eh8PcVj8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #42 from David Cook <dcook at prosentient.com.au> ---
All looks good to me using Chrome Version 71.0.3578.98 (Official Build)
(64-bit) on Windows 10.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:50:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:50:31 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-rNFiSHPMQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83731|0                           |1
        is obsolete|                            |

--- Comment #43 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84316&action=edit
Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display

This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky
(https://github.com/somewebmedia/hc-sticky). This plugin provides the
same functionality without the page-reflow problems fixFloat suffers
from.

To test, apply the patch and regenerate the staff client CSS. Test the
behavior of the floating toolbar on these pages:

 - Acquisitions -> Vendor -> Vendor details
 - Acquisitions -> Vendor -> View basket
   - On both these pages, test toolbar behavior before and after
     expanding the "Orders search" options at the top of the page.
 - Administration -> System preferences
 - Authorities -> Create or edit an authority
 - Catalog -> Advanced search
   - Search results
 - Catalog -> Item search
 - Cataloging -> Add or edit a record
   - Open the plugin window for the 008 field
 - Tools -> Label creator -> New label batch -> Add items -> Search ->
   Results
 - Patrons -> New patron
   - Test before and after expanding the patron search options at the
     top of the page
   - Test editing a patron too
 - Tools -> Automatic item modifications by age -> Edit
 - Tools -> Notices & slips -> Edit
 - Lists -> View list

Check that the About page has been updated with information about the
plugin.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:50:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:50:35 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-0MeJ7VCwu5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83732|0                           |1
        is obsolete|                            |

--- Comment #44 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84317&action=edit
Bug 21751: Remove former fixFloat plugin

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 06:50:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 05:50:47 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-sKuXiDrz52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:11:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:11:41 +0000
Subject: [Koha-bugs] [Bug 12902] Cronjob monitoring script,
	nagios3 compatible
In-Reply-To: <bug-12902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12902-70-fz8Zhedkvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #3)
> Patch still applies, but I don't know how to test this. Someone using Nagios
> maybe?

1. I don't think this really has a place in Koha. People can monitor however
they like, so I don't think we should include Nagios specifically.

2. I use Nagios, but I don't have any interest in testing this.

3. It's not clear from the description what this patch does, although after
reviewing the code, it seems like it's trying to do too much. 

4. That all said, it wouldn't hurt to make cronjobs log in some way that is
friendly for monitoring apps. We have cronlogaction now, but maybe that could
be improved. 

Olli, are you still interested in this in 2019?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:20:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:20:27 +0000
Subject: [Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e"
 isn't numeric in numeric ne (!=)
In-Reply-To: <bug-21172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21172-70-Zf22vbpBtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #2)
> Isn't 01e a bug on the data?

I was curious about this...

https://www.loc.gov/marc/bibliographic/bdintro.html

"Variable fields - The data in a MARC bibliographic record is organized into
variable fields, each identified by a three-character numeric tag that is
stored in the Directory entry for the field. Each field ends with a field
terminator character. The last variable field in a record ends with both a
field terminator and a record terminator (ASCII 1D hex). There are two types of
variable fields."

It seems that technically 01e is a violation of the MARC standard. 

Maybe it is time to remove 01e from the frameworks...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:31:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:31:11 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-n0fqPOZ2s7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81861|0                           |1
        is obsolete|                            |

--- Comment #251 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84318&action=edit
Bug 10662: Build OAI-PMH Harvesting Client

This patch adds an OAI-PMH harvesting client to Koha.

The client runs as a daemon in the background. Users interact with the client
via the Koha web user interface, which communicates with the daemon via a unix
socket
using a simple JSON-based protocol.

The harvester ingests MARCXML. You can harvest other metadata formats, but you
must use a XSLT to transform them into MARCXML, if you want them to be imported
into Koha.

You can supply your own download and import modules via the
oai-pmh-harvester.yaml
configuration file, but the default modules supplied in this patch should
be good enough for your purposes. If they're not, raise a Bugzilla issue.

There is a cleanup_database.pl addition, because high volume harvesting
will cause the oai_harvester_import_queue table to fill quickly. This table
is not required for adding/updating records. It's mostly just for general
monitoring and audit purposes.

Signed-off-by: Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:31:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:31:29 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-NnFjEzOzlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81863|0                           |1
        is obsolete|                            |

--- Comment #253 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84320&action=edit
Bug 10662: (QA follow-up) Fix plural in pod and use statements

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:31:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:31:36 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-VABiordR9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81864|0                           |1
        is obsolete|                            |

--- Comment #254 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84321&action=edit
Bug 10662: (QA follow-up) Enhance marc matchers description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:31:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:31:21 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-d6qIV4TF2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81862|0                           |1
        is obsolete|                            |

--- Comment #252 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84319&action=edit
Bug 10662: (QA follow-up) provide DBIC schema files

DBIC schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:31:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:31:44 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-Gifqg12RFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82219|0                           |1
        is obsolete|                            |

--- Comment #255 from David Cook <dcook at prosentient.com.au> ---
Created attachment 84322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84322&action=edit
Bug 10662: (follow-up) Template corrections and improvements

This patch makes a number of corrections and improvements to the OAI
harvester templates:

 - Add missing DataTables CSS include
 - Replace YUI grid with Bootstrap
 - Correct style of inline dialogs (.dialog.alert, .dialog.message)
 - Correct class of form hint and error messages
 - Format dates in saved and submitted requests tables
   - Add title-string sorting to DataTables configuration
 - Add delete confirmation to saved and submitted tables
 - Disable sorting on action columns
 - Style action links inside tables as buttons
 - Removed commented markup
 - Add missing JavaScript include (tools-menu.js) to highlight active
   section in sidebar menu
 - Add CodeMirror styling to record view page (CodeMirror XML mode file
   is added to enable this)
 - Remove invalid <script> "type" attribute

To test, apply the patch and clear your cache if necessary.

 - Go to Tools -> OAI-PMH harvester
   - "Saved," "Submitted," and "Import history" table should look
      correct and work correctly: Sorting, column visibility,
      pagination, etc.
   - In the "Saved" and "Submitted" tables, dates should be formatted
     according to the dateformat preference and sorting of these dates
     should work correctly.
   - In the "Import history" table the "View record" and "View in
     catalog" links should be styled as Bootstrap buttons.
     - Click the "View record" button.
       - The view of the downloaded record should have XML syntax
         highlighting.
   - When you perform actions like submitting requests, starting
     requests, etc, corresponding dialogs should be styled correctly.
     Informational/successful information should be "message" style
     dialogs. Error dialogs should be "alert" style.
   - Click "New request"
     - Form hints in the new request form should be styled correctly.
     - Submit the form without filling in any fields. Field-specific
       error messages should be styled italic red.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 07:39:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 06:39:52 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-qf5EUvibNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #442 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Alex Arnaud from comment #441)
> (In reply to Katrin Fischer from comment #440)
> > "No undecided" sounds fine to me indeed :)
> > 
> > But I wonder if this is really the behaviur of the current patches? I think
> > it said "Enabled" when I test installed the other day. But I won't have time
> > for another test the next days :(
> 
> Katrin,
> 
> Does that means you are ok for the third option (the so called "No, let me
> think about it") as described above ?

Yes, if I understood the feature correctly, I would be fine. I understand it
would mean off by default, but with an information to the user that they might
want to turn it on. Turning it yes or no would turn the message off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:27:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:27:00 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-3jgN7sz1V5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84260|0                           |1
        is obsolete|                            |

--- Comment #443 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84323&action=edit
Bug 17047: add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:27:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:27:34 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-4ts99bQmmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84261|0                           |1
        is obsolete|                            |

--- Comment #444 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84324&action=edit
Bug 17047: subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:28:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:28:20 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-KZZBOF4ZCl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84263|0                           |1
        is obsolete|                            |

--- Comment #446 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84326&action=edit
Bug 17047: add a dedicated page for Mana setup

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:27:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:27:58 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-5eJ0DdjjTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84262|0                           |1
        is obsolete|                            |

--- Comment #445 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84325&action=edit
Bug 17047: SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by
number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
    - no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the
test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again
on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the
action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com> (2018-07-04)
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:28:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:28:50 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-vqzoj1D2Do@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #447 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84327&action=edit
Bug 17047: Add a third option for Mana system preference

This adds the "No, let me think about it" option.
It is the default option. If the Mana system preference
is set to "No, let me think about it", the user is warned
on the admin home page that he has not decided yet to use
or not Mana knowlegde base.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:29:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:29:34 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Td4eeuGgKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84265|0                           |1
        is obsolete|                            |

--- Comment #449 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84329&action=edit
Bug 17047: [DO NOT PUSH] provides schema files

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:29:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:29:11 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-31nQfV30EQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84264|0                           |1
        is obsolete|                            |

--- Comment #448 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84328&action=edit
Bug 17047: [DO NOT PUSH] provide staff-global.css

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 10:32:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 09:32:32 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-9JQV91DvE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #450 from Alex Arnaud <alex.arnaud at biblibre.com> ---
I re-added the third "No, let me think about it" option.
Also, reword the commit message to be consistent with the naming conventions.

Need a signoff for this last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 11:56:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 10:56:30 +0000
Subject: [Koha-bugs] [Bug 22189] New: Advance Search is not working
Message-ID: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

            Bug ID: 22189
           Summary: Advance Search is not working
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: schulzezekiel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Created attachment 84330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84330&action=edit
image.

i have been cataloguing. lately the advance search option is not working. it
says no results found. i have recorded alomst 7,000 books in it. what happened?
is everything deleted ? i have a screenshot i can give you about the result
page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 11:58:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 10:58:24 +0000
Subject: [Koha-bugs] [Bug 22189] Advance Search is not working
In-Reply-To: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22189-70-QNlLGTXOhl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to bunny from comment #0)
> Created attachment 84330 [details]
> image.
> 
> i have been cataloguing. lately the advance search option is not working. it
> says no results found. i have recorded alomst 7,000 books in it. what
> happened? is everything deleted ? i have a screenshot i can give you about
> the result page.

Is Zebra running?

See About page, if there is some problem with Zebra, you should see it here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:00:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:00:00 +0000
Subject: [Koha-bugs] [Bug 22189] Advance Search is not working
In-Reply-To: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22189-70-HypvONK77J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

--- Comment #2 from bunny <schulzezekiel at gmail.com> ---
sorry . i dont know what zebra is....

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:00:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:00:19 +0000
Subject: [Koha-bugs] [Bug 22189] Advance Search is not working
In-Reply-To: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22189-70-hCExtpAd0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

--- Comment #3 from bunny <schulzezekiel at gmail.com> ---
sorry . i dont know what zebra is....

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:01:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:01:56 +0000
Subject: [Koha-bugs] [Bug 22189] Advance Search is not working
In-Reply-To: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22189-70-NCkbmYGZo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

--- Comment #4 from bunny <schulzezekiel at gmail.com> ---
Zebra 2.0.44 (C) 1994-2010, Index Data ApS Zebra is free software, covered by
the GNU General Public License, and you are welcome to change it and/or
distribute copies of it under certain conditions. SHA1 ID:
419ad759807269fdfa379799a051ed3a551c6541 Using ICU

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:03:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:03:12 +0000
Subject: [Koha-bugs] [Bug 22189] Advance Search is not working
In-Reply-To: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22189-70-Nlohbv87as@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

--- Comment #5 from bunny <schulzezekiel at gmail.com> ---
Created attachment 84331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84331&action=edit
about koha image

about KOHA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:06:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:06:52 +0000
Subject: [Koha-bugs] [Bug 22189] Advance Search is not working
In-Reply-To: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22189-70-CfNcBLTpxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22189

bunny <schulzezekiel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|All                         |PC
          Component|Cataloging                  |Searching

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:20:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:20:58 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-BRkLPWXxWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I get the feeling having some tests added here would greatly appease any
worries of possible introducing regressions.

It would also be nice to have a definitive performance comparison, but actually
to me that less important than having tests for regressions as the code looks
cleaner this way to me and doesn't give a noticeable degradation in performance
in testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:47:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:47:40 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-iUf8P133H3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
If memory serves there's some fun to be had regarding the EasyAnalytics and the
UseControlNumber preferences around this code.. you may (or may not) want to
investiage that preference a little further too before making this change.

I do however like the general idea here.. tidying up a little.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 12:48:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 11:48:54 +0000
Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22140-70-uTMazs7kv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Also.. looking at the original diff
(https://github.com/Koha-Community/Koha/commit/f09e2ca27ee89860dbdd0ca512735f37fbfaf8a6)
of the EasyAnalytics submission, it looks like this could go futher.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:06:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:06:53 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-8rEaZ274PG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:08:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:08:23 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-sxhNlPIwtT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:22:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:22:24 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-w1s2el3olW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:23:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:23:02 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-mElW7ldZzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:23:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:23:44 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-1UTWUidyoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:25:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:25:25 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-PA40nNOayM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:26:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:26:09 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-KV65OjbpEm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:27:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:27:10 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-453ne8lTKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:38:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:38:19 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-2iIjq4KBST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84115|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:39:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:39:26 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-v73PZn32KH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84327|0                           |1
        is obsolete|                            |

--- Comment #451 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84332&action=edit
Bug 17047: Add a third option for Mana system preference

This adds the "No, let me think about it" option.
It is the default option. If the Mana system preference
is set to "No, let me think about it", the user is warned
on the admin home page that he has not decided yet to use
or not Mana knowlegde base.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:41:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:41:13 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-v9xJMU3KDu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:42:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:42:23 +0000
Subject: [Koha-bugs] [Bug 21491] When 'Default lost item fee refund on
 return policy' is unset it says no but acts as if 'yes'
In-Reply-To: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21491-70-fbAVRvRq7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:43:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:43:07 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-LF39KfpRj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:44:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:44:10 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
 gives no results if search terms include punctuation
In-Reply-To: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21084-70-XKjWWn6UVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:45:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:45:55 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-DpAPrDmZ4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:46:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:46:39 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-9Gg1efRlfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:46:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:46:44 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-lapJhWiIx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:48:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:48:15 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-FcOPUfNmGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 13:56:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 12:56:48 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-d32QWooknl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to David Cook from comment #11)
> I take it that the RM is responsible for generating the
> koha-tmpl/intranet-tmpl/prog/css/staff-global.css later?

That is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 14:07:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 13:07:48 +0000
Subject: [Koha-bugs] [Bug 22187] Choose which fields can be modified by
	patron on OPAC
In-Reply-To: <bug-22187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22187-70-rq0uogjXIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22187

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I think what you want is  PatronSelfModificationBorrowerUnwantedField, which
appears to be incorrectly grouped with Self Registration preferences. Hopefully
someone can fact-check me on that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 15:43:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 14:43:28 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-noxg6dkAdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
           Keywords|                            |release-notes-needed

--- Comment #452 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

This adds Mana with default setting 'No,let me think about it' which advertises
the feature. I think before release we may want to consider a way to move this
to a yes/no, but I think it will help advertise for testing and usage before
release.

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 15:45:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 14:45:00 +0000
Subject: [Koha-bugs] [Bug 22190] New: Add column configuration to patron
 category administration
Message-ID: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

            Bug ID: 22190
           Summary: Add column configuration to patron category
                    administration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

I propose to add column configuration to the patron category administration
page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 15:54:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 14:54:52 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-P3q0UVoGoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 15:54:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 14:54:54 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-DstskcuMTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84333&action=edit
Bug 22190: Add column configuration to patron category administration

This patch adds column configuration to the table of patron categories
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Patron categoires.
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the patron categories table. Confirm that these
   changes are reflected in patron category administration.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:00:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:00:31 +0000
Subject: [Koha-bugs] [Bug 22191] New: Add column configuration to libraries
 administration
Message-ID: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

            Bug ID: 22191
           Summary: Add column configuration to libraries administration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com,
                    koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
  Target Milestone: ---

I propose to add column configuration to the libraries administration page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:13:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:13:39 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-eGz4tXDtqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add method marc() to        |Add method metadata() to
                   |Koha::Biblio                |Koha::Biblio

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:26:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:26:25 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-IxwFQYZw87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22144
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=22144                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144
[Bug 22144] Add method metadata() to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:26:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:26:25 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-RFMR5yTgzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22155
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=22155                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155
[Bug 22155] biblio_metadata.marcflavour should be renamed 'schema'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:36:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:36:01 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-3kFQ6kXRsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84334&action=edit
Bug 22191: Add column configuration to libraries administration

This patch adds column configuration to the table of libraries
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Libraries
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the libraries table. Confirm that these
   changes are reflected in libraries administration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:35:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:35:59 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-mwZWDJv0jS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:39:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:39:55 +0000
Subject: [Koha-bugs] [Bug 22187] Choose which fields can be modified by
	patron on OPAC
In-Reply-To: <bug-22187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22187-70-CGp0patU0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22187

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Oh, you're absolutely right! I didn't even check in the SelfRegistration
section since this function is not enabled in this particular instance.

Sorry about that!

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:47:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:47:58 +0000
Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on
	checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-oKusRAYtHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
            Summary|Allow arbitrary automatic   |Allow automatic update of
                   |update of location on       |location on checkin
                   |checkin                     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:49:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:49:48 +0000
Subject: [Koha-bugs] [Bug 22192] New: Patron messaging preferences: SMS
 checkbox value not displayed
Message-ID: <bug-22192-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22192

            Bug ID: 22192
           Summary: Patron messaging preferences: SMS checkbox value not
                    displayed
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: chris.kirby at ilsleypubliclibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

When SMS checkbox has been checked on  /cgi-bin/koha/members/memberentry.pl,
/cgi-bin/koha/members/moremember.pl does not display the SMS checkbox as
checked. Or perhaps it display the value fleetingly, and then the checkbox
appears to not be selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:59:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:59:32 +0000
Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports
In-Reply-To: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22193-70-V6LUoD9tqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17047
           Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:59:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:59:32 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-XzakEPgGeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22193


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193
[Bug 22193] Mana - share comments about reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 16:59:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 15:59:16 +0000
Subject: [Koha-bugs] [Bug 22193] New: Mana - share comments about reports
Message-ID: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

            Bug ID: 22193
           Summary: Mana - share comments about reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alex.arnaud at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Currently, it is possible to comment subscriptions imported from Mana. We need
to do the same for reports.
Patches coming soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:09:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:09:30 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-GjasuF2Rnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:09:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:09:19 +0000
Subject: [Koha-bugs] [Bug 22194] New: Add Koha::Exceptions::Metadata
Message-ID: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

            Bug ID: 22194
           Summary: Add Koha::Exceptions::Metadata
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

We need a base exceptions class for metadata objects. To be used in 22144

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:12:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:12:14 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-pHKm5S1DCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84335&action=edit
Bug 22194: Add Koha::Exceptions::Metadata

This trivial patch adds a basic Koha::Exceptions::Metadata exception and
Koha::Exceptions::Metadata::Invalid for using when the data cannot be
decoded (maybe because of incompatibility between format, schema, or
just bad data).

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:12:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:12:29 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-K46zRlNrBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:12:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:12:40 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-QxZpvM7ipZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144
[Bug 22144] Add method metadata() to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:12:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:12:40 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-XrPOUmLFil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22194


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194
[Bug 22194] Add Koha::Exceptions::Metadata
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:39:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:39:44 +0000
Subject: [Koha-bugs] [Bug 22195] New: Change default DataTables
 configuration to consolidate buttons
Message-ID: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

            Bug ID: 22195
           Summary: Change default DataTables configuration to consolidate
                    buttons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Created attachment 84336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84336&action=edit
Screen capture showing the new button style

DataTables gives us the option of more carefully controlling the arrangement
and appearance of buttons like "Column visibility." I propose to change the
default DataTables configuration so that tables with columns settings have two
buttons: One to trigger a menu of columns show show/hide, and one to trigger a
menu of export options. See attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:57:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:57:56 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-PhgLAjg5aj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84337&action=edit
Bug 22195: Change default DataTables configuration to consolidate buttons

This patch changes the default DataTables configuration provided by the
columns settings include file. It consolidates DataTables buttons into
to menus: One for column configuration and one for export options.

This change would not affect tables which aren't set up for column
configuration.

To test, apply the patch and view a page with columns configuration.

 Example: Tools -> Notices & slips
  - Confirm that the buttons appear as expected.
  - Confirm that each button menu performs its task correctly (column
    visiblity, export, print).
  - Test other pages with columns configuration. For instance:
    Acquisitions order search, Currencies administration, Holds queue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 17:57:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 16:57:53 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-rdNJ71nO6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 18:06:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 17:06:15 +0000
Subject: [Koha-bugs] [Bug 22196] New: Clean up Mana KB administration
	template
Message-ID: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

            Bug ID: 22196
           Summary: Clean up Mana KB administration template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

There are some markup and content corrections to be made to the Mana KB
administration template.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 18:06:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 17:06:15 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-ncrAyhmJ51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196
[Bug 22196] Clean up Mana KB administration template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 18:44:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 17:44:30 +0000
Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile
	balance for patrons
In-Reply-To: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21915-70-e0T4SKpvtt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #36 from Jesse Maseto <jesse at bywatersolutions.com> ---
Will not be in 18.05. Merge conflicts and doesn't apply cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 18:44:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 17:44:31 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-Xg9BNz1ui3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Bug 14825 depends on bug 21915, which changed state.

Bug 21915 Summary: Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:10:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:10:17 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-ccMKX6owjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:10:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:10:20 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-d9iSuWUGaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84338&action=edit
Bug 22196: Clean up Mana KB administration template

This patch makes language changes to the Mana KB administration
template, and corresponding language changes to the Web Services
preference file.

Some markup errors have been fixed:

 - Correct title and breadcrumbs, copied and pasted from another
   template
 - Add ids to form fields to match their label "for" attributes
 - Make <input>s self-closing
 - Correct class names on alert dialogs
 - Wrap text in JavaScript with _() to make it translatable

To test, apply the patch and go to Administration -> Share content with
Mana KB.

Test the process for enabling and configuring Mana KB. Check that
forms work correctly and that the language of instructions and labels
reads well.

Go to Administration -> System preferences -> Web services, and confirm
that the language changes to the Mana KB preference look good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:12:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:12:02 +0000
Subject: [Koha-bugs] [Bug 22197] New: Add Mana KB link to administration
	sidebar menu
Message-ID: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

            Bug ID: 22197
           Summary: Add Mana KB link to administration sidebar menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

There is no link to the Mana KB configuration page in the administration
sidebar menu.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:12:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:12:02 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-EKBsQeQxfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22197


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197
[Bug 22197] Add Mana KB link to administration sidebar menu
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:12:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:12:27 +0000
Subject: [Koha-bugs] [Bug 22058] OPAC holdings table shows &nbsp;
	instead of blank
In-Reply-To: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22058-70-ed6ALDfwql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #9 from Jesse Maseto <jesse at bywatersolutions.com> ---
Merge conflicts with 18.05. Will not be backported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:14:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:14:52 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
 gives no results if search terms include punctuation
In-Reply-To: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21084-70-kggwGvKDkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Merge conflicts with 18.05. Will not be backported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:15:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:15:12 +0000
Subject: [Koha-bugs] [Bug 22198] New: Add granular permission setting for
	Mana KB
Message-ID: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

            Bug ID: 22198
           Summary: Add granular permission setting for Mana KB
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 17047
  Target Milestone: ---

Mana KB should have its own permission setting


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:15:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:15:12 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-bX8zVzFZIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198
[Bug 22198] Add granular permission setting for Mana KB
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:21:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:21:45 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-axZzD3z0cy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

--- Comment #10 from Jesse Maseto <jesse at bywatersolutions.com> ---
Merge conflicts while trying to backport to 18.05. Can not be backported until
rebased to 18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:24:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:24:04 +0000
Subject: [Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
In-Reply-To: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21912-70-hE5XQvNc4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:24:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:24:24 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-DNDkx3ZT7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:24:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:24:35 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-llvR3Ug2vz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:24:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:24:48 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-e1g9wprRo6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:25:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:25:02 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-852OaL47yi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:25:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:25:11 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-PPsLCmzJkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #11 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:25:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:25:23 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-U6XKgTCXW1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:25:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:25:40 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-5Wl8bkuMxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:25:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:25:53 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-cVsDe0Bfay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:25:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:25:59 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-OvhGsDDtkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:26:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:26:07 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-J31e9dXpGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:27:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:27:16 +0000
Subject: [Koha-bugs] [Bug 21491] When 'Default lost item fee refund on
 return policy' is unset it says no but acts as if 'yes'
In-Reply-To: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21491-70-htQHRcNfxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Pushed to 18.05.x for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:43:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:43:55 +0000
Subject: [Koha-bugs] [Bug 22199] New: Planning Budget does not retain values
Message-ID: <bug-22199-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22199

            Bug ID: 22199
           Summary: Planning Budget does not retain values
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When trying to use the planning function in Acquisitions/Budgets, Koha does not
retain the values entered for month/itemtype/library, when entered either
manually, using autofill, or a combination of both.  Once figures have been
entered and save is clicked, all the figures revert to zero.  Noticed in
18.05.07 and confirmed in 18.11.00.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:53:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:53:51 +0000
Subject: [Koha-bugs] [Bug 22200] New: Forgiving a fine (FFOR) does not
 update the accountline date
Message-ID: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

            Bug ID: 22200
           Summary: Forgiving a fine (FFOR) does not update the
                    accountline date
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

Each time a fine is incremented, the date column is updated. When that fine is
forgiven ( often via the "Forgive fines" option on the checkin page ), it does
not update the column. It makes sense that if updating a fine sets the date
column, forgiving it should do so as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:57:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:57:50 +0000
Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the
 accountline date
In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22200-70-MLaaaXzoF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 23 20:57:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 19:57:53 +0000
Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the
 accountline date
In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22200-70-bgEFnWGuc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84339&action=edit
Bug 22200 - Forgiving a fine (FFOR) does not update the accountline date

Each time a fine is incremented, the date column is updated. When that fine is
forgiven ( often via the "Forgive fines" option on the checkin page ), it does
not update the column. It makes sense that if updating a fine sets the date
column, forgiving it should do so as well.

Test Plan:
1) Find a checkout that is overdue with fines, where the date is not today
2) Note the date in the accountlines table
3) Check it in, note the date is not updated
4) Apply this patch
5) Repeat steps 1-2
6) Note the date is updated!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 00:07:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 23:07:40 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-SGs6tyis38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 18.05 for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 00:18:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Jan 2019 23:18:21 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-1mGFZhCmjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 18.05 for 18.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 01:40:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 00:40:53 +0000
Subject: [Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching
 searches without the auth type
In-Reply-To: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21450-70-CZNMJTv1d7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 01:40:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 00:40:56 +0000
Subject: [Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching
 searches without the auth type
In-Reply-To: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21450-70-yPySSOJBAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79600|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84340&action=edit
Bug 21450: Unit tests

To test:
1 - Apply just this patch
2 - prove -v t/db_dependent/Linker_Default.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/Linker_Default.t
6 - It passes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 01:41:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 00:41:00 +0000
Subject: [Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching
 searches without the auth type
In-Reply-To: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21450-70-zEhxJPlbDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84341&action=edit
Bug 21450: Cache authorities search using term and auth_type

This is a simple fix to prevent incorrect caching of results when using
link_bibs_to_authorities

To test:
1 - Find or create a record with the same term in a subject and genre
heading
2 - Find or create authority records for the term as a subject and genre
type
3 - Run link bibs to authorities
4 - Verify both tags in the record are linked to the subject heading
5 - Aply patch
6 - Unlink the record and re-run the script (or just re-run)
7 - Each tag should be linked to correct authority

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 01:41:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 00:41:43 +0000
Subject: [Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching
 searches without the auth type
In-Reply-To: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21450-70-yy76AK10SE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 01:55:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 00:55:46 +0000
Subject: [Koha-bugs] [Bug 21528] Combine all reserves in a biblio hold-group
 into a single line entry
In-Reply-To: <bug-21528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21528-70-tREQN6YtuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 01:56:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 00:56:00 +0000
Subject: [Koha-bugs] [Bug 21528] Combine all reserves in a biblio hold-group
 into a single line entry
In-Reply-To: <bug-21528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21528-70-jgLFYdjv5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80443|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 04:18:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 03:18:48 +0000
Subject: [Koha-bugs] [Bug 22201] New: Spine labels are blank when exporting
	batch
Message-ID: <bug-22201-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22201

            Bug ID: 22201
           Summary: Spine labels are blank when exporting batch
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: Other
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: jamilajannac at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Created attachment 84342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84342&action=edit
Screen grab of exported labels

When exporting a batch of labels to print, the data doesn't always seem to
export properly. For spine labels, some of them are left blank, and for
barcodes there is a weird corrupted image. The attachment shows an example of
each.

I have tried exporting with all available options (pdf, csv, xml) but it seems
the data doesn't come through for any of them. I don't believe there is a
problem with the template or layout as this is happens for either barcode or
spine labels. It seems to affect random items. 

Any help would be appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 05:33:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 04:33:15 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
	implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-D8JDdI37XE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Happy for other people to work on this. This isn't really a priority for me at
the moment, although it would be a great addition to Koha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 06:03:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 05:03:34 +0000
Subject: [Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching
 searches without the auth type
In-Reply-To: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21450-70-2T7mlrOsyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 06:03:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 05:03:34 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-f2Wvwpx5hN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 06:18:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 05:18:12 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-bnHTXNdFt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 08:25:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 07:25:00 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-ZvCraFJGM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Aleihsa! Also thx Christopher for weighing in! (not just me :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 10:31:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 09:31:52 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-1rEOn12Cgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Paul Thornton <paul.thornton at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.thornton at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 11:03:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 10:03:28 +0000
Subject: [Koha-bugs] [Bug 22202] Breadcrumbs wrong in Mana admin page
In-Reply-To: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22202-70-ELN2t3FxoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22202

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17047


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 11:03:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 10:03:13 +0000
Subject: [Koha-bugs] [Bug 22202] New: Breadcrumbs wrong in Mana admin page
Message-ID: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22202

            Bug ID: 22202
           Summary: Breadcrumbs wrong in Mana admin page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The path says Home > Administration > Usage statistics, and it should say
'Mana-KB' or similar. The same for the page title.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 11:03:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 10:03:28 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-eq5XPYKQBr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22202


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22202
[Bug 22202] Breadcrumbs wrong in Mana admin page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:10:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:10:50 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-j9Sxlqt705@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:11:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:11:24 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-iWMn6mQdu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84137|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:11:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:11:27 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-m3Y1A0ByBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84205|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:12:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:12:08 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-rAoxiYj55S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84343&action=edit
Bug 22144: Add method metadata() to Koha::Biblio

It would be very convenient to be able to retrieve a bib's attached metadata
objects directly from the biblio object. This would be very useful for Template
Toolkit syntax in slips and notices where a library would like to use arbitrary
metadata fields that aren't stored in the database.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Te Rahui Tunua <terahuitunua at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:12:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:12:13 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-XyDzL2gRSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84344&action=edit
Bug 22144: (QA follow-up) Prepare the ground for other formats

This patch refactors the original implementation so it is ready for
supporting other formats. It also adds some error handling.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:12:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:12:53 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-pfdZYCjdUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:13:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:13:12 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-SrnEZQZWw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:19:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:19:10 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-E7Yu93oH6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:32:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:32:03 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-fQIEeTeIZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84346&action=edit
Bug 22144: (QA follow-up) Prepare the ground for other formats

This patch refactors the original implementation so it is ready for
supporting other formats. It also adds some error handling.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:31:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:31:46 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-SXKRHqHNjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84343|0                           |1
        is obsolete|                            |
  Attachment #84344|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84345&action=edit
Bug 22144: Add method metadata() to Koha::Biblio

It would be very convenient to be able to retrieve a bib's attached metadata
objects directly from the biblio object. This would be very useful for Template
Toolkit syntax in slips and notices where a library would like to use arbitrary
metadata fields that aren't stored in the database.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Te Rahui Tunua <terahuitunua at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:36:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:36:28 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-b8UtVJ6i1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:36:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:36:31 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-KPBb0A96rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84335|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84347&action=edit
Bug 22194: Add Koha::Exceptions::Metadata

This trivial patch adds a basic Koha::Exceptions::Metadata exception and
Koha::Exceptions::Metadata::Invalid for using when the data cannot be
decoded (maybe because of incompatibility between format, schema, or
just bad data).

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 12:44:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 11:44:55 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-CKMPZElMFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84284|0                           |1
        is obsolete|                            |

--- Comment #4 from Hugo Agud <hagud at orex.es> ---
Created attachment 84348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84348&action=edit
Bug 18909: Enable the maximum zebra records size to be specified per instance

The default for Zebra is to not return results where the record size is
greater than 1045 KB ( 1 MB ). Some libraries need to increase this
ceiling, but it may come at a cost with z39.50 compatibility with other
services. For that reason, we should make this setting configurable on a
per-instance basis.

Test plan for kohadevbox:
1) Apply this patch
2) Run:
   $ reset_all
3) Restart Zebra:
   $ sudo koha-zebra --restart kohadev
4) Check how zebrasrv was called:
   $ ps waux | grep zebrasrv
=> SUCCESS: Looks like
 ... /usr/bin/zebrasrv -v none,fatal,warn -k 1024
5) Edit /etc/koha/sites/kohadev/koha-conf.xml, add:
   <zebra_max_record_size>2048</zebra_max_record_size>
6) Repeat (3) and (4)
=> SUCCESS: Looks like
 ... /usr/bin/zebrasrv -v none,fatal,warn -k 2048
7) Sign off :-D

General test plan:
1) Apply this patch
2) Build a Debian package
3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml
4) Restart zebra
5) Index a record greater than 1 MB but smaller than 2 MB
6) Note that it is searchable!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Hugo Agud <hagud at orex.es>


 Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:39:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:39:26 +0000
Subject: [Koha-bugs] [Bug 22202] Breadcrumbs wrong in Mana admin page
In-Reply-To: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22202-70-Eu53wNWoFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22202

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 22196 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:39:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:39:26 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-VyBtpuvZj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 22202 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:42:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:42:57 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-jp7clS2D7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:44:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:44:49 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-D0IXpYxSEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:46:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:46:33 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-BlRv1F4kni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:46:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:46:35 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-ZxrdSeiEYb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84347|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84349&action=edit
Bug 22194: Add Koha::Exceptions::Metadata

This trivial patch adds a basic Koha::Exceptions::Metadata exception and
Koha::Exceptions::Metadata::Invalid for using when the data cannot be
decoded (maybe because of incompatibility between format, schema, or
just bad data).

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 13:46:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 12:46:43 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-kP43dEvTLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:02:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:02:53 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-uXRzHMuqpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:03:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:03:01 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-5u3w1n27s8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84346|0                           |1
        is obsolete|                            |

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84351&action=edit
Bug 22144: (QA follow-up) Prepare the ground for other formats

This patch refactors the original implementation so it is ready for
supporting other formats. It also adds some error handling.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:02:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:02:57 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-EpDvbnFo67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84345|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84350&action=edit
Bug 22144: Add method metadata() to Koha::Biblio

It would be very convenient to be able to retrieve a bib's attached metadata
objects directly from the biblio object. This would be very useful for Template
Toolkit syntax in slips and notices where a library would like to use arbitrary
metadata fields that aren't stored in the database.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Te Rahui Tunua <terahuitunua at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:03:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:03:31 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-DcWOwZMEo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:09:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:09:07 +0000
Subject: [Koha-bugs] [Bug 20705] In subscription,
 subscription length type "month" do not show right number of issues
 on prediction pattern
In-Reply-To: <bug-20705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20705-70-QrrMP5rBxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20705

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
I think this might be a duplicate of bug 15148

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:27:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:27:01 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-Tbv3OCjV2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:27:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:27:55 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-wONvCPAnyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22197


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197
[Bug 22197] Add Mana KB link to administration sidebar menu
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 14:27:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 13:27:55 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-ATRoKHZ9nZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198
[Bug 22198] Add granular permission setting for Mana KB
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:24:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:24:59 +0000
Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21845-70-v8pjfbm2k8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:25:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:25:51 +0000
Subject: [Koha-bugs] [Bug 21826] Automatic authority record generation
	improvements
In-Reply-To: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21826-70-G5Dtlxz5Dc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Erm.. I can't get Biblio.t to fail here.. any further guidance on getting it to
fail Nick?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:43:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:43:00 +0000
Subject: [Koha-bugs] [Bug 21826] Automatic authority record generation
	improvements
In-Reply-To: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21826-70-5bHG0bxoLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #46 from Nick Clemens <nick at bywatersolutions.com> ---
Tests all pass for me now, not sure what was happening

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:48:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:48:46 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-4oxZoEmMqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com,
                   |                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:49:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:49:19 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-FiV5zbq3gM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add Basic authentication    |Add Basic authentication to
                   |                            |the REST API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:49:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:49:49 +0000
Subject: [Koha-bugs] [Bug 22071] authenticate_api_request does not stash
 koha.user in the OAuth use case
In-Reply-To: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22071-70-F2BqjMEn64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22132


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132
[Bug 22132] Add Basic authentication to the REST API
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:49:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:49:49 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-knHOKDTcli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22071


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071
[Bug 22071] authenticate_api_request does not stash koha.user in the OAuth use
case
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:52:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:52:42 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-J1art01GMK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:56:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:56:01 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-vDhh60WSvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:56:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:56:04 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-akMsN9yDq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84338|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84352&action=edit
Bug 22196: Clean up Mana KB administration template

This patch makes language changes to the Mana KB administration
template, and corresponding language changes to the Web Services
preference file.

Some markup errors have been fixed:

 - Correct title and breadcrumbs, copied and pasted from another
   template
 - Add ids to form fields to match their label "for" attributes
 - Make <input>s self-closing
 - Correct class names on alert dialogs
 - Wrap text in JavaScript with _() to make it translatable

To test, apply the patch and go to Administration -> Share content with
Mana KB.

Test the process for enabling and configuring Mana KB. Check that
forms work correctly and that the language of instructions and labels
reads well.

Go to Administration -> System preferences -> Web services, and confirm
that the language changes to the Mana KB preference look good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:59:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:59:25 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-Dih4a4y9of@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:59:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:59:28 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-Fmfrnktext@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83993|0                           |1
        is obsolete|                            |
  Attachment #83994|0                           |1
        is obsolete|                            |
  Attachment #83995|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84353&action=edit
Bug 22132: Add RESTBasicAuth syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:59:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:59:40 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-cn5hV7Xnxy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198
[Bug 22198] Add granular permission setting for Mana KB
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:59:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:59:40 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-N5Gylz9Iik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196
[Bug 22196] Clean up Mana KB administration template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:59:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:59:41 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-fXJ8zrgtpj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84354&action=edit
Bug 22132: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 15:59:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 14:59:45 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-ZSeGnsocQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84355&action=edit
Bug 22132: Add Basic authentication to the API

This patch implements Basic authentication for the API to aid testers
and developers with tools like Postman.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_basic.t
=> SUCCESS: Tests pass!
- Open Postman or your favourite tool
- In Authorization, choose Basic auth.
- Enter the username and password of a known privileged user.
- Hit an endpoint with Postman, for example:
  ] GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons
=> SUCCESS: Basic authentication is great!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:03:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:03:18 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-8WWMjumxyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:03:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:03:20 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-cQMDE51btr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84356&action=edit
Bug 22198: Add granular permission setting for Mana KB

This patch adds a separate permission for managing Mana KB.

To test, apply the patch and update the database.

 - Open the permissions page for a patron with staff client privileges
   - Confirm that there is a "Manage Mana KB content sharing
     (manage_mana)" permission.
   - Leaving this new permission unchecked, log into the staff client
     with as that patron and go to the Administration home page.
       - The "Using Mana-KB" link should not appear.
       - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You
         should get a "permission denied" message.
   - Modify the patron's permissions to grant them access to Mana KB.
       - Confirm that the link now appears on the Administration home
         page and that the user can access the page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:05:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:05:20 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-JDxZM9Vo7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:05:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:05:28 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-SXP01z2tIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84356|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:09:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:09:45 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-RXJ0JoPnH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:09:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:09:54 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-I0PnEUHWPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84352|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:43:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:43:51 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-c4pfOVwQQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:43:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:43:54 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-TyZkXhHspq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84357&action=edit
Bug 22196: Clean up Mana KB administration template

This patch makes language changes to the Mana KB administration
template, and corresponding language changes to the Web Services
preference file.

Some markup errors have been fixed:

 - Correct title and breadcrumbs, copied and pasted from another
   template
 - Add ids to form fields to match their label "for" attributes
 - Make <input>s self-closing
 - Correct class names on alert dialogs
 - Wrap text in JavaScript with _() to make it translatable

Also changed: Some language revisions to the Mana dialogs on the
Administration home page.

To test, apply the patch and go to Administration -> Share content with
Mana KB.

Test the process for enabling and configuring Mana KB. Check that
forms work correctly and that the language of instructions and labels
reads well.

Go to Administration -> System preferences -> Web services, and confirm
that the language changes to the Mana KB preference look good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:47:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:47:46 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-hWBWCSE9UW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84358&action=edit
Bug 22198: Add granular permission setting for Mana KB

This patch adds a separate permission for managing Mana KB.

To test, apply the patch and update the database.

 - Open the permissions page for a patron with staff client privileges
   - Confirm that there is a "Manage Mana KB content sharing
     (manage_mana)" permission.
   - Leaving this new permission unchecked, log into the staff client
     with as that patron and go to the Administration home page.
       - The "Using Mana-KB" link should not appear.
       - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You
         should get a "permission denied" message.
   - Modify the patron's permissions to grant them access to Mana KB.
       - Confirm that the link now appears on the Administration home
         page and that the user can access the page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:47:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:47:43 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-CVMLYCgCzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:50:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:50:00 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-F4hSjhheo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84359&action=edit
Bug 22197: Add Mana KB link to administration sidebar menu

This patch adds a link to the Mana KB configuration page to the
administration sidebar menu.

To test, apply the patch and:

 - Log in to the staff client as a user who lacks permission to manage
   Mana KB.
   - Go to an Administration page which shows the sidebar, like
     Libraries or Patron categories. There should be no link to Mana KB
     in the left-hand sidebar.
 - Log in to the staff client as a user who has permission to manage
   Mana KB.
   - Go to Administration -> Mana KB
     - In the sidebar menu you should see a link to Mana KB and it
       should be bold.
   - Navigate to another Administration page which shows the sidebar.
     The Mana KB link should not be highlighted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:49:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:49:57 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-tEt1OWitZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:53:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:53:00 +0000
Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21845-70-Rmd1MDlLtS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976
[Bug 11976] Add column settings + new column "Publication date" to the
subscription table
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 16:53:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 15:53:00 +0000
Subject: [Koha-bugs] [Bug 11976] Add column settings + new column
 "Publication date" to the subscription table
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-VLuG2wF24U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21845


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845
[Bug 21845] Sort of issues in OPAC subscription table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:11:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:11:40 +0000
Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21845-70-lb8KYVKtk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
            Version|18.05                       |master

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
It looks to me like the sorting of the table changed arbitrarily--DataTables
sorts by the first column by default if no sorting option is set. This overrode
the sorting of the data passed by the script (publisheddate). So, a regression
of sorts. heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:20:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:20:05 +0000
Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21845-70-66LQOBKe11@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:20:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:20:09 +0000
Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21845-70-BSinYQJ2NA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84360&action=edit
Bug 21845: Sort of issues in OPAC subscription table

This patch adds a default sort option to the table of subscriptions on
the OPAC detail page. This sorting option matches the sort of data
passed from GetLatestSerials.

To test, apply the patch and locate a subscription in the OPAC which has
multiple issues. They should be sorted by default on publication date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:26:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:26:14 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-T2d2GcAwQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #27 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
@Jos?-Mario The patch "(Alternate Solution) Block form submission" is obsolete
right? The previous functional discussion points toward using "Change dot into
comma" if I understand correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:35:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:35:55 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-WkVdwWCqpX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84361&action=edit
Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth

Mojolicious has built in handling for encoding/decoding of of basic auth
paramenters. We should use it to simplify our test here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:37:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:37:05 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-dUdvBT5ztQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84353|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84362&action=edit
Bug 22132: Add RESTBasicAuth syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:37:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:37:09 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-KOvO0Xm6RW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84354|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84363&action=edit
Bug 22132: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:37:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:37:13 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-DegSt0DcWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84355|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84364&action=edit
Bug 22132: Add Basic authentication to the API

This patch implements Basic authentication for the API to aid testers
and developers with tools like Postman.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_basic.t
=> SUCCESS: Tests pass!
- Open Postman or your favourite tool
- In Authorization, choose Basic auth.
- Enter the username and password of a known privileged user.
- Hit an endpoint with Postman, for example:
  ] GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons
=> SUCCESS: Basic authentication is great!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:37:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:37:16 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-5JjbkU4Q1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84361|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84365&action=edit
Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth

Mojolicious has built in handling for encoding/decoding of of basic auth
paramenters. We should use it to simplify our test here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:38:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:38:23 +0000
Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports
In-Reply-To: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22193-70-Lm6hqe4xE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84366&action=edit
Bug 22193: Code refactoring/improvments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:38:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:38:29 +0000
Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports
In-Reply-To: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22193-70-XtCbEmUrP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

--- Comment #2 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 84367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84367&action=edit
Bug 22193: Share report comments

Test plan:
  - apply this patches,
  - download a report from Mana,
  - you should see a "Report mistake" button when you show, edit and run
    this report,
  - click on Report mistake -> New and type a comment,
  - check that it appears on the list,
  - reload the page, check the comment is still in the list,
  - click on Report mistake -> your comment,
  - ckeck the count has been incremented,
  - reload the page, the counter is still the same

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:38:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:38:16 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-4QSsJfzu7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works for me and seems like sane and sensible code.

I've added a QA follow-up with a little code golf on the tests, I'll let the RM
decide whether it's worthwhile or not keeping that final patch.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:38:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:38:50 +0000
Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports
In-Reply-To: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22193-70-RX0Si3bHew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:41:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:41:25 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-bImQYSN68O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84365|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84368&action=edit
Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth

Mojolicious has built in handling for encoding/decoding of of basic auth
paramenters. We should use it to simplify our test here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:42:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:42:43 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-sifqmounLc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #15)
> All works for me and seems like sane and sensible code.
> 
> I've added a QA follow-up with a little code golf on the tests, I'll let the
> RM decide whether it's worthwhile or not keeping that final patch.
> 
> Passing QA

Thanks!! I like the changes! I will adopt that style myself

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:43:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:43:13 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-HcPgiIQ48l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84368|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84369&action=edit
Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth

Mojolicious has built in handling for encoding/decoding of of basic auth
paramenters. We should use it to simplify our test here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:47:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:47:59 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-L9bSpqtM0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:48:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:48:28 +0000
Subject: [Koha-bugs] [Bug 22203] New: Holds modal no longer links to patron
Message-ID: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

            Bug ID: 22203
           Summary: Holds modal no longer links to patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: nick at bywatersolutions.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

To recreate:
1 - Place a hold for a patron
2 - Check the item in at the pickup location
3 - Note the holds modal does not link to patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:48:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:48:37 +0000
Subject: [Koha-bugs] [Bug 22204] New: Leading spaces in barcode should not
 allowed in cataloguing
Message-ID: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

            Bug ID: 22204
           Summary: Leading spaces in barcode should not allowed in
                    cataloguing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

When creating a new item, it is not allowed to add trailing spaces, it shows
'Barcode must be unique'.
But it is allowed to use leading spaces :(
In this case since circulation does a trim on barcode this item can not be
checked-out.
It also allows duplicates even with UNIQUE KEY constraint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:49:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:49:03 +0000
Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
 allowed in cataloguing
In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22204-70-mVfVTdDLtQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:49:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:49:14 +0000
Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
 allowed in cataloguing
In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22204-70-cbbs8vUjRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=1626

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:49:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:49:14 +0000
Subject: [Koha-bugs] [Bug 1626] Trim whitespace from barcode inputs
In-Reply-To: <bug-1626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1626-70-oN8HgpL1L7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1626

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22204

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:50:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:50:23 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-KBLAzka19G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 84370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84370&action=edit
Bug 22203: Holds modal does not link to patorn account

To test:
1 - Place a hold for a patron
2 - Check the item in at the pickup location
3 - Note the holds modal does not link to patron
4 - Apply patch
5 - Check in item again
6 - Patron name in modal is a link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:50:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:50:20 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-cjhHAnfKJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:50:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:50:42 +0000
Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates
In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18789-70-MrPtId4wHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22203


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203
[Bug 22203] Holds modal no longer links to patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:50:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:50:42 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-WkgIU6bAFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18789


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789
[Bug 18789] Send a Koha::Patron object to the templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 17:57:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 16:57:58 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-Njz9qzQwLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry, quite confused here by now :( 

I'll try to test myself, but not sure when time will allow. If someone knows
right away, what would be the expected behaviour for entering the actual price
on receive and CurrencyFormat CH with the patch? Will it expect 10.00 or 10,00?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:00:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:00:43 +0000
Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
 allowed in cataloguing
In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22204-70-VuxJkIzsRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:02:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:02:06 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-TMT5JLpIlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84369|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84371&action=edit
Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth

Mojolicious has built in handling for encoding/decoding of of basic auth
paramenters. We should use it to simplify our test here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:05:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:05:35 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-Nkr01qXUGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The followup also happens to clarify why this addition is a good thing.. it
should make writing tests simpler as it requires less scaffolding for
authenticated api tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:06:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:06:19 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-pAa7tbJyU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #29 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
> I'll try to test myself, but not sure when time will allow.

Don't worry, that's quite quick. It took me less than 10 min to test with the 3
syspref values. Including some time to get lost due to fall into some traps due
to not knowing well this part of acq.

> what would be the expected behaviour for entering the actual price on receive and CurrencyFormat CH with the patch? Will it expect 10.00 or 10,00?

Both! It depend on what the user expects :)
input 10.00 => 10.00
input 10,00 => 1000 (treated a thousands sep and discarded)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:15:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:15:22 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must raised an exception if
 called with dateformat => rfc3339 and > dateonly => 1
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-hPbEAAHUBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
             Status|CLOSED                      |REOPENED
         Resolution|INVALID                     |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:15:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:15:31 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must raised an exception if
 called with dateformat => rfc3339 and > dateonly => 1
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-c5Z9FLj7na@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:18:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:18:34 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-PyulVLmJcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84150|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:21:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:21:12 +0000
Subject: [Koha-bugs] [Bug 22205] New: Software Error on basket deletion with
 bib number in more than one aqorders line
Message-ID: <bug-22205-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22205

            Bug ID: 22205
           Summary: Software Error on basket deletion with bib number in
                    more than one aqorders line
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

To test:
- Create a basket
- Add an order to the basket
- Add a second order for the same bib number
- Delete the basket, selecting "Delete Basket, Orders, and Records"
- Receive error "Can't call method "subscriptions" on an undefined value at
/usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 137"

Looks like Koha deletes the bib when deleting the first aqorders line and then
tried to delete it again when deleting the second aqorders line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:22:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:22:55 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must raised an exception if
 called with dateformat => rfc3339 and > dateonly => 1
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-8XtTgl48dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
OpenAPI specifies a format for date-only formatted strings (1). It basically
specifies that for 'date' format, the 'full-date' profile needs to be used [2]

Reopening.

[1]
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dataTypeFormat

[2] https://tools.ietf.org/html/rfc3339#section-5.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:23:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:23:37 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-QsJyvIDcwR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|output_pref must raised an  |output_pref must implement
                   |exception if called with    |'dateonly' for dateformat
                   |dateformat => rfc3339 and > |=> rfc3339
                   |dateonly => 1               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:23:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:23:50 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-esKy6YRkbb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:23:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:23:52 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-zoSrYzfkIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #30 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
@Victor the patch is indeed obsolete, I simply forgot to mark it as such.

@Katrin As Victor said, in CH format, 10,00 would be treated as 1000 since
commas are thousand separators. I do not think anybody using CH would expect
10,00 to be treated as 10.00 due to commas having a different meaning in that
format, but I could be wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:24:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:24:03 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-zqkdsS4GZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:35:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:35:25 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-wwQK1fzVnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84372&action=edit
Bug 19816: Regression tests

This patch adds tests for the rfc3339 behaviour when dateonly => 1.

To test:
- Run:
  $ kshell
 k$ prove t/DateUtils.t
=> SUCCESS: Tests pass
- Apply this patch
- Run:
 k$ prove t/DateUtils.t
=> FAIL: dateonly is not implemented

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:35:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:35:28 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-eLMXtCr4xf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84373&action=edit
Bug 19816: Implement dateonly for rfc3339 format

This patch implements the dateonly option for the rfc3339. This is
described in the OpenAPI 2.0 specification [1]. The required output
format is described on RFC 3339 [2], as 'full-date'.

[1]
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dataTypeFormat
[2] https://tools.ietf.org/html/rfc3339#section-5.6

To test:
- Apply the regression tests patch
- Run:
 k$ prove t/DateUtils.t
=> FAIL: Tests fail because dateonly is not implemented
- Apply this patch
- Run:
 k$ prove t/DateUtils.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:35:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:35:44 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-MYstGrzJyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:57:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:57:10 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-0Dpoelrc4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19816


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816
[Bug 19816] output_pref must implement 'dateonly' for dateformat => rfc3339
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:57:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:57:10 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-BjX4QLLQCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006
[Bug 20006] Adapt /v1/holds to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:57:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:57:39 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-sGLKfArM0t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84374&action=edit
Bug 20006: Spec changes

This patch makes the spec match the voted RFC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:57:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:57:43 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-nadbFHQ8ro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84375&action=edit
Bug 20006: Unit tests fixes

This patch makes the holds endpoint tests pass and expect data structures that
match the voted RFC.

As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:57:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:57:46 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-62ayUuuEBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84376&action=edit
But 20006: Adapt /holds to the RFC

This patch makes the /holds endpoint respect the voted RFC. Some
behaviours are changed as well:

- As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.

- GET /holds now uses the objects->search helper, so it now has
pagination.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:58:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:58:11 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-u3872H6Ngd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 18:58:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 17:58:55 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-vRWruijAet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
TODO: Still need to adjust the holds page to use the new aPI spec.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:05:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:05:19 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-MYancTHk5I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68388|0                           |1
        is obsolete|                            |
  Attachment #68389|0                           |1
        is obsolete|                            |
  Attachment #71978|0                           |1
        is obsolete|                            |

--- Comment #11 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84377&action=edit
Rebased on current master.

Signed-off-by: Hugo Agud <hagud at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:09:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:09:50 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-cGbUdU6UdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

--- Comment #12 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84378&action=edit
Bug 19376 - Adds 655$a to Zebra facets

Rebased on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:10:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:10:33 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-FhoOfKn7BW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

--- Comment #13 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84379&action=edit
Bug 19376 - Follow-up on QA

Reverted useless/bad modifications.

Signed-off-by: Hugo Agud <hagud at orex.es>

Signed-off-by: Hugo Agud <hagud at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:10:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:10:50 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-5BfcHLWH32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

--- Comment #14 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84380&action=edit
Bug 19376 - Keep 655 in the general Subject index

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:22:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:22:25 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-lRcHQg98qA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84376|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84381&action=edit
Bug 20006: Adapt /holds to the RFC

This patch makes the /holds endpoint respect the voted RFC. Some
behaviours are changed as well:

- As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.

- GET /holds now uses the objects->search helper, so it now has
pagination.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:22:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:22:30 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-yUZIL5fPUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84382&action=edit
Bug 20006: (follow-up) Fix holds.js

This patch makes holds.js call the endpoint with 'pickup_library_id'
instead of the old 'branchcode' property.

To test:
- Place a hold
- Go to the patron's detail page
- Go to the Holds tab
- Change the pickup location
=> SUCCESS: It works!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:30:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:30:29 +0000
Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
In-Reply-To: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1993-70-2EQHyGI7u8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:30:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:30:32 +0000
Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically
In-Reply-To: <bug-3935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3935-70-otAYvjMKSV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:30:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:30:46 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-fQCNzmCREY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84377|0                           |1
        is obsolete|                            |
  Attachment #84378|0                           |1
        is obsolete|                            |
  Attachment #84379|0                           |1
        is obsolete|                            |
  Attachment #84380|0                           |1
        is obsolete|                            |

--- Comment #15 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84383&action=edit
Bug 19376 - Adds 655$a to Zebra facets

Test plan:
0) Apply patch
1) Depending on your setup, copy the content of the following files to their
counterparts in /etc/ (or where your Koha configuration files are) :
<git>/etc/zebradb/biblios/etc/bib1.att
<git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
<git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xsl
<git>/etc/zebradb/marc_defs/marc21/biblios/record.abs
<git>/etc/zebradb/ccl.properties

2) Edit a record to use the 655$a MARC tag, if you don't already
3) In the OPAC or Intranet, execute a search that would get a hit on the record
you edited.
> You should see the "Genre form" filter appear on the left
4) Click on the entry under "Genre form"
> You should now only see the records with the matching 655$a tag.

Signed-off-by: Hugo Agud <hagud at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:31:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:31:05 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-lMWlXvl8gN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

--- Comment #16 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84384&action=edit
Bug 19376 - Follow-up on QA

Reverted useless/bad modifications.

Signed-off-by: Hugo Agud <hagud at orex.es>

Signed-off-by: Hugo Agud <hagud at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 19:31:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 18:31:22 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
	facets
In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19376-70-O07MRm65bs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

--- Comment #17 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84385&action=edit
Bug 19376 - Keep 655 in the general Subject index

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:13:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:13:46 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-CC6IHuyMxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84386&action=edit
Bug 20006: (follow-up) Plural class name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:18:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:18:58 +0000
Subject: [Koha-bugs] [Bug 22206] New: Add route to handle holds suspensions
Message-ID: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

            Bug ID: 22206
           Summary: Add route to handle holds suspensions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:20:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:20:26 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-MD8K3ueU5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://wiki.koha-community
                   |                            |.org/wiki/Holds_suspension_
                   |                            |endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:26:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:26:14 +0000
Subject: [Koha-bugs] [Bug 21034] Re-indent circulation.tt
In-Reply-To: <bug-21034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21034-70-ldaJfUHSJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78267|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84387&action=edit
Bug 21034: Re-indent circulation.tt

This patch reindents the template for the checkout page, circulation.tt:

- Trailing spaces removed
- Indentation changed to a consistent 4 spaces
- Markup indentation made more consistent

To test, view the checkout page under various circumstances:

- No card number submitted
- Name submitted (patron search results)
- Card number submitted
  - Restricted patron
  - Patron with circulation messages
  - On-site checkouts
  - Check all tabs: checkouts, relatives' checkouts holds, article
    requests, restrictions, clubs

HTML validation before and after the patch should return the same
results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:26:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:26:32 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-c68gaQqecT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006
[Bug 20006] Adapt /v1/holds to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:26:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:26:32 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-opgGjwfbNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206
[Bug 22206] Add route to handle holds suspensions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:26:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:26:11 +0000
Subject: [Koha-bugs] [Bug 21034] Re-indent circulation.tt
In-Reply-To: <bug-21034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21034-70-MTsuBxe04h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:29:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:29:54 +0000
Subject: [Koha-bugs] [Bug 14090] Add link to basket from invoice and vice
	versa
In-Reply-To: <bug-14090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14090-70-sRe1QK1gWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14090

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:33:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:33:38 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
	records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-wdDnE42ojv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81385|0                           |1
        is obsolete|                            |

--- Comment #29 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84388&action=edit
Bug 17385: Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
    * The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found Simple Export.
  - Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
https://bugs.koha-community.org/show_bug.cgi?id=17835

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:35:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:35:17 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
	records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-WKFFr0NdAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84388|0                           |1
        is obsolete|                            |

--- Comment #30 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84389&action=edit
Bug 17385: Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
    * The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found Simple Export.
  - Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
https://bugs.koha-community.org/show_bug.cgi?id=17835

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:35:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:35:30 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
	records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-sCnPtl3mpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81386|0                           |1
        is obsolete|                            |

--- Comment #31 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84390&action=edit
Bug 17385: Add tests for CustomXSLTExportList

+ Added tests for CustomXSLTExportList to C4::XSLT
+ Added an eval block in CustomXSLTExportList to handle invalid XML.

* Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent

+ Added "Custom" option to OPACExportOptions preference.

Tested with invalid XML (not originally on purpose, but...) and then
added a new field to add to the simple export.

Walked through the testing steps.

Question: should this also apply to the cataloging page as an export
option? It doesn't now.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:37:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:37:50 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
	records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-gJg1LAmAky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |mikael.olangcay-brisebois at i
                   |                            |nLibro.com

--- Comment #32 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Rebased on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:42:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:42:23 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-SF4GXL0Ukt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:53:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:53:02 +0000
Subject: [Koha-bugs] [Bug 18333] Removal of SQL queries from
	admin/systempreferences.sql
In-Reply-To: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18333-70-PmMqK4OmWN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18333

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |LATER

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
I will try to get to this in the future if I get a bit more time available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:54:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:54:24 +0000
Subject: [Koha-bugs] [Bug 18334] Removal of SQL code from
	admin/smart-rules.pl
In-Reply-To: <bug-18334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18334-70-2tq2ZrgvqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18334

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |LATER
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
I will try to get this in the future if I get more available time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:56:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:56:55 +0000
Subject: [Koha-bugs] [Bug 18333] Removal of SQL queries from
	admin/systempreferences.sql
In-Reply-To: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18333-70-9TXiuG8yoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18333

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|LATER                       |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:57:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:57:01 +0000
Subject: [Koha-bugs] [Bug 18333] Removal of SQL queries from
	admin/systempreferences.sql
In-Reply-To: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18333-70-DE9d0HBpq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18333

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:57:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:57:23 +0000
Subject: [Koha-bugs] [Bug 18333] Removal of SQL queries from
	admin/systempreferences.sql
In-Reply-To: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18333-70-9r04D0XXbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18333

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I'm putting this back to "NEW" in case someone else might want to pick it up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:57:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:57:35 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-bUWUOd6CZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:57:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:57:38 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-pQC6qMQhI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84337|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 84391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84391&action=edit
Bug 22195: Change default DataTables configuration to consolidate buttons

This patch changes the default DataTables configuration provided by the
columns settings include file. It consolidates DataTables buttons into
to menus: One for column configuration and one for export options.

This change would not affect tables which aren't set up for column
configuration.

To test, apply the patch and view a page with columns configuration.

 Example: Tools -> Notices & slips
  - Confirm that the buttons appear as expected.
  - Confirm that each button menu performs its task correctly (column
    visiblity, export, print).
  - Test other pages with columns configuration. For instance:
    Acquisitions order search, Currencies administration, Holds queue

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 20:59:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 19:59:09 +0000
Subject: [Koha-bugs] [Bug 18333] Removal of SQL queries from
	admin/systempreferences.sql
In-Reply-To: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18333-70-T9P3x5g2eS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18333

--- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 21:00:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 20:00:22 +0000
Subject: [Koha-bugs] [Bug 18333] Removal of SQL queries from
	admin/systempreferences.sql
In-Reply-To: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18333-70-gtUs6ALW3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18333

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 21:12:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 20:12:13 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-SqIKLHYF9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 21:12:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 20:12:16 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-NzGhivTYr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84392&action=edit
Bug 21449: Update two-column templates with Bootstrap grid: Circulation part 2

This patch modifies several circulation templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths. For each page, test with
the CircSidebar preference both on and off.

 - Catalog -> Search -> Details -> Items -> View item's checkout history
 - Circulation -> Overdues with fines
 - Circulation -> Transfer
 - Circulation -> Patron -> Batch checkout
 - Circulation -> Built-in offline circulation interface
   - Synchronize
   - Pending offline circulation actions
   - Check out
   - Check in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 24 22:05:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 21:05:21 +0000
Subject: [Koha-bugs] [Bug 13626] Permission for "forgive fines on return"
In-Reply-To: <bug-13626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13626-70-xcYZukN3vu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13626

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> ---
It has been brought to my attention that if a staff member does not have fines
permissions- they will not see the Forgive Fines on Return.  If neither Fines
permissions are check marked, they will not see the Forgive Fines on Return
from the circulation.pl.

If the staff member has "Remaining permissions for managing fines and fees"
check marked, they also will not see the Forgive fines on return from
circulation.pl.

If they have "Write off Fines/Fees" - Forgive Fines on Return will display at
circulation.pl.


So I believe this bug has been resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 00:42:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Jan 2019 23:42:53 +0000
Subject: [Koha-bugs] [Bug 22207] New: course reserves page does not have
	unique <body> id
Message-ID: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

            Bug ID: 22207
           Summary: course reserves page does not have unique <body> id
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The course reserve <body> id is "opac-main". This is problematic when trying to
use unique CSS or jQuery selectors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 05:25:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 04:25:55 +0000
Subject: [Koha-bugs] [Bug 22208] New: Advance Search is not working
Message-ID: <bug-22208-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22208

            Bug ID: 22208
           Summary: Advance Search is not working
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: schulzezekiel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 05:26:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 04:26:10 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-AYv9HxIqge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
In 2019, I'm still having librarians getting in touch over irate patrons
getting misleading notifications.

And now it's not just holds. It's also notifications about reaching the limit
of renewals, even though they won't need to autorenew for another 3 weeks. 

It seems like most people aren't affected by the problems with how autornewals
works because they don't have notices set up, but the people who do get notices
are plagued by notices that don't make sense.

I think it's clear that we need to do "something".

But how do we reconcile the people who like the current functionality and the
people who hate the current functionality?

Looking at Jonathan's patch, it doesn't go far enough. 

Maybe the easiest thing to do is refactor CanBookBeRenewed to have the
"auto_too_soon" code put into a function... and then add that function wrapped
in a system preference in automatic_renewals.pl, so that people can toggle
between the preferred behaviours.

I don't like it... I think everyone should agree with me about what I think is
logical (hahahaha), but that might be the most feasible path forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 07:28:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 06:28:36 +0000
Subject: [Koha-bugs] [Bug 22208] Advance Search is not working
In-Reply-To: <bug-22208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22208-70-fF5McyPbOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22208

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi bunny, I am sorry, but this bug title is too general to help you. If you
have problems searching, please ask on the mailing list first. Please include
details about your setup (version, how it was installed), what's not working
and what you've already tried to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 07:46:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 06:46:33 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on
	receive
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-n1TkOssbHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jos?-Mario Monteiro-Santos from comment #30)
> @Victor the patch is indeed obsolete, I simply forgot to mark it as such.
> 
> @Katrin As Victor said, in CH format, 10,00 would be treated as 1000 since
> commas are thousand separators. I do not think anybody using CH would expect
> 10,00 to be treated as 10.00 due to commas having a different meaning in
> that format, but I could be wrong.

Still confused, but the test plan reads well (too tired from travelling) I will
try to have  a look during the weekend!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 07:47:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 06:47:43 +0000
Subject: [Koha-bugs] [Bug 13626] Permission for "forgive fines on return"
In-Reply-To: <bug-13626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13626-70-mer6VvUcBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13626

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 08:50:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 07:50:29 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-Zbbmk1HWCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 08:50:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 07:50:36 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-qEvmoE073n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84394&action=edit
Bug 19816: Implement dateonly for rfc3339 format

This patch implements the dateonly option for the rfc3339. This is
described in the OpenAPI 2.0 specification [1]. The required output
format is described on RFC 3339 [2], as 'full-date'.

[1]
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dataTypeFormat
[2] https://tools.ietf.org/html/rfc3339#section-5.6

To test:
- Apply the regression tests patch
- Run:
 k$ prove t/DateUtils.t
=> FAIL: Tests fail because dateonly is not implemented
- Apply this patch
- Run:
 k$ prove t/DateUtils.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 08:50:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 07:50:32 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-2mCcg8p3fk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84372|0                           |1
        is obsolete|                            |
  Attachment #84373|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84393&action=edit
Bug 19816: Regression tests

This patch adds tests for the rfc3339 behaviour when dateonly => 1.

To test:
- Run:
  $ kshell
 k$ prove t/DateUtils.t
=> SUCCESS: Tests pass
- Apply this patch
- Run:
 k$ prove t/DateUtils.t
=> FAIL: dateonly is not implemented

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 09:39:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 08:39:29 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-b1NHmwwqMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84374|0                           |1
        is obsolete|                            |
  Attachment #84375|0                           |1
        is obsolete|                            |
  Attachment #84381|0                           |1
        is obsolete|                            |
  Attachment #84382|0                           |1
        is obsolete|                            |
  Attachment #84386|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84395&action=edit
Bug 20006: Spec changes

This patch makes the spec match the voted RFC.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 09:39:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 08:39:32 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-2e54TnMIoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84396&action=edit
Bug 20006: Unit tests fixes

This patch makes the holds endpoint tests pass and expect data structures that
match the voted RFC.

As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 09:39:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 08:39:36 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-rzd1gWIuFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84397&action=edit
Bug 20006: Adapt /holds to the RFC

This patch makes the /holds endpoint respect the voted RFC. Some
behaviours are changed as well:

- As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.

- GET /holds now uses the objects->search helper, so it now has
pagination.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 09:39:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 08:39:39 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-gVCX76VkM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84398&action=edit
Bug 20006: (follow-up) Fix holds.js

This patch makes holds.js call the endpoint with 'pickup_library_id'
instead of the old 'branchcode' property.

To test:
- Place a hold
- Go to the patron's detail page
- Go to the Holds tab
- Change the pickup location
=> SUCCESS: It works!

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 09:39:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 08:39:42 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-XZM7wFtEzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84399&action=edit
Bug 20006: (follow-up) Plural class name

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 09:39:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 08:39:26 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-e8NqJG1hsP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 10:11:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 09:11:33 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
	but not if renewed
In-Reply-To: <bug-9805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9805-70-NwKpnSY8A4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

SiobhanC <siobhancottam at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |siobhancottam at gmail.com

--- Comment #54 from SiobhanC <siobhancottam at gmail.com> ---
I'd also be interested in an update on this - we are using
DefaultLongOverdueLostValue to automatically update item status. We allow
renewal of these items, in the staff client and OPAC, but when items are
renewed, the lost status remains which means that fines are not applied and
overdue notices are not sent. There is talk of a system pref for removing lost
status when items renewed - will this be in a future release?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 10:29:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 09:29:28 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-R1TxXORExH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #68 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The ...AV.pl catalouging plugins are based on a counter in an authorised value.
The original catalouging plugin is used for generating stocknumbers, but could
also be adapted to be used for generating numerus currens callnumbers.

This has the advantage that even with more than one person catalouging at the
same time, the number is only generated/used once. The downside is that when
you have used a number but not save the record/item, the number is lost unused.

I believe other catalouging plugins use the approach to look for the
max(stocknumber or similar) with SQL and creating the next number from there.
Advantage: Every number will be used, disadvantage: the number could be used
multiple times. 

I can send you the file for the 001-plugin we use - but I think I really only
adapted the SQL statement of stocknumberAV.pl a bit.

This might also be interesting for you (new in 18.11): bug 19263

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:16:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:16:00 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-WBMK3I7xxC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20770

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:22:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:22:53 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-zG8oRpvkxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #220 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 84400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84400&action=edit
Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:23:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:23:43 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-F0O7THsOlC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84400|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:31:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:31:45 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-P0nn1TcmW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #118 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This seems to have moved beyond it's initial purpose with the Elasticsearch
additions. Would it make sense to split it up or at least change the title? It
might gain more interest that way too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:38:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:38:28 +0000
Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token
In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21998-70-wubZqO423t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:38:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:38:31 +0000
Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token
In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21998-70-bqs23zWiWJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83348|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 84401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84401&action=edit
Bug 21998: Throw exception on bad pattern

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:38:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:38:52 +0000
Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token
In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21998-70-7XuD0CBxmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Cross sign-offs ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:39:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:39:54 +0000
Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token
In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21998-70-DPeMH4K2wI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    ok 4 - Only uppercase letters
Use of uninitialized value $ch in string ne at
/usr/share/perl5/String/Random.pm line 141.
    ok 5 - Exception should be thrown when wrong pattern is used

This warning from String::Random is annoying, but no problem..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:56:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:56:28 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-1U2krwx3PI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:56:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:56:31 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-a2Mys9NQKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84096|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 84402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84402&action=edit
Bug 7403: Shorten CataloguingLog preference description

To test:

1) Look at value of CataloguingLog prefernce
2) Apply the patch and the value should change
3) Verify that the warning has been removed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 11:56:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 10:56:46 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-YdMfvsN0aI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |m.de.rooy at rijksmuseum.nl
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 12:11:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 11:11:02 +0000
Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings
In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18320-70-Rkx9aCadTp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 12:11:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 11:11:06 +0000
Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings
In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18320-70-8Q9KVaxYKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61532|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 84403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84403&action=edit
Bug 18320: Remove patroncards/edit-layout.pl warnings

This patch removes warnings generated by the script itself.

To test:
- Go to Tools ? Patron card creator ? Manage layouts and
        Tools ? Patron card creator ? New layout
- Add a new layout, adit existing.
=> FAIL: Warnings logged by edit-layout.pl
- Apply this patch
- Go to Tools ? Patron card creator ? Manage layouts and
        Tools ? Patron card creator ? New layout
- Add a new layout, adit existing.
=> SUCCESS: No warnings generated by edit-layout.pl
- Sign off :-D

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 12:26:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 11:26:31 +0000
Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on
	serial-level
In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18745-70-1vbY33ZNBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #6 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Hi, when creating a serial without a vendor, there is an internal server error.

logs:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha`.`serial`, CONSTRAINT `serial_aqbooksellerid_fk`
FOREIGN KEY (`aqbooksellerid`) REFERENCES `aqbooksellers` (`id`)) [for
Statement "INSERT INTO `serial` ( `aqbooksellerid`, `biblionumber`,
`planneddate`, `publisheddate`, `serialseq`, `serialseq_x`, `serialseq_y`,
`serialseq_z`, `status`, `subscriptionid`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?,
? )" with ParamValues: 0='0', 1="12345", 2='2019-01-01', 3='2019-01-01', 4='Vol
145, No 1,2019', 5='145', 6='1', 7='2019', 8=1, 9='123'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a
foreign key constraint fails (`koha`.`serial`, CONSTRAINT
`serial_aqbooksellerid_fk` FOREIGN KEY (`aqbooksellerid`) REFERENCES
`aqbooksellers` (`id`)) at /home/koha/src/Koha/Object.pm line 121

It seems that the issue is that 0 is trying to get in "aqbooksellerid".

And there is no aqbooksellers.aqbooksellerid egal to 0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 12:57:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 11:57:30 +0000
Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL
	request statuses
In-Reply-To: <bug-20581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20581-70-uS6UZk4vbC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #132 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84404&action=edit
Bug 20581: (follow-up) Fix dependency requirement

Since this bug is now dependent on Bug 20600 (Provide the ability for
users to filter ILL requests) we need to make the status filtering aware
of the custom statuses. This patch does that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 13:04:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 12:04:30 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
 datatable to be customisable
In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21063-70-Ab5I10ncHM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063

--- Comment #23 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84405&action=edit
Bug 21063: (follow-up) Add comments to column list

Since this bug is now dependent on Bug 18591 (Allow an arbitrary number
of comments on ILLs) we need to add the comments column to this table
and the list of selectable columns. This patch does this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 14:00:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 13:00:22 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
	records
In-Reply-To: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18757-70-CslHxFvfjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

Serhij Dubyk <dubyk at ukr.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dubyk at ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 14:00:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 13:00:29 +0000
Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it
 multi-threaded
In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21872-70-SqaHQuKNsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

david holoshka <david.holoshka at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.holoshka at ub.lu.se

--- Comment #35 from david holoshka <david.holoshka at ub.lu.se> ---
We were force to rewrite rebuild_elastic_search.pl as it just died after a
couple days never finishing to index our 2.4 million bibliographic records. Our
version forks a copy of the process to each machine core using biblio_metadata
based limits precalculated by the parent process (this has been upgraded since
I sent you a copy of the code, David to make sure each core gets the same
number of records to index). My old algorithm didn't distribute the load well
as the metadata ids gaps were create by biblio updates with time.  With 8 cores
the indexing completes in 50 minutes with elastic search running on the same
virtual machine. We speed up the process a great deal by accessing the metadata
table directly instead of through the iterator.  The only draw back is memory
usage due to needing to put the 952 item data (coincidentally also 2.4 million
items) in hashes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 14:05:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 13:05:48 +0000
Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it
 multi-threaded
In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21872-70-DgXAxkKTz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

--- Comment #36 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> ---
(In reply to david holoshka from comment #35)
> We were force to rewrite rebuild_elastic_search.pl as it just died after a
> couple days never finishing to index our 2.4 million bibliographic records.

Why did it die?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 15:12:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 14:12:12 +0000
Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable
In-Reply-To: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22175-70-pLndV8gMgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84406&action=edit
Bug 22175: Make stock rotation table sortable

This patch adds sorting and column configuration to the stock
rotation tables, both rotas and items. No new defaults for the table are
defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Tools -> Stock rotation.
   - In the table of rotas test that sorting works correctly.
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
   - Choose a rota with multiple items on it and select manage ->
     stages. Repeat the above DataTables functionality tests.

 - Go to Administration -> Columns settings and edit the default
   configuration of the stock rotation tables. Confirm that these
   changes are reflected in the corresponding tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 15:12:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 14:12:09 +0000
Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable
In-Reply-To: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22175-70-wnt4LWFWw1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:19:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:19:10 +0000
Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle
	incorrect values
In-Reply-To: <bug-21610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21610-70-40ikC0dFVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:20:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:20:03 +0000
Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle
	incorrect values
In-Reply-To: <bug-21610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21610-70-mMozZnEiIP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:42:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:42:11 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-Jk7LbTHeU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 84407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84407&action=edit
Bug 22207: course reserves page does not have unique <body> id test plan go to
cgi-bin/koha/opac-course-reserves.pl in the OPAC and make sure the body id is
opac-course-reserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:42:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:42:08 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-laI6xtA7on@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:43:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:43:13 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-nE89rjiNUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |lucas at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:57:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:57:38 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-AgBhi12SoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84407|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84408&action=edit
Bug 22207: course reserves page does not have unique <body> id

Test plan: Go to cgi-bin/koha/opac-course-reserves.pl in the OPAC and
make sure the body id is opac-course-reserves

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 16:57:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 15:57:35 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-kC3FDDDSar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:04:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:04:03 +0000
Subject: [Koha-bugs] [Bug 7614] Use branch transfer limits for determining
 available opac holds pickup locations
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-yNlg4rTBWJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Branch transfer limit and   |Use branch transfer limits
                   |holds                       |for determining available
                   |                            |opac holds pickup locations
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:16:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:16:21 +0000
Subject: [Koha-bugs] [Bug 22209] New: Move stock rotation stage and item
 forms into modals
Message-ID: <bug-22209-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209

            Bug ID: 22209
           Summary: Move stock rotation stage and item forms into modals
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 11897
  Target Milestone: ---

I propose to put "Add stage" and "Add items" buttons in the stock rotation
toolbar which trigger modals with the corresponding forms in them.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897
[Bug 11897] Stock Rotation for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:16:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:16:21 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-94BqRz7lYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22209


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209
[Bug 22209] Move stock rotation stage and item forms into modals
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:39:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:39:38 +0000
Subject: [Koha-bugs] [Bug 21610] Koha::Object->store needs to handle
	incorrect values
In-Reply-To: <bug-21610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21610-70-9VstE92MEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:53:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:53:03 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-jdXge0a5VY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84410&action=edit
Bug 21478: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:53:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:53:07 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-pzgq9iii6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84411&action=edit
Bug 21478: Make Koha::Hold->suspend reject found holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:52:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:52:59 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-te5BHOsbTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84409&action=edit
Bug 21478: Add Koha::Exceptions::Hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:54:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:54:25 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-mwa2651d9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478
[Bug 21478] Koha::Hold->suspend_hold allows suspending in transit holds
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:54:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:54:25 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-QltgQyS5Yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206
[Bug 22206] Add route to handle holds suspensions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:55:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:55:02 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-RqFripIuXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 17:56:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 16:56:07 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-r2Fsk36V0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #24 from Charles Farmer <charles.farmer at inlibro.com> ---
We've received feedback from librarians who were confounded by this new, and
different, behaviour of pay.pl in v18. I don't understand myself how we went
from not being able to pay negative numbers, to an interface requiring more
clicks to do what was possible previously, which was to ask from the patron the
amount that would return his ->balance to 0.

I feel like the patch should've checked first what the balance was, and display
outstanding_credits AND/OR debits depending on whether that number turned out
positive or negative.

So, before opening a new bug report, is this something that was considered
during development?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:00 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-8LUfBnBV44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81771|0                           |1
        is obsolete|                            |
  Attachment #81772|0                           |1
        is obsolete|                            |
  Attachment #81773|0                           |1
        is obsolete|                            |
  Attachment #81774|0                           |1
        is obsolete|                            |
  Attachment #81775|0                           |1
        is obsolete|                            |
  Attachment #81778|0                           |1
        is obsolete|                            |
  Attachment #82196|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84412&action=edit
Bug 20912: Update database

Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:31 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-BpR2PWmrfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84413&action=edit
Bug 20912: Rental Fees based on Time Period

Some libraries would like to be able to charge a rental fee based on the
number of days and item will be checked out, as opposed to the flat fee
currently offered by Koha.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Edit an itemtype, add a daily rental fee of 1.00
4) Check an item of that itemtype out for 7 days
5) Verify the patron now has rental fee of 7.00

Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:34 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-YcsUBkrHOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84414&action=edit
Bug 20912: Update schema file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:38 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-npFTUlYZjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84415&action=edit
Bug 20912: (QA follow-up) Fix number of tests and correct typos

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:41 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-AzvjzgTllH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84416&action=edit
Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used
for test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:45 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-fZOQ5Cvx3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84417&action=edit
Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:48 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-BaePMSpN51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84418&action=edit
Bug 20912: Move calculation to Koha::Fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:52 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-9EYwe5KHHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84419&action=edit
Bug 20912 (QA Follow-up): Fix up Koha::Fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:50:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:50:55 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-p3yxVmYPEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84420&action=edit
Bug 20912 (QA Follow-up): Fix up unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:52:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:52:18 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-c9vWp7Tq4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:56:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:56:29 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-aWWNEXIzyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Minor rebase needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:57:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:57:06 +0000
Subject: [Koha-bugs] [Bug 7614] Use branch transfer limits for determining
 available opac holds pickup locations
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-kMFtWzVWFw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #44 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:57:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:57:17 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-hipqOMic0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:57:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:57:30 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-0VXE89msyZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:58:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:58:01 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-E2CJr33II1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:57:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:57:42 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-tb5vOdJHfa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:58:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:58:25 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-CGBr2Tmtzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:58:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:58:39 +0000
Subject: [Koha-bugs] [Bug 21672] Switch templates to Bootstrap grid: Various
In-Reply-To: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21672-70-OM5WJjdm8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21672

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:58:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:58:50 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-jUs7wmJZGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:59:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:59:03 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-3y2MgZhHVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:59:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:59:14 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-X66Yb0A5wJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 18:59:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 17:59:27 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-FER8YwrWuK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:32:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:32:51 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21944-70-29LuIrlD22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83144|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:49:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:49:33 +0000
Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable
In-Reply-To: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22175-70-QVJGJ3u6R8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84406|0                           |1
        is obsolete|                            |

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84421&action=edit
Bug 22175: Make stock rotation table sortable

This patch adds sorting and column configuration to the stock
rotation tables, both rotas and items. No new defaults for the table are
defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Tools -> Stock rotation.
   - In the table of rotas test that sorting works correctly.
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
   - Choose a rota with multiple items on it and select manage ->
     stages. Repeat the above DataTables functionality tests.

 - Go to Administration -> Columns settings and edit the default
   configuration of the stock rotation tables. Confirm that these
   changes are reflected in the corresponding tables.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:52:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:52:52 +0000
Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable
In-Reply-To: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22175-70-pR8EbeqZYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

--- Comment #3 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
"- Choose a rota with multiple items on it and select manage ->
     stages. Repeat the above DataTables functionality tests."

I assumed this meant manage -> items, since that's where the DataTable is.

Also, I'm not sure if this is expected behavior but when exporting the rota
table, the "Number of items" column isn't exported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:53:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:53:03 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
	records
In-Reply-To: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18757-70-WygdH6RZUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:54:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:54:20 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
	records
In-Reply-To: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18757-70-UI0uI3sEqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|jose-mario.monteiro-santos@ |
                   |inlibro.com                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:59:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:59:52 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-DrmbciS38a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 19:59:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 18:59:56 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-3TQ1Of8bSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83594|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:00:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:00:00 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-18jD5Lu3jo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83595|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:00:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:00:05 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-M8q76shgUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83596|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:00:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:00:42 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-iUp3Dilu2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84423&action=edit
Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password

This patch makes Koha::Patron->set_password expect a hashref as param
and adds support for an 'skip_validation' param to be passed. Its purpose is to
make the method skip the relevant password strength checks if required.

It targets the Auth_with_ldap.pm usage when the 'update_password' flag
is set in the configuration.

The tests on this bug cover this use case so, to test:

- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail, code doesn't work as expected
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass! Yay!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:00:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:00:37 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-CoDxxPqetr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84422&action=edit
Bug 22047: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:00:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:00:46 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-5ig9Cff6Np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84424&action=edit
Bug 22047: Fix opac/opac-passwd.pl call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:10:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:10:57 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21944-70-rsOOM6nsdV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

--- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Comment on attachment 83144
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83144
Bug 21944: Test for Circulation.pm

[11:01] <kidclamp> your tests look lright - except that you call
ModReserveAffect
[11:02] <kidclamp> the test shoudl be to do AddReturn on the waiting hold as if
it is at another branch
[11:02] <kidclamp> the tests are thenjust checks to verify the situation is as
you expect it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:11:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:11:23 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-nVtollFilE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84370|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84425&action=edit
Bug 22203: Holds modal does not link to patorn account

To test:
1 - Place a hold for a patron
2 - Check the item in at the pickup location
3 - Note the holds modal does not link to patron
4 - Apply patch
5 - Check in item again
6 - Patron name in modal is a link

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:11:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:11:24 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21944-70-Zxdujwc6Iy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83144|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:11:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:11:20 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-22Ovqi5Bk9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:16:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:16:02 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-mo7C5Vzjhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:26:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:26:11 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-7gLL3X0MdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:26:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:26:14 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-uvxjw3YMdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84334|0                           |1
        is obsolete|                            |

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84426&action=edit
Bug 22191: Add column configuration to libraries administration

This patch adds column configuration to the table of libraries
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Libraries
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the libraries table. Confirm that these
   changes are reflected in libraries administration.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:31:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:31:12 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-mZpLgOaaam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:31:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:31:15 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-8DkWSZpzLR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84333|0                           |1
        is obsolete|                            |

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84427&action=edit
Bug 22190: Add column configuration to patron category administration

This patch adds column configuration to the table of patron categories
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Patron categoires.
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the patron categories table. Confirm that these
   changes are reflected in patron category administration.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:32:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:32:00 +0000
Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the
 accountline date
In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22200-70-nndSFshYZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

--- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
I created a fine and changed it so its date is not today. I went to Pay fines
and paid, but the date did not update. Am I doing something wrong?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:33:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:33:17 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-sRuIKP7C1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:33:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:33:20 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-I6B9s6UMSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84392|0                           |1
        is obsolete|                            |

--- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84428&action=edit
Bug 21449: Update two-column templates with Bootstrap grid: Circulation part 2

This patch modifies several circulation templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths. For each page, test with
the CircSidebar preference both on and off.

 - Catalog -> Search -> Details -> Items -> View item's checkout history
 - Circulation -> Overdues with fines
 - Circulation -> Transfer
 - Circulation -> Patron -> Batch checkout
 - Circulation -> Built-in offline circulation interface
   - Synchronize
   - Pending offline circulation actions
   - Check out
   - Check in

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:35:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:35:04 +0000
Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern
In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22188-70-W2gcpI7wql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |pierre-marc.thibault at inlibr
                   |                            |o.com

--- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
The patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:47:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:47:35 +0000
Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21845-70-HXEWYup00v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84360|0                           |1
        is obsolete|                            |

--- Comment #3 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84429&action=edit
Bug 21845: Sort of issues in OPAC subscription table

This patch adds a default sort option to the table of subscriptions on
the OPAC detail page. This sorting option matches the sort of data
passed from GetLatestSerials.

To test, apply the patch and locate a subscription in the OPAC which has
multiple issues. They should be sorted by default on publication date.

Signed-off-by: mikael <mikael.Olangcay-Brisebois at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 20:52:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 19:52:55 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-YbPE8wUg3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Patch failed to apply

Applying: Bug 15148: Predict serials issues from subscription start date
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
M       serials/showpredictionpattern.pl
Falling back to patching base and 3-way merge...
Auto-merging serials/showpredictionpattern.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15148: Predict serials issues from subscription start
date


Also, are you sure step 5 of your test plan is correct ? When I did it, I had
all 104 results in the prediction. The problem is that the issues' dates start
in 2016 (first publication) instead of 2019 (subscription start)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:06:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:06:35 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-GveVW2WMCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84408|0                           |1
        is obsolete|                            |

--- Comment #3 from Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com> ---
Created attachment 84430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84430&action=edit
Bug 22207: course reserves page does not have unique <body> id

Test plan: Go to cgi-bin/koha/opac-course-reserves.pl in the OPAC and
make sure the body id is opac-course-reserves

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mika?l Olangcay Brisebois
<mikael.olangcay-brisebois at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:09:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:09:33 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-qxOiOaEnRY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:09:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:09:36 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-7UolCS64Jp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84358|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84431&action=edit
Bug 22198: Add granular permission setting for Mana KB

This patch adds a separate permission for managing Mana KB.

To test, apply the patch and update the database.

 - Open the permissions page for a patron with staff client privileges
   - Confirm that there is a "Manage Mana KB content sharing
     (manage_mana)" permission.
   - Leaving this new permission unchecked, log into the staff client
     with as that patron and go to the Administration home page.
       - The "Using Mana-KB" link should not appear.
       - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You
         should get a "permission denied" message.
   - Modify the patron's permissions to grant them access to Mana KB.
       - Confirm that the link now appears on the Administration home
         page and that the user can access the page.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:12:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:12:18 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-IOSTKXvQa5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:12:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:12:21 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-V9JfaY78pC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84409|0                           |1
        is obsolete|                            |
  Attachment #84410|0                           |1
        is obsolete|                            |
  Attachment #84411|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84432&action=edit
Bug 21478: Add Koha::Exceptions::Hold

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:12:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:12:30 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-X2X9JjYE1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84433&action=edit
Bug 21478: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:12:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:12:33 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-IGIb9ezLXh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84434&action=edit
Bug 21478: Make Koha::Hold->suspend reject found holds

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:13:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:13:40 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-DB3yLVc6cu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84359|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84435&action=edit
Bug 22197: Add Mana KB link to administration sidebar menu

This patch adds a link to the Mana KB configuration page to the
administration sidebar menu.

To test, apply the patch and:

 - Log in to the staff client as a user who lacks permission to manage
   Mana KB.
   - Go to an Administration page which shows the sidebar, like
     Libraries or Patron categories. There should be no link to Mana KB
     in the left-hand sidebar.
 - Log in to the staff client as a user who has permission to manage
   Mana KB.
   - Go to Administration -> Mana KB
     - In the sidebar menu you should see a link to Mana KB and it
       should be bold.
   - Navigate to another Administration page which shows the sidebar.
     The Mana KB link should not be highlighted.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:13:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:13:44 +0000
Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl
	results
In-Reply-To: <bug-11870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11870-70-yXRUiZ21Em@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |jose-mario.monteiro-santos@
                   |                            |inlibro.com

--- Comment #12 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Patch failed to apply

Applying: Bug 11870: Add more informations to histsearch.pl results
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 11870: Add more informations to histsearch.pl results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:13:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:13:37 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-TnpMwoIMDz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:28:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:28:30 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-4impUhwaG4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

--- Comment #11 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Both patches seems to be fine and I will probably sign them off.

When I do a test with NOT_LOAN and AV = 2, I see this : "Item not for loan .".
There is a space character created by the dot no matter what the system
preference setting is. 

I wonder if it can be fixed as well too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:34:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:34:56 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-aRO0Gd3cg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84273|0                           |1
        is obsolete|                            |

--- Comment #12 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84436&action=edit
Bug 21877: Show authorized value description for withdrawn in checkout

During checkout the withdrawn information is displayed in a message :
"Item has been withdrawn".

Like in other pages and like notforloan, we should display the withdrawn
authorized value description.

This patch adds this display.
Add <span> so that translation does not change.
Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding
this new information via CSS.

Test plan :
1) On a catalog with items.withdrawn defined with authorized values category
WITHDRAWN
2) Define in WITHDRAWN an authorized values 1 with description 'dropped in
trash'
3) Define in WITHDRAWN an authorized values 2 with description empty
4) Edit an item with withdrawn=1
5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)'
6) Edit an item with withdrawn=2
7) Checkout this item => You see 'Item has been withdrawn'

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:34:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:34:59 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-4ZW8XttGyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84274|0                           |1
        is obsolete|                            |

--- Comment #13 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84437&action=edit
Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in
checkout

Using only TT plugin for authorised value description is a better code.

Test plan :
Part 1:
1.1) On a catalog with items.notforloan defined with authorized values category
NOT_LOAN
1.2) Define in NOT_LOAN an authorized values 1 with description 'at the beach'
1.3) Define in NOT_LOAN an authorized values 2 with description empty
Part 2:
2.1) Set preference 'AllowNotForLoanOverride' to 'Don't allow'
2.2) Edit an item with notforloan=1
2.3) Checkout this item => You see 'Item not for loan (at the beach)'
2.4) Edit an item with notforloan=2
2.5) Checkout this item => You see 'Item not for loan'
Part 3:
3.1) Set preference 'AllowNotForLoanOverride' to 'Allow'
3.2) Edit an item with notforloan=1
3.3) Checkout this item => You see 'Item is normally not for loan (at the
beach)'
3.4) Edit an item with notforloan=2
3.5) Checkout this item => You see 'Item is normally not for loan'

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:35:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:35:17 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-qwtt1ZpIW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:50:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:50:00 +0000
Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate
	only
In-Reply-To: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22049-70-uGoJOvHd5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:50:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:50:07 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-rtqqdX2sCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:50:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:50:22 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-PWFGjzAp5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:50:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:50:36 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-sduMh5kTlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:50:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:50:48 +0000
Subject: [Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
In-Reply-To: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21993-70-wrU6UPg984@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:51:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:51:02 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-w1isQKys95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:51:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:51:26 +0000
Subject: [Koha-bugs] [Bug 21826] Automatic authority record generation
	improvements
In-Reply-To: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21826-70-ULFffn8BTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #47 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:51:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:51:38 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-x4C1kFlM85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:51:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:51:13 +0000
Subject: [Koha-bugs] [Bug 21965] Switch two-column templates to Bootstrap
 grid: Patrons part 3
In-Reply-To: <bug-21965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21965-70-vF4HmXYzDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21965

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:51:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:51:50 +0000
Subject: [Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap
 grid: Patron card creator
In-Reply-To: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21438-70-heAumVoZwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:52:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:52:01 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-T5rMjBaS4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:53:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:53:44 +0000
Subject: [Koha-bugs] [Bug 22151] Developer name spelled wrong in About
In-Reply-To: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22151-70-8X4nDQ2x3R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22151

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Apologies, didn't see this one here so just fixed my mistake

Apologies to Helene for the mistake.

Thanks all for all your work :-)

*** This bug has been marked as a duplicate of bug 7143 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 21:53:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 20:53:44 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-5k1xhHjZ1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #443 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 22151 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:12:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:12:31 +0000
Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration
 to overdues report
In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21852-70-ddn5Mkt8PI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maryse.simard at inlibro.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> ---
I followed the test plan and everything works. But I ran into some troubles on
the columns settings page (Administration > Configure columns).

First, the column names for the table circ-overdues don't appear. Also, on that
same page, if I try to save a new column configuration for that table
(randomly, because I cannot see the column names), my changes aren't kept.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:13:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:13:40 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-WR4ucT9XUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:18:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:18:20 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-fySGhzwMfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84425|0                           |1
        is obsolete|                            |

--- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 84438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84438&action=edit
Bug 22203: Holds modal does not link to patorn account

To test:
1 - Place a hold for a patron
2 - Check the item in at the pickup location
3 - Note the holds modal does not link to patron
4 - Apply patch
5 - Check in item again
6 - Patron name in modal is a link

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:23:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:23:29 +0000
Subject: [Koha-bugs] [Bug 18805] Currently it is impossible to apply credits
 against debits in patron accounts
In-Reply-To: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18805-70-TKmouR48wg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:23:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:23:14 +0000
Subject: [Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
In-Reply-To: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21896-70-IG5BgwEh4p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:35:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:35:21 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-qaXFgZ2GIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84132|0                           |1
        is obsolete|                            |

--- Comment #3 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84439&action=edit
Bug 22148: Changed where user is redirected by cancelling payment

To test:
1) Create a manual invoice and save
2) Go to Make a payment tab
3) Click 'Pay amount', then cancel
4) Notice you are redirected to the Transactions tab, rather than back to
Make a payment
5) Also try this with Pay selected and write off selected result when
cancelling should be the same
6) Apply patch and try steps 2-6 again
7) Verify that you are now redirected to the 'make a payment tab'

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:42:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:42:41 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-68Kju736u1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:42:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:42:44 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-vO4t6F3LFQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83889|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 84440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84440&action=edit
Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl

This patch undoes the changes to addorderiso2709.tt introduced by Bug
19753. The item information tab can include embedded JavaScript for
cataloging plugins, and these don't currently work with JS in the
footer.

To test, apply the patch and test the JavaScript driven features of the
"Add to basket from a staged file" page:

  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - MARC and Card previews, select all/clear all
    - Item information tab: Cataloging plugins for fields like date
      acquired, barcode
    - Default accounting details tab: Show inactive control

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:43:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:43:47 +0000
Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input
In-Reply-To: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12283-70-n734Qbd9gH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 22:43:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 21:43:50 +0000
Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input
In-Reply-To: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12283-70-4wNMcp2X7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80753|0                           |1
        is obsolete|                            |

--- Comment #4 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84441&action=edit
Bug 12283: Disable autocomplete for patron search inputs

In a production system, you don't usually search for the same
patron over and over, so there's no sense for the browser
to save a list of searched patrons in the patron quick
search. Therefore, should set autocomplete=off for that
input field.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 23:12:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 22:12:11 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-5wd4o9r9Ll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84391|0                           |1
        is obsolete|                            |

--- Comment #3 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> ---
Created attachment 84442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84442&action=edit
Bug 22195: Change default DataTables configuration to consolidate buttons

This patch changes the default DataTables configuration provided by the
columns settings include file. It consolidates DataTables buttons into
to menus: One for column configuration and one for export options.

This change would not affect tables which aren't set up for column
configuration.

To test, apply the patch and view a page with columns configuration.

 Example: Tools -> Notices & slips
  - Confirm that the buttons appear as expected.
  - Confirm that each button menu performs its task correctly (column
    visiblity, export, print).
  - Test other pages with columns configuration. For instance:
    Acquisitions order search, Currencies administration, Holds queue

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 25 23:16:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Jan 2019 22:16:19 +0000
Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the
 accountline date
In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22200-70-xa8KNrm8oq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Sorry, I didn't follow the steps precisely. I didn't test on the checking in
page, but I did by the Create manual credit way and it wasn't still working.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:28:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:28:00 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-cxl5t2meZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like that it takes up less space, but I am a little worried about it being
less self-explanatory. Could we get a tooltip showing when you leave the cursor
on the icon?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:28:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:28:38 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-guHiVDuXaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:28:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:28:41 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-7THJAx7Lrh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84442|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84443&action=edit
Bug 22195: Change default DataTables configuration to consolidate buttons

This patch changes the default DataTables configuration provided by the
columns settings include file. It consolidates DataTables buttons into
to menus: One for column configuration and one for export options.

This change would not affect tables which aren't set up for column
configuration.

To test, apply the patch and view a page with columns configuration.

 Example: Tools -> Notices & slips
  - Confirm that the buttons appear as expected.
  - Confirm that each button menu performs its task correctly (column
    visiblity, export, print).
  - Test other pages with columns configuration. For instance:
    Acquisitions order search, Currencies administration, Holds queue

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:35:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:35:40 +0000
Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input
In-Reply-To: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12283-70-MC7KhcdStx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:35:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:35:45 +0000
Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input
In-Reply-To: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12283-70-PwJ8xcnFx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84441|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84444&action=edit
Bug 12283: Disable autocomplete for patron search inputs

In a production system, you don't usually search for the same
patron over and over, so there's no sense for the browser
to save a list of searched patrons in the patron quick
search. Therefore, should set autocomplete=off for that
input field.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:44:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:44:14 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-BsLLgESpcl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:44:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:44:17 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-nxo0mUSHWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84440|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84445&action=edit
Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl

This patch undoes the changes to addorderiso2709.tt introduced by Bug
19753. The item information tab can include embedded JavaScript for
cataloging plugins, and these don't currently work with JS in the
footer.

To test, apply the patch and test the JavaScript driven features of the
"Add to basket from a staged file" page:

  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - MARC and Card previews, select all/clear all
    - Item information tab: Cataloging plugins for fields like date
      acquired, barcode
    - Default accounting details tab: Show inactive control

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 13:45:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 12:45:05 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-UoXv2s5rtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ignoring the QA script fail as invalid in this case (see commit message):

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   FAIL   js_in_body
                A <script> tag found inside head, must be moved to the body
(see bug 17858)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:10:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:10:05 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-vHljX7qcd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:10:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:10:09 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-wOIKM6IiMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84439|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84446&action=edit
Bug 22148: Changed where user is redirected by cancelling payment

To test:
1) Create a manual invoice and save
2) Go to Make a payment tab
3) Click 'Pay amount', then cancel
4) Notice you are redirected to the Transactions tab, rather than back to
Make a payment
5) Also try this with Pay selected and write off selected result when
cancelling should be the same
6) Apply patch and try steps 2-6 again
7) Verify that you are now redirected to the 'make a payment tab'

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:15:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:15:12 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-1xud5wlUCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:15:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:15:15 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-NiE0fSYsrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84438|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84447&action=edit
Bug 22203: Holds modal does not link to patorn account

To test:
1 - Place a hold for a patron
2 - Check the item in at the pickup location
3 - Note the holds modal does not link to patron
4 - Apply patch
5 - Check in item again
6 - Patron name in modal is a link

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:31:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:31:36 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-Ffc3SANWUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:31:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:31:44 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-Sy5jMWVj1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84449&action=edit
Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in
checkout

Using only TT plugin for authorised value description is a better code.

Test plan :
Part 1:
1.1) On a catalog with items.notforloan defined with authorized values category
NOT_LOAN
1.2) Define in NOT_LOAN an authorized values 1 with description 'at the beach'
1.3) Define in NOT_LOAN an authorized values 2 with description empty
Part 2:
2.1) Set preference 'AllowNotForLoanOverride' to 'Don't allow'
2.2) Edit an item with notforloan=1
2.3) Checkout this item => You see 'Item not for loan (at the beach)'
2.4) Edit an item with notforloan=2
2.5) Checkout this item => You see 'Item not for loan'
Part 3:
3.1) Set preference 'AllowNotForLoanOverride' to 'Allow'
3.2) Edit an item with notforloan=1
3.3) Checkout this item => You see 'Item is normally not for loan (at the
beach)'
3.4) Edit an item with notforloan=2
3.5) Checkout this item => You see 'Item is normally not for loan'

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 14:31:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 13:31:40 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-cFThlKLkd4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84436|0                           |1
        is obsolete|                            |
  Attachment #84437|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84448&action=edit
Bug 21877: Show authorized value description for withdrawn in checkout

During checkout the withdrawn information is displayed in a message :
"Item has been withdrawn".

Like in other pages and like notforloan, we should display the withdrawn
authorized value description.

This patch adds this display.
Add <span> so that translation does not change.
Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding
this new information via CSS.

Test plan :
1) On a catalog with items.withdrawn defined with authorized values category
WITHDRAWN
2) Define in WITHDRAWN an authorized values 1 with description 'dropped in
trash'
3) Define in WITHDRAWN an authorized values 2 with description empty
4) Edit an item with withdrawn=1
5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)'
6) Edit an item with withdrawn=2
7) Checkout this item => You see 'Item has been withdrawn'

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 15:06:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 14:06:57 +0000
Subject: [Koha-bugs] [Bug 11870] Add more information to histsearch.pl
	results
In-Reply-To: <bug-11870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11870-70-4IMTWviLYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add more informations to    |Add more information to
                   |histsearch.pl results       |histsearch.pl results

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are dependencies on this bug not applying, I think this might be the
issue (bug 11708 and bug 11844)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 19:26:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 18:26:38 +0000
Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable
In-Reply-To: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22175-70-12s0CMdQzg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jos?-Mario Monteiro-Santos from comment #3)
> I assumed this meant manage -> items, since that's where the DataTable is.

Yes, sorry about that.

> Also, I'm not sure if this is expected behavior but when exporting the rota
> table, the "Number of items" column isn't exported.

That isn't expected, so I'll take another look at it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 26 20:23:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Jan 2019 19:23:56 +0000
Subject: [Koha-bugs] [Bug 22195] Change default DataTables configuration to
 consolidate buttons
In-Reply-To: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22195-70-UzZt9kKY7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22195

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84450&action=edit
Bug 22195: (follow-up) Add tooltip to buttons

This patch adds title attributes and Bootstrap tooltips to the columns
configuration and export/print butttons.

To test, apply the patch and visit a page with columns configuration
buttons. Confirm that when you hover over each of the DataTable control
buttons a tooltip is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:00:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:00:11 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-RknavTDFkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:00:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:00:16 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-M3ZylaBLuf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84357|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84451&action=edit
Bug 22196: Clean up Mana KB administration template

This patch makes language changes to the Mana KB administration
template, and corresponding language changes to the Web Services
preference file.

Some markup errors have been fixed:

 - Correct title and breadcrumbs, copied and pasted from another
   template
 - Add ids to form fields to match their label "for" attributes
 - Make <input>s self-closing
 - Correct class names on alert dialogs
 - Wrap text in JavaScript with _() to make it translatable

Also changed: Some language revisions to the Mana dialogs on the
Administration home page.

To test, apply the patch and go to Administration -> Share content with
Mana KB.

Test the process for enabling and configuring Mana KB. Check that
forms work correctly and that the language of instructions and labels
reads well.

Go to Administration -> System preferences -> Web services, and confirm
that the language changes to the Mana KB preference look good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:00:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:00:20 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-m3tShPV1su@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84452&action=edit
Bug 22196: (QA follow-up) Fix some typo

Fixes the typo on the admin main page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:01:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:01:01 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-bpd2WPpYWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I really like the clean-up, but from the discussion on the main bug I
understood that the token is an optional feature and you would still be allowed
to search for subscriptions/reports without it (what about commenting/rating?).
If that's the case it would be nice to make this more clear in the
documentation of the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:07:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:07:17 +0000
Subject: [Koha-bugs] [Bug 22210] New: Allow organisations to sign up to Mana
 KB more easily
Message-ID: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210

            Bug ID: 22210
           Summary: Allow organisations to sign up to Mana KB more easily
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

The Mana KB registration form asks for first name and last name. I think a lot
of libraries would prefer to sign up with a general account for the
organisation (library at ...). People can leave the library and more than one
person might work with serials/reports. So I think tying the account to a
person might not be the best way.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:07:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:07:17 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-cz8rq92Csd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22210


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210
[Bug 22210] Allow organisations to sign up to Mana KB more easily
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:15:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:15:02 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-FRMANSc5cd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84431|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84453&action=edit
Bug 22198: Add granular permission setting for Mana KB

This patch adds a separate permission for managing Mana KB.

To test, apply the patch and update the database.

 - Open the permissions page for a patron with staff client privileges
   - Confirm that there is a "Manage Mana KB content sharing
     (manage_mana)" permission.
   - Leaving this new permission unchecked, log into the staff client
     with as that patron and go to the Administration home page.
       - The "Using Mana-KB" link should not appear.
       - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You
         should get a "permission denied" message.
   - Modify the patron's permissions to grant them access to Mana KB.
       - Confirm that the link now appears on the Administration home
         page and that the user can access the page.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:14:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:14:58 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-kuwhY4Rhl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:16:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:16:54 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-4cWlonPKIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Passing QA on this patch, but there is an issue: the listed dependency wasn't
signed off initially. The dependency is only a line in the admin-home template,
so I think even if pushed out of order this could probably be fixed easily.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:20:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:20:31 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-Bp7C6eFQr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:20:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:20:35 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-s90irggjRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84435|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84454&action=edit
Bug 22197: Add Mana KB link to administration sidebar menu

This patch adds a link to the Mana KB configuration page to the
administration sidebar menu.

To test, apply the patch and:

 - Log in to the staff client as a user who lacks permission to manage
   Mana KB.
   - Go to an Administration page which shows the sidebar, like
     Libraries or Patron categories. There should be no link to Mana KB
     in the left-hand sidebar.
 - Log in to the staff client as a user who has permission to manage
   Mana KB.
   - Go to Administration -> Mana KB
     - In the sidebar menu you should see a link to Mana KB and it
       should be bold.
   - Navigate to another Administration page which shows the sidebar.
     The Mana KB link should not be highlighted.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:22:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:22:54 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-HBZjThzWWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:22:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:22:57 +0000
Subject: [Koha-bugs] [Bug 22207] course reserves page does not have unique
	<body> id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-T60DhmAl5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84430|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84455&action=edit
Bug 22207: course reserves page does not have unique <body> id

Test plan: Go to cgi-bin/koha/opac-course-reserves.pl in the OPAC and
make sure the body id is opac-course-reserves

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mika?l Olangcay Brisebois
<mikael.olangcay-brisebois at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:23:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:23:48 +0000
Subject: [Koha-bugs] [Bug 22207] Course reserves page does not have unique
	body id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-pJdosoEK3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|lucas at bywatersolutions.com  |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:23:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:23:37 +0000
Subject: [Koha-bugs] [Bug 22207] Course reserves page does not have unique
	body id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-2ykQJA6NcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|normal                      |minor
            Summary|course reserves page does   |Course reserves page does
                   |not have unique <body> id   |not have unique body id

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:36:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:36:52 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-BpOiq02Csr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd love for this to finally go in!

But sadly, I found 2 that won't work for me:

Acquisitions -> Vendor -> View basket
Patrons -> New patron

Error is the same:
<TypeError: c is null[Learn More] hc-sticky_18.1200008.js:11:4777 


Generated the CSS and did a restart_all... hope it's not something I've been
missing. Tested with Firefox in Ubuntu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:45:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:45:11 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-2K1lGlYR07@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:45:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:45:20 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-fR0EcTigP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84433|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84457&action=edit
Bug 21478: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:45:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:45:24 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-RGH7Kuz0g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84434|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84458&action=edit
Bug 21478: Make Koha::Hold->suspend reject found holds

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 11:45:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 10:45:15 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-cX4AxVlJbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84432|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84456&action=edit
Bug 21478: Add Koha::Exceptions::Hold

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:03:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:03:06 +0000
Subject: [Koha-bugs] [Bug 22211] New: In-built offline circulation shows
 incomplete information for checkouts
Message-ID: <bug-22211-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22211

            Bug ID: 22211
           Summary: In-built offline circulation shows incomplete
                    information for checkouts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

The checkouts table on a patron account in the in-built offline circulation is
missing some important information. Columns suggest that this used to work, so
filing as a bug.

To test:

- Switch on AllowOfflineCirculation
- Go to: /cgi-bin/koha/circ/offline.pl
- Synchronize (make sure you have some accounts with checkouts
- Check out
- Open the account by entering the cardnumber in field on top
- View checkouts shown
- Verify: 
  - item type shows as undefined
  - checkout location shows as undefined
  - empty call number shows as undef

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:04:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:04:54 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-cOJSafcjsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:04:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:04:58 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-uFwaDzgtM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84428|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84459&action=edit
Bug 21449: Update two-column templates with Bootstrap grid: Circulation part 2

This patch modifies several circulation templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths. For each page, test with
the CircSidebar preference both on and off.

 - Catalog -> Search -> Details -> Items -> View item's checkout history
 - Circulation -> Overdues with fines
 - Circulation -> Transfer
 - Circulation -> Patron -> Batch checkout
 - Circulation -> Built-in offline circulation interface
   - Synchronize
   - Pending offline circulation actions
   - Check out
   - Check in

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:05:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:05:26 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-Gk9RTmloKR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:35:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:35:49 +0000
Subject: [Koha-bugs] [Bug 7062] Titles on labels not truncating
In-Reply-To: <bug-7062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7062-70-ox84c0QhXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7062

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|barcode titles not          |Titles on labels not
                   |truncating                  |truncating

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:53:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:53:07 +0000
Subject: [Koha-bugs] [Bug 22212] New: Improve usability of column
	configuration page
Message-ID: <bug-22212-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22212

            Bug ID: 22212
           Summary: Improve usability of column configuration page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

The column configuration page currently doesn't translate well. The modules on
the tabs translate, but neither do the id= parts or the columns.

I think as a first step it would help to navigate these pages if we could add a
little description on where the table appears somewhere that is translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:54:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:54:13 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-DGTcz6Oos6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:54:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:54:16 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-1eKIMZNy9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84427|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84460&action=edit
Bug 22190: Add column configuration to patron category administration

This patch adds column configuration to the table of patron categories
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Patron categoires.
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the patron categories table. Confirm that these
   changes are reflected in patron category administration.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 12:55:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 11:55:03 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-ujrDViCz6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 13:00:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 12:00:13 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-Bu9WTHd2NA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen,
I was a bit irriated by the actions column getting wider and wider with each
column removed, but it appear on other pages like currencies as well. Maybe
something to improve on later on.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 13:00:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 12:00:46 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-zugSNSDaiB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84460|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84461&action=edit
Bug 22190: Add column configuration to patron category administration

This patch adds column configuration to the table of patron categories
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Patron categoires.
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the patron categories table. Confirm that these
   changes are reflected in patron category administration.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 13:02:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 12:02:32 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-ElID4kzqya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84426|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84462&action=edit
Bug 22191: Add column configuration to libraries administration

This patch adds column configuration to the table of libraries
in administration. No new defaults for the table are defined.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Administration -> Libraries
   - Test that the "Column visibility" button works to show and hide
     columns. The "actions" column should be excluded.
   - Test that export options (Excel, CSV, etc) exclude the "actions"
     column.
 - Go to Administration -> Columns settings and edit the default
   configuration of the libraries table. Confirm that these
   changes are reflected in libraries administration.

Signed-off-by: Jose-Mario Monteiro-Santos
<jose-mario.monteiro-santos at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 13:12:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 12:12:01 +0000
Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
In-Reply-To: <bug-5087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5087-70-1ehqg6HqyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, 
please don't forget to change kohastructure.sql as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 13:18:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 12:18:26 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-7oZfalnhNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83390|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 13:56:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 12:56:01 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-JFU4EsoJQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84463&action=edit
Bug 5770: (QA follow-up) Minor formatting fixes

- Rewords system preference slightly
- Minor changes to the sample template like
  " : " to ": "
- Alphabetizes sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:00:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:00:40 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-axeHHblK76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like TT syntax, but I think we could deal with it separately as not all
notices are TT yet. If we do TT we might want to do not just a conversion, but
also do a nice one, using [% IF (....) %] to avoid empty labels and the like.

I've added a follow-up doing some minor changes - plz have a look at those.

Failing for missing tests for the change on NewSuggestion. Please add tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:06:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:06:10 +0000
Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-Q6hJwwtHVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|tomascohen at gmail.com        |katrin.fischer at bsz-bw.de
            Summary|cannot renew items on hold  |Cannot renew items on hold
                   |even with override          |even with override
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:31:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:31:54 +0000
Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-yocBQVNTzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andrew,

some first QA notes here:

1) The QA script fails, easy to fix:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 206)

2) We don't want to change the current behaviour for updating installations, so
the feature should be set to of in the database update. I think since all the
other override features also default to "no", I'd also make it no for new
installations.

3) I don't understand the new entry form for the hold due date. My feeling is
that we should use the one existing already for entering the new due date for
any override. Having 2 forms seems confusing.

4) I'd also have expected the renewal to be locked initially and the checkbox
to unlock it. Reasoning: Renewing an item with a hold should always be an
exception. The way it's now a "renew all" checked on top will also check the
"on hold" ones which might be easily missed. We could relabel the checkbox and
use it for both: Allow override of renewal restrictions?

Last 2 are up for discussion of course. Feel free to seek an additional
opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:36:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:36:31 +0000
Subject: [Koha-bugs] [Bug 22213] New: Improve display of renewal related
 labels in circulation
Message-ID: <bug-22213-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22213

            Bug ID: 22213
           Summary: Improve display of renewal related labels in
                    circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com,
                    oleonard at myacpl.org
  Target Milestone: ---

Created attachment 84464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84464&action=edit
Renew options at the bottom of checkouts table

For some reason in the checkouts table in the staff patron account, the labels
for renewing at the bottom of the table are quite squashed while the input box
below is much wider (see screenshot). I think it would be nice to improve this,
also to aid longer translations (German being famous for long words wrapping
not nicely).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:45:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:45:50 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-QwaMh54JzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:45:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:45:54 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-nP3pD5lYlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84315|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84465&action=edit
Bug 21089: Overlapping elements in ordering information on acqui/supplier.pl

This patch changes the HTML structure of the vendor edit page so that
the markup is a little simpler. CSS is modified to match. This structure
should serve as a model for other similar form structures:

 <fieldset class="rows">
     <ol>
         <li>
             <label>General label:</label>
             <label class="radio">
                 Specific label 1 <input type="radio" />
             </label>
             <label class="radio">
                 Specific label 2 <input type="radio" />
             </label>
         </li>
     </ol>
 </fieldset>

To test, apply the patch and regenerate the staff client CSS.

 - Go to Acquisitions -> Vendor search -> Vendor -> Edit vendor
 - In the "Ordering information" section, confirm that the position of
   radio buttons looks correct.
 - Confirm that radio button labels work correctly.
 - Confirm that the adjacent dropdown menus work well.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:59:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:59:30 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-xUu53rsRQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:59:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:59:34 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-QRHEh3UVqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83834|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84466&action=edit
Bug 21871: Show authority 856 links in the OPAC

This patch modifies the authority detail view in the OPAC so that any
links found in 856 tags are displayed and active.

To test, apply the patch and locate or create an authority record which
contains one or more URLs in 856 tags.
 - View this record in the OPAC and confirm that the links appear.
 - Test records with and without link text.
 - Test records with and without public notes.

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 14:59:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 13:59:38 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-gEWLtQjxHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84223|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84467&action=edit
Bug 21871: (follow-up) Remove link tracking

Links to tracklinks.pl were erroneously copied from detail.tt. This
patch removes them.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:08:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:08:46 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-aSavSRzJxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84466|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84468&action=edit
Bug 21871: Show authority 856 links in the OPAC

This patch modifies the authority detail view in the OPAC so that any
links found in 856 tags are displayed and active.

To test, apply the patch and locate or create an authority record which
contains one or more URLs in 856 tags.
 - View this record in the OPAC and confirm that the links appear.
 - Test records with and without link text.
 - Test records with and without public notes.

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21817

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:08:50 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-a4UlNE8Icj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84467|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84469&action=edit
Bug 21871: (follow-up) Remove link tracking

Links to tracklinks.pl were erroneously copied from detail.tt. This
patch removes them.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21817

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:08:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:08:54 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-YxlmX4guFP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84470&action=edit
Bug 21871: (QA follow-up) Use Koha.Preference in template

Use TT plugin to get value for OPACURLOpenInNewWindow.

Works without, but might be a little nicer.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21817

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:08:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:08:59 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-9WEH2PrkNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84471&action=edit
Bug 21871: (QA follow-up) C4::Biblio qw(GetMarcUrls)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21817

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:10:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:10:20 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-OLG8HlYsHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Suggesting 2 follow-ups:

I think it's a tiny bit irritating to use something from Biblio in
authorities... but I know we will get to make this all shiny at some point with
the new API. Added a qw() to help remember what we exactly need this for here.

Suggest use of TT plugin in the template.

Kept them separate, so you can pick and choose :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:16:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:16:13 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-yudhRJapc0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure if this patch does fix the problem initially reported. Adding
Owen in hope he might be able to shine some light.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:16:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:16:47 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-oTB3foCd9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:18:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:18:43 +0000
Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from
 "Holds over" tab
In-Reply-To: <bug-15561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15561-70-GxSjwXTJJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Patches no longer apply, can you please rebase?

warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
Auto-merging circ/waitingreserves.pl
CONFLICT (content): Merge conflict in circ/waitingreserves.pl
Auto-merging C4/Reserves.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15561 - Add ability to charge cancelation fee from
"Holds over" tab
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-15561---Add-ability-to-charge-cancelation-fee--N7o9xj.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:28:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:28:19 +0000
Subject: [Koha-bugs] [Bug 17854] Print Slip and Close button
In-Reply-To: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17854-70-UL7G7mkYKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:28:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:28:23 +0000
Subject: [Koha-bugs] [Bug 17854] Print Slip and Close button
In-Reply-To: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17854-70-g2XMlzgnBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79942|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84472&action=edit
Bug 17854: Adds print/close icon in checkout

To Test:
1) Apply Patch.
2) Go to a patron checkout screen (circulation.pl).
3) Note there are no clear screen buttons in the upper right corner of
the checkout window.
4) Turn on the DisplayClearScreenButton preference.
5) Go back to patron checkout.  Note the clear screen button and the new
printer icon next to it.
6) Click the printer icon.  This will trigger a print slip function, and
close the patron screen.
7) Try to arrow back to the previous screen.  Should go to main menu and
not the patron screen, just like the orginal close button (X).

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 15:30:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 14:30:13 +0000
Subject: [Koha-bugs] [Bug 17854] New Print slip and close button next to
	Close button
In-Reply-To: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17854-70-vW2Fg1B7O9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Print Slip and Close button |New Print slip and close
                   |                            |button next to Close button
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 18:37:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 17:37:55 +0000
Subject: [Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong
 "for" attribute) in paycollect.tt
In-Reply-To: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20527-70-xMTWXxyBnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
The patch doesn't address what the bug reports. The patch adds auto-focus to
some accounting form fields, but some of them don't make sense: Putting the
focus on the payment field only makes sense if it's the first or only field in
the form. Adding focus to the *last* input in the form seems counterproductive.

The auto-focus changes to paycollect.tt could be re-implemented on a new bug
report, but it's not right for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 27 19:40:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 18:40:41 +0000
Subject: [Koha-bugs] [Bug 22214] New: New authority RDA indexes
Message-ID: <bug-22214-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22214

            Bug ID: 22214
           Summary: New authority RDA indexes
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Zebra
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: viliam.polonec at snk.sk
  Target Milestone: ---

Is it possible to add new authority indexes: birth_date / death_date /
birth_place / death_place / country / related_place / field_of_activity /
occupation / gender / language that are RDA compiliant? Also the KOHA OPAC
ability to search by theese new indexeses.
thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 00:03:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Jan 2019 23:03:31 +0000
Subject: [Koha-bugs] [Bug 21559] Rules for automatic framework codes
In-Reply-To: <bug-21559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21559-70-y4QRCi88nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Paxed, some first QA notes:

1) There is a fail from the QA tools:

 FAIL   t/Biblio/AutoFrameworkcode.t
   FAIL   critic
                "return" statement with explicit "undef" at line 47, column 9.
See page 199 of PBP.

2) I think the system preference description would be more helpful with some a
hint at documentation. I was wondering if a link to the manual would work, but
maintaining the link to always link to the current manual would not be so nice.
Maybe adding some more hints to the preference description for now?  

I am a bit concerned that this adds a lot of code in the "old style" to
C4::Biblio. Specifically: GetAutoFrameworkCode,_matchRecordFieldspec. Not sure
how much we have in place yet in Koha for dealing with records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 09:27:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 08:27:20 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-hxnFeo471J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509
[Bug 17509] Notify patrons to return items requested on hold by another person
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 09:27:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 08:27:20 +0000
Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on
 hold by another person
In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17509-70-ukn9MekYXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19014


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014
[Bug 19014] Patrons should not get a on_reserve notification if the due date is
far into the future
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 10:15:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 09:15:01 +0000
Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search
In-Reply-To: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8778-70-Uou3eKhLUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dcook at prosentient.com.au    |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am volunteering to do the first part: Add Keyword, Phrase to the advanced
search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:06:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:06:41 +0000
Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions
In-Reply-To: <bug-9833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9833-70-2ucP9jOisd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Merge from shelves is more a cataloguing action non ?
Should be a permission under "editcatalogue".
It is actually depending on "edit_catalogue" permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:43:27 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-FAC7YirItT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206
[Bug 22206] Add route to handle holds suspensions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:43:27 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-i01ASwHj1u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |22132, 19816


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816
[Bug 19816] output_pref must implement 'dateonly' for dateformat => rfc3339
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132
[Bug 22132] Add Basic authentication to the REST API
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:43:27 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-AvyJ0hhB9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206
[Bug 22206] Add route to handle holds suspensions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:44:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:44:23 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-D0IEnyAQzo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84473&action=edit
Bug 22206: OpenAPI spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:44:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:44:28 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-gM40w9GaXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84474&action=edit
Bug 22206: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:44:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:44:32 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-9VDPLhuQwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84475&action=edit
Bug 22206: Add routes to suspend/resume holds

This patch introduces:

- POST   /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" }
- DELETE /holds/{hold_id}/suspension

to suspend a hold or resume a suspended hold, respectively.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 11:45:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 10:45:00 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-gYMcCGwJ63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 12:20:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 11:20:26 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-YrvaSjEpdO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 12:59:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 11:59:14 +0000
Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-mb8H3cGteD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:04:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:04:33 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-EYNsELULsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:14:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:14:47 +0000
Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU
 daemon that can inject item status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-r5Jbqt4nrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add a search backend        |Add an
                   |agnostic Z39.50/SRU daemon  |Elasticsearch-compatible
                   |that can inject item status |Z39.50/SRU daemon that can
                   |MARC subfields              |inject item status MARC
                   |                            |subfields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:32:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:32:27 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-dywXvL6jFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:41:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:41:39 +0000
Subject: [Koha-bugs] [Bug 22215] New: table_borrowers name is inconsistent
 with other tables
Message-ID: <bug-22215-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22215

            Bug ID: 22215
           Summary: table_borrowers name is inconsistent with other tables
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

This table should be renamed more like patrons-table or patron-results-table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:41:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:41:57 +0000
Subject: [Koha-bugs] [Bug 22215] table_borrowers name is inconsistent with
	other tables
In-Reply-To: <bug-22215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22215-70-Bd5PbJzLFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22215

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17353
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353
[Bug 17353] Add phone number column to checkout search
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:41:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:41:57 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-VDzczMiaIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22215


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22215
[Bug 22215] table_borrowers name is inconsistent with other tables
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:49:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:49:32 +0000
Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports
 from export.pl fail under plack
In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8437-70-ukiCjKmGnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17240

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 13:49:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 12:49:32 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-PNGtOQJSaO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8437

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:02:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:02:28 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-FYqTgjm5GR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #64 from Ere Maijala <ere.maijala at helsinki.fi> ---
David, will you be able to address the test issues?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:07:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:07:20 +0000
Subject: [Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called
 twice when running link_bibs_to_authorities
In-Reply-To: <bug-21957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21957-70-A1fgxEWGql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957

--- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> ---
I'd call the parameter something like $disable_autolink to convey its meaning,
and check it first to avoid a call to C4::Context->preference() if
$disable_autolink is true.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:29:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:29:00 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-VxDwwZUIt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83713|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:28:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:28:45 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-kgFjvF7dlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83712|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:29:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:29:58 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-kT084clIcJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83711|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:31:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:31:20 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-u0z1SWWRdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:31:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:31:23 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-NW1vz5GVCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

--- Comment #46 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84476&action=edit
Bug 21751: (follow-up) Correction to selectors

This patch makes a couple of corrections to the selectors used by
hcsticky in targeting the position of the floating toolbar. These
changes were made necessary by changes made in recently-pushed patches.

To test, confirm that these two pages work correctly:

 - Acquisitions -> Vendor -> View basket
 - Patrons -> New patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:33:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:33:56 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-qbTEdcppUz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83844|0                           |1
        is obsolete|                            |
  Attachment #83845|0                           |1
        is obsolete|                            |
  Attachment #83846|0                           |1
        is obsolete|                            |
  Attachment #83847|0                           |1
        is obsolete|                            |

--- Comment #30 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84477&action=edit
Bug 20809: Link patron image to patron image add/edit form

This patch modifies an include file so that it is possible with edit a
patron's image on any patron-related page which uses that include.

To test you must have the patronimages system preference enabled.

Apply the patch and open any patron record for viewing.

 - Hover the mouse over the patron image.

   - If the patron has a previously-defined patron image, should you see
     an "Edit" button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

   - If a patron has no patron image defined, you should see an "Add"
     button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

This process should work from any page which shows the patron sidebar:
Check out, Details, Fines, Routing lists, Circulation history, etc.

Patch works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:34:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:34:00 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-AHNTec0oj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #31 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84478&action=edit
Bug 20809: (follow-up) Corrections to CSS and JS

This follow-up modifies JavaScript so that the confirmation dialog is
triggered when deleting a patron image from the modal window.

The CSS is modified to improve the alignment of patron image and edit
button.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:34:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:34:07 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-fsGE1PGzp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #33 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84480&action=edit
Bug 20809: (QA follow-up) Fix missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:34:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:34:04 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-EfRP8Dks4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #32 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84479&action=edit
Bug 20809: (follow-up) Add missing JS to view log page

If the log viewer is being used to track patron-related data the
patron-related JavaScript file should be included.

To test, apply the patch and open a patron record. In the left-hand
sidebar choose Modification Log. Test the patron image edit/replace
process from the patron image in the sidebar and confirm that it works
correctly.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:38:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:38:12 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-pd1iTnyuGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84478|0                           |1
        is obsolete|                            |

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84482&action=edit
Bug 20809: (follow-up) Corrections to CSS and JS

This follow-up modifies JavaScript so that the confirmation dialog is
triggered when deleting a patron image from the modal window.

The CSS is modified to improve the alignment of patron image and edit
button.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:38:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:38:16 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-A8FiygvYMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84479|0                           |1
        is obsolete|                            |

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84483&action=edit
Bug 20809: (follow-up) Add missing JS to view log page

If the log viewer is being used to track patron-related data the
patron-related JavaScript file should be included.

To test, apply the patch and open a patron record. In the left-hand
sidebar choose Modification Log. Test the patron image edit/replace
process from the patron image in the sidebar and confirm that it works
correctly.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:38:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:38:20 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-GHrC7tGf68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84480|0                           |1
        is obsolete|                            |

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84484&action=edit
Bug 20809: (QA follow-up) Fix missing filters

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 14:38:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 13:38:08 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-3MirMDCdHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84477|0                           |1
        is obsolete|                            |

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 84481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84481&action=edit
Bug 20809: Link patron image to patron image add/edit form

This patch modifies an include file so that it is possible with edit a
patron's image on any patron-related page which uses that include.

To test you must have the patronimages system preference enabled.

Apply the patch and open any patron record for viewing.

 - Hover the mouse over the patron image.

   - If the patron has a previously-defined patron image, should you see
     an "Edit" button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

   - If a patron has no patron image defined, you should see an "Add"
     button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

This process should work from any page which shows the patron sidebar:
Check out, Details, Fines, Routing lists, Circulation history, etc.

Patch works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:11:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:11:38 +0000
Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search
In-Reply-To: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17353-70-JMSLS2yRKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:11:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:11:51 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-DPQINiTtTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:12:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:12:08 +0000
Subject: [Koha-bugs] [Bug 20569] Improve description of CheckPrevCheckout
 system preference
In-Reply-To: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20569-70-gUK13JmhRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20569

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:12:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:12:37 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-q2agR9DNSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84282|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84485&action=edit
Bug 21495: Regression in hold override functionality

The changes caused by the patches for bug 11512 have broken existing
workflows for many libraries and are widely considered to be a bad move.
We should revert this behavior.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Rhonda Kuiper <kuiper at roundrocktexas.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:12:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:12:41 +0000
Subject: [Koha-bugs] [Bug 20729] Update style of datepickers
In-Reply-To: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20729-70-9xjVS9dOyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:12:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:12:21 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-Sey7YfotWj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #41 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:12:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:12:57 +0000
Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering
 information on acqui/supplier.pl
In-Reply-To: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21089-70-LNbriWPgHV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:13:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:13:15 +0000
Subject: [Koha-bugs] [Bug 21241] Set suggestion notices
 message_transport_type to sms if syspref is enabled and patron has an
 smsalertnumber but no email address
In-Reply-To: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21241-70-pCrkiiT0VL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:13:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:13:44 +0000
Subject: [Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date
 descending as a default
In-Reply-To: <bug-21399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21399-70-j3UU8utS3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:13:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:13:58 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-rqbbfboIzi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:14:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:14:24 +0000
Subject: [Koha-bugs] [Bug 21877] Show authorized value description for
 withdrawn in checkout
In-Reply-To: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21877-70-VFffi2oWx7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:14:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:14:25 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-KKmuxDuffx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
@RM: I understand the change done by this patch and why libraries are
requesting the new behaviour to be reverted. My only doubt is what the upgrade
path should be. Is anyone relying on the current behaviour 'features'?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:14:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:14:12 +0000
Subject: [Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry
	form to modal
In-Reply-To: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21573-70-pA6K0lf0mN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:14:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:14:46 +0000
Subject: [Koha-bugs] [Bug 21913] Clean up payment details page
In-Reply-To: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21913-70-SNK3bR7kni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:14:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:14:59 +0000
Subject: [Koha-bugs] [Bug 21930] Typo in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21930-70-W3wEavoEQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:15:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:15:23 +0000
Subject: [Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" -
 addorderiso2709.pl
In-Reply-To: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21989-70-ik0qhCowtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:16:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:16:07 +0000
Subject: [Koha-bugs] [Bug 22066] branchcode should be recorded for manual
	credits
In-Reply-To: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22066-70-ehJopvy4ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:15:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:15:51 +0000
Subject: [Koha-bugs] [Bug 22029] Remove Google+ from social links on OPAC
	detail
In-Reply-To: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22029-70-B4Jc0jGHec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22029

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:16:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:16:35 +0000
Subject: [Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
In-Reply-To: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22083-70-YQqaw6dAag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:16:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:16:51 +0000
Subject: [Koha-bugs] [Bug 22138] members/paycollect.pl has not been updated
 to have the new tab names
In-Reply-To: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22138-70-UsHptq3Qro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:17:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:17:17 +0000
Subject: [Koha-bugs] [Bug 22149] Grammar fix in the
 manage_circ_rules_from_any_libraries description
In-Reply-To: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22149-70-iwQhgLoqgZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:17:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:17:53 +0000
Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron
In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22203-70-yUR96GmJmx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:18:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:18:05 +0000
Subject: [Koha-bugs] [Bug 22207] Course reserves page does not have unique
	body id
In-Reply-To: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22207-70-CUEqHNkpQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22207

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:29:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:29:57 +0000
Subject: [Koha-bugs] [Bug 22216] New: Make {GET|PUT} /patrons/{patron_id}
	staff only
Message-ID: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

            Bug ID: 22216
           Summary: Make {GET|PUT} /patrons/{patron_id} staff only
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

Now that we voted to have a /public namespace for unprivileged access
endpoints, the existing /patrons endpoint needs to be adapted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:41:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:41:03 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-rvuLjwtBQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Needs a rebase after removal of dropbox mode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:45:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:45:29 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-clcZt61Nvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Needs small rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:55:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:55:04 +0000
Subject: [Koha-bugs] [Bug 15110] Improve decreaseHighHolds system preference
	description
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-8fyxIUB1bJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
  Attachment #84152|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:58:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:58:33 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-uQPh272FTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 15:58:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 14:58:36 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-sKMxzX32C6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84233|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84486&action=edit
Bug 22168: Improve styling of new chart settings for reports

This patch updates a number of aspects of the reports chart creation
interface: Chart creation form is now shown in a modal window, and a
separate link has been added to show or hide the chart itself.

Also changed: Minor markup and JavaScript cleanup.

To test, apply the patch and go to Reports -> Saved reports.

- Run a report which returns more than one column.
- On the report results page, click the "Create chart" button. The chart
  settings form should appear in a modal window.
- Confirm that the form controls work correctly: Each label should give
  focus to the correct input. Changing the chart type should show or
  hide the appropriate form fields.
- Click the "Draw" button. The modal should disappear and the chart
  should be shown.
- Above the chart should be a "Hide chart" link which works to hide (and
  then show) the chart.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:16:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:16:29 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-HNpT6lv3Mk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:16:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:16:41 +0000
Subject: [Koha-bugs] [Bug 22216] Make {GET|PUT} /patrons/{patron_id} staff
	only
In-Reply-To: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22216-70-uCl4Wpaxsf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22061


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061
[Bug 22061] Public route to change password
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:16:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:16:41 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-ytt2nv2KK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216
[Bug 22216] Make {GET|PUT} /patrons/{patron_id} staff only
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:30:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:30:44 +0000
Subject: [Koha-bugs] [Bug 21478] Koha::Hold->suspend_hold allows suspending
 in transit holds
In-Reply-To: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21478-70-nauUi6t7xA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84487&action=edit
Bug 21478: (QA follow-up) Make sure tests don't fail randomly

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:35:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:35:54 +0000
Subject: [Koha-bugs] [Bug 21485] When checking in books on hold,
 hitting "Enter" should do something else than "Ignore" which is now
 default
In-Reply-To: <bug-21485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21485-70-NgkUdAQMQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21485

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:38:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:38:12 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-HOw9CzrtmI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

--- Comment #75 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84488&action=edit
Bug 17006: (follow-up) set_password expects a hashref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 16:45:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 15:45:18 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-i6D17szeP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

--- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84489&action=edit
Bug 22061: (follow-up) set_password expects a hashref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:05:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:05:52 +0000
Subject: [Koha-bugs] [Bug 22216] Make {GET|PUT} /patrons/{patron_id} staff
	only
In-Reply-To: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22216-70-NPQbfc8kht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:08:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:08:03 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-56WKb5oza0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:08:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:08:11 +0000
Subject: [Koha-bugs] [Bug 15110] Improve decreaseHighHolds system preference
	description
In-Reply-To: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15110-70-3VKzntX6pc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:08:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:08:25 +0000
Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password
In-Reply-To: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17006-70-zW5JrUaytH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #76 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:08:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:08:37 +0000
Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron
 attributes" default on patron import
In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18661-70-L14ey9qwwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:09:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:09:10 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-lmVX6SSHaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:08:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:08:52 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-DzUaATIBGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:09:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:09:24 +0000
Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts
In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19994-70-t8wvIHj5OU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:09:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:09:43 +0000
Subject: [Koha-bugs] [Bug 20679] Remove 'rows per page' from reports print
	layout
In-Reply-To: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20679-70-sKTpWyVldo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20679

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:10:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:10:04 +0000
Subject: [Koha-bugs] [Bug 21290] POD of ModItem mentions MARC for items
In-Reply-To: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21290-70-yjzy69qBuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21290

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:10:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:10:51 +0000
Subject: [Koha-bugs] [Bug 21926] Enhance OAI-PMH:archiveID system preference
	description
In-Reply-To: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21926-70-fhgwZ8DBRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:11:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:11:13 +0000
Subject: [Koha-bugs] [Bug 21945] Clean up stock rotation template
In-Reply-To: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21945-70-INlpN7GpTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21945

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:11:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:11:26 +0000
Subject: [Koha-bugs] [Bug 21964] Switch two-column templates to Bootstrap
 grid: Patrons part 2
In-Reply-To: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21964-70-FYDZtho3Fd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:11:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:11:37 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
	Koha::REST::classes
In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22026-70-Wc1RJgparu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:11:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:11:50 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-NZnVgQkEbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #26 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:12:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:12:03 +0000
Subject: [Koha-bugs] [Bug 22102] Markup fixes for OPAC article request page
In-Reply-To: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22102-70-8nedBXVdnN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:12:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:12:14 +0000
Subject: [Koha-bugs] [Bug 22104] Clean up patron API keys template
In-Reply-To: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22104-70-tdaOEO4L87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22104

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:12:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:12:44 +0000
Subject: [Koha-bugs] [Bug 22124] Update cataloguing plugin system to not
 generate type parameter in script tag
In-Reply-To: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22124-70-9KBMCrXUS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22124

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:13:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:13:55 +0000
Subject: [Koha-bugs] [Bug 22134] Add account expiration information to
	patron details
In-Reply-To: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22134-70-gO3MG3fSbG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:14:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:14:09 +0000
Subject: [Koha-bugs] [Bug 22136] Import patrons notes hides a note because
 the syspref isn't referenced correctly
In-Reply-To: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22136-70-8qCdkVeVcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:14:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:14:23 +0000
Subject: [Koha-bugs] [Bug 22168] Improve styling of new chart settings for
	reports
In-Reply-To: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22168-70-d7XSGZPJrO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:26 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-PffvVMaFLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83157|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:29 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-S3cXUxivsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83158|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:32 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-CxjQ9WZJmn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83159|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:35 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-4asKXnhOdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83160|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:38 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-rK0pfycGad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83161|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:40 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-htFpVh8PGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83162|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:21:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:21:43 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-CYu1Phfks0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83163|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:05 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-WBQrWtmpKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #35 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84490&action=edit
Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:09 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-i2lPsdOp1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #36 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84491&action=edit
Bug 21798: Unify the creation of bibliographic record in tests

Using the newly created subroutine

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:13 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-86EPuRh4IY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #37 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84492&action=edit
Bug 21798: Fix a wrong test

Now biblioitem.itemtype has a value, GetItem should fill itype with this
value if item-level_itypes it not set

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:17 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-EvprbBm3Ja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #38 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84493&action=edit
Bug 21798: Fix another test

We should correctly generate the data we need, here we expect 2 records
with title starting with "Silence in the".

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:21 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-Weq5BQqLIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #39 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84494&action=edit
Bug 21798: Replace 2 more occurrences

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:25 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-wtXXtT2A6f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #40 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84495&action=edit
Bug 21798: replace gimme_a_biblio with build_sample_biblio

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:22:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:22:29 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-RDAxDyv8av@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #41 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84496&action=edit
Bug 21798: (QA follow-up) Fix Biblios.t

Global symbol "$bibnum" requires explicit package name

Test plan:
Run test

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:24:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:24:36 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-IRqWcQkGis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:38:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:38:31 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-w5Vd5166aQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #47 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84497&action=edit
Bug 20750: (follow-up) Fix dependency merge error

During the dependency merge the embed of status_alias in the API call
had got lost, resulting in the user defined statuses not displaying.
This patch fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:42:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:42:10 +0000
Subject: [Koha-bugs] [Bug 22217] New: error "Connection to the memcached
 servers '__MEMCACHED_SERVERS__' failed" during install
Message-ID: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217

            Bug ID: 22217
           Summary: error "Connection to the memcached servers
                    '__MEMCACHED_SERVERS__' failed" during install
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: giuseppe.ciaccio at unige.it
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

I'm trying to install Koha on a fresh Debian 9.7 32-bit, following the
instructions at https://wiki.koha-community.org/wiki/Koha_on_Debian  .  I work
as root so I have all privileges.

One of the installation steps consists of editing file
/etc/koha/koha-sites.conf .  Inside koha-sites.con, I find the following row:

USE_MEMCACHED="yes"

1.1) start memcached in the localhost
(this action is not reported in the instructions but is needed):

root at myhost:~# service memcached start

1.2) ensure that memcached is indeed active and listening at port 11211

root at myhost:~# ps ax
  PID TTY      STAT   TIME COMMAND
...
16908 ?        S      0:00 /usr/sbin/apache2 -k start
16909 ?        S      0:00 /usr/sbin/apache2 -k start
16910 ?        S      0:00 /usr/sbin/apache2 -k start
16920 ?        Ssl    0:00 /usr/bin/memcached -m 64 -p 11211 -u memcache -l
127.
...

1.3) proceed with install procedure, get worrying error messages

root at myhost:~# koha-create --create-db mylibrary

Koha instance is empty, no staff user created.
[ ok ] Starting Koha indexing daemon for mylibrary:.

root at myhost:~# koha-translate --install it-IT

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues
Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 197.
Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 239.

1.4) at this point, try not to use memcached and repeat the koha-translate
step, get same error as before

root at myhost:~# vi /etc/koha/koha-sites.conf
...set USE_MEMCACHED="no"

root at myhost:~# koha-translate --update it-IT

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues

Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the
unix socket permissions set properly? Is the host reachable?
If you ignore this warning, you will face performance issues
Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 197.
Use of uninitialized value $pref_name in concatenation (.) or string at
/usr/share/koha/misc/translator/LangInstaller.pm line 239.


So it seems that

I) the language installer tries to connect to memcached, no matter the value of
USE_MEMCACHED

II) the language installer fails to connect to memcached even if the daemon is
up and listening to the right port.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 17:42:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 16:42:48 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-2YMB5Cg5X8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

--- Comment #74 from Josef Moravec <josef.moravec at gmail.com> ---
So, started the first QA run ;)

First of all, I really like this enhancement and would to see it in Koha.

But this need some more work I think, first some not critical and easy to fix:
- System preference SummaryHoldings is missing in db updates
- Holdings marc framework is missing from db update
- Schema files should be attached in its own patch
- I do not like using subfield "V" as default for linking item to holding,
uppercase letters for subfields are not possible in marc21 standard

But, the main problem I see here is C4::Holdings module - C4 namespace is
deprecated, and should not be used for new modules, you always should add the
new modules into Koha namespace and use objects if possible and if it does make
sense, of course. You already have Koha::Holdings and
Koha::Holdings::Metadatas, so you should add new routines here (in the
Koha::Objects(s) manner).

See also bug 22144, that's the way the holdings, holding::metadatas and its
marc record object should be linked together too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 18:10:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 17:10:31 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
	events
In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20750-70-OPwFpUFiDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #48 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84498&action=edit
Bug 20750: (follow-up) Fix logging of status changes

Since this bug now is dependent on Bug 20581, it should be aware of the
custom statuses provided in 20581. This patch enables logging of request
statuses being changed to custom ones. As such the test plan is
modified:

To test:
- Apply patch
- Ensure the Illlog logging preference is turned on
- Ensure you have some custom request statuses defined in the
Authorised Values ILLSTATUS category
- Create an ILL request and perform actions on it that change it's
status.
- Edit the request and change status to a custom one
- Navigate to the "Manage ILL request" screen
- Click the "Display request log" button
- Observe that a modal opens displaying a summary of the status changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 18:24:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 17:24:40 +0000
Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB
	more easily
In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22210-70-OJCacMv7YC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I agree! As long as the Mana registration is global for the whole Koha instance
it makes sense to allow for a more general account.

Right now I don't think it's clear to the user why the interface asks for their
name... Is that information going to be displayed somewhere?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:20:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:20:54 +0000
Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP
In-Reply-To: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20292-70-5nT34J7gjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292

Christopher Davis <cgdavis at uintah.utah.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgdavis at uintah.utah.gov

--- Comment #2 from Christopher Davis <cgdavis at uintah.utah.gov> ---
Greetings devs,

This bug needs some love. If my institution is the one which is sponsoring this
development, am I allowed to signoff this patch?

Thank you,

Christopher Davis

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:43:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:43:44 +0000
Subject: [Koha-bugs] [Bug 22218] New: Make endpoints not in /public require
 privileged credentials [OMNIBUS]
Message-ID: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218

            Bug ID: 22218
           Summary: Make endpoints not in /public require privileged
                    credentials [OMNIBUS]
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

Some existing endpoints need to be adjusted so privileged access is mandatory.
For example:

GET /cities

If a public endpoint offering a similar functionality is required, it needs to
be published in the /public namespace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:44:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:44:07 +0000
Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require
 privileged credentials [OMNIBUS]
In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22218-70-YkoqvzFJO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216
[Bug 22216] Make {GET|PUT} /patrons/{patron_id} staff only
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:44:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:44:07 +0000
Subject: [Koha-bugs] [Bug 22216] Make {GET|PUT} /patrons/{patron_id} staff
	only
In-Reply-To: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22216-70-SwCZBnnCGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22218


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218
[Bug 22218] Make endpoints not in /public require privileged credentials
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:47:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:47:25 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-j363kIClsn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think advertising it in the release notes should be ok - the change was not
that far ago. Maybe add some "text to go in the release notes". 

I'd like to have the revert followed-up by some patch that makes the changes
keeping the additional use cases in mind. A hold that can't be trapped should
not be placed with override as this is still confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:50:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:50:43 +0000
Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of
 OPAC result list
In-Reply-To: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21850-70-el9UsAC4IK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84499&action=edit
Bug 21850: (follow-up) Add query information in title attribute

This follow-up adds back the old machine-friendly search details to a
title attribute in case it might be useful for debugging purposes.

To test, apply the patch and perform a search in the OPAC. On the search
results page, hover your mouse over the "Results" link in the
breadcrumbs. The title attribute value should appear with the search
details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:53:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:53:38 +0000
Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require
 privileged credentials [OMNIBUS]
In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22218-70-dgS1Ny9JNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006
[Bug 20006] Adapt /v1/holds to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:53:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:53:38 +0000
Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines
In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20006-70-IlNZMiwKZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22218


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218
[Bug 22218] Make endpoints not in /public require privileged credentials
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:53:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:53:45 +0000
Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require
 privileged credentials [OMNIBUS]
In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22218-70-Q3KeuD7KEY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 19:53:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 18:53:50 +0000
Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require
 privileged credentials [OMNIBUS]
In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22218-70-1ZVLoxLDv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:01:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:01:49 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-z6aCaNwn71@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84317|0                           |1
        is obsolete|                            |

--- Comment #48 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 84501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84501&action=edit
Bug 21751: Remove former fixFloat plugin

Signed-off-by: David Cook <dcook at prosentient.com.au>

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:01:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:01:52 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-xItFDOx6Sz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84476|0                           |1
        is obsolete|                            |

--- Comment #49 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 84502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84502&action=edit
Bug 21751: (follow-up) Correction to selectors

This patch makes a couple of corrections to the selectors used by
hcsticky in targeting the position of the floating toolbar. These
changes were made necessary by changes made in recently-pushed patches.

To test, confirm that these two pages work correctly:

 - Acquisitions -> Vendor -> View basket
 - Patrons -> New patron

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:01:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:01:34 +0000
Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in
	Chrome
In-Reply-To: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21751-70-Zyz4SIi7uk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84316|0                           |1
        is obsolete|                            |

--- Comment #47 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 84500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84500&action=edit
Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display

This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky
(https://github.com/somewebmedia/hc-sticky). This plugin provides the
same functionality without the page-reflow problems fixFloat suffers
from.

To test, apply the patch and regenerate the staff client CSS. Test the
behavior of the floating toolbar on these pages:

 - Acquisitions -> Vendor -> Vendor details
 - Acquisitions -> Vendor -> View basket
   - On both these pages, test toolbar behavior before and after
     expanding the "Orders search" options at the top of the page.
 - Administration -> System preferences
 - Authorities -> Create or edit an authority
 - Catalog -> Advanced search
   - Search results
 - Catalog -> Item search
 - Cataloging -> Add or edit a record
   - Open the plugin window for the 008 field
 - Tools -> Label creator -> New label batch -> Add items -> Search ->
   Results
 - Patrons -> New patron
   - Test before and after expanding the patron search options at the
     top of the page
   - Test editing a patron too
 - Tools -> Automatic item modifications by age -> Edit
 - Tools -> Notices & slips -> Edit
 - Lists -> View list

Check that the About page has been updated with information about the
plugin.

Signed-off-by: David Cook <dcook at prosentient.com.au>

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:27:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:27:13 +0000
Subject: [Koha-bugs] [Bug 22219] New: C4::Biblio->GetItemsForInventory can
 return wrong count / duplicated items when skipping waiting holds
Message-ID: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219

            Bug ID: 22219
           Summary: C4::Biblio->GetItemsForInventory can return wrong
                    count / duplicated items when skipping waiting holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The SQL does a left join to reserves ON (itemnumber)

If there are multiple item-specific holds we will get multiple results for a
biblio

Discovered while running tests on bug 21798

To recreate:
1 - place several holds on a specific item
2 - prove -v t/db_dependent/Items/GetItemsForInventory
3 - It fails

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:28:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:28:42 +0000
Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return
 wrong count / duplicated items when skipping waiting holds
In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22219-70-ncrJXEcNeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21413
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |tomascohen at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413
[Bug 21413] Inventory - Allow skipping items with waiting holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:28:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:28:42 +0000
Subject: [Koha-bugs] [Bug 21413] Inventory - Allow skipping items with
	waiting holds
In-Reply-To: <bug-21413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21413-70-RHWYrXbDrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22219


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219
[Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count /
duplicated items when skipping waiting holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:29:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:29:39 +0000
Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is
 faulty when there are waiting/intransit holds
In-Reply-To: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21608-70-J7VApAlHAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:29:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:29:45 +0000
Subject: [Koha-bugs] [Bug 11722] Hold status not updated after change while
	in transit
In-Reply-To: <bug-11722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11722-70-G9KfvaP7b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11722

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 20:29:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 19:29:51 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-f4geEy9hdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 21:03:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 20:03:13 +0000
Subject: [Koha-bugs] [Bug 21241] Set suggestion notices
 message_transport_type to sms if syspref is enabled and patron has an
 smsalertnumber but no email address
In-Reply-To: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21241-70-uceRHPNgp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

--- Comment #22 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Thanks Martin, Nick, Katrin and Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 21:57:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 20:57:26 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-aOzRxnAwIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 21:57:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 20:57:55 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-PzbbynHC5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 21:57:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 20:57:59 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-QfjZjvlC3H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84451|0                           |1
        is obsolete|                            |
  Attachment #84452|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84503&action=edit
Bug 22196: Clean up Mana KB administration template

This patch makes language changes to the Mana KB administration
template, and corresponding language changes to the Web Services
preference file.

Some markup errors have been fixed:

 - Correct title and breadcrumbs, copied and pasted from another
   template
 - Add ids to form fields to match their label "for" attributes
 - Make <input>s self-closing
 - Correct class names on alert dialogs
 - Wrap text in JavaScript with _() to make it translatable

Also changed: Some language revisions to the Mana dialogs on the
Administration home page.

To test, apply the patch and go to Administration -> Share content with
Mana KB.

Test the process for enabling and configuring Mana KB. Check that
forms work correctly and that the language of instructions and labels
reads well.

Go to Administration -> System preferences -> Web services, and confirm
that the language changes to the Mana KB preference look good.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 21:58:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 20:58:05 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-hTy32C3nrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84504&action=edit
Bug 22196: (QA follow-up) Fix some typo

Fixes the typo on the admin main page.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 21:58:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 20:58:09 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-2aQXDeXgbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84505&action=edit
Bug 22196: (QA follow-up) Fix some more typo

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:05:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:05:57 +0000
Subject: [Koha-bugs] [Bug 21971] TestBuilder::build_sample_item
In-Reply-To: <bug-21971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21971-70-zqpLi4PGed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:06:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:06:06 +0000
Subject: [Koha-bugs] [Bug 21798] We need
	t::lib::TestBuilder::build_sample_biblio
In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21798-70-WclOtu64tL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:06:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:06:19 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-lwj43eXvBX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:08:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:08:22 +0000
Subject: [Koha-bugs] [Bug 22220] New: Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
Message-ID: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

            Bug ID: 22220
           Summary: Error in ReWriteRule for 'bib' in
                    apache-shared-intranet.conf
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

To recreate:
1 - visit https://localhost:8081/bib/1
   or any valid biblionumber
2 - 404 not found error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:17:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:17:05 +0000
Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers
 '__MEMCACHED_SERVERS__' failed" during install
In-Reply-To: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22217-70-HInnnIkbtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |ulrich.kleiber at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:36:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:36:56 +0000
Subject: [Koha-bugs] [Bug 22221] New: Changing an item to a Lost Status on
 an item level hold does not change the hold
Message-ID: <bug-22221-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22221

            Bug ID: 22221
           Summary: Changing an item to a Lost Status on an item level
                    hold  does not change the hold
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

If a library is using Item Level holds and a patron places a specific item
hold.   If the library finds that this specific item is missing, they can
change the item to missing, however, the hold is still attached to this item. 
The library then needs to remove the item level hold and re-attach it to
another item or make it a bib level hold.  It would be nice, if this change of
"Lost" status of this item is altered, the hold can be changed to a bib level
hold or an easy ability to adjust the hold as necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 28 22:38:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 21:38:41 +0000
Subject: [Koha-bugs] [Bug 22221] Changing an item to a Lost Status on an
 item level hold does not change the hold
In-Reply-To: <bug-22221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22221-70-uodk37w29e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think changing to a bib level hold might not be the right thing as the other
items might not be the 'same' (thinking about holds on serial issues or mixed
materials with items attached to one record)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 00:07:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Jan 2019 23:07:56 +0000
Subject: [Koha-bugs] [Bug 22201] Spine labels are blank when exporting batch
In-Reply-To: <bug-22201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22201-70-KNXgulVVsJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22201

jamilajannac at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamilajannac at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 03:00:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 02:00:38 +0000
Subject: [Koha-bugs] [Bug 22222] New: Mana subscription search always
	returns all results
Message-ID: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222

            Bug ID: 22222
           Summary: Mana subscription search always returns all results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: release-notes-needed
          Severity: normal
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: alex.arnaud at biblibre.com, alexbuckley at catalyst.net.nz,
                    baptiste.wojtkowski at biblibre.com, bibliwho at gmail.com,
                    black23 at gmail.com, brendan at bywatersolutions.com,
                    claire.hernandez at biblibre.com,
                    dcook at prosentient.com.au, hagud at orex.es,
                    jesse at bywatersolutions.com,
                    jonathan.druart at bugs.koha-community.org,
                    josef.moravec at gmail.com, katrin.fischer at bsz-bw.de,
                    kyle at bywatersolutions.com, lisetteslatah at gmail.com,
                    m.de.rooy at rijksmuseum.nl,
                    marjorie.barry-vila at collecto.ca,
                    morgane.alonso at biblibre.com, mtj at kohaaloha.com,
                    nick at bywatersolutions.com, paul.poulain at biblibre.com,
                    vfernandes at keep.pt
        Depends on: 17047
  Target Milestone: ---

No matter what title string I submit I always get 3852 results back.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 03:00:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 02:00:38 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-dhtWj2z7rm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22222


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222
[Bug 22222] Mana subscription search always returns all results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 03:01:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 02:01:20 +0000
Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all
	results
In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22222-70-To9growvjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
                 CC|alexbuckley at catalyst.net.nz |
                   |,                           |
                   |baptiste.wojtkowski at biblibr |
                   |e.com, bibliwho at gmail.com,  |
                   |black23 at gmail.com,          |
                   |brendan at bywatersolutions.co |
                   |m,                          |
                   |claire.hernandez at biblibre.c |
                   |om,                         |
                   |dcook at prosentient.com.au,   |
                   |hagud at orex.es,              |
                   |jesse at bywatersolutions.com, |
                   |jonathan.druart at bugs.koha-c |
                   |ommunity.org,               |
                   |josef.moravec at gmail.com,    |
                   |katrin.fischer at bsz-bw.de,   |
                   |kyle at bywatersolutions.com,  |
                   |lisetteslatah at gmail.com,    |
                   |m.de.rooy at rijksmuseum.nl,   |
                   |marjorie.barry-vila at collect |
                   |o.ca,                       |
                   |morgane.alonso at biblibre.com |
                   |, mtj at kohaaloha.com,        |
                   |nick at bywatersolutions.com,  |
                   |paul.poulain at biblibre.com,  |
                   |vfernandes at keep.pt          |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 04:20:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 03:20:12 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-q15VoxqEh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #9)
> We should probably remove all fork calls. Resolve it with an ajax call (like
> the upload in one of these scripts) or via a queue serviced by some daemon.
> In general, it seems better to prevent starting jobs directly by the web
> interface.

I totally agree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 06:14:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 05:14:25 +0000
Subject: [Koha-bugs] [Bug 22223] New: Item url double-encode when parameter
 is an encoded URL
Message-ID: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223

            Bug ID: 22223
           Summary: Item url double-encode when parameter is an encoded
                    URL
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

The following use of the "url" filter is problematic:

[% IF Koha.Preference("OPACURLOpenInNewWindow") %]
<a target="_blank" rel="noreferrer" href="[% ITEM_RESULT.uri | url %]"
property="url">[% ITEM_RESULT.uri | html %]</a>
[% ELSE %]
<a href="[% ITEM_RESULT.uri | url %]" property="url">[% ITEM_RESULT.uri | html
%]</a>
[% END %]

If ITEM_RESULT.uri is
"https://idp.com?redirect_url=https%3A%2F%2Fsomewhere_else.com", then the
percent signs in the argument to the "redirect_url" parameters will be encoded
incorrectly and the result will be
"https://idp.com?redirect_url=https%253A%252F%252Fsomewhere_else.com", which is
obviously an invalid URL. 

Can we really expect that no one will ever include a URL with URI encoded
parameters?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 06:58:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 05:58:16 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-r6RrLdc5Sc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 07:41:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 06:41:51 +0000
Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB
	more easily
In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22210-70-zO9mLVRowp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 08:46:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 07:46:19 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-kFRpQCKUkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 08:52:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 07:52:13 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-QTqZhz9Atv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #75 from Ere Maijala <ere.maijala at helsinki.fi> ---
Ok, I'll revise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 09:11:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 08:11:15 +0000
Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all
	results
In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22222-70-UxeWIYLFzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 11:16:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 10:16:57 +0000
Subject: [Koha-bugs] [Bug 22224] New: ILL Request has hard-coded email
 subject and body message
Message-ID: <bug-22224-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22224

            Bug ID: 22224
           Summary: ILL Request has hard-coded email subject and body
                    message
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at koha-suomi.fi
  Target Milestone: ---

Illrequest.pm:

        my $draft->{subject} = "ILL Request";
        $draft->{body} = <<EOF;
Dear Sir/Madam,

    We would like to request an interlibrary loan for a title matching the
following description:

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 11:19:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 10:19:04 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-3mVNhEuxQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22224


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22224
[Bug 22224] ILL Request has hard-coded email subject and body message
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 11:19:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 10:19:04 +0000
Subject: [Koha-bugs] [Bug 22224] ILL Request has hard-coded email subject
 and body message
In-Reply-To: <bug-22224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22224-70-RgbMfYd4De@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22224

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 11:27:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 10:27:42 +0000
Subject: [Koha-bugs] [Bug 22224] ILL Request has hard-coded email subject
 and body message
In-Reply-To: <bug-22224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22224-70-IVsve4Mnht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22224

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 12:38:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 11:38:21 +0000
Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search
In-Reply-To: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8778-70-j6F8uutJN3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #5)
> I am volunteering to do the first part: Add Keyword, Phrase to the advanced
> search.

Cool thanks a lot

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 12:47:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 11:47:38 +0000
Subject: [Koha-bugs] [Bug 21495] Regression in hold override functionality
In-Reply-To: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21495-70-CSjOcf7tdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21495

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #9)
> I think advertising it in the release notes should be ok - the change was
> not that far ago. Maybe add some "text to go in the release notes". 
> 
> I'd like to have the revert followed-up by some patch that makes the changes
> keeping the additional use cases in mind. A hold that can't be trapped
> should not be placed with override as this is still confusing.

If we capture why the hold needs an override, we could tell the librarian if
the force is likely to result in an unfillable hold or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:02:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:02:56 +0000
Subject: [Koha-bugs] [Bug 22225] New: Tax hints and prices on
 orderreceive.pl may not match
Message-ID: <bug-22225-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22225

            Bug ID: 22225
           Summary: Tax hints and prices on orderreceive.pl may not match
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

In the perl script we test whether the vendor invoice prices include tax:
if ( $bookseller->invoiceincgst ) {
    $rrp = $order->{rrp_tax_included};
    $ecost = $order->{ecost_tax_included};
    unless ( $unitprice != 0 and defined $unitprice) {
        $unitprice = $order->{ecost_tax_included};
    }
} else {
    $rrp = $order->{rrp_tax_excluded};
    $ecost = $order->{ecost_tax_excluded};
    unless ( $unitprice != 0 and defined $unitprice) {
        $unitprice = $order->{ecost_tax_excluded};
    }
}


In the template we test whether the vendor list prices include tax:
        <li><label for="rrp">Retail price: </label>[% rrp | $Price %] <span
class="hint">(adjusted for [% cur_active | html %], [% IF (listincgst == 1)
%]tax inclusive[% ELSE %]tax exclusive[% END %])</span></li>
        <li>
            <label for="replacementprice">Replacement price:</label>
            <input type="text" size="20" name="replacementprice"
id="replacementprice" value="[% replacementprice | $Price %]" />
        </li>
        <li><label for="ecost">Budgeted cost: </label>[% ecost | $Price %]
<span class="hint">[% IF (listincgst == 1) %](tax inclusive)[% ELSE %](tax
exclusive)[% END %]</span></li>
        <li>
            <label for="unitprice">Actual cost:</label>
            <input type="text" size="20" name="unitprice" id="unitprice"
value="[% unitprice | $Price on_editing => 1 %]" /> <span class="hint">[% IF
(invoiceincgst == 1) %](tax inclusive)[% ELSE %](tax exclusive)[% END %]</span>
        </li>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:03:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:03:22 +0000
Subject: [Koha-bugs] [Bug 22225] Tax hints and prices on orderreceive.pl may
	not match
In-Reply-To: <bug-22225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22225-70-wk20jUR640@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22225

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:03:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:03:48 +0000
Subject: [Koha-bugs] [Bug 22225] Tax hints and prices on orderreceive.pl may
	not match
In-Reply-To: <bug-22225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22225-70-gXijMv9lVc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22225

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21619, 21387


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387
[Bug 21387] Receive items from - form should include tax hints the same as the
ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619
[Bug 21619] Tax hints should not be abbreviated
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:03:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:03:48 +0000
Subject: [Koha-bugs] [Bug 21387] Receive items from - form should include
 tax hints the same as the ordering form
In-Reply-To: <bug-21387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21387-70-qOzamvmSn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22225


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22225
[Bug 22225] Tax hints and prices on orderreceive.pl may not match
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:03:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:03:48 +0000
Subject: [Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
In-Reply-To: <bug-21619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21619-70-CUhxNLnYMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22225


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22225
[Bug 22225] Tax hints and prices on orderreceive.pl may not match
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:34:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:34:37 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-9NE2NVJ0Wr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:44:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:44:41 +0000
Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the
 accountline date
In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22200-70-BRrxiLWVBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Pierre-Marc Thibault from comment #2)
> I created a fine and changed it so its date is not today. I went to Pay
> fines and paid, but the date did not update. Am I doing something wrong?

That is not the action I meant. You'll need to check in the item with the
"forgive fine" option from the checkins page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 14:45:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 13:45:14 +0000
Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the
 accountline date
In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22200-70-So9Ms59m7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Pierre-Marc Thibault from comment #3)
> Sorry, I didn't follow the steps precisely. I didn't test on the checking in
> page, but I did by the Create manual credit way and it wasn't still working.

To test, you'll need a checked out overdue item with fines. Nothing else will
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:04:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:04:06 +0000
Subject: [Koha-bugs] [Bug 22216] Make GET /patrons/{patron_id} staff only
In-Reply-To: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22216-70-nvhvmtgkhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make {GET|PUT}              |Make GET
                   |/patrons/{patron_id} staff  |/patrons/{patron_id} staff
                   |only                        |only

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:10:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:10:01 +0000
Subject: [Koha-bugs] [Bug 22216] Make GET /patrons/{patron_id} staff only
In-Reply-To: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22216-70-rqy856sQGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:10:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:10:04 +0000
Subject: [Koha-bugs] [Bug 22216] Make GET /patrons/{patron_id} staff only
In-Reply-To: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22216-70-2BDkBpIa6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84506&action=edit
Bug 22216: Make GET /patrons/{patron_id} staff only

This patch removes the possibility to access the patron object
identified by patron_id by the patron itself, or a guarantor.

It does so by removing the permissions from the spec. The tests are
adjusted to remove that use case.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:20:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:20:13 +0000
Subject: [Koha-bugs] [Bug 22226] New: Add status information to Z39.50
 server administration
Message-ID: <bug-22226-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22226

            Bug ID: 22226
           Summary: Add status information to Z39.50 server administration
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Z39.50 / SRU / OpenSearch Servers
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barbara.johnson at bedfordtx.gov
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

On the list of Z39.50 servers at /admin/z3950servers.pl there is no way to tell
whether a server is correctly configured or not. It would be helpful to display
this information.

- On the list of servers add a column to indicate the status (such as Active,
Inactive, In Testing, Not working, etc.) of a Z39.50 server

- On the diplay for a specific server, add a field to include the status
information

- Allow libraries to select their own wording for the statuses

- Allow libraries to block the display of Z39.50 servers with certain statuses
from showing up when using a Z39.50 search with the Advanced Cataloging Editor,
the basic editor, creating a new record via Z39.50 or creating a new order via
Z39.50

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:41:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:41:05 +0000
Subject: [Koha-bugs] [Bug 22227] New: Make GET /cities staff only
Message-ID: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

            Bug ID: 22227
           Summary: Make GET /cities staff only
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
  Target Milestone: ---

Now that we voted to have a /public namespace for unprivileged access
endpoints, the existing /cities endpoint needs to be adapted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:41:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:41:41 +0000
Subject: [Koha-bugs] [Bug 22227] Make GET /cities staff only
In-Reply-To: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22227-70-86BUiQeN31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:41:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:41:44 +0000
Subject: [Koha-bugs] [Bug 22227] Make GET /cities staff only
In-Reply-To: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22227-70-f2yZxbRomM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84507&action=edit
Bug 22227: Make GET /cities staff only

This patch removes the possibility to access the city objects without
privileged access (minimum permissions == catalogue).

It does so by adding the required permissions to the spec. The tests are
adjusted.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/cities.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:43:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:43:32 +0000
Subject: [Koha-bugs] [Bug 22227] Make GET /cities staff only
In-Reply-To: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22227-70-TrIPQl7zfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22218
         Depends on|                            |22061


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061
[Bug 22061] Public route to change password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218
[Bug 22218] Make endpoints not in /public require privileged credentials
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:43:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:43:32 +0000
Subject: [Koha-bugs] [Bug 22061] Public route to change password
In-Reply-To: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22061-70-f5kseRTO1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22227


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227
[Bug 22227] Make GET /cities staff only
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 15:43:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 14:43:32 +0000
Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require
 privileged credentials [OMNIBUS]
In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22218-70-BUMBAs843l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22227


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227
[Bug 22227] Make GET /cities staff only
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 17:30:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 16:30:23 +0000
Subject: [Koha-bugs] [Bug 22228] New: Elasticsearch - standalone colons
 should be escaped when performing a search
Message-ID: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228

            Bug ID: 22228
           Summary: Elasticsearch - standalone colons should be escaped
                    when performing a search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
  Target Milestone: ---

Currently if you search with a colon it can cause failure or no results

To recreate:
Search for a term containing a colon
i.e. Harry potter : the creature vault
Note search fails
Now try
Harry potter \: the creature vault
It works (maybe returns nothing)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 17:36:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 16:36:57 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
	editor
In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8976-70-jATirLvdA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 17:38:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 16:38:47 +0000
Subject: [Koha-bugs] [Bug 22229] Elasticsearch - fields do not have aliases
 - Koha should always use the common term internally
In-Reply-To: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22229-70-ktDEAWhDcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22229

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 17:38:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 16:38:35 +0000
Subject: [Koha-bugs] [Bug 22229] New: Elasticsearch - fields do not have
 aliases - Koha should always use the common term internally
Message-ID: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22229

            Bug ID: 22229
           Summary: Elasticsearch - fields do not have aliases - Koha
                    should always use the common term internally
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
  Target Milestone: ---

This problem was discovered in the advanced search - when limiting by shelving
location the search is composed as 
limit=mc-loc:{term}

this fails in ES because the index is setup as 'location'

What works in both is:
limit=location:{term} 

We either need to build field aliases into ES
(https://www.elastic.co/guide/en/elasticsearch/reference/master/alias.html)

Or make sure to use consistent names across Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 19:33:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 18:33:26 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
	status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-kjlRAub84Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Laura Horgan <horganl at middlesex.mass.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |horganl at middlesex.mass.edu

--- Comment #9 from Laura Horgan <horganl at middlesex.mass.edu> ---
We are also interested in an update of this enhancement. Once a request is
funded what is the procedure for moving an option into development.  I don't
believe all the libraries in our group are interested in this feature so it
would be good if each library could decide for itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 20:09:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 19:09:36 +0000
Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be
 escaped when performing a search
In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22228-70-0HP0TTtdI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 20:57:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 19:57:23 +0000
Subject: [Koha-bugs] [Bug 22230] New: Make SearchWithISBNVariations search
 in index keyword
Message-ID: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230

            Bug ID: 22230
           Summary: Make SearchWithISBNVariations  search in index keyword
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

Hi, 

the SearchWithISBNVariations system preference does not search for variants in
the index keyword (kw, wrdl). It is imperative to use the ISBN index (nb) for
this kind of search. It would be nice if this system preference makes it
possible to search the ISBN variants in the index keyword as well.

Thanks, Patrick

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 21:33:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 20:33:02 +0000
Subject: [Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in
	index keyword
In-Reply-To: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22230-70-A0MTBdQDz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Patrick, can you explain your use case?

I think it could pose problems in some use cases. As the 7xx and 8xx fields can
also contain ISBNs for the records they link to, you'd potentially end up with
a lot more records as result.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 21:34:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 20:34:36 +0000
Subject: [Koha-bugs] [Bug 22229] Elasticsearch - fields do not have aliases
 - Koha should always use the common term internally
In-Reply-To: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22229-70-HkvrsBADwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Would this be solved by bug 19575?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 21:35:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 20:35:23 +0000
Subject: [Koha-bugs] [Bug 22229] Elasticsearch - fields do not have aliases
 - Koha should always use the common term internally
In-Reply-To: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22229-70-zwln5z5FB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19575

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 21:35:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 20:35:23 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-OeLFGOIqzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22229

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 21:58:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 20:58:40 +0000
Subject: [Koha-bugs] [Bug 22231] New: add the filter on the subscription end
 date in the Check expiration report
Message-ID: <bug-22231-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22231

            Bug ID: 22231
           Summary: add the filter on the subscription end date in the
                    Check expiration report
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
  Target Milestone: ---

Hi, 

In the page to check the expiration dates (checkexpiration.pl), it would be
nice to have a search field to enter the end date of subscription. In this way
we could choose to check the subscriptions according to the renewal date or the
end date of the subscription. In this way we could choose to generate the
report based on one or one of these fields.it would be useful to be able to
generate this report according to the end dates of subscription. 

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 29 23:53:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 22:53:40 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-0lzJSKvLgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED
                 CC|                            |aleisha at catalyst.net.nz
           Assignee|alexbuckley at catalyst.net.nz |aleisha at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 00:31:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 23:31:05 +0000
Subject: [Koha-bugs] [Bug 22232] New: Advanced Cataloguing Editor (Rancor)
 to edit authority records?
Message-ID: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

            Bug ID: 22232
           Summary: Advanced Cataloguing Editor (Rancor) to edit authority
                    records?
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: clopez at dml.vic.edu.au
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Dear colleagues
How hard would it be to allow Rancor to edit authority records?
Regards,
Carlos Lopez
Dalton McCaughey Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 00:52:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Jan 2019 23:52:43 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-lPi4X3Z0Tf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #193 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Aleisha is going to manage/work on the upstreaming of the patches on this bug
report, as I am unlikely to have enough time to do this for the next while.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 04:22:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 03:22:40 +0000
Subject: [Koha-bugs] [Bug 22233] New: Fines forgiven
Message-ID: <bug-22233-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22233

            Bug ID: 22233
           Summary: Fines forgiven
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mustaqeemabd at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Hi,

I'm using Koha 18.05.05. The problem is:

- patron has overdue fines. For example 3.40
- the amount has been forgiven using 'Create Manual Credit'.
- total amount in account is deducted from the forgiven amount, but the amount
remain same in 'Pay Fines' tab.
- if I write off the amount in 'Pay Fines', that 3.40 is count as credit in 
patron account.
- it is endless process if I create another invoice to clear that credited
amount. No outstanding amount in account, but there is outstanding amount in
'Pay Fines'.

thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 04:22:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 03:22:55 +0000
Subject: [Koha-bugs] [Bug 22233] Fines forgiven
In-Reply-To: <bug-22233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22233-70-snjcofCu9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22233

mustaqeem <mustaqeemabd at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mustaqeemabd at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:03:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:03:43 +0000
Subject: [Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
In-Reply-To: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21912-70-qFwwwI2CxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:07:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:07:44 +0000
Subject: [Koha-bugs] [Bug 22107] Avoid deleting data in some tests
In-Reply-To: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22107-70-txjULuUawR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22107

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Tests impacted are not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:08:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:08:43 +0000
Subject: [Koha-bugs] [Bug 21866] Warning: This *report* was written for an
 older version of Koha. Run at your own risk.
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-CcaPuVHbhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:16:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:16:28 +0000
Subject: [Koha-bugs] [Bug 22095] Dead link in web installer
In-Reply-To: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22095-70-DljgUY9Ffz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22095

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:19:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:19:16 +0000
Subject: [Koha-bugs] [Bug 22054] Display a nicer error message when trying
 to renew an on-site checkout from renew page
In-Reply-To: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22054-70-VohbsNjOgb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:20:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:20:40 +0000
Subject: [Koha-bugs] [Bug 20165] Capitalization: Street Address should be
 Street address in patron search options
In-Reply-To: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20165-70-Rj9VEF51HQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I dont push to 17.11.x to minimize translation work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:21:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:21:28 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-PUKCIzSwnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I dont push to 17.11.x to minimize translation work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:24:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:24:14 +0000
Subject: [Koha-bugs] [Bug 22036] Tidy up tags/review script
In-Reply-To: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22036-70-I5B9X5ibyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22036

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Not a real bug, I prefer not to push to 17.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:25:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:25:16 +0000
Subject: [Koha-bugs] [Bug 21637] Capitalization: EasyAnalyticalRecords
 syspref option "Don't Display" should be "Don't display"
In-Reply-To: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21637-70-d5aDL3mYHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I prefer not to push to 17.11.x to minimize translation work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:26:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:26:42 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-MTvkspBo8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I prefer not to push to 17.11.x to minimize translation work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:27:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:27:33 +0000
Subject: [Koha-bugs] [Bug 22085] UNIMARC default XSLT broken by Bug 14716
In-Reply-To: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22085-70-opuCQxX2Jd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22085

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 14716 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:43:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:43:24 +0000
Subject: [Koha-bugs] [Bug 21491] When 'Default lost item fee refund on
 return policy' is unset it says no but acts as if 'yes'
In-Reply-To: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21491-70-PHSixYa6yz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:48:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:48:18 +0000
Subject: [Koha-bugs] [Bug 22082] Ambiguous column in patron stats
In-Reply-To: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22082-70-gKVNegggKH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:51:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:51:45 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-X5BdmwxTKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Bug 19489 depends on bug 22006, which changed state.

Bug 22006 Summary: Koha::Account::Line->item should return undef if no item linked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 09:51:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 08:51:45 +0000
Subject: [Koha-bugs] [Bug 22006] Koha::Account::Line->item should return
 undef if no item linked
In-Reply-To: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22006-70-M4pFB4l2QI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 12001 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 10:09:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 09:09:25 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-oWtJ0ZRkVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
New year, new request for next steps.. be nice to get this moving again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 10:10:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 09:10:55 +0000
Subject: [Koha-bugs] [Bug 22008] Missing constraints on accountlines
In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22008-70-pfnH6iDpqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 10:30:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 09:30:37 +0000
Subject: [Koha-bugs] [Bug 22209] Move stock rotation stage and item forms
	into modals
In-Reply-To: <bug-22209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22209-70-avcgB0zNfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 11:11:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 10:11:52 +0000
Subject: [Koha-bugs] [Bug 21657] Mojo::Util::slurp is DEPRECATED in favor of
 Mojo::File::slurp
In-Reply-To: <bug-21657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21657-70-Oiw8NiEyxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21657

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |tomascohen at gmail.com
         Resolution|---                         |WONTFIX

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Do you see them in master? Because we are not using the Swagger2 plugin
anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 11:48:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 10:48:42 +0000
Subject: [Koha-bugs] [Bug 22234] New: User Login Problem.
Message-ID: <bug-22234-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22234

            Bug ID: 22234
           Summary: User Login Problem.
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tapu.b3u at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

Created attachment 84508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84508&action=edit
I can't login to koha after installing software.

I can't login to koha after installing software.
And this is my first login.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 12:02:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 11:02:04 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-Oyl79NdYAp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> ---
And if a library has barcodes with hyphens (-)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 12:04:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 11:04:08 +0000
Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-139YaNJ6IO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84509&action=edit
Bug 7088: (follow-up) Remove script "type" attribute

As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 12:06:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 11:06:11 +0000
Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-CZc4ehHtwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #26 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84510&action=edit
Bug 7088: (follow-up) Set syspref default to off

As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 12:48:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 11:48:42 +0000
Subject: [Koha-bugs] [Bug 21698] FIX POD of cancel_unfilled_holds.pl
In-Reply-To: <bug-21698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21698-70-RC3SFTs3Bq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
18720

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:05:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:05:27 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-cmK7AQG2w9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Fr?d?ric Demians from comment #10)
> And if a library has barcodes with hyphens (-)?

Yeah, we'd better move these chars in a pref ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:22:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:22:33 +0000
Subject: [Koha-bugs] [Bug 18562] There should be a koha-sip script to handle
 SIP daemons for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-gyHj0dcDM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84511&action=edit
Bug 18562: Add koha-sip maintenance script

This patch introduces a single script to handle all actions on SIP
servers for Koha instances. It is intended to be a replacement for:

- koha-start-sip
- koha-stop-sip
- koha-enable-sip

It adds a function called is_sip_running to koha-functions.sh.

To test:
- Apply this patch
- Run:
  $ misc4dev/cp_debian_files.pl
  $ sudo koha-sip --enable kohadev
  $ sudo koha-sip --start kohadev
  $ sudo koha-sip --status kohadev
=> SUCCESS: The SIP server is running for kohadev
- Run:
  $ sudo koha-sip --restart --verbose kohadev
  $ sudo koha-sip --status kohadev
=> SUCCESS: The SIP server is running for kohadev
- Run:
  $ sudo koha-sip --stop kohadev
  $ sudo koha-sip --status kohadev
=> SUCCESS: The SIP server is not running for kohadev
- Play with other combinations like enabling an already enabled
instance, etc. Remember you need to remove the
/etc/koha/sites/kohadev/SIPconfig.xml file so it is considered disabled.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:22:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:22:40 +0000
Subject: [Koha-bugs] [Bug 18562] There should be a koha-sip script to handle
 SIP daemons for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-sDwqJM1v0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84512&action=edit
Bug 18562: Add manpage for koha-sip

This patch adds the manpage for koha-sip.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove xt/verify-debian-docbook.t
=> SUCCESS: Tests pass!
- Run:
  $ misc4dev/cp_debian_files.pl
  $ man koha-sip
=> SUCCESS: The man page shows correctly.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:22:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:22:45 +0000
Subject: [Koha-bugs] [Bug 18562] There should be a koha-sip script to handle
 SIP daemons for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-wd9OYiKEw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84513&action=edit
Bug 18562: Tab completion in bash

This patch adds the fancy tab completion in bash.

To test:
- Run:
  $ source debian/koha-common.bash-completion
  $ sudo koha-sip <tab>
- Play with all the options
=> SUCCESS: The combinations make sense (e.g. only SIP-enabled instances
  are completed for --start, --stop, --restart, -v and --verbose are not
  offered if the other one is already in there, --enable only applies to
  SIP-disabled instances, etc).
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:23:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:23:50 +0000
Subject: [Koha-bugs] [Bug 18562] There should be a koha-sip script to handle
 SIP daemons for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-uPVksWoEbp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:24:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:24:06 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-vRYXAZ5Itt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|There should be a koha-sip  |Add koha-sip script to
                   |script to handle SIP        |handle SIP servers for
                   |daemons for instances       |instances

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:27:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:27:59 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-PRCqDyLhll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |magnus at libriotech.no,
                   |                            |mirko at abunchofthings.net
  Text to go in the|                            |To ease multi-tenant sites
      release notes|                            |maintenance, several handy
                   |                            |scripts were introduced.
                   |                            |For handling SIP servers, 3
                   |                            |scripts were introduced:
                   |                            |koha-start-sip,
                   |                            |koha-stop-sip and
                   |                            |koha-enable-sip.
                   |                            |This patch
                   |                            |introduces a new script,
                   |                            |koha-sip, that unifies
                   |                            |those actions regarding SIP
                   |                            |servers on a per instance
                   |                            |base, through the use of
                   |                            |option switches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:29:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:29:07 +0000
Subject: [Koha-bugs] [Bug 22235] New: Make maintenance scripts use koha-sip
 instead of koha-*-sip
Message-ID: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

            Bug ID: 22235
           Summary: Make maintenance scripts use koha-sip instead of
                    koha-*-sip
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:37:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:37:36 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-d58YjIevwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:46:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:46:47 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-oxNmLELroY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84515&action=edit
Bug 22235: (follow-up) Make koha-remove stop SIP server if required

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:47:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:47:06 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-dzKuUYNqva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
   Target Milestone|---                         |19.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:46:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:46:42 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-CpTW9xDGaq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84514&action=edit
Bug 22235: Make maintenance scripts use koha-sip instead of koha-*-sip

This patch makes all maintenance scripts use **koha-sip** instead of
the old **koha-*-sip** scripts.

To test:
- Run:
  $ perl misc4dev/cp_debian_files.pl
  $ sudo service koha-common stop
=> SUCCESS: No errors and the SIP-related sevices are stopped
  $ sudo service koha-common start
=> SUCCESS: No errors and the SIP-related services are started
  $ sudo service koha-common restart
=> SUCCESS: No erros and SIP-related services are running
  $ sudo koha-create --create-db test
  $ sudo koha-sip --enable test
  $ sudo koha-sip --start test
  $ sudo koha-disable test
=> SUCCESS: No errors, instance disabled, no SIP running for test
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:47:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:47:25 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-xoWpaWsmRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:47:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:47:59 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-9ESW5C5pQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18562


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562
[Bug 18562] Add koha-sip script to handle SIP servers for instances
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 13:47:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 12:47:59 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-lQTF5VDrfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22235


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235
[Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:15:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:15:51 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-QihIAGiDjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:15:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:15:55 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-WWc8upljZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79276|0                           |1
        is obsolete|                            |

--- Comment #37 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84516&action=edit
Bug 20664: Optimize retrieval of biblio and item data

Optimizes embedding of item data in MARC and fixes several bottlenecks
encountered while profiling OAI-PMH and exporting of records. There are two
ways this is accomplished:

1.) Create optimized method for fetching item fields for MARC embedding.
2.) Use the cache service more and where repeated calls are made.

Test plan:

1.) Before applying the patch, time an export_records.pl run for a set of
biblios that also have items. Run it a couple of times to account for initial
slowness and possible fluctuations. For example:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename unoptimized.xml

2.) Apply the patch.

3.) Time the export process again with a different output file:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename optimized.xml

4.) Verify that the optimized process is faster.

5.) Compare the resulting export files to make sure they're identical:

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:16:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:16:01 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-MzTmFpv9T5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79277|0                           |1
        is obsolete|                            |

--- Comment #38 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84517&action=edit
Bug 20664: Add unit tests for GetMarcItem

To test:
prove -v t/db_dependent/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:16:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:16:06 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-O8AgvkNcnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79278|0                           |1
        is obsolete|                            |

--- Comment #39 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84518&action=edit
Bug 20664: Unit tests for GetMarcItemFields

To test:
prove -v t/db_dependent/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:16:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:16:11 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-ZSAUMdumqA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79279|0                           |1
        is obsolete|                            |

--- Comment #40 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84519&action=edit
Bug 20664: (follow-up) Fix test for GetMarcItemFields

Without this patch I got this error running the test:

YAML Error: Stream does not end with newline character

Test plan:
prove t/db_dependent/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:16:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:16:16 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-zDvHRXiTvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #41 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84520&action=edit
Bug 20664: (follow-up) Fix QA whitespace errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:19:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:19:06 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-pzm4seWiC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:19:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:19:08 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-INrSyk0pc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

--- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> ---
When playing with this issue, I was comparing inventory tool with Batch item
modification tool. Both tools accept as input a barcodes file.

Barcodes with hyphen are OK in Batch item modification. This regex is used to
split file lines:

  /[\r\n]/

Barcodes with hyphen are not OK in Inventory tool. This regex is used:

  /[\n\r,;|-]/

Wouldn't it make sense to have the same splitting logic in both places?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:19:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:19:09 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-QIaiYUjgso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84511|0                           |1
        is obsolete|                            |
  Attachment #84512|0                           |1
        is obsolete|                            |
  Attachment #84513|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84521&action=edit
Bug 18562: Add koha-sip maintenance script

This patch introduces a single script to handle all actions on SIP
servers for Koha instances. It is intended to be a replacement for:

- koha-start-sip
- koha-stop-sip
- koha-enable-sip

It adds a function called is_sip_running to koha-functions.sh.

To test:
- Apply this patch
- Run:
  $ misc4dev/cp_debian_files.pl
  $ sudo koha-sip --enable kohadev
  $ sudo koha-sip --start kohadev
  $ sudo koha-sip --status kohadev
=> SUCCESS: The SIP server is running for kohadev
- Run:
  $ sudo koha-sip --restart --verbose kohadev
  $ sudo koha-sip --status kohadev
=> SUCCESS: The SIP server is running for kohadev
- Run:
  $ sudo koha-sip --stop kohadev
  $ sudo koha-sip --status kohadev
=> SUCCESS: The SIP server is not running for kohadev
- Play with other combinations like enabling an already enabled
instance, etc. Remember you need to remove the
/etc/koha/sites/kohadev/SIPconfig.xml file so it is considered disabled.
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:19:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:19:22 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-Ivd6Y6GDvf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #42 from Ere Maijala <ere.maijala at helsinki.fi> ---
Sorry for the delay. Now rebased and fixed the whitespace issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:19:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:19:37 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-0pw2ZjpqV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84522&action=edit
Bug 18562: Add manpage for koha-sip

This patch adds the manpage for koha-sip.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove xt/verify-debian-docbook.t
=> SUCCESS: Tests pass!
- Run:
  $ misc4dev/cp_debian_files.pl
  $ man koha-sip
=> SUCCESS: The man page shows correctly.
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:19:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:19:40 +0000
Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers
	for instances
In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18562-70-pTbYydnTPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 84523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84523&action=edit
Bug 18562: Tab completion in bash

This patch adds the fancy tab completion in bash.

To test:
- Run:
  $ source debian/koha-common.bash-completion
  $ sudo koha-sip <tab>
- Play with all the options
=> SUCCESS: The combinations make sense (e.g. only SIP-enabled instances
  are completed for --start, --stop, --restart, -v and --verbose are not
  offered if the other one is already in there, --enable only applies to
  SIP-disabled instances, etc).
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:47:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:47:02 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-nWuGWs9KDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 84524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84524&action=edit
Bug 20208: Unit tests for checksum and dir

Test plan:
    kshell
    prove t/db_dependent/Upload.t

must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 14:49:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 13:49:18 +0000
Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be
 escaped when performing a search
In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22228-70-F6H7TkBGf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:09:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:09:17 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15260-70-si44cIfnOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com
             Status|NEW                         |ASSIGNED
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:34:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:34:41 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-rEOTDxpp5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:34:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:34:44 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-ecLg4450pQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Getting this error at step 1:

root at 48864c0cb6e1:kohadevbox$ perl misc4dev/cp_debian_files.pl
Cannnot open file No such file or directory at misc4dev/cp_debian_files.pl line
35.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:34:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:34:45 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-26xfPOOcIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

--- Comment #4 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 84525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84525&action=edit
Bug 20208: Development - Peddie School - Custom file upload paths

Test plan:
1) Upload two files with and without checksum
2) UPLOAD add new options to authorized values
3) Upload two files with and without checksum by selecting from the pulldown
category options 
4) UPLOAD_PATH add new options to authorized values
5) Try uploads by selecting from the pulldown upload path options and other
options
6) Check the files in the /var/lib/koha/kohadev/uploads

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:35:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:35:46 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-yIigrXhPYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jesse at bywatersolutions.com  |kohadevinim at devinim.com.tr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:45:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:45:44 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-Uq47mH49xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:45:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:45:58 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-LRR9GTc6GD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74517|0                           |1
        is obsolete|                            |
  Attachment #74518|0                           |1
        is obsolete|                            |
  Attachment #74519|0                           |1
        is obsolete|                            |
  Attachment #74520|0                           |1
        is obsolete|                            |
  Attachment #79648|0                           |1
        is obsolete|                            |
  Attachment #82423|0                           |1
        is obsolete|                            |

--- Comment #36 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84526&action=edit
Bug 20582: Turn Koha into a Mojolicious application

This patch is a proof-of-concept of Koha as a Mojolicious application

This has several benefits:
- Run `morbo bin/koha` and you're set : fully functional Koha without
  apache2/nginx (URL rewrites and static files are handled by the app)
- apache2/nginx configuration is much simpler (an example of nginx
  configuration is included in the patch)
- starman and plack middlewares can still be used for debug or gzip
  compression for instance (see bin/koha.psgi)
- All that is needed to run koha is in the source code and not hidden in
  an obscure directory (I'm looking at you, debian/templates/plack.psgi)
- Using Test::Mojo we can test the whole application, as we do with the
  REST API (which is a Mojolicious application too)
- It's another step in the direction of dropping CGI support
- It also opens a way for converting CGI scripts into Mojolicious
  controllers and actions (even if that's not possible at the moment
  because of the authentication code)
- It requires zero changes to existing files, so it should apply nicely
  forever (no rebase needed \o/)

A few downsides too:
- It is not complete : some things from debian/templates/plack.psgi are
  missing, like the L1 cache flush or Koha::Middleware::SetEnv. But that
  shouldn't be too hard to add.
- Already mentioned above, but the actual state of get_template_and_user
  and checkauth completely forbids the use of Mojolicious controllers.
  We really need to rewrite C4::Auth
- Not sure if it's a downside or not, but as OPAC and Intranet are on
  the same host:port, if you authenticate on OPAC you will be
  authenticated on Intranet too.
  This can probably be changed if it's really a problem.
- ... see FIXME in the code

Other remarks:
- It uses the same mechanism as Plack::App::CGIBin to deal with CGI
  scripts, so it should be equivalent in terms of performance

How to test ?
- Run `morbo bin/koha`, then go to:
  - http://localhost:3000/  -  Redirects to OPAC main page
  - Then navigate in the OPAC, searching for bugs
  - http://localhost:3000/intranet  -  Redirects to intranet main page
  - Then navigate in the Intranet, still searching for bugs
  - http://localhost:3000/api/v1/...  -  The REST API
  - Test the web installer
- Read the code (and the comments), it's not very long

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:46:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:46:06 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-fgI5XHbPvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #37 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84527&action=edit
Bug 20582: Add routes for some svc/ scripts

svc/club/enroll, svc/club/cancel_enrollment and svc/report are available
in different versions: one for the OPAC, one for the intranet
This patch creates new routes that override the CGI scripts and that
work for both OPAC and intranet

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:46:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:46:13 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-TRf3N9wK2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #38 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84528&action=edit
Bug 20582: Enable SetEnv middleware in bin/koha.psgi

and make sure the psgi env is passed to CGI scripts

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:46:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:46:21 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-rHMYyZJGd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #39 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84529&action=edit
Bug 20582: Flush memory caches before every request

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:46:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:46:32 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-8Rsm7iphzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #40 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84530&action=edit
Bug 20582: Fix memory cache flush

Cache flush should be in around_action hook instead of before_dispatch
Otherwise it is flushed before every request (even static files
requests)
Also, make sure the Cache::Memory cache is really flushed (not only L1
cache)

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:46:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:46:46 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-OzmrH6NVdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #41 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 84531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84531&action=edit
Bug 20582: Handle multipart content-type

Mojo::Message::Request's body attribute does not contain anything when
the content-type is multipart/*
We have to rebuild the multipart body for CGI scripts

Test plan:
1. Go to Tools ? Upload and try to upload a file

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 15:56:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 14:56:48 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-QujS4ysFeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #42 from Josef Moravec <josef.moravec at gmail.com> ---
Signed off as it works as advertised and it would be great to see it moving ;)

Just one note: we need to add Mojolicious::Plugin::TemplateToolkit to
dependencies and make a debian package (adding Mirko to CC)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:14:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:14:11 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20630-70-CpH5Rz5aG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 74671
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74671
Bug 20630: An attempt at multitenancy with Mojolicious

Review of attachment 74671:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20630&attachment=74671)
-----------------------------------------------------------------

::: Koha/App/Koha.pm
@@ +73,5 @@
> +    my $caches = $Koha::Caches::singleton_caches;
> +    if ($caches) {
> +        foreach my $key (keys %$caches) {
> +            my $cache = $caches->{$key};
> +            if (ref $cache->{cache} eq 'Cache::Memory') {

This should not be needed, as of Cache::Memory was removed by bug 21955

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:14:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:14:11 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20630-70-9eF4R0Zpfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 74671
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74671
Bug 20630: An attempt at multitenancy with Mojolicious

Review of attachment 74671:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20630&attachment=74671)
-----------------------------------------------------------------

::: Koha/App/Koha.pm
@@ +73,5 @@
> +    my $caches = $Koha::Caches::singleton_caches;
> +    if ($caches) {
> +        foreach my $key (keys %$caches) {
> +            my $cache = $caches->{$key};
> +            if (ref $cache->{cache} eq 'Cache::Memory') {

This should not be needed, as of Cache::Memory was removed by bug 21955

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 74671
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74671
Bug 20630: An attempt at multitenancy with Mojolicious

Review of attachment 74671:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20630&attachment=74671)
-----------------------------------------------------------------

::: Koha/App/Koha.pm
@@ +73,5 @@
> +    my $caches = $Koha::Caches::singleton_caches;
> +    if ($caches) {
> +        foreach my $key (keys %$caches) {
> +            my $cache = $caches->{$key};
> +            if (ref $cache->{cache} eq 'Cache::Memory') {

This should not be needed, as of Cache::Memory was removed by bug 21955

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:32:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:32:39 +0000
Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo
In-Reply-To: <bug-20635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20635-70-yYbwIGPdqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Just tried, but without any success, not sure what's wrong here:

1..2
# Subtest: intranet
    1..10
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
Reference is already weak at
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1/Template/Plugin/Filter.pm line 68.
A context appears to have been destroyed without first calling release().
Based on $@ it does not look like an exception was thrown (this is not always
a reliable test)

This is a problem because the global error variables ($!, $@, and $?) will
not be restored. In addition some release callbacks will not work properly from
inside a DESTROY method.

Here are the context creation details, just in case a tool forgot to call
release():
  File: t/integration/auth/password.t
  Line: 58
  Tool: Test::More::subtest

Cleaning up the CONTEXT stack...
# Test ended with extra hubs on the stack!
    # No tests run!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:34:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:34:40 +0000
Subject: [Koha-bugs] [Bug 22236] New: Translation should generate tags with
 consistent attribute order
Message-ID: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236

            Bug ID: 22236
           Summary: Translation should generate tags with consistent
                    attribute order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

When running misc/translator/translate, the order of attributes in the
translated templates is not consistent and may vary. This is caused by the
random order of hash keys in perl.

This causes things like this in run 1:
<input type="submit" class="btn" value="Plaats aanvraag" />
And this in run 2:
<input value="Plaats aanvraag" type="submit" class="btn" />
As you can see, there is actually no difference apart from the order.

When comparing the result of various translation runs, I would rather get rid
of such noise and only see the real changes.

The needed change is not trivial to find, but only requires a simple addition
to a sort operation in tmpl_process3.pl. The current sort only makes sure that
the '/' comes at the end. We should sort the names of the keys too when this
value is 0 (just meaning: no end tag symbol).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:35:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:35:01 +0000
Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with
 consistent attribute order
In-Reply-To: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22236-70-5f3I29yth0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Small patch
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:41:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:41:06 +0000
Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with
 consistent attribute order
In-Reply-To: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22236-70-SVbicipeqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:41:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:41:09 +0000
Subject: [Koha-bugs] [Bug 22236] Translation should generate tags with
 consistent attribute order
In-Reply-To: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22236-70-DDbOAbEvFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22236

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 84532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84532&action=edit
Bug 22236: Translation should generate tags with consistent attribute order

When running misc/translator/translate, the order of attributes in the
translated templates is not consistent and may vary. This is caused by the
random order of hash keys in perl.

This causes things like this in run 1:
<input type="submit" class="btn" value="Plaats aanvraag" />
And this in run 2:
<input value="Plaats aanvraag" type="submit" class="btn" />
As you can see, there is actually no difference apart from the order.

When comparing the result of various translation runs, I would rather get rid
of such noise and only see the real changes.

The needed change is not trivial to find, but only requires a simple addition
to a sort operation in tmpl_process3.pl. The current sort only makes sure that
the '/' comes at the end. We should sort the names of the keys too when this
value is 0 (just meaning: no end tag symbol).

Test plan:
[1] Run a translation without this patch and set a few templates aside.
[2] Run a translation with this patch.
[3] Run a compare (diff) on the templates copied in step 1. Verify that the
    only changes are found in the sort order of attributes in html tags.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 16:51:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 15:51:01 +0000
Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
 allowed in cataloguing
In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22204-70-ZXT8FYUAbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:11:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:11:03 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Qdn9MmXQtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22237


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237
[Bug 22237] Subscriptions are not linked to Mana upon edit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:11:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:11:03 +0000
Subject: [Koha-bugs] [Bug 22237] New: Subscriptions are not linked to Mana
	upon edit
Message-ID: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237

            Bug ID: 22237
           Summary: Subscriptions are not linked to Mana upon edit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Web services
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

When a new subscription is created using data from Mana, a mana_id value is
added to the subscription table. In Serials.pm ModSubscription was not modified
to include mana_id, so subscription edits do not correctly link to Mana.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:11:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:11:51 +0000
Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter
 subfields to item search fields
In-Reply-To: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20689-70-57tcFncZXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:21:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:21:07 +0000
Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon
	edit
In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22237-70-2erAEgtKnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:21:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:21:10 +0000
Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon
	edit
In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22237-70-EaoIsG0kGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84533&action=edit
Bug 22237: Subscriptions are not linked to Mana upon edit

This patch modifies C4/Serials.pm so that during the process of editing
a subscription a link to Mana can be created.

To test, apply the patch and go to Serials.

 - Locate a subscription which was not created using Mana data but which
   can be found in Mana.
 - Edit the subscription, skipping to the second page.
 - View the results returned by Mana and select one.
 - Save the subscription.
 - Upon being redirected to the subscription detail page you should see
   a "Report mistake" button. This shows that the subscription has been
   linked to Mana successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:28:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:28:17 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-OQLvoCThmu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree, especially since hyphen and other characters are not as unlikey as one
might think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:28:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:28:53 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-oApvEs5aVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
But we should move this to a new bug as this has already been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:31:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:31:32 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
	upload paths
In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20208-70-i4QVfdhOC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle/Devinim, can you please make the bug title more general? (Think release
notes :) )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:35:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:35:45 +0000
Subject: [Koha-bugs] [Bug 21866] Rephraase "Warning: This *report* was
 written for an older version of Koha" to refer to plugins
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-AMpmFlxSPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Warning: This *report* was  |Rephraase "Warning: This
                   |written for an older        |*report* was written for an
                   |version of Koha. Run at     |older version of Koha" to
                   |your own risk.              |refer to plugins
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:35:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:35:54 +0000
Subject: [Koha-bugs] [Bug 21866] Rephrase "Warning: This *report* was
 written for an older version of Koha" to refer to plugins
In-Reply-To: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21866-70-D08Y9qbHLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rephraase "Warning: This    |Rephrase "Warning: This
                   |*report* was written for an |*report* was written for an
                   |older version of Koha" to   |older version of Koha" to
                   |refer to plugins            |refer to plugins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:37:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:37:27 +0000
Subject: [Koha-bugs] [Bug 22011] Typo in Item Batch Modification
In-Reply-To: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22011-70-V7H4Mtw3SR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22011

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin SOMERS from comment #8)
> I prefer not to push to 17.11.x to minimize translation work

Not even fixing a typo?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:39:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:39:43 +0000
Subject: [Koha-bugs] [Bug 22232] Advanced Cataloguing Editor (Rancor) to
 edit authority records?
In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22232-70-R1LgfAMJUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Carlos, not a lot of people read the bug email - maybe ask the mailing list
in parallel.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:43:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:43:16 +0000
Subject: [Koha-bugs] [Bug 22233] Fines forgiven
In-Reply-To: <bug-22233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22233-70-VOh7b8qfZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22233

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi mustqueem,

credits won't be "used up" in this version of Koha. Please see the discussion
on the mailing list

https://lists.katipo.co.nz/pipermail/koha/2019-January/052148.html

and bug 21896 (I am marking this one as duplicate).

*** This bug has been marked as a duplicate of bug 21896 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:43:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:43:16 +0000
Subject: [Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
In-Reply-To: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21896-70-r2KjfXRRM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mustaqeemabd at gmail.com

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 22233 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:44:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:44:36 +0000
Subject: [Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
In-Reply-To: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21896-70-b2UPivgnRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We had a question on the mailing list and another in a bug report about this
one for 18.05. Not sure how hard backporting would bea (lots of missing
dependencies)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:48:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:48:12 +0000
Subject: [Koha-bugs] [Bug 22234] User Login Problem.
In-Reply-To: <bug-22234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22234-70-XTcTbfUCTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22234

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Tapu, 

this is more likely to be an installation/support question.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Please make sure to include information about the version you installed, how
you installed it and which instructions you followed.

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 18:49:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 17:49:32 +0000
Subject: [Koha-bugs] [Bug 22234] User Login Problem.
In-Reply-To: <bug-22234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22234-70-DWNxVKmFSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22234

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Also note: In this version the database user login won't work for login. You
will need to use the staff user's login you created through the web installer.
Alternatively you can create a user using the command line script. See here for
instructions:
http://kohageek.blogspot.com/2018/07/create-super-librarian-by-command-line.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:05:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:05:49 +0000
Subject: [Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
In-Reply-To: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21896-70-lU5JUG7dao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896

--- Comment #35 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #34)
> We had a question on the mailing list and another in a bug report about this
> one for 18.05. Not sure how hard backporting would bea (lots of missing
> dependencies)?

I don't think it is that bad, and we could have a 18.05 version of this if
required.

It was the RMaint call not to backport it. Maybe the new RMaints change their
mindS?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:06:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:06:06 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-K3isn7TAVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:13:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:13:33 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-GTSmB3twnE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Kyle M Hall from comment #3)
> Getting this error at step 1:
> 
> root at 48864c0cb6e1:kohadevbox$ perl misc4dev/cp_debian_files.pl
> Cannnot open file No such file or directory at misc4dev/cp_debian_files.pl
> line 35.

The instructions were for kohadevbox, that's why they don't work :-/

In koha-testing-docker you need to run like this:

root at b2cf8a1790c7:kohadevbox$ cd misc4dev
root at b2cf8a1790c7:misc4dev(master)$ perl cp_debian_files.pl --koha_dir
/kohadevbox/koha --instance kohadev --gitify_dir /kohadevbox/gitify

Thanks for your interest!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:19:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:19:18 +0000
Subject: [Koha-bugs] [Bug 22238] New: Remove koha-*-sip scripts in favor of
	koha-sip
Message-ID: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238

            Bug ID: 22238
           Summary: Remove koha-*-sip scripts in favor of koha-sip
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:19:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:19:39 +0000
Subject: [Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of
	koha-sip
In-Reply-To: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22238-70-WA046er0uM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |22235


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235
[Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:19:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:19:39 +0000
Subject: [Koha-bugs] [Bug 22235] Make maintenance scripts use koha-sip
 instead of koha-*-sip
In-Reply-To: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22235-70-w1MHO9Yhui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22238


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238
[Bug 22238] Remove koha-*-sip scripts in favor of koha-sip
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:35:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:35:11 +0000
Subject: [Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of
	koha-sip
In-Reply-To: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22238-70-w4cPjq4Nkz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:35:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:35:14 +0000
Subject: [Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of
	koha-sip
In-Reply-To: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22238-70-jtuLt0TQLd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84534&action=edit
Bug 22238: Remove koha-*-sip scripts in favor of koha-sip

This patch removes traces from the (deprecated) koha-*-sip scripts.

To test:
- Apply the patch
- Verify no traces of koha-*-sip remain on the codebase (besides
  Release Notes, koha-common.links and the koha-sip script):
  $ cd kohaclone
  $ git grep koha-start-sip
  $ git grep koha-stop-sip
  $ git grep koha-enable-sip
=> SUCCESS: No traces!
- Create the following symlinks:
  $ sudo ln -s /usr/sbin/koha-sip  /usr/sbin/koha-start-sip
  $ sudo ln -s /usr/sbin/koha-sip  /usr/sbin/koha-stop-sip
  $ sudo ln -s /usr/sbin/koha-sip  /usr/sbin/koha-enable-sip
- Try the koha-*-zebra commands:
  $ sudo koha-stop-sip kohadev
  $ sudo koha-start-sip kohadev
  $ sudo koha-restart-sip kohadev
=> SUCCESS: They all work as expected!

- Sign off :-D!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:35:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:35:32 +0000
Subject: [Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of
	koha-sip
In-Reply-To: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22238-70-Tkw8z2uvps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:37:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:37:23 +0000
Subject: [Koha-bugs] [Bug 22238] Remove koha-*-sip scripts in favor of
	koha-sip
In-Reply-To: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22238-70-vRLLRtrWjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22238

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |The new koha-sip
      release notes|                            |maintenance script replaces
                   |                            |the old koha-start-sip,
                   |                            |koha-stop-sip and
                   |                            |koha-enable-sip scripts.
                   |                            |This patch removes them,
                   |                            |while keeping backwards
                   |                            |compatibility (i.e. you can
                   |                            |still run them until you
                   |                            |get used to the new
                   |                            |syntax).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:41:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:41:21 +0000
Subject: [Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in
	index keyword
In-Reply-To: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22230-70-0ZXBlEJtzM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230

--- Comment #2 from Patrick Robitaille <patrick.robitaille at collecto.ca> ---
Hello Katrin,

When scanning a document with the barcode, we would like to avoid having to
choose the ISBN index to get a search that also shows the variantions of this
ISBN. That ISBNs in 7xx and 8xx come out with this research on ISBN variations
does not seem a problem for us, on the contrary. Most of the time we have the
ISBNs of the other versions of the documents. So if these documents are
retrieved by research, that's what we want. For us, it would allow us to see
that we have the same document but in another format.

thanks, Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:46:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:46:30 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-1OyXB3JXb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84362|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:46:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:46:34 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-PfVP6TLT80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84363|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:46:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:46:36 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-X7cIgcDYvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84364|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:46:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:46:39 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-CX045OuN3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84371|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:47:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:47:38 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-L0bIgF3Ng5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84535&action=edit
Bug 22132: Add RESTBasicAuth syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:47:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:47:43 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-0mi576bgjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84536&action=edit
Bug 22132: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:47:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:47:48 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-T4aGxspUvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84537&action=edit
Bug 22132: Add Basic authentication to the API

This patch implements Basic authentication for the API to aid testers
and developers with tools like Postman.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_basic.t
=> SUCCESS: Tests pass!
- Open Postman or your favourite tool
- In Authorization, choose Basic auth.
- Enter the username and password of a known privileged user.
- Hit an endpoint with Postman, for example:
  ] GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons
=> SUCCESS: Basic authentication is great!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:47:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:47:52 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-rRvpyNm0gE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84538&action=edit
Bug 22132: (QA follow-up) Tests - use Mojo builtin for auth

Mojolicious has built in handling for encoding/decoding of of basic auth
paramenters. We should use it to simplify our test here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:47:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:47:56 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-uOs2ZsbUXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84539&action=edit
Bug 22132: (QA follow-up) set_password now expects a hashref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:57:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:57:59 +0000
Subject: [Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in
	index keyword
In-Reply-To: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22230-70-aKyDseQoVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I assume the problem why this was not done before is that you'd have to look at
each and every search entered and try to verify if it contains something that
looks like an ISBN. I am not sure if this kind of processing could impact
performance?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:57:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:57:32 +0000
Subject: [Koha-bugs] [Bug 22227] Make GET /cities staff only
In-Reply-To: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22227-70-EziD9K6zU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Do we need to do anything other than what is in the test plan on a kohadevbox?
For example have some particular data loaded in our database? I've just tried
to apply the patch with the following result:

vagrant at kohadevbox:kohaclone(master)$ git checkout -b bug22227
Switched to a new branch 'bug22227'
vagrant at kohadevbox:kohaclone(bug22227)$ git bz apply 22227
Bug 22227 - Make GET /cities staff only

84507 - Bug 22227: Make GET /cities staff only

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22227: Make GET /cities staff only
vagrant at kohadevbox:kohaclone(bug22227)$ kshell
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/api/v1/cities.t
t/db_dependent/api/v1/cities.t .. 
    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/cities.t line 87.
    #          got: '400'
    #     expected: '200'

    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/cities.t line 87.
    #     Structures begin differing at:
    #          $got->[0]{state} = Does not exist
    #     $expected->[0]{state} =
'O5v1BdpdGC68BA87LFM5W_sSkKGJLmnkPL4rz_34K8hlXzvLUtZsoeuJ8x6tv8zKdJ'

    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/cities.t line 96.
    #          got: '400'
    #     expected: '200'

    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/cities.t line 96.
    #     Structures begin differing at:
    #          $got->[0]{city_id} = Does not exist
    #     $expected->[0]{city_id} = '12'
    # Looks like you failed 4 tests of 18.
t/db_dependent/api/v1/cities.t .. 1/5 
#   Failed test 'list() tests'
#   at t/db_dependent/api/v1/cities.t line 109.

    #   Failed test '403 Forbidden'
    #   at t/db_dependent/api/v1/cities.t line 162.
    #          got: '200'
    #     expected: '403'
    # Looks like you failed 1 test of 17.

#   Failed test 'add() tests'
#   at t/db_dependent/api/v1/cities.t line 226.

    #   Failed test '403 Forbidden'
    #   at t/db_dependent/api/v1/cities.t line 246.
    #          got: '400'
    #     expected: '403'
    # Looks like you failed 1 test of 15.

#   Failed test 'update() tests'
#   at t/db_dependent/api/v1/cities.t line 324.

    #   Failed test '403 Forbidden'
    #   at t/db_dependent/api/v1/cities.t line 343.
    #          got: '200'
    #     expected: '403'

    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/cities.t line 349.
    #          got: '404'
    #     expected: '200'

    #   Failed test 'exact match for content'
    #   at t/db_dependent/api/v1/cities.t line 349.
    #          got: '{"error":"Object not found"}'
    #     expected: '""'
    # Looks like you failed 3 tests of 7.

#   Failed test 'delete() tests'
#   at t/db_dependent/api/v1/cities.t line 360.
# Looks like you failed 4 tests of 5.
t/db_dependent/api/v1/cities.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/5 subtests 

Test Summary Report
-------------------
t/db_dependent/api/v1/cities.t (Wstat: 1024 Tests: 5 Failed: 4)
  Failed tests:  1, 3-5
  Non-zero exit status: 4
Files=1, Tests=5,  3 wallclock secs ( 0.02 usr  0.00 sys +  2.37 cusr  0.24
csys =  2.63 CPU)
Result: FAIL
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 19:58:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 18:58:46 +0000
Subject: [Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in
	index keyword
In-Reply-To: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22230-70-jAHPq7LElt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If we do it, we could have multiple options for the pref maybe to determine
behaviour in different spots.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 20:24:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 19:24:43 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
	subscription
In-Reply-To: <bug-21467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21467-70-vhzKixUBuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22239


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239
[Bug 22239] JavaScript error on subscription detail page when there are no
orders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 20:24:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 19:24:43 +0000
Subject: [Koha-bugs] [Bug 22239] New: JavaScript error on subscription
 detail page when there are no orders
Message-ID: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239

            Bug ID: 22239
           Summary: JavaScript error on subscription detail page when
                    there are no orders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
        Depends on: 21467
  Target Milestone: ---

I get a JavaScript error in the console when I view the details of a
subscription (serials/subscription-detail.pl):

TypeError: this.data(...) is undefined[Learn More]
jquery.treetable_18.1200010.js:481:7

I assume this is because I don't have any orders associated with my
subscription?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
[Bug 21467] Allow several receipts for a given subscription
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 20:52:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 19:52:12 +0000
Subject: [Koha-bugs] [Bug 22240] New: Add possibility to specify a category
 of patron in calendar
Message-ID: <bug-22240-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240

            Bug ID: 22240
           Summary: Add possibility to specify a category of patron in
                    calendar
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Hi, 

Currently when we add a closing day in the calendar we can not specify a
particular patron category. Which means, this day of closure affects all types
of patrons of the library and at the same time the circulation rules. It would
be nice if when we add a closing day, to have the possibility to specify a
category of patrons that would be subject to this closing day. Like that, the
rest of the patrons catgory are not concerned by this limitation.

It could be an additional option in the page to choose the type of closing day
where you would have access to the list of types of users in the library. 

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 20:54:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 19:54:05 +0000
Subject: [Koha-bugs] [Bug 22240] Add possibility to specify a category of
 patron in calendar
In-Reply-To: <bug-22240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22240-70-SwIejexspY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Patrick, I am always interested in the use cases. The calendar mostly
affects the holds queue, fines and due dates. Can you explain how you'd use the
feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:04:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:04:52 +0000
Subject: [Koha-bugs] [Bug 22239] JavaScript error on subscription detail
 page when there are no orders
In-Reply-To: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22239-70-UlMALiXD7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:04:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:04:55 +0000
Subject: [Koha-bugs] [Bug 22239] JavaScript error on subscription detail
 page when there are no orders
In-Reply-To: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22239-70-HUAW3PaiOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84540&action=edit
Bug 22239: JavaScript error on subscription detail page when there are no
orders

This page modifies the subscription detail page so that a JavaScript
error isn't triggered when a subscription has no acquisition details.

To test, apply the patch and go to Serials.

 - Locate a subscription which isn't tied to acquisitions. In the
   browser console there should be no errors.
 - Locate a subscription which is part of an order. There should be an
   'Acquisitions details' tab and the order information on that tab
   should be displayed as a collapsible tree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:16:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:16:14 +0000
Subject: [Koha-bugs] [Bug 9069] Make it possible to import MARC21
 authorities from VIAF into Koha
In-Reply-To: <bug-9069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9069-70-KNZWAqedtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:16:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:16:22 +0000
Subject: [Koha-bugs] [Bug 22241] New: Duplicate records.
Message-ID: <bug-22241-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22241

            Bug ID: 22241
           Summary: Duplicate records.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: orlib at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Within the last two days, when adding new items to the catalog, I get a
"barcode must be original" message. I know this is a new barcode. I then
discovered that the item I just added was showing up twice, with one of the
records showing no items. I have just been going in and removing these, but
this is trouble, if I don't catch it...which may have already happened. I
cleared my cache, in case there was an update I wasn't aware of, but it is
still happening, that is why I am submitting this ticket.
Estel Porras, Orland Free Library, orlib at yahoo.com 
(530)865-1640

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:16:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:16:51 +0000
Subject: [Koha-bugs] [Bug 22241] Duplicate records.
In-Reply-To: <bug-22241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22241-70-nxhxsLftGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22241

Estel Porras <orlib at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orlib at yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:19:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:19:20 +0000
Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon
	edit
In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22237-70-Q0RnVTGXWd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:56:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:56:12 +0000
Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports
In-Reply-To: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22193-70-6rXg5h3xUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

--- Comment #3 from Michal Denar <black23 at gmail.com> ---
Hi Alex,
last two lines on test plan don't work for me

More than one comments 
https://screenshots.firefox.com/bUEQMVj2BDVcwhpJ/localhost

After reload: back "New"

https://screenshots.firefox.com/f65JRGJd5rayY6ll/localhost

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 21:58:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 20:58:43 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-utae21lGsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 30 22:56:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Jan 2019 21:56:25 +0000
Subject: [Koha-bugs] [Bug 22232] Advanced Cataloguing Editor (Rancor) to
 edit authority records?
In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22232-70-4tLyyElxHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

--- Comment #2 from Carlos Lopez <clopez at dml.vic.edu.au> ---
(In reply to Katrin Fischer from comment #1)
> Hi Carlos, not a lot of people read the bug email - maybe ask the mailing
> list in parallel.

Thanks Katrin

I'll do that.

c.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:03:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:03:44 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-DULcBrrpXh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83331|0                           |1
        is obsolete|                            |

--- Comment #194 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84541&action=edit
Bug 15565: Place multiple holds at once for the same record on staff and OPAC.

Test plan:
1. Create an circulation rule to use for testing the patches on this bug
report. Ensure it has a value greater than 1 for 'Holds
allowed', 'Holds per record (count)', and 'Item level holds' is enabled.

2. Also ensure the 'RequestOnOpac' syspref is set to 'Allow'.

3. Go to the reservation page (request.pl) of a biblio in the staff client with
more
than one item.

4. Notice beside each item a radio button is displayed preventing you
from being able to select multiple items to place a hold on.

5. Go to the reservation page (opac-reserve.pl) of the same biblio in the OPAC
also notice a radio button is displayed beside every item.

6. Apply patches

7. Repeat step 3 and 5 and notice in both the staff client and OPAC
checkboxes rather than radio buttons are displayed beside each item so
you can select multiple items for reservation at a time.

8. From staff interface, place several item-level holds for the same user
on the same record at once:

  - check that you are warned if you exceed "Holds per record (count)"
(circulation rules) for this record.
  - check also maxReserves system preference.

9. From opac, place several item-level and record level holds
for the same user on the same record at once:

  - check that can't exceed "Holds per record (count)" for
  this record.
  This is enforced by all unticked item checkboxes being
  disabled after the number of ticked checkboxes equals the 'Holds per record
(count)' (circulation rules) value.

  - check also maxReserves system preference.

Do the same in OPAC and staff by selecting several
record (multi-hold).

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:04:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:04:05 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-P8exwXjjit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83333|0                           |1
        is obsolete|                            |

--- Comment #196 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84543&action=edit
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off

Signed-off-by: Danielle Elder <danielle at bywatersolution.com>

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:03:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:03:56 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-9i1J97CGYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83332|0                           |1
        is obsolete|                            |

--- Comment #195 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84542&action=edit
Bug 15565: Use item's biblionumber only on item-level request

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:04:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:04:15 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-mBKRr5eC4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83334|0                           |1
        is obsolete|                            |

--- Comment #197 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84544&action=edit
Bug 15565: Alert librarian that maximum holds per record is reached

Signed-off-by: Dani Elder <dani at bywatersolutions.com>

Signed-off-by: Danielle Elder <danielle at bywatersolution.com>

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:04:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:04:24 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-JakaGveK9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83335|0                           |1
        is obsolete|                            |

--- Comment #198 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84545&action=edit
Bug 15565: Remove use of GetBiblionumberFromItemnumber

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:04:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:04:33 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-jliME4pnzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83336|0                           |1
        is obsolete|                            |

--- Comment #199 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84546&action=edit
Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC

This commit fixes two bugs:

1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format:
status => 'output'

However opac-reserve.pl is not accessing th output of this function
correctly consequently no item is ever reservable.

And so after a patron submits the reservation form on opac-reserve.pl it
looks like the item-level reservation has successfully been placed
however it has not and no error message is displayed to them.

This commit stores the output of the aforementioned function in a hash
and then checks the value of the status key. As a result opac-reserve.pl
now correctly accesses the value returned and item level holds are
successfully placed from the OPAC.

2. If a biblio has previously been reserved then the opac-reserve.pl page
shows the 'Next available item' and 'A specific item' radio buttons to be
disabled to ensure patrons cannot place a reservation of a different
type on the biblio.

With both of these radio buttons being disabled it results in item level holds
placed in the OPAC on a previously reserved item not being stored in the
database. This is very confusing for users.

I have implemented a conditional which checks what the forced_hold_type
of the previous hold was. If it was 'item' then the $reqtype =
'Specific' and if it was 'record' then $reqtype is 'Any'.

This means there will always be a value for $reqtype, and this variable
is checked if it is equal to 'Specific' and if it is then an item level
hold is placed.

Test plan:
1. Ensure in your circulation rules that 'Item level holds' is enabled

2. Apply all patches on this bug report except this commit

3. In the OPAC try placing a item level hold (and notice you can submit
the opac-reserve.pl page and no error messages are displayed. However
the hold(s) are not being placed.

4. Place an item level hold(s) on the biblio from staff client interface
and then return to the opac-reserve.pl page for the biblio in the OPAC
and notice both the 'Next available' and 'A specific item' radio buttons
are disabled.

5. Again try placing an item level hold in the OPAC and notice dispite
no error/warning message being displayed the hold is not being placed.

6. Apply this patch

7. Restart memcached, and plack

8. In the staff client remove the reservation you placed from the staff
client.

9. Repeat step 3 and notice when you go to your opac summary
(opac-user.pl) page the holds are displayed. .i.e. You can now
successfully place item level holds in the OPAC.

10. Return to the opac-reserve.pl page for the biblio and notice that
because you have already placed a hold on this biblio the 'Next
available item' and 'A specific item' radiobuttons are disabled.

11. Select several of the items checkboxes to place more item level
holds and press the 'Confirm hold' button.

12. Go to your opac summary (opac-user.pl) page again and notice the
holds you placed in step 11 are shown there.

i.e. you can place item level holds from the OPAC on biblios which have
previously had reserves placed on them.

Sponsored-By: Brimbank Library

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:04:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:04:42 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-amf3uaqXxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83337|0                           |1
        is obsolete|                            |

--- Comment #200 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84547&action=edit
Bug 15565: Changed the retrieval of selected hold pickup branch in
opac-reserve.pl

Previously the selected branch dropdown value was not being successfully
retrieved in
opac-reserve.pl, this resulted in opac holds being placed with no pickup
branch being set.

Consequently as no branch was associated with the hold an Ajax error was
thrown when viewing the holds-table in the patron page in the staff
client.

This commit successfully retrieves the selected branch value and so
fixing the Ajax error.

Test plan:
1. Apply all patches on bug report 15565 except this commit

2. Place a hold(s) from opac-reserve.pl.

3. Go to your opac patron summary page (opac-user.pl) and notice
although the holds are successfully displayed they have no 'Pickup
location' value

4. Go to the patron page in the staff client and click on the 'Hold(s)'
tab and notice a popup explaining the datatable Ajax error is loaded

5. Apply this patch

6. Repeat step 3 noticing this time in the
opac-user.pl a 'Pickup location' is displayed for the hold you just
created.

6. Repeat step 4 and notice the hold datatable is successfully loaded
and populated without an Ajax error popup being loaded.

Sponsored-By: Brimbank Library

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:04:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:04:51 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-Gzvl9zgrRz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83338|0                           |1
        is obsolete|                            |

--- Comment #201 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84548&action=edit
Bug 15565: Allow up to (and including) maxreserves number of OPAC item
levelholds

This commit implements changes to opac-reserve.tt and opac-reserve.pl.

1. The change to opac-reserve.tt JS fixes the total_requested() function which
returns an output which is always 2 digits higher than the actual number of
selected item checkboxes.

i.e. if the 'maxreserves' syspref (limit for the overall
number of reserves allowed by a user) is 4 and a user has no previous
holds and ticks 3 item checkboxes and submits the form.

The 'Maximum number of reserve exceded.' popup message is displayed,
however as they have selected 3 items for reservation this is less than
the maxreserves value of 4.

The popup is displayed because total_requested() JS function is
returning 5 (i.e. 2 on top of the actual number of requested holds).

This commit usbtracts 2 from the number of holds calculated by
total_requested() so that the accurate number of requested holds is
being used to determine whether or not to display the excess holds
popup.

2. When the 'Holds per record (count)' (circulation rule) and
'maxreserves' syspref are the same value (e.g. 4) you can tick 4 item
checkboxes in opac-reserve.pl and submit the form.

The form will submit successfully and to the user everything looks to
have worked however the holds will not be
successfully created.

This is because after the form is submitted to opac-reserve.pl a check is
done:

If 'number of submitted hold requests' + 'number of previous existing holds'
greater than or equal to maxreserves syspref then set the variable
'$canreserve' to 0.

If the $canreserve variable is 0 the form will submit, no warning/error
message is displayed to the user but the holds are not created.

Users should be able to place 4 holds if the maxreserves syspref is 4
(just not more than 4 holds). This commit changes this check to:

If 'number of submitted hold requests' + 'number of previous existing
holds' greater than maxreserves syspref then set the variable '$canreserve' to
0..

i.e. notice we only check for greater than (not equal to).

Which solves the bug of the form submitting and no holds being created
when the maxreserves syspref and 'Holds per record (count)' (circulation
rule) are the same.

Test plan (in two parts to test fix #1 and #2 (above)):

Test plan for fix #1:
1. Apply all patches on this bug report (15565) and follow and confirm
the feature works as described in the test plan in the first commit

2. Set the 'maxreserves' syspref to 3 (and 'Holds per record (count)'
(circulation rule) to 5)

3. Ensure your logged in patron account has no existing reserves

4. In the OPAC go to a biblio page with 3 or more items

5. In the reservation page (opac-reserve.pl) for that biblio select 2
item checkboes to place 2 item level holds and notice the 'Maximum
number of reserve exceded.' popup message is displayed.

As the maxreserves syspref value is 3 you should be able to place 2
holds without exceeding that value

6. Apply this patch

7. Repeat step 5 and notice the form submits without the exceeding popup
message and the holds are successfully placed.

Test plan for fix #2:
1. Apply all patches attached to this bug report (bug 15565) and perform
the test plan in the first commit and verify it works.

2. Set your 'Holds per record (count)' (circulation rule) and
'maxreserves' syspref to the same value 3

3. Go to a biblio in the OPAC with 3 or more items

4. In the opac-reserve.pl reservation interface for that biblio tick 3
item checkboxes to place 3 item level holds and submit the form.

5. Notice the form submits and no warning/error message is displayed

6. In the opac user summary page that is displayed after the reserve
form is submitted notice the holds are not displayed this is because
they have not been placed

7. Apply this patch

8. Repeat step 4 and 5 and notice the holds have been successfully
placed and are displayed in your opac user summary page.

Sponsored-By: Brimbank Library
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:05:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:05:01 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-gyWL5QI3gB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83339|0                           |1
        is obsolete|                            |

--- Comment #202 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84549&action=edit
Bug 15565: (follow-up) Removed leftover debug code and added missing filters

Sponsord-By: Brimbank Library, Australia

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:05:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:05:32 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-vQ14TeEFFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83380|0                           |1
        is obsolete|                            |

--- Comment #204 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84551&action=edit
Bug 15565: (follow-up) Changes to maximum hold allowed logic

Implemented changes to the logic to address Katrin Fischer's points in
comment #175, also changed the modal box wording to use 'hold' not
'reserve'

Also updated t/db_dependent/Reserves/MultiplePerRecord.t test to reflect
moving function.

Added the display of the JS modal box informing OPAC borrower that
they have exceeded hold limit after they click 'A specific item'
radiobutton on opac-reserve if holds per day, holds per record or
maxreserves is 1

Test plan:
1. Apply patches
2. Restart memcached and plack
3. Run t/db_dependent/Reserves/MultiplePerRecord.t
4. Set your maxreserves syspref to 3, and a circ rules holds per record
to 2 and holds per day to 1
5. In the OPAC visit the 'Place hold' interface of item. Select the 'A
specific item' radiobutton and observe the first item checkbox is
checked and other unchecked checkboxes are disabled.
6. Repeat step 4 this time setting holds per day to 5
7. Now reloading the OPAC 'Place hold' page notice after clicking 'A
specific item' no modal displays
8. Select a second item checkbox and observe a modal saying you have reached
the maximum number of holds for the record is loaded - notice the
wording 'hold' not 'reserve' in use in the modal box
9. Click 'OK' on modal and observe all unchecked item checkboxes are
automatically disabled to prevent additional holds being placed
10. Select 'Confirm hold'
11. On your holds summary page confirm both holds are placed
12. In the staff client set the 'AllowHoldPolicyOverride' syspref to
"Don't allow"
13. Visit a biblio reservation interface in the staff client
14. Select 2 item checkboxes and observe the modal box explaining you
have reached maximum holds for the record is displayed - notice the
wording of 'hold' not 'reserve' is used in the modal box.
15. Select 'OK' on the modal and notice all un-checked item checkboxes
are automatically disabled
16. Repeat steps 12-15 this time with the value of
'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once
you have clicked on the second item checkbox although the modal still
loads the item checkboxes do not disable - you are able to override and
continue selecting checkboxes each time with modal warning loading.

17. In both the OPAC and staff client try placing a record level hold,
selecting a value from the 'Holds to place (count)' dropdown. Notice
that the maximum value of this is the lowest value out of the 'maximum
number of holds per record', 'maximum number of holds per day' and the
'maxreserves' system preference so in this case it will be 2
18. Save and notice 2 holds are placed

19. Observe the allow_holds() function is in the Koha/Biblio.pm file and
the GetAllowedHoldsForPatronToday() function has been removed from
C4/Reserves.pm

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:05:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:05:41 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-6Jvy6OoRcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83381|0                           |1
        is obsolete|                            |

--- Comment #205 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84552&action=edit
Bug 15565: (follow-up) Place multiple holds from opac-search.pl

Previously before this patch if you selected multiple bibliographic
results from opac-search.pl and selected 'Place hold' and confirmed the
hold only 1 hold on the first of the selected biblios would be placed.

This patch fixes this bug and enables users to be able to place holds on
multiple bibliographic records in opac-search.pl, select 'Place hold', select
if they want
each of these holds to be on 'Next available', 'Next available from
group', or 'A specific item' and place their holds and all the holds
they placed will be placed correctly.

Test plan:
1. Follow test plan on the last patch - (Don't apply this patch)
2. Try to select multiple bibliographic record checkboxes and select
'Place hold'
3. Confirm holds and notice you are re-directed to opac-user.pl and only
the first hold has been placed

4. Apply this patch
5. Restart memcached and plack if running
6. Repeat steps 2 and 3 and notice all holds were placed
7. Repeat step 2 and then select a variety of 'A specific item' and 'Next
available item' holds for each of the bibliographic holds and
confirm they are all placed correctly
8. Confirm you can still place multiple holds correctly in opac-reserve
accessing from a OPAC biblio detail page

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:05:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:05:18 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-97Yo1WlWoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83340|0                           |1
        is obsolete|                            |

--- Comment #203 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84550&action=edit
Bug 15565: (QA follow-up) Fix some last filters

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 02:14:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 01:14:39 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-myHtoYigEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #206 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Patches have been rebased. Working on improving the code and including
design/layout changes that were requested by Brimbank.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:13:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:13:08 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record in OPAC
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-F3bcmWywOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #207 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84553&action=edit
Bug 15565: (follow-up) fixing typo that breaks placing a hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:49:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:49:44 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-zfFrzuvatO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
  Attachment #81462|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:51:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:51:34 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-mlp7xAWcEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81453|0                           |1
        is obsolete|                            |

--- Comment #104 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84554&action=edit
Bug 15516: Allow to reserve first available item from a group of titles

It can be useful, for instance, if a library have the same title from
different publishers (so 1 title but several biblio records) but the
user only wants a copy of the book, regardless of the publisher.

This patch is only for staff interface.

Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to intranet search, display some results, click on some checkboxes
   and click on 'Place hold' button at the top of the results.
2. Enter a patron cardnumber and click Search
3. Check the box for 'Place a hold on the next available item' (it's
   usually hidden when placing a hold on multiple biblios)
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
   additional text '(part of a reserve group)' in Details column.
6. Click on the "reserve group" link. A modal window should appear with
   the content of the reserve group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
8. The hold status is changed to Waiting, and all other holds are
   deleted.

Note: the "reserve group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:51:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:51:42 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-oFmebbFJBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81454|0                           |1
        is obsolete|                            |

--- Comment #105 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84555&action=edit
Bug 15516: Holding first available item from x biblios only count 1 reserve

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:51:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:51:49 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-ML9jM9tcd8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81455|0                           |1
        is obsolete|                            |

--- Comment #106 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84556&action=edit
Bug 15516: Update old_reserves (reserve_group_id)

Without it, deletion of reserves will fail

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:51:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:51:57 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-A2EGHMv6N2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81456|0                           |1
        is obsolete|                            |

--- Comment #107 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84557&action=edit
Bug 15516: Set reserve-group.pl to be executable

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:52:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:52:13 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-LxR0UyYJnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81458|0                           |1
        is obsolete|                            |

--- Comment #109 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84559&action=edit
Bug 15516: Fix translation issues

- Use " inside _()
- Merge two strings (PART_OF_A, HOLD_GROUP)

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:52:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:52:04 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-4Qk7lV3TUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81457|0                           |1
        is obsolete|                            |

--- Comment #108 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84558&action=edit
Bug 15516: Reword 'reserve group' to 'hold group'

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:52:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:52:22 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-eIPlegb7SN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81459|0                           |1
        is obsolete|                            |

--- Comment #110 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84560&action=edit
Bug 15516: (follow-up) Fix kohastructure.sql

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:52:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:52:32 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-zc8PI1DWU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81460|0                           |1
        is obsolete|                            |

--- Comment #111 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84561&action=edit
Bug 15516: (follow-up) Fix reserve -> hold change

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:52:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:52:43 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-HfYFs3jz40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81461|0                           |1
        is obsolete|                            |

--- Comment #112 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84562&action=edit
Bug 15516: (follow-up) Fix modal for hold group

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:53:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:53:09 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-3VbYofii3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #113 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84563&action=edit
Bug 15516: (follow-up) Fix pod in C4::Reserves

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 03:53:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 02:53:20 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-YgkW7Ntg6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81463|0                           |1
        is obsolete|                            |

--- Comment #114 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 84564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84564&action=edit
Bug 15516: (follow-up) Fix template filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:01:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:01:00 +0000
Subject: [Koha-bugs] [Bug 22232] Advanced Cataloguing Editor (Rancor) to
 edit authority records?
In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22232-70-u0jrp1P073@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:11:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:11:38 +0000
Subject: [Koha-bugs] [Bug 22242] New: Javascript error in value builder
	cased by Select2
Message-ID: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242

            Bug ID: 22242
           Summary: Javascript error in value builder cased by Select2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

Same as Bug 17780 but in value builders.

Select2 (Bug 13501) introduced divs and inputs that broke some assumptions
about the expected HTML structure.
This patch checks if input has name attribute, because some inputs in Select2
have not.

It brakes value builders marc21_linking_section.tt and unimarc_field_4XX.tt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:11:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:11:47 +0000
Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results
 new window shows a blank screen
In-Reply-To: <bug-17780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17780-70-SlLNhDtu5k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242
[Bug 22242] Javascript error in value builder cased by Select2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:12:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:12:00 +0000
Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by
	Select2
In-Reply-To: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22242-70-afyfm4UVBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:11:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:11:47 +0000
Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by
	Select2
In-Reply-To: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22242-70-kUq7cfb3nL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17780


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780
[Bug 17780] When choose an author in authority results new window shows a blank
screen
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:30:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:30:03 +0000
Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by
	Select2
In-Reply-To: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22242-70-I84Pz6uaEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:30:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:30:06 +0000
Subject: [Koha-bugs] [Bug 22242] Javascript error in value builder cased by
	Select2
In-Reply-To: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22242-70-6Ktp20cFvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22242

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 84565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84565&action=edit
Same as Bug 17780 but in value builders.

Select2 (Bug 13501) introduced divs and inputs that broke some assumptions
about the expected HTML structure.
This patch checks if input has name attribute, because some inputs in Select2
have not.

It brakes value builders marc21_linking_section.tt and unimarc_field_4XX.tt.

Test plan :
1) On a MARC21 database
2) Define 774$0 as a regular subfield
3) Define 774$4 with an authorised value category
4) Define 774$t with value builder marc21_linking_section
5) Create a new record
6) Use value builder in 774$t
7) Search for a record and click choose
8) Without patch : a popup window does not close and show a blank screen
9) With patch : popup windows get close and you see in field 774 $0 and $t
field with values
10) Same tests with a UNIMARC database on field 461 with value builder
unimarc_field_4XX.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 09:39:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 08:39:10 +0000
Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
 allowed in cataloguing
In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22204-70-mKa79agNKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 10:38:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 09:38:38 +0000
Subject: [Koha-bugs] [Bug 22243] New: Advanced Cataloguer editor fails if
 the target contains an apostrophe in the name
Message-ID: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243

            Bug ID: 22243
           Summary: Advanced Cataloguer editor fails if the target
                    contains an apostrophe in the name
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
  Target Milestone: ---

As the title, if a z39.50 target has an apostrophe in the name, the editor
fails with an "Unexpected token" Javascript error. The array containing the
targets is constructed then embedded in the page template and, since the string
is enclosed in unescaped single apostrophes, things fall over.

The fix is to replace ' in target names with &apos;

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 10:39:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 09:39:12 +0000
Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the
 target contains an apostrophe in the name
In-Reply-To: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22243-70-2J83MZLCjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 10:43:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 09:43:12 +0000
Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the
 target contains an apostrophe in the name
In-Reply-To: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22243-70-wK7FTbddB1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84566&action=edit
Bug 22243: Fix unescaped apostrophe in Z target

This patch escapes apostrophes in the z39.50 target name prior to them
being embedded in the template.

To test:

- Create a z39.50 target containing an apostrophe in the title
- Note that the Advanced Cataloguer editor does not load
- Apply the patch
- TEST: Note that the Advanced Cataloguer editor does load

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 10:58:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 09:58:37 +0000
Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the
 target contains an apostrophe in the name
In-Reply-To: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22243-70-GSkqQWo90K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 11:40:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 10:40:54 +0000
Subject: [Koha-bugs] [Bug 22244] New: Typo in Mana Knowledge Base message
Message-ID: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

            Bug ID: 22244
           Summary: Typo in Mana Knowledge Base message
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

There is a typo in the message "You haven't decided if you want to activate
Mana Knowlede Base, please let us know by clicking" The word "Knowledge" is
misspelt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 11:41:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 10:41:42 +0000
Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message
In-Reply-To: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22244-70-GX3ElSObqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com
   Patch complexity|---                         |String patch
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 11:42:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 10:42:57 +0000
Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message
In-Reply-To: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22244-70-hrhqUiqUht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 11:43:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 10:43:00 +0000
Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message
In-Reply-To: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22244-70-QE7JjEO9qD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 84567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84567&action=edit
Bug 22244: Fix typo

knowlede -> knowledge

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:21:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:21:23 +0000
Subject: [Koha-bugs] [Bug 16994] Import and export MARC modification
	templates
In-Reply-To: <bug-16994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16994-70-bAKsfwMrZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #2 from Paul Poulain <paul.poulain at biblibre.com> ---
yes, something for mana, for sure !
Mana is now pushed. BibLibre developers have a lot of things pending, but I add
this idea in my radar (maybe something for an intern in the future ? ;) )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:28:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:28:04 +0000
Subject: [Koha-bugs] [Bug 22245] New: MARC modification templates does not
 allow move or copy control fields
Message-ID: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

            Bug ID: 22245
           Summary: MARC modification templates does not allow move or
                    copy control fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

MARC modification templates does not allow an action with move, copy nor copy
and replace when both from and to fields are control fields.
This should be allowed.
Looks like there just some work to do on RegExp use since it calls
$field->subfields.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:28:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:28:12 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-HmITQlyNpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11395


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395
[Bug 11395] Batch modifications for records
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:28:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:28:12 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-7KDOrLTbGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22245


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245
[Bug 22245] MARC modification templates does not allow move or copy control
fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:29:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:29:42 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-snEkWsyRPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:54:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:54:39 +0000
Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be
 escaped when performing a search
In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22228-70-oEM08uiEp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 12:54:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 11:54:42 +0000
Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be
 escaped when performing a search
In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22228-70-Uedf6c7ptU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228

--- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 84568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84568&action=edit
Bug 22228: Escape lone colons and make sure term is balanced

Escapes unquoted colons that have whitespace on either side. Removed unbalanced
quotes.

Test plan:

1. Make sure the test case described in the bug works
2. Make sure tests pass:
  prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 13:08:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 12:08:10 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-GP8t34atpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 13:21:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 12:21:38 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-x2rg1WzGhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
This is definitely an API enhancement I'd love to see backported as far as
possible!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 13:22:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 12:22:42 +0000
Subject: [Koha-bugs] [Bug 22246] New: Elasticsearch indexing needs a maximum
 length for __sort fields
Message-ID: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246

            Bug ID: 22246
           Summary: Elasticsearch indexing needs a maximum length for
                    __sort fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ere.maijala at helsinki.fi
  Target Milestone: ---

Currently there's no limit to the length of *__sort fields. If such field is
created from item information or something else that can be repeated a lot, the
field may become too long. Such field is e.g. local-classification, which is by
default created from 952o. If there are hundreds or thousands of items, the
field may become longer than what Elasticsearch accepts. Also consider making
it a non-sortable field by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 13:22:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 12:22:57 +0000
Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum
 length for __sort fields
In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22246-70-0GXuDzc2JI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:18:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:18:35 +0000
Subject: [Koha-bugs] [Bug 22247] New:
 Koha::IssuingRule->get_effective_issuing_rule has no hard fallback
Message-ID: <bug-22247-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22247

            Bug ID: 22247
           Summary: Koha::IssuingRule->get_effective_issuing_rule has no
                    hard fallback
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

We don't yet make full use of this Koha::IssuingRule in koha, however I have
now found that the get_effective_... method within it behaves differently to
the some of the C4 modules which query the same table..

In C4::Circulation there is a hard coded default should the default rule not be
set (*, *, *) which claims a loan of 0 days.  This default either needs to be
coded into get_effective_issuing_rule or a Koha::Exception thrown is such a
rule is not found or something....

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:37:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:37:06 +0000
Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input
In-Reply-To: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12283-70-DVIQ1Zi1jH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:37:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:37:27 +0000
Subject: [Koha-bugs] [Bug 20634] Inventory form has 2 identical labels
	"Library:"
In-Reply-To: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20634-70-mmQuocZLB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20634

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:37:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:37:40 +0000
Subject: [Koha-bugs] [Bug 21449] Switch two-column templates to Bootstrap
 grid: Circulation part 2
In-Reply-To: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21449-70-DOrN0G4NoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21449

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:37:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:37:16 +0000
Subject: [Koha-bugs] [Bug 17854] New Print slip and close button next to
	Close button
In-Reply-To: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17854-70-hACX1DcZAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:37:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:37:51 +0000
Subject: [Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
In-Reply-To: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21871-70-HLJZJobyjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:38:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:38:06 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21918-70-NiXwqoT57n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:38:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:38:17 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-JufDZ4C8hS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:38:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:38:29 +0000
Subject: [Koha-bugs] [Bug 22144] Add method metadata() to Koha::Biblio
In-Reply-To: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22144-70-gUNe7iwuMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:38:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:38:42 +0000
Subject: [Koha-bugs] [Bug 22148] Cancelling some payments/writeoffs
 redirects to unexpected page
In-Reply-To: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22148-70-EmBnPcO5R4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22148

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:38:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:38:56 +0000
Subject: [Koha-bugs] [Bug 22155] biblio_metadata.marcflavour should be
	renamed 'schema'
In-Reply-To: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22155-70-KNw7gf4qDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22155

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:39:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:39:09 +0000
Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category
 administration
In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22190-70-WcIHz7OTs2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:39:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:39:20 +0000
Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries
	administration
In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22191-70-xXU0XQ2tMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:39:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:39:28 +0000
Subject: [Koha-bugs] [Bug 22248] New: Error when incrementing Mana comment
Message-ID: <bug-22248-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248

            Bug ID: 22248
           Summary: Error when incrementing Mana comment
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

When I select an existing Mana comment on a subscription the process completes
successfully but in the console this error is returned:


Can't return outside a subroutine at /home/vagrant/kohaclone/svc/mana/increment
line 48.

It looks like that script should return JSON.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:39:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:39:28 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-QhSquxGR4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248
[Bug 22248] Error when incrementing Mana comment
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:39:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:39:33 +0000
Subject: [Koha-bugs] [Bug 22194] Add Koha::Exceptions::Metadata
In-Reply-To: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22194-70-W7FpZHXhh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22194

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:50:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:50:22 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-wgye90AfO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22249


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249
[Bug 22249] Error when submitting Mana comment
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 14:50:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 13:50:22 +0000
Subject: [Koha-bugs] [Bug 22249] New: Error when submitting Mana comment
Message-ID: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249

            Bug ID: 22249
           Summary: Error when submitting Mana comment
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

When I submit a Mana comment on a subscription the process completes
successfully but in the console this error is returned:

Can't locate object method "find" via package "Koha::Resource_comments"
(perhaps you forgot to load "Koha::Resource_comments"?) at
/home/vagrant/kohaclone/Koha/SharedContent.pm line 89.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:11:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:11:03 +0000
Subject: [Koha-bugs] [Bug 22227] Make GET /cities staff only
In-Reply-To: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22227-70-pqUeGjtWzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Can you retry?:

 $ git fetch
 $ git checkout origin/master -b bug22227
 $ kshell
k$ prove t/db_dependent/api/v1/cities.pl

In my case:

 $ kshell
k$ prove t/db_dependent/api/v1/cities.t
t/db_dependent/api/v1/cities.t .. ok
All tests successful.
Files=1, Tests=5,  4 wallclock secs ( 0.03 usr  0.01 sys +  3.21 cusr  0.37
csys =  3.62 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:24:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:24:13 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Hozpbiegot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250
[Bug 22250] Clean up Mana KB integration with serials and reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:24:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:24:13 +0000
Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon
	edit
In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22237-70-1Wfh6D2s7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250
[Bug 22250] Clean up Mana KB integration with serials and reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:24:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:24:13 +0000
Subject: [Koha-bugs] [Bug 22250] New: Clean up Mana KB integration with
 serials and reports
Message-ID: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250

            Bug ID: 22250
           Summary: Clean up Mana KB integration with serials and reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 17047, 22237
  Target Milestone: ---

There are a number of template and JavaScript improvements I'd like to make to
the files related to Mana integration with serials and reports: markup
corrections, improved error handling, and general UI improvements.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237
[Bug 22237] Subscriptions are not linked to Mana upon edit
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:30:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:30:49 +0000
Subject: [Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in
	index keyword
In-Reply-To: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22230-70-pOl59iWwZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230

--- Comment #5 from Patrick Robitaille <patrick.robitaille at collecto.ca> ---
Hi Katrin, 

This could be a field in which we could enter the field dedicated to the search
for ISBN variations. In this way, the different libraries could decide whether
or not to search for variants in ill the field or to limit the search to
particular field. Thus, we could make sure that this search is done in the
index keyword.

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:41:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:41:31 +0000
Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message
In-Reply-To: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22244-70-UaQbbhQ4Sc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:41:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:41:34 +0000
Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message
In-Reply-To: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22244-70-lyoMnztGIc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84567|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 84569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84569&action=edit
Bug 22244: Fix typo

knowlede -> knowledge

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 15:55:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 14:55:49 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
	allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-BOBFkuC4TW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:24 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-ECYyeXZCan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84412|0                           |1
        is obsolete|                            |

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84570&action=edit
Bug 20912: Update database

Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:27 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-P7oks8eSHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84413|0                           |1
        is obsolete|                            |

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84571&action=edit
Bug 20912: Rental Fees based on Time Period

Some libraries would like to be able to charge a rental fee based on the
number of days an item will be checked out, as opposed to the flat fee
currently offered by Koha.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Edit an itemtype, add a daily rental fee of 1.00
4) Check an item of that itemtype out for 7 days
5) Verify the patron now has rental fee of 7.00

Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:31 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-J9WODI27Ks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84414|0                           |1
        is obsolete|                            |

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84572&action=edit
Bug 20912: Update schema file

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:35 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-B3PF7z6dfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84415|0                           |1
        is obsolete|                            |

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84573&action=edit
Bug 20912: (QA follow-up) Fix number of tests and correct typos

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:39 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-9BI9SdHxni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84416|0                           |1
        is obsolete|                            |

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84574&action=edit
Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used
for test

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:42 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-A4pfHjkz8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84417|0                           |1
        is obsolete|                            |

--- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84575&action=edit
Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:46 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-OAx9wsYHuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84418|0                           |1
        is obsolete|                            |

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84576&action=edit
Bug 20912: Move calculation to Koha::Fees

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:50 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-085IE2B2DT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84577&action=edit
Bug 20912: (QA follow-up): Fix up Koha::Fees

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:53 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-3WsdTe4r4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84578&action=edit
Bug 20912: (QA follow-up): Fix up unit tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:29:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:29:57 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-UBWjtEt8Qq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84579&action=edit
Bug 20912: (QA follow-up) Move Fees to Charges::

In preparation for the introduction of Koha::Charges::Fines I have moved
this ::Fees class into the Koha::Charges:: namespace

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:30:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:30:00 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-JaRFuYnonI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84580&action=edit
Bug 20912: (QA follow-up) Test for distinct accountlines

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:30:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:30:05 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-k5rogcnzmU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84581&action=edit
Bug 20912: (QA follow-up) Make DB Update idempotent

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:30:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:30:08 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-b7LqAiAMwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84582&action=edit
Bug 20912: (follow-up) Improve test coverage

Increase test coverage for CanBookBeIssued and fix a introduced during
the refactoring to Koha::Fees.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:30:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:30:12 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-i9vm3O7qva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84583&action=edit
Bug 20912: (follow-up) Add hourly support

It seemed strange to only add support for Daily loans in the feature
when Koha also support loan periods in hours. This patch adds parallel
functionaliy for hourly loan periods.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:30:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:30:16 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-Kp4qO7LZzp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84584&action=edit
Bug 20912: (QA follow-up) Fix TestBuilder

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:30:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:30:20 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-W8lt9lXBlX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84585&action=edit
Bug 20912: (QA follow-up) Fix some test failures

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:32:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:32:29 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-VJkxeJ1KfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I have given this a thorough testing and added a few qa followups to fix some
failing test cases and improve test coverage.

I also felt it important to add support for hourly loan periods and as such,
I've added a pair of follow-ups to add this. As such, although I'd PQA on all
work preceding my own, I've asked Tomas and Kyle to cast their eyes over the
followup as a final QA signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:38:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:38:08 +0000
Subject: [Koha-bugs] [Bug 22251] New: Highest priority holds
Message-ID: <bug-22251-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22251

            Bug ID: 22251
           Summary: Highest priority holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
  Target Milestone: ---

Just like we have a lowest priority toggle for a hold, we need a highest
priority toggle.

Sometimes, we have an item that needs to go through some updating or
processing, and so we place an item on hold and bump it to the top of the list.
 But sometimes someone else will place a hold and bump it to the top of the
list and it will go above that hold.

We either need:

A) A single highest priority per item toggle

or 

B) A highest priority toggle that keeps the hold glued to the top, and when
others are added, they go below previous highest priorities, and cannot be
bumped above them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:38:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:38:55 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-IaYTH6XzVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84419|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:39:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:39:00 +0000
Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-DuWXiOWq9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84420|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:47:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:47:35 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-dnHn5mI044@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84393|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84586&action=edit
Bug 19816: Regression tests

This patch adds tests for the rfc3339 behaviour when dateonly => 1.

To test:
- Run:
  $ kshell
 k$ prove t/DateUtils.t
=> SUCCESS: Tests pass
- Apply this patch
- Run:
 k$ prove t/DateUtils.t
=> FAIL: dateonly is not implemented

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:47:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:47:38 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-PQ8NppKAec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84394|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84587&action=edit
Bug 19816: Implement dateonly for rfc3339 format

This patch implements the dateonly option for the rfc3339. This is
described in the OpenAPI 2.0 specification [1]. The required output
format is described on RFC 3339 [2], as 'full-date'.

[1]
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dataTypeFormat
[2] https://tools.ietf.org/html/rfc3339#section-5.6

To test:
- Apply the regression tests patch
- Run:
 k$ prove t/DateUtils.t
=> FAIL: Tests fail because dateonly is not implemented
- Apply this patch
- Run:
 k$ prove t/DateUtils.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:48:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:48:13 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must implement 'dateonly' for
 dateformat => rfc3339
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-JXqsdFXRr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial enhancement, passes all tests. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:49:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:49:02 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-MzUCkCverI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:58:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:58:31 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-q6eK8FrVt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83945|0                           |1
        is obsolete|                            |

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84588&action=edit
Bug 16497: Add /api/v1/libraries

CRUD for libraries via REST API.

GET    /api/v1/libraries              - List all libraries
GET    /api/v1/libraries/{branchcode} - Get one Library
POST   /api/v1/libraries              - Add new Library
DELETE /api/v1/libraries/{branchcode} - Delete Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:58:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:58:39 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-2pijrSMxwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83947|0                           |1
        is obsolete|                            |

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84590&action=edit
Bug 16497: (follow-up) New column marcorgcode added

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:58:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:58:35 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-4gPs4GhGsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83946|0                           |1
        is obsolete|                            |

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84589&action=edit
Bug 16497: Add missing field in definitions due to bug 18066

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:58:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:58:43 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-88EJx4kmV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83948|0                           |1
        is obsolete|                            |

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84591&action=edit
Bug 16497: Add POD in Koha/REST/V1/Library.pm

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:58:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:58:47 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-Sn1Wr1U6ds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83949|0                           |1
        is obsolete|                            |

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84592&action=edit
Bug 16497: (follow-up) Adapt to existing guidelines and RFC

This patch makes the original implementation match what is specified on
the RFC [1].

The controller is updated, and so the tests.

To test:
- Apply this patches:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/libraries.t
=> SUCCESS: Tests pass!

[1] https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 16:58:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 15:58:51 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-4QiwN1R9sO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84198|0                           |1
        is obsolete|                            |

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 84593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84593&action=edit
Bug 16497: (follow-up) GET operations require staff access

With the introduction of the /public namespace all other endpoints, the
rest of the endpoints are restricted to privileged users.

This patch makes the GET /libraries and GET /libraries/:library_id
endpoints require 'catalogue' permissions.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:00:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:00:27 +0000
Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-EUuZsdp6Wn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
A solid implementation, well tested, passes qa scripts.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:11:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:11:09 +0000
Subject: [Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric
 in numeric eq (==)
In-Reply-To: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21170-70-QcCkoWItBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:13:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:13:10 +0000
Subject: [Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details
 Screen Use Self Register Field Options Incorrectly
In-Reply-To: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21192-70-hjikFKakAz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:15:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:15:41 +0000
Subject: [Koha-bugs] [Bug 22125] branches.pickup_location should be flagged
	as boolean
In-Reply-To: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22125-70-aYOPIyQFj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:15:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:15:41 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-QmcrbJjFXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22252
[Bug 22252] Status messages returned by Mana are not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:15:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:15:41 +0000
Subject: [Koha-bugs] [Bug 22252] New: Status messages returned by Mana are
 not translatable
Message-ID: <bug-22252-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22252

            Bug ID: 22252
           Summary: Status messages returned by Mana are not translatable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 17047
  Target Milestone: ---

Some Mana messages which are shown in Koha are being passed directly from Mana
as English strings:

lib/Mana/Resource.pm: return { msg => "The $resource already exists on Mana,
thanks for your contribution!", id => $id, statuscode => 208 };

These strings are not translatable in Koha. If each message is being sent with
a unique statuscode we should put the messages strings in a template and use
the statuscodes to control their display.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
[Bug 17047] Mana Knowledge Base : share data
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:16:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:16:23 +0000
Subject: [Koha-bugs] [Bug 22101] ILL requests missing in menu on advanced
	search page
In-Reply-To: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22101-70-cjM7fXD428@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:17:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:17:17 +0000
Subject: [Koha-bugs] [Bug 22122] Make sequence of Z39.50 search options
 match in acq and cataloguing
In-Reply-To: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22122-70-oMuQnpELoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:22:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:22:44 +0000
Subject: [Koha-bugs] [Bug 20274] itemtypes.plugin report: not handling
 item-level_itypes syspref
In-Reply-To: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20274-70-WBS1PjA3ka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20274

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:24 +0000
Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and
 scripts for Koha)
In-Reply-To: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18618-70-GQr1otPgL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618
Bug 18618 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:24 +0000
Subject: [Koha-bugs] [Bug 18922] Mana - Share review
In-Reply-To: <bug-18922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18922-70-SEQD90lF4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922
Bug 18922 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:25 +0000
Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports
In-Reply-To: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22193-70-ZbgSXp4j6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193
Bug 22193 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:25 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-PIYpAqXd5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196
Bug 22196 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:25 +0000
Subject: [Koha-bugs] [Bug 22197] Add Mana KB link to administration sidebar
	menu
In-Reply-To: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22197-70-oOE4DViiWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197
Bug 22197 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:26 +0000
Subject: [Koha-bugs] [Bug 22198] Add granular permission setting for Mana KB
In-Reply-To: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22198-70-fkSzvQgw0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198
Bug 22198 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:26 +0000
Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB
	more easily
In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22210-70-VftaPGW0z6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210
Bug 22210 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:26 +0000
Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all
	results
In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22222-70-OYY8bgbls4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222
Bug 22222 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:26 +0000
Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon
	edit
In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22237-70-3x9d3DvLt7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237
Bug 22237 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:26 +0000
Subject: [Koha-bugs] [Bug 22248] Error when incrementing Mana comment
In-Reply-To: <bug-22248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22248-70-Tm1Aku2a5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248
Bug 22248 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:27 +0000
Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment
In-Reply-To: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22249-70-Ac0ZG7a0d2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249
Bug 22249 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:27 +0000
Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials
	and reports
In-Reply-To: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22250-70-gWsBZ1ovfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250
Bug 22250 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:27 +0000
Subject: [Koha-bugs] [Bug 22252] Status messages returned by Mana are not
	translatable
In-Reply-To: <bug-22252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22252-70-UpFFO4DF8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22252
Bug 22252 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:21 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-axckYy0UNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #453 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This enhancement will not be backported to the 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:23:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:23:27 +0000
Subject: [Koha-bugs] [Bug 22202] Breadcrumbs wrong in Mana admin page
In-Reply-To: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22202-70-3PtKpbXuyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22202
Bug 22202 depends on bug 17047, which changed state.

Bug 17047 Summary: Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:35:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:35:02 +0000
Subject: [Koha-bugs] [Bug 7614] Use branch transfer limits for determining
 available opac holds pickup locations
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-5IRvf2EyQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03. 

This should probably have got pushed alongside it's dependants before now but
unfortunately didn't quite make the final cut.  Bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:35:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:35:59 +0000
Subject: [Koha-bugs] [Bug 7403] Remove warning from CataloguingLog system
	preference
In-Reply-To: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7403-70-XBPilO6eCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:37:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:37:06 +0000
Subject: [Koha-bugs] [Bug 20491] Use "Date due" in table header of item table
In-Reply-To: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20491-70-i6E1iABygZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20491

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:38:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:38:05 +0000
Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members
 but has been removed
In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19920-70-f8CDn0nnOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:38:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:38:47 +0000
Subject: [Koha-bugs] [Bug 11922] Add SHOW_BCODE patron attribute for
 Norwegian web installer
In-Reply-To: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11922-70-8DsViFSiT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:39:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:39:29 +0000
Subject: [Koha-bugs] [Bug 22118] Format hold fee when placing holds in OPAC
In-Reply-To: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22118-70-WSGlgM6MPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:40:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:40:46 +0000
Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be
 specified per instance
In-Reply-To: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18909-70-rtWWEwUpgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:41:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:41:56 +0000
Subject: [Koha-bugs] [Bug 21855] Remove mention of deprecated
 delete_unverified_opac_registrations.pl cronjob
In-Reply-To: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21855-70-7FaKq6jPJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:43:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:43:10 +0000
Subject: [Koha-bugs] [Bug 22113] Add price formatting on item lost report
In-Reply-To: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22113-70-E1gOzIItSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22113

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:43:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:43:56 +0000
Subject: [Koha-bugs] [Bug 22111] Correctly format fines when placing holds
 (maxoutstanding warning)
In-Reply-To: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22111-70-St7MNYFGVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:44:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:44:31 +0000
Subject: [Koha-bugs] [Bug 21672] Switch templates to Bootstrap grid: Various
In-Reply-To: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21672-70-CADIVqnTib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21672

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:44:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:44:32 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-ASHTDzKLRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21672, which changed state.

Bug 21672 Summary: Switch templates to Bootstrap grid: Various
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21672

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:47:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:47:44 +0000
Subject: [Koha-bugs] [Bug 22047] set_password should have a
	'skip_validation' param
In-Reply-To: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22047-70-jeOnlU0GID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Invisible enhancement, I'm choosing to backport this to the 18.11.x series for
18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:51:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:51:08 +0000
Subject: [Koha-bugs] [Bug 21826] Automatic authority record generation
	improvements
In-Reply-To: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21826-70-BGWZWuAMzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I love this enhancement, but alas it didn't make 18.11 and can wait for 19.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:51:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:51:08 +0000
Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many
	subfields
In-Reply-To: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21958-70-tGRiAop6Od@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958
Bug 21958 depends on bug 21826, which changed state.

Bug 21826 Summary: Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:57:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:57:07 +0000
Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password
 in the codebase
In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22048-70-rsaG9wd17t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported at this time to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:57:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:57:07 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-Ct6af2C1Zu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992
Bug 21992 depends on bug 22048, which changed state.

Bug 22048 Summary: Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:57:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:57:41 +0000
Subject: [Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
In-Reply-To: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21992-70-NBHzR3K415@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported at this time to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:58:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:58:04 +0000
Subject: [Koha-bugs] [Bug 21792] Switch two-column templates to Bootstrap
 grid: Serials part 3
In-Reply-To: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21792-70-fn67X2JVv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:58:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:58:04 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-3U7h9qOrzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21792, which changed state.

Bug 21792 Summary: Switch two-column templates to Bootstrap grid: Serials part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:58:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:58:33 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-nXih7eDe3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21438, which changed state.

Bug 21438 Summary: Switch two-column templates to Bootstrap grid: Patron card creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:58:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:58:33 +0000
Subject: [Koha-bugs] [Bug 21438] Switch two-column templates to Bootstrap
 grid: Patron card creator
In-Reply-To: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21438-70-J3n8unKbXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21438

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:58:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:58:59 +0000
Subject: [Koha-bugs] [Bug 21965] Switch two-column templates to Bootstrap
 grid: Patrons part 3
In-Reply-To: <bug-21965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21965-70-Fhamcy8A0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21965

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 17:59:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 16:59:00 +0000
Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use
 Bootstrap grid
In-Reply-To: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20654-70-m7EA6hYRl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 21965, which changed state.

Bug 21965 Summary: Switch two-column templates to Bootstrap grid: Patrons part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21965

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:07:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:07:36 +0000
Subject: [Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
In-Reply-To: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21993-70-xGm8FiYKhZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This enhancement verges on a bug and as such I've backported it to 18.11.x
series for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:50 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-iKGLfJedrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series at this time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:50 +0000
Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's
	account
In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21043-70-A00IxIJoS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043
Bug 21043 depends on bug 21002, which changed state.

Bug 21002 Summary: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:50 +0000
Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to
 use Koha::Account->add_debit
In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21720-70-T7rlZynLIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720
Bug 21720 depends on bug 21002, which changed state.

Bug 21002 Summary: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:50 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
 Koha::Account->add_debit
In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21722-70-twRKZAnSMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722
Bug 21722 depends on bug 21002, which changed state.

Bug 21002 Summary: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:51 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
 use Koha::Account->add_debit
In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21728-70-b9dEqBdYSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728
Bug 21728 depends on bug 21002, which changed state.

Bug 21002 Summary: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:51 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-fXqfBnZo4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
Bug 21747 depends on bug 21002, which changed state.

Bug 21002 Summary: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:08:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:08:51 +0000
Subject: [Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use
 Koha::Account->add_debit instead)
In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21756-70-jfoLWPKPjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756
Bug 21756 depends on bug 21002, which changed state.

Bug 21002 Summary: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:12:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:12:56 +0000
Subject: [Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
In-Reply-To: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21993-70-SpSwUxqNmo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #7)
> This enhancement verges on a bug and as such I've backported it to 18.11.x
> series for 18.11.03

Agreed! Great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 18:14:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 17:14:25 +0000
Subject: [Koha-bugs] [Bug 22051] Make Koha::Object->store translate
 'Incorrect <type> value' exceptions
In-Reply-To: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22051-70-kDBIUUQC74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Developer aid, backporting to 18.11.x for 18.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:11:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:11:10 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-fbOdBFTmyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Charles, can you detail the difference (maybe with step by steps?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:16:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:16:53 +0000
Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all
	results
In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22222-70-4AbyxDDdjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:25:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:25:34 +0000
Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly
 decrements accrued overdue fines
In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14591-70-CqW2E2AW9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

--- Comment #7 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Kyle M Hall from comment #3)
> I think the solution is to remove all the dropbox code, and make dropbox
> mode just be a backdated return which backdates to the last day the library
> was previously open.

I disagree with this. We actually don't use bookdrop mode since it confines us
to 24 hours. We manually set the backdate because there are times that we might
be days behind checking in items and times we are caught up. We try to match
the date to when the item was returned.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:36:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:36:07 +0000
Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly
 decrements accrued overdue fines
In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14591-70-AaE5rQMW5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Margo, this will still work. What was removed was the checkbox on the
circulation page that only allowed to set for last day library open in favor of
the newer more flexible specifyreturndate feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:37:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:37:55 +0000
Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly
 decrements accrued overdue fines
In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14591-70-gMPb1xodp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

--- Comment #9 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Katrin Fischer from comment #8)
> Hi Margo, this will still work. What was removed was the checkbox on the
> circulation page that only allowed to set for last day library open in favor
> of the newer more flexible specifyreturndate feature.

Yes, I just read through 13044. I'm generally ok with the solution proposed,
though I do have another comment I'll put in that ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:43:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:43:43 +0000
Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode
In-Reply-To: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13044-70-azKNXtux0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

--- Comment #8 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Kyle M Hall from comment #3)
> I suppose we could make bookdrop mode find the last date open and
> recalculate the fine in full from there. That way it looks the same from a
> user perspective.
> 
> The problem with bookdrop mode is that it is quite fragile. For example, if
> fines.pl doesn't run for a night, and does the following night, then using
> bookdrop mode will decrement the fine by double the expected amount. The
> backdating returns feature does not suffer from this kind of fragility.

One thing to mention here, especially as this related to 21969, is how to
manage payments on accruing items. Right now there is no way to see an accruing
fine, so there's no way to stop from taking payment on the item, but if we are
recalculating fines on checking, what happens to that payment?

The broader question of taking payment on accruing fines is probably worth
discussing as well. I feel we need to do that, especially if a user needs to
make a payment to get below the checkout threshold. Users will expect to be
able to pay that regardless.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:57:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:57:16 +0000
Subject: [Koha-bugs] [Bug 22253] New: Koha throws an exception when updating
 a borrower with an insecure password
Message-ID: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253

            Bug ID: 22253
           Summary: Koha throws an exception when updating a borrower with
                    an insecure password
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
  Target Milestone: ---

To recreate:
1 - Set RequireStrongPassword to 'Don't require'
2 - Have or set a patron with a simple password like 'oops'
3 - Set RequireStrongPassword to 'Require'
4 - Attempt to edit another part of that patron's record (from the full edit
page)
5 - Koha throws an exception

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 19:57:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 18:57:35 +0000
Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a
 borrower with an insecure password
In-Reply-To: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22253-70-uDA5h0srVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:34:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:34:28 +0000
Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a
 borrower with an insecure password
In-Reply-To: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22253-70-6C0XRp3bkN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:34:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:34:31 +0000
Subject: [Koha-bugs] [Bug 22253] Koha throws an exception when updating a
 borrower with an insecure password
In-Reply-To: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22253-70-zejryiru1y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22253

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84594&action=edit
Bug 22253: Check we actually need to update the password

This patch makes memberentry.pl check if password needs to be updated
before attempting to call set_password. Above this there's a check that
won't raise any errors if no password is passed, or the default string (****)
is received.

So we could reach that line of code with no password, but the code
wouldn't check that.

To test:
- In master, edit any patron without changing the password
=> FAIL: It raises an exception
- Apply this patch
- Edit the patron withtout changing the password
=> SUCCESS: Edit successful
- Edit the patron, changing the password
- Try to login with the new password
=> SUCCESS: The password got changed correctly
- Sigh off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:53:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:53:57 +0000
Subject: [Koha-bugs] [Bug 21890] Patron password reset by category
In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21890-70-HlMoyCBdpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84595&action=edit
Bug 21890: DB updates

This patch adds a new column to the categories table:
'can_reset_password' which is a boolean, and represents, well... that.

It also deletes the OpacResetPassword system preference, but first sets
the OpacResetPassword value to all defined categories as it will be used
in the same way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:54:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:54:00 +0000
Subject: [Koha-bugs] [Bug 21890] Patron password reset by category
In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21890-70-BeMW0SUaDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84596&action=edit
Bug 21890: Add can_any_reset_password() to the Categories TT plugin

This patch introduces a method to the Koha::Template::Plugin::Categories
TT plugin. This methods queries for categories that have the
can_reset_password flag set, and returns a boolean representing the fact
that there's at least one category with the flag set.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Template/Plugin/Categories.t
=> SUCCESS: Tests pass!
- Sign off :-D

Caveat: this patch/tests require the schema to be updated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:54:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:54:08 +0000
Subject: [Koha-bugs] [Bug 21890] Patron password reset by category
In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21890-70-o7sPJUyWq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84598&action=edit
Bug 21890: Allow restricting password resets by patron category

This patch makes the templates relying on the OpacResetPassword syspref
use the introduced TT plugin method instead by changing:

[% IF Koha.Preference('OpacResetPassword') %]

=>

[% IF Categories.can_any_reset_password %]

To test:
- Verify that all the places in which the 'forgot password' link is
displayed in OPAC keep working, provided there's at least one category
that has the flag set
- Attempt to recover the password for a patron that belong to a valid
category (i.e. that has the flag set)
=> SUCCESS: You can go through the normal process
- Attempt to recover the password for a patron that belongs to a
category with the flag unset.
=> SUCCESS: Once Koha identifies your category, you are told you are not
allowed to do it
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:54:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:54:04 +0000
Subject: [Koha-bugs] [Bug 21890] Patron password reset by category
In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21890-70-cHGrCmNIOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 84597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84597&action=edit
Bug 21890: Handle can_reset_password on the staff interface

This patch makes the staff interface handle the new flag when editing
the categories. I didn't add the flag to the list of categories table
because it makes it too big, but can be easily added if required by
users or QA.

To test:
- Along with other patches from this bug, edit patron categories
=> SUCCESS: Notice the changes are correctly stored
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 31 20:54:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Jan 2019 19:54:36 +0000
Subject: [Koha-bugs] [Bug 21890] Patron password reset by category
In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21890-70-w3um7JT8l3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.