[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 2 21:34:40 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83598&action=edit
Bug 22048: Use set_password in member-password.pl

This patch makes member-password.pl use $patron->set_password instead of
update_password. The side effect is that setting password and userid
become separate steps in the code.

For the password all the initial checks are the same, but password
strength is checked on calling set_password and an exception is thrown.
So instead of checking the password quality, we just wait for exceptions
and behave the same as before.

Bonus: you will notice I reused the initially fetched $patron object.
Things get simpler :-D

To test:
- Verify that changing the password / userid for a patron works as usual

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list