[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jan 4 22:59:16 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83630|0                           |1
        is obsolete|                            |

--- Comment #21 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> ---
Created attachment 83668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83668&action=edit
Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted

The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't
exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

https://bugs.koha-community.org/show_bug.cgi?id=22053

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list