[Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jan 4 23:59:43 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654
Charles Farmer <charles.farmer at inlibro.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |charles.farmer at inlibro.com
--- Comment #11 from Charles Farmer <charles.farmer at inlibro.com> ---
In the case where neither CountItemsIssued nor
$biblio->has_items_waiting_or_intransit return 1, pushing AllowOnShelfHolds =>
1 to the template doesn't seem enough, since the ReservableItems variable
wouldn't have been initialized in opac-details.pl. On my end, at least, this
means that I'm still not able to see the 'Place hold' button after applying the
patch.
I would suggest either also sending ReservableItems to the template, or simply
setting $allow_onshelf_holds = 1.
Still a bit too early to put this as Failed QA, as I'm not a QA person myself,
but the patch doesn't feel quite right.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list