[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jan 7 11:39:15 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 83676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83676&action=edit
Bug 22071: (follow-up) Simplify code

In order to add features to this method, the current code would force us
to do it for each authentication method.

There's duplicated code that could be simplified. This patch makes the
authentication code just set $user on each block (oauth and cookie
authentication) and moves the final permissions check to the end of the
authenticate_api_request method.

Overall, the behaviour remains unchanged.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
          t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass! Nothing changed!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list