[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 8 19:47:50 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83654|0                           |1
        is obsolete|                            |
  Attachment #83655|0                           |1
        is obsolete|                            |
  Attachment #83656|0                           |1
        is obsolete|                            |

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 83727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83727&action=edit
Bug 22049: Make MarkIssueReturned rely on returndate only

This patch changes the params accepted by
C4::Circulation::MarkIssueReturned by removing the $dropbox_branch
param.

This passed branchcode was only used to initialize the Koha::Calendar
object, but the date arithmetic has already taken place in a couple
places before we reach this point. This logic needs to be simplified
(bug 14591), and this is the starting point.

To test:
- Apply this patch
- Run:
  $ git grep MarkIssueReturned
=> SUCCESS: Check all the uses of the function either originally passed
undef, or now pass the same date that would've been calculated anyway,
in the returndate param.
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list