[Koha-bugs] [Bug 20527] <label> linked to the wrong <input> (wrong "for" attribute) in paycollect.tt

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 16 11:24:43 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20527

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from David Nind <david at davidnind.com> ---
Hi Ethan.

This works for the Write off button.

I think this should also be done for the other buttons as well - Pay, Pay
amount, Pay selected, and Write off selected.

I also noticed that for the row of buttons at the bottom (Pay, Pay amount, Pay
selected, and Write off selected) when you press cancel on the individual
screens that it takes you back to the Transactions tab, rather than Make a
payment tab. This should probably be added as separate bug.

Note that bug 18661 will fix the tab titles when you are in any of the payment
and write off screens so that they stay as 'Transactions' and 'Make a payment' 
(currently they are labelled Account and Pay fines).

I would also add an updated test plan to the bug as well (the QA team will
probably ask for it!), for example:

1. Search for a patron (Patrons > Search > Select a patron)
2. Add an invoice for a patron (Accounting > Create manual invoice)
3. Before applying the patch click on any of the payment or write off buttons*
(under Accounting > Make a payment) - you should notice that the tab focus is
on the search patrons field at the top of the page, rather than the payment
amount field
4. After applying the patch check that the tab focus for all of the payment or
write off buttons* is on the payment amount field (and it should be outlined in
a darker green)

* Buttons for transaction line items: Pay, Write off; Buttons at the bottom:
Pay, Pay amount, Pay selected, and Write off selected

Setting the focus on the payment amount field allows staff to more quickly
update the amount.

It is also an accessibility issue, and fixing this makes navigating the pages
easier for those using accessibility tools, such as screen readers.


David

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list