[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andrew,

some first QA notes here:

1) The QA script fails, easy to fix:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 206)

2) We don't want to change the current behaviour for updating installations, so
the feature should be set to of in the database update. I think since all the
other override features also default to "no", I'd also make it no for new
installations.

3) I don't understand the new entry form for the hold due date. My feeling is
that we should use the one existing already for entering the new due date for
any override. Having 2 forms seems confusing.

4) I'd also have expected the renewal to be locked initially and the checkbox
to unlock it. Reasoning: Renewing an item with a hold should always be an
exception. The way it's now a "renew all" checked on top will also check the
"on hold" ones which might be easily missed. We could relabel the checkbox and
use it for both: Allow override of renewal restrictions?

Last 2 are up for discussion of course. Feel free to seek an additional
opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.