[Koha-bugs] [Bug 22227] Make GET /cities staff only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22227

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Do we need to do anything other than what is in the test plan on a kohadevbox?
For example have some particular data loaded in our database? I've just tried
to apply the patch with the following result:

vagrant at kohadevbox:kohaclone(master)$ git checkout -b bug22227
Switched to a new branch 'bug22227'
vagrant at kohadevbox:kohaclone(bug22227)$ git bz apply 22227
Bug 22227 - Make GET /cities staff only

84507 - Bug 22227: Make GET /cities staff only

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22227: Make GET /cities staff only
vagrant at kohadevbox:kohaclone(bug22227)$ kshell
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/api/v1/cities.t
t/db_dependent/api/v1/cities.t .. 
    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/cities.t line 87.
    #          got: '400'
    #     expected: '200'

    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/cities.t line 87.
    #     Structures begin differing at:
    #          $got->[0]{state} = Does not exist
    #     $expected->[0]{state} =
'O5v1BdpdGC68BA87LFM5W_sSkKGJLmnkPL4rz_34K8hlXzvLUtZsoeuJ8x6tv8zKdJ'

    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/cities.t line 96.
    #          got: '400'
    #     expected: '200'

    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/cities.t line 96.
    #     Structures begin differing at:
    #          $got->[0]{city_id} = Does not exist
    #     $expected->[0]{city_id} = '12'
    # Looks like you failed 4 tests of 18.
t/db_dependent/api/v1/cities.t .. 1/5 
#   Failed test 'list() tests'
#   at t/db_dependent/api/v1/cities.t line 109.

    #   Failed test '403 Forbidden'
    #   at t/db_dependent/api/v1/cities.t line 162.
    #          got: '200'
    #     expected: '403'
    # Looks like you failed 1 test of 17.

#   Failed test 'add() tests'
#   at t/db_dependent/api/v1/cities.t line 226.

    #   Failed test '403 Forbidden'
    #   at t/db_dependent/api/v1/cities.t line 246.
    #          got: '400'
    #     expected: '403'
    # Looks like you failed 1 test of 15.

#   Failed test 'update() tests'
#   at t/db_dependent/api/v1/cities.t line 324.

    #   Failed test '403 Forbidden'
    #   at t/db_dependent/api/v1/cities.t line 343.
    #          got: '200'
    #     expected: '403'

    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/cities.t line 349.
    #          got: '404'
    #     expected: '200'

    #   Failed test 'exact match for content'
    #   at t/db_dependent/api/v1/cities.t line 349.
    #          got: '{"error":"Object not found"}'
    #     expected: '""'
    # Looks like you failed 3 tests of 7.

#   Failed test 'delete() tests'
#   at t/db_dependent/api/v1/cities.t line 360.
# Looks like you failed 4 tests of 5.
t/db_dependent/api/v1/cities.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/5 subtests 

Test Summary Report
-------------------
t/db_dependent/api/v1/cities.t (Wstat: 1024 Tests: 5 Failed: 4)
  Failed tests:  1, 3-5
  Non-zero exit status: 4
Files=1, Tests=5,  3 wallclock secs ( 0.02 usr  0.00 sys +  2.37 cusr  0.24
csys =  2.63 CPU)
Result: FAIL
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.