From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 00:47:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Jun 2019 22:47:50 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
item and allocating to bib-level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hayleymapley at catalyst.net.n
| |z
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 01:40:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Jun 2019 23:40:47 +0000
Subject: [Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779
David Roberts changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david.roberts at ptfs-europe.c
| |om
--- Comment #3 from David Roberts ---
It appears that (at 17.11 at least, I haven't yet tested at other versions) the
action_logs table records holds created as being created the opac, even when
they were created on the staff client.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 02:05:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 00:05:27 +0000
Subject: [Koha-bugs] [Bug 23217] Batch patron modification shows database
errors when no Attribute provided
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217
--- Comment #8 from David Cook ---
Thanks, Jonathan. I'm working from home with a sick child today, but I'll take
a look at signing off your patch when I'm back in the office (with a full size
keyboard instead of a tiny netbook keyboard).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 02:05:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 00:05:52 +0000
Subject: [Koha-bugs] [Bug 23218] Batch patron modification empty attribute
causes improper handling of values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218
--- Comment #2 from David Cook ---
I'll be looking at signing off this one when I'm back at the office as well.
Thanks, Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 07:48:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 05:48:40 +0000
Subject: [Koha-bugs] [Bug 4120] Add options for handling holds in self
checkout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4120
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Katrin Fischer ---
There is AllowItemsOnHoldCheckoutSCO now, I think that fixes this issue.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:01:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 07:01:51 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
Joonas Kylm?l? changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |ASSIGNED
--- Comment #16 from Joonas Kylm?l? ---
(In reply to Kyle M Hall from comment #15)
> Ignoring the fact that AllowItemsOnHoldCheckout appears to be broken right
> now, this seems like it is just *removing* flexibility from Koha, right? Why
> would we want less flexibility instead of more?
Thanks for this comment, for now I think we should keep both of these sysprefs
as discussed in bug #15131. I will make a new version of the patch where this
setting is available again and also applies to SIP checkouts instead of just
SCO module.
Later on we could probably address #15131 in some better way like making a
possibility to authorize another patron to pickup their items.
I'm moving this bug back to ASSIGNED state.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:19:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 07:19:34 +0000
Subject: [Koha-bugs] [Bug 23232] Enable the option to use the onscreen
keyboard on the basic cataloguing editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |RM_priority
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:20:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 07:20:02 +0000
Subject: [Koha-bugs] [Bug 23231] We display too many layout options for the
onscreen keyboard in the advanced cataloguing editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23231
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |RM_priority
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:53:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 07:53:24 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
item and allocating to bib-level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172
--- Comment #3 from Alex Buckley ---
Created attachment 91133
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91133&action=edit
Bug 23172: Unit tests
Adding unit tests to check the output of the
Koha::Hold->check_if_existing_hold_matches_issuingrules()
Test plan:
1. Run test plan in first patch
2. Enter Koha shell:
sudo koha-shell
3. Run: prove t/db_dependent/Hold.t
4. All tests should pass
Sponsored-By: Brimbank Library, Australia
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:09:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 08:09:59 +0000
Subject: [Koha-bugs] [Bug 23239] New: install.pl: DBD::mysql::st execute
failed: Incorrect integer value
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23239
Bug ID: 23239
Summary: install.pl: DBD::mysql::st execute failed: Incorrect
integer value
Change sponsored?: ---
Product: Koha
Version: 19.05
Hardware: PC
OS: Linux
Status: NEW
Severity: minor
Priority: P5 - low
Component: Installation and upgrade (web-based installer)
Assignee: koha-bugs at lists.koha-community.org
Reporter: ashwinloyal at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
I'm using Koha 19.0500000 from Koha official PPA. The DB server that I use is
latest Maria BD 10.4 from their official PPA. During MARC 21 setup, I get this
error:
[Mon Jul 1 07:12:57 2019] install.pl: DBD::mysql::st execute failed: Incorrect
integer value: '' for column `koha_library`.`auth_subfield_structure`.`linkid`
at row 148 at /usr/share/perl5/DBIx/RunSQL.pm line 273.
But, installation completes successfully. Is this a serious error? How can I
prevent it?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:12:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 08:12:13 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
--- Comment #17 from Katrin Fischer ---
Hi Joonas and Kyle,
please also take a look at:
bug 23233
bug 23223
and bug 7090 (which suggests that this was for SIP initially)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:03:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:03:28 +0000
Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does
not set all values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90818|0 |1
is obsolete| |
--- Comment #9 from Martin Renvoize ---
Created attachment 91134
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91134&action=edit
Bug 23083: Add tests
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:03:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:03:51 +0000
Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does
not set all values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Needs Signoff |Signed Off
--- Comment #11 from Martin Renvoize ---
Fix works for me in testing, Signing Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:03:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:03:31 +0000
Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does
not set all values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90819|0 |1
is obsolete| |
--- Comment #10 from Martin Renvoize ---
Created attachment 91135
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91135&action=edit
Bug 23083: Fix course reserve item editing if one of the value is set to
UNCHANGED
Test plan:
0: Do not apply the patches
1: Create an item with itype, ccode, location, and holding branch set
2: Create a course
3: Add item to course, changing the values for itype, ccode, and location
4: Click Edit for that item on course-details.pl
5: Assign new values for itype, ccode, and location but leave the holding
library dropdown set to LEAVE UNCHANGED
6: Hit Save
7: Back on course-details.pl, observe that the item is still showing the values
set in step 3
8: Apply this patch
9: Repeat 4 to 6
10: Back on course-details.pl, observe that the item is now showing the correct
values
11: Edit the course reserve again, setting new values for itype, ccode, and
location and setting the holding library dropdown to whatever the holding
library for the item is currently
12: hit save
13: On course-details.pl, see that the change actually happened, the item is
now showing the values set in step 9
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:09:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:09:37 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Joonas Kylm?l? changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |joonas.kylmala at helsinki.fi
--- Comment #2 from Joonas Kylm?l? ---
The syspref affects also the code in Koha/Item.pm, function "has_pending_hold".
I believe it gets indirectly used in opac/intranet so we can't do this by
simply renaming.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:15:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:15:46 +0000
Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws
a JS error on incomplete/blank lines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90467|0 |1
is obsolete| |
--- Comment #7 from Martin Renvoize ---
Created attachment 91137
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91137&action=edit
Bug 23045: Return record along with errors
We don't seem to directly handle the errors in most cases, let's always return
the record
To test:
1 - Add some blank lines to editor, previous patch is okay with this
2 - Add a line with just 'e' or some other incomplete field
3 - Try to save
4 - Note JS leader error
5 - Apply this patch
6 - No errors
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:15:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:15:43 +0000
Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws
a JS error on incomplete/blank lines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90466|0 |1
is obsolete| |
--- Comment #6 from Martin Renvoize ---
Created attachment 91136
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91136&action=edit
Bug 23045: TextMarc errors on blank lines
Since bug 16251 we use TextMarc to get some record fields, however, it throws
an error when
processing blank lines.
We should just pass on these rather then erroring
To test:
1 - Define a new macro that delete more fields than it adds
delete 245
2 - Run it
3 - Note an error in JS console, and helpers will not load
4 - Apply patch
5 - Reload, try again
6 - No error
Signed-off-by: Claire Gravely
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:17:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:17:33 +0000
Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws
a JS error on incomplete/blank lines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #8 from Martin Renvoize ---
This works well and meets current QA requirements.. so I'm Passing QA..
but.. it really worries me that I can't find any tests for Rancor.. I'd really
like to have this mini-app tested to lower the likelihood or regressions. I'll
open another bug to highlight this issue of missing tests.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:19:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:19:55 +0000
Subject: [Koha-bugs] [Bug 23240] New: Rancor appears to be untested.
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23240
Bug ID: 23240
Summary: Rancor appears to be untested.
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
I can't find any tests for rancor (the advanced cataloguing editor).. I may be
just missing them.. I hope I am.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:20:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:20:04 +0000
Subject: [Koha-bugs] [Bug 23240] Rancor appears to be untested.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23240
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:24:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:24:04 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
Joonas Kylm?l? changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |In Discussion
--- Comment #18 from Joonas Kylm?l? ---
(In reply to Katrin Fischer from comment #17)
> please also take a look at:
> bug 23233
> bug 23223
> and bug 7090 (which suggests that this was for SIP initially)
Mhm, okay so in #23233 Kyle says the AllowItemsOnHoldCheckout affects only SIP
based checkouts which is almost true but not quite there because of one
additional usage in the "has_pending_hold" function. If we get rid of the usage
in "has_pending_hold" function then IMHO it would okay to merge
AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO together since they
are both self-checkouts. That lead me to the question why in #15131 this new
syspref AllowItemsOnHoldCheckoutSCO was even introduced? Didn't the bug
reporter just know because of the wrong documentation (as Jonathan points out
in the report) that the AllowItemsOnHoldCheckout would have worked also in the
situation described in the report?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:27:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:27:49 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
--- Comment #19 from Katrin Fischer ---
(In reply to Joonas Kylm?l? from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > please also take a look at:
> > bug 23233
> > bug 23223
> > and bug 7090 (which suggests that this was for SIP initially)
>
> Mhm, okay so in #23233 Kyle says the AllowItemsOnHoldCheckout affects only
> SIP based checkouts which is almost true but not quite there because of one
> additional usage in the "has_pending_hold" function. If we get rid of the
> usage in "has_pending_hold" function then IMHO it would okay to merge
> AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO together since they
> are both self-checkouts. That lead me to the question why in #15131 this new
> syspref AllowItemsOnHoldCheckoutSCO was even introduced? Didn't the bug
> reporter just know because of the wrong documentation (as Jonathan points
> out in the report) that the AllowItemsOnHoldCheckout would have worked also
> in the situation described in the report?
I think better to keep them separate - both are self checks, but... libraries.
There might be a use case that we are not aware of right now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:36:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:36:08 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
Joonas Kylm?l? changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |23233
--- Comment #20 from Joonas Kylm?l? ---
(In reply to Katrin Fischer from comment #19)
> I think better to keep them separate - both are self checks, but...
> libraries. There might be a use case that we are not aware of right now.
Okay, fine by me, but maybe we could also announce somewhere in the main page
that we are deprecating it? Or better, in the syspref setttings page. This way
we don't have to carry it with us just because theoretically somebody might
want to use it. And so if somebody complains then we remove the deprecation.
I'm gonna make this bug depend on #23233 (the renaming of
AllowItemsOnHoldCheckout to AllowItemsOnHoldCheckoutSIP) since that sounds easy
to fix now and would conflict with this patch.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
[Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is
for SIP-based checkouts only
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:36:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:36:08 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Joonas Kylm?l? changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21572
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
[Bug 21572] Allow checkout an item with reserve that is not yet in waiting
state
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:45:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:45:18 +0000
Subject: [Koha-bugs] [Bug 23241] New: Does misc/bin/koha-index-daemon-ctl.sh
still belong in community koha?
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23241
Bug ID: 23241
Summary: Does misc/bin/koha-index-daemon-ctl.sh still belong in
community koha?
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
We have had a daemon mode in rebuild_zebra.pl for a long time and have been
using that as the default indexing daemon for years.. Should we deprecate the
above script to prevent confusion for new users where indexing should just work
out of the box without the need for installing external dependancies.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:46:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:46:36 +0000
Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |RESOLVED
CC| |martin.renvoize at ptfs-europe
| |.com
Resolution|--- |WONTFIX
--- Comment #7 from Martin Renvoize ---
We've had an indexing daemon in koha for years now.. do we really still need
this confusing/misleading script in community koha at all?
I've opened a new bug to discuss #23241 and am going to mark this one as
wontfix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:46:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:46:53 +0000
Subject: [Koha-bugs] [Bug 23241] Does misc/bin/koha-index-daemon-ctl.sh
still belong in community koha?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23241
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=10665
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:46:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 09:46:53 +0000
Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=23241
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:02:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:02:35 +0000
Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19474,
| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=20427
Status|In Discussion |Patch doesn't apply
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:02:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:02:35 +0000
Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=1918
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:02:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:02:35 +0000
Subject: [Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=1918
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:07:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:07:14 +0000
Subject: [Koha-bugs] [Bug 2326] Help should be diff for each of the sys pref
tabs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2326
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|In Discussion |Patch doesn't apply
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19817
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:07:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:07:14 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=2326
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:15:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:15:52 +0000
Subject: [Koha-bugs] [Bug 2960] Cyrillic Z39-50 servers (bad encoding
results)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2960
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|In Discussion |RESOLVED
CC| |nick at bywatersolutions.com
--- Comment #3 from Nick Clemens ---
No more reports of this, and no response from filer, closing this one
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:21:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:21:47 +0000
Subject: [Koha-bugs] [Bug 21005] Missing row/column defaults cause
unexpected results in report wizards
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #11 from Nick Clemens ---
*** Bug 3311 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:21:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:21:47 +0000
Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and
column aren't selected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |RESOLVED
CC| |nick at bywatersolutions.com
Resolution|--- |DUPLICATE
--- Comment #50 from Nick Clemens ---
*** This bug has been marked as a duplicate of bug 21005 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:54:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:54:06 +0000
Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|In Discussion |Patch doesn't apply
--- Comment #17 from Nick Clemens ---
Cardnumber appears to have been added, other info still not.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:54:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:54:35 +0000
Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #15 from Martin Renvoize ---
Bug 15171 actually hard codes to always display all expirations before the
entered date and so resolved this issue..
However, I prefer the logic here which allowed the end user to select whether
to display old expired subscriptions or not. (Also, I'm sure the description on
bug 15171 is incorrect).
I'm going to resurrect this bug
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:56:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:56:32 +0000
Subject: [Koha-bugs] [Bug 23242] New: Error when adding new server in DB
strict mode
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23242
Bug ID: 23242
Summary: Error when adding new server in DB strict mode
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Z39.50 / SRU / OpenSearch Servers
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Unless you select 'preselected' and set 'rank' and 'timeout'
DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for
column 'checked' at row 1 at /kohadevbox/koha/admin/z3950servers.pl line 82
at /usr/share/perl5/DBIx/Class/Exception.pm line 77
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:56:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 10:56:40 +0000
Subject: [Koha-bugs] [Bug 23242] Error when adding new server in DB strict
mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23242
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:13:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:13:09 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #3 from Kyle M Hall ---
(In reply to Joonas Kylm?l? from comment #2)
> The syspref affects also the code in Koha/Item.pm, function
> "has_pending_hold". I believe it gets indirectly used in opac/intranet so we
> can't do this by simply renaming.
The one and only use of this method is in
koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc so supressing the
pending hold status here based on the system preference should be considered
buggy behavior as well! I'll file a followup to remove the use of the syspref
for that method.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:19:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:19:14 +0000
Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23243
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
[Bug 23243] Show items expired before today in check expiration of serials page
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:19:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:19:14 +0000
Subject: [Koha-bugs] [Bug 23243] New: Show items expired before today in
check expiration of serials page
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
Bug ID: 23243
Summary: Show items expired before today in check expiration of
serials page
Change sponsored?: Sponsored
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: adrien.saurat at biblibre.com,
charles.farmer at inlibro.com,
colin.campbell at ptfs-europe.com,
eric.begin at inLibro.com, katrin.fischer at bsz-bw.de,
koha-bugs at lists.koha-community.org,
koha.sekjal at gmail.com,
martin.renvoize at ptfs-europe.com,
maxime.beaulieu at inlibro.com, paola.rossi at cineca.it,
paul.poulain at biblibre.com, pelletiermaxime at gmail.com,
philippe.blouin at inlibro.com,
simith.doliveira at inlibro.com
Depends on: 6968
+++ This bug was initially created as a clone of Bug #6968 +++
The Check Expiration page in Serials is now hardcoded (bug 15171) to always
show all subscriptions that expire/expired before the date specified. We should
have optionally enabled filtering out the historic expirations that have
happened before today rather than removing that feature entirely.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968
[Bug 6968] Show items expired before today in check expiration of serials page
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:19:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:19:47 +0000
Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
--- Comment #1 from Martin Renvoize ---
Created attachment 91138
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91138&action=edit
Bug 23243: Restore filtering out historic expired subscriptions
The 'Check Expiration' page in Serials is now hardcoded to display all
expired subscriptions before the entered date. This patch restores the
ability to limit the results to just those expiring between 'today'
and the date entered.
Original code taken from bug 6968 autored by Maxime Pelletier, rebased
by Charles Farmer and then moved to a new report and rebased again by
Martin Renvoize.
Test plan:
1) Without the patch any results after a search from this page will
result in matches both before after todays date (but before the date
you entered).
2) With the patch you should see a 'Show historic expirations' checkbox
which will allow you to limit the results to just those that expire
between the date you enter and today.
Sponsored-by: CCSR
Rescued-by: Charles Farmer
Rescued-by: Martin Renvoize
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:20:17 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:20:21 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #4 from Kyle M Hall ---
Created attachment 91139
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91139&action=edit
Bug 23233: Remove use of AllowItemsOnHoldCheckout from
Koha::Item::has_pending_hold, it can cause false data to be returned
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:20:30 +0000
Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--- Comment #2 from Martin Renvoize ---
Patch reworked from bug 6968 and attached, ready for testing.
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:20:40 +0000
Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
|ity.org |.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:21:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:21:13 +0000
Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |MOVED
Status|Patch doesn't apply |RESOLVED
--- Comment #16 from Martin Renvoize ---
Moved to bug 23243 which updates it to the current context.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:21:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:21:14 +0000
Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check
expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
Bug 23243 depends on bug 6968, which changed state.
Bug 6968 Summary: Show items expired before today in check expiration of serials page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |RESOLVED
Resolution|--- |MOVED
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:23:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:23:14 +0000
Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in
details data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Resolution|--- |WORKSFORME
Status|In Discussion |RESOLVED
--- Comment #10 from Nick Clemens ---
Newlines in note fields appear to be respected in the Descriptions tab - else
in XLST controlled sections they may not. Patch here seems to address the first
- closing this one
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:23:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:23:34 +0000
Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic
subscription expirations in the check expiration of serials page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Show items expired before |Allow filtering out of
|today in check expiration |historic subscription
|of serials page |expirations in the check
| |expiration of serials page
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:42:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:42:25 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
--- Comment #21 from Kyle M Hall ---
> Okay, fine by me, but maybe we could also announce somewhere in the main
> page that we are deprecating it? Or better, in the syspref setttings page.
> This way we don't have to carry it with us just because theoretically
> somebody might want to use it. And so if somebody complains then we remove
> the deprecation.
I'm not sure I understand what you are proposing we deprecate. Can you clarify
that for me? Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:44:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:44:45 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
--- Comment #22 from Joonas Kylm?l? ---
(In reply to Kyle M Hall from comment #21)
> > Okay, fine by me, but maybe we could also announce somewhere in the main
> > page that we are deprecating it? Or better, in the syspref setttings page.
> > This way we don't have to carry it with us just because theoretically
> > somebody might want to use it. And so if somebody complains then we remove
> > the deprecation.
>
> I'm not sure I understand what you are proposing we deprecate. Can you
> clarify that for me? Thanks!
To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g.
"AllowItemsOnHoldCheckoutSCO".
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:45:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:45:30 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
--- Comment #23 from Joonas Kylm?l? ---
(In reply to Joonas Kylm?l? from comment #22)
> > I'm not sure I understand what you are proposing we deprecate. Can you
> > clarify that for me? Thanks!
>
> To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g.
> "AllowItemsOnHoldCheckoutSCO".
Sorry, I meant just to have for example "AllowItemsOnHoldCheckout"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:48:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:48:14 +0000
Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a
'no-image' class, in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:48:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:48:16 +0000
Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a
'no-image' class, in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50497|0 |1
is obsolete| |
--- Comment #9 from Nick Clemens ---
Created attachment 91140
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91140&action=edit
Bug 13597: Make staff client amazon no image results match opac
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:50:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:50:31 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Joonas Kylm?l? changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
--- Comment #5 from Joonas Kylm?l? ---
(In reply to Kyle M Hall from comment #4)
> Created attachment 91139 [details] [review]
> Bug 23233: Remove use of AllowItemsOnHoldCheckout from
> Koha::Item::has_pending_hold, it can cause false data to be returned
Thanks. So just to summarize what this does: In
koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc it is shown to patron
whether the item is available for checkout and without this patch it actually
showed whether it is available through SIP server and didn't consider it could
have been available through intranet or SCO. This same bug seems to be in two
other lines in the same Koha/Items.pm file:
C4/Items.pm: $query .= ",IF(tmp_holdsqueue.itemnumber,1,0) AS
has_pending_hold" if !C4::Context->preference('AllowItemsOnHoldCheckout');
C4/Items.pm: LEFT JOIN tmp_holdsqueue USING (itemnumber)" if
!C4::Context->preference('AllowItemsOnHoldCheckout');
Shouldn't those also be fixed?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:52:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:52:18 +0000
Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a
'no-image' class, in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
--- Comment #10 from Nick Clemens ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Mason James from comment #7)
> > > On master, I have set a local cover image for 1 record and not for another
> > > one.
> > > Launch a search, I get the local cover image for the first record and the
> > > "No cover image available" for the other one.
> > >
> > > Switching off LocalCoverImages, I get the amazon "No image available" image
> >
> > Jonathan, on staff, with patch and CSS added, LocalCoverImages off.. you get
> > the amazon "No image available" image shown?
>
> I do not know, I have not tried, why should I?
> I think I did not get the goal of this patch.
> Could you please give me the use case and provide a more detailed test plan?
The point is to make Staff client HTML for missing amazon cover images more
equivalent to that of the OPAC
To test:
1 - Enable amazon images everywhere
2 - Search on the Staff and OPAC to get some results without amazon covers
(missing ISBNs and bad ISBNs)
3 - Note OPAC missing images are like:
No cover image available
4 - Note Staff client are like:
5 - The staff links do not lend themselves to easy CSS hiding/styling
6 - Apply patch
7 - Repeat
8 - Note increased consistency
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:53:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:53:59 +0000
Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image
available" message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
CC| |nick at bywatersolutions.com
Status|In Discussion |RESOLVED
--- Comment #13 from Nick Clemens ---
Seems discussion is that we need consistent links and then CSS works here,
making this a duplicate of 13597 to allow that to resolve this
*** This bug has been marked as a duplicate of bug 13597 ***
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:53:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 11:53:59 +0000
Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a
'no-image' class, in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |reed at catalyst.net.nz
--- Comment #11 from Nick Clemens ---
*** Bug 5761 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:15:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:15:21 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
First issue date, not Subscription start date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84312|0 |1
is obsolete| |
--- Comment #4 from Nick Clemens ---
Created attachment 91141
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91141&action=edit
Bug 15148: Predict serials issues from subscription start date
To test:
1 - Create a new serial
2 - Set 'First issue plublication date' to some date in 2016
3 - Set subscription start date to today
4 - Set length to 104 weeks
5 - Test prediction pattern - only one generated
6 - Apply patch
7 - Test prediction patern - many generated!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:15:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:15:18 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
First issue date, not Subscription start date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:18:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:18:40 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
First issue date, not Subscription start date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148
--- Comment #5 from Nick Clemens ---
Created attachment 91142
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91142&action=edit
Bug 15148: Make param order more logical
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:18:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:18:58 +0000
Subject: [Koha-bugs] [Bug 23232] Enable the option to use the onscreen
keyboard on the basic cataloguing editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |master
Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:19:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:19:22 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #6 from Kyle M Hall ---
(In reply to Joonas Kylm?l? from comment #5)
> (In reply to Kyle M Hall from comment #4)
> > Created attachment 91139 [details] [review] [review]
> > Bug 23233: Remove use of AllowItemsOnHoldCheckout from
> > Koha::Item::has_pending_hold, it can cause false data to be returned
>
> Thanks. So just to summarize what this does: In
> koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc it is shown to
> patron whether the item is available for checkout and without this patch it
> actually showed whether it is available through SIP server and didn't
> consider it could have been available through intranet or SCO. This same bug
> seems to be in two other lines in the same Koha/Items.pm file:
>
> C4/Items.pm: $query .= ",IF(tmp_holdsqueue.itemnumber,1,0) AS
> has_pending_hold" if !C4::Context->preference('AllowItemsOnHoldCheckout');
>
> C4/Items.pm: LEFT JOIN tmp_holdsqueue USING (itemnumber)" if
> !C4::Context->preference('AllowItemsOnHoldCheckout');
>
> Shouldn't those also be fixed?
You are absolutely right! Good catch :)
I'll update my followup to include those changes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:20:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:20:32 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
First issue date, not Subscription start date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
Hm, I am not sure this is right.
We always say that the date of the first issue matters, so if you set that to
15th and the subscription start date to 1st, the pattern should still use the
15th for calculating. That's how it always worked, it looks like this might
change that?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:45:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:45:15 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:45:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:45:17 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #7 from Kyle M Hall ---
Created attachment 91143
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91143&action=edit
Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:45:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:45:59 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91143|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:50:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:50:01 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #8 from Joonas Kylm?l? ---
(In reply to Kyle M Hall from comment #7)
> Created attachment 91143 [details] [review]
> Bug 23233: Remove use of AllowItemsOnHoldCheckout from
> C4::Items::GetItemsInfo
You accidentally obsoleted the new patch instead of old one?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:56:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 12:56:42 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #9 from Kyle M Hall ---
Created attachment 91144
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91144&action=edit
Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:07:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:07:10 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
--- Comment #10 from Kyle M Hall ---
(In reply to Joonas Kylm?l? from comment #8)
> (In reply to Kyle M Hall from comment #7)
> > Created attachment 91143 [details] [review] [review]
> > Bug 23233: Remove use of AllowItemsOnHoldCheckout from
> > C4::Items::GetItemsInfo
>
> You accidentally obsoleted the new patch instead of old one?
I realized it wasn't complete and I decided to keep it separate for clarity.
Thanks for checking!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:08:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:08:24 +0000
Subject: [Koha-bugs] [Bug 23244] New: Sort order in basket to default to
title
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244
Bug ID: 23244
Summary: Sort order in basket to default to title
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: paul.thornton at educampus.ie
QA Contact: testopia at bugs.koha-community.org
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:09:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:09:51 +0000
Subject: [Koha-bugs] [Bug 23244] Sort order in basket to default to title
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244
--- Comment #1 from Paul Thornton ---
Customer wants the sort order in a basket to default to title a-z, and have all
titles in the basket display on the one screen. While you can create it to 'x
number of entries' and also display a-z, it cannot be set as a default
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:11:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:11:04 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is
not yet in waiting state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572
--- Comment #24 from Kyle M Hall ---
(In reply to Joonas Kylm?l? from comment #23)
> (In reply to Joonas Kylm?l? from comment #22)
> > > I'm not sure I understand what you are proposing we deprecate. Can you
> > > clarify that for me? Thanks!
> >
> > To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g.
> > "AllowItemsOnHoldCheckoutSCO".
>
> Sorry, I meant just to have for example "AllowItemsOnHoldCheckout"
Thanks! I tend to agree with Katrin. For instance, it may be that Koha SCO is
being used on site and librarians want to prevent patrons from grabbing books
from the hold shelf and SIP is being used off site and if the "patron has
possession" of the item they need to be able to check it out. This scenario is
completely contrived but I think it's illustrative ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:11:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:11:35 +0000
Subject: [Koha-bugs] [Bug 23245] New: Floating toolbar on vendors page
overlaps with vendor name
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245
Bug ID: 23245
Summary: Floating toolbar on vendors page overlaps with vendor
name
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
Created attachment 91145
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91145&action=edit
Floating toolbar overlapping with vendor name
In some browsers we see strange behaviur with the new floating toolbar on the
vendor summary page. The toolbar will overlap with the vendor's name (see
screenshot).
So far it happens in:
Version 73.0.3683.103 (Windows)
Firefox Quantum, 67.0.4 (Windows)
Working well:
Firefox Quantum 60.7.1esr (64-Bit) (Windows)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:13:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:13:29 +0000
Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare
OO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--- Comment #1 from Kyle M Hall ---
(In reply to Tom?s Cohen Arazi from comment #0)
> This method is to be run inside plugin objects that inherit from
> Koha::Plugins::Base, but calling
>
> $self->_version_compare();
>
> won't work because the method doesn't expect $self to be passed.
We should make it work either way since historically it has been non-OO and
there are some plugins that may be using it in a non-OO way. I think ti should
be easy to check the first parameter to know if it is being called as an object
method or not!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:14:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 13:14:54 +0000
Subject: [Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps
with vendor name
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245
Christian Stelzenm?ller changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |christian.stelzenmueller at bs
| |z-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:02:30 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
inappropriately and is missing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:02:39 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
inappropriately and is missing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #16 from Nick Clemens ---
Created attachment 91147
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91147&action=edit
Bug 16787: Add tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:02:45 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
inappropriately and is missing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #17 from Nick Clemens ---
Created attachment 91148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91148&action=edit
Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record
To test:
1 - Set 'Holds per record' to 0 for some itemtype/patorn combination
2 - Attempt to plac a hold
3 - Will see 'Too many..'
4 - Apply patch
5 - Try again
6 - Should now see 'No holds..'
7 - prove -v t/db_dependent/Holds.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:02:35 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
inappropriately and is missing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72827|0 |1
is obsolete| |
Attachment #72828|0 |1
is obsolete| |
Attachment #72889|0 |1
is obsolete| |
--- Comment #15 from Nick Clemens ---
Created attachment 91146
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91146&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data
This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds
To test:
1 - Set an item type to allow no holds
2 - Attempt to place a hold for a patron
3 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
4 - Try placing a multihold with the record above and a holdable record,
message should end "...cannot place holds on some of these titles'
items"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:02:51 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
inappropriately and is missing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #18 from Nick Clemens ---
Created attachment 91149
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91149&action=edit
Bug 16787: Rebase fixes and updates
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:21:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:21:11 +0000
Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many
subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:21:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:21:14 +0000
Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many
subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84283|0 |1
is obsolete| |
--- Comment #5 from Nick Clemens ---
Created attachment 91150
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91150&action=edit
Bug 21958: Fix bibliographic record field comparison with authority
This makes the comparison between bibliographic field and authority field more
robust and per subfield. This makes the comparison not consider the same e.g.
the following fields:
$a Test User
$a Test $b User
The actual issue cannot be as easily reproduced with the patches for bug 21826
applied, but here's a test plan anyway:
1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*)
2. Make sure authority linking still works properly
3. Make sure authority and biblio frameworks allow subfield i
4. Make sure that even if you add subfield i to 700 in biblio, authority link
is kept the same
5. Make sure that even if you add subfield i to the authority record, the
authority link is kept the same
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:38:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:38:01 +0000
Subject: [Koha-bugs] [Bug 22826] Allow indexing of individual authority
records in Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:38:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:38:11 +0000
Subject: [Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps
with vendor name
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|master |18.11
--- Comment #1 from Katrin Fischer ---
Chrome works with 19.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:38:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:38:05 +0000
Subject: [Koha-bugs] [Bug 22826] Allow indexing of individual authority
records in Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89330|0 |1
is obsolete| |
--- Comment #4 from Nick Clemens ---
Created attachment 91151
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91151&action=edit
Bug 22826: Allow indexing of individual authorities in Elasticsearch
To test:
1 - perl misc/search_tools/rebuild_elastic_search.pl -h
2 - Note it indicates the bn option can be passed to index individual authids
3 - perl misc/search_tools/rebuild_elastic_search.pl -a -bn 92 -v
4 - Note the error
5 - Apply patch
6 - perl misc/search_tools/rebuild_elastic_search.pl -h
7 - Note new option ai|authid for indexing individual authids
8 - Note updated text for bn|biblionumber option
9 - perl misc/search_tools/rebuild_elastic_search.pl -a -bn 92 -v
10 - No errors, but no records indexed
11 - perl misc/search_tools/rebuild_elastic_search.pl -a -ai 92 -v
12 - 1 record indexed
13 - perl misc/search_tools/rebuild_elastic_search.pl -ai 92 -bn 92 -v
14 - 1 authority record and 1 biblio record indexed
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:45:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:45:51 +0000
Subject: [Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps
with vendor name
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245
--- Comment #2 from Katrin Fischer ---
Firefox Quantum, 67.0.4 (Windows) works with 19.05 too
I think this might make this WONTFIX?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:45:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:45:55 +0000
Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare
OO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230
--- Comment #2 from Tom?s Cohen Arazi ---
Created attachment 91152
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91152&action=edit
Bug 23230: Unit tests
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:45:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:45:58 +0000
Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare
OO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230
--- Comment #3 from Tom?s Cohen Arazi ---
Created attachment 91153
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91153&action=edit
Bug 23230: Make _version_compare OO context aware
On using _version_compare in plugins development, it would be nice if it
was able to be called as an object method. This way we don't need to
fully qualify it like this:
Koha::Plugins::Base::_version_compare
and we can do
$self->_version_compare
instead.
This patch implements this behavior change. It is backwards compatible
so plugins using the 'old way' don't break.
To test:
- Apply the unit tests patch
- Run:
$ kshell
k$ prove t/db_dependent/Plugins.t
=> FAIL: Tests fail
- Apply this patch
- Run:
k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass!
- Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:47:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:47:19 +0000
Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare
OO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:47:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:47:27 +0000
Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare
OO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:50:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:50:09 +0000
Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of
category limits
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
|y.org |
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:55:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 14:55:27 +0000
Subject: [Koha-bugs] [Bug 23246] New: Record detail page jumps into the
'images' tab if no holdings
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
Bug ID: 23246
Summary: Record detail page jumps into the 'images' tab if no
holdings
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
This is certainly related to bug 16507. The original implementation is supposed
to jump into the 'media tab' if there are no holdings, but it is not checking
HTML5MediaEnabled or HTML5MediaYouTube in order to jump to that tab.
Steps to reproduce:
- Have HTML5MediaYouTube and HTML5MediaEnabled disabled
- Create a record with no items
- Go to the detail page
=> FAIL: the 'Images' tab is selected
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:21 +0000
Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's
renewability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:23 +0000
Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's
renewability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003
--- Comment #30 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:25 +0000
Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of
category limits
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:27 +0000
Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of
category limits
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492
--- Comment #70 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:30 +0000
Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy,
returnbranch to circulation_rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:32 +0000
Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy,
returnbranch to circulation_rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928
--- Comment #117 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:34 +0000
Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws
a JS error on incomplete/blank lines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |19.11.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:36 +0000
Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws
a JS error on incomplete/blank lines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045
--- Comment #9 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:37 +0000
Subject: [Koha-bugs] [Bug 23225] OPAC ISBD view returns 404 when no item
attached
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:19:39 +0000
Subject: [Koha-bugs] [Bug 23225] OPAC ISBD view returns 404 when no item
attached
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225
--- Comment #13 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:34:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:34:56 +0000
Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13325
CC| |martin.renvoize at ptfs-europe
| |.com
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325
[Bug 13325] Add logs for budgets and funds
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:34:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:34:56 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |13988
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988
[Bug 13988] Log activities related to Acquisitions
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:39:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:39:55 +0000
Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws
a JS error on incomplete/blank lines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045
Margaret changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |margaret at bywatersolutions.c
| |om
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:54:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:54:01 +0000
Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Failed QA
--- Comment #4 from Martin Renvoize ---
Failing QA.. we need tests adding to
Koha/SearchEngine/Elasticsearch/QueryBuilder.t for this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:54:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 15:54:06 +0000
Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:03:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 16:03:38 +0000
Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from
payment plugin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213
--- Comment #4 from Martin Renvoize ---
As a note to this one.. I think it really ought to have been written
independently of bug 23214 really.. it was a surprise to see that as a
dependency here as really they're pretty unrelated changes.
I will however on this occasion look to testing both to save you a refactor.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:06:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 16:06:33 +0000
Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from
payment plugin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213
--- Comment #5 from Martin Renvoize ---
On second thoughts.. the tree beneath bug 23214 is fairly large and currently
blocked by an FQA bug.. will wait on that to test this, but in effect, it means
this bug is blocked..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:22:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 16:22:07 +0000
Subject: [Koha-bugs] [Bug 19383] Print hold slips without confirmation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383
--- Comment #13 from jdemuth at roseville.ca.us ---
We just tested the automatic printing and it only seems to work if you have one
library location. It works for everything else but at the end we tried
switching the hold location to one of our other branches and it still auto
prints the hold even. Here is my test example:
1. Item found on Library A shelf for pick up at Library B.
2. Check in item at Library A to trigger the transfer.
3. Hold slip prints and says its on hold at Library B.
So it looks like it overwrites the transfer, however a transfer box does come
up under the hold box.
Thanks,
Jen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:25:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 16:25:12 +0000
Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images'
tab if no holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
--- Comment #1 from Tom?s Cohen Arazi ---
Created attachment 91154
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91154&action=edit
Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to
This patch makes jumping into the third tab happen only if
HTML5MediaEnabled is set to 'both' or 'staff'.
To test:
- Have HTML5MediaEnabled set to 'opac' or 'not at all'
- Open the detail page of a record with no holdings
=> FAIL: The 'images' tab is selected
- Apply this patch
- Reload
=> SUCCESS: The 'holdings' tab is selected as it should be.
- Sign off :-D
Sponsored-by: America Numismatic Society
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:25:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 16:25:32 +0000
Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images'
tab if no holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:18:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:18:25 +0000
Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images'
tab if no holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
--- Comment #2 from Tom?s Cohen Arazi ---
Created attachment 91155
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91155&action=edit
Bug 23246: (follow-up) Hardcoding tab position is not enough
There are many conditions that determine the tab number for 'media'.
Translated into variables that hold the tabs count on each condition, it
is clear that '3' was not good enough:
[%- holdings = (SeparateHoldings) ? 2 : 1
notes = (MARCNOTES || notes) ? 1 : 0
acq = (Koha.Preference('AcquisitionDetails')) ? 1 : 0
frbr = (FRBRizeEditions && XISBNS) ? 1 : 0
local_covers = (LocalCoverImages && (localimages ||
CAN_user_tools_upload_local_cover_images)) ? 1 : 0
media_tab = holdings + notes + acq + frbr + local_covers
-%]
This patch gets rid of the hardcoded value, adds an id to the 'media'
tab (i.e. 'media_tab') and uses JS to get the right index.
To test:
- Play with the different options governing those variables
=> FAIL: 3 is not always the 'media' tab
- Apply this patch
- Repeat your tests
=> SUCCESS: It always picks the 'media' tab
- Sign off :-D
Sponsored-by: American Numismatics Society
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:19:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:19:28 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
to a record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #153 from Martin Renvoize ---
I hit this error during DB update.. seems harmless but perhaps we should be
handling it better.
DEV atomic update: bug_14570.perl
DBD::mysql::db do failed: Column 'relationship' cannot be null [for Statement "
INSERT INTO borrower_relationships ( guarantor_id, guarantee_id,
relationship )
SELECT guarantorid, borrowernumber, relationship FROM borrowers
WHERE guarantorid IS NOT NULL;
"] at (eval 1396) line 24.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:19:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:19:30 +0000
Subject: [Koha-bugs] [Bug 9548] Log changes to baskets/basket groups so you
can print/download the same data as at time of creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548
Janet McGowan changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |janet.mcgowan at ptfs-europe.c
| |om
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:20:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:20:34 +0000
Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images'
tab if no holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |16507
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507
[Bug 16507] Show play media tab first
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:20:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:20:34 +0000
Subject: [Koha-bugs] [Bug 16507] Show play media tab first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23246
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
[Bug 23246] Record detail page jumps into the 'images' tab if no holdings
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:28:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:28:42 +0000
Subject: [Koha-bugs] [Bug 23247] New: Simplify visibility logic in
opac-*detail.pl
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
Bug ID: 23247
Summary: Simplify visibility logic in opac-*detail.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
The logic seems too complex for the covered use cases, and it queries the DB
too many times without a real need for that.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:29:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:29:00 +0000
Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in
opac-ISBDdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23247
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
[Bug 23247] Simplify visibility logic in opac-*detail.pl [OMNIBUS]
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:29:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:29:00 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
opac-*detail.pl [OMNIBUS]
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Simplify visibility logic |Simplify visibility logic
|in opac-*detail.pl |in opac-*detail.pl
| |[OMNIBUS]
Depends on| |22696
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696
[Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:58:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 17:58:23 +0000
Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to
circulation_rules table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agust?n Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:28:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:28:01 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-detail.pl
and opac-MARCdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
Summary|Simplify visibility logic |Simplify visibility logic
|in opac-*detail.pl |in opac-detail.pl and
|[OMNIBUS] |opac-MARCdetail.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:40:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:40:58 +0000
Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and
item changes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #4 from Kyle M Hall ---
Unit tests are failing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:51:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:51:17 +0000
Subject: [Koha-bugs] [Bug 23248] New: opac-ISBDdetail.pl dies on invalid
biblionumber
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
Bug ID: 23248
Summary: opac-ISBDdetail.pl dies on invalid biblionumber
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
To reproduce:
- Open your OPAC on a biblio detail page
- Pick the ISBD page
- Alter the biblionumber query param to an obviously non-existent one
=> FAIL: It explodes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:52:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:52:31 +0000
Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid
biblionumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
--- Comment #1 from Tom?s Cohen Arazi ---
Created attachment 91156
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91156&action=edit
Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:52:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:52:44 +0000
Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid
biblionumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Assignee|oleonard at myacpl.org |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:55:38 +0000
Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid
biblionumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:55:42 +0000
Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid
biblionumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91156|0 |1
is obsolete| |
--- Comment #2 from Tom?s Cohen Arazi ---
Created attachment 91157
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91157&action=edit
Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber
This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it
should) in the event of a bad biblionumber passed.
To test:
- Open your browser on a known record detail page (OPAC)
- Switch to the ISBD view
=> SUCCESS: It shows
- Alter the biblionumber on the URL into an obviously non-existent
biblionumber (e.g. very high value)
=> FAIL: Internal errors are shown
- Apply this patch
- Reload the bad biblionumber ISBD view
=> SUCCESS: Browser is redirected to the 404 page as it should
- Sign off :-=> FAIL: Internal errors are shown
- Apply this patch
- Reload the bad biblionumber ISBD view
=> SUCCESS: Browser is redirected to the 404 page as it should
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:55:55 +0000
Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid
biblionumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |22696
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696
[Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 18:55:55 +0000
Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in
opac-ISBDdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23248
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248
[Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:01:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:01:38 +0000
Subject: [Koha-bugs] [Bug 19383] Print hold slips without confirmation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383
--- Comment #14 from Katrin Fischer ---
(In reply to jdemuth at roseville.ca.us from comment #13)
> We just tested the automatic printing and it only seems to work if you have
> one library location. It works for everything else but at the end we tried
> switching the hold location to one of our other branches and it still auto
> prints the hold even. Here is my test example:
>
> 1. Item found on Library A shelf for pick up at Library B.
> 2. Check in item at Library A to trigger the transfer.
> 3. Hold slip prints and says its on hold at Library B.
>
> So it looks like it overwrites the transfer, however a transfer box does
> come up under the hold box.
>
> Thanks,
>
> Jen
Hi Jen, could you file this as a new bug maybe? This one is RESOLVED FIXED and
any work needs to be done on a new bug as a bug fix now. You can use the
"depends" field to link to this bug. Let me know if I can help!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:10:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:10:19 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
opac-MARCdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Simplify visibility logic |Simplify visibility logic
|in opac-detail.pl and |in opac-MARCdetail.pl
|opac-MARCdetail.pl |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:12:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:12:14 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
opac-MARCdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:12:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:12:19 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
opac-MARCdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
--- Comment #1 from Tom?s Cohen Arazi ---
Created attachment 91158
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158&action=edit
Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl
This patch uses the OO code, with prefetching and all, to make decisions
on visibility. It shouldn't change any behaviour, unless you are
counting DB queries, execution time, etc.
To test:
- Find a known record, go to the OPAC MARC page of it.
- Play with several options in OpacHiddenItems, refreshing it
- Play with OpacHiddenItemsExceptions as well
=> SUCCESS: Things work as expected
- Apply this patch
- Repeate the tests above
=> SUCCESS: Things work as expected!
- Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:28:09 +0000
Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view
guarantee's fines in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691
Agust?n Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:28:16 +0000
Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view
guarantee's fines in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691
--- Comment #26 from Agust?n Moyano ---
Created attachment 91160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91160&action=edit
Bug 20691: Add ability to turn feature on and off
This patch adds two preferences
1. AllowPatronToSetFinesVisibilityForGuarantor: Allow/Don't allow patrons to
choose their own privacy settings for showing the patron's fines to the
patron's guarantor
2. AllowStaffToSetFinesVisibilityForGuarantor: Allow/Don't allow staff to set
the ability for a patron's fines to be viewed by linked patrons in the OPAC
Also adds a tinyint, non nullable, default to 0 column in borrower and
deletedborrower named privacy_guarantor_fines.
1. privacy_guarantor_fines = 0 => don't allow guarantor to see guarantee's
fines
2. privacy_guarantor_fines = 1 => allow guarantor to see guarantee's fines
To test:
1) git reset --hard master
2) apply patches (including dependencies)
3) perl installer/data/mysql/updatedatabase.pl
4) dbic
5) restart_all
6) in intranet search for AllowPatronToSetFinesVisibilityForGuarantor and
AllowStaffToSetFinesVisibilityForGuarantor preferences
SUCCESS => both preferences should be present
7) search for a patron with guarantor
SUCCESS => in details tab, in "Library use" section you should see a row
labeled "Show fines to guarantor"
8) edit
CHECK => in Guarantor information there is no "Show fines to guarantor" select
9) set AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow"
10) return to patron with guarantor and edit
SUCCESS => in Guarantor information section there is a "Show fines to
guarantor" select
11) change "Show fines to guarantor" select to "Yes" and save
SUCCESS => Value is saved
12) go to details tab
SUCCESS => in "Library use" section you see a row labeled "Show fines to
guarantor" with value "Yes"
13) set OPACPrivacy preference to "Allow"
14) open 2 opacs, one with a patron that has a guarantor and another that
hasn't and go to "your privacy" tab.
CHECK => in both opacs you should not see a "Allow your guarantor to view your
current fines?" select
15) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow"
16) refresh both opacs
SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view
your current fines?" select
=> in Patron without guarantor you don't see a "Allow your guarantor to
view your current fines?" select
17) in Patron with guarantor change value of select and save
SUCCESS => Value is saved
18) in intranet set OPACPrivacy preference to "Don't allow" and
AllowPatronToSetFinesVisibilityForGuarantor to "Don't allow"
19) got to "your personal details" in both opacs
CHECK => in both opacs you should not see no Privacy section with a "Allow your
guarantor to view your current fines?" select
20) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow"
21) refresh both opacs
SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view
your current fines?" select in a Privacy section
=> in Patron without guarantor there is no Privacy section
22) in Patron with guarantor change value of select and update
SUCCESS => Value is saved
23) Sign off
Signed-off-by: Agustin Moyano
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:28:12 +0000
Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view
guarantee's fines in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691
Agust?n Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90093|0 |1
is obsolete| |
Attachment #90094|0 |1
is obsolete| |
Attachment #91025|0 |1
is obsolete| |
Attachment #91026|0 |1
is obsolete| |
--- Comment #25 from Agust?n Moyano ---
Created attachment 91159
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91159&action=edit
Bug 20691: Database update
Signed-off-by: Agustin Moyano
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:28:20 +0000
Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view
guarantee's fines in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691
--- Comment #27 from Agust?n Moyano ---
Created attachment 91161
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91161&action=edit
Bug 20691: Implement fines view
This patch implements the logic to show guarantee's fines with guarantor user.
To test:
1) Apply (if not already done) steps 1 to 5 of previous patch
2) Apply this patch
3) Set OPACFinesTab and AllowStaffToSetFinesVisibilityForGuarantor preference
to "Allow"
4) Find a guarantee and in accounting create a manual invoice
5) Enter OPAC with guarantor user
CHECK => In summary there is no "Relatives fines" tab
6) On intranet edit guarantee and set "Show fines to guarantors" to "Yes" and
save
7) Reload guarantor's OPAC
SUCCESS => You see a "Relatives fines" tab with guarantee's fines information
8) Sign off
Signed-off-by: Agustin Moyano
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 19:28:23 +0000
Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view
guarantee's fines in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691
--- Comment #28 from Agust?n Moyano ---
Created attachment 91162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91162&action=edit
Bug 20691: (follow-up) Fix qa fails
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:00:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:00:08 +0000
Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins
home
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:00:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:00:12 +0000
Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins
home
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91129|0 |1
is obsolete| |
--- Comment #3 from Tom?s Cohen Arazi ---
Created attachment 91163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91163&action=edit
Bug 23222: Update plugins-home.tt with new ENABLE/DISABLE flag name
At some point of history, the flag to indicate if a plugin was enabled/disabled
was called "enabled", now it's called "is_enabled"
To test:
1) get a fresh master copy
2) Enable plugins
3) Install any plugin
CHECK => plugin appears as disabled
=> If you try to enable it, it just appears as disabled just the same
4) Apply this patch
5) Reload page
SUCCESS => plugin appears as enabled
=> enable / disable action works again
6) Sign off
Signed-off-by: Fr?d?ric Demians
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:26:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:26:30 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
form, with collapsed settings panel
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959
--- Comment #44 from Katrin Fischer ---
This works well for me, just a spelling question:
Remember due date for next check in
Should it be check-in in this case? (substantive)?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:32:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:32:54 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
form, with collapsed settings panel
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:32:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:32:59 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
form, with collapsed settings panel
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91123|0 |1
is obsolete| |
--- Comment #45 from Katrin Fischer ---
Created attachment 91164
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91164&action=edit
Bug 20959: Style checkin form more like the checkout form, with collapsed
settings panel
This patch modifies the structure of the checkin form so that settings
(Specify return date, book drop mode, forgive overdue charges) are in a
collapsed panel when inactive. The style of the barcode field and the
mode notification messages has been changed to reduce the vertical
motion of the form when selecting options.
Some class names have been changed in circulation.tt and circulation.js
to make them appropriate for use on both forms.
To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.
- View the checkin page. The "checkin settings" panel should be
collapsed by default.
- Confirm that the settings panel collapses and expands as it should.
- Confirm that selecting "Forgive overdue charges" or "Book drop mode"
trigger the display of the correct message and that the style of the
barcode field is changed.
- Confirm that after submitting a barcode for check-in, the
settings panel stays open and your selected settings are still
selected.
- Confirm that specifying a due date and selecting "remember" shows
a new message with the selected date.
- Confirm that unchecking "remember" hides the message.
- Confirm that date settings are remembered and the correct message
displayed (or not) during check-in.
- Test with CircSidebar enabled and disabled.
Signed-off-by: Arthur Bousquet
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:37:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:37:58 +0000
Subject: [Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap
grid: ILL requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:38:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:38:01 +0000
Subject: [Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap
grid: ILL requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91052|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 91165
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91165&action=edit
Bug 22897: Switch two-column templates to Bootstrap grid: ILL requests
This patch modifies the ILL requests template to use the Bootstrap grid
instead of YUI.
To test, apply the patch and look at the ILL requests template. Confirm
that it looks correct at various browser widths.
Signed-off-by: Andrew Isherwood
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:39:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:39:43 +0000
Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap
grid: Circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Patch doesn't apply
--- Comment #6 from Katrin Fischer ---
I am sorry, Owen, but this one no longer applies:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22999: Switch two-column templates to Bootstrap grid: Circulation
Applying: Bug 22999: (follow-up) Indentation updates
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 22999: (follow-up) Indentation updates
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-22999-follow-up-Indentation-updates-hr86eW.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:47:28 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88330|0 |1
is obsolete| |
--- Comment #51 from Josef Moravec ---
Created attachment 91167
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91167&action=edit
Bug 17005: Test for checked_in parameter
Test plan:
prove t/db_dependent/api/v1/checkouts.t
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:47:30 +0000
Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self
check modules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Summary|Wrong icons/paths in 18.11 |[18.11] Wrong icons/paths
|for self check modules |in 18.11 for self check
| |modules
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:47:34 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88331|0 |1
is obsolete| |
--- Comment #52 from Josef Moravec ---
Created attachment 91168
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91168&action=edit
Bug 17005: Add plugin parameters to /checkouts endpoint
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:47:23 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88329|0 |1
is obsolete| |
--- Comment #50 from Josef Moravec ---
Created attachment 91166
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91166&action=edit
Bug 17005: Add checked_in checkouts to REST API response
This patch implements parameter 'checked_in' on checkouts endpoint to
enable getting circulation history.
Test plan:
1) Apply the patch and restart plack
2) Use your favorite REST API tester and play with /checkouts endpoint:
- use it without checked_in parameter
- use checked_in=1 for getting returned checkouts
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:48:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:48:11 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--- Comment #53 from Josef Moravec ---
Rebased on master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:59:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 20:59:33 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
item and allocating to bib-level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--- Comment #4 from Hayley Mapley ---
Ready to be signed off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:03:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 21:03:58 +0000
Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self
check modules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:04:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 21:04:01 +0000
Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self
check modules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91101|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 91169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91169&action=edit
Bug 23198: Wrong icons/paths in 18.11 for self check modules
This patch amends the CSS in self checkout and self check-in modules so
that paths to icon images are correct.
To test, apply the patch and make sure the WebBasedSelfCheck and
SelfCheckInModule preferences are enabled.
In self-checkout and self-check-in, confirm that the following icons
appear correctly:
- "Help" (?) icon in the upper right.
- "Finish" (stop sign) icon -- Shown to logged-in self checkout users
from the start. Shown to self-check-in users after they check in an
item.
- "Cancel" (X) icon -- Shown for instance when you try to check out an
item which is already checked out to you and can be renewed.
- Also in this dialog: "Return" (Book with arrow) and "Renew"
(refresh icon).
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:21:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 21:21:55 +0000
Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:24:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 23:24:38 +0000
Subject: [Koha-bugs] [Bug 19383] Print hold slips without confirmation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383
jdemuth at roseville.ca.us changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23249
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249
[Bug 23249] Print hold slips without confirmation for multiple locations
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:24:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 23:24:38 +0000
Subject: [Koha-bugs] [Bug 23249] New: Print hold slips without confirmation
for multiple locations
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249
Bug ID: 23249
Summary: Print hold slips without confirmation for multiple
locations
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: jdemuth at roseville.ca.us
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Depends on: 19383
Our library just upgraded to 18.11.06 and we tested bug 19383 which allows
printing hold slips without confirmation. Everything worked as expected but we
noticed this only works if you have one library location. This does not work
for multiple library locations and looks like it overwrites the transfer and
prints the hold slip making it confusing for staff. After the slip prints the
screen displays both the hold box and then the transfer box below it.
Here is a test plan of how to recreate this issue:
1. Place an item on hold that is at Library A and select Library B as the pick
up location.
2. Check in item at Library A to trigger the transfer.
3. A hold slip still automatically prints and states its on hold at Library B.
4. Once you close the pop up box, you can see two alerts, one to reprint the
hold slip and then the actual transfer prompt is below.
Thanks,
Jen DeMuth
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383
[Bug 19383] Print hold slips without confirmation
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:30:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Jul 2019 23:30:49 +0000
Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null
dateofbirth
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151
jdemuth at roseville.ca.us changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jdemuth at roseville.ca.us
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 03:28:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 01:28:27 +0000
Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images'
tab if no holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
--- Comment #3 from M. Tompsett ---
Comment on attachment 91155
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91155
Bug 23246: (follow-up) Hardcoding tab position is not enough
Review of attachment 91155:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23246&attachment=91155)
-----------------------------------------------------------------
*sniff sniff* Love the fixing of the hard coding. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 03:37:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 01:37:41 +0000
Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images'
tab if no holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
--- Comment #4 from Tom?s Cohen Arazi ---
(In reply to M. Tompsett from comment #3)
> Comment on attachment 91155 [details] [review]
> Bug 23246: (follow-up) Hardcoding tab position is not enough
>
> Review of attachment 91155 [details] [review]:
> -----------------------------------------------------------------
>
> *sniff sniff* Love the fixing of the hard coding. :)
Glad to hear
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 04:44:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 02:44:19 +0000
Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname
syspref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
Attachment #90983|0 |1
is obsolete| |
--- Comment #4 from M. Tompsett ---
Comment on attachment 90983
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90983
Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron
I believe the second patch is a rebase.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 05:07:12 +0000
Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname
syspref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 05:07:15 +0000
Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname
syspref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90996|0 |1
is obsolete| |
--- Comment #5 from M. Tompsett ---
Created attachment 91170
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91170&action=edit
Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref
Test plan:
1/ set uppercasesurname to 'Do'
2/ register a new patron using the REST API with lowercase surname
3/ verify the surname is not saved in uppercase
4/ apply patch
5/ repeat 2
6/ verify the surname now is saved to uppercase
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 05:07:17 +0000
Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname
syspref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199
--- Comment #6 from M. Tompsett ---
Created attachment 91171
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91171&action=edit
Bug 23199: Added tests for Koha::Patron
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 05:07:19 +0000
Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname
syspref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199
--- Comment #7 from M. Tompsett ---
Created attachment 91172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91172&action=edit
Bug 23199: (follow-up) Fix tab/space issues
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:12:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 05:12:29 +0000
Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should
not return a 404 error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:16:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 05:16:25 +0000
Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |mtompset at hotmail.com
--- Comment #3 from M. Tompsett ---
prove -v t/integration/auth/
t/integration/auth/cas.t .......
1..2
# Subtest: intranet
1..10
[Tue Jul 2 05:13:43 2019] [debug] GET "/cgi-bin/koha/mainpage.pl"
[Tue Jul 2 05:13:43 2019] [debug] Routing to a callback
A context appears to have been destroyed without first calling release().
Based on $@ it does not look like an exception was thrown (this is not always
a reliable test)
This is a problem because the global error variables ($!, $@, and $?) will
not be restored. In addition some release callbacks will not work properly from
inside a DESTROY method.
Here are the context creation details, just in case a tool forgot to call
release():
File: t/integration/auth/cas.t
Line: 74
Tool: Test::More::subtest
Cleaning up the CONTEXT stack...
# Test ended with extra hubs on the stack!
# No tests run!
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
t/integration/auth/password.t ..
1..2
# Subtest: intranet
1..10
[Tue Jul 2 05:13:46 2019] [debug] GET "/cgi-bin/koha/mainpage.pl"
[Tue Jul 2 05:13:46 2019] [debug] Routing to a callback
A context appears to have been destroyed without first calling release().
Based on $@ it does not look like an exception was thrown (this is not always
a reliable test)
This is a problem because the global error variables ($!, $@, and $?) will
not be restored. In addition some release callbacks will not work properly from
inside a DESTROY method.
Here are the context creation details, just in case a tool forgot to call
release():
File: t/integration/auth/password.t
Line: 58
Tool: Test::More::subtest
Cleaning up the CONTEXT stack...
# Test ended with extra hubs on the stack!
# No tests run!
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
Test Summary Report
-------------------
t/integration/auth/cas.t (Wstat: 65280 Tests: 0 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 2 tests but ran 0.
t/integration/auth/password.t (Wstat: 65280 Tests: 0 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 2 tests but ran 0.
Files=2, Tests=0, 5 wallclock secs ( 0.02 usr 0.00 sys + 4.16 cusr 0.59
csys = 4.77 CPU)
Result: FAIL
-- confirmed the same problem in comment #2, marking Failed QA. Though, I don't
know if it is this patch, or the one it depends on, that is the problem.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:06:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 06:06:21 +0000
Subject: [Koha-bugs] [Bug 22624] Show OPAC description for authorised values
in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:06:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 06:06:36 +0000
Subject: [Koha-bugs] [Bug 22624] Show OPAC description for authorised values
in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to oldstable |Pushed to oldoldstable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:13:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 06:13:56 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #6 from Martin Renvoize ---
QA Questions
1) Does this work with the Mojo derived API's too?
2) What if Koha is running under CGI and not plack - yes.. there are still some
out there :P
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:16:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 06:16:12 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #7 from Martin Renvoize ---
Created attachment 91173
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91173&action=edit
Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features work behind a proxy
Koha has a number of features that rely on knowing the IP address of the
connecting client. If that server is behind a proxy these features do not work.
We can use Plack::Middleware::RealIP to automatically convert the
X-Forwarded-For header into the REMOTE_ADDR environment variable so no Koha
code need be modified.
We can take advantage of the module's trusted_proxy setting to allow Koha to
use these feature even after going through *multiple* proxies.
TEST PLAN:
1) Apply this patch set
2) Install Plack::Middleware::RealIP via cpanm or your favorite utility
3) Update your plack.psgi with the changes you find in this patch set ( this
process differs based on your testing environment )
4) Restart plack
5) Tail the plack error log for your instance
6) Use curl to access the OPAC, adding an X-Forwarded-For header: curl --header
"X-Forwarded-For: 32.32.32.32" http://127.0.0.1:8080
7) Note the logs output this address if you are unproxied
8) If you are proxied, restart plack using a command like below, where the ip
you see in the logs is what you put in the environment variable:
KOHA_TRUSTED_PROXIES="172.22.0.1 1.1.1.1" koha-plack --restart kohadev
9) Repeat step 6
7) You should now see 32.32.32.32 as the remote address in your logs!
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:16:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 Jul 2019 06:16:15 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90582|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize