From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 00:47:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Jun 2019 22:47:50 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 01:40:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Jun 2019 23:40:47 +0000 Subject: [Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #3 from David Roberts --- It appears that (at 17.11 at least, I haven't yet tested at other versions) the action_logs table records holds created as being created the opac, even when they were created on the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 02:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 00:05:27 +0000 Subject: [Koha-bugs] [Bug 23217] Batch patron modification shows database errors when no Attribute provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217 --- Comment #8 from David Cook --- Thanks, Jonathan. I'm working from home with a sick child today, but I'll take a look at signing off your patch when I'm back in the office (with a full size keyboard instead of a tiny netbook keyboard). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 02:05:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 00:05:52 +0000 Subject: [Koha-bugs] [Bug 23218] Batch patron modification empty attribute causes improper handling of values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #2 from David Cook --- I'll be looking at signing off this one when I'm back at the office as well. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 07:48:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 05:48:40 +0000 Subject: [Koha-bugs] [Bug 4120] Add options for handling holds in self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- There is AllowItemsOnHoldCheckoutSCO now, I think that fixes this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 07:01:51 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #16 from Joonas Kylm?l? --- (In reply to Kyle M Hall from comment #15) > Ignoring the fact that AllowItemsOnHoldCheckout appears to be broken right > now, this seems like it is just *removing* flexibility from Koha, right? Why > would we want less flexibility instead of more? Thanks for this comment, for now I think we should keep both of these sysprefs as discussed in bug #15131. I will make a new version of the patch where this setting is available again and also applies to SIP checkouts instead of just SCO module. Later on we could probably address #15131 in some better way like making a possibility to authorize another patron to pickup their items. I'm moving this bug back to ASSIGNED state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:19:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 07:19:34 +0000 Subject: [Koha-bugs] [Bug 23232] Enable the option to use the onscreen keyboard on the basic cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:20:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 07:20:02 +0000 Subject: [Koha-bugs] [Bug 23231] We display too many layout options for the onscreen keyboard in the advanced cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23231 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 07:53:24 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #3 from Alex Buckley --- Created attachment 91133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91133&action=edit Bug 23172: Unit tests Adding unit tests to check the output of the Koha::Hold->check_if_existing_hold_matches_issuingrules() Test plan: 1. Run test plan in first patch 2. Enter Koha shell: sudo koha-shell 3. Run: prove t/db_dependent/Hold.t 4. All tests should pass Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:09:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 08:09:59 +0000 Subject: [Koha-bugs] [Bug 23239] New: install.pl: DBD::mysql::st execute failed: Incorrect integer value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23239 Bug ID: 23239 Summary: install.pl: DBD::mysql::st execute failed: Incorrect integer value Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: ashwinloyal at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I'm using Koha 19.0500000 from Koha official PPA. The DB server that I use is latest Maria BD 10.4 from their official PPA. During MARC 21 setup, I get this error: [Mon Jul 1 07:12:57 2019] install.pl: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_library`.`auth_subfield_structure`.`linkid` at row 148 at /usr/share/perl5/DBIx/RunSQL.pm line 273. But, installation completes successfully. Is this a serious error? How can I prevent it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 08:12:13 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #17 from Katrin Fischer --- Hi Joonas and Kyle, please also take a look at: bug 23233 bug 23223 and bug 7090 (which suggests that this was for SIP initially) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:03:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:03:28 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90818|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 91134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91134&action=edit Bug 23083: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:03:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:03:51 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- Fix works for me in testing, Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:03:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:03:31 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90819|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 91135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91135&action=edit Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED Test plan: 0: Do not apply the patches 1: Create an item with itype, ccode, location, and holding branch set 2: Create a course 3: Add item to course, changing the values for itype, ccode, and location 4: Click Edit for that item on course-details.pl 5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED 6: Hit Save 7: Back on course-details.pl, observe that the item is still showing the values set in step 3 8: Apply this patch 9: Repeat 4 to 6 10: Back on course-details.pl, observe that the item is now showing the correct values 11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently 12: hit save 13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:09:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:09:37 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |joonas.kylmala at helsinki.fi --- Comment #2 from Joonas Kylm?l? --- The syspref affects also the code in Koha/Item.pm, function "has_pending_hold". I believe it gets indirectly used in opac/intranet so we can't do this by simply renaming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:15:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:15:46 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90467|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 91137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91137&action=edit Bug 23045: Return record along with errors We don't seem to directly handle the errors in most cases, let's always return the record To test: 1 - Add some blank lines to editor, previous patch is okay with this 2 - Add a line with just 'e' or some other incomplete field 3 - Try to save 4 - Note JS leader error 5 - Apply this patch 6 - No errors Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:15:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:15:43 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90466|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 91136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91136&action=edit Bug 23045: TextMarc errors on blank lines Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when processing blank lines. We should just pass on these rather then erroring To test: 1 - Define a new macro that delete more fields than it adds delete 245 2 - Run it 3 - Note an error in JS console, and helpers will not load 4 - Apply patch 5 - Reload, try again 6 - No error Signed-off-by: Claire Gravely Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:17:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:17:33 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- This works well and meets current QA requirements.. so I'm Passing QA.. but.. it really worries me that I can't find any tests for Rancor.. I'd really like to have this mini-app tested to lower the likelihood or regressions. I'll open another bug to highlight this issue of missing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:19:55 +0000 Subject: [Koha-bugs] [Bug 23240] New: Rancor appears to be untested. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23240 Bug ID: 23240 Summary: Rancor appears to be untested. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org I can't find any tests for rancor (the advanced cataloguing editor).. I may be just missing them.. I hope I am. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:20:04 +0000 Subject: [Koha-bugs] [Bug 23240] Rancor appears to be untested. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23240 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:24:04 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #18 from Joonas Kylm?l? --- (In reply to Katrin Fischer from comment #17) > please also take a look at: > bug 23233 > bug 23223 > and bug 7090 (which suggests that this was for SIP initially) Mhm, okay so in #23233 Kyle says the AllowItemsOnHoldCheckout affects only SIP based checkouts which is almost true but not quite there because of one additional usage in the "has_pending_hold" function. If we get rid of the usage in "has_pending_hold" function then IMHO it would okay to merge AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO together since they are both self-checkouts. That lead me to the question why in #15131 this new syspref AllowItemsOnHoldCheckoutSCO was even introduced? Didn't the bug reporter just know because of the wrong documentation (as Jonathan points out in the report) that the AllowItemsOnHoldCheckout would have worked also in the situation described in the report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:27:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:27:49 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #19 from Katrin Fischer --- (In reply to Joonas Kylm?l? from comment #18) > (In reply to Katrin Fischer from comment #17) > > please also take a look at: > > bug 23233 > > bug 23223 > > and bug 7090 (which suggests that this was for SIP initially) > > Mhm, okay so in #23233 Kyle says the AllowItemsOnHoldCheckout affects only > SIP based checkouts which is almost true but not quite there because of one > additional usage in the "has_pending_hold" function. If we get rid of the > usage in "has_pending_hold" function then IMHO it would okay to merge > AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO together since they > are both self-checkouts. That lead me to the question why in #15131 this new > syspref AllowItemsOnHoldCheckoutSCO was even introduced? Didn't the bug > reporter just know because of the wrong documentation (as Jonathan points > out in the report) that the AllowItemsOnHoldCheckout would have worked also > in the situation described in the report? I think better to keep them separate - both are self checks, but... libraries. There might be a use case that we are not aware of right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:36:08 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23233 --- Comment #20 from Joonas Kylm?l? --- (In reply to Katrin Fischer from comment #19) > I think better to keep them separate - both are self checks, but... > libraries. There might be a use case that we are not aware of right now. Okay, fine by me, but maybe we could also announce somewhere in the main page that we are deprecating it? Or better, in the syspref setttings page. This way we don't have to carry it with us just because theoretically somebody might want to use it. And so if somebody complains then we remove the deprecation. I'm gonna make this bug depend on #23233 (the renaming of AllowItemsOnHoldCheckout to AllowItemsOnHoldCheckoutSIP) since that sounds easy to fix now and would conflict with this patch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:36:08 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:45:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:45:18 +0000 Subject: [Koha-bugs] [Bug 23241] New: Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23241 Bug ID: 23241 Summary: Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We have had a daemon mode in rebuild_zebra.pl for a long time and have been using that as the default indexing daemon for years.. Should we deprecate the above script to prevent confusion for new users where indexing should just work out of the box without the need for installing external dependancies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:46:36 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |WONTFIX --- Comment #7 from Martin Renvoize --- We've had an indexing daemon in koha for years now.. do we really still need this confusing/misleading script in community koha at all? I've opened a new bug to discuss #23241 and am going to mark this one as wontfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:46:53 +0000 Subject: [Koha-bugs] [Bug 23241] Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10665 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 09:46:53 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23241 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:02:35 +0000 Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19474, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20427 Status|In Discussion |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:02:35 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1918 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:02:35 +0000 Subject: [Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1918 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:07:14 +0000 Subject: [Koha-bugs] [Bug 2326] Help should be diff for each of the sys pref tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|In Discussion |Patch doesn't apply See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19817 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:07:14 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2326 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:15:52 +0000 Subject: [Koha-bugs] [Bug 2960] Cyrillic Z39-50 servers (bad encoding results) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2960 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- No more reports of this, and no response from filer, closing this one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:21:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:21:47 +0000 Subject: [Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #11 from Nick Clemens --- *** Bug 3311 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:21:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:21:47 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren't selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #50 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 21005 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:54:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:54:06 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|In Discussion |Patch doesn't apply --- Comment #17 from Nick Clemens --- Cardnumber appears to have been added, other info still not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:54:35 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Bug 15171 actually hard codes to always display all expirations before the entered date and so resolved this issue.. However, I prefer the logic here which allowed the end user to select whether to display old expired subscriptions or not. (Also, I'm sure the description on bug 15171 is incorrect). I'm going to resurrect this bug -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:56:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:56:32 +0000 Subject: [Koha-bugs] [Bug 23242] New: Error when adding new server in DB strict mode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23242 Bug ID: 23242 Summary: Error when adding new server in DB strict mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Unless you select 'preselected' and set 'rank' and 'timeout' DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'checked' at row 1 at /kohadevbox/koha/admin/z3950servers.pl line 82 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:56:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 10:56:40 +0000 Subject: [Koha-bugs] [Bug 23242] Error when adding new server in DB strict mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:13:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:13:09 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #3 from Kyle M Hall --- (In reply to Joonas Kylm?l? from comment #2) > The syspref affects also the code in Koha/Item.pm, function > "has_pending_hold". I believe it gets indirectly used in opac/intranet so we > can't do this by simply renaming. The one and only use of this method is in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc so supressing the pending hold status here based on the system preference should be considered buggy behavior as well! I'll file a followup to remove the use of the syspref for that method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:19:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:19:14 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 [Bug 23243] Show items expired before today in check expiration of serials page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:19:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:19:14 +0000 Subject: [Koha-bugs] [Bug 23243] New: Show items expired before today in check expiration of serials page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Bug ID: 23243 Summary: Show items expired before today in check expiration of serials page Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: adrien.saurat at biblibre.com, charles.farmer at inlibro.com, colin.campbell at ptfs-europe.com, eric.begin at inLibro.com, katrin.fischer at bsz-bw.de, koha-bugs at lists.koha-community.org, koha.sekjal at gmail.com, martin.renvoize at ptfs-europe.com, maxime.beaulieu at inlibro.com, paola.rossi at cineca.it, paul.poulain at biblibre.com, pelletiermaxime at gmail.com, philippe.blouin at inlibro.com, simith.doliveira at inlibro.com Depends on: 6968 +++ This bug was initially created as a clone of Bug #6968 +++ The Check Expiration page in Serials is now hardcoded (bug 15171) to always show all subscriptions that expire/expired before the date specified. We should have optionally enabled filtering out the historic expirations that have happened before today rather than removing that feature entirely. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 [Bug 6968] Show items expired before today in check expiration of serials page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:19:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:19:47 +0000 Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 --- Comment #1 from Martin Renvoize --- Created attachment 91138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91138&action=edit Bug 23243: Restore filtering out historic expired subscriptions The 'Check Expiration' page in Serials is now hardcoded to display all expired subscriptions before the entered date. This patch restores the ability to limit the results to just those expiring between 'today' and the date entered. Original code taken from bug 6968 autored by Maxime Pelletier, rebased by Charles Farmer and then moved to a new report and rebased again by Martin Renvoize. Test plan: 1) Without the patch any results after a search from this page will result in matches both before after todays date (but before the date you entered). 2) With the patch you should see a 'Show historic expirations' checkbox which will allow you to limit the results to just those that expire between the date you enter and today. Sponsored-by: CCSR Rescued-by: Charles Farmer Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:20:17 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:20:21 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #4 from Kyle M Hall --- Created attachment 91139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91139&action=edit Bug 23233: Remove use of AllowItemsOnHoldCheckout from Koha::Item::has_pending_hold, it can cause false data to be returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:20:30 +0000 Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Martin Renvoize --- Patch reworked from bug 6968 and attached, ready for testing. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:20:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:20:40 +0000 Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:21:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:21:13 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|Patch doesn't apply |RESOLVED --- Comment #16 from Martin Renvoize --- Moved to bug 23243 which updates it to the current context. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:21:14 +0000 Subject: [Koha-bugs] [Bug 23243] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Bug 23243 depends on bug 6968, which changed state. Bug 6968 Summary: Show items expired before today in check expiration of serials page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:23:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:23:14 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |WORKSFORME Status|In Discussion |RESOLVED --- Comment #10 from Nick Clemens --- Newlines in note fields appear to be respected in the Descriptions tab - else in XLST controlled sections they may not. Patch here seems to address the first - closing this one -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:23:34 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show items expired before |Allow filtering out of |today in check expiration |historic subscription |of serials page |expirations in the check | |expiration of serials page -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:42:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:42:25 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #21 from Kyle M Hall --- > Okay, fine by me, but maybe we could also announce somewhere in the main > page that we are deprecating it? Or better, in the syspref setttings page. > This way we don't have to carry it with us just because theoretically > somebody might want to use it. And so if somebody complains then we remove > the deprecation. I'm not sure I understand what you are proposing we deprecate. Can you clarify that for me? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:44:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:44:45 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #22 from Joonas Kylm?l? --- (In reply to Kyle M Hall from comment #21) > > Okay, fine by me, but maybe we could also announce somewhere in the main > > page that we are deprecating it? Or better, in the syspref setttings page. > > This way we don't have to carry it with us just because theoretically > > somebody might want to use it. And so if somebody complains then we remove > > the deprecation. > > I'm not sure I understand what you are proposing we deprecate. Can you > clarify that for me? Thanks! To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g. "AllowItemsOnHoldCheckoutSCO". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:45:30 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #23 from Joonas Kylm?l? --- (In reply to Joonas Kylm?l? from comment #22) > > I'm not sure I understand what you are proposing we deprecate. Can you > > clarify that for me? Thanks! > > To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g. > "AllowItemsOnHoldCheckoutSCO". Sorry, I meant just to have for example "AllowItemsOnHoldCheckout" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:48:14 +0000 Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:48:16 +0000 Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50497|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 91140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91140&action=edit Bug 13597: Make staff client amazon no image results match opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:50:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:50:31 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Joonas Kylm?l? --- (In reply to Kyle M Hall from comment #4) > Created attachment 91139 [details] [review] > Bug 23233: Remove use of AllowItemsOnHoldCheckout from > Koha::Item::has_pending_hold, it can cause false data to be returned Thanks. So just to summarize what this does: In koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc it is shown to patron whether the item is available for checkout and without this patch it actually showed whether it is available through SIP server and didn't consider it could have been available through intranet or SCO. This same bug seems to be in two other lines in the same Koha/Items.pm file: C4/Items.pm: $query .= ",IF(tmp_holdsqueue.itemnumber,1,0) AS has_pending_hold" if !C4::Context->preference('AllowItemsOnHoldCheckout'); C4/Items.pm: LEFT JOIN tmp_holdsqueue USING (itemnumber)" if !C4::Context->preference('AllowItemsOnHoldCheckout'); Shouldn't those also be fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:52:18 +0000 Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > (In reply to Mason James from comment #7) > > > On master, I have set a local cover image for 1 record and not for another > > > one. > > > Launch a search, I get the local cover image for the first record and the > > > "No cover image available" for the other one. > > > > > > Switching off LocalCoverImages, I get the amazon "No image available" image > > > > Jonathan, on staff, with patch and CSS added, LocalCoverImages off.. you get > > the amazon "No image available" image shown? > > I do not know, I have not tried, why should I? > I think I did not get the goal of this patch. > Could you please give me the use case and provide a more detailed test plan? The point is to make Staff client HTML for missing amazon cover images more equivalent to that of the OPAC To test: 1 - Enable amazon images everywhere 2 - Search on the Staff and OPAC to get some results without amazon covers (missing ISBNs and bad ISBNs) 3 - Note OPAC missing images are like: No cover image available 4 - Note Staff client are like: 5 - The staff links do not lend themselves to easy CSS hiding/styling 6 - Apply patch 7 - Repeat 8 - Note increased consistency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:53:59 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|In Discussion |RESOLVED --- Comment #13 from Nick Clemens --- Seems discussion is that we need consistent links and then CSS works here, making this a duplicate of 13597 to allow that to resolve this *** This bug has been marked as a duplicate of bug 13597 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 13:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 11:53:59 +0000 Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |reed at catalyst.net.nz --- Comment #11 from Nick Clemens --- *** Bug 5761 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:15:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:15:21 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84312|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 91141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91141&action=edit Bug 15148: Predict serials issues from subscription start date To test: 1 - Create a new serial 2 - Set 'First issue plublication date' to some date in 2016 3 - Set subscription start date to today 4 - Set length to 104 weeks 5 - Test prediction pattern - only one generated 6 - Apply patch 7 - Test prediction patern - many generated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:15:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:15:18 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:18:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:18:40 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 --- Comment #5 from Nick Clemens --- Created attachment 91142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91142&action=edit Bug 15148: Make param order more logical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:18:58 +0000 Subject: [Koha-bugs] [Bug 23232] Enable the option to use the onscreen keyboard on the basic cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:19:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:19:22 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #6 from Kyle M Hall --- (In reply to Joonas Kylm?l? from comment #5) > (In reply to Kyle M Hall from comment #4) > > Created attachment 91139 [details] [review] [review] > > Bug 23233: Remove use of AllowItemsOnHoldCheckout from > > Koha::Item::has_pending_hold, it can cause false data to be returned > > Thanks. So just to summarize what this does: In > koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc it is shown to > patron whether the item is available for checkout and without this patch it > actually showed whether it is available through SIP server and didn't > consider it could have been available through intranet or SCO. This same bug > seems to be in two other lines in the same Koha/Items.pm file: > > C4/Items.pm: $query .= ",IF(tmp_holdsqueue.itemnumber,1,0) AS > has_pending_hold" if !C4::Context->preference('AllowItemsOnHoldCheckout'); > > C4/Items.pm: LEFT JOIN tmp_holdsqueue USING (itemnumber)" if > !C4::Context->preference('AllowItemsOnHoldCheckout'); > > Shouldn't those also be fixed? You are absolutely right! Good catch :) I'll update my followup to include those changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:20:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:20:32 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hm, I am not sure this is right. We always say that the date of the first issue matters, so if you set that to 15th and the subscription start date to 1st, the pattern should still use the 15th for calculating. That's how it always worked, it looks like this might change that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:45:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:45:15 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:45:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:45:17 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #7 from Kyle M Hall --- Created attachment 91143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91143&action=edit Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:45:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:45:59 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91143|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:50:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:50:01 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #8 from Joonas Kylm?l? --- (In reply to Kyle M Hall from comment #7) > Created attachment 91143 [details] [review] > Bug 23233: Remove use of AllowItemsOnHoldCheckout from > C4::Items::GetItemsInfo You accidentally obsoleted the new patch instead of old one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:56:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 12:56:42 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #9 from Kyle M Hall --- Created attachment 91144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91144&action=edit Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:07:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:07:10 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #10 from Kyle M Hall --- (In reply to Joonas Kylm?l? from comment #8) > (In reply to Kyle M Hall from comment #7) > > Created attachment 91143 [details] [review] [review] > > Bug 23233: Remove use of AllowItemsOnHoldCheckout from > > C4::Items::GetItemsInfo > > You accidentally obsoleted the new patch instead of old one? I realized it wasn't complete and I decided to keep it separate for clarity. Thanks for checking! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:08:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:08:24 +0000 Subject: [Koha-bugs] [Bug 23244] New: Sort order in basket to default to title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244 Bug ID: 23244 Summary: Sort order in basket to default to title Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: paul.thornton at educampus.ie QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:09:51 +0000 Subject: [Koha-bugs] [Bug 23244] Sort order in basket to default to title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244 --- Comment #1 from Paul Thornton --- Customer wants the sort order in a basket to default to title a-z, and have all titles in the basket display on the one screen. While you can create it to 'x number of entries' and also display a-z, it cannot be set as a default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:11:04 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #24 from Kyle M Hall --- (In reply to Joonas Kylm?l? from comment #23) > (In reply to Joonas Kylm?l? from comment #22) > > > I'm not sure I understand what you are proposing we deprecate. Can you > > > clarify that for me? Thanks! > > > > To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g. > > "AllowItemsOnHoldCheckoutSCO". > > Sorry, I meant just to have for example "AllowItemsOnHoldCheckout" Thanks! I tend to agree with Katrin. For instance, it may be that Koha SCO is being used on site and librarians want to prevent patrons from grabbing books from the hold shelf and SIP is being used off site and if the "patron has possession" of the item they need to be able to check it out. This scenario is completely contrived but I think it's illustrative ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:11:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:11:35 +0000 Subject: [Koha-bugs] [Bug 23245] New: Floating toolbar on vendors page overlaps with vendor name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 Bug ID: 23245 Summary: Floating toolbar on vendors page overlaps with vendor name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 91145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91145&action=edit Floating toolbar overlapping with vendor name In some browsers we see strange behaviur with the new floating toolbar on the vendor summary page. The toolbar will overlap with the vendor's name (see screenshot). So far it happens in: Version 73.0.3683.103 (Windows) Firefox Quantum, 67.0.4 (Windows) Working well: Firefox Quantum 60.7.1esr (64-Bit) (Windows) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:13:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:13:29 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #0) > This method is to be run inside plugin objects that inherit from > Koha::Plugins::Base, but calling > > $self->_version_compare(); > > won't work because the method doesn't expect $self to be passed. We should make it work either way since historically it has been non-OO and there are some plugins that may be using it in a non-OO way. I think ti should be easy to check the first parameter to know if it is being called as an object method or not! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:14:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 13:14:54 +0000 Subject: [Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps with vendor name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 Christian Stelzenm?ller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:02:30 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:02:39 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #16 from Nick Clemens --- Created attachment 91147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91147&action=edit Bug 16787: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:02:45 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #17 from Nick Clemens --- Created attachment 91148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91148&action=edit Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record To test: 1 - Set 'Holds per record' to 0 for some itemtype/patorn combination 2 - Attempt to plac a hold 3 - Will see 'Too many..' 4 - Apply patch 5 - Try again 6 - Should now see 'No holds..' 7 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:02:35 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72827|0 |1 is obsolete| | Attachment #72828|0 |1 is obsolete| | Attachment #72889|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 91146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91146&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds To test: 1 - Set an item type to allow no holds 2 - Attempt to place a hold for a patron 3 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 4 - Try placing a multihold with the record above and a holdable record, message should end "...cannot place holds on some of these titles' items" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:02:51 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #18 from Nick Clemens --- Created attachment 91149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91149&action=edit Bug 16787: Rebase fixes and updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:21:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:21:11 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:21:14 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84283|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 91150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91150&action=edit Bug 21958: Fix bibliographic record field comparison with authority This makes the comparison between bibliographic field and authority field more robust and per subfield. This makes the comparison not consider the same e.g. the following fields: $a Test User $a Test $b User The actual issue cannot be as easily reproduced with the patches for bug 21826 applied, but here's a test plan anyway: 1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*) 2. Make sure authority linking still works properly 3. Make sure authority and biblio frameworks allow subfield i 4. Make sure that even if you add subfield i to 700 in biblio, authority link is kept the same 5. Make sure that even if you add subfield i to the authority record, the authority link is kept the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:38:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:38:01 +0000 Subject: [Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:38:11 +0000 Subject: [Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps with vendor name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |18.11 --- Comment #1 from Katrin Fischer --- Chrome works with 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:38:05 +0000 Subject: [Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89330|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 91151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91151&action=edit Bug 22826: Allow indexing of individual authorities in Elasticsearch To test: 1 - perl misc/search_tools/rebuild_elastic_search.pl -h 2 - Note it indicates the bn option can be passed to index individual authids 3 - perl misc/search_tools/rebuild_elastic_search.pl -a -bn 92 -v 4 - Note the error 5 - Apply patch 6 - perl misc/search_tools/rebuild_elastic_search.pl -h 7 - Note new option ai|authid for indexing individual authids 8 - Note updated text for bn|biblionumber option 9 - perl misc/search_tools/rebuild_elastic_search.pl -a -bn 92 -v 10 - No errors, but no records indexed 11 - perl misc/search_tools/rebuild_elastic_search.pl -a -ai 92 -v 12 - 1 record indexed 13 - perl misc/search_tools/rebuild_elastic_search.pl -ai 92 -bn 92 -v 14 - 1 authority record and 1 biblio record indexed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:45:51 +0000 Subject: [Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps with vendor name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 --- Comment #2 from Katrin Fischer --- Firefox Quantum, 67.0.4 (Windows) works with 19.05 too I think this might make this WONTFIX? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:45:55 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 91152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91152&action=edit Bug 23230: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:45:58 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 91153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91153&action=edit Bug 23230: Make _version_compare OO context aware On using _version_compare in plugins development, it would be nice if it was able to be called as an object method. This way we don't need to fully qualify it like this: Koha::Plugins::Base::_version_compare and we can do $self->_version_compare instead. This patch implements this behavior change. It is backwards compatible so plugins using the 'old way' don't break. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:47:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:47:19 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:47:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:47:27 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:50:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:50:09 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:55:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 14:55:27 +0000 Subject: [Koha-bugs] [Bug 23246] New: Record detail page jumps into the 'images' tab if no holdings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Bug ID: 23246 Summary: Record detail page jumps into the 'images' tab if no holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is certainly related to bug 16507. The original implementation is supposed to jump into the 'media tab' if there are no holdings, but it is not checking HTML5MediaEnabled or HTML5MediaYouTube in order to jump to that tab. Steps to reproduce: - Have HTML5MediaYouTube and HTML5MediaEnabled disabled - Create a record with no items - Go to the detail page => FAIL: the 'Images' tab is selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:21 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:23 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #30 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:25 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:27 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 --- Comment #70 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:30 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:32 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #117 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:34 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:36 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:37 +0000 Subject: [Koha-bugs] [Bug 23225] OPAC ISBD view returns 404 when no item attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:19:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:19:39 +0000 Subject: [Koha-bugs] [Bug 23225] OPAC ISBD view returns 404 when no item attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:34:56 +0000 Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13325 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 [Bug 13325] Add logs for budgets and funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:34:56 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 [Bug 13988] Log activities related to Acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:39:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:39:55 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Margaret changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:54:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:54:01 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #4 from Martin Renvoize --- Failing QA.. we need tests adding to Koha/SearchEngine/Elasticsearch/QueryBuilder.t for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:54:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 15:54:06 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:03:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 16:03:38 +0000 Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #4 from Martin Renvoize --- As a note to this one.. I think it really ought to have been written independently of bug 23214 really.. it was a surprise to see that as a dependency here as really they're pretty unrelated changes. I will however on this occasion look to testing both to save you a refactor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:06:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 16:06:33 +0000 Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #5 from Martin Renvoize --- On second thoughts.. the tree beneath bug 23214 is fairly large and currently blocked by an FQA bug.. will wait on that to test this, but in effect, it means this bug is blocked.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 16:22:07 +0000 Subject: [Koha-bugs] [Bug 19383] Print hold slips without confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 --- Comment #13 from jdemuth at roseville.ca.us --- We just tested the automatic printing and it only seems to work if you have one library location. It works for everything else but at the end we tried switching the hold location to one of our other branches and it still auto prints the hold even. Here is my test example: 1. Item found on Library A shelf for pick up at Library B. 2. Check in item at Library A to trigger the transfer. 3. Hold slip prints and says its on hold at Library B. So it looks like it overwrites the transfer, however a transfer box does come up under the hold box. Thanks, Jen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:25:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 16:25:12 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 91154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91154&action=edit Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to This patch makes jumping into the third tab happen only if HTML5MediaEnabled is set to 'both' or 'staff'. To test: - Have HTML5MediaEnabled set to 'opac' or 'not at all' - Open the detail page of a record with no holdings => FAIL: The 'images' tab is selected - Apply this patch - Reload => SUCCESS: The 'holdings' tab is selected as it should be. - Sign off :-D Sponsored-by: America Numismatic Society -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:25:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 16:25:32 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:18:25 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 91155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91155&action=edit Bug 23246: (follow-up) Hardcoding tab position is not enough There are many conditions that determine the tab number for 'media'. Translated into variables that hold the tabs count on each condition, it is clear that '3' was not good enough: [%- holdings = (SeparateHoldings) ? 2 : 1 notes = (MARCNOTES || notes) ? 1 : 0 acq = (Koha.Preference('AcquisitionDetails')) ? 1 : 0 frbr = (FRBRizeEditions && XISBNS) ? 1 : 0 local_covers = (LocalCoverImages && (localimages || CAN_user_tools_upload_local_cover_images)) ? 1 : 0 media_tab = holdings + notes + acq + frbr + local_covers -%] This patch gets rid of the hardcoded value, adds an id to the 'media' tab (i.e. 'media_tab') and uses JS to get the right index. To test: - Play with the different options governing those variables => FAIL: 3 is not always the 'media' tab - Apply this patch - Repeat your tests => SUCCESS: It always picks the 'media' tab - Sign off :-D Sponsored-by: American Numismatics Society -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:19:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:19:28 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #153 from Martin Renvoize --- I hit this error during DB update.. seems harmless but perhaps we should be handling it better. DEV atomic update: bug_14570.perl DBD::mysql::db do failed: Column 'relationship' cannot be null [for Statement " INSERT INTO borrower_relationships ( guarantor_id, guarantee_id, relationship ) SELECT guarantorid, borrowernumber, relationship FROM borrowers WHERE guarantorid IS NOT NULL; "] at (eval 1396) line 24. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:19:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:19:30 +0000 Subject: [Koha-bugs] [Bug 9548] Log changes to baskets/basket groups so you can print/download the same data as at time of creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:20:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:20:34 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 [Bug 16507] Show play media tab first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:20:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:20:34 +0000 Subject: [Koha-bugs] [Bug 16507] Show play media tab first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 [Bug 23246] Record detail page jumps into the 'images' tab if no holdings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:28:42 +0000 Subject: [Koha-bugs] [Bug 23247] New: Simplify visibility logic in opac-*detail.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Bug ID: 23247 Summary: Simplify visibility logic in opac-*detail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The logic seems too complex for the covered use cases, and it queries the DB too many times without a real need for that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:29:00 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-*detail.pl [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:29:00 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-*detail.pl [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify visibility logic |Simplify visibility logic |in opac-*detail.pl |in opac-*detail.pl | |[OMNIBUS] Depends on| |22696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:58:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 17:58:23 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:28:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:28:01 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-detail.pl and opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Summary|Simplify visibility logic |Simplify visibility logic |in opac-*detail.pl |in opac-detail.pl and |[OMNIBUS] |opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:40:58 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Kyle M Hall --- Unit tests are failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:51:17 +0000 Subject: [Koha-bugs] [Bug 23248] New: opac-ISBDdetail.pl dies on invalid biblionumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Bug ID: 23248 Summary: opac-ISBDdetail.pl dies on invalid biblionumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: - Open your OPAC on a biblio detail page - Pick the ISBD page - Alter the biblionumber query param to an obviously non-existent one => FAIL: It explodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:52:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:52:31 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 91156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91156&action=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:52:44 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:55:38 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:55:42 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91156|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 91157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91157&action=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:55:55 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 18:55:55 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:01:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:01:38 +0000 Subject: [Koha-bugs] [Bug 19383] Print hold slips without confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 --- Comment #14 from Katrin Fischer --- (In reply to jdemuth at roseville.ca.us from comment #13) > We just tested the automatic printing and it only seems to work if you have > one library location. It works for everything else but at the end we tried > switching the hold location to one of our other branches and it still auto > prints the hold even. Here is my test example: > > 1. Item found on Library A shelf for pick up at Library B. > 2. Check in item at Library A to trigger the transfer. > 3. Hold slip prints and says its on hold at Library B. > > So it looks like it overwrites the transfer, however a transfer box does > come up under the hold box. > > Thanks, > > Jen Hi Jen, could you file this as a new bug maybe? This one is RESOLVED FIXED and any work needs to be done on a new bug as a bug fix now. You can use the "depends" field to link to this bug. Let me know if I can help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:10:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:10:19 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify visibility logic |Simplify visibility logic |in opac-detail.pl and |in opac-MARCdetail.pl |opac-MARCdetail.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:12:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:12:14 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:12:19 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 91158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158&action=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:28:09 +0000 Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:28:16 +0000 Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #26 from Agust?n Moyano --- Created attachment 91160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91160&action=edit Bug 20691: Add ability to turn feature on and off This patch adds two preferences 1. AllowPatronToSetFinesVisibilityForGuarantor: Allow/Don't allow patrons to choose their own privacy settings for showing the patron's fines to the patron's guarantor 2. AllowStaffToSetFinesVisibilityForGuarantor: Allow/Don't allow staff to set the ability for a patron's fines to be viewed by linked patrons in the OPAC Also adds a tinyint, non nullable, default to 0 column in borrower and deletedborrower named privacy_guarantor_fines. 1. privacy_guarantor_fines = 0 => don't allow guarantor to see guarantee's fines 2. privacy_guarantor_fines = 1 => allow guarantor to see guarantee's fines To test: 1) git reset --hard master 2) apply patches (including dependencies) 3) perl installer/data/mysql/updatedatabase.pl 4) dbic 5) restart_all 6) in intranet search for AllowPatronToSetFinesVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor preferences SUCCESS => both preferences should be present 7) search for a patron with guarantor SUCCESS => in details tab, in "Library use" section you should see a row labeled "Show fines to guarantor" 8) edit CHECK => in Guarantor information there is no "Show fines to guarantor" select 9) set AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow" 10) return to patron with guarantor and edit SUCCESS => in Guarantor information section there is a "Show fines to guarantor" select 11) change "Show fines to guarantor" select to "Yes" and save SUCCESS => Value is saved 12) go to details tab SUCCESS => in "Library use" section you see a row labeled "Show fines to guarantor" with value "Yes" 13) set OPACPrivacy preference to "Allow" 14) open 2 opacs, one with a patron that has a guarantor and another that hasn't and go to "your privacy" tab. CHECK => in both opacs you should not see a "Allow your guarantor to view your current fines?" select 15) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow" 16) refresh both opacs SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select => in Patron without guarantor you don't see a "Allow your guarantor to view your current fines?" select 17) in Patron with guarantor change value of select and save SUCCESS => Value is saved 18) in intranet set OPACPrivacy preference to "Don't allow" and AllowPatronToSetFinesVisibilityForGuarantor to "Don't allow" 19) got to "your personal details" in both opacs CHECK => in both opacs you should not see no Privacy section with a "Allow your guarantor to view your current fines?" select 20) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow" 21) refresh both opacs SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select in a Privacy section => in Patron without guarantor there is no Privacy section 22) in Patron with guarantor change value of select and update SUCCESS => Value is saved 23) Sign off Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:28:12 +0000 Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90093|0 |1 is obsolete| | Attachment #90094|0 |1 is obsolete| | Attachment #91025|0 |1 is obsolete| | Attachment #91026|0 |1 is obsolete| | --- Comment #25 from Agust?n Moyano --- Created attachment 91159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91159&action=edit Bug 20691: Database update Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:28:20 +0000 Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #27 from Agust?n Moyano --- Created attachment 91161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91161&action=edit Bug 20691: Implement fines view This patch implements the logic to show guarantee's fines with guarantor user. To test: 1) Apply (if not already done) steps 1 to 5 of previous patch 2) Apply this patch 3) Set OPACFinesTab and AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow" 4) Find a guarantee and in accounting create a manual invoice 5) Enter OPAC with guarantor user CHECK => In summary there is no "Relatives fines" tab 6) On intranet edit guarantee and set "Show fines to guarantors" to "Yes" and save 7) Reload guarantor's OPAC SUCCESS => You see a "Relatives fines" tab with guarantee's fines information 8) Sign off Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:28:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 19:28:23 +0000 Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #28 from Agust?n Moyano --- Created attachment 91162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91162&action=edit Bug 20691: (follow-up) Fix qa fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:00:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:00:08 +0000 Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:00:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:00:12 +0000 Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91129|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 91163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91163&action=edit Bug 23222: Update plugins-home.tt with new ENABLE/DISABLE flag name At some point of history, the flag to indicate if a plugin was enabled/disabled was called "enabled", now it's called "is_enabled" To test: 1) get a fresh master copy 2) Enable plugins 3) Install any plugin CHECK => plugin appears as disabled => If you try to enable it, it just appears as disabled just the same 4) Apply this patch 5) Reload page SUCCESS => plugin appears as enabled => enable / disable action works again 6) Sign off Signed-off-by: Fr?d?ric Demians Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:26:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:26:30 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #44 from Katrin Fischer --- This works well for me, just a spelling question: Remember due date for next check in Should it be check-in in this case? (substantive)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:32:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:32:54 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:32:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:32:59 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91123|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 91164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91164&action=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Confirm that specifying a due date and selecting "remember" shows a new message with the selected date. - Confirm that unchecking "remember" hides the message. - Confirm that date settings are remembered and the correct message displayed (or not) during check-in. - Test with CircSidebar enabled and disabled. Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:37:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:37:58 +0000 Subject: [Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap grid: ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:38:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:38:01 +0000 Subject: [Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap grid: ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91052|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 91165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91165&action=edit Bug 22897: Switch two-column templates to Bootstrap grid: ILL requests This patch modifies the ILL requests template to use the Bootstrap grid instead of YUI. To test, apply the patch and look at the ILL requests template. Confirm that it looks correct at various browser widths. Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:39:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:39:43 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer --- I am sorry, Owen, but this one no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22999: Switch two-column templates to Bootstrap grid: Circulation Applying: Bug 22999: (follow-up) Indentation updates error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22999: (follow-up) Indentation updates The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22999-follow-up-Indentation-updates-hr86eW.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:47:28 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88330|0 |1 is obsolete| | --- Comment #51 from Josef Moravec --- Created attachment 91167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91167&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:47:30 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Wrong icons/paths in 18.11 |[18.11] Wrong icons/paths |for self check modules |in 18.11 for self check | |modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:47:34 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88331|0 |1 is obsolete| | --- Comment #52 from Josef Moravec --- Created attachment 91168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91168&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:47:23 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88329|0 |1 is obsolete| | --- Comment #50 from Josef Moravec --- Created attachment 91166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91166&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:48:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:48:11 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #53 from Josef Moravec --- Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 20:59:33 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Hayley Mapley --- Ready to be signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 21:03:58 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:04:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 21:04:01 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91101|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 91169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91169&action=edit Bug 23198: Wrong icons/paths in 18.11 for self check modules This patch amends the CSS in self checkout and self check-in modules so that paths to icon images are correct. To test, apply the patch and make sure the WebBasedSelfCheck and SelfCheckInModule preferences are enabled. In self-checkout and self-check-in, confirm that the following icons appear correctly: - "Help" (?) icon in the upper right. - "Finish" (stop sign) icon -- Shown to logged-in self checkout users from the start. Shown to self-check-in users after they check in an item. - "Cancel" (X) icon -- Shown for instance when you try to check out an item which is already checked out to you and can be renewed. - Also in this dialog: "Return" (Book with arrow) and "Renew" (refresh icon). Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 21:21:55 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 23:24:38 +0000 Subject: [Koha-bugs] [Bug 19383] Print hold slips without confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 [Bug 23249] Print hold slips without confirmation for multiple locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 23:24:38 +0000 Subject: [Koha-bugs] [Bug 23249] New: Print hold slips without confirmation for multiple locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 Bug ID: 23249 Summary: Print hold slips without confirmation for multiple locations Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jdemuth at roseville.ca.us QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 19383 Our library just upgraded to 18.11.06 and we tested bug 19383 which allows printing hold slips without confirmation. Everything worked as expected but we noticed this only works if you have one library location. This does not work for multiple library locations and looks like it overwrites the transfer and prints the hold slip making it confusing for staff. After the slip prints the screen displays both the hold box and then the transfer box below it. Here is a test plan of how to recreate this issue: 1. Place an item on hold that is at Library A and select Library B as the pick up location. 2. Check in item at Library A to trigger the transfer. 3. A hold slip still automatically prints and states its on hold at Library B. 4. Once you close the pop up box, you can see two alerts, one to reprint the hold slip and then the actual transfer prompt is below. Thanks, Jen DeMuth Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 [Bug 19383] Print hold slips without confirmation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:30:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2019 23:30:49 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 03:28:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 01:28:27 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #3 from M. Tompsett --- Comment on attachment 91155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91155 Bug 23246: (follow-up) Hardcoding tab position is not enough Review of attachment 91155: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23246&attachment=91155) ----------------------------------------------------------------- *sniff sniff* Love the fixing of the hard coding. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 03:37:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 01:37:41 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #3) > Comment on attachment 91155 [details] [review] > Bug 23246: (follow-up) Hardcoding tab position is not enough > > Review of attachment 91155 [details] [review]: > ----------------------------------------------------------------- > > *sniff sniff* Love the fixing of the hard coding. :) Glad to hear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 04:44:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 02:44:19 +0000 Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #90983|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Comment on attachment 90983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90983 Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron I believe the second patch is a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 05:07:12 +0000 Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 05:07:15 +0000 Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90996|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 91170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91170&action=edit Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref Test plan: 1/ set uppercasesurname to 'Do' 2/ register a new patron using the REST API with lowercase surname 3/ verify the surname is not saved in uppercase 4/ apply patch 5/ repeat 2 6/ verify the surname now is saved to uppercase Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 05:07:17 +0000 Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 --- Comment #6 from M. Tompsett --- Created attachment 91171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91171&action=edit Bug 23199: Added tests for Koha::Patron Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 05:07:19 +0000 Subject: [Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 --- Comment #7 from M. Tompsett --- Created attachment 91172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91172&action=edit Bug 23199: (follow-up) Fix tab/space issues Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:12:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 05:12:29 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 07:16:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 05:16:25 +0000 Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- prove -v t/integration/auth/ t/integration/auth/cas.t ....... 1..2 # Subtest: intranet 1..10 [Tue Jul 2 05:13:43 2019] [debug] GET "/cgi-bin/koha/mainpage.pl" [Tue Jul 2 05:13:43 2019] [debug] Routing to a callback A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/integration/auth/cas.t Line: 74 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # No tests run! Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests t/integration/auth/password.t .. 1..2 # Subtest: intranet 1..10 [Tue Jul 2 05:13:46 2019] [debug] GET "/cgi-bin/koha/mainpage.pl" [Tue Jul 2 05:13:46 2019] [debug] Routing to a callback A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/integration/auth/password.t Line: 58 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # No tests run! Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- t/integration/auth/cas.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. t/integration/auth/password.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=2, Tests=0, 5 wallclock secs ( 0.02 usr 0.00 sys + 4.16 cusr 0.59 csys = 4.77 CPU) Result: FAIL -- confirmed the same problem in comment #2, marking Failed QA. Though, I don't know if it is this patch, or the one it depends on, that is the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:06:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:06:21 +0000 Subject: [Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:06:36 +0000 Subject: [Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:13:56 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- QA Questions 1) Does this work with the Mojo derived API's too? 2) What if Koha is running under CGI and not plack - yes.. there are still some out there :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:16:12 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #7 from Martin Renvoize --- Created attachment 91173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91173&action=edit Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy Koha has a number of features that rely on knowing the IP address of the connecting client. If that server is behind a proxy these features do not work. We can use Plack::Middleware::RealIP to automatically convert the X-Forwarded-For header into the REMOTE_ADDR environment variable so no Koha code need be modified. We can take advantage of the module's trusted_proxy setting to allow Koha to use these feature even after going through *multiple* proxies. TEST PLAN: 1) Apply this patch set 2) Install Plack::Middleware::RealIP via cpanm or your favorite utility 3) Update your plack.psgi with the changes you find in this patch set ( this process differs based on your testing environment ) 4) Restart plack 5) Tail the plack error log for your instance 6) Use curl to access the OPAC, adding an X-Forwarded-For header: curl --header "X-Forwarded-For: 32.32.32.32" http://127.0.0.1:8080 7) Note the logs output this address if you are unproxied 8) If you are proxied, restart plack using a command like below, where the ip you see in the logs is what you put in the environment variable: KOHA_TRUSTED_PROXIES="172.22.0.1 1.1.1.1" koha-plack --restart kohadev 9) Repeat step 6 7) You should now see 32.32.32.32 as the remote address in your logs! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:16:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:16:15 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90582|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 91174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91174&action=edit Bug 23068: Allow the list of proxy IPs to be set in the koha-conf.xml file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:17:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:17:06 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:17:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 06:17:55 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Fixed up the commit line to get the QA scripts happy and signing off.. I'll leave my two QA questions for a QA person to follow up but I didn't see any point in holding up SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:08:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 07:08:08 +0000 Subject: [Koha-bugs] [Bug 23250] New: koha-create generates broken mysql password Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 Bug ID: 23250 Summary: koha-create generates broken mysql password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org Using koha-create with latest master generates a broken mysql password in koha-conf.xml, like this > B6_uW%vW"__DB_PASS__`1l(Gm The problem does not appear when I revert the changes from bug 23090. This will make every new instance unusable. It's in the nightly, that means new devboxes will be broken too I guess. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 07:09:43 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23090 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 [Bug 23090] MySQL validate_password plugin breaks koha-create -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 07:09:43 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 [Bug 23250] koha-create generates broken mysql password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:51:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 07:51:36 +0000 Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 --- Comment #4 from Julian Maurice --- This has something to do with the safe_exit subroutine in C4::Auth, called by checkauth, which calls exit because psgi_env returns false. %ENV does not contain any 'psgi.' variables, but I don't know why... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:09:22 +0000 Subject: [Koha-bugs] [Bug 23219] Prevent patron delete if holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at outlook.com |ity.org | --- Comment #4 from Emmi Takkinen --- Created attachment 91175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91175&action=edit Bug 23219: Cancel patrons holds when patron delete Currently deleting a patron deletes all their holds and leaves no record to the "old_reserves" table. Steps to reproduce: - Create a patron - Add holds for patron - Holds are recorded to "reserves" table - Delete patron - Confirm delete =>Patron and all holds are deleted and no record of holds is left in "old_reserves" table This patch displays alert text notifying user that deleting patron cancels all their holds. Holds are cancelled instead of deleting them. This patch also writes stringified datetime to holds cancel log instead of whole datetime object. To test: - Apply this patch - Create a patron - Add holds for patron - Holds are recorded to "reserves" table - Delete patron - Alert text of holds is displayed - Confirm patron delete => Patron is deleted, their holds are cancelled and moved to "old_reserves" table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:21:21 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:21:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:21:24 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #46 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:21:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:21:26 +0000 Subject: [Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap grid: ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:21:27 +0000 Subject: [Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap grid: ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:22:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:22:55 +0000 Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Passed QA |Pushed to master --- Comment #4 from Martin Renvoize --- Nice work, thanks!! Pushed to master to 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:31:06 +0000 Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 --- Comment #5 from Julian Maurice --- Created attachment 91176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91176&action=edit Bug 20635: Make sure CGI::Compile is loaded first in tests CGI::Compile needs to be loaded before Koha modules for it to work normally. Even if not directly needed in test files, we need to 'use' it explicitely so that it loads before Koha modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:32:44 +0000 Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 --- Comment #6 from Julian Maurice --- The last patch fixes the problem mentioned in comment 2 and comment 3, and make t/integration/auth/password.t pass. However the CAS test still fails, for other reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:51:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:51:34 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90026|0 |1 is obsolete| | --- Comment #27 from Julian Maurice --- Created attachment 91177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91177&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Universit? de Lyon 3 Signed-off-by: Liz Rea Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:51:43 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90028|0 |1 is obsolete| | --- Comment #29 from Julian Maurice --- Created attachment 91179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91179&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Universit? de Lyon 3 Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:51:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:51:39 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90027|0 |1 is obsolete| | --- Comment #28 from Julian Maurice --- Created attachment 91178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91178&action=edit Bug 22630: Do not modify item fields if course reserve item says LEAVE UNCHANGED Sponsored-by: Universit? de Lyon 3 Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:51:49 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #30 from Julian Maurice --- Created attachment 91180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91180&action=edit Bug 22630: Allow _RevertFields to set an empty value to item field Sponsored-by: Universit? de Lyon 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:52:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 08:52:11 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:03:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 09:03:20 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:09:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 09:09:11 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.11.02 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:09:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 09:09:28 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.01 |19.11.00,19.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 09:48:56 +0000 Subject: [Koha-bugs] [Bug 23251] New: EDI Order line incorrectly terminated when it ends with a quoted apostrophe Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23251 Bug ID: 23251 Summary: EDI Order line incorrectly terminated when it ends with a quoted apostrophe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Apostrophe is used to terminate segments in Edifact orders. Therefore if appearing in the data it is quoted - Code should not assume that a quoted apostrophe is a valid segment terminator e.g. LIN+4++9781471186684:EN' IMD+L+009+:::Newton-John, Olivia' IMD+L+050+:::Don?'t stop believin?' IMD+L+109+:::Simon & Schuster' QTY+21:1' GIR+001+001:LFN+CRO:LLO+BAH:LST+920 NEW:LSM' PRI+AAE:20.00:CA' RFF+LI:93323' RFF+QLI:OTM88093/00004' The IMD 050 line is incorrectly formed it should end believin?'' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 10:47:45 +0000 Subject: [Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cancelling holds over |Cancelling holds over |returning to wrong tabon |returning to wrong tab on |waitingreserves.pl |waitingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:59:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 10:59:48 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:59:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 10:59:50 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90474|0 |1 is obsolete| | Attachment #90475|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 91181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91181&action=edit Bug 23077: Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 10:59:53 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #9 from Nick Clemens --- Created attachment 91182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91182&action=edit Bug 23077: Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:59:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 10:59:55 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #10 from Nick Clemens --- Created attachment 91183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91183&action=edit Bug 23077: Fix import of cardnumber 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 12:30:08 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:30:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 12:30:10 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91127|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 91184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91184&action=edit Bug 22999: (follow-up) Indentation updates The markup changes require indentation updates. This patch contains indentation changes only. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:30:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 12:30:36 +0000 Subject: [Koha-bugs] [Bug 23118] Copy PayPal logic into plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23118 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:33:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 12:33:44 +0000 Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #6 from Agust?n Moyano --- (In reply to Martin Renvoize from comment #4) > As a note to this one.. I think it really ought to have been written > independently of bug 23214 really.. it was a surprise to see that as a > dependency here as really they're pretty unrelated changes. > > I will however on this occasion look to testing both to save you a refactor. My bad. I'll try to take that into account the next time Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 12:58:53 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:58:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 12:58:56 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40425|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 91185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91185&action=edit Bug 14419: Expanding facets (Show more) performs a new search This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page. Updated tests included. To test: 1 - Perform an OPAC search that returns more than 5 of any given facet type 2 - Click the "Show more" link on the facets and see that the search is reloaded 3 - Apply patch 4 - Repeat search 5 - Note that you can click "Show more" without reloading page 6 - Test that page load is not greatly affected 7 - Ensure that all facet links function normally 8 - Ensure that facets are the same a prior to patch 9 - Repeat for staff client 10 - Prove t/Search.t NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet. Ending punctuation seems to confuse the matcher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:00:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:00:01 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #10 from Nick Clemens --- (In reply to Fridolin SOMERS from comment #8) > Is this the same as Bug 22903 ? Yes, it does seem to be. Also this supersedes the need for 22924 We will need to decide which one we want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:00:14 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22924 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:00:14 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14419 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:07:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:07:45 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 91186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91186&action=edit Bug 22709: (follow-up) Mock enable_plugins config entry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:08:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:08:37 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Kyle M Hall from comment #4) > Unit tests are failing. Thanks for testing! I've added a follow-up to fix the issue. I didn't notice I forgot to mock the enable_plugins config entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:18:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:18:42 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:38:05 +0000 Subject: [Koha-bugs] [Bug 22475] Shelving location doesn't appear on tags list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Bug 22475 depends on bug 22422, which changed state. Bug 22422 Summary: improve item location display with class "shelvingloc" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:38:05 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:42:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:42:39 +0000 Subject: [Koha-bugs] [Bug 23252] New: Missing input_marceditor class in item editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Bug ID: 23252 Summary: Missing input_marceditor class in item editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In serials receive and acquisition order creation from iso2709, the item edition form shows inputs that are missing "input_marceditor" class. They are also missing tabindex and id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:42:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:42:49 +0000 Subject: [Koha-bugs] [Bug 23252] Missing input_marceditor class in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:47:15 +0000 Subject: [Koha-bugs] [Bug 23253] New: OpacNavRight does not display if opacuserlogin disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Bug ID: 23253 Summary: OpacNavRight does not display if opacuserlogin disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 22318 moved the content of OpacNavRight to a 'news' item to aid in translatability. C4/Auth.pm still looks for the OpacNavRight system preference to determine if there is content opac-main.tt checks the value form C4/Auth.pm to set the correct spans To recreate: 1 - Add a news items with location 'OpacNavRight' 2 - View the catalog, it should show correctly 3 - Disable opacuserlogin 4 - The news item no longer appears 5 - git grep OpacNavRight 6 - Note occurrences of reference to the system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:47:26 +0000 Subject: [Koha-bugs] [Bug 23253] OpacNavRight does not display if opacuserlogin disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:47:26 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 [Bug 23253] OpacNavRight does not display if opacuserlogin disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:59:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 13:59:55 +0000 Subject: [Koha-bugs] [Bug 23254] New: Batch item modification and deletion handle leading and trailing spaces inconsistently Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 Bug ID: 23254 Summary: Batch item modification and deletion handle leading and trailing spaces inconsistently Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To Test: - create an item with barcode "123 " - enter barcode "123" in either batch item deletion or batch item modification - receive a "barcode not found error for "123" - note that your item with barcode "123 " does appear in the list for deletion/modification similar to bug 22799 for case sensitivity in these tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:20:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 14:20:20 +0000 Subject: [Koha-bugs] [Bug 23252] Missing input_marceditor class in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:20:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 14:20:23 +0000 Subject: [Koha-bugs] [Bug 23252] Missing input_marceditor class in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 --- Comment #1 from Fridolin SOMERS --- Created attachment 91187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91187&action=edit Bug 23252: Add missing input_marceditor class in item editor In serials receive and acquisition order creation from iso2709, the item edition form shows inputs that are missing "input_marceditor" class. They are also missing tabindex and id. The side effect is that those inputs dont get the "noEnterSubmit" class so form is posted if a barcode scanner is used or if enter is used on keyboard. Test plan : 1) 1.1) Verify you have an item subfield linked to items.itemnotes, ie 952$z 1.2) Verify system preference "AcqCreateItem" is on "placing an order" 2) 2.2) Go to cataloguing module and edit an item 2.3) Verify that $z has an id, tabindex and "input_marceditor" class. 2.4) Verify that typing enter in $z does not submit the form 3) 3.1) Go to a serial with items creation, click on receive 3.2) Change status to "Arrived" 3.3) Verify that $z has an id, tabindex and "input_marceditor" class. 3.4) Verify that typing enter in $z does not submit the form 4) 4.1) Go to an acquisition basket 4.2) Click "Add to basket" and "From a staged file" 4.3) Click "Add orders" on a staged file 4.4) Go in tab "Item information" 4.5) Verify that $z has an id, tabindex and "input_marceditor" class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 14:46:53 +0000 Subject: [Koha-bugs] [Bug 23252] Missing input_marceditor class in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 --- Comment #2 from Marcel de Rooy --- (In reply to Fridolin SOMERS from comment #1) > The side effect is that those inputs dont get the "noEnterSubmit" class so > form is posted if a barcode scanner is used or if enter is used on keyboard. But will everyone appreciate that change ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:14:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 15:14:42 +0000 Subject: [Koha-bugs] [Bug 23251] EDI Order line incorrectly terminated when it ends with a quoted apostrophe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23251 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 91188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91188&action=edit Patch and test To test apply the patch and tests should still pass including new test for correct behaviour when data ends with apostrophe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 15:27:35 +0000 Subject: [Koha-bugs] [Bug 23255] New: HomeOrHoldingbranch system preference options are described wrong Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Bug ID: 23255 Summary: HomeOrHoldingbranch system preference options are described wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This preference is titled well, it determines whether to use the items homebranch or the items holdingbranch for determining circulation rules. The descriptions, however, are wrong: homebranch => 'the library the item is from' holdingbranch => 'the library the item was checked out from' This is not what happens. To recreate: 1 - Set an all all rule for all libraries with a checkout period of 5 days 2 - Set an all all rule for library A with a checkout period of 7 days 3 - Sign in to Koha as Library B 4 - Set CircControl to "item's home library" 5 - Set HomeOrHoldingBranch to "the library the item was checked out from" 6 - Find an item with home and holding branch of library A 7 - Check this out to a patron 8 - The item will be a 7 day loan 9 - You would expect to use the rules of the library you checked out from "Library B" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 15:46:49 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #126 from Cori Lynn Arnold --- Failed to apply: Applying: Bug 18823: Rancor - add support for editing/searching records Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/editor.pl M koha-tmpl/intranet-tmpl/prog/css/cateditor.css M koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc Auto-merging koha-tmpl/intranet-tmpl/prog/css/cateditor.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/cateditor.css Auto-merging cataloguing/editor.pl Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18823: Rancor - add support for editing/searching records The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18823-Rancor---add-support-for-editingsearchin-0J4EtP.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 15:51:55 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- This seems to be explained and updated to the manual, closing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:54:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 15:54:26 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:05:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:05:20 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #11 from M. Tompsett --- (In reply to Jonathan Druart from comment #10) > (In reply to M. Tompsett from comment #9) > > Comment on attachment 90940 [details] [review] [review] > > Bug 23079: Handle invalid timezones when adding/subtracting durations > > > > Review of attachment 90940 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: Koha/Patron.pm > > @@ +622,4 @@ > > > return 0 unless $delay; > > > return 0 unless $self->dateexpiry; > > > return 0 if $self->dateexpiry =~ '^9999'; > > > + return 1 if dt_from_string( $self->dateexpiry, undef, 'floating' )->subtract( days => $delay ) < dt_from_string(undef, undef, 'floating')->truncate( to => 'day' ); > > > > I'd prefer GMT. > > Why? https://metacpan.org/pod/DateTime#How-DateTime-Math-Works Nice long read of recommendations. Floating is fine if we don't care about leap days/seconds, but if we are subtracting days, then perhaps we do care? "If you can always use the floating or UTC time zones, you can skip ahead to "Leap Seconds and Date Math" " So, this uses floating, I'd prefer UTC. Floating is good if we don't care about partial days, but... "$dt->subtract( $duration_object ) A synonym of $dt->subtract_duration( $duration_object )." -- implying we care about partial days. "If you only care about the date (calendar) portion of a datetime, you should use either delta_md() or delta_days(), not subtract_datetime(). This will give predictable, unsurprising results, free from DST-related complications." In short, floating is perfectly okay if we don't care about partial days, do we? > > > ::: acqui/duplicate_orders.pl > > @@ +74,4 @@ > > > > > > unless ( $input->param('from') ) { > > > # Fill the form with year-1 > > > + $from_placed_on->set_time_zone('floating')->subtract( years => 1 ); > > > > Why not: > > $from_placed_on->set_year($from_placed_on->year() - 1); > > -- no timezone needed. > > Hum? I do not understand how it will fix the problem. When timezones are involved weird and wonderful maths are necessary. Since we are just looking for last year, and the time in the current date is valid (otherwise it would have blown up sooner) merely changing just the year back one year avoids anything that might pass-through bizarre timezone stuff. Though, perhaps we care about that? If we care about partial days, then floating is wrong. If we don't, then floating is okay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:11:21 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:11:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:11:23 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 --- Comment #1 from Nick Clemens --- Created attachment 91189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91189&action=edit Bug 23255: Correct HomeOrHoldingBranch descriptions To test: 1 - Apply patch 2 - View 'HomeOrHoldingBranch' system preference 3 - Confirm the options make sense -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:14:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:14:57 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #12 from M. Tompsett --- > > Why not: > > $from_placed_on->set_year($from_placed_on->year() - 1); > > -- no timezone needed. > > Hum? I do not understand how it will fix the problem. "Do not use this method to do date math. Use the add() and subtract() methods instead." https://metacpan.org/pod/DateTime#%22Set%22-Methods -- Okay, bad suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:20:17 +0000 Subject: [Koha-bugs] [Bug 22886] Missing space between fields from Keyword to MARC mapping in cataloguing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22886 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |wizzyrea at gmail.com --- Comment #7 from Liz Rea --- Pushed to 18.05 for 18.05.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:20:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:20:47 +0000 Subject: [Koha-bugs] [Bug 22878] Cannot add a patron card layout with mysql strict mode on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Liz Rea --- Pushed to 18.05 for 18.05.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:21:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:21:11 +0000 Subject: [Koha-bugs] [Bug 20514] Searching for a patrons using the address option doesn't work with streetnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Liz Rea --- Pushed to 18.05 for 18.05.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:21:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 16:21:35 +0000 Subject: [Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #22 from Liz Rea --- Pushed to 18.05 for 18.04.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 19:54:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 17:54:24 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 19:54:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 17:54:32 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #79 from M. Tompsett --- Created attachment 91191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91191&action=edit Bug 1985: Send email alert when comment posted. Many blog systems have a feature where the admin gets an email when someone posts a new comment that needs to be moderated. It would be nice to incorporate this into Koha. Ideally, you could set an email address in system preferences where notifications should be sent (since the Koha administrator is probably not the one approving comments). The body of the email would contain the comments, and offer a direct link to approve or delete the comment. The authorship was corrected to Olli-Antti Kivilahti. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <> is now usable in the letter, as is <>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 19:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 17:54:28 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74769|0 |1 is obsolete| | Attachment #74770|0 |1 is obsolete| | Attachment #74771|0 |1 is obsolete| | --- Comment #78 from M. Tompsett --- Created attachment 91190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91190&action=edit Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 19:54:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 17:54:37 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #80 from M. Tompsett --- Created attachment 91192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91192&action=edit Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Left signed off, even though uk-UA was rebased. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:05:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 18:05:55 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #81 from M. Tompsett --- Found some issues with the StaffClientBaseUrl. http://http:// :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 18:09:22 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from Tom?s Cohen Arazi --- Kyle, the patches look correct and actually solve the specific use case you are tackling. BUT... $ git grep AddRenewal shows there are some places in which the branchcode is still calculated outside and passed: Koha/REST/V1/Checkouts.pm circ/renew.pl misc/cronjobs/automatic_renewals.pl svc/renew also some tests, but I guess they are mocking userenv to match what they pass as parameter, and that's why they are still green. In some cases it might make sense to use userenv (maybe the staff controllers), but I'm not sure (haven't checked) if there is an override available on the UI to allow specifying the branchcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:42:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 18:42:40 +0000 Subject: [Koha-bugs] [Bug 23256] New: fr-CA OPAC_REG_VERIFY has hard-coded http:// Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Bug ID: 23256 Summary: fr-CA OPAC_REG_VERIFY has hard-coded http:// Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Should be an easy fix to remove the http://, since the OPACBaseUrl is supposed to have the protocol in it. Need to create an atomic update (fix during upgrade) AND fix installer/data/mysql/fr-CA/obligatoire/sample_notices.sql (fix on fresh install) TEST PLAN ---------- 1) install fresh for fr-CA language 2) OPAC_REG_VERIFY letter should have http:// in it. 3) apply patch 4) restart all 5) run database upgrade 6) OPAC_REG_VERIFY letter should not have http:// in it. 7) reset all 8) OPAC_REG_VERIFY letter should not have http:// in it. 9) run qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 21:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 19:01:30 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 21:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 19:38:11 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #7 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #6) > Kyle, the patches look correct and actually solve the specific use case you > are tackling. BUT... > > $ git grep AddRenewal > > shows there are some places in which the branchcode is still calculated > outside and passed: > > Koha/REST/V1/Checkouts.pm > circ/renew.pl > misc/cronjobs/automatic_renewals.pl > svc/renew > > also some tests, but I guess they are mocking userenv to match what they > pass as parameter, and that's why they are still green. > > In some cases it might make sense to use userenv (maybe the staff > controllers), but I'm not sure (haven't checked) if there is an override > available on the UI to allow specifying the branchcode. This code is only responsible for calculating the branchcode if the renewal is done from the opac. I don't believe any of those calls you listed are opac based, right? Are you prososing we should consolidate all 'branchcode' logic within the sub and remove the branchcode parameter altogether? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 21:46:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 19:46:33 +0000 Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 23:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2019 21:48:14 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #8 from Tom?s Cohen Arazi --- I'm wondering if there's any race in the different logics for calculating the branchcode. I haven't checked it, but will do at the office! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:18:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:18:40 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:18:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:18:47 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #83 from M. Tompsett --- Created attachment 91194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91194&action=edit Bug 1985: Send email alert when comment posted. Many blog systems have a feature where the admin gets an email when someone posts a new comment that needs to be moderated. It would be nice to incorporate this into Koha. Ideally, you could set an email address in system preferences where notifications should be sent (since the Koha administrator is probably not the one approving comments). The body of the email would contain the comments, and offer a direct link to approve or delete the comment. The authorship was corrected to Olli-Antti Kivilahti. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <> is now usable in the letter, as is <>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:18:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:18:43 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91190|0 |1 is obsolete| | Attachment #91191|0 |1 is obsolete| | Attachment #91192|0 |1 is obsolete| | --- Comment #82 from M. Tompsett --- Created attachment 91193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91193&action=edit Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:18:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:18:51 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #84 from M. Tompsett --- Created attachment 91195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91195&action=edit Bug 1985: (follow-up) correct http:// in staff URL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:18:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:18:55 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #85 from M. Tompsett --- Created attachment 91196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91196&action=edit Bug 1985: (follow-up) Add letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Left signed off, even though uk-UA was rebased. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:19:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:19:00 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #86 from M. Tompsett --- Created attachment 91197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91197&action=edit Bug 1985: (follow-up) fix staff URL in other letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 02:19:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 00:19:05 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #87 from M. Tompsett --- Created attachment 91198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91198&action=edit Bug 1985: (follow-up) Fix Reviews.t logic Read the tests to make sure they make sense. Before the patch is applied, they don't. $nb_of_approved_reviews + 2 did not make sense, because the three reviews added were not approved. search->count counts everything, so the use of approved+3 didn't make sense. Rather than duplicate the search->count test, changed the first one to reflect that the added reviews were all unapproved. Before applying patch, prove fails. After applying patch, prove passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 03:47:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 01:47:11 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 --- Comment #13 from M. Tompsett --- (In reply to Jonathan Druart from comment #10) > Please provide a test plan. > > NormalizeISBN is used in some places and it's hard to imagine the side > effects this patch could introduce. Actually, GetNormalizedISBN is what is more broadly used. It calls _isbn_cleanup which calls NormalizeISBN. It would also seem that this is used to grab book covers using the ISBN-10. Take Amazon for example. https://www.amazon.com/Tolkiens-Failed-Quest-Michael-Jones/dp/1521406812/ That's an ISBN-10. https://www.amazon.com/Apprenez-%C3%A0-programmer-2e-%C3%A9dition/dp/B006MV70GS/ That's an ASIN which is Amazon's own unique ID, because it is ISBN-13 only: 979-1090085008 But what about "The Hobbit"? ISBN-13: 9780547928227 ISBN-10: 054792822X https://www.amazon.com/Hobbit-J-R-Tolkien/dp/054792822X/ So, how are we supposed to grab Amazon covers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:15:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:15:51 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #2) > Created attachment 82173 [details] [review] > Bug 21801: (follow-up) Use ->account > > This patch is a minor refactoring, that reuses the $account object we > already get from $patron, instead of creating new ones all over the > place. Code gets simpler to read too. And given the use of the variable, probably is faster too. Nice. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:17:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:17:12 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 --- Comment #4 from M. Tompsett --- Comment on attachment 82173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82173 Bug 21801: (follow-up) Use ->account Review of attachment 82173: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21801&attachment=82173) ----------------------------------------------------------------- ::: members/paycollect.pl @@ +59,4 @@ > my $category = $patron->category; > my $user = $input->remote_user; > > +my $library_id = C4::Context->userenv->{'branch'}; Just had to rename $branch to library_id to fit the _id structure of thinking. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:18:20 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 --- Comment #5 from M. Tompsett --- Comment on attachment 82172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82172 Bug 21801: Make paycollect.pl pass library_id when calling ->pay Review of attachment 82172: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21801&attachment=82172) ----------------------------------------------------------------- ::: members/paycollect.pl @@ +168,4 @@ > Koha::Account->new( { patron_id => $borrowernumber } )->pay( > { > amount => $total_paid, > + library_id => $branch, Strange how, it was passed in a place above, but not these two changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:29:01 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:29:06 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 --- Comment #7 from M. Tompsett --- Created attachment 91200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91200&action=edit Bug 21801: (follow-up) Use ->account This patch is a minor refactoring, that reuses the $account object we already get from $patron, instead of creating new ones all over the place. Code gets simpler to read too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:29:03 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82172|0 |1 is obsolete| | Attachment #82173|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 91199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91199&action=edit Bug 21801: Make paycollect.pl pass library_id when calling ->pay This patch makes paycollect store the branchcode of the current library when payments are done. - Try all the possible options, specially selecting things to pay for (not using the individual buttons). - Check on the DB, that the accountlines for the patron you're playin with have the branchcode stored correctly in all cases: $ sudo koha-mysql kohadev > SELECT * FROM accountlines WHERE borrowernumber=; => SUCCESS: Things are as expected - SIgn off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:36:02 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #4 from M. Tompsett --- Created attachment 91201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91201&action=edit Bug 23230: (follow-up) Fix broken tests Before patch, the new tests don't run. After patch, they do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:36:48 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91152|0 |1 is obsolete| | Attachment #91153|0 |1 is obsolete| | Attachment #91201|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 91202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91202&action=edit Bug 23230: Unit tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:36:50 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #6 from M. Tompsett --- Created attachment 91203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91203&action=edit Bug 23230: Make _version_compare OO context aware On using _version_compare in plugins development, it would be nice if it was able to be called as an object method. This way we don't need to fully qualify it like this: Koha::Plugins::Base::_version_compare and we can do $self->_version_compare instead. This patch implements this behavior change. It is backwards compatible so plugins using the 'old way' don't break. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:36:53 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #7 from M. Tompsett --- Created attachment 91204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91204&action=edit Bug 23230: (follow-up) Fix broken tests Before patch, the new tests don't run. After patch, they do. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:36:45 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:55:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 02:55:24 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #4) > Created attachment 91201 [details] [review] > Bug 23230: (follow-up) Fix broken tests > > Before patch, the new tests don't run. > After patch, they do. I wonder what bug I attached my version of this patch he he -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 05:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 03:27:51 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #2 from M. Tompsett --- Comment on attachment 91158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158 Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl Review of attachment 91158: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23247&attachment=91158) ----------------------------------------------------------------- ::: opac/opac-MARCdetail.pl @@ +305,4 @@ > push @item_loop, $item if $item; > } > my ( $holdingbrtagf, $holdingbrtagsubf ) = > + &GetMarcFromKohaField( "items.holdingbranch", $biblio->frameworkcode ); If you are refactoring, while I would prefer to keep framework code in, so as to allow weird and wonderful things in the future (UNIMARC and MARC21 co-existing), the function has already been neutered. So perhaps a refactor on this and other uses of this function here would be in order? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 05:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 03:28:35 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett --- Setting to Failed QA, while discussion about cleaning up the other function call is had and/or done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 07:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 05:11:43 +0000 Subject: [Koha-bugs] [Bug 23190] Authority hierarchy display appears to be broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Do you have sample data? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 08:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 06:18:50 +0000 Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Priority|P5 - low |P4 Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 09:54:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 07:54:03 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to M. Tompsett from comment #2) > Comment on attachment 91158 [details] [review] > Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl > > Review of attachment 91158 [details] [review]: > ----------------------------------------------------------------- > > ::: opac/opac-MARCdetail.pl > @@ +305,4 @@ > > push @item_loop, $item if $item; > > } > > my ( $holdingbrtagf, $holdingbrtagsubf ) = > > + &GetMarcFromKohaField( "items.holdingbranch", $biblio->frameworkcode ); > > If you are refactoring, while I would prefer to keep framework code in, so > as to allow weird and wonderful things in the future (UNIMARC and MARC21 > co-existing), the function has already been neutered. So perhaps a refactor > on this and other uses of this function here would be in order? Hi Marc, resetting status - this is only a clan-up, the parameter frameworkcode for GetMarcFromKohaField does no longer exist. See bug 22721 for some more info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:40:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:40:50 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88493|0 |1 is obsolete| | --- Comment #127 from Alex Arnaud --- Created attachment 91205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91205&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:05 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88495|0 |1 is obsolete| | --- Comment #129 from Alex Arnaud --- Created attachment 91207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91207&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:13 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88496|0 |1 is obsolete| | --- Comment #130 from Alex Arnaud --- Created attachment 91208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91208&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:40:57 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88494|0 |1 is obsolete| | --- Comment #128 from Alex Arnaud --- Created attachment 91206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91206&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:20 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88497|0 |1 is obsolete| | --- Comment #131 from Alex Arnaud --- Created attachment 91209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91209&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:27 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88498|0 |1 is obsolete| | --- Comment #132 from Alex Arnaud --- Created attachment 91210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91210&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:33 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88499|0 |1 is obsolete| | --- Comment #133 from Alex Arnaud --- Created attachment 91211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91211&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:40 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88500|0 |1 is obsolete| | --- Comment #134 from Alex Arnaud --- Created attachment 91212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91212&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:47 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88501|0 |1 is obsolete| | --- Comment #135 from Alex Arnaud --- Created attachment 91213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91213&action=edit Bug 18823: Fix targets registering Signed-off-by: cori ebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:41:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:41:55 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88502|0 |1 is obsolete| | --- Comment #136 from Alex Arnaud --- Created attachment 91214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91214&action=edit Bug 18823: Add pod for UpdateMarcTimestamp and template filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:42:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:42:02 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88503|0 |1 is obsolete| | --- Comment #137 from Alex Arnaud --- Created attachment 91215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91215&action=edit Bug 18823: add unit tests for added/changed subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:42:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:42:08 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88504|0 |1 is obsolete| | --- Comment #138 from Alex Arnaud --- Created attachment 91216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91216&action=edit Bug 18823: C4::Koha::GetNormalizedISBN loading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:42:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:42:13 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88505|0 |1 is obsolete| | --- Comment #139 from Alex Arnaud --- Created attachment 91217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91217&action=edit Bug 18823: center sucess saving message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:42:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:42:20 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88506|0 |1 is obsolete| | --- Comment #140 from Alex Arnaud --- Created attachment 91218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91218&action=edit Bug 18823: reduce batches management modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:42:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:42:26 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88507|0 |1 is obsolete| | --- Comment #141 from Alex Arnaud --- Created attachment 91219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91219&action=edit Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 08:47:58 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:17:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 10:17:20 +0000 Subject: [Koha-bugs] [Bug 23257] New: OPACHoldsIfAvailableAtPickup not working correctly for single branch installations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23257 Bug ID: 23257 Summary: OPACHoldsIfAvailableAtPickup not working correctly for single branch installations Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Found this testing in 17.11, needs to be confirmed for versions higher up: - Have only 1 library in your system - Set OPACHoldsIfAvailableAtPickup to "not allow" - Create a circulation condition allowing "on shelf holds" - Go to the OPAC - try to place a hold. It won't be possible. (NOT OK) - Go to the staff side- try to place ahold. It will be possible. (OK) - Change the pref - Holds should work in both staff and OPAC. - Change the pref back to "not allow", add a second library - Holds will be possible. (NOT OK it requires a second library) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:17:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 11:17:13 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:17:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 11:17:25 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #10 from Kyle M Hall --- Created attachment 91221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91221&action=edit Bug 23230: Make _version_compare OO context aware On using _version_compare in plugins development, it would be nice if it was able to be called as an object method. This way we don't need to fully qualify it like this: Koha::Plugins::Base::_version_compare and we can do $self->_version_compare instead. This patch implements this behavior change. It is backwards compatible so plugins using the 'old way' don't break. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 11:17:16 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91202|0 |1 is obsolete| | Attachment #91203|0 |1 is obsolete| | Attachment #91204|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 91220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91220&action=edit Bug 23230: Unit tests Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:17:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 11:17:27 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #11 from Kyle M Hall --- Created attachment 91222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91222&action=edit Bug 23230: (follow-up) Fix broken tests Before patch, the new tests don't run. After patch, they do. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:20:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 11:20:01 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #9 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #8) > I'm wondering if there's any race in the different logics for calculating > the branchcode. I haven't checked it, but will do at the office! I can't imagine how this code could have race conditions, but I'm interested in what the results of your research are! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 11:45:50 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #142 from Cori Lynn Arnold --- Patches apply, but going to the advanced editor causes a javascript error that prevents the page from fully loading: Uncaught ReferenceError: insert_copyright is not defined at marc-editor.js:140 at Object.execCb (require_19.0600010.js:29) at X.check (require_19.0600010.js:18) at X. (require_19.0600010.js:23) at require_19.0600010.js:8 at require_19.0600010.js:23 at y (require_19.0600010.js:7) at X.emit (require_19.0600010.js:23) at X.check (require_19.0600010.js:19) at X. (require_19.0600010.js:23) https://snag.gy/4eWg7B.jpg using Chrome browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:18:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 12:18:11 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #12 from Nick Clemens --- List comments were positive, I also taked with our trainers. They agreed, if a patron has said they don't want a book after a certain date, then they don't want it after that date. In terms of patron experience, they don't know the book is in-transit, so would be a mystery why they sometimes get a notice for a hold they said they didn't want. Back to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:19:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 12:19:51 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:19:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 12:19:53 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90950|0 |1 is obsolete| | Attachment #90951|0 |1 is obsolete| | Attachment #91186|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 91223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91223&action=edit Bug 22709: Unit tests This patch introduces tests for new plugin hooks added to C4::Biblio::{Add|Mod|Del}Biblio and C4::Items::{Add|Mod|Del}Item. They are tested together as for creating an item you need to first create a biblio and tests looks basically the same. The testing strategy is - Make sure the plugin is passed the right params - Throw an exception at plugin-level, to be trapped by the C4::Biblio and C4::Items lib, and converted into a warning. So we test for the warning. - Also, the fact that C4::Biblio and C4::Items warns, means the exception was cought, and then Koha won't break on faulty plugins or fatal errors from plugins. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 12:20:04 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #8 from Kyle M Hall --- Created attachment 91224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91224&action=edit Bug 22709: Add after biblio/item action hooks This patch introduces after-action hooks for - C4::Biblio::{Add|Mod|Del}Biblio - C4::Items::{Add|Mod|Del}Biblio After the action has taken place, a call to a helper method is done, which loops through all plugins implementing the hooks, and calls the plugin method. The related object is passed, along with an 'action' string specifying the action that took place, and the object id (which is specially important for the 'Del' case). To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Biblio_and_Items_plugin_hooks.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 12:20:10 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #10 from Kyle M Hall --- Created attachment 91226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91226&action=edit Bug 22709: (follow-up) Move new test file into a Plugins subdirectory Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 12:20:06 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #9 from Kyle M Hall --- Created attachment 91225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91225&action=edit Bug 22709: (follow-up) Mock enable_plugins config entry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:03:07 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:05:27 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:06:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:06:17 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Kyle M Hall from comment #10) > Created attachment 91226 [details] [review] > Bug 22709: (follow-up) Move new test file into a Plugins subdirectory > > Signed-off-by: Kyle M Hall Good idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:08:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:08:43 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:08:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:08:45 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:21:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:21:37 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:21:40 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #10 from Kyle M Hall --- Created attachment 91227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91227&action=edit Bug 23165: (QA follow-up) Don't set if it's already set for non-opac calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:22:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:22:37 +0000 Subject: [Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:23:32 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:26:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:26:17 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Component|Authentication |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:30:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:30:15 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:30:18 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91189|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 91228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91228&action=edit Bug 23255: Correct HomeOrHoldingBranch descriptions To test: 1 - Apply patch 2 - View 'HomeOrHoldingBranch' system preference 3 - Confirm the options make sense Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:43:37 +0000 Subject: [Koha-bugs] [Bug 23219] Prevent patron delete if holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Everything looks like it's working as it should. There's just one minor complaint from the QA tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/deletemem.tt FAIL filters missing_filter at line 41 (

Patron has [% ItemsOnHold %] hold(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:45:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:45:34 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91227|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Comment on attachment 91227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91227 Bug 23165: (QA follow-up) Don't set if it's already set for non-opac calls Bug 17781 directly contravenes this bug. The original patch behaviors is correct. Thank goodness for unit tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:46:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 13:46:06 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #12 from Kyle M Hall --- > Bug 17781 directly contravenes this bug. The original patch behaviors is > correct. Thank goodness for unit tests! s/bug/patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 14:22:15 +0000 Subject: [Koha-bugs] [Bug 22037] regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83436|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 91229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91229&action=edit Bug 22037: Block SIP checkout if guarantees have debt Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 14:22:12 +0000 Subject: [Koha-bugs] [Bug 22037] regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:32:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 14:32:25 +0000 Subject: [Koha-bugs] [Bug 20655] Z3950 Authorities search is unordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20655 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:33:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 14:33:05 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #38 from Christopher Brannon --- I would really like to see this backported to 18.X -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:59:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 14:59:21 +0000 Subject: [Koha-bugs] [Bug 23258] New: Batch holding Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Bug ID: 23258 Summary: Batch holding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org Add a "batch holding" tool (just like batch item modification, batch patron deletion...) This tool would allow to place or cancel holds in batch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:00:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 15:00:23 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #1 from Matthias Meusburger --- Created attachment 91230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91230&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:01:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 15:01:01 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 15:51:55 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #143 from Alex Arnaud --- Can't see this error. It seems odd to me that there is this kind of issue here (insert_copyright is not defined at marc-editor.js:140) Using chromium But i have an other error with firefox: TypeError: a.label is undefined This one prevents the editor to be loaded too. Working on first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 16:25:21 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #144 from Alex Arnaud --- That last error seems to be introduced by Bug 16232 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 16:36:11 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I can't seem to get this to work... Every time I submit a set of barcodes it tells me none of them can be placed on hold. I can place an item-level hold for the same patron using the regular method, so I assume it's not a problem with my circulation rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:38:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 16:38:37 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #3 from Owen Leonard --- This needs some follow-up work to fix QA tool warnings too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:48:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 16:48:08 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Margaret changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:29:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:29:04 +0000 Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |agustinmoyano at theke.io CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:32:02 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:32:02 +0000 Subject: [Koha-bugs] [Bug 23259] New: Remove reset-fonts-grids.css Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Bug ID: 23259 Summary: Remove reset-fonts-grids.css Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The staff client's global CSS file imports a CSS file called "reset-fonts-grids.css," a set of defaults and grid definitions from the YUI library. We can remove this now that we have Bootstrap grids on all staff client pages. Some of our CSS will require some minor updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:38:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:38:35 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #154 from Agust?n Moyano --- Created attachment 91231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91231&action=edit Bug 14570: (follow-up) Fix patron type when "add child" button is pressed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:38:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:38:29 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:40:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:40:39 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 --- Comment #4 from Lucas Gass --- pushed to 18.11.x for 18.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:41:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:41:20 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:49:32 +0000 Subject: [Koha-bugs] [Bug 23260] New: Anonymize (remove) patron data from items_last_borrower Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Bug ID: 23260 Summary: Anonymize (remove) patron data from items_last_borrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Increase level of patron privacy by removing patron information from the items_last_borrower table after a set period of time. Adjust the batch_anonymize cronjob to also remove data from the items_last_borrower table when the data is more than x days old (runtime option) but not if the item is lost, damaged, or withdrawn. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:50:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:50:32 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:53:29 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:53:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:53:40 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:55:21 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass --- missing dependency for 18.11.x series, no backport -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 17:55:33 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 20:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 18:11:12 +0000 Subject: [Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #8 from Christopher Brannon --- Would like to see this move forward. This is an active problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 20:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 18:35:13 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 91232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91232&action=edit Bug 22280: Fix typo in _status_graph_union Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 20:48:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 18:48:48 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:11:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:11:22 +0000 Subject: [Koha-bugs] [Bug 23261] New: RecordedBooks - notify patron of need to login / register to see availability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Bug ID: 23261 Summary: RecordedBooks - notify patron of need to login / register to see availability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:15:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:15:45 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:15:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:15:47 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #1 from Nick Clemens --- Created attachment 91233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91233&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:15:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:15:53 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:20:46 +0000 Subject: [Koha-bugs] [Bug 22578] calendar options for every other week closings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22578 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:21:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:21:57 +0000 Subject: [Koha-bugs] [Bug 6664] Allow to set a weekly holiday for a given data range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:23:57 +0000 Subject: [Koha-bugs] [Bug 23262] New: OverduesBlockCirc should ask for confirmation about checkout session Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23262 Bug ID: 23262 Summary: OverduesBlockCirc should ask for confirmation about checkout session Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would like to see another option added to the OverduesBlockCirc preference that would 'Ask for checkout session confirmation'. Scenario: A patron comes in with 50 books that are overdue. Drops them in the book drop. Comes to the desk with 50 more books. (It happens, especially parents with kids). Our only choice is to either check all the books in from the book drop, or override every item they check out. Preferably, if this new option is added, the override remains in effect until the staff member closes the patron account page or navigates away from that page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:30:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:30:25 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91185|0 |1 is obsolete| | --- Comment #11 from Michal Denar --- Created attachment 91234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91234&action=edit Bug 14419: Expanding facets (Show more) performs a new search This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page. Updated tests included. To test: 1 - Perform an OPAC search that returns more than 5 of any given facet type 2 - Click the "Show more" link on the facets and see that the search is reloaded 3 - Apply patch 4 - Repeat search 5 - Note that you can click "Show more" without reloading page 6 - Test that page load is not greatly affected 7 - Ensure that all facet links function normally 8 - Ensure that facets are the same a prior to patch 9 - Repeat for staff client 10 - Prove t/Search.t NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet. Ending punctuation seems to confuse the matcher. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:30:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:30:21 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:48:56 +0000 Subject: [Koha-bugs] [Bug 23263] New: RecordedBooks shows 'Check out' button for unavailable items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23263 Bug ID: 23263 Summary: RecordedBooks shows 'Check out' button for unavailable items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The recorded books code checks if the current patron has a specific item checked out, if not it shows a checkout button. We should instead check the availability of the item and only show a button if it is available. Currently RB digital results don't have this information: https://gitlab.com/srdjan-catalyst/webservice-ils/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 19:49:04 +0000 Subject: [Koha-bugs] [Bug 23263] RecordedBooks shows 'Check out' button for unavailable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23263 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:02:00 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91166|0 |1 is obsolete| | --- Comment #54 from Josef Moravec --- Created attachment 91235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91235&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:02:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:02:07 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91167|0 |1 is obsolete| | --- Comment #55 from Josef Moravec --- Created attachment 91236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91236&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:02:13 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91168|0 |1 is obsolete| | --- Comment #56 from Josef Moravec --- Created attachment 91237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91237&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:02:20 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #57 from Josef Moravec --- Created attachment 91238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91238&action=edit Bug 17005: Fix bad rebase Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:25:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:25:34 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91126|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 91239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91239&action=edit Bug 22999: Switch two-column templates to Bootstrap grid: Circulation This patch modifies the circulation page template to use the Bootstrap grid instead of YUI. To test, apply the patch and view the checkout page, confirming that it looks correct at various browser widths: - Check out (no patron) - Check out -> Patron search - Results - No results - Check out -> Patron selected - Can check out - Checkout blocked (renewal confirmation, item on hold, etc) - Can't check out (expired, restricted) Signed-off-by: David Nind Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:25:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:25:39 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91184|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 91240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91240&action=edit Bug 22999: (follow-up) Indentation updates The markup changes require indentation updates. This patch contains indentation changes only. Signed-off-by: David Nind Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:28:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 20:28:14 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:01:35 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91234|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 91241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91241&action=edit Bug 14419: Expanding facets (Show more) performs a new search This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page. Updated tests included. To test: 1 - Perform an OPAC search that returns more than 5 of any given facet type 2 - Click the "Show more" link on the facets and see that the search is reloaded 3 - Apply patch 4 - Repeat search 5 - Note that you can click "Show more" without reloading page 6 - Test that page load is not greatly affected 7 - Ensure that all facet links function normally 8 - Ensure that facets are the same a prior to patch 9 - Repeat for staff client 10 - Prove t/Search.t NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet. Ending punctuation seems to confuse the matcher. Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:01:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:01:40 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #13 from Josef Moravec --- Created attachment 91242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91242&action=edit Bug 14419: (QA follow-up) Restore the link styling Test plan: Look at Show more/less links in facets, in opac and staff client --> without this patch they are pure text, no styling, no hand cursor --> with this patch it is link, but continues to work as before Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:03:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:03:13 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:07:42 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91228|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 91243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91243&action=edit Bug 23255: Correct HomeOrHoldingBranch descriptions To test: 1 - Apply patch 2 - View 'HomeOrHoldingBranch' system preference 3 - Confirm the options make sense Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:08:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:08:07 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:19:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:19:24 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91223|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 91244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91244&action=edit Bug 22709: Unit tests This patch introduces tests for new plugin hooks added to C4::Biblio::{Add|Mod|Del}Biblio and C4::Items::{Add|Mod|Del}Item. They are tested together as for creating an item you need to first create a biblio and tests looks basically the same. The testing strategy is - Make sure the plugin is passed the right params - Throw an exception at plugin-level, to be trapped by the C4::Biblio and C4::Items lib, and converted into a warning. So we test for the warning. - Also, the fact that C4::Biblio and C4::Items warns, means the exception was cought, and then Koha won't break on faulty plugins or fatal errors from plugins. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:19:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:19:33 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91225|0 |1 is obsolete| | --- Comment #14 from Josef Moravec --- Created attachment 91246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91246&action=edit Bug 22709: (follow-up) Mock enable_plugins config entry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:19:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:19:29 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91224|0 |1 is obsolete| | --- Comment #13 from Josef Moravec --- Created attachment 91245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91245&action=edit Bug 22709: Add after biblio/item action hooks This patch introduces after-action hooks for - C4::Biblio::{Add|Mod|Del}Biblio - C4::Items::{Add|Mod|Del}Biblio After the action has taken place, a call to a helper method is done, which loops through all plugins implementing the hooks, and calls the plugin method. The related object is passed, along with an 'action' string specifying the action that took place, and the object id (which is specially important for the 'Del' case). To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Biblio_and_Items_plugin_hooks.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:19:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:19:37 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91226|0 |1 is obsolete| | --- Comment #15 from Josef Moravec --- Created attachment 91247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91247&action=edit Bug 22709: (follow-up) Move new test file into a Plugins subdirectory Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:20:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:20:03 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:33:54 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91199|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 91248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91248&action=edit Bug 21801: Make paycollect.pl pass library_id when calling ->pay This patch makes paycollect store the branchcode of the current library when payments are done. - Try all the possible options, specially selecting things to pay for (not using the individual buttons). - Check on the DB, that the accountlines for the patron you're playin with have the branchcode stored correctly in all cases: $ sudo koha-mysql kohadev > SELECT * FROM accountlines WHERE borrowernumber=; => SUCCESS: Things are as expected - SIgn off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:34:19 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:33:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 21:33:58 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91200|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 91249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91249&action=edit Bug 21801: (follow-up) Use ->account This patch is a minor refactoring, that reuses the $account object we already get from $patron, instead of creating new ones all over the place. Code gets simpler to read too. Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 01:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 23:25:33 +0000 Subject: [Koha-bugs] [Bug 23264] New: OPAC elements with class="dropdown" include incomplete WAI-ARIA Menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23264 Bug ID: 23264 Summary: OPAC elements with class="dropdown" include incomplete WAI-ARIA Menu Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: brian at mcneil.ly QA Contact: testopia at bugs.koha-community.org Details: Buttons that spawn items with role="menu" must indicate this fact with aria-haspopup="menu", and an aria-controls attribute referencing the id value for the element with role="menu". On expansion, focus should move to the first menu item, and focus should be tracked with either a roving tabindex attribute (so one menu item is always focusable) or tracked with an aria-activedescendant attribute on the element with role="menu". aria-expanded can be used to indicate the state of the button and its attached menu (e.g. expanded or collapsed). This paradigm may apply to over OPAC menus, such as the Lists Menu on the homepage. Steps to Reproduce: 1. Navigate to the element with id="langmenu" 2. Verify this item does not have an aria-haspopup attribute 3. Activate the element, verify a menu appears 4. Verify this content contains an element with role="menu" 5. Verify focus has not moved to the first menuitem beneath the menu 6. Use the arrow keys to adjust content within the menu 7. Verify tabindex attributes are not adjusted and aria-activedescendant is not set on the element with role="menu" Actual Results: Screen readers and other assistive technologies may be unable to interact with content as intended if ARIA controls are not coded to spec. Expected Results: The above listed attributes are added to the button item and element with role="menu". An example of a fully implemented button spawning an element with role="menu" (in this case using aria-activedescendant) can be found at: https://www.w3.org/TR/wai-aria-practices/examples/menu-button/menu-button-actions-active-descendant.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 01:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2019 23:27:52 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- What was the koha-create command used to generate that?! Because: sudo koha-create --create-db {instance name} generally is working for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 00:33:46 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 00:33:48 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 --- Comment #2 from M. Tompsett --- Created attachment 91250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91250&action=edit Bug 23250: Just use an @ in the password Rather than try to use -y and symbols, since older versions of pwgen don't have the -y, Purposefully just shorten the generated password to 15 characters and put @ on the end. This avoids nasty shell globbing, fixes the MySQL requiring a symbol by default in the newer versions. While @ at the end is less secure, the password portion providing security is still 15 characters long. Before patch, password should have potentially multiple ugly symbols in it. After patch, when creating an instance, the password will have an @ at the end of it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:35:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 00:35:35 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91250|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 91251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91251&action=edit Bug 23250: Just use an @ in the password Rather than try to use -y and symbols, since older versions of pwgen don't have the -y, Purposefully just shorten the generated password to 15 characters and put @ on the end. This avoids nasty shell globbing, fixes the MySQL requiring a symbol by default in the newer versions. While @ at the end is less secure, the password portion providing security is still 15 characters long. Before patch, password should have potentially multiple ugly symbols in it. After patch, when creating an instance, the password will have an @ at the end of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 03:52:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 01:52:15 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 03:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 01:52:18 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 --- Comment #4 from M. Tompsett --- Created attachment 91252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91252&action=edit Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls Test plan: Run tests, at least: t/db_dependent/Biblio.t t/db_dependent/Biblio/TransformHtmlToMarc.t t/db_dependent/Charset.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/ImportBatch.t t/db_dependent/Items.t t/db_dependent/Items/AutomaticItemModificationByAge.t t/db_dependent/Items/GetItemsForInventory.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Serials.t t/db_dependent/XISBN.t t/db_dependent/FrameworkPlugin.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 03:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 01:53:59 +0000 Subject: [Koha-bugs] [Bug 20655] Z3950 Authorities search is unordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20655 --- Comment #1 from David Cook --- I'd have to take a look and get my hands dirty to have an opinion on this one, but I'm preoccupied at the moment. Sounds interesting though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:13:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:13:39 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Rebased -- bug 22696 made changes to opac-ISBDdetail.pl not necessary. bug 22046 made changes to C4/Matcher.pm which conflicted, but were easily resolved. Also removed unused variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:14:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:14:21 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:13:57 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:22:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:22:09 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:22:12 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #5 from M. Tompsett --- Created attachment 91253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91253&action=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:27:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:27:38 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on|22696 |22721 --- Comment #6 from M. Tompsett --- I believe I have rebased it correctly to be off bug 22721 as mentioned by Katrin in comment #4. As such, I'm happy to leave it back at Needs Signoff. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 [Bug 22721] Normalize GetMarcFromKohaField calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:27:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:27:38 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23247 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:27:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:27:38 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:28:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:28:09 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:29:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 02:29:45 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #7 from M. Tompsett --- Apologies, I lost the other Depends on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:48:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:48:55 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90544|0 |1 is obsolete| | --- Comment #44 from Josef Moravec --- Created attachment 91254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91254&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:49:04 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90546|0 |1 is obsolete| | --- Comment #46 from Josef Moravec --- Created attachment 91256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91256&action=edit Bug 18930: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:48:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:48:59 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90545|0 |1 is obsolete| | --- Comment #45 from Josef Moravec --- Created attachment 91255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91255&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:49:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:49:08 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90547|0 |1 is obsolete| | --- Comment #47 from Josef Moravec --- Created attachment 91257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91257&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:49:13 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90548|0 |1 is obsolete| | --- Comment #48 from Josef Moravec --- Created attachment 91258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91258&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:49:17 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90549|0 |1 is obsolete| | --- Comment #49 from Josef Moravec --- Created attachment 91259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91259&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:49:22 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #50 from Josef Moravec --- Created attachment 91260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91260&action=edit Bug 18930: (QA follow-up) Remove debug code Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 06:49:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 04:49:46 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:19 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89836|0 |1 is obsolete| | --- Comment #141 from Josef Moravec --- Created attachment 91261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91261&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:31 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89839|0 |1 is obsolete| | --- Comment #143 from Josef Moravec --- Created attachment 91263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91263&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89840|0 |1 is obsolete| | --- Comment #144 from Josef Moravec --- Created attachment 91264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91264&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:25 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89838|0 |1 is obsolete| | --- Comment #142 from Josef Moravec --- Created attachment 91262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91262&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:43 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89841|0 |1 is obsolete| | --- Comment #145 from Josef Moravec --- Created attachment 91265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91265&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:49 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89842|0 |1 is obsolete| | --- Comment #146 from Josef Moravec --- Created attachment 91266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91266&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:27:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:27:54 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89843|0 |1 is obsolete| | --- Comment #147 from Josef Moravec --- Created attachment 91267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91267&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:05 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89845|0 |1 is obsolete| | --- Comment #149 from Josef Moravec --- Created attachment 91269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91269&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:00 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89844|0 |1 is obsolete| | --- Comment #148 from Josef Moravec --- Created attachment 91268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91268&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:15 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89846|0 |1 is obsolete| | --- Comment #150 from Josef Moravec --- Created attachment 91270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91270&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89847|0 |1 is obsolete| | --- Comment #151 from Josef Moravec --- Created attachment 91271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91271&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:28 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89848|0 |1 is obsolete| | --- Comment #152 from Josef Moravec --- Created attachment 91272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91272&action=edit Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:34 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89849|0 |1 is obsolete| | --- Comment #153 from Josef Moravec --- Created attachment 91273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91273&action=edit Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:41 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90133|0 |1 is obsolete| | --- Comment #154 from Josef Moravec --- Created attachment 91274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91274&action=edit Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90199|0 |1 is obsolete| | --- Comment #155 from Josef Moravec --- Created attachment 91275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91275&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:28:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:28:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90200|0 |1 is obsolete| | --- Comment #156 from Josef Moravec --- Created attachment 91276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91276&action=edit Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:29:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:29:05 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90201|0 |1 is obsolete| | --- Comment #157 from Josef Moravec --- Created attachment 91277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91277&action=edit Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:29:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:29:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90469|0 |1 is obsolete| | --- Comment #158 from Josef Moravec --- Created attachment 91278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91278&action=edit Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:29:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:29:19 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90525|0 |1 is obsolete| | --- Comment #159 from Josef Moravec --- Created attachment 91279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91279&action=edit Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:29:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:29:25 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #160 from Josef Moravec --- Created attachment 91280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91280&action=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:30:19 +0000 Subject: [Koha-bugs] [Bug 23219] Prevent patron delete if holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91175|0 |1 is obsolete| | --- Comment #6 from Emmi Takkinen --- Created attachment 91281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91281&action=edit Bug 23219: Cancel patrons holds when patron delete Fixed missing filter from "ItemsOnHold". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:31:21 +0000 Subject: [Koha-bugs] [Bug 23219] Prevent patron delete if holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:32:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:32:35 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #161 from Josef Moravec --- Created attachment 91282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91282&action=edit Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 07:32:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 05:32:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:17:26 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:17:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:17:36 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:17:16 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |martin.renvoize at ptfs-europe | |.com Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:17:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:17:57 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:17:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:17:44 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:18:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:18:47 +0000 Subject: [Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |18.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:41:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:41:53 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:41:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 06:41:56 +0000 Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91252|0 |1 is obsolete| | --- Comment #6 from Michal Denar --- Created attachment 91283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91283&action=edit Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls Test plan: Run tests, at least: t/db_dependent/Biblio.t t/db_dependent/Biblio/TransformHtmlToMarc.t t/db_dependent/Charset.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/ImportBatch.t t/db_dependent/Items.t t/db_dependent/Items/AutomaticItemModificationByAge.t t/db_dependent/Items/GetItemsForInventory.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Serials.t t/db_dependent/XISBN.t t/db_dependent/FrameworkPlugin.t Signed-off-by: Josef Moravec Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 09:19:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 07:19:37 +0000 Subject: [Koha-bugs] [Bug 23171] The plugin_methods table should not include imported methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 09:46:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 07:46:58 +0000 Subject: [Koha-bugs] [Bug 16232] Edit as new (duplicate) doesn't work correctly with Rancor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #9 from Alex Arnaud --- This give me a new "undefined" value in save target list. What is it supposed to be ? Clicking on it simply save the record in database, like if i just click on "Save to catalog". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:26:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:26:27 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:26:29 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:26:31 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:26:33 +0000 Subject: [Koha-bugs] [Bug 23255] HomeOrHoldingbranch system preference options are described wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23255 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:32:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:32:20 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91251|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 91284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91284&action=edit Bug 23250: Just use an @ in the password Rather than try to use -y and symbols, since older versions of pwgen don't have the -y, Purposefully just shorten the generated password to 15 characters and put @ on the end. This avoids nasty shell globbing, fixes the MySQL requiring a symbol by default in the newer versions. While @ at the end is less secure, the password portion providing security is still 15 characters long. Before patch, password should have potentially multiple ugly symbols in it. After patch, when creating an instance, the password will have an @ at the end of it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:33:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:33:15 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com Patch complexity|--- |Trivial patch --- Comment #5 from Martin Renvoize --- Simple patch that works well. Thanks Mark, Going straight for PQA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:33:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:33:24 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:33:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:33:43 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:33:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 08:33:41 +0000 Subject: [Koha-bugs] [Bug 23250] koha-create generates broken mysql password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23250 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:06:12 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #21 from Mirko Tietgen --- I assume this breaks upgrading the Koha DB schema at DB revision 16.12.00.032 >[?] >Upgrade to 16.12.00.030 done (Bug 16344 - Add a circ rule to limit the auto renewals given a specific date) >Upgrade to 16.12.00.031 done (Bug 15108: OAI-PMH provider improvements) >DBD::mysql::st execute failed: Unknown column 'me.item_level_hold' in 'field list' [for Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`, `me`.`item_level_hold` FROM `reserves` `me` WHERE ( ( `found` = ? AND `priority` = ? ) )" with ParamValues: 0='W', 1=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. >DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.item_level_hold' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 209 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:11:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:11:09 +0000 Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- Rebase looks easy ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:13:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:13:37 +0000 Subject: [Koha-bugs] [Bug 23265] New: Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Bug ID: 23265 Summary: Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org When creating an instance from an older DB and running koha-upgrade-schema, the following error occurs. >[?] >Upgrade to 16.12.00.030 done (Bug 16344 - Add a circ rule to limit the auto renewals given a specific date) >Upgrade to 16.12.00.031 done (Bug 15108: OAI-PMH provider improvements) >DBD::mysql::st execute failed: Unknown column 'me.item_level_hold' in 'field list' [for Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`, `me`.`item_level_hold` FROM `reserves` `me` WHERE ( ( `found` = ? AND `priority` = ? ) )" with ParamValues: 0='W', 1=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. >DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.item_level_hold' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 209 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:13:57 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23265 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:13:57 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9834 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:50:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:50:27 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85787|0 |1 is obsolete| | --- Comment #269 from Julian Maurice --- Created attachment 91286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91286&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed 5. prove t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:50:19 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85786|0 |1 is obsolete| | --- Comment #268 from Julian Maurice --- Created attachment 91285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91285&action=edit Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 10:51:53 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:12:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 11:12:54 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72977|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 91287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91287&action=edit Bug 19809: Re-allow to call Koha::Objects::find in list context and remove 'scalar' keyword in calls where it's not needed. Also, fix Koha::Patron::guarantor which had the same problem as find Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 11:13:21 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 11:53:33 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Johanna R?is? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58611|0 |1 is obsolete| | CC| |johanna.raisa at koha-suomi.fi Status|Patch doesn't apply |Signed Off Assignee|olli-antti.kivilahti at jns.fi |johanna.raisa at koha-suomi.fi --- Comment #5 from Johanna R?is? --- Created attachment 91288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91288&action=edit Bug 17851 - Add elasticsearch config to koha-conf.xml Fixed to apply master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:54:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 11:54:34 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Johanna R?is? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58956|0 |1 is obsolete| | --- Comment #6 from Johanna R?is? --- Created attachment 91289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91289&action=edit Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log Fixed to apply master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:34:19 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20942 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:34:19 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15165 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:34:49 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #65 from Fridolin SOMERS --- Is this a duplicate of Bug 20942 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:56:51 +0000 Subject: [Koha-bugs] [Bug 23266] New: Add to cart fires twice on shelf page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23266 Bug ID: 23266 Summary: Add to cart fires twice on shelf page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Simple fix: opac-bottom.inc should do the work not opac-shelves itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:57:09 +0000 Subject: [Koha-bugs] [Bug 23266] Add to cart fires twice on shelf page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:57:55 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:57:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:57:57 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:57:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:57:58 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:58:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:58:00 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:58:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:58:03 +0000 Subject: [Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:57:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:57:53 +0000 Subject: [Koha-bugs] [Bug 21801] paycollect.pl should pass library_id when adding accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:59:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:59:25 +0000 Subject: [Koha-bugs] [Bug 23266] Add to cart fires twice on shelf page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 12:59:28 +0000 Subject: [Koha-bugs] [Bug 23266] Add to cart fires twice on shelf page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23266 --- Comment #1 from Marcel de Rooy --- Created attachment 91290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91290&action=edit Bug 23266: Add to cart fires twice on shelf page Remove some duplicate functionality between opac-bottom and opac-shelves. Test plan: [1] Before this patch, add to cart from a shelf page. Observe that the basket count is incremented with 2. [2] After this patch, it should be incremented with 1. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 15:06:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 13:06:46 +0000 Subject: [Koha-bugs] [Bug 23259] Remove reset-fonts-grids.css In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 15:09:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 13:09:18 +0000 Subject: [Koha-bugs] [Bug 23232] Enable the option to use the onscreen keyboard on the basic cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:15:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:15:40 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:27:52 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90689|0 |1 is obsolete| | --- Comment #9 from Andreas Jonsson --- Created attachment 91291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91291&action=edit Bug 23141: Add --dbport parameter to koha-create -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:28:45 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #10 from Andreas Jonsson --- Created attachment 91292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91292&action=edit Bug 23141: Parse mysql portnumber from /etc/mysql/koha-common.cnf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:31:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:31:48 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91157|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 91293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91293&action=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:31:45 +0000 Subject: [Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:32:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:32:34 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #11 from Andreas Jonsson --- The database connection details have three different purposes: 1. to create the database and database user 2. to set the connection details in koha-conf.xml and 3. to load data. There are five different sources for acquiring the connection details: 1. command line, 2. password file, 3. /etc/mysql/koha-common.cnf (if /etc/myslq/debian.cnf exists!?) 4. koha-conf.xml and 5. default values. So, to add support for port number we could: 1. Add command line parameter for portnumber 2. Add an optional field to the password file 3. Parse port number from /etc/mysql/koha-common.cnf 4. Add command line flag to select which source should have priority when loading data. But then there is also the question on how to prioritize which source should be used in what situation. For my particular use case I need to use the connection details of koha-conf.xml when populating the database. But when using the credentials from the instance configuration it would be better to call koha-mysql. I suggest adding the parameter --defaultsql-creds for this purpose. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:34:13 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #12 from Andreas Jonsson --- Updated testplan for devbox: * Change port of mariadb by adding the file /etc/mysql/conf.d/port.cnf with contents: [mysqld] port = 12345 * systemctl restart mariadb * edit /etc/koha/sites/kohadev/koha-conf.xml and change the elments hostname and port: 127.0.0.1 12345 * Test the scripts: sudo ~/kohaclone/debian/scripts/koha-mysql kohadev sudo ~/kohaclone/debian/scripts/koha-mysqlcheck kohadev sudo ~/kohaclone/debian/scripts/koha-dump kohadev * Make sure the template is installed in /etc/koha/koha-conf-site.xml.in (sudo cp $HOME/kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha) * Test koha-create using command line parameter: sudo $HOME/kohaclone/debian/scripts/koha-create --dbport 12345 --create-db test * Verify portnumber: sudo xmlstarlet sel -t -v 'yazgfs/config/port' "/etc/koha/sites/test/koha-conf.xml" * Test koha-create using configuration file: * Edit /etc/mysql/koha-common.cnf and add port = 12345 in section client. sudo $HOME/kohaclone/debian/scripts/koha-create --create-db test2 * Verify portnumber: sudo xmlstarlet sel -t -v 'yazgfs/config/port' "/etc/koha/sites/test2/koha-conf.xml" * Test koha-create using password file: * Edit /etc/koha/passwd and add a column with portnumber ':12345' sudo $HOME/kohaclone/debian/scripts/koha-create --create-db test3 * Verify portnumber: sudo xmlstarlet sel -t -v 'yazgfs/config/port' "/etc/koha/sites/test2/koha-conf.xml" * Test separate db population sudo $HOME/kohaclone/debian/scripts/koha-create --request-db test4 sudo mysqldump --defaults-file=/etc/mysql/koha-common.cnf koha_kohadev >/tmp/kohadev.sql mysqluser="$( sudo xmlstarlet sel -t -v 'yazgfs/config/user' /etc/koha/sites/test4/koha-conf.xml )" mysqlpass="$( sudo xmlstarlet sel -t -v 'yazgfs/config/pass' /etc/koha/sites/test4/koha-conf.xml )" sudo mysql --defaults-file=/etc/mysql/koha-common.cnf -e "CREATE DATABASE koha_test4; GRANT ALL ON koha_test4.* TO '$mysqluser'@'localhost' IDENTIFIED BY '$mysqlpass'" sudo ~/kohaclone/debian/scripts/koha-create --populate-db --defaultsql /tmp/kohadev.sql test4 * Test separate db population using instance credentials sudo $HOME/kohaclone/debian/scripts/koha-create --request-db test5 mysqluser="$( sudo xmlstarlet sel -t -v 'yazgfs/config/user' /etc/koha/sites/test5/koha-conf.xml )" mysqlpass="$( sudo xmlstarlet sel -t -v 'yazgfs/config/pass' /etc/koha/sites/test5/koha-conf.xml )" sudo mysql --defaults-file=/etc/mysql/koha-common.cnf -e "CREATE DATABASE koha_test5; GRANT ALL ON koha_test5.* TO '$mysqluser'@'localhost' IDENTIFIED BY '$mysqlpass'" sudo ~/kohaclone/debian/scripts/koha-create --populate-db --defaultsql --defaultsql-creds instance --dbport 1 /tmp/kohadev.sql test5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:34:50 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:39:09 +0000 Subject: [Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores -D In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:39:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:39:12 +0000 Subject: [Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores -D In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91056|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 91294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91294&action=edit Bug 21000: Force case sensitivity on Getopt::Long Before patch: -D and -d are mistaken for --debug $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" Option d does not take an argument git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "squeeze-dev" -v "19.06~git+20190627205913.466f99e4-1" "Building git snapshot." dch warning: Recognised distributions are: experimental, unstable, testing, stable, oldstable, oldoldstable, {bullseye,buster,stretch,jessie,wheezy}-proposed-updates, {testing,stable,oldstable,oldoldstable}-proposed-updates, {bullseye,buster,stretch,jessie,wheezy}-security, {testing,stable,oldstable,oldoldstable}}-security, jessie-backports, stretch-backports and UNRELEASED. Using your request anyway. NOTE: squeeze-dev in the first dch line and warning about Option d. Apply patch: -D and -d are differentiated correctly. $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "stretch" -v "19.06~git+20190627210316.b3f919a7-1" "Building git snapshot." dch warning: Previous package version was Debian native whilst new version is not dch -r "Building git snapshot." NOTE: No more 'Option d' error, and "stretch" in the first dch line. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 19:39:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 17:39:46 +0000 Subject: [Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores -D In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 --- Comment #6 from Tom?s Cohen Arazi --- Good catch, Mark. This always bothered me and didn't find the time to dig into the solution. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:01:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:01:14 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from M. Tompsett --- Frederik seems to have forgotten to set the status to signed off. My former comments were addressed. Fixing status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:11:21 +0000 Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:17:23 +0000 Subject: [Koha-bugs] [Bug 22951] Markup error in OPAC holds template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:17:26 +0000 Subject: [Koha-bugs] [Bug 22951] Markup error in OPAC holds template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91018|0 |1 is obsolete| | Attachment #91019|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 91295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91295&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:17:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:17:29 +0000 Subject: [Koha-bugs] [Bug 22951] Markup error in OPAC holds template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 --- Comment #4 from M. Tompsett --- Created attachment 91296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91296&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:55:10 +0000 Subject: [Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 --- Comment #7 from M. Tompsett --- Comment on attachment 91033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91033 Bug 23221: (follow-up) Add comments on markup structure Review of attachment 91033: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23221&attachment=91033) ----------------------------------------------------------------- I don't understand the insertion of /'s in the comments. ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +276,4 @@ > > [% END %] > > + [% END #/ IF did_commit %] I would expect "# /" for consistency, but as a comment it doesn't really matter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:56:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:56:25 +0000 Subject: [Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett --- # really force master to be latest before. git checkout master git pull git reset --hard origin/master cat koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | tr -d [:space:] > before.txt git checkout -b bug_23221 origin/master git bz apply 23221 # interactive and apply just the first patch cat koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | tr -d [:space:] > after.txt diff before.txt after.txt # should be no differences # didn't use git diff -w origin/master, because too much scroll. rm before.txt after.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:56:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:56:59 +0000 Subject: [Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:57:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:57:05 +0000 Subject: [Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 --- Comment #10 from M. Tompsett --- Created attachment 91298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91298&action=edit Bug 23221: (follow-up) Add comments on markup structure This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 20:57:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 18:57:02 +0000 Subject: [Koha-bugs] [Bug 23221] Reindent tools/manage-marc-import.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23221 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91032|0 |1 is obsolete| | Attachment #91033|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 91297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91297&action=edit Bug 23221: Reindent tools/manage-marc-import.tt This patch reformats the template for the Manage staged MARC records page. It makes only whitespace changes. It should have no effect on the behavior of the page. In addition to re-indentation, some lines have been broken up. These should be the only changes highlighted when using diff while ignoring whitespace. To test, apply the patch and view the Manage staged MARC records page. The page should look correct and work correctly: - Paging through results - Viewing batches - Cleaning batches - Deleting batches Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 21:09:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 19:09:56 +0000 Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Quick question about & vs & and HTML vs XML validation with respect to the removal of CDATA in acquisitions-toolbar.inc? Are we ever validating as XML or XHTML? If not, okay. If so, then why remove CDATA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 21:16:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 19:16:11 +0000 Subject: [Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 21:16:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2019 19:16:13 +0000 Subject: [Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91054|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 91299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91299&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from