[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #18 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Katrin Fischer from comment #17)
> please also take a look at:
> bug 23233
> bug 23223
> and bug 7090 (which suggests that this was for SIP initially)

Mhm, okay so in #23233 Kyle says the AllowItemsOnHoldCheckout affects only SIP
based checkouts which is almost true but not quite there because of one
additional usage in the "has_pending_hold" function. If we get rid of the usage
in "has_pending_hold" function then IMHO it would okay to merge
AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO together since they
are both self-checkouts. That lead me to the question why in #15131 this new
syspref AllowItemsOnHoldCheckoutSCO was even introduced? Didn't the bug
reporter just know because of the wrong documentation (as Jonathan points out
in the report) that the AllowItemsOnHoldCheckout would have worked also in the
situation described in the report?

-- 
You are receiving this mail because:
You are watching all bug changes.