[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jul 1 11:27:49 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Joonas Kylmälä from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > please also take a look at:
> > bug 23233
> > bug 23223
> > and bug 7090 (which suggests that this was for SIP initially)
> 
> Mhm, okay so in #23233 Kyle says the AllowItemsOnHoldCheckout affects only
> SIP based checkouts which is almost true but not quite there because of one
> additional usage in the "has_pending_hold" function. If we get rid of the
> usage in "has_pending_hold" function then IMHO it would okay to merge
> AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO together since they
> are both self-checkouts. That lead me to the question why in #15131 this new
> syspref AllowItemsOnHoldCheckoutSCO was even introduced? Didn't the bug
> reporter just know because of the wrong documentation (as Jonathan points
> out in the report) that the AllowItemsOnHoldCheckout would have worked also
> in the situation described in the report?

I think better to keep them separate - both are self checks, but... libraries.
There might be a use case that we are not aware of right now.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list