[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Joonas Kylmälä from comment #2)
> The syspref affects also the code in Koha/Item.pm, function
> "has_pending_hold". I believe it gets indirectly used in opac/intranet so we
> can't do this by simply renaming.

The one and only use of this method is in
koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc so supressing the
pending hold status here based on the system preference should be considered
buggy behavior as well! I'll file a followup to remove the use of the syspref
for that method.

-- 
You are receiving this mail because:
You are watching all bug changes.