[Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Tomás Cohen Arazi from comment #0)
> This method is to be run inside plugin objects that inherit from
> Koha::Plugins::Base, but calling
> 
>   $self->_version_compare();
> 
> won't work because the method doesn't expect $self to be passed.

We should make it work either way since historically it has been non-OO and
there are some plugins that may be using it in a non-OO way. I think ti should
be easy to check the first parameter to know if it is being called as an object
method or not!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.