[Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |mtompset at hotmail.com

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
prove -v t/integration/auth/
t/integration/auth/cas.t ....... 
1..2
# Subtest: intranet
    1..10
[Tue Jul  2 05:13:43 2019] [debug] GET "/cgi-bin/koha/mainpage.pl"
[Tue Jul  2 05:13:43 2019] [debug] Routing to a callback
A context appears to have been destroyed without first calling release().
Based on $@ it does not look like an exception was thrown (this is not always
a reliable test)

This is a problem because the global error variables ($!, $@, and $?) will
not be restored. In addition some release callbacks will not work properly from
inside a DESTROY method.

Here are the context creation details, just in case a tool forgot to call
release():
  File: t/integration/auth/cas.t
  Line: 74
  Tool: Test::More::subtest

Cleaning up the CONTEXT stack...
# Test ended with extra hubs on the stack!
    # No tests run!
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests 
t/integration/auth/password.t .. 
1..2
# Subtest: intranet
    1..10
[Tue Jul  2 05:13:46 2019] [debug] GET "/cgi-bin/koha/mainpage.pl"
[Tue Jul  2 05:13:46 2019] [debug] Routing to a callback
A context appears to have been destroyed without first calling release().
Based on $@ it does not look like an exception was thrown (this is not always
a reliable test)

This is a problem because the global error variables ($!, $@, and $?) will
not be restored. In addition some release callbacks will not work properly from
inside a DESTROY method.

Here are the context creation details, just in case a tool forgot to call
release():
  File: t/integration/auth/password.t
  Line: 58
  Tool: Test::More::subtest

Cleaning up the CONTEXT stack...
# Test ended with extra hubs on the stack!
    # No tests run!
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests 

Test Summary Report
-------------------
t/integration/auth/cas.t     (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 2 tests but ran 0.
t/integration/auth/password.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 2 tests but ran 0.
Files=2, Tests=0,  5 wallclock secs ( 0.02 usr  0.00 sys +  4.16 cusr  0.59
csys =  4.77 CPU)
Result: FAIL


-- confirmed the same problem in comment #2, marking Failed QA. Though, I don't
know if it is this patch, or the one it depends on, that is the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.