[Koha-bugs] [Bug 23219] Prevent patron delete if holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at outlook.com
                   |ity.org                     |

--- Comment #4 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 91175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91175&action=edit
Bug 23219: Cancel patrons holds when patron delete

Currently deleting a patron deletes all their holds and leaves
no record to the "old_reserves" table.

 Steps to reproduce:
- Create a patron
- Add holds for patron
- Holds are recorded to "reserves" table
- Delete patron
- Confirm delete
=>Patron and all holds are deleted and no record of holds is
left in "old_reserves" table

This patch displays alert text notifying user that deleting patron
cancels all their holds. Holds are cancelled instead of deleting them.
This patch also writes stringified datetime to holds cancel log instead
of whole datetime object.

To test:
- Apply this patch
- Create a patron
- Add holds for patron
- Holds are recorded to "reserves" table
- Delete patron
- Alert text of holds is displayed
- Confirm patron delete
=> Patron is deleted, their holds are cancelled and moved to
"old_reserves" table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.