[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 2 20:09:22 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Kyle, the patches look correct and actually solve the specific use case you are
tackling. BUT...

$ git grep AddRenewal

shows there are some places in which the branchcode is still calculated outside
and passed:

Koha/REST/V1/Checkouts.pm
circ/renew.pl
misc/cronjobs/automatic_renewals.pl
svc/renew

also some tests, but I guess they are mocking userenv to match what they pass
as parameter, and that's why they are still green.

In some cases it might make sense to use userenv (maybe the staff controllers),
but I'm not sure (haven't checked) if there is an override available on the UI
to allow specifying the branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list