[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 3 02:19:05 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #87 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 91198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91198&action=edit
Bug 1985: (follow-up) Fix Reviews.t logic

Read the tests to make sure they make sense.
Before the patch is applied, they don't.

$nb_of_approved_reviews + 2 did not make sense, because the three
reviews added were not approved.
search->count counts everything, so the use of approved+3 didn't
make sense.
Rather than duplicate the search->count test, changed the
first one to reflect that the added reviews were all unapproved.

Before applying patch, prove fails.

After applying patch, prove passes.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list