[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 3 05:27:51 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 91158
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158
Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl

Review of attachment 91158:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23247&attachment=91158)
-----------------------------------------------------------------

::: opac/opac-MARCdetail.pl
@@ +305,4 @@
>      push @item_loop, $item if $item;
>  }
>  my ( $holdingbrtagf, $holdingbrtagsubf ) =
> +  &GetMarcFromKohaField( "items.holdingbranch", $biblio->frameworkcode );

If you are refactoring, while I would prefer to keep framework code in, so as
to allow weird and wonderful things in the future (UNIMARC and MARC21
co-existing), the function has already been neutered. So perhaps a refactor on
this and other uses of this function here would be in order?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list