[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to M. Tompsett from comment #2)
> Comment on attachment 91158 [details] [review]
> Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl
> 
> Review of attachment 91158 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: opac/opac-MARCdetail.pl
> @@ +305,4 @@
> >      push @item_loop, $item if $item;
> >  }
> >  my ( $holdingbrtagf, $holdingbrtagsubf ) =
> > +  &GetMarcFromKohaField( "items.holdingbranch", $biblio->frameworkcode );
> 
> If you are refactoring, while I would prefer to keep framework code in, so
> as to allow weird and wonderful things in the future (UNIMARC and MARC21
> co-existing), the function has already been neutered. So perhaps a refactor
> on this and other uses of this function here would be in order?

Hi Marc, 

resetting status - this is only a clan-up, the parameter frameworkcode for
GetMarcFromKohaField does no longer exist. See bug 22721 for some more info.

-- 
You are receiving this mail because:
You are watching all bug changes.