[Koha-bugs] [Bug 23018] Refunding a lost item fee may trigger error if any fee has been written off related to that item

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23018

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90640|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 91330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91330&action=edit
Bug 23018: Refunding a lost item fee may trigger error if any fee has been
written off related to that item

If a lost item fee is written off, it creates a writeoff with the same
itemnumber but the amount column is a negative number.

Now, when the lost item is returned, it calls _FixAccountForLostAndReturned
which searchs for all accountlines with an account type of 'L' or 'W'.

Then, if the *first* of those lines has an outstanding balance, a credit is
created and *all* the lines found are passed to $credit->apply. The apply
method then calls is_debit on each line and when it hits the writeoff, it
throws an exception ( Koha::Exceptions::Account::IsNotDebit ).

When this happens, the credit is creating but not applied the the outstanding
lost item fee, and the librarian is presented with an error page.

It seems like the solution is to only fetch the first result since it seems
like that is the only one we should be operating on.

Test Plan:
1) Create a lost item with a fee
2) Create a manual debit using the barcode of the item
3) Write off that manual debit
4) Check in the item, note the error
5) Apply this patch
6) Repeat steps 1-3
7) Check in the item, no error!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.