[Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 10 05:59:29 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 91436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91436&action=edit
Bug 23291: Find patrons by smsalertnumber in the batch patron modification

Add ability to paste in sms numbers (one per line) or upload a file of
sms numbers and find patrons with matching smsalertnumber values.

If an sms number is not found then this is displayed in a yellow box to
the librarian i.e. the batch patron modification tool will behave as it
does currently when a cardnumber is not found.

Test plan:
1. Go to Tools > Batch patron modification

2. Notice there is a file upload (for cardnumbers) and a text input area
(for cardnumbers)

3. Apply patch and restart memached and plack

4. Refresh the page and notice a file upload (for sms numbers) and file
text input area (for sms numbers) have been added

5. Create a file with valid sms numbers matching smsalertnumber values
of patrons (one per line)

6. Select/upload the file into the sms number file upload and submit the
form

7. Notice the patrons are found and you can batch modify them. Select a
date in the 'Restriction expiration' datepicker and submit and notice
this is added to the selected borrowers in the borrowers.debarred,
borrowers.debarredcomment fields and borrower_debarment table.

8. Create a file with some valid and some invalid sms numbers (i.e. some
smsnumbers belonging to patrons in their smsalertnumber field and some
not matching)

9. Upload your file from 8 in the SMS number file upload and notice that
error handling means the invalid/non-matching sms numbers are shown
below the yellow box at the top of the page whilst matching sms numbers
have returned patrons which you can edit

10. Confirm card number file upload still works by making a file of
valid cardnumbers and uploading it in the Batch patron modification tool
and noticing the patrons are successfully returned

11. In the batch patron modification tool paste valid sms numbers into the sms
number text area input (0ne
per line) and submit the batch patron modification. Notice that the
patrons are successfully returned and displayed.

12. Repeat step 11 but this time paste in valid and invalid sms numbers
and notice error handling means sms numbers which did not match
borrowers, smsalertnumber are shown under the yellow box at the top of
the page and patrons who matched sms numbers are shown below in the
table

13. Repeat step 11 this time input only invalid sms numbers and submit.

Notice that a page showing the yellow notice box and a list of all
smsnumbers which could not be found are returned.

14. Repeat step 11 submitting valid smsnumbers in the cardnumber text area
field and you will
notice that  a page showing the yellow notice box and a list of all non
matching cardnumbers.

15. In your Koha home directory run: sudo koha-shell <instancename>

Then run: prove xt

16. Confirm all test pass

17. Sign off

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list