[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #26)
> Comment on attachment 91326 [details] [review]
> Bug 23057: (QA follow-up) Stay closer to old code
> 
> I agree with Liz of course ;)
> 
> The old code is messy and confusing. I put a lot of thought into the changes
> I made to make the code clean, terse and understandable. I don't think we
> should put back bad code just for the sake of leaving it unchanged in this
> case. There is very real benefit to the new code consolidating logic for the
> benefit of future developers who have to deal with this code.

No problem. But in that case it may not harm to have another QAer look at it
too. Thanks for your feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.