[Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #30 from M. Tompsett <mtompset at hotmail.com> ---
This is called in C4::Members::patronflags
-- this function has been deprecated, and is only used in C4::SIP::ILS::Patron.
And while I would think it should be:
    my $flags     = C4::Members::patronflags( $kp->{borrowernumber} );
Fixing that is not in this scope. And because borrowernumber is magically
determined, checkoverdues doesn't just return, which is the problem this bug
addresses.

In fact, looking at the other few places that call checkoverdues, it is clear
that it should always be called with a borrower number. So while is a valid
fix, there is no way to test it short of adding a test. That, a new test, will
be the next attachment. :)

-- 
You are receiving this mail because:
You are watching all bug changes.