[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Nadine and Nick, 

Thanks for taking the time to test/look at my patches.

I've done the following in the follow-up patch I've just attached in response
to your notes in comment #4 Nick:

Re. point 1. 

* Renamed the syspref so it has a name more relevant to what it does:
RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult

* Set the preference to OFF by default so if the library wants the behaviour
change they have to actively enable it. 

Re. point 2. 

* As the syspref has been renamed to reflect that it doesn't block unlinked
patrons from being set as guarantors this should be 
resolved now. Having said that it could be a good idea in the future to block
unlinked patrons from being set as guarantors in
another bug report in the future. 

Re. point 3. 

* When the aforementioned syspref is enabled then the contactname,
contactfirstname and relationship are set to NULL upon a guarantee being
updated to a guarantor via members/update-child.pl or members/memberentry.pl

Can you please retest?

Cheers,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.