[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 23 15:12:23 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
I definitely agree. we should move this to a module and test it, however, this
code has problems:
1 - It gets data that is not grouped so breaks under strict mode
2 - All our tests enforce strict mode
3 - It should be refactored or reworked to use DBIC and objects instead of
straight SQL

The fix here is relatively minor, the work you are asking for is more intense
and will involve likely changing the report and its output and should be
another report. Let's fix providing the wrong data

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list