[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jul 26 17:41:31 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91198|0                           |1
        is obsolete|                            |

--- Comment #93 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 91823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91823&action=edit
Bug 1985: (follow-up) Fix Reviews.t logic

Read the tests to make sure they make sense.
Before the patch is applied, they don't.

$nb_of_approved_reviews + 2 did not make sense, because the three
reviews added were not approved.
search->count counts everything, so the use of approved+3 didn't
make sense.
Rather than duplicate the search->count test, changed the
first one to reflect that the added reviews were all unapproved.

Before applying patch, prove fails.

After applying patch, prove passes.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list