From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 05:46:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 03:46:58 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #16 from Nabila --- The patch works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 19:06:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 17:06:04 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 --- Comment #7 from Christopher Brannon --- (In reply to Johanna R?is? from comment #6) > Lot of work for closing a library for a period of time. Could this be only a > single preference in libraries, probably the easiest way than try to add > this to calendar? That was one of the suggestions in the first comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 19:33:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 17:33:13 +0000 Subject: [Koha-bugs] [Bug 23030] New: Install Date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23030 Bug ID: 23030 Summary: Install Date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Would like to see the install date (or last upgrade date, or both) in About. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 22:30:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 20:30:37 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #17 from Jonathan Druart --- (In reply to Nabila from comment #16) > The patch works. You should not need this patch to have Koha working correctly. You will certainly face other problems. By any chances, could you sign the patch off? https://wiki.koha-community.org/wiki/Sign_off_on_patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 22:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 20:33:54 +0000 Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #12 from Jonathan Druart --- Jenkins is failing randomly with this error: koha_1 | # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1477. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 4. koha_1 | koha_1 | # Failed test 'BorrowersLog tests' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1478. koha_1 | # Looks like you failed 1 test of 39. koha_1 | [21:28:37] t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 22:34:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 20:34:03 +0000 Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 22:34:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 20:34:31 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Second prove of |Koha/Patrons.t is failing |Koha/Patrons.t fails on |randomly on test |test BorrowerLogs and |BorrowerLogs and |TrackLastPatronActivity |TrackLastPatronActivity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 23:12:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2019 21:12:51 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #13 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Jenkins is failing randomly with this error: Beware that run was launched with COVERAGE=yes, so a very allow run -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:59:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 07:59:30 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 --- Comment #6 from Katrin Fischer --- Hm, this is a little strange - patch applies cleanly for me. Just uploading it again to make sure! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:59:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 07:59:52 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89619|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 90262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90262&action=edit Bug 14669: Add search option for managing library to orders search Currently the order search can't be limited by managing library. The patch adds the search option to the order history search form and a column for the managing library to the search results table. To test: - Create some baskets with orders - Set managing library for some, but also have some without - Apply patch - prove t/db_dependent/Acquisition.t - Go to Aquisition > Orders search tab on top > Advanced search link - Search for orders without limiting Orders with and without managing library set should show up - Limit search to a specific managing library - Verify results match expectations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:00:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:00:03 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:16:50 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #155 from Katrin Fischer --- Hi David, 1) Documentation https://gitlab.com/gnucifer/koha-manual/commit/593c5da008dbc4b074cac9dee167cce9a6dfc250#c5e2c75dc923f21c5b95185b2f350df00fec661f Thanks a lot, this documentation is SO helpful. We really couldn't have continued without as the feature is quite complex. 2) GUI - Terminology and translatability One thing that bothers me is that the GUI is a big 'rough'. I'd much prefer if it was using better terms/descriptions like in the help instead of 'codes'. bachmod = Bach record modification intranet = Cataloging module (unles it inlcudes batchmod?) batchimport = Staged MARC import etc. batchmarcimport = Cronjob batchmarcimport.pl (I hope I got them right) Experience tells that those are likely to get translated strangely or might not be translatable at all. 3) Over-granularity? Another thing that bothers me is a bit is the granularity. Being able to limit to specific patrons seems a little overkill? Especially since the interface expects borrowernumbers to be entered? (borrower = patron) Is there a use case for this? 4) marc_merge_rules_modules I am still quite suspicious of this one. We should not add descriptions to the database ever (translatability) - and this currently won't work for new installations. Can you please consider moving the modules to the templates instead and checking if this table is really needed as is? Or explain to me? At the moment the patch set doesn't apply. - I am really interested in the feature, just feel right now that it's an old development that still needs a bit of love. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:17:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:17:00 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:22:56 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #80 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #79) > (In reply to Jonathan Druart from comment #78) > > 1. Only one occurrence of passwordlengthhint > > koha-tmpl/intranet-tmpl/prog/css/installer.css:#passwordlengthhint > > > > 2. Do we really need the warning when adding/editing a patron? > > BTW, $warning is not needed, memberentry.pl > > 177 my $warning = 1; > > 178 $template->param("passwordwarning"=>$warning); > > > > 3. Just a though, next time we add a "step" we will need to rethink the > > template. The shift is terrible. And hard to see the real changes. > > > > Not passing QA for 2, waiting for another QA point of view. > > I would suggest to squash some patches, getting rid of merge marker stuff > and warnings etc. > In general, I would not favor putting more prefs inside onboarding. Keep it > simple. This change can be made without changing onboarding. I tend to agree with Marcel and Jonathan here. I am not sure if we should add this to the installer as it adds a lot more to read for little gain (slows down the process). I think instead, why not just set it to at least 8 by default? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:29:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:29:20 +0000 Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Kelly, I think your request is a bit different to Lisette's. I see Lisette's feature more like the additional fields for subscriptions and baskets, while yours sounds more like BorrowerUnwantedFields. It might be good to split this into 2 bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:30:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:30:05 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:30:06 +0000 Subject: [Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Bug 22800 depends on bug 22550, which changed state. Bug 22550 Summary: OPAC suggestion form doesn't require mandatory fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:35:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:35:50 +0000 Subject: [Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21329 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:35:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:35:50 +0000 Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 14049 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:38:30 +0000 Subject: [Koha-bugs] [Bug 23031] New: Improve UX of buttons on order search page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Bug ID: 23031 Summary: Improve UX of buttons on order search page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When the change for bug 21364 was made, there as some discussion about what buttons should be accessible immediately and what should be hidden in the menu. Owen's last suggestion was: The "View" part of the split button is an unnecessary duplication of the linked basket name earlier in the table. I think the actions column should have two possible buttons: "Add to basket" and "Close basket." Maybe we could implement this? As I understand it, we would remove the view part which would leave us with 2 (or 3: uncertain prices instead of close basket) buttons that show outside of a menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:38:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:38:36 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 lulihua at ibwya.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lulihua at ibwya.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:38:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:38:37 +0000 Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 [Bug 21364] Allow closing basket from vendor search/view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:38:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:38:37 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 [Bug 23031] Improve UX of buttons on order search page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:39:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:39:15 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #33 from Katrin Fischer --- I've moved the discussion about the buttons onto a new bug 23031. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:40:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:40:26 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #24 from Katrin Fischer --- (In reply to Liz Rea from comment #23) > I think I agree, pub date searches should use the 008, but non-marc > libraries coming to Koha might not know how to use the 008 and that... kind > of frightens me. But they might also not add useful data to 260/264... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:44:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:44:13 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #3 from lulihua at ibwya.net --- Koha18.11.05.000 on Debian 9.9 and MariaDB10.1.38 has the same issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:46:49 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #4 from lulihua at ibwya.net --- $ sudo koha-remove klib Removing Koha instance klib ERROR 1133 (28000) at line 1: Can't find any matching row in the user table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:51:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:51:48 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:51:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:51:51 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 --- Comment #3 from Katrin Fischer --- Created attachment 90263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90263&action=edit Bug 22770: Fix typo in German language description of el Fixes: Griechisch (Moern [1453- ] ==> Griechisch (Modern 1453-) To test: - Install de-DE language and activate it - Check the language pull down on advanced search has the typo - Apply patch and run database update - Check advanced search again - Verify the description now shows correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:52:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:52:25 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:53:24 +0000 Subject: [Koha-bugs] [Bug 22958] Clicking on the HELP button when in SMS providers- does not bring user to that portion in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:53:29 +0000 Subject: [Koha-bugs] [Bug 22958] Clicking on the HELP button when in SMS providers- does not bring user to that portion in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:59:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 08:59:42 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking on the HELP button |The Help link on SMS |when in SMS providers- does |providers page should link |not bring user to that |to the correct chapter in |portion in the manual |the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:02:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:02:19 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:02:22 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 --- Comment #1 from Katrin Fischer --- Created attachment 90264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90264&action=edit Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:19:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:19:01 +0000 Subject: [Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #9 from Katrin Fischer --- Created attachment 90265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90265&action=edit Bug 22960: (follow-up) Fix another tiny typo This only seems to appear in the .pref file: ...pairs. the => ... pairs. The -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:22:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:22:19 +0000 Subject: [Koha-bugs] [Bug 22961] Allow special characters in password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Amit, can you explain this bug a bit more please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:24:17 +0000 Subject: [Koha-bugs] [Bug 22984] Holding branch disappears after saving to course and isn't restored when removing item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Course Reserve Item |Holding branch disappears |Location Disappears after |after saving to course and |saving to course |isn't restored when | |removing item from course -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:27:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:27:53 +0000 Subject: [Koha-bugs] [Bug 22984] Holding branch disappears after saving to course and isn't restored when removing item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- Hi Jessie, I just tested this on master and can't replicate the problem. Can you confirm this is still a problem in 18.05 or later? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:35:13 +0000 Subject: [Koha-bugs] [Bug 3567] Display Alternate Graphic Representation (MARC21 880) in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:35:13 +0000 Subject: [Koha-bugs] [Bug 23032] New: Add 264 to Alternate Graphic Representation (MARC21 880) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 Bug ID: 23032 Summary: Add 264 to Alternate Graphic Representation (MARC21 880) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 3567 Target Milestone: --- The 880 field containing information from 264 is not displayed in the OPAC and intranet detail pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3567 [Bug 3567] Display Alternate Graphic Representation (MARC21 880) in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 11:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 09:36:08 +0000 Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:32:50 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:32:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:32:53 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90257|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 90266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90266&action=edit Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:33:27 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Maybe something for another day/bug: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc OK filters FAIL forbidden patterns forbidden paattern: Contains old bootstrap style for buttons (see bug 16239) (line 93) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:37:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:37:31 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:37:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:37:35 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90259|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 90267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90267&action=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:37:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:37:53 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- That's a lot of sign-offs! Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:40:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:40:41 +0000 Subject: [Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 15:40:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 13:40:44 +0000 Subject: [Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90261|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 90268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90268&action=edit Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 16:01:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 14:01:45 +0000 Subject: [Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to modify hold dates |Allow to modify hold and |on reserve/request.pl |hold expiration date in | |staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 16:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 14:09:51 +0000 Subject: [Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- This patch does a bit more than I thought - apart from changing the hold date, it also allows to change the expiration date. I think while the first should be controlled by the AllowHoldDateInFuture, the expiration date should not as it's already available to be set in the table now. Note: the expiration date has a double use, it's used to say: - Patron: I don't need this after... and also: - Library: Hold needs to picked up until ... Can you please change? I am not sure about the consequences of this change. I think the date pickers are a bit too wide in the table. Adding Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 17:12:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 15:12:35 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #59 from Katrin Fischer --- First of all: I like this! Some findings while testing: 1) Use the TT Asset plugin instead: [% IF ( Koha.Preference('OPACSuggestionAutoFill') ) %] [% END %] 2) Style question :) (non-blocker) [% IF NOT Koha.Preference( 'OPACSuggestionAutoFill' ) %] Why not UNLESS? Just hadn't seen this before! 3) The jQuery plugin Wondering about the Javascript file included here. I think right now it's the biggest issue for me. It's labelled "jquery autofill plugin", but it appears to be unrelated to the existing one or has been changed so much I am not seeing the relationship anymore: https://plugins.jquery.com/autofill/ Maybe this should be renamed as it's now a plugin dealing with the Google API specifically and no longer a generic one and the note be removed to avoid confusion? I also think that Jonathan's comment 18 is still valid. If we only need it on one page, it would make sense to only include it there. I think we also really need to figure out the license situation here. My guess right now is that Martin is the author. We don't usually add the authors/licenses for js files written for Koha that live in bootstrap/js, so maybe this is mostly about removing the confusing comment/making sure this was written for Koha and is not a general plugin. Adding Owen. 4) Pref description should mention this is about the suggestion form :) 5) It would be nice if the error message didn't appear as another button (and if the Google Search button was more clearly formatted as a button) (non-blocker)(In reply to Chris Cormack from comment #7) 6) Copyright date / Publication year > > And lastly, not a problem but a question: In my test copyright date is never > > populated. Is that a bug or a problem with Google Books' data? > > Yes, Google books API only hands back publication date, not copyright date. I think it might make sense to use this in the field. While technically not the same, we use both in Koha often for the same thing. This is one of the forms using copyright date, but in other places it will be publication year. And it all goes into the same fields when creating a record from it. The year would be helpful I think. (I'd even go as far to say we should relabel the form, because I doubt copyright date has meaning to users) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 17:12:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 15:12:43 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 17:14:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 15:14:02 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #60 from Katrin Fischer --- > ..., because I doubt copyright date has meaning to users) I meant: people! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 17:26:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 15:26:49 +0000 Subject: [Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 --- Comment #2 from Pablo AB --- Shouldn't always newer bugs marked duplicated of older ones, instead of the other way around? At least unless the newer have much more info. Marking older bugs duplicate of newer ones give the wrong impression that this request is recent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 17:27:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 15:27:44 +0000 Subject: [Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #16 from Katrin Fischer --- Blocked by dependency bug 20388 awaiting sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 17:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2019 15:34:56 +0000 Subject: [Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 --- Comment #3 from Katrin Fischer --- (In reply to Pablo AB from comment #2) > Shouldn't always newer bugs marked duplicated of older ones, instead of the > other way around? At least unless the newer have much more info. > > Marking older bugs duplicate of newer ones give the wrong impression that > this request is recent. You are right Pablo that this is the general rule. Tbh, I was not sure if this was active and picked the other for the recent activity on it. It sure is debatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 07:18:25 +0000 Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 07:49:10 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 --- Comment #8 from Magnus Enger --- (In reply to Magnus Enger from comment #5) > (In reply to Christopher Brannon from comment #4) > > Checking to see whatever came of this. :) > > Thanks for checking! :-) I have been working on this, but I started out in > the wrong direction so things have taken longer than expected. I should probably say that I never got any useful results for this, and I am not working on it any longer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 07:49:22 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|magnus at libriotech.no |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 08:17:05 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #17 from Josef Moravec --- (In reply to Agust?n Moyano from comment #16) > (In reply to Tom?s Cohen Arazi from comment #15) > > (In reply to Agust?n Moyano from comment #14) > > > (In reply to Josef Moravec from comment #13) > > > > Just one question: > > > > > > > > why are all the language and layout files added to the codebase, when you > > > > need only the ones named all.js? > > > > > > Hi Josef, all.js is constructed by concatenating all js files.. > > > > > > So, if you want to modify one language, or add a new one you should: > > > > > > 1. remove all.js > > > 2. place the new file in that directory (or modify an existing file) > > > 3. cat *.js > all.js > > > > Agustin, I think Josef's question is if we really need to ship those files > > with the project, or we can just remove them to save space. > > If modifications from layout / languages are required, it would be rather > inconvenient to have to import those files, make the adjustments and remove > them... > > I'm not sure which is best.. > > To make modifications, surely the most convenient option is to have those > files, but it's clear there are a lot of files.. > > maybe we could have a separate repo somehow and import / copy the resultant > all.js But why don't to contribute back to Mottie Keyboard? Also, these files are minified, I don't think anybody would like to edit minified files... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:32:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 08:32:31 +0000 Subject: [Koha-bugs] [Bug 20313] Article requests: Can we do without the processing notice ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:32:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 08:32:41 +0000 Subject: [Koha-bugs] [Bug 20313] Article requests: Can we do without the processing notice ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:35:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 08:35:29 +0000 Subject: [Koha-bugs] [Bug 22961] Allow special characters in password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22961 --- Comment #2 from Amit Gupta --- Hi Katrin, Right now password generate taking only Uppercase, lowercase and numbers. We are planning to add password generation with special character to make more strong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 08:50:35 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:33:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 10:33:42 +0000 Subject: [Koha-bugs] [Bug 22037] regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Jonathan, First, does the patch you've attached here fix a bug? If so, we should probably get it onto a fresh bug report. Second, since the behavior we want *is* new, we need to add a sip2 parameter for it. Do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 11:19:25 +0000 Subject: [Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |martin.renvoize at ptfs-europe | |.com --- Comment #16 from Martin Renvoize --- I'd love to see a selenium test to cover this to repent future regressions... and do we need to submit corresponding bugs for Unimarc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 13:11:50 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #13 from Andrew Isherwood --- Slightly revised test plan: - Apply patch - Update database and schema - Create a report using the following SQL in order to verify that notices are being generated: SELECT borrowernumber, subject, content, message_transport_type, to_address, from_address FROM message_queue WHERE letter_code LIKE 'ILL%' ORDER BY message_id DESC - Create one or more "partners". These are patrons that belong to a patron category that has a code that matches the value in your koha-conf.xml (default is ILLLIBS). Patrons in this category must have a primary email defined. Patrons defined in this way are offered as request partners within the ILL interface. - Go to "Koha administration", search for "IllLog" syspref, ensure it is set to "Log" SYSTEM PREFERENCES AND BRANCH CONFIG - In the staff interface, go to Tools > Notices & Slips => TEST: Observe that there are 5 new notices defined for the "Interlibrary loans" module - Go to "Koha administration" > "Libraries" - Choose a library and "Edit" it => TEST: Observe there is a new "ILL staff email" field - Enter an email address in the "ILL staff email" field and save the branch - Go to "Koha administration" > search for the "ILLDefaultStaffEmail" syspref => TEST: Observe the new syspref exists - Enter an email address in this syspref and then save it - Go to "Koha administration" > search for the "ILLSendStaffNotices" syspref => TEST: Observe the new syspref exists - Enter the names of the two staff notices in this syspref as "ILL_REQUEST_CANCEL|ILL_REQUEST_MODIFIED" and save the syspref PATRON MESSAGING PREFERENCES - Go to a patron's messaging preferences => TEST: Observe that two new messaging preferences exist, "Interlibrary loan ready" & "Interlibrary loan unavailable" - Select email and/or SMS for each of these notices SENDING PATRON NOTICES FROM ILL REQUEST - In the staff interface, go to "ILL requests" - Create an ILL request using the FreeForm backend (for the user you just modified the messaging preferences for), select the branch that you previously added the "ILL staff email" address to - Go to the "Manage ILL request" screen for the newly created request => TEST: Observe that there is a new "Send notice to patron" dropdown in the button bar which offers two notices to send - Select a notice to be sent => TEST: Observe that a message reporting the successful queueing of the notice is displayed - Click on the "ILL request log" for the request => TEST: Observe that a log entry "Patron notice sent:" was added to the log - Run the report created earlier => TEST: Observe that a notice was created for all sending methods selected in the patron's messaging preferences => TEST: Observe that the borrowernumber column of the notice is populated SENDING REQUEST TO PARTNERS - Go to the "Manage ILL request" screen for a request - Choose "Place request with partners" => TEST: Observe that the text defined in the ILL_PARTNER_REQ notice is displayed and can be modified - Select one or more partners that were defined earlier, then click "Send email" => TEST: Observe that the request's status has changed to "Requested from partners" - Run the report created earlier => TEST: Observe that a notice was created for each selected partner => TEST: Observe that the to_address column matches the primary email address for the partner => TEST: Observe that the from_address matches the previously defined "ILL staff email" for the request's branch PATRON GENERATED NOTICES - As a patron with ILL requests, go to the "your interlibrary loan requests" page in the OPAC - View a request - Add some text to the notes field and save - Run the report created earlier => TEST: Observe that a notice was created for the modification => TEST: Observe that the to_address matches the previously defined "ILL staff email" for the request's branch => TEST: Observe that the from_address matches the previously defined "ILL staff email" for the request's branch - As a patron with ILL requests, go to the "your interlibrary loan requests" page in the OPAC - View a request - Choose "Request cancellation" - Run the report created earlier => TEST: Observe that a notice was created for the modification => TEST: Observe that the to_address matches the previously defined "ILL staff email" for the request's branch => TEST: Observe that the from_address matches the previously defined "ILL staff email" for the request's branch There is a fallback hierarchy for the address to which staff notices are sent: Branch ILL staff email > ILLDefaultStaffEmail > General branch email > Koha admin email Please test that this hierarchy is adhered to by undefining one or more of these options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:27:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 13:27:26 +0000 Subject: [Koha-bugs] [Bug 22013] Command line staging: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22013 --- Comment #10 from Simon Hohl --- I am back to the original situation (working, but with warnings): 1. Added to authority-koha-indexdefs.xml (roughly copied over from the biblio equivalent): Identifier-standard:w Identifier-standard:p Identifier-standard:s 2. Added to etc/zebradb/authorities/etc/bib1.att: att 1007 Identifier-standard 3. Ran xsltproc on xml to create xsl file: xsltproc /etc/koha/zebradb/xsl/koha-indexdefs-to-zebra.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl 4. Rebuilt Zebra: koha-rebuild-zebra -a -f -v (...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 13:38:07 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #18 from Agust?n Moyano --- (In reply to Josef Moravec from comment #17) > But why don't to contribute back to Mottie Keyboard? > > Also, these files are minified, I don't think anybody would like to edit > minified files... Hi Josef.. all.js is not part of Mottie keyboard.. and I found no other way to include all languages, that didn't require to parse all js files with perl, just to write an array of languages in the template. Maybe we could have a fork of that project, so we can PR on that project, and in the same time we could have 'releases' with all.js compiled and included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:31:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 14:31:18 +0000 Subject: [Koha-bugs] [Bug 23033] New: C4::Items::AddItemBatchFromMarc does not queue bib record for indexing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23033 Bug ID: 23033 Summary: C4::Items::AddItemBatchFromMarc does not queue bib record for indexing Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: paul at flo.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Callers of C4::Items::AddItemBatchFromMarc must call ModZebra (directly or indirectly) afterwards, which strikes me as wrong. AddItemBatchFromMarc used to call C4::Biblio::ModBiblioMarc, which calls C4::Items::ModZebra[*] but the call to ModBiblioMarc was commented out in commit 3584c442 (2010-09-03 12:16:52 +0200, see bug #5579) and the comment was never removed. The only code in Koha 18.11 that calls AddItemBatchFromMarc is in migration_tools/bulkmarcimport.pl, which dutifully calls MobBiblioMarc once after each call to AddItemBatchFromMarc -- even(!) if AddItemBatchFromMarc fails, which seems weird but I don't fully understand the code. We could add a call to ModZebra in AddItemBatchFromMarc but I assume it would be better to reinstate the call to ModBiblioMarc. I'll attach a patch shortly. [*] C4::Items gets ModZebra from C4::Biblio, which implements and exports it, so my will also change this to a call to C4::Biblio::ModZebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:33:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 14:33:47 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84663|0 |1 is obsolete| | Attachment #84664|0 |1 is obsolete| | Attachment #84735|0 |1 is obsolete| | --- Comment #17 from Owen Leonard --- Created attachment 90269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90269&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:33:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 14:33:51 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #18 from Owen Leonard --- Created attachment 90270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90270&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 14:33:54 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #19 from Owen Leonard --- Created attachment 90271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90271&action=edit Bug 21852: (follow up) Remove persistent DataTables user configuration This patch removes the DataTables function for restoring a user's previous configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:33:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 14:33:44 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:53:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 14:53:55 +0000 Subject: [Koha-bugs] [Bug 23034] New: Warning when in Mana KB settings Auto subscription sharing is unchecked Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 Bug ID: 23034 Summary: Warning when in Mana KB settings Auto subscription sharing is unchecked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Mana-kb Assignee: joonas.kylmala at helsinki.fi Reporter: joonas.kylmala at helsinki.fi Target Milestone: --- If you go to the page /cgi-bin/koha/admin/share_content.pl and unselect the checkbox "Auto subscription sharing" you will get following warning to plack-error.log: "Use of uninitialized value $auto_share in string ne at /home/koha/kohaclone/admin/share_content.pl line 49." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:04:28 +0000 Subject: [Koha-bugs] [Bug 23033] C4::Items::AddItemBatchFromMarc does not queue bib record for indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23033 Paul Hoffman changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5579 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:04:28 +0000 Subject: [Koha-bugs] [Bug 5579] Remove items from biblioitems.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5579 Paul Hoffman changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23033 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:06:18 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea at gmail.com --- Comment #8 from Liz Rea --- Hi Katrin, This works but it has a QA tool failure that I don't understand because it seems to be set up correctly: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc FAIL valid_template options_for_libraries: not found IT may be a false positive, if it is just let me know and I'll sign it off. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:17:59 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:17:41 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 --- Comment #1 from Joonas Kylm?l? --- Created attachment 90273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90273&action=edit 0001-Bug-23034-Remove-uninitialized-value-warning-in-Mana Here is a patch to remove the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:23:09 +0000 Subject: [Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:27:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:27:44 +0000 Subject: [Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:28:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:28:47 +0000 Subject: [Koha-bugs] [Bug 23035] New: Intranet search is slow if thousands of items are in the biblios shown in the search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Bug ID: 23035 Summary: Intranet search is slow if thousands of items are in the biblios shown in the search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching Assignee: joonas.kylmala at helsinki.fi Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org Target Milestone: --- If you search on intranet for biblios that have in total thousands of items then then the search result will load very very slowly. The slowing down is linear with the amount of items in the bibs. I already tracked this down to a GetAuthorisedValueDesc() call in C4/XSLT.pm. I will start working on a patch for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:30:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:30:38 +0000 Subject: [Koha-bugs] [Bug 23036] New: Optionally order facets by result hits Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23036 Bug ID: 23036 Summary: Optionally order facets by result hits Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: jhannert at nmc.edu QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Facets on the left sidebar of the OPAC currently sort alphabetically. It would be nice to allow administrators the option to order them by number of results, with most hits at the top of the list. I understand that this, like the displayFacetCount preference, would be highly dependent on the value of the maxRecordsForFacets. Still, this type of sorting for facets is common in discovery systems and, I think, something our patrons expect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:30:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:30:43 +0000 Subject: [Koha-bugs] [Bug 23036] Optionally order facets by result hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23036 Joelle Hannert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhannert at nmc.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:31:42 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #14 from Jonathan Druart --- I can recreate in a devbox if I change the timezone (ie. tz is different between host and box) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:32:30 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:32:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:32:35 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90264|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 90274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90274&action=edit Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:50:19 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:50:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:50:23 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90263|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 90275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90275&action=edit Bug 22770: Fix typo in German language description of el Fixes: Griechisch (Moern [1453- ] ==> Griechisch (Modern 1453-) To test: - Install de-DE language and activate it - Check the language pull down on advanced search has the typo - Apply patch and run database update - Check advanced search again - Verify the description now shows correctly Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:56:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:56:25 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 15:56:28 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90236|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 90276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90276&action=edit Bug 23027: Make Suggestions.t pass even if no biblio in DB There are biblionumbers 1 and 2 hardcoded Test plan: MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio; % prove t/db_dependent/Suggestions.t Must return green with this patch applied Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:13:10 +0000 Subject: [Koha-bugs] [Bug 23037] New: Henry Bolshaw is missing from the contributors list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Bug ID: 23037 Summary: Henry Bolshaw is missing from the contributors list Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Ooops, we missed a new contributor who crept in just a few days before release.. working whilst as Kohacon19. We should add him in, and backport to 18.11.x for 18.11.01 to give due recognition ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:33:27 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 --- Comment #1 from Martin Renvoize --- Created attachment 90277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90277&action=edit Bug 23037: Add Henry Bolshaw to contributors We missed Henry from the release notes and about page.. sorry Henry! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:33:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:33:47 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:34:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:34:08 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:40:25 +0000 Subject: [Koha-bugs] [Bug 22908] Modsuggestion will generate a notice even if the modification failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22908 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 [Bug 23038] Expected warnings displayed by tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:40:25 +0000 Subject: [Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 [Bug 23038] Expected warnings displayed by tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:40:25 +0000 Subject: [Koha-bugs] [Bug 23038] New: Expected warnings displayed by tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Bug ID: 23038 Summary: Expected warnings displayed by tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 22908, 22049 Target Milestone: --- When tests are ran, there are 2 warnings that are expected and raised by DBI. As they are expected they must be correctly caught and not displayed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 [Bug 22049] MarkIssueReturned should rely on returndate only https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22908 [Bug 22908] Modsuggestion will generate a notice even if the modification failed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:41:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:41:06 +0000 Subject: [Koha-bugs] [Bug 23039] New: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Bug ID: 23039 Summary: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- During the checkin process, all the message info is completely obscured by any modal forms that may be triggered by the checkin. In some cases that info could be vital to making an informed decision as to what option to choose in the modal itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:41:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:41:37 +0000 Subject: [Koha-bugs] [Bug 22906] Minor corrections to plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:41:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:41:39 +0000 Subject: [Koha-bugs] [Bug 22906] Minor corrections to plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:42:46 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:42:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:42:51 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 --- Comment #1 from Jonathan Druart --- Created attachment 90278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90278&action=edit Bug 23038: Hide expected warnings from tests When tests are ran, there are 2 warnings that are expected and raised by DBI. As they are expected they must be correctly caught and not displayed. We could have reconnect with PrintError turned off, but then reconnect with it on. Test plan: % prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Suggestions.t Must not display DBI warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:46:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:46:24 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #1 from Kyle M Hall --- Screencast example: https://monosnap.com/file/zHNCgXuEg0eG1BOb3hdKpIRlKnra4O -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:46:41 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:46:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:46:55 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expected warnings displayed |Expected warnings displayed |by tests |by tests should be hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:49:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:49:59 +0000 Subject: [Koha-bugs] [Bug 23040] New: The output of Illrequests.t displays warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23040 Bug ID: 23040 Summary: The output of Illrequests.t displays warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20750 Target Milestone: --- kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Illrequests.t t/db_dependent/Illrequests.t .. 1/11 no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. t/db_dependent/Illrequests.t .. 4/11 no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. t/db_dependent/Illrequests.t .. 7/11 no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. t/db_dependent/Illrequests.t .. 10/11 no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. t/db_dependent/Illrequests.t .. ok All tests successful. Files=1, Tests=11, 6 wallclock secs ( 0.04 usr 0.00 sys + 4.94 cusr 1.16 csys = 6.14 CPU) Result: PASS Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 [Bug 20750] Allow timestamped auditing of ILL request events -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:49:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:49:59 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23040 [Bug 23040] The output of Illrequests.t displays warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:56:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 16:56:44 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #15 from Jonathan Druart --- It was D9 on Node 2 (#742) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:09:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:09:36 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > I can recreate in a devbox if I change the timezone (ie. tz is different > between host and box) It's not that, I can recreate when MySQL server has not been restarted after a tz change. % sudo dpkg-reconfigure tzdata # Pick something different than where you are % prove t/db_dependent/Koha/Patrons.t # Fail! % sudo systemctl restart mysql % prove t/db_dependent/Koha/Patrons.t # Success! It does not explain much why the tests are randomly failing. I have tried to run it with the different tests playing with the timezone config, without success. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:09:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:09:47 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:10:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:10:39 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #2 from Martha Fuerst --- We circulate hotspots, and when a device is 4 days overdue, we mark it lost and damaged and turn off the service. When these hotspots are returned, a hold will trigger (they are a high-demand item), but if the item has been deactivated, staff often miss this and trap the hold. Moving the the modal so it does not obstruct these messages, or adding lost/damaged information to the modal would benefit us greatly. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:49:31 +0000 Subject: [Koha-bugs] [Bug 23041] New: Add Custom reports to patron record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23041 Bug ID: 23041 Summary: Add Custom reports to patron record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: christofer.zorn at ajaxlibrary.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Created attachment 90279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90279&action=edit The print button Hello, It would be a wonderful feature to allow the addition of custom notices to the "Print" pull down when viewing a patron record. We would like the ability to pull up a patron, then be able to print more notice options than just the Issue Slip, Quick Slip and Summary. The idea would be to put a billing notice under that so we can generate a canned printed report directly from the patrons record. We want to generate a print copy, not an email. A system preference that built off of the existing list and add pre-defined notices to that pull down. Please let me know if you'd like me to elaborate. Thanks for considering! Christofer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:51:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:51:48 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:51:50 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 --- Comment #36 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:51:53 +0000 Subject: [Koha-bugs] [Bug 22906] Minor corrections to plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:51:55 +0000 Subject: [Koha-bugs] [Bug 22947] Markup error in OPAC preferences file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:51:57 +0000 Subject: [Koha-bugs] [Bug 22947] Markup error in OPAC preferences file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:51:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:51:58 +0000 Subject: [Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:52:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:52:00 +0000 Subject: [Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:52:04 +0000 Subject: [Koha-bugs] [Bug 22955] Markup error in OPAC lists template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:52:02 +0000 Subject: [Koha-bugs] [Bug 22955] Markup error in OPAC lists template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:56:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:56:03 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:57:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:57:25 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 19:57:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 17:57:27 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:50:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 19:50:39 +0000 Subject: [Koha-bugs] [Bug 23043] New: Overdrive search results contain irrelevant books when series (or other) links are followed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23043 Bug ID: 23043 Summary: Overdrive search results contain irrelevant books when series (or other) links are followed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To recreate: 1 - Enable overdrive 2 - perform a search, say "Harry potter" 3 - Note you get some results from overdrive and link looks like: "/cgi-bin/koha/opac-overdrive-search.pl?q=harry%20potter" 4 - Click a series link 5 - Note overdrive link now looks like: " /cgi-bin/koha/opac-overdrive-search.pl?q=se%2Cphr%3A%26quot%3BRowling%2C%20J.%20K.%26quot%3B" 6 - Note the se,phr: causes odd results from overdrive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 22:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 20:35:13 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23 at gmail.com --- Comment #4 from Michal Denar --- Hi Tom?s, test passed with Zebra, but fails with ES. Can you take a look? Thank You. Result: t/db_dependent/Circulation.t .. 104/130 # No tests run! t/db_dependent/Circulation.t .. 108/130 # Failed test 'No tests run for subtest "CanBookBeIssued & AllowReturnToBranch"' # at t/db_dependent/Circulation.t line 1330. Can't call method "leader" on an undefined value at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 429. # Looks like your test exited with 255 just after 108. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 23/130 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 108 Failed: 1) Failed test: 108 Non-zero exit status: 255 Parse errors: Bad plan. You planned 130 tests but ran 108. Files=1, Tests=108, 8 wallclock secs ( 0.04 usr 0.00 sys + 5.32 cusr 0.66 csys = 6.02 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 22:55:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 20:55:59 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Joelle Hannert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhannert at nmc.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 01:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 23:58:13 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89404|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 01:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 23:58:17 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 01:58:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 23:58:22 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 01:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 23:59:02 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #25 from Agust?n Moyano --- Created attachment 90280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90280&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 01:59:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 23:59:08 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #26 from Agust?n Moyano --- Created attachment 90281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90281&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 01:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2019 23:59:13 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #27 from Agust?n Moyano --- Created attachment 90282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90282&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:04:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:04:22 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:04:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:04:33 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:04:42 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:05:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:05:18 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #28 from Agust?n Moyano --- Created attachment 90283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90283&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:05:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:05:24 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #29 from Agust?n Moyano --- Created attachment 90284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90284&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:05:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:05:29 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #30 from Agust?n Moyano --- Created attachment 90285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90285&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:08:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 00:08:09 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #31 from Agust?n Moyano --- (In reply to Jonathan Druart from comment #24) > Comment on attachment 89404 [details] [review] > Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters > in smart-rules.pl > > We should not need this patch. If the rule_name param is needed to make it > works, something else is broken. Hello Jonathan, I agree with you, so I patched Koha::RefundLostItemFeeRules->find Regards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:14:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:14:14 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #3 from Hayley Mapley --- Created attachment 90286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90286&action=edit Bug 22627: (follow-up) Changed accountlines and sco to match OPAC Test plan: Same as previous patch Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:14:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:14:11 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:19:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:19:19 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #4 from Hayley Mapley --- Created attachment 90287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90287&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:20:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:20:44 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90101|0 |1 is obsolete| | Attachment #90286|0 |1 is obsolete| | Attachment #90287|0 |1 is obsolete| | --- Comment #5 from Hayley Mapley --- Created attachment 90288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90288&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:02 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88173|0 |1 is obsolete| | --- Comment #161 from Aleisha Amohia --- Created attachment 90289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90289&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:11 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88174|0 |1 is obsolete| | --- Comment #162 from Aleisha Amohia --- Created attachment 90290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90290&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:18 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88175|0 |1 is obsolete| | --- Comment #163 from Aleisha Amohia --- Created attachment 90291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90291&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:25 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88176|0 |1 is obsolete| | --- Comment #164 from Aleisha Amohia --- Created attachment 90292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90292&action=edit Bug 15516: Set reserve-group.pl to be executable Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:31 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88177|0 |1 is obsolete| | --- Comment #165 from Aleisha Amohia --- Created attachment 90293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90293&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88178|0 |1 is obsolete| | --- Comment #166 from Aleisha Amohia --- Created attachment 90294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90294&action=edit Bug 15516: Fix translation issues - Use " inside _() - Merge two strings (PART_OF_A, HOLD_GROUP) Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88179|0 |1 is obsolete| | --- Comment #167 from Aleisha Amohia --- Created attachment 90295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90295&action=edit Bug 15516: (follow-up) Fix kohastructure.sql Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88180|0 |1 is obsolete| | --- Comment #168 from Aleisha Amohia --- Created attachment 90296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90296&action=edit Bug 15516: (follow-up) Fix reserve -> hold change Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:59:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 02:59:58 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88181|0 |1 is obsolete| | --- Comment #169 from Aleisha Amohia --- Created attachment 90297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90297&action=edit Bug 15516: (follow-up) Fix modal for hold group Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:00:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:00:05 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88182|0 |1 is obsolete| | --- Comment #170 from Aleisha Amohia --- Created attachment 90298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90298&action=edit Bug 15516: (follow-up) Fix pod in C4::Reserves Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:00:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:00:13 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88183|0 |1 is obsolete| | --- Comment #171 from Aleisha Amohia --- Created attachment 90299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90299&action=edit Bug 15516: (follow-up) Fix template filters Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:00:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:00:19 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88184|0 |1 is obsolete| | --- Comment #172 from Aleisha Amohia --- Created attachment 90300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90300&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:00:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:00:26 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88185|0 |1 is obsolete| | --- Comment #173 from Aleisha Amohia --- Created attachment 90301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90301&action=edit Bug 15516: (follow-up) Schema updates Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:00:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:00:32 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88186|0 |1 is obsolete| | --- Comment #174 from Aleisha Amohia --- Created attachment 90302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90302&action=edit Bug 15516: (follow-up) Changing utf8 to utf8mb4 Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:00:39 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #175 from Aleisha Amohia --- Created attachment 90303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90303&action=edit Bug 15516: (follow-up) Fixing atomic update to prevent errors This patch prevents errors when applying atomic update, particularly for those that have already tested this feature before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 03:02:22 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #176 from Aleisha Amohia --- Rebased and ready to test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 07:56:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 05:56:44 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #18 from Nabila --- (In reply to Jonathan Druart from comment #17) > (In reply to Nabila from comment #16) > > The patch works. > > You should not need this patch to have Koha working correctly. You will > certainly face other problems. > > By any chances, could you sign the patch off? > https://wiki.koha-community.org/wiki/Sign_off_on_patches If this patch is not supposed to run - then how do I sign it off? (Sorry, first time). I had 4 instances of Koha created on my system. The first one did not throw this error, only rest of the 3 did. If everytime MySQL and Koha setup is same. This error should not have been encountered in the first place. Yet, when error started to come for authority, the change mentioned in authorities_normal_marc21.sql file worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:02:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 06:02:07 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |josef.moravec at gmail.com, | |katrin.fischer at bsz-bw.de, | |magnus at libriotech.no, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 06:02:58 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:08:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 06:08:11 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #7 from Martin Renvoize --- Perhaps I happened to hit the feature when the Mana server was down or something? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 06:12:41 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #8 from Martin Renvoize --- Created attachment 90304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90304&action=edit Error Afraid I do still see this error.. attaching a screenshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:15:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 06:15:44 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #19 from Nabila --- (In reply to Jonathan Druart from comment #17) > (In reply to Nabila from comment #16) > > The patch works. > > You should not need this patch to have Koha working correctly. You will > certainly face other problems. > > By any chances, could you sign the patch off? > https://wiki.koha-community.org/wiki/Sign_off_on_patches If I have to test the patch in Sandbox then I will have to run the Web Installer. Which Username/password should I use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 10:53:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 08:53:42 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 10:53:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 08:53:45 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90277|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 90305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90305&action=edit Bug 23037: Add Henry Bolshaw to contributors We missed Henry from the release notes and about page.. sorry Henry! Signed-off-by: Magnus Enger Not really tested, just had a look and checked the changes look sane. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:07:54 +0000 Subject: [Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:07:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:07:55 +0000 Subject: [Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:07:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:07:57 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:07:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:07:59 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #24 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:08:02 +0000 Subject: [Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:08:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:08:03 +0000 Subject: [Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:08:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:08:05 +0000 Subject: [Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:08:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:08:08 +0000 Subject: [Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:09:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:09:15 +0000 Subject: [Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #11 from Martin Renvoize --- Created attachment 90306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90306&action=edit Bug 22960: (RM follow-up) Correct a further typo "This a list" changed to "This is a list" Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:01 +0000 Subject: [Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:06 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:04 +0000 Subject: [Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887 --- Comment #17 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:08 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:10 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:12 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:13 +0000 Subject: [Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:20:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:20:15 +0000 Subject: [Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:45:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:45:56 +0000 Subject: [Koha-bugs] [Bug 23044] New: Able to filter only late transfers on 'Transfers to receive' page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23044 Bug ID: 23044 Summary: Able to filter only late transfers on 'Transfers to receive' page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: johanna.raisa at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Sometimes there might be lot of transfers from lot of branches on 'Transfers to receive' page. It would be handy to filter results so librarians can see only transfers which are late. In this way they could know faster the transfers which are problematic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:57:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 09:57:12 +0000 Subject: [Koha-bugs] [Bug 22891] ILS-DI: RenewLoan explodes in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22891 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:16:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:16:34 +0000 Subject: [Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Jeff Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.j.brown at lboro.ac.uk --- Comment #1 from Jeff Brown --- At Loughborough University we agree that the decreaseLoanHighHolds should only count holds that are not fulfilled. This is especially important when borrowers collect & issue their own holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:21:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:21:01 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90222|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 90307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90307&action=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:21:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:21:05 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90223|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 90308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90308&action=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:21:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:21:08 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90224|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 90309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90309&action=edit Bug 22563: (follow-up) Corrections for tests Updates to unit tests to reflect the accounttype changes and introduction of status usage. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:21:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:21:11 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90225|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize --- Created attachment 90310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90310&action=edit Bug 22563: (follow-up) Items LOST should not be RETURNED Up until now we marked lost items as returned in the accountlines, now we have the oportunity to mark these distinctly with an appropriate status we should. Test Plan 1) Find an overdue with fines 2) Ensure you are not forgiving fines when an item is marked as lost 3) Mark the item as lost 4) Confirm the Fine is given a status of 'Lost' Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:21:15 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90226|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize --- Created attachment 90311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90311&action=edit Bug 22563: (follow-up) Corrections for overdue tests Updates to unit tests to reflect the accounttype changes and introduction of status usage for _FixOverduesOnReturn. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:21:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:21:18 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90227|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize --- Created attachment 90312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90312&action=edit Bug 22563: (follow-up) Clean up remaing L, LR and CR cases in the database Test plan: 1) Confirm that after the DB update there are no L, LR or CR accountlines present. 2) Read the db update and confirm is makes sense. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:37:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:37:57 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90232|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 90314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90314&action=edit Bug 11573: Update existing accountlines for 'Rent' Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:38:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:38:01 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90233|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 90315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90315&action=edit Bug 11573: Update of unit tests This patch updates the unit tests to reflect the changes to the core routines. The relevant changes are the removal of a hard coded 'description' and the splitting up of the 'Rent' accounttype into 'RENT', 'RENT_RENEW', 'RENT_DAILY' and 'RENT_DAILY_RENEW'. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:38:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:38:06 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90234|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 90316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90316&action=edit Bug 11573: (follow-up) Correction to accountype search on opac-user.pl With the update of accountype from 'Rent' to four distinct accountypes we need to update the search here to catch all four types of charge. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:37:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:37:53 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90231|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 90313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90313&action=edit Bug 11573: Make rental accountlines translatable To test: 1. Set up an item type with a rental charge 2. Issue an item with that item type 3. Check fines, a charge of type 'Rent' will be visible with a description of 'Rental'. 4. Renew the item 5. Check fines, a charge of type 'Rent' will be visible with a description of 'Renewal of Rental Item TITLE BARCODE' where TITLE and BARCODE are the items title and barcode. 5. Apply the patch 6. Repeat steps 1-4, charge descriptions should now be empty and charge types should display 'Rental fee' and 'Renewal of rental item'. 7. Repeat steps 1-6 for an item type with a daily rental charge and note the charge types are now 'Daily rental fee' and 'Renewal of daily rental item' Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:39:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:39:11 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:41:43 +0000 Subject: [Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:43:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:43:30 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 [Bug 19489] Detailed description of charges on Accounting tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:43:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:43:30 +0000 Subject: [Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 [Bug 15985] Include transacting library in fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:47:47 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 12:50:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 10:50:48 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:13:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 12:13:07 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 12:13:10 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72611|0 |1 is obsolete| | Attachment #72612|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 90317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90317&action=edit Bug 15985: Include transacting library in fines Some librarians would like to see the library an item was checked out from in the fines table on the fines payment page. Test Plan: 1) Apply this patch 2) Find a patron with overdue items that have fines 3) Browse to the pay fines page 4) Note the new "checked out from" column Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:13:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 12:13:27 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #14 from Kyle M Hall --- Created attachment 90318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90318&action=edit Bug 15985: Add new method Koha::Account::Line::checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:45:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 12:45:08 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #16 from Nightly Build Bot --- Created attachment 90319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90319&action=edit Bug 17108- Automatic debian/control updates (stable/19.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:41:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 13:41:55 +0000 Subject: [Koha-bugs] [Bug 23045] New: 008 Widget breaks JS when used with Macro Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Bug ID: 23045 Summary: 008 Widget breaks JS when used with Macro Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- When running this macro (see below) with the helpers turned the JS is breaking. Error: record.leader is not a function. It is possible the helper is calling the leader (possibly when it is deleted since part of the macro is delete the leader) and therefore the get material is breaking. delete 000 delete 005 delete 008 delete 245 new 000= cam a22 Ii 4500 new 005= new 008=190320s2017 nyua c 000 0 eng d In 18.05.10 this is not performing this same way, however, bug 16251 was fixed and pushed to the next 18.05 version, and therefore this might be the cause of the breakage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:42:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 13:42:12 +0000 Subject: [Koha-bugs] [Bug 23045] 008 Widget breaks JS when used with Macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 13:52:12 +0000 Subject: [Koha-bugs] [Bug 23044] Able to filter only late transfers on 'Transfers to receive' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23044 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- Hi, This is a really good idea, I think! Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 14:08:12 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:37:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 14:37:01 +0000 Subject: [Koha-bugs] [Bug 23045] 008 Widget breaks JS when used with Macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 --- Comment #1 from Nick Clemens --- Created attachment 90320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90320&action=edit Bug 23045: TextMarc errors on blank lines Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when processing blank lines. We should just pass on these rather then erroring To test: 1 - Define a new macro that delete more fields than it adds delete 245 2 - Run it 3 - Note an error in JS console, and helpers will not load 4 - Apply patch 5 - Reload, try again 6 - No error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:36:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 14:36:59 +0000 Subject: [Koha-bugs] [Bug 23045] 008 Widget breaks JS when used with Macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:39:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 14:39:49 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|008 Widget breaks JS when |Advanced cataloging editor |used with Macro |(rancor) throws a JS error | |when lines deleted by | |macros Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:41:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 14:41:53 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 15:15:39 +0000 Subject: [Koha-bugs] [Bug 22977] OMNIBUS: Ensure hidden fields are correctly passed during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22977 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew --- wrong-transfer-modal is lacking these inputs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:07:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:07:41 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #152 from Agust?n Moyano --- Sorry to anounce that yesterday I applied this patches over a fresh master, and the problem of add child that shows "Add Patron (Adult)" returned... I'll do it again today just to be sure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:12:10 +0000 Subject: [Koha-bugs] [Bug 23030] Install Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23030 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:12:58 +0000 Subject: [Koha-bugs] [Bug 23041] Add Custom reports to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23041 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:20:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:20:08 +0000 Subject: [Koha-bugs] [Bug 21936] Patrons do not have option on printed notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21936 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:24:15 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 --- Comment #1 from Lisette Scheer --- *** Bug 12218 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:24:15 +0000 Subject: [Koha-bugs] [Bug 12218] show patrons the notices log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12218 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |lisetteslatah at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Lisette Scheer --- *** This bug has been marked as a duplicate of bug 9699 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:24:23 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvr at fct.unl.pt --- Comment #2 from Lisette Scheer --- *** Bug 19011 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:24:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:24:43 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:24:23 +0000 Subject: [Koha-bugs] [Bug 19011] Display patron's own notices for patron user itself In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19011 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |lisetteslatah at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Lisette Scheer --- *** This bug has been marked as a duplicate of bug 9699 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:37:05 +0000 Subject: [Koha-bugs] [Bug 22507] Modification of the Holds Slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #3 from Lisette Scheer --- We use some JQ in our notice to make this happen as well, though we are working on switching it to TT. I could see how separating it out could be useful, even though it is technically possible now. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:51:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 16:51:34 +0000 Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 --- Comment #1 from Owen Leonard --- Would it make sense to have the actions menu include the same options the basket view toolbar has? - Add to basket - Edit basket - Delete basket - Close basket - Export as CSV - Create EDIFACT order - E-mail order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:16:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 23:16:11 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #20 from Jonathan Druart --- What are the differences between the 4 Koha you have installed? To sign it off you could just add your signed-off-by line at the bottom of the git commit, if you have a Koha git repo. Otherwise I will add it for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 23:23:57 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #32 from Jonathan Druart --- Augustin, can you provide tests for the changes you made please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:24:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 23:24:36 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #33 from Jonathan Druart --- Agust?n, can you provide tests for the changes you made please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 23:39:52 +0000 Subject: [Koha-bugs] [Bug 22037] regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 --- Comment #9 from Jonathan Druart --- Hi Kyle, This patch is supposed to fix the regression caused by: Bug 19933: Remove patronflags - tricky ones -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2019 23:45:39 +0000 Subject: [Koha-bugs] [Bug 11853] Cannot clear date of birth via OPAC patron update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89581|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 90321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90321&action=edit [18.05.x] Bug 11853: Add tests Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 07:43:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 05:43:30 +0000 Subject: [Koha-bugs] [Bug 22985] Tag cloud only displays user's own tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22985 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:45:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 07:45:16 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:45:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 07:45:29 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 --- Comment #3 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 07:45:27 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 07:46:28 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 --- Comment #4 from Martin Renvoize --- I went ahead and pushed this as it's a trivial patch.. Only reason I created a bug for it really was that I believe it should be backported to 19.05.x series as his contribution made it in just before the release of that version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:47:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 07:47:13 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:47:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 07:47:22 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:03:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 08:03:24 +0000 Subject: [Koha-bugs] [Bug 23046] New: Add tax handling to accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 Bug ID: 23046 Summary: Add tax handling to accounts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We should have the ability to assign tax rates to the various charges a patron can incur. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 08:03:50 +0000 Subject: [Koha-bugs] [Bug 23047] New: Add tax handling to accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 Bug ID: 23047 Summary: Add tax handling to accounts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We should have the ability to assign tax rates to the various charges a patron can incur. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 08:04:06 +0000 Subject: [Koha-bugs] [Bug 23047] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 08:04:06 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 [Bug 23047] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:59:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 08:59:29 +0000 Subject: [Koha-bugs] [Bug 23048] New: Hide non-pickup branches from hold modification select Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048 Bug ID: 23048 Summary: Hide non-pickup branches from hold modification select Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:00:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 09:00:32 +0000 Subject: [Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:04:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 09:04:14 +0000 Subject: [Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 09:04:05 +0000 Subject: [Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048 --- Comment #1 from paxed --- Created attachment 90322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90322&action=edit Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches. Test plan: 1) Create a branch that is marked as a non-pickup location. 2) Create a hold or a patron. 3) Go to members/moremember.pl for that patron, check the Holds-tab Pickup library -drop down. It lists the non-pickup branch. 4) Go to reserve/request.pl for that biblio. The Existing hold-table Pickup library -drop down lists the non-pickup branch. 5) Apply patch. 6) Repeat 3 & 4, drop down no longer lists the non-pickup branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 09:52:20 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #47 from Michael Kuhn --- When updating from Koha 18.11 to Koha 19.05 the update process says: Upgrade to 18.12.00.025 done (Bug 21846 - Using emoji as tags has broken weights) WARNING: (Bug 21846) You need to manually run /usr/share/koha/intranet/cgi-bin/misc/maintenance/fix_tags_weight.pl to fix possible issues with tags. But in fact the script "fix_tags_weight.pl" is located at "/usr/share/koha/bin/maintenance/fix_tags_weight.pl". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:32:33 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17702 |23047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 [Bug 23047] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:32:33 +0000 Subject: [Koha-bugs] [Bug 23047] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:32:33 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:37:04 +0000 Subject: [Koha-bugs] [Bug 23049] New: Replace MANUAL_INV authorised value with a dedicated table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Bug ID: 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Account debits types should be properly recorded in their own table with a purpose-built interface for working upon them. This would pave the way for extensions to the cash management side of Koha, allowing for more granular definitions of charges for a point of sale system and giving an obvious location to add features like recording tax rates on different charges. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:37:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:37:34 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6759 Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 [Bug 6759] Use a different account type for account renewals than for new accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:37:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:37:34 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:37:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:37:34 +0000 Subject: [Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:38:28 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6759 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 [Bug 6759] Use a different account type for account renewals than for new accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:38:28 +0000 Subject: [Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:39:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:39:18 +0000 Subject: [Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:39:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:39:18 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:55:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:55:43 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87705|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 90323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90323&action=edit Bug 10215: Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. Rescued-by: Martin Renvoize Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:55:46 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #23 from Martin Renvoize --- Created attachment 90324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90324&action=edit Bug 10215: (follow-up) Correct existing data This patch adds the correction of data ('' => NULL) during the DB update. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:55:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:55:58 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:56:12 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #24 from Martin Renvoize --- Added a followup for Katrins request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 11:59:28 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #25 from Martin Renvoize --- Created attachment 90325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90325&action=edit Bug 10215: (follow-up) Fix the failing test We now handle NULL values at the database end and do not expect empty strings. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:08:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:08:05 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #20 from Martin Renvoize --- (In reply to Jonathan Druart from comment #18) > (In reply to Martin Renvoize from comment #17) > > As an aside, do we have any inflators setup with our dbic schemata? > > Like: > Koha/ItemTypes.pm: $Koha::Schema::Result::Itemtype::LANGUAGE = > $language; > ? No, I meant like DBIC::InflateColumn::DateTime.. or in this case we could easily have DBIC::::InflateColumn::MARC and similar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:15:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:15:41 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78268|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger --- Created attachment 90326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90326&action=edit Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. This patch adds two entries in the loans section of GetPatronInfo's response: - itemonhold: number of holds on this specific item. - recordonhold: number of holds on the record. Test plan: - Call GetPatronInfo on a user with a loan that has no holds - Check that itemonhold and recordonhold entries are equal to zero - Add holds on biblio and/or item level - Check that itemonhold and recordonhold are incremented accordingly Please note that a hold on item level counts as a hold on record level, but not vice-versa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:16:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:16:37 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Matthias Meusburger --- Patch rebased and use C4::Reserves removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:30:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:30:58 +0000 Subject: [Koha-bugs] [Bug 23050] New: Plugins: Add hook to add a tab in intranet biblio details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Bug ID: 23050 Summary: Plugins: Add hook to add a tab in intranet biblio details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Add a plugin hook that will allow plugins to add a new tab in intranet biblio details page (catalogue/detail.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:33:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:33:22 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19919 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:33:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:33:22 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:38:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:38:49 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90243|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 90327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90327&action=edit Bug 22982: Paying lost fee does not always remove lost item from checkouts Depending on how a lost fee is paid, it may or may not be removed from the patrons current checkouts. The current expected behavior is for the lost item to be removed from the patrons checkouts when the lost fee is paid in full. This is due to the subroutine for handling of lost fees being included in the 'pay specific lines' code but not in the 'pay by amount' code. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account.t Signed-off-by: Liz Rea Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:38:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:38:52 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90244|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 90328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90328&action=edit Bug 22982: Add unit tests Signed-off-by: Liz Rea Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:38:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:38:55 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90245|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 90329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90329&action=edit Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit test Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:39:09 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:39:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:39:43 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize --- I'm pretty happy with this one now, it all works for me, passes QA scripts and I can't see any regressions. Thanks Kyle, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:41:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:41:03 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:41:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:41:03 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:41:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:41:38 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 --- Comment #18 from Martin Renvoize --- Note to self.. this will conflict quietly with 22563 when it is pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:44:18 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:44:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:44:20 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 --- Comment #19 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:17 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90307|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 90330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90330&action=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:20 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90308|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 90331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90331&action=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:23 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90309|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 90332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90332&action=edit Bug 22563: (follow-up) Corrections for tests Updates to unit tests to reflect the accounttype changes and introduction of status usage. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:27 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90310|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 90333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90333&action=edit Bug 22563: (follow-up) Items LOST should not be RETURNED Up until now we marked lost items as returned in the accountlines, now we have the oportunity to mark these distinctly with an appropriate status we should. Test Plan 1) Find an overdue with fines 2) Ensure you are not forgiving fines when an item is marked as lost 3) Mark the item as lost 4) Confirm the Fine is given a status of 'Lost' Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:30 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90311|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 90334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90334&action=edit Bug 22563: (follow-up) Corrections for overdue tests Updates to unit tests to reflect the accounttype changes and introduction of status usage for _FixOverduesOnReturn. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:33 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90312|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 90335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90335&action=edit Bug 22563: (follow-up) Clean up remaing L, LR and CR cases in the database Test plan: 1) Confirm that after the DB update there are no L, LR or CR accountlines present. 2) Read the db update and confirm is makes sense. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:40 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:40 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 [Bug 22982] Paying lost fee does not always remove lost item from checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:46 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22563 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 12:54:46 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22982 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:13:41 +0000 Subject: [Koha-bugs] [Bug 23051] New: Optionally renew fine accruing items when all fines on item are paid off Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Bug ID: 23051 Summary: Optionally renew fine accruing items when all fines on item are paid off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Currently, if a user pays an accruing fine on an overdue item but forgets to renew the item fines start accruing again. If a user pays off the amount outstanding on an item with an accruing fine (accounttype "OVERDUE" & status "UNRETURNED" in 19.05) via the OPAC or self-service, or a member of staff takes payment in the staff client, attempt to automatically renew the item according to circulation rules. This behaviour should be controlled by a new syspref "RenewAccruingItemWhenPaid" which is initially turned off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:13:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:13:59 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:39:50 +0000 Subject: [Koha-bugs] [Bug 23052] New: Expiration date retained when hold waiting status reverted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23052 Bug ID: 23052 Summary: Expiration date retained when hold waiting status reverted Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- To Test: - Place a hold - Check item in to fill hold - Revert hold waiting status - Query the reserves table to see that expiration date has been retained - Change the value in ReservesMaxPickUpDelay - Check item in to fill hold again - Confirm that expiration date has not been re-calculated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:45:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:45:42 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew --- *** Bug 23052 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:45:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:45:42 +0000 Subject: [Koha-bugs] [Bug 23052] Expiration date retained when hold waiting status reverted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23052 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Andrew --- *** This bug has been marked as a duplicate of bug 21729 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:52:10 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #6 from Kelly McElligott --- This is still valid in 18.11.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:53:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:53:13 +0000 Subject: [Koha-bugs] [Bug 23053] New: Local-Number cannot be used for authority matching due to non-existence of 'phrase' index Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Bug ID: 23053 Summary: Local-Number cannot be used for authority matching due to non-existence of 'phrase' index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 21581 ensured that we can pass authority indexes through to the authorities search for matching, however, when searching in Zebra we deault to using: @attr 6=3 This seems to be equivalent to searching 'phrase' index for a field: See section 2.4.5 https://software.indexdata.com/zebra/doc/querymodel-rpn.html It seems Local-Number does not support phrase searching currently To recreate: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:54:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:54:05 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 13:54:47 +0000 Subject: [Koha-bugs] [Bug 23054] New: Unable to change priority after reverting hold waiting status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23054 Bug ID: 23054 Summary: Unable to change priority after reverting hold waiting status Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- To Test: - Place a hold for Patron A - Place a hold on same item for Patron B - Check item in, triggering Patron A's hold - Revert waiting status on hold - Confirm holds list shows Patron A at priority 1, Patron B at priority 2 - Use arrow buttons to move Patron B to priority 1 - Query reserves table to confirm Patron B at priority 1, Patron A at priority 2 - Check item in - Patron A's hold triggers, even though Patron B was first in priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:01:02 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:01:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:01:05 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 --- Comment #1 from Nick Clemens --- Created attachment 90336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90336&action=edit Bug 23053: Add phrase index to authority Local-Number To test: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 7 - Apply patch 8 - Copy the indexdefs files to the installed versions 9 - Reapply matchign rules to staged files 10 - Matches should now be found 11 - Logs should not have errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:04:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:04:53 +0000 Subject: [Koha-bugs] [Bug 23054] Unable to change priority after reverting hold waiting status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23054 --- Comment #1 from Andrew --- Possible this behavior is actually an offshoot of bug 19288. Following my test plan, we start with two bib-level holds, but Patron A's hold becomes item-level when reverted (see bug 9834). At that point we have one bib hold and one item hold, which bug 19288 says will perform inconsistently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:29:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:29:14 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #1 from Julian Maurice --- Created attachment 90337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90337&action=edit Bug 23050: Plugin hook to add tabs in intranet biblio details page Test Plan: 1) Enable plugins 2) Download and install the latest version of this plugin https://git.biblibre.com/biblibre/koha-plugin-intranet-detail-hook 3) Browse to catalogue/detail.pl for a record 4) Note you see two new tabs with content -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:29:37 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:29:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:29:53 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:29:27 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:32:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:32:12 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:36:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:36:34 +0000 Subject: [Koha-bugs] [Bug 23016] Add columns for copy number and material specified in patron checkout (circulation.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23016 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:36:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 14:36:44 +0000 Subject: [Koha-bugs] [Bug 23017] More search options for Z39.50 search (z3950_search.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23017 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:40:15 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:40:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:40:18 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90276|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 90338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90338&action=edit Bug 23027: Make Suggestions.t pass even if no biblio in DB There are biblionumbers 1 and 2 hardcoded Test plan: MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio; % prove t/db_dependent/Suggestions.t Must return green with this patch applied Signed-off-by: Liz Rea Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:40:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:40:47 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | --- Comment #4 from Josef Moravec --- Good catch Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:44:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:44:54 +0000 Subject: [Koha-bugs] [Bug 23055] New: Internal server error when trying to pay selected charges in fines accountant Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23055 Bug ID: 23055 Summary: Internal server error when trying to pay selected charges in fines accountant Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Internal server error when trying to pay fines. See file attached please. Plack log: ERROR PROCESSING TEMPLATE: undef error - : filter not found at /usr/share/koha/lib/Koha/Account.pm line 258. Tested in 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:46:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:46:20 +0000 Subject: [Koha-bugs] [Bug 23055] Internal server error when trying to pay selected charges in fines accountant In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23055 --- Comment #1 from Claudio --- Created attachment 90339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90339&action=edit Internal server error Tested in 19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:54:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:54:55 +0000 Subject: [Koha-bugs] [Bug 23055] Internal server error when trying to pay selected charges in fines accountant In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23055 --- Comment #2 from Claudio --- Email notice is not sent (ACCOUNT_PAYMENT) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:55:07 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:55:10 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90274|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 90340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90340&action=edit Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual Signed-off-by: Liz Rea Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 17:55:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 15:55:20 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 18:08:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 16:08:18 +0000 Subject: [Koha-bugs] [Bug 23055] Internal server error when trying to pay selected charges in fines accountant In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23055 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #3 from Claudio --- It's a template issue. Sorry. I will check again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 18:27:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 16:27:02 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #15 from Martin Renvoize --- Might this be a good opportunity to introduce a proper foreign key constraint at the DB level for issues.branchcode and old_issues.branchcode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 18:29:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 16:29:19 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22683 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 18:29:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 16:29:19 +0000 Subject: [Koha-bugs] [Bug 22683] Make issue and old_issue prefetchable from Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22683 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15985 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 19:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 17:29:17 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #48 from Tom?s Cohen Arazi --- (In reply to Michael Kuhn from comment #47) > When updating from Koha 18.11 to Koha 19.05 the update process says: > > Upgrade to 18.12.00.025 done (Bug 21846 - Using emoji as tags has broken > weights) > WARNING: (Bug 21846) You need to manually run > /usr/share/koha/intranet/cgi-bin/misc/maintenance/fix_tags_weight.pl to fix > possible issues with tags. > > But in fact the script "fix_tags_weight.pl" is located at > "/usr/share/koha/bin/maintenance/fix_tags_weight.pl". Thanks for reporting it. I will file a new bug for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 19:31:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 17:31:03 +0000 Subject: [Koha-bugs] [Bug 23056] New: Wrong path for fix_tags_weight.pl in updatedatabase.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23056 Bug ID: 23056 Summary: Wrong path for fix_tags_weight.pl in updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The displayed path is wrong on non-dev setups. This as introduced by bug 21846. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 19:31:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 17:31:11 +0000 Subject: [Koha-bugs] [Bug 23056] Wrong path for fix_tags_weight.pl in updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23056 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |21846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 19:31:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 17:31:11 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23056 [Bug 23056] Wrong path for fix_tags_weight.pl in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 20:40:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 18:40:24 +0000 Subject: [Koha-bugs] [Bug 23057] New: If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Bug ID: 23057 Summary: If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- Because of the way the alert suppression was implemented on bug 15221, the alert flag is suppressed for any and all reasons if checked_in_ok is set and the item is not checked out. This is problematic because the alert flag may be set because the item has been trapped for a hold or another reasons not related to its checked in status. Because of this, SIP AMHs ( automated material handlers iirc ) will send the items to be reshelved instead of sending them to the hold shelf. This code needs to be made aware of the reason the alert flag was triggered or not ( and probably a list of the reasons it was triggered ). That way if the only reason the flag was triggered is due to the item not being checked out, the SIP server can suppress the flag correctly, and allow it to be flagged if there are other reason to raise the alert flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 20:40:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 18:40:45 +0000 Subject: [Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23057 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 20:40:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 18:40:45 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15221 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 [Bug 15221] SIP server always sets the alert flag when item not returned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 21:01:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 19:01:12 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #58 from robbinsk at middlesex.mass.edu --- I would like to see the Long Overdue(Lost) and Lost status changed when the item is renewed. We do not allow our patrons to renew lost items but our staff is allowed to override the renewal limit and set a new due date. It is confusing to staff because we can see the new due date but the status is still Lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 21:31:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 19:31:07 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 22:26:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 20:26:02 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #6 from Nick Clemens --- Created attachment 90341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90341&action=edit Bug 22924: [alternate] Make elasticsearch honour FacetMaxCount system preference We have a line in QueryBuilder to respect the preference if a facet is expanded, it seems we forgot to pass the option to the querybuilder however To test: 1 - Enable Elasticsearch 2 - Set FacetMaxCount to 20 3 - Search in ES for '*' or something with a lot of results 4 - Expand some facets, note you get no more than 10 for any facet 5 - Apply patch 6 - Search again 7 - Expand facets, note they now go up to 20 8 - Try with various values of FacetMaxCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 22:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 20:26:23 +0000 Subject: [Koha-bugs] [Bug 23059] New: reserves_stats.pl needs overhaul Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Bug ID: 23059 Summary: reserves_stats.pl needs overhaul Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- This bug is sort of a catch-all for changes that need to be made to the holds statistic wizard, reserves_stats.pl Two big issues: - By default, the wizard sets a value for items.homebranch and items.holdingbranch. That means it unexpectedly cuts out all bib-level holds and gives no clear indication that it's done so. You *can* change home and holding branch to not limit, but it's not intuitive. - The wizard splits holds into 5 statuses (Placed, Processed, Pending, Satisfied, and Cancelled) that aren't used anywhere else in Koha. These statuses aren't explained without diving into the code and don't match how we otherwise divide and talk about holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 22:26:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 20:26:38 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 22:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 20:27:27 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- I propose an alternate patch - QueryBuilder should already respect the preference, as long as we pass an expanded facet It should have unit tests regardless of which patch we use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 22:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 20:27:46 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 22:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 20:33:09 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Ron Houk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhouk at ottumwapubliclibrary. | |org --- Comment #1 from Ron Houk --- I have run into issues with reserves_stats.pl mentioned by Andrew where no bib level holds were showing up, and I didn't understand why. I think it might be nice to make the defaults be so that all holds show up and then allow users to filter later on. It might also be nice to have an explanation of the different statuses in the documentation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 01:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2019 23:56:12 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- What about translation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:14:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:14:34 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:14:38 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 --- Comment #2 from Jonathan Druart --- Created attachment 90343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90343&action=edit Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER To make our sql mode list compatible with MySQL 8.0.11 NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html I do not think we needed it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:18:20 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:21:48 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Uh oh, that's no good. When I was writing the patch for 15221, I was looking at implementing the alert suppression a different way...looking at sub do_checkin in C4/SIP/ILS/Transaction/Checkin.pm, I see the following lines: my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, dt_from_string($return_date)); $self->alert(!$return); So we should revert the patch for 15221, and add $checked_in_ok to the params for sub do_checkin. And wrap that $self->alert(!$return); within a condition looking for $checked_in_ok. Not sure why I didn't do that originally. I was going to... but then I figured I'd try to centralize the changes with the existing use of $checked_in_ok. Bad call on my part. I'm super pressed for time at the moment, but I'll do up a quick patch with what I'm thinking and post it here for review... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:22:56 +0000 Subject: [Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #16 from David Cook --- Kyle's found a bug with this patch (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057). I'm going to provide a patch on that new report, but I'm under time pressure at the moment, so I'd be happy for someone else to take it over, or just revert this patch as it's probably causing more problems than it's fixing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:32:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:32:38 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #2 from David Cook --- Created attachment 90344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90344&action=edit Bug 23057: If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason This patch fixes a bug from Bug 15221 and hopefully also makes it so that the alert flag is suppressed when checked_in_ok is set and an item is not checked out. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp --port=6001 --address=localhost --item test -m checkin --patron NOTE: You need to replace with the borrowernumber from Step 2, and with the password from Step 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 02:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 00:33:46 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #3 from David Cook --- I haven't actually tested my patch or run the unit tests, but hopefully this is the solution. I have more urgent matters to attend to but I'll look back on this one as soon as I can. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 07:35:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 05:35:11 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #21 from sandboxes at biblibre.com --- Patch tested with a sandbox, by nabila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 07:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 05:35:28 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 07:35:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 05:35:35 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #22 from sandboxes at biblibre.com --- Created attachment 90346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90346&action=edit Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:10:37 +0000 Subject: [Koha-bugs] [Bug 23046] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 --- Comment #1 from Katrin Fischer --- *** Bug 23047 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:10:37 +0000 Subject: [Koha-bugs] [Bug 23047] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 23046 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:10:38 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 23047, which changed state. Bug 23047 Summary: Add tax handling to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:16:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:16:03 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79858|0 |1 is obsolete| | --- Comment #6 from paxed --- Created attachment 90347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90347&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:16:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:16:16 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:21:55 +0000 Subject: [Koha-bugs] [Bug 23047] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:22:07 +0000 Subject: [Koha-bugs] [Bug 23046] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:24:23 +0000 Subject: [Koha-bugs] [Bug 15235] Add column filters to checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:33:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:33:28 +0000 Subject: [Koha-bugs] [Bug 23061] New: Add column/print/export feature on checkout history page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Bug ID: 23061 Summary: Add column/print/export feature on checkout history page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Hi, on many page we have column/export/print toolbar. Not on checkout history page. Examples: Holds history: http://prntscr.com/ny8knt Checkouts history: http://prntscr.com/ny8lg4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:34:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:34:15 +0000 Subject: [Koha-bugs] [Bug 14166] exportable version of reading history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14166 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com Depends on| |23061 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 [Bug 23061] Add column/print/export feature on checkout history page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:34:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:34:15 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14166 [Bug 14166] exportable version of reading history -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:47:24 +0000 Subject: [Koha-bugs] [Bug 14166] exportable version of reading history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14166 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Michal Denar --- *** This bug has been marked as a duplicate of bug 23061 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:47:24 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Michal Denar --- *** Bug 14166 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:48:06 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:48:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:48:26 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:49:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:49:20 +0000 Subject: [Koha-bugs] [Bug 23046] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:49:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:49:20 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:49:44 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 08:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 06:49:44 +0000 Subject: [Koha-bugs] [Bug 23046] Add tax handling to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 09:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 07:22:41 +0000 Subject: [Koha-bugs] [Bug 23062] New: List of checked-in items disappared if there is transfer warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23062 Bug ID: 23062 Summary: List of checked-in items disappared if there is transfer warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- It isn't consistent because if hold warning, list is still present. And it's correct behaviour. Staff really need to see previous checked-in items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 09:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 07:22:53 +0000 Subject: [Koha-bugs] [Bug 23062] List of checked-in items disappared if there is transfer warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23062 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 09:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 07:23:09 +0000 Subject: [Koha-bugs] [Bug 23062] List of checked-in items disappared if there is transfer warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23062 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 09:50:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 07:50:41 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #9 from Alex Arnaud --- (In reply to Martin Renvoize from comment #8) > Created attachment 90304 [details] > Error > > Afraid I do still see this error.. attaching a screenshot Martin, URL is https://mana-kb... Not http://mana-kb. switching to https should solve your problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 09:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 07:53:33 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #10 from Alex Arnaud --- (In reply to Jonathan Druart from comment #2) > Looks ok for me as well, however on the confirmation screen, I get: > > Following information will be registered: > First Name: > Last Name: > E-Mail: > > (all empty) > > https://ui.mana-kb.koha-community.org/registration?id=XXX > > > Then I confirm and get: > > Error: seems like the token you try to activate (XXX) doesn't exist or is to > old All ok for me. Nothing empty and i get this confirmation message: "E-mail successfuly validated, token xxxx is now active." (on production server) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 10:02:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 08:02:56 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 10:02:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 08:02:59 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90337|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 90348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90348&action=edit Bug 23050: Plugin hook to add tabs in intranet biblio details page Test Plan: 1) Enable plugins 2) Download and install the latest version of this plugin https://git.biblibre.com/biblibre/koha-plugin-intranet-detail-hook 3) Browse to catalogue/detail.pl for a record 4) Note you see two new tabs with content Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:11:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:11:10 +0000 Subject: [Koha-bugs] [Bug 19598] ES configuration - Make the columns sortable/searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19598 axel Amghar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.amghar at biblibre.com Assignee|koha-bugs at lists.koha-commun |axel.amghar at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:24:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:24:37 +0000 Subject: [Koha-bugs] [Bug 23063] New: Add item does not respect CurrencyFormat Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Bug ID: 23063 Summary: Add item does not respect CurrencyFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Adding or editing an item, fields mapped to items.price and items.replacementprice do not obey CurrencyFormat. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:39:57 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at koha-suomi.fi --- Comment #3 from paxed --- Still valid, looks like. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:40:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:40:26 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Alex Arnaud --- (In reply to Katrin Fischer from comment #7) > (In reply to Michal Denar from comment #6) > > Hi Alex, > > patch works but if I follow ling filed Name, Last nname and e-mail are > > empty. I know it's on Mana server side ... Is it correct result? > > > > Thank you > > I've also got some problems with the sign-up process. In my koha-conf.xml I > have the mana test server, but when I register, the email I receive reads: > https://ui.mana-kb.koha-community.org/ > registration?id=aa1JLPnpz6vBshtSpm2f6yr4sKKmJZ26 > > And clicking on it it tells me my token is too old or doesn't exist? Good catch Katrin! I fixed that in the configuration. Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:39:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:39:40 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #9 from Alex Arnaud --- (In reply to Michal Denar from comment #6) > Hi Alex, > patch works but if I follow ling filed Name, Last nname and e-mail are > empty. I know it's on Mana server side ... Is it correct result? > > Thank you Fixed on Mana server side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:44:01 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #11 from Alex Arnaud --- (In reply to Alex Arnaud from comment #10) > (In reply to Jonathan Druart from comment #2) > > Looks ok for me as well, however on the confirmation screen, I get: > > > > Following information will be registered: > > First Name: > > Last Name: > > E-Mail: > > > > (all empty) > > > > https://ui.mana-kb.koha-community.org/registration?id=XXX > > > > > > Then I confirm and get: > > > > Error: seems like the token you try to activate (XXX) doesn't exist or is to > > old > > All ok for me. > Nothing empty and i get this confirmation message: > "E-mail successfuly validated, token xxxx is now active." > > (on production server) I got it! Mana test server was set up with production URL. So you was registering on test and try to confirm it on production one (thx Katrin for the catch). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:53:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:53:34 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #7 from Alex Arnaud --- Created attachment 90349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90349&action=edit Bug 22193: QA follow up - return undef instead of an array if no ressource id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 11:53:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 09:53:55 +0000 Subject: [Koha-bugs] [Bug 22193] Mana - share comments about reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 12:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 10:00:50 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 --- Comment #5 from Alex Arnaud --- Created attachment 90350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90350&action=edit Bug 22358: fix POD header and typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 12:01:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 10:01:20 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 12:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 10:18:17 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #12 from Martin Renvoize --- Aha, excellent.. it sounds like you found the issue.. I'll have a quick test and report back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:12:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:12:09 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #81 from Nick Clemens --- I think Jonathan had agreement, setting this as FQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:21:19 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:21:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:21:22 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90346|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 90351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90351&action=edit Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:39:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:39:15 +0000 Subject: [Koha-bugs] [Bug 23064] New: Cannot add edit subscription with strict SQL modes turned on Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Bug ID: 23064 Summary: Cannot add edit subscription with strict SQL modes turned on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- bug 22812 fixed the values when adding a new subscription, however, editing a subscription throws errors like: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'innerloop1' if all numbering pattern values are not set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:39:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:39:23 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot add edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:45:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:45:00 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85773|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 90352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90352&action=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:45:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:45:06 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85775|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 90354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90354&action=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:45:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:45:04 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85774|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 90353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90353&action=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:45:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:45:34 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:46:00 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:49:58 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #16 from Kyle M Hall --- (In reply to Martin Renvoize from comment #15) > Might this be a good opportunity to introduce a proper foreign key > constraint at the DB level for issues.branchcode and old_issues.branchcode? Sounds like a capital idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 13:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 11:51:57 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #17 from Martin Renvoize --- I'm resurrecting bug 22421 for the FK piece at the minute.. may also be nice to have bug 22683 feed into this too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:07:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:07:09 +0000 Subject: [Koha-bugs] [Bug 23065] New: 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Bug ID: 23065 Summary: 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- I don't know if this is expected behvaiour, but it feels like a bug - at the very least the label of the button should change? Or I would think 2 buttons 'New Subscription' and 'New subscription for this serial' To recreate: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created 6 - Click 'New subscription' 7 - You get a form populated with the biblio of the last subscription you created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:07:20 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:10:31 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:10:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:10:34 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90323|0 |1 is obsolete| | Attachment #90324|0 |1 is obsolete| | Attachment #90325|0 |1 is obsolete| | --- Comment #26 from Nick Clemens --- Created attachment 90355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90355&action=edit Bug 10215: Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. Rescued-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:10:38 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #27 from Nick Clemens --- Created attachment 90356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90356&action=edit Bug 10215: (follow-up) Correct existing data This patch adds the correction of data ('' => NULL) during the DB update. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:10:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:10:41 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #28 from Nick Clemens --- Created attachment 90357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90357&action=edit Bug 10215: (follow-up) Fix the failing test We now handle NULL values at the database end and do not expect empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:11:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:11:27 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #29 from Nick Clemens --- Just noting: If you save a note, then blank it, the DB value is '' instead of NULL -I don't think that is an issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:16:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:16:58 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:26:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:26:24 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90352|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 90359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90359&action=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:26:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:26:27 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90353|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 90360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90360&action=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:26:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:26:30 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90354|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 90361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90361&action=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:26:33 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #12 from Martin Renvoize --- Created attachment 90362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90362&action=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:27:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:27:44 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:31:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:31:51 +0000 Subject: [Koha-bugs] [Bug 16219] Runreport.pl should allow sql paramters to be passed on the command line. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:31:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:31:54 +0000 Subject: [Koha-bugs] [Bug 16219] Runreport.pl should allow sql paramters to be passed on the command line. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78434|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 90363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90363&action=edit Bug 16219: Add 'params' parameter to runreport.pl To test: 1 - Apply patch 2 - Write a report that takes no variables 3 - Run this using runreport.pl perl misc/cronjobs/runreport.pl 1 4 - Confirm results as expected 5 - Write a report that takes one or more variables 6 - Run using runreport.pl, but pass no params 7 - You should get a SQL error 8 - Now run passing the correct number of params perl misc/cronjobs/runreport.pl --param first --param=2nd 2 9 - Verify results as expected 10 - call runreport with no parameters perl misc/cronjobs/runreport.pl 11 - Verify documentation is correct and helpful Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 14:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 12:42:53 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #18 from Kyle M Hall --- Created attachment 90364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90364&action=edit Bug 15985: Add foreign key for issues tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:09:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:09:08 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:09:13 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90359|0 |1 is obsolete| | Attachment #90360|0 |1 is obsolete| | Attachment #90361|0 |1 is obsolete| | Attachment #90362|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 90365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90365&action=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:09:23 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #14 from Kyle M Hall --- Created attachment 90366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90366&action=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:09:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:09:26 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #15 from Kyle M Hall --- Created attachment 90367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90367&action=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:09:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:09:28 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #16 from Kyle M Hall --- Created attachment 90368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90368&action=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:20:12 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 --- Comment #2 from Owen Leonard --- Created attachment 90369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90369&action=edit Bug 23061: Add column/print/export feature on checkout history page This patch adds columns configuration and export features to the checkout history page. This patch also removes some inline CSS: "overflow:hidden" from both the checkout and holds history pages. This was breaking the table controls tooltips, and didn't appear to me to be necessary. To test, apply the patch and restart Plack (or restart_all on kohadevbox). - Open a patron's checkout history page in the staff client. - The table of checkouts should have controls at the top. for columns configuration and export/print. - These controls should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:20:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:20:09 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:21:21 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:28:17 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89249|0 |1 is obsolete| | Attachment #89250|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 90370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90370&action=edit Bug 18829: Elasticsearch - Put a better display for the view of ES indexed record To test: - apply the patch - go to global sysPref - make sure that SearchEngine have "ElasticSearch" as value - Search whatever you want in Search the catalog and select a record - Search the link (Ctrl f) : "Elasticsearch Record :" , click on the link - make sure that the pop-up open and you should see the elasticsearch result in JSON (the pop-up look the same as MARC preview) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:30:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:30:55 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #9 from Nick Clemens --- Squashed as axel rewrote my patch :-) Some issues: 1 - Missing filter from QA tool - this is tricky too - if I add to the title I can break the view - we need to make sure the JOSN can't break 2 - We should order the view, at least for _source - this could be later enhancement, but would make it much easier to read -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:31:38 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90364|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Comment on attachment 90364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90364 Bug 15985: Add foreign key for issues tables We should move this patch to its' own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:38:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:38:56 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90369|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 90371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90371&action=edit Bug 23061: Add column/print/export feature on checkout history page This patch adds columns configuration and export features to the checkout history page. This patch also removes some inline CSS: "overflow:hidden" from both the checkout and holds history pages. This was breaking the table controls tooltips, and didn't appear to me to be necessary. To test, apply the patch and restart Plack (or restart_all on kohadevbox). - Open a patron's checkout history page in the staff client. - The table of checkouts should have controls at the top. for columns configuration and export/print. - These controls should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:41:10 +0000 Subject: [Koha-bugs] [Bug 23066] New: Add foreign key for issues tables to branches table for branchcodes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 Bug ID: 23066 Summary: Add foreign key for issues tables to branches table for branchcodes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We should really have foreign key constrains between the branches table and the issues and old_issues tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:42:28 +0000 Subject: [Koha-bugs] [Bug 23066] Add foreign key for issues tables to branches table for branchcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 --- Comment #1 from Kyle M Hall --- Created attachment 90372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90372&action=edit Bug 23066: Add foreign key for issues tables to branches table for branchcodes - Update DB We should really have foreign key constrains between the branches table and the issues and old_issues tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:42:53 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 [Bug 23066] Add foreign key for issues tables to branches table for branchcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:42:53 +0000 Subject: [Koha-bugs] [Bug 23066] Add foreign key for issues tables to branches table for branchcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 [Bug 15985] Include transacting library in fines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:43:53 +0000 Subject: [Koha-bugs] [Bug 23066] Add foreign key for issues tables to branches table for branchcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90372|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 90373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90373&action=edit Bug 23066: Add foreign key for issues tables to branches table for branchcodes - Update DB We should really have foreign key constrains between the branches table and the issues and old_issues tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:45:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:45:01 +0000 Subject: [Koha-bugs] [Bug 23066] Add foreign key for issues tables to branches table for branchcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90373|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 90374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90374&action=edit Bug 23066: Add foreign key for issues tables to branches table for branchcodes - Update DB We should really have foreign key constrains between the branches table and the issues and old_issues tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 15:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 13:51:57 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:00:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:00:48 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:00:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:00:51 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90371|0 |1 is obsolete| | --- Comment #4 from Michal Denar --- Created attachment 90375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90375&action=edit Bug 23061: Add column/print/export feature on checkout history page This patch adds columns configuration and export features to the checkout history page. This patch also removes some inline CSS: "overflow:hidden" from both the checkout and holds history pages. This was breaking the table controls tooltips, and didn't appear to me to be necessary. To test, apply the patch and restart Plack (or restart_all on kohadevbox). - Open a patron's checkout history page in the staff client. - The table of checkouts should have controls at the top. for columns configuration and export/print. - These controls should work correctly. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:46 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:49 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #30 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:51 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:53 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #24 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:54 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:56 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:27:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:27:58 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:28:00 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:32:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:32:56 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:32:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:32:59 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #2 from Nick Clemens --- Created attachment 90376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90376&action=edit Bug 22585: remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:33:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:33:24 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:36:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:36:33 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:37:51 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #4 from Kyle M Hall --- Created attachment 90377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90377&action=edit Bug 23057: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:44:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:44:30 +0000 Subject: [Koha-bugs] [Bug 22862] Normalize SMS messaging numbers before validating them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes it release notes| |easier to paste in patron | |phone numbers as it will | |attempt to normalize out | |illegal characters often | |used to human-friendly | |formatting. CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:46:35 +0000 Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:49:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:49:25 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:53:09 +0000 Subject: [Koha-bugs] [Bug 23067] New: in Opac Confirm holds page the Last location column is empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Bug ID: 23067 Summary: in Opac Confirm holds page the Last location column is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- In opac-reserve.pl click on 'Show more options' select 'A specific item' Then you'll see a table with a column 'Last location' (holdingbranch) always empty if homebranch = holdingbranch. It would be better if this column shows always this location. opac/opac-reserve.pl # If the holdingbranch is different than the homebranch, we show the # holdingbranch of the document too. if ( $itemInfo->{homebranch} ne $itemInfo->{holdingbranch} ) { $itemLoopIter->{holdingBranchName} = $itemInfo->{holdingbranch}; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 16:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 14:59:53 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:02:03 +0000 Subject: [Koha-bugs] [Bug 22910] Do not copy unique patron attributes to duplicated patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:02:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:02:46 +0000 Subject: [Koha-bugs] [Bug 22910] Unique attributes should not be copied when duplicating a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do not copy unique patron |Unique attributes should |attributes to duplicated |not be copied when |patron |duplicating a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:05:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:05:14 +0000 Subject: [Koha-bugs] [Bug 22867] UniqueItemFields preference value should be pipe-delimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:08:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:08:13 +0000 Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 --- Comment #6 from Alex Arnaud --- Created attachment 90378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90378&action=edit Bug 22249: Mana - Move comment process in a dedicated sub -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:09:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:09:08 +0000 Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Attachment #90378|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:09:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:09:50 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #3 from Alex Arnaud --- Created attachment 90379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90379&action=edit Bug 22249: Mana - Move comment process in a dedicated sub https://bugs.koha-community.org/show_bug.cgi?id=22259 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:35 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:37 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 --- Comment #15 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:39 +0000 Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:41 +0000 Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:42 +0000 Subject: [Koha-bugs] [Bug 22867] UniqueItemFields preference value should be pipe-delimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:44 +0000 Subject: [Koha-bugs] [Bug 22867] UniqueItemFields preference value should be pipe-delimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:46 +0000 Subject: [Koha-bugs] [Bug 22910] Unique attributes should not be copied when duplicating a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:10:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:10:48 +0000 Subject: [Koha-bugs] [Bug 22910] Unique attributes should not be copied when duplicating a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:11:01 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90379|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud --- Created attachment 90380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90380&action=edit Bug 22249: Mana - Move comment process in a dedicated sub -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:11:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:11:28 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:16:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:16:56 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:16:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:16:59 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24891|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 90381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90381&action=edit Bug 11642: Add confirmation and tooltips to batch deletion tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:18:38 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Just trying to revive this one - this doesn't go as far as Kyle suggests, but at least adds a warn. I think we could do a second bug to add a permission to permanently delete to make the tool a bit safer generally? Also, we should probably add a check so you can't delete your own record (the account that is signed in) with this tool? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 17:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 15:43:18 +0000 Subject: [Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Runreport.pl should allow |Runreport.pl should allow |sql paramters to be passed |SQL parameters to be passed |on the command line. |on the command line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:31:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:31:01 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:34:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:34:20 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:37:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:37:35 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #26 from Martin Renvoize --- This introduces JSON files to the /preferences directory.. as such we'll need to update xt/yaml_valid.t to be a little more intelligent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:43:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:43:15 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:43:18 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90377|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 90384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90384&action=edit Bug 23057: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:43:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:43:28 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #6 from Kyle M Hall --- Created attachment 90385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90385&action=edit Bug 23057: Update subroutine so tests pass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 18:47:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 16:47:09 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Laurie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmckee at littleelm.org --- Comment #111 from Laurie --- Is this bug still in process? We could really use the granularity to assign different wait items on different item types. Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:06:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:06:33 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:09:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:09:30 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:16:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:16:31 +0000 Subject: [Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #56 from Nick Clemens --- *** Bug 13812 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:16:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:16:31 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Nick Clemens --- Seems to be fixed in master *** This bug has been marked as a duplicate of bug 21526 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:22:18 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #1 from Owen Leonard --- This is ready for testing, bug Bugzilla rejects the patches because of the size. I've posted the branch here: https://gitlab.com/koha-dev/koha-dev/tree/bug-23013-datatables-upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:29:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:29:58 +0000 Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Do we need this now since we have customizable alerts? Users can simply add links to any additional sounds Looks like they came from here: http://soundbible.com/2084-Glass-Ping.html http://soundbible.com/2067-Blop.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:41:10 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot add edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 --- Comment #2 from Jonathan Druart --- Created attachment 90387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90387&action=edit Bug 23064: Fix mod subscription with strict sql modes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:41:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:41:06 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot add edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 --- Comment #1 from Jonathan Druart --- Created attachment 90386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90386&action=edit Bug 23064: Add tests This param list is scary! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:44:06 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot add edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Jonathan Druart --- I have lost too much time with the argument list! They differ from NewSubscription for no good reasons, it's insane. This patch is not ready for 2 reasons: - The returned value is not correct ($modified is not correctly named) and is a change in the behavior (not sure it matters are it is never checked). However the tests is wrong as it does not test anything. - There is a warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. I think it's related to bug 21761, that need to be fixed ASAP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:45:31 +0000 Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:48:57 +0000 Subject: [Koha-bugs] [Bug 22626] 'Filter paid transactions' broken on Transactions tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:53 +0000 Subject: [Koha-bugs] [Bug 21013] Missing itemtype for checkut makes patron summary print explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:53 +0000 Subject: [Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:54 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Bug 12561 depends on bug 22695, which changed state. Bug 22695 Summary: Remove non-XSLT search results view from the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:54 +0000 Subject: [Koha-bugs] [Bug 22697] Reindent catalogue/result.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Bug 22697 depends on bug 22695, which changed state. Bug 22695 Summary: Remove non-XSLT search results view from the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:55 +0000 Subject: [Koha-bugs] [Bug 13629] SingleBranchMode removes both library and availability search from advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:55 +0000 Subject: [Koha-bugs] [Bug 22716] Use gender-neutral pronouns in system preference descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22716 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:56 +0000 Subject: [Koha-bugs] [Bug 14358] Changing the module refreshes the page and resets library choice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14358 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:56 +0000 Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:57 +0000 Subject: [Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:57 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:58 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Bug 22560 depends on bug 22561, which changed state. Bug 22561 Summary: Forgotten password requirements hint doesn't list all rules for new passwords https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:58 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:59 +0000 Subject: [Koha-bugs] [Bug 22881] Trying to clear search history via the navbar X doesn't clear any searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22881 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:53:59 +0000 Subject: [Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:54:00 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:54:00 +0000 Subject: [Koha-bugs] [Bug 21089] Overlapping elements in ordering information on acqui/supplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:54:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:54:01 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 19:54:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 17:54:02 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 20:04:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 18:04:58 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90385|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 90388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90388&action=edit Bug 23057: Update do_checkin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 20:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 18:28:05 +0000 Subject: [Koha-bugs] [Bug 10199] Move fields type, options and explanation from systempreferences table? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 20:52:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 18:52:09 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot add edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21761 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 20:52:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 18:52:09 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23064 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:00:37 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88364|0 |1 is obsolete| | --- Comment #81 from Nadine Pierre --- Created attachment 90389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90389&action=edit Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:00:46 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88365|0 |1 is obsolete| | --- Comment #82 from Nadine Pierre --- Created attachment 90390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90390&action=edit Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:00:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:00:52 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88366|0 |1 is obsolete| | --- Comment #83 from Nadine Pierre --- Created attachment 90391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90391&action=edit Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:01:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:01:00 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88367|0 |1 is obsolete| | --- Comment #84 from Nadine Pierre --- Created attachment 90392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90392&action=edit Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:02:35 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Assignee|kyle.m.hall at gmail.com |koha-bugs at lists.koha-commun | |ity.org CC| |nick at bywatersolutions.com Resolution|--- |WONTFIX --- Comment #7 from Nick Clemens --- Not sponsored, no current work planned here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:03:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:03:01 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nadine.pierre at InLibro.com Status|Failed QA |Needs Signoff --- Comment #85 from Nadine Pierre --- I rebased the patches against master. Ready to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:12:17 +0000 Subject: [Koha-bugs] [Bug 23068] New: Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Bug ID: 23068 Summary: Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Koha has a number of features that rely on knowing the IP address of the connecting client. If that server is behind a proxy these features do not work. We can use Plack::Middleware::RealIP to automatically convert the X-Forwarded-For header into the REMOTE_ADDR environment variable so no Koha code need be modified. A future enhancement could be to take advantage of the module's trusted_proxy setting to allow Koha to use these feature even after going through *multiple* proxies. This would require being able to read configuration from the plack.psgi file and is beyond the scope of this enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:12:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:12:27 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:22:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:22:06 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:22:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:22:09 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #7 from Nick Clemens --- Created attachment 90393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90393&action=edit Bug 8260: user rank order instead of absolute rank to set dropdowns on routing.pl When deleting a borrower on a routing list we leave a gap in the numbering. It appears to only be a problem when viewing or editing the list in the staff client. Rather than use the rank in the DB to set the values, we use the implicit order To test: 1 - Create a subscription (or find one) 2 - Add a routing list 3 - Add five patrons 4 - Delete the patron who is third in the list 5 - Edit the routing list 6 - Note the priority for the last patron is 1 7 - Apply patch 8 - Reload the page 9 - Values look correct 10 - Confirm reordering works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:22:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:22:30 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:24:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:24:33 +0000 Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |WONTFIX --- Comment #10 from Nick Clemens --- MyISAM does not support transactions, this route seems to have dead ended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:31:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:31:59 +0000 Subject: [Koha-bugs] [Bug 23069] New: More pratical order for columns on the cataloging board Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23069 Bug ID: 23069 Summary: More pratical order for columns on the cataloging board Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Created attachment 90394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90394&action=edit item display in cataloging Hi, Some librarians are asking if can change the order of columns when we are modifying item in cataloging. More precisely, the problem is the "material" column is far from the "copy number" column. This can be confusing when we are in batch items modification. I let an image which is in french. (Material is "Mat?riel d?sign?" and copy number is "Num?ro d'exemplaire".) Thanks you, Alexandre -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:35:52 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #1 from Kyle M Hall --- Actually, we can use an environment variable so I'm increasing the scope to include setting the list of proxies! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:41:41 +0000 Subject: [Koha-bugs] [Bug 23062] List of checked-in items disappared if there is transfer warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23062 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Michal Denar --- I'm sorry. I'm not able to reproduce this on 19.05 and master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:42:28 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:42:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:42:31 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #2 from Kyle M Hall --- Created attachment 90395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90395&action=edit Bug 23068: [DO NOT PUSH] Add debugging to C4::Context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:42:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:42:47 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #3 from Kyle M Hall --- Created attachment 90396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90396&action=edit Bug 23068 - Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy Koha has a number of features that rely on knowing the IP address of the connecting client. If that server is behind a proxy these features do not work. We can use Plack::Middleware::RealIP to automatically convert the X-Forwarded-For header into the REMOTE_ADDR environment variable so no Koha code need be modified. We can take advantage of the module's trusted_proxy setting to allow Koha to use these feature even after going through *multiple* proxies. TEST PLAN: 1) Apply this patch set 2) Install Plack::Middleware::RealIP via cpanm or your favorite utility 3) Update your plack.psgi with the changes you find in this patch set ( this process differs based on your testing environment ) 4) Restart plack 5) Tail the plack error log for your instance 6) Use curl to access the OPAC, adding an X-Forwarded-For header: curl --header "X-Forwarded-For: 32.32.32.32" http://127.0.0.1:8080 7) Note the logs output this address if you are unproxied 8) If you are proxied, restart plack using a command like below, where the ip you see in the logs is what you put in the environment variable: KOHA_TRUSTED_PROXIES="172.22.0.1 1.1.1.1" koha-plack --restart kohadev 9) Repeat step 6 7) You should now see 32.32.32.32 as the remote address in your logs! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:53:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:53:20 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #7 from Jonathan Druart --- Created attachment 90397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90397&action=edit Bug 9834: Add DB changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:53:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:53:25 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #8 from Jonathan Druart --- Created attachment 90398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90398&action=edit Bug 9834: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:53:29 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #9 from Jonathan Druart --- Created attachment 90399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90399&action=edit Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 21:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 19:53:16 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:02:28 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:13:04 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:13:57 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:13:57 +0000 Subject: [Koha-bugs] [Bug 23070] New: Use Koha::Hold in C4::Reserves::RevertWaitingStatus Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Bug ID: 23070 Summary: Use Koha::Hold in C4::Reserves::RevertWaitingStatus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 9834 Target Milestone: --- We are using raw SQL statements, we should use Koha::Hold instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:14:39 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:15:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:15:58 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #1 from Jonathan Druart --- Created attachment 90400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90400&action=edit Bug 23070: Use Koha::Hold in C4::Reserves::RevertWaitingStatus We are using raw SQL statements, we should use Koha::Hold instead. This patch does not seem optimal, we would like to increment priority in only 1 statement and without the need to fetch and loop all holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:16:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:16:51 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- I am missing a DBIx::Class trick to make this better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:34:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:34:20 +0000 Subject: [Koha-bugs] [Bug 22027] Upload cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22027 --- Comment #9 from Jonathan Druart --- Hi Frederico, did you finally fix your issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:40:25 +0000 Subject: [Koha-bugs] [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:40:25 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:42:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:42:20 +0000 Subject: [Koha-bugs] [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #2 from Jonathan Druart --- I'd say that code related to AllowHoldsOnPatronsPossessions (from reserve/request.pl and opac/opac-reserve.pl) must be moved to C4::Reserves::CanBookBeReserved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:42:53 +0000 Subject: [Koha-bugs] [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 [Bug 9206] Only allow place holds in records that the patron don't have in his possession -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:42:53 +0000 Subject: [Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 22:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 20:44:06 +0000 Subject: [Koha-bugs] [Bug 21219] NULL values in updated_on field break the Patrons REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:13:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:13:33 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:28:31 +0000 Subject: [Koha-bugs] [Bug 23071] New: New options for erasing circulation history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23071 Bug ID: 23071 Summary: New options for erasing circulation history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Hi, We wondering if it could be possible to add some options to erase circulation history for one patron at the time. An other option would be to able to erase this history when we forgive overdue charges for a patron (at the same time) on check in page in circulation module. Thanks, Alexandre -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:33:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:33:16 +0000 Subject: [Koha-bugs] [Bug 23072] New: Certificate invalid for lists.koha-community.org Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 Bug ID: 23072 Summary: Certificate invalid for lists.koha-community.org Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The SSL certificate for https://lists.koha-community.org/ is coming up as invalid as it has expired. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:33:54 +0000 Subject: [Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 --- Comment #1 from David Nind --- Created attachment 90401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90401&action=edit 1 - Error message in Google Chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:34:23 +0000 Subject: [Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 --- Comment #2 from David Nind --- Created attachment 90402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90402&action=edit 2 - Error message in Firefox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:34:49 +0000 Subject: [Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 --- Comment #3 from David Nind --- Created attachment 90403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90403&action=edit 3 - Certificate information in Google Chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:35:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:35:17 +0000 Subject: [Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 --- Comment #4 from David Nind --- Created attachment 90404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90404&action=edit 4 - Certificate details in Firefox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:36:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:36:12 +0000 Subject: [Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea at gmail.com |paul.poulain at biblibre.com Priority|P5 - low |P2 CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:41:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:41:12 +0000 Subject: [Koha-bugs] [Bug 23073] New: wiki.koha-community.org needs updating to a later version Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 Bug ID: 23073 Summary: wiki.koha-community.org needs updating to a later version Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The version of Wikimedia used for https://wiki.koha-community.org needs updating. Current version information: https://wiki.koha-community.org/wiki/Special:Version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:45:58 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #1 from David Nind --- See discussion on IRC: - http://irc.koha-community.org/koha/2019-06-06#i_2149184 and - http://irc.koha-community.org/koha/2019-06-06#i_2149465 A blocker for updating in the past seems to have been the CategoryTree extension and other extensions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:48:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:48:19 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #2 from David Nind --- I am happy to help with testing, including doing a test upgrade locally to see what the issues are, and mapping out a plan for updating. This would require a database dump and the site files - not sure what the security implications are of this as the database would include user name and password information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 6 23:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jun 2019 21:48:58 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea at gmail.com |gmc at esilibrary.com CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:15:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:15:36 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:15:39 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90320|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 90405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90405&action=edit Bug 23045: TextMarc errors on blank lines Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when processing blank lines. We should just pass on these rather then erroring To test: 1 - Define a new macro that delete more fields than it adds delete 245 2 - Run it 3 - Note an error in JS console, and helpers will not load 4 - Apply patch 5 - Reload, try again 6 - No error Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:42:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:42:39 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |pasi.kallinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:42:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:42:32 +0000 Subject: [Koha-bugs] [Bug 23074] New: Holds table sort does not understand dateformat Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Bug ID: 23074 Summary: Holds table sort does not understand dateformat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:46:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:46:56 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:46:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:46:43 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 --- Comment #1 from paxed --- Created attachment 90406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90406&action=edit Bug 23074: Holds table sort does not understand dateformat Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. Test plan: 1) Create multiple holds for a patron with different hold creation and expiration dates, with different years, months and days. 2) Change the dateformat to DD.MM.YYYY. 3) Resort the holds table (in circ/circulation or members/moremember) by the hold date or expiration date. The table sorts the date by the day number. 4) Apply patch 5) Redo 3 - the table now sorts correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:53:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:53:30 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #27 from Martin Renvoize --- Created attachment 90407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90407&action=edit Bug 22844: (QA follow-up) Build items.json for UniqueItemFields Adding items.json, built from latest kohastructure.sql. Control UniqueItemFields with this source file. And add StatisticsFields. Test plan: Go to Preferences, play with UniqueItemFields. Adjust StatisticsFields and look at patron record, statistics tab. Moved-from: Bug 22867 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:55:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:55:29 +0000 Subject: [Koha-bugs] [Bug 22867] UniqueItemFields preference value should be pipe-delimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 --- Comment #10 from Martin Renvoize --- I have reverted the QA follow-up and copied it across into bug 22844 and reversed the dependencies. It seemed pertinent to get this consistency fix in place as it had already passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:56:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:56:13 +0000 Subject: [Koha-bugs] [Bug 22867] UniqueItemFields preference value should be pipe-delimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22844 | Blocks| |22844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:56:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:56:13 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22867 | Depends on| |22867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 [Bug 22867] UniqueItemFields preference value should be pipe-delimited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 08:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 06:59:05 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:04:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:04:46 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:30:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:30:37 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #28 from Martin Renvoize --- It feels like we're starting to mix concerns a bit here. I would suggest splitting the `BorrowerMandatoryField` handling back out of this bug and putting it in bug 22728 and letting this bug start moving forward again. Perhaps we could add the free text box itself into the bottom of the modal and track it's content to match the checkbox selection with some clever JS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:39:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:39:41 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #13 from Martin Renvoize --- Right.. so it does work now as long as I change koha-conf to point to the https URL. However.. I do still think there's a couple of bugs here. Firstly: looking at master, 'etc/koha-conf.xml' which is used as part of the make process still points to 'http' so by default people using the make process to install will be getting an incorrect default config. Secondly: The error here is meaningless.. we should be able to catch a bad URL earlier and give a much more meaningful error.. I wasn't sure whether it was the Mana service that was down, a Koha end bug or what. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:50:42 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85849|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 90408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90408&action=edit Bug 20292: Filter/censor info sent via SIP Some libraries would like to limit the amount of personal information a SIP server sends to arbitrary parties on a per-login basis. Test Plan: 1) Add a new key/value pair to one of your existing login stanzas in your SIP config file For example: hide_fields="BD,BE,BF,PB" 2) Restart SIP 3) Send a SIP message that would normally return those fields ( in this example, a Patron Information Request ) 4) Note the response has had those fields removed Signed-off-by: Kyle M Hall Signed-off-by: Christopher Davis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:50:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:50:39 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:51:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:51:35 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #14 from Katrin Fischer --- Is there a reason we have the URL in koha-conf.xml? It might be nice to store it in a pref. But I might be missing something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:52:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:52:41 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 --- Comment #12 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #10) > I see no reason to override a librarian's ability to scrub any particular > SIP field. That just makes the feature inconsistent, and for all we know > maybe there *will* be a scenario where a library needs to not send those > fields to a particular service. In the assumption that we are not stripping fields that the SIP standard dictates, I guess you are right. And if we do, we should not ;) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:52:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:52:48 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 09:56:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 07:56:16 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 --- Comment #13 from Marcel de Rooy --- Note to RM: We should be a bit careful with future SIP patches that still have the old maybe_add behavior in mind? In some cases they should use add_field now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:18:28 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #15 from Alex Arnaud --- Created attachment 90409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90409&action=edit Bug 22915: fix Mana URL in etc/koha-conf.xml -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:21:04 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #16 from Alex Arnaud --- (In reply to Katrin Fischer from comment #14) > Is there a reason we have the URL in koha-conf.xml? It might be nice to > store it in a pref. But I might be missing something. 1) IMO for consistency. All external backends/services URI are defined in koha-conf.xml (elasticsearch, pazpar2 etc...). 2) To prevent an other system preference :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:22:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:22:39 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #17 from Alex Arnaud --- (In reply to Martin Renvoize from comment #13) > Right.. so it does work now as long as I change koha-conf to point to the > https URL. > > However.. I do still think there's a couple of bugs here. > > Firstly: looking at master, 'etc/koha-conf.xml' which is used as part of the > make process still points to 'http' so by default people using the make > process to install will be getting an incorrect default config. Fixed in the attached patch > > Secondly: The error here is meaningless.. we should be able to catch a bad > URL earlier and give a much more meaningful error.. I wasn't sure whether it > was the Mana service that was down, a Koha end bug or what. Not a blocker for me. This can be done in a separate BZ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:22:35 +0000 Subject: [Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #11 from Martin Renvoize --- It feels like it could be some fun with dh_compress.. history.txt (until very recently) was the only file mentioned in the exclude list there.. I can't find any other reason it may be treated differently to other files. I want to check what the two new files added to the exclude list look like on Ubuntu to test my theory. Reopening as the fix in koha-testing-docker is no longer working since we tidied up that project.. time to revisit the core issue here I tihnk. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:23:21 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:25:41 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #18 from Martin Renvoize --- Thanks Alex, I'm game with that, the /etc/ fix is nice to have here and I'm not worried about it staying in koha-conf for now... (if we do end up with lots of mana servers hosted by the various support companies, my opinion on it being converted to a pref may change). Also happy to have a nicer fix for the error message done in a distinct bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:27:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:27:02 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch --- Comment #19 from Martin Renvoize --- As a string patch I'm going to go straight for PQA here and push it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:27:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:27:12 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:28:00 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90409|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 90410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90410&action=edit Bug 22915: fix Mana URL in etc/koha-conf.xml Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:28:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:28:40 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:28:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:28:41 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 --- Comment #21 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:31:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:31:04 +0000 Subject: [Koha-bugs] [Bug 23075] New: Incorrect URL should have a meaningful error message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Bug ID: 23075 Summary: Incorrect URL should have a meaningful error message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com Target Milestone: --- Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:31:21 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22915 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:31:21 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23075 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 10:41:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 08:41:35 +0000 Subject: [Koha-bugs] [Bug 22248] Error when incrementing Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:21:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:21:25 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:21:27 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 --- Comment #3 from Nick Clemens --- Created attachment 90411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90411&action=edit Bug 23045: Return record along with errors We don't seem to directly handle the errors in most cases, let's always return the record To test: 1 - Add some blank lines to editor, previous patch is okay with this 2 - Add a line with just 'e' or some other incomplete field 3 - Try to save 4 - Note JS leader error 5 - Apply this patch 6 - No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:24:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:24:57 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:24:59 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90336|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 90412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90412&action=edit Bug 23053: Add phrase index to authority Local-Number To test: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 7 - Apply patch 8 - Copy the indexdefs files to the installed versions 9 - Reapply matchign rules to staged files 10 - Matches should now be found 11 - Logs should not have errors Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:27:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:27:22 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #11 from Nick Clemens --- (In reply to Humberto Blanco from comment #10) > Dear all, > this script uses sendmail, but we are using Mail::Sendmail ani idea to > patch this? > > Humberto, I am not sure what the problem is? If still relevant please open a new bug for discussion. Closing this one out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:29:22 +0000 Subject: [Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|In Discussion |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:29:55 +0000 Subject: [Koha-bugs] [Bug 16342] Plack breaks Baker and Taylor cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |DUPLICATE --- Comment #6 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 16636 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:29:55 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #16 from Nick Clemens --- *** Bug 16342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:34:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:34:40 +0000 Subject: [Koha-bugs] [Bug 22248] Error when incrementing Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 --- Comment #1 from Alex Arnaud --- Created attachment 90413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90413&action=edit Bug 22248: make svc/mana/increment print valid output Test plan: - select an existing comment on a subscription - check the logs, note the error (Can't return outside a subroutine) - apply this patch - select an existing comment again - error should be gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:35:33 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20271 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:35:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:35:07 +0000 Subject: [Koha-bugs] [Bug 22248] Error when incrementing Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:35:33 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:37:49 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #48 from Nick Clemens --- *** Bug 18377 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 12:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 10:37:49 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #10 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 16733 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 13:54:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 11:54:03 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #11 from Julian Maurice --- (In reply to Mason James from comment #9) > (In reply to Julian Maurice from comment #0) > > Koha lacks a proper Plack file for dev install. > > debian/templates/plack.psgi is for package install and misc/plack/koha.psgi > > seems a bit outdated > > hi Julian > > i think BZ16733 now provides DEV_INSTALL support in the > debian/templates/plack.psgi file > > so, this issue is now resolved? Sort of. I still believe that the main entry point for Koha should be outside of the debian/ directory, and that the "debian case" should be treated as a specific case, rather than the default. But this "problem" would be solved if we decide to use a web framework like suggested in bug 20582, so this bug is obsolete anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:00:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:00:33 +0000 Subject: [Koha-bugs] [Bug 23076] New: Include OpacUserJS on OPAC maintenance page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Bug ID: 23076 Summary: Include OpacUserJS on OPAC maintenance page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- At the moment it's not possible to use OpacUserJS with the OPAC maintenance page. It would be nice to have that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:03:34 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |17.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:09:13 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|17.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:16:14 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #1 from Owen Leonard --- Created attachment 90414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90414&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:16:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:16:11 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:16:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:16:39 +0000 Subject: [Koha-bugs] [Bug 23077] New: Can't import patrons without cardnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Bug ID: 23077 Summary: Can't import patrons without cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Note the plural, you can import 1 patron without a cardnumber, it defaults to an empty string The next patron cannot be imported because empty string is already in use Will attach sample file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:18:39 +0000 Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23077 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:18:39 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14601 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:22:24 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:22:26 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #1 from Nick Clemens --- Created attachment 90415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90415&action=edit Bug 23077 - Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:22:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:22:29 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #2 from Nick Clemens --- Created attachment 90416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90416&action=edit Bug 23077 - Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:23:21 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #3 from Nick Clemens --- Created attachment 90417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90417&action=edit Sample import file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:23:57 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #4 from Nick Clemens --- Created attachment 90418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90418&action=edit Sample file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:24:10 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:24:59 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:27:27 +0000 Subject: [Koha-bugs] [Bug 23078] New: Use Koha.Preference in OPAC global header include Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Bug ID: 23078 Summary: Use Koha.Preference in OPAC global header include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: katrin.fischer at bsz-bw.de, testopia at bugs.koha-community.org Target Milestone: --- To prevent bugs like Bug 23076 the OPAC's doc-head-close.inc include file should use 'Koha.Preference' syntax everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:27:28 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23078 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:46:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:46:45 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:46:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:46:47 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65693|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 90419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90419&action=edit Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:48:20 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #8 from Nick Clemens --- *** Bug 20671 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:48:20 +0000 Subject: [Koha-bugs] [Bug 20671] Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20671 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|In Discussion |RESOLVED --- Comment #5 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 19012 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:49:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:49:05 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 --- Comment #9 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > No, they are not mandatory. It's the default value for > BorrowerMandatoryField, but can be removed, and others can be added. I guess > you will have to parse the pref to display which fields are mandatory. Nope, test it, fields required in the pref are not required for import - that may be its own bug if you wish -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:49:37 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23077, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14601 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:49:37 +0000 Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19012 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:49:37 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 14:51:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 12:51:51 +0000 Subject: [Koha-bugs] [Bug 23071] New options for erasing circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23071 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:07:51 +0000 Subject: [Koha-bugs] [Bug 23069] More pratical order for columns on the cataloging board In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23069 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:10:37 +0000 Subject: [Koha-bugs] [Bug 23079] New: Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Bug ID: 23079 Summary: Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- We keep having issues especially with the TZ America/Sao_Paulo in certain areas of Koha. The most recent error was the checkouts page showing "Internal server error" resolving to: Invalid local time for date in time zone: America/Sao_Paulo The date expiry of this patron was: 2019-12-03 Changing the date expiry date to be a day later (2019-12-04) fixed the issue. The patron currently has no checkouts. I am not sure yet if other settings factor into this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:19:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:19:52 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:19:55 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90406|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 90420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90420&action=edit Bug 23074: Holds table sort does not understand dateformat Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. Test plan: 1) Create multiple holds for a patron with different hold creation and expiration dates, with different years, months and days. 2) Change the dateformat to DD.MM.YYYY. 3) Resort the holds table (in circ/circulation or members/moremember) by the hold date or expiration date. The table sorts the date by the day number. 4) Apply patch 5) Redo 3 - the table now sorts correctly. Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:56:51 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #4 from Martin Renvoize --- Created attachment 90421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90421&action=edit Bug 22566: Fix some problems Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:56:54 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #5 from Martin Renvoize --- Created attachment 90422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90422&action=edit Bug 22566: Fix some more issues 1) Fix warning for undefined value in sprintf when no items have the indemand flag set. 2) Corrections to report_full for bad ternary in string construction 3) Perldoc corrections Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 15:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 13:56:57 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #6 from Martin Renvoize --- Created attachment 90423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90423&action=edit Bug 22566: Fix malformed notice for stockrotation The default notice for stockrotation was malformed. This patch replaces it with a working one. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:00:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:00:15 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:00:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:00:19 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:00:06 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Martin Renvoize --- This is upsetting.. I think it's a case of the originally working implementation getting destroyed during the QA process and not properly tested after the massive number of QA followups. I'd appreciate some thorough testing of the cronjob reporting/dry-run functionality with these patches applied. Test plan as above.. with patches applied the 'full' and 'email' reports should both output meaningful data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:01:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:01:01 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:07:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:07:08 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Summary|columns_settings.pl: add |Add columns configuration |option for circulation |and export options to |rules column configuration |circulation and fine rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:14:31 +0000 Subject: [Koha-bugs] [Bug 23069] More pratical order for columns on the cataloging board In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23069 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:16:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:16:41 +0000 Subject: [Koha-bugs] [Bug 23071] New options for erasing circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23071 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:29:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:29:12 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:55:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:55:49 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow / never gives a result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:55:52 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow / never gives a result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #5 from Nick Clemens --- Created attachment 90424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90424&action=edit Bug 14794: Display JS tooltip whenever dateofbirth is being searched This updates the code that adds a tooltip for the correct date format to display after the initial search To test: 1 - Do a patron search, choosing date of birth as the search field 2 - Note on choosing that field you get a tooltip defining the format 3 - Do a search 4 - Note tooltip is gone, but date fo birth is still selected as the field to search 5 - Apply patch, reload 6 - Note tooltip shows after initial search and until field is changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:56:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:56:26 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Searching patron by |Searching patron by |birthday is slow / never |birthday returns no results |gives a result |if format incorrect CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 16:57:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 14:57:04 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com --- Comment #6 from Nick Clemens --- It seems the code no longer hangs, this just improves visiblity of tooltip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 17:12:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 15:12:57 +0000 Subject: [Koha-bugs] [Bug 22373] Stock Rotation duration test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22373 --- Comment #2 from Martin Renvoize --- Thanks Lisette, that's really helpful to know. What would you expect the correction functionality to be here I'm wondering? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 17:55:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 15:55:04 +0000 Subject: [Koha-bugs] [Bug 22373] Stock Rotation duration test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22373 --- Comment #3 from Lisette Scheer --- Martin, After this I went and looked at the code and it looks like it needs to be on the shelf for 20 days at the branch (in a row I think) for it to move on when the cronjob runs. What we were hoping for with the stock rotation was more like this: June 1, Rota moves from MOS to BOV set to be there for 120 days. September 29, Rota moves from BOV to DEA set to be there for 120 days. Doesn't care if it was checked out during that time, on the shelf, in transit or anything. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 17:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 15:55:51 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- I also think this would be very helpful. We don't use a bunch of the columns at any of our branches. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 18:41:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 16:41:48 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io Blocks|22284 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 18:41:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 16:41:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 19:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 17:40:58 +0000 Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:06:09 +0000 Subject: [Koha-bugs] [Bug 23080] New: Item search: To Call Number Search Not Inclusive Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 Bug ID: 23080 Summary: Item search: To Call Number Search Not Inclusive Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: jyorio at esilibrary.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When conducting an item search and specifying a "To Call Number", the results are not inclusive of the call number specified, contrary to the "(inclusive)" on the form. I have seen this on systems with Library of Congress call numbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:15:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:15:29 +0000 Subject: [Koha-bugs] [Bug 23080] Item search: To Call Number Search Not Inclusive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi John, could you add some sample searches? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:18:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:18:24 +0000 Subject: [Koha-bugs] [Bug 23081] New: Item search : Filter for Items with Zero Checkouts Returns No Results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Bug ID: 23081 Summary: Item search : Filter for Items with Zero Checkouts Returns No Results Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: jyorio at esilibrary.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When conducting an item search, if I set the checkout count to = 0, I get "No data available in table" (and there are most definitely items without any checkouts). If I conduct a search that returns results (without filtering by checkout count), and then enter 0 into the box on the search results screen, I get results with 10 checkouts. I expected to get the items with 0 checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:32:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:32:59 +0000 Subject: [Koha-bugs] [Bug 23080] Item search: To Call Number Search Not Inclusive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 --- Comment #3 from Joelle Hannert --- I can provide an example of this: With a search setup from call number GN-GT returns results up through GR. If I change the parameters to GN-GU, then the results are up through GT. I am attaching screenshots to illustrate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:32:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:32:49 +0000 Subject: [Koha-bugs] [Bug 23080] Item search: To Call Number Search Not Inclusive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 Joelle Hannert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhannert at nmc.edu --- Comment #2 from Joelle Hannert --- Created attachment 90425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90425&action=edit The search setup for call numbers GN-GT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:33:54 +0000 Subject: [Koha-bugs] [Bug 23080] Item search: To Call Number Search Not Inclusive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 --- Comment #4 from Joelle Hannert --- Created attachment 90426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90426&action=edit Results sorted Descending by call # for GN-GT search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:34:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:34:26 +0000 Subject: [Koha-bugs] [Bug 23080] Item search: To Call Number Search Not Inclusive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 --- Comment #5 from Joelle Hannert --- Created attachment 90427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90427&action=edit Results sorted Descending by call # for GN-GU search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:35:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:35:03 +0000 Subject: [Koha-bugs] [Bug 23081] Item search : Filter for Items with Zero Checkouts Returns No Results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Joelle Hannert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhannert at nmc.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:39:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:39:01 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90424|0 |1 is obsolete| | --- Comment #7 from Maryse Simard --- Created attachment 90428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90428&action=edit Bug 14794: Display JS tooltip whenever dateofbirth is being searched This updates the code that adds a tooltip for the correct date format to display after the initial search To test: 1 - Do a patron search, choosing date of birth as the search field 2 - Note on choosing that field you get a tooltip defining the format 3 - Do a search 4 - Note tooltip is gone, but date fo birth is still selected as the field to search 5 - Apply patch, reload 6 - Note tooltip shows after initial search and until field is changed Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:39:14 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:42:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:42:32 +0000 Subject: [Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:42:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:42:35 +0000 Subject: [Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048 --- Comment #2 from Bin Wen --- Created attachment 90429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90429&action=edit Bug 23048: Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches. Signed-off-by: Pasi Kallinen Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:55:21 +0000 Subject: [Koha-bugs] [Bug 23082] New: Fatal error editing a restricted patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Bug ID: 23082 Summary: Fatal error editing a restricted patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: frinaudo at infocpt.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Para reproducir el error, se debe tener un socio con una restricci?n, ya sea manual o autom?tica: 1- Editar el socio 2- Marcar el checkbox "eliminar" en la restricci?n 3- Guardar En ese momento aparece un internal server error En los logs el mensaje es: ==> /var/log/koha/eco/plack-error.log <== No property remove_debarment for Koha::Patron La restricci?n se elimina, pero se debe abrir una ventana de koha nuevamente. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:55:52 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90414|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 90430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90430&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 20:56:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 18:56:02 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:07:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:07:38 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90430|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 90431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90431&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:33:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:33:11 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |templates to use JavaScript | |included the OPACUserJS | |system preference (it now | |uses the 'Koha.Preference' | |syntax in the global | |include file). This makes | |the data available in | |templates, such as the OPAC | |maintenance page. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:37:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:37:30 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #4 from David Nind --- Should the title now be 'Include OpacUserJS in templates'? Not understanding the nuts and bolts of this, my limited understanding as that the OPAC maintenance page is just one place it can be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:38:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:38:02 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #5 from David Nind --- Also, have I got the text for the release notes right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:48:10 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #6 from Owen Leonard --- (In reply to David Nind from comment #4) > Should the title now be 'Include OpacUserJS in templates'? OpacUserJS was available to almost all templates before this patch. I'm not sure if the maintenance page was the only one which lacked it. My patch ensures that the bug affecting the maintenance page won't affect other pages for the same reason. It would be safer to keep the title as-is. The release notes should be indicate that this is a bug fix affecting the OPAC maintenance page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:47:45 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90420|0 |1 is obsolete| | --- Comment #3 from Arthur Bousquet --- Created attachment 90432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90432&action=edit Bug 23074: Holds table sort does not understand dateformat Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. Test plan: 1) Create multiple holds for a patron with different hold creation and expiration dates, with different years, months and days. 2) Change the dateformat to DD.MM.YYYY. 3) Resort the holds table (in circ/circulation or members/moremember) by the hold date or expiration date. The table sorts the date by the day number. 4) Apply patch 5) Redo 3 - the table now sorts correctly. Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:55:52 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90421|0 |1 is obsolete| | --- Comment #8 from Nadine Pierre --- Created attachment 90433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90433&action=edit Bug 22566: Fix some problems Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:55:55 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90422|0 |1 is obsolete| | --- Comment #9 from Nadine Pierre --- Created attachment 90434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90434&action=edit Bug 22566: Fix some more issues 1) Fix warning for undefined value in sprintf when no items have the indemand flag set. 2) Corrections to report_full for bad ternary in string construction 3) Perldoc corrections Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 21:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 19:56:00 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90423|0 |1 is obsolete| | --- Comment #10 from Nadine Pierre --- Created attachment 90435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90435&action=edit Bug 22566: Fix malformed notice for stockrotation The default notice for stockrotation was malformed. This patch replaces it with a working one. Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 22:20:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 20:20:40 +0000 Subject: [Koha-bugs] [Bug 23083] New: Course reserve item edit fails if one does not set all values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Bug ID: 23083 Summary: Course reserve item edit fails if one does not set all values Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To Test: 1: Create an item with itype, ccode, location, and holding branch set 2: Create a course 3: Add item to course, changing the values for itype, ccode, and location 4: Click Edit for that item on course-details.pl 5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED 6: Hit Save 7: Back on course-details.pl, observe that the item is still showing the values set in step 3 8: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently 9: hit save 10: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 22:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 20:32:44 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 22:34:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 20:34:54 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This fix allows the OPAC release notes|templates to use JavaScript |maintenance page to use |included the OPACUserJS |JavaScript included in the |system preference (it now |OPACUserJS system |uses the 'Koha.Preference' |preference. |syntax in the global | |include file). This makes | |the data available in | |templates, such as the OPAC | |maintenance page. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 7 22:36:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 20:36:49 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #7 from David Nind --- Thnaks Owen! I've updated the text for the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 00:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 22:49:51 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot add edit |Cannot edit subscription |subscription with strict |with strict SQL modes |SQL modes turned on |turned on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 00:55:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 22:55:29 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #8 from Jonathan Druart --- Hi Nick, I do not understand what you are trying to fix. Do not we want to add a JS check to make sure the date is valid? Moreover if you want the tooltip to be displayed when the input has the focus, maybe you should bind the on focus event? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 00:57:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jun 2019 22:57:51 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 --- Comment #2 from Jonathan Druart --- Hi Owen, if you plan to work on this please try to make the changes as succinct as possible (keeping bug 15522 in mind). Thanks! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 05:18:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 03:18:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #137 from Liz Rea --- Hi Agustin, This is looking pretty good, a few things to note: - there's a typo in the Hold column "Cannot place hold from patrons's library" should be "Cannot place hold from patron's library" When an item is selected in the intranet for an item level hold, the location select shows all of the libraries from every group represented on the page (i.e. if you have group 1 CPL, MPL and group 2 UNI, IPL, the list will show CPL, MPL, UNI, IPL in the pickup locations. There are test failures: Holds.t # Failed test 'can request item if policy that matches on item type allows it' # 48 I can add a follow up for the typo - and I will, if you can have a look at the other stuff! This is a really good feature I think - libraries will really like having the option to do these things. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 05:34:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 03:34:20 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 05:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 03:34:23 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90397|0 |1 is obsolete| | Attachment #90398|0 |1 is obsolete| | Attachment #90399|0 |1 is obsolete| | --- Comment #10 from Liz Rea --- Created attachment 90436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90436&action=edit Bug 9834: Add DB changes Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 05:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 03:34:32 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #11 from Liz Rea --- Created attachment 90437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90437&action=edit Bug 9834: Add tests Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 05:34:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 03:34:36 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #12 from Liz Rea --- Created attachment 90438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90438&action=edit Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:53:15 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20784 [Bug 20784] Capture more changes made in the Administration module in logs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:53:15 +0000 Subject: [Koha-bugs] [Bug 20784] Capture more changes made in the Administration module in logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Blocks| |22794 Summary|Capture more changes in |Capture more changes made |Logs |in the Administration | |module in logs CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:53:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:53:46 +0000 Subject: [Koha-bugs] [Bug 16544] Changes to circ rules should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changes to circ rules |Changes to circ rules |should be logged. |should be logged Blocks| |22794 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:53:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:53:46 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 [Bug 16544] Changes to circ rules should be logged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:55:15 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Katrin Fischer --- *** Bug 21422 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:55:34 +0000 Subject: [Koha-bugs] [Bug 17400] KOHA keeps requesting log-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 07:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 05:55:15 +0000 Subject: [Koha-bugs] [Bug 21422] Create logging for any action triggered by a staff override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9762 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 19:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 17:46:28 +0000 Subject: [Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #12 from Jonathan Druart --- (In reply to Martin Renvoize from comment #11) > I can't find any other reason it may be treated differently to other files. >From commit b7cd95bcc909f7db330b5acbfcf9e8f817328a67 """ Bug 10802: make Debian package install history.txt While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] [...] [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 19:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 17:52:57 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #8 from Jonathan Druart --- Comment on attachment 90388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90388 Bug 23057: Update do_checkin Review of attachment 90388: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23057&attachment=90388) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1945,4 @@ > } > > if ( $item->itemlost and C4::Context->preference("BlockReturnOfLostItems") ) { > + $messages->{'ReturnOfLostItemBlocked'}; Should we handle it from returns.pl as well? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 19:57:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 17:57:18 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > What about renaming the method in Koha::S::R::Biblio to ->marc_xml_metadata > (adding the conditions in it) and Koha::Biblio->metadata to ->marc_xml (make > it returns the MARX XML directly)? Should we go with that for now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:21:15 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22630 --- Comment #1 from Jonathan Druart --- I think the patch on bug 22630 (Do not modify item fields if course reserve item says LEAVE UNCHANGED) will fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:21:15 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23083 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:32:14 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:32:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:32:18 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 --- Comment #1 from Jonathan Druart --- Created attachment 90439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90439&action=edit Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:32:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:32:45 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:34:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:34:16 +0000 Subject: [Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|paul.poulain at biblibre.com |laurent.ducos at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:42:56 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:59:28 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:59:31 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #1 from Jonathan Druart --- Created attachment 90440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90440&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 20:59:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 18:59:51 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:24:01 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |major --- Comment #1 from Jonathan Druart --- I have no idea how to provide a global and quick fix for this. It will be a big problem for Brazilian libraries using Koha (are there?): % perl -MDateTime -e "DateTime->new(year => 2019, month => 12, day => 3, time_zone => 'America/Sao_Paulo')->subtract(days => 30);" Invalid local time for date in time zone: America/Sao_Paulo % perl -MDateTime -e "DateTime->new(year => 2019, month => 11, day => 3, time_zone => 'America/Sao_Paulo');" Invalid local time for date in time zone: America/Sao_Paulo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:25:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:25:53 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #2 from Jonathan Druart --- You specific issue could be fixed with: @ Patron.pm:625 @ sub is_going_to_expire { return 0 unless $delay; return 0 unless $self->dateexpiry; return 0 if $self->dateexpiry =~ '^9999'; - return 1 if dt_from_string( $self->dateexpiry )->subtract( days => $delay ) < dt_from_string->truncate( to => 'day' ); + return 1 + if dt_from_string( $self->dateexpiry, undef, 'floating')->subtract( days => $delay ) < + dt_from_string->truncate( to => 'day' ); return 0; } But it will not help much. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:28:35 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #3 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > I have no idea how to provide a global and quick fix for this. It will be a > big problem for Brazilian libraries using Koha (are there?): We alone support 4 in this timezone. I was wondering because we don't see issues in other timezones so far and we got quite a few with the Goethe institute libraries. Can you explain the issue a bit? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:36:02 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hola Frederico, no puedo reproducir este problema. Cual versi?n usas? Reiniciaste Plack? I cannot recreate this issue, which version are you using? Did you restart Plack? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:39:50 +0000 Subject: [Koha-bugs] [Bug 22984] Holding branch disappears after saving to course and isn't restored when removing item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22984 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23083 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:39:50 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22984 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:41:13 +0000 Subject: [Koha-bugs] [Bug 22985] Tag cloud only displays user's own tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22420 --- Comment #1 from Jonathan Druart --- Which exact versin of 18.11.x? See bug 22420 which is part of 18.11.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:41:13 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22985 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:47:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:47:05 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:47:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:47:09 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 --- Comment #1 from Jonathan Druart --- Created attachment 90441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90441&action=edit Bug 22941: Do not return 500 if sortfield contain parenthesis Test plan: Hit /virtualshelves/shelves.pl?op=view&shelfnumber=1&sortfield=author( You must not get: Unmatched ( in regex; marked by <-- HERE in m/^author( <-- HERE $/ at /home/vagrant/kohaclone/virtualshelves/shelves.pl line 236 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:47:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:47:19 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:51:04 +0000 Subject: [Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:51:04 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 21:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 19:51:04 +0000 Subject: [Koha-bugs] [Bug 23084] New: Replace grep {^$var$} with grep {$var eq $_} Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bug ID: 23084 Summary: Replace grep {^$var$} with grep {$var eq $_} Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- See bug 23006 and bug 22941. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:09:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:09:17 +0000 Subject: [Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Owen, are you working on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:16:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:16:59 +0000 Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:17:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:17:03 +0000 Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 --- Comment #1 from Jonathan Druart --- Created attachment 90442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90442&action=edit Bug 22937: Display library search group descriptions Instead of their "title" Test plan: Create a group of library with a title and a description On the advanced search pages (OPAC & staff) confirm the the description is displayed Edit the group of library and remove its description The "title" must now be displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:17:18 +0000 Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:37:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:37:00 +0000 Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:37:04 +0000 Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 --- Comment #2 from Jonathan Druart --- Created attachment 90443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90443&action=edit Bug 22927: Do not check an already lost item when marked as withdrawn or damaged Due to how moredetail.pl was written it was hard to know which action was triggered. Test plan: - Set MarkLostItemsAsReturned to "from the items tab of the catalog module." - Check an item out to a patron - Use additem.pl to set that item to a lost status without returning it - go to moredetail.pl for that item - mark item as either damaged or withdrawn without interacting with the lost dropdown - note that item has not been returned Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'} to call LostItem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 8 22:37:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jun 2019 20:37:18 +0000 Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 16:30:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 14:30:46 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 --- Comment #2 from Barbara Johnson --- Creating a connection between purchase suggestions and staged files would be a real timesaver. We?d like it to go one step further. Instead of just notifying the patron we would like for it to automatically place a hold on the item so the patron is the first user to get the item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 18:36:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 16:36:58 +0000 Subject: [Koha-bugs] [Bug 1887] Managing Suggestions - hold books for patron who requested In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #4 from Barbara Johnson --- Automatic holds for suggestions would make our patrons very happy. We use staged files to import our orders so we would need a connection between acquisitions and suggestions (similar to request in bug #19538) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:08:41 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:08:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:08:44 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90432|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 90444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90444&action=edit Bug 23074: Holds table sort does not understand dateformat Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. Test plan: 1) Create multiple holds for a patron with different hold creation and expiration dates, with different years, months and days. 2) Change the dateformat to DD.MM.YYYY. 3) Resort the holds table (in circ/circulation or members/moremember) by the hold date or expiration date. The table sorts the date by the day number. 4) Apply patch 5) Redo 3 - the table now sorts correctly. Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:12:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:12:33 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:12:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:12:36 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90431|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 90445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90445&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:12:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:12:49 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #9 from Katrin Fischer --- Thank you for the quick fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:15:52 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:15:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:15:55 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90412|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 90446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90446&action=edit Bug 23053: Add phrase index to authority Local-Number To test: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 7 - Apply patch 8 - Copy the indexdefs files to the installed versions 9 - Reapply matchign rules to staged files 10 - Matches should now be found 11 - Logs should not have errors Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:36:48 +0000 Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90442|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 90448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90448&action=edit Bug 22937: Display library search group descriptions Instead of their "title" Test plan: Create a group of library with a title and a description On the advanced search pages (OPAC & staff) confirm the the description is displayed Edit the group of library and remove its description The "title" must now be displayed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:36:45 +0000 Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:38:39 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:38:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:38:43 +0000 Subject: [Koha-bugs] [Bug 23061] Add column/print/export feature on checkout history page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23061 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90375|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 90449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90449&action=edit Bug 23061: Add column/print/export feature on checkout history page This patch adds columns configuration and export features to the checkout history page. This patch also removes some inline CSS: "overflow:hidden" from both the checkout and holds history pages. This was breaking the table controls tooltips, and didn't appear to me to be necessary. To test, apply the patch and restart Plack (or restart_all on kohadevbox). - Open a patron's checkout history page in the staff client. - The table of checkouts should have controls at the top. for columns configuration and export/print. - These controls should work correctly. Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 22:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 20:54:10 +0000 Subject: [Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- This works, but feels a little hacky: - When the report expects params, the SQL message is output. We could possibly print a nicer error message instead with the number of params to expected. - When the report is built with reusable variables, you need to enter each of those on command line. If not easy to fix, hinting at it in the help might be good. My example query was: select * from items where holdingbranch = <> and homebranch = <> and itype= <> So b will be shown as 1 input field, but will be required twice in the command: ./misc/cronjobs/runreport.pl 1 --param=CPL --param=BK DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "select * from items where holdingbranch = ? and homebranch = ? and itype= ? LIMIT ?, ?" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Reports/Guided.pm line 544. NO OUTPUT: 0 results from execute_query ./misc/cronjobs/runreport.pl 1 --param=CPL --param=CPL --param=BK Works. Pushing back to Nick for comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 23:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 21:03:46 +0000 Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com Status|Signed Off |In Discussion --- Comment #3 from Katrin Fischer --- I am not sure if this is a bug or a case of 'needs better labelling'. While we use internal codes for things like libraries/branches and itemtypes that we enter in the GUI, the library groups feature uses a numeric primary key. Unlike a code, the title shown in the GUI can be changed anytime and I think is supposed to be the display text, while the description can be used to give more information to staff. Example how I'd use it: Title: South Germany Description: Grouping all branches in Bavaria and BW into a hold group. I think if we changed this now, libraries who used it like this won't be happy. Adding Kyle for another opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 23:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 21:12:10 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- With this patch, there remains: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt:
  • Can you please check if this needs to be changed as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 9 23:30:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jun 2019 21:30:57 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer --- Hi Kyle, the unit tests pass, but the QA script has some complaints: FAIL Koha/Checkout.pm OK critic OK forbidden patterns OK git manipulation FAIL pod *** ERROR: Unknown command 'head' in file Koha/Checkout.pm FAIL pod coverage POD is missing for 'library' OK spelling OK valid FAIL Koha/Old/Checkout.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Old::Checkout': current merge results [ Koha::Old::Checkout, ] merging failed on 'Koha::Checkout' FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt FAIL filters missing_filter at line 88 ( [% line.checkout.library.branchname %]) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template Can you please check? Also a question for testing: are overdues the only fines where the library will show? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 09:27:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 07:27:14 +0000 Subject: [Koha-bugs] [Bug 19247] Feature release change tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 09:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 07:28:12 +0000 Subject: [Koha-bugs] [Bug 19247] Feature release change tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 --- Comment #15 from Martin Renvoize --- So, a little bird told me you're back from an amazing break and feel refreshed and raring to go Alex... is this bug still on your horizon? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 09:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 07:49:33 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 09:51:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 07:51:36 +0000 Subject: [Koha-bugs] [Bug 23085] New: tools/modborrowers.pl doesn't have branchcode as mandatory field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23085 Bug ID: 23085 Summary: tools/modborrowers.pl doesn't have branchcode as mandatory field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org Target Milestone: --- In tools/modborrowers.pl branchcode is not mandatory field if it is not defined in BorrowerMandatoryField syspref. It missing causes errors in the tool. We could maybe circumvent this by always automatically adding branchcode to BorrowerMandatoryField syspref when user saves it, or with some other mechanism. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 09:56:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 07:56:18 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 09:56:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 07:56:27 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:25:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:25:44 +0000 Subject: [Koha-bugs] [Bug 23086] New: Search for collection is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Bug ID: 23086 Summary: Search for collection is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Target Milestone: --- We have seen this issue in a 17.11 installation, but not in a newer 18.11. I believe that Zebra version and using/not using ICU might play a role here. When looking into it, we were able to fix the issue removing the lines adding quotes to the search in Search.pm: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Search.pm;h=4191cbc2de0e8530637cb2027b2a3de8374e0eef;hb=8427b684148944b9306fd4786c75c53527037024#l1722 The quotes appear to be the issue, as a simple search using mc-ccode: without quotes works. This problem has also been reported on the mailing list: https://lists.katipo.co.nz/pipermail/koha/2019-June/053081.html Setting to major as this effects a major feature in the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:29:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:29:53 +0000 Subject: [Koha-bugs] [Bug 22373] Stock Rotation duration test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22373 --- Comment #4 from Martin Renvoize --- https://github.com/Koha-Community/Koha/blob/master/Koha/StockRotationItem.pm#L117-L140 is the code in question. It certainly reads to me as though it should work as you expect (note the filtering of branchtransfers by the appearance of 'StockrotationAdvance' in the comments field). I'll try to come up with an automated test we can add for the unit tests to prove this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:38:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:38:34 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #8 from Katrin Fischer --- *** Bug 17407 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:38:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:38:34 +0000 Subject: [Koha-bugs] [Bug 17407] Fields cataloged using MARC21 880 are only searchable using keyword search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15187 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:39:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:39:23 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #2 from Alex Arnaud --- Merge request is here: https://git.biblibre.com/biblibre/koha-mana/pulls/1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:39:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:39:43 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:46:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:46:33 +0000 Subject: [Koha-bugs] [Bug 23087] New: Update DB system for Mana Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 Bug ID: 23087 Summary: Update DB system for Mana Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Mana-kb (server) Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com Target Milestone: --- All is in the title, we need an update DB system on Mana KB -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:46:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:46:42 +0000 Subject: [Koha-bugs] [Bug 23087] Update DB system for Mana In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:53:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:53:56 +0000 Subject: [Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:55:47 +0000 Subject: [Koha-bugs] [Bug 23088] New: Stockrotation full_report should use 'notices' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23088 Bug ID: 23088 Summary: Stockrotation full_report should use 'notices' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- The stockrotation cronjob allows for two different types of report. One of those reports is plumbed in to using the SR_SLIP from the 'notices' system, but the other reports 'full' is hard coded in the script. We should add a second SR_REPORT slip to the notices system to use for this full report to allow for easier translations etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:55:54 +0000 Subject: [Koha-bugs] [Bug 23088] Stockrotation full_report should use 'notices' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23088 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 [Bug 22566] Stock rotation cronjob reporting has issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:55:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:55:58 +0000 Subject: [Koha-bugs] [Bug 23088] Stockrotation full_report should use 'notices' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23088 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 10:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 08:55:54 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23088 [Bug 23088] Stockrotation full_report should use 'notices' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:05:16 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #17 from Fridolin SOMERS --- (In reply to Nightly Build Bot from comment #16) > Created attachment 90319 [details] [review] > Bug 17108- Automatic debian/control updates (stable/19.05.x) Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:14:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:14:02 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:14:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:14:02 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:14:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:14:09 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items currrent and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:14:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:14:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 [Bug 22567] Stock rotation manage rotas should show items currrent and desired locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:32:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:32:00 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:31:55 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #1 from Martin Renvoize --- Nice idea, I'll try to get to this some time soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 11:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 09:55:07 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I wanted to test this, but couldn't figure it out! Any hints or direction would be appreciated. Is this talking about etc/koha-config.xml and the URL in there? For testing is this the URL to configure in koha-config.xml? https://mana-test.koha-community.org/ Or is it once you have it enabled and working, that is you have enabled and added a token? Up-to-date on master. I haven't been to get registration to work either, I get these two error messages when on /cgi-bin/koha/admin/share_content.pl: - An error occurred, mana server returned: URL must be absolute - Mana configuration is currently empty. This feature will not work. Please contact your site administrator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:08:04 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #8 from Katrin Fischer --- I like the idea and discussion here. I am not quite ready to sign this of, some things I have thought about testing: Asking for confirmation - YES! The message itself appears a bit non-standard in wording and formatting. Maybe it could be a bit improved there. I'd also add a confirmation message in any case - we are deleting data. The hints on the radio boxes are a nice idea, but maybe too hidden. Also I'd be careful about the 'recoverable'. Not all of the deleted data is, even if you could (only with SQL) recover some of it. Adding Owen for a GUI opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:29:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:29:54 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- I like the tool tip idea, although I'd omit the '' (I know people who will enter them :) ) Checking the format would be nice, but is not a blocker here for me. But: I think we need the same on the filters on the left side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:43:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:43:09 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:43:12 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89923|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 90450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90450&action=edit Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:44:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:44:23 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #12 from Katrin Fischer --- Thank you Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:56:57 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #3 from Martin Renvoize --- I was envisaging more of a human friendly splash page.. probably with a pretty definition of the Mana word (from Maori) and then a very short description/summary of what the 'product' is intended to do... something for the human reader that see's the page URL in the koha config page and wants to learn a bit more about what they're signing up to. The machine readable json is certainly an improvement over a 404, but it's still not all that friendly to the person who is most likely to ever try navigating to the page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:57:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:57:48 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #4 from Katrin Fischer --- Hi Alex, not sure how to test this. But I think what it does is returning a JSON type of answer. What I'd expect hitting the page from the browser would be a one page HTML page, just explaining what it is and maybe giving a hint on how to use it (link to the manual?). I think having a non-404 could still be good until we have figured this out, but don't think I can test? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 12:57:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 10:57:56 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #5 from Katrin Fischer --- Just collided with Martin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 13:50:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 11:50:52 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 --- Comment #3 from Owen Leonard --- (In reply to Jonathan Druart from comment #2) > keeping bug 15522 in mind) I think bug 15522 should keep my changes in mind :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:00:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:00:36 +0000 Subject: [Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #7 from Owen Leonard --- (In reply to Jonathan Druart from comment #6) > Owen, are you working on this? I am not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:16:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:16:02 +0000 Subject: [Koha-bugs] [Bug 22985] Tag cloud only displays user's own tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22985 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Andrew --- I believe I ran into this on 18.11.03. Just had a look on an 18.11.06 site and it appears to be resolved. I'll go ahead and close this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:23:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:23:06 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 --- Comment #2 from Andrew --- Confirmed that applying the patch from 22630 fixes this. I'll mark this bug a dupe of that one. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:23:22 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #25 from Andrew --- *** Bug 23083 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:23:22 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Andrew --- *** This bug has been marked as a duplicate of bug 22630 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:30:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:30:37 +0000 Subject: [Koha-bugs] [Bug 23089] New: Elasticsearch - cannot sort on non-text fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Bug ID: 23089 Summary: Elasticsearch - cannot sort on non-text fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Target Milestone: --- issues is defined as an sum field, this is interpreted to ES as integer, however, the issues__sort field is stored as keyword. Attempting to order search results by 'popularity' fails from ES - because we can't use text fields, we have to use a 'keyword' field. In our biblio search indexes this is fine because our __sort fields all get a phrase keyword field We onyl set field__sort.phrase for text fields though, so issues__sort doesn't use the phrase field, even though it exists Adding a test to try to ilustrate what I am saying here To recreate: 1 - Enable and index ES 2 - Search on staff client or OPAC 3 - Attempt to sort by popularity 4 - It fails, check the error logs to see why -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:31:21 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |ere.maijala at helsinki.fi, | |glasklas at gmail.com, | |mkstephens at lancasterseminar | |y.edu, | |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:32:30 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #26 from Katrin Fischer --- 2 problems here, this is failed QA as an enhancement, but also happens to fix a critical bug - bug 23083. Could the bug fix be separated from the bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:32:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:32:35 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:32:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:32:38 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 --- Comment #1 from Nick Clemens --- Created attachment 90451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90451&action=edit Bug 23089: Unit test to highlight sorting issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:33:49 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:38:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:38:18 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:38:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:38:20 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 --- Comment #4 from Owen Leonard --- Created attachment 90452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90452&action=edit Bug 15726: Add columns configuration and export options to circulation and fine rules This patch adds DataTables search, column configuration, and export options to the circulation and fine rules table. It does not add or change sorting. Some changes to admin/smart-rules.pl were necessary to ensure that form fields removed by hidden columns wouldn't trigger errors because of empty values. This patch also makes minor markup corrections to fix HTML validator errors. To test, apply the patch and go to Administration -> Circulation and fine rules. - Test all aspects of the circulation and fine rules table: Adding new rules, editing rules, cloning rules, deleting rules. - Test the new DataTables features: Search, columns configuration, and export. - Make changes to the table's column configuration in Administration -> Configure columns. Confirm that they are correctly applied to the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 14:39:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 12:39:49 +0000 Subject: [Koha-bugs] [Bug 23067] in Opac Confirm holds page the Last location column is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com Status|NEW |Needs Signoff --- Comment #1 from Christophe Croullebois --- Created attachment 90453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90453&action=edit Show holdingbranch whatever the case To test : Without patch 1? Choose an item available to hold with the same homebranch and holdingbranch 2? In opac-reserve.pl click on 'Show more options' 3? Select 'A specific item' 4? You'll see a table with column 'Last location' (holdingbranch) empty With patch 4? You'll see column 'Last location' (holdingbranch) filled thx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:04:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:04:16 +0000 Subject: [Koha-bugs] [Bug 22744] 'Do not notify' is really a 'Clear' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 --- Comment #6 from Nick Clemens --- Created attachment 90454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90454&action=edit Bug 22744: Make checkboxes links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:04:13 +0000 Subject: [Koha-bugs] [Bug 22744] 'Do not notify' is really a 'Clear' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:13:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:13:37 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 --- Comment #4 from Jonathan Druart --- Instead I think the patch should be moved here, bug 22630 is an enhancement and will not be backported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:16:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:16:37 +0000 Subject: [Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #8 from Jonathan Druart --- Should we follow: https://google-webfonts-helper.herokuapp.com/fonts/noto-sans?subsets=latin,greek-ext,devanagari,cyrillic,latin-ext,vietnamese,greek,cyrillic-ext Download and include them all? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:22:23 +0000 Subject: [Koha-bugs] [Bug 13520] Move rental fee as total amount to circulation matrix and remove rental discount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:22:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:22:31 +0000 Subject: [Koha-bugs] [Bug 13520] Move rental fee as total amount to circulation matrix and remove rental discount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520 --- Comment #2 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:31:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:31:19 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #4 from Jonathan Druart --- It comes from: C4/Auth.pm 1310 foreach my $key ( keys %$casservers ) { 1311 push @tmplservers, { name => $key, value => login_cas_url( $query, $key, $type ) . "?cas=$key" }; 1312 } So you are right Katrin, it must not be filtered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:33:48 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : Data sharing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 [Bug 23087] Update DB system for Mana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:33:48 +0000 Subject: [Koha-bugs] [Bug 23087] Update DB system for Mana In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : Data sharing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:34:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:34:33 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:34:35 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #10 from Nick Clemens --- Created attachment 90455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90455&action=edit Bug 14794: (follow-up) Add tooltip to filter box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:34:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:34:58 +0000 Subject: [Koha-bugs] [Bug 23087] Update DB system for Mana In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Alex Arnaud --- Pull request: https://git.biblibre.com/biblibre/koha-mana/pulls/2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:42:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:42:36 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #5 from Nick Clemens --- Created attachment 90456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90456&action=edit Bug 22585: (follow-up) Fix additional occurences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:43:53 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #6 from Alex Arnaud --- Martin, Katrin, https://mana-* is an API and, IMO, is intended to return machine readable format only. This could be useful if we want koha to be able to check if the url is a valid mana instance. May be what you are expecting could be done on the user interface part: https://ui.mana-* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:47:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:47:50 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #13 from Alex Arnaud --- Mana pull request: https://git.biblibre.com/biblibre/koha-mana/pulls/3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:49:10 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Hi Nick, I do not understand what you are trying to fix. > > Do not we want to add a JS check to make sure the date is valid? > > Moreover if you want the tooltip to be displayed when the input has the > focus, maybe you should bind the on focus event? It is not so much a 'fix' but hopefully provides feedback to the user on what they must do there. I am not changing behvaiour, just trying to make current behaviour more clear. I think making that field a date entry/calendar would probably be helpful, but I think that can be a separate enhancement. The tooltip shows when the dropdown is changed, or on focus, so I think doing it on change makes sense - you select dateofbirth, you see what you must enter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:53:33 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 --- Comment #9 from Owen Leonard --- Created attachment 90457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90457&action=edit Bug 11642: (follow-up) Batch patron deletion/anonymization should not allow permanent destruction of patron data This patch makes some template changes to try to make this interface more consistent with other areas of Koha and to make warnings more clear. I have also changed the phrase "deletion/anonymization" to "deletion and anonymization." To test, apply the patch and test the patron deletion and anonymization process and confirm that the interface is clear and works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:53:29 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:54:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:54:31 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #4) > Instead I think the patch should be moved here, bug 22630 is an enhancement > and will not be backported. I agree, not a real duplicate in this case, deduplicating, changing to a see also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 15:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 13:56:33 +0000 Subject: [Koha-bugs] [Bug 22906] Minor corrections to plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:02:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:02:11 +0000 Subject: [Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:03:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:03:54 +0000 Subject: [Koha-bugs] [Bug 22947] Markup error in OPAC preferences file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:05:00 +0000 Subject: [Koha-bugs] [Bug 22955] Markup error in OPAC lists template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:06:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:06:19 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:08:41 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #3 from Alex Arnaud --- (In reply to David Nind from comment #2) > I wanted to test this, but couldn't figure it out! Any hints or direction > would be appreciated. > > Is this talking about etc/koha-config.xml and the URL in there? For testing > is this the URL to configure in koha-config.xml? > https://mana-test.koha-community.org/ > > Or is it once you have it enabled and working, that is you have enabled and > added a token? David, just enter a non valid URL in mana_config and try to register via cgi-bin/koha/admin/share_content.pl (request a mana token). > > Up-to-date on master. > > I haven't been to get registration to work either, I get these two error > messages when on /cgi-bin/koha/admin/share_content.pl: > > - An error occurred, mana server returned: URL must be absolute > > - Mana configuration is currently empty. This feature will not work. Please > contact your site administrator. As said, mana_config is empty. enter the following in your koha-conf.xml: https://mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:18:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:18:51 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #2 from Martin Renvoize --- Created attachment 90458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90458&action=edit Bug 22569: Proof of concept This patch adds a proof of concept 'Transfers to send' report to the circulation page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:19:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:19:28 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11897 |22566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 [Bug 22566] Stock rotation cronjob reporting has issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:19:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:19:28 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:19:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:19:28 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:19:44 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:21:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:21:00 +0000 Subject: [Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:22:26 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #25 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:29:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:29:15 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #6 from Jonathan Druart --- This patch is for OPAC and so more a follow-up for bug 21973. But I am not sure it would make sense to open a third report for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:40:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:40:01 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Alex Arnaud --- This makes we lost the response code ($result->{code} = $response->code;) We need it in some place to test the response. I.e: report search is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:44:27 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > This patch is for OPAC and so more a follow-up for bug 21973. But I am not > sure it would make sense to open a third report for it. Maybe just retitle this one as "Fix remaning CAS links"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:49:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:49:21 +0000 Subject: [Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:50:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:50:08 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #12 from Jonathan Druart --- About the JS check, I actually thought we add a JS function to check the date formatting, and so it would have been easy to reuse it here. But we don't. We have a CheckDate function (in members.js) to make sure it matches DD/MM/YYYY. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:52:38 +0000 Subject: [Koha-bugs] [Bug 20114] Build better $query_cgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #9 from Nick Clemens --- I think David has some points, we could do more here in the future. As he has abandoned this code and 22413 seems to fix the issues caused by this bug I think we can close *** This bug has been marked as a duplicate of bug 22413 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:52:38 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas at gmail.com --- Comment #15 from Nick Clemens --- *** Bug 20114 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:53:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:53:51 +0000 Subject: [Koha-bugs] [Bug 22585] Fix remaining double-escaped CAS links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CAS login link for staff |Fix remaining |intranet is double-escaped |double-escaped CAS links Depends on| |21973 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21973 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 [Bug 21973] CAS URL escaped twice, preventing login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:53:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:53:51 +0000 Subject: [Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22585 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22585 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 [Bug 22585] Fix remaining double-escaped CAS links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:55:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:55:20 +0000 Subject: [Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:56:09 +0000 Subject: [Koha-bugs] [Bug 22964] Remove the word "product" from the bugzilla bug report page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22964 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #2 from Nick Clemens --- If I recall this came from a discussionat Koha con to make it easier for users/newbies to file a bug maybe just a link on the mainpage to "File a Koha Bug" directly and avoid this choice screen all together? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:56:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:56:35 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:57:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:57:05 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #5 from Jonathan Druart --- Are you sure Alex? This patch did not remove the line you are referring to, it moved it above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 16:58:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 14:58:35 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #6 from Jonathan Druart --- Ha! my bad, got it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:01:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:01:40 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #7 from Alex Arnaud --- My explanation was not very clear, i admit :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:02:13 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:06:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:06:28 +0000 Subject: [Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:09:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:09:14 +0000 Subject: [Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #9 from Janusz Kaczmarek --- (In reply to Jonathan Druart from comment #8) > Should we follow: > > https://google-webfonts-helper.herokuapp.com/fonts/noto-sans?subsets=latin, > greek-ext,devanagari,cyrillic,latin-ext,vietnamese,greek,cyrillic-ext > > Download and include them all? Entire WOFF2 set (Regular, Italic, Bold, BoldItalic) = 546 KB Entire WOFF set = 714 KB Now it is eight times less (71 KB, 89 KB, respectively). If it is OK (the browser would keep it normally in cache, wouldn't it? -- if so, then it would be downloaded only once, in general) -- let's do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:14:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:14:22 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:14:31 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90440|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 90459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90459&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:37:04 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #7 from Alex Arnaud --- [Update] merge request is here: https://gitlab.com/koha-community/koha-mana/merge_requests/1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:39:14 +0000 Subject: [Koha-bugs] [Bug 23087] Update DB system for Mana In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 --- Comment #2 from Alex Arnaud --- Pull request: https://gitlab.com/koha-community/koha-mana/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:40:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:40:55 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #14 from Alex Arnaud --- Pull request: https://gitlab.com/koha-community/koha-mana/merge_requests/3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:45:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:45:59 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen at gmail.com --- Comment #28 from Tom?s Cohen Arazi --- I have a few remarks: - The method you are adding to Koha::Patron (->suggestions) needs tests, and it should be actually relying on a relationship, and thus using _new_from_dbic so it is prefetchable. This has been discussed recently so you couldn't know beforehand. - There's now a clear distinction between endpoints that target unprivileged users (OPAC) and administrative ones (e.g. staff interface). If this bug only targets the 'privileged' one, maybe make it explicit and make sure the permissions are correct. - The attribute names seem to come straight from the DB structure. This should be fixed. Look at the RFCs page [1] and please follow naming conventions discussed and voted there. For example, borrowernumber is not used on the API, use patron_id instead. - POD is missing on the controller - Take a look at Koha::REST::V1::Cities and how it uses ->objects_search. It will automagically add pagination to the list method, which is desierd on busy sites (i.e. make the list manageable). - objects_search requires you to pass the _to_api and _to_model methods you will need to write to comply with the currently voted RFCs regarding terminology. - If you want the end user (session) to create purchase suggestions, then you need an endpoint in /public. And if you need to list them on the patron's page, maybe worth generating /public/patron/{patron_id}/purchase_suggestions (this is very arguable, just a thought). [1] https://wiki.koha-community.org/wiki/REST_api_RFCs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 17:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 15:46:32 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > (In reply to Jonathan Druart from comment #1) > Can you explain the issue a bit? On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00 (http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime consider it as an invalid date. It is a problem when we are playing with dates without the time part (always 00:00). When we instantiate a DateTime (from dt_from_string) we are already handling this issue, and use the floating timezone (since bug 12669). The problem remains when we generate a DateTime then add or subtract a duration, which will result in an invalid date: DateTime->new(year => 2019, month => 12, day => 3, time_zone => 'America/Sao_Paulo')->subtract(days => 30); => Nov 3rd 2019, kaboom. I think we should replace all the occurrences of dt_from_string->subtract (or ->add) with dt_from_string(undef, undef, 'floating'), to use the floating timezone and avoid the error. Technical note: we must update the prototype of dt_from_string before, to send a hashref instead: dt_from_string({ timezone => 'floating'}); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:31:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:31:52 +0000 Subject: [Koha-bugs] [Bug 23090] New: MySQL validate_password plugin breaks koha-create Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Bug ID: 23090 Summary: MySQL validate_password plugin breaks koha-create Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When attempting to run a simple: sudo koha-create --create-db NewInstance The password generated lacks special characters which causes newer versions of MySQL (5.7.26 on Bionic) to fail. This can be fixed either by lowering the: set GLOBAL validate_password_policy='LOW'; -- or Adding '-s -y' to all the pwgen calls in the koha-create script. The later is more secure, and thus will be the patch here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:32:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:32:20 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:34:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:34:25 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:34:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:34:27 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #1 from Owen Leonard --- Created attachment 90460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90460&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:40:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:40:56 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:41:41 +0000 Subject: [Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC doesn't hold search |OPAC doesn't retain search |filters in results pages |filters in results pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:44:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:44:44 +0000 Subject: [Koha-bugs] [Bug 22986] Tag cloud displays same tag multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22986 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:48:54 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:54:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:54:05 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:54:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:54:07 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 --- Comment #1 from Owen Leonard --- Created attachment 90461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90461&action=edit Bug 22851: Style navigation links in serials modules like same links in other modules This patch makes minor markup changes to the serials sidebar menu include so that links are displayed in a style consistent with similar menus in other areas of the staff client. This patch contains whitespace changes, so please use the "-w" flag when viewing the diff. To test, apply the patch and go to the Serials module. The links in the sidebar menu should be displayed in the same style as the corresponding menu on the Acquisitions home page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 18:56:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 16:56:47 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #9 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Comment on attachment 90388 [details] [review] > Bug 23057: Update do_checkin > > Review of attachment 90388 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +1945,4 @@ > > } > > > > if ( $item->itemlost and C4::Context->preference("BlockReturnOfLostItems") ) { > > + $messages->{'ReturnOfLostItemBlocked'}; > > Should we handle it from returns.pl as well? It would make sense. I find it odd that that is the *only* doreturn block without a message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 19:40:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 17:40:40 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 --- Comment #2 from Katrin Fischer --- Thx Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 19:59:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 17:59:57 +0000 Subject: [Koha-bugs] [Bug 22727] Forgiven fines are recreated when lost item that was not marked returned is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22727 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Andrew --- *** This bug has been marked as a duplicate of bug 22877 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 19:59:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 17:59:57 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 --- Comment #37 from Andrew --- *** Bug 22727 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:13:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:13:31 +0000 Subject: [Koha-bugs] [Bug 23091] New: Restore Forgiven Overdue Fines When Lost Item Returned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Bug ID: 23091 Summary: Restore Forgiven Overdue Fines When Lost Item Returned Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 22877 is closing a loophole that several libraries have been happily using to achieve their desired fine behavior. These libraries want this behavior: - item accrues overdue fine up to maximum - when item is lost, overdue fine is forgiven and lost fee is applied - when item is returned, lost fee is forgiven and overdue fine is restored So, while many libraries will see bug 22877 as a fix, for some libraries it will be a very big disruption. My understanding of bug 22877 is that we're changing the fine calculation at checkin to not do anything with fines if the item is lost. Maybe we need to instead say don't add fines if the item is lost and the there is an existing fine for that issue where amountoutstanding!=0? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:13:41 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22877 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:13:41 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23091 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:14:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:14:05 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:18:29 +0000 Subject: [Koha-bugs] [Bug 23062] List of checked-in items disappared if there is transfer warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23062 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 22896 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:18:29 +0000 Subject: [Koha-bugs] [Bug 22896] Item to be transferred at checkin clears overridden due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #13 from Nick Clemens --- *** Bug 23062 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:27:43 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52462|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 90462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90462&action=edit Bug 16750 - Redirect from selectbranchprinter.pl to additem.pl causes software error How to reproduce: 1) Edit and save an item in the items editor 2) You should be redirected back to the items editor, note that the biblionumber is not passed in the url 3) Choose "set library" from the upper right hand pulldown on the page 4) Choose a different library, click submit 5) You should get the error message: Software error: Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test Plan: 1) Apply this patch 2) Follow plan above 3) No software error should occur at step 5 Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:28:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:28:53 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |nick at bywatersolutions.com --- Comment #16 from Nick Clemens --- Three years later, still a valid bug. In testing Kyle's patch solves the issue - Jonathan's leads to 404 I think we should open new bug for the more general fix and deal with those issues there and fix up at least this known error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:33:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:33:58 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #3 from Donna --- Confirming Comment 1 - this is still an issue, and is causing confusion for staff as they have to look up what the defaults should be for the different categories of patrons that are being added to the parent card. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:53:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:53:52 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:53:54 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 --- Comment #1 from M. Tompsett --- Created attachment 90463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90463&action=edit Bug 23090: Add some special characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:58:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:58:06 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 --- Comment #2 from M. Tompsett --- TEST PLAN --------- $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP at ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 Clean up of useless instances is left as an exercise to the reader. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:58:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:58:40 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 --- Comment #3 from Nick Clemens --- Created attachment 90464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90464&action=edit Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:58:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:58:38 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 20:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 18:59:03 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |oleonard at myacpl.org Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 21:10:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 19:10:20 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Agreeing with both Katrin and Jonathan here - moving to Assigned for future work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 21:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 19:13:58 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Nick Clemens --- In testing the fields appear in the order they are cataloged,we can adjust the order in both editors, closing this one now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 21:57:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 19:57:08 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 21:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 19:57:11 +0000 Subject: [Koha-bugs] [Bug 23065] 'New subscription' button in serials sometimes uses a blank form and sometimes defaults to current serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23065 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90439|0 |1 is obsolete| | --- Comment #2 from Michal Denar --- Created attachment 90465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90465&action=edit Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial" Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 21:57:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 19:57:30 +0000 Subject: [Koha-bugs] [Bug 1887] Managing Suggestions - hold books for patron who requested In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887 --- Comment #5 from Barbara Johnson --- That should have been bug #19358 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 22:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 20:00:04 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #5 from Michal Denar --- Hi Alex, any test plan? Thank You. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 23:10:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 21:10:51 +0000 Subject: [Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 23:21:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 21:21:56 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 23:21:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 21:21:59 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90405|0 |1 is obsolete| | Attachment #90411|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 90466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90466&action=edit Bug 23045: TextMarc errors on blank lines Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when processing blank lines. We should just pass on these rather then erroring To test: 1 - Define a new macro that delete more fields than it adds delete 245 2 - Run it 3 - Note an error in JS console, and helpers will not load 4 - Apply patch 5 - Reload, try again 6 - No error Signed-off-by: Claire Gravely Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 23:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 21:22:07 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error when lines deleted by macros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 --- Comment #5 from Liz Rea --- Created attachment 90467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90467&action=edit Bug 23045: Return record along with errors We don't seem to directly handle the errors in most cases, let's always return the record To test: 1 - Add some blank lines to editor, previous patch is okay with this 2 - Add a line with just 'e' or some other incomplete field 3 - Try to save 4 - Note JS leader error 5 - Apply this patch 6 - No errors Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 10 23:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jun 2019 21:49:19 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nadine.pierre at InLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 02:28:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 00:28:11 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #48 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #47) > Please take a look at bug 22454 and bug 22455. The rationale is that if you > have the biblio object, you can know all that is needed regarding hiding in > OPAC without fetching MARC data or complex calculations. And if we were to > add parameters like category and library, I would rather pass the > Koha::Patron object altogether. > This check, with bug 22457 in mind could be written: > > my $should_hide = ( $patron->category->overrides_opac_hidding_policy or > $patron->library->overrides_opac_hidding_policy ) > ? 0 > : 1; > > while ( my $biblio = $biblios->next ) { > next if $biblio->hidden_in_opac and $should_hide; > do_your_things(); > } > > This check should be written on the controller script. Doesn't quite work. The idea is: if (! defined $patron) { $globally_override = 0; } elsif (! defined $patron->category) { $globally_override = 0; } else { $globally_override = $patron->category->globally_overrides_opac_hiding; } while ( my $biblio = $bilbios->next ) { if (! defined $patron) { $locally_override = 0; } else { $locally_override = ($patron->branchcode ne $biblio->homebranch) ? 0 : $patron->category->overrides_opac_hiding_policy_locally; } $should_show = $globally_override || $locally_override; $should_hide = ! $should_show; next if $biblio->hidden_in_opac && $should_hide; do_your_things(); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 02:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 00:39:07 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #49 from M. Tompsett --- Doh! That doesn't quite work, because homebranch is on item. So, you want to pass patron to hidden_in_opac on items... Okay... Hmm... thinking.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 03:30:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 01:30:21 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90464|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 90468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90468&action=edit Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 03:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 01:30:18 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 03:49:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 01:49:34 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #2 from M. Tompsett --- Comment on attachment 90460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90460 Bug 23078: Use Koha.Preference in OPAC global header include Review of attachment 90460: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23078&attachment=90460) ----------------------------------------------------------------- Fix the lines that should be removed, and I'll sign off. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc @@ +9,4 @@ > [% IF ( bidi ) %] > [% Asset.css("lib/bootstrap/css/bootstrap-rtl.min.css") | $raw %] > + [% Asset.css("lib/jquery/jquery-ui-rtl.css") | $raw %] > + [% Asset.css("css/right-to-left.css") | $raw %] Nice clean up moves. @@ +20,1 @@ > [% END %] You probably could have deleted these three lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 03:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 01:49:58 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett --- Because extra lines got left behind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 03:51:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 01:51:44 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #4 from M. Tompsett --- (In reply to M. Tompsett from comment #3) > Because extra lines got left behind. 18 [% IF ( bidi ) %] 19 [% ELSE %] 20 [% END %] Those ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 05:05:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 03:05:21 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #138 from Agust?n Moyano --- Created attachment 90469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90469&action=edit Bug 22284: (follow-up) Fix typo in request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 05:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 03:33:48 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 05:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 03:33:53 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90389|0 |1 is obsolete| | --- Comment #86 from Hayley Mapley --- Created attachment 90470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90470&action=edit Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 05:33:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 03:33:59 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90390|0 |1 is obsolete| | --- Comment #87 from Hayley Mapley --- Created attachment 90471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90471&action=edit Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 05:34:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 03:34:06 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90391|0 |1 is obsolete| | --- Comment #88 from Hayley Mapley --- Created attachment 90472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90472&action=edit Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 05:34:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 03:34:12 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90392|0 |1 is obsolete| | --- Comment #89 from Hayley Mapley --- Created attachment 90473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90473&action=edit Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 06:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 04:25:38 +0000 Subject: [Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #4 from M. Tompsett --- This is a global override, this is not the branch-based override as envisioned in bug 10589. So, perhaps both overrides, outright and partial based on matching item homebranch and patron branch, should be fields in the patron category table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:02:22 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:02:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:02:25 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #5 from Claire Gravely --- Created attachment 90474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90474&action=edit [SIGNED-OFF] Bug 23077 - Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:02:28 +0000 Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #6 from Claire Gravely --- Created attachment 90475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90475&action=edit [SIGNED-OFF] Bug 23077 - Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:10:07 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:10:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:10:10 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90461|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 90476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90476&action=edit Bug 22851: Style navigation links in serials modules like same links in other modules This patch makes minor markup changes to the serials sidebar menu include so that links are displayed in a style consistent with similar menus in other areas of the staff client. This patch contains whitespace changes, so please use the "-w" flag when viewing the diff. To test, apply the patch and go to the Serials module. The links in the sidebar menu should be displayed in the same style as the corresponding menu on the Acquisitions home page. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:38:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:38:01 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:38:03 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:38:05 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:38:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:38:06 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:38:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:38:08 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 09:38:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 07:38:10 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 10:16:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 08:16:39 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #47 from Martin Renvoize --- (In reply to Tom?s Cohen Arazi from comment #15) > Proposal for discussion: > - Make it explicit by declaring what 'capabilities' the plugin has, like > our $capabilities = { tools => 1, ... }; > - Rename methods => capabilities: > CREATE TABLE IF NOT EXISTS plugin_capabilities ( > class varchar(255) NOT NULL, > capability varchar(255) NOT NULL, > PRIMARY KEY ( `class` (191), `capability` (191) ) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; I sort of like the idea behind this (very much borrowed from ILL backends ;) ), but I'm happy for it to wait for another patch if we deem it's helpful. I do however note we're currently loading all class methods into the database.. do we perhaps want to restrict them to 'public' methods only (i.e. missing out _method methods) or even limit down to only 'supported' methods known by the plugin system? (I'm not sure about the latter.. we might want to allow a plugin to introspect itself for some reason in the future... perhaps?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 10:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 08:23:30 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #48 from Martin Renvoize --- New dependency introduced: 'Class::Inspector' but not added to our dependencies lists yet.. can we get that as a QA followup here please (Seems fine for it to be added to me as it appears to all be packaged for debian already) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 10:23:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 08:23:42 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 10:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 08:52:26 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #49 from Martin Renvoize --- Comment on attachment 89801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89801 Bug 21073: Improve plugin performance Review of attachment 89801: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21073&attachment=89801) ----------------------------------------------------------------- A few, hopefully minor, bits of feedback.. Failing QA whilst I await a reply. ::: Koha/Plugins.pm @@ +73,5 @@ > my $method = $params->{method}; > my $req_metadata = $params->{metadata} // {}; > > + my $dbh = C4::Context->dbh; > + my $plugin_classes = $dbh->selectcol_arrayref('SELECT DISTINCT(plugin_class) FROM plugin_methods'); Why do we mix old dbh calls with dbic calls in this new code? Also, can we not skip a series of DB calls that are found in the loop by filtering on $method if it exists before running through the loop? @@ +119,4 @@ > > my $plugin = $plugin_class->new({ enable_plugins => $self->{'enable_plugins'} }); > > + Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete(); Can't make my mind up as to whether we should really rebuilding the whole db table with every/any install/upgrade of any plugin... ::: Koha/Plugins/Handler.pm @@ +63,5 @@ > my $params = $args->{'params'}; > > + my $has_method = Koha::Plugins::Methods->search({ plugin_class => $plugin_class, plugin_method => $plugin_method })->count(); > + if ( $has_method ) { > + load $plugin_class; Is it ever possible for 'load' to fail here and if so should we catch and warn about it?.. We seem to have effectively removed a warning from the prior code.. I'm wondering if we may ever get a case where the plugin exists in the DB but has been deleted from the filesystem. @@ +68,2 @@ > my $plugin = $plugin_class->new( { cgi => $cgi, enable_plugins => $args->{'enable_plugins'} } ); > + my @return = $plugin->$plugin_method( $params ); The above line is never referenced right? ::: plugins/plugins-upload.pl @@ +87,4 @@ > $template->param( ERRORS => [ \%errors ] ); > output_html_with_http_headers $input, $cookie, $template->output; > exit; > + } else { 'unless else' is a weird looking construct.. as we're calling 'exit' in the unless block we can just call the 'Koha::Plugins->new()->InstallPlugins' method below the block and not in it's own else block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 10:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 08:52:38 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:09:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:09:59 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:12:38 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Before this patch, whenever release notes| |a plugin hook was reached | |in koha code we would | |iteratively load plugins | |looking for one that may | |support the method. This | |patch adds database level | |caching of this data so we | |do one database call | |instead of iteratively | |calling 'load'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:15:13 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:16:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:16:28 +0000 Subject: [Koha-bugs] [Bug 18344] Overdue fines 'cap at replacement price' and 'cap by amount' should work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow overdue fines cap at |Overdue fines 'cap at |replacement price, and cap |replacement price' and 'cap |by amount to work together |by amount' should work | |together -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:20:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:20:31 +0000 Subject: [Koha-bugs] [Bug 13094] It should be easy to hide the 'Cancel all' button on the holds over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Summary|Make it easy to hide |It should be easy to hide |'Cancel all' button on |the 'Cancel all' button on |holds over report |the holds over report CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:03 +0000 Subject: [Koha-bugs] [Bug 13094] It should be easy to hide the 'Cancel all' button on the holds over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:05 +0000 Subject: [Koha-bugs] [Bug 13094] It should be easy to hide the 'Cancel all' button on the holds over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:06 +0000 Subject: [Koha-bugs] [Bug 18344] Overdue fines 'cap at replacement price' and 'cap by amount' should work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:09 +0000 Subject: [Koha-bugs] [Bug 18344] Overdue fines 'cap at replacement price' and 'cap by amount' should work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:12 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:15 +0000 Subject: [Koha-bugs] [Bug 23074] Holds table sort does not understand dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23074 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:24:18 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:29:02 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:35:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:35:54 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Kris Sinnaeve changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |kris.sinnaeve at etf.edu Resolution|FIXED |--- --- Comment #32 from Kris Sinnaeve --- Moving the contents of OpacNavRight to opac_news fails due to improper (no?) escaping: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+' at line 1 [for Statement "INSERT INTO opac_news (branchcode, lang, title, content ) VALUES (NULL, 'OpacNavRight_en', '', ' ')"] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 18220. In this example, OpacNavRight contains a script to embed a Twitter timeline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:35:55 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:35:55 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Bug 22783 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:35:55 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Bug 22880 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:41:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:41:11 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items currrent and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:46:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:46:27 +0000 Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:46:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:46:27 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 11:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 09:46:10 +0000 Subject: [Koha-bugs] [Bug 23092] New: Transfers should record 'requested' as well as 'sent' and 'arrived' dates. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Bug ID: 23092 Summary: Transfers should record 'requested' as well as 'sent' and 'arrived' dates. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- The transfers system is very much tied to the Holds/Reserves features at the moment, but slowly some other subsystems are starting to use it too (Stock Rotation, Rotating Collections). For full audit purposes we should record the 'requested' date along with the 'sent' and 'arrived' dates. Currently stock rotation misuses 'sent' to mean 'requested', so the item may have not actually been picked off the shelf, captured at checkin, and put into physical transit to the next library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 12:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 10:02:28 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 jvr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from jvr --- Dear Sir, We at the FCT NOVA https://www.fct.unl.pt/en already move to version 18.05.06.000 https://opac.fct.unl.pt last year. We hope that your works to enable this preference could be coded in a near future, because it will make a big change in the relation with the patrons. Please inform us which versions will include it... Also, I would like to inform you that we at the FCT NOVA have been doing KOHA workshops for the last seven years and this preference as been asked every time. Thank you in antecipation for an early reply. Victor Ros?rio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 12:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 10:45:30 +0000 Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11897 |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 12:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 10:45:30 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23092 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 12:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 10:45:30 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 12:56:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 10:56:05 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90458|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 90477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90477&action=edit Bug 22569: Proof of concept This patch adds a proof of concept 'Transfers to send' report to the circulation page. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:02:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:02:11 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Martin Renvoize --- This patch adds a 'Transfers to send' report to compliment the 'Transfers to receive' report. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:02:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:02:21 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:05:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:05:05 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #21 from Kyle M Hall --- Created attachment 90478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90478&action=edit Bug 15985: (QA Follow up) Fix issues found by koha-qa.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:08:41 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Kyle M Hall --- I'm unable to resolve the qa failure FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Old::Checkout': current merge results [ Koha::Old::Checkout, ] merging failed on 'Koha::Checkout' without removing the 'use Modern::Perl', which of course causes a different qa failure. I believe we can safely ignore this one. The actual dependency tree is clear and simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:43:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:43:17 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #10 from Kyle M Hall --- Created attachment 90479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90479&action=edit Bug 23057: (QA Follow-up) [ALT PATCH] Handle new ReturnOfLostItemBlocked message in returns.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:47:21 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90479|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 90480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90480&action=edit Bug 23057: (QA Follow-up) Remove new AddReturn message ReturnOfLostItemBlocked, use existing pattern from returns.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:47:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:47:31 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:51:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:51:07 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #12 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Comment on attachment 90388 [details] [review] > Bug 23057: Update do_checkin > > Review of attachment 90388 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +1945,4 @@ > > } > > > > if ( $item->itemlost and C4::Context->preference("BlockReturnOfLostItems") ) { > > + $messages->{'ReturnOfLostItemBlocked'}; > > Should we handle it from returns.pl as well? So, implementing this turned out to be way more complicated than I expected. The logic in AddReturn for lost items is "messy" to put it kindly. You can find this patch in the obsolete patches on this bug. As an alternative solution with far fewer changes to the code, I've added a different followup that removes the new ReturnOfLostItemBlocked and follows the existing pattern implemented by returns.pl where the logic is implemented outside AddReturn. I find this to be technically inferior, but re-implementing the ReturnOfLostItemBlocked message properly is far outside the scope of a SIP bug report. The now obsoleted patch could definitely be re-used on a bug dedicated to this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 13:53:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 11:53:52 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #13 from Kyle M Hall --- To follow up on my last comment, I did want to say that if QA feels that my ALT patch is ok as part of this bug, please by all means use it instead of my more terse followup! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:24:49 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:24:52 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90460|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 90481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90481&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:34:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:34:03 +0000 Subject: [Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced cataloging editor |Advanced cataloging editor |(rancor) throws a JS error |(rancor) throws a JS error |when lines deleted by |on incomplete/blank lines |macros | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:39:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:39:01 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #100 from Nick Clemens --- Some feedback: t/db_dependent/TestBuilder.t - occurrence of default_circ_rules Set rule: All-libraries Default holds policy by item type Computer files -> From home library -> Item's home libary -> Item floats Go to a specific branch 'Fairview' - the above rule shows Setting a branch specific does override and then show correctly Set rule: Checkout, hold policy by patron category for Fairview Teacher -> blank -> blank -> 0 rule does not show as set, check the DB, it is set correctly It does prevent teacher from placing holds set to: Teacher -> blank -> blank -> 1 It shows and is set correctly Otherwise testing worked, code functions as I believe it is supposed to, overriding and choosing correct rule. We should move this one early this cycle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:39:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:39:41 +0000 Subject: [Koha-bugs] [Bug 23093] New: Error during upgrade of OpacNavRight preference to Koha news Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 Bug ID: 23093 Summary: Error during upgrade of OpacNavRight preference to Koha news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 22318 Target Milestone: --- Copied from Bug 22318: Moving the contents of OpacNavRight to opac_news fails due to improper (no?) escaping: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+' at line 1 [for Statement "INSERT INTO opac_news (branchcode, lang, title, content ) VALUES (NULL, 'OpacNavRight_en', '', ' ')"] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 18220. In this example, OpacNavRight contains a script to embed a Twitter timeline. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:39:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:39:41 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:40:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:40:18 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #33 from Owen Leonard --- (In reply to Kris Sinnaeve from comment #32) > Moving the contents of OpacNavRight to opac_news fails due to improper (no?) > escaping This issue belongs in a new bug report since this one has already been pushed to master: Bug 23093. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:40:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:40:28 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:40:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:40:29 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:40:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:40:29 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Bug 22783 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:40:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:40:29 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Bug 22880 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 14:40:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 12:40:30 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 Bug 23093 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:07:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:07:09 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens --- Closing this one out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:07:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:07:49 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- (In reply to Michal Denar from comment #2) > Hi, > any test plan? When it is just POD, perl documentation: perldoc {affected file} e.g. perldoc Koha::SharedContent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:08:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:08:56 +0000 Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- Closing this one, seems to be no longer an issue? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:09:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:09:24 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:09:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:09:31 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86996|0 |1 is obsolete| | Attachment #90350|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 90482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90482&action=edit Bug 22358: Add POD to Koha::SharedContent Signed-off-by: Liz Rea Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:09:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:09:36 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 --- Comment #8 from M. Tompsett --- Created attachment 90483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90483&action=edit Bug 22358: fix POD header and typo Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:20:05 +0000 Subject: [Koha-bugs] [Bug 23094] New: Use Bootstrap-style pagination on staged MARC records page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Bug ID: 23094 Summary: Use Bootstrap-style pagination on staged MARC records page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 22935 Target Milestone: --- This patch will update the pagination links on the staged MARC records page to match the links on the catalog search results page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22935 [Bug 22935] Improve style of Bootstrap pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:20:05 +0000 Subject: [Koha-bugs] [Bug 22935] Improve style of Bootstrap pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22935 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 [Bug 23094] Use Bootstrap-style pagination on staged MARC records page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:27:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:27:59 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:28:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:28:02 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90343|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90484&action=edit Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER To make our sql mode list compatible with MySQL 8.0.11 NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html I do not think we needed it. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:29:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:29:25 +0000 Subject: [Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:29:27 +0000 Subject: [Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 --- Comment #1 from Owen Leonard --- Created attachment 90485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90485&action=edit Bug 23094: Use Bootstrap-style pagination on staged MARC records page This patch makes markup and CSS changes in order to make the pagination links on the staged MARC records page consistent with the links on the catalog search results page. The patch also adds Font Awesome icons to the catalog search results pagination include, replacing angle bracket symbols. To test, apply the patch and rebuild the staff client CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). To test properly you should have enough staged marc record batches that there are multiple pages to list. Go to Tools -> Manage staged MARC records. Test that the pagination links look consistent with the catalog search results page and that they work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:31:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:31:35 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90477|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 90486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90486&action=edit Bug 22569: Proof of concept This patch adds a proof of concept 'Transfers to send' report to the circulation page. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:33:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:33:05 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90486|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 90487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90487&action=edit Bug 22569: Proof of concept This patch adds a proof of concept 'Transfers to send' report to the circulation page. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:33:27 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 --- Comment #9 from Fridolin SOMERS --- Created attachment 90488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90488&action=edit Bug 22944: remove obsolete unit test Test 'AnonymiseIssueHistory should not return any error if success' is obsolete, previous statement will explode if something went wrong. Test plan : Run t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:34:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:34:40 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #7 from Martin Renvoize --- Work still to be done.. Unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:34:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:34:55 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:36:51 +0000 Subject: [Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens --- Patches work, however, the tests delete all my data, then start a transaction at the end? QA tool doesn't like commit title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:36:53 +0000 Subject: [Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #18 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:38:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:38:55 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23022 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:38:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:38:55 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22128 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:40:04 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:40:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:40:07 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #6 from Claire Gravely --- Created attachment 90489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90489&action=edit [SIGNED-OFF] Bug 21181: Unit tests Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:40:10 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #7 from Claire Gravely --- Created attachment 90490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90490&action=edit [SIGNED-OFF] Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:40:25 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #5 from M. Tompsett --- Created attachment 90491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90491&action=edit Bug 22128: Removed outdated comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:41:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:41:19 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:41:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:41:30 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90081|0 |1 is obsolete| | Attachment #90491|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 90492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90492&action=edit Bug 22128: Use DROP USER IF EXISTS instead of GRANT USAGE before DROP USAGE MySQL 5.7 is old, and the latest versions fail on "GRANT USAGE" if the user does not exist. "DROP USER IF EXISTS" has been with us since 5.7, so all users should have it by now. This patch fixes the issue. To test: Try to koha_remove a site, and if it works with no errors, all good! Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:41:33 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #7 from M. Tompsett --- Created attachment 90493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90493&action=edit Bug 22128: Removed outdated comment Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:43:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:43:08 +0000 Subject: [Koha-bugs] [Bug 23037] Henry Bolshaw is missing from the contributors list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23037 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:45:39 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #20 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:48:33 +0000 Subject: [Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:49:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:49:39 +0000 Subject: [Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:51:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:51:23 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #25 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:53:21 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items currrent and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 --- Comment #1 from Martin Renvoize --- Erm, maybe I'm not looking at the right screen.. I see 'Stages & duration in days (current stage highlighted)' as the next field across from 'In transit' and it highlights where the item currently is on the rotation and where it will be going next. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 15:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 13:55:47 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Stock rotation manage rotas |Stock rotation manage rotas |should show items currrent |should show items current |and desired locations |and desired locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:05:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:05:20 +0000 Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:06:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:06:51 +0000 Subject: [Koha-bugs] [Bug 22802] When ordering from a staged file, if funds are populated per item order level fund should not be required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:08:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:08:23 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:14:40 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:28:49 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:28:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:28:52 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 --- Comment #1 from Jonathan Druart --- Created attachment 90494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90494&action=edit Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:31:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:31:43 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #6 from Jonathan Druart --- Created attachment 90495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90495&action=edit Bug 22880: Use placeholders Always. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:32:44 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:36:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:36:12 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 --- Comment #10 from M. Tompsett --- Created attachment 90496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90496&action=edit Bug 11642: change / to and in related tools menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:37:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:37:30 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:37:33 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90381|0 |1 is obsolete| | Attachment #90457|0 |1 is obsolete| | Attachment #90496|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 90497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90497&action=edit Bug 11642: Add confirmation and tooltips to batch deletion tool Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:37:37 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 --- Comment #12 from M. Tompsett --- Created attachment 90498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90498&action=edit Bug 11642: (follow-up) Batch patron deletion/anonymization should not allow permanent destruction of patron data This patch makes some template changes to try to make this interface more consistent with other areas of Koha and to make warnings more clear. I have also changed the phrase "deletion/anonymization" to "deletion and anonymization." To test, apply the patch and test the patron deletion and anonymization process and confirm that the interface is clear and works well. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:37:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:37:41 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 --- Comment #13 from M. Tompsett --- Created attachment 90499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90499&action=edit Bug 11642: change / to and in related tools menu Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:59:18 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 16:59:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 14:59:21 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90494|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90500&action=edit Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:00:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:00:28 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #2 from Federico Rinaudo --- Reinicie plack y sigue saliendo el mismo error. Utilizo debian 8 y koha est? en su viersi?n 18.11.05.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:04:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:04:35 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #101 from Jonathan Druart --- (In reply to Nick Clemens from comment #100) > Some feedback: > t/db_dependent/TestBuilder.t - occurrence of default_circ_rules Sure? I do not have it :) > Set rule: > All-libraries > Default holds policy by item type > Computer files -> From home library -> Item's home libary -> Item floats > > Go to a specific branch 'Fairview' - the above rule shows > Setting a branch specific does override and then show correctly Yes, that's the error we have since the beginning, patch's coming. Thanks! > Set rule: > Checkout, hold policy by patron category for Fairview > Teacher -> blank -> blank -> 0 > rule does not show as set, check the DB, it is set correctly > It does prevent teacher from placing holds > set to: > Teacher -> blank -> blank -> 1 > It shows and is set correctly > > Otherwise testing worked, code functions as I believe it is supposed to, > overriding and choosing correct rule. We should move this one early this > cycle I'd say it's a master bug, I am investigating it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:06:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:06:56 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #102 from Jonathan Druart --- Created attachment 90501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90501&action=edit Bug 18928: (bug 22847 follow-up 2) Display correctly the values (not the propagated ones) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:13:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:13:55 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #31 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:16:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:16:28 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #16 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:18:48 +0000 Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #13 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:20:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:20:13 +0000 Subject: [Koha-bugs] [Bug 22910] Unique attributes should not be copied when duplicating a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #14 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:24:23 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #22 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:25:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:25:24 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:28:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:28:14 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Should'nt it also be added to UNIMARC ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:30:22 +0000 Subject: [Koha-bugs] [Bug 18344] Overdue fines 'cap at replacement price' and 'cap by amount' should work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #13 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:33:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:33:37 +0000 Subject: [Koha-bugs] [Bug 13094] It should be easy to hide the 'Cancel all' button on the holds over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:42:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:42:44 +0000 Subject: [Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:44:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:44:02 +0000 Subject: [Koha-bugs] [Bug 23095] New: Circulation rules not displayed (empty vs null) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Bug ID: 23095 Summary: Circulation rules not displayed (empty vs null) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18925 Target Milestone: --- >From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:44:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:44:02 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 [Bug 23095] Circulation rules not displayed (empty vs null) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:46:28 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:47:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:47:12 +0000 Subject: [Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:47:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:47:16 +0000 Subject: [Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 --- Comment #1 from Jonathan Druart --- Created attachment 90502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90502&action=edit Bug 23095: Correctly display circulation rules (0 vs undef) >From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:48:02 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23095 --- Comment #103 from Jonathan Druart --- (In reply to Jonathan Druart from comment #101) > > Set rule: > > Checkout, hold policy by patron category for Fairview > > Teacher -> blank -> blank -> 0 > > rule does not show as set, check the DB, it is set correctly > > It does prevent teacher from placing holds > > set to: > > Teacher -> blank -> blank -> 1 > > It shows and is set correctly > > > > Otherwise testing worked, code functions as I believe it is supposed to, > > overriding and choosing correct rule. We should move this one early this > > cycle > > I'd say it's a master bug, I am investigating it. See bug 23095. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:48:02 +0000 Subject: [Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:55:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:55:45 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:55:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:55:48 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #3 from Owen Leonard --- Created attachment 90503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90503&action=edit Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:56:28 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:56:33 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:59:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:59:23 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 17:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 15:59:26 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #4 from Owen Leonard --- Created attachment 90504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90504&action=edit Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:01:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:01:55 +0000 Subject: [Koha-bugs] [Bug 22947] Markup error in OPAC preferences file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:02:14 +0000 Subject: [Koha-bugs] [Bug 23096] New: Add floating toolbar to OPAC lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Bug ID: 23096 Summary: Add floating toolbar to OPAC lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 5287 Target Milestone: --- To match the updated OPAC search results page, the toolbar on the OPAC list contents table should be a floating toolbar. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 [Bug 5287] Add floating toolbar to search results in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:02:14 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23096 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 [Bug 23096] Add floating toolbar to OPAC lists -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:04:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:04:11 +0000 Subject: [Koha-bugs] [Bug 22955] Markup error in OPAC lists template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:09:01 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:14:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:14:26 +0000 Subject: [Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:22:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:22:59 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:23:01 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90344|0 |1 is obsolete| | Attachment #90384|0 |1 is obsolete| | Attachment #90388|0 |1 is obsolete| | Attachment #90480|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 90505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90505&action=edit Bug 23057: If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason This patch fixes a bug from Bug 15221 and hopefully also makes it so that the alert flag is suppressed when checked_in_ok is set and an item is not checked out. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp --port=6001 --address=localhost --item test -m checkin --patron NOTE: You need to replace with the borrowernumber from Step 2, and with the password from Step 0. Signed-off-by: Kyle M Hall Signed-off-by: Matha Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:23:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:23:14 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #15 from Kyle M Hall --- Created attachment 90506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90506&action=edit Bug 23057: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Matha Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:23:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:23:17 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #16 from Kyle M Hall --- Created attachment 90507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90507&action=edit Bug 23057: Update do_checkin Signed-off-by: Kyle M Hall Signed-off-by: Matha Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:23:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:23:20 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 --- Comment #17 from Kyle M Hall --- Created attachment 90508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90508&action=edit Bug 23057: (QA Follow-up) Remove new AddReturn message ReturnOfLostItemBlocked, use existing pattern from returns.pl Signed-off-by: Kyle M Hall Signed-off-by: Matha Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:23:22 +0000 Subject: [Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:35:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:35:04 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #36 from Nick Clemens --- Created attachment 90509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90509&action=edit Bug 19014: [alternate-alternate] Only process issues for autorenewal if on or after soonest renewal date This patch check the soonest renewal date and skips processing auto renewals if before this date This ensures patrons won't get notifications far in advance if an item is on hold or has other issues To test: 1 - Checkout an item to a patron with a due date 2 days in the future and 'No renewal before' unset 2 - Place a hold on that item 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum [% checkout.auto_renew_error %] 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices 5 - Patron is not notified 6 - Set 'No renewal before' to 1 7 - run cronjob 8 - Patron is notified with error 'on_reserve' 9 - Set 'No renewal before' to 3 10 - UPDATE issues SET auto_renew_error = NULL; 11 - run cronjob 12 - Patron is notified with error 'on_reserve' 13 - APPLY PATCH 14 - Unset 'No renewal before' 15 - UPDATE issues SET auto_renew_error = NULL; 16 - run cronjob 17 - Patron is not notified 18 - UPDATE issues SET auto_renew_error = NULL; 19 - Set 'No renewal before' to 1 20 - run cronjob 21 - Patron is notified with error 'on_reserve' 22 - Set 'No renewal before' to 3 23 - UPDATE issues SET auto_renew_error = NULL; 24 - run cronjob 25 - Patron is not notified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:36:57 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #37 from Nick Clemens --- I tested David's patch with our educators, I don't think it quite does what it meant to do. I attached an updated version of David's patch that simplifies the logic, I believe this fulfills the intent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:37:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:37:43 +0000 Subject: [Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:40:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:40:37 +0000 Subject: [Koha-bugs] [Bug 23097] New: Circulation Overdues report patron link goes to patron's holds tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Bug ID: 23097 Summary: Circulation Overdues report patron link goes to patron's holds tab Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jyorio at esilibrary.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Steps to reproduce: Go to Circulation Click Overdues Apply any filters you know will return overdue items Click Apply Filter Click on a patron Notice that it takes you to their Holds tab, and the URL ends with #reserves At least as recently as 17.11, clicking the link took you to the patron's detail screen, not their holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:40:27 +0000 Subject: [Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:42:46 +0000 Subject: [Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:44:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:44:31 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #37 from Jonathan Druart --- Asking for another QA feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:53:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:53:56 +0000 Subject: [Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90502|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90510&action=edit Bug 23095: Correctly display circulation rules (0 vs undef) >From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 18:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 16:53:53 +0000 Subject: [Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 19:06:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 17:06:04 +0000 Subject: [Koha-bugs] [Bug 23098] New: KOC upload process has misleading wording Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 Bug ID: 23098 Summary: KOC upload process has misleading wording Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: bdaeuber at cityoffargo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- During the KOC upload process, after a user clicks "Upload", Koha will return "Your file was processed". This is somewhat misleading and implies the process is over. When looking at pending offline circulation actions that button also says "Process", so staff that do this rarely may get them confused and stop the process too early. I suggest changing the wording to "Your file was uploaded. Once all files are uploaded, please process them in pending offline circulation actions." or something to that effect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 19:10:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 17:10:02 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90196|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 90511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90511&action=edit Bug 15814: Handle correctly MMTA edit button The MARC modification template action edit buton does not correctly handle variable escaping. Assigning a JS variable containing the JSON representation of the hashref will make the processing much more easier. Test plan: Create a MARC Modification Template with several actions. In the description you should use the following characters, to try to break this patch: \ ' " \n \r (not sure what we handled \n and \r) Then edit the action, modify and save again. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 19:09:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 17:09:59 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 19:44:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 17:44:54 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 19:44:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 17:44:56 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #1 from Owen Leonard --- Created attachment 90512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90512&action=edit Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:06:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:06:43 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90504|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 90513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90513&action=edit Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:06:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:06:51 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #6 from Liz Rea --- Created attachment 90514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90514&action=edit Bug 5287: (QA follow-up) update deprecated button Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:06:40 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:08:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:08:32 +0000 Subject: [Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- Sorry Owen, even following the dependencies, I can't seem to get this one to apply. :/ Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:12:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:12:07 +0000 Subject: [Koha-bugs] [Bug 23099] New: OPAC Search result sorting "go" button flashes on page load Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Bug ID: 23099 Summary: OPAC Search result sorting "go" button flashes on page load Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I think this button is supposed to be hidden, but it seems to flash on/off when the page loads. It'd probably be tidier if it didn't do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:35:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:35:42 +0000 Subject: [Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90485|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 90515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90515&action=edit Bug 23094: Use Bootstrap-style pagination on staged MARC records page This patch makes markup and CSS changes in order to make the pagination links on the staged MARC records page consistent with the links on the catalog search results page. The patch also adds Font Awesome icons to the catalog search results pagination include, replacing angle bracket symbols. To test, apply the patch and rebuild the staff client CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). To test properly you should have enough staged marc record batches that there are multiple pages to list. Go to Tools -> Manage staged MARC records. Test that the pagination links look consistent with the catalog search results page and that they work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:35:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:35:40 +0000 Subject: [Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:48:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:48:52 +0000 Subject: [Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:49:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:49:26 +0000 Subject: [Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 11 20:49:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jun 2019 18:49:29 +0000 Subject: [Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 --- Comment #1 from Owen Leonard --- Created attachment 90516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90516&action=edit Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the ... that shows all the options in the export table, but we want only the selected option They might be some more issues. Good Luck :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 16:51:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 14:51:39 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 16:53:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 14:53:17 +0000 Subject: [Koha-bugs] [Bug 23128] New: Missing Net::OAuth2::AuthorizationServer dependency Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Bug ID: 23128 Summary: Missing Net::OAuth2::AuthorizationServer dependency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Target Milestone: --- The Net::OAuth2::AuthorzationServer library packaging is missing a dependency: Crypt::PRNG. This causes the OAuth2 protocol to fail for production sites. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 16:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 14:53:28 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:11:50 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:11:53 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 --- Comment #1 from Owen Leonard --- Created attachment 90603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90603&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:13:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:13:07 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90567|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 90604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90604&action=edit Bug 23115: Tweak display of totals on 'Fines and charges' page This patch tweaks the display of totals on the OPAC 'Fines and charges' page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the 'Fines and charges' page before applying the patch 3) Look at the 'Fines and charges' page after applying the patch 4) Varify the new layout is an improvment or not Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:16:00 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 --- Comment #4 from Martin Renvoize --- Created attachment 90605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90605&action=edit Proposal 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:20:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:20:59 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:25:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:25:37 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 17:45:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 15:45:19 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 18:00:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 16:00:20 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Are we supposed to be able to set the number to 0? I thought we were Currently 0 turns into empty turns into unlimited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 18:02:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 16:02:01 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #5 from Lisette Scheer --- (In reply to Martin Renvoize from comment #3) > (In reply to Lisette Scheer from comment #1) > > In the Step: Places a hold on the item for the patron and marks it ready for > > collection, I'd like to recommend a preference if it marks it as available > > for pickup. > > Happy to add a preference, though I do wonder how the item is then meant to > get to 'ready for collection'? > If a hold is still placed for the patron, the hold could be captured by checking the item in, perhaps a place hold and marks it ready for collection button and a separate place hold button where they would have to scan it in again to mark the hold ready? That would solve both issues I brought up in my comment. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 18:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 16:27:47 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23102 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 [Bug 23102] 404 errors on page causes SCI user to be logged out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 18:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 16:27:47 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 [Bug 18387] 404 errors on page causes SCO user to be logged out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:12:45 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #44 from Nick Clemens --- I think Kyle Qaed? marking as such -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:17:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:17:39 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:17:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:17:42 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90596|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 90606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90606&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:36:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:36:41 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:36:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:36:43 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90484|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 90607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90607&action=edit Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER To make our sql mode list compatible with MySQL 8.0.11 NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html I do not think we needed it. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:41:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:41:27 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:41:33 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90483|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 90609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90609&action=edit Bug 22358: fix POD header and typo Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:41:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:41:30 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90482|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 90608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90608&action=edit Bug 22358: Add POD to Koha::SharedContent Signed-off-by: Liz Rea Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:41:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:41:36 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 --- Comment #11 from Nick Clemens --- Created attachment 90610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90610&action=edit Bug 22358: (QA follow-up) Clear up phrasing Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:49:37 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:49:40 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90436|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 90611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90611&action=edit Bug 9834: Add DB changes Signed-off-by: Liz Rea Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:49:44 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90437|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 90612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90612&action=edit Bug 9834: Add tests Signed-off-by: Liz Rea Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:49:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:49:47 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90438|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 90613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90613&action=edit Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") Signed-off-by: Liz Rea Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:53:29 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |9834 --- Comment #31 from Nick Clemens --- 9834 allows for manual reversion of hold to take original state of hold (item level vs next available) This should be adapted to use that code, or maybe that fix satisfies the requirements here? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:53:29 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 [Bug 20844] Reset a hold when it is missing after allocation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:56:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:56:30 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Wildcards not being analyzed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ElasticSearch - Dash is |ElasticSearch - Wildcards |considered like a boolean |not being analyzed |operator | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:57:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:57:27 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Wildcards not being analyzed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 19:57:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 17:57:31 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Wildcards not being analyzed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90260|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 90614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90614&action=edit Bug 21534: Always compute wildcards You get no results when searching with an hyphen + with * in query string (or with preference QueryAutoTruncate) : ie /cgi-bin/koha/opac-search.pl?q=saints-anges* Looks like query-string by default does not compute wildcards, see analyze_wildcard in : https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html Test plan : 1) Use Elasticsearch 2) Create a record with "saints-anges" 3) Search for "saints-anges" => you get results 4) Search for "saints-anges*" => you get results 5) Search for "saints-ang*" => you get results Signed-off-by: Michal Denar Signed-off-by: Arthur Bousquet Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:05:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:05:22 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90603|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 90615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90615&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:05:32 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:11:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:11:46 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90604|0 |1 is obsolete| | --- Comment #5 from Nadine Pierre --- Created attachment 90616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90616&action=edit Bug 23115: Tweak display of totals on 'Fines and charges' page This patch tweaks the display of totals on the OPAC 'Fines and charges' page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the 'Fines and charges' page before applying the patch 3) Look at the 'Fines and charges' page after applying the patch 4) Varify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:11:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:11:59 +0000 Subject: [Koha-bugs] [Bug 23129] New: Items holdingbranch should be set to the originating library when generating a transfer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Bug ID: 23129 Summary: Items holdingbranch should be set to the originating library when generating a transfer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- In C4::Items::ModItemTransfer we call ModItem to update the holdingbranch of the item. Currently we set this to the transfer destination. By definition we are generating a transfer because the item has not yet arrived. We should set the holdingbranch to the current location of the item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:12:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:12:32 +0000 Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:13:51 +0000 Subject: [Koha-bugs] [Bug 23100] Notify user if leaving modified patron edit form without saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23100 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:13:53 +0000 Subject: [Koha-bugs] [Bug 23100] Notify user if leaving modified patron edit form without saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23100 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90526|0 |1 is obsolete| | --- Comment #3 from Bin Wen --- Created attachment 90617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90617&action=edit Bug 23100: Add leave page confirmation to patron edit form Test plan: 1) Apply the patch 2) Try to edit a patron, change some value and try to go out without saving, you should be notified you have unsaved changes For me,it works on chrome and firefox Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:18:46 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90580|0 |1 is obsolete| | --- Comment #2 from Bin Wen --- Created attachment 90618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90618&action=edit Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:18:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:18:43 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:20:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:20:22 +0000 Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:20:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:20:24 +0000 Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #1 from Nick Clemens --- Created attachment 90619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90619&action=edit Bug 23129: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:20:27 +0000 Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 --- Comment #2 from Nick Clemens --- Created attachment 90620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90620&action=edit Bug 23129: Set holdingbranch to library that initiates transfer To test: 1 - Find an item 2 - Check it in at anothe rbranch and initiate a transfer 3 - View the item details or check db - note that holdingbranch is set as the destination library 4 - Complete or cancel the transfer 5 - Apply patch 6 - Initiate a new transfer 7 - Note the holdingbranch is set to the initiating library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:20:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:20:32 +0000 Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:22:20 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90600|0 |1 is obsolete| | --- Comment #6 from Maryse Simard --- Created attachment 90621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90621&action=edit Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Verify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:22:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:22:29 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:24:28 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90616|0 |1 is obsolete| | --- Comment #6 from Maryse Simard --- Created attachment 90622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90622&action=edit Bug 23115: Tweak display of totals on 'Fines and charges' page This patch tweaks the display of totals on the OPAC 'Fines and charges' page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the 'Fines and charges' page before applying the patch 3) Look at the 'Fines and charges' page after applying the patch 4) Varify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:25:28 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:25:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:25:31 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90618|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 90623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90623&action=edit Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 Signed-off-by: Bin Wen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:27:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:27:13 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:30:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:30:23 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90615|0 |1 is obsolete| | --- Comment #3 from Nadine Pierre --- Created attachment 90624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90624&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:37:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:37:11 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:37:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:37:14 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90621|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 90625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90625&action=edit Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Verify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Maryse Simard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:39:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:39:28 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90624|0 |1 is obsolete| | --- Comment #4 from Arthur Bousquet --- Created attachment 90626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90626&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:46:19 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90626|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 90627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90627&action=edit Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard Signed-off-by: Nadine Pierre Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:46:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:46:16 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:50:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:50:28 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 20:51:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 18:51:01 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90488|0 |1 is obsolete| | --- Comment #10 from Arthur Bousquet --- Created attachment 90628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90628&action=edit Bug 22944: remove obsolete unit test Test 'AnonymiseIssueHistory should not return any error if success' is obsolete, previous statement will explode if something went wrong. Test plan : Run t/db_dependent/Koha/Patrons.t Signed-off-by: Arthur Bousquet Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 21:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 19:30:53 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90468|0 |1 is obsolete| | --- Comment #5 from Bouzid Fergani --- Created attachment 90629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90629&action=edit Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug Signed-off-by: Mark Tompsett Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 21:51:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 19:51:28 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #50 from Tom?s Cohen Arazi --- Created attachment 90630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90630&action=edit Bug 21073: (follow-up) Add Class::Inspector to PerlDependencies Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 21:51:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 19:51:33 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #51 from Tom?s Cohen Arazi --- Created attachment 90631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90631&action=edit Bug 21073: (QA follow-up) Only public subs should be considered Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 22:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 20:04:28 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #70 from Martin Renvoize --- Created attachment 90632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90632&action=edit Bug 22563: (QA follow-up) Use issue_id in chargelostitem C4::Accounts::chargelostitem contained a FIXME which asked if an item should be charged for it lost, returned and then lost again. We add handling for that case here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 22:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 20:18:31 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Marie-Luce Laflamme --- Patch doesn't apply. Unfortunately, the content toolbar doesn't stick to the top. No specific error message while applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 22:42:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 20:42:21 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #26 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 22:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 20:49:13 +0000 Subject: [Koha-bugs] [Bug 22910] Unique attributes should not be copied when duplicating a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 22:53:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 20:53:44 +0000 Subject: [Koha-bugs] [Bug 23076] Include OpacUserJS on OPAC maintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 23:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 21:00:34 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 23:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 21:00:37 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90597|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90633&action=edit Bug 23120: Pass necessary inputs through when transferring item automatically To test: 1 - Find an item in you system 2 - Have syspref AutomaticItemReturn = Do 3 - Check in the item at a branch that is not its homebranch a) admin/admin set library b) circulation->checkin 4 - Click 'Print slip' on the modal popup 5 - Error! 6 - Apply patch 7 - Check the item in at its homebranch (to clear transfers) 8 - Check it in at another branch again 9 - Print slip 10 - Success! Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 23:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 21:24:20 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 14 23:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jun 2019 21:24:23 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89934|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 90634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90634&action=edit Eliminates both error messages. Looks good, thanks Owen. Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 03:39:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 01:39:25 +0000 Subject: [Koha-bugs] [Bug 23130] New: Incorrect alternative mana server URL in etc/koha-conf.xml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 Bug ID: 23130 Summary: Incorrect alternative mana server URL in etc/koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Mana-kb Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com Target Milestone: --- The commented out alternative mana KB server URL included in etc/koha-conf.xml is not correct. If it is used it generates an error message when submitting an account creation request, and the account creation request fails. Error message: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\n References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 03:40:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 01:40:43 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 --- Comment #1 from David Nind --- The URL should start with https instead of http: - Current URL: - Corrected URL: To replicate the issue: 1) Add http://mana-test.koha-community.org to /etc/koha/sites//koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\n References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 --- Comment #2 from David Nind --- Created attachment 90635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90635&action=edit Bug 23130: Fix alternative mana server URL in etc/koha-conf.xml If the alternative mana KB server URL in etc/koha-conf.xml is used it causes an error message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\nhttp://mana-test.koha-community.org to /etc/koha/sites//koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\n References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 05:18:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 03:18:27 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 08:19:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 06:19:56 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #71 from Martin Renvoize --- Created attachment 90637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90637&action=edit Bug 22563: (QA follow-up) Catch LOST maninvoice cases One could add a manual invoice of type LOST but we would not associate it with an issue_id. This patch tries to catch such cases and extrapolate an issue_id to add to the accountline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 08:50:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 06:50:36 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fix updates the release notes| |alternative Mana KB server | |URL in | |etc/koha-conf.xml to | |https://mana-test.koha-comm | |unity.org. If the updated | |URL is used the account | |creation request is | |successful and doesn't | |cause any error messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:36 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:39 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:41 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Wildcards not being analyzed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:43 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Wildcards not being analyzed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:45 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:47 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:49 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:51 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:53 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:55 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:56 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:02:58 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:03:00 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:03:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:03:01 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:03:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:03:04 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:03:05 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 09:27:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 07:27:00 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement displays a release notes| |more meaningful error | |message if an incorrect | |Mana KB service URL is used | |in the koha-conf.xml | |configuration file (for | |example, if http is used | |instead of https), rather | |than the direct output from | |the failed json parse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 12:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 10:54:28 +0000 Subject: [Koha-bugs] [Bug 22915] Cannot subscribe to Mana-KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fix updates the Mana release notes| |server URL in | |etc/koha-conf.xml so that | |it uses the correct URL - | |https://mana-kb.koha-commun | |ity.org. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 13:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 11:40:27 +0000 Subject: [Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 Jens Weber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber at phsh.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 13:50:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 11:50:43 +0000 Subject: [Koha-bugs] [Bug 20203] Add info about contributing to koha-community.org/documentation/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea at gmail.com |david at davidnind.com CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 14:11:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 12:11:49 +0000 Subject: [Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 Jens Weber changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 22:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 20:53:53 +0000 Subject: [Koha-bugs] [Bug 23122] When searching callnumber in simple search, search option is not retained In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23122 --- Comment #6 from Katrin Fischer --- Thanks Owen for the super quick fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 15 22:56:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jun 2019 20:56:38 +0000 Subject: [Koha-bugs] [Bug 23127] Using commas in shipping cost on invoices causes issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- What format are you trying to put in? 10,00? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 16 22:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Jun 2019 20:09:55 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- (In reply to Nick Clemens from comment #8) > Are we supposed to be able to set the number to 0? I thought we were > > Currently 0 turns into empty turns into unlimited We definitely need 0 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 16 22:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Jun 2019 20:10:18 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:32:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:32:49 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:36:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:36:15 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90633|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 90638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90638&action=edit Bug 23120: Pass necessary inputs through when transferring item automatically To test: 1 - Find an item in you system 2 - Have syspref AutomaticItemReturn = Do 3 - Check in the item at a branch that is not its homebranch 4 - Click 'Print slip' on the modal popup 5 - Error! 6 - Apply patch 7 - Check the item in at its homebranch (to clear transfers) 8 - Check it in at another branch again 9 - Print slip 10 - Success! Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:36:50 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Nice easy fix, works well. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:45:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:45:21 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize --- (In reply to Jonathan Druart from comment #10) > Because there are 3 values: From any library, From home library and not > allowed (0) I'm wondering if we're taking into account the 1, and 2 options correctly then in that case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:46:14 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89665|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 90639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90639&action=edit Bug 13640: Do not display unreserveable items on the Holds to pull screen We should only display the items that meet the hold policies Test plan: It would be good to have a huge list of holds displayed on the "Holds to pull" and confirm that the display is now correct. One of the possible test plan has been let in a comment on the bug report: Bib Record A has 2 items: Item Record X (can be placed on hold) Item Record Y (cannot be placed on hold) If you place a bib-level hold on Bib Record A, both Item Record X and Item Record Y show up as available items in the Holds To Pull List. With this patch applied you must not see Y Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:47:34 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- Signing off as in a testing it appears to work as expected.. I'd love to see this query moved into a module and unit tested really, but this fix works for now in my opinion.. good luck QAers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:50:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:50:45 +0000 Subject: [Koha-bugs] [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:51:43 +0000 Subject: [Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:55:47 +0000 Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday returns no results if format incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #16 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:58:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:58:09 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #21 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:58:53 +0000 Subject: [Koha-bugs] [Bug 23018] Refunding a lost item fee may trigger error if any fee has been written off related to that item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23018 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90206|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 90640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90640&action=edit Bug 23018: Refunding a lost item fee may trigger error if any fee has been written off related to that item If a lost item fee is written off, it creates a writeoff with the same itemnumber but the amount column is a negative number. Now, when the lost item is returned, it calls _FixAccountForLostAndReturned which searchs for all accountlines with an account type of 'L' or 'W'. Then, if the *first* of those lines has an outstanding balance, a credit is created and *all* the lines found are passed to $credit->apply. The apply method then calls is_debit on each line and when it hits the writeoff, it throws an exception ( Koha::Exceptions::Account::IsNotDebit ). When this happens, the credit is creating but not applied the the outstanding lost item fee, and the librarian is presented with an error page. It seems like the solution is to only fetch the first result since it seems like that is the only one we should be operating on. Test Plan: 1) Create a lost item with a fee 2) Create a manual debit using the barcode of the item 3) Write off that manual debit 4) Check in the item, note the error 5) Apply this patch 6) Repeat steps 1-3 7) Check in the item, no error! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:59:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:59:54 +0000 Subject: [Koha-bugs] [Bug 22585] Fix remaining double-escaped CAS links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 09:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 07:59:47 +0000 Subject: [Koha-bugs] [Bug 23018] Refunding a lost item fee may trigger error if any fee has been written off related to that item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23018 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Signing off.. it's basically the same change I made in bug 22563 only more backport friendly. Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:03:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:03:28 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize --- Simple fix which works well for me, Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:03:07 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90584|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 90641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90641&action=edit Bug 17526: Change grep to deal with malformed sortfield Giving sortfield a malformed value when viewing lists results in Internal Server Error. eg. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=1&sortfield=title( Note the trailing ( Before Patch: kaboom apply patch restart After Patch: No kaboom Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:05:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:05:26 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:05:32 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:05:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:05:37 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:05:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:05:44 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:05:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:05:50 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:15:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:15:47 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:15:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:15:47 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22399 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:19:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:19:41 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7890 --- Comment #10 from Martin Renvoize --- One to bring back to life for this new cycle Owen? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 10:19:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 08:19:41 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 11:14:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 09:14:33 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88236|0 |1 is obsolete| | --- Comment #16 from Josef Moravec --- Created attachment 90642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90642&action=edit Bug 16284: Check only item for previous checkout if biblio is serial Test plan: 1) Set 'CheckPrevCheckout' system preference to 'Do' 2) Make a checkout with item from serial record (942$s is 1 on default settings) 3) Return that checkout 4) Try to check it out again, you should see an alert, that the patron has thi item checked out previously 5) Try to checkout another item from same bibliographic record, you sholud not see the alert and item should be checked out 6) prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 11:14:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 09:14:36 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88237|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 90643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90643&action=edit Bug 16284: Add test Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 11:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 09:14:39 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88258|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 90644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90644&action=edit Bug 16284: Add Koha::Biblio->is_serial method Test plan: prove t/db_dependent/Koha/Biblio.t should return green -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 11:14:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 09:14:42 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88259|0 |1 is obsolete| | --- Comment #19 from Josef Moravec --- Created attachment 90645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90645&action=edit Bug 16284: Use new method to determine serials in check previous checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 11:15:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 09:15:04 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Josef Moravec --- (In reply to Michal Denar from comment #15) > Josef, can You rebase this on master? > > Thank You. > Rebased, thanks for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:02:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:02:44 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #52 from Tom?s Cohen Arazi --- (In reply to Martin Renvoize from comment #47) > I do however note we're currently loading all class methods into the > database.. do we perhaps want to restrict them to 'public' methods only > (i.e. missing out _method methods) or even limit down to only 'supported' > methods known by the plugin system? (I'm not sure about the latter.. we > might want to allow a plugin to introspect itself for some reason in the > future... perhaps?) Addressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:02:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:02:59 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #53 from Tom?s Cohen Arazi --- (In reply to Martin Renvoize from comment #48) > New dependency introduced: 'Class::Inspector' but not added to our > dependencies lists yet.. can we get that as a QA followup here please (Seems > fine for it to be added to me as it appears to all be packaged for debian > already) Addressed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:07:35 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #11 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:24:01 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:24:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:24:05 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90642|0 |1 is obsolete| | Attachment #90643|0 |1 is obsolete| | Attachment #90644|0 |1 is obsolete| | Attachment #90645|0 |1 is obsolete| | --- Comment #21 from Michal Denar --- Created attachment 90646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90646&action=edit Bug 16284: Check only item for previous checkout if biblio is serial Test plan: 1) Set 'CheckPrevCheckout' system preference to 'Do' 2) Make a checkout with item from serial record (942$s is 1 on default settings) 3) Return that checkout 4) Try to check it out again, you should see an alert, that the patron has thi item checked out previously 5) Try to checkout another item from same bibliographic record, you sholud not see the alert and item should be checked out 6) prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:24:10 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 --- Comment #22 from Michal Denar --- Created attachment 90647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90647&action=edit Bug 16284: Add test Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:24:15 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 --- Comment #23 from Michal Denar --- Created attachment 90648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90648&action=edit Bug 16284: Add Koha::Biblio->is_serial method Test plan: prove t/db_dependent/Koha/Biblio.t should return green Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:24:19 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 --- Comment #24 from Michal Denar --- Created attachment 90649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90649&action=edit Bug 16284: Use new method to determine serials in check previous checkouts Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 12:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 10:49:53 +0000 Subject: [Koha-bugs] [Bug 23131] New: We cannot adjust profiles for CSV exports, for billing and delivery addresses Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23131 Bug ID: 23131 Summary: We cannot adjust profiles for CSV exports, for billing and delivery addresses Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: paul.thornton at educampus.ie QA Contact: testopia at bugs.koha-community.org Target Milestone: --- For basket exports you can use data from following tables: biblio, biblioitems, aqorders, aqbudgets and aqbasket. The delivery and billing codes are stored in aqbasket but the addresses are in the branches table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:08:52 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement modifies release notes| |the basic MARC editor so | |that required fields have | |the standard "Required" | |label on them instead of a | |small red asterisk. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:03 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:10 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:07 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:13 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:17 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:21 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:24 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:27 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:30 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:33 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:36 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:20:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:20:40 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:10 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #54 from Tom?s Cohen Arazi --- Created attachment 90650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90650&action=edit Bug 21073: Add new table, schema and classes Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:14 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #55 from Tom?s Cohen Arazi --- Created attachment 90651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90651&action=edit Bug 21073: Improve plugin performance Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. Test Plan: 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing plugins 5) Verify you can install new plugins Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:19 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #56 from Tom?s Cohen Arazi --- Created attachment 90652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90652&action=edit Bug 21073: Upgrade the kitchen sink plugin to get rid of warnings Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:23 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #57 from Tom?s Cohen Arazi --- Created attachment 90653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90653&action=edit Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:28 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #58 from Tom?s Cohen Arazi --- Created attachment 90654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90654&action=edit Bug 21073: (QA follow-up) Restore check on template Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:32 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #59 from Tom?s Cohen Arazi --- Created attachment 90655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90655&action=edit Bug 21073: (QA follow-up) Remove unused libraries Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:37 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #60 from Tom?s Cohen Arazi --- Created attachment 90656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90656&action=edit Bug 21073: Regression tests for GetPlugins Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:41 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #61 from Tom?s Cohen Arazi --- Created attachment 90657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90657&action=edit Bug 21073: Restore filtering by metadata This patch restores filtering the plugins by metadata. That got lost on rebase at some point. Regression tests are added on a prior patch. To test: - Have the 'regression tests for GetPlugins' patch applied - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:46 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #62 from Tom?s Cohen Arazi --- Created attachment 90658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90658&action=edit Bug 21073: (follow-up) QA fixes after rebase Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:50 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #63 from Tom?s Cohen Arazi --- Created attachment 90659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90659&action=edit Bug 21073: (follow-up) Add Class::Inspector to PerlDependencies Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:55 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #64 from Tom?s Cohen Arazi --- Created attachment 90660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90660&action=edit Bug 21073: (QA follow-up) Only public subs should be considered Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:21:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:21:59 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #65 from Tom?s Cohen Arazi --- Created attachment 90661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90661&action=edit Bug 21073: (QA follow-up) Add ->is_enabled and tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:22:04 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #66 from Tom?s Cohen Arazi --- Created attachment 90662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90662&action=edit Bug 21073: (QA follow-up) Simplify logic This patch simplifies the logic inside GetPlugins so: - It uses Koha::Plugins::Methods instead of plain SQL - It doesn't do more DB calls than needed, by filtering on method in the initial query to Koha::Plugins::Methods. It also relies on the (newly introduced) ->is_enabled method in Koha::Plugins::Base, for better readability. To test: - Run the tests and notice no behaviour changes are introduced. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:22:08 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #67 from Tom?s Cohen Arazi --- Created attachment 90663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90663&action=edit Bug 21073: (QA follow-up) Don't call -> twice! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:22:13 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #68 from Tom?s Cohen Arazi --- Created attachment 90664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90664&action=edit Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:25:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:25:51 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #69 from Tom?s Cohen Arazi --- I'm leaving it as NSO, I would like Kyle's review on the latest changes even if they are simple. Specially as a bug is fixed in 'Don't call ->$method twice!' and I might have missed something. Once someone else add the SO stamp on this I will switch it to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:32:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:32:48 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #70 from Tom?s Cohen Arazi --- (In reply to Martin Renvoize from comment #49) > Comment on attachment 89801 [details] [review] > Bug 21073: Improve plugin performance > > Review of attachment 89801 [details] [review]: > ----------------------------------------------------------------- > > A few, hopefully minor, bits of feedback.. Failing QA whilst I await a reply. > > ::: Koha/Plugins.pm > @@ +73,5 @@ > > my $method = $params->{method}; > > my $req_metadata = $params->{metadata} // {}; > > > > + my $dbh = C4::Context->dbh; > > + my $plugin_classes = $dbh->selectcol_arrayref('SELECT DISTINCT(plugin_class) FROM plugin_methods'); > > Why do we mix old dbh calls with dbic calls in this new code? Fixed! > Also, can we not skip a series of DB calls that are found in the loop by > filtering on $method if it exists before running through the loop? Fixed! > @@ +119,4 @@ > > > > my $plugin = $plugin_class->new({ enable_plugins => $self->{'enable_plugins'} }); > > > > + Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete(); > > Can't make my mind up as to whether we should really rebuilding the whole db > table with every/any install/upgrade of any plugin... I agree with this uncomfortable feeling,. I've added a note about why we do this in the POD. Hopefully once this is in master and we start using it, we realize there are simple ways to deal with faulty scenarios. I volunteer to work on it if we find out. > ::: Koha/Plugins/Handler.pm > @@ +63,5 @@ > > my $params = $args->{'params'}; > > > > + my $has_method = Koha::Plugins::Methods->search({ plugin_class => $plugin_class, plugin_method => $plugin_method })->count(); > > + if ( $has_method ) { > > + load $plugin_class; > > Is it ever possible for 'load' to fail here and if so should we catch and > warn about it?.. We seem to have effectively removed a warning from the > prior code.. I'm wondering if we may ever get a case where the plugin exists > in the DB but has been deleted from the filesystem. Before this patchset, we really queried the FS for plugins, and we could only find existing plugins! With this way of not doing so, we might have scenarios in which the DB contains references to (manually) deleted plugins. See above for discussion about this. I vote for this approach until things settle a bit. > @@ +68,2 @@ > > my $plugin = $plugin_class->new( { cgi => $cgi, enable_plugins => $args->{'enable_plugins'} } ); > > + my @return = $plugin->$plugin_method( $params ); > > The above line is never referenced right? It was a bug! ->$method was being called twice even! This is probably some rebasing problem. > ::: plugins/plugins-upload.pl > @@ +87,4 @@ > > $template->param( ERRORS => [ \%errors ] ); > > output_html_with_http_headers $input, $cookie, $template->output; > > exit; > > + } else { > > 'unless else' is a weird looking construct.. as we're calling 'exit' in the > unless block we can just call the 'Koha::Plugins->new()->InstallPlugins' > method below the block and not in it's own else block. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 13:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 11:58:26 +0000 Subject: [Koha-bugs] [Bug 23127] Using commas in shipping cost on invoices causes issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23127 --- Comment #2 from Nick Clemens --- The original report was issues copying in a US formatted number over 1000: 1,234 Testing seems to show it fails even when using FR formatting and entering as you suggested: 10,00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:01:52 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:03:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:03:25 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Attachment #90053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:03:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:03:36 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:06:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:06:05 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90341|0 |1 is obsolete| | --- Comment #8 from Alex Arnaud --- Created attachment 90665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90665&action=edit Bug 22924: Make elasticsearch honour FacetMaxCount system preference We have a line in QueryBuilder to respect the preference if a facet is expanded, it seems we forgot to pass the option to the querybuilder however To test: 1 - Enable Elasticsearch 2 - Set FacetMaxCount to 20 3 - Search in ES for '*' or something with a lot of results 4 - Expand some facets, note you get no more than 10 for any facet 5 - Apply patch 6 - Search again 7 - Expand facets, note they now go up to 20 8 - Try with various values of FacetMaxCount Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:06:18 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:06:58 +0000 Subject: [Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #16 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 19530 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:06:58 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #25 from Nick Clemens --- *** Bug 9322 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:06:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:06:59 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Bug 8292 depends on bug 9322, which changed state. Bug 9322 Summary: If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 14:14:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 12:14:06 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #14 from Nick Clemens --- 9322 resolved by 19530 This bug still appears valid, but patch no longer applies, marking as such -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 15:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 13:52:12 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 15:55:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 13:55:43 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 --- Comment #10 from M. Tompsett --- Created attachment 90666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90666&action=edit Bug 23104: (follow-up) fix display for 0/Unlimited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 15:55:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 13:55:40 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:01:51 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #72 from Martin Renvoize --- Created attachment 90667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90667&action=edit Bug 22563: (QA follow-up) Correction to DB update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:13:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:13:11 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:12:48 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 --- Comment #6 from Fridolin SOMERS --- I see that there is a removal of "mc-" before index to field convertion : Added by commit : Bug 12478: fix multi-choice stuff in advanced search In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm : my $mc = ''; if ($f =~ /^mc-/) { $mc = 'mc-'; $f =~ s/^mc-//; } And in %index_field_convert there is : 'mc-loc' => 'location' So I think adding loc => location should fix the problem. That is why there is no problem with mc-ccode and mc-itemtype. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:16:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:16:09 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #71 from Martin Renvoize --- Thanks Tomas, this is looking really good now.. Hopefully Kyle will have a chance to take a quick peek and give us that second SO to go for PQA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:16:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:16:43 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82031|0 |1 is obsolete| | Attachment #87711|0 |1 is obsolete| | Attachment #87771|0 |1 is obsolete| | Attachment #88205|0 |1 is obsolete| | Attachment #88206|0 |1 is obsolete| | Attachment #89961|0 |1 is obsolete| | --- Comment #158 from David Gustafsson --- Created attachment 90668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90668&action=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:17:18 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #159 from David Gustafsson --- Created attachment 90669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90669&action=edit Bug 14957: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:18:29 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:18:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:18:33 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 --- Comment #7 from Fridolin SOMERS --- Created attachment 90670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90670&action=edit Bug 22426: (alternate) Elasticsearch fix location limit in advanced search A search made on Shelving location tab in advanced search gives 0 result. Test plan : Without patch: - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc) - 0 result - check that location exist by doing a simple search and filtering on the location facet - have some results With patch: - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc) - found results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:19:55 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 --- Comment #8 from Fridolin SOMERS --- Here is my alternate patch. Don't hesitate to discuss it. Kind regards ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:22:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:22:25 +0000 Subject: [Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14419 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:22:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:22:25 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22903 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:23:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:23:43 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Is this the same as Bug 22903 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:25:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:25:03 +0000 Subject: [Koha-bugs] [Bug 23132] New: Encoding issues in facets with show more link Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Bug ID: 23132 Summary: Encoding issues in facets with show more link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When one uses characters like ?, ?, ? ... the first search show up correctly but when you refine your search with "Show more", the encoding becomes bad and so, results of the search too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:25:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:25:12 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:25:19 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:25:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:25:52 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22903 --- Comment #1 from Fridolin SOMERS --- A quick fix of Bug 22903 problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:25:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:25:52 +0000 Subject: [Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23132 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:26:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:26:34 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:26:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:26:34 +0000 Subject: [Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 [Bug 23132] Encoding issues in facets with show more link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:27:27 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 --- Comment #2 from Fridolin SOMERS --- Same fix as commit : Bug 21526: Fix search result pages (url vs uri vs raw) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:27:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:27:34 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90669|0 |1 is obsolete| | --- Comment #160 from David Gustafsson --- Created attachment 90671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90671&action=edit Bug 14957: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:27:42 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90668|0 |1 is obsolete| | --- Comment #161 from David Gustafsson --- Created attachment 90672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90672&action=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:31:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:31:09 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:31:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:31:11 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 --- Comment #3 from Fridolin SOMERS --- Created attachment 90673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90673&action=edit Bug 23132: Fix encoding issues in facets with show more link When one uses characters like ?, ? ... the first searcshow up correctly but when you refine your search with "Show more", the encoding becomes bad and so, results of the search too. Test plan : Without the patch: - check if you have your SysPref SearchEngine with Elasticsearch as value, - put your SysPref FacetMaxCount at 10, - search in the catalog "a" and then in Refine your search click on show more (just to see how it works), - then search with special characters like "?", ?" ... and make the same test, the research should be wrong when you click on show more and the page is realoaded. Then apply the patch: - and make the same with a classic reasearch, then with special characters, - verify that when you click on show more the page isn't realoded and the reasearch is correct. - same with show less - and finnaly, add some facets and test show more/less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:33:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:33:42 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #162 from David Gustafsson --- Fixed most of the issues, rebased and squashed into one commit as things were getting a little bit messy. There are still some things that might need fixing for example I'm not sure if the marc rule presets are translatable as they are defined as js-data. I haven't used the translation tools myself but will try to figure this out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:36:45 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #163 from David Gustafsson --- Also did a pod change in C4/Biblio.pm without the output so need also to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:38:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:38:04 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #17 from Tom?s Cohen Arazi --- Comment on attachment 90611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90611 Bug 9834: Add DB changes >+ `item_level_hold` BOOLEAN NOT NULL DEFAULT 0, -- Is the hpld placed at item level Please see https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans This is missing a tweak to hold.json and to the schema files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 16:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 14:42:52 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Software error: Template process failed: file error - parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt line 284: unexpected token (BLOCK) [% SET location = BLOCK %] at /home/vagrant/kohaclone/C4/Templates.pm line 122. Same kind of explosion with plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:00:06 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:00:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:00:08 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 --- Comment #4 from M. Tompsett --- Created attachment 90674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90674&action=edit Bug 22783: (follow up) not SET for anonymous BLOCK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:03:46 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88923|0 |1 is obsolete| | Attachment #90674|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 90675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90675&action=edit Bug 22783: Make 'OPAC News' string translatable The idea was to use an anonymous block Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:03:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:03:48 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 --- Comment #6 from M. Tompsett --- Created attachment 90676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90676&action=edit Bug 22783: (follow up) not SET for anonymous BLOCK Fixed syntax. http://www.template-toolkit.org/docs/manual/Directives.html#section_BLOCK Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:06:39 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 --- Comment #7 from M. Tompsett --- Test plan is to navigate in the staff client to the News Home -> Tools -> News And have at least one item that is in the OPAC News, not NavRight, position. Before and after should be the same, if no translation is done. If translation is done, Opac News can be translated after the patch is applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:17:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:17:13 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 90677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90677&action=edit Bug 9834: (QA follow-up) API fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:17:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:17:44 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick at bywatersolutions.com Keywords| |additional_work_needed CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:18:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:18:45 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:18:48 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90278|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90678&action=edit Bug 23038: Hide expected warnings from tests When tests are ran, there are 2 warnings that are expected and raised by DBI. As they are expected they must be correctly caught and not displayed. We could have reconnect with PrintError turned off, but then reconnect with it on. Test plan: % prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Suggestions.t Must not display DBI warnings Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:22:23 +0000 Subject: [Koha-bugs] [Bug 23133] New: Rename reserves.item_level_hold for reserves.item_level Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Bug ID: 23133 Summary: Rename reserves.item_level_hold for reserves.item_level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Opinionated report, but I think new column names should match our latest practices. i.e. don't make it read: if ( $hold->item_level_hold ) { ... but if ( $hold->item_level ) { ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:22:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:22:32 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:22:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:22:32 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 [Bug 23133] Rename reserves.item_level_hold for reserves.item_level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:34:32 +0000 Subject: [Koha-bugs] [Bug 23134] New: Having an "internal notes" field which would be available throughout the suggestion process Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23134 Bug ID: 23134 Summary: Having an "internal notes" field which would be available throughout the suggestion process Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: paul.thornton at educampus.ie QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When editing a Purchase Suggestion there is no field to allow staff communicate or add internal notes for other staff. Due to the workflow relating to Purchase Suggestions a suggestion is often passed to another member of staff for approval. Having an "internal notes" field which would be available throughout the suggestion process, would help to facilitate this communication. Staff are currently relying on coded text to communicate using the Notes field e.g. "Lot 1.1 1 X NCM-ML; 1 X NCSL-SL". They also set the reason in the drop-down menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:37:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:37:52 +0000 Subject: [Koha-bugs] [Bug 23135] New: Order should pull additional data from Purchase Suggestion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23135 Bug ID: 23135 Summary: Order should pull additional data from Purchase Suggestion Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: paul.thornton at educampus.ie QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Neither the note field in the bibliographic information section of the purchase suggestion nor the quantity (number of copies requested) are pulled into the order form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:40:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:40:17 +0000 Subject: [Koha-bugs] [Bug 23136] New: The Filter Suggestions option to Search by Requester worked across all the tabs simultaneously Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23136 Bug ID: 23136 Summary: The Filter Suggestions option to Search by Requester worked across all the tabs simultaneously Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: paul.thornton at educampus.ie QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When viewing Purchase Suggestions, it would be useful if the Filter Suggestions option to Search by Requester worked across all the tabs simultaneously (Accepted; Pending etc). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:49:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:49:46 +0000 Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 --- Comment #4 from M. Tompsett --- Comment on attachment 75836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75836 0001-Restart-memcached-after-koha-remove-if-needed.patch Review of attachment 75836: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20884&attachment=75836) ----------------------------------------------------------------- ::: debian/scripts/koha-remove @@ +139,5 @@ > done > > +if [ -e /etc/koha/koha-sites.conf ] > +then > + . /etc/koha/koha-sites.conf What is the purpose of this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:50:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:50:04 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 90680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90680&action=edit Bug 23133: Rename uses of item_level_hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:50:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:50:08 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 90681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90681&action=edit Bug 23133: API cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:50:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:50:01 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 90679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90679&action=edit Bug 23133: DB update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:51:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:51:37 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #4 from Tom?s Cohen Arazi --- Ok, my two cents. I included the schema updates, let me know if you need it separate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:52:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:52:58 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #17 from Martin Renvoize --- Oops, this one slipped passed. I'm going to revert as I don't think the solution here is tangible unfortunately. The Mana server itself may return codes that are still meaningful even if they're not 200.. i.e. 201 has a meaning of it's own and as we're short-circuiting anything that's not 200 in this patch we'll be dropping OK responses of kinds. I have a plan and will post an alternative shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:54:35 +0000 Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 --- Comment #5 from Jerome Charaoui --- The purpose is to load the USE_MEMCACHED variable into the environment from koha-sites.conf. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:54:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:54:57 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:55:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:55:01 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:56:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:56:22 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23075 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 [Bug 23075] Incorrect URL should have a meaningful error message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 17:56:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 15:56:22 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Depends on| |22913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 18:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 16:03:02 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #8 from Martin Renvoize --- I've been won around.. though in many ways I wish we had the URL's the other way around.. Right now it's very hard to discover that mana-ui exists from an end user perspective. I would have liked, for example: mana-kb.koha-community.org api.mana-kb.koha-community.org That way the more cryptic, aimed at machines, portal is on the more cryptic URL vs the user facing one being the more user friendly URL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 18:08:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 16:08:57 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 18:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 16:10:35 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #38 from M. Tompsett --- Comment on attachment 88201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88201 Bug 20116: Flush the caches Review of attachment 88201: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20116&attachment=88201) ----------------------------------------------------------------- ::: debian/scripts/koha-translate @@ +233,5 @@ > > +flush_cache() > +{ > + if [ "$dev" = "" ]; then > + koha-foreach --enabled "$KOHA_HOME/misc/bin/clear_cache.pl" Is $KOHA_HOME/misc/bin going to exist? And is clear_cache.pl going to get put there? Something is fishy for running this live. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 18:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 16:11:53 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Signed Off |Failed QA --- Comment #39 from M. Tompsett --- In addition to the whole $KOHA_HOME path existing in live problem, perhaps the flushing could be split to a separate patch, so that bug 20884 could depend on that, and not this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:26:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:26:50 +0000 Subject: [Koha-bugs] [Bug 23137] New: Elasticsearch - should have command line tool to reset mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23137 Bug ID: 23137 Summary: Elasticsearch - should have command line tool to reset mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Target Milestone: --- It would be useful to have this option from the command line Possibly as part of koha-elasticsearch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:27:46 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #18 from Martin Renvoize --- Created attachment 90682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90682&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:28:35 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:29:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:29:30 +0000 Subject: [Koha-bugs] [Bug 23138] New: Elasticsearch - koha-elasticsearch rebuidl should support -d and other parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23138 Bug ID: 23138 Summary: Elasticsearch - koha-elasticsearch rebuidl should support -d and other parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Target Milestone: --- The helper script should accept all options the script takes directly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:30:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:30:44 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #19 from Martin Renvoize --- I've submitted an alternative resolution to this bug above. This alternative checks for a known response for a mana server to identify if the URL appears to be correct. It relies on bug 22913 at the mana-kb serverside to match this known state.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:30:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:30:52 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:38:30 +0000 Subject: [Koha-bugs] [Bug 23139] New: Koha::SharedContent->get_sharing_url is not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Bug ID: 23139 Summary: Koha::SharedContent->get_sharing_url is not used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com Target Milestone: --- The `get_sharing_url` method in Koha::SharedContent is currently only used in the unit tests. We should either convert code to use this routine or remove it. Personally, I think it could perhaps serve a similar use to shib_ok in C4::Auth_with_shibboleth in that we could add a cached config check (which would hit the Mana server to test it's actually there) and then return undef for failure or pass through the mana base url otherwise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:47:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:47:03 +0000 Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20116 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:47:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:47:03 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20884 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:51:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:51:14 +0000 Subject: [Koha-bugs] [Bug 23139] Koha::SharedContent->get_sharing_url is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23075 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:51:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:51:14 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23139 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:58:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:58:46 +0000 Subject: [Koha-bugs] [Bug 23140] New: Typo in returns.tt prevents printing branchcode in transfer slips Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Bug ID: 23140 Summary: Typo in returns.tt prevents printing branchcode in transfer slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- data-url="transfer-slip.pl?transferitem=ITEMNUMBER&&branchcodeCODE&op=slip" should be: data-url="transfer-slip.pl?transferitem=ITEMNUMBER&&branchcode=CODE&op=slip" Note the missing '=' after branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:59:28 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:59:31 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89362|0 |1 is obsolete| | Attachment #89363|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90683&action=edit Bug 22571: Add tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:59:33 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 --- Comment #4 from M. Tompsett --- Created attachment 90684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90684&action=edit Bug 22571: Handle control fields in MMT for conditionals Control fields are not handled correctly by Koha::SimpleMARC when comparaison (with or without regex) is done. Which means we did not support something like: Do something if control field 008 equals or matches "a string" Test plan: Create a new MARC modification template and a new action, like: Add new field 100$a with value "foo bar" if 008 (or any other control fields) matches (or equals) a regex Then use the record mofication tool and confirm that the new field is create if the regex matches 008 of the bib record Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 19:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 17:59:36 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 --- Comment #5 from M. Tompsett --- Created attachment 90685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90685&action=edit Bug 22571: (follow up) fix Donald cut-&-paste error Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 20:02:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 18:02:09 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 --- Comment #1 from Nick Clemens --- Created attachment 90686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90686&action=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 20:02:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 18:02:25 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 20:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 18:02:06 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 20:12:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 18:12:23 +0000 Subject: [Koha-bugs] [Bug 23141] New: The Debian scripts do not use the myql portnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Bug ID: 23141 Summary: The Debian scripts do not use the myql portnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: andreas.jonsson at kreablo.se QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Target Milestone: --- The scripts koha-mysql, koha-mysqldump, and koha-create and possibly others do not use the configured mysql portnumber configured in koha-conf.xml. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 20:46:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 18:46:43 +0000 Subject: [Koha-bugs] [Bug 23142] New: Hold History for Patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23142 Bug ID: 23142 Summary: Hold History for Patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: christofer.zorn at ajaxlibrary.ca QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Hello! Would it be possible to add a feature to the public facing catalogue that allowed the patrons to see their hold history? We've had a number of patrons ask for this functionality. I see it being an additional tab that appears and shows what they had on hold. Thanks Christofer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 20:59:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 18:59:37 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #1 from Andreas Jonsson --- Created attachment 90687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90687&action=edit Bug 23141: Add port number to koha-dump script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:00:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:00:20 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #3 from Andreas Jonsson --- Created attachment 90688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90688&action=edit Bug 23141: Add support for configuring database port in koha-dump, koha-mysql and koha-mysqlcheck -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:00:04 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #2 from Andreas Jonsson --- Testplan for devbox: * Change port of mariadb by adding the file /etc/mysql/conf.d/port.cnf with contents: [mysqld] port = 12345 * systemctl restart mariadb * edit /etc/koha/sites/kohadev/koha-conf.xml and change the elments hostname and port: 127.0.0.1 12345 * Test the scripts: sudo ~/kohaclone/debian/scripts/koha-mysql kohadev sudo ~/kohaclone/debian/scripts/koha-mysqlcheck kohadev sudo ~/kohaclone/debian/scripts/koha-dump kohadev * Test populate db: sudo /usr/sbin/koha-create --request-db test sudo mysqldump --defaults-file=/etc/mysql/koha-common.cnf koha_kohadev >/tmp/kohadev.sql mysqluser="$( sudo xmlstarlet sel -t -v 'yazgfs/config/user' /etc/koha/sites/test/koha-conf.xml )" mysqlpass="$( sudo xmlstarlet sel -t -v 'yazgfs/config/pass' /etc/koha/sites/test/koha-conf.xml )" sudo mysql --defaults-file=/etc/mysql/koha-common.cnf -e "CREATE DATABASE koha_test; GRANT ALL ON koha_test.* TO '$mysqluser'@'localhost' IDENTIFIED BY '$mysqlpass'" sudo ~/kohaclone/debian/scripts/koha-create --populate-db --defaultsql /tmp/kohadev.sql test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:00:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:00:51 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #4 from Andreas Jonsson --- Created attachment 90689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90689&action=edit Bug 23141: Add mysql portnumber support when populating db -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:02:06 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:16:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:16:11 +0000 Subject: [Koha-bugs] [Bug 23143] New: filter paid transactions not working Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 Bug ID: 23143 Summary: filter paid transactions not working Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: bdaeuber at cityoffargo.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Same issue as bug 22626 but on 18.11.06 The Filter paid transactions function on /cgi-bin/koha/members/boraccount.pl under the Account tab no longer works. If you click on it the wording will change, but no transactions will disappear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:20:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:20:35 +0000 Subject: [Koha-bugs] [Bug 23144] New: Bad POD breaks svc/barcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 Bug ID: 23144 Summary: Bad POD breaks svc/barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- A certain RM apparently tried to fix a QA pod complaint when pushing bug 20676 to master. This seems to have had the effect of breaking this script all together -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:25:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:25:17 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:25:19 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 --- Comment #1 from Nick Clemens --- Created attachment 90690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90690&action=edit Bug 23144: Replace missing =cut in svc/header -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:26:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:26:39 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20676 CC| |mtompset at hotmail.com, | |oleonard at myacpl.org Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 [Bug 20676] svc/barcode should allow barcode to be printed without text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:26:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:26:39 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 [Bug 23144] Bad POD breaks svc/barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 21:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 19:50:59 +0000 Subject: [Koha-bugs] [Bug 21917] Payment type should not show on Write off selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21917 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- On the pat_paycollect page there are options to pay a fine, write off a fine, pay an individiual fine, or write off an individual fine. Clicking a button brings up the corresponding form, with the following ID's and names: Pay selected fine: id="payfine" name="payfine" Write off selected fine: id="payfine" name="payfine" Pay Individual fine: id="payindivfine" name="payindivfine" Write off individual fine: id="woindivfine" name="woindivfine" Write off selected doesnt not have its own unique id and name. This makes it difficult to devise JavaScript that works on one but not the other. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:03:34 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:14:56 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:15:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:15:04 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90536|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 90692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90692&action=edit Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, again Not kidding, it's again, and will certainly appear more. The problem is that we should have a NULL value in DB to make things more readable and logical. Now we need a quick fix. Test plan: Set "Current checkouts allowed" to unlimited (empty string) Try to check an item out => Without this patch we are blocked with a "too many" message => With this patch applied the correct behavior is back! Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:14:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:14:59 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90535|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 90691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90691&action=edit Bug 23104: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:15:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:15:08 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90581|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 90693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90693&action=edit Bug 23104: Add tests for maxonsiteissueqty Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:15:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:15:12 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90666|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 90694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90694&action=edit Bug 23104: (follow-up) fix display for 0/Unlimited Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:22:41 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90641|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 90695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90695&action=edit Bug 17526: Change grep to deal with malformed sortfield Giving sortfield a malformed value when viewing lists results in Internal Server Error. eg. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=1&sortfield=title( Note the trailing ( Before Patch: kaboom apply patch restart After Patch: No kaboom Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:22:36 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:30:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:30:26 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:30:29 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90675|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 90696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90696&action=edit Bug 22783: Make 'OPAC News' string translatable The idea was to use an anonymous block Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:30:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:30:33 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90676|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 90697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90697&action=edit Bug 22783: (follow up) not SET for anonymous BLOCK Fixed syntax. http://www.template-toolkit.org/docs/manual/Directives.html#section_BLOCK Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:33:46 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:33:49 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90634|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 90698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90698&action=edit Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:39:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:39:13 +0000 Subject: [Koha-bugs] [Bug 23100] Notify user if leaving modified patron edit form without saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I've tried it in Firefox and Chrome, while both times I am asked for confirmation before leaving the page, it always shows the default message from the browser instead of the custom one. Josef, can you have a look? I might also change it to: You have modified this patron record, ... or You have made a change to this patron record... or similar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:39:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:39:19 +0000 Subject: [Koha-bugs] [Bug 23100] Notify user if leaving modified patron edit form without saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:41:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:41:28 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:41:31 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90476|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 90699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90699&action=edit Bug 22851: Style navigation links in serials modules like same links in other modules This patch makes minor markup changes to the serials sidebar menu include so that links are displayed in a style consistent with similar menus in other areas of the staff client. This patch contains whitespace changes, so please use the "-w" flag when viewing the diff. To test, apply the patch and go to the Serials module. The links in the sidebar menu should be displayed in the same style as the corresponding menu on the Acquisitions home page. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:41:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:41:47 +0000 Subject: [Koha-bugs] [Bug 22851] Style navigation links in serials modules like same links in other modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 --- Comment #5 from Katrin Fischer --- I wonder how this one managed to escape for so long! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:46:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:46:45 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:46:48 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90513|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 90700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90700&action=edit Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:46:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:46:52 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90514|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 90701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90701&action=edit Bug 5287: (QA follow-up) update deprecated button Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:52:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:52:15 +0000 Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 --- Comment #2 from Katrin Fischer --- (In reply to Owen Leonard from comment #1) > Would it make sense to have the actions menu include the same options the > basket view toolbar has? > > - Add to basket > - Edit basket > - Delete basket > - Close basket > - Export as CSV > - Create EDIFACT order > - E-mail order I think the more urgent issue here is to make the 'add to basket' more prominent again. But I see no reason not to include them, other than the list might get a little full :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:55:33 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #4 from Katrin Fischer --- Created attachment 90702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90702&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:56:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:56:07 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Katrin Fischer --- Hi Hayley, thx for testing so well! It appears it was fixed in staff, but I forgot to remove it in OPAC. Could you have another look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 22:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 20:56:45 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:16:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:16:53 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 --- Comment #4 from Katrin Fischer --- Created attachment 90703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90703&action=edit Bug 22653: Remove unimplemented RotationPreventTransfers system preference This removes the RotationPreventTransfers system preference from updated and new installations. To test: - Verify you have the RotationPreventTransfers pref - Apply patch and run database update - Verify the preference no longer exists in your system - in the sys pref editor - in your database: SELECT * from systempreferences WHERE variable = "RotationPreventTransfers"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:16:50 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:18:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:18:05 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #6 from Katrin Fischer --- Updating severity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:20:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:20:09 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |katrin.fischer at bsz-bw.de Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:24:28 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:24:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:24:53 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 --- Comment #3 from Katrin Fischer --- Hi Lisette and Benjamin, I've changed the message, hope that works for you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:24:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:24:31 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 --- Comment #2 from Katrin Fischer --- Created attachment 90704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90704&action=edit Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:33:33 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:33:56 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:33:33 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18403 CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:39:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:39:31 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 --- Comment #1 from Katrin Fischer --- Created attachment 90705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90705&action=edit Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:39:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:39:27 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:42:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:42:17 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com --- Comment #3 from Katrin Fischer --- I've added adding and deleting restrictions from a patron account in staff in 18.11 and it worked ok, no internal server error. Not sure I tested the right thing, can someone help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:52:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:52:45 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:52:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:52:48 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #1 from Katrin Fischer --- Created attachment 90706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90706&action=edit Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:53:24 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|18.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:56:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:56:01 +0000 Subject: [Koha-bugs] [Bug 23063] Add item does not respect CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- You are right, but it's the same for all price/monetary amounts. Koha currently only works with decimal . Something we need to find a global fix for - changing to enh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:58:49 +0000 Subject: [Koha-bugs] [Bug 23142] Hold History for Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23142 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Lisette Scheer --- *** This bug has been marked as a duplicate of bug 20936 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:58:49 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #1 from Lisette Scheer --- *** Bug 23142 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 17 23:59:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 21:59:07 +0000 Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin sends entries with wrong branchcode without error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Katrin Fischer --- This is fixed with current versions of Koha and the KOCT Firefox plugin. Once the URL and login are tested, there is now a nice pull down with the available branches from the connected installation. Thx Matts! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 00:06:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 22:06:01 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90635|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 90707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90707&action=edit Bug 23130: Fix alternative mana server URL in etc/koha-conf.xml If the alternative mana KB server URL in etc/koha-conf.xml is used it causes an error message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\nhttp://mana-test.koha-community.org to /etc/koha/sites//koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\n -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 00:06:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 22:06:31 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer --- It appears that http: now forwards to https:, but it's still nice to have this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 00:10:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 22:10:02 +0000 Subject: [Koha-bugs] [Bug 23143] filter paid transactions not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can't confirm this - I just tested in our 18.11.06 installation and the filtering works nicely. Payments and paid fines are filtered in my testing. Do you run some custom jQuery maybe that could interfere here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 00:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 22:10:44 +0000 Subject: [Koha-bugs] [Bug 23143] filter paid transactions not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > I can't confirm this - I just tested in our 18.11.06 installation and the > filtering works nicely. Payments and paid fines are filtered in my testing. > > Do you run some custom jQuery maybe that could interfere here? I was testing in the wrong installation - it IS broken in 18.11.06. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 01:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jun 2019 23:59:03 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- Created attachment 90708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90708&action=edit Really Spare Patron Import. This is a scary example of what patron import let's you import. I suspect if you had userid set and empty card number and used userid as the match, it would import too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:00:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:00:29 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from M. Tompsett --- I got away with cardnumber, branch code, and category code. If we are correcting the text to match what it does, then the text is still wrong. If we are fixing the import and matching the text, then that's still broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:07:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:07:08 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:07:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:07:11 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90690|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90709&action=edit Bug 23144: Replace missing =cut in svc/header Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:09:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:09:19 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 --- Comment #3 from M. Tompsett --- Similar to something I tinkered with, because of Owen. http://paste.koha-community.org/2708 Perhaps the 403 is another bug? Perhaps the 404 is at least a good idea for a section, but probably not 404? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:13:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:13:44 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #5 from M. Tompsett --- Comment on attachment 90689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90689 Bug 23141: Add mysql portnumber support when populating db Review of attachment 90689: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23141&attachment=90689) ----------------------------------------------------------------- ::: debian/scripts/koha-create @@ +118,4 @@ > } > > getmysqlhost() { > + if [ ! -f /etc/mysql/koha-common.cnf ] No. Because koha-common.cnf was (at least last time I checked) a soft link to debian.cnf -- which triggers noise when accessing a broken link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:26:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:26:02 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #6 from M. Tompsett --- Comment on attachment 90689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90689 Bug 23141: Add mysql portnumber support when populating db Review of attachment 90689: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23141&attachment=90689) ----------------------------------------------------------------- ::: debian/scripts/koha-create @@ +694,4 @@ > # something. > mysqluser=$(getinstancemysqluser $name) > mysqldb=$(getinstancemysqldatabase $name) > + mysqlhost=$(getinstancemysqlhost $name) No. Because the logic for determining the mysqlhost is at the top of the script (542-576 approx). Command line over rides password file over rides the "host" listed in the mysql [client] section. Now, perhaps in the case of populate, we should insert an override based on the koha-conf.xml file, but it doesn't belong here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:27:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:27:07 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- Marking Failed QA, because of comment #6 (without a doubt) and possibly comment #5. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:40:19 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23140 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:40:19 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23120 CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Found that I didn't get an internal error with this applied. So, I just made this see also bug 23120. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:41:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:41:08 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:41:10 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90686|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90710&action=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:42:42 +0000 Subject: [Koha-bugs] [Bug 22977] OMNIBUS: Ensure hidden fields are correctly passed during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22977 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Depends on| |23140 --- Comment #2 from M. Tompsett --- Updated to include bug 23140 in the depends. Though, I think 23120 and 23140 kind of overlap in solving something. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:42:42 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22977 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22977 [Bug 22977] OMNIBUS: Ensure hidden fields are correctly passed during circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:56:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:56:35 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- It is quite annoying to not be able to get to circulation home. You need circulate_remaining_permissions to get to the circulation home. However, I was able to cut-and-paste the checkout notes URL and confirm this patch does get the person into the page. So for that specific problem it does work. As such, I'm going to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:57:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:57:26 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:57:29 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90589|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 90711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90711&action=edit Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. This is just a typo in perl script : circulation instead of circulate Test plan : 1) Set preference "AllowCheckoutNotes" to "Allow" 2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes" 3) Loggin with this user 4) Go to "Circulation" home page 5) Click on "Checkout notes" 6) You should be allowed to access Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 02:58:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 00:58:45 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 --- Comment #5 from M. Tompsett --- Comment on attachment 90711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90711 Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage Review of attachment 90711: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22617&attachment=90711) ----------------------------------------------------------------- ::: circ/checkout-notes.pl @@ +33,4 @@ > query => $query, > type => "intranet", > authnotrequired => 0, > + flagsrequired => { circulate => "manage_checkout_notes" }, Nice catch on this typo, as: $ git grep "circulation =" gives nothing, but $ git grep "circulate =" shows that this is what it should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 03:08:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 01:08:27 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 --- Comment #7 from Jonathan Druart --- Created attachment 90712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90712&action=edit Bug 15814: Add missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 03:08:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 01:08:23 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 04:34:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 02:34:05 +0000 Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349 --- Comment #4 from M. Tompsett --- Created attachment 90713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90713&action=edit Bug 16349: Scrape currently supported versions Before patch: Koha -> About -> Server Information - Only the currently running version After patch: - Currently supported versions are listed Are you sure you just want it on the web page and not in Koha itself? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 06:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 04:33:46 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Signed Off |Patch doesn't apply --- Comment #204 from Hayley Mapley --- Patch doesn't apply: Applying: Bug 11529: Add new fields to biblio table Applying: Bug 11529: Use new biblio fields whenever possible Applying: Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl Applying: Bug 11529: Clean up subtitle usage error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 11529: Clean up subtitle usage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 08:06:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 06:06:54 +0000 Subject: [Koha-bugs] [Bug 23143] Filter paid transactions not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|filter paid transactions |Filter paid transactions |not working |not working -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 08:16:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 06:16:04 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 --- Comment #8 from Andreas Jonsson --- (In reply to M. Tompsett from comment #5) > Comment on attachment 90689 [details] [review] > Bug 23141: Add mysql portnumber support when populating db > > Review of attachment 90689 [details] [review]: > ----------------------------------------------------------------- > > ::: debian/scripts/koha-create > @@ +118,4 @@ > > } > > > > getmysqlhost() { > > + if [ ! -f /etc/mysql/koha-common.cnf ] > > No. Because koha-common.cnf was (at least last time I checked) a soft link > to debian.cnf -- which triggers noise when accessing a broken link. Sorry! This change was not supposed to be included. But I have to point out that it does not make sense to check for the existance of /etc/mysql/debian.cnf and then proceed to use /etc/mysql/koha-common.cnf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 08:16:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 06:16:43 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 08:16:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 06:16:45 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 --- Comment #2 from Katrin Fischer --- Created attachment 90714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90714&action=edit Bug 23126: Display multi-line entries in subscrpitions correctly There are several notes and other fields in a subscription that can be entered as multi-line input with breaks. We should display them as they were entered with keeping the line breaks intact. To test: - Add a subscription - Add comments including line breaks in internal and OPAC note - Check the manual history checkbox - Go to the subscription detail page, tab 'Planning' - Use the 'Edit history' link to edit the history - Enter content with line breaks in all the input fields where it's possible - Go to the OPAC detail page for your subscription record - Go to tab 'Subscriptions' > More details > Brief history - Verify the line breaks show there as
    - Apply patch - Relaod page, verify all information displays correctly now - Go back to the detail page, subscription tab - verify same there - Go back to the subscription detail page in staff - Check editing the history works as expected - Verify information on all tabs displays correctly - Receive a serial issue - verify note on top displays right - Go to the serial collection page of the subscription - same there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 08:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 06:19:55 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 --- Comment #3 from Katrin Fischer --- This turned out to be a little bit bigger than a missing filter. GetSubscriptionsFromBiblionumber actually turned the \n to
    , which we should never do but leave to the templates. I removed the 3 lines doing that and have fixed every place in the templates where I found the variables displayed with TT filter html_line_breaks. I have not submitted tests, because it seemed a little silly to test if the data does not contain
    ? Existing tests in t/db_dependent/Serials.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 08:20:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 06:20:49 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 09:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 07:37:33 +0000 Subject: [Koha-bugs] [Bug 22626] 'Filter paid transactions' broken on Transactions tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23143 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 [Bug 23143] [18.11] Filter paid transactions not working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 09:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 07:37:33 +0000 Subject: [Koha-bugs] [Bug 23143] [18.11] Filter paid transactions not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22626 Summary|Filter paid transactions |[18.11] Filter paid |not working |transactions not working Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 [Bug 22626] 'Filter paid transactions' broken on Transactions tab in staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 10:06:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 08:06:38 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #9 from Paul Poulain --- (In reply to Martin Renvoize from comment #8) > I've been won around.. though in many ways I wish we had the URL's the other > way around.. > > Right now it's very hard to discover that mana-ui exists from an end user > perspective. The end-user has no reason to know (and use) mana-ui: it's only for admin purposes, you have access to nothing unless you're logged-in (and have admin permissions). ui let you parse mana DB, delete invalid shared infos, check users, ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 10:24:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 08:24:09 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90063|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 90715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90715&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Signed-off-by: Niamh Walker-Headon Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 10:24:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 08:24:16 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90065|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes --- Created attachment 90717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90717&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Signed-off-by: Niamh Walker-Headon Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 10:24:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 08:24:13 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90064|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes --- Created attachment 90716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90716&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Signed-off-by: Niamh Walker-Headon Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 10:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 08:24:19 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90066|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes --- Created attachment 90718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90718&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Signed-off-by: Niamh Walker-Headon Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 10:24:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 08:24:22 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90067|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes --- Created attachment 90719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90719&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Signed-off-by: Niamh Walker-Headon Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:38 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 --- Comment #15 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:41 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:42 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:44 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:46 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:47 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:49 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 --- Comment #15 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:51 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:36 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:07:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:07:53 +0000 Subject: [Koha-bugs] [Bug 23120] Internal server error when checking in item to transfer and printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23120 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:50:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:50:23 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |martin.renvoize at ptfs-europe | |.com Assignee|martin.renvoize at ptfs-europe |katrin.fischer at bsz-bw.de |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:50:38 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 --- Comment #5 from Martin Renvoize --- Thanks for grabbing this one Katrin :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 11:58:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 09:58:36 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:20:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:20:37 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:29:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:29:31 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90703|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 90720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90720&action=edit Bug 22653: Remove unimplemented RotationPreventTransfers system preference This removes the RotationPreventTransfers system preference from updated and new installations. To test: - Verify you have the RotationPreventTransfers pref - Apply patch and run database update - Verify the preference no longer exists in your system - in the sys pref editor - in your database: SELECT * from systempreferences WHERE variable = "RotationPreventTransfers"; Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:30:19 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Going straight to QA for this one.. nice clean patch.. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:30:24 +0000 Subject: [Koha-bugs] [Bug 22653] Preference RotationPreventTransfers is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22653 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:35:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:35:21 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:40:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:40:18 +0000 Subject: [Koha-bugs] [Bug 23116] AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:45:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:45:18 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:45:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:45:05 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 --- Comment #12 from Nick Clemens --- Created attachment 90721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90721&action=edit Really realy spare patron import Remove surname from the file and it fails on missing a critical column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:49:04 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 --- Comment #4 from Nick Clemens --- (In reply to M. Tompsett from comment #3) > Similar to something I tinkered with, because of Owen. > http://paste.koha-community.org/2708 > Perhaps the 403 is another bug? > Perhaps the 404 is at least a good idea for a section, but probably not 404? Yes, I think this would be another bug, maybe 400 instead of 404? https://www.restapitutorial.com/httpstatuscodes.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 12:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 10:57:29 +0000 Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 13:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 11:04:54 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90672|0 |1 is obsolete| | --- Comment #164 from David Gustafsson --- Created attachment 90722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90722&action=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 13:08:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 11:08:35 +0000 Subject: [Koha-bugs] [Bug 23136] The Filter Suggestions option to Search by Requester worked across all the tabs simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23136 --- Comment #1 from Paul Thornton --- It would also be beneficial to search across tabs by Suggestion number -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 13:18:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 11:18:30 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #20 from Katrin Fischer --- We are early enough, let's push this into 19.11.01 (which means now we have translation break, but better now than later) and fix the Mana server at release day if possible. But I agree that in general we should make sure things stay backwards compatible or version properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 13:21:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 11:21:34 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #21 from Martin Renvoize --- OK, I'll push this as is but I really hope we get API versioning done during the .02 month as by .03 I think this will become a much bigger issue for end users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 13:23:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 11:23:25 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 13:23:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 11:23:27 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #22 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:03:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:03:59 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 [Bug 23145] Confirming transfer during checkin clears the table of previously checked-in items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:03:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:03:59 +0000 Subject: [Koha-bugs] [Bug 23145] New: Confirming transfer during checkin clears the table of previously checked-in items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Bug ID: 23145 Summary: Confirming transfer during checkin clears the table of previously checked-in items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: cbrannon at cdalibrary.org, gmcharlt at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 21346 Target Milestone: --- Following the changes made by Bug 21346, transfers triggered during checkin result in a modal dialog asking for confirmation. When this confirmation is clicked the page reloads and the table of previously checked-in items disappears. The information in that table can be very important to librarians keeping track of what they've checked in or as a way to navigate directly to an item or patron. The modal should be dismissed without reloading the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:11:50 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #2 from Christofer --- Good morning, I've been asked several times by our staff and patrons to include a Holds History in the public facing OPAC. Our patrons would find this helpful, especially for those holds that have lapsed. This would allow someone to put a hold back on that item that they missed. Thanks for considering. Christofer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:13:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:13:36 +0000 Subject: [Koha-bugs] [Bug 23100] Notify user if leaving modified patron edit form without saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23100 --- Comment #5 from Owen Leonard --- Looks like the parts of this patch related to adding a custom message can be removed: https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload#Browser_compatibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:39:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:39:32 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #165 from David Gustafsson --- Created attachment 90723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90723&action=edit Bug 14957: Make preset labels translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:42:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:42:11 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:42:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:42:15 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90650|0 |1 is obsolete| | Attachment #90651|0 |1 is obsolete| | Attachment #90652|0 |1 is obsolete| | Attachment #90653|0 |1 is obsolete| | Attachment #90654|0 |1 is obsolete| | Attachment #90655|0 |1 is obsolete| | Attachment #90656|0 |1 is obsolete| | Attachment #90657|0 |1 is obsolete| | Attachment #90658|0 |1 is obsolete| | Attachment #90659|0 |1 is obsolete| | Attachment #90660|0 |1 is obsolete| | Attachment #90661|0 |1 is obsolete| | Attachment #90662|0 |1 is obsolete| | Attachment #90663|0 |1 is obsolete| | Attachment #90664|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall --- Created attachment 90724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90724&action=edit Bug 21073: Add new table, schema and classes Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:43:27 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #166 from David Gustafsson --- I managed to find documentation on how to make javascript strings translatable here: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS2:_Enabling_translation_of_language_strings_in_embedded_JavaScript I'm a little bit unsure if the inline template toolkit strings are translatable though and don't know how to test if they are. For example: [% FOR preset IN [ 'Protect', 'Overwrite', 'Add new', 'Add and append', 'Protect from deletion' ] %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:49:55 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard --- This applies fine for me, so please re-test if you can. Note that it depends on Bug 5287 which requires that you rebuild the OPAC CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:57:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:57:57 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90724|0 |1 is obsolete| | --- Comment #73 from Kyle M Hall --- Created attachment 90725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90725&action=edit Bug 21073: Add new table, schema and classes Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:11 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #75 from Kyle M Hall --- Created attachment 90727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90727&action=edit Bug 21073: Upgrade the kitchen sink plugin to get rid of warnings Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:14 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #76 from Kyle M Hall --- Created attachment 90728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90728&action=edit Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:18 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #77 from Kyle M Hall --- Created attachment 90729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90729&action=edit Bug 21073: (QA follow-up) Restore check on template Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:22 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #78 from Kyle M Hall --- Created attachment 90730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90730&action=edit Bug 21073: (QA follow-up) Remove unused libraries Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:06 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #74 from Kyle M Hall --- Created attachment 90726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90726&action=edit Bug 21073: Improve plugin performance Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. Test Plan: 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing plugins 5) Verify you can install new plugins Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:25 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #79 from Kyle M Hall --- Created attachment 90731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90731&action=edit Bug 21073: Regression tests for GetPlugins Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:29 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #80 from Kyle M Hall --- Created attachment 90732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90732&action=edit Bug 21073: Restore filtering by metadata This patch restores filtering the plugins by metadata. That got lost on rebase at some point. Regression tests are added on a prior patch. To test: - Have the 'regression tests for GetPlugins' patch applied - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:33 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #81 from Kyle M Hall --- Created attachment 90733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90733&action=edit Bug 21073: (follow-up) QA fixes after rebase Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:36 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #82 from Kyle M Hall --- Created attachment 90734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90734&action=edit Bug 21073: (follow-up) Add Class::Inspector to PerlDependencies Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:40 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #83 from Kyle M Hall --- Created attachment 90735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90735&action=edit Bug 21073: (QA follow-up) Only public subs should be considered Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:44 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #84 from Kyle M Hall --- Created attachment 90736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90736&action=edit Bug 21073: (QA follow-up) Add ->is_enabled and tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:51 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #86 from Kyle M Hall --- Created attachment 90738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90738&action=edit Bug 21073: (QA follow-up) Don't call -> twice! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:48 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #85 from Kyle M Hall --- Created attachment 90737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90737&action=edit Bug 21073: (QA follow-up) Simplify logic This patch simplifies the logic inside GetPlugins so: - It uses Koha::Plugins::Methods instead of plain SQL - It doesn't do more DB calls than needed, by filtering on method in the initial query to Koha::Plugins::Methods. It also relies on the (newly introduced) ->is_enabled method in Koha::Plugins::Base, for better readability. To test: - Run the tests and notice no behaviour changes are introduced. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 14:58:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 12:58:55 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #87 from Kyle M Hall --- Created attachment 90739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90739&action=edit Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:00:46 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90723|0 |1 is obsolete| | --- Comment #167 from David Gustafsson --- Created attachment 90740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90740&action=edit Bug 14957: Make preset labels translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:01:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:01:10 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:04:59 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #88 from Kyle M Hall --- (In reply to Martin Renvoize from comment #71) > Thanks Tomas, this is looking really good now.. Hopefully Kyle will have a > chance to take a quick peek and give us that second SO to go for PQA :) Looks great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:17:34 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90740|0 |1 is obsolete| | --- Comment #168 from David Gustafsson --- Created attachment 90741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90741&action=edit Bug 14957: Make preset labels translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:27:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:27:53 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90434|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 90743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90743&action=edit Bug 22566: Fix some more issues 1) Fix warning for undefined value in sprintf when no items have the indemand flag set. 2) Corrections to report_full for bad ternary in string construction 3) Perldoc corrections Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:27:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:27:56 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90435|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 90744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90744&action=edit Bug 22566: Fix malformed notice for stockrotation The default notice for stockrotation was malformed. This patch replaces it with a working one. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:27:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:27:58 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #14 from Martin Renvoize --- Created attachment 90745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90745&action=edit Bug 22566: Accept 'all' in the branch params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:28:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:28:01 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #15 from Martin Renvoize --- Created attachment 90746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90746&action=edit Bug 22566: Rename 'report_email' to 'report_by_branch' To clarify the intention of this routine, lets rename it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:27:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:27:50 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90433|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 90742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90742&action=edit Bug 22566: Fix some problems Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:28:05 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #16 from Martin Renvoize --- Created attachment 90747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90747&action=edit Bug 22566: Clarify intent of reports and add warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:29:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:29:51 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bibliwho at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:10 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90742|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 90748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90748&action=edit Bug 22566: Fix some problems Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:13 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90743|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 90749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90749&action=edit Bug 22566: Fix some more issues 1) Fix warning for undefined value in sprintf when no items have the indemand flag set. 2) Corrections to report_full for bad ternary in string construction 3) Perldoc corrections Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:16 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90745|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 90750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90750&action=edit Bug 22566: Accept 'all' in the branch params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:18 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90746|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 90751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90751&action=edit Bug 22566: Rename 'report_email' to 'report_by_branch' To clarify the intention of this routine, lets rename it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:24 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #22 from Martin Renvoize --- Created attachment 90753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90753&action=edit Bug 22566: Add 'branch' key to GetPreparedLetter The branch key was missing from the subsitution call to GetPreparedLetter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:21 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90747|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 90752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90752&action=edit Bug 22566: Clarify intent of reports and add warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:31:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:31:43 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:34:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:34:06 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 15:53:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 13:53:42 +0000 Subject: [Koha-bugs] [Bug 23146] New: Add support for Basic auth on the OAuth2 token endpoint Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23146 Bug ID: 23146 Summary: Add support for Basic auth on the OAuth2 token endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Target Milestone: --- The current implementation restricts it to only allow the parameters to be passed on the request body. This is an unnecessary limitation that (probably) prevents the integration of systems not capable of sending the parameters in the request body. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:05:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:05:39 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #169 from David Gustafsson --- Fixed documentation (borrower changed to userid). https://gitlab.com/gnucifer/koha-manual/tree/bug-14957-marc-merge-rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:08:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:08:08 +0000 Subject: [Koha-bugs] [Bug 23116] AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:08:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:08:54 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AllowHoldPolicyOverride |Cannot place overridden |allows a librarian to |holds |almost place a hold on an | |item already on hold | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:23:09 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- I'm getting an error when I try to place an item-level hold: Undefined subroutine &CGI::Compile::ROOT::home_vagrant_kohaclone_reserve_placerequest_2epl::canItemBeReserved called at /home/vagrant/kohaclone/reserve/placerequest.pl line 100 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:40:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:40:13 +0000 Subject: [Koha-bugs] [Bug 21917] Payment type should not show on Write off selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21917 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:40:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:40:46 +0000 Subject: [Koha-bugs] [Bug 21917] Payment type should not show on Write off selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21917 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:59:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:59:22 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett --- Failing as per Owen's suggestion, since foo is out of place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 18 16:58:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jun 2019 14:58:58 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 --- Comment #4 from M. Tompsett --- Comment on attachment 90512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90512 Bug 23096: Add floating toolbar to OPAC lists Review of attachment 90512: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23096&attachment=90512) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc @@ +90,4 @@ > > > > + HTML comments and Template comments added make this harder to check. @@ +489,5 @@ > + > + [% END %] > + > + > + [% END # /IF duplicatebiblionumber %] Your insertion of comments while clarifying, would have been better in a separate commit, so it would be easier to check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:09:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:09:38 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #3 from M. Tompsett --- Created attachment 90789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90789&action=edit Bug 23159: (followup) re-add comments" This reverts the previous followup, so that all patches can be pushed without only pushing the first one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:10:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:10:27 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #4 from M. Tompsett --- Created attachment 90790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90790&action=edit Bug 23159: (followup) remove added comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:10:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:10:02 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #90789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:10:31 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #5 from M. Tompsett --- Created attachment 90791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90791&action=edit Bug 23159: (followup) re-add comments" This reverts the previous followup, so that all patches can be pushed without only pushing the first one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:12:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:12:54 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement modifies |This bugfix modifies the release notes|the basic MARC editor so |basic MARC editor so that |that required fields have |required fields have the |the standard "Required" |standard "Required" label |label on them instead of a |on them instead of a small |small red asterisk. |red asterisk. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:17:35 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90786|0 |1 is obsolete| | Attachment #90790|0 |1 is obsolete| | Attachment #90791|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 90792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90792&action=edit Bug 23159: Reindent addbiblio.tt This patch corrects whitespace in the basic MARC editor template, addbiblio.tt: Tabs converted to spaces, indentation corrected. Some comments have been added in the markup to clarify the page structure. To test, apply the patch and open the basic MARC editor. Confirm that everything works correctly, including: - Showing/hiding subfields - Re-ordering subfields - Removing tags and subfields - Cloning tags and subfields - Plugin links Use the "-w" flag when using diff to examine the patch. The only changes should be places where single lines were broken up and where comments were added. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:17:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:17:38 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #7 from M. Tompsett --- Created attachment 90793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90793&action=edit Bug 23159: (follow-up) remove added comments Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:17:41 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #8 from M. Tompsett --- Created attachment 90794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90794&action=edit Bug 23159: (follow-up) re-add comments" This reverts the previous followup, so that all patches can be pushed without only pushing the first one. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:17:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:17:30 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:21:48 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #9 from M. Tompsett --- TEST PLAN (on a kohadevbox) --------- $ git checkout master $ git pull $ git checkout -b bug_23159 origin/master $ git bz apply 23159 -- do this interactively, and only apply the first 2 patches $ tr -d '[:space:]' < koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt > after.txt $ git checkout master $ tr -d '[:space:]' < koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt > before.txt $ diff before.txt after.txt -- no differences, which means the only differences are whitespace $ git checkout bug_23159 $ git bz apply 23159 -- apply the last patch $ restart_all Do the recommended testing in comment #1, though the "-w" won't help much, hence the provision of the remove and re-add comments patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:24:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:24:00 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #35 from Owen Leonard --- Changing the status of this to reflect that it has been pushed to master and won't be backported. Bug 22768 will address Comment 34. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:24:01 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:24:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:24:02 +0000 Subject: [Koha-bugs] [Bug 22980] Unwanted console.log in simple MARC editor template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22980 Bug 22980 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:24:01 +0000 Subject: [Koha-bugs] [Bug 22768] Basic MARC editor tab keyboard navigation broekn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Bug 22768 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:24:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:24:32 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #7 from Christopher Brannon --- The bigger the system, the more data you have to sift through, and it can make reports very sluggish. I'd be fine if it were kept in the logs, if there were some mechanism that could prune the logs of items that are deleted, and the pruning could be fine tuned as needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:54:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:54:30 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90764|0 |1 is obsolete| | Attachment #90769|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 90795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90795&action=edit Bug 23151: Properly clear/not clear date of birth. The problem is caused by how change is stored: {changed value} || NULL. NULL means no change, but in the case of clearing a date of birth one wants to set it to NULL, which is indistinguishable from the no change value. By adding a DUMMY_DATE '9999-12-31', and using it as an intermediate check, we can set the value to NULL. This required storing the DUMMY_DATE as the change value, then in the case of date of birth displaying blank when listing the changes, and saving undef when the changes are stored. TEST PLAN --------- 0) running this test plan without the patch results in bad data. 1) Ensure the Global System Preference OPACPatronDetails is set to Allow. 2) reset_all in the kohadevbox. 3) log into admin/admin. 4) open up localhost:8080 in one tab, and localhost:8081 in another. 5) In the opac tab, click on the user name, and then the 'your personal details' tab. 5a) Set the first name, so it won't complain. 6) Set the salutation to Mr. and the birth date to any date. 7) scroll down and submit 8) In the staff tab, click home 9) click on the 'patrons requesting modifications' at the bottom of the screen. -- you should see the changes you just made. 10) click the 'Approve' radio button, and click Submit. 11) In the opac tab, click on the 'your personal details' tab. -- the values should be as expected 12) Set the salutation to blank and leave the birth date alone. 13) scroll down and submit 14) repeat steps 8-11. -- the values should be as expected 15) Clear the birth date 16) scroll down and submit 17) repeat steps 8-11. 18) Set the salutation to Mr. and leave the birth date blank. 19) scroll down and submit. 20) repeat steps 8-11. 21) Repeat steps 6-11 for good measure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 16:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 14:54:33 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #8 from M. Tompsett --- Created attachment 90796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90796&action=edit Bug 23151: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:02:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:02:19 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:02:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:02:21 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90795|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 90797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90797&action=edit Bug 23151: Properly clear/not clear date of birth. The problem is caused by how change is stored: {changed value} || NULL. NULL means no change, but in the case of clearing a date of birth one wants to set it to NULL, which is indistinguishable from the no change value. By adding a DUMMY_DATE '9999-12-31', and using it as an intermediate check, we can set the value to NULL. This required storing the DUMMY_DATE as the change value, then in the case of date of birth displaying blank when listing the changes, and saving undef when the changes are stored. TEST PLAN --------- 0) running this test plan without the patch results in bad data. 1) Ensure the Global System Preference OPACPatronDetails is set to Allow. 2) reset_all in the kohadevbox. 3) log into admin/admin. 4) open up localhost:8080 in one tab, and localhost:8081 in another. 5) In the opac tab, click on the user name, and then the 'your personal details' tab. 5a) Set the first name, so it won't complain. 6) Set the salutation to Mr. and the birth date to any date. 7) scroll down and submit 8) In the staff tab, click home 9) click on the 'patrons requesting modifications' at the bottom of the screen. -- you should see the changes you just made. 10) click the 'Approve' radio button, and click Submit. 11) In the opac tab, click on the 'your personal details' tab. -- the values should be as expected 12) Set the salutation to blank and leave the birth date alone. 13) scroll down and submit 14) repeat steps 8-11. -- the values should be as expected 15) Clear the birth date 16) scroll down and submit 17) repeat steps 8-11. 18) Set the salutation to Mr. and leave the birth date blank. 19) scroll down and submit. 20) repeat steps 8-11. 21) Repeat steps 6-11 for good measure. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:02:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:02:38 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90796|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 90798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90798&action=edit Bug 23151: Add tests Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:12:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:12:15 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90798|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes --- Created attachment 90799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90799&action=edit Bug 23151: Add tests Signed-off-by: Lucas Gass Signed-off-by: Ed Veal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:13:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:13:19 +0000 Subject: [Koha-bugs] [Bug 23155] Tidy up Bugzilla statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23155 --- Comment #1 from Jonathan Druart --- What happens on release time, when oldstable become oldoldstable? Actually when pushed to oldoldstable should not it be RESOLVED FIXED? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:13:53 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:13:53 +0000 Subject: [Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 [Bug 23116] Cannot place overridden holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:15:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:15:07 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #27 from Jonathan Druart --- *** Bug 6993 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:15:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:15:08 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 6993, which changed state. Bug 6993 Summary: Incorrect data type in auth_subfield_structure https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:15:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:15:14 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90754|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 90800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90800&action=edit Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold A library appears to be able to place a second item level hold on an item a patron already has on hold if A) AllowHoldPolicyOverride is enabled and B) the circ rule allow for multple item level holds. Once the patron submits the hold requests though, the hold does not get stored in the database. Because allowing two item level holds for the same item makes no sense, we should not allow this attempt to take place, even if AllowHoldPolicyOverride is enabled. Test Plan: 1) Enable AllowHoldPolicyOverride 2) Set up circ rules to allow for multiple item level holds on one record 3) Place an item level hold on a record 4) Note you can force placing a second item hold on that reocrd 5) Attempt to do so, it will not actually work 6) Apply this patch 7) Note you can no longer place another item level hold for the same item you just placed an item-level hold on 8) Note you can still force holds that contravene the circ rules for any and all other reasons 9) Test with record level holds 10) Test by placing multiple holds from search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:15:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:15:07 +0000 Subject: [Koha-bugs] [Bug 6993] Incorrect data type in auth_subfield_structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 22919 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:42:58 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > suspend in the same table is still BOOLEAN. BOOLEAN is just an alias for TINYINT(1), I think it is worth changing anyway unless... > If SQL12 is applied we should patch all existing occurrences, and have a > check in the QA script. Is there a bug report already? we have this kind of thing, and we actually prefer to add them as BOOLEAN in kohastructure.sql, because we have TINYINT(1) fields that are not really booleans (for example marc_subfield_structure.tab). There isn't a bug report yet (sorry for that), and it would be great to have the QA tools catch this problems. If BOOLEAN helps detect them, then lets change the rule and use BOOLEAN! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:43:48 +0000 Subject: [Koha-bugs] [Bug 23146] Add support for Basic auth on the OAuth2 token endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23146 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 90801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90801&action=edit Bug 23146: (QA follow-up) Make sure we use the absolute path When making a request using any tool (like cUrl or Postman) you get a 'Basic authentication disabled' error (if it is actually disabled) or an 'invalid password' error if it is disabled. This is because the comparisson of the path we do passes on oauth.t but fails on external tools. This is probably related to our stack including Apache URL mappings and then in the plack.psgi file. The safest way is to just ask Mojo::URL the absolute path to be sure. To test: - Having the rest of the patches applied and plack restarted, run: [1] $ curl -X POST -H 'Authorization: Basic ZGQ2NjlmNGUtZmI1NS00Y2YzLWE4ZmYtYmFiYzJiNDIwNWY1OmM0ZDJmYmYzLWYwOWMtNGJkZi1iNWE4LTgxMDJmNjcwYTI1Mw' -i 'http://kohadev.myDNSname.org:8081/api/v1/oauth/token' --data grant_type=client_credentials => FAIL: It fails saying Basic auth is disabled - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass - Apply this patch - Replicate your curl/postman test => SUCCESS: It now works as expected - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests still pass! - Sign off :-D [1] You need to generate a client_id and client_secret, and encode them using: encode_base64url( "$client_id:$client_secret" ); Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:53:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:53:23 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:53:26 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90800|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 90802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90802&action=edit Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold A library appears to be able to place a second item level hold on an item a patron already has on hold if A) AllowHoldPolicyOverride is enabled and B) the circ rule allow for multple item level holds. Once the patron submits the hold requests though, the hold does not get stored in the database. Because allowing two item level holds for the same item makes no sense, we should not allow this attempt to take place, even if AllowHoldPolicyOverride is enabled. Test Plan: 1) Enable AllowHoldPolicyOverride 2) Set up circ rules to allow for multiple item level holds on one record 3) Place an item level hold on a record 4) Note you can force placing a second item hold on that reocrd 5) Attempt to do so, it will not actually work 6) Apply this patch 7) Note you can no longer place another item level hold for the same item you just placed an item-level hold on 8) Note you can still force holds that contravene the circ rules for any and all other reasons 9) Test with record level holds 10) Test by placing multiple holds from search results Signed-off-by: Martha Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 17:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 15:58:53 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #6 from Jonathan Druart --- Should we really ignore this case? It sounds like the library owes money to somebody. I have no idea how we could handle it properly however... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:06:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:06:59 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90766|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 90804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90804&action=edit Bug 23152: Implement koha_object[s]_class when needed A simple use case is the ->get_from_storage (useful when writing tests) Test plan: Apply only the first patch and notice the test failures Apply the second patch and confirm the the tests are returning green Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:06:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:06:56 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90765|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 90803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90803&action=edit Bug 23152: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:08:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:08:49 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- This is a bit of a no-brainer and something I've been meaning to get around to doing myself for a while. Going straight for PQA as the patch is trivial to read and the qa scripts don't complain. The test currently fails, but the reason is clear and it just warrants an RM followup on push to bring it up to date with the available classes at the time of push. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:08:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:08:55 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:11:36 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 --- Comment #6 from Jonathan Druart --- (In reply to Martin Renvoize from comment #5) > This is a bit of a no-brainer I wrote a script ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:18:41 +0000 Subject: [Koha-bugs] [Bug 23162] New: Cannot copy a notice if independent branches enabled and not a superlibrarian Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23162 Bug ID: 23162 Summary: Cannot copy a notice if independent branches enabled and not a superlibrarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We forget to set the branch to current branch I guess To recreate: 1 - Be a superlibrarian (you all are anyways!) 2 - Go to Tools->notices and slips 3 - Note you see notices and can copy them to other branches to edit 4 - Now enabled independent branches 5 - It all still works 6 - Stop being a superlibrarian (i.e. create a patron with permissions for notices, but not superlibrarian) 7 - Go to Tools->notices and slips 8 - Note the 'copy' button doesn't have a drop down to select branch 9 - Click it, you can edit 10 - Try to save - Alert:A letter with the code 'ACCTDETAILS' already exists for 'undefined'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:32:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:32:53 +0000 Subject: [Koha-bugs] [Bug 23147] changes made by bug 20044 to addbiblio.pl causing issues for some catalogers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23147 Kim Olson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lclibill at gmail.com --- Comment #5 from Kim Olson --- Since the newest update, all the beautiful formatting we used to enjoy while editing records is gone. This is slowing my work flow down so much, it's really not acceptable. Two factors are making life particularly difficult. First, the indenting is gone. Before, with subfields indented from fields, and open boxes indented from that, it was quick and easy to scan down a page. Now the more cluttered look of everything left-justified makes it difficult to focus on field numbers. Second, the longer field boxes (which are rarely even useful, as so much of the content is brief, and never necessary, since they all expand vertically to include content) are distracting. But the main difficulty is the fact that subfield headings, and the duplicate/delete buttons are no longer in line with the boxes, but above them. I keep having to correct myself, because I use the box above instead of below a subfield heading, just because it's not as immediately obvious. Also, there is the small up-pointing arrow to the left of the subfield number and label, which is there for rearranging subfields manually, but in the new alignment, it seems to be (incorrectly) connecting the label to the box above it. I have to really concentrate to remind my brain that it has a different purpose, and that never happened before. > Can we please have the old alignment and indents back? Applying the suggestion that Owen posted is beyond me. I just need it to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:37:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:37:13 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90797|0 |1 is obsolete| | Attachment #90799|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 90805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90805&action=edit Bug 23151: Modifiy database structure This modifies a fresh install structure, and provides an atomic update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:37:15 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #13 from M. Tompsett --- Created attachment 90806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90806&action=edit Bug 23151: Schema changes It is best to regenerate these from scratch. On a kohadevbox: $ misc/devel/update_dbix_class_files.pl --db_name=koha_kohadev --db_user=koha_kohadev --db_passwd=password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:37:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:37:18 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #14 from M. Tompsett --- Created attachment 90807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90807&action=edit Bug 23151: Tweak to use the new database structure This will use changed_fields to know whether a borrower field is actually modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:37:21 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #15 from M. Tompsett --- Created attachment 90808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90808&action=edit Bug 23151: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:37:24 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #16 from M. Tompsett --- Created attachment 90809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90809&action=edit Bug 23151: (follow-up) tweaked tests This forces the tests to use the new changed_fields field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:40:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:40:35 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:41:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:41:54 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org, | |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:42:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:42:30 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #17 from M. Tompsett --- Sorry, I forgot to change the status before Lucas and Ed signed off. DOH! Feel free to try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:45:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:45:28 +0000 Subject: [Koha-bugs] [Bug 23147] changes made by bug 20044 to addbiblio.pl causing issues for some catalogers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23147 --- Comment #6 from Owen Leonard --- (In reply to Kim Olson from comment #5) > Applying the suggestion that Owen posted is beyond me. To use my suggestion above you would go to Administration -> Global system preferences, and search for "IntranetUserCSS." Click the "Click to edit" link to expand the textarea. Paste in the following text: @media (min-width:613px){#addbibliotabs div.subfield_line label{width:15em}#addbibliotabs .input_marceditor{width:20em}#addbibliotabs .subfield{width:12em}}@media (min-width:768px){#addbibliotabs div.subfield_line label{width:20em}#addbibliotabs .input_marceditor{width:30em}#addbibliotabs .subfield{width:14em}}@media (min-width:1200px){#addbibliotabs div.subfield_line label{width:25em}#addbibliotabs .input_marceditor{width:50em}#addbibliotabs .subfield{width:16em}} Save your changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:49:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:49:26 +0000 Subject: [Koha-bugs] [Bug 23163] New: HoldsSplitQueueNumbering requires "modify_holds_priority" permission to work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23163 Bug ID: 23163 Summary: HoldsSplitQueueNumbering requires "modify_holds_priority" permission to work Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- In Koha 18.11, if HoldsSplitQueueNumbering is set to "'virtual' priorities, where each group is numbered separately" the virtual holds queues are not renumbered separately unless the staff user has the "modify_holds_priority" set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 18:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 16:55:56 +0000 Subject: [Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Basic MARC editor tab |Global search forms' |keyboard navigation broekn |keyboard navigation broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:06:37 +0000 Subject: [Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:06:39 +0000 Subject: [Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 --- Comment #1 from Owen Leonard --- Created attachment 90810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90810&action=edit Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:07:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:07:12 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Required fields in the MARC editor should be highlighted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:07:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:07:12 +0000 Subject: [Koha-bugs] [Bug 7890] Required fields in the MARC editor should be highlighted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22399 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:31:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:31:31 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Jonathan Druart --- Mark, what about the update process? We need to have an atomic update file and update the existing rows in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:31:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:31:59 +0000 Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:32:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:32:01 +0000 Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90774|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90812&action=edit Bug 23156: Add pagination to checkouts in ILS-DI GetPatronInfo service When patrons have a lot of checkouts, GetPatronInfo can take a lot of time. This patch introduces two new parameters to allow pagination of this list of checkouts Also, fix a warning in C4::ILSDI::Services::GetPatronInfo Test plan: 1. Go to /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X&show_loans=1 where X is a borrowernumber of a patron who has several checkouts Verify that all checkouts are listed 2. Add '&loans_per_page=1&loans_page=1' to the URL. Verify that you have now only one checkout listed, and that there is a new element which contain the total number of checkouts 3. Increase the page number in the URL until you have seen all checkouts 4. prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:38:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:38:41 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Naive question reading the diff: should not we have that check in CanItemBeReserved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:42:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:42:39 +0000 Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 --- Comment #3 from Arthur Suzuki --- Yipee, super great! I was looking for this since a couple months but unfortunately couldn't find the time nor the expertise to do it myself. Thanks Julian for the patch!!! Thanks Mark for signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:46:18 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from M. Tompsett --- It's in the first patch as a .perl, Jonathan. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:58:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:58:14 +0000 Subject: [Koha-bugs] [Bug 19515] Refactor REST API session mocking to reduce code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19515 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED --- Comment #7 from Tom?s Cohen Arazi --- We have implemented Basic authentication, and it got really simple to test the API without this much trouble. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:58:26 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add user expiration date to |Add ability to send custom |SIP2 message |field(s) containing patron | |information in SIP patron | |responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:59:31 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:59:31 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 [Bug 22431] Incorrect group by in circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 19:59:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 17:59:39 +0000 Subject: [Koha-bugs] [Bug 23164] New: Add a way to unmock preferences and config entries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23164 Bug ID: 23164 Summary: Add a way to unmock preferences and config entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- There should be a way to unmock mocked things. In my opinion t::lib::Mocks should be object-oriented, and keep references to the context object that is used for mocking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:00:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:00:44 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 --- Comment #3 from Jonathan Druart --- I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if anyone is willing to work on/continue it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:02:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:02:57 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22431 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:02:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:02:57 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13640 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:06:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:06:52 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:06:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:06:54 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 --- Comment #1 from Nick Clemens --- Created attachment 90813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90813&action=edit Bug 20816: Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) 2 - If you copied the above file you should be set to get custom field DE with dateexpiry 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp xyzzy -l LPL --patron nick -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp xyzzy -l LPL --patron nick -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:06:58 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 --- Comment #20 from Jonathan Druart --- (In reply to M. Tompsett from comment #19) > It's in the first patch as a .perl, Jonathan. :) Sorry, I missed it. However the column need to be set for existing installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:17:53 +0000 Subject: [Koha-bugs] [Bug 23165] New: Renewals for Self Checkout (SCO) module do not record branchcode in statistics Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Bug ID: 23165 Summary: Renewals for Self Checkout (SCO) module do not record branchcode in statistics Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Koha considers SCO to be part of the OPAC, but the code related to OpacRenewalBranch is in opac-renew.pl. Because of this, the branchcode does not get set when a renewal takes place via the self check module. It would make more sense to move this logic into C4::Circulation::AddRenewal to centralize it and ensure that the statistics branch is set no matter where in the OPAC AddRenewal may be called. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:18:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:18:04 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:18:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:18:01 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:21:28 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 --- Comment #1 from Kyle M Hall --- Created attachment 90815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90815&action=edit Bug 23165: Renewals for Self Checkout (SCO) module do not record branchcode in statistics Koha considers SCO to be part of the OPAC, but the code related to OpacRenewalBranch is in opac-renew.pl. Because of this, the branchcode does not get set when a renewal takes place via the self check module. It would make more sense to move this logic into C4::Circulation::AddRenewal to centralize it and ensure that the statistics branch is set no matter where in the OPAC AddRenewal may be called. Test Plan: 1) Using the SCO module, renew an item 2) View the statistics table row for the renewal, note that branch is empty 3) Apply this patch 4) Restart all the things! 5) Renew the item again 6) View the stats table row for the new renewal, the branch code should be set as per the system preference OpacRenewalBranch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 20:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 18:38:39 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #94 from Tom?s Cohen Arazi --- Created attachment 90816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90816&action=edit Bug 21073: (QA follow-up) Fix plugin-related tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:16:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:16:38 +0000 Subject: [Koha-bugs] [Bug 23164] Add a way to unmock preferences and config entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:21:15 +0000 Subject: [Koha-bugs] [Bug 23053] Local-Number cannot be used for authority matching due to non-existence of 'phrase' index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23053 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:25:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:25:23 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #4 from Jonathan Druart --- Federico, can you locate where you Koha code is (should be something like /usr/share/koha/lib) then copy the output of the following command: % grep -r remove_debarment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:25:38 +0000 Subject: [Koha-bugs] [Bug 18344] Overdue fines 'cap at replacement price' and 'cap by amount' should work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:39:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:39:51 +0000 Subject: [Koha-bugs] [Bug 23162] Cannot copy a notice if independent branches enabled and not a superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- What should we do? Remove the Copy button? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:47:58 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:47:58 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23150 --- Comment #80 from Jonathan Druart --- Why do we have the following line: opac/opac-memberentry.pl: push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy'); It causes bug 23150. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 [Bug 23150] GDPR breaks patron self modification on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:53:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:53:06 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:53:09 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #1 from Jonathan Druart --- Created attachment 90817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90817&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 19 21:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jun 2019 19:53:54 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |m.de.rooy at rijksmuseum.nl Version|18.11 |master --- Comment #2 from Jonathan Druart --- Not sure about this fix, I'd like Marcel review :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 02:18:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 00:18:05 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 02:18:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 00:18:05 +0000 Subject: [Koha-bugs] [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22844 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I think we should fix it on top of bug 22844. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 02:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 00:24:58 +0000 Subject: [Koha-bugs] [Bug 23127] Using commas in shipping cost on invoices causes issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12310 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Yes but, where does it work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 02:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 00:24:58 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 02:26:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 00:26:43 +0000 Subject: [Koha-bugs] [Bug 23139] Koha::SharedContent->get_sharing_url is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- It's also used in Koha::SharedContent::build_request 187 my $mana_url = get_sharing_url(); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 02:34:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 00:34:39 +0000 Subject: [Koha-bugs] [Bug 23108] staffaccess permission can be easily circumvented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23108 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- (In reply to Andrew from comment #0) > BUT: A user without the staffaccess permission can simply change a Staff > user to a new non-staff patron category and then make changes to permissions > and/or password. Hi Andrew, are you aware of the pref ProtectSuperlibrarianPrivileges? With the pref turned on (default) what you describe should not be allowed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:15:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:15:29 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:15:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:15:33 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 --- Comment #7 from Jonathan Druart --- Created attachment 90818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90818&action=edit Bug 23083: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:15:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:15:36 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 --- Comment #8 from Jonathan Druart --- Created attachment 90819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90819&action=edit Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED Test plan: 0: Do not apply the patches 1: Create an item with itype, ccode, location, and holding branch set 2: Create a course 3: Add item to course, changing the values for itype, ccode, and location 4: Click Edit for that item on course-details.pl 5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED 6: Hit Save 7: Back on course-details.pl, observe that the item is still showing the values set in step 3 8: Apply this patch 9: Repeat 4 to 6 10: Back on course-details.pl, observe that the item is now showing the correct values 11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently 12: hit save 13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:15:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:15:56 +0000 Subject: [Koha-bugs] [Bug 23083] Course reserve item edit fails if one does not set all values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:18:46 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #40 from Jonathan Druart --- (In reply to M. Tompsett from comment #38) > Comment on attachment 88201 [details] [review] > Bug 20116: Flush the caches > > Review of attachment 88201 [details] [review]: > ----------------------------------------------------------------- > > ::: debian/scripts/koha-translate > @@ +233,5 @@ > > > > +flush_cache() > > +{ > > + if [ "$dev" = "" ]; then > > + koha-foreach --enabled "$KOHA_HOME/misc/bin/clear_cache.pl" > > Is $KOHA_HOME/misc/bin going to exist? And is clear_cache.pl going to get > put there? Something is fishy for running this live. How that? Did you `git grep KOHA_HOME`? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:20:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:20:28 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #41 from Jonathan Druart --- (In reply to M. Tompsett from comment #39) > In addition to the whole $KOHA_HOME path existing in live problem, perhaps > the flushing could be split to a separate patch, so that bug 20884 could > depend on that, and not this? Or we push this and bug 20884 will benefit from it? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:28:35 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Nick Clemens from comment #1) > Created attachment 90528 [details] [review] > Bug 23102 - 404 errors on page causes SCI user to be logged out > > To test: > 1 - Have something on the SCO page that won't load Can you be more specific? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:31:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:31:52 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #6 from Jonathan Druart --- About 23070, not sure I will manage to rephrase it :) ->store will check the default values (triggering Koha::Object->store), and also do some stuffs (like logging, etc.) But in some cases (like the one we have on 23070), we know that it won't be necessary. The +1 query will not need the default values check or anything else, we just want to increment a value in DB. That a good example to let people use ->update directly, even if it should considered as a not recommended method And QA will have to be careful about that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 03:34:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 01:34:06 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #22 from Jonathan Druart --- It's hard to provide a complete test plan, you will need to show imagination to find bugs :) The idea is to translate authorised values and confirm that they are displayed translated for translated templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:01:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:01:29 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:01:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:01:33 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #2 from Jonathan Druart --- Created attachment 90820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90820&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:03:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:03:37 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90820|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 90821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90821&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:13:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:13:30 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:13:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:13:33 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90463|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 90822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90822&action=edit Bug 23090: Add some special characters TEST PLAN --------- $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP at ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 (Clean up and databases made) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:18:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:18:01 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90821|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 90823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90823&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:34:50 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:34:50 +0000 Subject: [Koha-bugs] [Bug 23166] New: Simplify code related to orders in catalogue/*detail.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Bug ID: 23166 Summary: Simplify code related to orders in catalogue/*detail.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 23084, 9780 Target Milestone: --- Since bug 9780 we are the ability to alert the librarian when a record which has been ordered will be deleted. Then the code to handle the alert has been copied to other catalogue/*detail.pl script, as the JS check is in the toolbar. This code is really unnecessary complicated and sometime simply not necessary. It could be replaced with Koha::Acquisition::Orders->search and make it more readable. (found it working on bug 23084, so writing it on top of it). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 [Bug 9780] Restrict the right to suppress a record used in some order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:34:50 +0000 Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used in some order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:36:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:36:20 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #1 from Jonathan Druart --- Created attachment 90824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90824&action=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:36:53 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90824|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 90825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90825&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:37:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:37:42 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90825|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 90826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90826&action=edit Bug 23166: Remove baskets_orders code This is never used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:37:45 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #4 from Jonathan Druart --- Created attachment 90827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90827&action=edit Bug 23166: Remove baskets_deletedorders code This is never used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:37:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:37:48 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #5 from Jonathan Druart --- Created attachment 90828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90828&action=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:39:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:39:05 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Jonathan Druart --- Martin, any suggestions to make this even more readable? Maybe using filter_by? I will be waiting for a decision before applying the change to other *detail.pl scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:52:20 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Jonathan Druart --- 1. Changes are made in Koha/Schema/Result/OldIssue.pm, above the "DO NOT MODIFY THIS OR ANYTHING ABOVE!" line. Is it expected? Did you forget to attached the DB changes patch? If you wanted to add it after that line, why not adding the constraint at DB level? Why not for Issue.pm? 2. -use base qw(Koha::Object); +use base qw(Koha::Checkout); Is this really needed? Why? If so I think it must be moved to its own bug report, explaining why we need it and what it will bring. Also tests must be provided for such changes. Note that both t/db_dependent/Koha/Account/Lines.t and t/db_dependent/Koha/Checkouts.t are passing without that change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:55:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:55:48 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90289|0 |1 is obsolete| | --- Comment #177 from Aleisha Amohia --- Created attachment 90829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90829&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:04 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90291|0 |1 is obsolete| | --- Comment #179 from Aleisha Amohia --- Created attachment 90831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90831&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:12 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90292|0 |1 is obsolete| | --- Comment #180 from Aleisha Amohia --- Created attachment 90832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90832&action=edit Bug 15516: Set reserve-group.pl to be executable Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:55:56 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90290|0 |1 is obsolete| | --- Comment #178 from Aleisha Amohia --- Created attachment 90830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90830&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:22 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90293|0 |1 is obsolete| | --- Comment #181 from Aleisha Amohia --- Created attachment 90833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90833&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:29 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90294|0 |1 is obsolete| | --- Comment #182 from Aleisha Amohia --- Created attachment 90834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90834&action=edit Bug 15516: Fix translation issues - Use " inside _() - Merge two strings (PART_OF_A, HOLD_GROUP) Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:37 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90295|0 |1 is obsolete| | --- Comment #183 from Aleisha Amohia --- Created attachment 90835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90835&action=edit Bug 15516: (follow-up) Fix kohastructure.sql Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:45 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90296|0 |1 is obsolete| | --- Comment #184 from Aleisha Amohia --- Created attachment 90836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90836&action=edit Bug 15516: (follow-up) Fix reserve -> hold change Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:56:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90297|0 |1 is obsolete| | --- Comment #185 from Aleisha Amohia --- Created attachment 90837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90837&action=edit Bug 15516: (follow-up) Fix modal for hold group Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:57:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:57:07 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90299|0 |1 is obsolete| | --- Comment #187 from Aleisha Amohia --- Created attachment 90839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90839&action=edit Bug 15516: (follow-up) Fix template filters Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:57:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:57:00 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90298|0 |1 is obsolete| | --- Comment #186 from Aleisha Amohia --- Created attachment 90838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90838&action=edit Bug 15516: (follow-up) Fix pod in C4::Reserves Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:57:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:57:14 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90300|0 |1 is obsolete| | --- Comment #188 from Aleisha Amohia --- Created attachment 90840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90840&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:57:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:57:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90301|0 |1 is obsolete| | --- Comment #189 from Aleisha Amohia --- Created attachment 90841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90841&action=edit Bug 15516: (follow-up) Schema updates Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:57:28 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90302|0 |1 is obsolete| | --- Comment #190 from Aleisha Amohia --- Created attachment 90842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90842&action=edit Bug 15516: (follow-up) Changing utf8 to utf8mb4 Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 04:57:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 02:57:35 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90303|0 |1 is obsolete| | --- Comment #191 from Aleisha Amohia --- Created attachment 90843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90843&action=edit Bug 15516: (follow-up) Fixing atomic update to prevent errors This patch prevents errors when applying atomic update, particularly for those that have already tested this feature before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 05:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 03:22:08 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #192 from Aleisha Amohia --- Created attachment 90844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90844&action=edit Bug 15516: Fixing missing curly bracket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 07:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 05:34:19 +0000 Subject: [Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488 Wangthoi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orangewangthoi at gmail.com --- Comment #15 from Wangthoi --- Someone please help me I am well verse with computer coding and all. My data are not lost but i am unable to check in books. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 08:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 06:42:56 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #3 from Marcel de Rooy --- (In reply to Andrew from comment #0) > - Request is refused with message "You have not filled out all required > fields. Please fill in all missing fields and resubmit." I am not sure if I understand. You only need to tick the GDPR consent field, and you can save the record? Note that if you do not agree with the GDPR policy, we do not want you to proceed and create an account. So the title GDPR breaks self registration, is completely unclear to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 08:44:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 06:44:49 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #2) > Not sure about this fix, I'd like Marcel review :) At least for mode Enforced, we should treat it as mandatory. But I think for Permissive it should better be handled as mandatory too. But that is more arbitrary. This change actually breaks GDPR ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 08:46:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 06:46:22 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #81 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #80) > Why do we have the following line: > > opac/opac-memberentry.pl: push @fields, 'gdpr_proc_consent' if > C4::Context->preference('GDPR_Policy'); > > It causes bug 23150. See bug 23150. No bug, but design. The field should be handled as mandatory. If you do not want to give consent, you cannot register an account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 09:29:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 07:29:33 +0000 Subject: [Koha-bugs] [Bug 23167] New: We should factor out shared code from Auth_with_cas.pm and Auth_with_shibboleth.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23167 Bug ID: 23167 Summary: We should factor out shared code from Auth_with_cas.pm and Auth_with_shibboleth.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- These two authentication mechanisms are starting to duplicate each others code in places; for example building a return url is now present in a nearly matching routine for both. We should factor out the similar routines into their own module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 09:29:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 07:29:46 +0000 Subject: [Koha-bugs] [Bug 23167] We should factor out shared code from Auth_with_cas.pm and Auth_with_shibboleth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23042 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 09:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 07:34:48 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Mirko Tietgen --- Due to the multitude of operating systems we try to support, we run into a dependency problem here. Crypt::PRNG is available in libcryptx-perl. It is available in -Debian 9 (Stretch) backports -Debian 10 (Buster) and later -Ubuntu 18.04 (Bionic Beaver) It is not available in -Debian 8 (Jessie) -Ubuntu 16.04 (Xenial Xerus) So far we have libcryptx-perl in the Koha repository, but it only works for Jessie, not Xenial, and it breaks Stretch without backports and Bionic. I propose to remove libcryptx-perl from our repository. The result will be -Debian 10 and Ubuntu 18.04 work out of the box -Debian 9 needs backports enabled -New installations on Jessie will not have Rest API support as far as Net::OAuth2::AuthorzationServer is required (but existing installations will continue to work because the package is already installed) -Ubuntu 16.04 will not have Rest API support as far as Net::OAuth2::AuthorzationServer is required Debian 10 will be released July 9. I propose to deprecate support for Debian 8 (Jessie). It will be enough work to support two versions of Debian, we will run into a lot of similar problems in the future otherwise. We try to support "the latest Ubuntu LTS", but have dragged Ubuntu 16.04 along so far. I propose to deprecate support for Ubuntu 16.04 (Xenial Xerus). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:33:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:33:55 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:33:57 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:33:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:33:58 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:34:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:34:00 +0000 Subject: [Koha-bugs] [Bug 23132] Encoding issues in facets with show more link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23132 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:34:02 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:34:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:34:04 +0000 Subject: [Koha-bugs] [Bug 23144] Bad POD breaks svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:56:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:56:38 +0000 Subject: [Koha-bugs] [Bug 23130] Incorrect alternative mana server URL in etc/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23130 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Congratulations on your first patch David, it's great to have you aboard :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 10:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 08:57:20 +0000 Subject: [Koha-bugs] [Bug 22966] Add Norwegian library and patron names for the web-based installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22966 --- Comment #5 from Martin Renvoize --- Congratulations on your first Petter David, it's great to have you aboard :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:28:38 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:44:18 +0000 Subject: [Koha-bugs] [Bug 23168] New: Ability to disable some plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Bug ID: 23168 Summary: Ability to disable some plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: agustinmoyano at theke.io, alex.arnaud at biblibre.com, axel.amghar at gmail.com, dcook at prosentient.com.au, gmcharlt at gmail.com, jose-mario.monteiro-santos at inlibro.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, tomascohen at gmail.com Depends on: 22053 Blocks: 21073, 22906 Target Milestone: --- With the combination of bug 21073 and bug 22053 in master now we have a breakage in updatedatabase. Bug 21073 uses Koha::Plugins to handle the GetPlugins call, but GetPlugins was changed to use DB tables which are built after the db update for bug 21073 runs and so the call fails during upgrades. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 [Bug 22053] Ability to disable some plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 [Bug 22906] Minor corrections to plugins home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:44:18 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Ability to disable some plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:44:18 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Ability to disable some plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:44:18 +0000 Subject: [Koha-bugs] [Bug 22906] Minor corrections to plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Ability to disable some plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:45:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:45:01 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The ability to | release notes|enable/disable plugins is | |added. This is particularly | |handy when testing new | |plugins or when plugins are | |not (yet) fully configured | |for production use. | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:44:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:44:54 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to disable some |Database Updates broken due |plugins |to conflicts in bug 21073 | |and bug 22053 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:45:27 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23168 Depends on|23168 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:45:27 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21073, 22906 | Depends on| |21073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 [Bug 22906] Minor corrections to plugins home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:45:27 +0000 Subject: [Koha-bugs] [Bug 22906] Minor corrections to plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23168 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:45:58 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:46:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:46:07 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:50:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:50:20 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #1 from Martin Renvoize --- Thankfully.. this one does only effect master at the moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 11:53:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 09:53:35 +0000 Subject: [Koha-bugs] [Bug 23169] New: When using "Save and continue editing" you are always sent to the first tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23169 Bug ID: 23169 Summary: When using "Save and continue editing" you are always sent to the first tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- When using the "Save and continue editing" feature in the cataloguing client, every time you save, you will be sent back to the first tab (in my case 0). It would be nice if you would stay on the tab you are currently work on instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:08:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:08:13 +0000 Subject: [Koha-bugs] [Bug 23170] New: in j2a.pl when a patron passes to an adult the name and surname of Guarantor stay on account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23170 Bug ID: 23170 Summary: in j2a.pl when a patron passes to an adult the name and surname of Guarantor stay on account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- To test : 1? run the j2a.pl with at least 1 juvenile/child patron who have the age to be moved to adult 2? on Patron details you see 'Guarantor' still with name and surname -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:24:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:24:48 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:25:26 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #7 from Martin Renvoize --- Adding Marcel to the CC list as my 'go to xslt guy'. Changes look sound to me so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:26:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:26:47 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90347|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 90845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90845&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:27:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:27:13 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:31:14 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Mirko, to get this some more visibility and come to a decision I have added it to the next General's meeting agenda: https://wiki.koha-community.org/wiki/General_IRC_meeting_10_July_2019#Agenda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:32:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:32:58 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #95 from Martin Renvoize --- Followup Pushed to Master, Thanks Tomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:33:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:33:52 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:33:54 +0000 Subject: [Koha-bugs] [Bug 21559] Rules for automatic framework codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559 --- Comment #10 from paxed --- Moving the _matchRecordFieldSpec and GetAutoFrameworkCode to Koha/Biblio.pm is the easy part. But then AddBiblio has to be rewritten. Unless there's a way to get a Koha::Biblio object without having the record in the database? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:36:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:36:35 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 --- Comment #3 from Mirko Tietgen --- I had already added it to the dev meeting agenda. :) I think it makes more sense there. And it's happening earlier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:36:51 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com --- Comment #96 from Andrew Isherwood --- I pulled latest master today and received this bug, looks great, nice job! I spotted something though and am not sure if it's expected behaviour or a bug. The database update that adds the plugin_methods table and then calls Koha::Plugins::InstallPlugins to populate it. However, upon looking at the plugin_methods table, I'm seeing far more methods than are exposed by my single installed plugin (CLA Permissions Check). Here are the methods that the plugin contains: koha-koha at aidev:/var/lib/koha/koha/plugins/Koha/Plugin/Com/PTFSEurope$ cat CLAPermissionsCheck.pm | grep '^sub ' sub new { sub intranet_catalog_biblio_enhancements { sub intranet_catalog_biblio_enhancements_toolbar_button { sub get_link { sub clean_isbn { sub clean_issn { sub check_start { sub configure { sub install() { sub upgrade { sub uninstall() { ...and this is the contents of my plugin_methods table: MariaDB [koha_demo1]> select * from plugin_methods; +----------------------------------------------------+-----------------------------------------------------+ | plugin_class | plugin_method | +----------------------------------------------------+-----------------------------------------------------+ | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | abs_path | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | as_heavy | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | bundle_path | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | canonpath | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | catdir | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | catfile | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | check_start | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | clean_isbn | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | clean_issn | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | configure | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | curdir | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | decode_json | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | disable | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | dt_from_string | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | enable | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | except | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | export | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | export_fail | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | export_ok_tags | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | export_tags | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | export_to_level | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | file_name_is_absolute | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | get_link | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | get_metadata | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | get_plugin_http_path | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | get_qualified_table_name | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | get_template | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | go_home | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | import | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | install | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | intranet_catalog_biblio_enhancements | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | intranet_catalog_biblio_enhancements_toolbar_button | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | is_enabled | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | max | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | mbf_dir | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | mbf_exists | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | mbf_open | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | mbf_path | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | mbf_read | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | mbf_validate | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | new | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | no_upwards | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | only | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | output | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | output_html | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | output_html_with_http_headers | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | output_with_http_headers | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | path | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | plugins | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | require_version | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | retrieve_data | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | rootdir | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | search_path | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | sha256_hex | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | store_data | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | uninstall | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | updir | | Koha::Plugin::Com::PTFSEurope::CLAPermissionsCheck | upgrade | +----------------------------------------------------+-----------------------------------------------------+ It seems to be grabbing all public methods, even those imported from other modules (explicitly or otherwise). Which, though they could be strictly argued to be capabilities of the plugin, aren't native to it and could easily lead to confusion. I couldn't see any discussion in this bug pertaining to this, so apologies if it's already been mentioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:37:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:37:20 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 12:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 10:52:32 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 --- Comment #4 from Katrin Fischer --- (In reply to Mirko Tietgen from comment #3) > I had already added it to the dev meeting agenda. :) > I think it makes more sense there. And it's happening earlier. I learned that 5 minutes after - sorry! I will remove, dev agenda is here: https://wiki.koha-community.org/wiki/Development_IRC_meeting_26_June_2019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:06:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:06:51 +0000 Subject: [Koha-bugs] [Bug 21559] Rules for automatic framework codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to paxed from comment #10) > Moving the _matchRecordFieldSpec and GetAutoFrameworkCode to Koha/Biblio.pm > is the easy part. But then AddBiblio has to be rewritten. Unless there's a > way to get a Koha::Biblio object without having the record in the database? Koha::Biblio->new({ attr1 => val1, ... }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:49:22 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #97 from Martin Renvoize --- Good point, I missed that.. I'll open a new bug to work that one out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:12 +0000 Subject: [Koha-bugs] [Bug 23171] New: Improve plugin performance Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Bug ID: 23171 Summary: Improve plugin performance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: agustinmoyano at theke.io, andrew.isherwood at ptfs-europe.com, arthur.suzuki at biblibre.com, black23 at gmail.com, dcook at prosentient.com.au, fridolin.somers at biblibre.com, jonathan.druart at bugs.koha-community.org, katrin.fischer at bsz-bw.de, kyle at bywatersolutions.com, martin.renvoize at ptfs-europe.com, mirko at abunchofthings.net, mtj at kohaaloha.com, mtompset at hotmail.com, nick at bywatersolutions.com, rbit at rbit.cz, tomascohen at gmail.com, wizzyrea at gmail.com Depends on: 21073, 22053 Blocks: 22832, 22834, 23168 Target Milestone: --- Bug #21073 introduced the plugin_methods table, but the methods being added include all inherited and imported methods alongside those implemented by the plugin in question... we should limit to those implemented directly by the plugin. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 [Bug 22053] Ability to disable some plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 [Bug 22832] Require plugins to specify the methods they implement https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 [Bug 22834] Add a method for plugins to return the absolute path for bundled files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:12 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:12 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:12 +0000 Subject: [Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:12 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:12 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:36 +0000 Subject: [Koha-bugs] [Bug 23171] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22053 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 [Bug 22053] Ability to disable some plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:36 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23171 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:57 +0000 Subject: [Koha-bugs] [Bug 23171] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22832, 22834 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 [Bug 22832] Require plugins to specify the methods they implement https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 [Bug 22834] Add a method for plugins to return the absolute path for bundled files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:57 +0000 Subject: [Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23171 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:51:57 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23171 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:52:04 +0000 Subject: [Koha-bugs] [Bug 23171] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Before this patch, whenever | release notes|a plugin hook was reached | |in koha code we would | |iteratively load plugins | |looking for one that may | |support the method. This | |patch adds database level | |caching of this data so we | |do one database call | |instead of iteratively | |calling 'load'. | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:53:33 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #98 from Kyle M Hall --- Yes, this is expected behavior and is a compromise to keep existing plugins from breaking. If we had whitelisted methods then any plugin using 'non-standard' plugin methods would have broken. The next step in plugins evolution is to allow each plugin to specify which methods it wants to declare ( on top of the 'official' ones ) and add those to the database instead. Then we can use this manual scanning method as a fallback for plugins that don't specify their available methods in the metadata. (In reply to Andrew Isherwood from comment #96) > I pulled latest master today and received this bug, looks great, nice job! > > I spotted something though and am not sure if it's expected behaviour or a > bug. > > The database update that adds the plugin_methods table and then calls > Koha::Plugins::InstallPlugins to populate it. However, upon looking at the > plugin_methods table, I'm seeing far more methods than are exposed by my > single installed plugin (CLA Permissions Check) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:54:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:54:22 +0000 Subject: [Koha-bugs] [Bug 23169] When using "Save and continue editing" you are always sent to the first tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23169 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- I think this problem is fixed by Bug 22768. Please re-open this report if I'm wrong. *** This bug has been marked as a duplicate of bug 22768 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 13:54:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 11:54:22 +0000 Subject: [Koha-bugs] [Bug 22768] Global search forms' keyboard navigation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Owen Leonard --- *** Bug 23169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:00:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:00:09 +0000 Subject: [Koha-bugs] [Bug 23171] The plugin_methods table includes imported methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve plugin performance |The plugin_methods table | |includes imported methods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:00:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:00:25 +0000 Subject: [Koha-bugs] [Bug 23171] The plugin_methods table should not include imported methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The plugin_methods table |The plugin_methods table |includes imported methods |should not include imported | |methods -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:05:34 +0000 Subject: [Koha-bugs] [Bug 23170] in j2a.pl when a patron passes to an adult the name and surname of Guarantor stay on account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure if we can assume that it should be removed... maybe comments from libraries using this would be good or it could be an option to the script? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:09:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:09:42 +0000 Subject: [Koha-bugs] [Bug 23170] in j2a.pl when a patron passes to an adult the name and surname of Guarantor stay on account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23170 --- Comment #2 from Christophe Croullebois --- Hi Katrin, good idea, I will propose that in patch. thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:15:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:15:45 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #5 from Andrew --- This is actually an issue on patron self *modification* rather than registration. If GDPR_policy is set to enforced or permissive, patron self modification will always give a "missing required field" error, even if the patron has already accepted the GDPR terms. There is nothing GDPR-related on the self-modification page, so there is nothing in the patron can do to move past this error and nothing indicating what the error is referring to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:21:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:21:02 +0000 Subject: [Koha-bugs] [Bug 22633] Barcodes in the patrons 'holds' summary should link to the moredetail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22633 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:27:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:27:22 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:31:17 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 Creates DB update 19.05.00.003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:33:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:33:14 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #6 from Marcel de Rooy --- (In reply to Andrew from comment #5) > This is actually an issue on patron self *modification* rather than > registration. > > If GDPR_policy is set to enforced or permissive, patron self modification > will always give a "missing required field" error, even if the patron has > already accepted the GDPR terms. There is nothing GDPR-related on the > self-modification page, so there is nothing in the patron can do to move > past this error and nothing indicating what the error is referring to. Ahh. Bad reader ;) Probably this fix then still needs a little tweak. Looking now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:34:48 +0000 Subject: [Koha-bugs] [Bug 23022] Koha is not compatible with MySQL >= 8.0.11 because of NO_AUTO_CREATE_USER mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23022 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:37:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:37:22 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:38:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:38:29 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #7 from Andrew --- I sort of anticipated confusion because I pointed at opac-memberentry.pl, which is confusingly both self reg and self mod :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:41:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:41:42 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:41:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:41:49 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #9 from Marcel de Rooy --- Created attachment 90847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90847&action=edit Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create When updating (patron modification), the field should not be required. Test plan: Check patron modification on opac. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:41:45 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90817|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 90846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90846&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:42:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:42:10 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #10 from Marcel de Rooy --- (In reply to Andrew from comment #7) > I sort of anticipated confusion because I pointed at opac-memberentry.pl, > which is confusingly both self reg and self mod :P Fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:42:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:42:49 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:43:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:43:41 +0000 Subject: [Koha-bugs] [Bug 23171] The plugin_methods table should not include imported methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 --- Comment #1 from Martin Renvoize --- Created attachment 90848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90848&action=edit Bug 23171: Only record actual plugin methods -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:43:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:43:49 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #82 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #81) > (In reply to Jonathan Druart from comment #80) > > Why do we have the following line: > > > > opac/opac-memberentry.pl: push @fields, 'gdpr_proc_consent' if > > C4::Context->preference('GDPR_Policy'); > > > > It causes bug 23150. > > See bug 23150. No bug, but design. > The field should be handled as mandatory. If you do not want to give > consent, you cannot register an account. Not completely true: see 23150 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:43:58 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Wildcards not being analyzed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #17 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:47:40 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|GDPR breaks patron self |GDPR feature breaks patron |modification on OPAC |self modification on OPAC --- Comment #11 from Katrin Fischer --- GDPR is a bit painful, but still changing the title slightly :) The law is not to blame here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:49:33 +0000 Subject: [Koha-bugs] [Bug 23117] additem.pl crashes on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23117 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:53:16 +0000 Subject: [Koha-bugs] [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 15:00:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 13:00:02 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22941 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 14:59:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 12:59:41 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #16 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 15:00:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 13:00:02 +0000 Subject: [Koha-bugs] [Bug 22941] Giving malformed sortfield to list results in Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22941 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17526 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 15:00:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 13:00:58 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a ( In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 --- Comment #17 from Fridolin SOMERS --- Same fix as Bug 22941, nice catch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 15:19:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 13:19:38 +0000 Subject: [Koha-bugs] [Bug 23171] The plugin_methods table should not include imported methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 --- Comment #2 from Martin Renvoize --- Grr, this doesn't work as Class::Inspector doesn't differentiate between imported routines and local routines (only inherited ones are taken account of). See https://github.com/plicease/Class-Inspector/issues/1 for further details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 15:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 13:39:24 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Could it be nice to allow for some indicator that the renewal has happened via SCO? The patrons have to come into the library to do it unlike when using the OPAC, so it might be interesting for stats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 15:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 13:47:35 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:08:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:08:13 +0000 Subject: [Koha-bugs] [Bug 22945] Markup error in OPAC search results around lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22945 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:09:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:09:52 +0000 Subject: [Koha-bugs] [Bug 23170] in j2a.pl when a patron passes to an adult the name and surname of Guarantor stay on account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23170 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com Status|NEW |Needs Signoff CC| |christophe.croullebois at bibl | |ibre.com --- Comment #3 from Christophe Croullebois --- Created attachment 90849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90849&action=edit add anonymize option to j2a.pl Test plan : Without the patch 1? run the j2a.pl with at least 1 juvenile/child patron who have the age to be moved to adult 2? on Patron details you see 'Guarantor' still with name and surname With the patch 1? run the j2a.pl with the option '-a' and with at least 1 juvenile/child patron who have the age to be moved to adult 2? on Patron details no more 'Guarantor' with name and surname Thx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:11:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:11:31 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #17 from Martin Renvoize --- The code in questions doesn't appear to have any dependancy on timezone where I'm looking.. perhaps we need to add some debugging code around the test at this point.. it seems to be happening more and more frequently on Jenkins. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:12:19 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #13 from Katrin Fischer --- Moving to failed QA, hope this can be fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:17:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:17:15 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #8 from Katrin Fischer --- I get a feeling that opinions on the stats tables vary wildly. As I said, I would not prune them, but only anonymize them if necessary. Having an idea about when something happened seems important to me. Having jobs with different options make sense. BTW: as far as I know it won't free space with MySQL if you delete lines. So that should not be a reason? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:17:53 +0000 Subject: [Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50 import sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:23:26 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:23:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:23:41 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #18 from Martin Renvoize --- OK.. so I threw in some debugging and it looks like it's the updated_on field that's throwing us. ok 3 - With BorrowerLogs, one detailed MODIFY action should be logged for the modification. Log 1 { "cardnumber" : { "after" : "TESTCARDNUMBER", "before" : "FAS0pUt3wnZaFD_aJOR" } } Log 2 { "updated_on" : { "after" : "2019-06-20 14:20:18", "before" : "2019-06-20 14:20:19" } } not ok 4 - With BorrowerLogs and TrackLastPatronActivity we should not spam the logs # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' # at t/db_dependent/Koha/Patrons.t line 1480. # got: '2' # expected: '1' # Looks like you failed 1 test of 4. not ok 31 - BorrowersLog tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:33:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:33:31 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #2 from Fridolin SOMERS --- We may ask to run an atomic perl script after upgrade ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:35:52 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #3 from Katrin Fischer --- I think if anyway possible we should avoid separate update scripts. They get missed too often and cause lots of issues then. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:36:16 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #4 from Tom?s Cohen Arazi --- I have a patch for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:38:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:38:23 +0000 Subject: [Koha-bugs] [Bug 17148] Add floating toolbar for tabs on cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17148 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Marjorie Barry-Vila --- *** This bug has been marked as a duplicate of bug 22045 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:38:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:38:23 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #36 from Marjorie Barry-Vila --- *** Bug 17148 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:44:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:44:17 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #19 from Martin Renvoize --- Wow.. this is a fun one.. The updated_on field is updated by a DB level trigger, but our Koha::Object store routine does not return freshly populated Koha::Object data (it uses update_or_insert which only updates the specified fields and does not repopulate from the database). So, in the Koha::Patron->store routine, where we build the actionlogs info we do a comparison between a freshly fetch row from the DB and the cached object data.. if this call to store happens to bridge a 1s boundary we spot a difference between whats in the updated_on in the Koha::Patron object and what's in the database row and record it as a change triggering an actionlog. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 16:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 14:54:25 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #20 from Martin Renvoize --- Had a quick chat with Kyle and Tomas about this.. We think we should add updated_on to the exclude list for the actionlogs (I don't think it makes much sense to record such a system maintained internal field in the actionlogs change information like this) We also think this highlights that we shouldn't be letting the DB maintain the updated_on field here.. if the server timezone and your Koha instance timezone don't happen to match you're going to get interesting data in the updated_on field. So we're suggesting adding a dt_from_string call in the Koha::Patron store routine itself to make sure we account for koha instance timezones. (there's a precedent for this elsewhere already apparently) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:01:51 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #21 from Martin Renvoize --- Created attachment 90850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90850&action=edit Bug 22741: Make updated_on timezone aware in Koha::Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:02:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:02:01 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:02:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:02:07 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:09:22 +0000 Subject: [Koha-bugs] [Bug 23155] Tidy up Bugzilla statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23155 --- Comment #2 from Martin Renvoize --- My proposal way back when was for rmaints to set 'Pushed to ...' for each of their respective branches as they push.. and then for the release tools to include a change to 'RESOLVED FIXED' on mass at release time. I even have the scripts to do this all built, but the caveat there is that doing any sort of bulk action like that triggers a metric tonne of emails and hence the idea went on hold somewhat.. Happy to be guided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:17:41 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:17:46 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 90851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90851&action=edit Bug 23168: Enable plugins using plain SQL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:18:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:18:57 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:22:36 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90851|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 90852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90852&action=edit Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:31:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:31:10 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #22 from Tom?s Cohen Arazi --- The timezone can be set on connexion time, and we do in Koha/Database:78 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:33:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:33:18 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #5 from M. Tompsett --- Comment on attachment 90823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90823 Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Review of attachment 90823: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23084&attachment=90823) ----------------------------------------------------------------- I only thing that really stood out was the C4/Search.pm "Why is the \Q and \E missing?"? Explain that, I may sign this off. Everything else is a result of me seeing tcohen wanting to improve readability of code. "unless grep" is better read as "if none". ::: C4/ImportBatch.pm @@ +1114,4 @@ > my $dbh = C4::Context->dbh; > > my $order_by = $parameters->{order_by} || 'import_record_id'; > + ( $order_by ) = grep( { $_ eq $order_by } qw( import_record_id title status overlay_status ) ) ? $order_by : 'import_record_id'; Wouldn't 'any' be semantically easier to read? It also has the added benefit of removing the whole need for () around $order_by, because $order_by is a string. $order_by = any { $_ eq $order_by } qw( import_record_id title status overlay_status ) ) ? $order_by : 'import_record_id'; Actually, the whole point of the code is even clearer with 'none': $order_by = none { $_ eq $order_by } qw( import_record_id title status overlay_status ) ) ? 'import_record_id' : $order_by; ::: C4/Installer/PerlModules.pm @@ +76,4 @@ > no warnings > ; # perl throws warns for invalid $VERSION numbers which some modules use > my ( $self, $module ) = @_; > + return -1 unless grep { $_ eq $module } keys(%$PERL_DEPS); any is better, since it is boolean. ::: C4/Items.pm @@ +2101,4 @@ > push @columns, Koha::Database->new()->schema()->resultset('Biblioitem')->result_source->columns; > my @operators = qw(= != > < >= <= like); > my $field = $filter->{field}; > + if ( (0 < grep { $_ eq $field } @columns) or (substr($field, 0, 5) eq 'marc:') ) { any is better, since it checking if the field is in the list of columns. @@ +2105,4 @@ > my $op = $filter->{operator}; > my $query = $filter->{query}; > > + if (!$op or (0 == grep { $_ eq $op } @operators)) { none would be better than a '0 ==' check. @@ +2601,5 @@ > |; > for my $condition ( @$conditions ) { > if ( > + grep { $_ eq $condition->{field} } @item_columns > + or grep { $_ eq $condition->{field} } @biblioitem_columns any's would be nicer. ::: C4/OAI/Sets.pm @@ +500,4 @@ > my $value = $mapping->{'marcvalue'}; > my @subfield_values = $record->subfield($field, $subfield); > if ($operator eq 'notequal') { > + if(0 == grep { $_ eq $value } @subfield_values) { none. @@ +505,5 @@ > last; > } > } > else { > + if(0 < grep { $_ eq $value } @subfield_values) { any. ::: C4/Overdues.pm @@ +766,4 @@ > # Put 'print' in first if exists > # It avoid to sent a print notice with an email or sms template is no email or sms is defined > @mtts = uniq( 'print', @mtts ) > + if grep { $_ eq 'print' } @mtts; any. ::: C4/Search.pm @@ +731,4 @@ > > my $data = $field->as_string( $subfield_letters, $facet->{ sep } ); > > + unless ( grep { $_ eq $data } @used_datas ) { Why is the \Q and \E missing? @@ +1490,4 @@ > # this happens when selecting a subject on the opac-detail page > @limits = grep {!/^$/} @limits; > my $original_q = $q; # without available part > + unless ( grep { $_ eq 'available' } @limits ) { unless is harder to read construction, if none would be clearer, I think. @@ +1494,5 @@ > $q =~ s| and \( \( allrecords,AlwaysMatches:'' not onloan,AlwaysMatches:''\) and \(lost,st-numeric=0\) \)||; > $original_q = $q; > } > if ( @limits ) { > + if ( grep { $_ eq 'available' } @limits ) { any. ::: C4/Serials.pm @@ +1579,4 @@ > ### Would use substr and index But be careful to previous presence of () > $recievedlist .= "; $serialseq" unless ( index( $recievedlist, $serialseq ) > 0 ); > } > + if ( grep { $_ eq $status } (MISSING_STATUSES) ) { any. ::: C4/Stats.pm @@ +108,4 @@ > } > my @invalid_params = (); > for my $myparam (keys %$params ) { > + push @invalid_params, $myparam unless grep { $_ eq $myparam } @allowed_keys; if none would be easier to read. ::: C4/Tags.pm @@ +192,4 @@ > carp "Empty argument key to get_tag_rows: ignoring!"; > next; > } > + unless (1 == scalar grep { $_ eq $key } @ok_fields) { if none would be easier to read. @@ +233,4 @@ > carp "Empty argument key to get_tags: ignoring!"; > next; > } > + unless (1 == scalar grep { $_ eq $key } @ok_fields) { if none would be easier to read. @@ +302,4 @@ > carp "Empty argument key to get_approval_rows: ignoring!"; > next; > } > + unless (1 == scalar grep { $_ eq $key } @ok_fields) { if none would be easier to read. ::: C4/Utils/DataTables/Members.pm @@ +38,4 @@ > # Do that after iTotalQuery! > if ( defined $branchcode and $branchcode ) { > @restricted_branchcodes = @restricted_branchcodes > + ? grep { $_ eq $branchcode } @restricted_branchcodes @restricted_branchcodes = ((scalar @restricted_branchcodes > 0) && (none { $_ eq $branchcode } @restricted_branchcodes)) ? (undef) : ($branchcode); Nested ternary's are harder to read. ::: Koha/Object.pm @@ +236,4 @@ > my @columns = @{$self->_columns()}; > > foreach my $p ( keys %$properties ) { > + unless ( grep { $_ eq $p } @columns ) { if none. @@ +442,4 @@ > > my @columns = @{$self->_columns()}; > # Using direct setter/getter like $item->barcode() or $item->barcode($barcode); > + if ( grep { $_ eq $method } @columns ) { if any. @@ +457,4 @@ > Koha::Exceptions::Object::MethodNotCoveredByTests->throw( > error => sprintf("The method %s->%s is not covered by tests!", ref($self), $method), > show_trace => 1 > + ) unless grep { $_ eq $method } @known_methods; if none. ::: Koha/Objects.pm @@ +384,4 @@ > $method =~ s/.*:://; > > > + unless ( grep { $_ eq $method } @known_methods ) { if none. ::: acqui/duplicate_orders.pl @@ +86,4 @@ > if ( $op eq 'select' ) { > @result_order_loop = map { > my $order = $_; > + ( grep {$_ eq $order->{ordernumber}} @ordernumbers ) ? () : $order Too ugly to suggest something. @@ +132,4 @@ > for my $field ( > qw(currency budget_id order_internalnote order_vendornote sort1 sort2 )) > { > + next if grep { $_ eq $field } @fields_to_copy; any. ::: admin/preferences.pl @@ +117,4 @@ > { > text => $options{multiple}->{$option_value}, > value => $option_value, > + selected => (grep { $_ eq $option_value } @values) ? 1 : 0, any without the ternary? ::: admin/searchengine/elasticsearch/mappings.pl @@ +124,4 @@ > my $mapping_suggestible = $mapping_suggestible[$i]; > my $mapping_sort = $mapping_sort[$i]; > $mapping_sort = undef if $mapping_sort eq 'undef'; > + $mapping_facet = ( grep { $_ eq $search_field_name } @facetable_field_names ) ? $mapping_facet : 0; $mapping_facet = 0 if none { $_ eq $search_field_name } @facetable_field_names; @@ +200,4 @@ > sort => $s->get_column('sort') // 'undef', # To avoid warnings "Use of uninitialized value in lc" > suggestible => $s->get_column('suggestible'), > facet => $s->get_column('facet'), > + is_facetable => ( grep { $_ eq $name } @facetable_field_names ) ? 1 : 0, any without the ternary? ::: catalogue/ISBDdetail.pl @@ +152,4 @@ > my $basket = $myorder->{'basketno'}; > if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){ > push @deletedorders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_deletedorders){ if none. @@ +157,5 @@ > } > } > else { > push @orders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_orders){ if none, and fix the brace indentation below. ::: catalogue/MARCdetail.pl @@ +328,4 @@ > my $basket = $myorder->{'basketno'}; > if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){ > push @deletedorders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_deletedorders){ if none @@ +333,5 @@ > } > } > else { > push @orders_using_biblio, $myorder; > + unless (grep { $_ eq $basket } @baskets_orders){ if none with brace indentation fix below. ::: catalogue/detail.pl @@ +522,4 @@ > my $basket = $myorder->{'basketno'}; > if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){ > push @deletedorders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_deletedorders){ if none @@ +527,5 @@ > } > } > else { > push @orders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_orders){ if none with brace indentation below. ::: catalogue/imageviewer.pl @@ +89,4 @@ > my $basket = $myorder->{'basketno'}; > if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){ > push @deletedorders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_deletedorders){ if none @@ +99,1 @@ > push @baskets_orders,$myorder->{'basketno'}; if none with brace indentation below. ::: catalogue/itemsearch.pl @@ +63,4 @@ > push @f, $columns[$i]; > push @c, 'and'; > > + if ( grep { $_ eq $columns[$i] } qw( ccode homebranch holdingbranch location itype notforloan itemlost ) ) { any would be better. ::: catalogue/labeledMARCdetail.pl @@ +135,4 @@ > my $basket = $myorder->{'basketno'}; > if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){ > push @deletedorders_using_biblio, $myorder; > + unless (grep { $_ eq $basket } @baskets_deletedorders){ if none @@ +140,5 @@ > } > } > else { > push @orders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_orders){ if none with brace indentation fix below. ::: catalogue/moredetail.pl @@ +235,4 @@ > my $basket = $myorder->{'basketno'}; > if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){ > push @deletedorders_using_biblio, $myorder; > + unless (grep{ $_ eq $basket } @baskets_deletedorders){ if none @@ +240,5 @@ > } > } > else { > push @orders_using_biblio, $myorder; > + unless (grep { $_ eq $basket } @baskets_orders){ if none with brace fix indentation below. ::: circ/circulation.pl @@ +126,4 @@ > $template_name = q|circ/circulation_batch_checkouts.tt|; > my @batch_category_codes = split '\|', C4::Context->preference('BatchCheckoutsValidCategories'); > my $categorycode = $patron->categorycode; > + if ( $categorycode && grep { $_ eq $categorycode } @batch_category_codes ) { any Though, I wonder if this $batch_allowed and $barcodes[] could be optimized a bit with the any logic. ::: clubs/templates-add-modify.pl @@ +92,4 @@ > ? Koha::Club::Template::Fields->find($field_id) > : Koha::Club::Template::Field->new(); > > + if ( grep { $_ eq $field_id } @field_delete ) { any @@ +126,4 @@ > ? Koha::Club::Template::EnrollmentFields->find($field_id) > : Koha::Club::Template::EnrollmentField->new(); > > + if ( grep { $_ eq $field_id } @field_delete ) { any ::: misc/cronjobs/gather_print_notices.pl @@ +91,4 @@ > @all_messages = map { > my $letter_code = $_->{letter_code}; > ( > + grep { $_ eq $letter_code } @letter_codes ugly code map code. no patently obvious suggestions. ::: misc/cronjobs/longoverdue.pl @@ +301,4 @@ > $skip_borrower_category = [ map { uc $_} @$skip_borrower_category ]; > my %category_to_process; > for my $cat ( @$borrower_category ) { > + unless ( grep { $_ eq $cat } @available_categories ) { if none @@ +311,4 @@ > } > if ( @$skip_borrower_category ) { > for my $cat ( @$skip_borrower_category ) { > + unless ( grep { $_ eq $cat } @available_categories ) { if none @@ +329,4 @@ > $skip_itemtype = [ map { uc $_} @$skip_itemtype ]; > my %itemtype_to_process; > for my $it ( @$itemtype ) { > + unless ( grep { $_ eq $it } @available_itemtypes ) { if none @@ +339,4 @@ > } > if ( @$skip_itemtype ) { > for my $it ( @$skip_itemtype ) { > + unless ( grep { $_ eq $it } @available_itemtypes ) { if none ::: misc/migration_tools/rebuild_zebra.pl @@ +146,4 @@ > } > > our @tables_allowed_for_select = ( 'biblioitems', 'items', 'biblio', 'biblio_metadata' ); > +unless ( grep { $_ eq $table } @tables_allowed_for_select ) { if none @@ +476,4 @@ > > sub select_all_biblios { > $table = 'biblioitems' > + unless grep { $_ eq $table } @tables_allowed_for_select; if none ::: misc/translator/LangInstaller.pm @@ +634,4 @@ > next if $entry =~ /^\./; > my $relentry = File::Spec->catfile($dir, $entry); > my $abspath = File::Spec->catfile($basedir, $relentry); > + if (-d $abspath and not grep { $_ eq $relentry } @blacklist) { none ::: opac/opac-detail.pl @@ +720,4 @@ > > if ( C4::Context->preference('OPACAcquisitionDetails') ) { > $itm->{on_order} = 1 > + if grep { $_ eq $itm->{itemnumber} } @itemnumbers_on_order; any. possible optimization? ::: opac/opac-memberentry.pl @@ +77,4 @@ > > my @libraries = Koha::Libraries->search; > if ( my @libraries_to_display = split '\|', C4::Context->preference('PatronSelfRegistrationLibraryList') ) { > + @libraries = map { my $b = $_; my $branchcode = $_->branchcode; grep { $_ eq $branchcode } @libraries_to_display ? $b : () } @libraries; ugly code! no suggestions. ::: opac/opac-search-history.pl @@ +70,4 @@ > @searches = map { $_->{type} ne $type ? $_ : () } @searches; > } > if ( @id ) { > + @searches = map { my $search = $_; ( grep { $_ eq $search->{id} } @id ) ? () : $_ } @searches; so many ugly map{ grep {...}}'s. ::: opac/opac-search.pl @@ +431,4 @@ > @sort_by = $cgi->multi_param('sort_by'); > $sort_by[0] = $default_sort_by if !$sort_by[0] && defined($default_sort_by); > foreach my $sort (@sort_by) { > + if ( grep { $_ eq $sort } @allowed_sortby ) { any ::: opac/opac-shelves.pl @@ +114,3 @@ > if ( $shelf ) { > $op = $referer; > my $sortfield = $query->param('sortfield'); if $sortfield is undef, next line will explode. // 'title'; would be good. @@ +114,4 @@ > if ( $shelf ) { > $op = $referer; > my $sortfield = $query->param('sortfield'); > + $sortfield = 'title' unless grep { $_ eq $sortfield } qw( title author copyrightdate itemcallnumber dateadded ); if none. ::: reports/borrowers_stats.pl @@ +162,4 @@ > my $attribute_type = $1; > return unless (grep {$attribute_type eq $_->{code}} @attribute_types); > } else { > + return unless (grep { $_ eq $line } @valid_names); if none @@ +167,5 @@ > if ($column =~ /^patron_attr\.(.*)/) { > my $attribute_type = $1; > return unless (grep {$attribute_type eq $_->{code}} @attribute_types); > } else { > + return unless (grep { $_ eq $column } @valid_names); if none @@ +172,3 @@ > } > return if ($digits and $digits !~ /^\d+$/); > + return if ($status and (grep { $_ eq $status } qw(debarred gonenoaddress lost)) == 0); none @@ +172,4 @@ > } > return if ($digits and $digits !~ /^\d+$/); > + return if ($status and (grep { $_ eq $status } qw(debarred gonenoaddress lost)) == 0); > + return if ($activity and (grep { $_ eq $activity } qw(active nonactive)) == 0); none ::: tools/export.pl @@ +75,4 @@ > if ( $filename ) { > my $mimetype = $query->uploadInfo($filename)->{'Content-Type'}; > my @valid_mimetypes = qw( application/octet-stream text/csv text/plain application/vnd.ms-excel ); > + unless ( grep { $_ eq $mimetype } @valid_mimetypes ) { if none ::: tools/letter.pl @@ +263,4 @@ > my $preview_is_available = 0; > > if ($code) { > + $preview_is_available = grep {$_ eq $code } qw( CHECKIN CHECKOUT HOLD_SLIP ); could optimize with an any. ::: tools/modborrowers.pl @@ +278,4 @@ > for my $field ( qw/surname firstname branchcode categorycode city state zipcode country sort1 sort2 dateenrolled dateexpiry borrowernotes opacnote/ ) { > my $value = $input->param($field); > $infos->{$field} = $value if $value; > + $infos->{$field} = "" if grep { $_ eq $field } @disabled; if (any...) { $infos->{$field} = q{}; } else { $infos->{$field} = $value if $value; } -- double assign shorter vertically, but two assigns are slower than one. Plus, any is better than grep. @@ +313,4 @@ > # If this borrower is not in the category of this attribute, we don't want to modify this attribute > ++$i and next if $attr_type->{category_code} and $attr_type->{category_code} ne $borrower_categorycode; > my $valuename = "attr" . $i . "_value"; > + if ( grep { $_ eq $valuename } @disabled ) { any ::: virtualshelves/shelves.pl @@ +102,4 @@ > if ( $shelf ) { > $op = $referer; > my $sortfield = $query->param('sortfield'); > + $sortfield = 'title' unless grep { $_ eq $sortfield } qw( title author copyrightdate itemcallnumber dateadded ); if none. also might want a "|| 'title'" added above. @@ +234,3 @@ > if ( $shelf ) { > if ( $shelf->can_be_viewed( $loggedinuser ) ) { > my $sortfield = $query->param('sortfield') || $shelf->sortfield || 'title'; # Passed in sorting overrides default sorting Actually, the following line is switch to title as default if the passed sortfield isn't one of the valid ones. Comment is wrong. @@ +234,4 @@ > if ( $shelf ) { > if ( $shelf->can_be_viewed( $loggedinuser ) ) { > my $sortfield = $query->param('sortfield') || $shelf->sortfield || 'title'; # Passed in sorting overrides default sorting > + $sortfield = 'title' unless grep { $_ eq $sortfield } qw( title author copyrightdate itemcallnumber dateadded ); if none. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:34:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:34:44 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:34:47 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90852|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 90853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90853&action=edit Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:36:11 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90853|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 90854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90854&action=edit Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:39:52 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90854|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 90855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90855&action=edit Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:40:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:40:22 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Test plan works for me, Passing QA.. thanks for the quick fix Tomas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:41:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:41:18 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:41:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:41:21 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:47:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:47:57 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Moving boolean discussion to: https://gitlab.com/koha-community/qa-test-tools/issues/20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:50:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:50:58 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:50:53 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #8 from Martin Renvoize --- Sorry mate, but I can't apply this one.. error: sha1 information is lacking or useless (Koha/Schema/Result/Reserve.pm). error: could not build fake ancestor Patch failed at 0001 Bug 23133: DB update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:52:12 +0000 Subject: [Koha-bugs] [Bug 21559] Rules for automatic framework codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:53:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:53:32 +0000 Subject: [Koha-bugs] [Bug 21294] Indentify boolean fields on the DB structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Adopting this bug as we should really be moving all cases of 'BOOLEAN' to 'TINYINT(1)' and ensuring the class files match as expected. Also, we've suggested a QA script enhancement on https://gitlab.com/koha-community/qa-test-tools/issues/20 to catch such cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:53:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:53:50 +0000 Subject: [Koha-bugs] [Bug 21294] Indentify boolean fields on the DB structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23133 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:53:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:53:50 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:55:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:55:19 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Martin Renvoize --- That'll be the schema updates.. I'll work around it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:57:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:57:56 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 17:57:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 15:57:58 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90419|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 90856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90856&action=edit Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable Signed-off-by: Katrin Fischer Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:07:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:07:13 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- $ git grep "\\\n\/\\\ References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 --- Comment #8 from Heather --- If present, I think all the subfields should be displayed since they show the exact location within the host item of the analyzed title, with the $w record number hyperlinked to execute a search to retrieve the exact record containing the record number--I'm working on a support ticket with ByWater for this, but it's very complicated since the format for record numbers in the 7XX linking entry fields doesn't exactly match how the record numbers are stored in, e.g., 001. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:14:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:14:54 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90679|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 90857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90857&action=edit Bug 23133: DB update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:14:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:14:57 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90680|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 90858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90858&action=edit Bug 23133: Rename uses of item_level_hold Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:15:00 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90681|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 90859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90859&action=edit Bug 23133: API cleanup Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:15:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:15:19 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords|additional_work_needed | --- Comment #20 from Martin Renvoize --- Pushed followup to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:16:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:16:48 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize --- I'm happy with the changes as they are here, but do agree it would be nice to see the BOOLEAN handling and QA handling of such cases dealt with.. lets get this one rolling whilst we discus and implement an approach to resolving those issues in the gitlab bug linked above and bug 21294 here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:18:39 +0000 Subject: [Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:43:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:43:08 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #2 from M. Tompsett --- Created attachment 90860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90860&action=edit Bug 23109: (follow-up) fix typo in upgrade script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:54:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:54:44 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:54:46 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90706|0 |1 is obsolete| | Attachment #90860|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90861&action=edit Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 18:54:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 16:54:49 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #4 from M. Tompsett --- Created attachment 90862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90862&action=edit Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 19:21:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 17:21:49 +0000 Subject: [Koha-bugs] [Bug 23067] in Opac Confirm holds page the Last location column is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 --- Comment #2 from M. Tompsett --- Created attachment 90863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90863&action=edit Bug 23067: show the holdingbranch in opac-reserve Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 19:23:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 17:23:11 +0000 Subject: [Koha-bugs] [Bug 23067] in Opac Confirm holds page the Last location column is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 19:23:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 17:23:13 +0000 Subject: [Koha-bugs] [Bug 23067] in Opac Confirm holds page the Last location column is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90863|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90864&action=edit Bug 23067: show the holdingbranch in opac-reserve Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 19:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 17:27:52 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 20:45:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 18:45:13 +0000 Subject: [Koha-bugs] [Bug 20576] t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t fails if Elasticsearch is configured but not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20576 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 20:45:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 18:45:15 +0000 Subject: [Koha-bugs] [Bug 20576] t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t fails if Elasticsearch is configured but not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20576 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74120|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90865&action=edit Bug 20576: Skip gracefully with a meaningful message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 22:09:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 20:09:47 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #23 from Martin Renvoize --- Coolios, so just excluding from the action log trigger would do the trick and save us a call to date time.. I'll amend the patch in the morning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 20 22:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jun 2019 20:42:28 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 --- Comment #5 from David Nind --- I did test this and everything seems fine. I didn't sign off because of comment #4, will test again when ready. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 04:56:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 02:56:29 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |mtompset at hotmail.com --- Comment #24 from M. Tompsett --- Changing to assigned so this patch doesn't suffer the same fate as bug 23151 (signing off the old patch) when I forgot to change the status. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 05:43:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 03:43:01 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 05:43:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 03:43:04 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90704|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 90866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90866&action=edit Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 05:44:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 03:44:24 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Only thing that was a little off was the processing AFTER this, the check/uncheck doesn't disappear once the success message appears in the first column. But that is beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 05:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 03:50:17 +0000 Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I am wondering if the reason the name in_ipset was chosen was because multiple, disjoined IP ranges are allowed, not just a single one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:00:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:00:23 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Had to TagsInputOnList 'Allow'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:02:58 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:03:00 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89942|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90867&action=edit Bug 22946: Markup error in OPAC search results around selection links This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, make sure holds and/or tags are enabled in the OPAC. Perform a search in the OPAC which will return multiple results. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "Element div not allowed as child of element span in this context." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:03:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:03:32 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 --- Comment #4 from M. Tompsett --- This fixes the two div errors, as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:25:21 +0000 Subject: [Koha-bugs] [Bug 23172] New: Issuingrules not checked when returning item and allocating to bib-level holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Bug ID: 23172 Summary: Issuingrules not checked when returning item and allocating to bib-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Currently, when an item is returned the values in the issuingrules are not checked when determining whether to allocate that item to a bib-level hold, based on the item's itemtype and the requesting patrons patron category. This means hold rules defined in the issuingrules table are not being respected when allocating an item to a bib-level hold. For example, A biblio 'Fish' has items with two different item types 'BK' and 'CR'. In the circulation rules the patron category 'B' (Board) with the item type 'BK' has a reservesallowed value of 0 and a holds_per_record value of 0. Patron A (who has a patron category of 'B') can place a bib-level hold on 'Fish' biblio as there is an item with itemtype of 'CR' which they are permitted to reserve. If the 'BK' item is returned first then that will be allocated to fill patron A's bib-level hold, even though in the issuingrules 'B' patrons cannot place a hold on 'BK' items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:42:28 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #1 from Alex Buckley --- Created attachment 90868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90868&action=edit Bug 23172: When returning items check issuingrules When iterating over every reserve on a biblio when it is being returned retrieve the issuingrule reserveallowed and holds_per_record values for the reserves requester borrower category and returned item type. If the issuingrule defines that reservesallowed or holds_per_record is 0 then skip allocating that item to the current bib-level reserve. Test plan: 1. Find/make a biblio record with two items: one with item type of 'BK' (book) and the other with the itemtype of 'CR' (Continuing Resource) 2. In Administration > Circulation and fine rules define 2 new rules: Patron category: 'B' (Board)/ item type: 'BK'/ holds allowed (total): 0/ hold allowed (daily): 0 / holds per record: 0 Patron category: 'P' (Patron)/Item type: 'BK' / holds allowed (total): 1/ holds allowed (daily): 1 / holds per record 1 3. On the biblio record place a biblio-level hold for patron A (who has patron category of 'B') and patron B (who has patron category of 'P') 4. Return the 'BK' item (item with item type of 'BK') 5. Notice a popup asking you to confirm the hold by patron A (even though patrons of category 'B' cannot hold items of item type 'BK') 6. Apply patch and restart memcached and plack 7. Remove both holds on biblio 8. Repeat steps 3-5 but notice instead of a popup for patron A appearing, a popup asking you to confirm patron B appears i.e. patron A's bib-level hold is skipped as the issuingrules has been checked when the item was returned and it has been found that they cannot reserve an item with that specific itemtype Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 06:43:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 04:43:44 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #2 from Alex Buckley --- Unit test patch for testing the new function: Koha::Hold->check_if_existing_hold_matches_issuingrules() is my next priority for this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 07:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 05:34:29 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #5 from Katrin Fischer --- Thx for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 07:48:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 05:48:38 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 07:48:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 05:48:41 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 --- Comment #6 from Katrin Fischer --- Created attachment 90869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90869&action=edit Bug 23126: Remove more unnecessary linebreak processing from serial collection This should have no visible effect on the templates as the information the grep changes is not used in the template. It's also strange, that these lines existed, as GetSubscriptionsFromBiblionumber contained the same changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 08:08:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 06:08:23 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 08:08:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 06:08:25 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90822|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 90870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90870&action=edit Bug 23090: Add some special characters TEST PLAN --------- $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP at ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 (Clean up and databases made) Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 08:08:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 06:08:40 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 08:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 06:18:56 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Koha/Schema/Result/OldReserve.pm | 8 ++++---- Koha/Schema/Result/Reserve.pm | 8 ++++---- .../atomicupdate/bug_23133_item_level_holds.perl | 19 +++++++++++++++++++ installer/data/mysql/kohastructure.sql | 4 ++-- I would not recommend doing this in one patch. And thought that we even had a rule for that? But can't find it. DBIx schema files should be separate and marked as do_not_push, if the RM wants to generate them himself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 08:33:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 06:33:04 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #17 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 08:59:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 06:59:51 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #18 from Marcel de Rooy --- Fails on strict sql mode: DBD::mysql::st execute failed: 'koha_master.reserves.reserve_id' isn't in GROUP BY [for Statement [ ... etc ] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:07:58 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #19 from Marcel de Rooy --- The where condition is wrong. It should also incorporate the case that default_branch_item_rules is NULL (for istance, no corresponding record found for a biblio level hold). Will add a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:11:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:11:03 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #20 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #14) > Signing off as in a testing it appears to work as expected.. > > I'd love to see this query moved into a module and unit tested really, but > this fix works for now in my opinion.. good luck QAers. It does not work, but I agree about the module thing ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:13:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:13:35 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:13:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:13:39 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90639|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 90871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90871&action=edit Bug 13640: Do not display unreserveable items on the Holds to pull screen We should only display the items that meet the hold policies Test plan: It would be good to have a huge list of holds displayed on the "Holds to pull" and confirm that the display is now correct. One of the possible test plan has been let in a comment on the bug report: Bib Record A has 2 items: Item Record X (can be placed on hold) Item Record Y (cannot be placed on hold) If you place a bib-level hold on Bib Record A, both Item Record X and Item Record Y show up as available items in the Holds To Pull List. With this patch applied you must not see Y Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:13:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:13:44 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #22 from Marcel de Rooy --- Created attachment 90872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90872&action=edit Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed If a rule has not been defined for an itemtype or you submit a biblio level hold, you cannot filter on holdallowed<>0. Test plan: Test with a biblio level hold. Have two items; one item should be blocked with a policy. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:15:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:15:11 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #23 from Marcel de Rooy --- @RM: Passing QA with a follow-up. Note that the current query also fails on strict SQL mode. So not blocking for that. And yes, it could be moved to a module on a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:18:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:18:03 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:28:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:28:10 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:28:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:28:13 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90792|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 90873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90873&action=edit Bug 23159: Reindent addbiblio.tt This patch corrects whitespace in the basic MARC editor template, addbiblio.tt: Tabs converted to spaces, indentation corrected. Some comments have been added in the markup to clarify the page structure. To test, apply the patch and open the basic MARC editor. Confirm that everything works correctly, including: - Showing/hiding subfields - Re-ordering subfields - Removing tags and subfields - Cloning tags and subfields - Plugin links Use the "-w" flag when using diff to examine the patch. The only changes should be places where single lines were broken up and where comments were added. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:28:17 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90793|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 90874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90874&action=edit Bug 23159: (follow-up) remove added comments Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:28:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:28:21 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90794|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 90875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90875&action=edit Bug 23159: (follow-up) re-add comments" This reverts the previous followup, so that all patches can be pushed without only pushing the first one. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:28:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:28:34 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:31:23 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #13 from Marcel de Rooy --- (In reply to M. Tompsett from comment #2) > Your insertion of comments while clarifying, would have been better in a > separate commit, so it would be easier to check. Agree completely. Without the two patches of Mark, this patch would probably be sitting in the queue for much longer! @RM: Patch 2 and 3 do not need to be pushed (although they can), but prove that patch 1 can be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:36:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:36:12 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:36:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:36:15 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90710|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 90876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90876&action=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:36:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:36:25 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:40:25 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:39:58 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Martin: * Commit title does not contain 'follow-up' correctly spelt - 093cc6da89 * Commit title does not contain '(QA follow-up)' correctly spelt - 093cc6da89 ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:54:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:54:13 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #9 from Marcel de Rooy --- Strange. Circulation.t passes and fails with me: not ok 19 - AddReturn must have debarred the patron # Failed test 'AddReturn must have debarred the patron' # at t/db_dependent/Circulation.t line 3194. # got: '' # expected: '1' # AddReturn returned message $VAR1 = { # 'WasReturned' => 1 # }; not ok 20 - Test at line 1918 # Failed test 'Test at line 1918' # at t/db_dependent/Circulation.t line 3198. # got: '0' # expected: '1' not ok 21 - Test at line 1918 # Failed test 'Test at line 1918' # at t/db_dependent/Circulation.t line 3201. # got: undef # expected: '2019-07-05' # Looks like you failed 3 tests of 21. t/db_dependent/Circulation.t .. 130/131 # Failed test 'Item needs rentalcharge confirmation to be issued' # at t/db_dependent/Circulation.t line 3358. # Structures begin differing at: # $got->{RENTALCHARGE} = Does not exist # $expected->{RENTALCHARGE} = '1' # Failed test 'Item needs rentalcharge confirmation to be issued, increment' # at t/db_dependent/Circulation.t line 3362. # Structures begin differing at: # $got->{RENTALCHARGE} = Does not exist # $expected->{RENTALCHARGE} = '3' # Looks like you failed 2 tests of 2. t/db_dependent/Circulation.t .. 131/131 # Failed test 'CanBookBeIssued & RentalFeesCheckoutConfirmation' # at t/db_dependent/Circulation.t line 3364. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:55:55 +0000 Subject: [Koha-bugs] [Bug 23173] New: ILL should be able to search third party sources prior to request creation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Bug ID: 23173 Summary: ILL should be able to search third party sources prior to request creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- Currently, there is no integrated way of knowing if an item being requested is already available. If a user creating a request wants to know if the item they are requesting is already available, it is necessary to search the, possibly, multiple sources the library has available (catalogue, discovery interface, open access provider etc.) first. The problem is further compounded if the institution has the unmediated ILL workflow enabled where a request can be placed with no oversight, even though the institution may already have access to it. I propose a mechanism by which, during request creation, one or more "sources" are searched with the provided metadata to try and determine if the item being requested is already available and, if so, links to that item are provided. This behaviour will be optional, via a syspref. "Sources" will be provided as Koha plugins and will provide the ability to accept metadata conforming to the established ILL schema, search the source with which they're concerned, and return results in a prescribed format. This will be performed via an API common to all "source" plugins. All plugins performing this task will be in a common plugin category and therefore enumerable. The workflow for two backends: Freeform: - User fills in Freeform form, clicks submit button - User is taken to an "Availability" page - ILL enumerates source plugins that can service this type of request (mostly determined by material type) and makes search requests to each using provided metadata - Displays results from each source, with links to matching items - User can then either choose a result and be taken to it, or choose none and continue with the request as normal BLDSS: - Identical to above except the user will choose a BLDSS result rather than filling in the Freeform form As part of this work, a source plugin, which will serve as a reference, will be provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 09:57:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 07:57:00 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no, | |tomascohen at gmail.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:00:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:00:55 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90850|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 90877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90877&action=edit Bug 22741: Make updated_on timezone aware in Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:01:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:01:22 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #26 from Martin Renvoize --- Back to NSO with fresh patch attached :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:07:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:07:30 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:08:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:08:27 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 --- Comment #1 from Andrew Isherwood --- Just to clarify, in the above workflows, at the stage: - User can then either choose a result and be taken to it, or choose none and continue with the request as normal If no sources return any results, then the user would continue with the request as normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:14:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:14:50 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:18:41 +0000 Subject: [Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00, 18.11.06 |19.05.00, 18.11.06, released in| |18.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:18:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:18:49 +0000 Subject: [Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:24:04 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #10 from Martin Renvoize --- (In reply to Jonathan Druart from comment #6) > Should we really ignore this case? It sounds like the library owes money to > somebody. > I have no idea how we could handle it properly however... I think this isn't a problem actually.. the use case is that patron lost the book and then left the library.. then at a later date someone came across the book, spotted the library tag and so was nice enough to return it to the library. The original patron has left at this point, there's no way for us to refund the payment to them and I don't think there's a requirement to track them down to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:36:45 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90573|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 90878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90878&action=edit Bug 23103: Cannot checkin items lost by deleted patrons with fines attached Test Plan: 1) Checkout an item to a patron 2) Ensure the item has a replacement cost (or itemtype has default) 3) Ensure patrons are charged when items lost 4) Mark the item lost 5) Confirm patron has a fine 6) Write off the fine 7) Delete the patron 8) Check in the item 9) Note the internal server error 10) Apply this patch 11) Repeat steps 1-8 12) Note there is no internal server error! 13) prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:36:48 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #12 from Martin Renvoize --- Created attachment 90879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90879&action=edit Bug 23103: (QA follow-up) Return undef implicitly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:38:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:38:23 +0000 Subject: [Koha-bugs] [Bug 18841] Punctuations in normal view is different from ISBD view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18841 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- There is not enough information here to see what we need to fix. Please reopen with more details if this is still an issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:40:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:40:49 +0000 Subject: [Koha-bugs] [Bug 23174] New: Default (OPAC)ISBD contains
    tags that print in ISBD download Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23174 Bug ID: 23174 Summary: Default (OPAC)ISBD contains
    tags that print in ISBD download Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The ISBD systempreferences are used to configure the ISBD views in OPAC and staff and also the ISBD download format. The default ISBD system preferences contain
    tag for nicer display in the OPAC. these won't translate to newlines in the download and
    will be printed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:43:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:43:03 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:43:12 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:59:20 +0000 Subject: [Koha-bugs] [Bug 23175] New: circ/pendingreserves.pl SQL fails with SQL strict modes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23175 Bug ID: 23175 Summary: circ/pendingreserves.pl SQL fails with SQL strict modes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 13640 highlighted that with sql_strict_modes enabled the query fails.. we should fix that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:59:34 +0000 Subject: [Koha-bugs] [Bug 23175] circ/pendingreserves.pl SQL fails with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 [Bug 13640] Holds To Pull List includes items unreserveable items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 10:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 08:59:34 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23175 [Bug 23175] circ/pendingreserves.pl SQL fails with SQL strict modes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:04:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:04:37 +0000 Subject: [Koha-bugs] [Bug 23176] New: Show items.timestamp on items tab as last change date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23176 Bug ID: 23176 Summary: Show items.timestamp on items tab as last change date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- It would be nice if the last change date of an item could be made visible in the GUI. Right now the timestamp can only be made visible using a report, which is requires a lot of extra steps to see when an item was last changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:05:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:05:07 +0000 Subject: [Koha-bugs] [Bug 23177] New: Rollback cleanup in Circulation.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Bug ID: 23177 Summary: Rollback cleanup in Circulation.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Move subs to the front and rollbacks after last subtest. Trivial edits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:05:19 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:05:34 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 [Bug 23177] Rollback cleanup in Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:05:34 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:16:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:16:10 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #24 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:16:12 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:16:14 +0000 Subject: [Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:16:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:16:15 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:16:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:16:17 +0000 Subject: [Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:16:07 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:18:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:18:30 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 --- Comment #1 from Marcel de Rooy --- Created attachment 90880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90880&action=edit Bug 23177: (QA follow-up) Move three subs from the middle to the top in Circulation.t Removed trailing comma for last sub too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:18:28 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:18:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:18:34 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 --- Comment #2 from Marcel de Rooy --- Created attachment 90881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90881&action=edit Bug 23177: (QA follow-up) Move rollback to the end Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:18:38 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 --- Comment #3 from Marcel de Rooy --- Created attachment 90882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90882&action=edit Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback This resolves: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) Removing unneeded subtest txn's. We should probably add them everywhere or just at global level. Test plan: With all three patches applied, run Circulation.t a few times. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:20:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:20:37 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:21:23 +0000 Subject: [Koha-bugs] [Bug 23175] circ/pendingreserves.pl SQL fails with SQL strict modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 22431 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:21:23 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- *** Bug 23175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:22:14 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 [Bug 13640] Holds To Pull List includes items unreserveable items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:22:14 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 [Bug 22431] Incorrect group by in circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:22:43 +0000 Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943 --- Comment #4 from David Cook --- (In reply to M. Tompsett from comment #3) > I am wondering if the reason the name in_ipset was chosen was because > multiple, disjoined IP ranges are allowed, not just a single one? This probably actually say "in_ipranges" that's true. If you look at the code in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407, you'll see lots of mentions of ranges instead of set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:22:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:22:50 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 --- Comment #5 from Martin Renvoize --- (In reply to Jonathan Druart from comment #3) > I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if > anyone is willing to work on/continue it. I'm game for looking at this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:24:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:24:35 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #13 from Marcel de Rooy --- OK Fixed the test with rollback problems on bug 23177. Test passes now continuously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:25:15 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:25:19 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90878|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 90883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90883&action=edit Bug 23103: Cannot checkin items lost by deleted patrons with fines attached Test Plan: 1) Checkout an item to a patron 2) Ensure the item has a replacement cost (or itemtype has default) 3) Ensure patrons are charged when items lost 4) Mark the item lost 5) Confirm patron has a fine 6) Write off the fine 7) Delete the patron 8) Check in the item 9) Note the internal server error 10) Apply this patch 11) Repeat steps 1-8 12) Note there is no internal server error! 13) prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:25:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:25:23 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90879|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 90884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90884&action=edit Bug 23103: (QA follow-up) Return undef implicitly Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:26:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:26:36 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:26:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:26:20 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy --- RM: Consider these three patches as QA follow-ups for 23103 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:27:08 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:38:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:38:24 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:38:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:38:44 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Severity|enhancement |normal QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:38:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:38:27 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90768|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 90885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90885&action=edit Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:42:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:42:50 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy --- t/db_dependent/Circulation/MarkIssueReturned.t .. 2/3 # Failed test 'An exception is thrown on bad date' # at t/db_dependent/Circulation/MarkIssueReturned.t line 185. # expecting: Koha::Exceptions::Object::BadValue # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'bad_date' for column `koha_master`.`issues`.`returndate` at row 1 at /usr/share/koha/Koha/Object.pm line 155 # ) # Looks like you failed 1 test of 3. t/db_dependent/Circulation/MarkIssueReturned.t .. 3/3 # Failed test 'Manually pass a return date' # at t/db_dependent/Circulation/MarkIssueReturned.t line 191. # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:44:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:44:28 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:44:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:44:31 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:44:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:44:29 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88584|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:44:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:44:58 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:52:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:52:45 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:52:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:52:48 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90714|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 90886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90886&action=edit Bug 23126: Display multi-line entries in subscrpitions correctly There are several notes and other fields in a subscription that can be entered as multi-line input with breaks. We should display them as they were entered with keeping the line breaks intact. To test: - Add a subscription - Add comments including line breaks in internal and OPAC note - Check the manual history checkbox - Go to the subscription detail page, tab 'Planning' - Use the 'Edit history' link to edit the history - Enter content with line breaks in all the input fields where it's possible - Go to the OPAC detail page for your subscription record - Go to tab 'Subscriptions' > More details > Brief history - Verify the line breaks show there as
    - Apply patch - Relaod page, verify all information displays correctly now - Go back to the detail page, subscription tab - verify same there - Go back to the subscription detail page in staff - Check editing the history works as expected - Verify information on all tabs displays correctly - Receive a serial issue - verify note on top displays right - Go to the serial collection page of the subscription - same there Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:52:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:52:51 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90869|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 90887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90887&action=edit Bug 23126: Remove more unnecessary linebreak processing from serial collection This should have no visible effect on the templates as the information the grep changes is not used in the template. It's also strange, that these lines existed, as GetSubscriptionsFromBiblionumber contained the same changes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:55:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:55:43 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |In Discussion --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Nick Clemens from comment #0) > > Debatable, but that problem as it arose: > > Should we ask the list then? Yeah, might be safer way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 11:58:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 09:58:20 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- No patch but signed off? What are we doing here ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:12:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:12:42 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:16:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:16:38 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Naive question reading the diff: should not we have that check in > CanItemBeReserved? Holds overrides are only possible from the staff interface and on this page so I believe this change is sufficient to fix the regression. In the future this code could be improved and moved to modules for more testing, but this is a serious regression affecting many users and must be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:18:31 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:23:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:23:02 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #11 from Katrin Fischer --- We were testing the new return of the mana server - just hti mana-kb.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:23:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:23:53 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #12 from Katrin Fischer --- Also comment#2 for the merge request with the code change for the mana server. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:24:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:24:03 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:24:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:24:05 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90867|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 90888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90888&action=edit Bug 22946: Markup error in OPAC search results around selection links This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, make sure holds and/or tags are enabled in the OPAC. Perform a search in the OPAC which will return multiple results. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "Element div not allowed as child of element span in this context." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:24:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:24:30 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:27:35 +0000 Subject: [Koha-bugs] [Bug 23178] New: If all items are marked 'not for loan' staff results displays 'None available' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23178 Bug ID: 23178 Summary: If all items are marked 'not for loan' staff results displays 'None available' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- If all items on a record are marked not for loan on the item or by item type configuration, the result list displays: None available. This is not quite true. Usually in Koha 'available' is used to indicate the item ins on the shelf, 'available for loan' or 'not available for loan' would indicate that the items are there, but cannot be checked out. I think changing it to 'none available for loan' would be more accurate here. Or alternatively: Treat them separately and use "x availble for reference" similar to the result list in the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:28:31 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:28:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:28:34 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90846|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 90889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90889&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:28:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:28:36 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90847|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 90890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90890&action=edit Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create When updating (patron modification), the field should not be required. Test plan: Check patron modification on opac. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:34:48 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #13 from Martin Renvoize --- See also bug 23161 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:38:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:38:46 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:50:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:50:14 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:50:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:50:55 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90511|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 90891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90891&action=edit Bug 15814: Handle correctly MMTA edit button The MARC modification template action edit buton does not correctly handle variable escaping. Assigning a JS variable containing the JSON representation of the hashref will make the processing much more easier. Test plan: Create a MARC Modification Template with several actions. In the description you should use the following characters, to try to break this patch: \ ' " \n \r (not sure what we handled \n and \r) Then edit the action, modify and save again. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:50:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:50:57 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90712|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 90892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90892&action=edit Bug 15814: Add missing filters Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:50:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:50:52 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:57:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:57:00 +0000 Subject: [Koha-bugs] [Bug 23153] In framework management action subfields goes directly to edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:57:03 +0000 Subject: [Koha-bugs] [Bug 23153] In framework management action subfields goes directly to edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90785|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 90893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90893&action=edit Bug 23153: In framework management action subfields must not go directly to edition Since 18.11, when viewing a framework field clicking on Actions > Subfields goes to subfields edition instead of subfields table view. This is because link contains op=add_form. This is is also missing /cgi-bin/koha/admin. Test plan : 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) On a line click Actions > Subfields 4) You see subfields table 5) Click on Edit subfields 6) You see subfields edition tabs Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:59:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:59:35 +0000 Subject: [Koha-bugs] [Bug 23179] New: Add 'Edit subfields' to framework management tag dropdown and clarify options Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Bug ID: 23179 Summary: Add 'Edit subfields' to framework management tag dropdown and clarify options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Currently if viewing a framework each field has an actions dropdown: Subfields Edit Delete I think we should have: Edit tag View subfields Edit subfields Delete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:59:46 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |23153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23153 [Bug 23153] In framework management action subfields goes directly to edition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 12:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 10:59:46 +0000 Subject: [Koha-bugs] [Bug 23153] In framework management action subfields goes directly to edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:04:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:04:31 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 --- Comment #1 from Nick Clemens --- Created attachment 90894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90894&action=edit Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:04:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:04:29 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:19:42 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:19:44 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90711|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 90895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90895&action=edit Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. This is just a typo in perl script : circulation instead of circulate Test plan : 1) Set preference "AllowCheckoutNotes" to "Allow" 2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes" 3) Loggin with this user 4) Go to "Circulation" home page 5) Click on "Checkout notes" 6) You should be allowed to access Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:30:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:30:23 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:30:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:30:28 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90684|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 90897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90897&action=edit Bug 22571: Handle control fields in MMT for conditionals Control fields are not handled correctly by Koha::SimpleMARC when comparaison (with or without regex) is done. Which means we did not support something like: Do something if control field 008 equals or matches "a string" Test plan: Create a new MARC modification template and a new action, like: Add new field 100$a with value "foo bar" if 008 (or any other control fields) matches (or equals) a regex Then use the record mofication tool and confirm that the new field is create if the regex matches 008 of the bib record Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:30:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:30:25 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90683|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 90896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90896&action=edit Bug 22571: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:30:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:30:31 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90685|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 90898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90898&action=edit Bug 22571: (follow up) fix Donald cut-&-paste error Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:32:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:32:38 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90880|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 90899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90899&action=edit Bug 23177: (QA follow-up) Move three subs from the middle to the top in Circulation.t Removed trailing comma for last sub too. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:32:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:32:41 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90881|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 90900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90900&action=edit Bug 23177: (QA follow-up) Move rollback to the end Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:32:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:32:43 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90882|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 90901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90901&action=edit Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback This resolves: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) Removing unneeded subtest txn's. We should probably add them everywhere or just at global level. Test plan: With all three patches applied, run Circulation.t a few times. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:32:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:32:46 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 --- Comment #8 from Martin Renvoize --- Created attachment 90902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90902&action=edit Bug 23177: (RM follow-up) Further test clarifications This patch makes a few minor improvements to Circulation.t 1) Adds a name to some of the scoped blocks by converting them to subtests. 2) Adds output messages to some tests where they were missing. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:34:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:34:01 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:33:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:33:59 +0000 Subject: [Koha-bugs] [Bug 23177] Rollback cleanup in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:37:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:37:59 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:38:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:38:01 +0000 Subject: [Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 13:42:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 11:42:47 +0000 Subject: [Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #9 from Nick Clemens --- Created attachment 90903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90903&action=edit Bug 22924: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:24 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:27 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89932|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 90904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90904&action=edit Bug 22944: change unit tests Add a dedicated UT and correct a test return value Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:30 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89933|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 90905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90905&action=edit Bug 22944: avoid AnonymousPatron in search_patrons_to_anonymise In Koha::Patrons::search_patrons_to_anonymise() old issues already affected to the anonymous patron should be avoided. It is useless and can impact performance. It is already working if AnymousPatron is not defined or 0 because of : 'old_issues.borrowernumber' => { 'not' => undef } In theory the anymous patron should have privacy=0 but in case its not it should be explicitly avoided. Test plan : Run t/db_dependent/Koha/Patrons.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:33 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90628|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 90906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90906&action=edit Bug 22944: remove obsolete unit test Test 'AnonymiseIssueHistory should not return any error if success' is obsolete, previous statement will explode if something went wrong. Test plan : Run t/db_dependent/Koha/Patrons.t Signed-off-by: Arthur Bousquet Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:39 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:41 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:43 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:45 +0000 Subject: [Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:47 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:49 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:52 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:53 +0000 Subject: [Koha-bugs] [Bug 22946] Markup error in OPAC search results around selection links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22946 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:55 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:57 +0000 Subject: [Koha-bugs] [Bug 23097] Circulation Overdues report patron link goes to patron's holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23097 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:13:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:13:59 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:14:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:14:01 +0000 Subject: [Koha-bugs] [Bug 23150] GDPR feature breaks patron self modification on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:14:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:14:05 +0000 Subject: [Koha-bugs] [Bug 23153] In framework management action subfields goes directly to edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23153 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:14:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:14:03 +0000 Subject: [Koha-bugs] [Bug 23153] In framework management action subfields goes directly to edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:22:23 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90866|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 90907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90907&action=edit Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:22:20 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:37:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:37:10 +0000 Subject: [Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #15 from Tom?s Cohen Arazi --- I had errors generating the updated schema with the is_boolean declaration. That's why I added it like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:47:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:47:05 +0000 Subject: [Koha-bugs] [Bug 23180] New: CI and Tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23180 Bug ID: 23180 Summary: CI and Tests Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Mana-kb (server) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com Target Milestone: --- We have a few tests in mana-kb but we're not running them in any form of CI process.. we should utilise gitlabs CI systems and run them on merge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:47:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:47:28 +0000 Subject: [Koha-bugs] [Bug 23181] New: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Bug ID: 23181 Summary: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:47:34 +0000 Subject: [Koha-bugs] [Bug 23180] CI and Tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23180 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:47:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:47:37 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:47:24 +0000 Subject: [Koha-bugs] [Bug 23180] CI and Tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23180 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:53:14 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 14:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 12:53:16 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #1 from Kyle M Hall --- Created attachment 90908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90908&action=edit Bug 23181 - Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. Test Plan: 1) Attempt to use [% branch.branchame %] in the ACCOUNT_PAYMENT notice 2) Note it produces no output 3) Apply this patch 4) Make another payment 5) You should now see the branche's name! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 15:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 13:10:44 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 15:38:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 13:38:27 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #23 from Alex Arnaud --- Mana test and prod are both up to date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 15:42:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 13:42:34 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20621 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 15:42:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 13:42:34 +0000 Subject: [Koha-bugs] [Bug 20621] Add ability for Koha::Object objects to update themselves with database generated value automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 15:43:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 13:43:25 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #27 from Martin Renvoize --- To note.. the cause of this in the first place and a patch to try and alleviate it was written ages ago on bug 20621 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 15:53:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 13:53:05 +0000 Subject: [Koha-bugs] [Bug 23182] New: Invoice does not completely print in Acq 18.11 Firefox Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23182 Bug ID: 23182 Summary: Invoice does not completely print in Acq 18.11 Firefox Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- It appears that due to the addition of the "Adjustments" section on an invoice, the entire invoice will no longer print. Using the print function in Firefox, only the first six titles in an invoice print out, followed by a blank page 3. Chrome prints the entire invoice. Verified that in 18.05 Firefox prints the entire invoice. To test: create and invoice with more than six title.s . Using the browser print function in Firefox, note that only six titles and a blank page three print. View the same invoice in Chrome and notice that it prints as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:10:00 +0000 Subject: [Koha-bugs] [Bug 23183] New: Reindent cataloging.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 Bug ID: 23183 Summary: Reindent cataloging.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 22399 Target Milestone: --- cataloging.js has some inconsistent indentation that I would like to correct before making more substantive changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:10:00 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 [Bug 23183] Reindent cataloging.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:14:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:14:24 +0000 Subject: [Koha-bugs] [Bug 23183] Reindent cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:14:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:14:26 +0000 Subject: [Koha-bugs] [Bug 23183] Reindent cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 --- Comment #1 from Owen Leonard --- Created attachment 90909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90909&action=edit Bug 23183: Reindent cataloging.js This patch makes some very minor corrections to indentation in cataloging.js, a JavaScript file used by the bibliographic and item records editors. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:20:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:20:21 +0000 Subject: [Koha-bugs] [Bug 23154] Add pagination to /api/v1/checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:33:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:33:08 +0000 Subject: [Koha-bugs] [Bug 23154] Add pagination to /api/v1/checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:33:10 +0000 Subject: [Koha-bugs] [Bug 23154] Add pagination to /api/v1/checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90787|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:34:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:34:18 +0000 Subject: [Koha-bugs] [Bug 23154] Add pagination to /api/v1/checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23154 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 90910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90910&action=edit Bug 23154: Add pagination to /api/v1/checkouts Allow to use _page and _per_page query parameters for /api/v1/checkouts Also fix a timezone problem in t/db_dependent/api/v1/checkouts.t Test plan: 1. With your favorite REST tester tool, or directly in the browser, fetch http://koha/api/v1/checkouts and check that you have results 2. Fetch /api/v1/checkouts?_per_page=1&_page=1 and check that only the first result is returned. Check that response contains headers X-Total-Count and Link 3. Fetch /api/v1/checkouts?_per_page=1&_page=2 and check that only the second result is returned. Check that response contains headers X-Total-Count and Link 4. prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:35:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:35:00 +0000 Subject: [Koha-bugs] [Bug 23184] New: Export/bibs/holdings settings unclear for exporting bibs without any holdings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Bug ID: 23184 Summary: Export/bibs/holdings settings unclear for exporting bibs without any holdings Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- By default, Koha will not export bibs without items as the "owned by libraries" check boxes are selected. This is unclear to users. If I upload a file of bibs to export, and don't uncheck the library boxes, the resulting mrc file will only contain records that have items, all bib records without items will not be included. The check boxes should either be empty by default, or a clarification note should be added stating that itemless bibs will not be exported. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:37:37 +0000 Subject: [Koha-bugs] [Bug 23182] Invoice does not completely print in Acq 18.11 Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23182 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:48:56 +0000 Subject: [Koha-bugs] [Bug 15850] Correct JSHint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23183 Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 [Bug 23183] Reindent cataloging.js -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 16:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 14:48:56 +0000 Subject: [Koha-bugs] [Bug 23183] Reindent cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 [Bug 15850] Correct JSHint errors in cataloging.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:12:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:12:47 +0000 Subject: [Koha-bugs] [Bug 22230] Make SearchWithISBNVariations search in index keyword In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22230 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:27:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:27:17 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:27:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:27:17 +0000 Subject: [Koha-bugs] [Bug 23185] New: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Bug ID: 23185 Summary: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P1 - high Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, jonathan.druart at bugs.koha-community.org, koha-bugs at lists.koha-community.org, kyle at bywatersolutions.com, m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, testopia at bugs.koha-community.org, tomascohen at gmail.com Depends on: 21761 Target Milestone: --- +++ This bug was initially created as a clone of Bug #21761 +++ If we're adding triggers at the code level all over the place by overloading the store method we need to never ever let dbic handle it.. by allowing the 'update' method through we are exposing ourselves to places in the codebase skipping the store triggers. This would in effect bind us to the 'update_all' style of update call from dbic, which results in a loop over the affected rows so that in code triggers can be called per row rather than allowing any form of 'update all these rows to X' in one query. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:28:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:28:27 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:48:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:48:48 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #5 from Martin Renvoize --- Created attachment 90914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90914&action=edit Bug 21761: Call set + store as update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:48:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:48:50 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74262|0 |1 is obsolete| | --- Comment #48 from Nadine Pierre --- Created attachment 90915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90915&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:48:58 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74263|0 |1 is obsolete| | --- Comment #49 from Nadine Pierre --- Created attachment 90916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90916&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:03 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90380|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud --- Created attachment 90917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90917&action=edit Bug 22249: Mana - Move comment process in a dedicated sub Test plan: - Go to a subscription's detail page, - click on "Report mistake" => "New comment", - check Koha logs file, - you can see the following warning: Can't locate object method "find" via package "Koha::Resource_comments" - Apply this patch, - same test again, - no wraning -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:04 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74264|0 |1 is obsolete| | --- Comment #50 from Nadine Pierre --- Created attachment 90918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90918&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:10 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74265|0 |1 is obsolete| | --- Comment #51 from Nadine Pierre --- Created attachment 90919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90919&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:17 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74266|0 |1 is obsolete| | --- Comment #52 from Nadine Pierre --- Created attachment 90920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90920&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:31 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:24 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #53 from Nadine Pierre --- Created attachment 90921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90921&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:49:58 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #6 from Martin Renvoize --- Sorry Jonathan, I hadn't spotted you'd already written a patch here.. but aren't you over complicating it? I've submitted an alternative patch which I think does the same but is considerably simpler... catch me if I'm incorrect please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:50:37 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |nadine.pierre at InLibro.com --- Comment #54 from Nadine Pierre --- Rebased on current master and added missing bracket after resolving conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:51:02 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #7 from Alex Arnaud --- (In reply to Michal Denar from comment #5) > Hi Alex, > any test plan? > > Thank You. Hello Michal, Just added that in the commit message. Thx! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:52:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:52:00 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #8 from Alex Arnaud --- Kyle, Patch rebased. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:56:51 +0000 Subject: [Koha-bugs] [Bug 23186] New: Koha::Object->store precludes us from sending scalar references to dbic methods Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23186 Bug ID: 23186 Summary: Koha::Object->store precludes us from sending scalar references to dbic methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Under the hood the store method uses DBIx::Classes update_or_insert which in turn calls update for updates. The update method accepts a hashref of key value pairs relating to fields to be udpated. If the value is a scalar ref then it passes the it through unaltered to the database and as such things like 'NOW()' and 'field + 1' can be used allowing the database to do some of the work. - https://metacpan.org/pod/DBIx::Class::Row#update As it stands, we will catch such values and replace them silently with defaults. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:57:16 +0000 Subject: [Koha-bugs] [Bug 23186] Koha::Object->store precludes us from sending scalar references to dbic methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23186 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21761 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:57:16 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23186 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:59:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:59:16 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 17:59:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 15:59:19 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90776|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 90922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90922&action=edit Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:00:39 +0000 Subject: [Koha-bugs] [Bug 23187] New: Koha::Objects supports find_or_create without passing through the Koha::Object store method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 Bug ID: 23187 Summary: Koha::Objects supports find_or_create without passing through the Koha::Object store method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P1 - high Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, jonathan.druart at bugs.koha-community.org, koha-bugs at lists.koha-community.org, kyle at bywatersolutions.com, m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, testopia at bugs.koha-community.org, tomascohen at gmail.com Depends on: 21761 Blocks: 23185 Target Milestone: --- +++ This bug was initially created as a clone of Bug #21761 +++ If we're adding triggers at the code level all over the place by overloading the store method we need to never ever let dbic handle it.. by allowing directly passing data to dbic's find_or_create method in Koha::Objects we are exposing ourselves to places in the codebase skipping the store triggers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:00:39 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 [Bug 23187] Koha::Objects supports find_or_create without passing through the Koha::Object store method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:00:39 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 [Bug 23187] Koha::Objects supports find_or_create without passing through the Koha::Object store method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:02:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:02:47 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #1 from Martin Renvoize --- Note the 's' in the bug title.. this is not the same as 'Koha::Object' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:03:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:03:22 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23185 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:03:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:03:22 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23070 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:03:50 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #2 from Martin Renvoize --- See further discussion in bug 23070 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:05:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:05:20 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #3 from Martin Renvoize --- My personal feeling is that perhaps we should allow this one through but add a QA script warning to check that 'store' for the object in question doesn't have any triggers in place for the fields of the set being updated in any changes or additions to the update call in question. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:05:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:05:33 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick at bywatersolutions.com CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:07:43 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #4 from Martin Renvoize --- I also think it wouldn't be a bad idea to have an 'update_with_triggers' or something along those lines method which in effect did a dbic update_all call(https://metacpan.org/pod/DBIx::Class::ResultSet#update_all), i.e. calling set + store one each Koha::Object in a loop from the Koha::Objects set. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:32:16 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:32:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:32:19 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90622|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 90923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90923&action=edit Bug 23115: Tweak display of totals on 'Fines and charges' page This patch tweaks the display of totals on the OPAC 'Fines and charges' page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the 'Fines and charges' page before applying the patch 3) Look at the 'Fines and charges' page after applying the patch 4) Varify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:32:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:32:22 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 --- Comment #8 from Nick Clemens --- Created attachment 90924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90924&action=edit Bug 23115: (follow-up) Move switches to a TT block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:32:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:32:25 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 --- Comment #9 from Nick Clemens --- Created attachment 90925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90925&action=edit Bug 23115: (QA follow-up) Address QA tools complaints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:32:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:32:48 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- RM check my followups or push back to SO for another QA round :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 18:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 16:44:47 +0000 Subject: [Koha-bugs] [Bug 23188] New: Holds Column in Receipt Page sorts oddly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23188 Bug ID: 23188 Summary: Holds Column in Receipt Page sorts oddly Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- In the acquisitions module, when viewing an invoice - and choosing to view this in the Receipt page option, there is a column called Holds. If any record on this receipt has a hold this number will be displayed. There is a tiny carrot to allow the user to change the order of this view to see the most holds first. Unfortunately, Koha displays the holds in a fashion such as 0/1. The first number is the item levels hold and the second number is the total number of holds on the record (or in this case, the bib level hold). The sorting will only sort on the first number and if a library only does bib level holds, the sort will never be accurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 19:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 17:01:51 +0000 Subject: [Koha-bugs] [Bug 9851] Ability to link orders to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 19358 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 19:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 17:01:51 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Kyle M Hall --- *** Bug 9851 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 19:10:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 17:10:59 +0000 Subject: [Koha-bugs] [Bug 20460] Changing password through the patron edit form does not reset failedloginattempts or log change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Summary|Staff can only change |Changing password through |password through the change |the patron edit form does |password button if patron |not reset |hits failedloginattempts |failedloginattempts or log | |change See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21312 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 19:10:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 17:10:59 +0000 Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20460 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 19:12:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 17:12:53 +0000 Subject: [Koha-bugs] [Bug 20460] Changing password through the patron edit form does not reset failedloginattempts or log change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460 --- Comment #4 from Nick Clemens --- Locks are now displayed as of 19.05 - the remaining issues are the logging and resetting of login attempts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 19:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 17:29:10 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #5 from Federico Rinaudo --- there is no output for the command -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:12:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:12:04 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Federico Rinaudo from comment #5) > there is no output for the command It might come from the templates. Try: $ cd /usr/share/koha $ grep -r remove_debarment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:13:51 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #7 from Federico Rinaudo --- /usr/share/koha# grep -r remove_debarment intranet/cgi-bin/members/memberentry.pl:my @debarments_to_remove = $input->multi_param('remove_debarment'); intranet/htdocs/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: intranet/htdocs/intranet-tmpl/prog/es-ES/modules/members/memberentrygen.tt: -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:18:50 +0000 Subject: [Koha-bugs] [Bug 23183] Reindent cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90909|0 |1 is obsolete| | --- Comment #2 from Nadine Pierre --- Created attachment 90926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90926&action=edit Bug 23183: Reindent cataloging.js This patch makes some very minor corrections to indentation in cataloging.js, a JavaScript file used by the bibliographic and item records editors. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:19:31 +0000 Subject: [Koha-bugs] [Bug 23183] Reindent cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nadine.pierre at InLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:41:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:41:23 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 frederik.chenier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90760|0 |1 is obsolete| | --- Comment #11 from frederik.chenier at inlibro.com --- Created attachment 90927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90927&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley Signed-off-by: frederik -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:41:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:41:29 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 frederik.chenier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90761|0 |1 is obsolete| | --- Comment #12 from frederik.chenier at inlibro.com --- Created attachment 90928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90928&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley Signed-off-by: frederik -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 20:49:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 18:49:38 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90887|0 |1 is obsolete| | --- Comment #9 from Arthur Bousquet --- Created attachment 90929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90929&action=edit Bug 23126: Remove more unnecessary linebreak processing from serial collection This should have no visible effect on the templates as the information the grep changes is not used in the template. It's also strange, that these lines existed, as GetSubscriptionsFromBiblionumber contained the same changes. Signed-off-by: David Nind Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:05:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:05:31 +0000 Subject: [Koha-bugs] [Bug 23183] Reindent cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23183 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90926|0 |1 is obsolete| | --- Comment #3 from Bin Wen --- Created attachment 90930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90930&action=edit Bug 23183: Reindent cataloging.js This patch makes some very minor corrections to indentation in cataloging.js, a JavaScript file used by the bibliographic and item records editors. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Nadine Pierre Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:07:43 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90886|0 |1 is obsolete| | --- Comment #10 from Nadine Pierre --- Created attachment 90931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90931&action=edit Bug 23126: Display multi-line entries in subscrpitions correctly There are several notes and other fields in a subscription that can be entered as multi-line input with breaks. We should display them as they were entered with keeping the line breaks intact. To test: - Add a subscription - Add comments including line breaks in internal and OPAC note - Check the manual history checkbox - Go to the subscription detail page, tab 'Planning' - Use the 'Edit history' link to edit the history - Enter content with line breaks in all the input fields where it's possible - Go to the OPAC detail page for your subscription record - Go to tab 'Subscriptions' > More details > Brief history - Verify the line breaks show there as
    - Apply patch - Relaod page, verify all information displays correctly now - Go back to the detail page, subscription tab - verify same there - Go back to the subscription detail page in staff - Check editing the history works as expected - Verify information on all tabs displays correctly - Receive a serial issue - verify note on top displays right - Go to the serial collection page of the subscription - same there Signed-off-by: David Nind Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:07:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:07:48 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Nadine Pierre changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90929|0 |1 is obsolete| | --- Comment #11 from Nadine Pierre --- Created attachment 90932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90932&action=edit Bug 23126: Remove more unnecessary linebreak processing from serial collection This should have no visible effect on the templates as the information the grep changes is not used in the template. It's also strange, that these lines existed, as GetSubscriptionsFromBiblionumber contained the same changes. Signed-off-by: David Nind Signed-off-by: Arthur Bousquet Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:08:51 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:08:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:08:54 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90894|0 |1 is obsolete| | --- Comment #2 from Bin Wen --- Created attachment 90933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90933&action=edit Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:23:30 +0000 Subject: [Koha-bugs] [Bug 22949] Markup error in OPAC course reserves template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 frederik.chenier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89944|0 |1 is obsolete| | --- Comment #2 from frederik.chenier at inlibro.com --- Created attachment 90934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90934&action=edit Bug 22949: Markup error in OPAC course reserves template This patch adds a missing "=" in opac-course-reserves.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have one or more course reserves available in the OPAC. Go to the course reserves page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses these errors: - 'Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.' - 'Attribute class"inst_surname" not allowed on element span at this point.' To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: frederik -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 21:44:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 19:44:28 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 22:44:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 20:44:05 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 22:44:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 20:44:43 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 Arthur Bousquet changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90781|0 |1 is obsolete| | --- Comment #2 from Arthur Bousquet --- Created attachment 90935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90935&action=edit Bug 23158: keep on-site checkout info when using itemBarcodeFallbackSearch When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form. Test plan : 1) Enable system preferences "itemBarcodeFallbackSearch" and "OnSiteCheckouts" 2) Disable system preference "ConsiderOnSiteCheckoutsAsNormalCheckouts" 3) Go to a patron circulation page 4) Check "On-site checkout" in "Checkout settings" 5) Enter a barcode in checkout form and click on "Check out" 6) You see the checkout in table with red "(On-site checkout)" 7) Check "On-site checkout" in "Checkout settings" 8) Enter the title of a record in in checkout form and click on "Check out" 9) Click on "Checkout" on a line 10) You see the checkout in table with red "(On-site checkout)" Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 22:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 20:46:53 +0000 Subject: [Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 frederik.chenier at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90481|0 |1 is obsolete| | --- Comment #6 from frederik.chenier at inlibro.com --- Created attachment 90936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90936&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. Signed-off-by: frederik -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 23:13:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 21:13:47 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error that release notes| |occurs when an account with | |full circulate permissions | |(but not super librarian | |permissions) clicks on | |'Checkout notes pending' | |and is then automatically | |logged out with the message | |"Error: you do not have | |permission to view this | |page. Log in as a different | |user". CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 21 23:14:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Jun 2019 21:14:01 +0000 Subject: [Koha-bugs] [Bug 22617] Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkout notes pending |Checkout notes pending |dashboard link - error |dashboard link - error |received even though |received even though |manage_checkout_notes |manage_checkout_notes |permission set. |permission set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 03:30:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 01:30:58 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #6 from Jonathan Druart --- (In reply to M. Tompsett from comment #5) > I only thing that really stood out was the C4/Search.pm > "Why is the \Q and \E missing?"? > > Explain that, I may sign this off. This is the whole point of the patch. Have a look at the related bugs, and what this patch is trying to prevent. If the variable contains a regex character (like parenthesis in the case of bug 22941, or $ in the case of bug 23006), then you need to surround your var with \Q\E, see man perlre). So the patch could have replaced grep {/^$var$/} @array with grep {/^\Q$var\E$/} @array But I preferred the other solution, I am sure you understand why :) > Everything else is a result of me seeing tcohen wanting to improve > readability of code. "unless grep" is better read as "if none". I am not tcohen :) The patch is a bugfix (updating the status). I would like to prevent other issues like the ones listed in see also. Replacing them with none, any or anything else will need more grey matter to make sure the changes will not introduce a regression. I am not against what you suggest but I think it should be done separately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 18:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 16:17:46 +0000 Subject: [Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #28 from Jonathan Druart --- (In reply to Martin Renvoize from comment #18) > { > "updated_on" : { > "after" : "2019-06-20 14:20:18", > "before" : "2019-06-20 14:20:19" > > } > } If this is the cause of the failure, we should compare the 2 values with t::lib::Dates::compare If we want to change the behavior we should update the bug report's title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 21:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 19:46:09 +0000 Subject: [Koha-bugs] [Bug 21892] Robin Sheat is not a typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #17 from Jonathan Druart --- Patch reverted. commit db31f7e3380b43ce09798b50ddc5ffd1b17b8836 Revert "Bug 21892: Ignore Sheat when checking spelling" This reverts commit 4e076f26417827494c87677b1d4f3e36ed2f2369. Tests were failing, see also bug 21892 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 22:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 20:35:19 +0000 Subject: [Koha-bugs] [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #12 from Jonathan Druart --- Isn't it the same problem at 19.06.00.006? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 22:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 20:57:29 +0000 Subject: [Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 --- Comment #6 from Jonathan Druart --- (In reply to Martin Renvoize from comment #5) > (In reply to Jonathan Druart from comment #3) > > I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if > > anyone is willing to work on/continue it. > > I'm game for looking at this. https://gitlab.com/joubu/Koha/commits/bug_22431 That's super dirty and I am not really sure what I was trying to achieve. IIRC the problem was the GROUP_CONCAT clause. So creating relevant data, executing the query, then comparing with what would replace the query (using Koha::Holds). That's really a work in progress but... not finished :) Good luck! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 23:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 21:24:34 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #7 from Jonathan Druart --- Apply the changes in the tests, then run it. You will get a warning with your patch: t/db_dependent/Koha/Object.t .. 7/11 Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 23:33:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 21:33:19 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #8 from Jonathan Druart --- Also, I think, my version will be faster: the fix is done only the attributes we are updating, not all the attributes of the object. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 22 23:38:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 21:38:40 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #8 from Jonathan Druart --- This is correct Federico, I have no idea what is going wrong. If you have a test server you could try to apply this debug statement: @ Object.pm:240 @ sub set { foreach my $p ( keys %$properties ) { unless ( grep {/^$p$/} @columns ) { + my @c = caller; use Data::Printer colored => 1; warn p @c; Koha::Exceptions::Object::PropertyNotFound->throw( "No property $p for " . ref($self) ); } } To understand where it comes from. Or, you can turn the dev_install flag on in your koha-conf.xml file, then restart plack. You will get a full stack trace of the error which will be easier to track the problem down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 01:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 23:51:49 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81319|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 90937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90937&action=edit Bug 21684: Add tests to show some of the discrepancies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 01:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 23:54:00 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I am in favour of such move but I would like people to give their opinion. Is silence acquiescence? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 01:56:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Jun 2019 23:56:06 +0000 Subject: [Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Jonathan Druart --- Closing, please reopen if still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 02:08:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 00:08:30 +0000 Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Bug 14868 depends on bug 17050, which changed state. Bug 17050 Summary: Accessing the REST API through Plack kicks the session out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 02:08:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 00:08:30 +0000 Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #21 from Jonathan Druart --- Andrew, please open a new bug report if the issue remains. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 02:18:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 00:18:45 +0000 Subject: [Koha-bugs] [Bug 22021] Item status not shown accurately on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22021 --- Comment #2 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Still valid. More so: if damaged and lost, only damaged shows. I do not understand, I see that in the template: 436 [% IF ( itemloo.damaged ) %] 437
    Damaged 438 [% END %] I guess we want to displayed the description for the AV DAMAGED. Lost description as well? One above the other? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 02:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 00:36:14 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 02:36:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 00:36:17 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 --- Comment #3 from Jonathan Druart --- Created attachment 90938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90938&action=edit Bug 22786: Prevent fund creation for locked budgets If a budget is locked, there is a "New fund for $budget" link that is disabled but clickable. We should ensure that the link is not clickable and prevent it at controller level (do we need it at module level, ie. Koha::Acquisition::Fund->store?) Test plan: - Create a budget, lock it - Go to /cgi-bin/koha/admin/aqbudgetperiods.pl - Click on the name of the budget you just created => The "New > New fund for $budget_name" button should be disabled - Click it anyway => Without this patch the form to add a new fund is displayed => With this patch applied nothing happens - Hit /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=XXX With XXX the budget's id => Without this patch the form is displayed => With this patch applied you get a message: "The budget is locked, fund creation is not possible." And you are not able to create a new fund QA notes: 1. See description 2. The add_validate op can still be forced, let trust librarians with administration permissions for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 02:36:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 00:36:43 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 03:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 01:49:57 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 03:50:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 01:50:04 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #6 from Jonathan Druart --- Created attachment 90940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90940&action=edit Bug 23079: Handle invalid timezones when adding/subtracting durations On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00 (http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime consider it as an invalid date. It is a problem when we are playing with dates without the time part (always 00:00). When we instantiate a DateTime (from dt_from_string) we are already handling this issue, and use the floating timezone (since bug 12669). The problem remains when we generate a DateTime then add or subtract a duration, which will result in an invalid date: DateTime->new(year => 2019, month => 12, day => 3, time_zone => 'America/Sao_Paulo')->subtract(days => 30); => Nov 3rd 2019, kaboom. We should replace all the problematic occurrences of dt_from_string->subtract (or ->add) with dt_from_string(undef, undef, 'floating'), to use the floating timezone and avoid the error. Actually there are not many of them, I have found only 3 that could produce real problems. The other occurrences are: - in tests => Not a big deal (for now) - called on a datetime, so it will explode if called at midnight 00:00:00 (and nobody should work at that time). Test plan: 0/ Define the timezone to 'America/Sao_Paulo' (in your koha-conf.xml file), restart_all 1/ Set a patron's expiry date to Dec 3rd 2019, and NotifyBorrowerDeparture to 30 (default value) 2/ See the checkouts page for this user => Without this patch you get "Invalid local time for date in time zone: America/Sao_Paulo" => With this patch apply the page displays correctly QA will review the 2 other occurrences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 03:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 01:50:00 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #5 from Jonathan Druart --- Created attachment 90939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90939&action=edit Bug 23079: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 03:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 01:52:04 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #7 from Jonathan Druart --- Actually the situation is not as dramatic as I thought. Those patches should fix the problematic cases, and especially the one you reported, Katrin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 03:57:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 01:57:24 +0000 Subject: [Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #10 from Jonathan Druart --- (In reply to Janusz Kaczmarek from comment #9) > (In reply to Jonathan Druart from comment #8) > > Should we follow: > > > > https://google-webfonts-helper.herokuapp.com/fonts/noto-sans?subsets=latin, > > greek-ext,devanagari,cyrillic,latin-ext,vietnamese,greek,cyrillic-ext > > > > Download and include them all? > > Entire WOFF2 set (Regular, Italic, Bold, BoldItalic) = 546 KB > Entire WOFF set = 714 KB > > Now it is eight times less (71 KB, 89 KB, respectively). > > If it is OK (the browser would keep it normally in cache, wouldn't it? -- if > so, then it would be downloaded only once, in general) -- let's do it. I have no idea how to proceed here. 1Mo to open a library's home page, for the first time, in some countries/cities it will not be acceptable (I would close the page thinking it crashed). Isn't there a best practice to follow? I am pretty sure we are not the only ones facing this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 17:47:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 15:47:06 +0000 Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- A Koha test must be provided here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 17:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 15:51:18 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #28 from Jonathan Druart --- Isn't this script missing the use Koha::Script from bug 22600? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 23 19:40:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 17:40:32 +0000 Subject: [Koha-bugs] [Bug 23189] New: Incorrect link to Zebra user's guide and reference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23189 Bug ID: 23189 Summary: Incorrect link to Zebra user's guide and reference Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org Target Milestone: --- In Koha 19.05 manual in chapter https://koha-community.org/manual/19.05/en/html/searching.html#indexing-and-searching-description there is a non-working link: http://www.indexdata.dk/zebra/doc/zebra.pdf - the correct link is probably https://software.indexdata.com/zebra/doc/idzebra.pdf (NB: At the moment Bugzilla does not know Koha 19.05 so I opened this bug for Koha 18.11 where in fact the link is also wrong) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 00:33:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 22:33:41 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Priority|P5 - low |P4 --- Comment #30 from Arthur Suzuki --- I guess we could move on this bugs since anyone agreed that this solves at least the hourly loan issue. >From what I understood following the discussion, there is a bigger issue with the whole fine calculation rules but I'd say it's not in the same scope and shall be documented in another bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 00:35:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Jun 2019 22:35:45 +0000 Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 04:00:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 02:00:38 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 09:31:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 07:31:49 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #9 from Martin Renvoize --- (In reply to Jonathan Druart from comment #7) > Apply the changes in the tests, then run it. You will get a warning with > your patch: > > t/db_dependent/Koha/Object.t .. 7/11 Argument "" isn't numeric in numeric eq > (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. Surely that highlights a bug in the current 'store' routine then rather than my patch ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 09:34:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 07:34:10 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #10 from Martin Renvoize --- (In reply to Jonathan Druart from comment #8) > Also, I think, my version will be faster: the fix is done only the > attributes we are updating, not all the attributes of the object. Again, I would suggest this is a bug in our store routine as it stands.. update really should just be shortcut to set + store else we're introducing bugs by having two distinct ways of doing the same thing. Also, in my patch because you're calling the parent store method you're not only dealing with the over-rides withs Koha::Object but also any class specific overrides in, for example, Koha::Patron are you not? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 10:24:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 08:24:14 +0000 Subject: [Koha-bugs] [Bug 21128] Replace JavaScript-driven authority hierarchy display with static version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21128 --- Comment #8 from Katrin Fischer --- Hi Owen, do you remember the issue here? I fail trying to activate the feature right now, following my own cataloguing instructions from bug 8523 comment 19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 11:13:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 09:13:26 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 --- Comment #11 from Martin Renvoize --- Lovely bit of code golf there, thanks Nick :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 11:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 09:24:39 +0000 Subject: [Koha-bugs] [Bug 23190] New: Authority hierarchy display appears to be broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190 Bug ID: 23190 Summary: Authority hierarchy display appears to be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- We followed the instructions on bug 8523 comment 19, but we didn't manage to get a tree view: AuthDisplayHieararchy ON Example: 151 $aGermany 551 $a Baden-W?rttemberg $w h 151 $aBaden-W?rttemberg 551 $a Konstanz $w h 551 $a Germany $w g 151 $aKonstanz 551 $a Baden-W?rttemberg $w g 551 $a F?rstenberg $w h 551 $a Paradies $w h 151 $a F?rstenberg 551 $a Konstanz $w g 151 $a Paradies 551 $a Konstanz $w g The authority that is displayed shows as the only entry of the 'tree' abvove the record in staff and OPAC. Links have been cataloged in both directions. Screenshots from Owen on bug 21128 from 2018 suggest that the feature still worked at this time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 11:25:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 09:25:11 +0000 Subject: [Koha-bugs] [Bug 23190] Authority hierarchy display appears to be broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8523 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 [Bug 8523] Authority hierarchies only support UNIMARC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 11:25:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 09:25:11 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190 [Bug 23190] Authority hierarchy display appears to be broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 11:25:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 09:25:11 +0000 Subject: [Koha-bugs] [Bug 21128] Replace JavaScript-driven authority hierarchy display with static version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21128 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:10:00 +0000 Subject: [Koha-bugs] [Bug 23191] New: Administrators should be able to install plugins from the command line Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Bug ID: 23191 Summary: Administrators should be able to install plugins from the command line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- Some support companies would prefer to now allow end users to install new plugins. Prior to bug 21073 this was mostly possible by enabling plugins in the config but making the plugin path read only to the apache user. In this way users could not upload new plugins, but support providers could add plugins at the users request. This did have the caveat that 'install', 'update' and 'remove' routines in the plugin would not be called. With bug 21073 we must run through the InstallPlugins method to populate the relevant database tables so we should add a command line script that would allow administrators to run this once they had manually added plugin code to the correct paths. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:27:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:27:57 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:28:00 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90917|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 90941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90941&action=edit Bug 22249: Mana - Move comment process in a dedicated sub Test plan: - Go to a subscription's detail page, - click on "Report mistake" => "New comment", - check Koha logs file, - you can see the following warning: Can't locate object method "find" via package "Koha::Resource_comments" - Apply this patch, - same test again, - no wraning Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:38:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:38:09 +0000 Subject: [Koha-bugs] [Bug 23190] Authority hierarchy display appears to be broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190 Christian Stelzenm?ller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:54:46 +0000 Subject: [Koha-bugs] [Bug 23192] New: Cancelling holds over returning to wrong tabon waitingreserves.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Bug ID: 23192 Summary: Cancelling holds over returning to wrong tabon waitingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Bug 21628 moved the tables to an include, however, it didn't take the 'tab' input into account To recreate: 1 - Place a hold 2 - Confirm the hold 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the button, note tab = "holdswaiting" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:57:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:57:21 +0000 Subject: [Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tabon waitingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 13:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 11:57:23 +0000 Subject: [Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tabon waitingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 --- Comment #1 from Nick Clemens --- Created attachment 90942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90942&action=edit Bug 23192: Correct tab input on waiting_holds.inc To test: 1 - Place 2 holds 2 - Confirm the holds 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting" 7 - Apply patch 8 - Refresh the page 9 - Inspect the buttton, note tab = "holdsover" 10 - Cancel the hold 11 - Note you return to the holds over tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:03:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:03:48 +0000 Subject: [Koha-bugs] [Bug 17338] waitingreserves.pl should keep you on the same tab when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17338 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- Hi Christopher, waitingreserves.pl should now keep you on the same tab once bug 23192 is addressed. Can you explain the focus? I am not sure what you mean. Should the page default to focus in the search/filter box for the table of reserves? -Nick -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:04:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:04:58 +0000 Subject: [Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tabon waitingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 [Bug 21628] Simplify holds awaiting pickup report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:05:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:05:07 +0000 Subject: [Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tabon waitingreserves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:04:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:04:58 +0000 Subject: [Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 [Bug 23192] Cancelling holds over returning to wrong tabon waitingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:34:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:34:37 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:34:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:34:12 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #1 from Martin Renvoize --- Created attachment 90943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90943&action=edit Bug 23191: Add commandline script to install plugins This adds an initial skeliton script to enable plugin installation at the commandline. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:36:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:36:21 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:40:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:40:33 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #2 from Martin Renvoize --- s/now/not in description.. man I wish i could go back and fix bugzilla descriptions/comments sometimes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:42:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:42:26 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 14:42:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 12:42:34 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:06:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:06:32 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #3 from Alex Arnaud --- Script install already installed plugins. Means that the install method is called again. Not safe IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:10:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:10:14 +0000 Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has FileAppender files with different owners, also compatibility with logrotate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:10:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:10:17 +0000 Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has FileAppender files with different owners, also compatibility with logrotate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51458|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90944&action=edit Bug 16509: fix multi-owner perms, improve logrotate compatibility Rescued, because the last CLI section no longer exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:11:01 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:16:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:16:21 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Alex Arnaud from comment #3) > Script install already installed plugins. Means that the install method is > called again. Not safe IMO. In the InstallPlugins method there is this line of code: Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete(); You can call InstallPlugins as many times as you want, because it is reinstall the second time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:19:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:19:04 +0000 Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has FileAppender files with different owners, also compatibility with logrotate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |mirko at abunchofthings.net, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:23:21 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew --- I'm able to recreate this on 18.11.06. Plack log showing the same error "No property remove_debarment for Koha::Patron." When I reload the patron the debarment has been removed, despite the error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:25:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:25:50 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #10 from Andrew --- Oh, and I do not get this error when removing the debarment from the restrictions tab on circulation.pl. Only when removing the debarment from memberentry.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:26:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:26:49 +0000 Subject: [Koha-bugs] [Bug 23193] New: set_password.pl should use Koha::Script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 Bug ID: 23193 Summary: set_password.pl should use Koha::Script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- It seems the original patch missed to add it (probably because Koha::Script wasn't there). Anyways, needs fixation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:26:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:26:58 +0000 Subject: [Koha-bugs] [Bug 23193] Make set_password.pl use Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|set_password.pl should use |Make set_password.pl use |Koha::Script |Koha::Script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:28:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:28:19 +0000 Subject: [Koha-bugs] [Bug 23193] Make set_password.pl use Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 90945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90945&action=edit Bug 23193: Make set_password.pl use Koha::Script Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:28:38 +0000 Subject: [Koha-bugs] [Bug 23193] Make set_password.pl use Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:29:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:29:08 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #29 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #28) > Isn't this script missing the use Koha::Script from bug 22600? True! I filed bug 23193. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:29:17 +0000 Subject: [Koha-bugs] [Bug 23193] Make set_password.pl use Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17746, 22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:29:17 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 [Bug 23193] Make set_password.pl use Koha::Script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:29:17 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 [Bug 23193] Make set_password.pl use Koha::Script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:36:09 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #19 from Tom?s Cohen Arazi --- (In reply to Josef Moravec from comment #17) > > > > I'm not sure which is best.. > > > > To make modifications, surely the most convenient option is to have those > > files, but it's clear there are a lot of files.. > > > > maybe we could have a separate repo somehow and import / copy the resultant > > all.js > > But why don't to contribute back to Mottie Keyboard? > > Also, these files are minified, I don't think anybody would like to edit > minified files... Josef, Agustin removed the files from the commit and only have all.js now. We propose to keep our own community fork (in next dev meeting agenda) just in case someone wants to add any special layout that doesn't fit upstream, and we will document how all.js is generated (basically cat *.js > all.js) so we can keep it up-to-date with upstream (probably automated build of all.js). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:39 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:40 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:42 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:44 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:46 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:47 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:49 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:37 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:51 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:50:53 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 15:55:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 13:55:16 +0000 Subject: [Koha-bugs] [Bug 15704] The 264 index should be split by subfield to match how 260 is indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor Summary|Split up 264 index |The 264 index should be | |split by subfield to match | |how 260 is indexed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:02:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:02:23 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #5 from Alex Arnaud --- (In reply to M. Tompsett from comment #4) > (In reply to Alex Arnaud from comment #3) > > Script install already installed plugins. Means that the install method is > > called again. Not safe IMO. > > In the InstallPlugins method there is this line of code: > Koha::Plugins::Methods->search({ plugin_class => $plugin_class > })->delete(); > > You can call InstallPlugins as many times as you want, because it is > reinstall the second time. Good! I was worried about script output, but i seems that InstallPlugins only reset plugin methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:03:07 +0000 Subject: [Koha-bugs] [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Normalize SMS messaging |It should be possible to |numbers before validating |paste formatted phone |them |numbers into the SMS | |messaging number field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:03:14 +0000 Subject: [Koha-bugs] [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:03:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:03:49 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90943|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud --- Created attachment 90946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90946&action=edit Bug 23191: Add commandline script to install plugins This adds an initial skeliton script to enable plugin installation at the commandline. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:04:06 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:04:50 +0000 Subject: [Koha-bugs] [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement makes it |This bugfix improves the release notes|easier to paste in patron |likelihood of pasted patron |phone numbers as it will |phone numbers passing |attempt to normalize out |validation as we will now |illegal characters often |attempt to normalise out |used to human-friendly |illegal characters often |formatting. |used to human-friendly | |formatting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:41:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:41:23 +0000 Subject: [Koha-bugs] [Bug 17338] waitingreserves.pl should keep you on the same tab when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17338 --- Comment #2 from Christopher Brannon --- This is an old request. If there were an option to do that, it would be great. I don't think it should just focus on that search filter always, but if there were a check box to keep the focus, that would streamline the use of this page for those that are going through a pile of holds that need to be cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:43:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:43:17 +0000 Subject: [Koha-bugs] [Bug 22021] Item status not shown accurately on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22021 --- Comment #3 from Christopher Brannon --- The category isn't needed as much as the description of the authorized value in that category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:45:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:45:36 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Passed QA |Patch doesn't apply --- Comment #9 from Martin Renvoize --- Sorry Owen.. I think a tidying push of yours I recently pushed knocked this one out.. Setting to Patch doesn't apply as I think you're better placed to rebase it and keep the tidier code than I am. Thanks -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:42 +0000 Subject: [Koha-bugs] [Bug 15704] The 264 index should be split by subfield to match how 260 is indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:45 +0000 Subject: [Koha-bugs] [Bug 15704] The 264 index should be split by subfield to match how 260 is indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:47 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:49 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:53 +0000 Subject: [Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:51 +0000 Subject: [Koha-bugs] [Bug 21588] Add "Collapse/Expand" options on subscription-detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:55 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:56 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 --- Comment #25 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:47:58 +0000 Subject: [Koha-bugs] [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:00 +0000 Subject: [Koha-bugs] [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:02 +0000 Subject: [Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:04 +0000 Subject: [Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:05 +0000 Subject: [Koha-bugs] [Bug 22935] Improve style of Bootstrap pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22935 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:07 +0000 Subject: [Koha-bugs] [Bug 22935] Improve style of Bootstrap pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22935 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:10 +0000 Subject: [Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 --- Comment #15 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:13 +0000 Subject: [Koha-bugs] [Bug 23034] Warning when in Mana KB settings Auto subscription sharing is unchecked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23034 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:16 +0000 Subject: [Koha-bugs] [Bug 23098] KOC upload process has misleading wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23098 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:23 +0000 Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:48:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:48:38 +0000 Subject: [Koha-bugs] [Bug 23194] New: Public notes items in the OPAC should allow for HTML tags Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Bug ID: 23194 Summary: Public notes items in the OPAC should allow for HTML tags Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- As with similar bugs, 22938, 22702, 22501, the HTML tags are broken in the newest version of 18.11. If an item has a URL in the public notes subfield, this should be allowed to have HTML tags. Currently, this is not displaying correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:51:46 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED --- Comment #11 from Jonathan Druart --- (In reply to Andrew from comment #10) > Oh, and I do not get this error when removing the debarment from the > restrictions tab on circulation.pl. Only when removing the debarment from > memberentry.pl That was the useful bit, thanks! Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:57:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:57:07 +0000 Subject: [Koha-bugs] [Bug 23193] Make set_password.pl use Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:57:09 +0000 Subject: [Koha-bugs] [Bug 23193] Make set_password.pl use Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90945|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 90949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90949&action=edit Bug 23193: Make set_password.pl use Koha::Script Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:57:11 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 90950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90950&action=edit Bug 22709: Unit tests This patch introduces tests for new plugin hooks added to C4::Biblio::{Add|Mod|Del}Biblio and C4::Items::{Add|Mod|Del}Item. They are tested together as for creating an item you need to first create a biblio and tests looks basically the same. The testing strategy is - Make sure the plugin is passed the right params - Throw an exception at plugin-level, to be trapped by the C4::Biblio and C4::Items lib, and converted into a warning. So we test for the warning. - Also, the fact that C4::Biblio and C4::Items warns, means the exception was cought, and then Koha won't break on faulty plugins or fatal errors from plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:57:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:57:14 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 90951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90951&action=edit Bug 22709: Add after biblio/item action hooks This patch introduces after-action hooks for - C4::Biblio::{Add|Mod|Del}Biblio - C4::Items::{Add|Mod|Del}Biblio After the action has taken place, a call to a helper method is done, which loops through all plugins implementing the hooks, and calls the plugin method. The related object is passed, along with an 'action' string specifying the action that took place, and the object id (which is specially important for the 'Del' case). To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Biblio_and_Items_plugin_hooks.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:57:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:57:35 +0000 Subject: [Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- (In reply to Katrin Fischer from comment #4) > This works well and is a nice enhancement, just one thing: I am not sure if > it's not a little confusing to have 2 keyword search options available that > fill out the other, when typing in it. It's a new pattern at least :) I agree.. this feels a little odd but I'm not entirely sure how to tidy it up.. Lets handle it on it's own bug perhaps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:58:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:58:20 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:59:13 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:59:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:59:50 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows the release notes| |administrator to set if, | |and which, fields should | |not be sent to third party | |SIP2 clients for privacy | |reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 16:59:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 14:59:58 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:05:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:05:36 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:05:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:05:39 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90700|0 |1 is obsolete| | Attachment #90701|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 90952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90952&action=edit Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:05:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:05:42 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #11 from Owen Leonard --- Created attachment 90953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90953&action=edit Bug 5287: (QA follow-up) update deprecated button Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:11:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:11:29 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:11:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:11:34 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #12 from Jonathan Druart --- Created attachment 90954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90954&action=edit Bug 23082: FIX debarment removing when editing a patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:22:13 +0000 Subject: [Koha-bugs] [Bug 15704] The 264 index should be split by subfield to match how 260 is indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bibliwho at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:28:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:28:07 +0000 Subject: [Koha-bugs] [Bug 20208] Custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Matthew Shellenbarger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mshellenbarger at mercyhurst.e | |du -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:30:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:30:25 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:30:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:30:28 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85407|0 |1 is obsolete| | Attachment #85408|0 |1 is obsolete| | Attachment #85788|0 |1 is obsolete| | --- Comment #31 from M. Tompsett --- Created attachment 90955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90955&action=edit Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens Signed-off-by: Arthur Suzuki Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:30:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:30:32 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #32 from M. Tompsett --- Created attachment 90956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90956&action=edit Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine Signed-off-by: Arthur Suzuki Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:30:35 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #33 from M. Tompsett --- Created attachment 90957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90957&action=edit Bug 14293: Add more tests and fix floor/ceil Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:32:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:32:22 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #34 from M. Tompsett --- (In reply to Arthur Suzuki from comment #30) > I guess we could move on this bugs since anyone agreed that this solves at > least the hourly loan issue. > From what I understood following the discussion, there is a bigger issue > with the whole fine calculation rules but I'd say it's not in the same scope > and shall be documented in another bugzilla. Given this comment, and the tests actually testing the changes. I figured it needed to be signed off to move forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:39:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:39:46 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:39:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:39:48 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90954|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 90958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90958&action=edit Bug 23082: FIX debarment removing when editing a patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:39:52 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:39:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:39:56 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90935|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 90959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90959&action=edit Bug 23158: keep on-site checkout info when using itemBarcodeFallbackSearch When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form. Test plan : 1) Enable system preferences "itemBarcodeFallbackSearch" and "OnSiteCheckouts" 2) Disable system preference "ConsiderOnSiteCheckoutsAsNormalCheckouts" 3) Go to a patron circulation page 4) Check "On-site checkout" in "Checkout settings" 5) Enter a barcode in checkout form and click on "Check out" 6) You see the checkout in table with red "(On-site checkout)" 7) Check "On-site checkout" in "Checkout settings" 8) Enter the title of a record in in checkout form and click on "Check out" 9) Click on "Checkout" on a line 10) You see the checkout in table with red "(On-site checkout)" Signed-off-by: Arthur Bousquet Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:40:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:40:00 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 --- Comment #4 from Jonathan Druart --- Created attachment 90960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90960&action=edit Bug 23158: Make the assignment statement more readable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:41:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:41:28 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #35 from Jonathan Druart --- I understand from comment 29 that Sonia disagrees with the behavior of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:42:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:42:51 +0000 Subject: [Koha-bugs] [Bug 14228] fill in patron info by scanning an ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:43:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:43:56 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:44:01 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90861|0 |1 is obsolete| | Attachment #90862|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 90961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90961&action=edit Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:44:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:44:09 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #7 from Jonathan Druart --- Created attachment 90962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90962&action=edit Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:44:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:44:37 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- I am not sure we should care about the description in DB (as it is not used on the interface) but it will not hurt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:45:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:45:18 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #7 from M. Tompsett --- > This is the whole point of the patch. Have a look at the related bugs, and > what this patch is trying to prevent. If the variable contains a regex > character (like parenthesis in the case of bug 22941, or $ in the case of > bug 23006), then you need to surround your var with \Q\E, see man perlre). > > So the patch could have replaced > grep {/^$var$/} @array > with > grep {/^\Q$var\E$/} @array > > But I preferred the other solution, I am sure you understand why :) Yes, anything that requires an escaped solution adds a level of complexity and poor readability which makes it prone to breaking. > > Everything else is a result of me seeing tcohen wanting to improve > > readability of code. "unless grep" is better read as "if none". > > I am not tcohen :) > The patch is a bugfix (updating the status). I would like to prevent other > issues like the ones listed in see also. Replacing them with none, any or > anything else will need more grey matter to make sure the changes will not > introduce a regression. I am not against what you suggest but I think it > should be done separately. I agree with that, which is why I just wanted an explanation of the \Q \E thing. Thanks for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 17:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 15:57:20 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #8 from M. Tompsett --- Comment on attachment 90823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90823 Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Review of attachment 90823: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23084&attachment=90823) ----------------------------------------------------------------- These are the two places I will actually test, because everything else is a easy eyeball by comparison. ::: opac/opac-memberentry.pl @@ +77,4 @@ > > my @libraries = Koha::Libraries->search; > if ( my @libraries_to_display = split '\|', C4::Context->preference('PatronSelfRegistrationLibraryList') ) { > + @libraries = map { my $b = $_; my $branchcode = $_->branchcode; grep { $_ eq $branchcode } @libraries_to_display ? $b : () } @libraries; Super ugly code. There won't be scoping issues the $_? ::: opac/opac-search-history.pl @@ +70,4 @@ > @searches = map { $_->{type} ne $type ? $_ : () } @searches; > } > if ( @id ) { > + @searches = map { my $search = $_; ( grep { $_ eq $search->{id} } @id ) ? () : $_ } @searches; Super ugly code. Test for scoping issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:37 +0000 Subject: [Koha-bugs] [Bug 23146] Add support for Basic auth on the OAuth2 token endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:39 +0000 Subject: [Koha-bugs] [Bug 23146] Add support for Basic auth on the OAuth2 token endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23146 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:41 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:42 +0000 Subject: [Koha-bugs] [Bug 23152] koha_object[s]_class methods must be implemented when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23152 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:44 +0000 Subject: [Koha-bugs] [Bug 23154] Add pagination to /api/v1/checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23154 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:46 +0000 Subject: [Koha-bugs] [Bug 23154] Add pagination to /api/v1/checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23154 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:47 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:03:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:03:49 +0000 Subject: [Koha-bugs] [Bug 23159] Reindent addbiblio.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:09:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:09:30 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:14:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:14:45 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:14:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:14:47 +0000 Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:14:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:14:49 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:14:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:14:50 +0000 Subject: [Koha-bugs] [Bug 23109] Incomplete description for staffacccess permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23109 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:14:52 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:14:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:14:54 +0000 Subject: [Koha-bugs] [Bug 23158] on-site checkout missing when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23158 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:22:24 +0000 Subject: [Koha-bugs] [Bug 23195] New: Shipping costs are inconsistent in where displayed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 Bug ID: 23195 Summary: Shipping costs are inconsistent in where displayed Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When an invoice has shipping costs included in it, the totals are displayed inconsistently in Koha Acquisitions. If looking at the acqui-home.pl, the shipping costs are included in the total, however, clicking on the link to see the ordered totals (ordered.pl), shipping costs are not included in this view, causing the totals to not be consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:56:52 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #9 from M. Tompsett --- Comment on attachment 90823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90823 Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Review of attachment 90823: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23084&attachment=90823) ----------------------------------------------------------------- C4/Tags fails qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 18:57:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 16:57:15 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from M. Tompsett --- Failing because of C4/Tags -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:00:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:00:35 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #7 from Martin Renvoize --- Yeah, I'm not the biggest fan of the fact that InstallPlugins re-installs all plugins every run.. but it is indeed idempotent in the way it does so. I argued for a cleaner approach in the performance bug but we decided to push forward and refine that code as a next step. You are right though, I thought the output was a nice extra to show 'something' had happened, but in this case it may be more confusing than helpful.. totally open to some code gulf or suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:01:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:01:29 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #8 from Martin Renvoize --- Also, it's not actually a change.. the code before the performance bug also iterated through all plugins each time install was called.. it was just less obvious about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:01:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:01:41 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:01:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:01:44 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90958|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 90963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90963&action=edit Bug 23082: Fatal error editing a restricted patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:07:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:07:23 +0000 Subject: [Koha-bugs] [Bug 23196] New: Reindent tools/batch_record_modification.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Bug ID: 23196 Summary: Reindent tools/batch_record_modification.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I would like to reindent tools/batch_record_modification.tt: Remove correct indentation, add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:08:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:08:08 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Jonathan Druart --- The failure is: FAIL C4/Tags.pm FAIL forbidden patterns forbidden pattern: tab char (line 195) forbidden pattern: tab char (line 236) forbidden pattern: tab char (line 305) They existed before, not blocker. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:15:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:15:46 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90763|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 90964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90964&action=edit Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:15:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:15:40 +0000 Subject: [Koha-bugs] [Bug 23096] Add floating toolbar to OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:20:16 +0000 Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- + $per_page ||= 10; Sure about that? It's a change in the behavior. I would default to 'all'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:28:17 +0000 Subject: [Koha-bugs] [Bug 23067] in Opac Confirm holds page the Last location column is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Not sure about that change, I do not know what is supposed to tell "last location" in that case. Maybe a feature? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:31:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:31:34 +0000 Subject: [Koha-bugs] [Bug 23196] Reindent tools/batch_record_modification.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:31:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:31:37 +0000 Subject: [Koha-bugs] [Bug 23196] Reindent tools/batch_record_modification.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #1 from Owen Leonard --- Created attachment 90965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90965&action=edit Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:31:40 +0000 Subject: [Koha-bugs] [Bug 23196] Reindent tools/batch_record_modification.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #2 from Owen Leonard --- Created attachment 90966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90966&action=edit Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:57:28 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:57:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:57:37 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 --- Comment #13 from Jonathan Druart --- Created attachment 90968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90968&action=edit Bug 23126: Remove more unnecessary linebreak processing from serial collection This should have no visible effect on the templates as the information the grep changes is not used in the template. It's also strange, that these lines existed, as GetSubscriptionsFromBiblionumber contained the same changes. Signed-off-by: David Nind Signed-off-by: Arthur Bousquet Signed-off-by: Nadine Pierre Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:57:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:57:33 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90931|0 |1 is obsolete| | Attachment #90932|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 90967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90967&action=edit Bug 23126: Display multi-line entries in subscrpitions correctly There are several notes and other fields in a subscription that can be entered as multi-line input with breaks. We should display them as they were entered with keeping the line breaks intact. To test: - Add a subscription - Add comments including line breaks in internal and OPAC note - Check the manual history checkbox - Go to the subscription detail page, tab 'Planning' - Use the 'Edit history' link to edit the history - Enter content with line breaks in all the input fields where it's possible - Go to the OPAC detail page for your subscription record - Go to tab 'Subscriptions' > More details > Brief history - Verify the line breaks show there as
    - Apply patch - Relaod page, verify all information displays correctly now - Go back to the detail page, subscription tab - verify same there - Go back to the subscription detail page in staff - Check editing the history works as expected - Verify information on all tabs displays correctly - Receive a serial issue - verify note on top displays right - Go to the serial collection page of the subscription - same there Signed-off-by: David Nind Signed-off-by: Nadine Pierre Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 19:57:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 17:57:41 +0000 Subject: [Koha-bugs] [Bug 23126] Multiline entries in subscription history display with
    in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23126 --- Comment #14 from Jonathan Druart --- Created attachment 90969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90969&action=edit Bug 23126: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:02:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:02:59 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:03:02 +0000 Subject: [Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90933|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 90970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90970&action=edit Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected Signed-off-by: Bin Wen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:22:04 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett --- (In reply to Jonathan Druart from comment #4) > I think we should replace all the occurrences of dt_from_string->subtract > (or ->add) with dt_from_string(undef, undef, 'floating'), to use the > floating timezone and avoid the error. Personally, I prefer all dates in the DB were GMT, and all calculations were GMT, and then dates displayed were in local based on the user signed on. Sadly, that would be a massive undertaking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:27:15 +0000 Subject: [Koha-bugs] [Bug 23197] New: Add more batch operation options to SQL report results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 Bug ID: 23197 Summary: Add more batch operation options to SQL report results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 90971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90971&action=edit Screenshot showing updated interface I propose to extend the functionality added by Bug 19233 so that one can send report results to the following operations: - Batch record deletion (with biblionumbers) - Batch record modification (with biblionumbers) - Batch item modification (with itemnumbers, currently the only option) - Batch item deletion Note that this change is still a template-only solution, so the batch operations will only get data contained in the first page of report results. The column names must be "biblionumber" and/or "itemnumber" in order for the feature to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:31:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:31:10 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #9 from M. Tompsett --- Comment on attachment 90940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90940 Bug 23079: Handle invalid timezones when adding/subtracting durations Review of attachment 90940: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23079&attachment=90940) ----------------------------------------------------------------- ::: Koha/Patron.pm @@ +622,4 @@ > return 0 unless $delay; > return 0 unless $self->dateexpiry; > return 0 if $self->dateexpiry =~ '^9999'; > + return 1 if dt_from_string( $self->dateexpiry, undef, 'floating' )->subtract( days => $delay ) < dt_from_string(undef, undef, 'floating')->truncate( to => 'day' ); I'd prefer GMT. ::: acqui/duplicate_orders.pl @@ +74,4 @@ > > unless ( $input->param('from') ) { > # Fill the form with year-1 > + $from_placed_on->set_time_zone('floating')->subtract( years => 1 ); Why not: $from_placed_on->set_year($from_placed_on->year() - 1); -- no timezone needed. ::: acqui/histsearch.pl @@ +94,4 @@ > my $to_placed_on = eval { dt_from_string( scalar $input->param('to') ) } || dt_from_string; > unless ( $input->param('from') ) { > # Fill the form with year-1 > + $from_placed_on->set_time_zone('floating')->subtract( years => 1 ); Why not: $from_placed_on->set_year($from_placed_on->year() - 1); -- no timezone needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:35:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:35:06 +0000 Subject: [Koha-bugs] [Bug 23196] Reindent tools/batch_record_modification.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:35:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:35:09 +0000 Subject: [Koha-bugs] [Bug 23196] Reindent tools/batch_record_modification.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90965|0 |1 is obsolete| | Attachment #90966|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 90972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90972&action=edit Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:35:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:35:12 +0000 Subject: [Koha-bugs] [Bug 23196] Reindent tools/batch_record_modification.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #4 from M. Tompsett --- Created attachment 90973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90973&action=edit Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:39:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:39:11 +0000 Subject: [Koha-bugs] [Bug 22949] Markup error in OPAC course reserves template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22949 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett --- Frederik forgot to mark as signed off. Eyeballs well from my perspective. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:53:21 +0000 Subject: [Koha-bugs] [Bug 23197] Add more batch operation options to SQL report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 [Bug 19233] Add ability to send itemnumbers in report results to batch modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:53:21 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 [Bug 23197] Add more batch operation options to SQL report results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:56:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:56:34 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 20:56:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 18:56:38 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90802|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 90974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90974&action=edit Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold A library appears to be able to place a second item level hold on an item a patron already has on hold if A) AllowHoldPolicyOverride is enabled and B) the circ rule allow for multple item level holds. Once the patron submits the hold requests though, the hold does not get stored in the database. Because allowing two item level holds for the same item makes no sense, we should not allow this attempt to take place, even if AllowHoldPolicyOverride is enabled. Test Plan: 1) Enable AllowHoldPolicyOverride 2) Set up circ rules to allow for multiple item level holds on one record 3) Place an item level hold on a record 4) Note you can force placing a second item hold on that reocrd 5) Attempt to do so, it will not actually work 6) Apply this patch 7) Note you can no longer place another item level hold for the same item you just placed an item-level hold on 8) Note you can still force holds that contravene the circ rules for any and all other reasons 9) Test with record level holds 10) Test by placing multiple holds from search results Signed-off-by: Martha Fuerst Signed-off-by: Tomas Cohen Arazi Simple fix for a regression. Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:08:50 +0000 Subject: [Koha-bugs] [Bug 23118] Move PayPal logic into plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23118 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move PayPal logic to plugin |Move PayPal logic into | |plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:26:33 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:29:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:29:47 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #10 from Jonathan Druart --- (In reply to M. Tompsett from comment #9) > Comment on attachment 90940 [details] [review] > Bug 23079: Handle invalid timezones when adding/subtracting durations > > Review of attachment 90940 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Patron.pm > @@ +622,4 @@ > > return 0 unless $delay; > > return 0 unless $self->dateexpiry; > > return 0 if $self->dateexpiry =~ '^9999'; > > + return 1 if dt_from_string( $self->dateexpiry, undef, 'floating' )->subtract( days => $delay ) < dt_from_string(undef, undef, 'floating')->truncate( to => 'day' ); > > I'd prefer GMT. Why? > ::: acqui/duplicate_orders.pl > @@ +74,4 @@ > > > > unless ( $input->param('from') ) { > > # Fill the form with year-1 > > + $from_placed_on->set_time_zone('floating')->subtract( years => 1 ); > > Why not: > $from_placed_on->set_year($from_placed_on->year() - 1); > -- no timezone needed. Hum? I do not understand how it will fix the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:32:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:32:45 +0000 Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 --- Comment #5 from Julian Maurice --- (In reply to Jonathan Druart from comment #4) > + $per_page ||= 10; > > Sure about that? It's a change in the behavior. I would default to 'all'. $per_page defaults to 10 only if $page is defined. If $page and $per_page are both undefined the behavior is to return all checkouts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:42:22 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 90976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90976&action=edit Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:42:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:42:08 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 90975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90975&action=edit Bug 17178: Add shortcut to keyboard_shortcut table This patch adds Ctrl-K shortcut to toggle virtual keyboard shortcut Sponsored-by: Round Rock Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:47:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:47:00 +0000 Subject: [Koha-bugs] [Bug 23198] New: Wrong icons/paths in 18.11 for self check modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Bug ID: 23198 Summary: Wrong icons/paths in 18.11 for self check modules Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- It looks like some icons were updated during SCSS changes, and some paths adjusted, these were not updated for 18.11 selfcheck modules (in/out) To recreate: 1 - Load the SCO modules 2 - Open developer tab in browser (Press F12) 3 - Go to Network tab 4 - Note help.png has a 404 5 - Sign in to SCO as a patron - note stop.png also doesn't load 6 - Test for similar issues in SCI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:47:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:47:20 +0000 Subject: [Koha-bugs] [Bug 23198] Wrong icons/paths in 18.11 for self check modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com, | |lucas at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 24 21:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Jun 2019 19:47:52 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #3 from Nick Clemens --- (In reply to Jonathan Druart from comment #2) > (In reply to Nick Clemens from comment #1) > > Created attachment 90528 [details] [review] [review] > > Bug 23102 - 404 errors on page causes SCI user to be logged out > > > > To test: > > 1 - Have something on the SCO page that won't load > > Can you be more specific? Add to SCOUserJS:
    Steps to reproduce: 1. Login with valid credentials 2. Start any proxy tool to intercept the request. 3. Click logout 4. Send to "repeator" 5. Change "referer" header 6. Observe the output 7. Create an HTML file using the CSRF POC mentioned above 8. Login again 9. Open the CSRF html file on a new tab 10. Submit request 11. Results would reflect on main account POC: PFA the video -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 30 18:41:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Jun 2019 16:41:51 +0000 Subject: [Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- +1 (little late for a comment on the list) -- You are receiving this mail because: You are watching all bug changes.