[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Jun 2 10:22:56 CEST 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
--- Comment #80 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #79)
> (In reply to Jonathan Druart from comment #78)
> > 1. Only one occurrence of passwordlengthhint
> > koha-tmpl/intranet-tmpl/prog/css/installer.css:#passwordlengthhint
> >
> > 2. Do we really need the warning when adding/editing a patron?
> > BTW, $warning is not needed, memberentry.pl
> > 177 my $warning = 1;
> > 178 $template->param("passwordwarning"=>$warning);
> >
> > 3. Just a though, next time we add a "step" we will need to rethink the
> > template. The shift is terrible. And hard to see the real changes.
> >
> > Not passing QA for 2, waiting for another QA point of view.
>
> I would suggest to squash some patches, getting rid of merge marker stuff
> and warnings etc.
> In general, I would not favor putting more prefs inside onboarding. Keep it
> simple. This change can be made without changing onboarding.
I tend to agree with Marcel and Jonathan here.
I am not sure if we should add this to the installer as it adds a lot more to
read for little gain (slows down the process). I think instead, why not just
set it to at least 8 by default?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list