[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
First of all: I like this!

Some findings while testing:

1) Use the TT Asset plugin instead:

[% IF ( Koha.Preference('OPACSuggestionAutoFill') ) %]
    <script type="text/javascript" src="[% interface %]/[% theme
%]/js/autofill.js"></script>
[% END %]

2) Style question :) (non-blocker)

[% IF NOT Koha.Preference( 'OPACSuggestionAutoFill' ) %]

Why not UNLESS? Just hadn't seen this before!

3) The jQuery plugin 

Wondering about the Javascript file included here. I think right now it's the
biggest issue for me.

It's labelled "jquery autofill plugin", but it appears to be unrelated to the
existing one or has been changed so much I am not seeing the relationship
anymore:

https://plugins.jquery.com/autofill/

Maybe this should be renamed as it's now a plugin dealing with the Google API
specifically and no longer a generic one and the note be removed to avoid
confusion?

I also think that Jonathan's comment 18 is still valid. If we only need it on
one page, it would make sense to only include it there.

I think we also really need to figure out the license situation here. My guess
right now is that Martin is the author. 

We don't usually add the authors/licenses for js files written for Koha that
live in bootstrap/js, so maybe this is mostly about removing the confusing
comment/making sure this was written for Koha and is not a general plugin.

Adding Owen.

4) Pref description should mention this is about the suggestion form :)

5) It would be nice if the error message didn't appear as another button (and
if the Google Search button was more clearly formatted as a button)
(non-blocker)(In reply to Chris Cormack from comment #7)

6) Copyright date / Publication year
> > And lastly, not a problem but a question: In my test copyright date is never
> > populated. Is that a bug or a problem with Google Books' data?
> 
> Yes, Google books API only hands back publication date, not copyright date.

I think it might make sense to use this in the field. While technically not the
same, we use both in Koha often for the same thing. This is one of the forms
using copyright date, but in other places it will be publication year. And it
all goes into the same fields when creating a record from it. The year would be
helpful I think. (I'd even go as far to say we should relabel the form, because
I doubt copyright date has meaning to users)

-- 
You are receiving this mail because:
You are watching all bug changes.