[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Uh oh, that's no good. 

When I was writing the patch for 15221, I was looking at implementing the alert
suppression a different way...looking at sub do_checkin in
C4/SIP/ILS/Transaction/Checkin.pm, I see the following lines:

my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch,
undef, dt_from_string($return_date));
$self->alert(!$return);

So we should revert the patch for 15221, and add $checked_in_ok to the params
for sub do_checkin. And wrap that $self->alert(!$return); within a condition
looking for $checked_in_ok.

Not sure why I didn't do that originally. I was going to... but then I figured
I'd try to centralize the changes with the existing use of $checked_in_ok. Bad
call on my part. 

I'm super pressed for time at the moment, but I'll do up a quick patch with
what I'm thinking and post it here for review...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.