[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928

--- Comment #101 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #100)
> Some feedback:
> t/db_dependent/TestBuilder.t - occurrence of default_circ_rules

Sure? I do not have it :)

> Set rule:
> All-libraries
> Default holds policy by item type
> Computer files -> From home library -> Item's home libary -> Item floats
> 
> Go to a specific branch 'Fairview' - the above rule shows
> Setting a branch specific does override and then show correctly

Yes, that's the error we have since the beginning, patch's coming.
Thanks!

> Set rule:
> Checkout, hold policy by patron category for Fairview
> Teacher -> blank -> blank -> 0
> rule does not show as set, check the DB, it is set correctly
> It does prevent teacher from placing holds
> set to:
> Teacher -> blank -> blank -> 1
> It shows and is set correctly
> 
> Otherwise testing worked, code functions as I believe it is supposed to,
> overriding and choosing correct rule. We should move this one early this
> cycle

I'd say it's a master bug, I am investigating it.

-- 
You are receiving this mail because:
You are watching all bug changes.