[Koha-bugs] [Bug 23095] Circulation rules not displayed (empty vs null)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90510|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 90540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90540&action=edit
Bug 23095: Correctly display circulation rules (0 vs undef)

>From the following commit:
  commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165
  Bug 18925: (follow-up) Fix null/empty behavior

The global test must have been adjusted as well to catch empty strings.

Actually we are expecting the plugin to return undef but the template variable
contains an empty string.

So the test should only be [% IF var != '' %] instead of [% IF var.defined &&
var != '' %]
but I prefer to keep it as it for now.

Test plan:
In the section "Default checkout, hold policy by patron category"
Set total checkouts = blank
    total on-site checkouts = blank
    total holds = 0
Save
=> Without this patch the line will not appear
=> With this patch applied there must be "unlimited, unlimited, 0"

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.