[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #38 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #37)
> I tested David's patch with our educators, I don't think it quite does what
> it meant to do.  I attached an updated version of David's patch that
> simplifies the logic, I believe this fulfills the intent

Could you elaborate on that, Nick?

I think my patch does what I mean it to do, but maybe I'm not clearly
communicating what I mean it to do?

If you look at Circulation.pm (I think), I'm basically just copying what
already happens if a person tries to perform a renewal manually. So I'm trying
to harmonize the human and machine methods of renewing, and that takes into
account NoRenewalBefore from the circulation rules.

-- 
You are receiving this mail because:
You are watching all bug changes.