[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Martin Renvoize from comment #12)
> > (In reply to Jonathan Druart from comment #10)
> > > Because there are 3 values: From any library, From home library and not
> > > allowed (0)
> > 
> > I'm wondering if we're taking into account the 1, and 2 options correctly
> > then in that case?
> 
> Why not? The patch adds the holdallowed != 0 condition, which matches 1 and
> 2 :)

It was more of a 'note to self' to make sure I improved my understanding of how
the value is used before Signing Off.

It looks sane enough to me, but I'm still not 100%. What I'm trying to work out
is if the clause is in the right place and is indeed correct allowing both 1
and 2 options. I note that with independent branches switched on we limit by
holdingbranch being the local branch.. hence wondering if we aught to be
handling library limitations in this part of the query too...  It's one monster
query.

-- 
You are receiving this mail because:
You are watching all bug changes.