[Koha-bugs] [Bug 15985] Include transacting library in fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. Changes are made in Koha/Schema/Result/OldIssue.pm, above the "DO NOT MODIFY
THIS OR ANYTHING ABOVE!" line.
Is it expected? Did you forget to attached the DB changes patch?
If you wanted to add it after that line, why not adding the constraint at DB
level?

Why not for Issue.pm?

2.
-use base qw(Koha::Object);
+use base qw(Koha::Checkout);

Is this really needed? Why?
If so I think it must be moved to its own bug report, explaining why we need it
and what it will bring. Also tests must be provided for such changes.

Note that both t/db_dependent/Koha/Account/Lines.t and
t/db_dependent/Koha/Checkouts.t are passing without that change.

-- 
You are receiving this mail because:
You are watching all bug changes.