[Koha-bugs] [Bug 23224] Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224

Liz Rea (ByWater) <liz at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91109|0                           |1
        is obsolete|                            |

--- Comment #8 from Liz Rea (ByWater) <liz at bywatersolutions.com> ---
Created attachment 91110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91110&action=edit
Bug 23224: Fix inconsistent behaviour of memberentry.pl

When editing a child patron (in memberentry.pl) and changing their
patron category to a non-child patron category Koha does not set the
guarantorid to 0.

This means we end up with non-child/non-professional patrons with guarantors,
which is
currently not allowed by Koha.

Whereas the behaviour in child-update.pl (which can be accessed from a
patrons summary page by clicking 'More'->Update child to adult
patron') sets the borrowers guarantorid value to 0. This is the correct
behaiviour and is what memberentry.pl should be doing. This patch fixes
that.

Test plan:
See how memberentry.pl currently behaves
1. Create a adult patron and select 'Add child' and create the child
record.

2. Enter the Koha MySQL terminal and select the guarantorid value for
the child record you just created:

SELECT guarantorid FROM borrowers WHERE userid=<username>;

3. Notice the guarantorid is set to the adult patrons borrowernumber

4. On the child record select 'Edit' and in the memberentry.pl page
change the category to any non-child/non-professional patron category (for
example
'Patron') and save

5. Repeat step 2 and notice the guarantorid value has not changed

----

See how child-update.pl currently behaves

6. Repeat steps 1-3 and on the child record select More > Update child
to adult patron

7. In the child-update.pl window that loads select any patron category and save

8. Repeat step 2 and notice the guarantorid is now 0

----

See how the patch fixes the behaviour of memberentry.pl

9. Apply patch

10. Repeat steps 1-5 and notice the guarantorid is now empty

----

Confirm the guarantorid is not removed when editing a patrons category
to a patron category with the category type of 'professional' as in Koha
professional patron categories can have guarantors

11. Repeat steps 1-3 and select 'Edit' on the childs record and change
the patron category to a 'professional' patron category and then save

12. Check the database and confirm that the guarantorid is unchanged

Sponsored-By: Brimbank Library, Australia
Signed-off-by: Liz Rea <liz at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.